Re: [Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

2013-06-23 Thread Laszlo Ersek
On 06/22/13 03:37, Ronnie Sahlberg wrote: > Don't assume that SG_IO is always invoked with a simple buffer, > check the iovec_count and if it is > 1 then we need to pass an array > of iovectors to libiscsi instead of just a plain buffer. > > Signed-off-by: Ronnie Sahlberg > --- > block/iscsi.c |

[Qemu-devel] porting peter-bochs to qemu

2013-06-23 Thread Peter Cheung
Hi I am porting peter-bochs debugger to qemu. I am stuck into the breakpoint->continue part. Anybody want to give a help to finish the debugger stub? https://www.dropbox.com/s/aidxcm9l1vnia1b/GKD.png https://www.dropbox.com/s/76a778f1a76ga7v/LibGKD.png?m Thanksfrom Peter

Re: [Qemu-devel] [PULL 00/21] pci,net,misc enhancements

2013-06-23 Thread Michael S. Tsirkin
On Fri, Jun 21, 2013 at 08:10:15AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > From: Michael S. Tsirkin > > > > The following changes since commit 90a2541b763b31d2b551b07e24aae3de5266d31b: > > > > target-i386: fix over 80 chars warnings (2013-06-15 17:50:38 +) > > >

Re: [Qemu-devel] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-23 Thread Michael S. Tsirkin
On Fri, Jun 21, 2013 at 09:51:20AM +1000, Alexey Kardashevskiy wrote: > And kvm_irqchip_add_msi_route does not have any link to a device or a bus > so I'll have to walk through all PHBs in system and see if PHB's MSI window > is the one from MSIMessage and convert MSIMessage to virq. Pretty easy an

Re: [Qemu-devel] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-23 Thread Anthony Liguori
On Sun, Jun 23, 2013 at 9:07 AM, Michael S. Tsirkin wrote: > On Fri, Jun 21, 2013 at 09:51:20AM +1000, Alexey Kardashevskiy wrote: >> And kvm_irqchip_add_msi_route does not have any link to a device or a bus >> so I'll have to walk through all PHBs in system and see if PHB's MSI window >> is the o

Re: [Qemu-devel] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-23 Thread Anthony Liguori
On Thu, Jun 20, 2013 at 11:46 PM, Alex Williamson wrote: > On Fri, 2013-06-21 at 12:49 +1000, Alexey Kardashevskiy wrote: >> On 06/21/2013 12:34 PM, Alex Williamson wrote: >> >> >> Do not follow you, sorry. For x86, is it that MSI routing table which is >> updated via KVM_SET_GSI_ROUTING in KVM? W

[Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi V3

2013-06-23 Thread Ronnie Sahlberg
List, Please find a new version of the patch to fix the iSCSI crash when ioctl with iovector is sent. Updated to fix the commit message as per lerseks suggestion. Also added an explicit cast to suppress a compiler warning when we dont have iovector support available.

[Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

2013-06-23 Thread Ronnie Sahlberg
Don't assume that SG_IO is always invoked with a simple buffer, check the iovec_count and if it is >= 1 then we need to pass an array of iovectors to libiscsi instead of just a plain buffer. Signed-off-by: Ronnie Sahlberg --- block/iscsi.c | 56 +

Re: [Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

2013-06-23 Thread Laszlo Ersek
On 06/23/13 17:07, Ronnie Sahlberg wrote: > Don't assume that SG_IO is always invoked with a simple buffer, > check the iovec_count and if it is >= 1 then we need to pass an array > of iovectors to libiscsi instead of just a plain buffer. > > Signed-off-by: Ronnie Sahlberg > --- > block/iscsi.c

Re: [Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment

2013-06-23 Thread Richard Henderson
On 06/22/2013 03:58 AM, Peter Maydell wrote: > On 22 June 2013 03:10, Richard Henderson wrote: >> + ldflags="$ldflags $textseg_ldflags" >> fi >> >> echo "LDFLAGS+=$ldflags" >> $config_target_mak > > Should we really be putting this in LDFLAGS? That seems > likely to end up getting accidentally

Re: [Qemu-devel] [PATCH] Switch the roles of jmp_next[0] and jmp_next[1].

2013-06-23 Thread Richard Henderson
On 06/22/2013 09:10 AM, Zhihui Zhang wrote: > This way, jmp_next[0] means "taken" for both conditional jumps AND > unconditional jumps. > Currently, it has opposite meanings for the two cases. So? There's no proscribed meaning for the 0 and 1 indices. r~

Re: [Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment

2013-06-23 Thread Peter Maydell
On 23 June 2013 19:20, Richard Henderson wrote: > On 06/22/2013 03:58 AM, Peter Maydell wrote: >> Should we really be putting this in LDFLAGS? That seems >> likely to end up getting accidentally applied in places >> where we don't want it (helper binaries, etc). It seems >> like it would be more r

[Qemu-devel] [Bug 1193628] Re: Undefined References

2013-06-23 Thread jean-christophe manciot
@Peter Maydell (pmaydell): you're right, but in the meantime, I needed to find another solution. @Michael Tokarev (mjt+launchpad-tls): Thanks a lot for your answer, it helped me pass this hindrance... to find 2 other obstacles. Regarding the first one: I patched the two files as recommended (and

[Qemu-devel] [PATCH 1/3] multiboot: Don't forget last mmap entry

2013-06-23 Thread Kevin Wolf
When the BIOS returns ebx = 0, the current entry is still valid and needs to be included in the Multiboot memory map. Fixing this meant that using bx as the entry index doesn't work any more because it's 0 on the last entry (and it was SeaBIOS-specific anyway), so the whole loop had to change a bi

[Qemu-devel] [PATCH 3/3] multiboot: Updated ROM binary

2013-06-23 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- pc-bios/multiboot.bin | Bin 1024 -> 1024 bytes 1 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 pc-bios/multiboot.bin diff --git a/pc-bios/multiboot.bin b/pc-bios/multiboot.bin old mode 100644 new mode 100755 index 7b3c1745a430ea5e0e

[Qemu-devel] [PATCH 0/3] multiboot: Fix memory information

2013-06-23 Thread Kevin Wolf
Kevin Wolf (3): multiboot: Don't forget last mmap entry multiboot: Calculate upper_mem in the ROM multiboot: Updated ROM binary hw/i386/multiboot.c |2 - pc-bios/multiboot.bin | Bin 1024 -> 1024 bytes pc-bios/optionrom/multiboot.S | 75 +

[Qemu-devel] [PATCH 2/3] multiboot: Calculate upper_mem in the ROM

2013-06-23 Thread Kevin Wolf
The upper_mem field of the Multiboot information struct doesn't really contain the RAM size - 1 MB like we used to calculate it, but only the memory from 1 MB up to the first (upper) memory hole. In order to correctly retrieve this information, the multiboot ROM now looks at the mmap it creates an

Re: [Qemu-devel] [PATCH v3 00/14] Refactor portio dispatching

2013-06-23 Thread Hervé Poussineau
Jan Kiszka a écrit : Changes in v3: - decouple vmport from portio types - removed portio traces from memory.h, consolidating it in ioport.h CC: Jan Kiszka CC: malc Jan Kiszka (14): adlib: replace register_ioport* applesmc: replace register_ioport* wdt_ib700: replace register_ioport*

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-06-23 Thread Hervé Poussineau
Jan Kiszka a écrit : From: Jan Kiszka The current ioport dispatcher is a complex beast, mostly due to the need to deal with old portio interface users. But we can overcome it without converting all portio users by embedding the required base address of a MemoryRegionPortio access into that data

Re: [Qemu-devel] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-23 Thread Benjamin Herrenschmidt
On Sun, 2013-06-23 at 17:07 +0300, Michael S. Tsirkin wrote: > Yes I think that's fine really. > > Basically devices all speak MSIMessage as they should - > this is what the PCI spec says. > On all normal systems guests also speak MSIMessage so > the API which uses these makes sense for kv

Re: [Qemu-devel] [Qemu-ppc] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-23 Thread Benjamin Herrenschmidt
On Sun, 2013-06-23 at 10:02 -0500, Anthony Liguori wrote: > It doesn't make a lot of sense to have Power do MSI decoding in > userspace while x86 does it in the kernel. I assume the kernel > doesn't have enough information to do the translation on Power? Well, it would need the host bridge which

Re: [Qemu-devel] [PATCH 0/3] multiboot: Fix memory information

2013-06-23 Thread Anthony Liguori
Kevin Wolf writes: > Kevin Wolf (3): > multiboot: Don't forget last mmap entry > multiboot: Calculate upper_mem in the ROM > multiboot: Updated ROM binary Reviewed-by: Anthony Liguori Do you have a test case that triggered this that you can share? I'll apply this after a day or so when

Re: [Qemu-devel] [Qemu-ppc] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-23 Thread Anthony Liguori
On Sun, Jun 23, 2013 at 4:39 PM, Benjamin Herrenschmidt wrote: > On Sun, 2013-06-23 at 10:02 -0500, Anthony Liguori wrote: >> It doesn't make a lot of sense to have Power do MSI decoding in >> userspace while x86 does it in the kernel. I assume the kernel >> doesn't have enough information to do

[Qemu-devel] [PATCH v4] QEMUBH: make AioContext's bh re-entrant

2013-06-23 Thread Liu Ping Fan
BH will be used outside big lock, so introduce lock to protect between the writers, ie, bh's adders and deleter. The lock only affects the writers and bh's callback does not take this extra lock. Note that for the same AioContext, aio_bh_poll() can not run in parallel yet. Signed-off-by: Liu Ping

Re: [Qemu-devel] [RFC PATCH v6 3/3] Force auto-convegence of live migration

2013-06-23 Thread Chegu Vinod
On 6/20/2013 5:54 AM, Paolo Bonzini wrote: Il 14/06/2013 15:58, Chegu Vinod ha scritto: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some duration and let th

[Qemu-devel] [PATCH v7 1/3] Introduce async_run_on_cpu()

2013-06-23 Thread Chegu Vinod
Introduce an asynchronous version of run_on_cpu() i.e. the caller doesn't have to block till the call back routine finishes execution on the target vcpu. Signed-off-by: Chegu Vinod Reviewed-by: Paolo Bonzini --- cpus.c| 29 + include/qemu-common.h |

[Qemu-devel] [PATCH v7 0/3] Throttle-down guest to help with live migration convergence

2013-06-23 Thread Chegu Vinod
Busy enterprise workloads hosted on large sized VM's tend to dirty memory faster than the transfer rate achieved via live guest migration. Despite some good recent improvements (& using dedicated 10Gig NICs between hosts) the live migration does NOT converge. If a user chooses to force convergence

[Qemu-devel] [PATCH v7 2/3] Add 'auto-converge' migration capability

2013-06-23 Thread Chegu Vinod
If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some duration and let the migration thread catchup and help converge. Verified the convergence using the following

[Qemu-devel] [PATCH v7 2/3] Add 'auto-converge' migration capability

2013-06-23 Thread Chegu Vinod
The auto-converge migration capability allows the user to specify if they choose live migration seqeunce to automatically detect and force convergence. Signed-off-by: Chegu Vinod Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake --- include/migration/migration.h |2 ++ migration.c

[Qemu-devel] [PATCH v7 3/3] Force auto-convegence of live migration

2013-06-23 Thread Chegu Vinod
If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some duration and let the migration thread catchup and help converge. Verified the convergence using the following

Re: [Qemu-devel] [PATCH v7 2/3] Add 'auto-converge' migration capability

2013-06-23 Thread Chegu Vinod
Oops! A minor glitch on my side (pl. ignore the subject line of this...as this is actually patch 3/3 and not patch 2/3). I just resent this as patch 3/3 with the correct subject line. Thx Vinod On 6/23/2013 1:05 PM, Chegu Vinod wrote: If a user chooses to turn on the auto-converge migra

Re: [Qemu-devel] [PATCH] Switch the roles of jmp_next[0] and jmp_next[1].

2013-06-23 Thread Zhihui Zhang
My intention was to make things consistent for readability. In the case of gen_jz_ecx_string(), jmp_next[1] is already the "not taken" case. However, looks like the meaning of jmp_next changes in the case of a TB loop, it does not point to the next TB to execute any more. Anyway, I thought this p

Re: [Qemu-devel] [RFT PATCH v1 01/30] net/e1000: QOM Upcast Sweep

2013-06-23 Thread Peter Crosthwaite
On Tue, Jun 11, 2013 at 4:40 PM, wrote: > From: Peter Crosthwaite > > Define and use standard QOM cast macro. Remove usages of DO_UPCAST > and direct -> style upcasting. > > Signed-off-by: Peter Crosthwaite > --- > > hw/net/e1000.c | 20 +--- > 1 file changed, 13 insertions(+),

Re: [Qemu-devel] [RFT PATCH v1 06/30] scsi/megasas: QOM Upcast Sweep

2013-06-23 Thread Peter Crosthwaite
On Tue, Jun 11, 2013 at 4:44 PM, wrote: > From: Peter Crosthwaite > > Define and use standard QOM cast macro. Remove usages of DO_UPCAST > and direct -> style upcasting. > > Signed-off-by: Peter Crosthwaite > --- > > hw/scsi/megasas.c | 17 +++-- > 1 file changed, 11 insertions(+),

Re: [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors

2013-06-23 Thread Alexey Kardashevskiy
On 06/21/2013 10:03 PM, Alexander Graf wrote: > > On 21.06.2013, at 14:01, Julio Guerra wrote: > >> 2013/6/21 Alexander Graf : >>> >>> On 26.05.2013, at 19:41, Julio Guerra wrote: >>> MPC86xx processors are based on the e600 core, which is not the case in qemu where it is based on the 7

Re: [Qemu-devel] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-23 Thread Alex Williamson
On Sun, 2013-06-23 at 10:06 -0500, Anthony Liguori wrote: > On Thu, Jun 20, 2013 at 11:46 PM, Alex Williamson > wrote: > > On Fri, 2013-06-21 at 12:49 +1000, Alexey Kardashevskiy wrote: > >> On 06/21/2013 12:34 PM, Alex Williamson wrote: > >> > >> > >> Do not follow you, sorry. For x86, is it that

Re: [Qemu-devel] [Qemu-ppc] [PATCH] RFC kvm irqfd: add directly mapped MSI IRQ support

2013-06-23 Thread Alex Williamson
On Sun, 2013-06-23 at 16:58 -0500, Anthony Liguori wrote: > On Sun, Jun 23, 2013 at 4:39 PM, Benjamin Herrenschmidt > wrote: > > On Sun, 2013-06-23 at 10:02 -0500, Anthony Liguori wrote: > >> It doesn't make a lot of sense to have Power do MSI decoding in > >> userspace while x86 does it in the ke

Re: [Qemu-devel] [RFT PATCH v1 16/30] isa/*: QOM casting sweep

2013-06-23 Thread Peter Crosthwaite
Hi Andreas, On Tue, Jun 11, 2013 at 7:58 PM, Andreas Färber wrote: > Am 11.06.2013 08:52, schrieb peter.crosthwa...@xilinx.com: >> From: Peter Crosthwaite >> >> Use standard QOM cast macros. Remove usage of DO_UPCAST and >> direct -> style upcasting. >> >> Signed-off-by: Peter Crosthwaite >> --

Re: [Qemu-devel] [RFT PATCH v1 12/30] virtio/virtio-pci: QOM casting sweep

2013-06-23 Thread Peter Crosthwaite
Hi Frederic, On Tue, Jun 11, 2013 at 5:09 PM, Frederic Konrad wrote: > Hi, > > > On 11/06/2013 08:49, peter.crosthwa...@xilinx.com wrote: >> >> From: Peter Crosthwaite >> >> Use standard QOM cast macro. Remove usages of container_of() and >> direct -> style upcasting. >> >> Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 1/2] monitor: discard global variable in auto completion functions

2013-06-23 Thread Wenchao Xia
于 2013-6-21 23:24, Luiz Capitulino 写道: On Fri, 21 Jun 2013 14:37:37 +0800 Wenchao Xia wrote: In monitor_find_completion() and related functions, Global variable *mon_cmds is not used any more, make them reenterable safely. *cur_mon is also not used now. *info_cmds is still there, but soon will

Re: [Qemu-devel] [PATCH V2] ARM Cortex A9 Global Timer

2013-06-23 Thread Peter Crosthwaite
I've respun this, but still testing and debugging a few issues. Some notes FTR. On Tue, Apr 16, 2013 at 10:50 PM, François Legal wrote: > Le 16-04-2013 14:19, Peter Maydell a écrit : [Snip] > > > New patch follows. > > --- > > diff -urN qemu-master.old/hw/cpu/a9mpcore.c qemu-master/hw/cpu/a9mpco

Re: [Qemu-devel] [PATCH 01/26] ohci: use realize for ohci

2013-06-23 Thread Peter Crosthwaite
Hi Hu, On Sat, Jun 22, 2013 at 6:50 PM, Hu Tao wrote: > Cc: Gerd Hoffmann > Signed-off-by: Hu Tao > --- > hw/usb/hcd-ohci.c | 16 +++- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index 51241cd..79ef41b 100644 > --- a/hw

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer

2013-06-23 Thread Jan Kiszka
On 2013-06-23 22:50, Hervé Poussineau wrote: > Jan Kiszka a écrit : >> From: Jan Kiszka >> >> The current ioport dispatcher is a complex beast, mostly due to the >> need to deal with old portio interface users. But we can overcome it >> without converting all portio users by embedding the required

Re: [Qemu-devel] [PATCH 01/26] ohci: use realize for ohci

2013-06-23 Thread Hu Tao
On Mon, Jun 24, 2013 at 03:54:31PM +1000, Peter Crosthwaite wrote: > Hi Hu, > > On Sat, Jun 22, 2013 at 6:50 PM, Hu Tao wrote: > > Cc: Gerd Hoffmann > > Signed-off-by: Hu Tao > > --- > > hw/usb/hcd-ohci.c | 16 +++- > > 1 file changed, 7 insertions(+), 9 deletions(-) > > > > diff -

Re: [Qemu-devel] [Qemu-trivial] [PATCH 01/13] qemu-socket: zero-initialize SocketAddress

2013-06-23 Thread Gerd Hoffmann
On 06/21/13 20:15, Michael Tokarev wrote: > 21.06.2013 14:38, Gerd Hoffmann wrote: >> Signed-off-by: Gerd Hoffmann >> --- >> util/qemu-sockets.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c >> index fdd8dc4..364bd8c 10064

Re: [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors

2013-06-23 Thread Julio Guerra
2013/6/24 Alexey Kardashevskiy : > On 06/21/2013 10:03 PM, Alexander Graf wrote: >> >> On 21.06.2013, at 14:01, Julio Guerra wrote: >> >>> 2013/6/21 Alexander Graf : On 26.05.2013, at 19:41, Julio Guerra wrote: > MPC86xx processors are based on the e600 core, which is not the cas

Re: [Qemu-devel] [PATCH 01/26] ohci: use realize for ohci

2013-06-23 Thread Peter Crosthwaite
Hi Hu, On Mon, Jun 24, 2013 at 4:11 PM, Hu Tao wrote: > On Mon, Jun 24, 2013 at 03:54:31PM +1000, Peter Crosthwaite wrote: >> Hi Hu, >> >> On Sat, Jun 22, 2013 at 6:50 PM, Hu Tao wrote: >> > Cc: Gerd Hoffmann >> > Signed-off-by: Hu Tao >> > --- >> > hw/usb/hcd-ohci.c | 16 +++- >>

Re: [Qemu-devel] [PATCH v2] vmdk: refuse to open higher version than supported

2013-06-23 Thread Fam Zheng
On Thu, 06/13 10:38, Stefan Hajnoczi wrote: > On Thu, Jun 13, 2013 at 11:21:29AM +0800, Fam Zheng wrote: > > Refuse to open higher version for safety. > > > > Although we try to be compatible with published VMDK spec, VMware has > > newer version from ESXi 5.1 exported OVF/OVA, which we have no kn

[Qemu-devel] [PATCH for mst/pci] output nc->name in NIC_RX_FILTER_CHANGED event

2013-06-23 Thread Amos Kong
netclient 'name' entry in event is useful for management to know which device is changed. n->netclient_name is not always set. This patch changes to use nc->name. If we don't assign 'id', qemu will set a generated name to nc->name. Signed-off-by: Amos Kong --- hw/net/virtio-net.c | 11 +++---

[Qemu-devel] [PATCH v2 04/13] qemu-char: check optional fields using has_*

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 2c3cfe6..ee7c70e 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3500,7 +3500,7 @@ static CharDriverState *qmp_chardev_open_file(ChardevFile *fil

[Qemu-devel] [PATCH v2 01/13] qemu-socket: zero-initialize SocketAddress

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- util/qemu-sockets.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 96eca2a..86fb09c 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -848,9 +848,9 @@ int unix_nonblocking_conn

[Qemu-devel] [PATCH v2 00/13] A bunch of little socket + chardev fixes

2013-06-23 Thread Gerd Hoffmann
Hi, Here is v2 of the series, addressing Michaels review comments. cheers, Gerd Gerd Hoffmann (13): qemu-socket: zero-initialize SocketAddress qemu-socket: drop pointless allocation qemu-socket: catch monitor_get_fd failures qemu-char: check optional fields using has_* qemu-char: u

[Qemu-devel] [PATCH v2 07/13] qemu-char: fix documentation for telnet+wait socket flags

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qapi-schema.json |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index a80ee40..a29ce57 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3185,10 +3185,11 @@ # @addr: socket address to liste

[Qemu-devel] [PATCH v2 03/13] qemu-socket: catch monitor_get_fd failures

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- util/qemu-sockets.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 35023a8..126cbb6 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -903,7 +903,7 @@ int socket_connect(SocketAddr

[Qemu-devel] [PATCH v2 06/13] qemu-char: print notification to stderr

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index cfc68cd..3e0044b 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2666,8 +2666,8 @@ static CharDriverState *qemu_chr_open_socket_fd(int fd, bool d

[Qemu-devel] [PATCH v2 05/13] qemu-char: use more specific error_setg_* variants

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-char.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index ee7c70e..cfc68cd 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2604,7 +2604,7 @@ static CharDriverState *qemu_chr_open_socket_fd(int fd, bool d

[Qemu-devel] [PATCH v2 13/13] qemu-socket: don't leak opts on error

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- util/qemu-sockets.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 126cbb6..095716e 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -963,7 +963,7 @@ int socket_dgram(SocketAddres

[Qemu-devel] [PATCH v2 11/13] qemu-char: add -chardev mux support

2013-06-23 Thread Gerd Hoffmann
Allow to explicitly create mux chardevs on the command line, like you can using QMP. Signed-off-by: Gerd Hoffmann --- qemu-char.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index e6c3157..7d072a8 100644 --- a/qemu-char.c +++ b/qemu-char.c

[Qemu-devel] [PATCH v2 09/13] qemu-char: use ChardevBackendKind in in CharDriver

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/sysemu/char.h |2 +- qemu-char.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/sysemu/char.h b/include/sysemu/char.h index 066c216..e65e4a4 100644 --- a/include/sysemu/char.h +++ b/include/sysemu/char.h @

Re: [Qemu-devel] [PULL 00/21] pci,net,misc enhancements

2013-06-23 Thread Amos Kong
On Sun, Jun 23, 2013 at 02:38:04PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 21, 2013 at 08:10:15AM -0500, Anthony Liguori wrote: > > "Michael S. Tsirkin" writes: > > > > > From: Michael S. Tsirkin > > > > > > The following changes since commit > > > 90a2541b763b31d2b551b07e24aae3de5266d31

[Qemu-devel] [PATCH v2 08/13] qemu-char: don't leak opts on error

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-char.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 3e0044b..5751391 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3185,7 +3185,7 @@ CharDriverState *qemu_chr_new_from_opts(QemuOpts *opts, if (i

[Qemu-devel] [PATCH v2 12/13] qemu-char: report udb backend errors

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-char.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index 7d072a8..dcc91bb 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2255,6 +2255,8 @@ static CharDriverState *qemu_chr_open_udp(QemuOpts *opts) fd = inet_dgram_

[Qemu-devel] [PATCH v2 10/13] qemu-char: minor mux chardev fixes

2013-06-23 Thread Gerd Hoffmann
mux failure path has a memory leak. creating a mux chardev can't fail though, so just assert() that instead of fixing an error path which never ever runs anyway ... Also fix bid being leaked while being at it. Signed-off-by: Gerd Hoffmann --- qemu-char.c |7 +++ 1 file changed, 3 inser

[Qemu-devel] [PATCH v2 02/13] qemu-socket: drop pointless allocation

2013-06-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- util/qemu-sockets.c |1 - 1 file changed, 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 86fb09c..35023a8 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -871,7 +871,6 @@ SocketAddress *socket_parse(const char *str, E

[Qemu-devel] [PULL 0/9] usb patch queue

2013-06-23 Thread Gerd Hoffmann
Hi, Here comes the usb patch queue, bringing QOM improvements for ehci-sysbus, tegra2 ehci support and the usual share of little bug fixes. please pull, Gerd The following changes since commit 576156ffed72ab4feb0b752979db86ff8759a2a1: Merge remote-tracking branch 'bonzini/iommu-for-anthon

Re: [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors

2013-06-23 Thread Alexander Graf
Am 24.06.2013 um 08:13 schrieb Julio Guerra : > 2013/6/24 Alexey Kardashevskiy : >> On 06/21/2013 10:03 PM, Alexander Graf wrote: >>> >>> On 21.06.2013, at 14:01, Julio Guerra wrote: >>> 2013/6/21 Alexander Graf : > > On 26.05.2013, at 19:41, Julio Guerra wrote: > >> MPC

[Qemu-devel] [PATCH 6/9] usb/host-libusb: Fix building with libusb git master code

2013-06-23 Thread Gerd Hoffmann
From: Hans de Goede The next libusb release will deprecate libusb_get_port_path, and since we compile with -Werror, this breaks the build. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c |4 1 file changed, 4 insertions(+) diff --git a/hw/usb/host-

[Qemu-devel] [PATCH 3/9] usb/hcd-ehci: Add Tegra2 SysBus EHCI device

2013-06-23 Thread Gerd Hoffmann
From: Andreas Färber This prepares an EHCI device for the Nvidia Tegra2 SoC family. Values based on patch by Vincent Palatin and verified against TRM v01p. Cc: Vincent Palatin Signed-off-by: Andreas Färber Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci-sysbus.c | 15 +++ hw/u

[Qemu-devel] [PATCH 1/9] usb/hcd-ehci-sysbus: Convert to QOM realize

2013-06-23 Thread Gerd Hoffmann
From: Andreas Färber The SysBus qdev initfn merely calls SysBusDeviceClass::init, so we can replace it with a realizefn already. This avoids getting into any initfn ambiguity with the upcoming Faraday EHCI implementation. Rename internal usb_ehci_initfn() to usb_ehci_realize() to allow to return

[Qemu-devel] [PATCH 7/9] usb-host-libusb: set USB_DEV_FLAG_IS_HOST

2013-06-23 Thread Gerd Hoffmann
... like host-{linux,bsd}.c do. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 0c12b0f..e2f3cc8 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c

[Qemu-devel] [PATCH 8/9] usb: add serial bus property

2013-06-23 Thread Gerd Hoffmann
This patch adds a serial property for all usb devices, which can be used to set the serial number of a usb device (as listed by lsusb -v) to a specific value. Applies to emulated devices only. Signed-off-by: Gerd Hoffmann --- hw/usb/bus.c |1 + hw/usb/desc.c|6 ++ hw

[Qemu-devel] [PATCH 9/9] usb: fix serial number for hid devices

2013-06-23 Thread Gerd Hoffmann
commit 7b074a22dab4bdda9864b933f1bc811a3db42845 changed the serial number of hid devices. Add compat properties to keep the old serial number for qemu 0.12 and older. Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/i386/p

[Qemu-devel] [PATCH 5/9] usb/hcd-ehci: Add Faraday FUSBH200 support

2013-06-23 Thread Gerd Hoffmann
From: Kuo-Jung Su Add Faraday FUSBH200 support, which is slightly different from EHCI spec. (Or maybe simply a bad/wrong implementation...) Signed-off-by: Kuo-Jung Su Signed-off-by: Andreas Färber Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci-sysbus.c | 75 ++

[Qemu-devel] [PATCH 2/9] usb/hcd-ehci: Split off instance_init from realize

2013-06-23 Thread Gerd Hoffmann
From: Andreas Färber This makes the mem MemoryRegion available to derived instance_inits. Keep the bus in realize for now since naming breaks in instance_init. Signed-off-by: Andreas Färber Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci-pci.c| 19 ++- hw/usb/hcd-ehci-

[Qemu-devel] [PATCH 4/9] usb/hcd-ehci: Replace PORTSC macros with variables

2013-06-23 Thread Gerd Hoffmann
From: Kuo-Jung Su Replace PORTSC macros with variables which could then be configured in ehci__class_init(...) Signed-off-by: Kuo-Jung Su Signed-off-by: Andreas Färber Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci-pci.c|2 ++ hw/usb/hcd-ehci-sysbus.c |6 ++ hw/usb/hcd-

[Qemu-devel] [PATCH v2 00/30] PCI: Cleanup legacy casts in device land

2013-06-23 Thread peter . crosthwaite
From: Peter Crosthwaite There are a number of different cast implementations from various stages of QEMU development out in device model land. This series cleans up the ones involving TYPE_PCI_DEVICE to consistently use proper QOM casts for both up and down casts. Some were easy, some needed QOM

[Qemu-devel] [PATCH v2 01/30] net/e1000: QOM Upcast Sweep

2013-06-23 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/net/e1000.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c

[Qemu-devel] [PATCH v2 02/30] net/rtl8139: QOM Upcast Sweep

2013-06-23 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/net/rtl8139.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/net/rtl8139.c b/hw

[Qemu-devel] [PATCH v2 03/30] net/pcnet-pci: QOM Upcast Sweep

2013-06-23 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/net/pcnet-pci.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/net/pcnet-pci.c b/hw/net/pcne