this series adds logical block provisioning functions to the iscsi layer.
it also is the first step to the change of migration to coroutines in
block/iscsi.
v4->v5:
- rebased to master + stefanha/block
- patch1: fetching block limits page also if lbpws == 1
- patch2: converted to get block s
this patch adds a coroutine for .bdrv_co_block_status as well as
a generic framework that can be used to build coroutines in block/iscsi.
Signed-off-by: Peter Lieven
---
block/iscsi.c | 135 +
1 file changed, 135 insertions(+)
diff --git
Signed-off-by: Peter Lieven
---
block/iscsi.c | 77 +
1 file changed, 77 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 5f28c6a..185bfd3 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -50,6 +50,10 @@ typedef struct Iscs
Signed-off-by: Peter Lieven
---
block/iscsi.c | 156 +++--
1 file changed, 73 insertions(+), 83 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 19afd6c..cb44fb1 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -85,6 +85,7 @@ typ
On Tue, Jul 16, 2013 at 06:29:28PM +0200, Paolo Bonzini wrote:
> diff --git a/block.c b/block.c
> index 557ce29..2d7d71f 100644
> --- a/block.c
> +++ b/block.c
> @@ -2977,7 +2977,7 @@ static int64_t coroutine_fn
> bdrv_co_get_block_status(BlockDriverState *bs,
>
On Tue, Jul 16, 2013 at 06:29:11PM +0200, Paolo Bonzini wrote:
> This series adds a subcommand to "map" that can dump file metadata.
> Metadata that is dumped includes:
>
> - whether blocks are allocated in bs->file and, if so, where
>
> - whether blocks are zero
>
> - whether data is read from
Am 19.07.2013 um 08:29 hat Wenchao Xia geschrieben:
> 于 2013-7-17 22:23, Eric Blake 写道:
> >On 07/17/2013 08:03 AM, Wenchao Xia wrote:
> >>This series allow user to read internal snapshot's contents without qemu-img
> >>convert. Another purpose is that, when qemu is online and have taken an
> >>inte
Am 19.07.2013 um 07:27 hat Stefan Hajnoczi geschrieben:
> On Thu, Jul 18, 2013 at 11:21:42PM +0200, Charlie Shepherd wrote:
> > This patch makes bdrv_flush a synchronous function and updates any callers
> > from
> > a coroutine context to use bdrv_co_flush instead.
> >
> > The motivation for this
From: Bharata B Rao
Use pkg-config to determine the version and library dependency
for GlusterFS block driver.
Signed-off-by: Bharata B Rao
Signed-off-by: Stefan Hajnoczi
---
configure | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/configure b/configure
The following changes since commit 24943978cbe79634a9a8b02a20efb25b29b3ab49:
boot-order-test: Add tests for Sun4u (2013-07-18 13:27:47 -0500)
are available in the git repository at:
git://github.com/stefanha/qemu.git block
for you to fetch changes up to a23fdf355969d331f60593fa5b857d43aec25
From: Fam Zheng
s->qcow and s->qcow_filename are allocated but not freed on error. Fix the
possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of
bdrv_create() and also the one of enable_write_target().
Signed-off-by: Fam Zheng
Reviewed-by: Laszlo Ersek
Signed-off-by: S
From: Bharata B Rao
Implement bdrv_aio_discard for gluster.
Signed-off-by: Bharata B Rao
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
---
block/gluster.c | 45 +
configure | 8
2 files changed, 53 insertions(+)
diff --git
From: Kevin Wolf
Even if the VM is already stopped, we cannot assume that all data has
already been successfully flushed to disk. The flush during the previous
vm_stop() could have failed.
Run bdrv_flush_all() unconditionally so that we get an error each time
if the block device isn't really flu
Load the virtio.c state into vring.c when we start dataplane mode and
vice versa when stopping dataplane mode. This patch makes it possible
to start and stop dataplane any time while the guest is running.
This will eventually allow us to go back to QEMU main loop for
bdrv_drain_all() and live mig
From: Peter Lieven
Signed-off-by: Peter Lieven
Reviewed-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index b05e2d6..6cd39fa 100644
--- a/block.c
+++ b/block.c
@@ -2255,7 +2255,7 @@ int bdrv_r
From: Peter Lieven
this patch adds a efficient encoding for zero blocks by
adding a new flag indicating a block is completely zero.
additionally bdrv_write_zeros() is used at the destination
to efficiently write these zeroes. depending on the implementation
this avoids that the destination targe
From: Peter Lieven
Signed-off-by: Peter Lieven
Signed-off-by: Stefan Hajnoczi
---
block/raw.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/block/raw.c b/block/raw.c
index 8c81de9..f1682d4 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -121,6 +121,11 @@ static int raw_has_zero_init(
From: Peter Lieven
Signed-off-by: Peter Lieven
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
---
block/raw.c | 8
1 file changed, 8 insertions(+)
diff --git a/block/raw.c b/block/raw.c
index ce10422..8c81de9 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -42,6 +42,13 @@ stat
> "migrate -b tcp ::1234"
There should be no space between tcp and the rest of the connection
details:
migrate -b tcp::1234
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1192499
Title:
virsh migr
From: Peter Lieven
Signed-off-by: Peter Lieven
Reviewed-by: Kevin Wolf
Signed-off-by: Stefan Hajnoczi
---
block.c | 27 +++
include/block/block.h | 2 ++
2 files changed, 21 insertions(+), 8 deletions(-)
diff --git a/block.c b/block.c
index b560241..b05
From: Liu Ping Fan
BH will be used outside big lock, so introduce lock to protect
between the writers, ie, bh's adders and deleter. The lock only
affects the writers and bh's callback does not take this extra lock.
Note that for the same AioContext, aio_bh_poll() can not run in
parallel yet.
Sig
于 2013-7-18 13:43, Stefan Hajnoczi 写道:
On Wed, Jul 17, 2013 at 10:03:51PM +0800, Wenchao Xia wrote:
This series allow user to read internal snapshot's contents without qemu-img
convert. Another purpose is that, when qemu is online and have taken an
internal snapshot, let user invoke qemu-nbd to
This is another trivial-patches pull request. This time
we have just 5 patches accumulated in two (!) weeks period.
Please consider apply.
/mjt
The following changes since commit 24943978cbe79634a9a8b02a20efb25b29b3ab49:
boot-order-test: Add tests for Sun4u (2013-07-18 13:27:47 -0500)
are av
From: Cole Robinson
sasldblistusers2 doesn't have a '-a' option
Signed-off-by: Cole Robinson
Signed-off-by: Michael Tokarev
---
qemu.sasl |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu.sasl b/qemu.sasl
index cf19cf8..9dc8323 100644
--- a/qemu.sasl
+++ b/qemu.sasl
于 2013-7-18 19:07, Stefan Hajnoczi 写道:
On Thu, Jul 11, 2013 at 01:46:58PM +0800, Wenchao Xia wrote:
diff --git a/include/qemu-common.h b/include/qemu-common.h
index f439738..06c777f 100644
--- a/include/qemu-common.h
+++ b/include/qemu-common.h
@@ -191,6 +191,9 @@ int64_t strtosz_suffix(const ch
Il 19/07/2013 08:48, Peter Lieven ha scritto:
>> @@ -3040,7 +3040,10 @@ int64_t bdrv_get_block_status(BlockDriverState
>> *bs, int64_t sector_num,
>> int coroutine_fn bdrv_is_allocated(BlockDriverState *bs, int64_t
>> sector_num,
>> int nb_sectors, int *pnum)
于 2013-7-18 19:48, Kevin Wolf 写道:
Am 11.07.2013 um 07:46 hat Wenchao Xia geschrieben:
Snapshot creation actually already distinguish id and name since it take
a structured parameter *sn, but delete can't. Later an accurate delete
is needed in qmp_transaction abort and blockdev-snapshot-delete-sy
Il 19/07/2013 08:35, Peter Lieven ha scritto:
> On 16.07.2013 18:29, Paolo Bonzini wrote:
>> Define the return value of get_block_status. Bits 0, 1, 2 and 9-62
>> are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-7
>> are left for future extensions.
>>
>> The return code is compatib
Il 19/07/2013 09:19, Peter Lieven ha scritto:
> Signed-off-by: Peter Lieven
> ---
> block/iscsi.c | 156
> +++--
> 1 file changed, 73 insertions(+), 83 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 19afd6c..cb44fb1 10064
Am 19.07.2013 um 11:03 hat Wenchao Xia geschrieben:
> 于 2013-7-18 13:43, Stefan Hajnoczi 写道:
> >On Wed, Jul 17, 2013 at 10:03:51PM +0800, Wenchao Xia wrote:
> >>This series allow user to read internal snapshot's contents without qemu-img
> >>convert. Another purpose is that, when qemu is online and
于 2013-7-18 20:22, Kevin Wolf 写道:
Am 11.07.2013 um 07:46 hat Wenchao Xia geschrieben:
Unlike savevm, the qmp_transaction interface will not generate
snapshot name automatically, saving trouble to return information
of the new created snapshot.
Although qcow2 support storing multiple snapshots w
From: Ed Maste
- Split 32Mb and 256Mb parts into a11 and a13 variants.
- Add the 4K sector flag to the 128Mb parts. (These entries were taken from
the Linux kernel list, which is missing the flag.)
- Fill out the table of sizes with entries for 64Mb parts.
Prodded by Peter Crosthwaite.
Signe
Signed-off-by: Michael Tokarev
---
qemu-options.hx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 4e98b4f..2dbfd42 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2493,8 +2493,8 @@ listening on port would be:
@table
From: Petar Jovanovic
sys_futex has 6 arguments, and all of these need to be copied. Fix incorrect
declaration in the mips_syscall_args array.
This change fixes the cases where the 5th and 6th arguments have non-zero
value and have importance. An example is a Linux implementation of
pthread_cond
---
slirp/mbuf.h | 51 ++-
slirp/tcp_subr.c | 12 ++--
2 files changed, 24 insertions(+), 39 deletions(-)
diff --git a/slirp/mbuf.h b/slirp/mbuf.h
index 3f3ab09..b144f1c 100644
--- a/slirp/mbuf.h
+++ b/slirp/mbuf.h
@@ -49,22 +49,6 @@
Am 18.07.2013 um 10:37 hat Peter Lieven geschrieben:
> Signed-off-by: Peter Lieven
> ---
> block.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index b560241..c7f0197 100644
> --- a/block.c
> +++ b/block.c
> @@ -2250,7 +2250,7 @@ int bdrv_read_u
On 19 July 2013 01:25, Jia Liu wrote:
> Hi Peter,
>
> On Thu, Jul 18, 2013 at 6:18 PM, Peter Maydell
> wrote:
>> Ping?
>>
>
> Thank you, it looks good to me, please push it.
The usual way to say this is to add your reviewed-by
or acked-by tag (depending on how thoroughly you
checked it)...
tha
On 07/18/2013 10:37 PM, Scott Wood wrote:
> On 07/18/2013 04:27:50 AM, Fabien Chouteau wrote:
>> On 07/17/2013 11:02 PM, Scott Wood wrote:
>>> On 07/17/2013 05:17:06 AM, Fabien Chouteau wrote:
Can you explain a possible error scenario?
>>>
>>> 126 byte packet, no fcb. rx_padding is 4 for CRC.
On 19.07.2013 11:14, Kevin Wolf wrote:
Am 18.07.2013 um 10:37 hat Peter Lieven geschrieben:
Signed-off-by: Peter Lieven
---
block.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index b560241..c7f0197 100644
--- a/block.c
+++ b/block.c
@@ -2250,7 +2
On 19.07.2013 11:18, Paolo Bonzini wrote:
Il 19/07/2013 09:19, Peter Lieven ha scritto:
Signed-off-by: Peter Lieven
---
block/iscsi.c | 156 +++--
1 file changed, 73 insertions(+), 83 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.
Il 19/07/2013 08:48, Peter Lieven ha scritto:
>>
>> -return bdrv_get_block_status(bs, sector_num, nb_sectors, pnum);
>> +int64_t ret = bdrv_get_block_status(bs, sector_num, nb_sectors,
>> pnum);
>> +return
>> +(ret & BDRV_BLOCK_DATA) ||
>> +((ret & BDRV_BLOCK_ZERO) && !b
于 2013-7-19 17:19, Kevin Wolf 写道:
Am 19.07.2013 um 11:03 hat Wenchao Xia geschrieben:
于 2013-7-18 13:43, Stefan Hajnoczi 写道:
On Wed, Jul 17, 2013 at 10:03:51PM +0800, Wenchao Xia wrote:
This series allow user to read internal snapshot's contents without qemu-img
convert. Another purpose is tha
On 19.07.2013 11:58, Paolo Bonzini wrote:
Il 19/07/2013 08:48, Peter Lieven ha scritto:
-return bdrv_get_block_status(bs, sector_num, nb_sectors, pnum);
+int64_t ret = bdrv_get_block_status(bs, sector_num, nb_sectors,
pnum);
+return
+(ret & BDRV_BLOCK_DATA) ||
+((ret
Am 19.07.2013 um 11:19 hat Wenchao Xia geschrieben:
> 于 2013-7-18 20:22, Kevin Wolf 写道:
> >Am 11.07.2013 um 07:46 hat Wenchao Xia geschrieben:
> >>Unlike savevm, the qmp_transaction interface will not generate
> >>snapshot name automatically, saving trouble to return information
> >>of the new crea
于 2013-7-18 12:41, Fam Zheng 写道:
On Wed, 07/17 06:44, Eric Blake wrote:
On 07/17/2013 03:42 AM, Fam Zheng wrote:
Similar to drive-backup, but this command uses a device id as target
instead of creating/opening an image file.
Signed-off-by: Fam Zheng
---
blockdev.c | 71 +++
于 2013-7-17 17:42, Fam Zheng 写道:
> This series adds for point-in-time snapshot NBD exporting based on
> blockdev-backup (variant of drive-backup with existing device as target). This
> patch is built on top of imain's sync mode patches for drive-backup.
>
> We get a thin point-in-time snapshot by
于 2013-7-17 0:57, Paolo Bonzini 写道:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 16/07/2013 18:56, Eric Blake ha scritto:
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
This series adds a subcommand to "map" that can dump file
metadata. Metadata that is dumped includes:
- whether blocks are
On 07/18/2013 08:23 PM, Pawit Pornkitprasan wrote:
> The "completed" stage sets total_time but not has_total_time and
> thus it is not sent via QMP reply (but sent via HMP nevertheless)
>
> Signed-off-by: Pawit Pornkitprasan
> ---
> migration.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-b
On 07/18/2013 08:36 PM, Pawit Pornkitprasan wrote:
> The qmp_migrate method uses the 'blk' and 'inc' parameter without
> checking if they're valid or not (they may be uninitialized if
> command is received via QMP)
>
> Signed-off-by: Pawit Pornkitprasan
> ---
> migration.c | 4 ++--
> 1 file cha
On Fri, Jul 19, 2013 at 7:57 PM, Eric Blake wrote:
>
> However, wouldn't it be nice if we improved the qapi generator to
> guarantee a sane default value for optional parameters, even when
> has_value is false?
>
I'm not a qemu expert or anything, but wouldn't that destroy the point
of has_value
Ping?
On 10/07/13 15:26, Jens Freimann wrote:
> With this patch dump-guest-memory on s390 produces an ELF formatted,
> crash-readable dump.
> In order to implement this, the arch-specific part of dump-guest-memory
> was added:
> target-s390x/arch_dump.c contains the whole set of function for writ
On 15 July 2013 16:15, Anthony Liguori wrote:
> Hard freeze is two weeks away.
>
> http://wiki.qemu.org/Planning/1.6
I've just noticed that this is still inconsistent. That
page says:
"Soft feature freeze. Major features should have initial code
committed by this date."
but it links to http://w
Hi!
This patch also breaks virtio on powerpc. I thought it was fixed
(reverted?) in the master branch from qemu.org but it is still there. What
did I miss?
The problem comes from "-drive file=virtimg/fc18guest,if=virtio".
My full command line is:
./qemu-system-ppc64 -L "qemu-ppc64-bios/" \
-tra
Ping^2 !
thanks
-- PMM
On 12 July 2013 16:05, Peter Maydell wrote:
> Ping!
>
> thanks
> -- PMM
>
> On 28 June 2013 12:40, Peter Maydell wrote:
>> A common operation in instruction decoding is to take a field
>> from an instruction that represents a signed integer in some
>> arbitrary number of
On 07/19/2013 05:04 AM, Pawit Pornkitprasan wrote:
> On Fri, Jul 19, 2013 at 7:57 PM, Eric Blake wrote:
>>
>> However, wouldn't it be nice if we improved the qapi generator to
>> guarantee a sane default value for optional parameters, even when
>> has_value is false?
>>
>
> I'm not a qemu expert
On 8 July 2013 23:40, Soren Brinkmann wrote:
> +
> +if (ep) {
> +*ep = hdr->ih_ep;
> +}
(Allowing ep to be NULL for IH_TYPE_KERNEL is new behaviour,
but it makes sense for consistency with the other pointer
argument handling.)
> +
> +/* TODO: Check CPU type.
On 8 July 2013 23:40, Soren Brinkmann wrote:
> The load_ramdisk function is used to load ramdisk featuring a U-Boot
> header.
>
> Signed-off-by: Soren Brinkmann
Reviewed-by: Peter Maydell
-- PMM
Il 19/07/2013 12:04, Peter Lieven ha scritto:
> On 19.07.2013 11:58, Paolo Bonzini wrote:
>> Il 19/07/2013 08:48, Peter Lieven ha scritto:
-return bdrv_get_block_status(bs, sector_num, nb_sectors, pnum);
+int64_t ret = bdrv_get_block_status(bs, sector_num, nb_sectors,
pnum);
Il 19/07/2013 12:48, Wenchao Xia ha scritto:
> I think dump of allocated info in qemu-img in this series, can do
> dirty change tracking job for backing chain snapshot now, qemu's QMP
> interface is not very needed.
> Only thing not perfect, is that it talks with string.
It uses JSON, actually
On 07/16/2013 04:37 AM, Amos Kong wrote:
> QMP schema is defined in a json file, it will be parsed by
> qapi scripts and generate C files.
>
> We want to return the schema information to management,
> this patch converts the json file to a string table in a
> C head file, then we can use the json
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> Do not do two reads for each sector; load each sector of the bitmap
> and use bitmap operations to process it.
>
> Writes are still dog slow!
>
> Signed-off-by: Paolo Bonzini
> ---
> v1->v2: use BDRV_SECTOR_SIZE, not 512 for bitmap array len
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> Only sync once per write, rather than once per sector.
>
> Signed-off-by: Paolo Bonzini
> ---
> block/cow.c | 19 ---
> 1 file changed, 16 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> As we change bdrv_is_allocated to gather more information from bs and
> bs->file, it will become a bit slower. It is still appropriate for online
> jobs, but not for reads/writes. Call the internal function instead.
>
> Signed-off-by: Paolo Bonzini
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> bdrv_is_allocated can detect coroutine context and go through a fast
> path, similar to other block layer functions.
>
> Signed-off-by: Paolo Bonzini
> ---
> block.c | 24 +++-
> block/raw.c | 2 +-
> blo
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> Now that bdrv_is_allocated detects coroutine context, the two can
> use the same code.
>
> Signed-off-by: Paolo Bonzini
> ---
> block.c | 46 --
> block/commit.c| 6 +++---
> block/m
Il 19/07/2013 13:09, Alexey Kardashevskiy ha scritto:
> Hi!
>
> This patch also breaks virtio on powerpc. I thought it was fixed
> (reverted?) in the master branch from qemu.org but it is still there. What
> did I miss?
It was not reverted, only the "DEVICE_LITTLE_ENDIAN" marking was.
Let me che
Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto:
> Nikunj A Dadhania writes:
>> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546
>> Author: Paolo Bonzini
>> Date: Fri May 24 12:54:01 2013 +0200
>>
>> memory: add big endian support to access_with_adjusted_size
>>
>> This will be us
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> Some bdrv_is_allocated callers do not expect errors, but the fallback
> in qcow2.c might make other callers trip on assertion failures or
> infinite loops.
>
> Fix the callers to always look for errors.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by:
On 07/19/2013 10:50 PM, Paolo Bonzini wrote:
> Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto:
>> Nikunj A Dadhania writes:
>>> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546
>>> Author: Paolo Bonzini
>>> Date: Fri May 24 12:54:01 2013 +0200
>>>
>>> memory: add big endian support to acc
Il 19/07/2013 14:58, Alexey Kardashevskiy ha scritto:
> On 07/19/2013 10:50 PM, Paolo Bonzini wrote:
>> Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto:
>>> Nikunj A Dadhania writes:
commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546
Author: Paolo Bonzini
Date: Fri May 24 12:54:01
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> qemu-img convert is assuming "that sectors which are unallocated in the input
> image are present in both the output's and input's base images", but it is
> only doing this if the output image is zero initialized. And checking if
> the output image is
On 07/19/2013 11:03 PM, Paolo Bonzini wrote:
> Il 19/07/2013 14:58, Alexey Kardashevskiy ha scritto:
>> On 07/19/2013 10:50 PM, Paolo Bonzini wrote:
>>> Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto:
Nikunj A Dadhania writes:
> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546
> Aut
On 19.07.2013 14:13, Paolo Bonzini wrote:
Il 19/07/2013 12:04, Peter Lieven ha scritto:
On 19.07.2013 11:58, Paolo Bonzini wrote:
Il 19/07/2013 08:48, Peter Lieven ha scritto:
-return bdrv_get_block_status(bs, sector_num, nb_sectors, pnum);
+int64_t ret = bdrv_get_block_status(bs, sect
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> This helps implementing is_allocated on top of get_block_status.
>
> Signed-off-by: Paolo Bonzini
> ---
> block.c| 5 +
> qemu-img.c | 9 +
> 2 files changed, 6 insertions(+), 8 deletions(-)
Reviewed-by: Eric Blake
> +++ b/block.c
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 19/07/2013 15:21, Eric Blake ha scritto:
> Question (more for my understanding, not that you need to change
> code): must we blindly return 0 in the presence of a backing file,
> or is it possible to recursively query the backing_hd's zero_init
> st
On Thu, Jul 18, 2013 at 11:08 PM, Peter Lieven wrote:
> On 19.07.2013 07:58, Paolo Bonzini wrote:
>>
>> Il 18/07/2013 21:28, Peter Lieven ha scritto:
>>>
>>> thanks for the details. I think to have optimal performance and best
>>> change for unmapping in qemu-img convert
>>> it might be best to ex
On 07/19/2013 11:05 PM, Alexey Kardashevskiy wrote:
> On 07/19/2013 11:03 PM, Paolo Bonzini wrote:
>> Il 19/07/2013 14:58, Alexey Kardashevskiy ha scritto:
>>> On 07/19/2013 10:50 PM, Paolo Bonzini wrote:
Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto:
> Nikunj A Dadhania writes:
>
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> For now, bdrv_get_block_status is just another name for bdrv_is_allocated.
> The next patches will add more flags.
>
> This also touches all block drivers with a mostly mechanical rename. The
> sole exception is cow; because it calls cow_co_is_alloca
On 19.07.2013 15:25, ronnie sahlberg wrote:
On Thu, Jul 18, 2013 at 11:08 PM, Peter Lieven wrote:
On 19.07.2013 07:58, Paolo Bonzini wrote:
Il 18/07/2013 21:28, Peter Lieven ha scritto:
thanks for the details. I think to have optimal performance and best
change for unmapping in qemu-img conve
On Thu, Jul 18, 2013 at 11:43 AM, Peter Lieven wrote:
>
> Am 18.07.2013 um 16:35 schrieb Paolo Bonzini :
>
>> Il 18/07/2013 16:32, Peter Lieven ha scritto:
>
(Mis)alignment and granularity can be handled later. We can ignore them
for now. Later, if we decide the best way to support
On Fri, Jul 19, 2013 at 6:49 AM, Peter Lieven wrote:
> On 19.07.2013 15:25, ronnie sahlberg wrote:
>>
>> On Thu, Jul 18, 2013 at 11:08 PM, Peter Lieven wrote:
>>>
>>> On 19.07.2013 07:58, Paolo Bonzini wrote:
Il 18/07/2013 21:28, Peter Lieven ha scritto:
>
> thanks for the detai
On 19.07.2013 16:00, ronnie sahlberg wrote:
On Fri, Jul 19, 2013 at 6:49 AM, Peter Lieven wrote:
On 19.07.2013 15:25, ronnie sahlberg wrote:
On Thu, Jul 18, 2013 at 11:08 PM, Peter Lieven wrote:
On 19.07.2013 07:58, Paolo Bonzini wrote:
Il 18/07/2013 21:28, Peter Lieven ha scritto:
thanks
From: Paolo Bonzini
Implement .bdrv_truncate in GlusterFS block driver so that GlusterFS backend
can support image resizing.
Signed-off-by: Paolo Bonzini
Signed-off-by: Bharata B Rao
Tested-by: Bharata B Rao
---
block/gluster.c | 17 +
1 file changed, 17 insertions(+)
diff -
Am 19.07.2013 04:26, schrieb Mike Qiu:
> 于 2013/7/19 1:14, Andreas Färber 写道:
>> There's some typos in the commit message, but the change looks okay to
>> me - although there were discussions to catch this on the memory API
>> side of things instead.
> You mean this patch: see below:
>
> exec: Sup
On 19 July 2013 15:12, Andreas Färber wrote:
> No, I don't. There were other segfault avoidance patches like yours over
> the past months - they're all fixing individual segfault symptoms.
> Question for Paolo is whether we want to continue to discover them one
> by one or whether to implement a f
On 19 July 2013 15:47, Kwok Cheung Yeung wrote:
> Decode trap instructions during the handling of an EXCP_TRAP according to
> the current ISA mode.
>
> Signed-off-by: Kwok Cheung Yeung
> ---
> linux-user/main.c | 20 ++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> v2:
On 19/07/2013 3:52 PM, Peter Maydell wrote:
On 19 July 2013 15:47, Kwok Cheung Yeung wrote:
Decode trap instructions during the handling of an EXCP_TRAP according to
the current ISA mode.
Signed-off-by: Kwok Cheung Yeung
---
linux-user/main.c | 20 ++--
1 file changed, 18 i
Decode trap instructions during the handling of an EXCP_TRAP according to
the current ISA mode.
Signed-off-by: Kwok Cheung Yeung
---
linux-user/main.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
v2: Read microMIPS instructions sequentially as 16-bit values to avo
hi, stefan:
I use systemtap to test this patch,the migration will success. But I
found the dataplane will start again after migration start. the
virtio_blk_handle_output will start dataplane.
virtio_blk_data_plane_stop pid:29037 tid:29037
0x6680fe : virtio_blk_data_plane_stop+0x0/0x232
Decode trap instructions during the handling of an EXCP_BREAK or EXCP_TRAP
according to the current ISA mode.
Signed-off-by: Kwok Cheung Yeung
---
linux-user/main.c | 46 +++---
1 file changed, 43 insertions(+), 3 deletions(-)
v2->v3: Handle microMIPS and
Ok. So.
What broke is...
I could try explaining but backtraces are lot better :)
Shortly - virtio_pci_config_ops.endianness was ignored before (was bad but
we had a workaround in spapr_io_ops), now it works so double swap happens
and everything gets broken.
If we talk about VGA (in powerpc, it i
On 07/19/2013 04:22:46 AM, Fabien Chouteau wrote:
On 07/18/2013 10:37 PM, Scott Wood wrote:
> On 07/18/2013 04:27:50 AM, Fabien Chouteau wrote:
>> The BD is full, we will have to put the rest of padding in the
next one.
>
> What rest of padding? I thought you said rx_padding was 2
somehow?
Using current master: 24943978cbe79634a9a8b02a20efb25b29b3ab49
'make check' gives:
ERROR:tests/boot-order-test.c:43:test_a_boot_order: assertion failed
(actual == expected_boot): (0x1230 == 0x)
GTester: last random seed: R02Se371669dcb0a3274fa9c170e22654334
I'm on x86_64
I can't
[ This is a patch for RFC purposes only. It is compile tested on Linux x86_64
only
and passes make check (or rather did before make check started dying in the
boot order test - different bug). I'd like to know whether I'm going in
the right direction ]
We no longer need alarm timers to trigger QE
Hi,
Reproducer:
# ./qemu-qmp -drive file=disks/test.img,if=virtio,cache=none,aio=native \
-enable-kvm -m 1G -monitor stdio -usb -usbdevice host:1.43
QEMU 1.5.50 monitor - type 'help' for more information
(qemu) qemu-qmp: /home/lcapitulino/work/src/upstream/qmp-unstable/exec.c:1927:
memory_acc
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> Define the return value of get_block_status. Bits 0, 1, 2 and 9-62
> are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-7
bits 3-8, actually
> are left for future extensions.
>
> The return code is compatible with the old is_allocated
Markus,
--On 19 July 2013 19:43:14 +0200 Markus Armbruster
wrote:
The tests pass for me. Anything unusual in your environment?
Did you rebuild from scratch, or just ran make after git-pull? Our
build process still isn't 100% reliable...
You're quite correct - a make clean, and a long re
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> v1->v2: handle extents that are stored in bs->file
>
> block/cow.c | 8 +++-
> block/qcow.c | 9 -
> block/qcow2.c| 16 ++--
> block/qed.c | 35
Am 04.07.2013 10:53, schrieb M. Mohan Kumar:
> Stefan Weil writes:
>
>> The leak was reported by cppcheck.
>>
>> Function proxy_init also calls g_free for ctx->fs_root.
>> Avoid reuse of this memory by setting ctx->fs_root to NULL.
>>
>> Signed-off-by: Stefan Weil
> Reviewed-by: M. Mohan Kumar
>
On Fri, 19 Jul 2013 13:28:52 -0400
Luiz Capitulino wrote:
> Hi,
>
> Reproducer:
>
> # ./qemu-qmp -drive file=disks/test.img,if=virtio,cache=none,aio=native \
> -enable-kvm -m 1G -monitor stdio -usb -usbdevice host:1.43
> QEMU 1.5.50 monitor - type 'help' for more information
> (qemu) qemu-qm
1 - 100 of 158 matches
Mail list logo
