Re: [Qemu-devel] [PATCH 06/16] dimm: implement dimm device abstraction

2013-07-24 Thread Hu Tao
On Tue, Jul 23, 2013 at 06:23:02PM +0200, Igor Mammedov wrote: > From: Vasilis Liaskovitis <...> > + > +/** > + * DimmBus: DimmDevice > + * @start: starting physical address, where @DimmDevice is mapped. > + * @size: amount of memory mapped at @start. > + * @node: numa node to which @DimmDevic

Re: [Qemu-devel] [PATCH 1/1] cpu: Correct cpu-hotplug failure

2013-07-24 Thread chenfan
On Thu, 2013-07-25 at 14:27 +0800, Chen Fan wrote: > When useing x86_64-softmmu --enable-kvm boot qemu, cpu-add command fails to > add a vcpu, > there show (KVM: setting VAPIC address failed). > > The reason is that we use an uninitialized cpu->kvm-fd to ioctl. > so we move realizing apic to the

Re: [Qemu-devel] [PATCH 04/16] qapi: make visit_type_size fallback to type_int

2013-07-24 Thread Hu Tao
On Tue, Jul 23, 2013 at 06:23:00PM +0200, Igor Mammedov wrote: > From: Vasilis Liaskovitis > > Currently visit_type_size checks if the visitor's type_size function pointer > is > NULL. If not, it calls it, otherwise it calls v->type_uint64(). But neither of > these pointers are ever set. Fallbac

[Qemu-devel] [PATCH 1/1] cpu: Correct cpu-hotplug failure

2013-07-24 Thread Chen Fan
When useing x86_64-softmmu --enable-kvm boot qemu, cpu-add command fails to add a vcpu, there show (KVM: setting VAPIC address failed). The reason is that we use an uninitialized cpu->kvm-fd to ioctl. so we move realizing apic to the back of qemu_init_vcpu. Signed-off-by: Chen Fan --- include/

[Qemu-devel] windows guests: bad mouse responsiveness with gtk

2013-07-24 Thread Michael S. Tsirkin
I've recently tried experimenting with the gtk qemu frontend. Unfortunately with gtk, mouse seems very unresponsive: sometimes I move it and the pointer won't move, or it jumps around, or refuses to go to some parts of the screen. No issues if I supply -sdl. I don't know much about how mouse work

Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: Fix new typos in comments and strings

2013-07-24 Thread Michael Tokarev
24.07.2013 21:48, Stefan Weil wrote: > All these typos were found by codespell. > > sould -> should > emperical -> empirical > intialization -> initialization > successfuly -> successfully > gaurantee -> guarantee > > Fix also another error (before before) in the same context. Thanks, applied to

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: correct argument number for sys_mremap and sys_splice

2013-07-24 Thread Michael Tokarev
23.07.2013 21:33, Peter Maydell wrote: > On 23 July 2013 18:18, Michael Tokarev wrote: >> 23.07.2013 21:00, Petar Jovanovic wrote: >>> From: Petar Jovanovic >>> >>> sys_mremap missed 5th argument (new_address), which caused examples that >>> remap to a specific address to fail. >>> sys_splice mis

Re: [Qemu-devel] commit 08521e2 breaks SLOF usb boot

2013-07-24 Thread Nikunj A Dadhania
Paolo Bonzini writes: > Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto: >> Nikunj A Dadhania writes: >>> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546 >>> Author: Paolo Bonzini >>> Date: Fri May 24 12:54:01 2013 +0200 >>> >>> memory: add big endian support to access_with_adjusted_siz

Re: [Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target

2013-07-24 Thread Fam Zheng
On Tue, 07/23 11:52, Stefan Hajnoczi wrote: > On Wed, Jul 17, 2013 at 05:42:12PM +0800, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > block/backup.c | 3 ++- > > block/mirror.c | 4 ++-- > > 2 files changed, 4 insertions(+), 3 deletions(-) > > Should we update the blockjob.c in_use c

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-24 Thread Jan Kiszka
On 2013-07-25 07:47, Benjamin Herrenschmidt wrote: > On Thu, 2013-07-25 at 15:26 +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2013-07-22 at 10:34 -0500, Anthony Liguori wrote: >>> >>> Really nice series. I'd prefer we simply got rid of the endianness >>> flag >>> entirely but this is a good ste

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread Liu Yuan
On Thu, Jul 25, 2013 at 02:53:57PM +0900, MORITA Kazutaka wrote: > At Thu, 25 Jul 2013 13:25:33 +0800, > Liu Yuan wrote: > > > > Hello Kazutaka, > > > >I have two patches fixing the problems I found on my testing and they are > > complementary patches. Please consider sending them on top of y

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread MORITA Kazutaka
At Thu, 25 Jul 2013 13:25:33 +0800, Liu Yuan wrote: > > Hello Kazutaka, > >I have two patches fixing the problems I found on my testing and they are > complementary patches. Please consider sending them on top of your patch set. Thanks a lot for your comments and patches, but I've already pr

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-24 Thread Benjamin Herrenschmidt
On Thu, 2013-07-25 at 15:26 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2013-07-22 at 10:34 -0500, Anthony Liguori wrote: > > > > Really nice series. I'd prefer we simply got rid of the endianness > > flag > > entirely but this is a good step. > > > > Reviewed-by: Anthony Liguori > > Are yo

Re: [Qemu-devel] [PATCH v2 3/8] virtio: Add support for guest setting of queue size

2013-07-24 Thread Michael S. Tsirkin
On Fri, Jul 12, 2013 at 09:36:57PM +0100, Peter Maydell wrote: > The MMIO virtio transport spec allows the guest to tell the host how > large the queue size is. Add virtio_queue_set_num() function which > implements this in the QEMU common virtio support code. > > Signed-off-by: Peter Maydell Pr

Re: [Qemu-devel] vhost acceleration broken?

2013-07-24 Thread Rusty Russell
Anthony Liguori writes: > On Wed, Jul 24, 2013 at 8:55 PM, Rusty Russell wrote: >> Hi all, >> >> Using latest kernel and master qemu, the following doesn't use >> vhost acceleration: >> >> sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net >> tap,script=/home/rusty/bin/kvm-

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

2013-07-24 Thread Benjamin Herrenschmidt
On Mon, 2013-07-22 at 10:34 -0500, Anthony Liguori wrote: > > Really nice series. I'd prefer we simply got rid of the endianness > flag > entirely but this is a good step. > > Reviewed-by: Anthony Liguori Are you going to merge this ? Afaik (Alexey just told me), pretty much anything IO is br

Re: [Qemu-devel] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread Liu Yuan
Hello Kazutaka, I have two patches fixing the problems I found on my testing and they are complementary patches. Please consider sending them on top of your patch set. Thanks Yuan

[Qemu-devel] [PATCH 2/2] sheepdog: put aio request into failed list when failing to send request

2013-07-24 Thread Liu Yuan
qemu_co_send() in the add_aio_request might fail if connection is closed. In this case we should it requests into failed list to be resended later when connection is repaired. Signed-off-by: Liu Yuan --- block/sheepdog.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --gi

[Qemu-devel] [PATCH 1/2] sheepdog: correct signedness of comparison

2013-07-24 Thread Liu Yuan
When signed int compared to unsigned int, signed int will be converted to unsigned int. For example, (-1 < sizeof(structure)) always true because -1 in the left is converted into unsigned int, thus this restule in unexpected true. Signed-off-by: Liu Yuan --- block/sheepdog.c | 10 +-

Re: [Qemu-devel] vhost acceleration broken?

2013-07-24 Thread Michael S. Tsirkin
On Thu, Jul 25, 2013 at 11:25:20AM +0930, Rusty Russell wrote: > Hi all, > > Using latest kernel and master qemu, the following doesn't use > vhost acceleration: > > sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net > tap,script=/home/rusty/bin/kvm-ifup,downscript=no,vhost

[Qemu-devel] [Bug 1204697] [NEW] guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-07-24 Thread Christoph Anton Mitterer
Public bug reported: Hi. This is from http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717724. Using Debian sid with 1.5.0-5 my Linux VMs (also Debian sid) are broken. When they boot I get gazillions of ATA errors inside the guest, as well as: [ 242.479951] kvm [7790]: vcpu0 unhandled rdmsr: 0

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-07-24 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Unknown => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1204697 Title: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/

Re: [Qemu-devel] Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-24 Thread Alex Williamson
Reminder, there's one week left to submit proposals for the virtualization micro-conference at LPC. Please see below for details and note the update to submit proposals through the Linux Plumbers website: http://www.linuxplumbersconf.org/2013/ocw/events/LPC2013/proposals/new Thanks, Alex On Su

Re: [Qemu-devel] RFC [PATCH] Make bdrv_flush synchronous only and update callers

2013-07-24 Thread Wenchao Xia
I am glad to have an accurate sync bdrv_flush(). Code looks fine. Reviewed-by: Wenchao Xia > This patch makes bdrv_flush a synchronous function and updates any callers > from > a coroutine context to use bdrv_co_flush instead. > > The motivation for this patch comes from the GSoC Continuatio

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread Liu Yuan
On Wed, Jul 24, 2013 at 11:42:49PM +0800, Liu Yuan wrote: > On Wed, Jul 24, 2013 at 06:07:21PM +0900, MORITA Kazutaka wrote: > > At Wed, 24 Jul 2013 16:28:30 +0800, > > Liu Yuan wrote: > > > > > > On Wed, Jul 24, 2013 at 04:56:24PM +0900, MORITA Kazutaka wrote: > > > > Currently, if a sheepdog ser

Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd

2013-07-24 Thread Wenchao Xia
Besides the argument, I think it helps to probe snapshot without qemu-img convert, hope to get comments for the code. -- Best Regards Wenchao Xia

Re: [Qemu-devel] vhost acceleration broken?

2013-07-24 Thread Anthony Liguori
On Wed, Jul 24, 2013 at 8:55 PM, Rusty Russell wrote: > Hi all, > > Using latest kernel and master qemu, the following doesn't use > vhost acceleration: > > sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net > tap,script=/home/rusty/bin/kvm-ifup,downscript=no,vhost=on -net

[Qemu-devel] vhost acceleration broken?

2013-07-24 Thread Rusty Russell
Hi all, Using latest kernel and master qemu, the following doesn't use vhost acceleration: sudo qemu-system-x86_64 -machine pc,accel=kvm $ARGS -m 1024 -net tap,script=/home/rusty/bin/kvm-ifup,downscript=no,vhost=on -net nic,model=virtio -drive file=$QEMUIMAGE,index=0,media=disk,if=virti

Re: [Qemu-devel] [PATCH v2 08/11] block: simplify bdrv_drop_intermediate

2013-07-24 Thread Fam Zheng
On Wed, 07/24 19:16, Jeff Cody wrote: > On Wed, Jul 17, 2013 at 05:42:13PM +0800, Fam Zheng wrote: > > bdrv_drop_intermediate used a local list to iterate through backing > > chain and delete each BDS. It is simplified while adopting to refcount > > mechanism. > > > > Hi Fam, > > The reason for

Re: [Qemu-devel] [PATCH v3 05/14] loader: use file path size from fw_cfg.h

2013-07-24 Thread Andreas Färber
Am 24.07.2013 18:01, schrieb Michael S. Tsirkin: > Avoid a bit of code duplication, make > max file path constant reusable. > > Suggested-by: Laszlo Ersek > Signed-off-by: Michael S. Tsirkin Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germ

Re: [Qemu-devel] [PATCH qom-next] ide: Introduce abstract QOM type for PCIIDEState

2013-07-24 Thread Andreas Färber
Am 22.07.2013 17:58, schrieb Andreas Färber: > Needed for QOM casts. > > Signed-off-by: Andreas Färber > --- > hw/ide/cmd646.c | 62 > ++--- > hw/ide/pci.c| 30 +--- > hw/ide/pci.h| 8 +++- > hw/ide/piix.c

[Qemu-devel] [PATCH qom-next for-1.6 8/8] tcx: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/tcx.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 9fd48b5..24876d3 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -34,8 +34,12 @@ #define TCX_THC_NREGS_24 0x1000

[Qemu-devel] [PATCH qom-next for-1.6 6/8] pl110: Rename pl110_state to PL110State

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/pl110.c | 64 +++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/hw/display/pl110.c b/hw/display/pl110.c index 60afcf3..7c2cd36 100644 --- a/hw/display/pl110.c +++ b/hw/display/pl110.c

[Qemu-devel] [PATCH qom-next for-1.6 3/8] jazz_led: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/jazz_led.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c index 7f82037..8407e6c 100644 --- a/hw/display/jazz_led.c +++ b/hw/display/jazz_led.c @@ -32,8 +32,12 @@ typedef e

[Qemu-devel] [PATCH qom-next for-1.6 7/8] pl110: QOM'ify pl110, pl110_versatile and pl111

2013-07-24 Thread Andreas Färber
Let pl110_versatile and pl111 inherit from pl110 and use PL110() cast; set their version index in an instance_init. Signed-off-by: Andreas Färber --- hw/display/pl110.c | 71 ++ 1 file changed, 29 insertions(+), 42 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH qom-next for-1.6 4/8] milkymist-tmu2: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/milkymist-tmu2.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/display/milkymist-tmu2.c b/hw/display/milkymist-tmu2.c index efda082..b2a5fba 100644 --- a/hw/display/milkymist-tmu2.c +++ b/hw/display/milkymist-tmu2

[Qemu-devel] [PATCH qom-next for-1.6 1/8] exynos4210_fimd: QOM cast cleanup

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/exynos4210_fimd.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c index eb168ea..65cca1d 100644 --- a/hw/display/exynos4210_fimd.c +++ b/hw/display/exyn

[Qemu-devel] [PATCH qom-next for-1.6 0/8] display: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Hello, This series eliminates FROM_SYSBUS() in hw/display/. Regards, Andreas Cc: Hu Tao Andreas Färber (8): exynos4210_fimd: QOM cast cleanup g364fb: QOM cast cleanup jazz_led: QOM cast cleanups milkymist-tmu2: QOM cast cleanups milkymist-vgafb: QOM cast cleanups pl110: Rename pl11

[Qemu-devel] [PATCH qom-next for-1.6 2/8] g364fb: QOM cast cleanup

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/g364fb.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index 79a0a50..a24a882 100644 --- a/hw/display/g364fb.c +++ b/hw/display/g364fb.c @@ -493,26 +493,33 @@ st

[Qemu-devel] [PATCH qom-next for-1.6 5/8] milkymist-vgafb: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/display/milkymist-vgafb.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/display/milkymist-vgafb.c b/hw/display/milkymist-vgafb.c index 870b339..5150cb4 100644 --- a/hw/display/milkymist-vgafb.c +++ b/hw/display/milky

Re: [Qemu-devel] [PATCH v2 08/11] block: simplify bdrv_drop_intermediate

2013-07-24 Thread Jeff Cody
On Wed, Jul 17, 2013 at 05:42:13PM +0800, Fam Zheng wrote: > bdrv_drop_intermediate used a local list to iterate through backing > chain and delete each BDS. It is simplified while adopting to refcount > mechanism. > Hi Fam, The reason for the local list is to keep the BDS deletion transactional

Re: [Qemu-devel] [PATCH V7 09/13] monitor: support sub command in help

2013-07-24 Thread Eric Blake
On 07/19/2013 07:44 PM, Wenchao Xia wrote: > The old code in help_cmd() use global 'info_cmds' and treat it as a s/use/uses/; s/treat/treats/ > special case. Actually 'info_cmds' is an sub command group of 'mon_cmds', s/an sub/a sub/ > in order to avoid direct use of it, help_cmd() need to chan

[Qemu-devel] [PATCH qom-next for-1.6 2/2] arm11mpcore: QOM cast cleanups for mpcore_rirq_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index 31c9d5a..a786c62 100644 --- a/hw/cpu/arm11mpcore.c +++ b/hw/cpu/arm11mpcore.c @@ -161,11 +161,16 @@ st

[Qemu-devel] [PATCH qom-next for-1.6 1/2] arm11mpcore: QOM cast cleanups for ARM11MPCorePriveState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index 8eeb53e..31c9d5a 100644 --- a/hw/cpu/arm11mpcore.c +++ b/hw/cpu/arm11mpcore.c @@ -12,8 +12,13 @@

[Qemu-devel] [PATCH qom-next for-1.6 0/2] cpu: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Hello Peter, This series eliminates FROM_SYSBUS() in hw/cpu/. For QOM realize post-1.6 these devices will need cleanups similar to a9/a15; it even instantiates arm11mpcore_priv from the realview_mpcore device, similar to my Tegra2 SoC (although in the same file ;)). Regards, Andreas Cc: Peter M

[Qemu-devel] [PATCH qom-next for-1.6 02/14] escc: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/escc.c | 19 +++ include/hw/char/escc.h | 1 + 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/char/escc.c b/hw/char/escc.c index 4c42198..6397f6f 100644 --- a/hw/char/escc.c +++ b/hw/char/escc.c @@ -96,8 +96,11

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-24 Thread Ian Main
On Wed, Jul 24, 2013 at 02:32:53PM -0600, Eric Blake wrote: > On 07/24/2013 04:55 AM, Kevin Wolf wrote: > > > Unconditionally overriding format for NEW_IMAGE_MODE_EXISTING is > > definitely wrong. It's the user's choice which COW format to use for the > > backup image. There's no reason why it has

[Qemu-devel] [PATCH qom-next for-1.6 00/14] char: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Hello, This series eliminates FROM_SYSBUS() in hw/char/. Regards, Andreas Cc: Hu Tao Andreas Färber (14): cadence_uart: QOM'ify escc: QOM'ify etraxfs_ser: QOM'ify exynos4210_uart: QOM'ify grlib_apbuart: QOM'ify imx_serial: QOM'ify lm32_juart: Relocate and tidy header lm32_juart

[Qemu-devel] [PATCH qom-next for-1.6] empty_slot: QOM'ify

2013-07-24 Thread Andreas Färber
Introduce type constant and use QOM casts. Signed-off-by: Andreas Färber --- hw/core/empty_slot.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/core/empty_slot.c b/hw/core/empty_slot.c index e624991..612b109 100644 --- a/hw/core/empty_slot.c +++ b/hw/core/

[Qemu-devel] [PATCH qom-next for-1.6 14/14] xilinx_uartlite: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/xilinx_uartlite.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c index 929743c..b0d1d04 100644 --- a/hw/char/xilinx_uartlite.c +++ b/hw/char/xilinx_uartlite.c @@ -46,8

[Qemu-devel] [PATCH qom-next for-1.6 10/14] milkymist-uart: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/milkymist-uart.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c index 46deab2..2e4b5c5 100644 --- a/hw/char/milkymist-uart.c +++ b/hw/char/milkymist-uart.c @@ -52,8

[Qemu-devel] [PATCH qom-next for-1.6 08/14] lm32_juart: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/lm32_juart.c | 19 +++ hw/lm32/lm32.h | 5 ++--- include/hw/char/lm32_juart.h | 2 ++ 3 files changed, 15 insertions(+), 11 deletions(-) diff --git a/hw/char/lm32_juart.c b/hw/char/lm32_juart.c index 154511e..252fe

[Qemu-devel] [PATCH qom-next for-1.6 09/14] lm32_uart: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/lm32_uart.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/char/lm32_uart.c b/hw/char/lm32_uart.c index 37b38ba..85d7265 100644 --- a/hw/char/lm32_uart.c +++ b/hw/char/lm32_uart.c @@ -89,8 +89,12 @@ enum { MSR_DCD

[Qemu-devel] [PATCH qom-next for-1.6 06/14] imx_serial: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/imx_serial.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c index 69b9ed2..d5d21c9 100644 --- a/hw/char/imx_serial.c +++ b/hw/char/imx_serial.c @@ -43,8 +43,12 @@ do { prin

[Qemu-devel] [PATCH qom-next for-1.6 07/14] lm32_juart: Relocate and tidy header

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- MAINTAINERS| 1 + hw/char/lm32_juart.c | 2 +- include/hw/{lm32 => char}/lm32_juart.h | 6 +++--- target-lm32/op_helper.c| 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) rename include/hw/{lm3

[Qemu-devel] [PATCH qom-next for-1.6 04/14] exynos4210_uart: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/exynos4210_uart.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c index 855ce7a..eef23a0 100644 --- a/hw/char/exynos4210_uart.c +++ b/hw/char/exynos4210

[Qemu-devel] [PATCH qom-next for-1.6 13/14] xilinx_uartlite: Rename xlx_uartlite to XilinxUARTLite

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/xilinx_uartlite.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c index feca497..929743c 100644 --- a/hw/char/xilinx_uartlite.c +++ b/hw/char/xilinx_uartlite

[Qemu-devel] [PATCH qom-next for-1.6 03/14] etraxfs_ser: QOM'ify

2013-07-24 Thread Andreas Färber
Rename etrax_serial to ETRAXSerial, introduce type constant and use QOM casts. Signed-off-by: Andreas Färber --- hw/char/etraxfs_ser.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/hw/char/etraxfs_ser.c b/hw/char/etraxfs_ser.c index d

[Qemu-devel] [PATCH qom-next for-1.6 11/14] pl011: Rename pl011_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/pl011.c | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index ebec64f..e0f7071 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -10,7 +10,7 @

[Qemu-devel] [PATCH qom-next for-1.6 05/14] grlib_apbuart: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/grlib_apbuart.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/char/grlib_apbuart.c b/hw/char/grlib_apbuart.c index 82e1b95..35ef661 100644 --- a/hw/char/grlib_apbuart.c +++ b/hw/char/grlib_apbuart.c @@ -67,8 +67,13 @

[Qemu-devel] [PATCH qom-next for-1.6 12/14] pl011: QOM'ify pl011 and pl011_luminary

2013-07-24 Thread Andreas Färber
Let the Luminary variant inherit from the ARM one, overwriting its ID on instance_init. Introduce type constant and use QOM casts. Replace triplicated SysBusDevice initfn with QOM realizefn and instance_init. Signed-off-by: Andreas Färber --- hw/char/pl011.c | 62 +---

[Qemu-devel] [PATCH qom-next for-1.6 01/14] cadence_uart: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/cadence_uart.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c index 4d457f8..3c2e960 100644 --- a/hw/char/cadence_uart.c +++ b/hw/char/cadence_uart.c @@ -106,8 +106,12 @@ #

Re: [Qemu-devel] [libvirt] [PATCH] caps: use -device for primary video when qemu >=1.6

2013-07-24 Thread Eric Blake
[adding qemu-devel] On 07/24/2013 03:41 AM, Guannan Ren wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=981094 > The commit 0ad9025ef introduce qemu flag QEMU_CAPS_DEVICE_VIDEO_PRIMARY > for using -device VGA, -device cirrus-vga, -device vmware-svga and > -device qxl-vga. In use, for -device

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-24 Thread Eric Blake
On 07/24/2013 04:55 AM, Kevin Wolf wrote: > Unconditionally overriding format for NEW_IMAGE_MODE_EXISTING is > definitely wrong. It's the user's choice which COW format to use for the > backup image. There's no reason why it has to be the same format as the > image that is being backed up. > > Be

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-07-24 Thread Andreas Färber
Am 24.07.2013 18:53, schrieb Gleb Natapov: > What happens on upstream kernel > (works for me obviously :)). 3.10.x has been working fine for me on openSUSE 12.3. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 167

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-07-24 Thread Alexander Graf
On 07/24/2013 06:53 PM, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 06:26:41PM +0200, Alexander Graf wrote: before. Are you saying configuring BIOS memslot differently solves the problem? Git bisect pointed to the commit mentioned in this email. The following patch also gets me a working guest

Re: [Qemu-devel] [PATCH 6/9] PlatBus: Add serial-platbus device

2013-07-24 Thread Peter Maydell
On 24 July 2013 21:16, Scott Wood wrote: > Plus, it's nice to have debug output from early on, rather than having to > wait until PCI is up and running. It would be nice if the device tree had bindings for "you can find your emergency serial port here"... -- PMM

Re: [Qemu-devel] [PATCH 6/9] PlatBus: Add serial-platbus device

2013-07-24 Thread Scott Wood
On 07/22/2013 01:56:32 PM, Alexander Graf wrote: On 22.07.2013, at 20:26, Peter Maydell wrote: > On 22 July 2013 18:50, Alexander Graf wrote: >> We want to be able to spawn a serial console on the platform bus. Create >> a small platbus wrapper device very similar to the ISA one. > > Why no

[Qemu-devel] [PATCH 1/2] alpha-linux-user: Fix umount syscall numbers

2013-07-24 Thread Richard Henderson
It has been pointed out on LKML that the alpha umount syscall numbers are named wrong, and a patch to rectify that has been posted for 3.11. Glibc works around this by treating NR_umount as NR_umount2 if NR_oldumount exists. That's more complicated than we need in QEMU, given that we control linu

[Qemu-devel] [PATCH 2/2] mips-linux-user: Adjust names in mips_syscall_args

2013-07-24 Thread Richard Henderson
The name field of MIPS_SYS isn't actually used; it's just documentation. But adjust the umount entries to match mips/syscall_nr.h anyway. Signed-off-by: Richard Henderson --- linux-user/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/

Re: [Qemu-devel] [RFC] [PATCH] linux-user: implement m68k atomic syscalls

2013-07-24 Thread Richard Henderson
On 07/23/2013 09:10 PM, riku.voi...@linaro.org wrote: > +#ifdef TARGET_NR_atomic_cmpxchg_32 > +case TARGET_NR_atomic_cmpxchg_32: > +{ > +/* should use start_exclusive from main.c */ > +abi_ulong mem_value; > +if (get_user_u32(mem_value, arg6)) > +ret = -T

Re: [Qemu-devel] APM regression since v1.3.0-408-g9ee59f3

2013-07-24 Thread Sebastian Herbszt
Gerd Hoffmann wrote: On 07/03/13 22:25, Sebastian Herbszt wrote: Commit 9ee59f3 ("pc: remove bochs bios debug ports") broke the APM interface between QEMU and Bochs BIOS/SeaBIOS. Without APM support older guests are no longer able to power off the VM. This regression also affects older machine t

Re: [Qemu-devel] [libvirt] [PATCH 4/7] qemu: Add monitor APIs to fetch CPUID data from QEMU

2013-07-24 Thread Eduardo Habkost
On Wed, Jul 24, 2013 at 11:03:03AM +0100, Daniel P. Berrange wrote: > On Tue, Jul 23, 2013 at 07:28:38PM +0200, Jiri Denemark wrote: > > On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote: > > > On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote: > > > > --- > > > > src/qemu/

Re: [Qemu-devel] [libvirt] [PATCH 4/7] qemu: Add monitor APIs to fetch CPUID data from QEMU

2013-07-24 Thread Eduardo Habkost
On Tue, Jul 23, 2013 at 07:32:46PM +0200, Jiri Denemark wrote: > On Tue, Jul 23, 2013 at 19:28:38 +0200, Jiri Denemark wrote: > > On Tue, Jul 23, 2013 at 17:32:42 +0100, Daniel Berrange wrote: > > > On Tue, Jul 23, 2013 at 06:11:33PM +0200, Jiri Denemark wrote: > > > > --- > > > > src/qemu/qemu_mo

Re: [Qemu-devel] [libvirt] [PATCH 6/7] qemu: Probe QEMU binary for host CPU

2013-07-24 Thread Eduardo Habkost
On Tue, Jul 23, 2013 at 05:19:03PM +0100, Daniel P. Berrange wrote: > On Tue, Jul 23, 2013 at 06:11:35PM +0200, Jiri Denemark wrote: > > Since QEMU and kvm may filter some host CPU features or add efficiently > > emulated features, asking QEMU binary for host CPU data provides > > better results wh

Re: [Qemu-devel] [PATCH V6 2/3] Add tests for sync modes 'TOP' and 'NONE'

2013-07-24 Thread Ian Main
On Wed, Jul 24, 2013 at 01:19:18PM +0200, Kevin Wolf wrote: > Am 23.07.2013 um 00:09 hat Ian Main geschrieben: > > This patch adds tests for sync modes top and none. Also added are tests > > for invalid and missing formats. > > > > Signed-off-by: Ian Main > > --- > > tests/qemu-iotests/055

Re: [Qemu-devel] [PATCH] seccomp: add additional asynchronous I/O syscalls

2013-07-24 Thread Eduardo Otubo
On 07/23/2013 10:57 AM, Paul Moore wrote: On Monday, July 15, 2013 03:32:01 PM Paul Moore wrote: A previous commit, "seccomp: add the asynchronous I/O syscalls to the whitelist", added several asynchronous I/O syscalls but left out the io_submit() and io_cancel() syscalls. This patch corrects

Re: [Qemu-devel] [PATCH] seccomp: add arch_prctl() to the syscall whitelist

2013-07-24 Thread Eduardo Otubo
On 07/23/2013 10:57 AM, Paul Moore wrote: On Thursday, July 18, 2013 09:57:03 AM Paul Moore wrote: It appears that even a very simple /etc/qemu-ifup configuration can require the arch_prctl() syscall, see the example below: #!/bin/sh /sbin/ifconfig $1 0.0.0.0 up /usr/s

[Qemu-devel] [PATCH 9/9] block: vhdx write support

2013-07-24 Thread Jeff Cody
This adds support for writing to VHDX image files, using coroutines. Writes into the BAT table goes through the VHDX log. Currently, BAT table writes occur when expanding a dynamic VHDX file, and allocating a new BAT entry. Signed-off-by: Jeff Cody --- block/vhdx.c | 149 +++

[Qemu-devel] [PATCH 8/9] block: vhdx - add log write support

2013-07-24 Thread Jeff Cody
This adds support for writing to the VHDX log. For spec details, see VHDX Specification Format v1.00: https://www.microsoft.com/en-us/download/details.aspx?id=34750 There are a few limitations to this log support: 1.) There is no caching yet 2.) The log is flushed after each entry The primary wr

[Qemu-devel] [PATCH 7/9] block: vhdx - log parsing, replay, and flush support

2013-07-24 Thread Jeff Cody
This adds support for VHDX v0 logs, as specified in Microsoft's VHDX Specification Format v1.00: https://www.microsoft.com/en-us/download/details.aspx?id=34750 The following support is added: * Log parsing, and validation - validate that an existing log is correct. * Log search - search throug

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-24 Thread Ian Main
On Wed, Jul 24, 2013 at 12:55:43PM +0200, Kevin Wolf wrote: > Am 23.07.2013 um 00:09 hat Ian Main geschrieben: > > This patch adds sync-modes to the drive-backup interface and > > implements the FULL, NONE and TOP modes of synchronization. > > > > FULL performs as before copying the entire content

[Qemu-devel] [PATCH 3/9] block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to header.

2013-07-24 Thread Jeff Cody
In preparation for VHDX log support, move these structures to the header. Signed-off-by: Jeff Cody --- block/vhdx.c | 51 --- block/vhdx.h | 47 +++ 2 files changed, 47 insertions(+), 51 deletions(-) dif

[Qemu-devel] [PATCH 6/9] block: vhdx - update log guid in header, and first write tracker

2013-07-24 Thread Jeff Cody
Allow tracking of first file write in the VHDX image, as well as the ability to update the GUID in the header. This is in preparation for log support. Signed-off-by: Jeff Cody --- block/vhdx.c | 28 +++- block/vhdx.h | 7 +-- 2 files changed, 28 insertions(+), 7 del

[Qemu-devel] [PATCH 4/9] block: vhdx - log support struct and defines

2013-07-24 Thread Jeff Cody
This adds some magic number defines, and internal structure definitions for VHDX log replay support. Signed-off-by: Jeff Cody --- block/vhdx.h | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/block/vhdx.h b/block/vhdx.h index c8d8593..2db6615 100644 --- a

Re: [Qemu-devel] [PATCH] misc: Fix new typos in comments and strings

2013-07-24 Thread Peter Maydell
On 24 July 2013 18:48, Stefan Weil wrote: > All these typos were found by codespell. > > sould -> should > emperical -> empirical > intialization -> initialization > successfuly -> successfully > gaurantee -> guarantee > > Fix also another error (before before) in the same context. > > Signed-off-

[Qemu-devel] [PATCH 1/9] block: vhdx - minor comments and typo correction.

2013-07-24 Thread Jeff Cody
Just a couple of minor comments to help note where allocated buffers are freed, and a typo fix. Signed-off-by: Jeff Cody --- block/vhdx.c | 6 -- block/vhdx.h | 6 +++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index e9704b1..56bc88e 100644

[Qemu-devel] [PATCH 5/9] block: vhdx - break endian translation functions out

2013-07-24 Thread Jeff Cody
This moves the endian translation functions out from the vhdx.c source, into a separate source file. In addition to the previously defined endian functions, new endian translation functions for log support are added as well. Signed-off-by: Jeff Cody --- block/Makefile.objs | 2 +- block/vhdx-e

[Qemu-devel] [PATCH 0/9] VHDX log replay and write support

2013-07-24 Thread Jeff Cody
This patch series contains the initial VHDX log parsing, replay, and write support. This will allow an existing log in a VHDX image to be replayed (e.g., a VHDX image from a Hyper-V host that crashed). In addition, metadata writes are enabled through the log. This allows write support to be enab

[Qemu-devel] [PATCH 2/9] block: vhdx - add header update capability.

2013-07-24 Thread Jeff Cody
This adds the ability to update the headers in a VHDX image, including generating a new MS-compatible GUID. As VHDX depends on uuid.h, VHDX is now a configurable build option. If VHDX support is enabled, that will also enable uuid as well. The default is to have VHDX enabled. To enable/disable

[Qemu-devel] [PATCH] misc: Fix new typos in comments and strings

2013-07-24 Thread Stefan Weil
All these typos were found by codespell. sould -> should emperical -> empirical intialization -> initialization successfuly -> successfully gaurantee -> guarantee Fix also another error (before before) in the same context. Signed-off-by: Stefan Weil --- block/vhdx.h |2 +- do

Re: [Qemu-devel] [PATCH 0/2] vdso for x86_64-linux-user

2013-07-24 Thread Richard Henderson
On 07/24/2013 06:39 AM, Peter Maydell wrote: > On 24 July 2013 17:34, Richard Henderson wrote: >> On 07/23/2013 11:15 AM, Peter Maydell wrote: >>> On 23 July 2013 21:27, Richard Henderson wrote: This is a refresh of a patch I wrote in 2010, and have re-posted every 6 months thereafter.

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 06:26:41PM +0200, Alexander Graf wrote: > >before. Are you saying configuring BIOS memslot differently solves the > >problem? > > Git bisect pointed to the commit mentioned in this email. The > following patch also gets me a working guest again: > > diff --git a/kvm-all.c

[Qemu-devel] [PATCH v3 08/14] loader: allow adding ROMs in done callbacks

2013-07-24 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Signed-off-by: Michael S. Tsirkin --- hw/core/loader.c| 6 +- include/hw/loader.h | 1 + vl.c| 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index c2309e6..c68f757 1

[Qemu-devel] [PATCH v3 13/14] hpet: add API to find it

2013-07-24 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Signed-off-by: Michael S. Tsirkin --- hw/timer/hpet.c | 5 + include/hw/timer/hpet.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 648b383..11bf401 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -

[Qemu-devel] [PATCH v3 07/14] loader: support for unmapped ROM blobs

2013-07-24 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: let user pass in MR for memory serving as the backing store. Signed-off-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek --- hw/core/loader.c | 32 +--- hw/lm32/lm32_hwsetup.h | 2 +- include/hw/loader.h| 4

[Qemu-devel] [PATCH v3 05/14] loader: use file path size from fw_cfg.h

2013-07-24 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek Signed-off-by: Michael S. Tsirkin --- hw/core/loader.c | 2 +- include/hw/nvram/fw_cfg.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/core/loader.c b/hw/core

Re: [Qemu-devel] [PATCH 0/2] vdso for x86_64-linux-user

2013-07-24 Thread Peter Maydell
On 24 July 2013 17:34, Richard Henderson wrote: > On 07/23/2013 11:15 AM, Peter Maydell wrote: >> On 23 July 2013 21:27, Richard Henderson wrote: >>> This is a refresh of a patch I wrote in 2010, and have re-posted every >>> 6 months thereafter. To my knowledge, it has never been reviewed. >>> >

Re: [Qemu-devel] [PATCH 0/2] vdso for x86_64-linux-user

2013-07-24 Thread Richard Henderson
On 07/23/2013 11:15 AM, Peter Maydell wrote: > On 23 July 2013 21:27, Richard Henderson wrote: >> This is a refresh of a patch I wrote in 2010, and have re-posted every >> 6 months thereafter. To my knowledge, it has never been reviewed. >> >> It supplies a replacement for the required x86-64 vds

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-07-24 Thread Alexander Graf
On 07/24/2013 06:17 PM, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 05:31:14PM +0200, Alexander Graf wrote: On 07/24/2013 05:21 PM, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 05:16:09PM +0200, Paolo Bonzini wrote: Il 24/07/2013 11:58, Alexander Graf ha scritto: No QEMU or kvm crashes, no err

  1   2   3   >