Re: [Qemu-devel] [PATCH] hw/mips: align initrd to 64KB to avoid kernel error

2013-07-24 Thread Leon Alrae
ping On 10/07/13 16:01, Leon Alrae wrote: > ping > > http://patchwork.ozlabs.org/patch/255005/ > > On 27/06/13 08:35, Leon Alrae wrote: >> From: James Hogan >> >> The Linux kernel can be configured to use 64KB pages, but it also >> requires initrd to be page aligned. Therefore, to be safe, alig

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: correct argument number for sys_mremap and sys_splice

2013-07-24 Thread Petar Jovanovic
From: Peter Maydell [peter.mayd...@linaro.org] Sent: Tuesday, July 23, 2013 7:33 PM To: Michael Tokarev Cc: Petar Jovanovic; qemu-triv...@nongnu.org; riku.voi...@linaro.org; qemu-devel@nongnu.org; Petar Jovanovic Subject: Re: [Qemu-devel] [Qemu-trivial] [P

[Qemu-devel] [PATCH v3 00/14] qemu: generate acpi tables for the guest

2013-07-24 Thread Michael S. Tsirkin
This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi Please review, and consider for 1.6. Changes from v2 repost: - address comment by Anthony - convert to use APIs implemented using QOM - address comment by Anthony - avoid tricky pointer path, use GArray

[Qemu-devel] [PATCH v3 03/14] acpi: add rules to compile ASL source

2013-07-24 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Note: distros are known to silently update iasl so detect correct iasl flags for the installed version on each run as opposed to at configure tim

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 05:31:14PM +0200, Alexander Graf wrote: > On 07/24/2013 05:21 PM, Gleb Natapov wrote: > >On Wed, Jul 24, 2013 at 05:16:09PM +0200, Paolo Bonzini wrote: > >>Il 24/07/2013 11:58, Alexander Graf ha scritto: > >No QEMU or kvm crashes, no error message printed, I mean it just

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2013 at 04:52:05PM +0200, Andreas Färber wrote: > Hi Gerd, > > Am 24.07.2013 16:42, schrieb Gerd Hoffmann: > >>> This does not satisfy the "should use QOM properties" requirement that > >>> we discussed in the RFC thread. > >> > >> I don't know which part of the RFC thread still ap

[Qemu-devel] [PATCH v3 01/14] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h

2013-07-24 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin Signed-off-by: Laszlo Ersek --- hw/i386/pc.c | 2 -- include/hw/i386/apic.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2a87563..b0b98a8 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -75,8

[Qemu-devel] [PATCH v3 14/14] i386: ACPI table generation code from seabios

2013-07-24 Thread Michael S. Tsirkin
This adds C code for generating ACPI tables at runtime, imported from seabios git tree commit 51684b7ced75fb76776e8ee84833fcfb6ecf12dd Although ACPI tables come from a system BIOS on real hw, it makes sense that the ACPI tables are coupled with the virtual machine, since they have to abstract

[Qemu-devel] [PATCH v3 12/14] pvpanic: add API to access io port

2013-07-24 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Signed-off-by: Michael S. Tsirkin --- hw/misc/pvpanic.c| 11 +++ include/hw/i386/pc.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index

[Qemu-devel] [PATCH v3 10/14] ich9: APIs for pc guest info

2013-07-24 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest info table, implemented using QOM, to various ich9 components. Signed-off-by: Michael S. Tsirkin --- hw/acpi/ich9.c| 6 ++ hw/isa/lpc_ich9.c | 19 +++ hw/pci-host/q35.c | 10 ++ include/hw/

[Qemu-devel] [PATCH v3 09/14] i386: define pc guest info

2013-07-24 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in guest info table. This structure will be filled in in follow-up patches, using QOM. Fill in NUMA node info is not available in QOM so it is filled in directly. Signed-off-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek --- hw/i386/pc.c

[Qemu-devel] [PATCH v3 11/14] piix: APIs for pc guest info

2013-07-24 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest info table, implemented using QOM, to various piix components. Signed-off-by: Michael S. Tsirkin --- hw/acpi/piix4.c | 29 +++-- hw/mips/mips_malta.c| 2 +- hw/pci-host/piix.c | 8 include/hw/i3

[Qemu-devel] [PATCH v3 06/14] i386: add bios linker/loader

2013-07-24 Thread Michael S. Tsirkin
This adds a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory segment - link tables to each other - fix up checksums after said linking Signed-off-by: Michael S. Tsirkin --- hw/i386/Makefile.objs

Re: [Qemu-devel] [PATCH] savevm: set right return value for qemu_file_rate_limit

2013-07-24 Thread Lei Li
In the logic of ram_save_iterate(), it checks the ret of qemu_file_rate_limit(f) by ret < 0 if there has been an error. But now it will never return negative value because qemu_file_rate_limit() return 1 if qemu_file_get_error(). Also the original implementation of qemu_file_rate_limit() as func

Re: [Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-24 Thread Daniel P. Berrange
On Wed, Jul 24, 2013 at 05:40:14PM +0200, Paolo Bonzini wrote: > Il 24/07/2013 17:33, Daniel P. Berrange ha scritto: > >>> One reason that QCow2 is bad, despite using a standard algorithm, is > >>> that the user passphrase is directly used encrypt/decrypt the data. > >>> Thus a weak passphrase lead

Re: [Qemu-devel] [PATCH v2 repost 8/9] i386: generate pc guest info

2013-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2013 at 05:36:58PM +0200, Laszlo Ersek wrote: > On 07/17/13 17:07, Laszlo Ersek wrote: > > On 07/10/13 15:51, Michael S. Tsirkin wrote: > >> This fills in guest info table with misc > >> information of interest to the guest. > >> Will be used by ACPI table generation code. > >> > >>

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread Liu Yuan
On Wed, Jul 24, 2013 at 06:07:21PM +0900, MORITA Kazutaka wrote: > At Wed, 24 Jul 2013 16:28:30 +0800, > Liu Yuan wrote: > > > > On Wed, Jul 24, 2013 at 04:56:24PM +0900, MORITA Kazutaka wrote: > > > Currently, if a sheepdog server exits, all the connecting VMs need to > > > be restarted. This se

Re: [Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 17:33, Daniel P. Berrange ha scritto: >>> One reason that QCow2 is bad, despite using a standard algorithm, is >>> that the user passphrase is directly used encrypt/decrypt the data. >>> Thus a weak passphrase leads to weak data encryption. With the LUKS >>> format, the passphrase is

Re: [Qemu-devel] [PATCH v2 repost 8/9] i386: generate pc guest info

2013-07-24 Thread Laszlo Ersek
On 07/17/13 17:07, Laszlo Ersek wrote: > On 07/10/13 15:51, Michael S. Tsirkin wrote: >> This fills in guest info table with misc >> information of interest to the guest. >> Will be used by ACPI table generation code. >> >> Signed-off-by: Michael S. Tsirkin >> --- >> hw/acpi/ich9.c | 7 +

Re: [Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-24 Thread Daniel P. Berrange
On Wed, Jul 24, 2013 at 05:30:22PM +0200, Paolo Bonzini wrote: > Il 23/07/2013 17:57, Daniel P. Berrange ha scritto: > > On Tue, Jul 23, 2013 at 05:38:00PM +0200, Kevin Wolf wrote: > >> Am 23.07.2013 um 17:22 hat Stefan Hajnoczi geschrieben: > >>> On Tue, Jul 23, 2013 at 04:40:34PM +0200, Benoît Ca

Re: [Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-24 Thread Paolo Bonzini
Il 23/07/2013 17:57, Daniel P. Berrange ha scritto: > On Tue, Jul 23, 2013 at 05:38:00PM +0200, Kevin Wolf wrote: >> Am 23.07.2013 um 17:22 hat Stefan Hajnoczi geschrieben: >>> On Tue, Jul 23, 2013 at 04:40:34PM +0200, Benoît Canet wrote: > More generally, QCow2's current encryption support is

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-07-24 Thread Alexander Graf
On 07/24/2013 05:21 PM, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 05:16:09PM +0200, Paolo Bonzini wrote: Il 24/07/2013 11:58, Alexander Graf ha scritto: No QEMU or kvm crashes, no error message printed, I mean it just hangs, even no BIOS information are printed. And "top" shows QEMU consumes

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 05:16:09PM +0200, Paolo Bonzini wrote: > Il 24/07/2013 11:58, Alexander Graf ha scritto: > >> > No QEMU or kvm crashes, no error message printed, I mean it just hangs, > >> > even no BIOS information are printed. > >> > And "top" shows QEMU consumes 100% cpu. > >> > > >> >

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2013 at 04:42:08PM +0200, Gerd Hoffmann wrote: > Hi, > > >> This does not satisfy the "should use QOM properties" requirement that > >> we discussed in the RFC thread. > > > > I don't know which part of the RFC thread still applied and > > which doesn't: at that point you were r

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 11:58, Alexander Graf ha scritto: >> > No QEMU or kvm crashes, no error message printed, I mean it just hangs, >> > even no BIOS information are printed. >> > And "top" shows QEMU consumes 100% cpu. >> > >> > When I define DEBUG_KVM in kvm-all.c, and run QEMU(this time I boot a >>

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 17:09, Andreas Färber ha scritto: > Hi, > > Am 24.07.2013 17:04, schrieb Gerd Hoffmann: /me suggests to check out qmp_qom_get() in qmp.c. Some qom aequivalent for qdev_find_recursive would be handy, dunno whenever such a thing exists already, Andreas? >>> >>> Not sure

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Andreas Färber
Hi, Am 24.07.2013 17:04, schrieb Gerd Hoffmann: >>> /me suggests to check out qmp_qom_get() in qmp.c. Some qom aequivalent >>> for qdev_find_recursive would be handy, dunno whenever such a thing >>> exists already, Andreas? >> >> Not sure what's needed here? object_resolve_path() and >> object_fo

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Gerd Hoffmann
Hi, >> /me suggests to check out qmp_qom_get() in qmp.c. Some qom aequivalent >> for qdev_find_recursive would be handy, dunno whenever such a thing >> exists already, Andreas? > > Not sure what's needed here? object_resolve_path() and > object_foreach_child() come to mind... object_resolve_p

Re: [Qemu-devel] [PATCH] kvm: migrate vPMU state

2013-07-24 Thread Andreas Färber
Am 24.07.2013 16:37, schrieb Paolo Bonzini: > This requires kernel 3.10 but it is otherwise quite simple to do. > The kernel pays attention to MSRs writes that are host initiated, and > disables all side effects of the PMU registers (e.g. the global status > MSR can be written and global overflow c

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Andreas Färber
Hi Gerd, Am 24.07.2013 16:42, schrieb Gerd Hoffmann: >>> This does not satisfy the "should use QOM properties" requirement that >>> we discussed in the RFC thread. >> >> I don't know which part of the RFC thread still applied and >> which doesn't: at that point you were rejecting the whole >> appr

[Qemu-devel] [PATCHv2a] [RFC 8/7 (really)] Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack

2013-07-24 Thread Alex Bligh
Where supported, called prctl(PR_SET_TIMERSLACK, 1, ...) to set one nanosecond timer slack to increase precision of timer calls. Signed-off-by: Alex Bligh --- [ Additional patch on the the end of the PATCHv2 series - I'll resend if I have further comments with this reordered so it's next to the p

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-24 Thread Gerd Hoffmann
Hi, >> This does not satisfy the "should use QOM properties" requirement that >> we discussed in the RFC thread. > > I don't know which part of the RFC thread still applied and > which doesn't: at that point you were rejecting the whole > approach. > > I found a mail where you said: > I'

[Qemu-devel] [PATCH] kvm: migrate vPMU state

2013-07-24 Thread Paolo Bonzini
This requires kernel 3.10 but it is otherwise quite simple to do. The kernel pays attention to MSRs writes that are host initiated, and disables all side effects of the PMU registers (e.g. the global status MSR can be written and global overflow control MSR does not clear bits in the global status

Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default

2013-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2013 at 03:18:01PM +0200, Paolo Bonzini wrote: > Il 24/07/2013 15:14, Michael S. Tsirkin ha scritto: > > On Wed, Jul 24, 2013 at 02:59:18PM +0200, Paolo Bonzini wrote: > >> Il 24/07/2013 11:51, Michael S. Tsirkin ha scritto: > Current seabios uses a slightly different approach:

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 0/5] trivial patches for 2013-07-19

2013-07-24 Thread Ed Maste
On 24 July 2013 09:32, Anthony Liguori wrote: > Ed Maste writes: > >> On 19 July 2013 05:11, Michael Tokarev wrote: >>> This is another trivial-patches pull request. This time >>> we have just 5 patches accumulated in two (!) weeks period. >>> Please consider apply. >> ... >>> Michael Tokarev (

[Qemu-devel] [PATCH] seabios: update to 1.7.3

2013-07-24 Thread Gerd Hoffmann
Changes summary (git shortlog rel-1.7.2.2..rel-1.7.3): Alex Williamson (4): seabios q35: Enable all PIRQn IRQs at startup seabios q35: Add new PCI slot to irq routing function seabios: Add a dummy PCI slot to irq mapping function pciinit: Enable default VGA device Asias He

[Qemu-devel] [PULL] seabios: update to 1.7.3

2013-07-24 Thread Gerd Hoffmann
Hi, We have a new seabios release. please pull, Gerd The following changes since commit f03d07d4683b2e8325a7cb60b4e14b977b1a869c: Merge remote-tracking branch 'quintela/migration.next' into staging (2013-07-23 10:57:23 -0500) are available in the git repository at: git://git.kraxel.

Re: [Qemu-devel] [qom-cpu PATCH 2/2] i386: disable PMU passthrough mode by default

2013-07-24 Thread Eduardo Habkost
On Wed, Jul 24, 2013 at 03:21:48PM +0200, Paolo Bonzini wrote: > Il 24/07/2013 15:15, Eduardo Habkost ha scritto: > > On Tue, Jul 23, 2013 at 09:43:06PM +0200, Paolo Bonzini wrote: > >> Il 23/07/2013 19:41, Eduardo Habkost ha scritto: > >>> On Tue, Jul 23, 2013 at 06:23:08PM +0200, Paolo Bonzini wr

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 0/5] trivial patches for 2013-07-19

2013-07-24 Thread Anthony Liguori
Ed Maste writes: > On 19 July 2013 05:11, Michael Tokarev wrote: >> This is another trivial-patches pull request. This time >> we have just 5 patches accumulated in two (!) weeks period. >> Please consider apply. > ... >> Michael Tokarev (2): >> slirp: remove mbuf(m_hdr,m_dat) indirection

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 0/5] trivial patches for 2013-07-19

2013-07-24 Thread Andreas Färber
Am 24.07.2013 14:24, schrieb Ed Maste: > On 19 July 2013 05:11, Michael Tokarev wrote: >> This is another trivial-patches pull request. This time >> we have just 5 patches accumulated in two (!) weeks period. >> Please consider apply. > ... >> Michael Tokarev (2): >> slirp: remove mbuf(m_hd

Re: [Qemu-devel] [PATCH V7 00/13] monitor: support sub command group in auto completion and help

2013-07-24 Thread Wenchao Xia
于 2013-7-20 9:44, Wenchao Xia 写道: > This series make auto completion and help functions works normal for sub > command, by using reentrant functions. In order to do that, global variables > are not directly used in those functions any more. With this series, cmd_table > is a member of structure Mon

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 2/5] slirp: remove mbuf(m_hdr, m_dat) indirection

2013-07-24 Thread Ed Maste
On 19 July 2013 05:11, Michael Tokarev wrote: > --- > slirp/mbuf.h | 51 ++- > slirp/tcp_subr.c | 12 ++-- > 2 files changed, 24 insertions(+), 39 deletions(-) Tested-by: Ed Maste

Re: [Qemu-devel] [qom-cpu PATCH 2/2] i386: disable PMU passthrough mode by default

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 15:15, Eduardo Habkost ha scritto: > On Tue, Jul 23, 2013 at 09:43:06PM +0200, Paolo Bonzini wrote: >> Il 23/07/2013 19:41, Eduardo Habkost ha scritto: >>> On Tue, Jul 23, 2013 at 06:23:08PM +0200, Paolo Bonzini wrote: Il 23/07/2013 17:40, Eduardo Habkost ha scritto: > On Tue

Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 15:14, Michael S. Tsirkin ha scritto: > On Wed, Jul 24, 2013 at 02:59:18PM +0200, Paolo Bonzini wrote: >> Il 24/07/2013 11:51, Michael S. Tsirkin ha scritto: Current seabios uses a slightly different approach: the 64bit hole is present only in case it is actually used to map

Re: [Qemu-devel] [qom-cpu PATCH 2/2] i386: disable PMU passthrough mode by default

2013-07-24 Thread Eduardo Habkost
On Tue, Jul 23, 2013 at 09:43:06PM +0200, Paolo Bonzini wrote: > Il 23/07/2013 19:41, Eduardo Habkost ha scritto: > > On Tue, Jul 23, 2013 at 06:23:08PM +0200, Paolo Bonzini wrote: > >> Il 23/07/2013 17:40, Eduardo Habkost ha scritto: > >>> On Tue, Jul 23, 2013 at 05:09:02PM +0200, Paolo Bonzini wr

Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default

2013-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2013 at 02:59:18PM +0200, Paolo Bonzini wrote: > Il 24/07/2013 11:51, Michael S. Tsirkin ha scritto: > > > Current seabios uses a slightly different approach: the 64bit hole is > > > present only in case it is actually used to map bars there, and seabios > > > tries to fit everythin

Re: [Qemu-devel] [PULL trivial 2/5] slirp: remove mbuf(m_hdr, m_dat) indirection

2013-07-24 Thread Michael Tokarev
24.07.2013 16:44, Andreas Färber wrote: > Am 19.07.2013 11:11, schrieb Michael Tokarev: >> --- > > NACK, this commit in the pull request is lacking Signed-off-bys! > > The original patch (attachment in reply to "slirp: reorder include to > fix FreeBSD build failure") had a misspelled "Signed-off-

Re: [Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-24 Thread Benoît Canet
> There are two ways I could see it happening. Either integrate directly > into the qcow2 file format, by mapping LUKS headers & key material > blocks into the qcow2 header region in some manner. > > Alternatively do it in a completely generic block driver, that qcow2 > (or any other qemu bdrv) ca

Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default

2013-07-24 Thread Gerd Hoffmann
On 07/24/13 11:51, Michael S. Tsirkin wrote: > On Wed, Jul 24, 2013 at 09:01:51AM +0200, Gerd Hoffmann wrote: >> On 07/24/13 08:01, Michael S. Tsirkin wrote: >>> It turns out that some 32 bit windows guests crash >>> if 64 bit PCI hole size is >2G. >> >> Ah, *that* is the reason for winxp crashing

Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 11:51, Michael S. Tsirkin ha scritto: > > Current seabios uses a slightly different approach: the 64bit hole is > > present only in case it is actually used to map bars there, and seabios > > tries to fit everything into the 32bit hole first. > > Yes. But this doesn't work with devic

Re: [Qemu-devel] [PATCH v3 0/2] Fix real mode guest live migration

2013-07-24 Thread Paolo Bonzini
Il 22/07/2013 19:29, Orit Wasserman ha scritto: > Older KVM versions save CS dpl value to an invalid value for real mode guests > (0x3). This caused migration to fail from older KVM on host without > unrestricted guest to hosts with restricted guest support with "kvm: > unhandled exit 8021".

Re: [Qemu-devel] [PATCH] RFC v2: hcd-ohci: add dma error handling

2013-07-24 Thread Gerd Hoffmann
> +/** A typical O/EHCI will stop operating, set itself into error state > + * (which can be queried by MMIO) and will set PERR in its config > + * space to signal that it got an error > + */ > +static void ohci_stop(OHCIState *ohci) > +{ > +OHCIPCIState *dev = container_of(ohci, OHCIPCIState,

[Qemu-devel] [ANNOUNCE] Key Signing Party at KVM Forum 2013

2013-07-24 Thread Anthony Liguori
I will be hosting a key signing party at this year's KVM Forum. http://wiki.qemu.org/KeySigningParty2013 Starting for the 1.7 release (begins in December), I will only accepted signed pull requests so please try to attend this event or make alternative arrangements to have someone sign your key

Re: [Qemu-devel] [PULL trivial 2/5] slirp: remove mbuf(m_hdr, m_dat) indirection

2013-07-24 Thread Andreas Färber
Am 19.07.2013 11:11, schrieb Michael Tokarev: > --- NACK, this commit in the pull request is lacking Signed-off-bys! The original patch (attachment in reply to "slirp: reorder include to fix FreeBSD build failure") had a misspelled "Signed-off-By" from mjt. Michael, can you please re-add that and

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 13:34, Igor Mammedov ha scritto: > On Wed, 24 Jul 2013 11:41:04 +0200 > Paolo Bonzini wrote: > >> Il 24/07/2013 10:36, Igor Mammedov ha scritto: >>> On Tue, 23 Jul 2013 19:09:26 +0200 >>> Paolo Bonzini wrote: >>> Il 23/07/2013 18:23, Igor Mammedov ha scritto: > - if slot p

Re: [Qemu-devel] [Qemu-trivial] [PULL trivial 0/5] trivial patches for 2013-07-19

2013-07-24 Thread Ed Maste
On 19 July 2013 05:11, Michael Tokarev wrote: > This is another trivial-patches pull request. This time > we have just 5 patches accumulated in two (!) weeks period. > Please consider apply. ... > Michael Tokarev (2): > slirp: remove mbuf(m_hdr,m_dat) indirection Any idea when this might g

[Qemu-devel] qemu git (f03d07d46) / e100 / sending large packets causes SIGABRT

2013-07-24 Thread Oleksii Shevchuk
1. qemu-kvm -sdl -nodefaults -name NP1-C1 \ -uuid b71057e9-5705-420b-a780-52339afa6ed9\ -boot c \ -hda np1UD.disk \ -hdb fat:exchang

Re: [Qemu-devel] [PATCH v3] spapr-vscsi: add task management

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 10:29, Alexey Kardashevskiy ha scritto: > At the moment the guest kernel issues two types of task management > requests to the hypervisor - task about and lun reset. This adds > handling for these tasks. As spapr-vscsi starts calling scsi_req_cancel(), > free_request callback was impl

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-07-24 Thread Igor Mammedov
On Wed, 24 Jul 2013 11:41:04 +0200 Paolo Bonzini wrote: > Il 24/07/2013 10:36, Igor Mammedov ha scritto: > > On Tue, 23 Jul 2013 19:09:26 +0200 > > Paolo Bonzini wrote: > > > >> Il 23/07/2013 18:23, Igor Mammedov ha scritto: > >>> - if slot property is not specified on -device/device_add comman

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 10:37, Alex Bligh ha scritto: > > > --On 24 July 2013 09:01:22 +0100 Alex Bligh wrote: > Most 'reasonable' POSIX compliant operating systems have ppoll >>> >>> Really? I could find no manpages for any of Solaris and *BSD. >> >> OK I shall (re)research that then! I suppose se

Re: [Qemu-devel] [PATCH V6 3/3] Add backing drive while performing backup.

2013-07-24 Thread Kevin Wolf
Am 23.07.2013 um 00:09 hat Ian Main geschrieben: > This patch adds the original source drive as a backing drive to our target > image so that the target image will appear complete during backup. This > is especially useful for SYNC_MODE_NONE as it allows export via NBD to > have a complete point-i

Re: [Qemu-devel] [PATCH V6 2/3] Add tests for sync modes 'TOP' and 'NONE'

2013-07-24 Thread Kevin Wolf
Am 23.07.2013 um 00:09 hat Ian Main geschrieben: > This patch adds tests for sync modes top and none. Also added are tests > for invalid and missing formats. > > Signed-off-by: Ian Main > --- > tests/qemu-iotests/055| 108 > +- > tests/qemu-iotes

Re: [Qemu-devel] [PATCH 00/16 RFC v6] ACPI memory hotplug

2013-07-24 Thread Vasilis Liaskovitis
On Wed, Jul 24, 2013 at 12:02:46PM +0200, Igor Mammedov wrote: > On Wed, 24 Jul 2013 17:52:50 +0800 > Hu Tao wrote: > > > v6 doesn't work here, things are going fine until online hotplugged > > memory in guest. > > > > steps: > > > > 1. qemu cmd: > > > > ./x86_64-softmmu/qemu-system-x86_64 -

Re: [Qemu-devel] [PATCH V6 1/3] Implement sync modes for drive-backup.

2013-07-24 Thread Kevin Wolf
Am 23.07.2013 um 00:09 hat Ian Main geschrieben: > This patch adds sync-modes to the drive-backup interface and > implements the FULL, NONE and TOP modes of synchronization. > > FULL performs as before copying the entire contents of the drive > while preserving the point-in-time using CoW. > NONE

Re: [Qemu-devel] [PATCH] Citrix PV Bus device

2013-07-24 Thread Gerd Hoffmann
On 07/02/13 16:03, Paul Durrant wrote: > This patch introduces a new PCI device which will act as the binding point > for Citrix branded PV drivers for Xen. > The intention is that Citrix Windows PV drivers will be available on Windows > Update and thus using the existing Xen platform PCI device as

Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default

2013-07-24 Thread Igor Mammedov
On Wed, 24 Jul 2013 12:51:16 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jul 24, 2013 at 09:01:51AM +0200, Gerd Hoffmann wrote: > > On 07/24/13 08:01, Michael S. Tsirkin wrote: > > > It turns out that some 32 bit windows guests crash > > > if 64 bit PCI hole size is >2G. > > > > Ah, *that* is th

Re: [Qemu-devel] [PATCH 00/16 RFC v6] ACPI memory hotplug

2013-07-24 Thread Igor Mammedov
On Wed, 24 Jul 2013 17:52:50 +0800 Hu Tao wrote: > v6 doesn't work here, things are going fine until online hotplugged > memory in guest. > > steps: > > 1. qemu cmd: > > ./x86_64-softmmu/qemu-system-x86_64 -enable-kvm -m 512,maxmem=2G,slots=1 \ > -hda /mnt/data/libvirt-images/hut-rhel6.3.i

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-07-24 Thread Alexander Graf
On 05.06.2013, at 04:44, Dunrong Huang wrote: > > > On Wed, Jun 5, 2013 at 1:03 AM, Jordan Justen wrote: > On Tue, Jun 4, 2013 at 1:26 AM, Dunrong Huang wrote: > > On Tue, Jun 4, 2013 at 3:51 PM, Gleb Natapov wrote: > >> On Tue, Jun 04, 2013 at 03:47:47PM +0800, Dunrong Huang wrote: > >> > O

Re: [Qemu-devel] [PATCH 00/16 RFC v6] ACPI memory hotplug

2013-07-24 Thread Hu Tao
v6 doesn't work here, things are going fine until online hotplugged memory in guest. steps: 1. qemu cmd: ./x86_64-softmmu/qemu-system-x86_64 -enable-kvm -m 512,maxmem=2G,slots=1 \ -hda /mnt/data/libvirt-images/hut-rhel6.3.img -L ../pc-bios-memhp/ (bios is from MST's acpi tree) 2. hot-plu

Re: [Qemu-devel] [PATCH] RFC v2: hcd-ohci: add dma error handling

2013-07-24 Thread Alexey Kardashevskiy
On 07/24/2013 07:05 PM, Benjamin Herrenschmidt wrote: > On Wed, 2013-07-24 at 18:28 +1000, Alexey Kardashevskiy wrote: >> 1. if a physical device once reported UnrecoverableError, what is it >> expected to be able to do after that? Should ohci_hcd module reloading bring >> it back to life? With thi

Re: [Qemu-devel] [PATCH] pc: limit 64 bit hole to 2G by default

2013-07-24 Thread Michael S. Tsirkin
On Wed, Jul 24, 2013 at 09:01:51AM +0200, Gerd Hoffmann wrote: > On 07/24/13 08:01, Michael S. Tsirkin wrote: > > It turns out that some 32 bit windows guests crash > > if 64 bit PCI hole size is >2G. > > Ah, *that* is the reason for winxp crashing with a 64bit hole. > > Current seabios uses a sl

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 10:36, Igor Mammedov ha scritto: > On Tue, 23 Jul 2013 19:09:26 +0200 > Paolo Bonzini wrote: > >> Il 23/07/2013 18:23, Igor Mammedov ha scritto: >>> - if slot property is not specified on -device/device_add command, >>> treat default value as request for assigning DimmDevice to >>>

Re: [Qemu-devel] [PATCH 03/16] vl: convert -m to qemu_opts_parse()

2013-07-24 Thread Igor Mammedov
On Wed, 24 Jul 2013 11:04:14 +0200 Paolo Bonzini wrote: > Il 24/07/2013 10:40, Igor Mammedov ha scritto: > > On Tue, 23 Jul 2013 19:11:31 +0200 > > Paolo Bonzini wrote: > > > >> Il 23/07/2013 18:22, Igor Mammedov ha scritto: > >>> Signed-off-by: Igor Mammedov > >>> --- > >>> qemu-options.hx |

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread MORITA Kazutaka
At Wed, 24 Jul 2013 16:28:30 +0800, Liu Yuan wrote: > > On Wed, Jul 24, 2013 at 04:56:24PM +0900, MORITA Kazutaka wrote: > > Currently, if a sheepdog server exits, all the connecting VMs need to > > be restarted. This series implements a feature to reconnect the > > server, and enables us to do o

Re: [Qemu-devel] [PATCH 03/16] vl: convert -m to qemu_opts_parse()

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 10:40, Igor Mammedov ha scritto: > On Tue, 23 Jul 2013 19:11:31 +0200 > Paolo Bonzini wrote: > >> Il 23/07/2013 18:22, Igor Mammedov ha scritto: >>> Signed-off-by: Igor Mammedov >>> --- >>> qemu-options.hx |9 +++-- >>> vl.c| 53 >>> +

Re: [Qemu-devel] [PATCH] RFC v2: hcd-ohci: add dma error handling

2013-07-24 Thread Benjamin Herrenschmidt
On Wed, 2013-07-24 at 18:28 +1000, Alexey Kardashevskiy wrote: > 1. if a physical device once reported UnrecoverableError, what is it > expected to be able to do after that? Should ohci_hcd module reloading bring > it back to life? With this patch, OHCI dies till reboot (but at least it does > not

[Qemu-devel] [PATCH qom-next for-1.6] onenand: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/block/onenand.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/hw/block/onenand.c b/hw/block/onenand.c index 2776f64..aae9ee7 100644 --- a/hw/block/onenand.c +++ b/hw/block/onenand.c @@ -34,8 +34,12 @@ /*

Re: [Qemu-devel] [PATCH 03/16] vl: convert -m to qemu_opts_parse()

2013-07-24 Thread Igor Mammedov
On Tue, 23 Jul 2013 19:11:31 +0200 Paolo Bonzini wrote: > Il 23/07/2013 18:22, Igor Mammedov ha scritto: > > Signed-off-by: Igor Mammedov > > --- > > qemu-options.hx |9 +++-- > > vl.c| 53 > > +++-- > > 2 files changed, 54

[Qemu-devel] [PATCH qom-next for-1.6 25/29] strongarm: QOM'ify StrongARMGPIOInfo

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/strongarm.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index 78211a0..efb56b3 100644 --- a/hw/arm/strongarm.c +++ b/hw/arm/strongarm.c @@ -464,6 +464,10 @@ static

[Qemu-devel] [PATCH qom-next for-1.6 3/4] milkymist-ac97: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/audio/milkymist-ac97.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/audio/milkymist-ac97.c b/hw/audio/milkymist-ac97.c index 133de4e..9c0f7a0 100644 --- a/hw/audio/milkymist-ac97.c +++ b/hw/audio/milkymist-ac97.c @@ -51,

[Qemu-devel] [PATCH qom-next for-1.6 4/4] pl041: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/audio/pl041.c | 45 + 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/hw/audio/pl041.c b/hw/audio/pl041.c index 7d331b9..4d7a329 100644 --- a/hw/audio/pl041.c +++ b/hw/audio/pl041.c @@ -70,8 +70,12 @@

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Alex Bligh
--On 24 July 2013 09:01:22 +0100 Alex Bligh wrote: Most 'reasonable' POSIX compliant operating systems have ppoll Really? I could find no manpages for any of Solaris and *BSD. OK I shall (re)research that then! I suppose select() / pselect() is an alternative when there are few FDs. Lo

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-07-24 Thread Igor Mammedov
On Tue, 23 Jul 2013 19:09:26 +0200 Paolo Bonzini wrote: > Il 23/07/2013 18:23, Igor Mammedov ha scritto: > > - if slot property is not specified on -device/device_add command, > > treat default value as request for assigning DimmDevice to > > the first free slot. > > Even with "-m" instead of "-

[Qemu-devel] [PATCH qom-next for-1.6 22/29] stellaris: QOM'ify stellaris_adc_state

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/stellaris.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index 15093ba..27205d0 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -896,9 +896,13 @@ stati

[Qemu-devel] [PATCH qom-next for-1.6 2/4] audio/marvell_88w8618: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/audio/marvell_88w8618.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c index b40ea43..97194ce 100644 --- a/hw/audio/marvell_88w8618.c +++ b/hw/audio/marvell_88w8618.c @

[Qemu-devel] [PATCH qom-next for-1.6 1/4] cs4231: QOM'ify

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/audio/cs4231.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/audio/cs4231.c b/hw/audio/cs4231.c index fabe9e6..d19195a 100644 --- a/hw/audio/cs4231.c +++ b/hw/audio/cs4231.c @@ -33,8 +33,13 @@ #define CS_DREGS 32 #de

[Qemu-devel] [PATCH qom-next for-1.6 0/4] audio: QOM cast cleanups

2013-07-24 Thread Andreas Färber
Hello, This series eliminates FROM_SYSBUS() in hw/audio/. Regards, Andreas Cc: Hu Tao Andreas Färber (4): cs4231: QOM'ify audio/marvell_88w8618: QOM'ify milkymist-ac97: QOM'ify pl041: QOM'ify hw/audio/cs4231.c | 15 ++- hw/audio/marvell_88w8618.c | 14 +--

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread liu ping fan
[...] >> http://social.msdn.microsoft.com/Forums/vstudio/en-US/e8a7cb1e-9edd-4ee3-982e-f66b7bf6ae44/improve-accuracy-waitforsingleobject >> >> suggest that WaitFor{Single,Multiple}Objects can have pretty >> appalling latency anyway (100ms!), and there's no evidence that's >> limited by making one o

[Qemu-devel] [PATCH v3] spapr-vscsi: add task management

2013-07-24 Thread Alexey Kardashevskiy
At the moment the guest kernel issues two types of task management requests to the hypervisor - task about and lun reset. This adds handling for these tasks. As spapr-vscsi starts calling scsi_req_cancel(), free_request callback was implemented. As virtio-vscsi, spapr-vscsi does not handle CLEAR_A

Re: [Qemu-devel] [PATCH v2 00/11] pseries: migration and QOM support

2013-07-24 Thread Andreas Färber
Am 23.07.2013 16:38, schrieb Anthony Liguori: > Anthony Liguori writes: > >> This series is based on Alexey's series: >> >> spapr: migration, pci, msi, power8 >> >> Which in turn was based on work by David Gibson. >> >> I've removed the bits not related to migration and made the >> following ch

[Qemu-devel] [PATCH] RFC v2: hcd-ohci: add dma error handling

2013-07-24 Thread Alexey Kardashevskiy
Current hcd-ohci does not handle DMA errors. However they may happen so here we introduce simple error handling. On such errors, a typical OHCI will stop operating, signal the guest about the error by sending "UnrecoverableError Event", set itself into error state and set "Detected Parity Error" i

Re: [Qemu-devel] [sheepdog] [PATCH v2 0/9] sheepdog: reconnect server after connection failure

2013-07-24 Thread Liu Yuan
On Wed, Jul 24, 2013 at 04:56:24PM +0900, MORITA Kazutaka wrote: > Currently, if a sheepdog server exits, all the connecting VMs need to > be restarted. This series implements a feature to reconnect the > server, and enables us to do online sheepdog upgrade and avoid > restarting VMs when sheepdog

[Qemu-devel] [PATCH qom-next for-1.6 02/29] highbank: QOM'ify HighbankRegsState

2013-07-24 Thread Andreas Färber
Add type constant and use QOM casts. Signed-off-by: Andreas Färber --- hw/arm/highbank.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index be264d3..35d5511 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -1

[Qemu-devel] [PATCH qom-next for-1.6 18/29] spitz: QOM'ify SLNANDState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/spitz.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index 593b75e..0bf5c5c 100644 --- a/hw/arm/spitz.c +++ b/hw/arm/spitz.c @@ -50,8 +50,12 @@ #define FLASHCTL_RYBY (1 <<

Re: [Qemu-devel] [PATCH v2 01/11] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-24 Thread Andreas Färber
Am 24.07.2013 10:16, schrieb Alexey Kardashevskiy: > On 07/19/2013 05:32 AM, Anthony Liguori wrote: >> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c >> index 79bfcd8..09ea944 100644 >> --- a/target-ppc/translate_init.c >> +++ b/target-ppc/translate_init.c >> @@ -8449,6 +844

Re: [Qemu-devel] trim in windows guest witch virtio

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 09:52, Libaiqing ha scritto: > Hi paolo, > With -M pc,trim works well in windows guest with ide device and ahci bus. > > About the filter driver,you mean do something in windows virtio-scsi > driver,let it send unmap command to qemu? Yes, it must trap the IOCTL_STORAGE_MA

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 10:01, Alex Bligh ha scritto: >>> >> >> Part of it should be fixed by os_setup_early_signal_handling. >> >> This is corroborated by the fact that without >> os_setup_early_signal_handling Wine always works, and Windows breaks. > > This: > http://www.windowstimestamp.com/description

[Qemu-devel] [PATCH qom-next for-1.6 19/29] spitz: QOM'ify SpitzKeyboardState

2013-07-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/spitz.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index 0bf5c5c..70f23b3 100644 --- a/hw/arm/spitz.c +++ b/hw/arm/spitz.c @@ -215,8 +215,13 @@ static const int spitz_gpiomap[5] =

Re: [Qemu-devel] [PATCH v2 01/11] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-24 Thread Alexey Kardashevskiy
On 07/19/2013 05:32 AM, Anthony Liguori wrote: > From: Alexey Kardashevskiy > > The savevm code for the powerpc cpu emulation is currently based around > the old register_savevm() rather than register_vmstate() method. It's also > rather broken, missing some important state on some CPU models. >

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-24 Thread Alex Bligh
Paolo, --On 24 July 2013 09:54:57 +0200 Paolo Bonzini wrote: Alex, can you add it to your series? (Note that you must set a timer slack of 1, because 0 is interpreted as "default"). Sure, will do. I'm guessing I'll have to look for that inside configure as well. -- Alex Bligh

<    1   2   3   >