Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-29 Thread Markus Armbruster
Anthony Liguori writes: > On Mon, Jul 29, 2013 at 7:15 PM, Markus Armbruster wrote: >> Luiz Capitulino writes: >> >>> On Fri, 19 Jul 2013 04:57:51 -0600 >>> Eric Blake wrote: >>> On 07/18/2013 08:36 PM, Pawit Pornkitprasan wrote: > The qmp_migrate method uses the 'blk' and 'inc' para

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-07-29 Thread Michael Tokarev
So, what changed so you were able to boot from IDE without errors? As far as I understand, your initial prob was I/O errors on IDE (virtual) drive, but now you can boot it without errors. Or was it always SATA not IDE? The rdmsr/wrmsr are unrelated, I already told you that, it is accessing optio

Re: [Qemu-devel] [PATCH 0/7] smbios cleanup & nicer defaults for type 1

2013-07-29 Thread Markus Armbruster
Ping for 1.6 Markus Armbruster writes: > This gets rid of one of the last get_param_value() users, makes > multiple -smbios work sanely, cleans up the gross side effect in > qemu_uuid_parse(), and more. Topped off with a little feature in the > last patch. > > Markus Armbruster (7): > smbios:

Re: [Qemu-devel] [PATCH 9/9] block: vhdx write support

2013-07-29 Thread Fam Zheng
On Wed, 07/24 13:54, Jeff Cody wrote: > This adds support for writing to VHDX image files, using coroutines. > Writes into the BAT table goes through the VHDX log. Currently, BAT > table writes occur when expanding a dynamic VHDX file, and allocating a > new BAT entry. > > Signed-off-by: Jeff Cod

Re: [Qemu-devel] [PATCH 8/9] block: vhdx - add log write support

2013-07-29 Thread Fam Zheng
On Wed, 07/24 13:54, Jeff Cody wrote: > This adds support for writing to the VHDX log. > > For spec details, see VHDX Specification Format v1.00: > https://www.microsoft.com/en-us/download/details.aspx?id=34750 > > There are a few limitations to this log support: > 1.) There is no caching yet > 2

Re: [Qemu-devel] [PATCH 7/9] block: vhdx - log parsing, replay, and flush support

2013-07-29 Thread Fam Zheng
On Wed, 07/24 13:54, Jeff Cody wrote: > This adds support for VHDX v0 logs, as specified in Microsoft's > VHDX Specification Format v1.00: > https://www.microsoft.com/en-us/download/details.aspx?id=34750 > > The following support is added: > > * Log parsing, and validation - validate that an exis

Re: [Qemu-devel] [RFC v2 0/5] arm AioContext with its own timer stuff

2013-07-29 Thread liu ping fan
On Mon, Jul 29, 2013 at 5:22 PM, Stefan Hajnoczi wrote: > On Mon, Jul 29, 2013 at 11:16:03AM +0800, Liu Ping Fan wrote: >> summary of the model: >> Three qemu-wide clock source allowed in system. And each AioContext has >> three corresponding timer list to run timer against clocksource. >> >> rf

Re: [Qemu-devel] [PATCH 4/9] block: vhdx - log support struct and defines

2013-07-29 Thread Fam Zheng
On Wed, 07/24 13:54, Jeff Cody wrote: > This adds some magic number defines, and internal structure > definitions for VHDX log replay support. > > Signed-off-by: Jeff Cody > --- > block/vhdx.h | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/block/v

Re: [Qemu-devel] [PATCH V6 0/8] add internal snapshot support at block device level

2013-07-29 Thread Wenchao Xia
>This series brings internal snapshot support at block devices level, now we > have two three methods to do block snapshot lively: 1) backing chain, > 2) internal one and 3) drive-back up approach. > > Comparation: > Advantages:Disadvantages: > 1)d

Re: [Qemu-devel] [PATCH] spapr-pci: rework MSI/MSIX

2013-07-29 Thread Alexey Kardashevskiy
Ping, anyone? On 07/23/2013 12:54 PM, Alexey Kardashevskiy wrote: > Michael, could you please review the patch as it is about PCI? Thanks! > > > On 07/12/2013 05:38 PM, Alexey Kardashevskiy wrote: >> On the sPAPR platform a guest allocates MSI/MSIX vectors via RTAS >> hypercalls which return gl

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-07-29 Thread liu ping fan
On Mon, Jul 29, 2013 at 7:21 PM, Paolo Bonzini wrote: > Il 29/07/2013 10:10, liu ping fan ha scritto: >> On Mon, Jul 29, 2013 at 2:30 PM, Paolo Bonzini wrote: >>> Il 29/07/2013 05:16, Liu Ping Fan ha scritto: After disabling the QemuClock, we should make sure that no QemuTimers are stil

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-07-29 Thread Christoph Anton Mitterer
Also, when using SATA for the virtual disk,... it seems that it takes much longer till it get's to the point where it (the initrd) tries to mount root. Till that point I see no errors... but then, after some time hanging at the root mount... it starts with the ATA errors. -- You received this bu

Re: [Qemu-devel] [RFC v2 4/5] timer: associate three timerlists with AioContext

2013-07-29 Thread liu ping fan
On Mon, Jul 29, 2013 at 9:11 PM, Paolo Bonzini wrote: > Il 29/07/2013 10:20, liu ping fan ha scritto: >>> > Another issue is that deadline computation is not using the AioContext's >>> > timer lists. >>> > >> Sorry, can not catch the meaning. When AioContext has its own timer >> lists, it will hav

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-07-29 Thread Christoph Anton Mitterer
Hi. Finally I was able to get it running with IDE instead of SATA. That works,... fine... no ATA errors. As you already expected,.. I still get the: [20424.793207] kvm [20947]: vcpu0 unhandled wrmsr: 0x6c1 data 0 [20424.793211] kvm [20947]: vcpu0 unhandled wrmsr: 0x682 data 0 [20424.793215] kvm [

Re: [Qemu-devel] RFC: [PATCH 0/4] xics: in-kernel support

2013-07-29 Thread Alexey Kardashevskiy
On 07/17/2013 04:37 PM, Alexey Kardashevskiy wrote: > This is rework of in-kernel XICS on top of "[PATCH 00/11] pseries: migration > and QOM support" + compile fix patch + XICS migration fix patch. > > Migration from XICS to XICS-KVM and vice versa works. > > In this series, XICS-KVM inherits fro

Re: [Qemu-devel] [Xen-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-29 Thread Gonglei (Arei)
> On Mon, Jul 29, 2013 at 08:48:54AM +, Gonglei (Arei) wrote: > > > -Original Message- > > > From: Pasi Kärkkäinen [mailto:pa...@iki.fi] > > > Sent: Saturday, July 27, 2013 7:51 PM > > > To: Gerd Hoffmann > > > Cc: Andreas Färber; Hanweidong; Luonengjun; qemu-devel@nongnu.org; > > > xen

[Qemu-devel] [ANNOUNCE] QEMU 1.6.0-rc0 is now available

2013-07-29 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 1.6 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.6.0-rc0.tar.bz2 You can help improve

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-29 Thread Anthony Liguori
On Mon, Jul 29, 2013 at 7:15 PM, Markus Armbruster wrote: > Luiz Capitulino writes: > >> On Fri, 19 Jul 2013 04:57:51 -0600 >> Eric Blake wrote: >> >>> On 07/18/2013 08:36 PM, Pawit Pornkitprasan wrote: >>> > The qmp_migrate method uses the 'blk' and 'inc' parameter without >>> > checking if the

[Qemu-devel] [Bug 1188991] Re: Unable to do serial communication using -chardev tty

2013-07-29 Thread t0n1
for me qemu crashes if I try to connect on /dev/pts/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1188991 Title: Unable to do serial communication using -chardev tty Status in QEMU: New Bug de

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-29 Thread Seiji Aguchi
Markus, Luiz > > A conversion from fprintf() to error_report() is always an improvement, > > because > > No disagreement here. Thank you for discussing this. I will update my patch by converting from fprintf(stderr, ..) to error_report(). Seiji > -Original Message- > From: Luiz Capitul

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-29 Thread Luiz Capitulino
On Tue, 30 Jul 2013 02:00:40 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Mon, 29 Jul 2013 23:23:32 +0200 > > Andreas Färber wrote: > > > >> Am 29.07.2013 23:20, schrieb Luiz Capitulino: > >> > On Mon, 22 Jul 2013 23:23:29 +0200 > >> > Andreas Färber wrote: > >> >> Am 22.

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-29 Thread Marcelo Tosatti
On Sat, Jul 27, 2013 at 07:47:49AM +, Zhanghaoyu (A) wrote: > >> hi all, > >> > >> I met similar problem to these, while performing live migration or > >> save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2, > >> guest:suse11sp2), running tele-communication software suite in gu

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-29 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 19 Jul 2013 04:57:51 -0600 > Eric Blake wrote: > >> On 07/18/2013 08:36 PM, Pawit Pornkitprasan wrote: >> > The qmp_migrate method uses the 'blk' and 'inc' parameter without >> > checking if they're valid or not (they may be uninitialized if >> > command is rece

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-29 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 29 Jul 2013 23:23:32 +0200 > Andreas Färber wrote: > >> Am 29.07.2013 23:20, schrieb Luiz Capitulino: >> > On Mon, 22 Jul 2013 23:23:29 +0200 >> > Andreas Färber wrote: >> >> Am 22.07.2013 23:03, schrieb Seiji Aguchi: >> >>> Convert stderr messages calling erro

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-29 Thread Pawit Pornkitprasan
On Tue, Jul 30, 2013 at 5:52 AM, Luiz Capitulino wrote: > > This doesn't apply anymore, can you rebase and resend? > Sure. > By grepping around I can see that there are several instances of > this bug in other commands. I'm surprised we never got a single > bug report about this... Would you min

[Qemu-devel] [PATCH v2] migration: don't use uninitialized variables

2013-07-29 Thread Pawit Pornkitprasan
The qmp_migrate method uses the 'blk' and 'inc' parameter without checking if they're valid or not (they may be uninitialized if command is received via QMP) Signed-off-by: Pawit Pornkitprasan --- migration.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration.c

Re: [Qemu-devel] [PATCH 1/4] block/sheepdog: Rename 'dprintf' to 'DPRINTF'

2013-07-29 Thread MORITA Kazutaka
At Mon, 29 Jul 2013 14:44:16 +0200, Kevin Wolf wrote: > > Am 29.07.2013 um 14:16 hat Peter Maydell geschrieben: > > 'dprintf' is the name of a POSIX standard function so we should not be > > stealing it for our debug macro. Rename to 'DPRINTF' (in line with > > a number of other source files.) > >

Re: [Qemu-devel] [PATCH RFT 4/5] virtio-console: Use exitfn for virtserialport, too

2013-07-29 Thread Andreas Färber
Michael, Anthony, Am 07.06.2013 20:18, schrieb Andreas Färber: > virtconsole and virtserialport are identical in every other aspect > except for the distinguishing VirtIOSerialPortClass::is_console field. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Andreas Färber > --- > hw/char/virtio-cons

[Qemu-devel] [PULL 163/173] xilinx_timer: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/timer/xilinx_timer.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c index ee53834..5f2c902 100644 --- a/hw/timer/xilinx_timer.c +++ b/hw/timer/xilinx_timer.c @@ -57,9 +57,14 @@

[Qemu-devel] [PULL 030/173] imx_avic: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Introduce type constant, use QOM casts and prepare SysBus initfn for QOM realize by resolving SysBusDevice vs. DeviceState "dev" name conflict. Acked-by: Peter Chubb Signed-off-by: Andreas Färber --- hw/intc/imx_avic.c | 27 +-- 1 file changed, 17 insertions(+), 10 delet

[Qemu-devel] [PULL 142/173] pl022: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/ssi/pl022.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/ssi/pl022.c b/hw/ssi/pl022.c index d33534e..fd479ef 100644 --- a/hw/ssi/pl022.c +++ b/hw/ssi/pl022.c @@ -39,8 +39,12 @@ do { fprintf(stderr, "pl022: error

[Qemu-devel] [PULL 158/173] pl031: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/timer/pl031.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/timer/pl031.c b/hw/timer/pl031.c index e705a69..d5e2f3e 100644 --- a/hw/timer/pl031.c +++ b/hw/timer/pl031.c @@ -33,8 +33,12 @@ do { printf("pl031: " fmt , ## __VA_

[Qemu-devel] [PULL 172/173] spapr_pci: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/ppc/spapr_pci.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 3156fdd..1ca35a0 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -479,6 +479,7 @@ static AddressSpace *spapr_pc

[Qemu-devel] [PULL 035/173] integratorcp: QOM cast cleanup for icp_pic_state

2013-07-29 Thread Andreas Färber
Introduce type constant and use QOM cast. Fix indentation. Signed-off-by: Andreas Färber --- hw/arm/integratorcp.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c index 58f4ed7..d51818

Re: [Qemu-devel] [PATCH 0/6] spapr: migration for vio, vio-lan, vio-tty, pseries, pci, ppc cpu

2013-07-29 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PULL 052/173] stellaris: QOM cast cleanup for stellaris_i2c_state

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts, rename the parent field and prepare for QOM realize. Signed-off-by: Andreas Färber --- hw/arm/stellaris.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index 9a7fafb.

[Qemu-devel] [PULL 011/173] pci-bridge/i82801b11: Rename parent field

2013-07-29 Thread Andreas Färber
Rename it to avoid accidental use. Reviewed-by: Don Koch Signed-off-by: Andreas Färber --- hw/pci-bridge/i82801b11.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c index 82e92d8..8a5e426 100644 --- a/hw/pci-bridge/i82

[Qemu-devel] [PULL 119/173] etraxfs_eth: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/net/etraxfs_eth.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c index ab9a215..dda1fc3 100644 --- a/hw/net/etraxfs_eth.c +++ b/hw/net/etraxfs_eth.c @@ -322,9 +322,14 @@ stati

[Qemu-devel] [PULL 167/173] opencores_eth: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/net/opencores_eth.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c index 513f345..4118d54 100644 --- a/hw/net/opencores_eth.c +++ b/hw/net/opencores_eth.c @@ -267,8

[Qemu-devel] [PULL 056/173] strongarm: QOM cast cleanup for StrongARMGPIOInfo

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts, rename the parent field and prepare for QOM realize. Signed-off-by: Andreas Färber --- hw/arm/strongarm.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index 78211a

[Qemu-devel] [PULL 164/173] sysbus: Drop FROM_SYSBUS()

2013-07-29 Thread Andreas Färber
As a replacement, use your own macro based on OBJECT_CHECK(). Signed-off-by: Andreas Färber --- include/hw/sysbus.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index 8c17165..fbfc066 100644 --- a/include/hw/sysbus.h +++ b/include/hw/sysbus.h @@

[Qemu-devel] [PULL 121/173] lan9118: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/net/lan9118.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c index 3323f48..2c838f6 100644 --- a/hw/net/lan9118.c +++ b/hw/net/lan9118.c @@ -170,8 +170,12 @@ static const VMS

[Qemu-devel] [PULL 036/173] musicpal: Fix typo in name of local function

2013-07-29 Thread Andreas Färber
From: Stefan Weil The misspelling was spotted by Andreas Färber. Signed-off-by: Stefan Weil Reviewed-by: Jan Kiszka Signed-off-by: Andreas Färber --- hw/arm/musicpal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index b06d442.

[Qemu-devel] [PULL 098/173] omap_intc: QOM'ify omap-intc and omap2-intc

2013-07-29 Thread Andreas Färber
Create a new abstract base type and let omap-intc and omap2-intc inherit from it. Introduce a type constant and use QOM casts. Signed-off-by: Andreas Färber --- hw/intc/omap_intc.c | 57 - 1 file changed, 35 insertions(+), 22 deletions(-) diff

[Qemu-devel] [PULL 123/173] milkymist-minimac2: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/net/milkymist-minimac2.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c index becd26c..1e92379 100644 --- a/hw/net/milkymist-minimac2.c +++ b/hw/net/mi

[Qemu-devel] [PULL 074/173] pl080: QOM'ify pl080 and pl081

2013-07-29 Thread Andreas Färber
Let pl081 inherit from pl080 and replace triple SysBus initfn with two instance_inits. Signed-off-by: Andreas Färber --- hw/dma/pl080.c | 51 --- 1 file changed, 20 insertions(+), 31 deletions(-) diff --git a/hw/dma/pl080.c b/hw/dma/pl080.c index

[Qemu-devel] [PULL 146/173] arm_timer: QOM cast cleanup for icp_pit_state

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/timer/arm_timer.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c index 8d95743..acfea59 100644 --- a/hw/timer/arm_timer.c +++ b/hw/timer/arm_timer.c @@ -298,8 +298,13 @@ static int sp

[Qemu-devel] [PULL 104/173] xilinx_intc: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/intc/xilinx_intc.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c index 25d2057..4a10398 100644 --- a/hw/intc/xilinx_intc.c +++ b/hw/intc/xilinx_intc.c @@ -37,9 +37,13 @@

[Qemu-devel] [PULL 111/173] milkymist-hpdmc: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/milkymist-hpdmc.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/misc/milkymist-hpdmc.c b/hw/misc/milkymist-hpdmc.c index a498881..aef135e 100644 --- a/hw/misc/milkymist-hpdmc.c +++ b/hw/misc/milkymist-hpdmc.c @@ -40,

[Qemu-devel] [PULL 080/173] omap_gpio: QOM cast cleanup for omap2_gpif_s

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/gpio/omap_gpio.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c index 295caad..b8f572b 100644 --- a/hw/gpio/omap_gpio.c +++ b/hw/gpio/omap_gpio.c @@ -208,8 +20

[Qemu-devel] [PULL 005/173] timer/arm_mptimer: QOM cast cleanup

2013-07-29 Thread Andreas Färber
From: Andreas Färber Introduce type constant and cast macro and rename ARMMPTimerState::busdev to enforce its use. Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/timer/arm_mptimer.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/tim

[Qemu-devel] [PULL 162/173] tusb6010: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/timer/tusb6010.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/hw/timer/tusb6010.c b/hw/timer/tusb6010.c index 47b6809..c48ecf8 100644 --- a/hw/timer/tusb6010.c +++ b/hw/timer/tusb6010.c @@ -26,8 +26,12 @@ #i

[Qemu-devel] [PULL 016/173] cs4231: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts and rename the parent field. Reviewed-by: Hu Tao Signed-off-by: Andreas Färber --- hw/audio/cs4231.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/audio/cs4231.c b/hw/audio/cs4231.c index fabe9e6..d19195a 100644

[Qemu-devel] [PULL 120/173] etraxfs_eth: Rename fs_eth to ETRAXFSEthState

2013-07-29 Thread Andreas Färber
Also add a typedef. Signed-off-by: Andreas Färber --- hw/net/etraxfs_eth.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c index dda1fc3..78ebbbc 100644 --- a/hw/net/etraxfs_eth.c +++ b/hw/ne

[Qemu-devel] [PULL 127/173] xgmac: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Introduce type constant and use QOM casts and typedef consistently. Signed-off-by: Andreas Färber --- hw/net/xgmac.c | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/hw/net/xgmac.c b/hw/net/xgmac.c index 997a5b5..9384fa0 100644

Re: [Qemu-devel] [BUG] GTK terminal is broken

2013-07-29 Thread Laszlo Ersek
On 07/29/13 20:18, Stefan Weil wrote: > Am 29.07.2013 20:05, schrieb Anthony Liguori: >> Stefan Weil writes: >> >>> Hello, >>> >>> maybe most developers will already have noticed that the terminal output >>> in QEMU's GTK user interface is broken. As far as I know, it never worked, >>> but as ther

[Qemu-devel] [PULL 102/173] realview_gic: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/intc/realview_gic.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/intc/realview_gic.c b/hw/intc/realview_gic.c index e122c2c..ce80447 100644 --- a/hw/intc/realview_gic.c +++ b/hw/intc/realview_gic.c @@ -9,8 +9,13

[Qemu-devel] [PULL 048/173] pxa2xx_pic: QOM cast cleanup for PXA2xxPICState

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts, rename the parent field and prepare for QOM realize. Signed-off-by: Andreas Färber --- hw/arm/pxa2xx_pic.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/arm/pxa2xx_pic.c b/hw/arm/pxa2xx_pic.c index 8929b6d..46

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-07-29 Thread Andrea Arcangeli
Hi, On Sat, Jul 27, 2013 at 07:47:49AM +, Zhanghaoyu (A) wrote: > >> hi all, > >> > >> I met similar problem to these, while performing live migration or > >> save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2, > >> guest:suse11sp2), running tele-communication software suite

[Qemu-devel] [PULL 017/173] audio/marvell_88w8618: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts and rename the parent field. Reviewed-by: Hu Tao Signed-off-by: Andreas Färber --- hw/audio/marvell_88w8618.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c index

Re: [Qemu-devel] [PATCH] seccomp: add arch_prctl() to the syscall whitelist

2013-07-29 Thread Paul Moore
On Wednesday, July 24, 2013 03:01:57 PM Eduardo Otubo wrote: > On 07/23/2013 10:57 AM, Paul Moore wrote: > > On Thursday, July 18, 2013 09:57:03 AM Paul Moore wrote: > >> It appears that even a very simple /etc/qemu-ifup configuration can > >> > >> require the arch_prctl() syscall, see the example

Re: [Qemu-devel] [PATCH] seccomp: add additional asynchronous I/O syscalls

2013-07-29 Thread Paul Moore
On Wednesday, July 24, 2013 03:02:23 PM Eduardo Otubo wrote: > On 07/23/2013 10:57 AM, Paul Moore wrote: > > On Monday, July 15, 2013 03:32:01 PM Paul Moore wrote: > >> A previous commit, "seccomp: add the asynchronous I/O syscalls to the > >> whitelist", added several asynchronous I/O syscalls but

[Qemu-devel] [PULL 033/173] highbank: QOM cast cleanup for HighbankRegsState

2013-07-29 Thread Andreas Färber
Add type constant and use QOM casts. Signed-off-by: Andreas Färber --- hw/arm/highbank.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index be264d3..35d5511 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -1

[Qemu-devel] [PULL 025/173] milkymist-tmu2: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts and rename the parent field. Signed-off-by: Andreas Färber --- hw/display/milkymist-tmu2.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/display/milkymist-tmu2.c b/hw/display/milkymist-tmu2.c index efda082..b2a5fba 1

[Qemu-devel] [PULL 001/173] fdc: Fix inheritence for SUNW,fdtwo

2013-07-29 Thread Andreas Färber
Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539) was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than SUNW,fdtwo. Fix this by letting SUNW,fdtwo and sysbus-fdc both inherit from an abstract type base-

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-07-29 Thread Laszlo Ersek
On 07/29/13 23:08, Luiz Capitulino wrote: > On Mon, 29 Jul 2013 16:37:12 +0200 > Laszlo Ersek wrote: > >> (Apologies for the long To: list, I'm including everyone who >> participated in >> ). >> >> Conceptually, the dump-guest-m

[Qemu-devel] [PULL 166/173] exynos4210_i2c: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Fix one ->qdev access and rename parent field. Signed-off-by: Andreas Färber --- hw/i2c/exynos4210_i2c.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/i2c/exynos4210_i2c.c b/hw/i2c/exynos4210_i2c.c index 42f5e89..ce5f849 100644 --- a/hw/i2c/exynos4210_i2c.c

[Qemu-devel] [PULL 125/173] stellaris_enet: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/net/stellaris_enet.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index aac7c76..6194e33 100644 --- a/hw/net/stellaris_enet.c +++ b/hw/net/stellaris_enet.c @@ -4

[Qemu-devel] [PULL 117/173] zynq_slcr: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/zynq_slcr.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c index fc7a85f..e42a5b0 100644 --- a/hw/misc/zynq_slcr.c +++ b/hw/misc/zynq_slcr.c @@ -114,8 +114,12 @@ typedef enum {

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-07-29 Thread Laszlo Ersek
On 07/29/13 23:53, Laszlo Ersek wrote: > On 07/29/13 23:08, Luiz Capitulino wrote: >> Is this for 1.6? > > It's for whichever release reviewers and maintainers accept it! :) > > On a more serious note, if someone makes an exception out of this, I > won't object, but I'm not pushing for it. My po

[Qemu-devel] [PULL 022/173] exynos4210_fimd: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts and rename the parent field. Signed-off-by: Andreas Färber --- hw/display/exynos4210_fimd.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c index eb168ea..

[Qemu-devel] [PULL 079/173] omap_gpio: QOM cast cleanup for omap_gpif_s

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/gpio/omap_gpio.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c index 855afae..295caad 100644 --- a/hw/gpio/omap_gpio.c +++ b/hw/gpio/omap_gpio.c @@ -35,8 +35,13 @@ st

Re: [Qemu-devel] [PATCH 2/2] i82378: cleanup implementation

2013-07-29 Thread Andreas Färber
Hi, Am 23.07.2013 23:16, schrieb Hervé Poussineau: > - i82378 only exists on PCI bus ; do not split implementation in 2 structures > - remove BARs, which are not specified in datasheet > - replace custom isa_mmio implementation by PCI bus IO region usage > - use QOM casts when required > > Signed

[Qemu-devel] [PULL 101/173] puv3_intc: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/intc/puv3_intc.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/intc/puv3_intc.c b/hw/intc/puv3_intc.c index 44b6651..c2803d0 100644 --- a/hw/intc/puv3_intc.c +++ b/hw/intc/puv3_intc.c @@ -13,8 +13,12 @@ #undef

Re: [Qemu-devel] [PATCH] sun4m: add display width and height to the firmware configuration

2013-07-29 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-29 Thread Luiz Capitulino
On Mon, 29 Jul 2013 23:23:32 +0200 Andreas Färber wrote: > Am 29.07.2013 23:20, schrieb Luiz Capitulino: > > On Mon, 22 Jul 2013 23:23:29 +0200 > > Andreas Färber wrote: > >> Am 22.07.2013 23:03, schrieb Seiji Aguchi: > >>> Convert stderr messages calling error_get_pretty() > >>> to error_report

[Qemu-devel] [PULL 100/173] pl190: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/intc/pl190.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/hw/intc/pl190.c b/hw/intc/pl190.c index dfd6ebf..329680d 100644 --- a/hw/intc/pl190.c +++ b/hw/intc/pl190.c @@ -15,8 +15,12 @@ #defin

[Qemu-devel] [PULL 031/173] imx_ccm: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Introduce type constant and use QOM casts. Acked-by: Peter Chubb Signed-off-by: Andreas Färber --- hw/misc/imx_ccm.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/misc/imx_ccm.c b/hw/misc/imx_ccm.c index 816d5e8..63e33a4 100644 --- a/hw/misc/imx_ccm.c

[Qemu-devel] [PULL 136/173] sun4m: QOM cast cleanup for AFXState

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/sparc/sun4m.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index eb3b11b..e5c6881 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -612,8 +612,12 @@ static const TypeInfo idreg_info

[Qemu-devel] [PULL 091/173] arm_gic: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/intc/arm_gic.c| 5 +++-- hw/intc/arm_gic_common.c | 2 +- hw/intc/gic_internal.h | 5 - 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c index 8e34004..d431b7a 100644 --- a/hw/intc/arm_gic.c +++

[Qemu-devel] [PULL 084/173] gpio/zaurus: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/gpio/zaurus.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/gpio/zaurus.c b/hw/gpio/zaurus.c index c235c3e..dc79a8b 100644 --- a/hw/gpio/zaurus.c +++ b/hw/gpio/zaurus.c @@ -24,9 +24,13 @@ /* SCOOP devices */ +

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-29 Thread Andreas Färber
Am 29.07.2013 23:20, schrieb Luiz Capitulino: > On Mon, 22 Jul 2013 23:23:29 +0200 > Andreas Färber wrote: >> Am 22.07.2013 23:03, schrieb Seiji Aguchi: >>> Convert stderr messages calling error_get_pretty() >>> to error_report(). >> >> How is this related to error_get_pretty()? > > Yeah, we're c

[Qemu-devel] [PULL 160/173] pxa2xx_timer: QOM'ify pxa25x-timer and pxa27x-timer

2013-07-29 Thread Andreas Färber
Introduce type constant for new abstract base type, use QOM casts and let both non-abstract types inherit from the new base type. Signed-off-by: Andreas Färber --- hw/timer/pxa2xx_timer.c | 42 +- 1 file changed, 29 insertions(+), 13 deletions(-) diff --g

[Qemu-devel] [PULL 096/173] grlib_irqmp: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/intc/grlib_irqmp.c | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/hw/intc/grlib_irqmp.c b/hw/intc/grlib_irqmp.c index 181f614..42e00bc 100644 --- a/hw/intc/grlib_irqmp.c +++ b/hw/intc/grlib_irqmp.c @@ -4

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

2013-07-29 Thread Luiz Capitulino
On Mon, 22 Jul 2013 23:23:29 +0200 Andreas Färber wrote: > Am 22.07.2013 23:03, schrieb Seiji Aguchi: > > Convert stderr messages calling error_get_pretty() > > to error_report(). > > > > Timestamp is prepended by -msg timstamp option with it. > > > > This is suggested by Luiz Capitulino. > >

[Qemu-devel] [PULL 071/173] pl011: QOM'ify pl011 and pl011_luminary

2013-07-29 Thread Andreas Färber
Let the Luminary variant inherit from the ARM one, overwriting its ID on instance_init. Introduce type constant and use QOM casts. Replace triplicated SysBusDevice initfn with QOM realizefn and instance_init. Signed-off-by: Andreas Färber --- hw/char/pl011.c | 62 +---

[Qemu-devel] [PULL 097/173] lm32_pic: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/intc/lm32_pic.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/intc/lm32_pic.c b/hw/intc/lm32_pic.c index b4e80c8..32d009f 100644 --- a/hw/intc/lm32_pic.c +++ b/hw/intc/lm32_pic.c @@ -26,8 +26,12 @@ #inclu

[Qemu-devel] [PULL 165/173] sysbus: Remove unused sysbus_new() prototype

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- include/hw/sysbus.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index fbfc066..f1d1c5e 100644 --- a/include/hw/sysbus.h +++ b/include/hw/sysbus.h @@ -55,7 +55,6 @@ struct SysBusDevice { pio_addr_t pio[QDEV_MAX

[Qemu-devel] [PULL 138/173] sun4m: QOM cast cleanup for RamDevice

2013-07-29 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/sparc/sun4m.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c index b943a07..942ca37 100644 --- a/hw/sparc/sun4m.c +++ b/hw/sparc/sun4m.c @@ -739,9 +739,12 @@ static const TypeInfo prom_in

Re: [Qemu-devel] [BUG] GTK terminal is broken

2013-07-29 Thread Anthony Liguori
Stefan Weil writes: > Am 29.07.2013 22:34, schrieb Andreas Färber: >> Am 29.07.2013 21:27, schrieb Stefan Weil: >>> Am 29.07.2013 20:55, schrieb Anthony Liguori: Stefan Weil writes: > Am 29.07.2013 20:05, schrieb Anthony Liguori: >> Stefan Weil writes: >> >>> Hello, >>

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-07-29 Thread Luiz Capitulino
On Mon, 29 Jul 2013 16:37:12 +0200 Laszlo Ersek wrote: > (Apologies for the long To: list, I'm including everyone who > participated in > ). > > Conceptually, the dump-guest-memory command works as follows: > (a) pause the gues

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-29 Thread Luiz Capitulino
On Fri, 19 Jul 2013 04:57:51 -0600 Eric Blake wrote: > On 07/18/2013 08:36 PM, Pawit Pornkitprasan wrote: > > The qmp_migrate method uses the 'blk' and 'inc' parameter without > > checking if they're valid or not (they may be uninitialized if > > command is received via QMP) > > > > Signed-off-b

[Qemu-devel] [PULL 126/173] stellaris_enet: Fix NetClientInfo::cleanup

2013-07-29 Thread Andreas Färber
Drop freeing stellaris_enet_state - that is done by QOM later on unref. Both MemoryRegion init and savevm registration happen in SysBusDevice initfn currently, so move them into an unrealizefn for now. Signed-off-by: Andreas Färber --- hw/net/stellaris_enet.c | 16 +++- 1 file chang

[Qemu-devel] [PULL 023/173] g364fb: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts and rename the parent field and prepare for QOM realize. Signed-off-by: Andreas Färber --- hw/display/g364fb.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index 2

[Qemu-devel] [PULL 009/173] pci-bridge: Turn PCIBridge into abstract QOM type

2013-07-29 Thread Andreas Färber
Introduce TYPE_PCI_BRIDGE as base type and use PCI_BRIDGE() casts. Reviewed-by: Don Koch Acked-by: Michael S. Tsirkin [AF: Updated pbm-bridge parent to TYPE_PCI_BRIDGE] Signed-off-by: Andreas Färber --- hw/pci-bridge/dec.c| 4 ++-- hw/pci-bridge/i82801b11.c | 6 +++--

[Qemu-devel] [PULL 024/173] jazz_led: QOM cast cleanup

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts and rename the parent field. Signed-off-by: Andreas Färber --- hw/display/jazz_led.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c index 7f82037..8407e6c 100644 --- a/hw/disp

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-29 Thread Luiz Capitulino
On Fri, 19 Jul 2013 11:36:41 +0900 Pawit Pornkitprasan wrote: > The qmp_migrate method uses the 'blk' and 'inc' parameter without > checking if they're valid or not (they may be uninitialized if > command is received via QMP) > > Signed-off-by: Pawit Pornkitprasan > --- > migration.c | 4 ++--

[Qemu-devel] [PULL 055/173] strongarm: QOM cast cleanup for StrongARMRTCState

2013-07-29 Thread Andreas Färber
Introduce a type constant, use QOM casts and rename the parent field. Signed-off-by: Andreas Färber --- hw/arm/strongarm.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index 457f9c7..78211a0 100644 --- a/hw/arm/stron

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-29 Thread Eric Blake
On 07/29/2013 02:24 PM, Anthony Liguori wrote: > Applied. Thanks. Script botch-up? This series has a title of RFC (which means it should not be applied as-is), and there have been later revisions that dropped the RFC in response to comments; did the correct version get applied? -- Eric Blake

Re: [Qemu-devel] [BUG] GTK terminal is broken

2013-07-29 Thread Andreas Färber
Am 29.07.2013 22:34, schrieb Andreas Färber: > FWIW I've been seeing similar garbled-Gtk-output issues on openSUSE 12.3 > but didn't investigate further. -monitor stdio has so far not failed me > on the same system by comparison. -serial stdio obviously. :) > One reproducible test case was the op

  1   2   3   4   5   >