Re: [Qemu-devel] [PATCH 0/3] rdma fixes and clean ups

2013-08-03 Thread Isaku Yamahata
On Fri, Aug 02, 2013 at 09:40:58AM -0400, "Michael R. Hines" wrote: > On 08/01/2013 11:56 PM, Isaku Yamahata wrote: > >Small fixes/clean up to rdma. found through code review. > > > >Isaku Yamahata (3): > > rdma: don't use negative index to array > > rdma: qemu_rdma_post_send_control uses wro

Re: [Qemu-devel] [PATCH 0/3] rdma fixes and clean ups

2013-08-03 Thread Michael R. Hines
On 08/03/2013 09:24 PM, Isaku Yamahata wrote: On Fri, Aug 02, 2013 at 09:40:58AM -0400, "Michael R. Hines" wrote: On 08/01/2013 11:56 PM, Isaku Yamahata wrote: Small fixes/clean up to rdma. found through code review. Isaku Yamahata (3): rdma: don't use negative index to array rdma: qem

[Qemu-devel] [PATCH v3 For-1.6 3/7] rdma: correct newlines in error statements

2013-08-03 Thread mrhines
From: "Michael R. Hines" Don't print newlines on the error_setg() function, but still allow newlines on fprintf(). Signed-off-by: Michael R. Hines --- migration-rdma.c | 68 +++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a

[Qemu-devel] [PATCH v3 For-1.6 5/7] rdma: qemu_rdma_post_send_control uses wrongly RDMA_WRID_MAX

2013-08-03 Thread mrhines
From: Isaku Yamahata RDMA_WRID_CONTROL should be used. And remove related work around. Reviewed-by: Michael R. Hines Signed-off-by: Isaku Yamahata Signed-off-by: Michael R. Hines --- migration-rdma.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/migration

[Qemu-devel] [PATCH v3 For-1.6 4/7] rdma: don't use negative index to array

2013-08-03 Thread mrhines
From: Isaku Yamahata Reviewed-by: Michael R. Hines Signed-off-by: Isaku Yamahata Signed-off-by: Michael R. Hines --- migration-rdma.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index c958e5f..7266803

[Qemu-devel] [PATCH v3 For-1.6 2/7] rdma: forgot to turn off the debugging flag

2013-08-03 Thread mrhines
From: "Michael R. Hines" Ooops. We forgot to turn off the flag. Signed-off-by: Michael R. Hines --- migration-rdma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration-rdma.c b/migration-rdma.c index 9cf73e3..fe6118d 100644 --- a/migration-rdma.c +++ b/migration-r

[Qemu-devel] [PATCH v3 For-1.6 7/7] rdma: memory leak RDMAContext::host

2013-08-03 Thread mrhines
From: Isaku Yamahata It is allocated by g_strdup(), so needs to be freed. Reviewed-by: Michael R. Hines Signed-off-by: Isaku Yamahata Signed-off-by: Michael R. Hines --- migration-rdma.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/migration-rdma.c b/migration-rdma.c index 6afe98

[Qemu-devel] [PATCH v3 For-1.6 0/7] rdma: bugfixes, cleanups, IPv6 support

2013-08-03 Thread mrhines
From: "Michael R. Hines" Changes: A few bug 1. IPv6 support was broken under libvirt. 2. incorrect use of error_setg() 3. DPRINTF flag was not disabled 4. Numerous other bugfixes. Isaku Yamahata (4): rdma: don't use negative index to array rdma: qemu_rdma_post_send_control uses wrongly RDMA

[Qemu-devel] [PATCH v3 For-1.6 6/7] rdma: use RDMA_WRID_READY

2013-08-03 Thread mrhines
From: Isaku Yamahata Reviewed-by: Michael R. Hines Signed-off-by: Isaku Yamahata Signed-off-by: Michael R. Hines --- migration-rdma.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index ea16f0e..6afe98c 100644 --- a/migration-rd

[Qemu-devel] [PATCH v3 For-1.6 1/7] rdma: bugfix: make IPv6 support work

2013-08-03 Thread mrhines
From: "Michael R. Hines" RDMA does not use sockets, so we cannot use many of the socket helper functions, but we *do* use inet_parse() which gives RDMA all the necessary details of the connection parameters. However, when testing with libvirt, a simple IPv6 migration test failed because we were

[Qemu-devel] [PATCH] tap: Use numbered tap/tun devices on all *BSD OS's

2013-08-03 Thread Brad Smith
The following patch simplifies the *BSD tap/tun code and makes use of numbered tap/tun interfaces on all *BSD OS's. NetBSD has a patch in their pkgsrc tree to make use of this feature and DragonFly also supports this as well. Signed-off-by: Brad Smith diff --git a/net/tap-bsd.c b/net/tap-bsd.c i

[Qemu-devel] [PATCH] rdma: memory leak RDMAContext::host

2013-08-03 Thread Isaku Yamahata
It is allocated by g_strdup(), so needs to be freed. Signed-off-by: Isaku Yamahata --- migration-rdma.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/migration-rdma.c b/migration-rdma.c index 4828738..2c15d95 100644 --- a/migration-rdma.c +++ b/migration-rdma.c @@ -2092,6 +2092,8 @@ s

Re: [Qemu-devel] [PATCH v2] Adds the ability to use the command key in the guest operating system.

2013-08-03 Thread Programmingkid
On Aug 3, 2013, at 7:06 PM, Peter Maydell wrote: > On 3 August 2013 23:52, G 3 wrote: >> This patch adds the ability to use the command key in the guest >> operating system. Just add -command-key 55 to the command line >> options sent to QEMU to use this feature. >> >> I have checked the patch

Re: [Qemu-devel] [PATCH v2] Adds the ability to use the command key in the guest operating system.

2013-08-03 Thread Peter Maydell
On 3 August 2013 23:52, G 3 wrote: > This patch adds the ability to use the command key in the guest > operating system. Just add -command-key 55 to the command line > options sent to QEMU to use this feature. > > I have checked the patch by sending it thru checkpatch.pl this time. I also > made

[Qemu-devel] [PATCH v2] Adds the ability to use the command key in the guest operating system.

2013-08-03 Thread G 3
This patch adds the ability to use the command key in the guest operating system. Just add -command-key 55 to the command line options sent to QEMU to use this feature. I have checked the patch by sending it thru checkpatch.pl this time. I also made a bunch of style changes to more closely match

[Qemu-devel] [PATCH for 1.6] mips: revert commit b332d24a8e1290954029814d09156b06ede358e2

2013-08-03 Thread Aurelien Jarno
Now that this code path is not triggered anymore during the tests, revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS target without kernel nor bios doesn't really make sense. Signed-off-by: Aurelien Jarno --- hw/mips/mips_fulong2e.c |3 ++- hw/mips/mips_jazz.c |3

Re: [Qemu-devel] [PATCH v2] target-mips: fix 34Kf configuration for DSP ASE

2013-08-03 Thread Aurelien Jarno
On Fri, Aug 02, 2013 at 10:33:43AM +0100, Yongbok Kim wrote: > 34Kf core does support DSP ASE. > CP0_Config3 configuration for 34Kf and description are wrong. > > Please refer to MIPS32(R) 34Kf(TM) Processor Core Datasheet > > Signed-off-by: Yongbok Kim > --- > changes from v1: > make status.MX

Re: [Qemu-devel] [PATCH] target-mips: fix decoding of microMIPS POOL32Axf instructions

2013-08-03 Thread Aurelien Jarno
On Thu, Aug 01, 2013 at 11:02:27AM +0100, Leon Alrae wrote: > These are not DSP instructions, thus there is no "ac" field. > > For more details please refer to instruction encoding of > MULT, MULTU, MADD, MADDU, MSUB, MSUBU, MFHI, MFLO, MTHI, MTLO in > MIPS Architecture for Programmers Volume II-B

Re: [Qemu-devel] default slot used for vga device on q35 machines

2013-08-03 Thread Laine Stump
On 08/02/2013 02:49 AM, Gerd Hoffmann wrote: > Hi, > >> qemu-kvm -M q35 -nodefaults -nodefconfig -qmp unix:/tmp/qemu,server >> -vnc :15 -vga std -usb >> >> Then ran "query-pci" in the qmp monitor and found that the vga device is >> put at slot 1 instead of slot 2. >> >> My questions: >> >> 1) I

[Qemu-devel] [#XJN-230-85435]: Re: [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-08-03 Thread TeamSpeak Piracy
Andreas Färber, Thank you for contacting us. This is an automated response confirming the receipt of your ticket. One of our agents will get back to you as soon as possible. For your records, the details of the ticket are listed below. When replying, please make sure that the ticket ID is kept in

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-08-03 Thread Andreas Färber
Am 26.07.2013 16:37, schrieb Paolo Bonzini: > Il 26/07/2013 14:51, Igor Mammedov ha scritto: >> On Fri, 26 Jul 2013 11:26:16 +0200 >> Paolo Bonzini wrote: >>> Il 26/07/2013 09:38, Igor Mammedov ha scritto: >> I agree that specifying the policy on every hotplug complicates >> management and

[Qemu-devel] [#ECQ-374-24898]: Re: Using virtio-mmio

2013-08-03 Thread TeamSpeak Piracy
Peter Maydell, Thank you for contacting us. This is an automated response confirming the receipt of your ticket. One of our agents will get back to you as soon as possible. For your records, the details of the ticket are listed below. When replying, please make sure that the ticket ID is kept in t

Re: [Qemu-devel] Using virtio-mmio

2013-08-03 Thread Peter Maydell
On 2 August 2013 18:48, Erlon Cruz wrote: > kernel: Linux 3.10-rc6 -> vexpress_defconfig > The kernel boots, but it cant mount the SD: > > mmc0: host doesn't support card's voltages > mmc0: error -22 whilst initialising SD card > SD: Unknown CMD1 The mainline kernel's vexpress_defconfig is know

[Qemu-devel] [#BPF-758-20959]: [PATCH 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-03 Thread TeamSpeak Piracy
Jan Kiszka, Thank you for contacting us. This is an automated response confirming the receipt of your ticket. One of our agents will get back to you as soon as possible. For your records, the details of the ticket are listed below. When replying, please make sure that the ticket ID is kept in the

[Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions"

2013-08-03 Thread Jan Kiszka
From: Jan Kiszka This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71. The commit was wrong: We only return -1 on invalid accesses, not on valid but unbacked ones. This broke various corner cases. Signed-off-by: Jan Kiszka --- memory.c |2 +- 1 files changed, 1 insertions(+), 1 de

[Qemu-devel] [PATCH 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-03 Thread Jan Kiszka
From: Jan Kiszka Accesses to unassigned io ports shall return -1 on read and be ignored on write. Ensure these properties via dedicated ops, decoupling us from the memory core's handling of unassigned accesses. Signed-off-by: Jan Kiszka --- exec.c|3 ++- include/exec/ioport