Now, There is websocket VNC available.
I can log in the terminal in VNC by web browser, but the performance of
this terminal is not very well.
IMO, we should a individual webscoket console.
Does qemu plan to support this feature?
--
Sheldon Feng(冯少合)
IBM Linux Technology Center
Pingfan,
--On 8 August 2013 14:21:34 +0800 liu ping fan wrote:
Go through this series, I can not find the caller of it. I think as
clock source, the QEMUClock can not be destroyed, except exit(2), so
could we let exit to reclaim the resource? Or at least, this interface
should not be public.
Executing slirp_pollfds_fill/_poll actions based on each slirp instance,
so we can decouple the slirp_pollfds_fill/_poll from main-loop.
Inside each slirp instance, it contains a GSource. The GSource holds a
group of GPollFD, which is the foundation of slirp-sockets. So the state-change
of GPollFD
Each slirp has its own time to caculate timeout.
Signed-off-by: Liu Ping Fan
---
slirp/slirp.c | 22 ++
slirp/slirp.h | 3 +++
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/slirp/slirp.c b/slirp/slirp.c
index 80b28ea..55654d5 100644
--- a/slirp/slirp.c
+++
On Wed, Aug 07, 2013 at 09:30:25PM +0200, Stefan Hajnoczi wrote:
> I have mixed feelings about removing coroutine_fn annotations from a
> function when it does not yield or call other coroutine_fn functions.
>
> These functions were probably written as part of a coroutine code path.
> The coroutin
In order to decouple with main loop, we fill timeout for gpoll
through slirp's GSource prepare. (Later, after curtime is decoupled,
slirp system will be self-contained, and isolated from main-loop)
Signed-off-by: Liu Ping Fan
---
slirp/slirp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletion
Introduce struct EventsGSource. It will ease the usage of GSource
associated with a group of files, which are dynamically allocated
and release, ex, slirp.
Signed-off-by: Liu Ping Fan
---
util/Makefile.objs | 1 +
util/event_gsource.c | 94
Each slirp instance will work on its own curtime updated when _prepare.
This patch help to fold the remaining main-loop's related stuff into GSource,
and isolated from main-loop.
Signed-off-by: Liu Ping Fan
---
main-loop.c | 3 ---
slirp/ip_icmp.c | 4 ++--
slirp/libslirp.h| 2
This series aims to port slirp onto GSource, so that it can be driven by
g_main_dispatch.
And clean up the #ifdef in main-loop.
Liu Ping Fan (5):
util: introduce gsource event abstraction
slirp: make timeout local
slirp: make slirp event dispatch based on slirp instance
slirp: decouple t
On Wed, Aug 7, 2013 at 7:48 AM, Alex Bligh wrote:
> Add qemu_clock_free and expose qemu_new_clock as qemu_clock_new.
>
> Expose clock types.
>
> Signed-off-by: Alex Bligh
> ---
> include/qemu/timer.h | 22 ++
> qemu-timer.c | 11 ++-
> 2 files changed, 28
On Thu, Aug 08, 2013 at 02:29:39AM +0100, Charlie Shepherd wrote:
> On 07/08/2013 23:13, Gabriel Kerneis wrote:
> >On Wed, Aug 07, 2013 at 09:18:05PM +0200, Stefan Hajnoczi wrote:
> >>I guess the practical problem is that CPC will get
> >>upset that it's being called by the coroutine implementation
On Wed, Aug 7, 2013 at 7:49 AM, Alex Bligh wrote:
> Split QEMUClock into QEMUClock and QEMUTimerList so that we can
> have more than one QEMUTimerList associated with the same clock.
>
> Introduce a default_timerlist concept and make existing
> qemu_clock_* calls that actually should operate on a
On 05/08/13 7:57 AM, Stefan Hajnoczi wrote:
On Sat, Aug 03, 2013 at 10:20:41PM -0400, Brad Smith wrote:
The following patch simplifies the *BSD tap/tun code and makes use of numbered
tap/tun interfaces on all *BSD OS's. NetBSD has a patch in their pkgsrc tree
to make use of this feature and Drag
On 08/07/2013 07:05 PM, mrhi...@linux.vnet.ibm.com wrote:
> From: "Michael R. Hines"
>
> getaddrinfo() already knows what it's doing,
> wqand can potentially return multiple addresses.
>
> Signed-off-by: Michael R. Hines
> ---
> migration-rdma.c | 56
> --
On Wed, Aug 07, 2013 at 09:29:39AM +0200, Gerd Hoffmann wrote:
> We'll need some way for seabios to fill in the pci window information
> into the qemu-provided tables. Easiest way to do that would be to
> extend the COMMAND_ADD_POINTER bios linker script command.
This idea certainly has an advant
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1208944
Title:
-kernel option broken for some multiboot kernels
Status in QEMU:
Fix Committe
On 08/01/2013 06:32 AM, Andreas Färber wrote:
> By default on KVM or when user asks for it via -cpu host, cpu_model will
> be "host" and sPAPR merely upper-cases it for the SLOF device tree.
>
> Change it so that we get the underlying CPU type, e.g., "POWER7_V2.3@0".
>
> Reported-by: Prerna Saxen
Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p.
Signed-off-by: Rusty Russell
---
hw/block/virtio-blk.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index cf12469.
Virtio is currently defined to work as "guest endian", but this is a
problem if the guest can change endian. As most targets can't change
endian, we make it a per-target option to avoid pessimising.
This is based on a simpler patch by Anthony Liguouri, which only handled
the vring accesses. We a
---
hw/char/virtio-serial-bus.c | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index cc3d1dd..0421725 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -2
Signed-off-by: Rusty Russell
---
hw/virtio/virtio-balloon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index d669756..c0b4f6e 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -30,6 +30,7
Signed-off-by: Rusty Russell
---
configure| 1 +
target-ppc/misc_helper.c | 8
2 files changed, 9 insertions(+)
diff --git a/configure b/configure
index ad32f87..cee32af 100755
--- a/configure
+++ b/configure
@@ -4217,6 +4217,7 @@ case "$target_name" in
ppc64)
TA
Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*_p.
Signed-off-by: Rusty Russell
---
hw/scsi/virtio-scsi.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 08dd3f3..c
Virtio is currently defined as "guest-endian", but that's a slippery
concept when the target can change endian. In particular, virtio devices
fail on little-endian powerpc 64.
Feedback welcome!
Rusty.
Rusty Russell (7):
virtio: allow byte swapping for vring and config access
target-ppc: ppc6
Signed-off-by: Rusty Russell
---
hw/char/virtio-serial-bus.c | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index cc3d1dd..0421725 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/
Signed-off-by: Rusty Russell
---
hw/net/virtio-net.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 1ea9556..e77e28d 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -21,6 +21,7 @@
#include "hw/virt
On 08/08/2013 12:22 AM, Andreas Färber wrote:
> Am 07.08.2013 09:26, schrieb Alexey Kardashevskiy:
>> On 08/07/2013 05:03 PM, Andreas Färber wrote:
>>> Am 07.08.2013 08:06, schrieb Alexey Kardashevskiy:
[...] How do I test it?
>>>
>>> ./QMP/qom-list to find the path, if not fixed in code yet,
On Wed, Aug 07, 2013 at 09:32:28PM -0400, Jeff Cody wrote:
> This patch series contains the initial VHDX log parsing, replay,
> and write support.
>
> === v3 changes ===
>
> Thank you Kevin & Stefan for the feedback; incoporated in v3:
>
> Patch 1: --- nil ---
>
> Patch 2: * use sizeof(crc) i
This adds support for writing to VHDX image files, using coroutines.
Writes into the BAT table goes through the VHDX log. Currently, BAT
table writes occur when expanding a dynamic VHDX file, and allocating a
new BAT entry.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 150 +++
This adds support for writing to the VHDX log.
For spec details, see VHDX Specification Format v1.00:
https://www.microsoft.com/en-us/download/details.aspx?id=34750
There are a few limitations to this log support:
1.) There is no caching yet
2.) The log is flushed after each entry
The primary wr
Allow tracking of first file write in the VHDX image, as well as
the ability to update the GUID in the header. This is in preparation
for log support.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 30 --
block/vhdx.h | 6 ++
2 files changed, 30 insertions(+), 6 de
This adds support for VHDX v0 logs, as specified in Microsoft's
VHDX Specification Format v1.00:
https://www.microsoft.com/en-us/download/details.aspx?id=34750
The following support is added:
* Log parsing, and validation - validate that an existing log
is correct.
* Log search - search throug
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation functions for log support are
added as well.
Signed-off-by: Jeff Cody
---
block/Makefile.objs | 2 +-
block/vhdx-e
In preparation for VHDX log support, move these structures to the
header.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 51 ---
block/vhdx.h | 47 +++
2 files changed, 47 insertions(+), 51 deletions(-)
dif
This adds some magic number defines, and internal structure definitions
for VHDX log replay support. The struct VHDXLogEntries does not reflect
an on-disk data structure, and thus does not need to be packed.
Some minor code style fixes are applied as well.
Signed-off-by: Jeff Cody
---
block/vh
This adds the ability to update the headers in a VHDX image, including
generating a new MS-compatible GUID.
As VHDX depends on uuid.h, VHDX is now a configurable build option. If
VHDX support is enabled, that will also enable uuid as well. The
default is to have VHDX enabled.
To enable/disable
Just a couple of minor comments to help note where allocated
buffers are freed, and a typo fix.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 6 --
block/vhdx.h | 6 +++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index e9704b1..56bc88e 100644
This patch series contains the initial VHDX log parsing, replay,
and write support.
=== v3 changes ===
Thank you Kevin & Stefan for the feedback; incoporated in v3:
Patch 1: --- nil ---
Patch 2: * use sizeof(crc) instead of 4
* remove outdated comment
* use sizeof(MSGUID) in
On 07/08/2013 20:30, Stefan Hajnoczi wrote:
On Mon, Aug 05, 2013 at 08:33:10PM +0100, Charlie Shepherd wrote:
On 05/08/2013 20:23, Gabriel Kerneis wrote:
On Mon, Aug 05, 2013 at 08:44:05PM +0200, Charlie Shepherd wrote:
diff --git a/include/block/coroutine_int.h b/include/block/coroutine_int.h
On 07/08/2013 23:13, Gabriel Kerneis wrote:
On Wed, Aug 07, 2013 at 09:18:05PM +0200, Stefan Hajnoczi wrote:
I guess the practical problem is that CPC will get
upset that it's being called by the coroutine implementation from
non-coroutine contexts.
But is it really the case? If Charlie added a
On 07/08/2013 20:18, Stefan Hajnoczi wrote:
On Mon, Aug 05, 2013 at 08:44:04PM +0200, Charlie Shepherd wrote:
From: Charlie Shepherd
While it only really makes sense to call qemu_coroutine_self() in a coroutine
context, it cannot actually yield execution itself, so remove the coroutine_fn
anno
On 06/08/2013 10:37, Kevin Wolf wrote:
Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben:
This patch series is a follow up to a previous RFC about converting functions
that dynamically yield execution depending on whether they are in executing in
a coroutine context or not to be explicitly
On 06/08/2013 09:39, Stefan Hajnoczi wrote:
On Mon, Aug 05, 2013 at 08:44:03PM +0200, Charlie Shepherd wrote:
From: Charlie Shepherd
Coroutine functions that can yield directly or indirectly should be annotated
with a coroutine_fn annotation. Add an explanation to that effect in
include/block/
On 05/08/2013 21:15, Gabriel Kerneis wrote:
On Mon, Aug 05, 2013 at 08:44:07PM +0200, Charlie Shepherd wrote:
This patch updates the callers of block layer functions converted to explicit
coroutine_fn annotation in the previous patch.
It looks like this patch is made of three parts:
- updating
On 06/08/2013 10:36, Kevin Wolf wrote:
Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben:
This patch follows on from the previous one and converts some block layer
functions to be
explicitly annotated with coroutine_fn instead of yielding depending upon
calling context.
---
block.c
On 06/08/2013 10:24, Kevin Wolf wrote:
Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben:
This patch converts the .bdrv_open, .bdrv_file_open and .bdrv_create members of
struct BlockDriver
to be explicitly annotated as coroutine_fn, rather than yielding dynamically
depending on whether
t
At Wed, 7 Aug 2013 16:59:53 +0800,
Liu Yuan wrote:
>
> With this patch, qemu-img info sheepdog:image will show disk size for sheepdog
> images.
>
> Cc: Kevin Wolf
> Cc: Stefan Hajnoczi
> Cc: MORITA Kazutaka
> Signed-off-by: Liu Yuan
> ---
> block/sheepdog.c | 19 +++
> 1 f
On Sun, Mar 31, 2013 at 01:02:22PM +0200, Aurelien Jarno wrote:
> The PCLMULQDQ instruction has been introduced on the Westmere CPU.
>
> Reviewed-by: Richard Henderson
> Reviewed-by: Edgar E. Iglesias
> Signed-off-by: Aurelien Jarno
> ---
> target-i386/cpu.c |2 +-
> 1 file changed, 1 inse
On Wed, Aug 07, 2013 at 09:18:05PM +0200, Stefan Hajnoczi wrote:
> I guess the practical problem is that CPC will get
> upset that it's being called by the coroutine implementation from
> non-coroutine contexts.
But is it really the case? If Charlie added an annotation, it probably means
that in p
> I saw more discussion on IRC. Does this mean you will send another
> revision to address outstanding issues?
>
> Just wanted to check if you are waiting for code review or if you are
> still developing the next patch revision.
I am currently finishing to write unit tests for the next patch rev
QEMU executables for w32, w64 had included meta information built from
version.rc. These rules were changed several times some months ago.
The latest version added version.o to the tools, but not to the system
emulations.
This patch adds the meta information to all system emulations again.
It bu
Don't we really want this too?
commit 2a9aeabdfb34374ecac25e7a8d21c9e368618cd4
Author: Kevin O'Connor
Date: Sun Jul 14 13:55:52 2013 -0400
Fix USB EHCI detection that was broken in hlist conversion of
PCIDevices.
Make sure t
Hi,
On behalf of the QEMU Team, I'd like to announce the availability of the
third release candidate for the QEMU 1.6 release. This release is meant
for testing purposes and should not be used in a production environment.
http://wiki.qemu.org/download/qemu-1.6.0-rc2.tar.bz2
You can help improve
On Mon, Aug 05, 2013 at 08:33:10PM +0100, Charlie Shepherd wrote:
> On 05/08/2013 20:23, Gabriel Kerneis wrote:
> >On Mon, Aug 05, 2013 at 08:44:05PM +0200, Charlie Shepherd wrote:
> >>diff --git a/include/block/coroutine_int.h b/include/block/coroutine_int.h
> >>index f133d65..d0ab27d 100644
> >>-
On Mon, Aug 05, 2013 at 08:44:04PM +0200, Charlie Shepherd wrote:
> From: Charlie Shepherd
>
> While it only really makes sense to call qemu_coroutine_self() in a coroutine
> context, it cannot actually yield execution itself, so remove the coroutine_fn
> annotation.
> ---
> include/block/corout
On 08/05/13 21:40, Seiji Aguchi wrote:
> Convert stderr messages calling error_get_pretty()
> to error_report().
>
> Timestamp is prepended by -msg timstamp option with it.
>
> Per Markus's comment below, A conversion from fprintf() to
> error_report() is always an improvement, regardless of
> e
On Wed, Aug 07, 2013 at 05:29:04PM +0200, Kevin Wolf wrote:
> Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
> > This moves the endian translation functions out from the vhdx.c source,
> > into a separate source file. In addition to the previously defined
> > endian functions, new endian transla
Paolo,
--On 7 August 2013 11:43:58 -0400 Paolo Bonzini wrote:
For anyone wishing to review this series, here's a diagram showing the
new relationships and a summary of this series:
http://vmsplice.net/~stefan/timerlist.jpg
TimerList is the list of QEMUTimers which are pending on a QEMUClock
On Wed, Aug 07, 2013 at 05:22:45PM +0200, Kevin Wolf wrote:
> Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
> > This adds some magic number defines, and internal structure
> > definitions for VHDX log replay support.
> >
> > Signed-off-by: Jeff Cody
> > ---
> > block/vhdx.h | 21
From: "Michael R. Hines"
getaddrinfo() already knows what it's doing,
wqand can potentially return multiple addresses.
Signed-off-by: Michael R. Hines
---
migration-rdma.c | 56 --
1 file changed, 29 insertions(+), 27 deletions(-)
diff --g
From: Isaku Yamahata
resp.len is given from remote host. So should be validated before use.
Otherwise memcpy can access beyond the buffer.
Cc: Michael R. Hines
Reviewed-by: Orit Wasserman
Reviewed-by: Michael R. Hines
Signed-off-by: Isaku Yamahata
Signed-off-by: Michael R. Hines
---
migrat
From: "Michael R. Hines"
Some nice buffer-overrun checks and fixing incorrect usage of getaddrinfo()
Isaku Yamahata (3):
rdma: use resp.len after validation in qemu_rdma_registration_stop
rdma: validate RDMAControlHeader::len
rdma: check if RDMAControlHeader::len match transferred byte
Mi
From: Isaku Yamahata
RMDAControlHeader::len is provided from remote, so validate it.
Reviewed-by: Orit Wasserman
Reviewed-by: Michael R. Hines
Signed-off-by: Isaku Yamahata
Signed-off-by: Michael R. Hines
---
migration-rdma.c |5 +
1 file changed, 5 insertions(+)
diff --git a/migra
From: Isaku Yamahata
RDMAControlHeader::len is provided from remote, so check if the value
match the actual transferred byte_len.
Reviewed-by: Orit Wasserman
Reviewed-by: Michael R. Hines
Signed-off-by: Isaku Yamahata
Signed-off-by: Michael R. Hines
---
migration-rdma.c | 32 +
On Aug 07 2013, Alex Bligh wrote:
>
> --On 7 August 2013 13:31:07 +0200 Stefan Hajnoczi
> wrote:
>
> > Regarding doc comments: if the function is self-documenting then the doc
> > comment might not add much. I think in those cases it's okay to omit
> > details about arguments or return values i
> For anyone wishing to review this series, here's a diagram showing the
> new relationships and a summary of this series:
>
> http://vmsplice.net/~stefan/timerlist.jpg
>
> TimerList is the list of QEMUTimers which are pending on a QEMUClock
> clock source.
I just started reviewing this and the
Register QGA VSS provider library into Windows when qemu-ga is installed as
Windows service ('-s install' option). It is deregistered when the service
is uninstalled ('-s uninstall' option).
Signed-off-by: Tomoki Sekiyama
Reviewed-by: Michael Roth
---
qga/main.c | 10 +-
qga/vss-
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy
disk I/O is running. To avoid unexpected timeout, this changes the timeout
to 60 seconds (timeout of pre-commit phase of VSS).
Signed-off-by: Tomoki Sekiyama
Reviewed-by: Paolo Bonzini
Reviewed-by: Laszlo Ersek
Reviewed-by:
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script
to extract VSS SDK headers on POSIX-systems using msitools.
* http://www.microsoft.com/en-us/download/details.aspx?id=23490
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Tomoki Sekiyama
Reviewed-by: Laszlo
These functions help maintaining homogeneous formatting of error messages
with Windows error code and description (generated by
g_win32_error_message()).
Signed-off-by: Tomoki Sekiyama
Reviewed-by: Michael Roth
---
include/qapi/error.h | 13 +
util/error.c | 35 +
Hi,
I rebased the patch series to add fsfreeze for Windows qemu-ga.
changes from v9:
- Fix conflict with commit e8ef31a3518c "qemu-ga: build it even if !system"
changes from v8:
- Add hEventTimeout to improve timeout error message (patch 07, see below)
- Build qga-vss.tlb if configure'd --wi
Add c++ keywords to avoid errors in compiling with c++ compiler.
This also renames class member of PciDeviceInfo to q_class.
Signed-off-by: Tomoki Sekiyama
Reviewed-by: Laszlo Ersek
Reviewed-by: Michael Roth
---
hmp.c |2 +-
hw/pci/pci.c|2 +-
scripts/qapi.py | 12 +
To enable VSS support in qemu-ga for Windows, header files included in
VSS SDK are required.
The VSS support is enabled by the configure option like below:
./configure --with-vss-sdk="/path/to/VSS SDK"
If the path is omitted, it tries to search the headers from default paths
and VSS support is e
Support guest-fsfreeze-freeze and guest-fsfreeze-thaw commands for Windows
guests. When fsfreeze command is issued, it calls the VSS requester to
freeze filesystems and applications. On thaw command, it again tells the VSS
requester to thaw them.
This also adds calling of initialize functions for
Enable checkpatch.pl to apply the same checks as C source files for
C++ files with .cpp extensions. It also adds some exceptions for C++
sources to suppress errors for:
- <> used in C++ template arguments (e.g. template )
- :: used to represent namespaces (e.g. SomeClass::method())
- : used
Add configuration for C++ compiler in configure and Makefiles.
The C++ compiler is choosed as following:
- ${CXX}, if it is specified.
- ${cross_prefix}g++, if ${cross_prefix} is specified.
- Otherwise, c++ is used.
Currently, usage of C++ language is only for access to Windows VSS
using COM+ s
Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
> This moves the endian translation functions out from the vhdx.c source,
> into a separate source file. In addition to the previously defined
> endian functions, new endian translation functions for log support are
> added as well.
>
> Signed-off-
Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
> This adds some magic number defines, and internal structure
> definitions for VHDX log replay support.
>
> Signed-off-by: Jeff Cody
> ---
> block/vhdx.h | 21 -
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --g
On 08/06/2013 10:26 PM, Isaku Yamahata wrote:
RDMAControlHeader::len is remote-provided. So validate the value before use.
Isaku Yamahata (3):
rdma: use resp.len after validation in qemu_rdma_registration_stop
rdma: validate RDMAControlHeader::len
rdma: check if RDMAControlHeader::len m
On 08/07/2013 04:39 AM, Orit Wasserman wrote:
On 08/04/2013 05:54 AM, mrhi...@linux.vnet.ibm.com wrote:
From: "Michael R. Hines"
RDMA does not use sockets, so we cannot use many of the socket
helper functions, but we *do* use inet_parse() which gives
RDMA all the necessary details of the conne
On Thu, Aug 01, 2013 at 03:44:41PM +0200, Stefan Hajnoczi wrote:
> On Wed, Jul 31, 2013 at 11:23:47PM -0400, Jeff Cody wrote:
> > @@ -212,6 +242,24 @@ bool vhdx_checksum_is_valid(uint8_t *buf, size_t size,
> > int crc_offset)
> >
> >
> > /*
> > + * This generates a UUID that is compliant with
Your observation is correct, but this is already fixed upstream:
commit 628e54857a82a3cb65ef96c12640c30d6307a064
Author: Gerd Hoffmann
Date: Wed Jun 12 13:17:02 2013 +0200
usb-host-libusb: set USB_DEV_FLAG_IS_HOST
** Changed in: qemu
Status: New => Fix Committed
--
You received t
Am 07.08.2013 09:26, schrieb Alexey Kardashevskiy:
> On 08/07/2013 05:03 PM, Andreas Färber wrote:
>> Am 07.08.2013 08:06, schrieb Alexey Kardashevskiy:
>>> [...] How do I test it?
>>
>> ./QMP/qom-list to find the path, if not fixed in code yet, and
>
> Something is wrong. XICS does not have an id
Public bug reported:
After the patch at http://lists.nongnu.org/archive/html/qemu-
devel/2013-05/msg01567.html, I cannot get my Logitech Unifying USB
receiver passed to the guest anymore.
Minimal reproduction command:
qemu-system-x86_64 -usbdevice host:046d:c52b
Debug patch:
diff --git a/h
On Fri, Aug 2, 2013 at 9:35 AM, Anthony Liguori wrote:
> Applied. Thanks.
>
> Where can I find this branch?
> Regards,
>
> Anthony Liguori
>
>
>
On Sat, Aug 3, 2013 at 7:03 AM, Peter Maydell wrote:
> On 2 August 2013 18:48, Erlon Cruz wrote:
> > kernel: Linux 3.10-rc6 -> vexpress_defconfig
>
> > The kernel boots, but it cant mount the SD:
> >
> > mmc0: host doesn't support card's voltages
> > mmc0: error -22 whilst initialising SD card
>
Andreas Färber writes:
> Am 07.08.2013 02:47, schrieb Anton Blanchard:
>> On POWER7, LPCR_ILE is used to control what endian guests take
>> their exceptions in so use it instead of MSR_ILE.
>>
>> Signed-off-by: Anton Blanchard
>> ---
>> target-ppc/cpu.h | 2 ++
>> target-ppc/excp_help
--On 7 August 2013 13:31:07 +0200 Stefan Hajnoczi
wrote:
Regarding doc comments: if the function is self-documenting then the doc
comment might not add much. I think in those cases it's okay to omit
details about arguments or return values if they are clear from the
function prototype.
G
On Wed, Aug 07, 2013 at 12:48:55AM +0100, Alex Bligh wrote:
> Add qemu_clock_free and expose qemu_new_clock as qemu_clock_new.
>
> Expose clock types.
>
> Signed-off-by: Alex Bligh
> ---
> include/qemu/timer.h | 22 ++
> qemu-timer.c | 11 ++-
> 2 files c
On Wed, Aug 07, 2013 at 12:48:55AM +0100, Alex Bligh wrote:
I forgot to mention that there's no need to change the doc comments
you've already written. I just wanted to share that to save you work in
the future.
On Wed, Aug 07, 2013 at 06:21:25PM +1000, Alexey Kardashevskiy wrote:
> From: David Gibson
>
> A PCI device's DMA address space (possibly an IOMMU) is returned by a
> method on the PCIBus. At the moment that only has one caller, so the
> method is simply open coded. We'll need another caller fo
--On 7 August 2013 09:27:36 +0200 Stefan Hajnoczi
wrote:
Do you think we need to wrap timer_mod, timer_del, timer_free
etc. to make aio_timer_mod and so forth, even though they are
a straight pass through?
Those wrappers are not necessary. Once the caller has their QEMUTimer
pointer they
--On 7 August 2013 09:21:17 +0200 Stefan Hajnoczi
wrote:
How do I actually run the code (i.e. how do I test whether I've broken
it)? I take it that's something different from just 'make check'?
make check includes qtest test cases like rtc-test, i440fx-test,
fdc-test, and others. As long
Stefan,
Some tips on which packages to install:
host big endian no
gprof enabled no
sparse enabledno
strip binariesno
profiler no
static build no
All the ones above are okay, fine to ignore.
SDL support no
Do you have libsdl1.2-dev installed?
ii libsd
On Mon, Aug 05, 2013 at 03:27:25PM +0200, Andreas Färber wrote:
> Adopt error_report() while at it.
>
> Signed-off-by: Andreas Färber
> ---
> hw/block/tc58128.c | 10 ++
> hw/sh4/shix.c | 9 +
> 2 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/hw/block/tc
On Mon, Aug 05, 2013 at 03:27:24PM +0200, Andreas Färber wrote:
> Signed-off-by: Andreas Färber
> ---
> hw/sh4/shix.c | 7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
> index 84dd666..66cbea4 100644
> --- a/hw/sh4/shix.c
> +++ b/hw/sh4/shix.c
> @@ -50,
On Mon, Aug 05, 2013 at 03:27:07PM +0200, Andreas Färber wrote:
> Signed-off-by: Andreas Färber
> ---
> hw/mips/mips_mipssim.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c
> index fea1a15..d8c4347 100644
> --- a/hw/mi
With this patch, qemu-img info sheepdog:image will show disk size for sheepdog
images.
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
Cc: MORITA Kazutaka
Signed-off-by: Liu Yuan
---
block/sheepdog.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/block/sheepdog.c b/block/sheepd
On 08/07/2013 05:26 AM, Isaku Yamahata wrote:
> RDMAControlHeader::len is remote-provided. So validate the value before use.
>
> Isaku Yamahata (3):
> rdma: use resp.len after validation in qemu_rdma_registration_stop
> rdma: validate RDMAControlHeader::len
> rdma: check if RDMAControlHeader
On PPC64 systems MSI Messages are translated to system IRQ in a PCI
host bridge. This is already supported for emulated MSI/MSIX but
not for irqfd where the current QEMU allocates IRQ numbers from
irqchip and maps MSIMessages to those IRQ in the host kernel.
The patch extends irqfd support in orde
1 - 100 of 134 matches
Mail list logo
