Re: [Qemu-devel] [RFC 0/2] target-arm: Provide '-cpu host' when running KVM

2013-08-13 Thread Alexander Graf
On 13.08.2013, at 20:03, Peter Maydell wrote: > These patches add support to target-arm for '-cpu host'. > The general semantics are the same as for ppc and x86 (ie "whatever > the host kernel can support that looks basically like the host > CPU"), but the mechanism is a little different. > > Th

[Qemu-devel] [PATCH v2 2/2] hw/openrisc: avoid undefined shift in openrisc_pic_cpu_handler()

2013-08-13 Thread Xi Wang
In C99 signed shift (1 << 31) is undefined behavior, since the result exceeds INT_MAX. Use 1U instead and move the shift after the check. Cc: Jia Liu Cc: Paolo Bonzini Signed-off-by: Xi Wang --- hw/openrisc/pic_cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/op

[Qemu-devel] [PATCH v2 1/2] hw/openrisc: fix masking in openrisc_pic_cpu_handler()

2013-08-13 Thread Xi Wang
Consider the masking of PICSR and PICMR: ((cpu->env.picsr && (1 << i)) && (cpu->env.picmr && (1 << i))) To correctly mask bits, we should use the bitwise AND "&" rather than the logical AND "&&". Also, the loop is not necessary for masking. Simply use (cpu->env.picsr & cpu->env.picmr). Cc:

Re: [Qemu-devel] [PATCH v2 1/4] target-arm: Allow raw_read() and raw_write() to handle 64 bit regs

2013-08-13 Thread Edgar E. Iglesias
On Fri, Aug 09, 2013 at 05:17:57PM +0100, Peter Maydell wrote: > Extend the raw_read() and raw_write() helper accessors so that > they can be used for 64 bit registers as well as 32 bit registers. > Reviewed-by: Edgar E. Iglesias > Signed-off-by: Peter Maydell > Tested-by: Laurent Desnogues >

Re: [Qemu-devel] [PATCH v2 2/4] target-arm: Support coprocessor registers which do I/O

2013-08-13 Thread Edgar E. Iglesias
On Fri, Aug 09, 2013 at 05:17:58PM +0100, Peter Maydell wrote: > Add an ARM_CP_IO flag which an ARMCPRegInfo definition can use to > indicate that the register's implementation does I/O and thus > its accesses need to be surrounded by gen_io_start()/gen_io_end() > in order for icount to work. Most

Re: [Qemu-devel] Free BIOS for MIPS Malta (was: mips_malta: do not raise exceptions when accessing invalid memory)

2013-08-13 Thread Stefan Weil
Am 13.08.2013 23:26, schrieb Aurelien Jarno: > On Tue, Aug 13, 2013 at 10:20:41PM +0100, Peter Maydell wrote: >> On 13 August 2013 22:15, Aurelien Jarno wrote: >>> I agree that Andreas is taking time to update the various devices, >>> thanks. That said he's not the one who has introduced this new

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.5.3, freeze on 2013-08-16

2013-08-13 Thread Doug Goldstein
On Tue, Aug 13, 2013 at 10:10 AM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.5.3: > > https://github.com/mdroth/qemu/commits/stable-1.5-staging > > The release is planned for 2013-08-21: > > http://wiki.qemu.org/Planning/1.5 > > Please respond he

Re: [Qemu-devel] [PATCH 1/8] virtio_get_byteswap: function for endian-ambivalent targets using virtio.

2013-08-13 Thread Rusty Russell
Benjamin Herrenschmidt writes: > On Tue, 2013-08-13 at 13:50 +0930, Rusty Russell wrote: >> We can have it call once (eg. when the first and storing the status >> word) and store the result. > > And fail with kexec of a different endian kernel :-) Let's not bother > yet. Merge it and then we see i

[Qemu-devel] [PATCH v2 3/3] slirp: set mainloop timeout with more precise value

2013-08-13 Thread Liu Ping Fan
If slirp needs to emulate tcp timeout, then the timeout value for mainloop should be more precise, which is determined by slirp's fasttimo or slowtimo. Achieve this by swap the logic sequence of slirp_pollfds_fill and slirp_update_timeout. Signed-off-by: Liu Ping Fan --- main-loop.c | 3 +-

[Qemu-devel] [PATCH v2 1/3] slirp: make timeout local

2013-08-13 Thread Liu Ping Fan
Each slirp has its own time to caculate timeout. Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 22 ++ slirp/slirp.h | 3 +++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 80b28ea..b71c617 100644 --- a/slirp/slirp.c +++

[Qemu-devel] [PATCH v2 0/3]

2013-08-13 Thread Liu Ping Fan
These patches are separated from "[PATCH v1 0/5] make slirp subsystem self-contained", as Paolo suggested. With them, we can set the mainloop timeout more precisely when slirp has to emulate tcp timeout problem. v2: fold slirp_update_timeout logic into slirp_pollfds_fill. Liu Ping Fan (3):

[Qemu-devel] [PATCH v2 2/3] slirp: define timeout as macro

2013-08-13 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index b71c617..c224523 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -47,6 +47,9 @@ static QTAILQ_HEAD(slirp_instances, Slirp) slirp_instanc

[Qemu-devel] question about gdb + qemu

2013-08-13 Thread Peter Cheung
Hi2. I have compile my qemu to --target-list=x86_64-softmmu , in gdb, why the registers is 32 bits? (gdb) i reax0x0 0ecx0xf7247edx 0x19a804 1681412ebx0x137 311esp0x19a0d0 0x19a0d0ebp0x9000 0x9000es

[Qemu-devel] [Bug Report] Compile error in current uq/master

2013-08-13 Thread Arthur Chunqi Li
Hi Paolo and Vincenzo, Here is a compile error in current uq/master (ca916d3729564d0eb3c2374a96903f7e8aced8a7) as follows: /root/qemu-kvm.git/kvm-stub.c:138:5: error: conflicting types for 'kvm_irqchip_add_irqfd_notifier' /root/qemu-kvm.git/include/sysemu/kvm.h:312:5: note: previous declaration o

Re: [Qemu-devel] Are there plans to achieve ram live Snapshot feature?

2013-08-13 Thread Wenchao Xia
于 2013-8-13 16:21, Stefan Hajnoczi 写道: On Tue, Aug 13, 2013 at 4:53 AM, Wenchao Xia wrote: 于 2013-8-12 19:33, Stefan Hajnoczi 写道: On Mon, Aug 12, 2013 at 12:26 PM, Alex Bligh wrote: --On 12 August 2013 11:59:03 +0200 Stefan Hajnoczi wrote: The idea that was discussed on qemu-devel@nongn

Re: [Qemu-devel] Using aio_poll for timer carrier threads

2013-08-13 Thread liu ping fan
On Tue, Aug 13, 2013 at 10:13 PM, Jan Kiszka wrote: > On 2013-08-13 15:45, Stefan Hajnoczi wrote: >> On Tue, Aug 13, 2013 at 09:56:17AM +0200, Jan Kiszka wrote: >>> in the attempt to use Alex' ppoll-based timer rework for decoupled, >>> real-time capable timer device models I'm now scratching my h

Re: [Qemu-devel] [PATCH v2 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-13 Thread liu ping fan
On Tue, Aug 13, 2013 at 10:53 PM, Paolo Bonzini wrote: > > Il 13/08/2013 07:43, Liu Ping Fan ha scritto: > > After disabling the QemuClock, we should make sure that no QemuTimers > > are still in flight. To implement that with light overhead, we resort > > to QemuEvent. The caller of disabling wil

Re: [Qemu-devel] Test report for xen-unstable and qemu-xen

2013-08-13 Thread Kevin O'Connor
On Tue, Aug 13, 2013 at 03:26:43PM +0200, Fabio Fantoni wrote: > Il 13/08/2013 13:09, Laszlo Ersek ha scritto: > >On 08/13/13 12:33, Fabio Fantoni wrote: > >>Il 13/08/2013 12:04, Laszlo Ersek ha scritto: > >>>On 08/13/13 11:16, Fabio Fantoni wrote: > Il 12/08/2013 17:04, Fabio Fantoni ha scritt

Re: [Qemu-devel] [PATCH] Introduce cache images for the QCOW2 format

2013-08-13 Thread Alex Bligh
--On 13 August 2013 19:03:56 +0200 Kaveh Razavi wrote: Also, simultaneously booting VMs from more than one VM image creates a bottleneck at the storage device of the base image, if the storage device does not fair well with the random access pattern that happens during booting. Additional

Re: [Qemu-devel] [PATCH] Introduce cache images for the QCOW2 format

2013-08-13 Thread Alex Bligh
--On 13 August 2013 19:03:56 +0200 Kaveh Razavi wrote: This patch introduces a block-level caching mechanism by introducing a copy-on-read image that supports quota and goes in between the base image and copy-on-write image. This cache image can either be stored on the nodes that run VMs or o

Re: [Qemu-devel] [ceph-users] qemu-1.4.0 and onwards, linux kernel 3.2.x, ceph-RBD, heavy I/O leads to kernel_hung_tasks_timout_secs message and unresponsive qemu-process, [Bug 1207686]

2013-08-13 Thread James Harper
> > This looks like a different issue than Oliver's. I see one anomaly in the > log, where a rbd io completion is triggered a second time for no apparent > reason. I opened a separate bug > > http://tracker.ceph.com/issues/5955 > > and pushed wip-5955 that will hopefully shine some light

Re: [Qemu-devel] [PATCH] Introduce cache images for the QCOW2 format

2013-08-13 Thread Eric Blake
On 08/13/2013 11:03 AM, Kaveh Razavi wrote: > Using copy-on-write images with the base image stored remotely is common > practice in data centers. This saves significant network traffic by > avoiding the transfer of the complete base image. However, the data > blocks needed for a VM boot still need

Re: [Qemu-devel] [ceph-users] qemu-1.4.0 and onwards, linux kernel 3.2.x, ceph-RBD, heavy I/O leads to kernel_hung_tasks_timout_secs message and unresponsive qemu-process, [Bug 1207686]

2013-08-13 Thread Sage Weil
Hi Oliver, (Posted this on the bug too, but:) Your last log revealed a bug in the librados aio flush. A fix is pushed to wip-librados-aio-flush (bobtail) and wip-5919 (master); can you retest please (with caching off again)? Thanks! sage On Fri, 9 Aug 2013, Oliver Francke wrote: > Hi Josh,

Re: [Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-13 Thread Aurelien Jarno
On Tue, Aug 13, 2013 at 10:20:41PM +0100, Peter Maydell wrote: > On 13 August 2013 22:15, Aurelien Jarno wrote: > > I agree that Andreas is taking time to update the various devices, > > thanks. That said he's not the one who has introduced this new API, and > > that should not be a justification

Re: [Qemu-devel] [ceph-users] qemu-1.4.0 and onwards, linux kernel 3.2.x, ceph-RBD, heavy I/O leads to kernel_hung_tasks_timout_secs message and unresponsive qemu-process, [Bug 1207686]

2013-08-13 Thread Sage Weil
On Mon, 5 Aug 2013, Mike Dawson wrote: > Josh, > > Logs are uploaded to cephdrop with the file name mikedawson-rbd-qemu-deadlock. > > - At about 2013-08-05 19:46 or 47, we hit the issue, traffic went to 0 > - At about 2013-08-05 19:53:51, ran a 'virsh screenshot' > > > Environment is: > > - Ce

[Qemu-devel] [Bug 1211943] [NEW] #GP and aligned move instruction

2013-08-13 Thread lukasz1235
Public bug reported: When the operand of movaps, movapd or movdqa instruction isn't aligned, general-protection exception should be generated. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [PATCH] Introduce cache images for the QCOW2 format

2013-08-13 Thread Kaveh Razavi
Using copy-on-write images with the base image stored remotely is common practice in data centers. This saves significant network traffic by avoiding the transfer of the complete base image. However, the data blocks needed for a VM boot still need to be transfered to the node that runs the VM. On s

[Qemu-devel] [Bug 1211910] [NEW] Logical to linear address translation is wrong for 32-bit guests on a 64-bit hypervisor

2013-08-13 Thread Nils Asmussen
Public bug reported: I run a 64-bit hypervisor in qemu-system-x86_64 (without KVM) and on top of that I have a 32-bit guest. The guest configures the code-segment to have a base of 0x4000_ and a limit of 0x_ with paging disabled. Thus, if a logical address of e.g. 0xC000_ is use

Re: [Qemu-devel] [PATCH] slirp: Port redirection option behave differently on Linux and Windows

2013-08-13 Thread Eric Blake
On 08/13/2013 03:05 PM, Taimoor wrote: > From: Taimoor Mirza > > port redirection code uses SO_REUSEADDR socket option before binding to > host port. Behavior of SO_REUSEADDR is different on Windows and Linux. > Relaunching QEMU with same host and guest port redirection values on Linux > throws e

Re: [Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-13 Thread Peter Maydell
On 13 August 2013 22:15, Aurelien Jarno wrote: > I agree that Andreas is taking time to update the various devices, > thanks. That said he's not the one who has introduced this new API, and > that should not be a justification for removing the Malta board or even > the MIPS target from QEMU. Has

Re: [Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-13 Thread Aurelien Jarno
On Tue, Aug 13, 2013 at 09:45:28PM +0100, Peter Maydell wrote: > On 13 August 2013 21:23, Aurelien Jarno wrote: > > It's great that people improve QEMU by providing new APIs allowing more > > things. That said it's a real pitty that people providing a new API do > > not (always) convert devices to

[Qemu-devel] [PATCH] slirp: Port redirection option behave differently on Linux and Windows

2013-08-13 Thread Taimoor
From: Taimoor Mirza port redirection code uses SO_REUSEADDR socket option before binding to host port. Behavior of SO_REUSEADDR is different on Windows and Linux. Relaunching QEMU with same host and guest port redirection values on Linux throws error but on Windows it does not throw any error. Pr

Re: [Qemu-devel] [PATCH] slirp: Port redirection option behave differently on Linux and Windows

2013-08-13 Thread Taimoor Mirza
Thanks for reviewing the patch On Wed, Aug 14, 2013 at 1:21 AM, Stefan Weil wrote: > Am 13.08.2013 22:00, schrieb Taimoor: >> From: Taimoor Mirza >> >> port redirection code uses SO_REUSEADDR socket option before binding to >> host port. Behavior of SO_REUSEADDR is different on Windows and Linux

Re: [Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-13 Thread Peter Maydell
On 13 August 2013 21:23, Aurelien Jarno wrote: > It's great that people improve QEMU by providing new APIs allowing more > things. That said it's a real pitty that people providing a new API do > not (always) convert devices to the new API, as they are the one really > knowing and understanding it

Re: [Qemu-devel] [PATCH v2] Convert stderr message calling error_get_pretty() to error_report()

2013-08-13 Thread Luiz Capitulino
On Tue, 13 Aug 2013 20:27:15 + Seiji Aguchi wrote: > Luiz, > > Can you pick up to your tree? Yes, this is queued for review for 1.7. I should start reviewing patches for 1.7 in the end of this week or in the beginning of next week.

Re: [Qemu-devel] [PATCH v2] Convert stderr message calling error_get_pretty() to error_report()

2013-08-13 Thread Seiji Aguchi
Luiz, Can you pick up to your tree? Seiji > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, August 07, 2013 3:10 PM > To: Seiji Aguchi > Cc: qemu-devel@nongnu.org; arm...@redhat.com; Tomoki Sekiyama; > lcapitul...@redhat.com > Subject: Re: [Qemu-dev

Re: [Qemu-devel] [PATCH for-1.6] mips_malta: do not raise exceptions when accessing invalid memory

2013-08-13 Thread Aurelien Jarno
On Tue, Aug 13, 2013 at 02:32:07PM +0200, Andreas Färber wrote: > Am 13.08.2013 12:05, schrieb James Hogan: > > On 12 August 2013 20:44, Aurelien Jarno wrote: > >> Since commit c658b94f6e8c206c59d02aa6fbac285b86b53d2c, MIPS raises > >> exceptions when accessing invalid memory. This is not the corr

Re: [Qemu-devel] [PATCH] slirp: Port redirection option behave differently on Linux and Windows

2013-08-13 Thread Stefan Weil
Am 13.08.2013 22:00, schrieb Taimoor: > From: Taimoor Mirza > > port redirection code uses SO_REUSEADDR socket option before binding to > host port. Behavior of SO_REUSEADDR is different on Windows and Linux. > Relaunching QEMU with same host and guest port redirection values on Linux > throws err

[Qemu-devel] [PATCH] slirp: Port redirection option behave differently on Linux and Windows

2013-08-13 Thread Taimoor
From: Taimoor Mirza port redirection code uses SO_REUSEADDR socket option before binding to host port. Behavior of SO_REUSEADDR is different on Windows and Linux. Relaunching QEMU with same host and guest port redirection values on Linux throws error but on Windows it does not throw any error. Pr

Re: [Qemu-devel] QEMU savevm RAM page offsets

2013-08-13 Thread Laszlo Ersek
On 08/13/13 21:06, Juerg Haefliger wrote: > On Tue, Aug 13, 2013 at 8:07 PM, Paolo Bonzini wrote: >> Il 13/08/2013 19:52, Juerg Haefliger ha scritto: >>> I didn't mean to imply that the savevm format is broken and needed >>> fixing. I was just wondering if the data is there and I simply hadn't >>>

Re: [Qemu-devel] QEMU savevm RAM page offsets

2013-08-13 Thread Juerg Haefliger
On Tue, Aug 13, 2013 at 8:07 PM, Paolo Bonzini wrote: > Il 13/08/2013 19:52, Juerg Haefliger ha scritto: >> I didn't mean to imply that the savevm format is broken and needed >> fixing. I was just wondering if the data is there and I simply hadn't >> found it. Upgrading QEMU is not an option at th

Re: [Qemu-devel] [PULL stable-1.5 0/1] QOM CPUState stable patch queue 2013-08-13

2013-08-13 Thread Michael Roth
Quoting Andreas Färber (2013-08-13 12:30:48) > Hello Michael, > > The following changes since commit 58ef8c530ca5d265f575ef88e93c0214d5740b0a: > > vhost: clear signalled_used_valid on vhost stop (2013-08-13 10:04:40 -0500) > > are available in the git repository at: > > git://github.com/afa

[Qemu-devel] [RFC 2/2] target-arm: Provide '-cpu host' when running KVM

2013-08-13 Thread Peter Maydell
Implement '-cpu host' for ARM when we're using KVM, broadly in line with other KVM-supporting architectures. Signed-off-by: Peter Maydell --- target-arm/helper.c |6 ++ target-arm/kvm.c| 195 +++ 2 files changed, 201 insertions(+) diff --

[Qemu-devel] [RFC 1/2] target-arm: Don't hardcode KVM target CPU to be A15

2013-08-13 Thread Peter Maydell
Instead of assuming that a KVM target CPU must always be a Cortex-A15 and hardcoding this in kvm_arch_init_vcpu(), look up the KVM_ARM_TARGET_* value based on the ARMCPU object type. This is slightly overengineered for a single supported CPU but provides a place to put support for future CPUs and f

[Qemu-devel] KVM guest cpu L3 cache and cpufreq

2013-08-13 Thread Benoît Canet
Hi, I noticed that the l3 cache size of a guest /proc/cpuinfo is not the same as the l3 cache size of the host. I did not found any references to this in the qemu and KVM code. Is the size of the guest L3 cache fixed in hardware ? Can a patch be written to set it ? Similarly I noticed that th

Re: [Qemu-devel] QEMU savevm RAM page offsets

2013-08-13 Thread Paolo Bonzini
Il 13/08/2013 19:52, Juerg Haefliger ha scritto: > I didn't mean to imply that the savevm format is broken and needed > fixing. I was just wondering if the data is there and I simply hadn't > found it. Upgrading QEMU is not an option at the moment since these > are tightly controlled productions ma

[Qemu-devel] [RFC 0/2] target-arm: Provide '-cpu host' when running KVM

2013-08-13 Thread Peter Maydell
These patches add support to target-arm for '-cpu host'. The general semantics are the same as for ppc and x86 (ie "whatever the host kernel can support that looks basically like the host CPU"), but the mechanism is a little different. The kernel API (currently still proposed rather than implement

Re: [Qemu-devel] QEMU savevm RAM page offsets

2013-08-13 Thread Juerg Haefliger
On Tue, Aug 13, 2013 at 6:58 PM, Laszlo Ersek wrote: > (apologies for responding to myself) > > On 08/13/13 18:51, Laszlo Ersek wrote: >> On 08/13/13 18:03, Andreas Färber wrote: >>> Hi, >>> >>> Am 13.08.2013 15:30, schrieb Juerg Haefliger: I'm writing/extending a little tool (courtesy of And

[Qemu-devel] [PULL stable-1.5 0/1] QOM CPUState stable patch queue 2013-08-13

2013-08-13 Thread Andreas Färber
Hello Michael, The following changes since commit 58ef8c530ca5d265f575ef88e93c0214d5740b0a: vhost: clear signalled_used_valid on vhost stop (2013-08-13 10:04:40 -0500) are available in the git repository at: git://github.com/afaerber/qemu-cpu.git tags/qom-cpu-for-1.5 for you to fetch chang

[Qemu-devel] [PULL stable-1.5 1/1] pc: Remove PCLMULQDQ from Westmere on pc-*-1.4 and older

2013-08-13 Thread Andreas Färber
From: Eduardo Habkost Commit 41cb383f42d0cb51d8e3e25e3ecebc954dd4196f made a guest-visible change by adding the PCLMULQDQ bit to Westmere without adding compatibility code to keep the ABI for older machine-types. Fix it by adding the missing compat code. Signed-off-by: Eduardo Habkost Signed-of

Re: [Qemu-devel] QEMU savevm RAM page offsets

2013-08-13 Thread Laszlo Ersek
(apologies for responding to myself) On 08/13/13 18:51, Laszlo Ersek wrote: > On 08/13/13 18:03, Andreas Färber wrote: >> Hi, >> >> Am 13.08.2013 15:30, schrieb Juerg Haefliger: >>> I'm writing/extending a little tool (courtesy of Andrew @pikewerks) >>> that dumps the RAM pages from a savevm file

[Qemu-devel] [PATCH 36/56] gtk: don't use g_object_unref on GdkCursor

2013-08-13 Thread Michael Roth
From: Anthony Liguori It's not a GObject. Cc: Gerd Hoffman Reported-by: Michael Tokarev Signed-off-by: Anthony Liguori --- v1 -> v2 - Fix summary to agree with code (Peter) (cherry picked from commit 171392406d8e230d62e5ebf4805f71460854b8ec) Signed-off-by: Michael Roth --- ui/gtk.c |2

Re: [Qemu-devel] QEMU savevm RAM page offsets

2013-08-13 Thread Laszlo Ersek
On 08/13/13 18:03, Andreas Färber wrote: > Hi, > > Am 13.08.2013 15:30, schrieb Juerg Haefliger: >> I'm writing/extending a little tool (courtesy of Andrew @pikewerks) >> that dumps the RAM pages from a savevm file to a raw memory dump file >> so that it can be analysed using tools that require a

[Qemu-devel] [PATCH 10/56] block/ssh: Set bdrv_has_zero_init according to the file type.

2013-08-13 Thread Michael Roth
From: "Richard W.M. Jones" If the remote is a regular file, set it to true (ie. reads of uninitialized areas in a newly created file will return zeroes). If we can't prove that, return false (a safe default). Tested by adding a debugging print statement [not part of this commit] and creating a r

Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2

2013-08-13 Thread Michael Roth
Quoting Alexander Graf (2013-08-12 23:06:19) > Am 13.08.2013 um 03:07 schrieb Michael Roth : > > > Quoting Michael Roth (2013-08-12 20:05:32) > >> Quoting Stefan Weil (2013-07-26 00:12:59) > >>> Am 26.07.2013 04:03, schrieb jean-christophe manciot: > Public bug reported: > > Enviro

[Qemu-devel] [PATCH 33/56] cpus: Add return value for vm_stop()

2013-08-13 Thread Michael Roth
From: Kevin Wolf If flushing the block devices fails, return an error. The VM is stopped anyway. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi (cherry picked from commit 5698346391b306c2c84358c68ee897c095d714cc) Signed-off-by: Michael Roth --- cpus.c | 20 +++

[Qemu-devel] [PATCH 04/56] qxl: Fix QXLRam initialisation.

2013-08-13 Thread Michael Roth
From: Anthony PERARD The qxl driver expect NULL for QXLRam.memory_configs, but this is never initialized. If memory is set to 0xc2c2.., it leads to a spice-critical error when trying to start qxl. Signed-off-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev (cherry

[Qemu-devel] [PATCH 55/56] virtio: clear signalled_used_valid when switching from dataplane

2013-08-13 Thread Michael Roth
From: Stefan Hajnoczi When the dataplane thread stops, its vring.c implementation synchronizes vring state back to virtio.c so we can continue emulating the virtio device. This patch ensures that virtio.c's signalled_used_valid flag is reset so that we do not suppress guest notifications due to

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Anthony Liguori
Andreas Färber writes: > Am 13.08.2013 17:27, schrieb Paolo Bonzini: >> Il 13/08/2013 17:11, Andreas Färber ha scritto: >>> >>> mst suggested to patch stable-1.5 to disable it there, too. I am not >>> against but have doubts as to how well that works with migration, since >>> 1.5.3 is still a bit

Re: [Qemu-devel] [RFC 01/14] tcg-aarch64: Allow immediate operands to add and sub

2013-08-13 Thread Richard Henderson
On 08/13/2013 01:57 AM, Jay Foad wrote: >> -static inline void tcg_out_addi(TCGContext *s, int ext, >> -TCGReg rd, TCGReg rn, unsigned int aimm) >> +static void tcg_out_addi(TCGContext *s, int ext, TCGReg rd, TCGReg rn, >> + tcg_target_long ai

[Qemu-devel] [PATCH 37/56] gtk: Fix compiler warning (GTK 3 deprecated function)

2013-08-13 Thread Michael Roth
From: Stefan Weil With GTK 3, the function gdk_cursor_unref is deprecated: qemu/ui/gtk.c: In function ‘gd_cursor_define’: qemu/ui/gtk.c:380:5: error: ‘gdk_cursor_unref’ is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkcursor.h:233): Use 'g_object_unref' instead [-Werror=deprecated-decla

[Qemu-devel] [PATCH 07/56] usb-host-libusb: set USB_DEV_FLAG_IS_HOST

2013-08-13 Thread Michael Roth
From: Gerd Hoffmann ... like host-{linux,bsd}.c do. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann (cherry picked from commit 628e54857a82a3cb65ef96c12640c30d6307a064) Signed-off-by: Michael Roth --- hw/usb/host-libusb.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/

[Qemu-devel] [PATCH] ppc: virtex_ml507: QEMU_OPTION_dtb support for this machine.

2013-08-13 Thread Efimov Vasily
Signed-off-by: Efimov Vasily --- hw/ppc/virtex_ml507.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c index 08e77fb..a00f709 100644 --- a/hw/ppc/virtex_ml507.c +++ b/hw/ppc/virtex_ml507.c @@ -141,11 +141,18 @@ st

Re: [Qemu-devel] QEMU savevm RAM page offsets

2013-08-13 Thread Andreas Färber
Hi, Am 13.08.2013 15:30, schrieb Juerg Haefliger: > I'm writing/extending a little tool (courtesy of Andrew @pikewerks) > that dumps the RAM pages from a savevm file to a raw memory dump file > so that it can be analysed using tools that require a raw dump as > input. Can't you just use QEMU's gu

[Qemu-devel] [PATCH 38/56] dataplane: refuse to start if device is already in use

2013-08-13 Thread Michael Roth
From: Stefan Hajnoczi Dataplane must check whether a block device is in use before launching the dataplane thread. This is necessary since the thread does not synchronize with the main loop and I/O requests could cause corruption. One example is when a drive is added and a block job is started

[Qemu-devel] [PATCH 51/56] semaphore: fix a hangup problem under load on NetBSD hosts.

2013-08-13 Thread Michael Roth
From: Izumi Tsutsui Fix following bugs in "fallback implementation of counting semaphores with mutex+condvar" added in c166cb72f1676855816340666c3b618beef4b976: - waiting threads are not restarted properly if more than one threads are waiting unblock signals in qemu_sem_timedwait() - possibl

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Andreas Färber
Am 13.08.2013 17:27, schrieb Paolo Bonzini: > Il 13/08/2013 17:11, Andreas Färber ha scritto: >> >> mst suggested to patch stable-1.5 to disable it there, too. I am not >> against but have doubts as to how well that works with migration, since >> 1.5.3 is still a bit off and I would expect 1.5.2 ->

[Qemu-devel] [PATCH 12/56] vmdk: remove wrong calculation of relative path

2013-08-13 Thread Michael Roth
From: Fam Zheng When creating image with backing file, the driver tries to calculate the relative path from created image file to backing file, but the path computation is incorrect. e.g.: $ qemu-img create -f vmdk -b vmdk-data-disk.vmdk vmdk-data-snapshot1 Formatting 'vmdk-data-snapshot

Re: [Qemu-devel] [PATCH v2 1/4] seqlock: introduce read-write seqlock

2013-08-13 Thread Paolo Bonzini
Il 13/08/2013 16:53, Jan Kiszka ha scritto: >> > I agree. I was writing the patch without looking at any Linux code >> > (just to be safe since it's GPLv2-only) and misremembered the name of >> > the API. > Another reason to forget about v2+. ;) Anyway, I am fairly sure this code is not based on

[Qemu-devel] [PATCH 54/56] dataplane: sync virtio.c and vring.c virtqueue state

2013-08-13 Thread Michael Roth
From: Stefan Hajnoczi Load the virtio.c state into vring.c when we start dataplane mode and vice versa when stopping dataplane mode. This patch makes it possible to start and stop dataplane any time while the guest is running. This will eventually allow us to go back to QEMU main loop for bdrv_

[Qemu-devel] [PATCH 53/56] i82801b11: Fix i82801b11 PCI host bridge config space

2013-08-13 Thread Michael Roth
From: Gerd Hoffmann pci_bridge_write_config() was not being used. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann Signed-off-by: Andreas Färber Signed-off-by: Michael S. Tsirkin (cherry picked from commit 4965b7f056177ddfb816319e9ff5e766898d0bc5) Conflicts: hw/pci-bridge/i82

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Paolo Bonzini
Il 13/08/2013 17:11, Andreas Färber ha scritto: > > mst suggested to patch stable-1.5 to disable it there, too. I am not > against but have doubts as to how well that works with migration, since > 1.5.3 is still a bit off and I would expect 1.5.2 -> 1.6.0 migration to > work without guest-visible

[Qemu-devel] [PATCH 49/56] target-i386: Fix X86CPU error handling

2013-08-13 Thread Michael Roth
From: Andreas Färber Error **errp argument is not for emitting warnings, it means an error has occurred and the caller should not make any assumptions about the state of other return values (unless otherwise documented). Therefore cpu_x86_create() must unref the new X86CPU itself, and pc_new_cpu

[Qemu-devel] [PATCH 44/56] xhci: fix segfault

2013-08-13 Thread Michael Roth
From: Gerd Hoffmann Guest trying to reset a endpoint of a disconnected device resulted in xhci trying to dereference uport while being NULL, thereby crashing qemu. Fix that by adding a check. Drop unused dev variable while touching that code bit. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd

Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization

2013-08-13 Thread Michael S. Tsirkin
On Tue, Aug 13, 2013 at 05:11:08PM +0200, Andreas Färber wrote: > Am 13.08.2013 16:54, schrieb Paolo Bonzini: > > Il 13/08/2013 16:11, Anthony Liguori ha scritto: > Fix this up, clean up a trivial code duplication > and add a comment explaining why we special-case 1.5 > with respect

[Qemu-devel] [PATCH 40/56] qemu-char: Register ring buffer driver with correct name "ringbuf"

2013-08-13 Thread Michael Roth
From: Markus Armbruster The driver is new in 1.4, with the documented name "ringbuf". However, it's actual name is the completely undocumented "memory". Screwed up in commit 3949e59. Fix code to match documentation. Keep the undocumented name working as an alias for compatibility. Cc: qemu-sta

[Qemu-devel] [PATCH 56/56] vhost: clear signalled_used_valid on vhost stop

2013-08-13 Thread Michael Roth
From: "Michael S. Tsirkin" When vhost device stops, its implementation synchronizes kernel state back to virtio.c so we can continue emulating the device in userspace. This patch ensures that virtio.c's signalled_used_valid flag is reset so that userspace does not suppress guest notifications du

[Qemu-devel] [PATCH 42/56] virtio-console: Use exitfn for virtserialport, too

2013-08-13 Thread Michael Roth
From: Andreas Färber virtconsole and virtserialport are identical in every other aspect except for the distinguishing VirtIOSerialPortClass::is_console field. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber Signed-off-by: Andreas Färber Message-id: 1375313326-14966-1-git-send-email-af

[Qemu-devel] [PATCH 52/56] Bugfix for loading multiboot kernels

2013-08-13 Thread Michael Roth
From: Martijn van den Broek This patch fixes a bug in rom_copy introduced by commit d60fa42e8bae39440f997ebfe8fe328269a57d16. rom_copy failed to load roms with a "datasize" of 0. As a result, multiboot kernels were not loaded correctly when they contain a segment with a "file size" of 0. https:

[Qemu-devel] [PATCH 35/56] megasas: Legacy command line handling fix

2013-08-13 Thread Michael Roth
From: Andreas Färber Only apply legacy command line handling when the device has not been hot-plugged. Propagate failure of legacy command line handling. Cc: qemu-sta...@nongnu.org Acked-by: Paolo Bonzini Signed-off-by: Andreas Färber (cherry picked from commit 22d6aa03fd87ba5f219d26bc1810646d

[Qemu-devel] [PATCH 50/56] ignore SIGPIPE in qemu-img and qemu-io

2013-08-13 Thread Michael Roth
From: MORITA Kazutaka This prevents the tools from being stopped when they write data to a closed connection in the other side. Signed-off-by: MORITA Kazutaka Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf (cherry picked from commit 526eda14a68d5b3596be715505289b541288ef2a) Signed-off-

[Qemu-devel] [PATCH 46/56] seccomp: add arch_prctl() to the syscall whitelist

2013-08-13 Thread Michael Roth
From: Paul Moore It appears that even a very simple /etc/qemu-ifup configuration can require the arch_prctl() syscall, see the example below: #!/bin/sh /sbin/ifconfig $1 0.0.0.0 up /usr/sbin/brctl addif $1 Signed-off-by: Paul Moore Reviewed-by: Eduardo Otubo Message-i

[Qemu-devel] [PATCH 31/56] iscsi: assert that sectors are aligned to LUN blocksize

2013-08-13 Thread Michael Roth
From: Peter Lieven if the blocksize of an iSCSI LUN is bigger than the BDRV_SECTOR_SIZE it is possible that sector_num or nb_sectors are not correctly aligned. to avoid corruption we fail requests which are misaligned. Signed-off-by: Peter Lieven Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo

[Qemu-devel] [PATCH 48/56] iov: handle EOF in iov_send_recv

2013-08-13 Thread Michael Roth
From: MORITA Kazutaka Without this patch, iov_send_recv() never returns when do_send_recv() returns zero. Signed-off-by: MORITA Kazutaka Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf (cherry picked from commit 840042901710c2dc1a3ac3e5af9bed449c339701) Signed-off-by: Michael Roth ---

[Qemu-devel] [PATCH 34/56] cpus: Let vm_stop[_force_state]() always flush block devices

2013-08-13 Thread Michael Roth
From: Kevin Wolf Even if the VM is already stopped, we cannot assume that all data has already been successfully flushed to disk. The flush during the previous vm_stop() could have failed. Run bdrv_flush_all() unconditionally so that we get an error each time if the block device isn't really flu

[Qemu-devel] [PATCH 30/56] iscsi: remove support for misaligned nb_sectors in aio_readv

2013-08-13 Thread Michael Roth
From: Peter Lieven this hask is not working (anymore). support for misaligned offsets should be handled at the block layer. Signed-off-by: Peter Lieven Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini (cherry picked from commit 7e4d5a9f94a0d8485bf63e1f8256e0a0014495ab) Signed-off-by: M

[Qemu-devel] [PATCH 45/56] chardev: fix CHR_EVENT_OPENED events for mux chardevs

2013-08-13 Thread Michael Roth
As of bd5c51ee6c4f1c79cae5ad2516d711a27b4ea8ec, chardevs no longer use bottom-halves to issue CHR_EVENT_OPENED events. To maintain past semantics, we instead defer the CHR_EVENT_OPENED events toward the end of chardev initialization. For muxes, this isn't good enough, since a range of FEs must be

[Qemu-devel] [PATCH 39/56] xhci: handle USB_RET_IOERROR

2013-08-13 Thread Michael Roth
From: Gerd Hoffmann https://bugzilla.redhat.com/show_bug.cgi?id=980377 Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann (cherry picked from commit ed60ff024fdb0e7ca9c002af166e10683cf49805) Signed-off-by: Michael Roth --- hw/usb/hcd-xhci.c |1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PATCH 32/56] block: Add return value for bdrv_flush_all()

2013-08-13 Thread Michael Roth
From: Kevin Wolf bdrv_flush() can fail, and bdrv_flush_all() should return an error as well if this happens for a block device. It returns the first error return now, but still at least tries to flush the remaining devices even in error cases. Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajno

[Qemu-devel] [PATCH 27/56] qapi: qapi-commands: fix possible leaks on visitor dealloc

2013-08-13 Thread Michael Roth
From: Luiz Capitulino In qmp-marshal.c the dealloc visitor calls use the same errp pointer of the input visitor calls. This means that if any of the input visitor calls fails, then the dealloc visitor will return early, before freeing the object's memory. Here's an example, consider this code:

[Qemu-devel] [PATCH 47/56] seccomp: add additional asynchronous I/O syscalls

2013-08-13 Thread Michael Roth
From: Paul Moore A previous commit, "seccomp: add the asynchronous I/O syscalls to the whitelist", added several asynchronous I/O syscalls but left out the io_submit() and io_cancel() syscalls. This patch corrects this by adding the two missing asynchronous I/O syscalls. Signed-off-by: Paul Moo

[Qemu-devel] [PATCH 29/56] iscsi: fix -ENOSPC in iscsi_create()

2013-08-13 Thread Michael Roth
From: Peter Lieven the -ENOPSC case did not work due to the missing goto. Reported-by: Kevin Wolf Signed-off-by: Peter Lieven Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini (cherry picked from commit d3bda7bc166f40326ba646ee145630bb1b59da96) Signed-off-by: Michael Roth --- block/i

[Qemu-devel] [PATCH 23/56] block: fix bdrv_flush() ordering in bdrv_close()

2013-08-13 Thread Michael Roth
From: Stefan Hajnoczi Since 80ccf93b we flush the block device during close. The bdrv_drain_all() call should come before bdrv_flush() to ensure guest write requests have completed. Otherwise we may miss pending writes when flushing. Call bdrv_drain_all() again for safety as the final step aft

[Qemu-devel] [PATCH 25/56] qom: Fix class cast of NULL classes

2013-08-13 Thread Michael Roth
From: Peter Crosthwaite Its clear from the implementation that class casting is supposed to work with a NULL class argument. Guard all dereferences of the class argument against NULL accordingly. Signed-off-by: Peter Crosthwaite Message-id: 94cd5ba46b74eea289a7e582635820c1c54e66fa.1371546907.g

[Qemu-devel] [PATCH 22/56] target-xtensa: gen_intermediate_code_internal() should be inlined

2013-08-13 Thread Michael Roth
From: Andreas Färber Cc: qemu-sta...@nongnu.org Reported-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Andreas Färber (cherry picked from commit ae06d4988d6799f0bd16f27c2bcf80fa1cd2cfd7) Signed-off-by: Michael Roth --- target-xtensa/translate.c |5 +++-- 1 file cha

[Qemu-devel] [PATCH 43/56] pci-bridge: update mappings for migration/restore

2013-08-13 Thread Michael Roth
From: Don Koch Fix for LP#1187529: Devices on PCI bridge stop working when live-migrated. Update bridge mappings for all PCI bridge devices in get_pci_config_device(). Signed-off-by: Don Koch Signed-off-by: Michael S. Tsirkin (cherry picked from commit e78e9ae4a933504d383703870d491615b0261801)

[Qemu-devel] [PATCH 17/56] qemu-char: Fix ID reuse after chardev-remove for qapi-based init

2013-08-13 Thread Michael Roth
From: Markus Armbruster Commit 2c5f488 introduced qapi-based character device initialization as a new code path in qemu_chr_new_from_opts(). Unfortunately, it failed to store parameter opts in the new chardev. Therefore, qemu_chr_delete() doesn't delete it. Even though the device is gone, its

[Qemu-devel] [PATCH 24/56] target-openrisc: Fix typename in openrisc_cpu_class_by_name()

2013-08-13 Thread Michael Roth
From: Dongxue Zhang Commit 478032a93d908e59085c1ac56f10979942e7dc4f (target-openrisc: Rename CPU subtypes) suffixed CPU sub-types with "-or32-cpu" but forgot to update openrisc_cpu_class_by_name(), so that it was still looking for the types without suffix. Make target-openrisc running OK by addi

[Qemu-devel] [PATCH 41/56] qapi: Rename ChardevBackend member "memory" to "ringbuf"

2013-08-13 Thread Michael Roth
From: Markus Armbruster Commit 1da48c6 called the new member "memory" after commit 3949e59 standardized "ringbuf". Rename for consistency. However, member name "memory" is visible in QMP since 1.5. It's undocumented just like the driver name. Keep it working anyway. Cc: qemu-sta...@nongnu.or

[Qemu-devel] [PATCH 21/56] target-moxie: gen_intermediate_code_internal() should be inlined

2013-08-13 Thread Michael Roth
From: Andreas Färber Cc: qemu-sta...@nongnu.org Reported-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Andreas Färber (cherry picked from commit 13692818a570d1fb1326c84d3edae68987aa) Signed-off-by: Michael Roth --- target-moxie/translate.c |2 +- 1 file changed

  1   2   >