Re: [Qemu-devel] [PATCH v2 1/9] tests: QAPI schema parser tests

2013-08-19 Thread Markus Armbruster
Laszlo Ersek writes: > On 07/27/13 17:41, Markus Armbruster wrote: >> The parser handles erroneous input badly. To be improved shortly. >> >> Signed-off-by: Markus Armbruster > >> diff --git a/tests/Makefile b/tests/Makefile >> index cdbb79e..ddb957c 100644 >> --- a/tests/Makefile >> +++ b/tes

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-19 Thread Alexander Graf
On 20.08.2013, at 02:36, Alexey Kardashevskiy wrote: > On 08/19/2013 07:47 PM, Paolo Bonzini wrote: >> Il 19/08/2013 10:44, Alexey Kardashevskiy ha scritto: > It means that if you use the same QEMU version with the same command > line on a different kernel version, your guest looks differ

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-19 Thread Alex Bligh
On 20 Aug 2013, at 02:42, Fam Zheng wrote: > OK, thanks for explaination. That sounds a valid use case for > streamOptimized. However I am afraid QEMU and its users benefit not much > from this feature anyway, because it's moving a VM away to VMware, :) > that might be the reason it's not there y

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-19 Thread Alex Bligh
>> >> for (bh = ctx->first_bh; bh; bh = bh->next) { >> if (!bh->deleted && bh->scheduled) { >> if (bh->idle) { >> /* idle bottom halves will be polled at least >> * every 10ms */ >> -*timeout = 10; >> +*t

[Qemu-devel] [PATCH v4 04/13] block: vhdx - log support struct and defines

2013-08-19 Thread Jeff Cody
This adds some magic number defines, and internal structure definitions for VHDX log replay support. The struct VHDXLogEntries does not reflect an on-disk data structure, and thus does not need to be packed. Some minor code style fixes are applied as well. Signed-off-by: Jeff Cody --- block/vh

Re: [Qemu-devel] [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL

2013-08-19 Thread Liu, Jinsong
Paolo Bonzini wrote: > Il 19/08/2013 16:59, Andreas Färber ha scritto: >> qemu-kvm is no longer maintained since 1.3 so it should not be >> occurring any more. >> >> Please use a prefix of "target-i386: " (the directory name) to signal >> where you are changing code, i.e. x86 only. >> >> "bugfix

[Qemu-devel] [PATCH v4 12/13] block: vhdx - fix comment typos in header, fix incorrect struct fields

2013-08-19 Thread Jeff Cody
VHDXPage83Data and VHDXParentLocatorHeader both incorrectly had their MSGUID fields set as arrays of 16. This is incorrect (it stems from an early version where those fields were uint_8 arrays). Those fields were, up to this patch, unused. Also, there were a couple of typos and incorrect wording

[Qemu-devel] [PATCH v4 13/13] block: vhdx - add .bdrv_create() support

2013-08-19 Thread Jeff Cody
This adds support for VHDX image creation, for images of type "Fixed" and "Dynamic". "Differencing" types (i.e., VHDX images with backing files) are currently not supported. Options for image creation include: * log size: The size of the journaling log for VHDX. Minimum is 1MB,

[Qemu-devel] [PATCH v4 07/13] block: vhdx - log parsing, replay, and flush support

2013-08-19 Thread Jeff Cody
This adds support for VHDX v0 logs, as specified in Microsoft's VHDX Specification Format v1.00: https://www.microsoft.com/en-us/download/details.aspx?id=34750 The following support is added: * Log parsing, and validation - validate that an existing log is correct. * Log search - search throug

[Qemu-devel] [PATCH v4 11/13] block: vhdx - break out code operations to functions

2013-08-19 Thread Jeff Cody
This is preperation for vhdx_create(). The ability to write headers, and calculate the number of BAT entries will be needed within the create() functions, so move this relevant code into helper functions. Signed-off-by: Jeff Cody --- block/vhdx.c | 121 +++---

[Qemu-devel] [PATCH v4 06/13] block: vhdx - update log guid in header, and first write tracker

2013-08-19 Thread Jeff Cody
Allow tracking of first file write in the VHDX image, as well as the ability to update the GUID in the header. This is in preparation for log support. Signed-off-by: Jeff Cody --- block/vhdx.c | 30 -- block/vhdx.h | 6 ++ 2 files changed, 30 insertions(+), 6 de

[Qemu-devel] [PATCH v4 05/13] block: vhdx - break endian translation functions out

2013-08-19 Thread Jeff Cody
This moves the endian translation functions out from the vhdx.c source, into a separate source file. In addition to the previously defined endian functions, new endian translation functions for log support are added as well. Signed-off-by: Jeff Cody --- block/Makefile.objs | 2 +- block/vhdx-e

[Qemu-devel] [PATCH v4 08/13] block: vhdx - add log write support

2013-08-19 Thread Jeff Cody
This adds support for writing to the VHDX log. For spec details, see VHDX Specification Format v1.00: https://www.microsoft.com/en-us/download/details.aspx?id=34750 There are a few limitations to this log support: 1.) There is no caching yet 2.) The log is flushed after each entry The primary wr

[Qemu-devel] [PATCH v4 10/13] block: vhdx - move more endian translations to vhdx-endian.c

2013-08-19 Thread Jeff Cody
In preperation for vhdx_create(), move more endian translation functions out to vhdx-endian.c. Signed-off-by: Jeff Cody --- block/vhdx-endian.c | 75 + block/vhdx.c| 20 +++--- block/vhdx.h| 9 ++- 3 files changed,

[Qemu-devel] [PATCH v4 09/13] block: vhdx write support

2013-08-19 Thread Jeff Cody
This adds support for writing to VHDX image files, using coroutines. Writes into the BAT table goes through the VHDX log. Currently, BAT table writes occur when expanding a dynamic VHDX file, and allocating a new BAT entry. Signed-off-by: Jeff Cody --- block/vhdx.c | 150 +++

[Qemu-devel] [PATCH v4 03/13] block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to header.

2013-08-19 Thread Jeff Cody
In preparation for VHDX log support, move these structures to the header. Signed-off-by: Jeff Cody --- block/vhdx.c | 51 --- block/vhdx.h | 47 +++ 2 files changed, 47 insertions(+), 51 deletions(-) dif

[Qemu-devel] [PATCH v4 02/13] block: vhdx - add header update capability.

2013-08-19 Thread Jeff Cody
This adds the ability to update the headers in a VHDX image, including generating a new MS-compatible GUID. As VHDX depends on uuid.h, VHDX is now a configurable build option. If VHDX support is enabled, that will also enable uuid as well. The default is to have VHDX enabled. To enable/disable

[Qemu-devel] [PATCH v4 01/13] block: vhdx - minor comments and typo correction.

2013-08-19 Thread Jeff Cody
Just a couple of minor comments to help note where allocated buffers are freed, and a typo fix. Signed-off-by: Jeff Cody --- block/vhdx.c | 6 -- block/vhdx.h | 6 +++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index e9704b1..56bc88e 100644

[Qemu-devel] [PATCH v4 00/13] VHDX log replay and write support, .bdrv_create()

2013-08-19 Thread Jeff Cody
This patch series contains the initial VHDX log parsing, replay, and write support. (New with v4: VHDX image file creation) === v4 changes === v4 patches are available from github as well, on branch vhdx-write-v4-upstream: https://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v4-upstream h

Re: [Qemu-devel] [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL

2013-08-19 Thread Liu, Jinsong
Andreas Färber wrote: > Am 19.08.2013 16:31, schrieb Liu, Jinsong: >> Paolo Bonzini wrote: >>> >>> The patch looks good. Please repost it with checkpatch.pl failures >>> fixed. >>> >>> Paolo >> >> Thanks Stefan and Paolo! Updated patch attached. >> >> Regards, >> Jinsong >> >> ==

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-19 Thread Wenchao Xia
于 2013-8-16 4:34, Alex Bligh 写道: > Calculate the timeout in aio_ctx_prepare taking into account > the timers attached to the AioContext. > > Alter aio_ctx_check similarly. > > Signed-off-by: Alex Bligh > --- > async.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) >

[Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-19 Thread Fam Zheng
It's more friendly to print which char is invalid to user, especially when user tries to input a float value and expect the monitor to round it to int. Since we don't round float number when we look for a integer, telling which char is invalid is less confusing. Signed-off-by: Fam Zheng --- moni

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-19 Thread Fam Zheng
On Mon, 08/19 12:50, Alex Bligh wrote: > > On 19 Aug 2013, at 12:23, Fam Zheng wrote: > > > Yes, that would be something possible to do. Is it the only format to > > upload a VM to vCenter now, shouldn't normal VMDK be supported as well? > > Ian puts it better than I can: > > > This format is o

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-19 Thread Alexey Kardashevskiy
On 08/19/2013 07:47 PM, Paolo Bonzini wrote: > Il 19/08/2013 10:44, Alexey Kardashevskiy ha scritto: It means that if you use the same QEMU version with the same command line on a different kernel version, your guest looks different because we generate the dtb differently. >> Oh. Sor

[Qemu-devel] [PATCH V8 08/11] NUMA: add qmp command set-mem-policy to set memory policy for NUMA node

2013-08-19 Thread Wanlong Gao
This QMP command allows user set guest node's memory policy through the QMP protocol. The qmp-shell command is like: set-mem-policy nodeid=0 policy=membind relative=true host-nodes=0-1 Signed-off-by: Wanlong Gao --- numa.c | 62 ++

[Qemu-devel] [PATCH V8 04/11] NUMA: Add numa_info structure to contain numa nodes info

2013-08-19 Thread Wanlong Gao
Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. Reviewed-by: Eduardo Habkost Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao --- hw/i386/pc.c| 4 ++-- include/sysemu/sysemu.h | 8 ++

Re: [Qemu-devel] [PATCH v2 0/8] OptsVisitor: support / flatten integer ranges for repeating options

2013-08-19 Thread Wanlong Gao
On 08/20/2013 06:35 AM, Laszlo Ersek wrote: > v1->v2: Tested-by: Wanlong Gao > - rebased to current master (patch #8 only applied with "git am -3"), > - now patch #7 adds "test-bitops" too to .gitignore, > - patch #8 updates "qapi-schema-test.out" to keep it in synch with the > test schema c

[Qemu-devel] [PATCH V8 07/11] NUMA: set guest numa nodes memory policy

2013-08-19 Thread Wanlong Gao
Set the guest numa nodes memory policies using the mbind(2) system call node by node. After this patch, we are able to set guest nodes memory policies through the QEMU options, this arms to solve the guest cross nodes memory access performance issue. And as you all know, if PCI-passthrough is used,

[Qemu-devel] [PATCH V8 06/11] NUMA: parse guest numa nodes memory policy

2013-08-19 Thread Wanlong Gao
The memory policy setting format is like: policy={default|membind|interleave|preferred}[,relative=true],host-nodes=N-N And we are adding this setting as a suboption of "-numa mem,", the memory policy then can be set like following: -numa node,nodeid=0,cpus=0 \ -numa node,nodeid=1,cpus=1

[Qemu-devel] [PATCH V8 11/11] NUMA: convert hmp command info_numa to use qmp command query_numa

2013-08-19 Thread Wanlong Gao
Signed-off-by: Wanlong Gao --- hmp.c | 54 ++ hmp.h | 1 + monitor.c | 21 + 3 files changed, 56 insertions(+), 20 deletions(-) diff --git a/hmp.c b/hmp.c index 98d2a76..3b2f04d 100644 --- a/hmp.c +++ b/hmp.c @@ -27

[Qemu-devel] [PATCH V8 03/11] NUMA: move numa related code to numa.c

2013-08-19 Thread Wanlong Gao
Signed-off-by: Wanlong Gao --- cpus.c | 14 --- include/sysemu/cpus.h | 1 - include/sysemu/sysemu.h | 2 ++ numa.c | 66 + vl.c| 47 +-- 5 files chang

[Qemu-devel] [PATCH V8 09/11] NUMA: add hmp command set-mem-policy

2013-08-19 Thread Wanlong Gao
Add hmp command set-mem-policy to set host memory policy for a guest NUMA node. Then we can also set node's memory policy using the monitor command like: (qemu) set-mem-policy 0 policy=membind,relative=false,host-nodes=0-1 Signed-off-by: Wanlong Gao --- hmp-commands.hx | 16 ++ h

[Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-19 Thread Wanlong Gao
As you know, QEMU can't direct it's memory allocation now, this may cause guest cross node access performance regression. And, the worse thing is that if PCI-passthrough is used, direct-attached-device uses DMA transfer between device and qemu process. All pages of the guest will be pinned by get_u

[Qemu-devel] [PATCH V8 02/11] NUMA: split -numa option

2013-08-19 Thread Wanlong Gao
Change -numa option like following as Paolo suggested: -numa node,nodeid=0,cpus=0-1 \ -numa mem,nodeid=0,size=1G This new option will make later coming memory hotplug better. And this new option is implemented using OptsVisitor. And just remain "-numa node,mem=xx" as legacy. Reviewed-by:

[Qemu-devel] [PATCH V8 10/11] NUMA: add qmp command query-numa

2013-08-19 Thread Wanlong Gao
Add qmp command query-numa to show guest NUMA information. Signed-off-by: Wanlong Gao --- numa.c | 69 qapi-schema.json | 36 + qmp-commands.hx | 49 3 files c

[Qemu-devel] [PATCH V8 05/11] NUMA: Add Linux libnuma detection

2013-08-19 Thread Wanlong Gao
Add detection of libnuma (mostly contained in the numactl package) to the configure script. Can be enabled or disabled on the command line, default is use if available. Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao --- configure | 32 1 file changed,

[Qemu-devel] [PATCH V8 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-08-19 Thread Wanlong Gao
Reviewed-by: Laszlo Ersek Signed-off-by: Wanlong Gao --- qapi-schema.json | 47 +++ 1 file changed, 47 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a51f7d2..b9b18e4 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3773,

[Qemu-devel] [PATCH v2 4/8] OptsVisitor: rebase opts_type_uint64() to parse_uint_full()

2013-08-19 Thread Laszlo Ersek
Simplify the code in preparation for the next patch. Signed-off-by: Laszlo Ersek --- qapi/opts-visitor.c | 23 +-- 1 files changed, 5 insertions(+), 18 deletions(-) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 90be583..d8f9a0e 100644 --- a/qapi/opts-visitor

[Qemu-devel] [PATCH v2 2/8] OptsVisitor: introduce list modes for interval flattening

2013-08-19 Thread Laszlo Ersek
The new modes are equal-rank, exclusive alternatives of LM_IN_PROGRESS. Teach opts_next_list(), opts_type_int() and opts_type_uint64() to handle them. Also enumerate explicitly what functions are valid to call in what modes: - opts_next_list() is valid to call while flattening a range, - opts_end_

[Qemu-devel] [PATCH v2 5/8] OptsVisitor: opts_type_uint64(): recognize intervals when LM_IN_PROGRESS

2013-08-19 Thread Laszlo Ersek
When a well-formed range value, bounded by unsigned integers, is encountered while processing a repeated option, enter LM_UNSIGNED_INTERVAL and return the low bound. Signed-off-by: Laszlo Ersek --- qapi/opts-visitor.c | 32 +++- 1 files changed, 27 insertions(+), 5

[Qemu-devel] [PATCH v2 6/8] OptsVisitor: don't try to flatten overlong integer ranges

2013-08-19 Thread Laszlo Ersek
Prevent mistyped command line options from incurring high memory and CPU usage at startup. 64K elements in a range should be enough for everyone (TM). The OPTS_VISITOR_RANGE_MAX macro is public so that unit tests can construct corner cases with it. Signed-off-by: Laszlo Ersek --- include/qapi/o

[Qemu-devel] [PATCH v2 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-08-19 Thread Laszlo Ersek
According to commit 4f193e34 ("tests: Use qapi-schema-test.json as schema parser test") the "tests/qapi-schema/qapi-schema-test.out" file must be updated as well. Signed-off-by: Laszlo Ersek --- v1->v2: - rebase to master, - synch "qapi-schema-test.out". tests/Makefile

[Qemu-devel] [PATCH v2 7/8] add "test-int128" and "test-bitops" to .gitignore

2013-08-19 Thread Laszlo Ersek
"test-int128" was probably missed in commit 6046c620 ("int128: optimize and add test cases"). "test-bitops" was probably missed in commit 3464700f ("tests: Add test-bitops.c with some sextract tests"). Signed-off-by: Laszlo Ersek --- v1->v2: - add test-bitops too .gitignore |2 ++ 1 file

[Qemu-devel] [PATCH v2 1/8] OptsVisitor: introduce basic list modes

2013-08-19 Thread Laszlo Ersek
We're going to need more state while processing a list of repeated options. This change eliminates "repeated_opts_first" and adds a new state variable: list_mode repeated_opts repeated_opts_first -- - --- LM_NONE NULL false

[Qemu-devel] [PATCH v2 0/8] OptsVisitor: support / flatten integer ranges for repeating options

2013-08-19 Thread Laszlo Ersek
v1->v2: - rebased to current master (patch #8 only applied with "git am -3"), - now patch #7 adds "test-bitops" too to .gitignore, - patch #8 updates "qapi-schema-test.out" to keep it in synch with the test schema changes warranted by the opts-visitor unit tests. rfc->v1: - addressed Paolo's com

[Qemu-devel] [PATCH v2 3/8] OptsVisitor: opts_type_int(): recognize intervals when LM_IN_PROGRESS

2013-08-19 Thread Laszlo Ersek
When a well-formed range value, bounded by signed integers, is encountered while processing a repeated option, enter LM_SIGNED_INTERVAL and return the low bound. Signed-off-by: Laszlo Ersek --- qapi/opts-visitor.c | 34 -- 1 files changed, 28 insertions(+), 6 de

Re: [Qemu-devel] [PATCH v2 1/9] tests: QAPI schema parser tests

2013-08-19 Thread Laszlo Ersek
On 07/27/13 17:41, Markus Armbruster wrote: > The parser handles erroneous input badly. To be improved shortly. > > Signed-off-by: Markus Armbruster > diff --git a/tests/Makefile b/tests/Makefile > index cdbb79e..ddb957c 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -233,13 +242,24

[Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-19 Thread Stefan Weil
Hello, is anybody working on KVM or something equivalent for Windows and Mac OS X? I recently noticed that the QEMU based Android emulator uses KVM for Linux and HAXM, an Intel hypervisor, for Windows and Mac OS X. Would it be a good plan to merge HAXM support in latest QEMU (the Android QEMU is

Re: [Qemu-devel] [PATCH] Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system. These patches change from using Linux kernel style upcasts to typesafe object o

2013-08-19 Thread Paolo Bonzini
Il 19/08/2013 20:57, Mike Day ha scritto: >>> >> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c >>> >> index ebcb52a..46d8c27 100644 >>> >> --- a/hw/misc/ivshmem.c >>> >> +++ b/hw/misc/ivshmem.c >>> >> @@ -789,7 +789,7 @@ static void pci_ivshmem_uninit(PCIDevice *dev) >>> >> >>> >> static void

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-08-19 Thread Laszlo Ersek
On 08/19/13 21:55, Laszlo Ersek wrote: > On 08/19/13 21:26, Luiz Capitulino wrote: >> On Mon, 22 Jul 2013 23:07:36 +0200 >> Laszlo Ersek wrote: >> >>> >>> Signed-off-by: Laszlo Ersek >> >> This patch now conflicts, can you respin please? > > Can you retry with "git am -3"? > > "git rebase -i" d

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-08-19 Thread Laszlo Ersek
On 08/19/13 21:26, Luiz Capitulino wrote: > On Mon, 22 Jul 2013 23:07:36 +0200 > Laszlo Ersek wrote: > >> >> Signed-off-by: Laszlo Ersek > > This patch now conflicts, can you respin please? Can you retry with "git am -3"? "git rebase -i" didn't ask me to do anything manually, so I'm guessing

Re: [Qemu-devel] [PATCH v2] Convert stderr message calling error_get_pretty() to error_report()

2013-08-19 Thread Luiz Capitulino
On Mon, 05 Aug 2013 15:40:44 -0400 Seiji Aguchi wrote: > Convert stderr messages calling error_get_pretty() > to error_report(). > > Timestamp is prepended by -msg timstamp option with it. > > Per Markus's comment below, A conversion from fprintf() to > error_report() is always an improvement,

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-08-19 Thread Luiz Capitulino
On Mon, 22 Jul 2013 23:07:36 +0200 Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek This patch now conflicts, can you respin please? > --- > tests/Makefile|6 +- > qapi-schema-test.json | 15 +++ > tests/test-opts-visitor.c | 275 > +

Re: [Qemu-devel] [PATCH] Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system. These patches change from using Linux kernel style upcasts to typesafe object o

2013-08-19 Thread Eric Blake
On 08/19/2013 12:33 PM, Mike Day wrote: Your subject line is atrociously long. Please put a blank line between the summary (ca. 60 characters or less) and the rest of your commit message. 'git shortlog -30' will give you a hint on typical summary naming. -- Eric Blake eblake redhat com+1

Re: [Qemu-devel] [PATCH] Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system. These patches change from using Linux kernel style upcasts to typesafe object o

2013-08-19 Thread Mike Day
Peter Maydell writes: > On 19 August 2013 19:33, Mike Day wrote: >> These patches apply to Paolo Bonzini's rcu tree: >> >> https://github.com/bonzini/qemu/tree/rcu >> commit 781e47bf1693a80b84eec298a6a1c7b29ab2c135 >> >> Signed-off-by: Mike Day >> --- >> hw/misc/ivshmem.c | 2 +-

Re: [Qemu-devel] [PATCH] Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system. These patches change from using Linux kernel style upcasts to typesafe object o

2013-08-19 Thread Peter Maydell
On 19 August 2013 19:33, Mike Day wrote: > These patches apply to Paolo Bonzini's rcu tree: > > https://github.com/bonzini/qemu/tree/rcu > commit 781e47bf1693a80b84eec298a6a1c7b29ab2c135 > > Signed-off-by: Mike Day > --- > hw/misc/ivshmem.c | 2 +- > hw/pci-bridge/pci_bridge_dev.c |

[Qemu-devel] [PATCH RESEND] RCU implementation for Qemu. Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system.

2013-08-19 Thread Mike Day
These patches change from using Linux kernel style upcasts to typesafe object oriented casts with runtime checking semantics. These patches apply to Paolo Bonzini's rcu tree: https://github.com/bonzini/qemu/tree/rcu commit 781e47bf1693a80b84eec298a6a1c7b29ab2c135 Signed-off-by: Mike Day --- h

Re: [Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-19 Thread Luiz Capitulino
On Mon, 12 Aug 2013 10:19:52 -0400 Luiz Capitulino wrote: > On Thu, 8 Aug 2013 20:05:48 +0300 > Orit Wasserman wrote: > > > "ram" is present also when migration completes. > > expected-downtime, total-time and downtime are no longer part of "ram" data. > > > > Signed-off-by: Orit Wasserman >

[Qemu-devel] [PATCH] Fixup some dynamic casts in the Qemu device tree to correspond to the QOM type-checking system. These patches change from using Linux kernel style upcasts to typesafe object orien

2013-08-19 Thread Mike Day
These patches apply to Paolo Bonzini's rcu tree: https://github.com/bonzini/qemu/tree/rcu commit 781e47bf1693a80b84eec298a6a1c7b29ab2c135 Signed-off-by: Mike Day --- hw/misc/ivshmem.c | 2 +- hw/pci-bridge/pci_bridge_dev.c | 6 +++--- hw/pci/pci_bridge.c| 2 +- 3 files

Re: [Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 09:04:28AM -0300, Eduardo Habkost wrote: > On Sun, Aug 18, 2013 at 04:50:02PM +0300, Michael S. Tsirkin wrote: > > Make 1.4 compat code call the 1.6 one, reducing > > code duplication. Add comment explaining why we can't > > make 1.4 call 1.5 as usual. > > > > Signed-off-by

Re: [Qemu-devel] [PATCH v4 2/2] loader: store FW CFG ROM files in RAM

2013-08-19 Thread Laszlo Ersek
On 08/19/13 16:26, Michael S. Tsirkin wrote: > ROM files that are put in FW CFG are copied to guest ram, by BIOS, but > they are not backed by RAM so they don't get migrated. > > Each time we change two bytes in such a ROM this breaks cross-version > migration: since we can migrate after BIOS has

Re: [Qemu-devel] [PATCH v4 1/2] arch_init: align MR size to target page size

2013-08-19 Thread Laszlo Ersek
On 08/19/13 19:48, Michael S. Tsirkin wrote: > On Mon, Aug 19, 2013 at 07:37:44PM +0200, Laszlo Ersek wrote: >> On 08/19/13 16:26, Michael S. Tsirkin wrote: >>> Migration code assumes that each MR is a multiple of TARGET_PAGE_SIZE: >>> MR size is divided by TARGET_PAGE_SIZE, so if it isn't migratio

Re: [Qemu-devel] [PATCH 1/1] virtio-scsi: Make type virtio-scsi-common abstract

2013-08-19 Thread Paolo Bonzini
Il 19/08/2013 17:53, arm...@redhat.com ha scritto: > From: Markus Armbruster > > It's the abstract base of virtio-scsi-device and vhost-scsi. > > Signed-off-by: Markus Armbruster > --- > hw/scsi/virtio-scsi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/scsi/virtio-scsi.c b/hw/

Re: [Qemu-devel] [PATCH v4 2/2] loader: store FW CFG ROM files in RAM

2013-08-19 Thread Paolo Bonzini
Il 19/08/2013 19:40, Michael S. Tsirkin ha scritto: > On Mon, Aug 19, 2013 at 07:28:12PM +0200, Paolo Bonzini wrote: >> Il 19/08/2013 16:26, Michael S. Tsirkin ha scritto: >>> ROM files that are put in FW CFG are copied to guest ram, by BIOS, but >>> they are not backed by RAM so they don't get mig

Re: [Qemu-devel] [PATCH v4 1/2] arch_init: align MR size to target page size

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 06:45:10PM +0100, Peter Maydell wrote: > On 19 August 2013 18:37, Laszlo Ersek wrote: > > ((3) memory_region_size() is slightly different from > > int128_get64(mr->size); it has a special case for int128_2_64() -- and I > > don't understand that. > > The special case is be

Re: [Qemu-devel] [PATCH v4 1/2] arch_init: align MR size to target page size

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 07:37:44PM +0200, Laszlo Ersek wrote: > On 08/19/13 16:26, Michael S. Tsirkin wrote: > > Migration code assumes that each MR is a multiple of TARGET_PAGE_SIZE: > > MR size is divided by TARGET_PAGE_SIZE, so if it isn't migration > > never completes. > > But this isn't really

Re: [Qemu-devel] [PATCH v4 1/2] arch_init: align MR size to target page size

2013-08-19 Thread Peter Maydell
On 19 August 2013 18:37, Laszlo Ersek wrote: > ((3) memory_region_size() is slightly different from > int128_get64(mr->size); it has a special case for int128_2_64() -- and I > don't understand that. The special case is because valid memory region sizes range from 0 to 2^64, *inclusive*. [2^64-si

Re: [Qemu-devel] [PATCH v4 2/2] loader: store FW CFG ROM files in RAM

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 07:28:12PM +0200, Paolo Bonzini wrote: > Il 19/08/2013 16:26, Michael S. Tsirkin ha scritto: > > ROM files that are put in FW CFG are copied to guest ram, by BIOS, but > > they are not backed by RAM so they don't get migrated. > > > > Each time we change two bytes in such a

Re: [Qemu-devel] [PATCH v4 2/2] loader: store FW CFG ROM files in RAM

2013-08-19 Thread Paolo Bonzini
Il 19/08/2013 16:26, Michael S. Tsirkin ha scritto: > ROM files that are put in FW CFG are copied to guest ram, by BIOS, but > they are not backed by RAM so they don't get migrated. > > Each time we change two bytes in such a ROM this breaks cross-version > migration: since we can migrate after BI

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-19 Thread Andreas Färber
Am 16.08.2013 02:20, schrieb Benjamin Herrenschmidt: > On Thu, 2013-08-15 at 16:47 +0200, Andreas Färber wrote: >> When we instantiate a -cpu POWER9 then having one POWER9_vX.Y around to >> back it doesn't really hurt. Unlike ARM's MIDR there doesn't seem to be >> an encoding of IBM vendor or POWER

Re: [Qemu-devel] [PATCH v4 1/2] arch_init: align MR size to target page size

2013-08-19 Thread Laszlo Ersek
On 08/19/13 16:26, Michael S. Tsirkin wrote: > Migration code assumes that each MR is a multiple of TARGET_PAGE_SIZE: > MR size is divided by TARGET_PAGE_SIZE, so if it isn't migration > never completes. > But this isn't really required for regions set up with > memory_region_init_ram, since that c

Re: [Qemu-devel] [RFC PATCH v3] powerpc: add PVR mask support

2013-08-19 Thread Andreas Färber
Am 15.08.2013 13:59, schrieb Alexander Graf: > > On 15.08.2013, at 13:48, Andreas Färber wrote: > >> We do have the following: >> >> "object" >> +- "device" >> +- "cpu" >> +- "powerpc64-cpu" >> +- "POWER7-family-powerpc64-cpu" -> POWERPC_FAMILY() > > Ah, there is the family :). >

Re: [Qemu-devel] [PATCH v2 6/7] vl: Set current_machine early

2013-08-19 Thread Andreas Färber
Am 19.08.2013 11:35, schrieb Markus Armbruster: > Andreas Färber writes: > >> Am 16.08.2013 15:18, schrieb arm...@redhat.com: >>> From: Markus Armbruster >>> >>> I'd like to access QEMUMachine from a QEMUMachine init() method, which >>> is currently not possible. Instead of passing it as an arg

Re: [Qemu-devel] [PATCH v4 0/2] future proof rom loading for cross versiom migration

2013-08-19 Thread Peter Maydell
On 19 August 2013 15:26, Michael S. Tsirkin wrote: > Changes from v3: > - drop new API, all changes are now internal to memory subsystem > Patch 1/2 is new. Patch 2/2 had minor changes. I'm happy with these from a memory system api point of view, though I don't know enough about migrati

Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for "raw"

2013-08-19 Thread Laszlo Ersek
On 08/18/13 16:25, Paolo Bonzini wrote: > Il 16/08/2013 16:59, Anthony Liguori ha scritto: >> Laszlo Ersek writes: >> >>> Paolo asked me to write such a driver based on his textual specification >>> alone. The first patch captures his email in full, the rest re-quotes >>> parts that are being impl

Re: [Qemu-devel] VNC key presses not correct

2013-08-19 Thread Erik Rull
Hi Markus, I would like to try it - see the python-traceback thread - when qemu compiles, I will definitively try it with the 1.6.0. Best regards, Erik Markus Armbruster wrote: Erik Rull writes: Hi all, I'm struggling with the QEMU VNC on qemu-kvm-1.2.0 a bit, the following two things

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

2013-08-19 Thread Erik Rull
Luiz Capitulino wrote: On Fri, 16 Aug 2013 14:21:50 +0100 Peter Maydell wrote: On 16 August 2013 08:59, Erik Rull wrote: Hi all, when using the released qemu-1.6.0.tar.bz2, I get the following error message: File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164 except QAPISchemaErr

Re: [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1

2013-08-19 Thread Eric Blake
On 08/19/2013 03:25 AM, Kevin Wolf wrote: > By the time that qemu 1.7 will be released, enough time will has passed > since qemu 1.1, which is the first version to understand version 3 > images, that changing the default shouldn't hurt many people any more > and the benefits of using the new format

Re: [Qemu-devel] [PATCH 1/2] Improve Monitor disas with symbol lookup

2013-08-19 Thread Fabien Chouteau
On 08/19/2013 04:14 PM, Andreas Färber wrote: > Am 02.08.2013 14:48, schrieb Fabien Chouteau: >> Part of M731-018. >> >> Signed-off-by: Fabien Chouteau >> --- >> disas.c | 16 >> 1 file changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/disas.c b/disas.c >> index 7100

Re: [Qemu-devel] [PATCH 1/1] virtio-scsi: Make type virtio-scsi-common abstract

2013-08-19 Thread Andreas Färber
Am 19.08.2013 17:53, schrieb arm...@redhat.com: > From: Markus Armbruster > > It's the abstract base of virtio-scsi-device and vhost-scsi. > > Signed-off-by: Markus Armbruster Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff H

[Qemu-devel] [PATCH 1/1] virtio-scsi: Make type virtio-scsi-common abstract

2013-08-19 Thread armbru
From: Markus Armbruster It's the abstract base of virtio-scsi-device and vhost-scsi. Signed-off-by: Markus Armbruster --- hw/scsi/virtio-scsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 05da56b..a9ee17b 100644 --- a/hw/scsi/virtio-s

Re: [Qemu-devel] SCSI bus failures with qemu-arm in kernel 3.8+

2013-08-19 Thread Guenter Roeck
On Thu, Aug 15, 2013 at 11:23:58PM +0100, Peter Maydell wrote: > On 15 August 2013 23:18, Guenter Roeck wrote: > > But doesn't that mean that there is _currently_ no problem ? If so, > > we can introduce the additional code when the problem really shows up. > > Being Preemptive is good, but if it

Re: [Qemu-devel] [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL

2013-08-19 Thread Paolo Bonzini
Il 19/08/2013 16:59, Andreas Färber ha scritto: > qemu-kvm is no longer maintained since 1.3 so it should not be occurring > any more. > > Please use a prefix of "target-i386: " (the directory name) to signal > where you are changing code, i.e. x86 only. > > "bugfix" is not a very telling descrip

Re: [Qemu-devel] [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL

2013-08-19 Thread Andreas Färber
Am 19.08.2013 16:31, schrieb Liu, Jinsong: > Paolo Bonzini wrote: >> >> The patch looks good. Please repost it with checkpatch.pl failures >> fixed. >> >> Paolo > > Thanks Stefan and Paolo! Updated patch attached. > > Regards, > Jinsong > > === > From a0ddf948d40e42de862543157a5668

Re: [Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-19 Thread Eduardo Habkost
On Mon, Aug 19, 2013 at 05:28:45PM +0300, Michael S. Tsirkin wrote: > On Mon, Aug 19, 2013 at 11:19:23AM -0300, Eduardo Habkost wrote: > > On Mon, Aug 19, 2013 at 04:02:10PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Aug 19, 2013 at 09:04:28AM -0300, Eduardo Habkost wrote: > > > > On Sun, Aug 1

Re: [Qemu-devel] [PATCH] Qemu-xen: HVM S3 bugfix

2013-08-19 Thread Liu, Jinsong
Ping? Thanks, Jinsong Liu, Jinsong wrote: > From fc928436df17673bfea1d902859c682c99c1489d Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Wed, 14 Aug 2013 05:26:56 +0800 > Subject: [PATCH] Qemu-xen: HVM S3 bugfix > > This patch is used to fix HVM S3 bug caused from the difference > between

[Qemu-devel] [PATCH v4 0/2] future proof rom loading for cross versiom migration

2013-08-19 Thread Michael S. Tsirkin
Changes from v3: - drop new API, all changes are now internal to memory subsystem Patch 1/2 is new. Patch 2/2 had minor changes. At laszlo's request (offline), here's the diff of patch 2/2 from v3 to v4: diff --git a/hw/core/loader.c b/hw/core/loader.c index 32

Re: [Qemu-devel] [qemu-devel]question on virtqueue_get_avail_bytes

2013-08-19 Thread Stefan Hajnoczi
On Mon, Aug 19, 2013 at 05:28:44PM +0800, yinyin wrote: > Hi,all: > in func virtqueue_get_avail_bytes, when found a indirect desc, we need > loop over it. > /* loop over the indirect descriptor table */ > indirect = 1; > max = vring_desc_len(desc_pa, i) /

Re: [Qemu-devel] [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL

2013-08-19 Thread Liu, Jinsong
Paolo Bonzini wrote: > > The patch looks good. Please repost it with checkpatch.pl failures > fixed. > > Paolo Thanks Stefan and Paolo! Updated patch attached. Regards, Jinsong === >From a0ddf948d40e42de862543157a5668a1c12faae6 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Mo

[Qemu-devel] [PULL 14/18] block/ssh: drop return_true()

2013-08-19 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop return_true(). Signed-off-by: Stefan Hajnoczi --- block/ssh.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index d7e7bf8..e149da9 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -740,14 +740,6 @@ sta

[Qemu-devel] [PULL 06/18] aio: stop using .io_flush()

2013-08-19 Thread Stefan Hajnoczi
Now that aio_poll() users check their termination condition themselves, it is no longer necessary to call .io_flush() handlers. The behavior of aio_poll() changes as follows: 1. .io_flush() is no longer invoked and file descriptors are *always* monitored. Previously returning 0 from .io_flush()

Re: [Qemu-devel] [PATCH] Make usb-bt-dongle configurable

2013-08-19 Thread Gerd Hoffmann
On Mo, 2013-08-19 at 15:58 +0200, Paolo Bonzini wrote: > Il 19/08/2013 15:41, Andreas Färber ha scritto: > > By my reading of `git grep CONFIG_USB_BLUETOOTH` it isn't disappearing, > > check default-configs/usb.mak. All targets that include usb.mak will > > have CONFIG_USB_BLUETOOTH. > > > > It's

[Qemu-devel] [PULL 13/18] block/sheepdog: drop have_co_req() and aio_flush_request()

2013-08-19 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop have_co_req() and aio_flush_request(). Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index afe0533..3fb4361 100644 ---

Re: [Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 11:19:23AM -0300, Eduardo Habkost wrote: > On Mon, Aug 19, 2013 at 04:02:10PM +0300, Michael S. Tsirkin wrote: > > On Mon, Aug 19, 2013 at 09:04:28AM -0300, Eduardo Habkost wrote: > > > On Sun, Aug 18, 2013 at 04:50:02PM +0300, Michael S. Tsirkin wrote: > > > > Make 1.4 comp

[Qemu-devel] [PULL 11/18] block/nbd: drop nbd_have_request()

2013-08-19 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop nbd_have_request(). We cannot drop in_flight since it is still used by other block/nbd.c code. Signed-off-by: Stefan Hajnoczi --- block/nbd.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/block/nbd.c b/block/nbd.c inde

[Qemu-devel] [PATCH v4 2/2] loader: store FW CFG ROM files in RAM

2013-08-19 Thread Michael S. Tsirkin
ROM files that are put in FW CFG are copied to guest ram, by BIOS, but they are not backed by RAM so they don't get migrated. Each time we change two bytes in such a ROM this breaks cross-version migration: since we can migrate after BIOS has read the first byte but before it has read the second o

[Qemu-devel] [PULL 10/18] block/linux-aio: drop qemu_laio_completion_cb()

2013-08-19 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop qemu_laio_completion_cb(). It turns out that count is now unused so drop that too. Signed-off-by: Stefan Hajnoczi --- block/linux-aio.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/block/linux-aio.c b/block/linux-

[Qemu-devel] [PULL 15/18] dataplane/virtio-blk: drop flush_true() and flush_io()

2013-08-19 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop flush_true() and flush_io(). Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 5

Re: [Qemu-devel] [PATCH 2/2] Add ARM registers definitions in Monitor commands

2013-08-19 Thread Andreas Färber
Am 19.08.2013 10:31, schrieb Peter Maydell: > On 19 August 2013 09:26, Fabien Chouteau wrote: >> Any comments? >> >> Regards, >> >> On 08/02/2013 02:48 PM, Fabien Chouteau wrote: >>> Signed-off-by: Fabien Chouteau >>> --- >>> monitor.c | 17 + >>> 1 file changed, 17 insertions(

[Qemu-devel] [PULL 18/18] aio: drop io_flush argument

2013-08-19 Thread Stefan Hajnoczi
The .io_flush() handler no longer exists and has no users. Drop the io_flush argument to aio_set_fd_handler() and related functions. The AioFlushEventNotifierHandler and AioFlushHandler typedefs are no longer used and are dropped too. Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi -

  1   2   3   >