[Qemu-devel] [PATCH v4] spapr-pci: fix config space access to support bridges

2013-08-21 Thread Alexey Kardashevskiy
spapr-pci config space accessors use find_dev() to find a PCI device. However find_dev() only searched on a primary bus and did not do recursive search through secondary buses so config space access was not possible for devices other that on a primary bus. This fixed find_dev() by using the PCI

Re: [Qemu-devel] [Xen-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-08-21 Thread Ben Guthro
On Aug 20, 2013, at 3:45 PM, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Sat, Aug 17, 2013 at 09:04:29AM +, Gonglei (Arei) wrote: Hi, The fundamental reason is traditional qemu-dm and upstream qemu using a different vgabios-cirrus.bin, qemu-dm is using

Re: [Qemu-devel] [PATCH v2 0/2] tests: Fixes for in-tree build

2013-08-21 Thread Laszlo Ersek
On 08/20/13 13:43, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com v2: Nominate for qemu-stable (Andreas) Markus Armbruster (2): tests: Fix schema parser test for in-tree build tests: Update .gitignore for test-int128 and test-bitops tests/.gitignore | 3 +++

Re: [Qemu-devel] [PATCH V8 07/11] NUMA: set guest numa nodes memory policy

2013-08-21 Thread Andrew Jones
- Original Message - On 08/20/2013 09:41 PM, Andrew Jones wrote: + +/* This is a workaround for a long standing bug in Linux' + * mbind implementation, which cuts off the last specified + * node. To stay compatible should this bug be fixed, we + * specify one

Re: [Qemu-devel] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-21 Thread Alexander Graf
On 20.08.2013, at 12:38, Benjamin Herrenschmidt wrote: On Tue, 2013-08-20 at 12:14 +0200, Paolo Bonzini wrote: I suppose if RH is going to deploy 3.10 and we aren't going to backport the multitce patches then there *might* be a case for supporting that combo specifically... but it's going to

[Qemu-devel] [PATCH 07/18] arch_init: export RAM_SAVE_xxx flags

2013-08-21 Thread Lei Li
Export RAM_SAVE_xxx flags for localhost migration. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 12 include/migration/migration.h | 14 ++ 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/arch_init.c b/arch_init.c

[Qemu-devel] [PATCH 0/18 RFC v3] Localhost migration

2013-08-21 Thread Lei Li
Hi, This patch series tries to add a new approach to localhost migration support in QEMU. When doing localhost migration, the host memory will balloon up during the period. This procedure might need to consume twice the memory needed to run the guest for some time. So we want to add a new

[Qemu-devel] [PATCH 01/18] migration: export MIG_STATE_xxx flags

2013-08-21 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h | 10 ++ migration.c |9 - 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index 140e6b4..6a24e65

[Qemu-devel] [PATCH 03/18] rename is_active to is_block_active

2013-08-21 Thread Lei Li
is_active is used to identify block migration, rename to is_block_active to make it more clear. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- block-migration.c |2 +- include/migration/vmstate.h |2 +- savevm.c| 16 3 files changed,

[Qemu-devel] [PATCH 05/18] savevm: add comments for qemu_file_get_error()

2013-08-21 Thread Lei Li
Add comments for qemu_file_get_error(), as its return value is not very clear. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- savevm.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 6362275..1522d95 100644 --- a/savevm.c +++

[Qemu-devel] [PATCH 02/18] savevm: export qemu_save_device_state()

2013-08-21 Thread Lei Li
Export qemu_save_device_state() for localhost migration. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/sysemu/sysemu.h |1 + savevm.c|7 ++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h

[Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit

2013-08-21 Thread Lei Li
Commit 1964a397063967acc5ce71a2a24ed26e74824ee1 refactors rate limiting to QEMUFile, but set the return value for qemu_file_rate_limit to 1 in the case of qemu_file_get_error. It is wrong and should be negative compared to the original function buffered_rate_limit and the current logic in

[Qemu-devel] [PATCH 16/18] migration-local: implementation of incoming part

2013-08-21 Thread Lei Li
Implementation of incoming part of localhost migration. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |2 + include/migration/qemu-file.h |8 ++-- migration-local.c | 99 + 3 files changed, 105

[Qemu-devel] [PATCH 09/18] exec: export qemu_get_ram_block()

2013-08-21 Thread Lei Li
Export qemu_get_ram_block() for localhost migration to get the RAMBlock of given ram address. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- exec.c|7 ++- include/exec/cpu-common.h |1 + 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/exec.c

[Qemu-devel] [PATCH 11/18] migration: introduce capability localhost

2013-08-21 Thread Lei Li
Introduce migration capability localhost. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |3 +++ migration.c | 12 qapi-schema.json |8 +++- 3 files changed, 22 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook()

2013-08-21 Thread Lei Li
It should set negative error value if there has been an error. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 1522d95..f10e031 100644 --- a/savevm.c +++ b/savevm.c @@ -649,7 +649,7 @@

[Qemu-devel] [PATCH 12/18] arch_init: factor out ram_save_blocks()

2013-08-21 Thread Lei Li
Factor out ram_save_blocks(), which will be used to send ram blocks hooked by save_page in ram_save_setup stage in coming patch. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 25 +++-- 1 files changed, 15 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 15/18] migration: adjust migration_thread for local migration

2013-08-21 Thread Lei Li
Integrate localhost migration thread to migration_thread. As the mechanism of local migration is different than the current migration, and it does not need to do iterate. So the whole thread can split into two stages, it will send all the ram pages in qemu_savevm_state_begin stage, and send the

[Qemu-devel] [PATCH 14/18] arch_init: skip migration_bitmap_sync for local migration

2013-08-21 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index cbbb4db..e6069eb 100644 --- a/arch_init.c +++ b/arch_init.c @@ -375,6 +375,11 @@ static void migration_bitmap_sync(void)

[Qemu-devel] [PATCH 16/18] migration-local: implementation of incoming part

2013-08-21 Thread Lei Li
Implementation of incoming part of localhost migration. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |2 + include/migration/qemu-file.h |8 ++-- migration-local.c | 99 + 3 files changed, 105

[Qemu-devel] [PATCH 17/18] migration: add prefix for local migration to incoming migration

2013-08-21 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- migration.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 2471664..17cf2fd 100644 --- a/migration.c +++ b/migration.c @@ -81,6 +81,9 @@ void qemu_start_incoming_migration(const char

[Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-21 Thread Lei Li
Send all the ram blocks hooked by save_page, which will copy ram page and MADV_DONTNEED the page just copied. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index

[Qemu-devel] [PATCH 18/18] hmp: better fomat for info migrate_capabilities

2013-08-21 Thread Lei Li
As we have more and more capabilities, better to display in lines. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hmp.c b/hmp.c index c45514b..3544219 100644 --- a/hmp.c +++ b/hmp.c @@ -226,13 +226,12 @@ void

Re: [Qemu-devel] [PATCH v3 3/3] slirp: set mainloop timeout with more precise value

2013-08-21 Thread Alex Bligh
--On 21 August 2013 10:15:52 +0800 Liu Ping Fan qemul...@gmail.com wrote: -void slirp_update_timeout(uint32_t *timeout) +static void slirp_update_timeout(uint32_t *timeout) { -if (!QTAILQ_EMPTY(slirp_instances)) { -*timeout = MIN(1000, *timeout); If you are putting things in

Re: [Qemu-devel] [PATCH V8 07/11] NUMA: set guest numa nodes memory policy

2013-08-21 Thread Wanlong Gao
On 08/21/2013 03:15 PM, Andrew Jones wrote: - Original Message - On 08/20/2013 09:41 PM, Andrew Jones wrote: + +/* This is a workaround for a long standing bug in Linux' + * mbind implementation, which cuts off the last specified + * node. To stay compatible should

Re: [Qemu-devel] [PULL 08/11] add test-int128 and test-bitops to .gitignore

2013-08-21 Thread Laszlo Ersek
On 08/20/13 21:16, Andreas Färber wrote: Am 20.08.2013 20:39, schrieb Luiz Capitulino: On Tue, 20 Aug 2013 18:23:00 +0200 Andreas Färber afaer...@suse.de wrote: Am 20.08.2013 18:10, schrieb Luiz Capitulino: diff --git a/.gitignore b/.gitignore index 0fe114d..a8e0f17 100644 --- a/.gitignore

Re: [Qemu-devel] [PATCH v2 0/8] OptsVisitor: support / flatten integer ranges for repeating options

2013-08-21 Thread Laszlo Ersek
On 08/20/13 03:09, Wanlong Gao wrote: On 08/20/2013 06:35 AM, Laszlo Ersek wrote: v1-v2: Tested-by: Wanlong Gao gaowanl...@cn.fujitsu.com Thank you. Laszlo

[Qemu-devel] [PATCH 10/18] migration-local: implementation of outgoing part

2013-08-21 Thread Lei Li
Implementation of outgoing part for localhost migration. The integration of migration thread and corresponding adjustment will be in coming patches. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |2 + migration-local.c | 85

Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type

2013-08-21 Thread Marcel Apfelbaum
On Wed, 2013-08-14 at 10:02 +0300, Ronen Hod wrote: How about adding a flag that tells QEMU whether to pause or reboot the guest after the panic? We cannot assume that we always have a management layer that takes care of this. One example is Microsoft's WHQL that deliberately generates a

[Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local()

2013-08-21 Thread Lei Li
Introduce read/write backend of QEMUFileLocal used by localhost migration. The unix domain socket will be replaced by PIPE with vmsplice mechanism. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- Makefile.objs |1 + migration-local.c | 211

Re: [Qemu-devel] [PATCH v3 3/3] slirp: set mainloop timeout with more precise value

2013-08-21 Thread liu ping fan
On Wed, Aug 21, 2013 at 3:36 PM, Alex Bligh a...@alex.org.uk wrote: --On 21 August 2013 10:15:52 +0800 Liu Ping Fan qemul...@gmail.com wrote: -void slirp_update_timeout(uint32_t *timeout) +static void slirp_update_timeout(uint32_t *timeout) { -if (!QTAILQ_EMPTY(slirp_instances)) { -

Re: [Qemu-devel] [PATCH 1/2] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 00:53, Charlie Shepherd ha scritto: On 20/08/2013 21:48, Paolo Bonzini wrote: Il 20/08/2013 20:34, Charlie Shepherd ha scritto: /* Return true if first block has been changed (ie. current version is @@ -146,40 +114,82 @@ static inline int is_bit_set(BlockDriverState *bs,

Re: [Qemu-devel] [PATCH] block: Fix race in gluster_finish_aiocb

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 04:02, Asias He ha scritto: In block/gluster.c, we have gluster_finish_aiocb { if (retval != sizeof(acb)) { qemu_mutex_lock_iothread(); /* We are in gluster thread context */ ... qemu_mutex_unlock_iothread(); } } qemu tools, e.g. qemu-img, might

Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for raw

2013-08-21 Thread Laszlo Ersek
On 08/20/13 10:21, Kevin Wolf wrote: Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben: Paolo asked me to write such a driver based on his textual specification alone. The first patch captures his email in full, the rest re-quotes parts that are being implemented. The tree compiles at each

Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 10:03, Marcel Apfelbaum ha scritto: On Wed, 2013-08-14 at 10:02 +0300, Ronen Hod wrote: How about adding a flag that tells QEMU whether to pause or reboot the guest after the panic? We cannot assume that we always have a management layer that takes care of this. One example is

[Qemu-devel] [PATCH] block: Introduce bs-zero_beyond_eof

2013-08-21 Thread Asias He
In 4146b46c42e0989cb5842e04d88ab6ccb1713a48 (block: Produce zeros when protocols reading beyond end of file), we break qemu-iotests ./check -qcow2 022. This happens because qcow2 temporarily sets -growable = 1 for vmstate accesses (which are stored beyond the end of regular image data). We

Re: [Qemu-devel] [RFC] Convert AioContext to Gsource sub classes

2013-08-21 Thread Stefan Hajnoczi
On Tue, Aug 20, 2013 at 05:59:58PM +0800, Wenchao Xia wrote: 于 2013-8-16 16:12, Wenchao Xia 写道: 于 2013-8-16 15:15, Wenchao Xia 写道: 于 2013-8-16 0:32, Michael Roth 写道: Quoting Michael Roth (2013-08-15 10:23:20) Quoting Wenchao Xia (2013-08-13 03:44:39) 于 2013-8-13 1:01, Michael Roth 写道:

Re: [Qemu-devel] [Qemu-ppc] [PATCH] powerpc iommu: enable multiple TCE requests

2013-08-21 Thread Alexander Graf
On 21.08.2013, at 08:11, Alexander Graf wrote: On 20.08.2013, at 12:38, Benjamin Herrenschmidt wrote: On Tue, 2013-08-20 at 12:14 +0200, Paolo Bonzini wrote: I suppose if RH is going to deploy 3.10 and we aren't going to backport the multitce patches then there *might* be a case for

Re: [Qemu-devel] [PATCH 5/8] vfio: Add guest side IOMMU support

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 07:31, Alexey Kardashevskiy ha scritto: memory_region_ref(section-mr); === You want me to move memory_region_ref() earlier to add a reference even if two last checks fail? No, of course not---I was looking at _del source code not _add. Paolo

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Marcel Apfelbaum
On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: This isn't patch review, just a couple of observations and questions. Current use of categories, please correct misunderstandings: * A device can have multiple categories. Most (all?) devices currently have exactly one. All

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 03:22, Wanlong Gao ha scritto: On 08/20/2013 09:43 PM, Paolo Bonzini wrote: Il 20/08/2013 03:07, Wanlong Gao ha scritto: -numa node,nodeid=0,cpus=0, \ -numa mem,size=1024M,policy=membind,host-nodes=0-1 \ -numa node,nodeid=1,cpus=1 \ -numa

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-21 Thread Stefan Hajnoczi
On Thu, Aug 15, 2013 at 09:34:21PM +0100, Alex Bligh wrote: @@ -150,13 +150,14 @@ aio_ctx_prepare(GSource *source, gint*timeout) { AioContext *ctx = (AioContext *) source; QEMUBH *bh; +int deadline; for (bh = ctx-first_bh; bh; bh = bh-next) { if

Re: [Qemu-devel] [PATCH 0/7] introduce BSD-licensed block driver for raw

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 10:20, Laszlo Ersek ha scritto: On 08/20/13 10:21, Kevin Wolf wrote: Am 16.08.2013 um 16:15 hat Laszlo Ersek geschrieben: Paolo asked me to write such a driver based on his textual specification alone. The first patch captures his email in full, the rest re-quotes parts that are

[Qemu-devel] [PATCH] q35: fix GPE method for cpu hotplug

2013-08-21 Thread Hu Tao
cpu hotplug uses bit 2 of GPE instead of bit 1. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/q35-acpi-dsdt.dsl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/q35-acpi-dsdt.dsl b/src/q35-acpi-dsdt.dsl index c031d83..417ac48 100644 --- a/src/q35-acpi-dsdt.dsl +++

[Qemu-devel] [PATCH 1/2] ich9: update sci on gpe write

2013-08-21 Thread Hu Tao
OSPM may disable the sci by clearing GPEx_BLK EN bit, in the case we have to set sci level to 0 or guest will receive sci interrupts endlessly. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/acpi/ich9.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c

[Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-08-21 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/acpi/ich9.c | 91 -- include/hw/acpi/ich9.h | 11 ++ 2 files changed, 100 insertions(+), 2 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 8717c15..146216a 100644 ---

Re: [Qemu-devel] Fwd: [libvirt] virDomainAttachDevice error during disk hotplug

2013-08-21 Thread Daniel P. Berrange
On Wed, Aug 21, 2013 at 11:03:49AM +0200, Stefan Hajnoczi wrote: On Tue, Aug 20, 2013 at 03:57:40PM +0100, Daniel P. Berrange wrote: On Tue, Aug 20, 2013 at 04:43:48PM +0200, Stefan Hajnoczi wrote: On Fri, Aug 16, 2013 at 06:52:32PM +0530, Deepak C Shetty wrote: 2) qemu-img info

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-21 Thread Stefan Hajnoczi
On Tue, Aug 20, 2013 at 12:12:21PM +0100, Peter Maydell wrote: On 20 August 2013 11:56, Paolo Bonzini pbonz...@redhat.com wrote: I guess patches are welcome---if they are of good quality, why not. Well, sort of. Given the fairly minimal level of support we currently have for OSX (ie Andreas

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-21 Thread Wanlong Gao
On 08/21/2013 05:00 PM, Paolo Bonzini wrote: Il 21/08/2013 03:22, Wanlong Gao ha scritto: On 08/20/2013 09:43 PM, Paolo Bonzini wrote: Il 20/08/2013 03:07, Wanlong Gao ha scritto: -numa node,nodeid=0,cpus=0, \ -numa mem,size=1024M,policy=membind,host-nodes=0-1 \ -numa node,nodeid=1,cpus=1

Re: [Qemu-devel] Fwd: [libvirt] virDomainAttachDevice error during disk hotplug

2013-08-21 Thread Stefan Hajnoczi
On Tue, Aug 20, 2013 at 03:57:40PM +0100, Daniel P. Berrange wrote: On Tue, Aug 20, 2013 at 04:43:48PM +0200, Stefan Hajnoczi wrote: On Fri, Aug 16, 2013 at 06:52:32PM +0530, Deepak C Shetty wrote: 2) qemu-img info /var/run/vdsm/017d-1278-4bfb-8129-62bded257399 image:

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-08-21 Thread Hu Tao
Added: Igor Mammedov imamm...@redhat.com On Wed, Aug 21, 2013 at 05:04:28PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/acpi/ich9.c | 91 -- include/hw/acpi/ich9.h | 11 ++ 2 files changed, 100

Re: [Qemu-devel] [PATCH 1/2] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-21 Thread Charlie Shepherd
On 21/08/2013 09:14, Paolo Bonzini wrote: Il 21/08/2013 00:53, Charlie Shepherd ha scritto: What if nb_sectors 512 * 8? For cow_co_is_allocated, you have the luxury of returning information only for the fewer than nb_sectors. That is, you can set *num_same to a smaller value than nb_sectors,

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 11:08, Stefan Hajnoczi ha scritto: On Tue, Aug 20, 2013 at 12:12:21PM +0100, Peter Maydell wrote: On 20 August 2013 11:56, Paolo Bonzini pbonz...@redhat.com wrote: I guess patches are welcome---if they are of good quality, why not. Well, sort of. Given the fairly minimal level

Re: [Qemu-devel] [PATCH V8 00/13] monitor: support sub command group in auto completion and help

2013-08-21 Thread Wenchao Xia
于 2013-8-20 22:04, Luiz Capitulino 写道: On Tue, 30 Jul 2013 12:03:11 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Fri, 26 Jul 2013 11:20:29 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This series make auto completion and help functions works normal for sub command, by using

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: This isn't patch review, just a couple of observations and questions. Current use of categories, please correct misunderstandings: * A device can have multiple categories. Most (all?)

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 11:08, Wanlong Gao ha scritto: Also, do you still need a -m option if you use -numa mem? The -m options will be used to compute the memory size of each node if the memory size of each node is not set by -numa mem option. This is also be consistent with the original concept.

[Qemu-devel] [PATCH 0/2] vfio: fixes for better support for 128 bit memory section sizes

2013-08-21 Thread Alexey Kardashevskiy
I made a couple of small patches while debugging VFIO on SPAPR which uses IOMMU MemoryRegion 2^64 bytes long. I was specifically fixing faults with the 2^64 bytes case while there may be other proglems. Alexey Kardashevskiy (2): vfio: Fix debug output for int128 values vfio: Fix 128 bit

[Qemu-devel] [PATCH 2/2] vfio: Fix 128 bit handling

2013-08-21 Thread Alexey Kardashevskiy
Upcoming VFIO on SPAPR PPC64 support will initialize the IOMMU memory region with UINT64_MAX (2^64 bytes) size so int128_get64() will assert. The patch takes care of this check. The existing type1 IOMMU code is not expected to map all 64 bits of RAM so the patch does not touch that part.

[Qemu-devel] [PATCH 1/2] vfio: Fix debug output for int128 values

2013-08-21 Thread Alexey Kardashevskiy
Memory regions can easily be 2^64 byte long and therefore overflow for just a bit but that is enough for int128_get64() to assert. This takes care of debug printing of huge section sizes. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- hw/misc/vfio.c | 6 -- 1 file changed, 4

Re: [Qemu-devel] [PATCH] q35: Add PCIe switch to example q35 configuration

2013-08-21 Thread Markus Armbruster
Alex Williamson alex.william...@redhat.com writes: Signed-off-by: Alex Williamson alex.william...@redhat.com --- docs/q35-chipset.cfg | 23 +++ 1 file changed, 23 insertions(+) diff --git a/docs/q35-chipset.cfg b/docs/q35-chipset.cfg index 1b6efc0..e4ddb7d 100644

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-21 Thread Laszlo Ersek
On 08/20/13 03:07, Wanlong Gao wrote: V7-V8: rebase to current master with Laszlo's V2 of OptsVisitor patch set fix an adding white space line error My R-b's that you've kept from V7, for patches 01 and 02, stand. Thanks Laszlo

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-21 Thread Stefan Weil
Am 21.08.2013 11:11, schrieb Paolo Bonzini: Still, I must say merging Xen has given us zero headaches. It's taken a while, but (at least from the QEMU project's POV) the wait has been worthwhile. I would hope that HAXN support would be almost as easy as adding haxn-all.c and haxn-stub.c

Re: [Qemu-devel] [RFC] Convert AioContext to Gsource sub classes

2013-08-21 Thread Wenchao Xia
于 2013-8-21 16:45, Stefan Hajnoczi 写道: On Tue, Aug 20, 2013 at 05:59:58PM +0800, Wenchao Xia wrote: 于 2013-8-16 16:12, Wenchao Xia 写道: 于 2013-8-16 15:15, Wenchao Xia 写道: 于 2013-8-16 0:32, Michael Roth 写道: Quoting Michael Roth (2013-08-15 10:23:20) Quoting Wenchao Xia (2013-08-13 03:44:39)

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-21 Thread Wanlong Gao
On 08/21/2013 05:22 PM, Paolo Bonzini wrote: Il 21/08/2013 11:08, Wanlong Gao ha scritto: Also, do you still need a -m option if you use -numa mem? The -m options will be used to compute the memory size of each node if the memory size of each node is not set by -numa mem option. This is also

Re: [Qemu-devel] [PATCH] q35: Add PCIe switch to example q35 configuration

2013-08-21 Thread Michael S. Tsirkin
On Tue, Aug 20, 2013 at 12:21:57PM -0600, Alex Williamson wrote: Signed-off-by: Alex Williamson alex.william...@redhat.com Thanks, applied. --- docs/q35-chipset.cfg | 23 +++ 1 file changed, 23 insertions(+) diff --git a/docs/q35-chipset.cfg b/docs/q35-chipset.cfg

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-21 Thread Wanlong Gao
On 08/21/2013 05:33 PM, Laszlo Ersek wrote: On 08/20/13 03:07, Wanlong Gao wrote: V7-V8: rebase to current master with Laszlo's V2 of OptsVisitor patch set fix an adding white space line error My R-b's that you've kept from V7, for patches 01 and 02, stand. Yeah, thank you. ;)

Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 10:18:23AM +0200, Paolo Bonzini wrote: Il 21/08/2013 10:03, Marcel Apfelbaum ha scritto: On Wed, 2013-08-14 at 10:02 +0300, Ronen Hod wrote: How about adding a flag that tells QEMU whether to pause or reboot the guest after the panic? We cannot assume that we

Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type

2013-08-21 Thread Hu Tao
On Wed, Aug 21, 2013 at 12:42:37PM +0300, Michael S. Tsirkin wrote: On Wed, Aug 21, 2013 at 10:18:23AM +0200, Paolo Bonzini wrote: Il 21/08/2013 10:03, Marcel Apfelbaum ha scritto: On Wed, 2013-08-14 at 10:02 +0300, Ronen Hod wrote: How about adding a flag that tells QEMU whether to pause

Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 11:42, Michael S. Tsirkin ha scritto: On Wed, Aug 21, 2013 at 10:18:23AM +0200, Paolo Bonzini wrote: Il 21/08/2013 10:03, Marcel Apfelbaum ha scritto: On Wed, 2013-08-14 at 10:02 +0300, Ronen Hod wrote: How about adding a flag that tells QEMU whether to pause or reboot the

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 11:34, Wanlong Gao ha scritto: On 08/21/2013 05:22 PM, Paolo Bonzini wrote: Il 21/08/2013 11:08, Wanlong Gao ha scritto: Also, do you still need a -m option if you use -numa mem? The -m options will be used to compute the memory size of each node if the memory size of each node

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 11:33, Stefan Weil ha scritto: Am 21.08.2013 11:11, schrieb Paolo Bonzini: Still, I must say merging Xen has given us zero headaches. It's taken a while, but (at least from the QEMU project's POV) the wait has been worthwhile. I would hope that HAXN support would be almost as

Re: [Qemu-devel] [RFC] Convert AioContext to Gsource sub classes

2013-08-21 Thread Alex Bligh
--On 21 August 2013 10:45:53 +0200 Stefan Hajnoczi stefa...@gmail.com wrote: Since AioContext provides a GSource, integrating with an application's glib event loop should also be easy. The only hard part is timers, since we use nanosecond timers - there we should just round up to

Re: [Qemu-devel] [PATCHv11 13/31] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-21 Thread Alex Bligh
Stefan, --On 21 August 2013 11:01:42 +0200 Stefan Hajnoczi stefa...@gmail.com wrote: I agree with Wenchao: The docs explicitly say that .prepare() can set timeout to the maximum timeout value that is required. It then explains that the actual timeout used is the minimum of all timeout

Re: [Qemu-devel] [PATCH 2/2] vfio: Fix 128 bit handling

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 11:28, Alexey Kardashevskiy ha scritto: Upcoming VFIO on SPAPR PPC64 support will initialize the IOMMU memory region with UINT64_MAX (2^64 bytes) size so int128_get64() will assert. The patch takes care of this check. The existing type1 IOMMU code is not expected to map all 64

Re: [Qemu-devel] [PATCH 1/2] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 11:11, Charlie Shepherd ha scritto: For cow_co_is_allocated, you have the luxury of returning information only for the fewer than nb_sectors. That is, you can set *num_same to a smaller value than nb_sectors, even if sector_num + *num_same has the same state as the [sector_num,

Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 11:59:36AM +0200, Paolo Bonzini wrote: Il 21/08/2013 11:42, Michael S. Tsirkin ha scritto: On Wed, Aug 21, 2013 at 10:18:23AM +0200, Paolo Bonzini wrote: Il 21/08/2013 10:03, Marcel Apfelbaum ha scritto: On Wed, 2013-08-14 at 10:02 +0300, Ronen Hod wrote: How about

Re: [Qemu-devel] [PATCH 1/2] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-21 Thread Charlie Shepherd
On 21/08/2013 10:19, Paolo Bonzini wrote: Il 21/08/2013 11:11, Charlie Shepherd ha scritto: It still seems worthwhile to me to be as efficient as possible, I guess that means processing a sector's worth of metadata at a time? Yes, that's what my patches do. My is_allocated and flushing

Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 12:16, Michael S. Tsirkin ha scritto: By the way, this means two things: - I am now sold on the idea that explicitly enabling of pvpanic is the right thing to do; - on the other hand this is the proof that the change was not fully understood, and rushing it in 1.6

[Qemu-devel] [PATCH v2 2/7] raw_bsd: emit debug events in bdrv_co_readv() and bdrv_co_writev()

2013-08-21 Thread Laszlo Ersek
On 08/05/13 15:03, Paolo Bonzini wrote: [...] 1) BlockDriver is a struct in which these function members are interesting: .bdrv_reopen_prepare .bdrv_co_readv .bdrv_co_writev .bdrv_co_is_allocated .bdrv_co_write_zeroes .bdrv_co_discard .bdrv_getlength

[Qemu-devel] [PATCH v2 4/7] raw_bsd: introduce special members

2013-08-21 Thread Laszlo Ersek
On 08/05/13 15:03, Paolo Bonzini wrote: [...] 3) These members are special .format_name is the string raw .bdrv_open raw_open should set bs-sg to bs-file-sg and return 0 .bdrv_closeraw_close should do nothing .bdrv_proberaw_probe should just return 1. v1-v2:

[Qemu-devel] [PATCH v2 3/7] raw_bsd: add raw_create()

2013-08-21 Thread Laszlo Ersek
On 08/05/13 15:03, Paolo Bonzini wrote: [...] 2) This is also a simple forwarder function: .bdrv_create but there is no BlockDriverState argument so the forwarded-to function does not have a bs-file argument either. The forwarded-to function is bdrv_create_file. Signed-off-by:

[Qemu-devel] [PATCH v2 0/7] introduce BSD-licensed block driver for raw

2013-08-21 Thread Laszlo Ersek
v1-v2: - added comment to raw_probe() [Kevin] - fixed raw_reopen_prepare() [Paolo Kevin] - keeping BSDL: according to the v1 discussion, LGPLv2+ could work too, but but most of the block layer is BSD [Paolo] and I haven't been clearly instructed to switch to LGPLv2+. diff --git

[Qemu-devel] [PATCH v2 1/7] add skeleton for BSD licensed raw BlockDriver

2013-08-21 Thread Laszlo Ersek
On 08/05/13 15:03, Paolo Bonzini wrote: - Original Message - From: Laszlo Ersek ler...@redhat.com To: Paolo Bonzini pbonz...@redhat.com Sent: Monday, August 5, 2013 2:43:46 PM Subject: Re: [PATCH 1/2] raw: add license header On 08/02/13 00:27, Paolo Bonzini wrote: On 08/01/2013

Re: [Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook()

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: It should set negative error value if there has been an error. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 1522d95..f10e031 100644

[Qemu-devel] [PATCH v2 5/7] raw_bsd: add raw_create_options

2013-08-21 Thread Laszlo Ersek
On 08/05/13 15:03, Paolo Bonzini wrote: [...] 4) There is another member, .create_options, which is an array of QEMUOptionParameter structs, terminated by an all-zero item. The only option you need is for the virtual disk size. You will find something to copy from in other block drivers,

[Qemu-devel] [PATCH v2 7/7] switch raw block driver from raw.o to raw_bsd.o

2013-08-21 Thread Laszlo Ersek
Incoming function prototypes and outgoing function calls must match reality. Implemented using the struct BlockDriver definition in include/block/block_int.h, and gcc errors warnings. v1-v2: On 08/20/13 09:51, Kevin Wolf wrote: Am 18.08.2013 um 16:29 hat Paolo Bonzini geschrieben: Il

[Qemu-devel] [PATCH v2 6/7] raw_bsd: register bdrv_raw

2013-08-21 Thread Laszlo Ersek
On 08/05/13 15:03, Paolo Bonzini wrote: [...] 5) Formats are registered with bdrv_register (takes a BlockDriver*). You also need to pass the caller of bdrv_register to block_init. Fill in the BlockDriver structure with the raw_*() functions that have been added to block/raw_bsd.c, in the

Re: [Qemu-devel] [PATCH 04/18] savevm: set right return value for qemu_file_rate_limit

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: Commit 1964a397063967acc5ce71a2a24ed26e74824ee1 refactors rate limiting to QEMUFile, but set the return value for qemu_file_rate_limit to 1 in the case of qemu_file_get_error. It is wrong and should be negative compared to the original function

Re: [Qemu-devel] [PATCH 05/18] savevm: add comments for qemu_file_get_error()

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: Add comments for qemu_file_get_error(), as its return value is not very clear. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- savevm.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index

Re: [Qemu-devel] [PATCH 1/2] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 12:31, Charlie Shepherd ha scritto: On 21/08/2013 10:19, Paolo Bonzini wrote: Il 21/08/2013 11:11, Charlie Shepherd ha scritto: It still seems worthwhile to me to be as efficient as possible, I guess that means processing a sector's worth of metadata at a time? Yes, that's what

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Marcel Apfelbaum
On Wed, 2013-08-21 at 11:23 +0200, Markus Armbruster wrote: Marcel Apfelbaum marce...@redhat.com writes: On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: This isn't patch review, just a couple of observations and questions. Current use of categories, please correct

Re: [Qemu-devel] [PATCH 10/18] migration-local: implementation of outgoing part

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: Implementation of outgoing part for localhost migration. The integration of migration thread and corresponding adjustment will be in coming patches. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/migration/migration.h |2 +

[Qemu-devel] updated: kvm PCI todo wiki

2013-08-21 Thread Michael S. Tsirkin
Hey guys, I've put up a wiki page with a kvm PCI todo list, mainly to avoid effort duplication, but also in the hope to draw attention to what I think we should try addressing in KVM: http://www.linux-kvm.org/page/PCITodo This page could cover all PCI related activity in KVM, it is very

Re: [Qemu-devel] [PATCH 15/18] migration: adjust migration_thread for local migration

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: Integrate localhost migration thread to migration_thread. As the mechanism of local migration is different than the current migration, and it does not need to do iterate. So the whole thread can split into two stages, it will send all the ram pages in

Re: [Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: Send all the ram blocks hooked by save_page, which will copy ram page and MADV_DONTNEED the page just copied. You should implement this entirely in the hook. It will be a little less efficient because of the dirty bitmap overhead, but you should aim at

Re: [Qemu-devel] [PATCH 07/18] arch_init: export RAM_SAVE_xxx flags

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: Export RAM_SAVE_xxx flags for localhost migration. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c | 12 include/migration/migration.h | 14 ++ 2 files changed, 14 insertions(+), 12

Re: [Qemu-devel] [PATCH 14/18] arch_init: skip migration_bitmap_sync for local migration

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- arch_init.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index cbbb4db..e6069eb 100644 --- a/arch_init.c +++ b/arch_init.c @@ -375,6

Re: [Qemu-devel] [PATCH 17/18] migration: add prefix for local migration to incoming migration

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- migration.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 2471664..17cf2fd 100644 --- a/migration.c +++ b/migration.c @@ -81,6 +81,9 @@

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-08-21 Thread Gerd Hoffmann
Hi, +#define ICH9_PROC_BASE 0xaf00 +#define ICH9_PROC_LEN 32 No, please don't. It makes it impossible to assign the 0xa000 - 0xafff I/O port window to a PCI bridge. Please lets stop occupy random io ports above 0x1000 and burn I/O address space that way. I'd suggest to place it at 0x0a00

Re: [Qemu-devel] [SeaBIOS] [PATCH] q35: fix GPE method for cpu hotplug

2013-08-21 Thread Gerd Hoffmann
Hi, Method(_L01) { +} +Method(_E02) { // CPU hotplug event \_SB.PRSC() } -Method(_L02) { -} E02? Typo? cheers, Gerd

  1   2   3   >