On 08/29/2013 04:29 PM, Paolo Bonzini wrote:
> Il 29/08/2013 04:26, Alexey Kardashevskiy ha scritto:
>>
>> Right. I was planning to add my IOMMU stuff right before calculating @end.
>
> But then the non-IOMMU stuff can just use int128_get64, no? So even if
> this patch simply uses int128_get64, i
Kindly ignore last email...it is reproducible on XP as well.
On Thu, Aug 29, 2013 at 11:31 AM, Taimoor Mirza wrote:
> I just tried it on Windows XP and its working fine there. So this
> problem comes only on Windows 7.
>
> -Taimoor
>
> On Thu, Aug 29, 2013 at 12:10 AM, Taimoor Mirza
> wrote
On Tue, Aug 27, 2013 at 01:45:41PM +0530, Bharata B Rao wrote:
> Currently if gluster AIO callback thread fails to notify the QEMU thread about
> AIO completion, we try graceful recovery by marking the disk drive as
> inaccessible. This error recovery code is race-prone as found by Asias and
> Stef
On Thu, Aug 29, 2013 at 09:09:45AM +0800, Wenchao Xia wrote:
> 于 2013-8-28 16:49, Stefan Hajnoczi 写道:
> >On Wed, Aug 28, 2013 at 11:25:33AM +0800, Wenchao Xia wrote:
> >>>+void aio_context_release(AioContext *ctx)
> >>>+{
> >>>+qemu_mutex_lock(&ctx->acquire_lock);
> >>>+assert(ctx->owner &&
Am 29.08.2013 um 09:35 hat Stefan Hajnoczi geschrieben:
> On Tue, Aug 27, 2013 at 01:45:41PM +0530, Bharata B Rao wrote:
> > Currently if gluster AIO callback thread fails to notify the QEMU thread
> > about
> > AIO completion, we try graceful recovery by marking the disk drive as
> > inaccessible
> On August 28, 2013 at 9:22 PM Erik Rull wrote:
>
>
> Benoît Canet wrote:
> >> thanks for your help. I cloned the git and compiled it - but I'm not
> >> completely sure how to enable the throttling finally - there were
> >> several mails regarding averages and max values... And the "unit" of
> >>
This converts old style fprintf to traces.
Signed-off-by: Alexey Kardashevskiy
---
hw/ppc/spapr_iommu.c | 75 ++--
trace-events | 5
2 files changed, 31 insertions(+), 49 deletions(-)
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_
The existing driver just dropped unsupported requests. This adds error
responses to those unhandled requests.
Signed-off-by: Alexey Kardashevskiy
---
Changes:
v2:
* reorganized code to have one return from the function
* fixed response length according to the spec, it is byte-swapped in
vscsi_sen
- Original Message -
> On 08/28/2013 09:44 PM, Paolo Bonzini wrote:
> > Il 26/08/2013 10:43, Andrew Jones ha scritto:
> >>
> >> - Original Message -
> On 08/26/2013 03:46 PM, Andrew Jones wrote:
> >> Is this patch still necessary? I thought that dropping the
> >>>
On 08/27/2013 06:36 PM, Alexander Graf wrote:
>
> On 27.08.2013, at 06:10, Benjamin Herrenschmidt wrote:
>
>> On Tue, 2013-08-27 at 03:48 +0200, Andreas Färber wrote:
>>> Also, QEMU is definitely not the only project that has higher
>>> acceptance
>>> criteria than patch-works-for-the-patch-autho
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
> This adds an incompatible bit indicating corruption to qcow2. Any image
> with this bit set may not be written to unless for repairing (and
> subsequently clearing the bit if the repair has been successful).
>
> Signed-off-by: Max Reitz
> ---
>
Currently HVM S3 has a bug coming from the difference between
qemu-traditioanl and qemu-xen. For qemu-traditional, the way
to resume from hvm s3 is via 'xl trigger' command. However,
for qemu-xen, the way to resume from hvm s3 inherited from
standard qemu, i.e. via QMP, and it doesn't work under Xe
Currently HVM S3 has a bug coming from the difference between
qemu-traditioanl and qemu-xen. For qemu-traditional, the way
to resume from hvm s3 is via 'xl trigger' command. However,
for qemu-xen, the way to resume from hvm s3 inherited from
standard qemu, i.e. via QMP, and it doesn't work under Xe
On 08/23/2013 09:38 PM, Andreas Färber wrote:
> Am 23.08.2013 05:39, schrieb Alexey Kardashevskiy:
>> On 08/19/2013 11:54 PM, Andreas Färber wrote:
>>> Am 19.08.2013 07:55, schrieb Alexey Kardashevskiy:
The upcoming support of in-kernel XICS will redefine migration callbacks
for both ICS
Am 29.08.2013 10:23, schrieb Kevin Wolf:
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
This adds an incompatible bit indicating corruption to qcow2. Any image
with this bit set may not be written to unless for repairing (and
subsequently clearing the bit if the repair has been successful).
On 08/28/2013 02:37 PM, Paolo Bonzini wrote:
Il 28/08/2013 05:26, Lei Li ha scritto:
RAMBlock structs are not visible outside of exec.c and arch_init.c,
how did you do this?
Hi Michael,
Good catch!
Actually this is the 'Known issue' that I listed in the cover
letter, and I planed to ask sugges
On Thu, Aug 29, 2013 at 12:10:48AM +0500, Taimoor Mirza wrote:
> Hi Stefan,
>
> Below is result of bt:
>
> Breakpoint 1, 0x006ac304 in abort ()
> (gdb) bt
> #0 0x006ac304 in abort ()
> #1 0x00553052 in _fu10846stack_chk_guard () at qemu-coroutine.c:111
> #2 0x0040d746 in _fu473stack_ch
- Original Message -
>
>
> - Original Message -
> > On 08/28/2013 09:44 PM, Paolo Bonzini wrote:
> > > Il 26/08/2013 10:43, Andrew Jones ha scritto:
> > >>
> > >> - Original Message -
> > On 08/26/2013 03:46 PM, Andrew Jones wrote:
> > >> Is this patch still
Il 26/08/2013 17:00, Fabio Fantoni ha scritto:
Il 16/08/2013 16:46, Anthony PERARD ha scritto:
In some cases (Xen), it will not be initialized before to be used. This
leads to segv.
Signed-off-by: Anthony PERARD
Tested-by: Fabio Fantoni
This patch have solved the critical regression of all
Am 29.08.2013 10:25, schrieb Alexey Kardashevskiy:
> On 08/23/2013 09:38 PM, Andreas Färber wrote:
>> Am 23.08.2013 05:39, schrieb Alexey Kardashevskiy:
>>> On 08/19/2013 11:54 PM, Andreas Färber wrote:
Am 19.08.2013 07:55, schrieb Alexey Kardashevskiy:
> The upcoming support of in-kernel
On Wed, Aug 28, 2013 at 10:04:32PM -0300, Eduardo Otubo wrote:
> Now there's a second whitelist, right before the vcpu starts. The second
> whitelist is the same as the first one, except for exec() and select().
-netdev tap,downscript=/path/to/script requires exec() in the QEMU
shutdown code path.
Am 19.08.2013 07:55, schrieb Alexey Kardashevskiy:
> From: David Gibson
>
> Recent (host) kernels support emulating the PAPR defined "XICS" interrupt
> controller system within KVM. This patch allows qemu to initialize and
> configure the in-kernel XICS, and keep its state in sync with qemu's XI
Il 27/08/2013 16:39, Stefan Hajnoczi ha scritto:
> +void aio_context_acquire(AioContext *ctx)
> +{
> +qemu_mutex_lock(&ctx->acquire_lock);
> +while (ctx->owner) {
> +assert(!qemu_thread_is_self(ctx->owner));
> +aio_notify(ctx); /* kick current owner */
> +qemu_cond_w
On 16 August 2013 15:46, Anthony PERARD wrote:
> In some cases (Xen), it will not be initialized before to be used. This
> leads to segv.
>
> Signed-off-by: Anthony PERARD
>
> ---
>
> It works with this simple initialization to NULL, but would it be
> necessary (or better) to assign a proper valu
Il 29/08/2013 08:58, Alexey Kardashevskiy ha scritto:
> On 08/29/2013 04:29 PM, Paolo Bonzini wrote:
>> Il 29/08/2013 04:26, Alexey Kardashevskiy ha scritto:
>>>
>>> Right. I was planning to add my IOMMU stuff right before calculating @end.
>>
>> But then the non-IOMMU stuff can just use int128_get
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
> Two new functions are added; the first one checks a given range in the
> image file for overlaps with metadata (main header, L1 tables, L2
> tables, refcount table and blocks).
>
> The second one should be used immediately before writing to the i
On 08/29/2013 06:37 PM, Andreas Färber wrote:
> Am 19.08.2013 07:55, schrieb Alexey Kardashevskiy:
>> From: David Gibson
>>
>> Recent (host) kernels support emulating the PAPR defined "XICS" interrupt
>> controller system within KVM. This patch allows qemu to initialize and
>> configure the in-ke
Am 29.08.2013 um 10:27 hat Max Reitz geschrieben:
> Am 29.08.2013 10:23, schrieb Kevin Wolf:
> >Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
> >>This adds an incompatible bit indicating corruption to qcow2. Any image
> >>with this bit set may not be written to unless for repairing (and
> >>sub
Il 29/08/2013 10:34, Stefan Hajnoczi ha scritto:
> On Wed, Aug 28, 2013 at 10:04:32PM -0300, Eduardo Otubo wrote:
>> Now there's a second whitelist, right before the vcpu starts. The second
>> whitelist is the same as the first one, except for exec() and select().
>
> -netdev tap,downscript=/path/
Am 29.08.2013 10:51, schrieb Kevin Wolf:
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
Two new functions are added; the first one checks a given range in the
image file for overlaps with metadata (main header, L1 tables, L2
tables, refcount table and blocks).
The second one should be used i
Il 16/08/2013 16:46, Anthony PERARD ha scritto:
> In some cases (Xen), it will not be initialized before to be used. This
> leads to segv.
>
> Signed-off-by: Anthony PERARD
>
> ---
>
> It works with this simple initialization to NULL, but would it be
> necessary (or better) to assign a proper v
Am 29.08.2013 02:13, schrieb Alexander Graf:
> The function qemu_notify_event is defined by a header that we don't
> include in the PPC KVM code. Include it to get the code building
> again.
>
> target-ppc/kvm_ppc.c: In function 'kvmppc_timer_hack':
> target-ppc/kvm_ppc.c:26:5: error: implicit
On 08/28/2013 09:42 PM, David Gibson wrote:
> On Wed, Aug 28, 2013 at 07:32:51PM +1000, Alexey Kardashevskiy wrote:
>> PAPR+ requires two RTAS calls to be supported by the hypervisor in
>> order to allow hotplugging VCPUs from the guest. The "start-cpu" RTAS
>> call was already there but "stop-self
Hi,
I have tested this series of changes, PING?
On 08/26/2013 05:29 PM, Lei Li wrote:
Signed-off-by: Lei Li
Signed-off-by: Paolo Bonzini
---
Change since v1:
Return fixes and improvement from Paolo Bonzini.
arch_init.c | 15 ++-
1 files changed, 10 insertions(+), 5 d
On Wed, Aug 28, 2013 at 05:07:16PM +0200, Benoît Canet wrote:
> This patchset implement continous leaky bucket throttling.
>
> It use two requests queue to enable to do silly unbalanced throttling like
> block_set_io_throttle 0 0 0 0 6000 1
>
> It use two timer to get the timer callbacks and the
Adds an "assigned" flag to QEMUOptionParameter which is cleared at the
beginning of parse_option_parameters and set on (successful)
set_option_parameter and set_option_parameter_int.
Signed-off-by: Max Reitz
---
include/qemu/option.h | 1 +
util/qemu-option.c| 9 +
2 files changed, 1
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
> The pre-write overlap check function is now called before most of the
> qcow2 writes (aborting it on collision or other error).
>
> Signed-off-by: Max Reitz
> ---
> block/qcow2-cache.c| 17 +
> block/qcow2-cluster.c | 21 ++
Am 29.08.2013 11:18, schrieb Kevin Wolf:
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
The pre-write overlap check function is now called before most of the
qcow2 writes (aborting it on collision or other error).
Signed-off-by: Max Reitz
---
block/qcow2-cache.c| 17 +
> My commandline section is (I played with bps between 0.5 and 2.0 MB/sec and
> iops
> with 1000 and 500):
> -drive file=/dev/sda2,cache=none,bps=548576,bps_max=1,iops_max=1000
> Within qemu it looks like that:
> QEMU 1.6.50 monitor - type 'help' for more information
> (qemu) info block
> ide0-hd0
> 1. We keep modifying the timer in bdrv_io_limits_intercept() on each
>request even when it has already been set. I think we'll set it to
>the same absolute timestamp, modulo numerical issues. Should we
>avoid doing this?
I could check that the timer is not pending before setting it
but it can successfully
run experimental version of barebox bootloader
(see http://www.barebox.org).
The last sources of barebox for PowerShot A1100 can be
obtained here:
https://github.com/frantony/barebox/tree/next.digic.20130829
The precompiled ROM image usable with qemu can be
obtained here
This is slightly altered version of ARM946E-S CPU code
from EOS QEMU (Magic Lantern project) so nearly all
credits go to @a1ex.
ARM946E-S Technical Reference Manual can be found here:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0201d/index.html
Signed-off-by: Antony Pavlov
---
Signed-off-by: Antony Pavlov
---
hw/arm/digic.c | 8 +++
hw/timer/Makefile.objs | 1 +
hw/timer/digic-timer.c | 140 +
3 files changed, 149 insertions(+)
create mode 100644 hw/timer/digic-timer.c
diff --git a/hw/arm/digic.c b/hw/arm/di
DIGIC is Canon Inc.'s name for a family of SoC
for digital cameras and camcorders.
There is no publicly available specification for
DIGIC chips. All information about DIGIC chip
internals is based on reverse engineering efforts
made by CHDK (http://chdk.wikia.com) and
Magic Lantern (http://www.mag
Signed-off-by: Antony Pavlov
---
hw/arm/digic.c| 3 +
hw/char/Makefile.objs | 1 +
hw/char/digic-uart.c | 207 ++
3 files changed, 211 insertions(+)
create mode 100644 hw/char/digic-uart.c
diff --git a/hw/arm/digic.c b/hw/arm/digic.c
Il 29/08/2013 11:00, Paolo Bonzini ha scritto:
Il 16/08/2013 16:46, Anthony PERARD ha scritto:
In some cases (Xen), it will not be initialized before to be used. This
leads to segv.
Signed-off-by: Anthony PERARD
---
It works with this simple initialization to NULL, but would it be
necessary
Hi all,
This is an attempt to do some triaging of the 18 current buildbot
failures[1].
default_ppc:
http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/729/steps/compile/logs/stdio
LINK ppc-linux-user/qemu-ppc
target-ppc/translate.o:(.text+0x53518): undefined reference to `tcg_
Il 27/08/2013 10:23, Stefan Hajnoczi ha scritto:
> Introduce QEMUTimerList->active_timers_lock to protect the linked list
> of active timers. This allows qemu_timer_mod_ns() to be called from any
> thread.
>
> Note that vm_clock is not thread-safe and its use of
> qemu_clock_has_timers() works fi
On 29/08/2013 10:57, Charlie Shepherd wrote:
default_x86_64_rhel5:
http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel5/builds/684/steps/compile/logs/stdio
File
"/home/buildbot/slave-public/default_x86_64_rhel5/build/scripts/qapi-visit.py",
line 23
full_name = name if no
On Thu, 2013-08-29 at 07:10 +0200, Andreas Färber wrote:
> Am 29.08.2013 04:09, schrieb Chen Fan:
> > After ACPI get a signal to eject a vcpu, then it will notify
> > the vcpu thread of needing to exit, before the vcpu exiting,
> > will release the vcpu related objects.
> >
> > Signed-off-by: Chen
On 29.08.2013, at 11:04, Alexey Kardashevskiy wrote:
> On 08/28/2013 09:42 PM, David Gibson wrote:
>> On Wed, Aug 28, 2013 at 07:32:51PM +1000, Alexey Kardashevskiy wrote:
>>> PAPR+ requires two RTAS calls to be supported by the hypervisor in
>>> order to allow hotplugging VCPUs from the guest. T
On Thu, Aug 29, 2013 at 12:02 PM, Charlie Shepherd
wrote:
> On 29/08/2013 10:57, Charlie Shepherd wrote:
>
>> default_x86_64_rhel5:
>>
>> http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel5/builds/684/steps/compile/logs/stdio
>>>
>>> File
>>> "/home/buildbot/slave-public/default_x
Do not try to update the refcount for zero clusters in
qcow2_update_snapshot_refcount.
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 1244693..7555242
Hi,
On 29/08/13 10:57, Charlie Shepherd wrote:
> xen40:
> xen41:
> xen42:
> xen_unstable:
>
>> > arm-softmmu/qemu-system-arm: error while loading shared libraries:
>> > libxenstore.so.3.0: cannot open shared object file: No such file or
>> > directory
> libxenstore is a QEMU dependency, is it a
If offset_within_address_space falls in a page, then we register a
subpage. So check offset_within_address_space rather than
offset_within_region.
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: "Andreas Färber"
Cc: Peter Maydell
Cc: Blue Swirl
Signed-off-by: Hu Tao
---
exec.c | 2 +-
1 file ch
On Thu, Aug 29, 2013 at 12:19 PM, Anthony PERARD
wrote:
> On 29/08/13 10:57, Charlie Shepherd wrote:
>> xen40:
>> xen41:
>> xen42:
>> xen_unstable:
>>
>>> > arm-softmmu/qemu-system-arm: error while loading shared libraries:
>>> > libxenstore.so.3.0: cannot open shared object file: No such file or
On 29 August 2013 10:33, Antony Pavlov wrote:
> This is slightly altered version of ARM946E-S CPU code
> from EOS QEMU (Magic Lantern project) so nearly all
> credits go to @a1ex.
>
> ARM946E-S Technical Reference Manual can be found here:
> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.
On Thu, Aug 29, 2013 at 11:57 AM, Charlie Shepherd
wrote:
> This is an attempt to do some triaging of the 18 current buildbot
> failures[1].
Thanks for doing this!
> trivial-patches_x86_64_debian_6_0:
> http://buildbot.b1-systems.de/qemu/builders/trivial-patches_x86_64_debian_6_0/builds/717/step
On Thu, Aug 22, 2013 at 09:58:36AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg.h | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tcg/tcg.h b/tcg/tcg.h
> index bfe420a..b71dcf4 100644
> --- a/tcg/tcg.h
> +++ b/tcg/tcg.h
> @@
On Thu, Aug 22, 2013 at 09:58:38AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg.c | 5 ++---
> tcg/tcg.h | 9 -
> 2 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index a0d0e9e..c23b23c 100644
> --- a/tcg/tcg.
On Thu, Aug 22, 2013 at 09:58:40AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/aarch64/tcg-target.c | 2 +-
> tcg/arm/tcg-target.c | 8
> tcg/hppa/tcg-target.c| 6 +++---
> tcg/i386/tcg-target.c| 2 +-
> tcg/ia64/tcg-target.c| 14 +++
On Thu, Aug 22, 2013 at 09:58:39AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg.c | 16 +---
> tcg/tcg.h | 8 +++-
> 2 files changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index c23b23c..04f1727 100644
> -
On Thu, Aug 22, 2013 at 09:58:37AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tcg/tcg.h b/tcg/tcg.h
> index b71dcf4..8353ba1 100644
> --- a/tcg/tcg.h
> +++ b/tcg/tcg.h
> @@ -6
On Thu, 29 Aug 2013 11:44:38 +0100
Peter Maydell wrote:
> On 29 August 2013 10:33, Antony Pavlov wrote:
> > This is slightly altered version of ARM946E-S CPU code
> > from EOS QEMU (Magic Lantern project) so nearly all
> > credits go to @a1ex.
> >
> > ARM946E-S Technical Reference Manual can be
On Thu, 29 Aug 2013, Fabio Fantoni wrote:
> Il 26/08/2013 17:00, Fabio Fantoni ha scritto:
> > Il 16/08/2013 16:46, Anthony PERARD ha scritto:
> > > In some cases (Xen), it will not be initialized before to be used. This
> > > leads to segv.
> > >
> > > Signed-off-by: Anthony PERARD
> >
> > Test
On 29/08/2013 11:14, Stefan Hajnoczi wrote:
On Thu, Aug 29, 2013 at 12:02 PM, Charlie Shepherd
wrote:
On 29/08/2013 10:57, Charlie Shepherd wrote:
default_x86_64_rhel5:
http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel5/builds/684/steps/compile/logs/stdio
File
"/home/buil
The syntax `var = a if b else c` was added in Python 2.5, but QEMU has a
minimum Python version of 2.4, which chokes on this syntax. This patch
converts the new syntax to Python 2.4 compatible syntax.
Signed-off-by: Charlie Shepherd
---
scripts/qapi-visit.py | 12 +---
1 file changed,
On Thu, 29 Aug 2013, Stefano Stabellini wrote:
> On Thu, 29 Aug 2013, Fabio Fantoni wrote:
> > Il 26/08/2013 17:00, Fabio Fantoni ha scritto:
> > > Il 16/08/2013 16:46, Anthony PERARD ha scritto:
> > > > In some cases (Xen), it will not be initialized before to be used. This
> > > > leads to segv.
On Thu, Aug 22, 2013 at 09:58:42AM -0700, Richard Henderson wrote:
> And update all users.
>
> Signed-off-by: Richard Henderson
> ---
> include/exec/gen-icount.h | 4 ++--
> target-alpha/translate.c | 8
> target-arm/translate.c| 2 +-
> target-cris/translate.c |
On Thu, Aug 22, 2013 at 09:58:41AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> tcg/tcg.c | 6 +++---
> tcg/tcg.h | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index c6ab07f..c80aa3c 100644
> --- a/tcg/tcg.c
> ++
On Thu, Aug 29, 2013 at 1:03 PM, Charlie Shepherd
wrote:
> The syntax `var = a if b else c` was added in Python 2.5, but QEMU has a
> minimum Python version of 2.4, which chokes on this syntax. This patch
> converts the new syntax to Python 2.4 compatible syntax.
>
> Signed-off-by: Charlie Shepher
This series adds support to qemu-img, block and qcow2 for amending image
options on existing image files.
Depends on:
- option: Add assigned flag to QEMUOptionParameter
- qcow2-refcount: Snapshot update for zero clusters
v2:
- Generally implemented Kevin's comments, especially:
- Zero clust
Add tests for qemu-img amend on qcow2 image files.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/061 | 152 ++
tests/qemu-iotests/061.out | 318 +
tests/qemu-iotests/group | 1 +
3 files changed, 471 insertions(+)
create
This patch adds the "amend" option to qemu-img which allows changing
image options on existing image files. It also adds the generic bdrv
implementation which is basically just a wrapper for the image format
specific function.
Signed-off-by: Max Reitz
---
block.c | 8 +
in
Implement bdrv_amend_options for compat, size, backing_file, backing_fmt
and lazy_refcounts.
Downgrading images from compat=1.1 to compat=0.10 is achieved through
handling all incompatible flags accordingly, clearing all compatible and
autoclear flags and expanding all zero clusters.
Signed-off-b
On 29/08/2013 11:23, Stefan Hajnoczi wrote:
On Thu, Aug 29, 2013 at 12:19 PM, Anthony PERARD
wrote:
On 29/08/13 10:57, Charlie Shepherd wrote:
xen40:
xen41:
xen42:
xen_unstable:
arm-softmmu/qemu-system-arm: error while loading shared libraries:
libxenstore.so.3.0: cannot open shared object
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
> The qcow2_check_refcounts function has been extended to be able to fix
> OFLAG_COPIED errors and multiple references on refcount blocks.
>
> If no corruptions remain after an image repair (and no errors have been
> encountered), clear the corrupt
Description of problem:
when guest do reboot or reset after hotunplug virtio NIC, Segmentation fault
occurs.It can reproduce 100%.
Similar to https://bugzilla.redhat.com/show_bug.cgi?id=988256
Version-Release number of selected component (if applicable):
Host OS:sles11sp2 kernel version:3.0.58
qe
Am 29.08.2013 13:36, schrieb Kevin Wolf:
Am 28.08.2013 um 16:55 hat Max Reitz geschrieben:
The qcow2_check_refcounts function has been extended to be able to fix
OFLAG_COPIED errors and multiple references on refcount blocks.
If no corruptions remain after an image repair (and no errors have be
On Fri, Aug 09, 2013 at 07:43:54PM +0200, Charlie Shepherd wrote:
> Signed-off-by: Charlie Shepherd
> ---
> block.c | 8
> block/blkdebug.c | 4 ++--
> block/blkverify.c | 4 ++--
> block/bochs.c | 4 ++--
> block/cloop.c |
Am 29.08.2013 11:33, schrieb Antony Pavlov:
> DIGIC is Canon Inc.'s name for a family of SoC
> for digital cameras and camcorders.
>
> There is no publicly available specification for
> DIGIC chips. All information about DIGIC chip
> internals is based on reverse engineering efforts
> made by CHDK
On 29/08/2013 13:11, Stefan Hajnoczi wrote:
On Fri, Aug 09, 2013 at 07:43:54PM +0200, Charlie Shepherd wrote:
Signed-off-by: Charlie Shepherd
---
block.c | 8
block/blkdebug.c | 4 ++--
block/blkverify.c | 4 ++--
block/bochs.c |
On 08/28/2013 08:09 PM, Chen Fan wrote:
> Signed-off-by: Chen Fan
> ---
> hw/i386/pc.c | 5 +
> hw/i386/pc_piix.c| 1 +
> include/hw/boards.h | 2 ++
> include/hw/i386/pc.h | 1 +
> qapi-schema.json | 12
> qmp-commands.hx | 23 +++
>
On Fri, Aug 09, 2013 at 07:43:55PM +0200, Charlie Shepherd wrote:
> +static int qcow2_open(BlockDriverState *bs, QDict *options, int flags)
> +{
> +Coroutine *co;
> +struct QOpenCo qo = {
> +.bs = bs,
> +.options = options,
> +.flags = flags,
> +.ret = NOT_DO
On 08/29/2013 04:16 AM, Max Reitz wrote:
> Do not try to update the refcount for zero clusters in
> qcow2_update_snapshot_refcount.
Why? What does this fix?
(Hint - your commit message could use more details, and you should add a
testsuite addition that exposes the case that you are fixing)
--
Signed-off-by: Paolo Bonzini
---
qemu-timer.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/qemu-timer.c b/qemu-timer.c
index 04869f4..d650247 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -319,13 +319,10 @@ void timer_free(QEMUTimer *ts)
g_free(ts
These four patches go on top of Stefan's patch introducing a lock for
a timerlist's active timers. Patches 1 and 2 fix bugs and probably
should simply be squashed into his patch.
Patch 3 is an optimization and code simplification. It could even go
in _before_ introducing the lock, at Stefan's di
Save the callback and opaque before releasing the mutex, because
the timer could be freed while we do not take the mutex. Related
to this, ensure the timer is not active before freeing it.
Signed-off-by: Paolo Bonzini
---
qemu-timer.c | 10 --
1 file changed, 8 insertions(+), 2 deletion
We can deduce the result from expire_time, by making it always -1 if
the timer is not in the active_timers list. We need to check against
negative times passed to timer_mod_ns; clamping them to zero is not
a problem because the only clock that has a zero value at VM startup
is QEMU_CLOCK_VIRTUAL,
Am 29.08.2013 um 12:16 hat Max Reitz geschrieben:
> Do not try to update the refcount for zero clusters in
> qcow2_update_snapshot_refcount.
>
> Signed-off-by: Max Reitz
> ---
> block/qcow2-refcount.c | 16 +---
> 1 file changed, 13 insertions(+), 3 deletions(-)
Please don't forget
This patch uses RCU to access the active timers list with no lock. The
access can race with concurrent timer_mod calls, but most of our read-side
critical sections are racy anyway and rely on aio_notify being called
whenever the head of the list changes. RCU is used simply to ensure that
the time
On Fri, Aug 09, 2013 at 07:43:55PM +0200, Charlie Shepherd wrote:
> The previous patch convert all .bdrv_open functions to run from a coroutine
> context. However
> qcow2's open method is also called from qcow2_invalidate_cache.
> bdrv_invalidate_cache is mainly
> called by migration.c, which doe
Am 29.08.2013 14:30, schrieb Eric Blake:
On 08/29/2013 04:16 AM, Max Reitz wrote:
Do not try to update the refcount for zero clusters in
qcow2_update_snapshot_refcount.
Why? What does this fix?
(Hint - your commit message could use more details, and you should add a
testsuite addition that exp
On 08/29/2013 05:20 AM, Max Reitz wrote:
> This patch adds the "amend" option to qemu-img which allows changing
> image options on existing image files. It also adds the generic bdrv
> implementation which is basically just a wrapper for the image format
> specific function.
>
> Signed-off-by: Max
Am 29.08.2013 14:33, schrieb Kevin Wolf:
Am 29.08.2013 um 12:16 hat Max Reitz geschrieben:
Do not try to update the refcount for zero clusters in
qcow2_update_snapshot_refcount.
Signed-off-by: Max Reitz
---
block/qcow2-refcount.c | 16 +---
1 file changed, 13 insertions(+), 3 de
Am 29.08.2013 14:38, schrieb Eric Blake:
On 08/29/2013 05:20 AM, Max Reitz wrote:
This patch adds the "amend" option to qemu-img which allows changing
image options on existing image files. It also adds the generic bdrv
implementation which is basically just a wrapper for the image format
specif
On 29/08/2013 13:33, Stefan Hajnoczi wrote:
On Fri, Aug 09, 2013 at 07:43:55PM +0200, Charlie Shepherd wrote:
The previous patch convert all .bdrv_open functions to run from a coroutine
context. However
qcow2's open method is also called from qcow2_invalidate_cache.
bdrv_invalidate_cache is ma
On 08/29/2013 05:20 AM, Max Reitz wrote:
> Implement bdrv_amend_options for compat, size, backing_file, backing_fmt
> and lazy_refcounts.
>
> Downgrading images from compat=1.1 to compat=0.10 is achieved through
> handling all incompatible flags accordingly, clearing all compatible and
> autoclear
Am 29.08.2013 um 11:15 hat Max Reitz geschrieben:
> Adds an "assigned" flag to QEMUOptionParameter which is cleared at the
> beginning of parse_option_parameters and set on (successful)
> set_option_parameter and set_option_parameter_int.
>
> Signed-off-by: Max Reitz
Thanks, applied to the block
Am 29.08.2013 14:45, schrieb Eric Blake:
On 08/29/2013 05:20 AM, Max Reitz wrote:
Implement bdrv_amend_options for compat, size, backing_file, backing_fmt
and lazy_refcounts.
Downgrading images from compat=1.1 to compat=0.10 is achieved through
handling all incompatible flags accordingly, clear
1 - 100 of 303 matches
Mail list logo
