[Qemu-devel] [PATCH 2/2] milkymist-uart: use Device::realize instead of SysBusDevice::init

2013-08-30 Thread Antony Pavlov
http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg04748.html";> Use of SysBusDevice::init is deprecated. Please use Device::realize instead of SysBusDevice::init. Check dma/pl330.c for an example of the pattern. Signed-off-by: Antony Pavlov CC: Peter Crosthwaite CC: Michael Walle

[Qemu-devel] [PATCH 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

2013-08-30 Thread Antony Pavlov
Here is a quote from the qemu-devel maillist: http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg04748.html";> qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and you don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Signed-off-by:

[Qemu-devel] [PATCH 0/2] milkymist-uart fixes

2013-08-30 Thread Antony Pavlov
[PATCH 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of [PATCH 2/2] milkymist-uart: use Device::realize instead of This patch series based on DIGIC support adding comments: http://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg04748.html

Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.6] isapc: disable kvmvapic

2013-08-30 Thread Cole Robinson
On 08/12/2013 06:02 PM, Paolo Bonzini wrote: > vapic requires the VAPIC ROM to be mapped into RAM. This is not > possible without PAM hardware. This fixes a segmentation fault > running with -M isapc. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Paolo Bonzini > --- > > diff --git a/hw/i386/

Re: [Qemu-devel] [PATCH v2 6/7] tcg: Introduce zero and sign-extended versions of load helpers

2013-08-30 Thread Richard Henderson
On 08/30/2013 02:23 PM, Aurelien Jarno wrote: > As you said earlier the solution would have been to replace > helper_ret_ldl_mmu() by helper_ret_ldsl_mmu(), but it should have been > done in the same patch to not break things. I just wanted to make > sure we don't have the problem in an another tar

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-30 Thread Alexander Graf
On 31.08.2013, at 00:19, Benjamin Herrenschmidt wrote: > On Fri, 2013-08-30 at 16:34 +0200, Alexander Graf wrote: > >>> So - kvmppc_define_rtas_in_kernel() or kvmppc_define_rtas_kernel_token()? >> >> The former probably. > > I told him the latter :-) Honestly, your name is gross :-) Mine > des

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-30 Thread Benjamin Herrenschmidt
On Fri, 2013-08-30 at 16:34 +0200, Alexander Graf wrote: > > So - kvmppc_define_rtas_in_kernel() or kvmppc_define_rtas_kernel_token()? > > The former probably. I told him the latter :-) Honestly, your name is gross :-) Mine describes exactly what the calls does. > > I would actually though that

Re: [Qemu-devel] [PATCHv2] qmp: fix integer usage in examples

2013-08-30 Thread Benoît Canet
Le Friday 30 Aug 2013 à 14:44:11 (-0600), Eric Blake a écrit : > Per the qapi schema, block_set_io_throttle takes most arguments > as ints, not strings. > > * qmp-commands.hx (block_set_io_throttle): Use correct type. Fix > whitespace and a copy-paste bug in the process. > > Signed-off-by: Eric

[Qemu-devel] [PATCHv2] qmp: fix integer usage in examples

2013-08-30 Thread Eric Blake
Per the qapi schema, block_set_io_throttle takes most arguments as ints, not strings. * qmp-commands.hx (block_set_io_throttle): Use correct type. Fix whitespace and a copy-paste bug in the process. Signed-off-by: Eric Blake --- v2: also touch up the doc comments qmp-commands.hx | 26 +++

Re: [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-08-30 Thread Eric Blake
On 08/30/2013 02:37 PM, Benoît Canet wrote: >>> @@ -1404,10 +1404,16 @@ Arguments: >>> - "device": device name (json-string) >>> - "bps": total throughput limit in bytes per second(json-int) >>> - "bps_rd": read throughput limit in bytes per second(json-int) >>> -- "bps_wr": read throughput l

Re: [Qemu-devel] [PATCH v2 6/7] tcg: Introduce zero and sign-extended versions of load helpers

2013-08-30 Thread Richard Henderson
On 08/30/2013 12:12 PM, Aurelien Jarno wrote: > On Fri, Aug 30, 2013 at 10:20:23AM -0700, Richard Henderson wrote: >> On 08/30/2013 09:55 AM, Aurelien Jarno wrote: >>> While it works for x86 and some other architectures, it makes the >>> assumption that only part of the register can be used later b

Re: [Qemu-devel] [PATCH v2 7/7] tcg-i386: Make use of zero-extended memory helper routines

2013-08-30 Thread Aurelien Jarno
On Thu, Aug 29, 2013 at 03:06:01PM -0700, Richard Henderson wrote: > For 8 and 16-bit unsigned loads, rely on the zero-extension > from the helper and use a smaller 32-bit move insn. > > Signed-off-by: Richard Henderson > --- > tcg/i386/tcg-target.c | 15 ++- > 1 file changed, 6 inse

Re: [Qemu-devel] [PATCH v2 6/7] tcg: Introduce zero and sign-extended versions of load helpers

2013-08-30 Thread Aurelien Jarno
On Fri, Aug 30, 2013 at 01:53:37PM -0700, Richard Henderson wrote: > On 08/30/2013 12:12 PM, Aurelien Jarno wrote: > > On Fri, Aug 30, 2013 at 10:20:23AM -0700, Richard Henderson wrote: > >> On 08/30/2013 09:55 AM, Aurelien Jarno wrote: > >>> While it works for x86 and some other architectures, it

Re: [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-08-30 Thread Benoît Canet
> It's odd that you are fixing one pre-existing case of missing space, but > not all of them. Should we split the cleanups into a separate patch? I > already started some cleanups[1], but could respin my patch to cover > more, if desired. If you make a cleanup patch for this I'll rebase cleanly

[Qemu-devel] About coroutine inside qemu

2013-08-30 Thread Yaodong Yang
When a new work thread, which is not inside coroutine,  enter a coroutine(named as A), what happened to the work thread? Is it true that the work thread also become a coroutine, or it just stop? Later if the coroutine A call yield. what happened to the work thread?

Re: [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-08-30 Thread Benoît Canet
> > @@ -1404,10 +1404,16 @@ Arguments: > > - "device": device name (json-string) > > - "bps": total throughput limit in bytes per second(json-int) > > - "bps_rd": read throughput limit in bytes per second(json-int) > > -- "bps_wr": read throughput limit in bytes per second(json-int) > > +- "b

[Qemu-devel] [PULL 10/17] virtio-pci: Pass size to virtio_pci_bus_new()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_inplace(). Reviewed-by: Wenchao Xia Signed-off-by: Andreas Färber --- hw/virtio/virtio-pci.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 8df43d6..606b4d4 100644 --- a/hw/virtio/virt

[Qemu-devel] [PULL 03/17] qom: Fix object_initialize_with_type() argument name in documentation

2013-08-30 Thread Andreas Färber
@obj -> @data. Reviewed-by: Wenchao Xia Signed-off-by: Andreas Färber --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h index 48109de..c463ced 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -

Re: [Qemu-devel] [PATCH V8 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-08-30 Thread Eric Blake
On 08/30/2013 08:36 AM, Benoît Canet wrote: > The max parameter of the leaky bucket throttling algorithm can be used to > allow the guest to do bursts. > The max value is a pool of I/O that the guest can use without being throttled > at all. Throttling is triggered once this pool is empty. > > Sig

[Qemu-devel] [PULL 11/17] s390-virtio-bus: Pass size to virtio_s390_bus_new()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_inplace(). Reviewed-by: Wenchao Xia Signed-off-by: Andreas Färber --- hw/s390x/s390-virtio-bus.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c index e46b8c8..579adbc 100644 --- a/hw

[Qemu-devel] [PULL 08/17] scsi: Pass size to scsi_bus_new()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_inplace(). Use DEVICE() casts instead of direct parent field access. Reviewed-by: Wenchao Xia Acked-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/scsi/esp-pci.c | 2 +- hw/scsi/esp.c | 2 +- hw/scsi/lsi53c895a.c | 2 +- hw/scsi/megasas.c

Re: [Qemu-devel] [PATCH v2] i386: Use #defines instead of magic numbers for CPUID cache information

2013-08-30 Thread Eduardo Habkost
On Fri, Aug 30, 2013 at 04:51:20PM +0200, Andreas Färber wrote: > Am 27.08.2013 17:24, schrieb Eduardo Habkost: > > This is an attempt to make the CPUID cache topology code clearer, by > > replacing the magic numbers in the code with #defines, and moving all > > the cache information to the same pl

[Qemu-devel] [PULL 15/17] qom: Pass available size to object_initialize()

2013-08-30 Thread Andreas Färber
To be passed on to object_initialize_with_type(). Acked-by: Cornelia Huck (virtio-ccw) Signed-off-by: Andreas Färber --- hw/core/qdev.c | 2 +- hw/dma/xilinx_axidma.c | 6 -- hw/intc/xics.c | 2 +- hw/misc/macio/macio.c | 13 +++-- hw/net/xilinx_a

[Qemu-devel] [PULL 12/17] virtio-ccw: Pass size to virtio_ccw_bus_new()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_inplace(). Reviewed-by: Wenchao Xia Acked-by: Cornelia Huck Signed-off-by: Andreas Färber --- hw/s390x/virtio-ccw.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index e3b207f..36cbf42 10064

Re: [Qemu-devel] [PATCH 00/16] qom: Assert sufficient object instance size

2013-08-30 Thread Andreas Färber
Am 24.08.2013 02:00, schrieb Andreas Färber: > Andreas Färber (16): > qom: Fix object_initialize_with_type() argument name in documentation > intel-hda: Pass size to hda_codec_bus_init() > ipack: Pass size to ipack_bus_new_inplace() > ide: Pass size to ide_bus_new() > pci: Pass size to pc

[Qemu-devel] [PATCH] qmp: fix integer usage in examples

2013-08-30 Thread Eric Blake
* qmp-commands.hx (block_set_io_throttle): Use correct type. Signed-off-by: Eric Blake --- Noticed while reviewing Benoît's series of "Continuous Leaky Bucket Throttling" - depending on whose patch goes in first, the other will have to rebase... qmp-commands.hx | 12 ++-- 1 file change

[Qemu-devel] [PULL 17/17] isa: Fix documentation of isa_register_portio_list()

2013-08-30 Thread Andreas Färber
From: Hervé Poussineau Commit b40acf9 (ioport: Switch dispatching to memory core layer, 2013-06-24) removed all instances of old_portio. Signed-off-by: Hervé Poussineau Acked-by: Paolo Bonzini Signed-off-by: Andreas Färber --- include/hw/isa/isa.h | 2 +- 1 file changed, 1 insertion(+), 1 de

[Qemu-devel] [PULL 14/17] qdev: Pass size to qbus_create_inplace()

2013-08-30 Thread Andreas Färber
To be passed to object_initialize(). Since commit 39355c3826f5d9a2eb1ce3dc9b4cdd68893769d6 the argument is void*, so drop some superfluous (BusState *) casts or direct parent field usages. Signed-off-by: Andreas Färber --- hw/audio/intel-hda.c | 2 +- hw/char/ipack.c | 2

[Qemu-devel] [PULL 09/17] usb: Pass size to usb_bus_new()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_inplace(). Use DEVICE() cast to avoid a direct parent field access. Reviewed-by: Wenchao Xia Signed-off-by: Andreas Färber --- hw/usb/bus.c | 3 ++- hw/usb/hcd-ehci.c | 2 +- hw/usb/hcd-musb.c | 2 +- hw/usb/hcd-ohci.c | 2 +- hw/usb/hcd-uhci.c | 2 +- hw/usb/h

[Qemu-devel] [PULL 16/17] qom: Assert instance size in object_initialize_with_type()

2013-08-30 Thread Andreas Färber
This catches objects initializing beyond allocated memory, e.g., when subtypes get extended with instance state of their own. Suggested-by: Peter Maydell Signed-off-by: Andreas Färber --- include/qom/object.h | 3 ++- qom/object.c | 7 --- 2 files changed, 6 insertions(+), 4 deletio

Re: [Qemu-devel] [PATCH] qmp: fix integer usage in examples

2013-08-30 Thread Benoît Canet
Le Friday 30 Aug 2013 à 13:35:53 (-0600), Eric Blake a écrit : > * qmp-commands.hx (block_set_io_throttle): Use correct type. > > Signed-off-by: Eric Blake > --- > > Noticed while reviewing Benoît's series of "Continuous Leaky Bucket > Throttling" - depending on whose patch goes in first, the ot

[Qemu-devel] [PATCH V9 5/5] block: Add iops_size to do the iops accounting for a given io size.

2013-08-30 Thread Benoît Canet
This feature can be used in case where users are avoiding the iops limit by doing jumbo I/Os hammering the storage backend. Signed-off-by: Benoit Canet Reviewed-by: Eric Blake --- block/qapi.c |3 +++ blockdev.c | 21 ++--- hmp.c|8 ++-- qapi-

[Qemu-devel] [PULL 05/17] ipack: Pass size to ipack_bus_new_inplace()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_inplace(). Simplify DEVICE() cast to avoid parent field access. Reviewed-by: Wenchao Xia Signed-off-by: Andreas Färber --- hw/char/ipack.c | 3 ++- hw/char/ipack.h | 3 ++- hw/char/tpci200.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/

[Qemu-devel] [PATCH V9 3/5] block: Enable the new throttling code in the block layer.

2013-08-30 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 338 + block/qapi.c | 21 ++- blockdev.c| 100 -- include/block/block.h |1 - include/block/block_int.h | 32 + 5 files changed, 164 i

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-30 Thread Laszlo Ersek
Hello Benjamin, On 08/27/13 02:43, Benjamin Herrenschmidt wrote: > Am I dreaming ? Those patches were written about a year ago and you guys > are still nitpicking on names ? They should have been merged a LONG time > ago ... > > I'm seriously wondering how people get anything done with qemu KVM

[Qemu-devel] [PATCH V9 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-08-30 Thread Benoît Canet
The max parameter of the leaky bucket throttling algorithm can be used to allow the guest to do bursts. The max value is a pool of I/O that the guest can use without being throttled at all. Throttling is triggered once this pool is empty. Signed-off-by: Benoit Canet Reviewed-by: Eric Blake ---

[Qemu-devel] [PATCH V9 2/5] throttle: Add units tests

2013-08-30 Thread Benoît Canet
Signed-off-by: Benoit Canet --- tests/Makefile|2 + tests/test-throttle.c | 481 + 2 files changed, 483 insertions(+) create mode 100644 tests/test-throttle.c diff --git a/tests/Makefile b/tests/Makefile index b0200fd..6d2f3ad 100644

[Qemu-devel] [PATCH V9 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-08-30 Thread Benoît Canet
Implement the continuous leaky bucket algorithm devised on IRC as a separate module. Signed-off-by: Benoit Canet --- include/qemu/throttle.h | 103 util/Makefile.objs |1 + util/throttle.c | 396 +++ 3 files changed, 500

[Qemu-devel] [PULL 13/17] virtio-mmio: Pass size to virtio_mmio_bus_new()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_initialize(). Reviewed-by: Wenchao Xia Signed-off-by: Andreas Färber --- hw/virtio/virtio-mmio.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index 4bd2953..692979e 100644 --- a/hw/virti

[Qemu-devel] [PATCH V9 0/5] Continuous Leaky Bucket Throttling

2013-08-30 Thread Benoît Canet
This patchset implement continous leaky bucket throttling. It use two requests queue to enable to do silly unbalanced throttling like block_set_io_throttle 0 0 0 0 6000 1 It use two timer to get the timer callbacks and the throttle.c code simple in this version: Apply Reviewed-By by Eric R

[Qemu-devel] [PULL 04/17] intel-hda: Pass size to hda_codec_bus_init()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_inplace(). Reviewed-by: Wenchao Xia Signed-off-by: Andreas Färber --- hw/audio/intel-hda.c | 4 ++-- hw/audio/intel-hda.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 78f9d28..6849c73 100644

[Qemu-devel] [PULL 06/17] ide: Pass size to ide_bus_new()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_inplace(). Reviewed-by: Wenchao Xia Signed-off-by: Andreas Färber --- hw/ide/ahci.c | 2 +- hw/ide/cmd646.c | 2 +- hw/ide/internal.h | 3 ++- hw/ide/isa.c | 2 +- hw/ide/macio.c| 2 +- hw/ide/mmio.c | 2 +- hw/ide/piix.c | 2 +- hw/ide/qdev.c

[Qemu-devel] [PULL 07/17] pci: Pass size to pci_bus_new_inplace()

2013-08-30 Thread Andreas Färber
To be passed to qbus_create_inplace(). Reviewed-by: Wenchao Xia Signed-off-by: Andreas Färber --- hw/pci-host/prep.c | 2 +- hw/pci-host/versatile.c | 2 +- hw/pci/pci.c| 2 +- include/hw/pci/pci.h| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/pci

[Qemu-devel] [PULL 00/17] QOM devices patch queue 2013-08-30

2013-08-30 Thread Andreas Färber
Hello Anthony, This is my current QOM devices patch queue. Please pull. This will be the base for all further QOM realize conversions and DIGIC, therefore pushing this out early with PMM's consent and some review. Thanks, Andreas Cc: Anthony Liguori Cc: Peter Maydell Cc: Antony Pavlov Cc: P

[Qemu-devel] [PULL 01/17] object: Fix typo in qom/object.h

2013-08-30 Thread Andreas Färber
From: Peter Chubb There's been a cut-and-paste error, it looks like, in the documentation in qom/object.h. Signed-off-by: Peter Chubb Signed-off-by: Andreas Färber --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/o

[Qemu-devel] [PULL 02/17] virtio: Remove unnecessary OBJECT() casts

2013-08-30 Thread Andreas Färber
From: Peter Maydell There's no need to cast the first argument of object_initialize() to Object. Remove these unnecessary casts. Signed-off-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/s390x/s390-virtio-bus.c | 12 ++-- hw/s390x/virtio-ccw.c | 14 +++--- hw/virt

[Qemu-devel] [PATCH v2 4/8] tcg-arm: Use QEMU_BUILD_BUG_ON to verify constraints on tlb

2013-08-30 Thread Richard Henderson
One of the two constraints we already checked via #if, but the tlb offset distance was only checked at runtime. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

2013-08-30 Thread Paolo Bonzini
Il 30/08/2013 19:39, Jordan Justen ha scritto: >> However, if you guys can figure out a patch for >> > UefiCpuPkg/ResetVector/Vtf0/Ia32/Flat32ToFlat64.asm so that it builds >> > the page tables in RAM (and removing the page table Python code), that >> > would also work. > That path is not quite how

[Qemu-devel] [PATCH v2 3/8] tcg-arm: Use strd for tcg_out_arg_reg64

2013-08-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index ba5fc43..17e256a 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -1148,9 +1148,16 @@ stati

[Qemu-devel] [PATCH v2 8/8] tcg-arm: Move the tlb addend load earlier

2013-08-30 Thread Richard Henderson
There are free scheduling slots between the sequence of comparison instructions. This requires changing the register in use to avoid conflict with those compares. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --

[Qemu-devel] [PATCH v2 5/8] tcg-arm: Move load of tlb addend into tcg_out_tlb_read

2013-08-30 Thread Richard Henderson
This allows us to make more intelligent decisions about the relative offsets of the tlb comparator and the addend, avoiding any need of writeback addressing. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 60 1 file changed, 23 in

[Qemu-devel] [PATCHv6] add qemu-img convert -n option (skip target volume creation)

2013-08-30 Thread Alex Bligh
From: Alexandre Derumier Add a -n option to skip volume creation on qemu-img convert. This is useful for targets such as rbd / ceph, where the target volume may already exist; we cannot always rely on qemu-img convert to create the image, as dependent on the output format, there may be parameters

[Qemu-devel] [PATCH v2 1/8] tcg-arm: Use ldrd/strd for appropriate qemu_ld/st64

2013-08-30 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 48 +++- 1 file changed, 43 insertions(+), 5 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 6d084b3..9176930 100644 --- a/tcg/arm/tcg-

Re: [Qemu-devel] [RFC 2/5] hw/arm: add very initial support for Canon DIGIC SoC

2013-08-30 Thread Andreas Färber
Am 30.08.2013 07:07, schrieb Peter Crosthwaite: > Hi, > > > On Fri, Aug 30, 2013 at 6:16 AM, Peter Maydell > wrote: >> >> On 29 August 2013 20:36, Antony Pavlov wrote: >>> On Thu, 29 Aug 2013 14:15:40 +0200 >>> Andreas Färber wrote: DigicState should be a QOM type derived from TYPE_DEVIC

[Qemu-devel] [PATCH v2 6/8] tcg-arm: Return register containing tlb addend

2013-08-30 Thread Richard Henderson
Preparatory to rescheduling the tlb load, and changing said register. Continues to use R1 for now. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 59 ++-- 1 file changed, 30 insertions(+), 29 deletions(-) diff --git a/tcg/arm/tcg-targ

Re: [Qemu-devel] [PATCH] target-i386: fix disassembly with PAE=1, PG=0

2013-08-30 Thread Richard Henderson
On 08/30/2013 02:58 AM, Paolo Bonzini wrote: > CR4.PAE=1 will not enable paging if CR0.PG=0, but the "if" chain > in x86_cpu_get_phys_page_debug says otherwise. Check CR0.PG > before everything else. > > Fixes "-d in_asm" for a code section at the beginning of OVMF. > > Cc: Richard Henderson >

Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-30 Thread Eric Blake
On 08/30/2013 12:13 PM, Alex Bligh wrote: >>> +# test of qemu-img convert -n - convert without creation >>> +# >>> +# Copyright (C) 2009 Red Hat, Inc. > >> Where have you been the last 4 years? I could understand a range of >> years, if this test borrows significantly from another file that old,

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

2013-08-30 Thread Jordan Justen
On Fri, Aug 30, 2013 at 11:44 AM, Paolo Bonzini wrote: > Il 30/08/2013 19:39, Jordan Justen ha scritto: >>> However, if you guys can figure out a patch for >>> > UefiCpuPkg/ResetVector/Vtf0/Ia32/Flat32ToFlat64.asm so that it builds >>> > the page tables in RAM (and removing the page table Python c

Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-30 Thread Alex Bligh
--On 30 August 2013 12:55:29 -0600 Eric Blake wrote: Yes, that looks like the best approach. Thanks - done in v6 and added your reviewed-by line -- Alex Bligh

[Qemu-devel] [PATCH v2 2/8] tcg-arm: Rearrange slow-path qemu_ld/st

2013-08-30 Thread Richard Henderson
Use the new helper_ret_*_mmu routines. Use a conditional call to arrange for a tail-call from the store path, and to load the return address for the helper for the load path. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 14 tcg/arm/tcg-target.c| 188 +

Re: [Qemu-devel] [PATCH v2 6/7] tcg: Introduce zero and sign-extended versions of load helpers

2013-08-30 Thread Aurelien Jarno
On Fri, Aug 30, 2013 at 10:20:23AM -0700, Richard Henderson wrote: > On 08/30/2013 09:55 AM, Aurelien Jarno wrote: > > While it works for x86 and some other architectures, it makes the > > assumption that only part of the register can be used later by the TCG > > code. It won't be the case if we la

Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-30 Thread Alex Bligh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Eric, On 30 Aug 2013, at 18:31, Eric Blake wrote: >> >> for(;;) { >> -c = getopt(argc, argv, "f:O:B:s:hce6o:pS:t:q"); >> +c = getopt(argc, argv, "f:O:B:s:hce6o:pS:t:qn"); > > The order here... > >> if (c == -1) { >>

[Qemu-devel] [PATCH v2 7/8] tcg-arm: Remove restriction on qemu_ld output register

2013-08-30 Thread Richard Henderson
The main intent of the patch is to allow the tlb addend register to be changed, without tying that change to the constraint. But the most common side-effect seems to be to enable usage of ldrd with the r0,r1 pair. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 49 ++

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

2013-08-30 Thread Jordan Justen
On Fri, Aug 30, 2013 at 4:58 AM, Paolo Bonzini wrote: > However, if you guys can figure out a patch for > UefiCpuPkg/ResetVector/Vtf0/Ia32/Flat32ToFlat64.asm so that it builds > the page tables in RAM (and removing the page table Python code), that > would also work. That path is not quite how it

Re: [Qemu-devel] [PATCH] target-i386: fix disassembly with PAE=1, PG=0

2013-08-30 Thread Max Filippov
On Fri, Aug 30, 2013 at 1:58 PM, Paolo Bonzini wrote: > CR4.PAE=1 will not enable paging if CR0.PG=0, but the "if" chain > in x86_cpu_get_phys_page_debug says otherwise. Check CR0.PG > before everything else. > > Fixes "-d in_asm" for a code section at the beginning of OVMF. > > Cc: Richard Hende

[Qemu-devel] [PATCH v2 0/8] tcg-arm ldst improvements

2013-08-30 Thread Richard Henderson
Changes since v1, * Rebase on the v2 of "Further ldst..." * Split patch 5 into 3 pieces for easier review. * Remove the 'L' constraint, handling all possible ld64 output registers. On v6 this tends to make more use of ldrd as r1 is no longer disallowed. r~ Richard Henderson (8): tcg

Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list

2013-08-30 Thread Andreas Färber
Am 30.08.2013 18:02, schrieb Paolo Bonzini: > Il 30/08/2013 17:56, Andreas Färber ha scritto: >> Am 30.08.2013 17:45, schrieb Paolo Bonzini: >>> Il 13/08/2013 12:38, Hervé Poussineau ha scritto: Signed-off-by: Hervé Poussineau --- include/hw/isa/isa.h |2 +- 1 file ch

Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-30 Thread Eric Blake
On 08/26/2013 03:12 AM, Alex Bligh wrote: > From: Alexandre Derumier > > Add a -n option to skip volume creation on qemu-img convert. > This is useful for targets such as rbd / ceph, where the > target volume may already exist; we cannot always rely on > qemu-img convert to create the image, as d

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

2013-08-30 Thread Jordan Justen
On Fri, Aug 30, 2013 at 5:42 AM, Paolo Bonzini wrote: > Il 30/08/2013 14:10, Gleb Natapov ha scritto: >> On Fri, Aug 30, 2013 at 01:58:59PM +0200, Paolo Bonzini wrote: >>> Il 30/08/2013 11:37, Laszlo Ersek ha scritto: Disclaimer: I don't know what I'm talking about. >>> >>> No problem. :) >>>

Re: [Qemu-devel] [PATCH v2] i386: Use #defines instead of magic numbers for CPUID cache information

2013-08-30 Thread Andreas Färber
Am 27.08.2013 17:24, schrieb Eduardo Habkost: > This is an attempt to make the CPUID cache topology code clearer, by > replacing the magic numbers in the code with #defines, and moving all > the cache information to the same place in the file. > > I took care of comparing the assembly output of co

Re: [Qemu-devel] [PATCH 12/16] qdev: Pass size to qbus_create_inplace()

2013-08-30 Thread Andreas Färber
Am 26.08.2013 09:44, schrieb Wenchao Xia: > 于 2013-8-24 8:00, Andreas Färber 写道: >> To be passed to object_initialize(). >> >> Since commit 39355c3826f5d9a2eb1ce3dc9b4cdd68893769d6 the argument is >> void*, so drop some superfluous (BusState *) casts or direct parent >> field usages. >> >> Signed-o

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-30 Thread Alexander Graf
On 29.08.2013, at 10:18, Alexey Kardashevskiy wrote: > On 08/27/2013 06:36 PM, Alexander Graf wrote: >> >> On 27.08.2013, at 06:10, Benjamin Herrenschmidt wrote: >> >>> On Tue, 2013-08-27 at 03:48 +0200, Andreas Färber wrote: Also, QEMU is definitely not the only project that has higher >>

Re: [Qemu-devel] [RFC PATCH] Convert ram_list to RCU DQ V2

2013-08-30 Thread Paolo Bonzini
Il 30/08/2013 18:06, Mike Day ha scritto: > Changes from V1: > > * Omitted locks or rcu critical sections within Some functions that > read or write the ram_list but are called in a protected context > (the caller holds the iothread lock, the ram_list mutex, or an rcu > critical section). >

[Qemu-devel] [PULL 24/26] qcow2-refcount: Repair shared refcount blocks

2013-08-30 Thread Kevin Wolf
From: Max Reitz If the refcount of a refcount block is greater than one, we can at least try to repair that problem by duplicating the affected block. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 148 - include

Re: [Qemu-devel] [PATCH v2 5/7] exec: Split softmmu_defs.h

2013-08-30 Thread Aurelien Jarno
On Thu, Aug 29, 2013 at 03:05:59PM -0700, Richard Henderson wrote: > The _cmmu helpers can be moved to exec-all.h. The helpers that are > used from TCG will shortly need access to tcg_target_long so move > their declarations into tcg.h. > > This requires minor include adjustments to all TCG backe

Re: [Qemu-devel] [PATCH] powerpc iommu: rework traces

2013-08-30 Thread Alexey Kardashevskiy
On 08/31/2013 12:39 AM, Alexander Graf wrote: > > On 29.08.2013, at 10:05, Alexey Kardashevskiy wrote: > >> This converts old style fprintf to traces. >> >> Signed-off-by: Alexey Kardashevskiy > > Thanks, applied with modified subject line. There are a lot more powerpc > machines than sPAPR.

[Qemu-devel] [PULL 26/26] qemu-iotests: Overlapping cluster allocations

2013-08-30 Thread Kevin Wolf
From: Max Reitz A new test on corrupted images with overlapping cluster allocations. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/060 | 111 + tests/qemu-iotests/060.out | 44 ++ tests/qemu-iotests/g

[Qemu-devel] PING^2 Re: [PATCH] KVM: always use MADV_DONTFORK

2013-08-30 Thread Paolo Bonzini
Il 06/08/2013 18:47, Paolo Bonzini ha scritto: > On 07/25/2013 12:11 PM, Andrea Arcangeli wrote: >> MADV_DONTFORK prevents fork to fail with -ENOMEM if the default >> overcommit heuristics decides there's too much anonymous virtual >> memory allocated. If the KVM secondary MMU is synchronized with

Re: [Qemu-devel] [PATCH 12/16] qdev: Pass size to qbus_create_inplace()

2013-08-30 Thread Andreas Färber
Am 26.08.2013 10:03, schrieb Cornelia Huck: > On Sat, 24 Aug 2013 02:00:32 +0200 > Andreas Färber wrote: > >> To be passed to object_initialize(). >> >> Since commit 39355c3826f5d9a2eb1ce3dc9b4cdd68893769d6 the argument is >> void*, so drop some superfluous (BusState *) casts or direct parent >>

Re: [Qemu-devel] [PATCH] seccomp: adding a second whitelist

2013-08-30 Thread Stefan Hajnoczi
On Fri, Aug 30, 2013 at 4:21 PM, Eduardo Otubo wrote: > On 08/29/2013 05:34 AM, Stefan Hajnoczi wrote: >> On Wed, Aug 28, 2013 at 10:04:32PM -0300, Eduardo Otubo wrote: >>> >>> Now there's a second whitelist, right before the vcpu starts. The second >>> whitelist is the same as the first one, exce

[Qemu-devel] [PATCH V8 2/5] throttle: Add units tests

2013-08-30 Thread Benoît Canet
Signed-off-by: Benoit Canet --- tests/Makefile|2 + tests/test-throttle.c | 481 + 2 files changed, 483 insertions(+) create mode 100644 tests/test-throttle.c diff --git a/tests/Makefile b/tests/Makefile index b0200fd..6d2f3ad 100644

[Qemu-devel] [PULL 10/26] raw_bsd: introduce "special members"

2013-08-30 Thread Kevin Wolf
From: Laszlo Ersek On 08/05/13 15:03, Paolo Bonzini wrote: > > [...] > > 3) These members are special > > .format_name is the string "raw" > .bdrv_open raw_open should set bs->sg to bs->file->sg and return 0 > .bdrv_closeraw_close should do nothing > .bdrv_proberaw_p

Re: [Qemu-devel] [PATCH V2] qemu-xen: HVM domain S3 bugfix

2013-08-30 Thread Anthony PERARD
On 29/08/13 09:25, Liu, Jinsong wrote: > Currently HVM S3 has a bug coming from the difference between > qemu-traditioanl and qemu-xen. For qemu-traditional, the way > to resume from hvm s3 is via 'xl trigger' command. However, > for qemu-xen, the way to resume from hvm s3 inherited from > standard

[Qemu-devel] PING Re: [PATCH for-1.6] exec: fix writing to MMIO area with non-power-of-two length

2013-08-30 Thread Paolo Bonzini
Il 29/07/2013 14:28, Paolo Bonzini ha scritto: > The problem is introduced by commit 2332616 (exec: Support 64-bit > operations in address_space_rw, 2013-07-08). Before that commit, > memory_access_size would only return 1/2/4. > > Since alignment is already handled above, reduce l to the largest

Re: [Qemu-devel] [PATCH] seccomp: adding a second whitelist

2013-08-30 Thread Paul Moore
On Friday, August 30, 2013 11:27:28 AM Eduardo Otubo wrote: > On 08/29/2013 09:56 AM, Paul Moore wrote: > > On Wednesday, August 28, 2013 10:04:32 PM Eduardo Otubo wrote: > >> Now there's a second whitelist, right before the vcpu starts. The second > >> whitelist is the same as the first one, excep

Re: [Qemu-devel] [PATCH] powerpc iommu: rework traces

2013-08-30 Thread Alexander Graf
On 30.08.2013, at 16:42, Alexey Kardashevskiy wrote: > On 08/31/2013 12:39 AM, Alexander Graf wrote: >> >> On 29.08.2013, at 10:05, Alexey Kardashevskiy wrote: >> >>> This converts old style fprintf to traces. >>> >>> Signed-off-by: Alexey Kardashevskiy >> >> Thanks, applied with modified su

Re: [Qemu-devel] [RFC 2/5] hw/arm: add very initial support for Canon DIGIC SoC

2013-08-30 Thread Andreas Färber
Am 29.08.2013 21:36, schrieb Antony Pavlov: > On Thu, 29 Aug 2013 14:15:40 +0200 > Andreas Färber wrote: > >> Am 29.08.2013 11:33, schrieb Antony Pavlov: >>> DIGIC is Canon Inc.'s name for a family of SoC >>> for digital cameras and camcorders. >>> >>> There is no publicly available specification

Re: [Qemu-devel] [PATCH v2 2/7] tcg-i386: Don't perform GETPC adjustment in TCG code

2013-08-30 Thread Aurelien Jarno
On Thu, Aug 29, 2013 at 03:05:56PM -0700, Richard Henderson wrote: > Since we now perform it inside the helper, no need to do it here. > This also lets us perform a tail-call from the store slow path to > the helper. > > Signed-off-by: Richard Henderson > --- > tcg/i386/tcg-target.c | 34 +++

[Qemu-devel] [PULL 20/26] qcow2: Metadata overlap checks

2013-08-30 Thread Kevin Wolf
From: Max Reitz Two new functions are added; the first one checks a given range in the image file for overlaps with metadata (main header, L1 tables, L2 tables, refcount table and blocks). The second one should be used immediately before writing to the image file as it calls the first function a

[Qemu-devel] [PULL 23/26] qcow2-refcount: Repair OFLAG_COPIED errors

2013-08-30 Thread Kevin Wolf
From: Max Reitz Since the OFLAG_COPIED checks are now executed after the refcounts have been repaired (if repairing), it is safe to assume that they are correct but the OFLAG_COPIED flag may be not. Therefore, if its value differs from what it should be (considering the according refcount), that

Re: [Qemu-devel] [PATCH v2 6/7] tcg: Introduce zero and sign-extended versions of load helpers

2013-08-30 Thread Richard Henderson
On 08/30/2013 09:55 AM, Aurelien Jarno wrote: > While it works for x86 and some other architectures, it makes the > assumption that only part of the register can be used later by the TCG > code. It won't be the case if we later (and I hope we will) implement a > MIPS64 TCG target. In that case, a 3

[Qemu-devel] [PULL 16/26] option: Add assigned flag to QEMUOptionParameter

2013-08-30 Thread Kevin Wolf
From: Max Reitz Adds an "assigned" flag to QEMUOptionParameter which is cleared at the beginning of parse_option_parameters and set on (successful) set_option_parameter and set_option_parameter_int. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- include/qemu/option.h | 1 + util/qemu-

Re: [Qemu-devel] [PATCH v2] spapr-vscsi: Report error on unsupported MAD requests

2013-08-30 Thread Alexander Graf
On 29.08.2013, at 10:13, Alexey Kardashevskiy wrote: > The existing driver just dropped unsupported requests. This adds error > responses to those unhandled requests. > > Signed-off-by: Alexey Kardashevskiy Acked-by: Alexander Graf Paolo, you want to take this one? Alex

Re: [Qemu-devel] [PATCH qom-cpu for-next 0/2] QOM CPUState, part 12: CPU loops, revisited

2013-08-30 Thread Andreas Färber
Am 14.08.2013 13:49, schrieb Andreas Färber: > Am 30.07.2013 18:55, schrieb Andreas Färber: >> Hello everyone, >> >> A short CPUState series for a change: This mini-series replaces our >> home-grown >> CPU list (first_cpu global and CPUState::next_cpu) with a QTAILQ. >> >> To avoid repeated QTAILQ

[Qemu-devel] [RFC PATCH] Convert ram_list to RCU DQ V2

2013-08-30 Thread Mike Day
Changes from V1: * Omitted locks or rcu critical sections within Some functions that read or write the ram_list but are called in a protected context (the caller holds the iothread lock, the ram_list mutex, or an rcu critical section). Allow "unlocked" reads of the ram_list by using an RCU-

[Qemu-devel] [PATCH V8 0/5] Continuous Leaky Bucket Throttling

2013-08-30 Thread Benoît Canet
This patchset implement continous leaky bucket throttling. It use two requests queue to enable to do silly unbalanced throttling like block_set_io_throttle 0 0 0 0 6000 1 It use two timer to get the timer callbacks and the throttle.c code simple in this version: rearm timer only when it's no

Re: [Qemu-devel] [PATCH 15/16] qdev-monitor: Clean up qdev_device_add() variable naming

2013-08-30 Thread Andreas Färber
Am 26.08.2013 09:52, schrieb Wenchao Xia: > 于 2013-8-24 8:00, Andreas Färber 写道: >> Avoid confusion between object and object class. > between object class and device class? No the issue is that by convention we usually use Object *obj; ObjectClass *oc; /* previously: klass or k */ rather than

Re: [Qemu-devel] [PATCH v2 3/7] exec: Rename USUFFIX to LSUFFIX

2013-08-30 Thread Aurelien Jarno
On Thu, Aug 29, 2013 at 03:05:57PM -0700, Richard Henderson wrote: > In a following patch, there will be confusion between multiple "unsigned" > suffixes; rename this one so as to imply "load". > > Signed-off-by: Richard Henderson > --- > include/exec/softmmu_template.h | 12 ++-- > 1 fi

[Qemu-devel] [PULL 21/26] qcow2: Employ metadata overlap checks

2013-08-30 Thread Kevin Wolf
From: Max Reitz The pre-write overlap check function is now called before most of the qcow2 writes (aborting it on collision or other error). Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2-cache.c| 17 + block/qcow2-cluster.c | 21 +

[Qemu-devel] [PULL 17/26] qcow2-refcount: Snapshot update for zero clusters

2013-08-30 Thread Kevin Wolf
From: Max Reitz Account for all cluster types in qcow2_update_snapshot_refcounts; this prevents this function from updating the refcount of unallocated zero clusters which effectively led to wrong adjustments of the refcount of cluster 0 (the main qcow2 header). This in turn resulted in images wi

  1   2   3   >