[Qemu-devel] [PATCH] pc: add 1.7 machine types for piix,q35

2013-09-11 Thread Michael S. Tsirkin
piix 1.7 is the default. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 19 +-- hw/i386/pc_q35.c | 17 - 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 66551b4..0ade373 100644 --- a/hw/i386/p

Re: [Qemu-devel] [PATCH v6 2/8] rule.mak: allow per object cflags and libs

2013-09-11 Thread Paolo Bonzini
Il 12/09/2013 04:52, Fam Zheng ha scritto: >>> > > define unnest-dir >>> > > $(foreach var,$(nested-vars),$(call push-var,$(var),$1/)) >>> > > $(eval obj-parent-$1 := $(obj)) >>> > > $(eval obj := $(if $(obj),$(obj)/$1,$1)) >>> > > $(eval include $(SRC_PATH)/$1/Makefile.objs) >>> > > +$(foreac

Re: [Qemu-devel] [PATCH v5 0/5] bugs fix for hpet

2013-09-11 Thread Paolo Bonzini
Il 12/09/2013 05:25, Liu Ping Fan ha scritto: > v5: > use stand compat property to fix hpet intcap on pc-q35, while on pc-piix, > hard code intcap as IRQ2 > > v4: > use stand compat property to fix hpet intcap > > v3: > change hpet interrupt capablity on board's demand > > Liu Ping Fan (5

[Qemu-devel] [Bug 1007269] Re: Can’t install or boot up 32bit win8 guest.

2013-09-11 Thread Stefan Weil
*** This bug is a duplicate of bug 921208 *** https://bugs.launchpad.net/bugs/921208 It's not a KVM bug, but a well known problem of QEMU without KVM (TCG). There is currently no solution. ** Changed in: qemu Status: Invalid => Confirmed ** This bug has been marked a duplicate of bug

Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function

2013-09-11 Thread Michael Tokarev
12.09.2013 07:02, Fam Zheng wrote. On Wed, 09/11 11:46, Richard Henderson wrote: On 09/11/2013 08:48 AM, Daniel P. Berrange wrote: We know the precise list of valid modules when building QEMU, so IMHO, this should just explicitly load each known module name, and *not* readdir. Also it should do

[Qemu-devel] [PATCH] KVM: IRQFD: equip irqfd and resamplefd with polarity

2013-09-11 Thread Liu Ping Fan
Nowadays, irqfd can emulate trigger mode, but it can not emulate trigger polarity. While in some cases, ioapic ioredtbl[x] expects _low_ active. So equipping irqfd with the ability. Correspondingly, resamplefd will have the same polarity as irqfd. Signed-off-by: Liu Ping Fan --- This helps to ste

[Qemu-devel] [PATCH 4/5] hpet: deliver irq by irqfd when in dedicated thread mode

2013-09-11 Thread Liu Ping Fan
Running hpet in iothread, there could be variable payload, which will finally affect the accurate of timing. So we want to run hpet on dedicated thread. For hpet, almost of the things can run out of BQL, except interrupt. We step around interrupt by using irqfd. Signed-off-by: Liu Ping Fan ---

[Qemu-devel] [PATCH 5/5] hpet: run on dedicate thread

2013-09-11 Thread Liu Ping Fan
migration is not supported yet. Signed-off-by: Liu Ping Fan --- hw/timer/hpet.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index ae54b87..8e32e36 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -91,6

[Qemu-devel] [PATCH 1/5] irq: introduce route method in IRQState to get gsi

2013-09-11 Thread Liu Ping Fan
Since the interrupt pin's connection does not change, so we can decide the gsi for the pin. Introducing "route" method in IRQState to do that, and the implement of "route" requires the guarantee that it can survive without BQL. When delivering irq, this will help us to step around the irq system

[Qemu-devel] [PATCH 3/5] irqfd: equip irqfd with polarity

2013-09-11 Thread Liu Ping Fan
Equip irqfd with polarity, so it can emulate the low-active interrupt. We take one extra bit in flags to pass this info to kernel and keep the default value "zero" as high-active. Signed-off-by: Liu Ping Fan --- The kernel will extend this interface correspondingly --- hw/misc/vfio.c

[Qemu-devel] [RFC 0/5] run hpet on a dedicated thread

2013-09-11 Thread Liu Ping Fan
Nowadays, we run hpet on iothread. But there are so many undetermined jobs on iothread. It will heavily affect the accuracy of hpet's timing. When running on a dedicated thread, the accuracy of timing is only determined by scheduler. which is more fixed. This series depend on the thread-safe patch

[Qemu-devel] [PATCH 2/5] irq: implement route method of ioapic

2013-09-11 Thread Liu Ping Fan
Implement the routing of PC's interrupt gpio to intc, and retrieve the gsi. Signed-off-by: Liu Ping Fan --- hw/core/qdev.c | 8 hw/i386/kvm/i8259.c| 8 +++- hw/i386/kvm/ioapic.c | 21 - hw/i386/pc_q35.c | 4 ++-- include/hw/qdev-core.h | 2

[Qemu-devel] [PATCH v5 5/5] PC-1.6: add compatibility for hpet intcap on pc-q35-1.6

2013-09-11 Thread Liu Ping Fan
For guest bug compat, we limit hpet's interrupt compatibility on ioapic's IRQ2 for pc-q35-1.6. As to pc-35-1.7 and newer, IRQ2, IRQ8, and IRQ16~23 are allowed. Signed-off-by: Liu Ping Fan --- hw/timer/hpet.c | 7 ++- include/hw/i386/pc.h | 4 2 files changed, 6 insertions(+), 5 del

[Qemu-devel] [PATCH v5 4/5] PC: differentiate hpet's interrupt capability on piix and q35

2013-09-11 Thread Liu Ping Fan
For pc-piix-*, hpet's intcap is always hard coded as IRQ2. While for pc-q35-*, we resort to compat property to fix it (a later patch). Signed-off-by: Liu Ping Fan --- hw/i386/pc.c | 12 hw/i386/pc_piix.c| 3 ++- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 3 ++

[Qemu-devel] [PATCH v5 3/5] PC: use qdev_xx to create hpet instead of sysbus_create_xx

2013-09-11 Thread Liu Ping Fan
sysbus_create_xx func does not allow us to set a device's extra properties. While hpet need to set its compat property before initialization, so we abandon the wrapper function, and spread its logic "inline" Signed-off-by: Liu Ping Fan --- hw/i386/pc.c | 11 +-- 1 file changed, 9 insert

[Qemu-devel] [PATCH v5 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS

2013-09-11 Thread Liu Ping Fan
According to hpet spec, hpet irq is high active. But according to ICH spec, there is inversion before the input of ioapic. So the OS will expect low active on this IRQ line.(And this is observed on bare metal). We fold the emulation of this inversion inside the hpet logic. Signed-off-by: Liu Ping

[Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-11 Thread Liu Ping Fan
On PC, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 of ioapic can be dynamically assigned to hpet as guest chooses. (Will enable them after introducing pc 1.6 compat) Signed-off-by: Liu Ping Fan --- hw/timer/hpet.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v5 0/5] bugs fix for hpet

2013-09-11 Thread Liu Ping Fan
v5: use stand compat property to fix hpet intcap on pc-q35, while on pc-piix, hard code intcap as IRQ2 v4: use stand compat property to fix hpet intcap v3: change hpet interrupt capablity on board's demand Liu Ping Fan (5): hpet: inverse polarity when pin above ISA_NUM_IRQS hpet: enti

Re: [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:24, Peter Maydell wrote: > On 11 September 2013 06:38, Fam Zheng wrote: > > --- a/linux-user/main.c > > +++ b/linux-user/main.c > > @@ -34,6 +34,7 @@ > > #include "qemu/timer.h" > > #include "qemu/envlist.h" > > #include "elf.h" > > +#include > > > > char *exec_path; > > > >

Re: [Qemu-devel] [PATCH v3 0/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-11 Thread liu ping fan
Hi Stefan, Do you think this series is ready to be merged? I have some code to run hpet on a dedicated thread, and in theory it will rely on this. Thanks and regards, Pingfan On Thu, Aug 29, 2013 at 10:42 PM, Stefan Hajnoczi wrote: > v3: > * Squashed Paolo's fixes and added his patch to avoid

Re: [Qemu-devel] [PATCH v6 0/8] Shared Library Module Support

2013-09-11 Thread Fam Zheng
On Wed, 09/11 17:26, Peter Maydell wrote: > On 11 September 2013 14:34, Fam Zheng wrote: > > This series implements feature of shared object building as described in: > > > > http://wiki.qemu.org/Features/Modules > > > v6: Dropping RFC. > > ...which I guess makes it a reasonable time to mention

[Qemu-devel] [Bug 1007269] Re: Can’t install or boot up 32bit win8 guest.

2013-09-11 Thread chao zhou
It's not a KVM bug. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1007269 Title: Can’t install or boot up 32bit win8 guest. Status in QEMU: Inv

Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function

2013-09-11 Thread Fam Zheng
On Wed, 09/11 11:46, Richard Henderson wrote: > On 09/11/2013 08:48 AM, Daniel P. Berrange wrote: > > We know the precise list of valid modules when building QEMU, > > so IMHO, this should just explicitly load each known module > > name, and *not* readdir. Also it should do something along the > >

Re: [Qemu-devel] [PATCH v6 2/8] rule.mak: allow per object cflags and libs

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:43, Paolo Bonzini wrote: > Il 11/09/2013 15:34, Fam Zheng ha scritto: > > Adds extract-libs in LINK to expand any "per object libs", the syntax to > > define > > such a libs options is like: > > > > foo.o-libs := $(CURL_LIBS) > > > > in block/Makefile.objs. > > > > Simi

Re: [Qemu-devel] [PATCH v6 3/8] Makefile: introduce common-obj-m and block-obj-m for DSO

2013-09-11 Thread Fam Zheng
On Wed, 09/11 21:34, Fam Zheng wrote: > Add necessary rules and flags for shared object generation. > $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does > for $(block-obj-y). The new rules introduced here are: > > 0) For all %.so compiling: > > QEMU_CFLAGS += -fPIC > > 1)

Re: [Qemu-devel] [PATCH v6 3/8] Makefile: introduce common-obj-m and block-obj-m for DSO

2013-09-11 Thread Fam Zheng
On Wed, 09/11 21:01, Peter Maydell wrote: > On 11 September 2013 14:34, Fam Zheng wrote: > > Add necessary rules and flags for shared object generation. > > $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does > > for $(block-obj-y). The new rules introduced here are: > > > > 0)

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:41, Paolo Bonzini wrote: > Il 11/09/2013 15:34, Fam Zheng ha scritto: > > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > > Makefile.objs: > > > > $(obj)/curl.o: QEMU_CFLAGS

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:59, Daniel P. Berrange wrote: > On Wed, Sep 11, 2013 at 09:34:01PM +0800, Fam Zheng wrote: > > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > > Makefile.objs: > > > > $(obj)

Re: [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules

2013-09-11 Thread Fam Zheng
On Wed, 09/11 16:41, Daniel P. Berrange wrote: > On Wed, Sep 11, 2013 at 09:34:08PM +0800, Fam Zheng wrote: > > The converted block drivers are: > > > > curl > > iscsi > > rbd > > ssh > > glusterfs > > > > no longer adds flags and libs for them to global variables, instead > >

Re: [Qemu-devel] [PATCH v6 5/8] configure: introduce --enable-modules

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:46, Paolo Bonzini wrote: > Il 11/09/2013 15:34, Fam Zheng ha scritto: > > The new option will enable support of shared object build. Otherwise > > objects are static linked to executables. > > > > Signed-off-by: Fam Zheng > > --- > > Makefile.target | 6 +- > > configure

Re: [Qemu-devel] [PATCH v6 6/8] Makefile: install modules with "make install"

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:50, Paolo Bonzini wrote: > Il 11/09/2013 15:34, Fam Zheng ha scritto: > > Install all the subdirs for modules under configure option "moddir". > > > > Signed-off-by: Fam Zheng > > --- > > Makefile | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Makefile b/M

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Fam Zheng
On Wed, 09/11 15:59, Daniel P. Berrange wrote: > On Wed, Sep 11, 2013 at 09:34:01PM +0800, Fam Zheng wrote: > > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > > Makefile.objs: > > > > $(obj)

Re: [Qemu-devel] [PATCH] ui/Makefile.objs: delete unnecessary cocoa.o dependency

2013-09-11 Thread Fam Zheng
On Wed, 09/11 17:49, Peter Maydell wrote: > Delete an unnecessary dependency for cocoa.o; we already have > a general rule that tells Make that we can build a .o file > from a .m source using an ObjC compiler, so this specific > rule is unnecessary. Further, it is using the dubious construct > "$(S

Re: [Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes

2013-09-11 Thread Eric Blake
On 09/11/2013 02:52 PM, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > docs/qmp/qmp-events.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt > index 39b6016..1e91f45 100644 > --- a/docs/qmp/qmp-even

Re: [Qemu-devel] [PATCH 5/6] QMP: Update qmp-spec.txt

2013-09-11 Thread Eric Blake
On 09/11/2013 02:52 PM, Luiz Capitulino wrote: > Simplify the text, fix some of the examples. > > Signed-off-by: Luiz Capitulino > --- > docs/qmp/qmp-spec.txt | 65 > ++- > 1 file changed, 28 insertions(+), 37 deletions(-) > > diff --git a/docs/

Re: [Qemu-devel] [PATCH 4/6] QMP: Update README file

2013-09-11 Thread Eric Blake
On 09/11/2013 02:52 PM, Luiz Capitulino wrote: > Drop unneeded info, fix some of the examples and rename QEMU Monitor > Protocol to QEMU Machine Protocol. > > Signed-off-by: Luiz Capitulino > --- > docs/qmp/README | 99 > - > 1 file change

[Qemu-devel] Ping http://patchwork.ozlabs.org/patch/251410/

2013-09-11 Thread Richard Henderson
There have been two patches posted for this uninitialized warning, outstanding since June 14. I still encounter this daily... r~

Re: [Qemu-devel] [PATCH 1/6] QMP: add scripts/qmp

2013-09-11 Thread Eric Blake
On 09/11/2013 04:08 PM, Eric Blake wrote: > On 09/11/2013 02:52 PM, Luiz Capitulino wrote: >> Populate it with all scripts stored in QMP/. >> >> Signed-off-by: Luiz Capitulino > Reviewed-by: Eric Blake > > Repeat after me: > git config diff.renames true > > at which point, this commit is much

Re: [Qemu-devel] [PATCH 1/6] QMP: add scripts/qmp

2013-09-11 Thread Eric Blake
On 09/11/2013 02:52 PM, Luiz Capitulino wrote: > Populate it with all scripts stored in QMP/. > > Signed-off-by: Luiz Capitulino > --- > QMP/qemu-ga-client | 299 > - > QMP/qmp| 126 --- > QMP/qmp-shell

Re: [Qemu-devel] [PATCH 3/6] QMP: QMP/ -> docs/qmp/

2013-09-11 Thread Eric Blake
On 09/11/2013 02:52 PM, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > QMP/README | 88 - > QMP/qmp-events.txt | 480 > > QMP/qmp-spec.txt| 282 > docs/qmp/README

Re: [Qemu-devel] [PATCH 2/6] QMP: fix qmp-commands.txt generation path

2013-09-11 Thread Eric Blake
On 09/11/2013 02:52 PM, Luiz Capitulino wrote: > This file should be generated in the BUILD_DIR, as all other docs. > > Signed-off-by: Luiz Capitulino > --- > Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com

Re: [Qemu-devel] [PATCH] target-i386: set model=6 on qemu64 & qemu32 CPU models

2013-09-11 Thread Andreas Färber
Am 11.09.2013 10:37, schrieb Igor Mammedov: > On Wed, 11 Sep 2013 10:25:58 +0200 > Andreas Färber wrote: > >> Am 11.09.2013 10:22, schrieb Igor Mammedov: >>> On Tue, 10 Sep 2013 17:48:59 -0300 >>> Eduardo Habkost wrote: >>> There's no Intel CPU with family=6,model=2, and Linux and Windows g

[Qemu-devel] [PATCH 0/6] QMP: re-organize documentation

2013-09-11 Thread Luiz Capitulino
The QMP dir is storing QMP docs and scripts. This series moves the scripts to scripts/qmp/ and the docs to docs/qmp/. Also, the docs are updated. Luiz Capitulino (6): QMP: add scripts/qmp QMP: fix qmp-commands.txt generation path QMP: QMP/ -> docs/qmp/ QMP: Update README file QMP: Update

[Qemu-devel] [PATCH 5/6] QMP: Update qmp-spec.txt

2013-09-11 Thread Luiz Capitulino
Simplify the text, fix some of the examples. Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-spec.txt | 65 ++- 1 file changed, 28 insertions(+), 37 deletions(-) diff --git a/docs/qmp/qmp-spec.txt b/docs/qmp/qmp-spec.txt index a277896..22568c6 100

[Qemu-devel] [PATCH 2/6] QMP: fix qmp-commands.txt generation path

2013-09-11 Thread Luiz Capitulino
This file should be generated in the BUILD_DIR, as all other docs. Signed-off-by: Luiz Capitulino --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 806946e..4a147b0 100644 --- a/Makefile +++ b/Makefile @@ -65,7 +65,7 @@ LIBS+=-lz $(L

[Qemu-devel] [PATCH 4/6] QMP: Update README file

2013-09-11 Thread Luiz Capitulino
Drop unneeded info, fix some of the examples and rename QEMU Monitor Protocol to QEMU Machine Protocol. Signed-off-by: Luiz Capitulino --- docs/qmp/README | 99 - 1 file changed, 49 insertions(+), 50 deletions(-) diff --git a/docs/qmp/READ

[Qemu-devel] [PATCH 3/6] QMP: QMP/ -> docs/qmp/

2013-09-11 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- QMP/README | 88 - QMP/qmp-events.txt | 480 QMP/qmp-spec.txt| 282 docs/qmp/README | 88 + docs/qmp/qmp-events.txt | 480 ++

[Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes

2013-09-11 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- docs/qmp/qmp-events.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt index 39b6016..1e91f45 100644 --- a/docs/qmp/qmp-events.txt +++ b/docs/qmp/qmp-events.txt @@ -1,4 +1,4 @@ -

Re: [Qemu-devel] [PATCH v6 3/8] Makefile: introduce common-obj-m and block-obj-m for DSO

2013-09-11 Thread Peter Maydell
On 11 September 2013 14:34, Fam Zheng wrote: > Add necessary rules and flags for shared object generation. > $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does > for $(block-obj-y). The new rules introduced here are: > > 0) For all %.so compiling: > > QEMU_CFLAGS += -fPIC >

Re: [Qemu-devel] [PATCH] qdev-monitor: Avoid exiting when hot-plugging two devices with the same bootindex value

2013-09-11 Thread Marcel Apfelbaum
On Wed, 2013-09-11 at 21:26 +0300, Marcel Apfelbaum wrote: > Qemu is expected to quit if the same boot index value is used by two devices. > However, hot-plugging a device with a bootindex value already used should > fail with a friendly message rather than quitting a running VM. > > Signed-off-by

Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function

2013-09-11 Thread Richard Henderson
On 09/11/2013 08:48 AM, Daniel P. Berrange wrote: > We know the precise list of valid modules when building QEMU, > so IMHO, this should just explicitly load each known module > name, and *not* readdir. Also it should do something along the > lines suggested their of poisoning exported symbols with

Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function

2013-09-11 Thread Alex Bligh
--On 11 September 2013 16:48:41 +0100 "Daniel P. Berrange" wrote: We know the precise list of valid modules when building QEMU, so IMHO, this should just explicitly load each known module name, and *not* readdir. Also it should do something along the lines suggested their of poisoning expor

Re: [Qemu-devel] [PATCHv2 2/3] seccomp: adding command line support for blacklist

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 12:45:54PM -0400, Corey Bryant wrote: > > > On 09/06/2013 03:21 PM, Eduardo Otubo wrote: > >New command line options for the seccomp blacklist feature: > > > > $ qemu -sandbox on[,strict=] > > > >The strict parameter will turn on or off the new system call blacklist > >

[Qemu-devel] [PATCH] qdev-monitor: Avoid exiting when hot-plugging two devices with the same bootindex value

2013-09-11 Thread Marcel Apfelbaum
Qemu is expected to quit if the same boot index value is used by two devices. However, hot-plugging a device with a bootindex value already used should fail with a friendly message rather than quitting a running VM. Signed-off-by: Marcel Apfelbaum --- qdev-monitor.c | 33

Re: [Qemu-devel] [PATCH] qemu-img: fix invalid JSON

2013-09-11 Thread Eric Blake
On 09/11/2013 10:47 AM, Paolo Bonzini wrote: > Single quotes for JSON are a QMP-ism, use real JSON in > qemu-img output. > > Reported-by: Kevin Wolf > Signed-off-by: Paolo Bonzini > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --g

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 18:38, Peter Maydell ha scritto: > On 11 September 2013 14:34, Fam Zheng wrote: >> Makefile.target includes rule.mak and unnested common-obj-y, then prefix >> them with '../', this will ignore object specific QEMU_CFLAGS in subdir >> Makefile.objs: >> >> $(obj)/curl.o: QEMU_CFLAG

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-11 Thread Scott Wood
On Wed, 2013-09-11 at 11:42 -0500, Yoder Stuart-B08248 wrote: > One thing we didn't discuss needs to be considered (probably by > Kim who is looking at the 'binding device' issue) is around > returning a passthru device back to the host. > > After a platform device has been bound to vfio and is in

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-11 Thread Yoder Stuart-B08248
> -Original Message- > From: Yoder Stuart-B08248 > Sent: Thursday, September 05, 2013 12:51 PM > To: Wood Scott-B07421; Sethi Varun-B16395; Bhushan Bharat-R65777; 'Peter > Maydell'; 'Santosh Shukla'; 'Alex Williamson'; 'Alexander Graf'; > 'Antonios Motakis'; 'Christoffer Dall'; 'kim.phill

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Peter Maydell
On 11 September 2013 17:40, Paolo Bonzini wrote: > Il 11/09/2013 18:38, Peter Maydell ha scritto: >> I think the right fix for this is just to delete that line >> from ui/Makefile.objs, because we have a generic >> rule that says "you can build foo.o from foo.m with >> an objective-C compiler". Th

Re: [Qemu-devel] [PATCHv2 2/3] seccomp: adding command line support for blacklist

2013-09-11 Thread Corey Bryant
On 09/06/2013 03:21 PM, Eduardo Otubo wrote: New command line options for the seccomp blacklist feature: $ qemu -sandbox on[,strict=] The strict parameter will turn on or off the new system call blacklist I mentioned this before but I'll say it again since I think it needs to be discusse

[Qemu-devel] [PATCH] qemu-img: fix invalid JSON

2013-09-11 Thread Paolo Bonzini
Single quotes for JSON are a QMP-ism, use real JSON in qemu-img output. Reported-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 3e5e388..626365d 100644 --- a/qemu-img.c +++ b/qemu-img.c

Re: [Qemu-devel] [PATCHv3 3/3] seccomp: general fixes

2013-09-11 Thread Corey Bryant
On 09/06/2013 03:21 PM, Eduardo Otubo wrote: 1) On qemu-seccomp.c:255, the variable ctx was being used uninitialized; now it's initialized with NULL and it's being checked at the end of the function. 2) Changed the name of the command line option from "enable" to "sandbox" for a better und

[Qemu-devel] [PATCH] ui/Makefile.objs: delete unnecessary cocoa.o dependency

2013-09-11 Thread Peter Maydell
Delete an unnecessary dependency for cocoa.o; we already have a general rule that tells Make that we can build a .o file from a .m source using an ObjC compiler, so this specific rule is unnecessary. Further, it is using the dubious construct "$(SRC_PATH)/$(obj)" to get at the source directory, whi

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-11 Thread Alex Williamson
On Wed, 2013-09-11 at 16:42 +, Yoder Stuart-B08248 wrote: > > > -Original Message- > > From: Yoder Stuart-B08248 > > Sent: Thursday, September 05, 2013 12:51 PM > > To: Wood Scott-B07421; Sethi Varun-B16395; Bhushan Bharat-R65777; 'Peter > > Maydell'; 'Santosh Shukla'; 'Alex Williamson

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Peter Maydell
On 11 September 2013 14:34, Fam Zheng wrote: > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > Makefile.objs: > > $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) > > Because $(obj) here is './bloc

Re: [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function

2013-09-11 Thread Richard Henderson
On 09/11/2013 08:23 AM, Alex Bligh wrote: >> But it does suggest the default being DT_RUNPATH, overridable "near" >> the command-line via LD_RUN_PATH. > > Not quite sure what you are suggesting here. DT_RUNPATH is an elf > tag IIRC. Not sure what LD_RUN_PATH does. LD_LIBRARY_PATH affects > more th

Re: [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 09:34:08PM +0800, Fam Zheng wrote: > The converted block drivers are: > > curl > iscsi > rbd > ssh > glusterfs > > no longer adds flags and libs for them to global variables, instead > create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which

Re: [Qemu-devel] [PATCHv2 1/3] seccomp: adding blacklist support

2013-09-11 Thread Corey Bryant
On 09/06/2013 03:21 PM, Eduardo Otubo wrote: Adding a system call blacklist right before the vcpus starts. This filter is composed by the system calls that can't be executed after the guests are up. This list should be refined as the whitelist is, with as much testing as we can do using virt-te

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Eric Blake
On 09/11/2013 08:53 AM, Paolo Bonzini wrote: > > printf "# Configured with:" >> $config_host_mak > printf " '%s'" "$0" "$@" >> $config_host_mak > > Something like > > for arg in "$0" "$@"; do >quoted_arg=$(echo "$i" | sed 's/[$\\"]/\\&/g') Won't work as written: mismatch between $arg vs. $i

Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 09:34:04PM +0800, Fam Zheng wrote: > Added three types of modules: > > typedef enum { > MODULE_LOAD_BLOCK = 0, > MODULE_LOAD_UI, > MODULE_LOAD_NET, > MODULE_LOAD_MAX, > } module_load_type; > > and their loading function: > > voi

Re: [Qemu-devel] [PATCH v6 0/8] Shared Library Module Support

2013-09-11 Thread Peter Maydell
On 11 September 2013 14:34, Fam Zheng wrote: > This series implements feature of shared object building as described in: > > http://wiki.qemu.org/Features/Modules > v6: Dropping RFC. ...which I guess makes it a reasonable time to mention that this doesn't build on MacOSX/clang: cc -m64 -DOS_OBJ

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Gabriel Kerneis
On Wed, Sep 11, 2013 at 04:01:37PM +0100, Gabriel Kerneis wrote: > On Wed, Sep 11, 2013 at 04:53:35PM +0200, Paolo Bonzini wrote: > > Oh, then it's this line in configure that has to be changed to do proper > > quoting. > > > > printf "# Configured with:" >> $config_host_mak > > printf " '%s'" "$0

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Gabriel Kerneis
On Wed, Sep 11, 2013 at 04:16:28PM +0100, Gabriel Kerneis wrote: > > Yeah, what I'm missing now is why your patch works. > > That is indeed very mysterious :-) Okay, the answer is simple enough: it doesn't fix the issue at all. Long story short, I had a sed script to rewrite the faulty extra_cfla

[Qemu-devel] [PATCH v4 01/24] a9mpcore: Split off instance_init

2013-09-11 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index 3e675e3..acbdab5 100644 --- a/hw/cpu/a9mpcore.c +++ b/hw/cpu/a9mpcore.

[Qemu-devel] [PATCH v4 11/24] a15mpcore: Embed GICState

2013-09-11 Thread Andreas Färber
From: Andreas Färber This covers both emulated and KVM GIC. Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c inde

[Qemu-devel] [PATCH v4 10/24] a15mpcore: Split off instance_init

2013-09-11 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c index 9abba67..af29c35 100644 --- a/hw/cpu/a15mpcore.c +++ b/hw/cpu/a15

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 16:42, Gabriel Kerneis ha scritto: > On Wed, Sep 11, 2013 at 04:01:50PM +0200, Paolo Bonzini wrote: >>> ./configure --extra-cflags="-Dcoroutine_fn='__attribute__((coroutine_fn))'" >> >> Where does the shell read config-host.mak? Make does not need the quotes. > > I might have been c

[Qemu-devel] [PATCH v4 12/24] a15mpcore: Convert to QOM realize

2013-09-11 Thread Andreas Färber
From: Andreas Färber Turn SysBusDevice initfn into a QOM realizefn. Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c index b2614e7..10dc35a 100644 --- a/hw/cpu/

[Qemu-devel] [PATCH v4 18/24] arm11mpcore: Split off SCU device

2013-09-11 Thread Andreas Färber
Inspired by a9scu. Signed-off-by: Andreas Färber --- default-configs/arm-softmmu.mak | 1 + hw/cpu/arm11mpcore.c| 65 ++ hw/misc/Makefile.objs | 1 + hw/misc/arm11scu.c | 100 include/hw/misc

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-09-11 Thread Kevin Wolf
Am 11.09.2013 um 17:32 hat Gabriel Kerneis geschrieben: > On Wed, Sep 11, 2013 at 05:24:55PM +0200, Kevin Wolf wrote: > > In config-host.make we do get: > > > > CONFIG_COROUTINE_POOL=0 > > > > But when config-host.h is generated from it, I assume it's only checked > > if the variable is defin

[Qemu-devel] [PATCH v4 14/24] a9scu: Build only once

2013-09-11 Thread Andreas Färber
It does not have a target or ARMCPU dependency. Signed-off-by: Andreas Färber --- hw/misc/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs index 2578e29..5636299 100644 --- a/hw/misc/Makefile.objs +++ b/hw/misc/Makefi

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-09-11 Thread Gabriel Kerneis
On Wed, Sep 11, 2013 at 05:24:55PM +0200, Kevin Wolf wrote: > In config-host.make we do get: > > CONFIG_COROUTINE_POOL=0 > > But when config-host.h is generated from it, I assume it's only checked > if the variable is defined, so we end up with: > > #define CONFIG_COROUTINE_POOL 1 Did y

Re: [Qemu-devel] [PATCH 10/16] dimm: add busy slot check and slot auto-allocation

2013-09-11 Thread Igor Mammedov
On Sat, 03 Aug 2013 15:56:50 +0200 Andreas Färber wrote: > Am 26.07.2013 16:37, schrieb Paolo Bonzini: > > Il 26/07/2013 14:51, Igor Mammedov ha scritto: > >> On Fri, 26 Jul 2013 11:26:16 +0200 > >> Paolo Bonzini wrote: > >>> Il 26/07/2013 09:38, Igor Mammedov ha scritto: > >> I agree that s

Re: [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path

2013-09-11 Thread Daniel P. Berrange
On Wed, Sep 11, 2013 at 09:34:01PM +0800, Fam Zheng wrote: > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > Makefile.objs: > > $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) > > Because $(obj)

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-09-11 Thread Kevin Wolf
Am 11.09.2013 um 16:42 hat Stefan Hajnoczi geschrieben: > The 'gthread' coroutine backend was written before the freelist (aka > pool) existed in qemu-coroutine.c. > > This means that every thread is expected to exit when its coroutine > terminates. It is not possible to reuse threads from a pool

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Gabriel Kerneis
On Wed, Sep 11, 2013 at 04:53:35PM +0200, Paolo Bonzini wrote: > Oh, then it's this line in configure that has to be changed to do proper > quoting. > > printf "# Configured with:" >> $config_host_mak > printf " '%s'" "$0" "$@" >> $config_host_mak No, this line has absolutely nothing to do with i

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 17:23, Gabriel Kerneis ha scritto: > On Wed, Sep 11, 2013 at 04:16:28PM +0100, Gabriel Kerneis wrote: >>> > > Yeah, what I'm missing now is why your patch works. >> > >> > That is indeed very mysterious :-) > Okay, the answer is simple enough: it doesn't fix the issue at all. > Long

[Qemu-devel] cache=writeback and migrations over shared storage

2013-09-11 Thread Filippos Giannakos
Hello All, I stumbled upon this link [1] which among other things contains the following: "iSCSI, FC, or other forms of direct attached storage are only safe to use with live migration if you use cache=none." How valid is this assertion with current QEMU versions? I checked out the source code

[Qemu-devel] [PATCH v4 08/24] a9mpcore: Convert to QOM realize

2013-09-11 Thread Andreas Färber
From: Andreas Färber Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index db3907e..a162ff0 100644 --- a/hw/cpu/a9mpcore.c +++ b/hw/cpu/a9mpcore.c

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 17:01, Gabriel Kerneis ha scritto: > On Wed, Sep 11, 2013 at 04:53:35PM +0200, Paolo Bonzini wrote: >> Oh, then it's this line in configure that has to be changed to do proper >> quoting. >> >> printf "# Configured with:" >> $config_host_mak >> printf " '%s'" "$0" "$@" >> $config_host

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Gabriel Kerneis
On Wed, Sep 11, 2013 at 05:06:41PM +0200, Paolo Bonzini wrote: > > The line that has to be fixed is > > really the line starting with "extra_cflags=" in config-host.mak (well, > > at least in my experience - my patch does not touch the first line, at > > it still solves the issue). > > Yeah, what

Re: [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function

2013-09-11 Thread Alex Bligh
--On 11 September 2013 08:06:20 -0700 Richard Henderson wrote: If we want dependencies between modules, we may well need to get the dynamic linker involved with the search directory. This would rule out any command-line, or monitor-line altering of the path. But it does suggest the defau

[Qemu-devel] [PATCH v4 02/24] arm_gic: Extract headers hw/intc/arm_gic{, _common}.h

2013-09-11 Thread Andreas Färber
Rename NCPU to GIC_NCPU and move GICState away from gic_internal.h. Signed-off-by: Andreas Färber --- hw/intc/arm_gic_common.c | 18 hw/intc/gic_internal.h | 80 +- include/hw/intc/arm_gic.h| 42 ++ include/hw/int

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-09-11 Thread Gabriel Kerneis
On Wed, Sep 11, 2013 at 04:42:35PM +0200, Stefan Hajnoczi wrote: > This patch automatically disables the pool when 'gthread' is used. This > allows the 'gthread' backend to work again (for example, > tests/test-coroutine completes successfully instead of hanging). > > Reported-by: Gabriel Kerneis

[Qemu-devel] [PATCH v4 03/24] a9mpcore: Embed GICState

2013-09-11 Thread Andreas Färber
From: Andreas Färber Prepares for conversion to QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index acbdab5..c57b149 100644 --- a/hw/cpu/a9mpc

Re: [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function

2013-09-11 Thread Richard Henderson
On 09/11/2013 07:10 AM, Alex Bligh wrote: > > > --On 11 September 2013 13:38:27 +0800 Fam Zheng wrote: > >> +switch (type) { >> +case MODULE_LOAD_BLOCK: >> +path = CONFIG_PREFIX "/qemu/block/"; >> +break; >> +case MODULE_LOAD_UI: >> +path = CONFIG_PREFIX "/qe

Re: [Qemu-devel] [PATCH 0/7] block: Error parameter for opening/creating images

2013-09-11 Thread Kevin Wolf
Am 10.09.2013 um 16:49 hat Max Reitz geschrieben: > This series adds an Error ** parameter to bdrv_open, bdrv_file_open, > bdrv_create and the respective functions provided by a block driver. > > This results in more specific error information than just -errno provided > to the user when opening o

[Qemu-devel] [PATCH v4 24/24] arm11mpcore: Split off RealView MPCore

2013-09-11 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/cpu/Makefile.objs | 1 + hw/cpu/arm11mpcore.c | 121 - hw/cpu/realview_mpcore.c | 139 +++ 3 files changed, 140 insertions(+), 121 deletions(-) create mode 100644 hw

Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak

2013-09-11 Thread Gabriel Kerneis
On Wed, Sep 11, 2013 at 04:01:50PM +0200, Paolo Bonzini wrote: > > ./configure --extra-cflags="-Dcoroutine_fn='__attribute__((coroutine_fn))'" > > Where does the shell read config-host.mak? Make does not need the quotes. I might have been confused about the shell vs. make interpreting the string

[Qemu-devel] [PATCH v4 05/24] a9mpcore: Embed A9SCUState

2013-09-11 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 16 ++-- hw/misc/a9scu.c | 18 +- include/hw/misc/a9scu.h | 31 +++ 3 files changed, 42 insertions(+), 23 deletions(-) cre

  1   2   3   >