[Qemu-devel] [PATCH V17 01/11] NUMA: move numa related code to new file numa.c

2013-12-04 Thread Wanlong Gao
Signed-off-by: Wanlong Gao --- Makefile.target | 2 +- cpus.c | 14 include/sysemu/cpus.h | 1 - include/sysemu/sysemu.h | 3 + numa.c | 182 vl.c| 139 +---

[Qemu-devel] [PATCH V17 00/11] Add support for binding guest numa nodes to host numa nodes

2013-12-04 Thread Wanlong Gao
As you know, QEMU can't direct it's memory allocation now, this may cause guest cross node access performance regression. And, the worse thing is that if PCI-passthrough is used, direct-attached-device uses DMA transfer between device and qemu process. All pages of the guest will be pinned by get_u

[Qemu-devel] [PATCH V17 02/11] NUMA: check if the total numa memory size is equal to ram_size

2013-12-04 Thread Wanlong Gao
If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI talb, then the guest will ignore the wrong ACPI table and recognize all memory to one node. It's buggy, we should check it to ensure that we write the right data to ACPI

[Qemu-devel] [PATCH V17 10/11] NUMA: add qmp command query-numa

2013-12-04 Thread Wanlong Gao
Add qmp command query-numa to show guest NUMA information. Reviewed-by: Luiz Capitulino Signed-off-by: Wanlong Gao --- numa.c | 66 qapi-schema.json | 36 +++ qmp-commands.hx | 49 +++

[Qemu-devel] [PATCH V17 09/11] NUMA: set guest numa nodes memory policy

2013-12-04 Thread Wanlong Gao
Set the guest numa nodes memory policies using the mbind(2) system call node by node. After this patch, we are able to set guest nodes memory policies through the QEMU options, this arms to solve the guest cross nodes memory access performance issue. And as you all know, if PCI-passthrough is used,

[Qemu-devel] [PATCH V17 06/11] NUMA: add "-numa mem," options

2013-12-04 Thread Wanlong Gao
Add "-numa mem," option like following as Paolo suggested: -numa mem,nodeid=0,size=1G This new option will make later coming memory hotplug better. We will use the new options to specify nodes memory info, and just remain "-numa node,mem=xx" as legacy. Reviewed-by: Laszlo Ersek Signed-off-

[Qemu-devel] [PATCH V17 07/11] NUMA: expand MAX_NODES from 64 to 128

2013-12-04 Thread Wanlong Gao
libnuma choosed 128 for MAX_NODES, so we follow libnuma here. Signed-off-by: Wanlong Gao --- include/sysemu/sysemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 291aa6a..807619e 100644 --- a/include/sysemu/sysemu.h +

[Qemu-devel] [PATCH V17 04/11] NUMA: convert -numa option to use OptsVisitor

2013-12-04 Thread Wanlong Gao
Signed-off-by: Wanlong Gao --- include/sysemu/sysemu.h | 3 +- numa.c | 148 +++- qapi-schema.json| 30 ++ vl.c| 11 +++- 4 files changed, 114 insertions(+), 78 deletions(-) diff --git a/include/

[Qemu-devel] [PATCH V17 03/11] NUMA: Add numa_info structure to contain numa nodes info

2013-12-04 Thread Wanlong Gao
Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. Reviewed-by: Eduardo Habkost Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao --- hw/i386/pc.c| 12 include/sysemu/sysemu.h |

[Qemu-devel] [PATCH V17 08/11] NUMA: parse guest numa nodes memory policy

2013-12-04 Thread Wanlong Gao
The memory policy setting format is like: policy={default|membind|interleave|preferred}[,relative=true],host-nodes=N-N And we are adding this setting as a suboption of "-numa mem,", the memory policy then can be set like following: -numa node,nodeid=0,cpus=0 \ -numa node,nodeid=1,cpus=1

[Qemu-devel] [PATCH V17 05/11] NUMA: introduce NumaMemOptions

2013-12-04 Thread Wanlong Gao
Signed-off-by: Wanlong Gao --- qapi-schema.json | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index db539b6..1043e57 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4223,7 +4223,8 @@ ## { 'union': 'NumaOption

[Qemu-devel] [PATCH V17 11/11] NUMA: convert hmp command info_numa to use qmp command query_numa

2013-12-04 Thread Wanlong Gao
Reviewed-by: Luiz Capitulino Signed-off-by: Wanlong Gao --- hmp.c | 57 + hmp.h | 1 + monitor.c | 21 + 3 files changed, 59 insertions(+), 20 deletions(-) diff --git a/hmp.c b/hmp.c index 32ee285..d6dedd2 1006

[Qemu-devel] [PATCH v8 1/5] vmstate: add VMSTATE_PTIMER_ARRAY

2013-12-04 Thread liguang
Signed-off-by: liguang --- include/migration/vmstate.h |4 savevm.c| 31 +++ 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 9d09e60..977cf52 100644 --- a/inc

[Qemu-devel] [PATCH v8 2/5] hw/timer: add allwinner a10 timer

2013-12-04 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |2 + hw/timer/allwinner-a10-pit.c | 253 ++ include/hw/timer/allwinner-a10-pit.h | 57 4 files changed, 314 insertions(+), 0 dele

[Qemu-devel] [PATCH v8 4/5] hw/arm: add allwinner a10 SoC support

2013-12-04 Thread liguang
Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/allwinner-a10.c | 77 include/hw/arm/allwinner-a10.h | 36 ++ 3 files changed, 114 insertions(+), 1 deletions(-) create mode 100644 hw/arm/allwinner-a1

[Qemu-devel] [PATCH v8 5/5] hw/arm: add cubieboard support

2013-12-04 Thread liguang
Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 52 ++ 2 files changed, 53 insertions(+), 1 deletions(-) create mode 100644 hw/arm/cubieboard.c diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs index b9e5

[Qemu-devel] [PATCH v8 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-04 Thread liguang
Signed-off-by: liguang --- hw/intc/Makefile.objs |1 + hw/intc/allwinner-a10-pic.c | 218 +++ include/hw/intc/allwinner-a10-pic.h | 40 +++ 3 files changed, 259 insertions(+), 0 deletions(-) create mode 100644 hw/intc/allwinner-a10

[Qemu-devel] [PATCH v8 0/5] add allwinner A10 SoC support

2013-12-04 Thread liguang
lay a foundation for allwinner A10 SoC with a cortex-a8 processor, and will add more devices later. v2: split timer and interrupt controller emulation into their corresponding files. v3: 1. change loader_start address 2. add 64-bit counter 3. fixup fail to clear interrup status

Re: [Qemu-devel] gpu and console chicken and egg

2013-12-04 Thread Gerd Hoffmann
On Mi, 2013-12-04 at 17:02 +1000, Dave Airlie wrote: > So I've hit a bit of a init ordering issue that I'm not sure how best to > solve, > > Just some background: > In order for the virt GPU and the UI layer (SDL or GTK etc) to > interact properly over OpenGL use, I have created and OpenGL provid

Re: [Qemu-devel] [PATCH v2 0/2]

2013-12-04 Thread Markus Armbruster
Your cover letter lacks a proper subject, and your patches lack proper threading. git-send-email threads properly (unless you mess up its configuration).

Re: [Qemu-devel] [PATCH 07/23] hw/pci/pcie_aer.c: fix buffer overruns on invalid state load

2013-12-04 Thread Michael S. Tsirkin
On Tue, Dec 03, 2013 at 08:59:52PM +, Peter Maydell wrote: > On 3 December 2013 20:41, Michael S. Tsirkin wrote: > > On Tue, Dec 03, 2013 at 06:30:46PM +, Peter Maydell wrote: > >> On 3 December 2013 16:28, Michael S. Tsirkin wrote: > >> > const VMStateDescription vmstate_pcie_aer_log =

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: Intel MPX

2013-12-04 Thread Paolo Bonzini
Il 04/12/2013 08:56, Liu, Jinsong ha scritto: > From 256484fd75d4eb4d248e5e0f493f16182da59dc2 Mon Sep 17 00:00:00 2001 > From: Liu Jinsong > Date: Wed, 4 Dec 2013 16:56:49 +0800 > Subject: [PATCH v2 2/2] target-i386: Intel MPX > > Add some MPX related definiation, and hardcode sizes and offsets >

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-04 Thread Paolo Bonzini
Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: > Normally the user is expected to eject DVD if it is not locked by > the guest. eject_device() makes few checks and calls bdrv_close() > if DVD is not in use. > > However it is still possible to eject DVD even if it is in use. > For that, QEMU

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: check for meduim on ALLOW_MEDIUM_REMOVAL

2013-12-04 Thread Paolo Bonzini
Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: > This prevents the guest from preventing DVD medium removal when > there is no medium. > > Without this, if the user has ejected a DVD, it is possible to > have a block device with an open tray, no media but locked. I need to check this again

[Qemu-devel] [PATCH V7 5/6] qemu-iotests: add test for snapshot in qemu-img convert

2013-12-04 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- tests/qemu-iotests/058 | 19 ++- tests/qemu-iotests/058.out | 12 2 files changed, 30 insertions(+), 1 deletions(-) diff --git a/tests/qemu-iotests/058 b/tests/qemu-iotests/058 index cf50857..14584cd 100755 --- a/tests/qemu-iote

[Qemu-devel] [PATCH V7 1/6] snapshot: distinguish id and name in load_tmp

2013-12-04 Thread Wenchao Xia
Since later this function will be used so improve it. The only caller of it now is qemu-img, and it is not impacted by introduce function bdrv_snapshot_load_tmp_by_id_or_name() that call bdrv_snapshot_load_tmp() twice to keep old search logic. bdrv_snapshot_load_tmp_by_id_or_name() return int to le

[Qemu-devel] [PATCH V7 4/6] qemu-img: add -l for snapshot in convert

2013-12-04 Thread Wenchao Xia
Now qemu-img convert have similar options as qemu-nbd for internal snapshot. Signed-off-by: Wenchao Xia --- qemu-img-cmds.hx |4 ++-- qemu-img.c | 44 +++- qemu-img.texi| 12 3 files changed, 45 insertions(+), 15 deletions(-)

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-04 Thread Markus Armbruster
Eric Blake writes: > On 12/03/2013 01:33 PM, Igor Mammedov wrote: > Also, is it worth adding asserts and/or compiler annotations to require that the Error **err argument of functions be non-NULL, to ensure that callers are always passing either a valid destination or one of the >>>

Re: [Qemu-devel] [PATCH] qemu-img create: add -o nocow option

2013-12-04 Thread Stefan Hajnoczi
On Mon, Dec 2, 2013 at 4:54 AM, Chunyan Liu wrote: > 2013/11/25 Kevin Wolf >> >> Am 21.11.2013 um 09:51 hat Stefan Hajnoczi geschrieben: >> > On Thu, Nov 21, 2013 at 11:33:56AM +0800, Chunyan Liu wrote: >> > > 2013/11/20 Stefan Hajnoczi >> > > >> > > > On Wed, Nov 20, 2013 at 04:50:29PM +0800, C

[Qemu-devel] [PATCH V7 0/6] export internal snapshot by qemu-nbd

2013-12-04 Thread Wenchao Xia
This series allow user to read internal snapshot's contents without qemu-img convert. V2: Address Stefan's comments: 02: add 'fall through' comments in the case statement. 03: add doc about the difference of internal snapshot and backing chain snapshot, which is used in previous '--snapshot'

[Qemu-devel] [PATCH V7 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2013-12-04 Thread Wenchao Xia
This case can't run when IMGPROTO=nbd, since it needs to create some internal snapshot which would fail for EOF write request, even when TEST_IMG is exported with "-f raw" in common.rc, so set _supported_proto to file. _require_command() is changed to tip what util is missing, instead of printing

[Qemu-devel] [PATCH V7 2/6] qemu-nbd: support internal snapshot export

2013-12-04 Thread Wenchao Xia
Now it is possible to directly export an internal snapshot, which can be used to probe the snapshot's contents without qemu-img convert. Signed-off-by: Wenchao Xia --- block/snapshot.c | 18 ++ include/block/snapshot.h |8 qemu-nbd.c | 46 ++

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-04 Thread Markus Armbruster
Paolo Bonzini writes: > Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: >> Normally the user is expected to eject DVD if it is not locked by >> the guest. eject_device() makes few checks and calls bdrv_close() >> if DVD is not in use. >> >> However it is still possible to eject DVD even if

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: check for meduim on ALLOW_MEDIUM_REMOVAL

2013-12-04 Thread Markus Armbruster
Paolo Bonzini writes: > Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: >> This prevents the guest from preventing DVD medium removal when >> there is no medium. >> >> Without this, if the user has ejected a DVD, it is possible to >> have a block device with an open tray, no media but lock

[Qemu-devel] [PATCH V7 6/6] qemu-nbd: add doc for option -f

2013-12-04 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- qemu-nbd.c|1 + qemu-nbd.texi |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index fe6053c..136e8c9 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -79,6 +79,7 @@ static void usage(const char *name) #endif "\n

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-12-04 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 11:00:24AM -0500, Paul Moore wrote: > > Developers will only be happy with seccomp if it's easy and rewarding to > > support/debug. > > Agreed. > > As a developer, how do you feel about the audit/syslog based approach I > mentioned earlier? I used the commands you posted

Re: [Qemu-devel] [RFC PATCH 03/21] target-arm: adjust TTBCR for TrustZone feature

2013-12-04 Thread Fedorov Sergey
On 12/03/2013 04:15 PM, Peter Crosthwaite wrote: On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov wrote: TTBCR has additional fields PD0 and PD1 when using Short-descriptor translation table format on a CPU with TrustZone feature support. Signed-off-by: Sergey Fedorov --- target-arm/helper.c

Re: [Qemu-devel] [RFC PATCH 04/21] target-arm: preserve RAO/WI bits of ARMv7 SCTLR

2013-12-04 Thread Fedorov Sergey
On 12/03/2013 04:17 PM, Peter Crosthwaite wrote: On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov wrote: From: Svetlana Fedoseeva Signed-off-by: Svetlana Fedoseeva Signed-off-by: Sergey Fedorov --- target-arm/helper.c |4 1 file changed, 4 insertions(+) diff --git a/target-arm/h

Re: [Qemu-devel] [Bug 1254940] [NEW] qemu-KVM guest OS occurs many ext3-fs errors after multiple forced shutdown

2013-12-04 Thread Stefan Hajnoczi
On Tue, Nov 26, 2013 at 01:59:41AM -, benjamin_zb wrote: > I met some filesysterm errors in a sles guest on KVM. My system environment > is: > HOST: >    suse 10, the kernel version is 2.6.32.43 >    Qemu-KVM 1.2 >    Libvirt 1.0 > guest OS: >    suse 10, the kernel version is 2.6.32.43 > VMs

Re: [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-04 Thread Fedorov Sergey
On 12/03/2013 04:51 PM, Peter Maydell wrote: On 3 December 2013 12:20, Peter Crosthwaite wrote: On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov wrote: From: Svetlana Fedoseeva Define CPU monitor mode. Adjust core registers banking. Adjust CPU VM state info. Provide CPU mode name for monitor

[Qemu-devel] [PATCH v2] qcow2: Zero-initialise first cluster for new images

2013-12-04 Thread Kevin Wolf
Strictly speaking, this is only required for has_zero_init() == false, but it's easy enough to just do a cluster-aligned write that is padded with zeros after the header. This fixes that after 'qemu-img create' header extensions are attempted to be parsed that are really just random leftover data.

Re: [Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone support

2013-12-04 Thread Fedorov Sergey
On 12/03/2013 12:48 PM, Sergey Fedorov wrote: This patch set implements a basic support of CPU core TrustZone feature. The following major functionalities are implemented: * CPU monitor mode * Separate code translation for each secure state * CPACR & NSACR co-processor access control

Re: [Qemu-devel] [PATCH v3] block: Close backing file early in bdrv_img_create

2013-12-04 Thread Stefan Hajnoczi
On Tue, Dec 03, 2013 at 02:57:52PM +0100, Max Reitz wrote: > Leaving the backing file open although it is not needed anymore can > cause problems if it is opened through a block driver which allows > exclusive access only and if the create function of the block driver > used for the top image (the

Re: [Qemu-devel] [Bug 1257334] [NEW] diffuse handling of image creation from another path

2013-12-04 Thread Stefan Hajnoczi
On Tue, Dec 03, 2013 at 03:22:28PM -, Florian Miksch wrote: Hi, This does not look like a bug. Please see the explanation below... Inlining Florian's reproducer script so we can discuss it via email: > #!/bin/bash > # This script does create a backing image and overlay to > # reproduce the r

Re: [Qemu-devel] [PATCH v2] qcow2: Zero-initialise first cluster for new images

2013-12-04 Thread Stefan Hajnoczi
On Wed, Dec 04, 2013 at 11:06:36AM +0100, Kevin Wolf wrote: > Strictly speaking, this is only required for has_zero_init() == false, > but it's easy enough to just do a cluster-aligned write that is padded > with zeros after the header. > > This fixes that after 'qemu-img create' header extensions

Re: [Qemu-devel] [RFC PATCH 03/21] target-arm: adjust TTBCR for TrustZone feature

2013-12-04 Thread Peter Crosthwaite
On Wed, Dec 4, 2013 at 7:50 PM, Fedorov Sergey wrote: > > On 12/03/2013 04:15 PM, Peter Crosthwaite wrote: >> >> On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov >> wrote: >>> >>> TTBCR has additional fields PD0 and PD1 when using Short-descriptor >>> translation table format on a CPU with TrustZon

Re: [Qemu-devel] [PATCH 00/23] qemu state loading issues

2013-12-04 Thread Michael S. Tsirkin
On Tue, Dec 03, 2013 at 06:24:24PM +, Peter Maydell wrote: > On 3 December 2013 16:28, Michael S. Tsirkin wrote: > > For example: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=588133#c8 > > https://bugzilla.redhat.com/show_bug.cgi?id=588133#c9 > > I get "not authorized" errors on

Re: [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-04 Thread Peter Crosthwaite
On Wed, Dec 4, 2013 at 8:01 PM, Fedorov Sergey wrote: > > On 12/03/2013 04:51 PM, Peter Maydell wrote: >> >> On 3 December 2013 12:20, Peter Crosthwaite >> wrote: >>> >>> On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov >>> wrote: From: Svetlana Fedoseeva Define CPU monitor mo

Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm

2013-12-04 Thread Peter Maydell
On 4 December 2013 00:48, Richard Henderson wrote: > On 12/04/2013 01:32 PM, Peter Maydell wrote: >> You're right that we can just make this function return the TCGv >> temp rather than making the caller pass one in. Are you suggesting >> the 64-bit case should return cpu_X[reg] rather than a copy

Re: [Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone support

2013-12-04 Thread Peter Crosthwaite
Hi Sergey, On Wed, Dec 4, 2013 at 8:08 PM, Fedorov Sergey wrote: > On 12/03/2013 12:48 PM, Sergey Fedorov wrote: >> >> This patch set implements a basic support of CPU core TrustZone feature. >> The >> following major functionalities are implemented: >>* CPU monitor mode >>* Separate code

Re: [Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone support

2013-12-04 Thread Peter Maydell
On 4 December 2013 10:08, Fedorov Sergey wrote: > On 12/03/2013 12:48 PM, Sergey Fedorov wrote: >> >> This patch set implements a basic support of CPU core TrustZone feature. > We'd like this patch series finally to be merged into mainstream. What > should be done to achieve this goal? I'd like

Re: [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-04 Thread Peter Maydell
On 4 December 2013 10:58, Peter Crosthwaite wrote: > So what im proposing is just a slightly more general patch. Is it > really any more complicated than just applying your change pattern for > the hyp mode? I think it would be, because of the wrinkle that hyp mode doesn't have a banked LR, so th

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: Intel MPX

2013-12-04 Thread Liu, Jinsong
> > Almost there. Migration (vmstate) is still missing. > Like this: == >From faead85c0dbe62da896e0ed9e165d98e10216968 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Wed, 4 Dec 2013 16:56:49 +0800 Subject: [PATCH 2/2] target-i386: Intel MPX Add some MPX related definiation,

Re: [Qemu-devel] [PATCH v8 4/5] hw/arm: add allwinner a10 SoC support

2013-12-04 Thread Peter Crosthwaite
On Wed, Dec 4, 2013 at 6:09 PM, liguang wrote: > Signed-off-by: liguang > --- > hw/arm/Makefile.objs |2 +- > hw/arm/allwinner-a10.c | 77 > > include/hw/arm/allwinner-a10.h | 36 ++ > 3 files changed, 114 insert

[Qemu-devel] [PATCH v8 1/6] target-arm: Move call to disas_vfp_insn out of disas_coproc_insn.

2013-12-04 Thread Will Newton
Floating point is an extension to the instruction set rather than a coprocessor, so call it directly from the ARM and Thumb decode functions. Signed-off-by: Will Newton Reviewed-by: Peter Maydell --- target-arm/translate.c | 32 +++- 1 file changed, 27 insertions(+),

[Qemu-devel] [PATCH v8 2/6] target-arm: Implement ARMv8 VSEL instruction.

2013-12-04 Thread Will Newton
This adds support for the VSEL floating point selection instruction which was added in ARMv8. Signed-off-by: Will Newton Reviewed-by: Peter Maydell --- target-arm/translate.c | 135 - 1 file changed, 134 insertions(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PATCH v8 6/6] target-arm: Implement ARMv8 SIMD VMAXNM and VMINNM instructions.

2013-12-04 Thread Will Newton
This adds support for the ARMv8 Advanced SIMD VMAXNM and VMINNM instructions. Signed-off-by: Will Newton --- target-arm/translate.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) Changes in v8: - Use VFP helper instead of adding a NEON specific one - Dr

[Qemu-devel] [PATCH v8 0/6] target-arm: Add support for VSEL and VMIN/MAXNM.

2013-12-04 Thread Will Newton
This series adds support for three new instructions added in ARMv8 - VSEL, VMINNM and VMAXNM. Will Newton (6): target-arm: Move call to disas_vfp_insn out of disas_coproc_insn. target-arm: Implement ARMv8 VSEL instruction. softfloat: Remove unused argument from MINMAX macro. softfloat: Add

[Qemu-devel] [PATCH v8 5/6] target-arm: Implement ARMv8 FP VMAXNM and VMINNM instructions.

2013-12-04 Thread Will Newton
This adds support for the ARMv8 floating point VMAXNM and VMINNM instructions. Signed-off-by: Will Newton Reviewed-by: Peter Maydell --- target-arm/helper.c| 25 + target-arm/helper.h| 5 + target-arm/translate.c | 50

[Qemu-devel] [PATCH v8 3/6] softfloat: Remove unused argument from MINMAX macro.

2013-12-04 Thread Will Newton
The nan_exp argument is not used, so remove it. Signed-off-by: Will Newton Reviewed-by: Peter Maydell --- fpu/softfloat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 7ba51b6..97bf627 100644 --- a/fpu/softfloat.c +++ b/fpu/sof

[Qemu-devel] [PATCH v8 4/6] softfloat: Add minNum() and maxNum() functions to softfloat.

2013-12-04 Thread Will Newton
Add floatnn_minnum() and floatnn_maxnum() functions which are equivalent to the minNum() and maxNum() functions from IEEE 754-2008. They are similar to min() and max() but differ in the handling of QNaN arguments. Signed-off-by: Will Newton --- fpu/softfloat.c | 32 ++

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-04 Thread Alexey Kardashevskiy
On 12/04/2013 08:33 PM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: >>> Normally the user is expected to eject DVD if it is not locked by >>> the guest. eject_device() makes few checks and calls bdrv_close() >>> if DVD is not in use.

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: check for meduim on ALLOW_MEDIUM_REMOVAL

2013-12-04 Thread Alexey Kardashevskiy
On 12/04/2013 08:35 PM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: >>> This prevents the guest from preventing DVD medium removal when >>> there is no medium. >>> >>> Without this, if the user has ejected a DVD, it is possible to >>

Re: [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-04 Thread Fedorov Sergey
On 12/04/2013 03:18 PM, Peter Maydell wrote: On 4 December 2013 10:58, Peter Crosthwaite wrote: So what im proposing is just a slightly more general patch. Is it really any more complicated than just applying your change pattern for the hyp mode? I think it would be, because of the wrinkle th

Re: [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-04 Thread Peter Maydell
On 4 December 2013 12:33, Fedorov Sergey wrote: > > On 12/04/2013 03:18 PM, Peter Maydell wrote: >> >> On 4 December 2013 10:58, Peter Crosthwaite >> wrote: >>> >>> So what im proposing is just a slightly more general patch. Is it >>> really any more complicated than just applying your change pat

[Qemu-devel] [PATCH] qemu-iotests: 074 fixups

2013-12-04 Thread Stefan Hajnoczi
A few things missing from the previous patch: * add 074 to the group file * label new output "074" instead of "048" * remove "qemu-io> " prompts from output (qemu.git/master merge conflict) Signed-off-by: Stefan Hajnoczi --- Fam: can I squash these missing things into your patch? tests/qe

Re: [Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone support

2013-12-04 Thread Fedorov Sergey
On 12/04/2013 03:13 PM, Peter Maydell wrote: On 4 December 2013 10:08, Fedorov Sergey wrote: On 12/03/2013 12:48 PM, Sergey Fedorov wrote: This patch set implements a basic support of CPU core TrustZone feature. We'd like this patch series finally to be merged into mainstream. What should be

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2013-12-04 Thread Eduardo Habkost
On Wed, Dec 04, 2013 at 04:50:59PM +1100, Alexey Kardashevskiy wrote: > On 12/04/2013 01:47 AM, Eduardo Habkost wrote: > > On Tue, Dec 03, 2013 at 02:30:48PM +0100, Andreas Färber wrote: > >> Am 03.12.2013 00:03, schrieb Alexey Kardashevskiy: > >>> On 12/03/2013 09:09 AM, Andreas Färber wrote: > >>

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: check for meduim on ALLOW_MEDIUM_REMOVAL

2013-12-04 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 12/04/2013 08:35 PM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: This prevents the guest from preventing DVD medium removal when there is no medium. Without this, if the user

Re: [Qemu-devel] [PATCH] qemu-iotests: 074 fixups

2013-12-04 Thread Fam Zheng
On 2013年12月04日 20:45, Stefan Hajnoczi wrote: A few things missing from the previous patch: * add 074 to the group file * label new output "074" instead of "048" * remove "qemu-io> " prompts from output (qemu.git/master merge conflict) Signed-off-by: Stefan Hajnoczi --- Fam: can I squa

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-04 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 12/04/2013 08:33 PM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: Normally the user is expected to eject DVD if it is not locked by the guest. eject_device() makes few checks and calls

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-12-04 Thread Eduardo Otubo
The existing approach clearly doesn't support the full range of options that users specify on the command-line. Bugs. It will get fixed in time with more testing/debugging. Eduardo is working on improving the testing and RH's QA folks are working hard to shake out the bugs too. I just poste

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-12-04 Thread Eduardo Otubo
On 12/04/2013 07:39 AM, Stefan Hajnoczi wrote: On Fri, Nov 22, 2013 at 11:00:24AM -0500, Paul Moore wrote: Developers will only be happy with seccomp if it's easy and rewarding to support/debug. Agreed. As a developer, how do you feel about the audit/syslog based approach I mentioned earlie

Re: [Qemu-devel] [PATCH v6 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback"

2013-12-04 Thread Stefan Hajnoczi
On Wed, Dec 04, 2013 at 09:06:57AM +0800, Fam Zheng wrote: > This series adds cache mode option in the iotests framework. Test cases are > updated to make use of cache mode and mask supported modes. > > v6: [05] Recover disappeared two lines. (Benoît) > Added Wenchao's reviewed-by lines to oth

Re: [Qemu-devel] [PATCH 3/5] Add vhostsock option

2013-12-04 Thread Stefan Hajnoczi
On Fri, Nov 29, 2013 at 08:52:24PM +0100, Antonios Motakis wrote: > @@ -91,15 +91,27 @@ static int vhost_net_get_fd(NetClientState *backend) > } > } > > -struct vhost_net *vhost_net_init(NetClientState *backend, int devfd, > - bool force) > +struct vhost_net

Re: [Qemu-devel] [PATCH 2/5] Add vhost-kernel and the vhost-user skeleton

2013-12-04 Thread Stefan Hajnoczi
On Fri, Nov 29, 2013 at 08:52:23PM +0100, Antonios Motakis wrote: > diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c > index 05de174..80defe4 100644 > --- a/hw/virtio/vhost-backend.c > +++ b/hw/virtio/vhost-backend.c > @@ -25,9 +25,18 @@ static int vhost_kernel_call(struct vhost_d

Re: [Qemu-devel] [RFC 0/5] Vhost and vhost-net support for userspace based backends

2013-12-04 Thread Stefan Hajnoczi
On Fri, Nov 29, 2013 at 08:52:21PM +0100, Antonios Motakis wrote: > In this patch series we would like to introduce our approach for putting a > virtio-net backend in an external userspace process. Our eventual target is to > run the network backend in the Snabbswitch ethernet switch, while receivi

Re: [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-12-04 Thread Stefan Hajnoczi
On Thu, Oct 10, 2013 at 05:07:18PM +0200, Paolo Bonzini wrote: > @@ -298,30 +278,31 @@ static void handle_notify(EventNotifier *e) > vring_disable_notification(s->vdev, &s->vring); > > for (;;) { > -head = vring_pop(s->vdev, &s->vring, iov, end, &out_num, > &in_num)

Re: [Qemu-devel] [PATCH 0/4] dataplane: use more of the generic virtio data structures, drop hostmem

2013-12-04 Thread Stefan Hajnoczi
On Thu, Oct 10, 2013 at 05:07:15PM +0200, Paolo Bonzini wrote: > Now that the memory API is thread-safe, we can use it in > virtio-blk-dataplane and replace hostmem.[ch]. This series does this, > and also changes the vring API to use VirtQueueElement (with an eye > towards migration). With this c

Re: [Qemu-devel] [PATCH 3/5] Add vhostsock option

2013-12-04 Thread Eric Blake
On 11/29/2013 12:52 PM, Antonios Motakis wrote: > Adding a new tap network backend option - vhostsock. It points > to a named unix domain socket, that will be used to communicate > with vhost-user backend. This is a temporary work around; in future > versions of this series vhost-user will be made

[Qemu-devel] [PATCH 04/32] tests: Fix schema parser test for in-tree build

2013-12-04 Thread Michael Roth
From: Markus Armbruster Commit 4f193e3 added the test, but screwed up in-tree builds (SRCDIR=.): the tests's output overwrites the expected output, and is thus compared to itself. Cc: qemu-sta...@nongnu.org Reported-by: Laszlo Ersek Reviewed-by: Andreas Färber Reviewed-by: Laszlo Ersek Signed

[Qemu-devel] [PATCH 05/32] tests: Update .gitignore for test-int128 and test-bitops

2013-12-04 Thread Michael Roth
From: Markus Armbruster Forgotten in commit 6046c62 and 3464700. Cc: qemu-sta...@nongnu.org Reviewed-by: Andreas Färber Reviewed-by: Laszlo Ersek Signed-off-by: Markus Armbruster Signed-off-by: Michael Tokarev (cherry picked from commit 9dbb52e862458935c250bac9e71d5a87da4e33e9) Conflicts:

[Qemu-devel] Patch Round-up for stable 1.6.2, freeze on 2013-12-06

2013-12-04 Thread Michael Roth
Hi everyone, The following new patches are queued for QEMU stable v1.6.2: https://github.com/mdroth/qemu/commits/stable-1.6-staging The release is planned for 2013-12-09: http://wiki.qemu.org/Planning/1.6 Please respond here or CC qemu-sta...@nongnu.org on any patches you think should be inclu

[Qemu-devel] [PATCH 07/32] bitops: Add rotate functions (rol8, ror8, ...)

2013-12-04 Thread Michael Roth
From: Stefan Weil These functions were copies from include/linux/bitopts.h. Signed-off-by: Stefan Weil Reviewed-by: Richard Henderson (cherry picked from commit 6aa25b4a7bb10c48c3054f268d5be98e42ea42c0) Signed-off-by: Michael Roth --- include/qemu/bitops.h | 80 +++

[Qemu-devel] [PATCH 01/32] char: move backends' io watch tag to CharDriverState

2013-12-04 Thread Michael Roth
From: Amit Shah All the backends implement an io watcher tag for callbacks. Move it to CharDriverState from each backend's struct to make accessing the tag from backend-neutral functions easier. This will be used later to cancel a callback on chardev detach from a frontend. CC: Reviewed-by: G

[Qemu-devel] [PATCH 06/32] tci: Add implementation of rotl_i64, rotr_i64

2013-12-04 Thread Michael Roth
From: Stefan Weil It is used by qemu-ppc64 when running Debian's busybox-static. Cc: qemu-stable Signed-off-by: Stefan Weil Reviewed-by: Richard Henderson (cherry picked from commit d285bf784b6234e994ce73c05c82c9fb6429df00) Signed-off-by: Michael Roth --- tcg/tci/tcg-target.c |1 - tci

[Qemu-devel] [PATCH 02/32] char: use common function to disable callbacks on chardev close

2013-12-04 Thread Michael Roth
From: Amit Shah This deduplicates code used a lot of times. CC: Reviewed-by: Gerd Hoffmann Signed-off-by: Amit Shah (cherry picked from commit 26da70c72524eb22c946ab19ec98a217b8252f7e) Signed-off-by: Michael Roth --- qemu-char.c | 62 ++

[Qemu-devel] [PATCH 08/32] misc: Use new rotate functions

2013-12-04 Thread Michael Roth
From: Stefan Weil Signed-off-by: Stefan Weil (cherry picked from commit 3df2b8fde949be86d8a78923c992fdd698d4ea4c) Signed-off-by: Michael Roth --- target-arm/iwmmxt_helper.c |2 +- tcg/optimize.c | 12 tci.c |8 3 files changed,

[Qemu-devel] [PATCH 32/32] rng-egd: offset the point when repeatedly read from the buffer

2013-12-04 Thread Michael Roth
From: Amos Kong The buffer content might be read out more than once, currently we just repeatedly read the first data block, buffer offset is missing. Cc: qemu-sta...@nongnu.org Signed-off-by: Amos Kong Message-id: 1385023371-8198-3-git-send-email-ak...@redhat.com Signed-off-by: Anthony Liguori

[Qemu-devel] [PATCH 12/32] audio: honor QEMU_AUDIO_TIMER_PERIOD instead of waking up every *nano* second

2013-12-04 Thread Michael Roth
From: Hans de Goede Now that we no longer have MIN_REARM_TIMER_NS a bug in the audio subsys has clearly shown it self by trying to make a timer fire every nano second. Note we have a similar problem in 1.6, 1.5 and older but there MIN_REARM_TIMER_NS limits the wakeups caused by audio being activ

[Qemu-devel] [PATCH 10/32] xen_disk: mark ioreq as mapped before unmapping in error case

2013-12-04 Thread Michael Roth
From: Matthew Daley Commit 4472beae modified the semantics of ioreq_{un,}map so that they are idempotent if called when they're not needed (ie., twice in a row). However, it neglected to handle the case where batch mapping is not being used (the default), and one of the grants fails to map. In th

[Qemu-devel] [PATCH 30/32] qdev-monitor: Unref device when device_add fails

2013-12-04 Thread Michael Roth
From: Stefan Hajnoczi qdev_device_add() leaks the created device upon failure. I suspect this problem crept in because qdev_free() unparents the device but does not drop a reference - confusing name. Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-

[Qemu-devel] [PATCH 31/32] pci: unregister vmstate_pcibus on unplug

2013-12-04 Thread Michael Roth
From: Bandan Das PCIBus registers a vmstate during init. Unregister it upon removal/unplug. Signed-off-by: Bandan Das Cc: qemu-sta...@nongnu.org Reviewed-by: Andreas Färber Signed-off-by: Michael S. Tsirkin (cherry picked from commit 5c397242d5d53c1adecce31817bb439383cf8228) Signed-off-by: M

[Qemu-devel] [PATCH 26/32] vfio-pci: Fix multifunction=on

2013-12-04 Thread Michael Roth
From: Alex Williamson When an assigned device is initialized it copies the device config space into the emulated config space. Unfortunately multifunction is setup prior to the device initfn and gets clobbered. We need to restore it just like pci-assign does. Cc: qemu-sta...@nongnu.org Signed-

[Qemu-devel] [PATCH 29/32] qdev-monitor: Fix crash when device_add is called with abstract driver

2013-12-04 Thread Michael Roth
From: Igor Mammedov User is able to crash running QEMU when following monitor command is called: device_add intel-hda-generic Crash is caused by assertion in object_initialize_with_type() when type is abstract. Checking if type is abstract before instance is created in qdev_device_add() allow

[Qemu-devel] [PATCH 28/32] qom: Fix memory leak in object_property_set_link()

2013-12-04 Thread Michael Roth
From: Vlad Yasevich Save the result of the call to object_get_canonical_path() so we can free it. Cc: qemu-sta...@nongnu.org Signed-off-by: Vlad Yasevich Reviewed-by: Amos Kong Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber (cherry picked from commit 2d3aa28cc2cf382aa04cd577e0be5

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-04 Thread Eric Blake
On 12/04/2013 02:11 AM, Markus Armbruster wrote: > No objection to asserting that the caller passed an error object when > the error object is the only way to signal failure. You can't force > your callers to check for failure, but the assertion could help prevent > accidental misuse. > > Assert

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-12-04 Thread Corey Bryant
On 12/04/2013 08:21 AM, Eduardo Otubo wrote: On 12/04/2013 07:39 AM, Stefan Hajnoczi wrote: On Fri, Nov 22, 2013 at 11:00:24AM -0500, Paul Moore wrote: Developers will only be happy with seccomp if it's easy and rewarding to support/debug. Agreed. As a developer, how do you feel about th

[Qemu-devel] [PATCH 03/32] char: remove watch callback on chardev detach from frontend

2013-12-04 Thread Michael Roth
From: Amit Shah If a frontend device releases the chardev (via unplug), the chr handlers are set to NULL via qdev's exit callbacks invoking qemu_chr_add_handlers(). If the chardev had a pending operation, a callback will be invoked, which will try to access data in the just-released frontend, ca

Re: [Qemu-devel] [PATCH V7 0/6] export internal snapshot by qemu-nbd

2013-12-04 Thread Stefan Hajnoczi
On Wed, Dec 04, 2013 at 05:10:53PM +0800, Wenchao Xia wrote: > This series allow user to read internal snapshot's contents without qemu-img > convert. > > V2: > Address Stefan's comments: > 02: add 'fall through' comments in the case statement. > 03: add doc about the difference of internal

  1   2   3   >