Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-11 Thread Michael S. Tsirkin
On Fri, Jan 10, 2014 at 08:31:36AM -0700, Alex Williamson wrote: > On Fri, 2014-01-10 at 14:55 +0200, Michael S. Tsirkin wrote: > > On Thu, Jan 09, 2014 at 03:42:22PM -0700, Alex Williamson wrote: > > > On Thu, 2014-01-09 at 23:56 +0200, Michael S. Tsirkin wrote: > > > > On Thu, Jan 09, 2014 at 12:

Re: [Qemu-devel] [PATCH v2] piix: fix 32bit pci hole

2014-01-11 Thread Michael S. Tsirkin
On Fri, Jan 10, 2014 at 09:28:39PM +0100, Laszlo Ersek wrote: > On 11/28/13 17:03, Laszlo Ersek wrote: > > Mike, > > > > On 11/27/13 12:57, Gerd Hoffmann wrote: > >> Make the 32bit pci hole start at end of ram, so all possible address > >> space is covered. Of course the firmware can use less tha

Re: [Qemu-devel] [PATCH V9 4/8] qcow2: return int for qcow2_free_clusters()

2014-01-11 Thread Max Reitz
On 05.01.2014 20:43, Wenchao Xia wrote: The return value can help caller check whether error happens, and it does not need to have *errp since the return value already tips what happend. Signed-off-by: Wenchao Xia --- block/qcow2-refcount.c |8 +--- block/qcow2.h |6 +++-

Re: [Qemu-devel] [PATCH V9 8/8] qemu-iotests: add test for qcow2 snapshot

2014-01-11 Thread Max Reitz
On 05.01.2014 20:43, Wenchao Xia wrote: This test will focus on the low level procedure of qcow2 snapshot operations, now it covers only the create operation. Overlap error paths are not checked since no good way to trigger those errors. Signed-off-by: Wenchao Xia --- tests/qemu-iotests/075

Re: [Qemu-devel] [PATCH V9 6/8] qcow2: rollback on fail in qcow2_snapshot_create()

2014-01-11 Thread Max Reitz
On 05.01.2014 20:43, Wenchao Xia wrote: A new variable *err_rollback is added to detect sub function's rollback failure. If one step in rollback procedure fails, following steps will be skipped, and the error message will be appended to errp. Signed-off-by: Wenchao Xia --- block/qcow2-snapsho

Re: [Qemu-devel] [PATCH V9 5/8] qcow2: full rollback on fail in qcow2_write_snapshots()

2014-01-11 Thread Max Reitz
On 05.01.2014 20:43, Wenchao Xia wrote: Header restore step is added, and old code section "fail" is renamed to "dealloc_sn_table" to tip better, now "fail" section does not rollback anything on disk. When one step in rollback fails, following steps will be skipped, to make sure no dangling point

Re: [Qemu-devel] Stuck at Win7 splash screen

2014-01-11 Thread Gabriel L. Somlo
So I (belatedly) found the thread already discussing this at http://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg02203.html I guess this should start working "out of the box" with qemu once again after the next round of bios blob updates :) Thanks, and sorry for the noise, --Gabriel On S

Re: [Qemu-devel] [PATCH V9 3/8] util: add error_append()

2014-01-11 Thread Max Reitz
On 05.01.2014 20:43, Wenchao Xia wrote: Some old code in error_set() is factored out, so this function can call it. Signed-off-by: Wenchao Xia --- include/qapi/error.h |6 ++ util/error.c | 44 +++- 2 files changed, 45 insertions(+),

[Qemu-devel] Stuck at Win7 splash screen

2014-01-11 Thread Gabriel L. Somlo
Gerd, I'm trying to install Windows 7 from the 32bit DVD image using this command line: bin/qemu-system-x86_64 -enable-kvm -m 4096 \ -cdrom ~/Downloads/Iso/Win7_32.iso -hda win7.img -boot once=d and the process freezes at the splash screen (black background, colored blobs flying around

Re: [Qemu-devel] [PATCH V9 2/8] qcow2: add error message in qcow2_write_snapshots()

2014-01-11 Thread Max Reitz
On 05.01.2014 20:43, Wenchao Xia wrote: The function still returns int since qcow2_snapshot_delete() will return the number. Signed-off-by: Wenchao Xia --- block/qcow2-snapshot.c | 43 +-- 1 files changed, 37 insertions(+), 6 deletions(-) Reviewed-

Re: [Qemu-devel] [PATCH v2 08/24] raw: Probe required direct I/O alignment

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: From: Paolo Bonzini Add a bs->request_alignment field that contains the required offset/length alignment for I/O requests and fill it in the raw block drivers. Use ioctls if possible, else see what alignment it takes for O_DIRECT to succeed. While at it,

Re: [Qemu-devel] [PATCH V9 1/8] snapshot: add parameter *errp in snapshot create

2014-01-11 Thread Max Reitz
On 05.01.2014 20:43, Wenchao Xia wrote: The return value is only used for error report before this patch, so change the function protype to return void. Signed-off-by: Wenchao Xia --- block/qcow2-snapshot.c| 30 +- block/qcow2.h |4 +++- blo

Re: [Qemu-devel] [PATCH v2 22/24] block: Make bdrv_pread() a bdrv_prwv_co() wrapper

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: Instead of implementing the alignment adjustment here, use the now existing functionality of bdrv_co_do_preadv(). Signed-off-by: Kevin Wolf --- block.c | 49 + 1 file changed, 13 insertions(+), 36 deletion

Re: [Qemu-devel] [PATCH v2 19/24] block: Allow wait_serialising_requests() at any point

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: We can only have a single wait_serialising_requests() call per request because otherwise we can run into deadlocks where requests are waiting for each other. The same is true when wait_serialising_requests() is not at the very beginning of a request, so that

Re: [Qemu-devel] [PATCH v2 21/24] block: Change coroutine wrapper to byte granularity

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- block.c | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v2 17/24] block: Generalise and optimise COR serialisation

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: Change the API so that specific requests can be marked serialising. Only these requests are checked for overlaps then. This means that during a Copy on Read operation, not all requests overlapping other requests are serialised any more, but only those that

Re: [Qemu-devel] [PATCH v2 24/24] iscsi: Set bs->request_alignment

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: From: Paolo Bonzini The iSCSI backend already gets the block size from the READ CAPACITY command it sends. Save it so that the generic block layer gets it too. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v2 18/24] block: Make overlap range for serialisation dynamic

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: Copy on Read wants to serialise with all requests touching the same cluster, so wait_serialising_requests() rounded to cluster boundaries. Other users like alignment RMW will have different requirements, though (requests touching the same sector), so make it

Re: [Qemu-devel] [PATCH v2 15/24] block: Allow waiting for overlapping requests between begin/end

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: Previously, it was not possible to use wait_for_overlapping_requests() between tracked_request_begin()/end() because it would wait for itself. Ignore the current request in the overlap check and run more of the bdrv_co_do_preadv/pwritev code with a BdrvTrac

Re: [Qemu-devel] [PATCH v2 20/24] block: Align requests in bdrv_co_do_pwritev()

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: This patch changes bdrv_co_do_pwritev() to actually be what its name promises. If requests aren't properly aligned, it performs a RMW. Requests touching the same block are serialised against the RMW request. Further optimisation of this is possible by diffe

Re: [Qemu-devel] [PATCH v2 11/24] block: Introduce bdrv_aligned_pwritev()

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: This separates the part of bdrv_co_do_writev() that needs to happen before the request is modified to match the backend alignment, and a part that needs to be executed afterwards and passes the request to the BlockDriver. Signed-off-by: Kevin Wolf --- bl

Re: [Qemu-devel] [PATCH v2 07/24] block: rename buffer_alignment to guest_block_size

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: From: Paolo Bonzini The alignment field is now set to the value that is promised to the guest, rather than required by the host. The next patches will make QEMU aware of the host-provided values, so make this clear. The alignment is also not about memory

Re: [Qemu-devel] [PATCH v2 12/24] block: write: Handle COR dependency after I/O throttling

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: First waiting for all COR requests to complete and calling the throttling function afterwards means that the request could be delayed and we still need to wait for the COR request even if it was issued only after the throttled write request. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 09/24] block: Introduce bdrv_aligned_preadv()

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: This separates the part of bdrv_co_do_readv() that needs to happen before the request is modified to match the backend alignment, and a part that needs to be executed afterwards and passes the request to the BlockDriver. Signed-off-by: Kevin Wolf --- blo

Re: [Qemu-devel] [PATCH v2 05/24] block: Detect unaligned length in bdrv_qiov_is_aligned()

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: For an O_DIRECT request to succeed, it's not only necessary that all base addresses in the qiov are aligned, but also that each length in it is aligned. Signed-off-by: Kevin Wolf Reviewed-by: Wenchao Xia --- block.c | 3 +++ 1 file changed, 3 insertion

Re: [Qemu-devel] [PATCH v2 06/24] block: Don't use guest sector size for qemu_blockalign()

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: bs->buffer_alignment is set by the device emulation and contains the logical block size of the guest device. This isn't something that the block layer should know, and even less something to use for determining the right alignment of buffers to be used for t

Re: [Qemu-devel] [PATCH v2 04/24] qemu_memalign: Allow small alignments

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: The functions used by qemu_memalign() require an alignment that is at least sizeof(void*). Adjust it if it is too small. Signed-off-by: Kevin Wolf Reviewed-by: Wenchao Xia --- util/oslib-posix.c | 5 + 1 file changed, 5 insertions(+) Reviewed-by:

Re: [Qemu-devel] [PATCH v2 03/24] block: Update BlockLimits when they might have changed

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: When reopening with different flags, or when backing files disappear from the chain, the limits may change. Make sure they get updated in these cases. Signed-off-by: Kevin Wolf Reviewed-by: Wenchao Xia --- block.c | 5 - block/stream.

Re: [Qemu-devel] [PATCH v2 02/24] block: Inherit opt_transfer_length

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: When there is a format driver between the backend, it's not guaranteed that exposing the opt_transfer_length for the format driver results in the optimal requests (because of fragmentation etc.), but it can't make things worse, so let's just do it. Signed-o

Re: [Qemu-devel] [PATCH v2 23/24] block: Make bdrv_pwrite() a bdrv_prwv_co() wrapper

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: Instead of implementing the alignment adjustment here, use the now existing functionality of bdrv_co_do_pwritev(). Signed-off-by: Kevin Wolf --- block.c | 64 +--- 1 file changed, 9 insertions(

Re: [Qemu-devel] [PATCH v2 01/24] block: Move initialisation of BlockLimits to bdrv_refresh_limits()

2014-01-11 Thread Max Reitz
On 13.12.2013 14:22, Kevin Wolf wrote: This function separates filling the BlockLimits from bdrv_open(), which allows it to call it from other operations which may change the limits (e.g. modifications to the backing file chain or bdrv_reopen) Signed-off-by: Kevin Wolf --- block.c

[Qemu-devel] [PATCH 2/3] linux-user: fixed getsockopt() optlen

2014-01-11 Thread pavel . zbitskiy
From: Pavel Zbitskiy optlen parameter of getsockopt() of type socklen_t* was read into variable of type socklen_t, that caused zeroing out of upper 4 bytes when running s390x on top of x86_64. This patch changes optlen type to abi_ulong. Signed-off-by: Pavel Zbitskiy --- linux-user/syscall.c |

[Qemu-devel] [PATCH 3/3] linux-user: fixed recvfrom() addrlen

2014-01-11 Thread pavel . zbitskiy
From: Pavel Zbitskiy addrlen parameter of recvfrom() of type socklen_t* was read into variable of type socklen_t, that caused zeroing out of upper 4 bytes when running s390x on top of x86_64. This patch changes addrlen type to abi_ulong. Signed-off-by: Pavel Zbitskiy --- linux-user/syscall.c |

[Qemu-devel] [PATCH 1/3] linux-user: fixed s390x clone() argument order

2014-01-11 Thread pavel . zbitskiy
From: Pavel Zbitskiy It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db, where TARGET_CLONE_BACKWARDS was specified instead of TARGET_CLONE_BACKWARDS2. Signed-off-by: Pavel Zbitskiy --- linux-user/s390x/syscall.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lin

[Qemu-devel] [PATCH 0/3] Fix networking for s390x-user

2014-01-11 Thread pavel . zbitskiy
Pavel Zbitskiy (3): linux-user: fixed s390x clone() argument order linux-user: fixed getsockopt() optlen linux-user: fixed recvfrom() addrlen linux-user/s390x/syscall.h | 2 +- linux-user/syscall.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [PATCH] target-i386: Fix CC_OP_CLR vs PF

2014-01-11 Thread Paolo Bonzini
Il 10/01/2014 21:39, Richard Henderson ha scritto: > Parity should be set for a zero result. > > Signed-off-by: Richard Henderson > --- > target-i386/cc_helper.c | 2 +- > target-i386/translate.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cc_helper.c

[Qemu-devel] [PATCH v2 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-11 Thread Beniamino Galvani
Signed-off-by: Beniamino Galvani --- hw/arm/allwinner-a10.c | 16 hw/arm/cubieboard.c|7 +++ include/hw/arm/allwinner-a10.h |3 +++ 3 files changed, 26 insertions(+) diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c index 4658e19..416

[Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-11 Thread Beniamino Galvani
This patch adds support for the Fast Ethernet MAC found on Allwinner SoCs, together with a basic emulation of Realtek RTL8201CP PHY. Since there is no public documentation of the Allwinner controller, the implementation is based on Linux kernel driver. Signed-off-by: Beniamino Galvani --- defau

[Qemu-devel] [PATCH v2 0/2] hw/arm: add ethernet support to Allwinner A10

2014-01-11 Thread Beniamino Galvani
This patch series adds support for the EMAC Fast Ethernet controller found on Allwinner SoCs to the Allwinner A10. v2: Address Peter Crosthwaite's comments: * Make phy address customizable through a property * Call qemu_flush_queued_packets() when rx becomes possible * Always create EM

Re: [Qemu-devel] [PATCH 11/13] mxs/imx23: Add the USB driver

2014-01-11 Thread Peter Crosthwaite
On Wed, Dec 11, 2013 at 11:56 PM, Michel Pollet wrote: > Add the USB IO block, and the USB PHY IO block. This just wraps > an ehci instance, and support some of the 'extra' mxs registers > > Signed-off-by: Michel Pollet > --- > hw/usb/Makefile.objs | 1 + > hw/usb/mxs_usb.c | 254 > ++

Re: [Qemu-devel] [PATCH 09/13] mxs/imx23: Add the RTC block

2014-01-11 Thread Peter Crosthwaite
On Wed, Dec 11, 2013 at 11:56 PM, Michel Pollet wrote: > Support for the RTC IO block on the imx23, enough to return > a valid date and make guest linux happy. > > Signed-off-by: Michel Pollet > --- > hw/timer/Makefile.objs | 1 + > hw/timer/mxs_rtc.c | 147 > +

Re: [Qemu-devel] [PATCH 08/13] mxs/imx23: Add SSP/SPI driver

2014-01-11 Thread Peter Crosthwaite
On Wed, Dec 11, 2013 at 11:56 PM, Michel Pollet wrote: > This implements the SSP port(s) of the mxs. Currently hardcoded for > the SD card interface, but as TODO it could rather easily be made > to be generic and support 'generic' SPI too. > It is geared toward working with DMA, as the linux drive

Re: [Qemu-devel] [PATCH 06/13] mxs/imx23: Add digctl driver

2014-01-11 Thread Peter Crosthwaite
On Thu, Jan 9, 2014 at 4:55 AM, Peter Maydell wrote: > On 8 January 2014 18:39, M P wrote: >> I will re-add the trace for both write and read and see if I can narrow the >> range down; it will be linux specific, tho, that's why I thought a >> 'catchall' block was more appropriate. I would sugges

Re: [Qemu-devel] [PATCH 06/13] mxs/imx23: Add digctl driver

2014-01-11 Thread Peter Crosthwaite
On Wed, Dec 11, 2013 at 11:56 PM, Michel Pollet wrote: > This implements just enough of the digctl IO block to allow > linux to believe it's running on (currently only) an imx23. > > Signed-off-by: Michel Pollet > --- > hw/arm/Makefile.objs | 1 + > hw/arm/imx23_digctl.c | 110 >

Re: [Qemu-devel] [PATCH 06/10] target-arm: A64: Add SIMD ZIP/UZP/TRN

2014-01-11 Thread Alex Bennée
r...@twiddle.net writes: > On 01/10/2014 09:12 AM, Peter Maydell wrote: >> +for (i = 0; i < elements; i++) { >> +switch (opcode) { >> +case 1: /* UZP1/2 */ >> +{ >> +int midpoint = elements / 2; >> +if (i < midpoint) { >> +read_v

Re: [Qemu-devel] [PATCH 05/13] mxs/imx23: Add the interrupt collector

2014-01-11 Thread Peter Crosthwaite
-- Forwarded message -- From: Michel Pollet Date: Wed, Dec 11, 2013 at 11:56 PM Subject: [Qemu-devel] [PATCH 05/13] mxs/imx23: Add the interrupt collector To: qemu-devel@nongnu.org Cc: Michel Pollet Implements the interrupt collector IO block Signed-off-by: Michel Pollet ---