Re: [Qemu-devel] [PATCH] opencores_eth: flush queue whenever can_receive can go from false to true

2014-02-03 Thread Paolo Bonzini
Il 03/02/2014 05:20, Max Filippov ha scritto: The following registers control whether MAC can receive frames: - MODER.RXEN bit that enables/disables receiver; - TX_BD_NUM register that specifies number of RX descriptors. Notify QEMU networking core when the MAC is ready to receive frames.

Re: [Qemu-devel] [PULL v4 05/12] milkymist-vgafb: swap pixel data in source buffer

2014-02-03 Thread Paolo Bonzini
Il 01/02/2014 18:57, Peter Maydell ha scritto: In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was eliminated. But we are reading from the target buffer a 16-bit value, which is in big-endian format. Therefore, swap the bytes if we are building for a little-endian

Re: [Qemu-devel] [PATCH 0/2] Use g_new() friends where that makes obvious sense

2014-02-03 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 31 January 2014 15:53, Markus Armbruster arm...@redhat.com wrote: PATCH 1/2 fixes a bug found by compiling the original PATCH 2/2. Evidence for my claim that PATCH 2/2 lets the compiler catch more type errors :) Markus Armbruster (2):

[Qemu-devel] qemu-iotest 077 does not terminate with VMDK

2014-02-03 Thread Peter Lieven
Hi, has anyone tried iotest 77 (RMW) with VMDK? for me it does not terminate. Peter

Re: [Qemu-devel] [PATCH 2/2] Use g_new() friends where that makes obvious sense

2014-02-03 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 01/31/2014 08:53 AM, Markus Armbruster wrote: g_new(T, n) is safer than g_malloc(sizeof(T) * n) for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors.

[Qemu-devel] GDB info registers vs. monitor info registers

2014-02-03 Thread Sebastian Huber
Hello, I have some trouble to implement a proper system reset for SPARC/LEON. It seems that a Qemu system reset doesn't propagate the state change thoroughly. (gdb) monitor system_reset (gdb) info registers g0 0x0 0 g1 0x40001fa8 1073749928 g2

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Gerd Hoffmann
Hi, ERROR:/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != -1) FAIL GTester: last random seed: R02S79ea313790bc9a8b21d9af5ed55c2fff (pid=5080) /i386/qom/pc:OK

Re: [Qemu-devel] [PATCH 0/2] Use g_new() friends where that makes obvious sense

2014-02-03 Thread Peter Maydell
On 3 February 2014 08:40, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 31 January 2014 15:53, Markus Armbruster arm...@redhat.com wrote: 186 files changed, 376 insertions(+), 415 deletions(-) No objection in principle, but I think this is going

[Qemu-devel] [PATCH] sparc/leon3: Initialize stack pointer

2014-02-03 Thread Sebastian Huber
A lot of real world LEON3 systems are shipped with the GRMON boot loader. This boot loader initializes the stack pointer with the end of RAM address. The application can use this to detect the RAM size of a particular board variant. Signed-off-by: Sebastian Huber

[Qemu-devel] [PATCHv9 2/5] qemu-iotests: change _supported_proto to file for various tests

2014-02-03 Thread Peter Lieven
all these tests do anything of the following and thus fail with any protocol other than file: - the tests use rm, cp or mv shell commands which only work on file - the tests use qcow2.py - the images construct new filenames (e.g. backing file names) and the logic is broken for anything else

[Qemu-devel] [PATCHv9 1/5] block: add native support for NFS

2014-02-03 Thread Peter Lieven
This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of the form: nfs://host/export/filename[?param=value[param2=value2[...]]] For example: qemu-img create -f

[Qemu-devel] [PATCHv9 0/5] block: add native support for NFS

2014-02-03 Thread Peter Lieven
This adds v9 of the NFS protocol driver + qemu-iotest adjustments. v8-v9: - change _supported_proto for qemu-iotests 071 072 from generic to file v7-v8: - bump libnfs requirement to 1.9.2 - renamed NFSRPC-status to NFSRPC-ret [Benoit] - avoid double invocation of nfs_client_close in

[Qemu-devel] [PATCHv9 4/5] qemu-iotests: enable test 016 and 025 to work with NFS protocol

2014-02-03 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- tests/qemu-iotests/016 |2 +- tests/qemu-iotests/025 |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/016 b/tests/qemu-iotests/016 index b87a32b..7ea9e94 100755 --- a/tests/qemu-iotests/016 +++

Re: [Qemu-devel] [PATCHv4 0/6] ui/vnc: update optimizations

2014-02-03 Thread Peter Lieven
On 08.01.2014 10:08, Peter Lieven wrote: this series includes several optimizations for the ui/vnc guest to server and server to client update cycles. comments/reviews appreciated. v3-v4: - patch 1,4,6 unchanged - patch 2: fix 2 missing changes from 16 - VNC_DIRTY_PIXELS_PER_BIT

[Qemu-devel] [PATCHv9 5/5] qemu-iotests: enable support for NFS protocol

2014-02-03 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- tests/qemu-iotests/common| 22 +++--- tests/qemu-iotests/common.rc |3 +++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index 8b4e22c..5795358 100644 ---

[Qemu-devel] [PATCHv9 3/5] qemu-iotests: blacklist test 020 for NFS protocol

2014-02-03 Thread Peter Lieven
reopening is currently not supported. Signed-off-by: Peter Lieven p...@kamp.de --- tests/qemu-iotests/020 |5 + 1 file changed, 5 insertions(+) diff --git a/tests/qemu-iotests/020 b/tests/qemu-iotests/020 index 73a0429..2f258dc 100755 --- a/tests/qemu-iotests/020 +++

Re: [Qemu-devel] 9pfs troubles (was Re: [PATCH 1/4] hw/9pfs: fix error handing in local_ioc_getversion())

2014-02-03 Thread Aneesh Kumar K.V
Michael S. Tsirkin m...@redhat.com writes: Haven't used 9pfs in a while. I thought these patches are a good time to play with it some more. I have encountered two issues. What I'm doing: host: qemu a75143eda2ddf581b51e96c000974bcdfe2cbd10. /scm/qemu/x86_64-softmmu/qemu-system-x86_64

Re: [Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support

2014-02-03 Thread Gerd Hoffmann
Hi, +switch (graphic_rotate) { +case 90: +if (evt-abs-axis == INPUT_AXIS_X) { +evt-abs-axis = INPUT_AXIS_Y; +} +if (evt-abs-axis == INPUT_AXIS_Y) { Need else here, same for case 270. Why? +evt-abs-axis = INPUT_AXIS_X;

Re: [Qemu-devel] [PATCH 06/42] input: qapi: define event types

2014-02-03 Thread Gerd Hoffmann
Hi, s/alot/a lot/ s/splitted/split/ Applied. +## +# @InputBtnEvent Should we spell this out? I'm okay with the abbreviation if it makes it easier to fit 80 columns, but Button is nicer to read than Btn. I'm sort-of following linux input layer convention here, which uses btn for

Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-02-03 Thread Kevin Wolf
Am 31.01.2014 um 22:37 hat Benoît Canet geschrieben: Le Friday 31 Jan 2014 à 21:32:34 (+0100), Max Reitz a écrit : On 28.01.2014 01:04, Benoît Canet wrote: Le Monday 27 Jan 2014 à 20:11:59 (+0100), Max Reitz a écrit : On 27.01.2014 15:36, Benoît Canet wrote: Le Friday 24 Jan 2014 à

[Qemu-devel] [PATCH v4 01/22] exec: Make tb_invalidate_phys_addr input an AS

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com No functional change. Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c| 3 ++- include/exec/exec-all.h | 2 +- target-xtensa/op_helper.c | 3 ++- translate-all.c | 4 ++-- 4 files changed, 7

[Qemu-devel] [PATCH v4 03/22] exec: Always initialize MemorySection address spaces

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exec.c b/exec.c index 8a90867..3814a7e 100644 --- a/exec.c +++ b/exec.c @@ -877,6 +877,7 @@ static void

[Qemu-devel] [PATCH v4 02/22] exec: Make iotlb_to_region input an AS

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- cputlb.c| 2 +- exec.c | 5 ++--- include/exec/exec-all.h | 2 +- include/exec/softmmu_template.h | 5 +++-- 4 files changed,

[Qemu-devel] [PATCH v4 04/22] exec: Make memory_region_section_get_iotlb use section AS

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 3814a7e..d8cfe52 100644 --- a/exec.c +++ b/exec.c @@ -781,7 +781,7 @@ hwaddr

Re: [Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support

2014-02-03 Thread Paolo Bonzini
Il 03/02/2014 10:42, Gerd Hoffmann ha scritto: Hi, +switch (graphic_rotate) { +case 90: +if (evt-abs-axis == INPUT_AXIS_X) { +evt-abs-axis = INPUT_AXIS_Y; +} +if (evt-abs-axis == INPUT_AXIS_Y) { Need else here, same for case 270. Why? Because

[Qemu-devel] [PATCH v4 00/22] Steps towards per CPU address-spaces

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Hi, I'm looking at modeling systems where multiple CPUs co-exist with different views of their attached buses/devs. With this series I'm trying to take some steps towards having an address-space per CPU. It's not complete but good enough for

[Qemu-devel] [PATCH v4 05/22] memory: Add MemoryListener to typedefs.h

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- include/exec/memory.h | 2 -- include/qemu/typedefs.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index

[Qemu-devel] [PATCH v4 07/22] exec: On AS changes, only flush affected CPU TLBs

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/exec.c b/exec.c index f299d06..a1d8bbe 100644 --- a/exec.c +++ b/exec.c @@ -1813,6 +1813,11 @@ static void

[Qemu-devel] [PATCH v4 10/22] exec: Make lduw_*_phys input an AddressSpace

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 18 +- hw/net/vmware_utils.h | 2 +- hw/ppc/spapr_hcall.c | 6 +++--- hw/s390x/css.c | 3 ++-

[Qemu-devel] [PATCH v4 06/22] cpu: Add per-cpu address space

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- cpus.c | 2 ++ cputlb.c| 7 --- exec.c | 27 +++ include/exec/exec-all.h

[Qemu-devel] [PATCH v4 08/22] exec: Make ldl_*_phys input an AddressSpace

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- cpu-exec.c| 5 +- exec.c| 19 --- hw/dma/pl080.c| 9 ++-- hw/dma/sun4m_iommu.c | 3 +-

[Qemu-devel] [PATCH v4 12/22] exec: Make stl_*_phys input an AddressSpace

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 19 + hw/net/vmware_utils.h | 2 +- hw/pci/msi.c | 2 +- hw/pci/msix.c | 2 +- hw/ppc/ppc405_uc.c |

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-02-03 Thread Kevin Wolf
Am 31.01.2014 um 21:07 hat Max Reitz geschrieben: So in summary, it looks technically correct, but I'm not sure about maintainability. If the problems are only for this intermediate state, I'm okay with leaving them as they are, but otherwise we should try and figure out something. You're

[Qemu-devel] [PATCH v4 11/22] exec: Make stq_*_phys input an AddressSpace

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 12 +++--- hw/alpha/dp264.c | 5 ++- hw/net/vmware_utils.h | 2 +- hw/ppc/spapr_hcall.c | 6 ++- hw/s390x/s390-virtio-bus.c |

Re: [Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support

2014-02-03 Thread Gerd Hoffmann
Hi, It looks like doing it right for relative is easy: But what is the point when this isn't used anyway? In what sense it is not used? Old code is obviously broken for the relative case. Seems to be used by hw/arm/spitz.c, which probably emulates a absolute pointing device. Machine

[Qemu-devel] [PATCH v4 09/22] exec: Make ldq/ldub_*_phys input an AddressSpace

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c| 22 +++ hw/alpha/typhoon.c| 2 +- hw/display/sm501.c| 1 + hw/display/sm501_template.h | 2 +-

[Qemu-devel] [PATCH v4 17/22] exec: Make cpu_memory_rw_debug use the CPUs AS

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/exec.c b/exec.c index 7045f76..8c05087 100644 --- a/exec.c +++ b/exec.c @@ -2717,11 +2717,11 @@

[Qemu-devel] [PATCH v4 18/22] memory: Add address_space_find_by_name()

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- include/exec/memory.h | 9 + memory.c | 12 translate-all.c | 10 -- 3 files changed, 29 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v4 13/22] exec: Make stl_phys_notdirty input an AddressSpace

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c| 4 ++-- hw/arm/boot.c | 5 +++-- hw/arm/highbank.c | 6 +++--- include/exec/cpu-common.h | 2 +- target-i386/helper.c | 16

[Qemu-devel] [PATCH v4 20/22] cpu: Add address-space property

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- qom/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qom/cpu.c b/qom/cpu.c index 9d62479..fc6dbff 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -24,6 +24,7 @@ #include

[Qemu-devel] [PATCH v4 21/22] petalogix-ml605: Create the CPU with object_new()

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com This is to allow future patches to set properties before cpu::realize(). Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- hw/microblaze/petalogix_ml605_mmu.c | 7 ++- 1 file changed,

[Qemu-devel] [PATCH v4 14/22] exec: Make stw_*_phys input an AddressSpace

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 20 ++-- hw/net/vmware_utils.h | 2 +- hw/ppc/ppc405_uc.c | 2 +- hw/ppc/spapr_hcall.c | 4 ++-- hw/s390x/css.c

[Qemu-devel] [PATCH v4 15/22] exec: Make stb_phys input an AddressSpace

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 6 +++--- hw/net/vmware_utils.h | 2 +- hw/ppc/ppc405_uc.c | 10 +- hw/ppc/spapr_hcall.c | 6 +++---

[Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-03 Thread Chen Gang
We can not assume 'path' + 'ctx-fs_root' must be less than MAX_PATH, so need use snprintf() instead of sprintf(). And also recommend to use ARRAY_SIZE instead of hard code macro for an array size in snprintf(). Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- hw/9pfs/virtio-9p-local.c | 9

[Qemu-devel] [PATCH v4 19/22] qdev: Add qdev property type for AddressSpaces

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- hw/core/qdev-properties-system.c | 8 ++ hw/core/qdev-properties.c| 54 include/hw/qdev-properties.h | 5

[Qemu-devel] [PATCH v4 22/22] petalogix-ml605: Make the LMB visible only to the CPU

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- hw/microblaze/petalogix_ml605_mmu.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/hw/microblaze/petalogix_ml605_mmu.c

Re: [Qemu-devel] [PATCH 03/10] block: Make bdrv_file_open() static

2014-02-03 Thread Kevin Wolf
Am 31.01.2014 um 21:20 hat Max Reitz geschrieben: On 29.01.2014 14:26, Kevin Wolf wrote: Am 26.01.2014 um 20:02 hat Max Reitz geschrieben: Add the bdrv_open() option BDRV_O_PROTOCOL which results in passing the call to bdrv_file_open(). Additionally, make bdrv_file_open() static and therefore

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Stefan Hajnoczi
On Fri, Jan 31, 2014 at 12:07:34AM +, Peter Maydell wrote: On 21 November 2013 11:03, Stefan Hajnoczi stefa...@redhat.com wrote: GLib uses abort(3) to exit failed test cases. As a result, the pid file and UNIX domain sockets for a running test are leaked upon failure. Since abort(3)

[Qemu-devel] [PATCH v4 16/22] exec: Make cpu_physical_memory_write_rom input an AS

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c| 15 --- hw/core/loader.c | 3 ++- hw/intc/apic.c| 3 ++- hw/sparc/sun4m.c | 3 ++- include/exec/cpu-common.h |

Re: [Qemu-devel] [PATCH] opencores_eth: flush queue whenever can_receive can go from false to true

2014-02-03 Thread Stefan Hajnoczi
On Mon, Feb 03, 2014 at 08:20:02AM +0400, Max Filippov wrote: The following registers control whether MAC can receive frames: - MODER.RXEN bit that enables/disables receiver; - TX_BD_NUM register that specifies number of RX descriptors. Notify QEMU networking core when the MAC is ready to

Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config check.

2014-02-03 Thread Daniel P. Berrange
On Mon, Feb 03, 2014 at 03:26:15PM +1100, Chris Johns wrote: Building against with a recent glib in a custom prefix fails because the gthread cflags in the pkg-config file do not have the correct path while the glib pc file does. Signed-off-by: Chris Johns chr...@rtems.org --- configure |

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Peter Maydell
On 3 February 2014 09:54, Stefan Hajnoczi stefa...@redhat.com wrote: I still think we should merge these patches :). Are you happy to merge them? They look like they're fixing a bug to me, so yes. You could make my life easier by arranging for them to appear in a pull request... thanks -- PMM

Re: [Qemu-devel] qemu-iotest 077 does not terminate with VMDK

2014-02-03 Thread Kevin Wolf
Am 03.02.2014 um 09:44 hat Peter Lieven geschrieben: Hi, has anyone tried iotest 77 (RMW) with VMDK? for me it does not terminate. I have a patch for that (077 should be raw-only), but apparently I forgot to send it out. I'll do that now. Kevin

[Qemu-devel] [PATCH] qemu-iotest: Make 077 raw-only

2014-02-03 Thread Kevin Wolf
The qemu-io command sequences make the assumption that an unaligned request on the format layer will be unaligned on the blkdebug layer as well. This doesn't necessarily hold true for drivers other than raw. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/077 | 2 +- 1 file

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-03 Thread Daniel P. Berrange
On Mon, Feb 03, 2014 at 06:00:42PM +0800, Chen Gang wrote: We can not assume 'path' + 'ctx-fs_root' must be less than MAX_PATH, so need use snprintf() instead of sprintf(). And also recommend to use ARRAY_SIZE instead of hard code macro for an array size in snprintf(). In the event that

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-03 Thread Chen Gang
On 02/03/2014 06:34 PM, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 06:00:42PM +0800, Chen Gang wrote: We can not assume 'path' + 'ctx-fs_root' must be less than MAX_PATH, so need use snprintf() instead of sprintf(). And also recommend to use ARRAY_SIZE instead of hard code macro for an

Re: [Qemu-devel] [PATCH 6/6] linux-user: Fix trampoline code for CRIS

2014-02-03 Thread Riku Voipio
On Sun, Feb 02, 2014 at 03:04:52AM +, edgar.igles...@gmail.com wrote: From: Stefan Weil s...@weilnetz.de __put_user can write bytes, words (2 bytes) or longwords (4 bytes). Here obviously words should have been written, but bytes were written, so values like 0x9c5f were truncated to

[Qemu-devel] [PATCH v4 2/5] pcihp: make PCI hotplug mmio handlers indifferent to PCI_HOTPLUG_ADDR

2014-02-03 Thread Igor Mammedov
... removes dependency of mmio handler on PCI_HOTPLUG_ADDR. It will be needed in case of Q35 where base could be different. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/pcihp.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH v4 1/5] pcihp: replace enable|disable_device() with oneliners

2014-02-03 Thread Igor Mammedov
enable_device() and disable_device() functions aren't reused anywere, so replace them with respective oneliners at call sites. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/pcihp.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH v4 3/5] pcihp: make pci_read() mmio calback compatible with legacy ACPI hotplug

2014-02-03 Thread Igor Mammedov
due to recent change introduced by: pcihp: reduce number of device check events 'up' field is cleared right after it's read. This is incompatible with legacy BIOS ACPI code where PCNF ACPI method reads this field 32 times. To make pci_read mmio callback compatible with legacy 'up' behavior,

[Qemu-devel] [PATCH v4 0/5] pc: make ACPI pcihp more reusable

2014-02-03 Thread Igor Mammedov
changes since v3: - keep acpi-pci-hotplug-with-bridge-support property and pass its value to acpi_pcihp_init() to init internal .legacy_piix field. changes since v2: - rename 'use_acpi_pci_hotplug' field to 'legacy_piix' and corresponding properties - drop excessive checks for legacy

[Qemu-devel] [PATCH v4 5/5] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug

2014-02-03 Thread Igor Mammedov
reduces acpi PCI hotplug code duplication by ~200LOC Signed-off-by: Igor Mammedov imamm...@redhat.com --- v3: - remove exessive checks for compat mode - replace up/down fields of pci_status with corresponding fields form AcpiPciHpPciStatus in vmstate wich allow to remove extra 50 LOC of

[Qemu-devel] [PATCH v4 4/5] pcihp: remove unused AcpiPciHpPciStatus.device_present field

2014-02-03 Thread Igor Mammedov
Remove now unused 'device_present' field wich was obsoleted by patch pcihp: reduce number of device check events Signed-off-by: Igor Mammedov imamm...@redhat.com --- include/hw/acpi/pcihp.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/hw/acpi/pcihp.h

Re: [Qemu-devel] 9pfs troubles (was Re: [PATCH 1/4] hw/9pfs: fix error handing in local_ioc_getversion())

2014-02-03 Thread Michael S. Tsirkin
On Mon, Feb 03, 2014 at 03:05:10PM +0530, Aneesh Kumar K.V wrote: Michael S. Tsirkin m...@redhat.com writes: Haven't used 9pfs in a while. I thought these patches are a good time to play with it some more. I have encountered two issues. What I'm doing: host: qemu

Re: [Qemu-devel] [PATCH 1/6] cris: Add a CRISv32 default any CPU for user mode emulation

2014-02-03 Thread Riku Voipio
On Sun, Feb 02, 2014 at 03:04:47AM +, edgar.igles...@gmail.com wrote: From: Edgar E. Iglesias edgar.igles...@xilinx.com This is not a regression, but my static busybox sample I have fails to run with -cpu crisv32. -cpu crisv11 works a little better, but most syscalls will blow up. Now it is

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Andreas Färber
Am 03.02.2014 10:54, schrieb Stefan Hajnoczi: On Fri, Jan 31, 2014 at 12:07:34AM +, Peter Maydell wrote: On 21 November 2013 11:03, Stefan Hajnoczi stefa...@redhat.com wrote: GLib uses abort(3) to exit failed test cases. As a result, the pid file and UNIX domain sockets for a running test

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Peter Maydell
On 3 February 2014 11:10, Andreas Färber afaer...@suse.de wrote: As an explanation, the temporary files contain the PID. When they remain behind due to test failure *and* the PID wraps around and file names thus happen to match, the error was triggered, and thereby not on each run but

Re: [Qemu-devel] [PATCH 1/6] cris: Add a CRISv32 default any CPU for user mode emulation

2014-02-03 Thread Andreas Färber
Hi, Am 02.02.2014 04:04, schrieb edgar.igles...@gmail.com: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-cris/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-cris/cpu.c b/target-cris/cpu.c

Re: [Qemu-devel] [PATCH V10 06/13] quorum: Add quorum mechanism.

2014-02-03 Thread Benoît Canet
Le Saturday 01 Feb 2014 à 00:04:01 (+0100), Max Reitz a écrit : On 28.01.2014 17:52, Benoît Canet wrote: From: Benoît Canet ben...@irqsave.net Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/Makefile.objs | 2 +-

Re: [Qemu-devel] [PATCH V10 09/13] quorum: Add quorum_co_get_block_status.

2014-02-03 Thread Benoît Canet
Le Sunday 02 Feb 2014 à 22:44:07 (+0100), Max Reitz a écrit : On 28.01.2014 17:52, Benoît Canet wrote: From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 67 ++ 1 file

Re: [Qemu-devel] [PATCH] hw/xtensa: add support for ML605 and KC705 FPGA board

2014-02-03 Thread Andreas Färber
Am 02.02.2014 03:31, schrieb Max Filippov: Signed-off-by: Max Filippov jcmvb...@gmail.com --- hw/xtensa/xtensa_lx60.c | 51 + 1 file changed, 47 insertions(+), 4 deletions(-) While I can't check the new numbers, the refactoring looks sane,

Re: [Qemu-devel] [PATCH V10 10/13] quorum: Add quorum_co_flush().

2014-02-03 Thread Benoît Canet
Le Sunday 02 Feb 2014 à 23:02:57 (+0100), Max Reitz a écrit : On 28.01.2014 17:52, Benoît Canet wrote: From: Benoît Canet ben...@irqsave.net Makes a vote to select error if any. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 34 ++

Re: [Qemu-devel] [BUGFIX][PATCH v2] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

2014-02-03 Thread Stefano Stabellini
On Wed, 15 Jan 2014, Paolo Bonzini wrote: Il 03/01/2014 03:12, Don Slutz ha scritto: Adjust TMPO and added TMPB, TMPL, and TMPA. libtool needs the names to be fixed (TMPB). Add new functions do_libtool and libtool_prog. Add check for broken gcc and libtool. Signed-off-by: Don

Re: [Qemu-devel] [PATCH 1/6] cris: Add a CRISv32 default any CPU for user mode emulation

2014-02-03 Thread Edgar E. Iglesias
On Mon, Feb 03, 2014 at 01:02:34PM +0200, Riku Voipio wrote: On Sun, Feb 02, 2014 at 03:04:47AM +, edgar.igles...@gmail.com wrote: From: Edgar E. Iglesias edgar.igles...@xilinx.com This is not a regression, but my static busybox sample I have fails to run with -cpu crisv32. -cpu crisv11

Re: [Qemu-devel] [PATCH V10 12/13] quorum: Add quorum_open() and quorum_close().

2014-02-03 Thread Benoît Canet
Le Monday 03 Feb 2014 à 00:09:28 (+0100), Max Reitz a écrit : On 28.01.2014 17:52, Benoît Canet wrote: From: Benoît Canet ben...@irqsave.net Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.raw,\ file.children.0.node-name=1.raw,\

Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

2014-02-03 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 10.01.2014 14:31, schrieb arm...@redhat.com: From: Markus Armbruster arm...@redhat.com Get available machines via QMP instead of hardcoding a list that's perpetually out of date. A few machines don't work out of the box: * Several ppcemb

Re: [Qemu-devel] [PATCH V10 12/13] quorum: Add quorum_open() and quorum_close().

2014-02-03 Thread Benoît Canet
Le Monday 03 Feb 2014 à 00:09:28 (+0100), Max Reitz a écrit : On 28.01.2014 17:52, Benoît Canet wrote: From: Benoît Canet ben...@irqsave.net Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.raw,\ file.children.0.node-name=1.raw,\

[Qemu-devel] Improving patch tracking - something like gerrit?

2014-02-03 Thread Mark Cave-Ayland
Hi all, It should be fairly evident to most people that the volume of patches flowing through the qemu-devel mailing list is continually increasing, and it is becoming increasingly difficult to track which patches have been applied over time. This is particularly a problem where patchsets

Re: [Qemu-devel] [PATCH V10 12/13] quorum: Add quorum_open() and quorum_close().

2014-02-03 Thread Benoît Canet
Le Monday 03 Feb 2014 à 13:21:18 (+0100), Benoît Canet a écrit : Le Monday 03 Feb 2014 à 00:09:28 (+0100), Max Reitz a écrit : On 28.01.2014 17:52, Benoît Canet wrote: From: Benoît Canet ben...@irqsave.net Example of command line: -drive if=virtio,file.driver=quorum,\

[Qemu-devel] KVM call agenda for 2014-02-04

2014-02-03 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. * Should we change anything to get more people to sign for the call? There hasn't been a call in quite a long time. Ideas? Thanks, Juan. Call details: 09:00 AM to 10:00 AM EDT Every two weeks If you need phone number details,

[Qemu-devel] Query regarding Iotrhead

2014-02-03 Thread Ayaz Akram
While debugging using gdb, I found that the interrupt related flow is not handled in io thread i.e. on using info thread, I found: Thread 2(iothread) is at __lll_lock_wait() while Thread 1 is at qemu_set_irq(in irq.c).. Initially I thought that this interrupt related

[Qemu-devel] [PULL 00/01] seccomp: adding new syscalls to the whitelist

2014-02-03 Thread Eduardo Otubo
The following changes since commit 2f61120c10da9128357510debc8e66880cd2bfdc: Merge remote-tracking branch 'qmp-unstable/queue/qmp' into staging (2014-02-01 23:32:31 +) are available in the git repository at: git://github.com/otubo/qemu.git seccomp Felix Geyer (1): seccomp: add

[Qemu-devel] [PULL 01/01] seccomp: add kill() to the syscall whitelist

2014-02-03 Thread Eduardo Otubo
From: Paul Moore pmo...@redhat.com The kill() syscall is triggered with the following command: # qemu -sandbox on -monitor stdio \ -device intel-hda -device hda-duplex -vnc :0 The resulting syslog/audit message: # ausearch -m SECCOMP time-Wed Nov 20 09:52:08 2013 type=SECCOMP

Re: [Qemu-devel] Improving patch tracking - something like gerrit?

2014-02-03 Thread Peter Maydell
On 3 February 2014 12:45, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: It should be fairly evident to most people that the volume of patches flowing through the qemu-devel mailing list is continually increasing, and it is becoming increasingly difficult to track which patches have been

Re: [Qemu-devel] [PATCHv9 1/5] block: add native support for NFS

2014-02-03 Thread Kevin Wolf
Am 03.02.2014 um 10:26 hat Peter Lieven geschrieben: This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of the form:

Re: [Qemu-devel] [PATCH 1/6] cris: Add a CRISv32 default any CPU for user mode emulation

2014-02-03 Thread Edgar E. Iglesias
On Mon, Feb 03, 2014 at 12:44:03PM +0100, Andreas Färber wrote: Hi, Am 02.02.2014 04:04, schrieb edgar.igles...@gmail.com: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-cris/cpu.c | 7 +++ 1 file

[Qemu-devel] [PATCH v2] cris: Add any as alias for crisv32 in user emulation

2014-02-03 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- Notes (cl): v1 - v2: Implement as an alias rather than as QOM type. (AF) target-cris/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target-cris/cpu.c

Re: [Qemu-devel] [PATCHv9 0/5] block: add native support for NFS

2014-02-03 Thread Kevin Wolf
Am 03.02.2014 um 10:26 hat Peter Lieven geschrieben: This adds v9 of the NFS protocol driver + qemu-iotest adjustments. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] Improving patch tracking - something like gerrit?

2014-02-03 Thread Daniel P. Berrange
On Mon, Feb 03, 2014 at 12:45:31PM +, Mark Cave-Ayland wrote: Hi all, It should be fairly evident to most people that the volume of patches flowing through the qemu-devel mailing list is continually increasing, and it is becoming increasingly difficult to track which patches have been

[Qemu-devel] [PATCH 1/3] glib: move g_poll() replacement into glib-compat.h

2014-02-03 Thread Stefan Hajnoczi
We have a dedicated header file for wrappers to smooth over glib version differences. Move the g_poll() definition into glib-compat.h for consistency. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/glib-compat.h | 12 include/qemu-common.h | 12 2 files

[Qemu-devel] [PATCH 0/3] glib: move compat functions into glib-compat.h

2014-02-03 Thread Stefan Hajnoczi
glib has deprecated APIs like GStaticMutex, g_thread_create(), and others. In QEMU support both old and new APIs since using deprecated APIs would flood us with warnings but legacy distros must continue to build the QEMU source code. This patch series reduces ifdefs by moving glib compat

[Qemu-devel] [PATCH 3/3] glib: add compat wrapper for GStaticMutex

2014-02-03 Thread Stefan Hajnoczi
Avoid duplicating ifdefs for the deprecated GStaticMutex API by introducing compat_g_static_mutex_*() in glib-compat.h. GStaticMutex users should use the compat API to avoid dealing with deprecation. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- coroutine-gthread.c | 13 +++--

[Qemu-devel] [PATCH 2/3] glib: add g_thread_new() compat function

2014-02-03 Thread Stefan Hajnoczi
Implement g_thread_new() in terms of the deprecated g_thread_create(). The API was changed in glib 2.31.0. The compat function allows us to write modern code and avoid ifdefs. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- coroutine-gthread.c | 13 +++-- include/glib-compat.h

Re: [Qemu-devel] [PATCH v4 0/5] pc: make ACPI pcihp more reusable

2014-02-03 Thread Michael S. Tsirkin
On Mon, Feb 03, 2014 at 11:44:56AM +0100, Igor Mammedov wrote: changes since v3: - keep acpi-pci-hotplug-with-bridge-support property and pass its value to acpi_pcihp_init() to init internal .legacy_piix field. changes since v2: - rename 'use_acpi_pci_hotplug' field to 'legacy_piix'

[Qemu-devel] [PATCH] block: Fail gracefully with missing filename

2014-02-03 Thread Kevin Wolf
This fixes a regression introduced in commit 2a05cbe42 ('block: Allow block devices without files'): $ qemu-system-x86_64 -drive driver=file qemu-system-x86_64: block.c:892: bdrv_open_common: Assertion `!drv-bdrv_needs_filename || filename != ((void *)0)' failed. Now the respective check must be

Re: [Qemu-devel] [PATCH v2] cris: Add any as alias for crisv32 in user emulation

2014-02-03 Thread Andreas Färber
Am 03.02.2014 14:23, schrieb Edgar E. Iglesias: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- Notes (cl): v1 - v2: Implement as an alias rather than as QOM type. (AF) Reviewed-by: Andreas Färber afaer...@suse.de

Re: [Qemu-devel] [PATCH 7/8] roms: update vgabios binaries

2014-02-03 Thread Paolo Bonzini
Il 05/01/2014 12:45, Jan Kiszka ha scritto: On 2014-01-05 12:26, Paolo Bonzini wrote: Il 05/01/2014 10:35, Jan Kiszka ha scritto: On 2013-12-06 10:35, Gerd Hoffmann wrote: This also switches from lgplvgabios to seavgabios. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

Re: [Qemu-devel] [PATCH 7/8] roms: update vgabios binaries

2014-02-03 Thread Gerd Hoffmann
Hi, Confirmed, win7 boots fine again with current seabios.git master. So please update qemu. Ping? Oops, totally forgot that. I'll send out a pull req in a moment. cheers, Gerd

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-03 Thread Stefan Hajnoczi
On Fri, Jan 31, 2014 at 05:09:03PM +0100, Lluís Vilanova wrote: Adds the base ability to specify which events in the trace-events file may be used to trace guest activity in the TCG code (using the tcg event propery). Such events generate an extra set of tracing functions that can be called

[Qemu-devel] [PULL 0/3] Update seabios to 1.7.4

2014-02-03 Thread Gerd Hoffmann
Hi, Sorry for the delay folks, totally forgot that one. Here is the seabios update to 1.7.4 final. please pull, Gerd The following changes since commit 2f61120c10da9128357510debc8e66880cd2bfdc: Merge remote-tracking branch 'qmp-unstable/queue/qmp' into staging (2014-02-01 23:32:31

  1   2   3   4   >