[Qemu-devel] [PATCH v19 04/11] block: use per-object cflags and libs

2014-02-07 Thread Fam Zheng
No longer adds flags and libs for them to global variables, instead create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is used as per object cflags and libs. This removes unwanted dependencies from libcacard. Signed-off-by: Fam Zheng [Split from Fam's patch to enable modules. -

[Qemu-devel] [PATCH v19 10/11] block: convert block drivers linked with libs to modules

2014-02-07 Thread Fam Zheng
The converted block drivers are: curl iscsi rbd ssh glusterfs Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 7aff69e..a30ec76 100755 --- a/configu

[Qemu-devel] [PATCH v19 11/11] module: Pass argv[0] along the module load path

2014-02-07 Thread Fam Zheng
This adds parameter "argv0" in calling path from main() to module_call_init(). So that module loader knows the location of executable. Suggested-by: Paolo Bonzini Signed-off-by: Fam Zheng --- block.c| 8 bsd-user/main.c| 2 +- include/block/blo

[Qemu-devel] [PATCH v19 01/11] util: Split outqemu_exec_dirfromos_find_datadir

2014-02-07 Thread Fam Zheng
This can be reused by module loading routines. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- include/qemu/osdep.h | 4 os-posix.c | 40 ++-- os-win32.c | 19 +-- util/oslib-posix.c | 45 +

[Qemu-devel] [PATCH v19 06/11] rules.mak: introduce DSO rules

2014-02-07 Thread Fam Zheng
Add necessary rules and flags for shared object generation. The new rules introduced here are: 1) %.o in $(common-obj-m) is compiled to %.o, then linked to %.so. 2) %.mo in $(common-obj-m) is the placeholder for %.so for pattern matching in Makefile. It's linked to "-shared" with all its dependen

[Qemu-devel] [PATCH v19 08/11] Makefile: install modules with "make install"

2014-02-07 Thread Fam Zheng
Install all the modules to ${MODDIR}. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 07d1ed7..57d83a3 100644 --- a/Makefile +++ b/Makefile @@ -368,6 +368,12 @@ install-datadir install-localst

[Qemu-devel] [PATCH v19 05/11] darwin: do not use -mdynamic-no-pic

2014-02-07 Thread Paolo Bonzini
While -mdynamic-no-pic can speed up the code somewhat, it is only used on the legacy PowerPC Mac OS X, and I am not sure if anyone is still testing that. Disabling PIC can cause problems when enabling modules, so do not do that. Signed-off-by: Paolo Bonzini --- configure | 2 -- 1 file changed,

[Qemu-devel] [PATCH v19 09/11] Makefile: introduce common-obj-m and block-obj-m for DSO

2014-02-07 Thread Fam Zheng
$(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does for $(block-obj-y). Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile| 4 +++- Makefile.objs | 2 ++ Makefile.target | 6 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Make

[Qemu-devel] [PATCH v19 00/11] Shared library module support

2014-02-07 Thread Fam Zheng
v19: [11/11] New to v18. Fam Zheng (10): util: Split out qemu_exec_dir from os_find_datadir rules.mak: fix $(obj) to a real relative path rules.mak: allow per object cflags and libs block: use per-object cflags and libs rules.mak: introduce DSO rules module: implement module loading

[Qemu-devel] [PATCH v19 07/11] module: implement module loading

2014-02-07 Thread Fam Zheng
This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version, it is called only after passed the checking of presense of stamp symbol: qemu_stamp_$RELEASEHASH w

[Qemu-devel] [PATCH v19 03/11] rules.mak: allow per object cflags and libs

2014-02-07 Thread Fam Zheng
Adds extract-libs in LINK to expand any "per object libs", the syntax to define such a libs options is like: foo.o-libs := $(CURL_LIBS) in block/Makefile.objs. Similarly, foo.o-cflags := $(FOO_CFLAGS) is also supported. "foo.o" must be listed in a nested var (e.g. common-obj-y

[Qemu-devel] [PATCH v19 02/11] rules.mak: fix $(obj) to a real relative path

2014-02-07 Thread Fam Zheng
Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't hurt compiling bec

Re: [Qemu-devel] Commit 34b9c07a3 (microblaze: Disable stack protection from bootloader) causing qemu crash

2014-02-07 Thread Guenter Roeck
On 02/07/2014 06:31 PM, Edgar E. Iglesias wrote: On Fri, Feb 07, 2014 at 03:17:31PM -0800, Guenter Roeck wrote: Michal, commit 34b9c07a3 (microblaze: Disable stack protection from bootloader) results in the following qemu crash in 3.14-rc1. /opt/buildbot/bin/qemu-system-microblaze -M petalogix

Re: [Qemu-devel] [PATCH v2 3/4] target-mips: add support for CP0_Config5

2014-02-07 Thread Eric Johnson
Reviewed-by: Eric Johnson From: qemu-devel-bounces+eric.johnson=imgtec@nongnu.org [qemu-devel-bounces+eric.johnson=imgtec@nongnu.org] on behalf of Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Friday, January 24, 2014 8:18 AM To: qemu-devel@no

Re: [Qemu-devel] [PATCH v2 4/4] target-mips: add user-mode FR switch support for MIPS32r5

2014-02-07 Thread Eric Johnson
Reviewed-by: Eric Johnson From: qemu-devel-bounces+eric.johnson=imgtec@nongnu.org [qemu-devel-bounces+eric.johnson=imgtec@nongnu.org] on behalf of Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Friday, January 24, 2014 8:18 AM To: qemu-devel@no

Re: [Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5

2014-02-07 Thread Eric Johnson
Reviewed-by: Eric Johnson From: qemu-devel-bounces+eric.johnson=imgtec@nongnu.org [qemu-devel-bounces+eric.johnson=imgtec@nongnu.org] on behalf of Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Friday, January 24, 2014 8:18 AM To: qemu-devel@no

Re: [Qemu-devel] [PATCH v2 2/4] target-mips: add support for CP0_Config4

2014-02-07 Thread Eric Johnson
Reviewed-by: Eric Johnson From: qemu-devel-bounces+eric.johnson=imgtec@nongnu.org [qemu-devel-bounces+eric.johnson=imgtec@nongnu.org] on behalf of Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Friday, January 24, 2014 8:18 AM To: qemu-devel@no

Re: [Qemu-devel] [PATCH v4] implementing victim TLB for QEMU system emulated TLB

2014-02-07 Thread Xin Tong
can anyone provide further review to this patch please ? Thank you, Xin On Mon, Feb 3, 2014 at 9:50 AM, Eric Blake wrote: > On 02/03/2014 08:18 AM, Xin Tong wrote: >> This patch adds a victim TLB to the QEMU system mode TLB. >> >> Changes from PATCH v3. >> 1. updated measurements - performance i

Re: [Qemu-devel] Commit 34b9c07a3 (microblaze: Disable stack protection from bootloader) causing qemu crash

2014-02-07 Thread Edgar E. Iglesias
On Fri, Feb 07, 2014 at 03:17:31PM -0800, Guenter Roeck wrote: > Michal, > > commit 34b9c07a3 (microblaze: Disable stack protection from bootloader) > results > in the following qemu crash in 3.14-rc1. > > /opt/buildbot/bin/qemu-system-microblaze -M petalogix-s3adsp1800 -kernel > arch/microblaz

[Qemu-devel] [Bug 1276879] Re: lots of dma command 10, 14 not supported

2014-02-07 Thread tyler knosis
So, Zoltan pointed to two patches. I applied the first (v8-06-10-i8259-fix.), but the second patches a file that is not in version 1.7.0. With the one patch, I am now able to get past the step where it crapped out before. The dma messages are still there, but it seems that they can be igno

[Qemu-devel] [Bug 1276847] Re: Build fails on latest MinGW

2014-02-07 Thread Corry Lazarowitz
Well, despite those very real error messages I had, its gone now with a full msys reinstall. Same dependencies for 32 bit. I just decided to try the 64 bit since to me it seemed like you were saying that would be more likely to work. As part of installing the 64 bit, I decided to incur more pain

Re: [Qemu-devel] Speed disk virtio

2014-02-07 Thread Brian Jackson
On 02/04/2014 08:21 AM, XliN wrote: > Good day. Very little speed drives Virtio. Drivers are the latest > guest on the system "Windows server 2008". Host system centos 6.5. What latest? There are a few different places to get drivers (Fedora site, RHEL subscription, build yourself, etc). From the

Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values

2014-02-07 Thread Laszlo Ersek
On 02/07/14 22:45, Kevin Wolf wrote: > Am 07.02.2014 um 17:27 hat Eric Blake geschrieben: >> On 02/07/2014 09:12 AM, Kevin Wolf wrote: >>> The behaviour of the ROUND_UP macro with negative numbers isn't obvious. >>> It happens to do the right thing in this please, but better avoid it. >> >> s/pleas

[Qemu-devel] Commit 34b9c07a3 (microblaze: Disable stack protection from bootloader) causing qemu crash

2014-02-07 Thread Guenter Roeck
Michal, commit 34b9c07a3 (microblaze: Disable stack protection from bootloader) results in the following qemu crash in 3.14-rc1. /opt/buildbot/bin/qemu-system-microblaze -M petalogix-s3adsp1800 -kernel arch/microblaze/boot/linux.bin -no-reboot -append "console=ttyUL0,115200 " -nographic qemu: f

[Qemu-devel] [PATCH 1/8] target-arm: A64: Implement plain vector SIMD indexed element insns

2014-02-07 Thread Peter Maydell
Implement all the SIMD vector x indexed element instructions in the subcategory which are not 'long' ops. Signed-off-by: Peter Maydell --- target-arm/helper-a64.c| 26 + target-arm/helper-a64.h| 2 + target-arm/translate-a64.c | 245 - 3

[Qemu-devel] [PATCH 4/8] target-arm: A64: Implement scalar three different instructions

2014-02-07 Thread Peter Maydell
Implement the scalar three different instruction group: it only has three instructions in it. Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 95 +- 1 file changed, 94 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c

[Qemu-devel] [PATCH 8/8] target-arm: A64: Implement remaining 3-same instructions

2014-02-07 Thread Peter Maydell
Implement the remaining instructions in the SIMD 3-reg-same and scalar-3-reg-same groups: FMULX, FRECPS, FRSQRTS, FACGE, FACGT, FMLA and FMLS. Signed-off-by: Peter Maydell --- target-arm/helper-a64.c| 60 ++ target-arm/helper-a64.h| 4 ta

[Qemu-devel] [PATCH 3/8] target-arm: A64: Implement SIMD scalar indexed instructions

2014-02-07 Thread Peter Maydell
Implement the SIMD scalar indexed instructions. The encoding here is nearly identical to the vector indexed grouping, so we combine the two. Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 115 - 1 file changed, 82 insertions(+), 33 delet

[Qemu-devel] [PATCH 6/8] target-arm: A64: Implement floating point pairwise insns

2014-02-07 Thread Peter Maydell
From: Alex Bennée Add support for the floating-point pairwise operations FADDP, FMAXP, FMAXNMP, FMINP and FMINNMP. To do this we use the code which was previously handling only integer pairwise operations, and push the integer-specific decode and handling of unallocated cases up one level in the

[Qemu-devel] [PATCH 5/8] target-arm: A64: Implement SIMD FP compare and set insns

2014-02-07 Thread Peter Maydell
From: Alex Bennée This adds all forms of the SIMD floating point and set instructions: FCM(GT|GE|EQ|LE|LT) Most of the heavy lifting is done by either the existing neon helpers or some new helpers for the 64bit double cases. Most of the code paths are common although the 2misc versions are a

[Qemu-devel] [PATCH 7/8] softfloat: Support halving the result of muladd operation

2014-02-07 Thread Peter Maydell
The ARMv8 instruction set includes a fused floating point reciprocal square root step instruction which demands an "(x * y + z) / 2" fused operation. Support this by adding a flag to the softfloat muladd operations which requests that the result is halved before rounding. Signed-off-by: Peter Mayd

[Qemu-devel] [PATCH 2/8] target-arm: A64: Implement long vector x indexed insns

2014-02-07 Thread Peter Maydell
Implement the 'long' operations in the vector x indexed element category. Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 144 +++-- 1 file changed, 139 insertions(+), 5 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/trans

[Qemu-devel] [PATCH 0/8] A64: Neon support, fourth set

2014-02-07 Thread Peter Maydell
This is the fourth set of A64 Neon support patches. This set provides complete implementations of the categories: * scalar x indexed * vector x indexed * scalar three-different and fills in all the previously missing instructions in: * vector 3-reg-same * scalar 3-reg-same It includes adding

Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values

2014-02-07 Thread Kevin Wolf
Am 07.02.2014 um 17:27 hat Eric Blake geschrieben: > On 02/07/2014 09:12 AM, Kevin Wolf wrote: > > The behaviour of the ROUND_UP macro with negative numbers isn't obvious. > > It happens to do the right thing in this please, but better avoid it. > > s/please/place/ Indeed... Thanks, fixed it loca

[Qemu-devel] [Bug 1276879] Re: lots of dma command 10, 14 not supported

2014-02-07 Thread BALATON Zoltan
http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg00889.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1276879 Title: lots of dma command 10, 14 not supported Status in QEMU: New B

Re: [Qemu-devel] [RFC for-next 0/2] QOM VMStateDescription remix

2014-02-07 Thread Peter Maydell
On 7 February 2014 21:28, Andreas Färber wrote: > I have found a single such case: armv7m_nvic overrides arm_gic_common > with a completely different vmsd. How can we fix that? :) We can deduce from this that nobody's been using migration with the Cortex-M3, since it would obviously be totally bu

Re: [Qemu-devel] [RFC for-next 0/2] QOM VMStateDescription remix

2014-02-07 Thread Andreas Färber
Peter, Am 02.09.2013 13:41, schrieb Michael S. Tsirkin: > On Mon, Jul 29, 2013 at 04:03:56AM +0200, Andreas Färber wrote: >> Hello, >> >> Based on a comment from mst, this mini-series proposes to change semantics of >> VMStateDescription registration to be more similar to those of static >> prope

Re: [Qemu-devel] [TCG] : Code flow understanding

2014-02-07 Thread Richard Henderson
On 02/05/2014 11:22 PM, Gaurav Sharma wrote: > I need some help regarding the flow of generating a TCG op and then > subsequent translation of any op into target instrn. That's most of tcg/tcg.c and tcg/foo/tcg-target.c. tcg_gen_code is the main entry point for beginning the compilation of the pr

Re: [Qemu-devel] Multi GPU passthrough via VFIO

2014-02-07 Thread Maik Broemme
Hi Alex, Alex Williamson wrote: > On Fri, 2014-02-07 at 01:22 +0100, Maik Broemme wrote: > > Interesting is the diff between 1st and 2nd boot, so if I do the lspci > > prior to the booting. The only difference between 1st start and 2nd > > start are: > > > > --- 001-lspci.290x.before.1st.log 2

[Qemu-devel] MSI interrupt support with vioscsi.c miniport driver

2014-02-07 Thread Nicholas A. Bellinger
Hi Yan, So recently I've been doing some KVM guest performance comparisons between the scsi-mq prototype using virtio-scsi + vhost-scsi, and Windows Server 2012 with vioscsi.sys (virtio-win-0.1-74.iso) + vhost-scsi using PCIe flash backend devices. I've noticed that small block random performance

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-07 Thread Stefan Priebe
Am 07.02.2014 21:02, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wrote: anything i could try or debug? to help to find the problem? I think the most useful would be to see if the problem is a new problem in the 1.7 you're using or has existed for a while; depending

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-07 Thread Dr. David Alan Gilbert
* Stefan Priebe (s.pri...@profihost.ag) wrote: > anything i could try or debug? to help to find the problem? I think the most useful would be to see if the problem is a new problem in the 1.7 you're using or has existed for a while; depending on the machine type you used, it might be possible to

Re: [Qemu-devel] Multi GPU passthrough via VFIO

2014-02-07 Thread Alex Williamson
On Fri, 2014-02-07 at 01:22 +0100, Maik Broemme wrote: > Interesting is the diff between 1st and 2nd boot, so if I do the lspci > prior to the booting. The only difference between 1st start and 2nd > start are: > > --- 001-lspci.290x.before.1st.log 2014-02-07 01:13:41.498827928 +0100 > +++ 004

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-07 Thread Stefan Priebe
anything i could try or debug? to help to find the problem? Stefan Am 07.02.2014 14:45, schrieb Stefan Priebe - Profihost AG: it's always the same "pattern" there are too many 0 instead of X. only seen: read:0x ... expected:0x or read:0x ... e

Re: [Qemu-devel] OpenBSD v5.X guest (with MP kernel) freezes on "virsh shutdown "

2014-02-07 Thread Robert Urban
I would be overjoyed if someone could point me to a description of the behavior of qemu when generating the ACPI "power button press" event for the guest. And a further reference to a description of the standard that qemu adheres to (I presume) would be icing on the cake. cheers, Rob Urban On 02

[Qemu-devel] [Bug 1276879] Re: lots of dma command 10, 14 not supported

2014-02-07 Thread tyler knosis
Successfully installed NextStep in bochs, but not qemu. Having same problem with OpenStep 4.2 in qemu. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1276879 Title: lots of dma command 10, 14 not s

[Qemu-devel] [PATCH] tcg/aarch64: refactoring, remove inline magic insn numbers

2014-02-07 Thread Claudio Fontana
From: Claudio Fontana this is general polishing for tcg/aarch64, removing the inline magic insn numbers, and putting up enums for intruction classes and subclasses in their stead. Signed-off-by: Claudio Fontana Tested-by: Claudio Fontana --- tcg/aarch64/tcg-target.c | 528

[Qemu-devel] timer issue on 1.7.0 and later

2014-02-07 Thread Rob Herring
I've bisected a problem with system emulation and SMP kernels using per cpu timers to this commit. I can reproduce this problem on ARM emulation with both ARM generic timers (only in 1.7.0) and ARM MPCore timers. Using a single broadcast timer in the guest kernel works fine. My host is ubuntu 13.1

Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest

2014-02-07 Thread Andreas Färber
Am 07.02.2014 16:48, schrieb Stefan Hajnoczi: > On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote: >> +#include "libqtest.h" >> + >> +#include >> +#include >> +#include "qemu/osdep.h" > > Please put includes before "user.h" includes. That way we > can be sure our macros don't mess

Re: [Qemu-devel] Multi GPU passthrough via VFIO

2014-02-07 Thread Maik Broemme
Hi Alex, Maik Broemme wrote: > Hi Alex, > > Alex Williamson wrote: > > On Thu, 2014-02-06 at 01:25 +0100, Maik Broemme wrote: > > > Hi Alex, > > > > > > Maik Broemme wrote: > > > > > > > > Another minor issue is that the R9 290X is not reset during > > > > > > > > shutdown of > > > > > > > >

Re: [Qemu-devel] [RFC qom-cpu 00/41] QOM CPUState, part 13: Emptying CPU_COMMON

2014-02-07 Thread Michael Walle
Am 2013-09-04 11:04, schrieb Andreas Färber: On part 11, rth said for alpha that using CPUAlphaState in DisasContext was bad and that the relevant fields should be copied into DisasContext instead; a few targets still have an env field though and use it for register access and cpu_abort(), so I

[Qemu-devel] [Patch/RFC 11/16] s390x/sclp: Add missing checks to SCLP handler

2014-02-07 Thread Christian Borntraeger
From: Thomas Huth If the 51 most significant bits of the SCCB address are zero or equal to the prefix, we should throw an specification exception, too. Also moved the check for privileged mode to sclp_service_call() to have all program checks in one place now. Signed-off-by: Thomas Huth Reviewe

[Qemu-devel] [Patch/RFC 01/16] update linux headers to kvm/next

2014-02-07 Thread Christian Borntraeger
upstream commit id tbd Signed-off-by: Christian Borntraeger --- linux-headers/asm-arm/kvm.h| 28 ++ linux-headers/asm-arm64/kvm.h | 21 - linux-headers/asm-s390/kvm.h | 19 linux-headers/asm-x86/hyperv.h | 16 -- linux-headers/linux/kvm.h

[Qemu-devel] [Patch/RFC 13/16] s390x/event-facility: some renaming

2014-02-07 Thread Christian Borntraeger
From: Heinz Graalfs Do some renaming to shorten some identifiers and to emphasize sclp. Signed-off-by: Heinz Graalfs Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/event-facility.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [Patch/RFC 08/16] s390x/virtio-hcall: Specification exception for illegal subcodes

2014-02-07 Thread Christian Borntraeger
From: Thomas Huth So far, the DIAG 500 hypervisor call was only setting -EINVAL in R2 when a guest tried to call this function with an illegal subcode. This patch now changes the behavior so that a specification exception is thrown instead, since this is the common behavior of other DIAG function

[Qemu-devel] [Patch/RFC 10/16] s390x/sclp: Fixed the size of sccb and code parameter

2014-02-07 Thread Christian Borntraeger
From: Thomas Huth The pointer to the SCCB should not be limited to 32 bits only. In contrast to this, the command word parameter is only 32 bits (the upper 32 bits should be ignored). Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/sclp

[Qemu-devel] [Patch/RFC 14/16] s390x/event-facility: code restructure

2014-02-07 Thread Christian Borntraeger
From: Heinz Graalfs Code restructure in order to simplify class hierarchy - remove S390SCLPDevice abstract base class and move function pointers into new SCLPEventFacilityClass - implement SCLPEventFacility as SysBusDevice - use define constants for instance creation strings The follow

[Qemu-devel] [Patch/RFC 07/16] s390x/virtio-hcall: Add range check for hypervisor call

2014-02-07 Thread Christian Borntraeger
From: Thomas Huth The handler for diag 500 did not check whether the requested function was in the supported range, so illegal values could crash QEMU in the worst case. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-hcall.

[Qemu-devel] [Patch/RFC 06/16] s390x/kvm: Add missing SIGP CPU RESET order

2014-02-07 Thread Christian Borntraeger
From: Thomas Huth The SIGP order CPU RESET was still missing in the list of our supported handler. This patch now adds a simple implementation, by using the cpu_reset() function that is already available in target-s390x/cpu.c. Signed-off-by: Thomas Huth Reviewed-by: Christian Borntraeger Revie

[Qemu-devel] [Patch/RFC 03/16] s390x/async_pf: Check for apf extension and enable pfault

2014-02-07 Thread Christian Borntraeger
From: Dominik Dingel S390 can also use async page faults, to enhance guest scheduling. In case of live migration we want to disable the feature let all pending request finish. Signed-off-by: Dominik Dingel Signed-off-by: Jens Freimann Signed-off-by: Christian Borntraeger --- hw/intc/s390_fli

[Qemu-devel] [Patch/RFC 15/16] s390x/event-facility: add support for live migration

2014-02-07 Thread Christian Borntraeger
From: Heinz Graalfs Add support for live migration using VMStateDescription. Fold this into final patch adding Live Migration code for SCLP Event Facility. Signed-off-by: Heinz Graalfs Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/event-facility.c | 12

[Qemu-devel] [Patch/RFC 02/16] s390x/kvm: implement floating-interrupt controller device

2014-02-07 Thread Christian Borntraeger
From: Jens Freimann This patch implements a floating-interrupt controller device (flic) which interacts with the s390 flic kvm_device. Signed-off-by: Jens Freimann Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- default-configs/s390x-softmmu.mak | 1 + hw/intc/Makefile.

[Qemu-devel] [Patch/RFC 16/16] s390x/event-facility: exploit realize/unrealize

2014-02-07 Thread Christian Borntraeger
From: Heinz Graalfs init/exit functionality of abstract SCLPEvent class is now exploiting realize/unrealize. Signed-off-by: Heinz Graalfs Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/event-facility.c | 27 ++- 1 file changed, 18 inserti

[Qemu-devel] [Patch/RFC 12/16] s390x/sclp: Fixed setting of condition code register

2014-02-07 Thread Christian Borntraeger
From: Thomas Huth In the SCLP handler function, the condition code register must only be set if no exception occured. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[Qemu-devel] [Patch/RFC 09/16] s390x/eventfacility: mask out commands

2014-02-07 Thread Christian Borntraeger
As a followup to commit 5f04c14a10fa7f259bc0808f35a0beda49f7821e (s390-sclp: Define New SCLP Codes) we should mask the sclp command not only in base sclp, but also in the event facility. Based on an initial patch from Ralf Hoppe. Signed-off-by: Christian Borntraeger --- hw/s390x/event-facility.

[Qemu-devel] [Patch/RFC 05/16] s390x/kvm: Rework SIGP INITIAL CPU RESET handler

2014-02-07 Thread Christian Borntraeger
From: Thomas Huth The s390_cpu_initial_reset() function had two deficiencies: First, it used an ioctl for the destination CPU, and this ioctl could block nearly forever, as long as the destination CPU was running in the SIE loop. Second, it also cleared the general purpose registers - something i

[Qemu-devel] [Patch/RFC 00/16] s390x/kvm features and fixes

2014-02-07 Thread Christian Borntraeger
here is my next bunch of patches for s390x/kvm for 2.0. The tree is also available at git://github.com/borntraeger/qemu.git s390-next It still depends on a not-yet pulled kvm tree ( git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git tags/kvm-s390-20140130) which Paolo will probabl

[Qemu-devel] [Patch/RFC 04/16] s390x/kvm: Fixed bad SIGP SET-ARCHITECTURE handler

2014-02-07 Thread Christian Borntraeger
From: Thomas Huth The SET-ARCHITECTURE handler in QEMU caused an program interruption. This is wrong according to the "Principles of Operations" specification (since SIGP should never cause a program interrupt) and was likely only introduced for debugging purposes. Since we handle SET-ARCHITECTUR

Re: [Qemu-devel] [PULL 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-07 Thread Peter Maydell
On 4 February 2014 08:31, Stefan Hajnoczi wrote: > On Mon, Feb 03, 2014 at 04:01:00PM +, Peter Maydell wrote: >> On 3 February 2014 15:20, Stefan Hajnoczi wrote: >> > This pull request has been rebased onto qemu.git/master and retested. >> > >> > The series fixes init_socket() failures when r

Re: [Qemu-devel] [PATCH v2] memory: fix limiting of translation at a page boundary

2014-02-07 Thread Mark Cave-Ayland
On 07/02/14 14:47, Paolo Bonzini wrote: Commit 360e607 (address_space_translate: do not cross page boundaries, 2014-01-30) broke MMIO accesses in cases where the section is shorter than the full register width. This can happen for example with the Bochs DISPI registers, which are 16 bits wide b

Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values

2014-02-07 Thread Eric Blake
On 02/07/2014 09:12 AM, Kevin Wolf wrote: > The behaviour of the ROUND_UP macro with negative numbers isn't obvious. > It happens to do the right thing in this please, but better avoid it. s/please/place/ > > Suggested-by: Laszlo Ersek > Signed-off-by: Kevin Wolf > --- > block.c | 4 ++-- > 1

[Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values

2014-02-07 Thread Kevin Wolf
The behaviour of the ROUND_UP macro with negative numbers isn't obvious. It happens to do the right thing in this please, but better avoid it. Suggested-by: Laszlo Ersek Signed-off-by: Kevin Wolf --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block

[Qemu-devel] [PATCH 1/3] block: Fix memory leaks in bdrv_co_do_pwritev()

2014-02-07 Thread Kevin Wolf
The error path for a failure in one of the two bdrv_aligned_preadv() calls leaked head_buf or tail_buf, respectively. This fixes the memory leak. Reported-by: Laszlo Ersek Signed-off-by: Kevin Wolf --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/blo

Re: [Qemu-devel] [PATCH v2] xen_disk: fix io accounting

2014-02-07 Thread Kevin Wolf
Am 07.02.2014 um 15:47 hat Olaf Hering geschrieben: > bdrv_acct_done was called unconditional. But in case the ioreq has no > segments there is no matching bdrv_acct_start call. This could lead to > bogus accounting values. > > Found by code inspection. > > Signed-off-by: Olaf Hering > --- > v2:

[Qemu-devel] [PATCH 0/3] 512-on-4k follow-up patches

2014-02-07 Thread Kevin Wolf
Kevin Wolf (3): block: Fix memory leaks in bdrv_co_do_pwritev() block: bdrv_aligned_pwritev: Assert overlap range block: Don't call ROUND_UP with negative values block.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) -- 1.8.1.4

[Qemu-devel] [PATCH 2/3] block: bdrv_aligned_pwritev: Assert overlap range

2014-02-07 Thread Kevin Wolf
This adds assertions that the request that we actually end up passing to the block driver (which includes RMW data and has therefore potentially been rounded to alignment boundaries) is fully covered by the overlap_{offset,size} fields of the associated BdrvTrackedRequest. Suggested-by: Laszlo Ers

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-07 Thread Benoît Canet
Le Friday 07 Feb 2014 à 20:57:35 (+0530), Bharata B Rao a écrit : > On Fri, Feb 07, 2014 at 03:22:29PM +0100, Benoît Canet wrote: > > Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit : > > > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > > > > Le Tuesday 04 Feb 2014

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-07 Thread Jeff Cody
On Fri, Feb 07, 2014 at 08:57:35PM +0530, Bharata B Rao wrote: > On Fri, Feb 07, 2014 at 03:22:29PM +0100, Benoît Canet wrote: > > Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit : > > > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > > > > Le Tuesday 04 Feb 2014 à 1

Re: [Qemu-devel] [PATCH qom-next 0/5] qtest: Prepare PCI NIC tests

2014-02-07 Thread Stefan Hajnoczi
On Wed, Feb 05, 2014 at 06:01:12PM +0100, Andreas Färber wrote: > Hello Stefan, > > As discussed late last year, this series starts preparing tests to cover > optional NICs. They don't do any functional tests but assure that QOM/PCI > refactorings don't break the basic usage of these devices. > >

Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest

2014-02-07 Thread Stefan Hajnoczi
On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote: > +#include "libqtest.h" > + > +#include > +#include > +#include "qemu/osdep.h" Please put includes before "user.h" includes. That way we can be sure our macros don't mess up system headers. > + > +static void nop(void) > +{ > +}

Re: [Qemu-devel] [SeaBIOS] [PATCH 1/2] SMBIOS: Update Type 17 (Memory Device) struct to v2.3

2014-02-07 Thread Paolo Bonzini
Il 06/02/2014 14:38, Gabriel L. Somlo ha scritto: But anyhow, right now QEMU seems to be making relatively minor tweaks to something that's firmly at home in SeaBIOS, which is why I sent my patches to the latter... Yeah, that's correct. There's really no particular hook in QEMU to do this. Pa

[Qemu-devel] [PATCH] ACPI: Remove commented-out code from HPET._CRS

2014-02-07 Thread Gabriel L. Somlo
IRQNoFlags on HPET._CRS crashes WinXP because it causes the HPET to conflict with the system timer and/or the RTC. It only occurs on Apple hardware, and even there it is exposed fully only when OS X is detected (via _OSI). Recent OS X versions work on QEMU without this statement, so at this time th

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-07 Thread Bharata B Rao
On Fri, Feb 07, 2014 at 03:22:29PM +0100, Benoît Canet wrote: > Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit : > > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > > > Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit : > > > > > > > > +static void qem

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-07 Thread Lluís Vilanova
Peter Maydell writes: > On 7 February 2014 14:49, Richard Henderson wrote: >> On 02/06/2014 11:26 AM, Lluís Vilanova wrote: > At which point, option 2 would be the best bet, I think. >>> Right. For the 3rd option I was also thinking about having per-vCPU tracing >>> states (in the case of gu

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-07 Thread Peter Maydell
On 7 February 2014 14:49, Richard Henderson wrote: > On 02/06/2014 11:26 AM, Lluís Vilanova wrote: >>> > At which point, option 2 would be the best bet, I think. >> Right. For the 3rd option I was also thinking about having per-vCPU tracing >> states (in the case of guest events), so that you can

Re: [Qemu-devel] [PATCH v2] xen_disk: fix io accounting

2014-02-07 Thread Olaf Hering
On Fri, Feb 07, Stefano Stabellini wrote: > added to my queue, I'll fix the tab manually Thanks, sorry for the TAB. Olaf

Re: [Qemu-devel] [PATCH] scripts: Add qom-tree script as modern equivalent of info qtree

2014-02-07 Thread Markus Armbruster
Andreas Färber writes: > Am 07.02.2014 14:06, schrieb Paolo Bonzini: >> Il 07/02/2014 13:44, Andreas Färber ha scritto: >>> Am 07.02.2014 12:21, schrieb Paolo Bonzini: Let's stop talking about theory and let's look at the actual ccode, please. >>> >>> I have posted actual patches, you h

Re: [Qemu-devel] [PATCH v2] xen_disk: fix io accounting

2014-02-07 Thread Stefano Stabellini
On Fri, 7 Feb 2014, Olaf Hering wrote: > bdrv_acct_done was called unconditional. But in case the ioreq has no > segments there is no matching bdrv_acct_start call. This could lead to > bogus accounting values. > > Found by code inspection. > > Signed-off-by: Olaf Hering added to my queue, I'll

Re: [Qemu-devel] [PATCH v2] memory: fix limiting of translation at a page boundary

2014-02-07 Thread Stefano Stabellini
On Fri, 7 Feb 2014, Paolo Bonzini wrote: > Commit 360e607 (address_space_translate: do not cross page boundaries, > 2014-01-30) broke MMIO accesses in cases where the section is shorter > than the full register width. This can happen for example with the > Bochs DISPI registers, which are 16 bits

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-07 Thread Richard Henderson
On 02/06/2014 11:26 AM, Lluís Vilanova wrote: >> > At which point, option 2 would be the best bet, I think. > Right. For the 3rd option I was also thinking about having per-vCPU tracing > states (in the case of guest events), so that you can trace separate events > depending on the vCPU. > > Which

[Qemu-devel] [PATCH v2] xen_disk: fix io accounting

2014-02-07 Thread Olaf Hering
bdrv_acct_done was called unconditional. But in case the ioreq has no segments there is no matching bdrv_acct_start call. This could lead to bogus accounting values. Found by code inspection. Signed-off-by: Olaf Hering --- v2: add comment /* fall through */ hw/block/xen_disk.c | 14 +

[Qemu-devel] [PATCH v2] memory: fix limiting of translation at a page boundary

2014-02-07 Thread Paolo Bonzini
Commit 360e607 (address_space_translate: do not cross page boundaries, 2014-01-30) broke MMIO accesses in cases where the section is shorter than the full register width. This can happen for example with the Bochs DISPI registers, which are 16 bits wide but have only a 1-byte long MemoryRegion (if

Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors

2014-02-07 Thread Paolo Bonzini
Il 07/02/2014 15:23, Markus Armbruster ha scritto: > No objections to patch 1-9. What does it take make you accept PATCH 10? The email you just wrote, basically, :) and removing the NULL pointer checks in the visitor implementations. Paolo

[Qemu-devel] [PATCH qom-test] qom-test: Test QOM properties

2014-02-07 Thread Andreas Färber
Recursively walk all properties under /machine and try to retrieve their value. This is a regression test for link<> properties. Cf. be2f78b6b062eec5170e2612299fb8953046993f Signed-off-by: Andreas Färber --- tests/qom-test.c | 38 ++ 1 file changed, 38 insert

Re: [Qemu-devel] [PATCH 1/2] xhci iso: fix time calculation

2014-02-07 Thread Hans de Goede
Hi, Looks good, ack series. Regards, Hans On 02/06/2014 12:42 PM, Gerd Hoffmann wrote: Frameid specifies frames not microframes, so we need to shift it to get the microframe index. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [Qemu-devel] [PATCH] memory: fix limiting of translation at a page boundary

2014-02-07 Thread Mark Cave-Ayland
On 06/02/14 23:40, Paolo Bonzini wrote: Commit 360e607 (address_space_translate: do not cross page boundaries, 2014-01-30) broke MMIO accesses in cases where the section is shorter than the full register width. This can happen for example with the Bochs DISPI registers, which are 16 bits wide b

Re: [Qemu-devel] [PATCH] scripts: Add qom-tree script as modern equivalent of info qtree

2014-02-07 Thread Paolo Bonzini
Il 07/02/2014 14:48, Andreas Färber ha scritto: And let me repeat that *reverting a broken patch should always be one of the alternatives*. Yes. But it has never been *mandatory* to revert things first before fixing them. We usually apply incremental fixes referencing the commit hash that brok

Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors

2014-02-07 Thread Markus Armbruster
Paolo Bonzini writes: > Il 06/02/2014 15:30, Markus Armbruster ha scritto: >> Visitors get passed a pointer to the visited object. The generated >> visitors try to cope with this pointer being null in some places, for >> instance like this: >> >> visit_start_optional(m, obj ? &(*obj)->has_na

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-07 Thread Benoît Canet
Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit : > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > > Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit : > > > > > > +static void qemu_gluster_parse_flags(int bdrv_flags, int *open_flags) > > > +{ > > > +

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-02-07 Thread Alexander Graf
On 07.02.2014, at 14:44, Greg Kurz wrote: > In the past, IO space could not be mapped into the memory address space > so we introduced a workaround for that. Nowadays it does not look > necessary so we can remove the workaround and make sPAPR PCI > configuration simplier. > > Signed-off-by: Gre

  1   2   >