Re: [Qemu-devel] QOM vs QAPI for QMP APIs

2014-02-24 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 02/21/2014 07:37 AM, Paolo Bonzini wrote: I have no objection to introducing a QMP command. I think qom-find-objects-by-class is a reasonable approach but I would also consider just grouping all of the IOThreads in a well known path instead of just

Re: [Qemu-devel] [PATCH] balloon: Fix device name in error message.

2014-02-24 Thread Markus Armbruster
Hani Benhabiles kroo...@gmail.com writes: Also fix trailing whitespace. Signed-off-by: Hani Benhabiles h...@linux.com --- balloon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/balloon.c b/balloon.c index e321f2c..b66710a 100644 --- a/balloon.c +++

[Qemu-devel] [PATCH] Support NBD client under win32/MinGW

2014-02-24 Thread Or Goshen
From: Or Goshen ober...@gmail.com --- aio-win32.c | 244 +-- block/Makefile.objs |4 +- block/nbd-client.h |2 +- include/block/aio.h |2 - include/block/nbd.h |2 +- main-loop.c |2 - nbd.c |

Re: [Qemu-devel] [PATCH] Support NBD client under win32/MinGW

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 10:13, Or Goshen ha scritto: + /* Create event */ + HANDLE event = WSACreateEvent(); + long lNetworkEvents = 0; + + if (node-io_read) + lNetworkEvents |= FD_READ; + if (node-io_write) +

Re: [Qemu-devel] [PATCH] hw/9pfs: use g_strdup_printf() instead of PATH_MAX limitation

2014-02-24 Thread Markus Armbruster
Chen Gang gang.chen.5...@gmail.com writes: When path is truncated by PATH_MAX limitation, it causes QEMU to access incorrect file. So use original full path instead of PATH_MAX within 9pfs (need check/process ENOMEM for related memory allocation). Also find/fix several another related issues

[Qemu-devel] [PATCH] Add a command to QMP to list the supported devices

2014-02-24 Thread Or Goshen
From: Or Goshen o...@heartbeat.com Was done on behalf of Intel Corp. --- qapi-schema.json | 26 ++ qdev-monitor.c | 28 qmp-commands.hx | 40 3 files changed, 94 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH] Add a command to QMP to list the supported devices

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 10:23, Or Goshen ha scritto: From: Or Goshen o...@heartbeat.com Was done on behalf of Intel Corp. Hi Or, you can use qom-list-types for this purpose. Paolo --- qapi-schema.json | 26 ++ qdev-monitor.c | 28

Re: [Qemu-devel] [PATCH v3 1/6] qemu-option: has_help_option() and is_valid_option_list()

2014-02-24 Thread Kevin Wolf
Am 24.02.2014 um 09:42 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: Am 21.02.2014 um 21:22 hat Eric Blake geschrieben: On 02/21/2014 08:24 AM, Kevin Wolf wrote: has_help_option() checks if any help option ('help' or '?') occurs anywhere in an option string,

Re: [Qemu-devel] [PULL 01/54] qcow2: Set zero flag for discarded clusters

2014-02-24 Thread Kevin Wolf
Am 22.02.2014 um 01:01 hat Eric Blake geschrieben: On 02/21/2014 03:11 PM, Kevin Wolf wrote: Instead of making the backing file contents visible again after a discard request, set the zero flag if possible (i.e. on version = 3). Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by:

Re: [Qemu-devel] [PATCH v2] net: Disable netmap backend when not supported

2014-02-24 Thread Vincenzo Maffione
Hi, I cannot see it in your net tree. Thanks, Vincenzo 2014-02-21 11:05 GMT+01:00 Stefan Hajnoczi stefa...@redhat.com: On Thu, Feb 20, 2014 at 03:40:43PM +0100, Vincenzo Maffione wrote: This patch fixes configure so that the netmap backend is not compiled in if the host doesn't

Re: [Qemu-devel] [PATCH v3 1/6] qemu-option: has_help_option() and is_valid_option_list()

2014-02-24 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 21.02.2014 um 21:22 hat Eric Blake geschrieben: On 02/21/2014 08:24 AM, Kevin Wolf wrote: has_help_option() checks if any help option ('help' or '?') occurs anywhere in an option string, so that things like 'cluster_size=4k,help' are recognised.

Re: [Qemu-devel] [PULL v2 33/37] block: vhdx - add .bdrv_create() support

2014-02-24 Thread Stefan Hajnoczi
On Fri, Feb 21, 2014 at 09:15:41AM -0500, Jeff Cody wrote: On Fri, Feb 21, 2014 at 01:06:43PM +0100, Alexander Graf wrote: On 08.11.2013, at 11:12, Stefan Hajnoczi stefa...@redhat.com wrote: /* Header for the region table block */ +#define VHDX_REGION_SIGNATURE 0x69676572 /* regi in

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Kevin Wolf
Am 22.02.2014 um 14:00 hat Peter Lieven geschrieben: this patch tries to optimize zero write requests by automatically using bdrv_write_zeroes if it is supported by the format. i know that there is a lot of potential for discussion, but i would like to know what the others think. this

[Qemu-devel] [PATCH 0/2] char: restore read callback on a reattached (hotplug) chardev

2014-02-24 Thread Gal Hammer
Added a patch which fix an assertion error. Gal Hammer (2): char: restore read callback on a reattached (hotplug) chardev qtest: fix a !chr-fd_in_tag assertion error in qtest. monitor.c | 1 + qemu-char.c | 21 + qtest.c | 2 ++ 3 files changed, 20 insertions(+),

[Qemu-devel] [PATCH 2/2] qtest: fix a !chr-fd_in_tag assertion error in qtest.

2014-02-24 Thread Gal Hammer
Replacement of the default chardev handlers now requires a call to release the current handlers. Signed-off-by: Gal Hammer gham...@redhat.com --- monitor.c | 1 + qtest.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/monitor.c b/monitor.c index de90fba..db52e7f 100644 --- a/monitor.c

[Qemu-devel] [PATCH 1/2] char: restore read callback on a reattached (hotplug) chardev

2014-02-24 Thread Gal Hammer
Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restored so data can't be transferred from the host to the guest (e.g. via the virtio-serial port).

Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files

2014-02-24 Thread Kevin Wolf
Am 23.02.2014 um 18:02 hat Stefan Weil geschrieben: These header files are used by most QEMU source files. If they depend on windows.h, all those source files do so, too. All Windows specific data types which are replaced use identical definitions for the 32 and 64 bit Windows APIs. HANDLE

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Peter Lieven
On 24.02.2014 11:11, Kevin Wolf wrote: Am 22.02.2014 um 14:00 hat Peter Lieven geschrieben: this patch tries to optimize zero write requests by automatically using bdrv_write_zeroes if it is supported by the format. i know that there is a lot of potential for discussion, but i would like to

Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h

2014-02-24 Thread Paolo Bonzini
Il 23/02/2014 18:02, Stefan Weil ha scritto: diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 8a303f3..3a0bf13 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -2,7 +2,7 @@ #include stdio.h #include stdbool.h #include glib.h -#include windows.h +#include

Re: [Qemu-devel] [PATCH 2/2] qtest: fix a !chr-fd_in_tag assertion error in qtest.

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 11:16, Gal Hammer ha scritto: Replacement of the default chardev handlers now requires a call to release the current handlers. Signed-off-by: Gal Hammer gham...@redhat.com --- monitor.c | 1 + qtest.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/monitor.c b/monitor.c

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 11:26, Peter Lieven ha scritto: I personally do not need this for QCOW2 but for iSCSI. Here the optimization is basically saved bandwidth since a zero write becomes a WRITESAME. It saves bandwidth, but at the potential cost of extra host CPU utilization. I would be fine with

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 02:01, Fam Zheng ha scritto: I would do this in qcow2: 1. In qcow2_co_writev, allocate cluster regardless of if data is zero or not. 2. If data is zero, set QCOW2_OFLAG_ZERO in L2. This is (or should be) bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP. Paolo

Re: [Qemu-devel] [PATCH v4 3/3] KVM: x86: Enable Intel MPX for guest

2014-02-24 Thread Liu, Jinsong
Liu, Jinsong wrote: Paolo Bonzini wrote: Il 21/02/2014 18:57, Liu, Jinsong ha scritto: - F(BMI2) | F(ERMS) | f_invpcid | F(RTM) | F(RDSEED) | + F(BMI2) | F(ERMS) | f_invpcid | F(RTM) | F(MPX) | F(RDSEED) | F(ADX); MPX also needs to be conditional on

[Qemu-devel] [PATCH v5 0/3] KVM: x86: enable Intel MPX for KVM

2014-02-24 Thread Liu, Jinsong
These patches are version 5 to enable Intel MPX for KVM. Version 1: * Add some Intel MPX definiation * Fix a cpuid(0x0d, 0) exposing bug, dynamic per XCR0 features enable/disable * vmx and msr handle for MPX support at KVM * enalbe MPX feature for guest Version 2: * remove generic MPX

[Qemu-devel] [PATCH v5 1/3] KVM: x86: Intel MPX vmx and msr handle

2014-02-24 Thread Liu, Jinsong
From caddc009a6d2019034af8f2346b2fd37a81608d0 Mon Sep 17 00:00:00 2001 From: Liu Jinsong jinsong@intel.com Date: Mon, 24 Feb 2014 18:11:11 +0800 Subject: [PATCH v5 1/3] KVM: x86: Intel MPX vmx and msr handle This patch handle vmx and msr of Intel MPX feature. Signed-off-by: Xudong Hao

[Qemu-devel] [PATCH v5 2/3] KVM: x86: add MSR_IA32_BNDCFGS to msrs_to_save

2014-02-24 Thread Liu, Jinsong
From 5d5a80cd172ea6fb51786369bcc23356b1e9e956 Mon Sep 17 00:00:00 2001 From: Liu Jinsong jinsong@intel.com Date: Mon, 24 Feb 2014 18:11:55 +0800 Subject: [PATCH v5 2/3] KVM: x86: add MSR_IA32_BNDCFGS to msrs_to_save Add MSR_IA32_BNDCFGS to msrs_to_save, and corresponding logic to

[Qemu-devel] [PATCH v5 3/3] KVM: x86: Enable Intel MPX for guest

2014-02-24 Thread Liu, Jinsong
From 44c2abca2c2eadc6f2f752b66de4acc8131880c4 Mon Sep 17 00:00:00 2001 From: Liu Jinsong jinsong@intel.com Date: Mon, 24 Feb 2014 18:12:31 +0800 Subject: [PATCH v5 3/3] KVM: x86: Enable Intel MPX for guest This patch enable Intel MPX feature to guest. Signed-off-by: Xudong Hao

Re: [Qemu-devel] [PATCH v5 3/3] KVM: x86: Enable Intel MPX for guest

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 11:58, Liu, Jinsong ha scritto: @@ -599,6 +599,9 @@ int __kvm_set_xcr(struct kvm_vcpu *vcpu, u32 index, u64 xcr) u64 old_xcr0 = vcpu-arch.xcr0; u64 valid_bits; + if (!kvm_x86_ops-mpx_supported || !kvm_x86_ops-mpx_supported()) + xcr0 =

Re: [Qemu-devel] [PATCH] hw/9pfs: use g_strdup_printf() instead of PATH_MAX limitation

2014-02-24 Thread Gang Chen
Firstly, thank you very much for your reviewing. :-) On 02/24/2014 05:22 PM, Markus Armbruster wrote: Chen Gang gang.chen.5...@gmail.com writes: When path is truncated by PATH_MAX limitation, it causes QEMU to access incorrect file. So use original full path instead of PATH_MAX within 9pfs

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Fam Zheng
On Mon, 02/24 11:39, Paolo Bonzini wrote: Il 24/02/2014 02:01, Fam Zheng ha scritto: I would do this in qcow2: 1. In qcow2_co_writev, allocate cluster regardless of if data is zero or not. 2. If data is zero, set QCOW2_OFLAG_ZERO in L2. This is (or should be) bdrv_co_write_zeroes

Re: [Qemu-devel] hotplug: VM got stuck when attaching a pass-through device to the non-pass-through VM for the first time

2014-02-24 Thread Zhanghaoyu (A)
I agree it's either COW breaking or (similarly) locking pages that the guest hasn't touched yet. You can use prealloc or -rt mlock=on to avoid this problem. Paolo Or the new shared flag - IIRC shared VMAs don't do COW either. Only if the problem isn't locking and zeroing of

Re: [Qemu-devel] [PATCH 2/2] qtest: fix a !chr-fd_in_tag assertion error in qtest.

2014-02-24 Thread Gal Hammer
On 24/02/2014 12:32, Paolo Bonzini wrote: Il 24/02/2014 11:16, Gal Hammer ha scritto: Replacement of the default chardev handlers now requires a call to release the current handlers. Signed-off-by: Gal Hammer gham...@redhat.com --- monitor.c | 1 + qtest.c | 2 ++ 2 files changed, 3

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Peter Lieven
On 24.02.2014 11:38, Paolo Bonzini wrote: Il 24/02/2014 11:26, Peter Lieven ha scritto: I personally do not need this for QCOW2 but for iSCSI. Here the optimization is basically saved bandwidth since a zero write becomes a WRITESAME. It saves bandwidth, but at the potential cost of extra

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 12:33, Fam Zheng ha scritto: This is (or should be) bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP. But IIUC bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP doesn't require cluster allocation if it's allocated yet, which is a bit different. Yeah, that's why I wrote or should

[Qemu-devel] [PATCH 04/44] console: export QemuConsole index, width, height

2014-02-24 Thread Gerd Hoffmann
Add functions to query QemuConsole properties. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 3 +++ ui/console.c | 24 2 files changed, 27 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 4156a87..8543d18

[Qemu-devel] [PATCH 02/44] sdl2: baum build fix

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- backends/baum.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/baum.c b/backends/baum.c index 1132899..665107f 100644 --- a/backends/baum.c +++ b/backends/baum.c @@ -566,7 +566,7 @@ CharDriverState

[Qemu-devel] [PATCH 10/44] input: keyboard: add helper functions to core

2014-02-24 Thread Gerd Hoffmann
A bunch of helper functions to manage keyboard events, to make life simpler for the ui code when submitting keyboard events. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 5 + ui/input.c | 35 +++ 2 files changed, 40

[Qemu-devel] [PATCH 08/44] input: qapi: add pause key

2014-02-24 Thread Gerd Hoffmann
It's missing. Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index eafc746..a5729af 100644 --- a/qapi-schema.json +++

[Qemu-devel] [PATCH 33/44] input-legacy: remove kbd_mouse_has_absolute

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 3 --- ui/input-legacy.c| 21 ++--- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index c7f4e4f..53e956d 100644 --- a/include/ui/console.h

[Qemu-devel] [PATCH 34/44] input-legacy: remove kbd_mouse_is_absolute

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 1 - ui/input-legacy.c| 11 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 53e956d..21b32e4 100644 --- a/include/ui/console.h +++

[Qemu-devel] [PATCH 11/44] input: keyboard: switch legacy handlers to new core

2014-02-24 Thread Gerd Hoffmann
legacy kbd event handlers are registered in the new core, so they receive events from the new input core code. keycode - scancode translation needed here. legacy kbd_put_keycode() sends events to the new core. scancode - keycode translation needed here. So with this patch the new input core is

[Qemu-devel] [PATCH 14/44] input: keyboard: switch sdl ui to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/sdl.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 736bb95..c3b8036 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -32,6 +32,7 @@ #include qemu-common.h #include

[Qemu-devel] [PATCH 26/44] input: mouse: switch vnc ui to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc.c | 46 ++ ui/vnc.h | 1 + 2 files changed, 23 insertions(+), 24 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 4658559..7dfc94a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1484,7 +1484,7 @@

[Qemu-devel] [PATCH 35/44] input-legacy: remove kbd_mouse_event

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 1 - ui/input-legacy.c| 49 - 2 files changed, 50 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 21b32e4..71a0da3 100644 ---

[Qemu-devel] [PATCH 32/44] input-legacy: remove kbd_put_keycode

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 1 - ui/input-legacy.c| 23 --- 2 files changed, 24 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index a3062d0..c7f4e4f 100644 --- a/include/ui/console.h +++

[Qemu-devel] [PATCH 18/44] input: keyboard: switch curses ui to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/curses.c | 47 +-- 1 file changed, 25 insertions(+), 22 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index dbc3d5e..b044790 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -30,6 +30,7 @@

[Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-24 Thread Gerd Hoffmann
Hi, The input layer moves to a model modeled roughly after the linux event layer. It also uses qapi to create all the data types needed. First, because it is convinient to have all the support code generated, and also to make it easier to integrate with qmp some day. Porting work has only be

[Qemu-devel] [PATCH 07/44] input: qapi: add unmapped key

2014-02-24 Thread Gerd Hoffmann
Simplifies building something - QkeyCode mapping tables. Uninitialized entries can easily identified then. Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- qapi-schema.json | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 06/44] input: qapi: define event types

2014-02-24 Thread Gerd Hoffmann
Define input event types, using qapi. So we get nicely autogenerated types for our input events. And when it comes to qmp support some day things will be a lot easier. Types are modeled after the linux input layer. There are separate event types for each value. There is a sync to indicate the

[Qemu-devel] [PATCH 31/44] input: trace events

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- trace-events | 8 ui/input.c | 48 2 files changed, 56 insertions(+) diff --git a/trace-events b/trace-events index 3713063..129a3b4 100644 --- a/trace-events +++ b/trace-events @@

[Qemu-devel] [PATCH 19/44] input: mouse: add helpers functions to core

2014-02-24 Thread Gerd Hoffmann
Likewise a bunch of helper functions to manage mouse button and movement events, again to make life easier for the ui code. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 14 +++ ui/input.c | 71 ++ 2

[Qemu-devel] [PATCH 42/44] input: remove index_from_keycode (no users)

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 1 - ui/input-legacy.c| 14 -- 2 files changed, 15 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 9a282cb..3bf69ee 100644 --- a/include/ui/console.h +++ b/include/ui/console.h

[Qemu-devel] [PATCH 01/44] ui/sdl2 : initial port to SDL 2.0 (v2.0)

2014-02-24 Thread Gerd Hoffmann
From: Dave Airlie airl...@redhat.com I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. The biggest changes were in the input handling, where SDL2 has done a major overhaul, and I've had to include a generated translation file to get from SDL2 codes back to qemu

[Qemu-devel] [PATCH 36/44] input: move mouse mode notifier to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 4 include/ui/input.h | 4 ui/input-legacy.c| 34 +- ui/input.c | 30 ++ 4 files changed, 35 insertions(+), 37 deletions(-) diff --git

[Qemu-devel] [PATCH 24/44] input: mouse: switch sdl ui to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/sdl.c | 84 ++-- 1 file changed, 39 insertions(+), 45 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index c3b8036..c1a16be 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -353,7 +353,7 @@

[Qemu-devel] [PATCH 17/44] input: keyboard: switch spice ui to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/spice-input.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index 3beb8de..c9df699 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -26,12 +26,15 @@

[Qemu-devel] [PATCH 15/44] sdl2: switch keyboard handling to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/sdl2.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index e7a30b3..ac3ac19 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -33,6 +33,7 @@ #include qemu-common.h #include

[Qemu-devel] [PATCH 28/44] input: mouse: switch monitor to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- monitor.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index de90fba..8f7e1a9 100644 --- a/monitor.c +++ b/monitor.c @@ -39,6 +39,7 @@ #include monitor/monitor.h

[Qemu-devel] [PATCH 30/44] input: mouse: switch cocoa ui to new core

2014-02-24 Thread Gerd Hoffmann
Build fixes by Peter Maydell. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 2 ++ ui/cocoa.m | 63 ++-- 2 files changed, 44 insertions(+), 21 deletions(-) diff --git a/include/ui/console.h

[Qemu-devel] [PATCH 16/44] input: keyboard: switch vnc ui to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5601cc3..4658559 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -33,6 +33,7 @@ #include qapi/qmp/types.h #include

[Qemu-devel] [PATCH 43/44] console: add head to index to qemu consoles.

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/arm/musicpal.c| 2 +- hw/display/blizzard.c| 2 +- hw/display/cirrus_vga.c | 4 ++-- hw/display/exynos4210_fimd.c | 2 +- hw/display/g364fb.c | 2 +- hw/display/jazz_led.c| 2 +-

[Qemu-devel] [PATCH 37/44] input: add input_mouse_mode tracepoint

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- trace-events | 1 + ui/input.c | 1 + 2 files changed, 2 insertions(+) diff --git a/trace-events b/trace-events index 129a3b4..7fd2432 100644 --- a/trace-events +++ b/trace-events @@ -1027,6 +1027,7 @@ input_event_btn(int conidx, const char

[Qemu-devel] [PATCH 25/44] sdl2: switch mouse handling to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/sdl2.c | 60 +++- 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index ac3ac19..e841424 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -329,7 +329,7 @@

[Qemu-devel] [PATCH 13/44] input: keyboard: switch gtk ui to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index a633d89..74c0936 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -59,6 +59,7 @@ #include trace.h #include ui/console.h

[Qemu-devel] [PATCH 38/44] sdl2: simplify keymap handling

2014-02-24 Thread Gerd Hoffmann
sdl2 gives us scancodes (i.e. identifies keys by location not by keysym mapped to it). We can map them directly to QKeyCodes, pass them on to the new input core and be done with it. No need to jump though any keymap hops. Zap the code. Also operate directly on SDL scancodes for any hotkeys.

[Qemu-devel] [PATCH 22/44] input: mouse: switch legacy handlers to new core

2014-02-24 Thread Gerd Hoffmann
legacy mouse event handlers are registered in the new core, so they receive events submitted to the new input core. legacy kbd_mouse_event() continues to use the old code paths. So new-core event handlers wouldn't see events submitted via kbd_mouse_event. This leads to the constrain that we we

[Qemu-devel] [PATCH 40/44] input: move qmp_query_mice to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/input-legacy.c | 23 --- ui/input.c| 29 + 2 files changed, 29 insertions(+), 23 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 7f8e72b..7843482 100644 ---

[Qemu-devel] [PATCH v2 2/2] acpi-test: issue errors instead of warnings when possible

2014-02-24 Thread Marcel Apfelbaum
If the expected (offline) acpi tables loaded correctly, it is safe to assume the iasl installation is OK and issue an error if the actual tables differ from expected ones. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- tests/acpi-test.c | 24 1 file changed, 16

[Qemu-devel] [PATCH 1/1] qxl: add sanity check

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- hw/display/qxl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 1471cc0..2a559eb 100644 --- a/hw/display/qxl.c +++

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Kevin Wolf
Am 24.02.2014 um 12:51 hat Paolo Bonzini geschrieben: Il 24/02/2014 12:33, Fam Zheng ha scritto: This is (or should be) bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP. But IIUC bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP doesn't require cluster allocation if it's allocated yet, which

[Qemu-devel] [PATCH 21/44] input: mouse: add qemu_input_is_absolute()

2014-02-24 Thread Gerd Hoffmann
Same as kbd_mouse_is_absolute(), but using new input core. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 1 + ui/input.c | 8 2 files changed, 9 insertions(+) diff --git a/include/ui/input.h b/include/ui/input.h index c6f50c2..28afc45 100644 ---

[Qemu-devel] [PATCH 29/44] input: keyboard: switch cocoa ui to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/cocoa.m | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 8661777..d4af3e5 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -514,16 +514,14 @@ QemuCocoaView *cocoaView;

[Qemu-devel] [PATCH v2 0/2] acpi-test: issue errors instead of warnings when possible

2014-02-24 Thread Marcel Apfelbaum
v1-v2: Addressed Michael S. Tsirkin's comments: - Split the path into 2 patches - First patch retains both asl and aml files on failure. - Second one guesses that iasl installation is OK by checking that no error was returned when the expected tables were

Re: [Qemu-devel] [PATCH 30/44] input: mouse: switch cocoa ui to new core

2014-02-24 Thread Andreas Färber
Hi Gerd, If this is a v2 of your PULL, please update your scripts to label the patches PULL rather than PATCH, as requested by mst. This is to avoid confusion as to whether patches should still be reviewed or not. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg,

[Qemu-devel] [PATCH 23/44] input: mouse: switch gtk ui to new core

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 58 +++--- 1 file changed, 19 insertions(+), 39 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 74c0936..1851495 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -194,7 +194,7 @@ static

[Qemu-devel] [PATCH 39/44] sdl2: codestyle fixups

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/Makefile.objs | 2 +- ui/sdl2.c| 173 +-- 2 files changed, 104 insertions(+), 71 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index e6a5ec1..6f2294e 100644 ---

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Fam Zheng
On Mon, 02/24 12:51, Paolo Bonzini wrote: Il 24/02/2014 12:33, Fam Zheng ha scritto: This is (or should be) bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP. But IIUC bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP doesn't require cluster allocation if it's allocated yet, which is a bit

[Qemu-devel] [PULL 0/1] spice patch queue

2014-02-24 Thread Gerd Hoffmann
Hi, Pretty short this time, just a single bugfix. please pull, Gerd The following changes since commit 105a060188dc6fdd4551571a966514d1a5f6815a: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140220' into staging (2014-02-21 15:04:58 +) are available in the

Re: [Qemu-devel] [PATCH] libvixl: Fix typo in comment

2014-02-24 Thread Peter Maydell
On 21 February 2014 19:54, Stefan Weil s...@weilnetz.de wrote: * substract - subtract Signed-off-by: Stefan Weil s...@weilnetz.de --- disas/libvixl/a64/constants-a64.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) It seems like a bad idea to make more changes than necessary to a

[Qemu-devel] [PULL 0/1] audio patch queue

2014-02-24 Thread Gerd Hoffmann
Hi, Short audio patch queue, with a single cleanup patch. please pull, Gerd The following changes since commit 105a060188dc6fdd4551571a966514d1a5f6815a: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140220' into staging (2014-02-21 15:04:58 +) are available

[Qemu-devel] [PULL 1/1] hda-audio: qom cleanups

2014-02-24 Thread Gerd Hoffmann
Add HDA_AUDIO type and macro, drop DO_UPCAST(). Had to add a abstract hda audio class as parent for all hda-* variants to make that fly. Killed some init code duplication while being at it. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Kevin Wolf
Am 24.02.2014 um 13:10 hat Paolo Bonzini geschrieben: Il 24/02/2014 13:07, Kevin Wolf ha scritto: Yeah, that's why I wrote or should be. Those are the intended semantics of bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP: always allocate a cluster that will read as zeroes (allocating even

Re: [Qemu-devel] Error compiling qemu from source on Ubuntu 12.10

2014-02-24 Thread Peter Maydell
On 21 February 2014 21:41, Jobin Raju George jobin...@gmail.com wrote: To fix this issue: I cloned dtc from its repository and extracted the tarball to qemu/dtc/. Why not just do the git submodule command that the error message from configure suggests? You don't need to manually stick the

Re: [Qemu-devel] [PULL 1/1] hda-audio: qom cleanups

2014-02-24 Thread Andreas Färber
Am 24.02.2014 13:22, schrieb Gerd Hoffmann: Add HDA_AUDIO type and macro, drop DO_UPCAST(). Had to add a abstract hda audio class as parent for all hda-* variants to make that fly. Killed some init code duplication while being at it. Cc: Andreas Färber afaer...@suse.de Signed-off-by:

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Paolo Bonzini
Il 24/02/2014 13:07, Kevin Wolf ha scritto: Yeah, that's why I wrote or should be. Those are the intended semantics of bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP: always allocate a cluster that will read as zeroes (allocating even if it does not necessarily write the zeroes). Which

[Qemu-devel] [PATCH 05/44] input: rename file to legacy

2014-02-24 Thread Gerd Hoffmann
Rename ui/input.c to ui/input-legacy.c. We are going to replace it step by step. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/Makefile.objs | 2 +- ui/{input.c = input-legacy.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename ui/{input.c = input-legacy.c}

[Qemu-devel] Which settings to use for Intel E3-1225V2?

2014-02-24 Thread Peter Littmann
Hello, welike to use our rescue system on a remote server at a hosting provider of dedicated servers(kimsufi.com) as QEMU host to install a operating systems like Linux or Windows on these servers. What settings would you suggest to use in case of the cpu is a E3-1225V2 (shouldbe IvyBridge)

Re: [Qemu-devel] [PULL 1/1] hda-audio: qom cleanups

2014-02-24 Thread Gerd Hoffmann
On Mo, 2014-02-24 at 13:32 +0100, Andreas Färber wrote: Am 24.02.2014 13:22, schrieb Gerd Hoffmann: Add HDA_AUDIO type and macro, drop DO_UPCAST(). Had to add a abstract hda audio class as parent for all hda-* variants to make that fly. Killed some init code duplication while being at

[Qemu-devel] [PATCH 03/44] sdl2: remove text console logic

2014-02-24 Thread Gerd Hoffmann
sdl2 explicitly binds windows to graphics consoles. No need to handle non-graphic consoles anywhere. Also console switching is pointless. Zap code. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/sdl2.c | 117 +- 1 file changed,

Re: [Qemu-devel] [PATCH] hw/9pfs: use g_strdup_printf() instead of PATH_MAX limitation

2014-02-24 Thread Markus Armbruster
Gang Chen gang.chen.5...@gmail.com writes: Firstly, thank you very much for your reviewing. :-) On 02/24/2014 05:22 PM, Markus Armbruster wrote: Chen Gang gang.chen.5...@gmail.com writes: When path is truncated by PATH_MAX limitation, it causes QEMU to access incorrect file. So use

Re: [Qemu-devel] [PATCHv2 00/18] qemu-iotests: adjust tests to work with the NFS protocol

2014-02-24 Thread Stefan Hajnoczi
On Sun, Jan 05, 2014 at 06:21:50PM +0100, Peter Lieven wrote: In order to proceed with the integration of the NFS protocol driver into qemu I was asked by Stefan to add integration for NFS into the qemu-iotests. Unfortunately, this became more complex than I had expected because most of the

[Qemu-devel] [PATCH 44/44] console: add QemuUIInfo

2014-02-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 12 ui/console.c | 17 + 2 files changed, 29 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index b2af53e..08a38ea 100644 --- a/include/ui/console.h +++

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-24 Thread Janne Grunau
Hi, On 2014-02-17 13:40:00 +, Alex Bennée wrote: After a solid few months of work the QEMU master branch [1] has now reached instruction feature parity with the suse-1.6 [6] tree that a lot of people have been using to build various aarch64 binaries. In addition to the SUSE work we have

Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes

2014-02-24 Thread Peter Lieven
On 24.02.2014 11:38, Paolo Bonzini wrote: Il 24/02/2014 11:26, Peter Lieven ha scritto: I personally do not need this for QCOW2 but for iSCSI. Here the optimization is basically saved bandwidth since a zero write becomes a WRITESAME. It saves bandwidth, but at the potential cost of extra

[Qemu-devel] [PATCH 20/44] input: mouse: add graphic_rotate support

2014-02-24 Thread Gerd Hoffmann
Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absolute and relative events, but the logic is broken for relative coordinates, so this is most likely not used anyway. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/input.c | 33

Re: [Qemu-devel] [PATCH] scsi-bus: Fix transfer length for VERIFY with BYTCHK=11b

2014-02-24 Thread Markus Armbruster
Ping? Markus Armbruster arm...@redhat.com writes: The transfer length depends on field BYTCHK, which is encoded in byte 1, bits 1..2. However, the guard for for case BYTCHK=11b doesn't work, and we get case 01b instead. Fix it. Note that since emulated scsi-hd fails the command outright,

Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files

2014-02-24 Thread Andreas Färber
Am 23.02.2014 18:02, schrieb Stefan Weil: These header files are used by most QEMU source files. If they depend on windows.h, all those source files do so, too. All Windows specific data types which are replaced use identical definitions for the 32 and 64 bit Windows APIs. HANDLE and LONG

[Qemu-devel] [PATCH 09/44] input: add core bits of the new input layer

2014-02-24 Thread Gerd Hoffmann
Register and unregister handlers. Event dispatcher code. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 32 + ui/Makefile.objs | 2 +- ui/input.c | 83 ++ 3 files changed, 116

Re: [Qemu-devel] [PATCH] drive-mirror: Change the amount of data base on granularity

2014-02-24 Thread Stefan Hajnoczi
On Sat, Jan 18, 2014 at 08:09:43AM +, Chentao (Boby) wrote: Please CC Kevin Wolf kw...@redhat.com who co-maintains the QEMU block layer with me. Use scripts/get_maintainer.pl -f block/mirror.c to find the list of maintainers to CC. Before, one iteration send the amount of data is

[Qemu-devel] [PATCH v2 1/2] acpi-test: retain both asl and aml files on failure

2014-02-24 Thread Marcel Apfelbaum
Updated the error message while at it. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- tests/acpi-test.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/acpi-test.c b/tests/acpi-test.c index 31f5359..2ce8c18 100644 --- a/tests/acpi-test.c +++

  1   2   3   >