Re: [Qemu-devel] [snabb-devel] Re: Make virtio-net.c ring size configurable?

2014-02-28 Thread Luke Gorrie
On 27 February 2014 15:49, Michael S. Tsirkin m...@redhat.com wrote: Michael: Luke has asked to increase the virtio-net virtqueue size. Thoughts? Stefan Heh you want to increase the bufferbloat? I'm sensitive to this. (I have actually built a commercial anti-bufferbloat network device

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 05:55, Michael S. Tsirkin ha scritto: Why? We already have different ACPI tables for TCG vs KVM. Specifically apic interrupt override flag in MADT is set for KVM but not TCG. It used to be this way, but bool kvm_allows_irq0_override(void) { return

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 05:55, Michael S. Tsirkin ha scritto: Why? We already have different ACPI tables for TCG vs KVM. Specifically apic interrupt override flag in MADT is set for KVM but not TCG. It used to be this way, but bool kvm_allows_irq0_override(void) { return

[Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Anton Ivanov (antivano)
Hi all, On behalf of Cisco Systems I am authorized to contribute a new transport to the network subsystem in qemu. Specifically, we would like to contribute a new transport: L2TPv3 static tunnel network transport. Earlier versions of this (we have patchsets going back to qemu-1.0) have been

Re: [Qemu-devel] [PATCH] tcg/aarch64: refactoring, remove inline magic insn numbers

2014-02-28 Thread Claudio Fontana
ping? Richard, do you prefer to spin your polishing from last year instead? We can start with the pure refactoring patch as you suggested, and in this case, you could look here for some things I'd look for, in particular that we move gradually, that we group instructions that are handled in a

Re: [Qemu-devel] [PATCH 1/7] XBZRLE: Fix one XBZRLE corruption issues

2014-02-28 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: The page may not be inserted into cache after executing save_xbzrle_page. In case of failure to insert, the original page should be sent rather than the page in the cache. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by:

[Qemu-devel] [PULL 06/22] s390x/virtio-hcall: Specification exception for illegal subcodes

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com So far, the DIAG 500 hypervisor call was only setting -EINVAL in R2 when a guest tried to call this function with an illegal subcode. This patch now changes the behavior so that a specification exception is thrown instead, since this is the common

[Qemu-devel] [PULL 05/22] s390x/virtio-hcall: Add range check for hypervisor call

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com The handler for diag 500 did not check whether the requested function was in the supported range, so illegal values could crash QEMU in the worst case. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck

[Qemu-devel] [PULL 10/22] s390x/sclp: Fixed setting of condition code register

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com In the SCLP handler function, the condition code register must only be set if no exception occured. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Christian Borntraeger

[Qemu-devel] [PULL 03/22] s390x/async_pf: Check for apf extension and enable pfault

2014-02-28 Thread Christian Borntraeger
From: Dominik Dingel din...@linux.vnet.ibm.com S390 can also use async page faults, to enhance guest scheduling. In case of live migration we want to disable the feature and let all pending request finish. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com Signed-off-by: Jens Freimann

[Qemu-devel] [PULL 09/22] s390x/sclp: Add missing checks to SCLP handler

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com If the 51 most significant bits of the SCCB address are zero or equal to the prefix, we should throw an specification exception, too. Also moved the check for privileged mode to sclp_service_call() to have all program checks in one place now.

[Qemu-devel] [PULL 15/22] s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx

2014-02-28 Thread Christian Borntraeger
The current code does not initialize next_idx in the virtio ring. As the ccw bios will always use guest memory at a fixed location, this queue might != 0 after a reboot. Lets make the initialization explicit. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Reviewed-by: Cornelia Huck

[Qemu-devel] [PULL 01/22] update linux headers to kvm/next

2014-02-28 Thread Christian Borntraeger
This updates the kvm headers to commit d3714010c307d26df251c45be9cd12ab6d41f0c4 KVM: x86: emulator_cmpxchg_emulated should mark_page_dirty in kvm/next. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- linux-headers/asm-arm/kvm.h | 28 +

[Qemu-devel] [PULL 11/22] s390x/event-facility: some renaming

2014-02-28 Thread Christian Borntraeger
From: Heinz Graalfs graa...@linux.vnet.ibm.com Do some renaming to shorten some identifiers and to emphasize sclp. Signed-off-by: Heinz Graalfs graa...@linux.vnet.ibm.com Acked-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com ---

[Qemu-devel] [PULL 07/22] s390x/eventfacility: mask out commands

2014-02-28 Thread Christian Borntraeger
As a followup to commit 5f04c14a10fa7f259bc0808f35a0beda49f7821e (s390-sclp: Define New SCLP Codes) we should mask the sclp command not only in base sclp, but also in the event facility. Based on an initial patch from Ralf Hoppe. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com ---

[Qemu-devel] [PULL 21/22] s390x/kvm: Rework priv instruction handlers

2014-02-28 Thread Christian Borntraeger
From: Frank Blaschka blasc...@linux.vnet.ibm.com The current implementation uses the second byte of the instruction to identify the instruction handler. This is not sufficient to support instructions not starting with 0xb2. This patch adds separate handlers for 0xb2, 0xb9 and 0xeb to be able to

[Qemu-devel] [PULL 20/22] s390x/kvm: Add missing SIGP CPU RESET order

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com The SIGP order CPU RESET was still missing in the list of our supported handler. This patch now adds a simple implementation, by using the cpu_reset() function that is already available in target-s390x/cpu.c. Signed-off-by: Thomas Huth

[Qemu-devel] [PULL 16/22] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css

2014-02-28 Thread Christian Borntraeger
We have to set the cssid to 0, otherwise the stsch code will return an operand exception without the m bit. In the same way we should set m=0. This case was triggered in some cases during reboot, if for some reason the location of blk_schid.cssid contains 1 and m was 0. Turns out that the qemu

[Qemu-devel] [PULL 02/22] s390x/kvm: implement floating-interrupt controller device

2014-02-28 Thread Christian Borntraeger
From: Jens Freimann jf...@linux.vnet.ibm.com This patch implements a floating-interrupt controller device (flic) which interacts with the s390 flic kvm_device. Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Christian

[Qemu-devel] [PULL 19/22] s390x/kvm: Rework SIGP INITIAL CPU RESET handler

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com The s390_cpu_initial_reset() function had two deficiencies: First, it used an ioctl for the destination CPU, and this ioctl could block nearly forever, as long as the destination CPU was running in the SIE loop. Second, it also cleared the general

[Qemu-devel] [PULL 13/22] s390x/event-facility: add support for live migration

2014-02-28 Thread Christian Borntraeger
From: Heinz Graalfs graa...@linux.vnet.ibm.com Add support for live migration using VMStateDescription. Signed-off-by: Heinz Graalfs graa...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com ---

[Qemu-devel] [PULL 14/22] s390x/event-facility: exploit realize/unrealize

2014-02-28 Thread Christian Borntraeger
From: Heinz Graalfs graa...@linux.vnet.ibm.com init/exit functionality of abstract SCLPEvent class is now exploiting realize/unrealize. Signed-off-by: Heinz Graalfs graa...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Christian Borntraeger

[Qemu-devel] [PULL 04/22] s390x/kvm: Fixed bad SIGP SET-ARCHITECTURE handler

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com The SET-ARCHITECTURE handler in QEMU caused a program interruption. This is wrong according to the Principles of Operations specification (since SIGP should never cause a program interrupt) and was likely only introduced for debugging purposes. Since we

[Qemu-devel] [PULL 22/22] s390x/ipl: Fix crash of ELF images with arbitrary entry points

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com When loading S390 kernels, the current code expects an ELF file with the start address 0x1. Other ELF files cause a segmentation fault. To avoid these crashes, we should get the start address from the ELF file instead of always using a hard-coded

[Qemu-devel] [PULL 18/22] s390x/cpu: Use ioctl to reset state in the kernel

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com Some of the state in the kernel can not be reset from QEMU yet. For this we've got to use the KVM_S390_INITIAL_RESET ioctl to make sure that the state in the kernel is set to the right values during initial CPU reset, too. Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-02-28 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: Add counters to log the times of updating the dirty bitmap. Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- arch_init.c | 20

Re: [Qemu-devel] [PATCH v4] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-28 Thread Mark Cave-Ayland
On 26/02/14 17:25, Peter Maydell wrote: On 26 February 2014 16:59, Fabien Chouteauchout...@adacore.com wrote: On 02/26/2014 08:56 AM, Sebastian Huber wrote: Hello, exists there someone who is able to commit this? I'm sorry Sebastian, as you probably understood the SPARC maintainer is

Re: [Qemu-devel] [PATCH 3/7] XBZRLE: optimize XBZRLE to decrease the cache missing

2014-02-28 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: Avoid the hot pages cache replacing by others to remarkable decrease cache missing. The counter of updating dirty bitmap is used to indicate the cached page age. It seems worth noting that you've changed 'it_age's use - that's ok, but perhaps

Re: [Qemu-devel] [PATCH 4/7] XBZRLE: rebuild the cache_is_cached function

2014-02-28 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: Rebuild the cache_is_cached function. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- page_cache.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-)

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Paolo Bonzini
This transport uses a linux specific call to get several GBit RX rate. Might as well mention that it's recvmmsg. :) This call can be wrapped (at some cost) in a compatibility loop using posix compliant recvmsg instead for other systems. As I am not familiar with the fine details on how to add

Re: [Qemu-devel] [PATCH] pseries: Update SLOF firmware image to 20140204

2014-02-28 Thread Stefan Hajnoczi
On Fri, Feb 21, 2014 at 09:24:47AM +0100, Alexander Graf wrote: Anthony / Stefan, could you please update the SLOF.git mirror on git.qemu.org? Done. The SLOT.git mirror should now update automatically every day. Please let me know if you notice any issues. Stefan

[Qemu-devel] [PULL 00/22] s390/kvm: features, fixes and cleanups for 2.0

2014-02-28 Thread Christian Borntraeger
Anthony, Peter, The following changes since commit d5001cf787ad0514839a81d0f2e771e01e076e21: xilinx: Delete hw/include/xilinx.h (2014-02-26 14:54:45 +1000) are available in the git repository at: git://github.com/borntraeger/qemu.git tags/kvm-s390-20140227 for you to fetch changes up to

Re: [Qemu-devel] [PATCH 0/7] migration: Optimization the xbzrle and fix two corruption issues

2014-02-28 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: Hi, a. Optimization the xbzrle remarkable decrease the cache misses. The efficiency of compress increases more than fifty times. Before the patch set, the cache almost totally miss when the number of cache item less than the

[Qemu-devel] [PULL 08/22] s390x/sclp: Fixed the size of sccb and code parameter

2014-02-28 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com The pointer to the SCCB should not be limited to 32 bits only. In contrast to this, the command word parameter is only 32 bits (the upper 32 bits should be ignored). Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Cornelia Huck

[Qemu-devel] [PATCH 0/2] Small fixes for qemu-sockets ipv4/ipv6 logic.

2014-02-28 Thread Paolo Bonzini
While reviewing the L2TPv3 submission, I wanted to tell Anton that IPv4/IPv6 is already done in qemu-sockets.c. Turns out it is not exactly the case; these patches fixes the two issues I spotted. Paolo Bonzini (2): socket: treat ipv4=on,ipv6=on uniformly socket: handle ipv4/ipv6 in

Re: [Qemu-devel] [PATCH 5/7] migration: Fix the migrate auto converge process

2014-02-28 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: It is inaccuracy and complex that using the transfer speed of migration thread to determine whether the convergence migration. The dirty page may be compressed by XBZRLE or ZERO_PAGE.The counter of updating dirty bitmap will be increasing

[Qemu-devel] [PULL 12/22] s390x/event-facility: code restructure

2014-02-28 Thread Christian Borntraeger
From: Heinz Graalfs graa...@linux.vnet.ibm.com Code restructure in order to simplify class hierarchy - remove S390SCLPDevice abstract base class and move function pointers into new SCLPEventFacilityClass - implement SCLPEventFacility as SysBusDevice - use define constants for instance

[Qemu-devel] [PATCH 1/2] socket: treat ipv4=on,ipv6=on uniformly

2014-02-28 Thread Paolo Bonzini
In some cases, ipv4=on,ipv6=on means try both kinds of address; in others, it means try IPv6 only just by virtue of how the code is structured. Fix this to make things more consistent, and adjust coding style too. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- util/qemu-sockets.c | 33

[Qemu-devel] [PULL 17/22] s390-ccw.img: new binary rom to match latest fixes

2014-02-28 Thread Christian Borntraeger
Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- pc-bios/s390-ccw.img | Bin 9336 - 9336 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index

[Qemu-devel] [PATCH 2/2] socket: handle ipv4/ipv6 in socket_dgram

2014-02-28 Thread Paolo Bonzini
We were forgetting to set the ipv4 and ipv6 QemuOpts properties, so socket_dgram was always trying _both_ ipv4 and ipv6. Forward the properties correctly. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- util/qemu-sockets.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff

Re: [Qemu-devel] migrate to fd - how to use with HMP?

2014-02-28 Thread Stefan Hajnoczi
On Fri, Feb 28, 2014 at 03:05:12PM +1100, Alexey Kardashevskiy wrote: However once socket_scm_helper talked to mon (./qemu.monitor), I cannot get any response from it via socat UNIX-CONNECT:./qemu.monitor STDIN. Have you tried with QMP? Perhaps the HMP monitor handles connect/disconnect

Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents

2014-02-28 Thread Stefan Hajnoczi
On Thu, Feb 27, 2014 at 11:15:22AM +0100, Peter Lieven wrote: Signed-off-by: Peter Lieven p...@kamp.de --- block/vmdk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan

Re: [Qemu-devel] migrate to fd - how to use with HMP?

2014-02-28 Thread Alexey Kardashevskiy
On 02/28/2014 09:27 PM, Stefan Hajnoczi wrote: On Fri, Feb 28, 2014 at 03:05:12PM +1100, Alexey Kardashevskiy wrote: However once socket_scm_helper talked to mon (./qemu.monitor), I cannot get any response from it via socat UNIX-CONNECT:./qemu.monitor STDIN. Have you tried with QMP? Perhaps

Re: [Qemu-devel] [PATCH 6/7] migraion: optimiztion xbzrle by reducing data copy

2014-02-28 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: Reducing data copy can reduce cpu overheah. (Note a few typos in subject/title) Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- arch_init.c | 8 +++- 1 file changed, 3 insertions(+), 5

[Qemu-devel] [PATCH] q35: Correct typo BRDIGE - BRIDGE

2014-02-28 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan bala...@eik.bme.hu --- hw/pci-host/q35.c | 6 +++--- include/hw/i386/ich9.h| 2 +- include/hw/pci-host/q35.h | 24 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index

Re: [Qemu-devel] [PATCH v4 4/6] qdev: add get_pointer_and_free() for temporary strings

2014-02-28 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 10:53:34AM +0100, Igor Mammedov wrote: On Fri, 21 Feb 2014 15:46:56 +0100 Stefan Hajnoczi stefa...@redhat.com wrote: get_pointer() assumes the string has unspecified lifetime (at least as long as the object is alive). In some cases we can only produce a temporary

Re: [Qemu-devel] [PATCH] pl011: fix corrupting the UARTCR value

2014-02-28 Thread Peter Maydell
On 28 February 2014 01:37, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@linaro.org Offset 4 is UARTRSR/UARTECR, not the UARTCR. As framing and parity errors will never occur, we can ignore writes to this register. It's true that we'll never get framing or parity

Re: [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD)

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 11:41, Joaquim Barrera ha scritto: Thanks for the answer. Something is still not clear to me. Are we in front of a bug (that means, something that could be fixed) or is this behaviour somehow expected for some reason? More and more tests I am doing, I get allways the same

[Qemu-devel] [PATCH v2] q35: Correct typo BRDIGE - BRIDGE

2014-02-28 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan bala...@eik.bme.hu --- v2: Sorry, I was too fast to send it. Found two more places to change. hw/pci-host/q35.c | 10 +- include/hw/i386/ich9.h| 2 +- include/hw/pci-host/q35.h | 24 3 files changed, 18 insertions(+),

Re: [Qemu-devel] [PATCH] build: build block-obj-y explicitly before recursing

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 06:27, Stefan Weil ha scritto: -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y) Using SUBDIR_RULES here instead of SOFTMMU_SUBDIR_RULES (as in my patch) includes more dependencies:

Re: [Qemu-devel] [PATCH 0/7] migration: Optimization the xbzrle and fix two corruption issues

2014-02-28 Thread Gonglei
On 2014/2/28 17:19, Dr. David Alan Gilbert wrote: * Gonglei (Arei) (arei.gong...@huawei.com) wrote: Hi, a. Optimization the xbzrle remarkable decrease the cache misses. The efficiency of compress increases more than fifty times. Before the patch set, the cache almost totally miss

Re: [Qemu-devel] [PATCH 3/7] XBZRLE: optimize XBZRLE to decrease the cache missing

2014-02-28 Thread Gonglei
On 2014/2/28 17:51, Dr. David Alan Gilbert wrote: * Gonglei (Arei) (arei.gong...@huawei.com) wrote: Avoid the hot pages cache replacing by others to remarkable decrease cache missing. The counter of updating dirty bitmap is used to indicate the cached page age. It seems worth noting that

Re: [Qemu-devel] [PATCH 5/7] migration: Fix the migrate auto converge process

2014-02-28 Thread Gonglei
On 2014/2/28 18:16, Dr. David Alan Gilbert wrote: * Gonglei (Arei) (arei.gong...@huawei.com) wrote: It is inaccuracy and complex that using the transfer speed of migration thread to determine whether the convergence migration. The dirty page may be compressed by XBZRLE or ZERO_PAGE.The

Re: [Qemu-devel] [PATCH v4 3/6] iothread: add I/O thread object

2014-02-28 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 11:00:19AM +0100, Igor Mammedov wrote: On Fri, 21 Feb 2014 15:46:55 +0100 Stefan Hajnoczi stefa...@redhat.com wrote: +char *iothread_get_id(IOThread *iothread) +{ +/* The last path component is the identifier */ +char *path =

Re: [Qemu-devel] [PATCH 6/7] migraion: optimiztion xbzrle by reducing data copy

2014-02-28 Thread Gonglei
On 2014/2/28 18:30, Dr. David Alan Gilbert wrote: * Gonglei (Arei) (arei.gong...@huawei.com) wrote: Reducing data copy can reduce cpu overheah. (Note a few typos in subject/title) Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com ---

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Anton Ivanov (antivano)
On 28/02/14 10:02, Paolo Bonzini wrote: This transport uses a linux specific call to get several GBit RX rate. Might as well mention that it's recvmmsg. :) :) This call can be wrapped (at some cost) in a compatibility loop using posix compliant recvmsg instead for other systems. As I am

Re: [Qemu-devel] [PATCH v4] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-28 Thread Fabien Chouteau
On 02/28/2014 10:33 AM, Mark Cave-Ayland wrote: On 26/02/14 17:25, Peter Maydell wrote: On 26 February 2014 16:59, Fabien Chouteauchout...@adacore.com wrote: On 02/26/2014 08:56 AM, Sebastian Huber wrote: Hello, exists there someone who is able to commit this? I'm sorry Sebastian, as

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 12:17, Anton Ivanov (antivano) ha scritto: As mentioned below, I suggest storing the cookies and session ids in host order in NetL2TPV3State, and doing the conversion in l2tpv3_form_header and friends. I can fix it. I prefer to keep all params in ready to use form so that no

Re: [Qemu-devel] [PATCH 0/7] migration: Optimization the xbzrle and fix two corruption issues

2014-02-28 Thread Dr. David Alan Gilbert
* Gonglei (arei.gong...@huawei.com) wrote: On 2014/2/28 17:19, Dr. David Alan Gilbert wrote: * Gonglei (Arei) (arei.gong...@huawei.com) wrote: Hi, a. Optimization the xbzrle remarkable decrease the cache misses. The efficiency of compress increases more than fifty times.

[Qemu-devel] qemu-img cannot convert 280G VHD file to qcow2 rightly

2014-02-28 Thread redtone
Vhd file uslinux01-1.vhd is uploaded to KVM node, the original VHD's size is 290G But when I convert to QCOW2, I find the disk size is 127G, and then I also found the uslinux01-1.vhd disk size is 127G by qemu-img info. Qemu version is 1.7.0 stable [root@raknode01 disk01]# qemu-img convert -f vpc

Re: [Qemu-devel] [PATCH 1/2] socket: treat ipv4=on, ipv6=on uniformly

2014-02-28 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: In some cases, ipv4=on,ipv6=on means try both kinds of address; in others, it means try IPv6 only just by virtue of how the code is structured. Fix this to make things more consistent, and adjust coding style too. Begs the question which one you're

[Qemu-devel] AMD Opteron 6276 to Intel Xeon E5645 live migration failure

2014-02-28 Thread Nick Thomas
Hi there, We recently acquired some of the latter CPUs, and are attempting to add them to our existing cluster of AMD 6200/6300 KVM hosts. My life is made much easier if live migration between all hosts in the cluster works flawlessly, but I can reliably trigger a migration failure when moving a

Re: [Qemu-devel] [PATCH 1/2] socket: treat ipv4=on, ipv6=on uniformly

2014-02-28 Thread Gerd Hoffmann
On Fr, 2014-02-28 at 11:16 +0100, Paolo Bonzini wrote: In some cases, ipv4=on,ipv6=on means try both kinds of address; in others, it means try IPv6 only just by virtue of how the code is structured. @@ -127,10 +127,13 @@ int inet_listen_opts(QemuOpts *opts, int port_offset, Error **errp)

[Qemu-devel] [PATCH 1/2] Add a generic vga device type for that specified by '-device'

2014-02-28 Thread Mark Wu
Some machine (like ppc) initialization code determines if it has vga configured according to vga_interface_type. In the original code, vga_interface_type is evaluated to VGA_NONE even if a vga is added by '-device VGA'. It causes the machine not aware of the graphics device configured. This patch

[Qemu-devel] [PATCH 2/2] Fix return value of vga initlization on ppc

2014-02-28 Thread Mark Wu
Before spapr_vga_init will returned false if the vga is specified by the command '-device VGA' because vga_interface_type was evaluated to VGA_NONE. With the change in previous patch of this series, spapr_vga_init should return true if it's told that the vga will be initialized in flow of the

Re: [Qemu-devel] file_ram_alloc: unify mem-path, mem-prealloc error handling

2014-02-28 Thread Igor Mammedov
On Thu, 27 Feb 2014 19:30:26 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 04/02/2014 19:41, Marcelo Tosatti ha scritto: -mem-prealloc asks to preallocate memory residing on -mem-path path. Currently QEMU exits in case: - Memory file has been created but allocation via explicit

Re: [Qemu-devel] AMD Opteron 6276 to Intel Xeon E5645 live migration failure

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 13:16, Nick Thomas ha scritto: I'd love to get this working, but I'm a little ignorant on where to begin, or even if it's possible at all. Are these CPUs just too old, or is a fixup missing in qemu (or kvm)? It's the latter (in kvm). Note that for migration to work, especially

Re: [Qemu-devel] [PATCH v2] modules: Fix building with --enable-modules

2014-02-28 Thread Peter Maydell
On 26 February 2014 22:31, Fam Zheng f...@redhat.com wrote: Compiling util/modules.c with modules enabled fails now. Fix it by including qemu-common.h before #ifdef testing in module.c. Signed-off-by: Fam Zheng f...@redhat.com Applied, thanks. -- PMM

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Anton Ivanov (antivano)
On 28/02/14 11:36, Paolo Bonzini wrote: Il 28/02/2014 12:17, Anton Ivanov (antivano) ha scritto: As mentioned below, I suggest storing the cookies and session ids in host order in NetL2TPV3State, and doing the conversion in l2tpv3_form_header and friends. I can fix it. I prefer to keep all

Re: [Qemu-devel] [PATCH 0/7] migration: Optimization the xbzrle and fix two corruption issues

2014-02-28 Thread Eric Blake
On 02/27/2014 09:05 PM, Gonglei (Arei) wrote: a. Optimization the xbzrle remarkable decrease the cache misses. The efficiency of compress increases more than fifty times. Before the patch set, the cache almost totally miss when the number of cache item less than the dirty page

Re: [Qemu-devel] AMD Opteron 6276 to Intel Xeon E5645 live migration failure

2014-02-28 Thread Nick Thomas
On 28/02/14 12:57, Paolo Bonzini wrote: Il 28/02/2014 13:16, Nick Thomas ha scritto: I'd love to get this working, but I'm a little ignorant on where to begin, or even if it's possible at all. Are these CPUs just too old, or is a fixup missing in qemu (or kvm)? It's the latter (in kvm).

Re: [Qemu-devel] [PATCH 2/7] migration: Add counters of updating the dirty bitmap

2014-02-28 Thread Eric Blake
On 02/27/2014 09:08 PM, Gonglei (Arei) wrote: Add counters to log the times of updating the dirty bitmap. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- arch_init.c | 20 1 file changed, 20 insertions(+) Is it also

Re: [Qemu-devel] [PATCH 4/7] XBZRLE: rebuild the cache_is_cached function

2014-02-28 Thread Eric Blake
On 02/27/2014 09:10 PM, Gonglei (Arei) wrote: Rebuild the cache_is_cached function. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- page_cache.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-)

Re: [Qemu-devel] [PATCH 2/2] socket: handle ipv4/ipv6 in socket_dgram

2014-02-28 Thread Gerd Hoffmann
On Fr, 2014-02-28 at 11:16 +0100, Paolo Bonzini wrote: -case SOCKET_ADDRESS_KIND_INET: +case SOCKET_ADDRESS_KIND_INET: { +bool ipv4 = remote-inet-ipv4 || !remote-inet-has_ipv4; +bool ipv6 = remote-inet-ipv6 || !remote-inet-has_ipv6; qemu_opt_set(opts, host,

Re: [Qemu-devel] [PATCH 1/2] Add a generic vga device type for that specified by '-device'

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 13:45, Mark Wu ha scritto: Some machine (like ppc) initialization code determines if it has vga configured according to vga_interface_type. In the original code, vga_interface_type is evaluated to VGA_NONE even if a vga is added by '-device VGA'. It causes the machine not aware of

Re: [Qemu-devel] [PATCH 1/1] pc q35: fix handling of lowmem

2014-02-28 Thread Gerd Hoffmann
On Do, 2014-02-27 at 15:01 -0500, Don Slutz wrote: Without this, asking for 3.25G on memory for pc-i440fx-2.0 does not adjust the pci hole to start at 3G. Asking for 3.75G does do this adjustment. This is intentional. If we can fit all ram into low memory, because it is less than 3.5G, we'll

[Qemu-devel] [PATCH] target-arm: Fix incorrect setting of E bit in CPSR

2014-02-28 Thread Peter Maydell
Commit 4cc35614a moved the exception mask bits out of env-uncached_cpsr and into env-daif. However the env-daif contents are AArch64 style mask bits, which include not just the AArch32 AIF bits but also the new D bit (masks debug exceptions). This means that when reconstructing the AArch32 CPSR

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Eric Blake
On 02/28/2014 01:28 AM, Anton Ivanov (antivano) wrote: Hi all, On behalf of Cisco Systems I am authorized to contribute a new transport to the network subsystem in qemu. Patch attached. Your patch is huge - it might be better to break it into smaller logical chunks to make it easier to

Re: [Qemu-devel] [PATCH] pl011: fix corrupting the UARTCR value

2014-02-28 Thread Rob Herring
On Fri, Feb 28, 2014 at 4:41 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 February 2014 01:37, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@linaro.org Offset 4 is UARTRSR/UARTECR, not the UARTCR. As framing and parity errors will never occur, we can ignore

Re: [Qemu-devel] [PATCH] pl011: fix corrupting the UARTCR value

2014-02-28 Thread Peter Maydell
On 28 February 2014 13:41, Rob Herring rob.herr...@linaro.org wrote: On Fri, Feb 28, 2014 at 4:41 AM, Peter Maydell peter.mayd...@linaro.org wrote: * for overrun, we should set the rsr bit in pl011_put_fifo if the fifo is full; however, it looks from that function as if we don't

Re: [Qemu-devel] [PATCH 1/2] socket: treat ipv4=on, ipv6=on uniformly

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 13:23, Gerd Hoffmann ha scritto: On Fr, 2014-02-28 at 11:16 +0100, Paolo Bonzini wrote: In some cases, ipv4=on,ipv6=on means try both kinds of address; in others, it means try IPv6 only just by virtue of how the code is structured. @@ -127,10 +127,13 @@ int

Re: [Qemu-devel] [PATCH v3 21/31] target-arm: Implement AArch64 DAIF system register

2014-02-28 Thread Peter Maydell
On 17 February 2014 00:17, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Sun, Feb 16, 2014 at 2:07 AM, Peter Maydell peter.mayd...@linaro.org wrote: Implement the DAIF system register which is a view of the DAIF bits in PSTATE. +static uint64_t aa64_daif_read(CPUARMState *env,

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Anton Ivanov (antivano)
On 28/02/14 13:40, Eric Blake wrote: On 02/28/2014 01:28 AM, Anton Ivanov (antivano) wrote: Hi all, On behalf of Cisco Systems I am authorized to contribute a new transport to the network subsystem in qemu. Patch attached. Your patch is huge - it might be better to break it into smaller

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Anton Ivanov (antivano)
I now remember why I am not using connected sockets. connect() in UDP used to break source address bind(). I had a bug filed vs that as far back as early 2.6 which everyone ignored for ages. It was showing as bug vs hpa-tftpd. I need to reverify if this is still the case as it has to keep a

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Eric Blake
On 02/28/2014 06:52 AM, Anton Ivanov (antivano) wrote: On 28/02/14 13:40, Eric Blake wrote: On 02/28/2014 01:28 AM, Anton Ivanov (antivano) wrote: Hi all, On behalf of Cisco Systems I am authorized to contribute a new transport to the network subsystem in qemu. +# +# +# Since 1.0

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Paolo Bonzini
Il 28/02/2014 14:40, Eric Blake ha scritto: These should probably be 'int', not 'str'. If you have to hand-parse a string into a numeric value, you encoded the QMP wrong. Eric, note that this is not QMP. It is only used for option parsing. Paolo

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-02-28 Thread Anton Ivanov (antivano)
[snip] s/1.0/2.0/ OK - just to clarify, which version is this referring to - qemu, api, etc? This field is the version of qemu that first contains the release. If your patch is on time to make the qemu 2.0 release, then 2.0 is appropriate; but we're close to feature freeze so it may end up

[Qemu-devel] [PULL 07/38] input: keyboard: add helper functions to core

2014-02-28 Thread Gerd Hoffmann
A bunch of helper functions to manage keyboard events, to make life simpler for the ui code when submitting keyboard events. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 5 + ui/input.c | 35 +++ 2 files changed, 40

[Qemu-devel] [PULL 09/38] input: keyboard: switch qmp_send_key() to new core.

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/input-legacy.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 80f4f5c..a4006cc 100644 --- a/ui/input-legacy.c +++ b/ui/input-legacy.c @@ -260,10 +260,8 @@ static void

[Qemu-devel] [PULL 15/38] input: mouse: add helpers functions to core

2014-02-28 Thread Gerd Hoffmann
Likewise a bunch of helper functions to manage mouse button and movement events, again to make life easier for the ui code. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 14 +++ ui/input.c | 71 ++ 2

[Qemu-devel] [PULL 08/38] input: keyboard: switch legacy handlers to new core

2014-02-28 Thread Gerd Hoffmann
legacy kbd event handlers are registered in the new core, so they receive events from the new input core code. keycode - scancode translation needed here. legacy kbd_put_keycode() sends events to the new core. scancode - keycode translation needed here. So with this patch the new input core is

[Qemu-devel] [PULL 29/38] input-legacy: remove kbd_mouse_is_absolute

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 1 - ui/input-legacy.c| 11 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 53e956d..21b32e4 100644 --- a/include/ui/console.h +++

[Qemu-devel] [PULL 03/38] input: qapi: define event types

2014-02-28 Thread Gerd Hoffmann
Define input event types, using qapi. So we get nicely autogenerated types for our input events. And when it comes to qmp support some day things will be a lot easier. Types are modeled after the linux input layer. There are separate event types for each value. There is a sync to indicate the

[Qemu-devel] [PULL 28/38] input-legacy: remove kbd_mouse_has_absolute

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 3 --- ui/input-legacy.c| 21 ++--- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index c7f4e4f..53e956d 100644 --- a/include/ui/console.h

[Qemu-devel] [PULL 14/38] input: keyboard: switch curses ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/curses.c | 47 +-- 1 file changed, 25 insertions(+), 22 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index dbc3d5e..b044790 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -30,6 +30,7 @@

[Qemu-devel] [PULL 11/38] input: keyboard: switch sdl ui to new core

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/sdl.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 9d8583c..e78e020 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -30,6 +30,7 @@ #include qemu-common.h #include

[Qemu-devel] [PULL 05/38] input: qapi: add pause key

2014-02-28 Thread Gerd Hoffmann
It's missing. Signed-off-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index f044f05..ce158ed 100644 --- a/qapi-schema.json +++

[Qemu-devel] [PULL 36/38] console: add head to index to qemu consoles.

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/arm/musicpal.c| 2 +- hw/display/blizzard.c| 2 +- hw/display/cirrus_vga.c | 4 ++-- hw/display/exynos4210_fimd.c | 2 +- hw/display/g364fb.c | 2 +- hw/display/jazz_led.c| 2 +-

[Qemu-devel] [PULL 17/38] input: mouse: add qemu_input_is_absolute()

2014-02-28 Thread Gerd Hoffmann
Same as kbd_mouse_is_absolute(), but using new input core. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 1 + ui/input.c | 8 2 files changed, 9 insertions(+) diff --git a/include/ui/input.h b/include/ui/input.h index c6f50c2..28afc45 100644 ---

[Qemu-devel] [PULL 26/38] input: trace events

2014-02-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- trace-events | 8 ui/input.c | 48 2 files changed, 56 insertions(+) diff --git a/trace-events b/trace-events index 580281d..b1dd4d1 100644 --- a/trace-events +++ b/trace-events @@

  1   2   3   >