[Qemu-devel] [PATCH v19 06/11] qapi: make string input visitor parse int list

2014-03-04 Thread Hu Tao
Cc: Laszlo Ersek ler...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- qapi/string-input-visitor.c | 160 -- tests/test-string-input-visitor.c | 21 + 2 files changed, 175 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH v19 11/11] hmp: add info memdev

2014-03-04 Thread Hu Tao
This is the hmp counterpart of qmp query-memdev. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hmp.c | 27 +++ hmp.h | 1 + monitor.c | 7 +++ 3 files changed, 35 insertions(+) diff --git a/hmp.c b/hmp.c index e3ddd46..3bbe5ff 100644 --- a/hmp.c +++

[Qemu-devel] [PATCH v19 01/11] object_add: allow completion handler to get canonical path

2014-03-04 Thread Hu Tao
From: Igor Mammedov imamm...@redhat.com Add object to /objects before calling user_creatable_complete() handler, so that object might be able to call object_get_canonical_path() in its completion handler. Signed-off-by: Igor Mammedov imamm...@redhat.com --- qmp.c | 8 +--- vl.c | 9

Re: [Qemu-devel] [PATCH V2] virtio-net: calculate proper msix vectors on init

2014-03-04 Thread Jason Wang
On 03/04/2014 11:26 AM, Gonglei (Arei) wrote: -Original Message- From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On Behalf Of Jason Wang Sent: Friday, February 21, 2014 5:05 PM To: aligu...@amazon.com;

[Qemu-devel] [PATCH v19 09/11] hostmem backend: implement memory policy

2014-03-04 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- backends/hostmem.c | 97 ++-- include/sysemu/hostmem.h | 4 ++ qapi-schema.json | 20 ++ 3 files changed, 118 insertions(+), 3 deletions(-) diff --git a/backends/hostmem.c

[Qemu-devel] [PATCH v19 05/11] numa: add -numa node, memdev= option

2014-03-04 Thread Hu Tao
From: Paolo Bonzini pbonz...@redhat.com This option provides the infrastructure for binding guest NUMA nodes to host NUMA nodes. For example: -object memory-ram,size=1024M,policy=membind,host-nodes=0,id=ram-node0 \ -numa node,nodeid=0,cpus=0,memdev=ram-node0 \ -object

[Qemu-devel] [PATCH v19 00/11] Add support for binding guest numa nodes to host numa nodes

2014-03-04 Thread Hu Tao
Based on series `convert -numa to QemuOpts/OptsVisitor' posted by Igor at http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg02801.html. You can also checkout this series out at https://github.com/taohu/qemu/tree/numa-binding-v19, including all required patches. changes in v19: - use

Re: [Qemu-devel] [PATCH v6 0/4] qemu-img: add preallocation=full

2014-03-04 Thread Stefan Hajnoczi
On Tue, Mar 04, 2014 at 03:31:31PM +0800, Hu Tao wrote: On Mon, Mar 03, 2014 at 04:00:37PM +0100, Stefan Hajnoczi wrote: On Fri, Feb 28, 2014 at 10:29:29AM +0800, Hu Tao wrote: This series implements full image preallocation to create a non-sparse image file at creation time, both for

[Qemu-devel] [PATCH v19 07/11] qapi: make string output visitor parse int list

2014-03-04 Thread Hu Tao
From: Hu Tao hu.t...@gmail.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- qapi/string-output-visitor.c | 156 +++-- tests/test-string-output-visitor.c | 26 +++ 2 files changed, 177 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v6 0/4] qemu-img: add preallocation=full

2014-03-04 Thread Hu Tao
On Mon, Mar 03, 2014 at 04:00:37PM +0100, Stefan Hajnoczi wrote: On Fri, Feb 28, 2014 at 10:29:29AM +0800, Hu Tao wrote: This series implements full image preallocation to create a non-sparse image file at creation time, both for raw and qcow2 format. The purpose is to avoid performance

[Qemu-devel] [PATCH v19 04/11] numa: introduce memory_region_allocate_system_memory

2014-03-04 Thread Hu Tao
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/i386/pc.c| 4 +--- include/sysemu/sysemu.h | 5 + numa.c | 10 ++ 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test progress output for conversion

2014-03-04 Thread Kevin Wolf
Am 03.03.2014 um 19:20 hat Eric Blake geschrieben: On 03/03/2014 06:57 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/086 | 65 ++ tests/qemu-iotests/086.out | 18 +

Re: [Qemu-devel] [PATCH v19 07/11] qapi: make string output visitor parse int list

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 08:28, Hu Tao ha scritto: From: Hu Tao hu.t...@gmail.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- qapi/string-output-visitor.c | 156 +++-- tests/test-string-output-visitor.c | 26 +++ 2 files changed, 177 insertions(+), 5

[Qemu-devel] [PATCH v19 02/11] add memdev backend infrastructure

2014-03-04 Thread Hu Tao
From: Igor Mammedov imamm...@redhat.com Provides framework for splitting host RAM allocation/ policies into a separate backend that could be used by devices. Initially only legacy RAM backend is provided, which uses memory_region_init_ram() allocator and compatible with every CLI option that

[Qemu-devel] [PATCH v19 10/11] qmp: add query-memdev

2014-03-04 Thread Hu Tao
Add qmp command query-memdev to query for information of memory devices Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- backends/hostmem.c | 1 + numa.c | 61 ++ qapi-schema.json | 31 +++ qmp-commands.hx

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-04 Thread Stefan Hajnoczi
On Tue, Mar 04, 2014 at 01:02:44AM +, Huangpeng (Peter) wrote: But back to the options: If the host has enough free memory to fork QEMU, a small helper process can be used to save the copy-on-write memory snapshot (thanks to fork(2) semantics). The hard part about the fork(2)

[Qemu-devel] [PATCH v19 08/11] Add Linux libnuma detection

2014-03-04 Thread Hu Tao
From: Wanlong Gao gaowanl...@cn.fujitsu.com Add detection of libnuma (mostly contained in the numactl package) to the configure script. Can be enabled or disabled on the command line, default is use if available. Signed-off-by: Andre Przywara andre.przyw...@amd.com Signed-off-by: Wanlong Gao

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 09:54, Stefan Hajnoczi ha scritto: Is there any other proposals to implement vm-snapshot? See the discussion by Paolo and Andrea about post-copy migration, which adds kernel memory management features for tracking userspace page faults. Perhaps you can use that infrastructure to

Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: Adapter interrupt support.

2014-03-04 Thread Cornelia Huck
On Tue, 25 Feb 2014 18:25:15 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Handle the new CCW_CMD_SET_IND_ADAPTER command enabling adapter interrupts on guest request. When active, host-guest notifications will be handled via global_indicator - queue indicators instead of queue

Re: [Qemu-devel] [PATCH V2] virtio-net: calculate proper msix vectors on init

2014-03-04 Thread Jason Wang
On 03/04/2014 11:26 AM, Gonglei (Arei) wrote: -Original Message- From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On Behalf Of Jason Wang Sent: Friday, February 21, 2014 5:05 PM To: aligu...@amazon.com;

Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: Adapter interrupt support.

2014-03-04 Thread Christian Borntraeger
On 04/03/14 10:05, Cornelia Huck wrote: On Tue, 25 Feb 2014 18:25:15 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Handle the new CCW_CMD_SET_IND_ADAPTER command enabling adapter interrupts on guest request. When active, host-guest notifications will be handled via global_indicator -

Re: [Qemu-devel] [PATCH 1/1] vl.c: Add pci_hole_min_size machine option.

2014-03-04 Thread Michael S. Tsirkin
On Thu, Feb 27, 2014 at 05:32:23PM -0500, Don Slutz wrote: This allows growing the pci_hole to the size needed. Signed-off-by: Don Slutz dsl...@verizon.com Could you supply the motivation for this change please? --- hw/i386/pc_piix.c| 14 -- hw/i386/pc_q35.c | 14

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-03-04 Thread Stefan Hajnoczi
On Mon, Mar 03, 2014 at 01:20:21PM +0100, Peter Lieven wrote: On 03.03.2014 13:03, Stefan Hajnoczi wrote: So what is the actual performance problem you are trying to solve and what benchmark output are you getting when you compare with FADV_DONTNEED against without FADV_DONTNEED? I found the

Re: [Qemu-devel] [PATCH v19 07/11] qapi: make string output visitor parse int list

2014-03-04 Thread Hu Tao
On Tue, Mar 04, 2014 at 10:03:49AM +0100, Paolo Bonzini wrote: Il 04/03/2014 08:28, Hu Tao ha scritto: From: Hu Tao hu.t...@gmail.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- qapi/string-output-visitor.c | 156 +++--

[Qemu-devel] [PATCH v2 0/1] e1000: add the ability to select among several specific

2014-03-04 Thread Romain Dolbeau
Hello, This patch builds up on the previous version. I adds this ability to select a specific variant of the e1000 virtual ethernet from the command-line (see details already mentioned in the previous patch below). It also add supports for the 82566DM device, an ICH9 device, found e.g. with the

Re: [Qemu-devel] [PATCH v19 07/11] qapi: make string output visitor parse int list

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 10:23, Hu Tao ha scritto: +} else { +out = g_strdup_printf(%lld-%lld, + (long long) sov-range_start.s, + (long long) sov-range_end.s); +} +} This

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-03-04 Thread Stefan Hajnoczi
On Mon, Mar 03, 2014 at 02:01:00PM +, Anton Ivanov (antivano) wrote: On 03/03/14 13:27, Stefan Hajnoczi wrote: On Fri, Feb 28, 2014 at 08:28:11AM +, Anton Ivanov (antivano) wrote: 3. Qemu to communicate with the local host, remote vms, network devices, etc at speeds which for a

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-04 Thread Dr. David Alan Gilbert
* Huangpeng (Peter) (peter.huangp...@huawei.com) wrote: I think this is different in the same way that block-backup and block-mirror are different. Huangpeng's proposal would let you make a consistent snapshot of disks and RAM. Right. Though the point isn't about consistency (doing

Re: [Qemu-devel] [Discussion 01/10] docs: add docs/api-hierarchy.txt

2014-03-04 Thread Stefan Hajnoczi
On Tue, Mar 04, 2014 at 10:47:21AM +0800, Xuebing Wang wrote: Signed-off-by: Xuebing Wang xbi...@gmail.com --- docs/api-hierarchy.txt | 93 1 file changed, 93 insertions(+) create mode 100644 docs/api-hierarchy.txt This type of

Re: [Qemu-devel] [PATCH v4 2/3] qapi: Add a primitive to include other files from a QAPI schema file

2014-03-04 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/03/2014 08:27 AM, Markus Armbruster wrote: +The QAPI schema definitions can be modularized using the 'include' directive: + + include(sub-system/qapi.json) And now it isn't JSON anymore. To keep it JSON, use syntax like { include:

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-03-04 Thread Anton Ivanov (antivano)
On 04/03/14 09:36, Stefan Hajnoczi wrote: On Mon, Mar 03, 2014 at 02:01:00PM +, Anton Ivanov (antivano) wrote: On 03/03/14 13:27, Stefan Hajnoczi wrote: On Fri, Feb 28, 2014 at 08:28:11AM +, Anton Ivanov (antivano) wrote: 3. Qemu to communicate with the local host, remote vms, network

[Qemu-devel] [PATCH v2 1/1] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details.

2014-03-04 Thread Romain Dolbeau
Signed-off-by: Romain Dolbeau rom...@dolbeau.org --- hw/net/e1000.c | 395 ++- hw/net/e1000_regs.h | 149 --- 2 files changed, 489 insertions(+), 55 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index

Re: [Qemu-devel] [Discussion 01/10] docs: add docs/api-hierarchy.txt

2014-03-04 Thread Xuebing wang
On 03/04/2014 05:42 PM, Stefan Hajnoczi wrote: On Tue, Mar 04, 2014 at 10:47:21AM +0800, Xuebing Wang wrote: Signed-off-by: Xuebing Wang xbi...@gmail.com --- docs/api-hierarchy.txt | 93 1 file changed, 93 insertions(+) create mode 100644

Re: [Qemu-devel] [Discussion 03/10] NEED_CPU_H: remove unnecessary use of NEED_CPU_H

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 03:47, Xuebing Wang ha scritto: Note: there is a FIXME to be addressed in this patch. For every appearance of NEED_CPU_H, there must be '#include cpu.h' to include target-xxx/cpu.h, because the code below NEED_CPU_H depends on architecture-specific information. Signed-off-by:

Re: [Qemu-devel] [Discussion 04/10] memory_mapping: make this architecture-independent

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 03:47, Xuebing Wang ha scritto: Use vaddr (instead of target_ulong) for virtual address. See document HACKING for more information about vaddr and target_ulong. Signed-off-by: Xuebing Wang xbi...@gmail.com --- include/sysemu/memory_mapping.h |3 ++- 1 file changed, 2

Re: [Qemu-devel] [Discussion 05/10] NEED_CPU_H: remove unnecessary inclusion of cpu.h in root

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 03:47, Xuebing Wang ha scritto: Enforce the strict associativity between NEED_CPU_H and inclusion of cpu.h, for every appearance of '#include cpu.h', there must have the check of NEED_CPU_H, and conversely. As mentioned earlier, the #ifndef is unnecessary. It is already

Re: [Qemu-devel] [Discussion 06/10] memory: move contents in include/exec/address-spaces.h = memory.h

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 03:47, Xuebing Wang ha scritto: In preparation for removing include/exec/address-spaces.h Why? Paolo Signed-off-by: Xuebing Wang xbi...@gmail.com --- include/exec/address-spaces.h | 29 - include/exec/memory.h | 19 +++

Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of exec-all.h

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 03:47, Xuebing Wang ha scritto: include/exec/exec-all.h should ONLY be included in target-xxx/* - 'git grep -nw exec-all.h' confirms this Ok. Paolo Signed-off-by: Xuebing Wang xbi...@gmail.com --- cputlb.c |1 - tcg/README |2 +- tci.c |2 +- 3 files

Re: [Qemu-devel] [Discussion 10/10] translate: remove file translate-all.h

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 03:47, Xuebing Wang ha scritto: This patch does below: - Move the declaration of 2 translate functions from translate-all.h into include/exec/translate.h - remove file translate-all.h No, this is backwards. :) translate-all.h is a private interface between exec.c and

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Paolo Bonzini
Hi, in general I agree with this patch. I have a few comments, and I suggest that you split it in multiple patches so that it's easier to get it in when each part is ready. diff --git a/hw/dma/soc_dma.c b/hw/dma/soc_dma.c index c06aabb..950f3ec 100644 --- a/hw/dma/soc_dma.c +++

Re: [Qemu-devel] [Discussion 08/10] exec: move TranslationBlock API from exec-all.h = translate.h

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 03:47, Xuebing Wang ha scritto: Signed-off-by: Xuebing Wang xbi...@gmail.com --- include/exec/exec-all.h | 302 + include/exec/translate.h | 306 ++ 2 files changed, 307 insertions(+), 301

[Qemu-devel] Do memory mappings need be rebuilt when deleting ioeventfds?

2014-03-04 Thread Gonglei (Arei)
Hi, Recently I found that when doing migration on a VM with many Virtio NICs, a lot down time was consuming in vm_state_notify(). Further investigation shows major consumption is in function memory_region_del_eventfd(). When deletes an ioeventfd, in address space transactions commit, it

[Qemu-devel] [RFC v2 0/2] prebuild cpu QOM tree /machine/node/socket/core/thread/..

2014-03-04 Thread Chen Fan
at present, after hotplug a discontinuous cpu id on source, then done migration, on target, it will fail to add the unoccupied cpu id which was skipped at source, this cause is on target Qemu prebuild CPU with continuous cpu_index. so after migration, the cpu infrastructure bewteen source and

[Qemu-devel] [RFC v2 1/2] i386: introduce struct X86TopoInfo for saving cpu topology information

2014-03-04 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/i386/pc.c | 13 + target-i386/cpu.c | 16 target-i386/cpu.h | 4 target-i386/topology.h | 7 +++ 4 files changed, 36 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc.c

[Qemu-devel] [RFC v2 2/2] i386: introduce cpu QOM hierarchy tree

2014-03-04 Thread Chen Fan
add cpu-topology.h cpu-topology.c files for prebuild cpu qom tree /machine/node[X]/socket[Y]/core[Z]/thread[N]/cpu Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/i386/pc.c | 6 +- target-i386/Makefile.objs | 2 +- target-i386/cpu-qom.h | 1 +

Re: [Qemu-devel] [Discussion 04/10] memory_mapping: make this architecture-independent

2014-03-04 Thread Peter Maydell
On 4 March 2014 02:47, Xuebing Wang xbi...@gmail.com wrote: Use vaddr (instead of target_ulong) for virtual address. See document HACKING for more information about vaddr and target_ulong. Signed-off-by: Xuebing Wang xbi...@gmail.com --- include/sysemu/memory_mapping.h |3 ++- 1 file

Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of exec-all.h

2014-03-04 Thread Peter Maydell
On 4 March 2014 02:47, Xuebing Wang xbi...@gmail.com wrote: include/exec/exec-all.h should ONLY be included in target-xxx/* Why? This header file defines a number of functions and types that are used outside target-xxx/. At the moment we implicitly rely on cpu.h pulling them in. Maybe it would

Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of exec-all.h

2014-03-04 Thread Peter Maydell
On 4 March 2014 11:11, Peter Maydell peter.mayd...@linaro.org wrote: On 4 March 2014 02:47, Xuebing Wang xbi...@gmail.com wrote: include/exec/exec-all.h should ONLY be included in target-xxx/* Why? This header file defines a number of functions and types that are used outside target-xxx/.

Re: [Qemu-devel] Do memory mappings need be rebuilt when deleting ioeventfds?

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 11:49, Gonglei (Arei) ha scritto: Hi, Recently I found that when doing migration on a VM with many Virtio NICs, a lot down time was consuming in vm_state_notify(). Further investigation shows major consumption is in function memory_region_del_eventfd(). When deletes an

Re: [Qemu-devel] [PATCH V2] virtio-net: calculate proper msix vectors on init

2014-03-04 Thread Gonglei
On 2014/3/4 15:41, Jason Wang wrote: On 03/04/2014 11:26 AM, Gonglei (Arei) wrote: -Original Message- From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On Behalf Of Jason Wang Sent: Friday, February 21, 2014

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-04 Thread Wenchao Xia
于 2014/3/4 17:05, Paolo Bonzini 写道: Il 04/03/2014 09:54, Stefan Hajnoczi ha scritto: Is there any other proposals to implement vm-snapshot? See the discussion by Paolo and Andrea about post-copy migration, which adds kernel memory management features for tracking userspace page faults. Perhaps

Re: [Qemu-devel] [PATCH v2 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

2014-03-04 Thread Peter Crosthwaite
On Tue, Mar 4, 2014 at 8:16 AM, Beniamino Galvani b.galv...@gmail.com wrote: On Mon, Mar 03, 2014 at 09:08:27PM +1000, Peter Crosthwaite wrote: On Mon, Mar 3, 2014 at 12:06 AM, Beniamino Galvani b.galv...@gmail.com wrote: The model was generating interrupts for all enabled timers after the

Re: [Qemu-devel] [PATCH 3/4] linux-user: set minimum kernel version to2.6.322

2014-03-04 Thread Alex Bennée
riku.voi...@linaro.org writes: From: Riku Voipio riku.voi...@linaro.org Popular glibc based distributions[1] require minimum 2.6.32 as kernel version. For some targets 2.6.18 would be enough, but dropping so low would mean some suboptimal system calls could get used. Is the effect of this

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-03-04 Thread Anton Ivanov (antivano)
Hi Stefan, I am addressing a few more comments which I missed on first pass. If you really *need* the page size, please use sysconf(_SC_PAGESIZE). I like to have it page aligned and if possible page sized so I can later extend to do jumbo frame support via a vector. If this is the wrong way

Re: [Qemu-devel] [PATCH 3/4] linux-user: set minimum kernel version to2.6.322

2014-03-04 Thread Peter Maydell
On 4 March 2014 11:32, Alex Bennée alex.ben...@linaro.org wrote: riku.voi...@linaro.org writes: From: Riku Voipio riku.voi...@linaro.org Popular glibc based distributions[1] require minimum 2.6.32 as kernel version. For some targets 2.6.18 would be enough, but dropping so low would mean

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Xuebing wang
Hi Paolo, thanks for reviewing. On 03/04/2014 06:19 PM, Paolo Bonzini wrote: Hi, in general I agree with this patch. I have a few comments, and I suggest that you split it in multiple patches so that it's easier to get it in when each part is ready. I spent some time trying to reduce it.

Re: [Qemu-devel] [Discussion 01/10] docs: add docs/api-hierarchy.txt

2014-03-04 Thread Stefan Hajnoczi
On Tue, Mar 04, 2014 at 05:58:13PM +0800, Xuebing wang wrote: On 03/04/2014 05:42 PM, Stefan Hajnoczi wrote: On Tue, Mar 04, 2014 at 10:47:21AM +0800, Xuebing Wang wrote: Signed-off-by: Xuebing Wang xbi...@gmail.com --- docs/api-hierarchy.txt | 93

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Xuebing wang
diff --git a/include/disas/disas.h b/include/disas/disas.h index c13ca9a..e5cdfd7 100644 --- a/include/disas/disas.h +++ b/include/disas/disas.h @@ -1,9 +1,9 @@ #ifndef _QEMU_DISAS_H #define _QEMU_DISAS_H -#include qemu-common.h - #ifdef NEED_CPU_H +#include cpu.h /* target-xxx/cpu.h,

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Xuebing wang
diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index a608a26..14addcb 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -11,6 +11,8 @@ #define GDB_WATCHPOINT_ACCESS4 #ifdef NEED_CPU_H +#include cpu.h /* target-xxx/cpu.h, required for target_ulong, +

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 13:02, Xuebing wang ha scritto: Of these, vl.c and linux-user/elfload.c should not include disas/disas.h at all, and hw/core/loader.c is !NEED_CPU_H. So there are just two files where you can add a #include cpu.h manually. My idea is to keep disas/disas.h correct just by

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Xuebing wang
index 367eda1..f0157e3 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -510,18 +510,4 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); -#ifdef CONFIG_SOFTMMU -extern const struct VMStateDescription vmstate_cpu_common; -#else -#define

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 13:19, Xuebing wang ha scritto: Like Andreas I don't like this particularly. You can add migration/vmstate.h to qom/cpu.h instead. In my humble opinion, qom/cpu is part of virtual machine along with other hw peripherals, thus I'd prefer vmstate to depend on qom/cpu. From

Re: [Qemu-devel] [PATCH v2 3/3] migration: add more traces

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 05:10, Alexey Kardashevskiy ha scritto: @@ -81,6 +81,7 @@ static void qemu_announce_self_iter(NICState *nic, void *opaque) uint8_t buf[60]; int len; +trace_qemu_announce_self_iter(); Should include the nic or, even better, the six bytes of the MAC address.

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Xuebing wang
#ifdef CONFIG_KVM #include linux/kvm.h #include linux/kvm_para.h @@ -169,6 +178,7 @@ int kvm_init_vcpu(CPUState *cpu); int kvm_cpu_exec(CPUState *cpu); #ifdef NEED_CPU_H +#include cpu.h /* target-xxx/cpu.h, required for target_ulong */ void kvm_setup_guest_memory(void *start, size_t

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 13:26, Xuebing wang ha scritto: #ifdef NEED_CPU_H +#include cpu.h /* target-xxx/cpu.h, required for target_ulong */ void kvm_setup_guest_memory(void *start, size_t size); void kvm_flush_coalesced_mmio_buffer(void); Perhaps move debugging-related definitions to a new file

Re: [Qemu-devel] [PATCH v2 0/3] migration: add more traces

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 05:10, Alexey Kardashevskiy ha scritto: This reworks/adds traces for migration. v2 is rework of an original single patch with the same subject. Alexey Kardashevskiy (3): vl: add system_wakeup_request tracepoint migration: extend section_start/end traces migration: add more

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Peter Maydell
On 4 March 2014 12:09, Xuebing wang xbi...@gmail.com wrote: target-*/gdbstub.c implementers only need to know gdbstub hooks (thus gdbstub API), they don't care cpu.h, although knowledge of cpu.h helps. The gdbstub.c code is just a tiny part of the target-* frontend; there is no way that anybody

Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include cpu.h' from include/qemu-common.h

2014-03-04 Thread Xuebing wang
Hi Peter, Thanks. You are correct, I don't know what I was thinking. :-) On 03/04/2014 08:34 PM, Peter Maydell wrote: On 4 March 2014 12:09, Xuebing wang xbi...@gmail.com wrote: target-*/gdbstub.c implementers only need to know gdbstub hooks (thus gdbstub API), they don't care cpu.h,

Re: [Qemu-devel] [PATCH V8 04/10] qapi script: check correctness of union

2014-03-04 Thread Markus Armbruster
Wenchao Xia wenchaoq...@gmail.com writes: From: Wenchao Xia xiaw...@linux.vnet.ibm.com Commit message lost detail since v7. Intentional? Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Wenchao Xia wenchaoq...@gmail.com --- scripts/qapi.py

Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)

2014-03-04 Thread Paolo Bonzini
Il 27/02/2014 21:28, Stefan Weil ha scritto: Comment from Makefile.objs: # block-obj-y is code used by both qemu system emulation and qemu-img The system emulation needs this dependency (which was missing in Makefile), otherwise builds without tools (or massive parallel builds) fail.

[Qemu-devel] [PULL 07/12] Add 'debug-threads' suboption to --name

2014-03-04 Thread Michael S. Tsirkin
From: Dr. David Alan Gilbert dgilb...@redhat.com Add flag storage to qemu-thread-* to store the namethreads flag Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- include/qemu/thread.h| 1 +

[Qemu-devel] [PULL 02/12] acpi-test-data: update expected files

2014-03-04 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- tests/acpi-test-data/pc/DSDT | Bin 4582 - 4485 bytes tests/acpi-test-data/pc/SSDT | Bin 2200 - 2275 bytes tests/acpi-test-data/q35/DSDT | Bin 7438 - 7383 bytes tests/acpi-test-data/q35/SSDT | Bin 475 - 564 bytes 4 files changed, 0

[Qemu-devel] [PULL 08/12] Add a 'name' parameter to qemu_thread_create

2014-03-04 Thread Michael S. Tsirkin
From: Dr. David Alan Gilbert dgilb...@redhat.com If enabled, set the thread name at creation (on GNU systems with pthread_set_np) Fix up all the callers with a thread name Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Acked-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Laszlo

[Qemu-devel] [PULL 11/12] acpi-test: retain both asl and aml files on failure

2014-03-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com Updated the error message while at it. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- tests/acpi-test.c | 16 +--- 1 file changed, 9

[Qemu-devel] [PULL 05/12] PCIE: fix regression with coldplugged multifunction device

2014-03-04 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com PCIE is causing asserts each time a multifunction device is added on command line (coldplug). This is caused by commit a66e657e18cd9b70e9f57ae5512c07faf2bc508f pci/pcie: convert PCIE hotplug to use hotplug-handler API QEMU abort is caused by misplaced

[Qemu-devel] [PULL 03/12] virtio-net: remove function calls from assert

2014-03-04 Thread Michael S. Tsirkin
From: Joel Stanley j...@jms.id.au peer_{de,at}tach were called from inside assert(). We don't support building without NDEBUG but it's not tidy. Rearrange to attach peer outside assert calls. Signed-off-by: Joel Stanley j...@jms.id.au Reviewed-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PULL 10/12] acpi-build: partially revert dac1e93093f9306c114f410785c99aa5261539b4

2014-03-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com It touched the acpi test by mistake, removed that hunk. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- tests/acpi-test.c | 2 +- 1 file changed,

Re: [Qemu-devel] [PULL 00/12] acpi,pc,pci,virtio,memory bug fixes

2014-03-04 Thread Peter Maydell
On 4 March 2014 13:03, Michael S. Tsirkin m...@redhat.com wrote: The following changes since commit 417c45ab2f847c0a47b1232f611aa886df6a97d5: ACPI: Remove commented-out code from HPET._CRS (2014-02-10 11:09:33 +0200) are available in the git repository at:

[Qemu-devel] [PULL 09/12] MAINTAINERS: drop an out of date address

2014-03-04 Thread Michael S. Tsirkin
Gleb's address seems to be out of date. Since it stayed like that for a while now, I'm guessing he's no longer interested in getting mail. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-03-04 Thread Markus Armbruster
Wenchao Xia wenchaoq...@gmail.com writes: This series address two issues: 1. support using enum as discriminator in union. For example, if we have following define in qapi schema: { 'enum': 'EnumOne', 'data': [ 'value1', 'value2', 'value3' ] } { 'type': 'UserDefBase0', 'data': {

Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)

2014-03-04 Thread Peter Maydell
On 4 March 2014 12:55, Paolo Bonzini pbonz...@redhat.com wrote: Il 27/02/2014 21:28, Stefan Weil ha scritto: Comment from Makefile.objs: # block-obj-y is code used by both qemu system emulation and qemu-img The system emulation needs this dependency (which was missing in Makefile),

Re: [Qemu-devel] [PULL 00/12] acpi,pc,pci,virtio,memory bug fixes

2014-03-04 Thread Michael S. Tsirkin
On Tue, Mar 04, 2014 at 01:07:02PM +, Peter Maydell wrote: On 4 March 2014 13:03, Michael S. Tsirkin m...@redhat.com wrote: The following changes since commit 417c45ab2f847c0a47b1232f611aa886df6a97d5: ACPI: Remove commented-out code from HPET._CRS (2014-02-10 11:09:33 +0200) are

Re: [Qemu-devel] [PATCH v4 1/3] qapi: Use an explicit input file

2014-03-04 Thread Markus Armbruster
Lluís Vilanova vilan...@ac.upc.edu writes: Markus Armbruster writes: [...] self.fp = schema.fp self.msg = msg self.line = self.col = 1 @@ -50,12 +52,17 @@ class QAPISchemaError(Exception): self.col += 1 def __str__(self): - return %s:%s:%s: %s % (self.fp.name, self.line, self.col,

[Qemu-devel] [PATCH v4] XBZRLE: Fix qemu crash when resize the xbzrle cache

2014-03-04 Thread Gonglei
Resizing the xbzrle cache during migration causes qemu-crash, because the main-thread and migration-thread modify the xbzrle cache size concurrently without lock-protection. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Dr. David Alan

[Qemu-devel] [PULL 01/12] acpi-build: append description for non-hotplug

2014-03-04 Thread Michael S. Tsirkin
As reported in http://article.gmane.org/gmane.comp.emulators.qemu/253987 Mac OSX actually requires describing all occupied slots in ACPI - even if hotplug isn't enabled. I didn't expect this so I dropped description of all non hotpluggable slots from ACPI. As a result: before commit

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-03-04 Thread Luiz Capitulino
On Tue, 04 Mar 2014 14:03:34 +0100 Markus Armbruster arm...@redhat.com wrote: Wenchao Xia wenchaoq...@gmail.com writes: This series address two issues: 1. support using enum as discriminator in union. For example, if we have following define in qapi schema: { 'enum': 'EnumOne',

Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for system emulation (fix build)

2014-03-04 Thread Stefan Weil
Am 27.02.2014 21:28, schrieb Stefan Weil: Comment from Makefile.objs: # block-obj-y is code used by both qemu system emulation and qemu-img Hello Peter, the comment which I cited above got lost when you applied the patch to QEMU master (maybe because it started with a #). Regards Stefan

[Qemu-devel] [PULL 06/12] Rework --name to use QemuOpts

2014-03-04 Thread Michael S. Tsirkin
From: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Reviewed-by: Alex Bennée alex.ben...@linaro.org Acked-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- vl.c | 52

[Qemu-devel] [PULL 12/12] acpi-test: issue errors instead of warnings when possible

2014-03-04 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com If the expected (offline) acpi tables loaded correctly, it is safe to assume the iasl installation is OK and issue an error if the actual tables failed to load. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 00/12] acpi,pc,pci,virtio,memory bug fixes

2014-03-04 Thread Michael S. Tsirkin
The following changes since commit 417c45ab2f847c0a47b1232f611aa886df6a97d5: ACPI: Remove commented-out code from HPET._CRS (2014-02-10 11:09:33 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-03-04 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Tue, 04 Mar 2014 14:03:34 +0100 Markus Armbruster arm...@redhat.com wrote: [] Applies cleanly on Luiz's queue/qmp branch. I got a few questions on 04/10, but nothing major. Perhaps you'd like to respin to address the nits picked by

[Qemu-devel] [PULL 04/12] memory_region_present: return false if address is not found in child MemoryRegion

2014-03-04 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com Windows XP shows COM2 port as non functional in Device Manager although no COM2 port backing device is present in QEMU. This regression is really due to 3bb28b7208b349e7a1b326e3c6ef9efac1d462bf? memory: Provide separate handling of unassigned io ports

[Qemu-devel] [PATCH 2.1 02/28] NUMA: check if the total numa memory size is equal to ram_size

2014-03-04 Thread Paolo Bonzini
From: Wanlong Gao gaowanl...@cn.fujitsu.com If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI talb, then the guest will ignore the wrong ACPI table and recognize all memory to one node. It's buggy, we should check it

[Qemu-devel] [PATCH 2.1 00/28] Current state of NUMA series, and hostmem improvements

2014-03-04 Thread Paolo Bonzini
This series includes all the pending work on QOMifying the memory backends. Some of the patches posted so far didn't correctly build all targets, so I'm posting it as the basis for further work (including memory hotplug!). It's available at branch numa on my github repository. To recap, the

[Qemu-devel] [PATCH 2.1 01/28] NUMA: move numa related code to new file numa.c

2014-03-04 Thread Paolo Bonzini
From: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.target | 2 +- cpus.c| 14 include/exec/cpu-all.h

[Qemu-devel] [PATCH 2.1 06/28] man: improve -numa doc

2014-03-04 Thread Paolo Bonzini
From: Luiz Capitulino lcapitul...@redhat.com The -numa option documentation in qemu's manpage lacks the command-line options and some information regarding how it relates to options -m and -smp. This commit fills in the missing text. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com

[Qemu-devel] [PATCH 2.1 11/28] qmp: improve error reporting for -object and object-add

2014-03-04 Thread Paolo Bonzini
Use QERR_INVALID_PARAMETER_VALUE for consistency, and avoid an assertion failure if the class name is incorrect. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qmp.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qmp.c b/qmp.c index 2ff943d..a3b0b73 100644 ---

[Qemu-devel] [PATCH 2.1 07/28] qemu-option: introduce qemu_find_opts_singleton

2014-03-04 Thread Paolo Bonzini
Reviewed-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qemu/config-file.h | 2 ++ util/qemu-config.c | 14 ++ vl.c | 11 +-- 3 files changed, 17 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 2.1 12/28] pc: pass QEMUMachineInitArgs to pc_memory_init

2014-03-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/i386/pc.c | 11 +-- hw/i386/pc_piix.c| 8 +++- hw/i386/pc_q35.c | 4 +--- include/hw/i386/pc.h | 7 +++ 4 files changed, 12 insertions(+), 18 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[Qemu-devel] [PATCH 2.1 08/28] vl: convert -m to QemuOpts

2014-03-04 Thread Paolo Bonzini
From: Igor Mammedov imamm...@redhat.com Adds option to -m mem - startup memory amount For compatibility with legacy CLI if suffix-less number is passed, it assumes amount in Mb. Otherwise user is free to use suffixed number using suffixes b,k/K,M,G Signed-off-by: Igor Mammedov

  1   2   3   >