[Qemu-devel] [PULL 1/8] tcg-ia64: Optimize small arguments to exit_tb

2014-03-04 Thread Richard Henderson
Saves one bundle for the common case of exit_tb 0. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index 2d8e00c..7407011 100644 ---

[Qemu-devel] [PULL 4/8] tcg-ia64: Move tlb addend load into tlb read

2014-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index cdc7487..802ec33 100644 --- a/tcg/ia64/tcg-target.c +++

[Qemu-devel] [PULL 3/8] tcg-ia64: Move bswap for store into tlb load

2014-03-04 Thread Richard Henderson
Saving at least two cycles per store, and cleaning up the code. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 94 +-- 1 file changed, 31 insertions(+), 63 deletions(-) diff --git a/tcg/ia64/tcg-target.c

[Qemu-devel] [PULL 2/8] tcg-ia64: Re-bundle the tlb load

2014-03-04 Thread Richard Henderson
This sequencing requires 5 stop bits instead of 6, and has room left over to pre-load the tlb addend, and bswap data prior to being stored. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 77 --- 1 file changed, 54

[Qemu-devel] [PULL 7/8] tcg-ia64: Move part of softmmu slow path out of line

2014-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 176 -- 1 file changed, 114 insertions(+), 62 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index 1abcbb3..aafb7ea 100644 ---

[Qemu-devel] [PULL 5/8] tcg-ia64: Reduce code duplication in tcg_out_qemu_ld

2014-03-04 Thread Richard Henderson
The only differences were in the bswap insns emitted. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 60 --- 1 file changed, 23 insertions(+), 37 deletions(-) diff --git a/tcg/ia64/tcg-target.c

[Qemu-devel] [PULL 6/8] tcg-ia64: Convert to new ldst helpers

2014-03-04 Thread Richard Henderson
Still inline, but updated to the new routines. Always use the LE helpers, reusing the bswap between the fast and slot paths. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 140 -- 1 file changed, 79 insertions(+), 61

Re: [Qemu-devel] [PATCH 1/1] vl.c: Add pci_hole_min_size machine option.

2014-03-04 Thread Don Slutz
On 03/04/14 11:58, Michael S. Tsirkin wrote: On Tue, Mar 04, 2014 at 11:36:44AM -0500, Don Slutz wrote: On 03/04/14 02:34, Michael S. Tsirkin wrote: On Thu, Feb 27, 2014 at 05:32:23PM -0500, Don Slutz wrote: This allows growing the pci_hole to the size needed. Signed-off-by: Don Slutz

[Qemu-devel] [PATCH 1/2] QEMU: SMBIOS: Update all structs to v2.3; Add type 2 struct

2014-03-04 Thread Gabriel L. Somlo
- update type 4 and 17 structures to v2.3 of the smbios spec - add type 2 structure definition Signed-off-by: Gabriel Somlo so...@cmu.edu --- This patch changes none of the current functionality. It simply documents a few missing fields and adds the definition for an optional type, so I'm

[Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-04 Thread Gabriel L. Somlo
- deprecate passing individual smbios fields (SMBIOS_FIELD_ENTRY) - added functionality to build full tables instead, and pass them to the bios via fw_cfg as SMBIOS_TABLE_ENTRY blobs - added code to optionally build type 2 smbios table expected by OS X Signed-off-by: Gabriel Somlo

[Qemu-devel] [PATCH v9 00/20] Vhost and vhost-net support for userspace based backends

2014-03-04 Thread Antonios Motakis
In this patch series we would like to introduce our approach for putting a virtio-net backend in an external userspace process. Our eventual target is to run the network backend in the Snabbswitch ethernet switch, while receiving traffic from a guest inside QEMU/KVM which runs an unmodified

[Qemu-devel] [PATCH v9 04/20] Add chardev API qemu_chr_fe_set_msgfds

2014-03-04 Thread Antonios Motakis
This will set an array of file descriptors to the internal structures. The next time a message is send the array will be send as ancillary data. This feature works on the UNIX domain socket backend only. Signed-off-by: Antonios Motakis a.mota...@virtualopensystems.com Signed-off-by: Nikolay

Re: [Qemu-devel] [RFC v2 1/2] i386: introduce struct X86TopoInfo for saving cpu topology information

2014-03-04 Thread Eduardo Habkost
On Tue, Mar 04, 2014 at 06:50:24PM +0800, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/i386/pc.c | 13 + target-i386/cpu.c | 16 target-i386/cpu.h | 4 target-i386/topology.h | 7 +++ 4 files

[Qemu-devel] [PATCH v9 14/20] Add vhost-backend and VhostBackendType

2014-03-04 Thread Antonios Motakis
Use vhost_set_backend_type to initialise a proper vhost_ops structure. In vhost_net_init and vhost_net_start_one call conditionally TAP related initialisation depending on the vhost backend type. Signed-off-by: Antonios Motakis a.mota...@virtualopensystems.com Signed-off-by: Nikolay Nikolaev

[Qemu-devel] [PATCH v9 03/20] Add chardev API qemu_chr_fe_read_all

2014-03-04 Thread Antonios Motakis
This function will attempt to read data from the chardev trying to fill the buffer up to the given length. Add tcp_chr_disconnect to reuse disconnection code where needed. Signed-off-by: Antonios Motakis a.mota...@virtualopensystems.com Signed-off-by: Nikolay Nikolaev

Re: [Qemu-devel] [PATCH v9 00/20] Vhost and vhost-net support for userspace based backends

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 19:22, Antonios Motakis ha scritto: In this patch series we would like to introduce our approach for putting a virtio-net backend in an external userspace process. Our eventual target is to run the network backend in the Snabbswitch ethernet switch, while receiving traffic from a

[Qemu-devel] [PATCH v9 13/20] Add mandatory_features to vhost_dev

2014-03-04 Thread Antonios Motakis
This will be used in a following patch to ensure that a vhost-user client reconnecting to QEMU supports the features that were exposed by the first client that initiated the virtio-net session. Signed-off-by: Antonios Motakis a.mota...@virtualopensystems.com Signed-off-by: Nikolay Nikolaev

Re: [Qemu-devel] [PATCH qom-cpu v10 1/2] target-i386: Prepare CPUClass::class_by_name for X86CPU

2014-03-04 Thread Eduardo Habkost
On Tue, Feb 25, 2014 at 08:36:26AM +0100, Andreas Färber wrote: Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de Reviewed-by: Eduardo Habkost ehabk...@redhat.com Tested-by: Eduardo Habkost ehabk...@redhat.com -- Eduardo

Re: [Qemu-devel] [PATCH qom-cpu v10 2/2] target-i386: X86CPU model subclasses

2014-03-04 Thread Eduardo Habkost
On Tue, Feb 25, 2014 at 08:36:27AM +0100, Andreas Färber wrote: From: Eduardo Habkost ehabk...@redhat.com Register separate QOM types for each x86 CPU model. This will allow management code to more easily probe what each CPU model provides, by simply creating objects using the appropriate

[Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call

2014-03-04 Thread Andreas Färber
Supply a required Error ** argument to qemu_gluster_init() in qemu_gluster_reopen_prepare(), as done in qemu_gluster_open(). Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- block/gluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PULL 8/8] tcg-ia64: Convert to new ldst opcodes

2014-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 100 +- tcg/ia64/tcg-target.h | 2 +- 2 files changed, 35 insertions(+), 67 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index

[Qemu-devel] [PATCH v9 19/20] libqemustub: add stubs to be able to use qemu-char.c

2014-03-04 Thread Antonios Motakis
chardev depends on lots of external symbols that are not necessarily needed to be able to use, for example, 'socket chardev'. So add stubs for these functions: - bdrv_commit_all - qemu_chr_open_msmouse - is_daemonized - qemu_add_machine_init_done_notifier - monitor_init - qemu_notify_event

[Qemu-devel] [PATCH v9 15/20] Add vhost-user as a vhost backend.

2014-03-04 Thread Antonios Motakis
The initialization takes a chardev backed by a unix domain socket. It should implement qemu_fe_set_msgfds in order to be able to pass file descriptors to the remote process. Each ioctl request of vhost-kernel has a vhost-user message equivalent, which is sent over the control socket. The general

Re: [Qemu-devel] [PULL 00/13] Trivial patches for 2014-03-04

2014-03-04 Thread Peter Maydell
On 4 March 2014 06:15, Michael Tokarev m...@tls.msk.ru wrote: Here's another pull request for trivial-patches tree. There's nothing exciting in there, small things here and there. Please consider pulling/applying. Thanks, /mjt The following changes since commit

Re: [Qemu-devel] [PATCH v9 13/20] Add mandatory_features to vhost_dev

2014-03-04 Thread Michael S. Tsirkin
On Tue, Mar 04, 2014 at 07:22:56PM +0100, Antonios Motakis wrote: This will be used in a following patch to ensure that a vhost-user client reconnecting to QEMU supports the features that were exposed by the first client that initiated the virtio-net session. Signed-off-by: Antonios Motakis

Re: [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call

2014-03-04 Thread Stefan Hajnoczi
On Tue, Mar 4, 2014 at 9:00 PM, Andreas Färber afaer...@suse.de wrote: Supply a required Error ** argument to qemu_gluster_init() in qemu_gluster_reopen_prepare(), as done in qemu_gluster_open(). Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de ---

Re: [Qemu-devel] [PATCH v9 00/20] Vhost and vhost-net support for userspace based backends

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 19:33, Antonios Motakis ha scritto: Hello Paolo, Yes we saw your series today, and we plan to try it out. Any idea on when your series will get in? Then we can probably remove our own implementation for shared memory. It's planned for 2.1, together with memory hotplug which is

[Qemu-devel] [PATCH buildfix v2] gluster: Add missing argument to qemu_gluster_init() call

2014-03-04 Thread Andreas Färber
Commit adccfbcd6020e928db93b2b4faf0dbd05ffbe016 (block: gluster - add reopen support.) did not supply the qemu_gluster_init() Error ** argument, needed since commit a7451cb850d115f257080aff3fbc54f255ebf8f7 (gluster: correctly propagate errors). Pass through qemu_gluster_reopen_prepare()'s errp,

Re: [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call

2014-03-04 Thread Andreas Färber
Am 04.03.2014 21:12, schrieb Stefan Hajnoczi: On Tue, Mar 4, 2014 at 9:00 PM, Andreas Färber afaer...@suse.de wrote: Supply a required Error ** argument to qemu_gluster_init() in qemu_gluster_reopen_prepare(), as done in qemu_gluster_open(). Cc: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PATCH v9 01/20] Convert -mem-path to QemuOpts and add share property

2014-03-04 Thread Antonios Motakis
Extend -mem-path with additional property: - share=on|off - default off, memory is mmapped with MAP_SHARED flag Signed-off-by: Antonios Motakis a.mota...@virtualopensystems.com Signed-off-by: Nikolay Nikolaev n.nikol...@virtualopensystems.com --- exec.c | 21

Re: [Qemu-devel] [PATCH buildfix v2] gluster: Add missing argument to qemu_gluster_init() call

2014-03-04 Thread Peter Maydell
On 4 March 2014 20:17, Andreas Färber afaer...@suse.de wrote: Commit adccfbcd6020e928db93b2b4faf0dbd05ffbe016 (block: gluster - add reopen support.) did not supply the qemu_gluster_init() Error ** argument, needed since commit a7451cb850d115f257080aff3fbc54f255ebf8f7 (gluster: correctly

Re: [Qemu-devel] [PATCH qom-cpu 0/6] cpu: Unifying features parsing

2014-03-04 Thread Andreas Färber
Am 04.03.2014 03:55, schrieb Andreas Färber: Hello, Prompted by Alexey's desire for tweakable PowerPCCPU properties but also by Peter's wish for ARMCPU properties, this series sets out to align cpu_model parsing across targets. QemuOpts would've been nice to use, but on the one hand x86

Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-04 Thread Kevin O'Connor
On Tue, Mar 04, 2014 at 02:20:06PM -0500, Gabriel L. Somlo wrote: Kevin and Gerd: I'd like to get your acked-by for this patch (or any future revision): you're the two people who've been editing src/fw/smbios.c in SeaBIOS, and while I didn't directly cut'n'paste anything from there, I did in

Re: [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call

2014-03-04 Thread Jeff Cody
On Tue, Mar 04, 2014 at 09:12:14PM +0100, Stefan Hajnoczi wrote: On Tue, Mar 4, 2014 at 9:00 PM, Andreas Färber afaer...@suse.de wrote: Supply a required Error ** argument to qemu_gluster_init() in qemu_gluster_reopen_prepare(), as done in qemu_gluster_open(). Cc: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH qom-next v1 2/6] ssi: Remove legacy SSI_BUS-BUS cast

2014-03-04 Thread Andreas Färber
Am 12.02.2014 01:28, schrieb Peter Crosthwaite: Remove two legacy -qbus style casts from TYPE_SSI_BUS to TYPE_BUS in ssi.c. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/ssi/ssi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH qom-next v1 4/6] misc: max111x: QOM casting sweep

2014-03-04 Thread Andreas Färber
Am 12.02.2014 01:29, schrieb Peter Crosthwaite: Define and use QOM cast macro. Removes some usages of legacy casting systems. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/misc/max111x.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH qom-next v1 6/6] block/m25p80: Remove FROM_SSI_SLAVE usages

2014-03-04 Thread Andreas Färber
Am 12.02.2014 01:30, schrieb Peter Crosthwaite: Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/block/m25p80.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 02a1544..bdbb139 100644 ---

Re: [Qemu-devel] [PATCH v3 1/2] qmp: rename query_option_descs() to get_param_infolist()

2014-03-04 Thread Eric Blake
On 03/03/2014 10:51 PM, Amos Kong wrote: Signed-off-by: Amos Kong ak...@redhat.com --- util/qemu-config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) No change from v2. To ease my review time, it is reasonable if you amend the commit message to include my: Reviewed-by:

[Qemu-devel] [PATCH 1/4] qom: split object_property_set_link()

2014-03-04 Thread Stefan Hajnoczi
The path resolution logic in object_property_set_link() should be a separate function. This makes the code easier to read and maintain. More importantly, the error behavior of object_property_set_link() is dangerous. It sets the link property object to NULL if an error occurs. A setter function

[Qemu-devel] [PATCH 0/4] qom: link property fixes

2014-03-04 Thread Stefan Hajnoczi
There are two problems with QOM link properties: 1. There are refcount leaks in many object_property_add_link() callers. 2. There is no way to prevent link properties from being set after a device is realized. This patch series fixes these issues by extending the object_property_add_link()

[Qemu-devel] [PATCH 2/4] qom: make QOM link property unref optional

2014-03-04 Thread Stefan Hajnoczi
Some object_property_add_link() callers expect property deletion to unref the link property object. Other callers expect to manage the refcount themselves. The former are currently broken and therefore leak the link property object. This patch adds the bool unref_on_release argument to

[Qemu-devel] [PATCH 3/4] qom: add set() argument to object_property_add_link()

2014-03-04 Thread Stefan Hajnoczi
There are currently three types of object_property_add_link() callers: 1. The link property may be set at any time. 2. The link property of a DeviceState instance may only be set before realize. 3. The link property may never be set, it is read-only. Something similar can already be achieved

[Qemu-devel] [PATCH 4/4] virtio-rng: avoid default_backend refcount leak

2014-03-04 Thread Stefan Hajnoczi
QOM child properties take a reference to the object and release it when the property is deleted. Therefore we should unref the default_backend after we have added it as a child property. Cc: KONRAD Frederic fred.kon...@greensocs.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

Re: [Qemu-devel] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-04 Thread Eric Blake
On 03/03/2014 10:51 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be

Re: [Qemu-devel] [PATCH qom-next v1 1/6] ssi: Convert legacy casts from SSI_SLAVE-DEVICE

2014-03-04 Thread Andreas Färber
Am 12.02.2014 01:27, schrieb Peter Crosthwaite: Convert legacy -qdev style casts from TYPE_SSI_SLAVE to TYPE_DEVICE. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/arm/spitz.c | 9 + hw/display/ads7846.c | 2 +- hw/display/ssd0323.c | 4 ++--

Re: [Qemu-devel] [PATCH qom-next v1 0/6] SSI QOM cleanups

2014-03-04 Thread Andreas Färber
Am 25.02.2014 09:51, schrieb Andreas Färber: Am 25.02.2014 09:46, schrieb Peter Crosthwaite: Ping! Looked good, didn't get to applying them yet. I did wonder though a) why 1/6 is not renaming the parent field to verify and b) whether I can swap d vs. dev naming in one hunk there while at

Re: [Qemu-devel] [PATCH] pl011: reset the fifo when enabled or disabled

2014-03-04 Thread Rob Herring
On Sun, Mar 2, 2014 at 2:20 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 28 February 2014 00:57, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@linaro.org Intermittent issues have been seen where no serial input occurs. It appears the pl011 gets in a state

Re: [Qemu-devel] [PATCH qom-next v1 1/6] ssi: Convert legacy casts from SSI_SLAVE-DEVICE

2014-03-04 Thread Andreas Färber
Am 04.03.2014 23:07, schrieb Andreas Färber: Am 12.02.2014 01:27, schrieb Peter Crosthwaite: Convert legacy -qdev style casts from TYPE_SSI_SLAVE to TYPE_DEVICE. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/arm/spitz.c | 9 + hw/display/ads7846.c | 2

Re: [Qemu-devel] [PATCH 1/1] vl.c: Add pci_hole_min_size machine option.

2014-03-04 Thread Michael S. Tsirkin
On Tue, Mar 04, 2014 at 02:18:49PM -0500, Don Slutz wrote: On 03/04/14 11:58, Michael S. Tsirkin wrote: On Tue, Mar 04, 2014 at 11:36:44AM -0500, Don Slutz wrote: On 03/04/14 02:34, Michael S. Tsirkin wrote: On Thu, Feb 27, 2014 at 05:32:23PM -0500, Don Slutz wrote: This allows growing the

Re: [Qemu-devel] [PATCH qom-next v1 0/6] SSI QOM cleanups

2014-03-04 Thread Peter Crosthwaite
On Wed, Mar 5, 2014 at 8:39 AM, Andreas Färber afaer...@suse.de wrote: Am 25.02.2014 09:51, schrieb Andreas Färber: Am 25.02.2014 09:46, schrieb Peter Crosthwaite: Ping! Looked good, didn't get to applying them yet. I did wonder though a) why 1/6 is not renaming the parent field to verify

[Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-03-04 Thread Serge Hallyn
@pitti, the version now in ppa should fix your virtfs problem. ** Changed in: qemu (Ubuntu) Status: Triaged = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1285505 Title:

Re: [Qemu-devel] [PATCH 0/2] PC: improve emulation correctness

2014-03-04 Thread Michael S. Tsirkin
On Mon, Mar 03, 2014 at 11:05:17PM +0100, Hervé Poussineau wrote: Ping. QEMU crash at reboot is due to not resetting PAM registers at i440fx reset, but a patch has already been rejected on ML: http://lists.gnu.org/archive/html/qemu-devel/2013-02/msg02928.html Hervé I thought an

Re: [Qemu-devel] [PATCH 1/1] vl.c: Add pci_hole_min_size machine option.

2014-03-04 Thread Don Slutz
On 03/04/14 17:20, Michael S. Tsirkin wrote: On Tue, Mar 04, 2014 at 02:18:49PM -0500, Don Slutz wrote: On 03/04/14 11:58, Michael S. Tsirkin wrote: On Tue, Mar 04, 2014 at 11:36:44AM -0500, Don Slutz wrote: On 03/04/14 02:34, Michael S. Tsirkin wrote: On Thu, Feb 27, 2014 at 05:32:23PM

Re: [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support

2014-03-04 Thread Kim Phillips
On Fri, 28 Feb 2014 11:03:18 -0700 Alex Williamson alex.william...@redhat.com wrote: On Tue, 2014-02-25 at 20:37 -0600, Kim Phillips wrote: - support allocating a variable number of regions - VFIODevice's bars[] become dynamically allocated *regions - VFIOBAR's device fd replaced with

[Qemu-devel] [PATCH 0/7] Allow a client chardev to reconnect if disconnected

2014-03-04 Thread minyard
This patch set was part of the IPMI patches, but people have asked it to be separated out because it's useful by itself and the IPMI patches are stuck in legal limbo. I have left the patch to move allocating CharDriverState in one place (patch 1). I didn't get much opinion either way, but I

[Qemu-devel] [PATCH 3/7] qemu-char: Wait until socket connect to report connected

2014-03-04 Thread minyard
From: Corey Minyard cminy...@mvista.com The socket code was reporting that a socket connection was connected as soon as the connect call was issued. If the connection failed, it would then report it was not connected. With the reconnect code, it's better to wait until the connection is actually

[Qemu-devel] [PATCH 1/7] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts

2014-03-04 Thread minyard
From: Corey Minyard cminy...@mvista.com This allocates the CharDriverState structure and passes it in to the open routine. This allows a coming option to automatically attempt to reconnect a chardev if the connection fails. The chardev has to be kept around so a reconnect can be done on it.

[Qemu-devel] [PATCH 5/7] qemu-char: Close fd at end of file

2014-03-04 Thread minyard
From: Corey Minyard cminy...@mvista.com The chardev backends that used qemu_chr_open_fd did not get their file descriptors closed at end of file or when the chardev was closed. This could result in a file descriptor leak. Signed-off-by: Corey Minyard cminy...@mvista.com --- qemu-char.c | 35

[Qemu-devel] [PATCH 2/7] qemu-char: Allow a chardev to reconnect if disconnected

2014-03-04 Thread minyard
From: Corey Minyard cminy...@mvista.com Allow a socket that connects to reconnect on a periodic basis if it fails to connect at startup or if the connection drops while in use. Signed-off-by: Corey Minyard cminy...@mvista.com --- include/sysemu/char.h | 16 - qemu-char.c | 165

[Qemu-devel] [PATCH 6/7] qemu-char: Clean up error handling in qmp_chardev_add

2014-03-04 Thread minyard
From: Corey Minyard cminy...@mvista.com The open functions called by qmp_chardev_add could either return NULL or set errp to return an error. Modify to just return errp, as that can pass useful information where returning NULL cannot. Signed-off-by: Corey Minyard cminy...@mvista.com ---

[Qemu-devel] [PATCH 4/7] qemu-char: remove free of chr from win_stdio_close

2014-03-04 Thread minyard
From: Corey Minyard cminy...@mvista.com This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard cminy...@mvista.com --- qemu-char.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qemu-char.c

[Qemu-devel] [PATCH 7/7] console: Don't use the console if NULL

2014-03-04 Thread minyard
From: Corey Minyard cminy...@mvista.com Two spots used an allocated console, even though new_console could return NULL. Check the return value first. Signed-off-by: Corey Minyard cminy...@mvista.com --- ui/console.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-04 Thread Huangpeng (Peter)
Is there any other proposals to implement vm-snapshot? See the discussion by Paolo and Andrea about post-copy migration, which adds kernel memory management features for tracking userspace page faults. Perhaps you can use that infrastructure to trap guest writes. Stefan I will look into

Re: [Qemu-devel] [PATCH v4 1/3] qapi: Use an explicit input file

2014-03-04 Thread Lluís Vilanova
Markus Armbruster writes: Lluís Vilanova vilan...@ac.upc.edu writes: Markus Armbruster writes: [...] self.fp = schema.fp self.msg = msg self.line = self.col = 1 @@ -50,12 +52,17 @@ class QAPISchemaError(Exception): self.col += 1 def __str__(self): - return %s:%s:%s: %s %

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-04 Thread Huangpeng (Peter)
Good suggestion, The latest patches of post-copy seems updated 2 years ago. https://github.com/yamahata/qemu I'm working on post-copy at the moment, using Andrea's kernel code, using bits of Yamahata's code base as well; hopefully it won't be too long until we have something to post.

Re: [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support

2014-03-04 Thread Alex Williamson
On Tue, 2014-03-04 at 18:24 -0600, Kim Phillips wrote: On Fri, 28 Feb 2014 11:03:18 -0700 Alex Williamson alex.william...@redhat.com wrote: On Tue, 2014-02-25 at 20:37 -0600, Kim Phillips wrote: - support allocating a variable number of regions - VFIODevice's bars[] become

Re: [Qemu-devel] [RFC v2 1/2] i386: introduce struct X86TopoInfo for saving cpu topology information

2014-03-04 Thread Chen Fan
On Tue, 2014-03-04 at 16:35 -0300, Eduardo Habkost wrote: On Tue, Mar 04, 2014 at 06:50:24PM +0800, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- hw/i386/pc.c | 13 + target-i386/cpu.c | 16 target-i386/cpu.h |

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-04 Thread Huangpeng (Peter)
Hi, Andrea Where can I get the dev-git-branch? I can use it to try the snapshot prototype coding. Thanks. -Original Message- From: Andrea Arcangeli [mailto:aarca...@redhat.com] Sent: Tuesday, March 04, 2014 3:52 AM To: Paolo Bonzini Cc: Kevin Wolf; Stefan Hajnoczi; Huangpeng

[Qemu-devel] [PATCH V9 00/10] qapi script: support enum as discriminator and better enum name

2014-03-04 Thread Wenchao Xia
This series address two issues: 1. support using enum as discriminator in union. For example, if we have following define in qapi schema: { 'enum': 'EnumOne', 'data': [ 'value1', 'value2', 'value3' ] } { 'type': 'UserDefBase0', 'data': { 'base-string0': 'str', 'base-enum0': 'EnumOne' } }

[Qemu-devel] [PATCH V9 02/10] qapi script: add check for duplicated key

2014-03-04 Thread Wenchao Xia
It is bad that same key was specified twice, especially when a union has two branches with same condition. This patch can prevent it. Signed-off-by: Wenchao Xia wenchaoq...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py |2 ++ tests/Makefile

[Qemu-devel] [PATCH V9 04/10] qapi script: check correctness of union

2014-03-04 Thread Wenchao Xia
Since line info is remembered as QAPISchema.line now, this patch uses it as additional info for every expr in QAPISchema inside qapi.py, then improves error message with it in checking of exprs. For common union the patch will check whether base is a valid complex type if specified. For flat

[Qemu-devel] [PATCH V9 09/10] qapi script: do not allow string discriminator

2014-03-04 Thread Wenchao Xia
Since enum based discriminators provide better type-safety and ensure that future qapi additions do not forget to adjust dependent unions, forbid using string as discriminator from now on. Signed-off-by: Wenchao Xia wenchaoq...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com ---

[Qemu-devel] [PATCH V9 03/10] qapi script: remember line number in schema parsing

2014-03-04 Thread Wenchao Xia
Before this patch, 'QAPISchemaError' scans whole input until 'pos' to get error line number. After this patch, the scan is avoided since line number is remembered in schema parsing. This patch also benefits other error report functions, which would be introduced later. Signed-off-by: Wenchao Xia

[Qemu-devel] [PATCH V9 05/10] qapi script: code move for generate_enum_name()

2014-03-04 Thread Wenchao Xia
Later both qapi-types.py and qapi-visit.py need a common function for enum name generation. Signed-off-by: Wenchao Xia wenchaoq...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi-types.py | 10 -- scripts/qapi.py | 10 ++ 2 files changed, 10

[Qemu-devel] [PATCH V9 06/10] qapi script: use same function to generate enum string

2014-03-04 Thread Wenchao Xia
Prior to this patch, qapi-visit.py used custom code to generate enum names used for handling a qapi union. Fix it to instead reuse common code, with identical generated results, and allowing future updates to generation to only need to touch one place. Signed-off-by: Wenchao Xia

[Qemu-devel] [PATCH V9 10/10] qapi script: do not add _ for every capitalized char in enum

2014-03-04 Thread Wenchao Xia
Now enum AIOContext will generate AIO_CONTEXT instead of A_I_O_CONTEXT, X86CPU will generate X86_CPU instead of X86_C_P_U. Signed-off-by: Wenchao Xia wenchaoq...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/qapi/qmp/qerror.h |2 +- scripts/qapi.py | 26

Re: [Qemu-devel] [PATCH qom-cpu 0/6] cpu: Unifying features parsing

2014-03-04 Thread Alexey Kardashevskiy
On 03/04/2014 01:55 PM, Andreas Färber wrote: Hello, Prompted by Alexey's desire for tweakable PowerPCCPU properties but also by Peter's wish for ARMCPU properties, this series sets out to align cpu_model parsing across targets. QemuOpts would've been nice to use, but on the one hand x86

[Qemu-devel] [PATCH V9 07/10] qapi script: support enum type as discriminator in union

2014-03-04 Thread Wenchao Xia
By default, any union will automatically generate a enum type as [UnionName]Kind in C code, and it is duplicated when the discriminator is specified as a pre-defined enum type in schema. After this patch, the pre-defined enum type will be really used as the switch case condition in generated C

[Qemu-devel] [PATCH V9 01/10] qapi script: remember explicitly defined enum values

2014-03-04 Thread Wenchao Xia
Later other scripts will need to check the enum values. Signed-off-by: Wenchao Xia wenchaoq...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py| 16 +++- tests/qapi-schema/comments.out |2 +-

[Qemu-devel] [PATCH v1] ppc: Force CPU threads count to be a power of 2.

2014-03-04 Thread Bharata B Rao
PowerPC kernel expects the number of SMT threads in a core to be a power of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel crash if invalid threads count is specified. Prevent this crash and make it a graceful exit from QEMU itself by validating the user supplied threads

[Qemu-devel] [PATCH V9 08/10] qapi: convert BlockdevOptions to use enum discriminator

2014-03-04 Thread Wenchao Xia
After this patch, hidden enum type BlockdevOptionsKind will not be generated, and other API can use enum BlockdevDriver. Signed-off-by: Wenchao Xia wenchaoq...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com --- qapi-schema.json | 14 +- 1 files changed, 13 insertions(+), 1

Re: [Qemu-devel] [PATCH 2.1 28/28] qmp: add query-memdev

2014-03-04 Thread Hu Tao
On Tue, Mar 04, 2014 at 07:11:53PM +0100, Paolo Bonzini wrote: Il 04/03/2014 18:37, Eric Blake ha scritto: On 03/04/2014 07:00 AM, Paolo Bonzini wrote: From: Hu Tao hu...@cn.fujitsu.com Add qmp command query-memdev to query for information of memory devices Signed-off-by: Hu Tao

Re: [Qemu-devel] [PATCH 2.1 28/28] qmp: add query-memdev

2014-03-04 Thread Hu Tao
... + +MemdevList *qmp_query_memdev(Error **errp) +{ +QmpOutputVisitor *ov = qmp_output_visitor_new(); +QmpInputVisitor *iv; +QObject *obj; +MemdevList *list = NULL, *m; +HostMemoryBackend *backend; +Error *err = NULL; +int i; + +for (i = 0; i

Re: [Qemu-devel] [PATCH v1] ppc: Force CPU threads count to be a power of 2.

2014-03-04 Thread Eric Blake
On 03/04/2014 08:36 PM, Bharata B Rao wrote: PowerPC kernel expects the number of SMT threads in a core to be a power of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel crash if invalid threads count is specified. Prevent this crash and make it a graceful exit from QEMU

Re: [Qemu-devel] [RFC 1/2] hw/arm/virt: add a Calxeda XGMAC device

2014-03-04 Thread Eric Auger
Hi Kim, - Parameter 'driver' expects pluggable device type this can be fixed setting dc-cannot_instantiate_with_device_add_yet to false in vfio_platform_dev_class_init. You do not get the error anymore. However I must aknowledge I have not studies all possible side effects of this setting and

[Qemu-devel] [PATCH] spapr-vscsi: fix CRQ status

2014-03-04 Thread Alexey Kardashevskiy
Normally VIOSRP_OK (0) means success and non-zero value means error except VIOSRP_OK2 (0x99) which is another success code by weird accident. This uses 0 as success code always as some guests do not cope with the 0x99 value well. The existing linux driver checks for both VIOSRP_OK and VIOSRP_OK2

Re: [Qemu-devel] [PATCH v1] ppc: Force CPU threads count to be a power of 2.

2014-03-04 Thread Bharata B Rao
On Tue, Mar 04, 2014 at 09:13:38PM -0700, Eric Blake wrote: On 03/04/2014 08:36 PM, Bharata B Rao wrote: PowerPC kernel expects the number of SMT threads in a core to be a power of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel crash if invalid threads count is

Re: [Qemu-devel] [PATCH 1/1] vl.c: Add pci_hole_min_size machine option.

2014-03-04 Thread Michael S. Tsirkin
On Tue, Mar 04, 2014 at 06:51:11PM -0500, Don Slutz wrote: On 03/04/14 17:20, Michael S. Tsirkin wrote: On Tue, Mar 04, 2014 at 02:18:49PM -0500, Don Slutz wrote: On 03/04/14 11:58, Michael S. Tsirkin wrote: On Tue, Mar 04, 2014 at 11:36:44AM -0500, Don Slutz wrote: On 03/04/14 02:34, Michael

Re: [Qemu-devel] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-04 Thread Amos Kong
On Tue, Mar 04, 2014 at 03:03:08PM -0700, Eric Blake wrote: Hi Eric, On 03/03/2014 10:51 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current

[Qemu-devel] BayTrail support

2014-03-04 Thread Praveen Bajantri
Hi Everyone, I am not sure whether I should post my query here. I want to try and boot android on top of a linux for intel BayTrail processor using KVM-QEMU. I had hard time in finding any tablet/board for this purpose. Does anyone has tried it before ? Thanks in advance.

[Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-03-04 Thread Martin Pitt
Confirmed, this works now. Thanks! Closing, as this only affected the PPA. ** Changed in: qemu (Ubuntu) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support

2014-03-04 Thread Eric Auger
Hi Kim, 1) I agree with Alex on the fact I would prefer to have the qemu-side platform device code separated from PCI device one, both using a separate generic helper code. Indeed calling functions referencing BAR in the platform device does not look natural to me; although I understand the code

<    1   2   3