[Qemu-devel] [RFC] support memory reserved feature and optimize mlock guest memory propose

2014-03-05 Thread Zhanghailiang
Hi all: Currently, we use cgroup(memory) to support memory QoS on KVM platform, and use "mlock" on qemu to support "memory reserved". The "mlock" seems to be not appropriate. Now qemu "mlock" memory in the main thread, which would lock iothread (qemu_mutex_lock_iothread), if the memory size is la

Re: [Qemu-devel] [PATCH 0/4] qom: link property fixes

2014-03-05 Thread Paolo Bonzini
Il 04/03/2014 22:45, Stefan Hajnoczi ha scritto: There are two problems with QOM link properties: 1. There are refcount leaks in many object_property_add_link() callers. 2. There is no way to prevent link properties from being set after a device is realized. This patch series fixes these iss

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Markus Armbruster
Eric Blake writes: > On 02/28/2014 02:01 PM, Markus Armbruster wrote: >> The encrypted images Saturday afternoon hack is a gift that keeps on >> giving. I wish we could rip it out and bury it deep. Or that I could >> continue to ignore it. Unfortunately, it looks like I need to touch it >> to

Re: [Qemu-devel] [PATCH] spapr-vscsi: fix CRQ status

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 06:15, Alexey Kardashevskiy ha scritto: Normally VIOSRP_OK (0) means success and non-zero value means error except VIOSRP_OK2 (0x99) which is another success code by weird accident. This uses 0 as success code always as some guests do not cope with the 0x99 value well. The existing

Re: [Qemu-devel] [PATCH 2.1 28/28] qmp: add query-memdev

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 04:50, Hu Tao ha scritto: > >"bind" is not one of the values of HostMemPolicy - is that missing from > >patch 27/28? > > Should be membind. How about change it into bind to keep in line with MPOL_BIND? Sure! Paolo

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Markus Armbruster
Paolo Bonzini writes: > Il 28/02/2014 23:08, Eric Blake ha scritto: >> Use the fact that we are calling the next release "2.0" to actually kill >> qemu disk encryption as a horribly botched feature, on the grounds that >> we are doing users a favor by not letting them use broken encryption? > > O

Re: [Qemu-devel] [PATCH 0/2] PC: improve emulation correctness

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 00:49, Michael S. Tsirkin ha scritto: On Mon, Mar 03, 2014 at 11:05:17PM +0100, Hervé Poussineau wrote: Ping. QEMU crash at reboot is due to not resetting PAM registers at i440fx reset, but a patch has already been rejected on ML: http://lists.gnu.org/archive/html/qemu-devel/2013-

Re: [Qemu-devel] [PATCH qom-cpu 0/6] cpu: Unifying features parsing

2014-03-05 Thread Andreas Färber
Am 05.03.2014 03:50, schrieb Alexey Kardashevskiy: > On 03/04/2014 01:55 PM, Andreas Färber wrote: >> Hello, >> >> Prompted by Alexey's desire for tweakable PowerPCCPU properties but also by >> Peter's wish for ARMCPU properties, this series sets out to align cpu_model >> parsing across targets. >>

[Qemu-devel] [PATCH v2] ppc: Force CPU threads count to be a power of 2.

2014-03-05 Thread Bharata B Rao
PowerPC kernel expects the number of SMT threads in a core to be a power of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel crash if invalid threads count is specified. Prevent this crash and make it a graceful exit from QEMU itself by validating the user supplied threads cou

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.02.2014 um 22:01 hat Markus Armbruster geschrieben: >> Questions: >> >> 1. Should we protect guests from state NEEDKEY? > > Yes. An image in state NEEDKEY isn't fully initialised, so we should > make sure that it isn't used. Consensus. >> 2. If yes, how? >> >>Pa

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-03-05 Thread Anton Ivanov (antivano)
On 04/03/14 15:53, Eric Blake wrote: > On 03/04/2014 08:22 AM, Anton Ivanov (antivano) wrote: >> Apologies, missed to diff the json definitions. >> >> Attached. >> > Missing a commit message and a Signed-off-by line, so it can't be > applied as-is. Also, we prefer inline patches (as sent by 'git >

Re: [Qemu-devel] [RFC] support memory reserved feature and optimize mlock guest memory propose

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 09:01, Zhanghailiang ha scritto: > Hi all: > > Currently, we use cgroup(memory) to support memory QoS on KVM platform, > and use "mlock" on qemu to support "memory reserved". > > The "mlock" seems to be not appropriate. > > Now qemu "mlock" memory in the main thread, which would lo

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-03-05 Thread Stefan Hajnoczi
On Tue, Mar 04, 2014 at 09:47:09AM +, Anton Ivanov (antivano) wrote: > On 04/03/14 09:36, Stefan Hajnoczi wrote: > > On Mon, Mar 03, 2014 at 02:01:00PM +, Anton Ivanov (antivano) wrote: > >> On 03/03/14 13:27, Stefan Hajnoczi wrote: > >>> On Fri, Feb 28, 2014 at 08:28:11AM +, Anton Ivan

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 09:24, Markus Armbruster ha scritto: Paolo Bonzini writes: Il 28/02/2014 23:08, Eric Blake ha scritto: Use the fact that we are calling the next release "2.0" to actually kill qemu disk encryption as a horribly botched feature, on the grounds that we are doing users a favor by n

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-03-05 Thread Stefan Hajnoczi
On Tue, Mar 04, 2014 at 11:32:26AM +, Anton Ivanov (antivano) wrote: > > If you really *need* the page size, please use sysconf(_SC_PAGESIZE). > > I like to have it page aligned and if possible page sized so I can later > extend to do jumbo frame support via a vector. If this is the wrong way

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 02:00, Huangpeng (Peter) ha scritto: One question: Can post-copy fallback if exceptions happen during post-copy? What do you mean by 'exceptions' here? Generally postcopy can't fall back to precopy because once you're in postcopy mode the state is split between the two machines.

Re: [Qemu-devel] [PATCH v2 0/3] migration: add more traces

2014-03-05 Thread Stefan Hajnoczi
On Tue, Mar 04, 2014 at 01:32:54PM +0100, Paolo Bonzini wrote: > Il 04/03/2014 05:10, Alexey Kardashevskiy ha scritto: > >This reworks/adds traces for migration. > >v2 is rework of an original single patch with the same subject. > > > >Alexey Kardashevskiy (3): > > vl: add system_wakeup_request tr

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-03-05 Thread Vincenzo Maffione
I think the would be nice if we add a command-line option (or maybe even an option that can be changed dinamically) for the net backend that enables/disables the use of the CORK flag, so that the device emulation can use it anyways, but backend does really use it (and so there are real effects) onl

Re: [Qemu-devel] [PATCH] spapr-vscsi: fix CRQ status

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 06:15, Alexey Kardashevskiy ha scritto: Normally VIOSRP_OK (0) means success and non-zero value means error except VIOSRP_OK2 (0x99) which is another success code by weird accident. This uses 0 as success code always as some guests do not cope with the 0x99 value well. The existing

[Qemu-devel] [PULL 1/1] s390x/virtio-ccw: Adapter interrupt support.

2014-03-05 Thread Cornelia Huck
Handle the new CCW_CMD_SET_IND_ADAPTER command enabling adapter interrupts on guest request. When active, host->guest notifications will be handled via global_indicator -> queue indicators instead of queue indicators + subchannel I/O interrupt. Indicators for virtqueues may be present at an offset.

[Qemu-devel] [PULL 0/1] virtio-ccw: adapter interrupts

2014-03-05 Thread Cornelia Huck
The following changes since commit f55ea6297cc0224fe4934b90ff5343b620b14669: block/gluster: Add missing argument to qemu_gluster_init() call (2014-03-04 20:20:57 +) are available in the git repository at: git://github.com/cohuck/qemu.git tags/virtio-ccw-20140305 for you to fetch

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 09:43, Markus Armbruster ha scritto: Or we can do our users a favor and kill support for encrypted images dead (except in qemu-img, of course). Revive when we have encryption that actually works, both in the safety and security sense. I think this is okay, since the patch should

Re: [Qemu-devel] [PATCH 0/4] qom: link property fixes

2014-03-05 Thread Andreas Färber
Am 05.03.2014 09:14, schrieb Paolo Bonzini: > Il 04/03/2014 22:45, Stefan Hajnoczi ha scritto: >> There are two problems with QOM link properties: >> >> 1. There are refcount leaks in many object_property_add_link() callers. >> 2. There is no way to prevent link properties from being set after a >>

Re: [Qemu-devel] [PATCH 1/4] qom: split object_property_set_link()

2014-03-05 Thread Andreas Färber
Am 04.03.2014 22:45, schrieb Stefan Hajnoczi: > The path resolution logic in object_property_set_link() should be a > separate function. This makes the code easier to read and maintain. > > More importantly, the error behavior of object_property_set_link() is > dangerous. It sets the link proper

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Gerd Hoffmann
Hi, > I can't see why QMP commands would ever want to create in state NEEDKEY. > We could easily avoid it there: give QMP commands creating > BlockDriverStates an optional password parameter, fail the command if > the BDS is encrypted and the password parameter is missing. Fully agree. The cha

Re: [Qemu-devel] [PATCH 0/4] qom: link property fixes

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 10:24, Andreas Färber ha scritto: Am 05.03.2014 09:14, schrieb Paolo Bonzini: Il 04/03/2014 22:45, Stefan Hajnoczi ha scritto: There are two problems with QOM link properties: 1. There are refcount leaks in many object_property_add_link() callers. 2. There is no way to prevent li

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Andreas Färber
Am 05.03.2014 09:43, schrieb Markus Armbruster: > Kevin Wolf writes: > >> 'change' is a bit trickier because it involves several low-level actions >> at once, and device_add is not one of them. > > The problem is that it can run while a device model is attached. What exactly is the problem here

[Qemu-devel] [PATCH v2 0/4] qom: link property fixes

2014-03-05 Thread Stefan Hajnoczi
v2: * A NULL set() callback should make the property read-only There are two problems with QOM link properties: 1. There are refcount leaks in many object_property_add_link() callers. 2. There is no way to prevent link properties from being set after a device is realized. This patch series f

[Qemu-devel] [PATCH v2 1/4] qom: split object_property_set_link()

2014-03-05 Thread Stefan Hajnoczi
The path resolution logic in object_property_set_link() should be a separate function. This makes the code easier to read and maintain. More importantly, the error behavior of object_property_set_link() is dangerous. It sets the link property object to NULL if an error occurs. A setter function

[Qemu-devel] [PATCH v2 3/4] qom: add set() argument to object_property_add_link()

2014-03-05 Thread Stefan Hajnoczi
There are currently three types of object_property_add_link() callers: 1. The link property may be set at any time. 2. The link property of a DeviceState instance may only be set before realize. 3. The link property may never be set, it is read-only. Something similar can already be achieved w

[Qemu-devel] [PATCH v2 2/4] qom: make QOM link property unref optional

2014-03-05 Thread Stefan Hajnoczi
Some object_property_add_link() callers expect property deletion to unref the link property object. Other callers expect to manage the refcount themselves. The former are currently broken and therefore leak the link property object. This patch adds the bool unref_on_release argument to object_pr

[Qemu-devel] [PATCH v2 4/4] virtio-rng: avoid default_backend refcount leak

2014-03-05 Thread Stefan Hajnoczi
QOM child properties take a reference to the object and release it when the property is deleted. Therefore we should unref the default_backend after we have added it as a child property. Cc: KONRAD Frederic Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio-rng.c | 3 +++ 1 file changed, 3 in

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Markus Armbruster
Paolo Bonzini writes: > Il 05/03/2014 09:24, Markus Armbruster ha scritto: >> Paolo Bonzini writes: >> >>> Il 28/02/2014 23:08, Eric Blake ha scritto: Use the fact that we are calling the next release "2.0" to actually kill qemu disk encryption as a horribly botched feature, on the gro

Re: [Qemu-devel] [PATCHv3 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-03-05 Thread Paolo Bonzini
Il 19/02/2014 10:05, Mark Cave-Ayland ha scritto: +#define CG3_REG_SIZE0x20 + +#define CG3_REG_FBC_CTRL0x10 +#define CG3_REG_FBC_STATUS 0x11 +#define CG3_REG_FBC_CURSTART0x12 +#define CG3_REG_FBC_CUREND 0x13 +#define CG3_REG_FBC_VCTRL 0x14 + +typedef struct

Re: [Qemu-devel] [PATCH 2.1 08/28] vl: convert -m to QemuOpts

2014-03-05 Thread Andreas Färber
Am 04.03.2014 15:00, schrieb Paolo Bonzini: > From: Igor Mammedov > > Adds option to -m > "mem" - startup memory amount Sorry for jumping in late, but assuming that -m is for "memory" already, wouldn't it make more sense to name it "size" instead of "mem"? > > For compatibility with legacy CL

Re: [Qemu-devel] [PATCH 2.1 07/28] qemu-option: introduce qemu_find_opts_singleton

2014-03-05 Thread Andreas Färber
Am 04.03.2014 15:00, schrieb Paolo Bonzini: > Reviewed-by: Laszlo Ersek > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Kevin Wolf
Am 05.03.2014 um 09:15 hat Markus Armbruster geschrieben: > Eric Blake writes: > > Uggh - so there's no current way to hot-plug a device in state GOTKEY > > short of using a two-command sequence? It would be nicer if hot-plug > > had a way to fail to add encrypted devices unless the user also pas

Re: [Qemu-devel] [PATCH 2.1 08/28] vl: convert -m to QemuOpts

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 11:06, Andreas Färber ha scritto: Am 04.03.2014 15:00, schrieb Paolo Bonzini: From: Igor Mammedov Adds option to -m "mem" - startup memory amount Sorry for jumping in late, but assuming that -m is for "memory" already, wouldn't it make more sense to name it "size" instead of "

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Markus Armbruster
Andreas Färber writes: > Am 05.03.2014 09:43, schrieb Markus Armbruster: >> Kevin Wolf writes: >> >>> 'change' is a bit trickier because it involves several low-level actions >>> at once, and device_add is not one of them. >> >> The problem is that it can run while a device model is attached.

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 11:36, Markus Armbruster ha scritto: Andreas Färber writes: Am 05.03.2014 09:43, schrieb Markus Armbruster: Kevin Wolf writes: 'change' is a bit trickier because it involves several low-level actions at once, and device_add is not one of them. The problem is that it can run

Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-05 Thread Gerd Hoffmann
On Di, 2014-03-04 at 14:20 -0500, Gabriel L. Somlo wrote: >- deprecate passing individual smbios fields (SMBIOS_FIELD_ENTRY) >- added functionality to build full tables instead, and pass them > to the bios via fw_cfg as SMBIOS_TABLE_ENTRY blobs >- added code to optionally build typ

Re: [Qemu-devel] [PATCH 2.1 00/28] Current state of NUMA series, and hostmem improvements

2014-03-05 Thread Andreas Färber
Am 04.03.2014 15:00, schrieb Paolo Bonzini: > This series includes all the pending work on QOMifying the memory > backends. [snip] There's also a recent RFC from Chen Fan about how to model the association between NUMA nodes and CPU socket/core/thread that would/should influence this series if we'

[Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread hong-hua....@freescale.com
Hi Gibson, I noticed your patch http://git.qemu.org/?p=qemu.git;a=commitdiff;h=89dfd6e1 and have some question about PCI bus name on PowerPC. When I use libvirt to start VM on PowerPC platforms, it failed as below: # virsh start sdk error: Failed to start domain sdk error: internal error: early

Re: [Qemu-devel] BayTrail support

2014-03-05 Thread Andreas Färber
Hi, Am 05.03.2014 08:27, schrieb Praveen Bajantri: > I am not sure whether I should post my query here. > I want to try and boot android on top of a linux for intel BayTrail > processor using KVM-QEMU. I had hard time in finding any tablet/board for > this purpose. Does anyone has tried it before

[Qemu-devel] Contribution - L2TPv3 - resubmit

2014-03-05 Thread Anton Ivanov (antivano)
Hi all, This is a functional driver which will interoperate versus most L2TPv3 implementations. It cannot be split into smaller patches - this is an entire transport. It will get one small incremental update at a later date. Some broken l2tpv3 implementations require a counter field but do not

Re: [Qemu-devel] [RFC 1/2] hw/arm/virt: add a Calxeda XGMAC device

2014-03-05 Thread Andreas Färber
Hi, Am 05.03.2014 05:27, schrieb Eric Auger: > Hi Kim, > > - Parameter 'driver' expects pluggable device type > this can be fixed setting dc->cannot_instantiate_with_device_add_yet to > false in vfio_platform_dev_class_init. You do not get the error anymore. > However I must aknowledge I have not

Re: [Qemu-devel] [PATCH qom-cpu 0/6] cpu: Unifying features parsing

2014-03-05 Thread Alexey Kardashevskiy
On 03/05/2014 07:30 PM, Andreas Färber wrote: > Am 05.03.2014 03:50, schrieb Alexey Kardashevskiy: >> On 03/04/2014 01:55 PM, Andreas Färber wrote: >>> Hello, >>> >>> Prompted by Alexey's desire for tweakable PowerPCCPU properties but also by >>> Peter's wish for ARMCPU properties, this series sets

Re: [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support

2014-03-05 Thread Andreas Färber
Am 05.03.2014 02:23, schrieb Alex Williamson: > On Tue, 2014-03-04 at 18:24 -0600, Kim Phillips wrote: >> On Fri, 28 Feb 2014 11:03:18 -0700 >> Alex Williamson wrote: >> >>> This all looks reasonable, but I suspect it would be cleaner if >>> vfio_find_get_group() was in a common file along with ba

Re: [Qemu-devel] [PATCH 2.1 00/28] Current state of NUMA series, and hostmem improvements

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 12:05, Andreas Färber ha scritto: Am 04.03.2014 15:00, schrieb Paolo Bonzini: This series includes all the pending work on QOMifying the memory backends. [snip] There's also a recent RFC from Chen Fan about how to model the association between NUMA nodes and CPU socket/core/threa

Re: [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support

2014-03-05 Thread Paolo Bonzini
Il 05/03/2014 12:28, Andreas Färber ha scritto: Am 05.03.2014 02:23, schrieb Alex Williamson: On Tue, 2014-03-04 at 18:24 -0600, Kim Phillips wrote: On Fri, 28 Feb 2014 11:03:18 -0700 Alex Williamson wrote: This all looks reasonable, but I suspect it would be cleaner if vfio_find_get_group()

Re: [Qemu-devel] Contribution - L2TPv3 transport

2014-03-05 Thread Peter Maydell
On 5 March 2014 08:49, Anton Ivanov (antivano) wrote: > On 04/03/14 15:53, Eric Blake wrote: >> Missing a commit message and a Signed-off-by line, so it can't be >> applied as-is. Also, we prefer inline patches (as sent by 'git >> send-email') over attached patches; I suggest using 'git send-emai

Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms

2014-03-05 Thread Alexey Kardashevskiy
On 03/05/2014 09:42 PM, hong-hua@freescale.com wrote: > Hi Gibson, > > I noticed your patch http://git.qemu.org/?p=qemu.git;a=commitdiff;h=89dfd6e1 > and have some question about PCI bus name on PowerPC. > > When I use libvirt to start VM on PowerPC platforms, it failed as below: > # virsh s

Re: [Qemu-devel] Contribution - L2TPv3 - resubmit

2014-03-05 Thread Andreas Färber
Hi, Am 05.03.2014 12:20, schrieb Anton Ivanov (antivano): > This is a functional driver which will interoperate versus most L2TPv3 > implementations. It cannot be split into smaller patches - this is an > entire transport. [snip] Please see http://wiki.qemu.org/Contribute/SubmitAPatch - in part

[Qemu-devel] [PULL v4 00/38] rework input handling, sdl2 support

2014-03-05 Thread Gerd Hoffmann
Hi, The input layer moves to a model modeled roughly after the linux event layer. It also uses qapi to create all the data types needed. First, because it is convinient to have all the support code generated, and also to make it easier to integrate with qmp some day. Porting work has only be d

[Qemu-devel] [PULL v4 08/38] input: keyboard: switch legacy handlers to new core

2014-03-05 Thread Gerd Hoffmann
legacy kbd event handlers are registered in the new core, so they receive events from the new input core code. keycode -> scancode translation needed here. legacy kbd_put_keycode() sends events to the new core. scancode -> keycode translation needed here. So with this patch the new input core is

[Qemu-devel] [PULL v4 03/38] input: qapi: define event types

2014-03-05 Thread Gerd Hoffmann
Define input event types, using qapi. So we get nicely autogenerated types for our input events. And when it comes to qmp support some day things will be a lot easier. Types are modeled after the linux input layer. There are separate event types for each value. There is a sync to indicate the

[Qemu-devel] [PULL v4 05/38] input: qapi: add pause key

2014-03-05 Thread Gerd Hoffmann
It's missing. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 609d576..6c381b7 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3556,7 +3556,7 @@

[Qemu-devel] [PULL v4 02/38] input: rename file to legacy

2014-03-05 Thread Gerd Hoffmann
Rename ui/input.c to ui/input-legacy.c. We are going to replace it step by step. Signed-off-by: Gerd Hoffmann --- ui/Makefile.objs | 2 +- ui/{input.c => input-legacy.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename ui/{input.c => input-legacy.c} (100%) diff --git a/

[Qemu-devel] [PULL v4 09/38] input: keyboard: switch qmp_send_key() to new core.

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 80f4f5c..a4006cc 100644 --- a/ui/input-legacy.c +++ b/ui/input-legacy.c @@ -260,10 +260,8 @@ static void free_keycodes(voi

[Qemu-devel] [PULL v4 11/38] input: keyboard: switch sdl ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 9d8583c..e78e020 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -30,6 +30,7 @@ #include "qemu-common.h" #include "ui/console.h" +#inclu

[Qemu-devel] [PULL v4 01/38] console: export QemuConsole index, width, height

2014-03-05 Thread Gerd Hoffmann
Add functions to query QemuConsole properties. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 3 +++ ui/console.c | 24 2 files changed, 27 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 4156a87..8543d18 100644 --- a/inclu

[Qemu-devel] [PULL v4 16/38] input: mouse: add graphic_rotate support

2014-03-05 Thread Gerd Hoffmann
Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absolute and relative events, but the logic is broken for relative coordinates, so this is most likely not used anyway. Signed-off-by: Gerd Hoffmann --- ui/input.c | 31 ++

[Qemu-devel] [PULL v4 35/38] input: remove index_from_keycode (no users)

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - ui/input-legacy.c| 14 -- 2 files changed, 15 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 9a282cb..3bf69ee 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -329,7 +329,6 @

[Qemu-devel] [PULL v4 18/38] input: mouse: switch legacy handlers to new core

2014-03-05 Thread Gerd Hoffmann
legacy mouse event handlers are registered in the new core, so they receive events submitted to the new input core. legacy kbd_mouse_event() continues to use the old code paths. So new-core event handlers wouldn't see events submitted via kbd_mouse_event. This leads to the constrain that we we mu

[Qemu-devel] [PULL v4 04/38] input: qapi: add unmapped key

2014-03-05 Thread Gerd Hoffmann
Simplifies building something -> QkeyCode mapping tables. Uninitialized entries can easily identified then. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blake --- qapi-schema.json | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index

[Qemu-devel] [PULL v4 32/38] input: add input_mouse_mode tracepoint

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 1 + ui/input.c | 1 + 2 files changed, 2 insertions(+) diff --git a/trace-events b/trace-events index fcdd570..744563c 100644 --- a/trace-events +++ b/trace-events @@ -1027,6 +1027,7 @@ input_event_btn(int conidx, const char *btn, bool down) "c

[Qemu-devel] [PULL v4 33/38] input: move qmp_query_mice to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 23 --- ui/input.c| 29 + 2 files changed, 29 insertions(+), 23 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 7f8e72b..7843482 100644 --- a/ui/input-legacy.c +++ b

[Qemu-devel] [PULL v4 14/38] input: keyboard: switch curses ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/curses.c | 47 +-- 1 file changed, 25 insertions(+), 22 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index dbc3d5e..b044790 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -30,6 +30,7 @@ #include "qemu-common

[Qemu-devel] [PULL v4 24/38] input: keyboard: switch cocoa ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 8661777..d4af3e5 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -514,16 +514,14 @@ QemuCocoaView *cocoaView; if (keycode) {

[Qemu-devel] [PULL v4 29/38] input-legacy: remove kbd_mouse_is_absolute

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - ui/input-legacy.c| 11 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 53e956d..21b32e4 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -5

[Qemu-devel] [PULL v4 10/38] input: keyboard: switch gtk ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index a633d89..74c0936 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -59,6 +59,7 @@ #include "trace.h" #include "ui/console.h" +#include "ui/input.h

[Qemu-devel] [PULL v4 28/38] input-legacy: remove kbd_mouse_has_absolute

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 3 --- ui/input-legacy.c| 21 ++--- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index c7f4e4f..53e956d 100644 --- a/include/ui/console.h +++ b/include/ui/co

[Qemu-devel] [PULL v4 26/38] input: trace events

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 8 ui/input.c | 48 2 files changed, 56 insertions(+) diff --git a/trace-events b/trace-events index d86f98c..fcdd570 100644 --- a/trace-events +++ b/trace-events @@ -1020,6 +1020,14 @@ g

[Qemu-devel] [PULL v4 15/38] input: mouse: add helpers functions to core

2014-03-05 Thread Gerd Hoffmann
Likewise a bunch of helper functions to manage mouse button and movement events, again to make life easier for the ui code. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 14 +++ ui/input.c | 71 ++ 2 files changed, 85 in

[Qemu-devel] [PULL v4 22/38] input: mouse: switch spice ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/spice-input.c | 62 ++-- 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index c9df699..6dab23b 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -98,4

[Qemu-devel] [PULL v4 06/38] input: add core bits of the new input layer

2014-03-05 Thread Gerd Hoffmann
Register and unregister handlers. Event dispatcher code. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 32 + ui/Makefile.objs | 2 +- ui/input.c | 83 ++ 3 files changed, 116 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL v4 20/38] input: mouse: switch sdl ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 84 ++-- 1 file changed, 39 insertions(+), 45 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index e78e020..b80b3df 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -351,7 +351,7 @@ static void sdl_hide

[Qemu-devel] [PULL v4 12/38] input: keyboard: switch vnc ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5601cc3..4658559 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -33,6 +33,7 @@ #include "qapi/qmp/types.h" #include "qmp-commands.h" #incl

[Qemu-devel] [PULL v4 07/38] input: keyboard: add helper functions to core

2014-03-05 Thread Gerd Hoffmann
A bunch of helper functions to manage keyboard events, to make life simpler for the ui code when submitting keyboard events. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 5 + ui/input.c | 35 +++ 2 files changed, 40 insertions(+) diff --git

[Qemu-devel] [PULL v4 25/38] input: mouse: switch cocoa ui to new core

2014-03-05 Thread Gerd Hoffmann
Build fixes by Peter Maydell. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 ++ ui/cocoa.m | 63 ++-- 2 files changed, 44 insertions(+), 21 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 8543d18.

[Qemu-devel] [PULL v4 27/38] input-legacy: remove kbd_put_keycode

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - ui/input-legacy.c| 23 --- 2 files changed, 24 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index a3062d0..c7f4e4f 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -46,7

Re: [Qemu-devel] [PATCH 02/10] tcg-aarch64: Remove redundantCPU_TLB_ENTRY_BITS checkk

2014-03-05 Thread Alex Bennée
Richard Henderson writes: > Removed from other targets in 56bbc2f967ce185fa1c5c39e1aeb5b68b26242e9. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/aarch64/tcg-target.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarc

[Qemu-devel] [PULL v4 38/38] ui/sdl2 : initial port to SDL 2.0 (v2.0)

2014-03-05 Thread Gerd Hoffmann
From: Dave Airlie I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. The biggest changes were in the input handling, where SDL2 has done a major overhaul, and I've had to include a generated translation file to get from SDL2 codes back to qemu compatible ones. I'm stil

[Qemu-devel] [PULL v4 19/38] input: mouse: switch gtk ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 58 +++--- 1 file changed, 19 insertions(+), 39 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 74c0936..1851495 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -194,7 +194,7 @@ static void gd_update_curs

Re: [Qemu-devel] [PATCH 01/10] tcg-aarch64: Enable builtin disassembler

2014-03-05 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > configure | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/configure b/configure > index 8ad03ea..d303ffc 100755 > --- a/configure > +++ b/configure > @@ -4868,6 +4868,12 @@ for i in $

[Qemu-devel] [PULL v4 37/38] console: add QemuUIInfo

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 12 ui/console.c | 17 + 2 files changed, 29 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index b2af53e..08a38ea 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@

[Qemu-devel] [PULL v4 13/38] input: keyboard: switch spice ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/spice-input.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index 3beb8de..c9df699 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -26,12 +26,15 @@ #include "qemu-common.

Re: [Qemu-devel] [PATCH 06/10] tcg-aarch64: Hoist common argument loadsin tcg_out_opp

2014-03-05 Thread Alex Bennée
Richard Henderson writes: > This reduces the code size of the function significantly. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 95 > +--- > 1 file changed, 50 insertions(+), 45 deletions(-) > > diff --git a/tcg/aarch64

Re: [Qemu-devel] [PATCH 04/10] tcg-aarch64: Set ext based onTCG_OPF_64BITT

2014-03-05 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Subject looks a little space mangled. Otherwise: Reviewed-by: Alex Bennée > --- > tcg/aarch64/tcg-target.c | 28 +++- > 1 file changed, 7 insertions(+), 21 deletions(-) > > diff --git a/tcg/aarch64/tcg-ta

Re: [Qemu-devel] [PATCH 07/10] tcg-aarch64: Remove the shift_immparameter from tcg_out_cmpp

2014-03-05 Thread Alex Bennée
Richard Henderson writes: > It was unused. Let's not overcomplicate things before we need them. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/aarch64/tcg-target.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/tcg/aarch64/tcg

Re: [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi intcg_out_opp

2014-03-05 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 20 +++- > 1 file changed, 7 insertions(+), 13 deletions(-) > > > +case INDEX_op_mov_i64: > +case INDEX_op_mov_i32: > +case INDEX_op_movi_i64: > +case INDEX_op_mov

[Qemu-devel] [PULL v4 34/38] input: move do_mouse_set to new core

2014-03-05 Thread Gerd Hoffmann
This removes the last user of the lecagy input mouse handler list, so we can remove more legacy bits with this. Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 43 --- ui/input.c| 21 + 2 files changed, 21 insertions(+), 43

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 05.03.2014 um 09:15 hat Markus Armbruster geschrieben: >> Eric Blake writes: >> > Uggh - so there's no current way to hot-plug a device in state GOTKEY >> > short of using a two-command sequence? It would be nicer if hot-plug >> > had a way to fail to add encrypted devic

Re: [Qemu-devel] The unholy encrypted image key mess

2014-03-05 Thread Markus Armbruster
Paolo Bonzini writes: > Il 05/03/2014 11:36, Markus Armbruster ha scritto: >> Andreas Färber writes: >> >>> Am 05.03.2014 09:43, schrieb Markus Armbruster: Kevin Wolf writes: > 'change' is a bit trickier because it involves several low-level actions > at once, and device_add i

[Qemu-devel] [PULL v4 30/38] input-legacy: remove kbd_mouse_event

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - ui/input-legacy.c| 49 - 2 files changed, 50 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 21b32e4..71a0da3 100644 --- a/include/ui/console.h +++ b/incl

[Qemu-devel] [PULL v4 21/38] input: mouse: switch vnc ui to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 46 ++ ui/vnc.h | 1 + 2 files changed, 23 insertions(+), 24 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 4658559..7dfc94a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1484,7 +1484,7 @@ static void client

[Qemu-devel] [PULL v4 17/38] input: mouse: add qemu_input_is_absolute()

2014-03-05 Thread Gerd Hoffmann
Same as kbd_mouse_is_absolute(), but using new input core. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 + ui/input.c | 8 2 files changed, 9 insertions(+) diff --git a/include/ui/input.h b/include/ui/input.h index c6f50c2..28afc45 100644 --- a/include/ui/input.h +++

[Qemu-devel] [PULL v4 36/38] console: add head to index to qemu consoles.

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/arm/musicpal.c| 2 +- hw/display/blizzard.c| 2 +- hw/display/cg3.c | 2 +- hw/display/cirrus_vga.c | 4 ++-- hw/display/exynos4210_fimd.c | 2 +- hw/display/g364fb.c | 2 +- hw/display/jazz_led.c| 2

[Qemu-devel] [PULL v4 23/38] input: mouse: switch monitor to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- monitor.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 3863d83..342e83b 100644 --- a/monitor.c +++ b/monitor.c @@ -39,6 +39,7 @@ #include "monitor/monitor.h" #include "qemu/readl

[Qemu-devel] [PULL v4 31/38] input: move mouse mode notifier to new core

2014-03-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 include/ui/input.h | 4 ui/input-legacy.c| 34 +- ui/input.c | 30 ++ 4 files changed, 35 insertions(+), 37 deletions(-) diff --git a/include/ui/cons

  1   2   3   >