[Qemu-devel] QEMU Command Line Options

2014-03-27 Thread Qasim Maqbool
Hi, I need to add a few command line options to QEMU. However, I am yet to determine how QEMU takes input from the command line and parses the option values. I have tried looking at various files including vl.c and cmd.c but nothing seems to work right now. Can anyone put me on the right path her

Re: [Qemu-devel] Massive read only kvm guests when backing file was missing

2014-03-27 Thread Alejandro Comisario
Seems like virtio (kvm 1.0) doesnt expose timeout on the guest side (ubuntu 12.04 on host and guest). So, how can i adjust the tinmeout on the guest ? This solution is the most logical one, but i cannot apply it! thanks for all the responses! regards Alejandro Comisario *MercadoLibre Cloud Ser

Re: [Qemu-devel] Massive read only kvm guests when backing file was missing

2014-03-27 Thread Alejandro Comisario
Seems like virtio (kvm 1.0) doesnt expose timeout on the guest side (ubuntu 12.04 on host and guest). So, how can i adjust the tinmeout on the guest ? This solution is the most logical one, but i cannot apply it! thanks for all the responses! regards Alejandro Comisario MercadoLibre Cloud Servi

Re: [Qemu-devel] [PATCH v5 10/11] spapr-vfio: add spapr-pci-vfio-host-bridge to support vfio

2014-03-27 Thread Alexey Kardashevskiy
On 03/20/2014 06:57 AM, Alex Williamson wrote: > On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: >> The patch adds a spapr-pci-vfio-host-bridge device type >> which is a PCI Host Bridge with VFIO support. The new device >> inherits from the spapr-pci-host-bridge device and adds >> th

Re: [Qemu-devel] [PATCH v5 07/11] vfio: Add guest side IOMMU support

2014-03-27 Thread Alexey Kardashevskiy
On 03/20/2014 04:25 PM, David Gibson wrote: > On Wed, Mar 19, 2014 at 01:57:41PM -0600, Alex Williamson wrote: >> On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: >>> From: David Gibson > [snip] >>> +if (!memory_region_is_ram(mr)) { >>> +DPRINTF("iommu map to non memory a

Re: [Qemu-devel] [PATCH v5 07/11] vfio: Add guest side IOMMU support

2014-03-27 Thread Alexey Kardashevskiy
On 03/22/2014 01:17 AM, Alex Williamson wrote: > On Fri, 2014-03-21 at 18:59 +1100, Alexey Kardashevskiy wrote: >> On 03/20/2014 06:57 AM, Alex Williamson wrote: >>> On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: From: David Gibson This patch uses the new IOMMU notif

Re: [Qemu-devel] [PATCH 0/9] target-ppc: VSX Bug Fixes

2014-03-27 Thread Anton Blanchard
Hi Tom, > This patch series addresses bugs in the recently added VSX > instructions. Two general defects are fixed: Thanks! This series fixes the issue I had with wget. Tested-by: Anton Blanchard Anton

Re: [Qemu-devel] [PATCH v5 05/11] vfio: Introduce VFIO address spaces

2014-03-27 Thread Alexey Kardashevskiy
On 03/20/2014 06:57 AM, Alex Williamson wrote: > On Wed, 2014-03-12 at 16:52 +1100, Alexey Kardashevskiy wrote: >> From: David Gibson >> >> The only model so far supported for VFIO passthrough devices is the model >> usually used on x86, where all of the guest's RAM is mapped into the >> (host) IO

Re: [Qemu-devel] [PATCH v7 for 2.0 3/4] raw-posix: Add full image preallocation option

2014-03-27 Thread hu...@cn.fujitsu.com
On Thu, Mar 20, 2014 at 02:22:19PM +0100, Kevin Wolf wrote: > Am 17.03.2014 um 07:53 hat Hu Tao geschrieben: > > This patch adds a new option preallocation for raw format, and implements > > full preallocation. > > > > Signed-off-by: Hu Tao > > --- > > block/raw-posix.c | 43

[Qemu-devel] [Bug 1297651] Re: KVM create a win7 guest with Qemu, it boots up fail

2014-03-27 Thread Robert Hu
[root@localhost qemu]# git branch -a * master remotes/origin/HEAD -> origin/master remotes/origin/master [root@localhost qemu]# git log db237e33 commit db237e33c08a279f0179f8f5128a6d10d9adc38a Merge: 61898bc ad1c7e0 Author: Peter Maydell Date: Wed Mar 26 17:10:15 2014 + Merge remote

Re: [Qemu-devel] Unresponsive linux guest once migrated

2014-03-27 Thread Chris Dunlop
On Fri, Mar 28, 2014 at 12:29:18AM +0100, Marcin Gibuła wrote: > W dniu 2014-03-27 23:52, Chris Dunlop pisze: >> Hi, >> >> I have a problem where I migrate a linux guest VM, and on the >> receiving side the guest goes to 100% cpu as seen by the host, and >> the guest itself is unresponsive, e.g. no

Re: [Qemu-devel] Unresponsive linux guest once migrated

2014-03-27 Thread Marcin Gibuła
W dniu 2014-03-27 23:52, Chris Dunlop pisze: Hi, I have a problem where I migrate a linux guest VM, and on the receiving side the guest goes to 100% cpu as seen by the host, and the guest itself is unresponsive, e.g. not responding to ping etc. The only way out I've found is to destroy the guest

Re: [Qemu-devel] [RFC PATCH V4 2/5] qapi: add event helper functions

2014-03-27 Thread Eric Blake
On 03/27/2014 02:03 AM, Wenchao Xia wrote: > This file holds some functions that do not need to be generated. > > Signed-off-by: Wenchao Xia > --- > include/qapi/qmp-event.h | 27 + > qapi/Makefile.objs |1 + > qapi/qmp-event.c | 70 > ++

[Qemu-devel] Unresponsive linux guest once migrated

2014-03-27 Thread Chris Dunlop
Hi, I have a problem where I migrate a linux guest VM, and on the receiving side the guest goes to 100% cpu as seen by the host, and the guest itself is unresponsive, e.g. not responding to ping etc. The only way out I've found is to destroy the guest. This seems to only happen if the guest has b

[Qemu-devel] networking stalls in the guest -- backlog in the host

2014-03-27 Thread David Ahern
We are hitting a networking problem and hoping someone has an idea -- perhaps a known bug. After a couple of hours of runtime with low level traffic (e.g., 1 sec pings) the VM stops receiving packets. In the host running tc on the tap device shows a full backlog and packets getting dropped:

Re: [Qemu-devel] [PATCH 1/7] monitor: Add command_completion callback to mon_cmd_t.

2014-03-27 Thread Hani Benhabiles
On Thu, Mar 27, 2014 at 04:21:51PM -0400, Luiz Capitulino wrote: > > I think this patch has to be split into at least three patches. One for > the drive_del change (which is unrelated with the other stuff), one > converting device_add & device_del and the third one converting > object_add and obje

Re: [Qemu-devel] [PATCH 4/7] monitor: Add cpu index argument completion.

2014-03-27 Thread Hani Benhabiles
On Thu, Mar 27, 2014 at 04:24:50PM -0400, Luiz Capitulino wrote: > On Sun, 9 Mar 2014 12:16:14 +0100 > Hani Benhabiles wrote: > > > Signed-off-by: Hani Benhabiles > > Honest question: is this one really worth it? Aren't we just > auto-completing a single integer? It could for example serve fo

Re: [Qemu-devel] [PATCH 0/7] monitor: Completion support for various commands.

2014-03-27 Thread Hani Benhabiles
On Thu, Mar 27, 2014 at 04:26:15PM -0400, Luiz Capitulino wrote: > On Sun, 9 Mar 2014 12:16:10 +0100 > Hani Benhabiles wrote: > > > This patch series adds a new callback to mon_cmd_t which will make adding > > completion support for more commands cleaner. > > > > It then adds full or partial ar

Re: [Qemu-devel] [PATCH 16/16] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2014-03-27 Thread Eric Blake
On 02/11/2014 06:08 AM, Samuel Thibault wrote: > This patchs adds parameters to manage some new options in the qemu -net s/patchs/patch/ > command. > Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in > argument to the qemu command. > Defaults parameters are respectively fec

Re: [Qemu-devel] [PATCH v2 2/2] tests: correctly skip qtest on non-POSIX hosts

2014-03-27 Thread Stefan Weil
Am 27.03.2014 15:28, schrieb Stefan Hajnoczi: > qtest test cases only work on POSIX hosts. The following line only > defines dependencies for qtest binaries on POSIX hosts: > > check-qtest-$(CONFIG_POSIX)=$(foreach > TARGET,$(TARGETS),$(check-qtest-$(TARGET)-y)) > > But the QTEST_TARGETS defi

Re: [Qemu-devel] [PATCH v2 1/2] tests: skip POSIX-only tests on Windows

2014-03-27 Thread Stefan Weil
Am 27.03.2014 15:28, schrieb Stefan Hajnoczi: > test-aio, test-rfifolock, and test-vmstate only build on POSIX hosts. > Exclude them if building for Windows. > > Signed-off-by: Stefan Hajnoczi > --- > tests/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/

Re: [Qemu-devel] [PATCH 1/2] tests: skip POSIX-only tests on Windows

2014-03-27 Thread Stefan Weil
Am 27.03.2014 12:53, schrieb Paolo Bonzini: > Il 27/03/2014 12:11, Stefan Hajnoczi ha scritto: >> test-aio, test-rfifolock, and test-vmstate only build on POSIX hosts. > > test-aio should build on Win32. Can be fixed in 2.1 though. > > Paolo > The modifications for tests-aio.c are trivial: con

Re: [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements

2014-03-27 Thread Luiz Capitulino
On Fri, 21 Mar 2014 19:42:19 -0400 Cole Robinson wrote: > Minor error API cleanups, and one error reporting improvement when > connected to qmp (patch #5) Applied to the qmp-next branch, very nice cleanup!

Re: [Qemu-devel] Missing guest clock-sync on Host clock change

2014-03-27 Thread Laszlo Ersek
On 03/27/14 21:14, Erik Rull wrote: > Laszlo Ersek wrote: >> On 03/27/14 09:41, Erik Rull wrote: >>> Hi all, >>> >>> I would like to have the guest "drifting" to a new set clock on the >>> host. >>> >>> My problem is the following: >>> >>> - Host System (Linux) starts up, hwclock and kernel time ar

Re: [Qemu-devel] [PATCH for-2.0] tcg-arm: Avoid ldrd/strd for user-only emulation

2014-03-27 Thread Peter Maydell
On 25 March 2014 21:17, Richard Henderson wrote: > The arm ldrd/strd insns must cause alignment traps, whereas > at least for armv7 ldr/str must handle unaligned operations. > > While this is hardly the only problem facing user-only emu, > this solves one problem for i386 on armv7 emulation. > > C

Re: [Qemu-devel] [PATCH 0/7] monitor: Completion support for various commands.

2014-03-27 Thread Luiz Capitulino
On Sun, 9 Mar 2014 12:16:10 +0100 Hani Benhabiles wrote: > This patch series adds a new callback to mon_cmd_t which will make adding > completion support for more commands cleaner. > > It then adds full or partial arguments completion for 7 different hmp > commands. The general approach seems

Re: [Qemu-devel] [PATCH 4/7] monitor: Add cpu index argument completion.

2014-03-27 Thread Luiz Capitulino
On Sun, 9 Mar 2014 12:16:14 +0100 Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles Honest question: is this one really worth it? Aren't we just auto-completing a single integer? > --- > hmp-commands.hx | 1 + > hmp.h | 1 + > monitor.c | 24 >

Re: [Qemu-devel] [PATCH 2/2] vdi: add bounds checks for block related header fields (CVE-2014-0144)

2014-03-27 Thread Stefan Weil
Am 27.03.2014 20:49, schrieb Jeff Cody: > On Wed, Mar 26, 2014 at 10:38:05PM +0100, Stefan Weil wrote: >> (1) block_size must not be null. >> >> (2) blocks_in_image * 4 must fit into a size_t. >> >> (3) blocks_in_image * block_size must fit into a uint64_t. >> >> Header field disk_size already has

Re: [Qemu-devel] [PATCH 1/7] monitor: Add command_completion callback to mon_cmd_t.

2014-03-27 Thread Luiz Capitulino
On Sun, 9 Mar 2014 12:16:11 +0100 Hani Benhabiles wrote: > Convert device_add, device_del, object_add and object_del commands to use > the new callback. > > Also fix drive_del id argument type to activate completion. I think this patch has to be split into at least three patches. One for the d

Re: [Qemu-devel] Missing guest clock-sync on Host clock change

2014-03-27 Thread Erik Rull
Laszlo Ersek wrote: On 03/27/14 09:41, Erik Rull wrote: Hi all, I would like to have the guest "drifting" to a new set clock on the host. My problem is the following: - Host System (Linux) starts up, hwclock and kernel time are synced, guest starts up with -rtc clock=host,driftfix=slew (which

Re: [Qemu-devel] [PATCH for-2.0 16/47] vdi: add bounds checks for blocks_in_image and disk_size header fields (CVE-2014-0144)

2014-03-27 Thread Stefan Weil
Am 27.03.2014 19:52, schrieb Jeff Cody: [...] > I looked around, and I could not find a definitive source for a VDI > specification. Do you know if there is a specified max size for a VDI > image? I used the reference which I also mentioned in the header comment of block/vdi.c: http://forums.virt

Re: [Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-27 Thread Richard Henderson
On 03/27/2014 09:37 AM, alex.ben...@linaro.org wrote: > From: Alex Bennée > > This allows the perf tool to map samples to each individual translation > block. This could be expanded for user space but currently it gives > enough information to find any hotblocks by other means. Plausible, I supp

Re: [Qemu-devel] [PATCH 2/2] vdi: add bounds checks for block related header fields (CVE-2014-0144)

2014-03-27 Thread Jeff Cody
On Wed, Mar 26, 2014 at 10:38:05PM +0100, Stefan Weil wrote: > (1) block_size must not be null. > > (2) blocks_in_image * 4 must fit into a size_t. > > (3) blocks_in_image * block_size must fit into a uint64_t. > > Header field disk_size already has a bounds check which now works > because of mo

Re: [Qemu-devel] [PATCH v6] net: L2TPv3 transport

2014-03-27 Thread Anton Ivanov
On 27/03/14 18:25, Stefan Hajnoczi wrote: > On Thu, Mar 27, 2014 at 4:53 PM, Anton Ivanov (antivano) > wrote: >> On 27/03/14 12:30, Stefan Hajnoczi wrote: >>> On Wed, Mar 26, 2014 at 11:08:41AM +, anton.iva...@kot-begemot.co.uk >>> wrote: +static ssize_t net_l2tpv3_receive_dgram_iov(NetC

Re: [Qemu-devel] [PATCH V2 3/3] qapi: Create an include directive for use in the JSON description files.

2014-03-27 Thread Benoît Canet
The Thursday 27 Mar 2014 à 19:07:48 (+0100), Markus Armbruster wrote : > Benoît Canet writes: > > > The new directive in the form { 'include': 'path/to/file.json' } will > > trigger the > > parsing of path/to/file.json. > > The directive will be replaced by the result of the parsing. > > > > Thi

Re: [Qemu-devel] [PATCH 4/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-03-27 Thread Michael S. Tsirkin
On Thu, Mar 27, 2014 at 06:21:08PM +, Stefano Stabellini wrote: > CC'ing Michael. > > On Fri, 21 Feb 2014, Yang Zhang wrote: > > From: Yang Zhang > > > > Some registers of Intel IGD are mapped in host bridge, so it needs to > > passthrough these registers of physical host bridge to guest bec

Re: [Qemu-devel] [PATCH qom-next v3 12/15] nvme: Permit zero-length block devices

2014-03-27 Thread Keith Busch
On Thu, 27 Mar 2014, Andreas Färber wrote: Am 12.03.2014 21:13, schrieb Keith Busch: On Wed, 12 Mar 2014, Andreas Färber wrote: Tonight is Hard Freeze for 2.0. If you could also review the matching test case http://patchwork.ozlabs.org/patch/329627/ I would put both in my pull. Looks great! I

Re: [Qemu-devel] [PATCH for-2.0 16/47] vdi: add bounds checks for blocks_in_image and disk_size header fields (CVE-2014-0144)

2014-03-27 Thread Jeff Cody
On Wed, Mar 26, 2014 at 07:21:29PM +0100, Stefan Weil wrote: > Hi Stefan, hi Jeff, > > please cc me for future block/vdi.c related patches. See more comments > below. > > Am 26.03.2014 13:05, schrieb Stefan Hajnoczi: > > From: Jeff Cody > > > > The maximum blocks_in_image is 0x / 4, whi

Re: [Qemu-devel] Virtual VFAT with floppy option doesn't work

2014-03-27 Thread Kiyokazu SUTO
Citation (with leading "> " of each line) from article: <8761mzq0wl@blackfin.pond.sub.org> by Markus Armbruster : > Your fix is correct, but the patch doesn't pass checkpatch, it doesn't > have a proper commit message, and it lacks your S-o-B. Since the fix is > trivial, and we're very

Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation

2014-03-27 Thread Luiz Capitulino
On Thu, 27 Mar 2014 19:25:31 +0100 Andreas Färber wrote: > Am 20.03.2014 13:56, schrieb Luiz Capitulino: > > On Wed, 19 Mar 2014 22:58:11 +0100 > > Andreas Färber wrote: > > > >> Am 19.03.2014 22:03, schrieb Luiz Capitulino: > >>> Linux guests, when using more than 4GB of RAM, may end up using

Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation

2014-03-27 Thread Andreas Färber
Am 20.03.2014 13:56, schrieb Luiz Capitulino: > On Wed, 19 Mar 2014 22:58:11 +0100 > Andreas Färber wrote: > >> Am 19.03.2014 22:03, schrieb Luiz Capitulino: >>> Linux guests, when using more than 4GB of RAM, may end up using 1GB pages >>> to store (kernel) data. When this happens, we're unable t

Re: [Qemu-devel] [PATCH v6] net: L2TPv3 transport

2014-03-27 Thread Stefan Hajnoczi
On Thu, Mar 27, 2014 at 4:53 PM, Anton Ivanov (antivano) wrote: > On 27/03/14 12:30, Stefan Hajnoczi wrote: >> On Wed, Mar 26, 2014 at 11:08:41AM +, anton.iva...@kot-begemot.co.uk >> wrote: >>> +static ssize_t net_l2tpv3_receive_dgram_iov(NetClientState *nc, >>> +const str

Re: [Qemu-devel] [PATCH 4/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-03-27 Thread Stefano Stabellini
CC'ing Michael. On Fri, 21 Feb 2014, Yang Zhang wrote: > From: Yang Zhang > > Some registers of Intel IGD are mapped in host bridge, so it needs to > passthrough these registers of physical host bridge to guest because > emulated host bridge in guest doesn't have these mappings. > > The origina

Re: [Qemu-devel] [PATCH] block/iscsi: speed up read for unallocated sectors

2014-03-27 Thread Peter Lieven
Am 27.03.2014 15:17, schrieb Paolo Bonzini: > Il 27/03/2014 14:43, Peter Lieven ha scritto: >> >> +static void iscsi_allocationmap_set(IscsiLun *iscsilun, int64_t sector_num, >> +int nb_sectors) >> +{ >> +if (!iscsilun->cluster_sectors) { >> +return;

Re: [Qemu-devel] [PATCH V2 3/3] qapi: Create an include directive for use in the JSON description files.

2014-03-27 Thread Markus Armbruster
Benoît Canet writes: > The new directive in the form { 'include': 'path/to/file.json' } will trigger > the > parsing of path/to/file.json. > The directive will be replaced by the result of the parsing. > > This will allow for easy modularisation of qapi JSON descriptions files. > > Signed-off-by

Re: [Qemu-devel] [PATCH V2 2/3] qapi: Change the qapi scripts to take their input as first argument.

2014-03-27 Thread Markus Armbruster
Benoît Canet writes: > This patch is here to pave the way for the JSON include directive which > will need to do include loop detection. > > Signed-off-by: Benoit Canet > --- > Makefile | 24 > scripts/qapi-commands.py

Re: [Qemu-devel] [PULL for-2.0 0/5] PowerPC patch queue 2014-03-27

2014-03-27 Thread Peter Maydell
On 27 March 2014 16:19, Andreas Färber wrote: > Hello Peter, > > Please pull the PowerPC queue into qemu.git master. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: Alexander Graf > Cc: Alexey Kardashevskiy > > The following changes since commit bea4acda3bff00e98cb0

Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation

2014-03-27 Thread Luiz Capitulino
On Wed, 19 Mar 2014 17:03:53 -0400 Luiz Capitulino wrote: > Linux guests, when using more than 4GB of RAM, may end up using 1GB pages > to store (kernel) data. When this happens, we're unable to debug a running > Linux kernel with GDB: > > (gdb) p node_data[0]->node_id > Cannot access memory at

Re: [Qemu-devel] [PATCH V2 3/3] qapi: Create an include directive for use in the JSON description files.

2014-03-27 Thread Eric Blake
On 03/27/2014 09:33 AM, Benoît Canet wrote: > The new directive in the form { 'include': 'path/to/file.json' } will trigger > the > parsing of path/to/file.json. > The directive will be replaced by the result of the parsing. > > This will allow for easy modularisation of qapi JSON descriptions fi

Re: [Qemu-devel] [PATCH V2 2/3] qapi: Change the qapi scripts to take their input as first argument.

2014-03-27 Thread Eric Blake
On 03/27/2014 09:33 AM, Benoît Canet wrote: > This patch is here to pave the way for the JSON include directive which > will need to do include loop detection. > Would also be nice to mention that it improves the error message quality. While 3/3 is definitely 2.1 material, 1/3 and 2/3 could argu

Re: [Qemu-devel] [PATCH 0/2] qtest: fix SIGABRT handler for multiple qtest instances

2014-03-27 Thread Andreas Färber
Am 27.03.2014 15:30, schrieb Marcel Apfelbaum: > On Thu, 2014-03-27 at 15:09 +0100, Stefan Hajnoczi wrote: >> I didn't realize some test cases use multiple qtest instances. This means we >> need to know about all instances in order to kill our QEMU processes. >> >> Stefan Hajnoczi (2): >> Revert

Re: [Qemu-devel] [PULL for-2.0 00/23] Trivial patches for 2014-03-27

2014-03-27 Thread Peter Maydell
On 27 March 2014 15:28, Michael Tokarev wrote: > Here's another trivial-patches pull request, for 2.0. > > I removed -m-to-QemuOpts conversion patches, what's left > are either really trivial stuff (some `static const' designators > from Stefan Weil, some duplicate statement removals from Prasad J

Re: [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit

2014-03-27 Thread Tom Musta
On 3/27/2014 9:58 AM, Andreas Färber wrote: > Am 25.03.2014 08:29, schrieb Alex Bennée: >> >> Anton Blanchard writes: >> >>> Add MSR_LE to the msr_mask for POWER8. >>> >> >>> -pcc->msr_mask = 0x8284FF36ULL; >>> +pcc->msr_mask = 0x8284FF37ULL; >> >> >> Should we be adding

[Qemu-devel] [PULL 11/23] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Use unsigned arithmetic for operations on the mask word in the foreach_apic() macro, to avoid relying on undefined behaviour when shifting into the sign bit. Signed-off-by: Peter Maydell Reviewed-by: Stefan Weil Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael Tokare

Re: [Qemu-devel] [PATCH v4 9/9] qapi: Add transaction support to dirty-bitmap-{add, disable}

2014-03-27 Thread Eric Blake
On 03/27/2014 03:09 AM, Fam Zheng wrote: > This adds dirty-bitmap-add and dirty-bitmap-disable to transactions. > With this, user can stop a dirty bitmap, start backup of it, and start > another dirty bitmap atomically, so that the dirty bitmap is tracked > incrementally and we don't miss any write

Re: [Qemu-devel] [PATCH qom-next v3 14/15] tests: Add i82801b11 qtest

2014-03-27 Thread Andreas Färber
Am 12.03.2014 19:28, schrieb Andreas Färber: > Signed-off-by: Andreas Färber > --- > tests/Makefile | 3 +++ > tests/i82801b11-test.c | 33 + > 2 files changed, 36 insertions(+) > create mode 100644 tests/i82801b11-test.c > > diff --git a/tests/Makefile

Re: [Qemu-devel] [PATCH qom-next v3 06/15] tests: Add virtio-9p qtest

2014-03-27 Thread Paolo Bonzini
Il 27/03/2014 17:01, Andreas Färber ha scritto: Am 12.03.2014 19:28, schrieb Andreas Färber: Make it conditional to 9p availability. Create a temporary directory to share. Signed-off-by: Andreas Färber --- tests/Makefile | 6 ++ tests/virtio-9p-test.c | 46 +++

[Qemu-devel] [PULL 19/23] hw/intc/slavio_intctl: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add 'U' suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/intc/slavio_intctl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/slavio_intctl.c b/hw/intc/slavio_intctl.c index 41a1672..b10f

[Qemu-devel] [PULL 04/23] util: Add 'static' attribute to function implementation

2014-03-27 Thread Michael Tokarev
From: Stefan Weil The static code analyzer smatch complains because of a missing 'static' attribute: util/module.c:166:6: warning: symbol 'module_load' was not declared. Should it be static? 'static' is used in the forward declaration, but not in the implementation. Add it there, too. Signed-

[Qemu-devel] [PULL 03/23] hw/ide: Add missing 'static' attributes

2014-03-27 Thread Michael Tokarev
From: Stefan Weil This fixes a warning from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/ide/pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 91151fc..d8b1157 100644 --- a/hw/i

[Qemu-devel] [PULL 02/23] target-arm: Add missing 'static' attribute

2014-03-27 Thread Michael Tokarev
From: Stefan Weil This fixes a warning from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- target-arm/machine.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/machine.c b/target-arm/machine.c index 8f9e7d4..7

[Qemu-devel] [PULL 08/23] doc: update default PowerPC framebuffer settings

2014-03-27 Thread Michael Tokarev
From: Mark Cave-Ayland Since 1.7, the default framebuffer settings for PowerPC are 800x600x32. Signed-off-by: Mark Cave-Ayland CC: qemu-...@nongnu.org Signed-off-by: Michael Tokarev --- qemu-doc.texi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-doc.texi b/qemu-d

Re: [Qemu-devel] [PATCH v4 7/9] qmp: Add dirty-bitmap-enable and dirty-bitmap-disable

2014-03-27 Thread Eric Blake
On 03/27/2014 03:09 AM, Fam Zheng wrote: > This allows to put the dirty bitmap into a disabled state where no more > writes will be tracked. > > It will be used before backup or writing to persistent file. Is it worth the add-bitmap command being able to add a bitmap in the disabled state to begi

Re: [Qemu-devel] [PULL for-2.0 0/2] target-arm queue

2014-03-27 Thread Peter Maydell
e74a928f: > > Merge remote-tracking branch 'remotes/mcayland/qemu-sparc' into staging > (2014-03-27 10:54:17 +) > > are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/p

Re: [Qemu-devel] [PATCH v4 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-27 Thread Eric Blake
On 03/27/2014 03:09 AM, Fam Zheng wrote: > The new command pair is added to manage user created dirty bitmap. The > dirty bitmap's name is mandatory and must be unique for the same device, > but different devices can have bitmaps with the same names. > > Signed-off-by: Fam Zheng > --- > +++ b/qa

Re: [Qemu-devel] [PATCH qom-next v3 13/15] tests: Add nvme qtest

2014-03-27 Thread Andreas Färber
Am 12.03.2014 19:28, schrieb Andreas Färber: > Signed-off-by: Andreas Färber > --- > tests/Makefile| 3 +++ > tests/nvme-test.c | 34 ++ > 2 files changed, 37 insertions(+) > create mode 100644 tests/nvme-test.c Squashing MAINTAINERS update: diff --git a/MA

Re: [Qemu-devel] [PATCH v4 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-27 Thread Dr. David Alan Gilbert
Hi Fam, Could you make this something like block-dirty-bitmap - the RAM migration also has a dirty bitmap, and it would just make it clearer. Dave -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

[Qemu-devel] [RFC PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-03-27 Thread alex . bennee
From: Alex Bennée This allows the perf tool to map samples to each individual translation block. This could be expanded for user space but currently it gives enough information to find any hotblocks by other means. --- qemu-options.hx | 10 ++ tcg/tcg.c | 21 +

Re: [Qemu-devel] [PATCH qom-next v3 12/15] nvme: Permit zero-length block devices

2014-03-27 Thread Andreas Färber
Hi Keith, Am 12.03.2014 21:13, schrieb Keith Busch: > On Wed, 12 Mar 2014, Andreas Färber wrote: >> Tonight is Hard Freeze for 2.0. If you could also review the matching >> test case http://patchwork.ozlabs.org/patch/329627/ I would put both in >> my pull. > > Looks great! I'd apply the new test

Re: [Qemu-devel] [PATCH RFC] virtio-net: announce self by guest

2014-03-27 Thread Amos Kong
On Thu, Mar 13, 2014 at 02:56:41PM +0800, Jason Wang wrote: > It's hard to track all mac addresses and their configurations (e.g > vlan or ipv6)in qemu. Without those information, it's impossible to > build proper garp packet after migration. The only possible solution > to this is let guest ( who

[Qemu-devel] [PULL for-2.0 3/5] target-ppc: POWER8 supports isel

2014-03-27 Thread Andreas Färber
From: Anton Blanchard Add PPC_ISEL to insns_flags. Signed-off-by: Anton Blanchard Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/translate_

[Qemu-devel] [PULL for-2.0 4/5] target-ppc: POWER7+ supports the MSR_VSX bit

2014-03-27 Thread Andreas Färber
From: Anton Blanchard Without MSR_VSX we die early during a Linux boot. Signed-off-by: Anton Blanchard Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Qemu-devel] [PULL for-2.0 5/5] target-ppc: MSR_POW not supported on POWER7/7+/8

2014-03-27 Thread Andreas Färber
From: Anton Blanchard Remove MSR_POW from the msr_mask for POWER7/7P/8. Signed-off-by: Anton Blanchard Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

[Qemu-devel] [PULL for-2.0 0/5] PowerPC patch queue 2014-03-27

2014-03-27 Thread Andreas Färber
Hello Peter, Please pull the PowerPC queue into qemu.git master. Regards, Andreas Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: Alexander Graf Cc: Alexey Kardashevskiy The following changes since commit bea4acda3bff00e98cb00d5354f23de9e74a928f: Merge remote-tracking branch 'remotes/mcayla

[Qemu-devel] [PULL for-2.0 1/5] intc/openpic_kvm: Fix MemListener delete region callback function

2014-03-27 Thread Andreas Färber
From: Prasad Joshi Fixes d85937e683f6ff4d68293cb24c780fb1f6820d2c. Signed-off-by: Prasad Joshi Signed-off-by: Andreas Färber --- hw/intc/openpic_kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c index 87fdb12..afa604d 10064

[Qemu-devel] [PULL for-2.0 2/5] target-ppc: POWER8 supports the MSR_LE bit

2014-03-27 Thread Andreas Färber
From: Anton Blanchard Add MSR_LE to the msr_mask for POWER8. Signed-off-by: Anton Blanchard Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/

Re: [Qemu-devel] [PATCH v4 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-27 Thread Stefan Hajnoczi
On Thu, Mar 27, 2014 at 05:09:41PM +0800, Fam Zheng wrote: > +if (has_granularity) { > +if (granularity & (granularity - 1)) { > +error_setg(errp, "Granularity must be power of 2"); > +return; > +} > +} else { > +granularity = 65536; > +}

[Qemu-devel] [PULL 15/23] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add U suffix to avoid undefined behaviour. This is only strictly necessary for the 1<<31 cases, but we add it for the other constants in these groups for consistency. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/usb/hcd-ohci.c | 32 -

[Qemu-devel] [PULL 09/23] CODING_STYLE: Section about mixed declarations

2014-03-27 Thread Michael Tokarev
From: Eduardo Habkost We had an unwritten rule about declarations having to be at beginning of blocks. Make it a written rule. Signed-off-by: Eduardo Habkost Reviewed-by: Stefan Weil Reviewed-by: Markus Armbruster Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- CODING_STYLE |

[Qemu-devel] [PULL 16/23] hw/intc/openpic: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add U suffix to avoid undefined behaviour. This is only strictly necessary for the 1 << 31 cases; for consistency we extend it to other constants in the same group. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/intc/openpic.c | 14 +++--- 1 f

[Qemu-devel] [PULL 18/23] tests/libqos/pci-pc: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add U suffix when doing "1 << 31" to avoid undefined behaviour. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- tests/libqos/pci-pc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/libqos/pci-pc.c b/tests/libqos/pci

[Qemu-devel] [PULL 17/23] hw/ppc: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add U suffix to various places where we were doing "1 << 31", which is undefined behaviour, and also to other constant definitions in the same groups, for consistency. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/ppc/ppc.c |2 +- hw/ppc/

[Qemu-devel] [PULL 01/23] target-s390x: Add missing 'static' and 'const' attributes

2014-03-27 Thread Michael Tokarev
From: Stefan Weil This fixes warnings from the static code analysis (smatch). Signed-off-by: Stefan Weil Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- target-s390x/arch_dump.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-s390x/arch_d

Re: [Qemu-devel] [PATCH qom-next v3 06/15] tests: Add virtio-9p qtest

2014-03-27 Thread Andreas Färber
Am 12.03.2014 19:28, schrieb Andreas Färber: > Make it conditional to 9p availability. > Create a temporary directory to share. > > Signed-off-by: Andreas Färber > --- > tests/Makefile | 6 ++ > tests/virtio-9p-test.c | 46 ++ > 2 files ch

Re: [Qemu-devel] [PATCH v6] net: L2TPv3 transport

2014-03-27 Thread Anton Ivanov (antivano)
On 27/03/14 12:30, Stefan Hajnoczi wrote: > On Wed, Mar 26, 2014 at 11:08:41AM +, anton.iva...@kot-begemot.co.uk > wrote: >> +static ssize_t net_l2tpv3_receive_dgram_iov(NetClientState *nc, >> +const struct iovec *iov, >> +int iovcnt) >> +{ >> +NetL2

[Qemu-devel] [PULL 22/23] hw/timer/grlib_gptimer: remove unnecessary assignment

2014-03-27 Thread Michael Tokarev
From: Prasad Joshi Signed-off-by: Prasad Joshi Signed-off-by: Michael Tokarev --- hw/timer/grlib_gptimer.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/timer/grlib_gptimer.c b/hw/timer/grlib_gptimer.c index 7672d3a..d655bb2 100644 --- a/hw/timer/grlib_gptimer.c +++ b/hw/timer/grlib

Re: [Qemu-devel] n ways block filters

2014-03-27 Thread Benoît Canet
The Monday 24 Mar 2014 à 16:58:55 (+0100), Kevin Wolf wrote : > Am 24.03.2014 um 15:53 hat Benoît Canet geschrieben: > > The Thursday 20 Mar 2014 à 17:06:26 (+0100), Benoît Canet wrote : > > > The Thursday 20 Mar 2014 à 16:12:34 (+0100), Kevin Wolf wrote : > > > > Am 20.03.2014 um 15:05 hat Benoît

[Qemu-devel] [PULL 21/23] hw/pci-host/apb.c: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/pci-host/apb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c index 1b399dd..252caef 100644

[Qemu-devel] [PULL 10/23] target-i386: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add 'U' suffixes where necessary to avoid (1 << 31) which shifts left into the sign bit, which is undefined behaviour. Add the suffix also for other constants in the same groupings even if they don't shift into bit 31, for consistency. Signed-off-by: Peter Maydell Signed-off

[Qemu-devel] [PULL 14/23] target-mips: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add U suffix to various places where we shift a 1 left by 31, to avoid undefined behaviour. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- target-mips/cpu.h|2 +- target-mips/helper.c |8 target-mips/op_helper.c |

Re: [Qemu-devel] [Qemu-ppc] [PATCH 6/6] target-ppc: Add PMC7/8 to 970

2014-03-27 Thread Andreas Färber
Am 27.03.2014 14:03, schrieb Alexey Kardashevskiy: > On 03/25/2014 01:40 PM, Anton Blanchard wrote: >> 970 CPUs have PMC7/8. Create gen_spr_970 to avoid replicating >> it 3 times, and simplify the existing code. >> >> Signed-off-by: Anton Blanchard >> --- >> target-ppc/translate_init.c | 89 >> +

[Qemu-devel] [PULL 13/23] hw/i386/acpi_build.c: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael Tokarev --- hw/i386/acpi-build.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build

Re: [Qemu-devel] [PATCH for-2.0] acpi: Fixed incorrect ACPI generation for pci bridges

2014-03-27 Thread Michael S. Tsirkin
On Thu, Mar 27, 2014 at 05:35:36PM +0200, Marcel Apfelbaum wrote: > Commit 8dcf525abc5dff785251a881f9764dd961065c0d appended > description for all occupied non hotpluggable PCI slots. > However the bridge devices are already added to SSDT, > adding them again will create an incorrect SSDT table. >

[Qemu-devel] [PATCH V2 0/3] Create an include directive for QAPI JSON files

2014-03-27 Thread Benoît Canet
The first patch make an error path in the test more explicit. The second make the qapi generator script take their input as first argument. It's done to be able to do cycle detection in the next patch. The third create an include directive for QAPI JSON files. The purpose of this series is to be

Re: [Qemu-devel] [PATCH v4 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-27 Thread Stefan Hajnoczi
On Thu, Mar 27, 2014 at 05:09:41PM +0800, Fam Zheng wrote: > @@ -1713,6 +1713,66 @@ void qmp_block_set_io_throttle(const char *device, > int64_t bps, int64_t bps_rd, > } > } > > +void qmp_dirty_bitmap_add(const char *device, const char *name, > + bool has_granulari

[Qemu-devel] [PULL 23/23] linux-user: remove duplicate statement

2014-03-27 Thread Michael Tokarev
From: Prasad Joshi Signed-off-by: Prasad Joshi Acked-by: Riku Voipio Signed-off-by: Michael Tokarev --- linux-user/signal.c |2 -- 1 file changed, 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index e5fb933..7d6246f 100644 --- a/linux-user/signal.c +++ b/linux-use

[Qemu-devel] [PULL 20/23] hw/intc/xilinx_intc: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Avoid undefined behaviour shifting left into the sign bit. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/intc/xilinx_intc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c index 4a1

[Qemu-devel] [PULL 12/23] hw/pci/pci_host.c: Avoid shifting left into sign bit

2014-03-27 Thread Michael Tokarev
From: Peter Maydell Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael Tokarev --- hw/pci/pci_host.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c inde

Re: [Qemu-devel] [PATCH 1/6] target-ppc: POWER8 supports the MSR_LE bit

2014-03-27 Thread Andreas Färber
Hi Anton, Am 25.03.2014 03:40, schrieb Anton Blanchard: > Add MSR_LE to the msr_mask for POWER8. > > Signed-off-by: Anton Blanchard > Signed-off-by: Cédric Le Goater Something went wrong here - you're sending patches without placing your Sob last, which breaks the DCO chain. Cédric indicated t

Re: [Qemu-devel] [PATCH v4 1/9] qapi: Add optional field "name" to block dirty bitmap

2014-03-27 Thread Stefan Hajnoczi
On Thu, Mar 27, 2014 at 05:09:40PM +0800, Fam Zheng wrote: > @@ -5079,18 +5080,45 @@ bool bdrv_qiov_is_aligned(BlockDriverState *bs, > QEMUIOVector *qiov) > return true; > } > > -BdrvDirtyBitmap *bdrv_create_dirty_bitmap(BlockDriverState *bs, int > granularity) > +BdrvDirtyBitmap *bdrv_fi

  1   2   3   >