Re: [Qemu-devel] [PATCH] input: mouse_set should check input device type.

2014-03-30 Thread Gerd Hoffmann
> +if (!(s->handler->mask & (INPUT_EVENT_MASK_REL | > + INPUT_EVENT_MASK_ABS))) { > +monitor_printf(mon, "Input device '%s' is not a mouse", > + s->handler->name); That should be error_report (I think, Markus?). Other

Re: [Qemu-devel] [PATCH v2 2/5] target-i386: Implement nmi() callback

2014-03-30 Thread Richard Henderson
On 03/30/2014 07:55 PM, Alexey Kardashevskiy wrote: > On 03/28/2014 11:51 PM, Alexey Kardashevskiy wrote: >> Signed-off-by: Alexey Kardashevskiy >> --- >> target-i386/cpu.c | 14 ++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >> index 8

Re: [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr

2014-03-30 Thread Richard Henderson
On 03/30/2014 08:31 AM, Richard Henderson wrote: > On 03/29/2014 01:26 PM, Peter Maydell wrote: >> It seems like it might be worth abstracting out "give me the byte >> difference between these two code pointers" rather than having >> inline (uintptr_t)codeptr1 - (uintptr_t)codeptr2, but I dunno. >

Re: [Qemu-devel] [PATCH v2 2/5] target-i386: Implement nmi() callback

2014-03-30 Thread Alexey Kardashevskiy
On 03/28/2014 11:51 PM, Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy > --- > target-i386/cpu.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 8fd1497..35f20e0 100644 > --- a/target-i386/cpu.c > +++ b/tar

Re: [Qemu-devel] [PATCH v2] target-ppc: improve "info registers" by printing SPRs

2014-03-30 Thread Alexey Kardashevskiy
On 03/24/2014 05:24 PM, Alexey Kardashevskiy wrote: > On 03/23/2014 01:43 AM, Stuart Brady wrote: >> On Sat, Mar 22, 2014 at 11:25:49PM +1100, Alexey Kardashevskiy wrote: >>> This adds printing of all SPR registers registered for a CPU. >>> >>> This removes "SPR_" prefix from SPR name to reduce the

[Qemu-devel] [PATCH 17/18] slirp: Adding IPv6 address for DNS relay

2014-03-30 Thread Samuel Thibault
This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is developed using this Slirp attribute. sotranslate_in/out() are also updated to manage the IPv6 case so the guest can be able to join the host using one of the Slirp addresses. Signed-off-by: Guillaume Subiron --- slirp/ip6.h

[Qemu-devel] [PATCH 13/18] slirp: Factorizing tcpiphdr structure with an union

2014-03-30 Thread Samuel Thibault
This patch factorizes the tcpiphdr structure to put the IPv4 fields in an union, for addition of version 6 in further patch. Using some macros, retrocompatibility of the existing code is assured. This patch also fixes the SLIRP_MSIZE and margin computation in various functions, and makes them comp

[Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2014-03-30 Thread Samuel Thibault
This patch makes solookup() compatible with varying address families. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the function (the function look at the last returned re

[Qemu-devel] [PATCH 11/18] slirp: Adding ICMPv6 error sending

2014-03-30 Thread Samuel Thibault
Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Adding icmp6_send_error to send ICMPv6 Error messages. This function is simpler than the v4 version. Adding some calls in various functions to send ICMP errors, when a r

[Qemu-devel] [PATCH 10/18] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2014-03-30 Thread Samuel Thibault
This patch adds the functions needed to handle IPv6 packets. ICMPv6 and NDP headers are implemented. Slirp is now able to send NDP Router or Neighbor Advertisement when it receives Router or Neighbor Solicitation. Using a 64bit-sized IPv6 prefix, the guest is now able to perform stateless autoconf

[Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2014-03-30 Thread Samuel Thibault
Hello, This is another respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, and make UDP and TCP compatible with IPv6. We have made some refactoring to make current code compatible with IPv6. Patches 1 to 8 are refactoring of existing code and do not change the behavior, 9 adds

[Qemu-devel] [PATCH 08/18] slirp: Adding family argument to tcp_fconnect()

2014-03-30 Thread Samuel Thibault
This patch simply adds a sa_family_t argument to remove the hardcoded "AF_INET" in the call of qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/slirp.h | 2 +- slirp/tcp_input.c | 3 ++- slirp/tcp_subr.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/slir

[Qemu-devel] [PATCH 15/18] slirp: Reindent after refactoring

2014-03-30 Thread Samuel Thibault
No code change. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/slirp.h | 3 +- slirp/tcp_input.c | 95 +++--- slirp/tcp_output.c | 29 - slirp/tcp_subr.c | 50 ++-- 4 file

Re: [Qemu-devel] 2.0 regression: loadvm assertion with ehci + tablet

2014-03-30 Thread Andreas Färber
Hi, Am 30.03.2014 22:27, schrieb Cole Robinson: > With git master, loadvm hits an assert failure if using ehci and usb tablet. > Steps to reproduce: > > $ qemu-img create -f qcow2 foo.qcow2 10G > $ ./x86_64-softmmu/qemu-system-x86_64 \ > -enable-kvm -m 4096 \ > -device ich9-usb-ehci1,id=usb,b

[Qemu-devel] [PATCH 12/18] slirp: Adding IPv6 UDP support

2014-03-30 Thread Samuel Thibault
This patch adds udp6_input() and udp6_output(). It also adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron --- slirp/Makefile.objs | 2 +- slirp/ip6_input.c | 3 +- slirp/socket.c | 7 ++- slirp/udp.h | 5 ++

[Qemu-devel] [PATCH 16/18] slirp: Handle IPv6 in TCP functions

2014-03-30 Thread Samuel Thibault
This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/ip6_input.c | 4 ++-- slirp/tcp.h

[Qemu-devel] [PATCH 14/18] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2014-03-30 Thread Samuel Thibault
Basically, this patch adds some switch in various TCP functions to prepare them for the IPv6 case. To have something to "switch" in tcp_input() and tcp_respond(), a new argument is used to give them the sa_family of the addresses they are working on. Signed-off-by: Guillaume Subiron --- slirp/i

[Qemu-devel] [PATCH 07/18] slirp: Make udp_attach IPv6 compatible

2014-03-30 Thread Samuel Thibault
A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded "AF_INET" to call qemu_socket(). Signed-off-by: Guillaume Subiron --- slirp/ip_icmp.c | 2 +- slirp/udp.c | 7 --- slirp/udp.h | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/sli

[Qemu-devel] [PATCH 03/18] slirp: Reindent after refactoring

2014-03-30 Thread Samuel Thibault
No code change. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/slirp.c | 107 +- 1 file changed, 54 insertions(+), 53 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 676c86d..bfc4832 100644 --- a/s

[Qemu-devel] [PATCH 04/18] slirp: Make Socket structure IPv6 compatible

2014-03-30 Thread Samuel Thibault
This patch replaces foreign and local address/port couples in Socket structure by 2 sockaddr_storage which can be casted in sockaddr_in or sockaddr_in6. Direct access to address and port is still possible thanks to some \#define, so retrocompatibility of the existing code is assured. The ss_family

[Qemu-devel] [PATCH 05/18] slirp: Factorizing address translation

2014-03-30 Thread Samuel Thibault
This patch factorizes some duplicate code into a new function, sotranslate_out(). This function perform the address translation when a packet is transmitted to the host network. If the paquet is destinated to the host, the loopback address is used, and if the paquet is destinated to the virtual DNS

[Qemu-devel] [PATCH 09/18] qemu/timer.h : Adding function to second scale

2014-03-30 Thread Samuel Thibault
This patch adds SCALE_S, timer_new_s(), and qemu_clock_get_s in qemu/timer.h to manage second-scale timers. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- include/qemu/timer.h | 32 1 file changed, 32 insertions(+) diff --git a/include/qemu

[Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2014-03-30 Thread Samuel Thibault
Basically, this patch replaces "arp" by "resolution" every time "arp" means "mac resolution" and not specifically ARP. Some indentation problems are solved in functions that will be modified in the next patches (ip_input…). In if_encap, a switch is added to prepare for the IPv6 case. Some code is

[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

2014-03-30 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/slirp/udp.c

[Qemu-devel] [PATCH 18/18] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2014-03-30 Thread Samuel Thibault
This patch adds parameters to manage some new options in the qemu -net command. Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in argument to the qemu command. Defaults parameters are respectively fec0::2, fec0::, /64 and fec0::3. Signed-off-by: Yann Bordenave Signed-off-by

[Qemu-devel] [Bug 1299858] [NEW] qemu all apps crash on OS X 10.6.8

2014-03-30 Thread Eric Blair
Public bug reported: qemu-2.0.0-rc0 (and 1.7.1) crashes with SIGABORT in all apps when configured with --with-coroutine=sigaltstack (which is what configure selects by default) but all run fine if configured with --with- coroutine=gthread. Crash is at line 253 (last line of Coroutine *qemu_corou

[Qemu-devel] Qemu and access to guest memory

2014-03-30 Thread sdrb
Hello, I'm trying to write my own driver for eepro100 (e100) NIC for Linux 2.6.3x running on Qemu 1.7.90. Unfortunately I've got problems with accessing memory. In my e100 driver I set some memory area to configure e100 Control Block. I set appropriate offset address to point to this control

Re: [Qemu-devel] 2.0 regression: loadvm assertion with ehci + tablet

2014-03-30 Thread Michael S. Tsirkin
On Sun, Mar 30, 2014 at 04:27:33PM -0400, Cole Robinson wrote: > With git master, loadvm hits an assert failure if using ehci and usb tablet. > Steps to reproduce: > > $ qemu-img create -f qcow2 foo.qcow2 10G > $ ./x86_64-softmmu/qemu-system-x86_64 \ > -enable-kvm -m 4096 \ > -device ich9-usb-

[Qemu-devel] [PATCHv53/3] qapi: Add tests for the "include" directive

2014-03-30 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- tests/Makefile|4 +++- tests/qapi-schema/include-cycle-b.json|1 + tests/qapi-schema/include-cycle-c.json|1 + tests/qapi-schema/include-cycle.err |1 + tests/qapi-schema/include-cycle.exit |1 +

[Qemu-devel] [PATCHv52/3] qapi: Add a primitive to include other files from a QAPI schema file

2014-03-30 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- docs/qapi-code-gen.txt |7 +++ scripts/qapi.py| 35 ++- 2 files changed, 37 insertions(+), 5 deletions(-) diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt index 824f6e5..1e19f64 100644 --- a/docs/qapi

[Qemu-devel] [PATCHv51/3] qapi: Use an explicit input file

2014-03-30 Thread Lluís Vilanova
Use an explicit input file on the command-line instead of reading from standard input Signed-off-by: Lluís Vilanova --- Makefile | 24 +++- docs/qapi-code-gen.txt |4 ++- scripts/qapi-commands.py

[Qemu-devel] [PATCHv50/3] qapi: Allow modularization of QAPI schema files

2014-03-30 Thread Lluís Vilanova
Adds an include primitive to the syntax of QAPI schema files, allowing these to be modularized into multiple per-topic files in the future. Signed-off-by: Lluís Vilanova --- Changes in v5: * Rebase on b3706fa. * Remove 'error_base' argument in 'parse_schema'; fix test checks instead. * Implemen

[Qemu-devel] 2.0 regression: loadvm assertion with ehci + tablet

2014-03-30 Thread Cole Robinson
With git master, loadvm hits an assert failure if using ehci and usb tablet. Steps to reproduce: $ qemu-img create -f qcow2 foo.qcow2 10G $ ./x86_64-softmmu/qemu-system-x86_64 \ -enable-kvm -m 4096 \ -device ich9-usb-ehci1,id=usb,bus=pci.0,addr=0x5.0x7 \ -device ich9-usb-uhci1,masterbus=usb.

Re: [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr

2014-03-30 Thread Richard Henderson
On 03/29/2014 01:26 PM, Peter Maydell wrote: > It seems like it might be worth abstracting out "give me the byte > difference between these two code pointers" rather than having > inline (uintptr_t)codeptr1 - (uintptr_t)codeptr2, but I dunno. Yeah, I dithered about that. I couldn't come up with a

Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator()

2014-03-30 Thread Chen Gang
Hello Maintainers: If it is necessary to send patch v2 by me, please let me know, I will/should send. Thanks. On 03/27/2014 06:01 PM, Chen Gang wrote: > > > On 03/27/2014 04:59 PM, Markus Armbruster wrote: >> Chen Gang writes: >> >>> At present, each 'opt_name' of 'accel_list' is uniq with e

Re: [Qemu-devel] [PATCH trival] vl.c: clean up code

2014-03-30 Thread Chen Gang
Hello Maintainers: In main switch of main(), it contents several styles for "{...}" code block. If it is necessary to use unique style within a function, please let me know, I will/should clean up it. And also better to tell me which style we need choose -- for me, I don't know which style is the

[Qemu-devel] [PATCH trival] vl.c: clean up code

2014-03-30 Thread Chen Gang
in get_boot_device() - remove 'res' to simplify code in main(): - remove useless 'continue'. - in main switch(): - remove or adjust all useless 'break'. - remove useless '{' and '}'. - use assignment directly to replace useless 'args' (which is defined in the middle of code bloc

[Qemu-devel] [PATCH] input: mouse_set should check input device type.

2014-03-30 Thread Hani Benhabiles
Otherwise, the index of an input device like a usb-kbd is silently accepted. (qemu) info mice Mouse #2: QEMU PS/2 Mouse * Mouse #3: QEMU HID Mouse (qemu) mouse_set 1 (qemu) info mice Mouse #2: QEMU PS/2 Mouse * Mouse #3: QEMU HID Mouse Signed-off-by: Hani Benhabiles --- ui/input.c | 15

[Qemu-devel] qemu core dump when vnc client connect to VM, Is anyone has the similar problem, thanks!

2014-03-30 Thread Caizhifeng
Hi, I've been tring to use QEMU-1.5.0 and Libvirt-1.1.0 to run a VM, but this problem comes up. The VM's log by libvirtd is as follow, which is similar to link: https://bugzilla.redhat.com/show_bug.cgi?id=906735, And it seems difficult to reproduce. Is there anyone have ever encounter this probl

[Qemu-devel] Guest bandwidth setting

2014-03-30 Thread Pradeep Kiruvale
Hi All, I am new to QEMU. I am implementing some functionality where in I need to set the bandwidth control for my guest vms.Please let me know how can I do it. I am looking into net/net.c file,I dint find any leads.I tried two ways. I am trying to find how to set virtual nics(in my case e1

[Qemu-devel] [PATCH v2 03/17] monitor: Add device_add and device_del completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 ++ hmp.h | 2 ++ monitor.c | 34 +- 3 files changed, 25 insertions(+), 13 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 1b382b6..4c4d261 100644 --- a/hmp-commands.hx +++

[Qemu-devel] [PATCH v2 02/17] monitor: Add command_completion callback to mon_cmd_t.

2014-03-30 Thread Hani Benhabiles
Convert object_add and object_del commands to use the new callback. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 ++ hmp.h | 3 +++ monitor.c | 19 +-- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx in

[Qemu-devel] [PATCH v2 12/17] monitor: Add migrate_set_capability completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 2 ++ monitor.c | 21 + 3 files changed, 24 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 669a845..8c674ba 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -975,6 +97

[Qemu-devel] [PATCH v2 01/17] monitor: Fix drive_del id argument type completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index f3fc514..6bf4797 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -176,7 +176,7 @@ ETEXI { .name = "drive_del",

[Qemu-devel] [PATCH v2 16/17] monitor: Add mouse_set index argument completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 22 ++ 3 files changed, 24 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index b41a6d6..04aa059 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -734,6 +73

[Qemu-devel] [chet.ens...@oasis-open.org: [members] 15-day Public Review for Virtual I/O Device (VIRTIO) V1.0 - ends 14 April]

2014-03-30 Thread Michael S. Tsirkin
- Forwarded message from Chet Ensign - Date: Fri, 28 Mar 2014 17:54:16 -0400 From: Chet Ensign To: tc-annou...@lists.oasis-open.org, memb...@lists.oasis-open.org, vir...@lists.oasis-open.org, virtio-comm...@lists.oasis-open.org Subject: [members] 15-day Public Review for Virtual I/O Dev

[Qemu-devel] [PATCH v2 17/17] monitor: Add delvm and loadvm argument completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 ++ hmp.h | 2 ++ monitor.c | 48 3 files changed, 52 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 04aa059..b59d0e0 100644 --- a/hmp-commands.hx +++ b/h

[Qemu-devel] [PATCH v2 10/17] monitor: Add ringbuf_write and ringbuf_read argument completion.

2014-03-30 Thread Hani Benhabiles
Export chr_is_ringbuf() function. Also remove left-over function prototypes while at it. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 2 ++ hmp.h | 2 ++ include/sysemu/char.h | 3 +-- monitor.c | 39 +++ qemu-char.

[Qemu-devel] [PATCH v2 06/17] monitor: Add cpu index argument completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 24 3 files changed, 26 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index a411d4f..813c0fb 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -690,6 +

[Qemu-devel] [PATCH v2 14/17] readline: Make completion strings always unique.

2014-03-30 Thread Hani Benhabiles
There is no need to clutter the user's choices with repeating the same value multiple times. Signed-off-by: Hani Benhabiles --- util/readline.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/util/readline.c b/util/readline.c index 8441be4..6aeae6a 100644 --- a/util/readline.c +++ b/ut

[Qemu-devel] [PATCH v2 05/17] monitor: Add chardev-add backend argument completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 23 +++ 3 files changed, 25 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 4f0f053..a411d4f 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1614,6 +

[Qemu-devel] [PATCH v2 15/17] monitor: Add host_net_remove arguments completion.

2014-03-30 Thread Hani Benhabiles
Relies on readline unique completion strings patch to make the added vlan/hub completion values unique, instead of using something like a hash table. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 2 ++ monitor.c | 38 ++ 3

[Qemu-devel] [PATCH v2 11/17] monitor: Add watchdog_action argument completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 2 ++ monitor.c | 14 ++ 3 files changed, 17 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 300be4e..669a845 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1351,6 +1351,7 @

[Qemu-devel] [PATCH v2 04/17] monitor: Add chardev-remove id argument completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 23 +++ 3 files changed, 25 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 4c4d261..4f0f053 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1630,6 +

[Qemu-devel] [PATCH v2 07/17] monitor: Add set_link arguments completion.

2014-03-30 Thread Hani Benhabiles
Make it possible to query all net clients without specifying an ID when calling qemu_find_net_clients_except(). This also adds the add_completion_option() function which is to be used for other commands completions as well. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h

[Qemu-devel] [PATCH v2 08/17] monitor: Add netdev_add type argument completion.

2014-03-30 Thread Hani Benhabiles
Also update the command's documentation. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 3 ++- hmp.h | 1 + monitor.c | 18 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index fbd303a..b009561 100644 --

[Qemu-devel] [PATCH v2 00/17] monitor: Completion support for various commands

2014-03-30 Thread Hani Benhabiles
This patch series adds a new callback to mon_cmd_t which will make adding completion support for more commands cleaner. It then adds full or partial arguments completion for multiple hmp commands. Changes since v1: * Splitting patch 1/7 to 1/17, 2/17 and 3/17. * Changed command_completion's fir

[Qemu-devel] [PATCH v2 13/17] monitor: Add host_net_add device argument completion.

2014-03-30 Thread Hani Benhabiles
Also fix the parameters documentation. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 3 ++- hmp.h | 1 + monitor.c | 14 ++ 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8c674ba..9da5866 100644 --- a/hm

[Qemu-devel] [PATCH v2 09/17] monitor: Add netdev_del id argument completion.

2014-03-30 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 26 ++ 3 files changed, 28 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index b009561..d252ffc 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1244,