Re: [Qemu-devel] [PATCH for-2.0 v2] tests: Don't run qom-test twice

2014-04-24 Thread Markus Armbruster
Andreas Färber writes: > Am 24.04.2014 16:34, schrieb Peter Maydell: >> On 24 April 2014 15:29, Stefan Hajnoczi wrote: >>> On Mon, Apr 07, 2014 at 04:13:00PM +0200, Andreas Färber wrote: Commit 3687d5325 accidentally resulted in running qom-test twice for x86_64, once directly via the

Re: [Qemu-devel] [PATCH] qxl: Fix initial screenshot with spice

2014-04-24 Thread Gerd Hoffmann
Hi, > ui/console.c:qmp_screendump attempts to handle this by calling > graphic_hw_update, but qxl handle's that asynchronously, and it isn't > run until after the first screendump is performed. That's why the second > screendump is correct. Known issue. The graphic_hw_update makes sure it work

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-24 Thread Markus Armbruster
Andreas Färber writes: > Am 24.04.2014 08:19, schrieb Jan Kiszka: >> On 2014-04-23 11:25, Stefan Hajnoczi wrote: >>> Dear QEMU, Libvirt, and KVM communities, We are participating in >>> Google Summer of Code 2014 (http://google-melange.com/) and >>> Outreach Program for Women (http://opw.gnome.or

Re: [Qemu-devel] [PATCH 0/3] virtio: Eliminate "exit(1)" upon invalid request in virtio-blk and virtio-scsi

2014-04-24 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Apr 24, 2014 at 12:43:56PM +0200, Kevin Wolf wrote: >> Am 24.04.2014 um 09:55 hat Michael S. Tsirkin geschrieben: >> > On Thu, Apr 24, 2014 at 09:15:25AM +0200, Markus Armbruster wrote: >> > > "Michael S. Tsirkin" writes: >> > > >> > > > On Wed, Apr 23, 20

Re: [Qemu-devel] [PATCH microblaze v1 1/1] net: xilinx_axienet.c: Add phy soft reset bit clearing

2014-04-24 Thread Edgar E. Iglesias
On Thu, Apr 24, 2014 at 02:03:45PM +0200, Stefan Hajnoczi wrote: > On Tue, Apr 08, 2014 at 06:52:39PM -0700, Peter Crosthwaite wrote: > > From: Nathan Rossi > > > > Clear the BMCR Reset when writing to registers. > > > > Signed-off-by: Nathan Rossi > > [ PC: > > * Trivial style fixes to commit

Re: [Qemu-devel] [PATCH] block: Expose host_* drivers in blockdev-add

2014-04-24 Thread Markus Armbruster
Kevin Wolf writes: > Am 24.04.2014 um 09:27 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 23.04.2014 um 17:34 hat Eric Blake geschrieben: >> >> On 04/23/2014 09:12 AM, Kevin Wolf wrote: >> >> > All the functionality to use the host_device, host_cdrom and host_floppy >> >>

Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-24 Thread Markus Armbruster
Amos Kong writes: > On Tue, Apr 22, 2014 at 09:20:41AM +0200, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >> > Il 18/04/2014 23:56, Amos Kong ha scritto: >> >> Currently we always add a space after c_type in mcgen(), there is >> >> some redundant space in generated code. The space isn'

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-24 Thread Fam Zheng
On Thu, 04/24 08:19, Jan Kiszka wrote: > On 2014-04-23 11:25, Stefan Hajnoczi wrote: > > Dear QEMU, Libvirt, and KVM communities, > > We are participating in Google Summer of Code 2014 > > (http://google-melange.com/) and Outreach Program for Women > > (http://opw.gnome.org/). Both programs fund c

[Qemu-devel] [PATCH 0/3] disas/libvixl: update to upstream 1.3

2014-04-24 Thread Peter Maydell
This patchset updates our copy of libvixl to the upstream 1.3 release. I don't think there's anything particularly earthshattering in 1.3 compared to what we had before. I had a bit of a dilemma with this patchset: * separate out the "pristine upstream files" from the "reapply local fixes" co

Re: [Qemu-devel] [PATCH] configure: Change --enable-tpm to --disable-tpm

2014-04-24 Thread Cole Robinson
On 04/21/2014 10:16 PM, Fam Zheng wrote: > On Mon, 04/21 19:09, Cole Robinson wrote: >> I don't see why tpm is disabled by default: it doesn't have any >> external dependencies, or change default behavior. Leaving it disabled >> is just going to cause it to bit rot. >> >> Enable it by default, and

Re: [Qemu-devel] [PATCH for-2.1 v1 2/3] qdev: Implement named GPIOs

2014-04-24 Thread Andreas Färber
Am 09.04.2014 01:45, schrieb Peter Crosthwaite: > Implement named GPIOs on the Device layer. Listifies the existing GPIOs > stuff using string keys. Legacy un-named GPIOs are preserved by using > a NULL name string - they are just a single matchable element in the > name list. > > Signed-off-by: P

Re: [Qemu-devel] [PATCH v25 00/31] replace QEMUOptionParameter with QemuOpts

2014-04-24 Thread Stefan Hajnoczi
On Mon, Apr 21, 2014 at 02:44:36PM +0800, Chunyan Liu wrote: > Hi, Eric, Stefan, Leandro, > > Could you have a look at the new version? > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01759.html > > This work lasts for a very long time, hope it could be ended soon :) Eric pointed out

[Qemu-devel] [PATCH v2 10/13] tcg-sparc: Hoist common argument loads in tcg_out_op

2014-04-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 123 - 1 file changed, 60 insertions(+), 63 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index d5d1761..655e435 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg

[Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen argument

2014-04-24 Thread Andreas Färber
POSIX specifies that address_len shall on output specify the length of the stored address; it does not however specify whether it may get updated on failure as well to, e.g., zero. In case EINTR occurs, re-initialize the variable to the desired value. Cc: Eric Blake Signed-off-by: Andreas Färber

[Qemu-devel] [PATCH 3/6] input: switch ps/2 kbd to new input api

2014-04-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/input/ps2.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 3412079..9b35869 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -24,6 +24,7 @@ #include "hw/hw.h" #include "hw

[Qemu-devel] [PATCH v2 2/4] acpi-build: properly decrement objects' reference counters

2014-04-24 Thread Kirill Batuzov
Object returned by object_property_get_qobject needs its reference counter to be decremented when it is not needed by caller anymore. Signed-off-by: Kirill Batuzov --- hw/i386/acpi-build.c |6 ++ 1 file changed, 6 insertions(+) v1 -> v2: No changes. diff --git a/hw/i386/acpi-build.c b

Re: [Qemu-devel] [PATCH] block: Use BDRV_O_NO_BACKING where appropriate

2014-04-24 Thread Stefan Hajnoczi
On Fri, Apr 18, 2014 at 03:44:19PM +0200, Benoît Canet wrote: > From: Kevin Wolf > > If you open an image temporarily just because you want to check its size > or get it flushed, there's no real reason to open the whole backing file > chain. > > This is a backport of c9fbb99d41b05acf0d7b93deb2fc

[Qemu-devel] [PULL 1/2] vga: allow non-global vmstate

2014-04-24 Thread Gerd Hoffmann
Need a way to opt-out from vga.vram being global vmstate, for secondary vga cards. Add a bool parameter to vga_common_init to support this. Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vga-isa-mm.c | 2 +- hw/display/vga-isa.c

Re: [Qemu-devel] [PATCH 04/16] pci-assign: make assign_failed_examine() just format the cause

2014-04-24 Thread Eric Blake
On 04/10/2014 02:24 AM, Laszlo Ersek wrote: > This allows us to report the entire error with one error_report() call, > easing future error propagation. > > Signed-off-by: Laszlo Ersek > --- > hw/i386/kvm/pci-assign.c | 30 +++--- > 1 file changed, 19 insertions(+), 11 de

Re: [Qemu-devel] [Qemu-trivial] [PATCH] xilinx: Fix typo in comment (Marvel -> Marvell)

2014-04-24 Thread Michael Tokarev
Thanks, applied to -trivial. /mjt

[Qemu-devel] [PATCH 2/5] qemu-img: Consistently name Error * objects err, and not errp

2014-04-24 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- qemu-img.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 8455994..88124bf 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -442,12 +442,12 @@ fail: static void dump_json_image_check(ImageCheck *ch

Re: [Qemu-devel] [PULL v2 0/2] usb: mtp filesharing

2014-04-24 Thread Peter Maydell
On 23 April 2014 09:30, Gerd Hoffmann wrote: > Hi, > > Here comes the usb patch queue, featuring the MTP (media transfer > protocol) device usable for file sharing. For now it is supported > on linux hosts and read-only. > > v2: clarify copyright and licensing as suggested by Eric Blake. > > pl

[Qemu-devel] Running KVM inside pure Qemu?

2014-04-24 Thread Jun Koi
Hi, On Qemu 2.0, what commandline options should I use to run KVM (nested VM) inside pure emulator Qemu? Any guideline available onthis would be very helpful. Thanks so much, Jun

Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-24 Thread Amos Kong
On Tue, Apr 22, 2014 at 09:20:41AM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > Il 18/04/2014 23:56, Amos Kong ha scritto: > >> Currently we always add a space after c_type in mcgen(), there is > >> some redundant space in generated code. The space isn't needed for > >> points by

[Qemu-devel] [PATCH 1/3] hw/arm/virt: Create the GIC ourselves rather than (ab)using a15mpcore_priv

2014-04-24 Thread Peter Maydell
Rather than having the virt machine model create an a15mpcore_priv device regardless of the actual CPU type in order to instantiate the GIC, move to having the machine model create the GIC directly. This corresponds to a system which uses a standalone GIC (eg the GIC-400) rather than the one built

[Qemu-devel] [PATCH 01/10] MAINTAINERS: Take maintainership for QTest

2014-04-24 Thread Andreas Färber
Invented by Anthony. Maintenance has been handled by me lately. Note that the tests themselves are intentionally not part of this entry; they are considered part of the device or subsystem they are covering. Cc: Anthony Liguori Cc: Stefan Hajnoczi Signed-off-by: Andreas Färber --- MAINTAINERS

[Qemu-devel] [PATCH 3/5] gtk: Fix -serial vc

2014-04-24 Thread Cole Robinson
Try kicking off a rhel5 text install over serial, the text menu navigation is all messed up, and some of the kernel boot messages are randomly corrupted. Drop use of a pty and just use vte infrastructure for reading and writing. This fixes the above corruption, and is simpler to boot. (I don't kn

Re: [Qemu-devel] [PATCH 0/3] virtio: Eliminate "exit(1)" upon invalid request in virtio-blk and virtio-scsi

2014-04-24 Thread Michael S. Tsirkin
On Thu, Apr 24, 2014 at 09:15:25AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Apr 23, 2014 at 11:22:51AM +0800, Fam Zheng wrote: > >> On Tue, 04/22 22:12, Michael S. Tsirkin wrote: > >> > On Tue, Apr 22, 2014 at 04:55:14PM +0800, Fam Zheng wrote: > >> > > Today,

Re: [Qemu-devel] [PATCH] ps2: set ps/2 output buffer size as the same as kernel

2014-04-24 Thread Gerd Hoffmann
Hi, > Move the check into ps2_mouse_send_packet() is not a good idea. > In that case, we cannot break the for loop except we change the return value > of ps2_mouse_send_packet(). Changing the return value is fine IMO. cheers, Gerd

[Qemu-devel] [PATCH] qxl: Fix initial screenshot with spice

2014-04-24 Thread Cole Robinson
1) Start an f20 VM with -device qxl-vga + spice, connect with remote-viewer 2) Wait till it boots to gdm 3) (qemu) screendump foo.ppm 4) (qemu) screendump bar.ppm foo.ppm will actually show the last screen contents before the VM switched out of VGA mode (right before switching to plymouth). bar.pp

[Qemu-devel] [Bug 1307225] Re: Running a virtual machine on a Haswell system produces machine check events

2014-04-24 Thread Tobias-leupold
Still happens with qemu 2.0.0 and the same environment (Windows SBS 2003 32 bit guest on a Gentoo Linux amd64 Haswell host). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307225 Title: Running a v

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-24 Thread Max Reitz
On 23.04.2014 11:32, Kevin Wolf wrote: Am 22.04.2014 um 18:22 hat Max Reitz geschrieben: On 22.04.2014 17:19, Eric Blake wrote: On 04/17/2014 03:59 PM, Max Reitz wrote: After the top image has been committed into an image in its backing chain, all images above that base image should be emptied

[Qemu-devel] [PATCH 1/2] net: Make qmp_query_rx_filter() with name argument more obvious

2014-04-24 Thread Markus Armbruster
With a client name, the QMP command is specified to return a list of one element. This isn't locally obvious in the code. Make it so. Signed-off-by: Markus Armbruster --- net/net.c | 4 1 file changed, 4 insertions(+) diff --git a/net/net.c b/net/net.c index e3ef1e4..3175809 100644 --- a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: Use cpu_physical_memory_read and cpu_physical_memory_write

2014-04-24 Thread Michael Tokarev
07.04.2014 22:28, Stefan Weil wrote: > These functions don't need type casts (as does cpu_physical_memory_rw) > and also make the code better readable. Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH 5/6] input: switch sparc32 kbd to new input api

2014-04-24 Thread Gerd Hoffmann
Nasty 0xe0 logic is gone. We map through QKeyCode now, giving us a nice, readable mapping table. Quick smoke test in OpenFirmware looks ok. Careful check from arch maintainers would be very nice, especially on the capslock and numlock logic. I'm not fully sure whenever I got it translated corre

Re: [Qemu-devel] [PULL] Trivial patches for 2014-04-18

2014-04-24 Thread Peter Maydell
On 18 April 2014 07:42, Michael Tokarev wrote: > This is the same pull request as has been sent initially for 2.0 > and which we didn't apply. Except that this time, I fixed one more > "allows to" case which I overlooked in qemu-options.hx. > > I'm not re-sending whole series again, as at has bee

Re: [Qemu-devel] [PULL 0/8] tcg-ia64 updates

2014-04-24 Thread Peter Maydell
On 21 April 2014 18:08, Richard Henderson wrote: > > Aurelien found a bug in v1 of this series, but v2 has been on the > list for 3 weeks now. > > This is also my first attempt at a signed pull. Please let me know > if I've mucked up any part of that process. Looks good, thanks. > FWIW, the key

Re: [Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen argument

2014-04-24 Thread Stefan Hajnoczi
On Thu, Apr 24, 2014 at 02:49:18PM +0200, Andreas Färber wrote: > POSIX specifies that address_len shall on output specify the length of > the stored address; it does not however specify whether it may get > updated on failure as well to, e.g., zero. > > In case EINTR occurs, re-initialize the var

[Qemu-devel] [PATCH 06/10] tests: Add ac97 qtest

2014-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- MAINTAINERS | 1 + tests/Makefile| 3 +++ tests/ac97-test.c | 33 + 3 files changed, 37 insertions(+) create mode 100644 tests/ac97-test.c diff --git a/MAINTAINERS b/MAINTAINERS index 81115d4..5d5f9e2 100644 --- a/MAI

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 1/2] move test-* from .gitignore to tests/.gitignore

2014-04-24 Thread Michael Tokarev
Thanks, applied both to -trivial. /mjt

Re: [Qemu-devel] [PATCH v2] ps2: set ps/2 output buffer size as the same as kernel

2014-04-24 Thread Gonglei (Arei)
Hi, Gerd. > > > if (!(s->mouse_status & MOUSE_STATUS_REMOTE) && > > -(s->common.queue.count < (PS2_QUEUE_SIZE - 16))) { > > +(s->common.queue.count < PS2_QUEUE_SIZE - 4)) { > > for(;;) { > > Almost there. > > The check for enougth space in the queue should be for ev

[Qemu-devel] [PATCH v2] ps2: set ps/2 output buffer size as the same as kernel

2014-04-24 Thread arei.gonglei
From: Gonglei According to the PS/2 Mouse/Keyboard Protocol, the keyboard outupt buffer size is 16 bytes. And the PS2_QUEUE_SIZE 256 was introduced in Qemu from the very beginning. When I started a redhat5.6 32bit guest, meanwhile tapped the keyboard as quickly as possible, the screen would sh

[Qemu-devel] restore vm error by inter-vm shared memory device

2014-04-24 Thread stone1...@126.com
hi,all, when my vm restore, it is error that "Unknown ramblock ":06.0/ivshmem.bar2", cannot accept migration load of migration failed ". how I do to modify it. Regards & thanks. stone1...@126.com

[Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Jens Freimann
From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand --- target-s390x/cpu.h| 4 target-s390x/helper.c | 4 2 files

[Qemu-devel] [PATCH] PPC: spapr: Expose /hypervisor node in device tree

2014-04-24 Thread Alexander Graf
PR KVM supports an ePAPR compliant hypercall interface in parallel to the normal sPAPR one. Expose the ePAPR /hypervisor node and properties to the guest so it can use it. This enables magic page sharing on PR KVM with -M pseries. Signed-off-by: Alexander Graf --- hw/ppc/spapr.c | 13 ++

[Qemu-devel] [PATCH 2/6] input: add qemu_input_handler_deactivate

2014-04-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 + ui/input.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/ui/input.h b/include/ui/input.h index 010c903..3d3d487 100644 --- a/include/ui/input.h +++ b/include/ui/input.h @@ -27,6 +27,7 @@ struct QemuInputHandl

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-24 Thread Fam Zheng
On Thu, 04/24 17:28, Michael S. Tsirkin wrote: > On Thu, Apr 24, 2014 at 11:19:14AM +0800, Fam Zheng wrote: > > On Wed, 04/23 10:17, Michael S. Tsirkin wrote: > > > On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote: > > > > If guest driver behaves abnormally, emulation code could mark the d

Re: [Qemu-devel] [PATCH 03/10] qtest: Assure that init_socket()'s listen() does not fail

2014-04-24 Thread Stefan Hajnoczi
On Thu, Apr 24, 2014 at 02:49:16PM +0200, Andreas Färber wrote: > In practice this seems very unlikely, so cleanup is neglected, as done > for bind(). > > Signed-off-by: Andreas Färber > --- > tests/libqtest.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnocz

[Qemu-devel] [PATCH 02/10] MAINTAINERS: Document I2C libqos

2014-04-24 Thread Andreas Färber
Written by me for TMP105 testing. Signed-off-by: Andreas Färber --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f746017..81115d4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -896,6 +896,12 @@ F: include/sysemu/qtest.h F: qtest.c F: tes

Re: [Qemu-devel] [PATCH 1/5] Use error_is_set() only when necessary (again)

2014-04-24 Thread Kevin Wolf
Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben: > error_is_set(&var) is the same as var != NULL, but it takes > whole-program analysis to figure that out. Unnecessarily hard for > optimizers, static checkers, and human readers. Commit 84d18f0 dumbed > it down to obvious, but a few more

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial v2 0/2] vl: simplify code for main()

2014-04-24 Thread Michael Tokarev
16.04.2014 03:55, Chen Gang wrote: > In "vl.c", at least, we can simplify the code below, so can let readers > read professional C code (especially for new readers, which often start > reading code at main function). > > - Remove useless 'continue' in main(). > > - Eliminate a superfluous local

Re: [Qemu-devel] [PATCH 2/5] qemu-img: Consistently name Error * objects err, and not errp

2014-04-24 Thread Markus Armbruster
Kevin Wolf writes: > Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben: >> >> Signed-off-by: Markus Armbruster >> --- >> qemu-img.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index 8455994..88124bf 100644 >> --- a

Re: [Qemu-devel] [PATCH 1/3] s390x: empty function stubs in preparation for __KVM_HAVE_GUEST_DEBUG

2014-04-24 Thread Christian Borntraeger
On 24/04/14 10:51, Jens Freimann wrote: > From: David Hildenbrand > > This patch creates empty function stubs (used by the gdbserver) in preparation > for the hw debugging support by kvm on s390, which will enable the > __KVM_HAVE_GUEST_DEBUG define in the linux headers and require these methods

[Qemu-devel] [PATCH 09/10] tests: Add ioh3420 qtest

2014-04-24 Thread Andreas Färber
Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/ioh3420-test.c | 34 ++ 2 files changed, 37 insertions(+) create mode 100644 tests/ioh3420-test.c diff --git a/tests/Makefile b/tests/Makefile index 80f276f..19f2208 100644 --- a/tests/Makefil

Re: [Qemu-devel] qemu projects

2014-04-24 Thread Pradeep Kiruvale
Hi Stefan, Thanks I will follow your suggestion. Regards, Pradeep On 24 April 2014 14:10, Stefan Hajnoczi wrote: > On Wed, Apr 09, 2014 at 07:28:15PM +0200, Pradeep Kiruvale wrote: > > I am new to qemu-kvm.But have good knowledge about virtulization and > cloud > > computing.I would like to

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-24 Thread Fam Zheng
On Fri, 04/25 11:01, Fam Zheng wrote: > On Thu, 04/24 08:19, Jan Kiszka wrote: > > On 2014-04-23 11:25, Stefan Hajnoczi wrote: > > > Dear QEMU, Libvirt, and KVM communities, > > > We are participating in Google Summer of Code 2014 > > > (http://google-melange.com/) and Outreach Program for Women >

[Qemu-devel] [PATCH 0/3] qemu: pending s390x patches

2014-04-24 Thread Jens Freimann
Cornelia,Alex,Christian, here are two fixes for address translation and one patch preparing support for guest debugging support. Patch 1 - This one should go in soon because we already have __KVM_HAVE_GUEST_DEBUG in kvm/queue. It adds function stubs for guest debugging as a p

[Qemu-devel] [PATCH 03/10] qtest: Assure that init_socket()'s listen() does not fail

2014-04-24 Thread Andreas Färber
In practice this seems very unlikely, so cleanup is neglected, as done for bind(). Signed-off-by: Andreas Färber --- tests/libqtest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 8155695..232f781 100644 --- a/tests/libqtest.c +++

[Qemu-devel] [PATCH 0/6] input layer rework continued

2014-04-24 Thread Gerd Hoffmann
Hi, Series adds some keyboard mapping helpers and starts switching over devices to the new input api. A careful look at the sparc bits from anyone more familiar with sparc keyboard than me would be great. cheers, Gerd Gerd Hoffmann (6): input: key mapping helpers input: add qemu_input_h

Re: [Qemu-devel] [PATCH 1/5] Use error_is_set() only when necessary (again)

2014-04-24 Thread Markus Armbruster
Kevin Wolf writes: > Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben: >> error_is_set(&var) is the same as var != NULL, but it takes >> whole-program analysis to figure that out. Unnecessarily hard for >> optimizers, static checkers, and human readers. Commit 84d18f0 dumbed >> it down

Re: [Qemu-devel] [PATCH v2] doc: add -drive rerror=, werror= to qemu --help output

2014-04-24 Thread Stefan Hajnoczi
On Wed, Apr 23, 2014 at 01:55:37PM +0200, Stefan Hajnoczi wrote: > These options are already documented on the man page but missing from > qemu --help. > > Signed-off-by: Stefan Hajnoczi > --- > qemu-options.hx | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to my block tree:

Re: [Qemu-devel] [PATCH microblaze/ppc v2 0/8] Remove include/hw/xilinx.h

2014-04-24 Thread Edgar E. Iglesias
On Mon, Apr 14, 2014 at 12:19:49PM +0200, Alexander Graf wrote: > > On 25.02.14 09:46, Peter Crosthwaite wrote: > >Ping! > > Did this get applied meanwhile? Edgar? Hi Alex, Sorry for the delays, yes this went in a while ago. http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04674.html

Re: [Qemu-devel] [PATCH v5 12/12] iotests: Omit length/offset test in 040 and 041

2014-04-24 Thread Max Reitz
On 23.04.2014 08:50, Fam Zheng wrote: On Thu, 04/17 23:59, Max Reitz wrote: As the length of a mirror block job no longer directly depends on the size of the block device, drop the related checks from this test. As 041 uses the wait_until_completed function from iotests.py, that check has to be

Re: [Qemu-devel] [patch 2/2] target-i386: block migration and savevm if invariant tsc is exposed

2014-04-24 Thread Paolo Bonzini
Il 24/04/2014 22:57, Eduardo Habkost ha scritto: On Thu, Apr 24, 2014 at 04:42:33PM -0400, Paolo Bonzini wrote: Il 22/04/2014 21:14, Eduardo Habkost ha scritto: Not for "-cpu host". If somebody needs migration to work, they shouldn't be using "-cpu host" anyway (I don't know if you have seen th

Re: [Qemu-devel] [PATCH v3] ps2: set ps/2 output buffer size as the same as kernel

2014-04-24 Thread Juan Quintela
wrote: > From: Gonglei > > According to the PS/2 Mouse/Keyboard Protocol, the keyboard outupt buffer size > is 16 bytes. And the PS2_QUEUE_SIZE 256 was introduced in Qemu from the very > beginning. > > When I started a redhat5.6 32bit guest, meanwhile tapped the keyboard as > quickly as > possi

[Qemu-devel] [PATCH v2 06/13] tcg-sparc: Use the RETURN instruction

2014-04-24 Thread Richard Henderson
Saves one insn per TB exit over JMPL+RESTORE. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 86229d5..b4a15af 100644 --- a/tcg/sparc/tcg-target.c

[Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-24 Thread Jens Freimann
From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. Signed-off-by: Thomas Huth Signed-off-by: Jens Freimann Reviewed-by: David Hildenbrand --- target-s390x/helper.c | 4 1 file changed, 4 insertions(+) diff --

[Qemu-devel] [PATCH 1/6] input: key mapping helpers

2014-04-24 Thread Gerd Hoffmann
Add helper functions to translate KeyValue (qapi key representation) into other representations: traditional qemu key numbers, qapi key codes (Q_KEY_CODE_*) and scancode sequences. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 4 + ui/Makefile.objs | 3 +- ui/input-keymap.c | 210

[Qemu-devel] [PATCH v3] ps2: set ps/2 output buffer size as the same as kernel

2014-04-24 Thread arei.gonglei
From: Gonglei According to the PS/2 Mouse/Keyboard Protocol, the keyboard outupt buffer size is 16 bytes. And the PS2_QUEUE_SIZE 256 was introduced in Qemu from the very beginning. When I started a redhat5.6 32bit guest, meanwhile tapped the keyboard as quickly as possible, the screen would sh

Re: [Qemu-devel] [PATCH v2 0/2] HMP: support specifying dump format for dump-guest-memory

2014-04-24 Thread Luiz Capitulino
On Thu, 24 Apr 2014 08:53:11 +0200 Markus Armbruster wrote: > qiaonuohan writes: > > > On 04/23/2014 09:30 PM, Luiz Capitulino wrote: > >> On Wed, 23 Apr 2014 12:38:12 +0200 > >> Christian Borntraeger wrote: > >> > >>> On 17/04/14 10:15, Qiao Nuohan wrote: > The last version is here: > >>

[Qemu-devel] [PULL 2/2] vga: add secondary stdvga variant

2014-04-24 Thread Gerd Hoffmann
Add a standard vga variant which doesn't occupy any legacy ressources and thus can easily be used as secondary (or legacy-free) graphics adapter. Programming must be done using the MMIO bar. Signed-off-by: Gerd Hoffmann --- docs/specs/standard-vga.txt | 13 +++--- hw/display/vga-pci.c

Re: [Qemu-devel] [PATCH 0/3] virtio: Eliminate "exit(1)" upon invalid request in virtio-blk and virtio-scsi

2014-04-24 Thread Michael S. Tsirkin
On Thu, Apr 24, 2014 at 12:43:56PM +0200, Kevin Wolf wrote: > Am 24.04.2014 um 09:55 hat Michael S. Tsirkin geschrieben: > > On Thu, Apr 24, 2014 at 09:15:25AM +0200, Markus Armbruster wrote: > > > "Michael S. Tsirkin" writes: > > > > > > > On Wed, Apr 23, 2014 at 11:22:51AM +0800, Fam Zheng wrot

[Qemu-devel] [PATCH 6/6] input: remove sparc keymap hack

2014-04-24 Thread Gerd Hoffmann
With sparc keyboard going directly from QKeyValue to sparc keycodes this should not be needed any more. Signed-off-by: Gerd Hoffmann --- ui/input-keymap.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/ui/input-keymap.c b/ui/input-keymap.c index 67a3ea7..6da4495 100644 -

Re: [Qemu-devel] [PATCH v2] configure: Change --enable-tpm to --disable-tpm

2014-04-24 Thread Cole Robinson
On 04/24/2014 01:13 PM, Cole Robinson wrote: > I don't see why tpm is disabled by default: it doesn't have any > external dependencies, or change default behavior. Leaving it disabled > is just going to cause it to bit rot. > > Enable it by default, and change --enable-tpm to --disable-tpm if > pe

Re: [Qemu-devel] [PATCH] block: Expose host_* drivers in blockdev-add

2014-04-24 Thread Kevin Wolf
Am 24.04.2014 um 09:27 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 23.04.2014 um 17:34 hat Eric Blake geschrieben: > >> On 04/23/2014 09:12 AM, Kevin Wolf wrote: > >> > All the functionality to use the host_device, host_cdrom and host_floppy > >> > drivers is already there, t

[Qemu-devel] [PATCH v2 05/13] tcg-sparc: Use 64-bit registers with sparcv8plus

2014-04-24 Thread Richard Henderson
Quite a lot of effort was spent composing and decomposing 64-bit quantities in registers, when we should just create them and leave them as one 64-bit register. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 525 + tcg/sparc/tcg-targ

Re: [Qemu-devel] [PATCH] block: prefer protocol_name over format_name in bdrv_iterate_format

2014-04-24 Thread Jeff Cody
On Thu, Apr 24, 2014 at 02:34:19PM +0200, Stefan Hajnoczi wrote: > On Tue, Apr 15, 2014 at 04:00:54PM +0200, Kevin Wolf wrote: > > Am 15.04.2014 um 15:28 hat Jeff Cody geschrieben: > > > Some block drivers have multiple BlockDriver instances with identical > > > format_name fields (e.g. gluster, nb

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-24 Thread Stefan Hajnoczi
On Thu, Apr 24, 2014 at 04:45:00PM +1000, Peter Crosthwaite wrote: > Convert conditional compilation of debug printfs to regular ifs. > > good: > > #ifdef DEBUG_FOO > #define DEBUG_FOO 0 > #endif > > #define DB_PRINTF \ > if (DEBUG_FOO) { \ > fprintf(...) \ > } > > bad: > > #ifdef DEB

[Qemu-devel] [PATCH 04/10] qtest: Add error reporting to socket_accept()

2014-04-24 Thread Andreas Färber
We're not using the GLib infrastructure here, to allow cleaning up the sockets. Still, knowing why a certain test run failed can be valuable. Signed-off-by: Andreas Färber --- tests/libqtest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 232f78

[Qemu-devel] [RFC]How to improve KVM VM resource assignment and per-vm process/thread scheduling.

2014-04-24 Thread Huangpeng (Peter)
Hi, ALL Currently kvm hypervisor have lots of features depend on linux standard apis, like vcpupin/mempin/processpin etc. But in the real production environment, we need an automated resource assign and/or scheduling, is there any plan to implement it? resource assignment requirements like: cpu

Re: [Qemu-devel] [PATCH v2] Add QEMU logo (SVG file)

2014-04-24 Thread Stefan Hajnoczi
On Thu, Apr 17, 2014 at 10:31:13PM +0200, Stefan Weil wrote: > The "Q" of the logo is already included in pc-bios/qemu_logo_no_text.svg. > > This file now adds the complete logo as it was designed by Benoît Canet. > Benoît licensed it under CC-BY 3.0, see > http://lists.gnu.org/archive/html/qemu-d

[Qemu-devel] [PATCH] pc: add 2.1 machine type

2014-04-24 Thread Michael S. Tsirkin
At the moment, 2.1 and 2.0 machines are identical. As several people are working on incompatible changes to the PC machine, collaboration will be made easier by merging this place-holder. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 28 hw/i386/pc_q35.c

Re: [Qemu-devel] [PATCH] ps2: set ps/2 output buffer size as the same as kernel

2014-04-24 Thread Gonglei (Arei)
Hi, Gerd. > > if (!(s->mouse_status & MOUSE_STATUS_REMOTE) && > > -(s->common.queue.count < (PS2_QUEUE_SIZE - 16))) { > > +(s->common.queue.count < PS2_QUEUE_SIZE)) { > > To me this looks like an attempt to make sure the queue has enough space > for the whole mouse message.

Re: [Qemu-devel] [PATCH v2] ps2: set ps/2 output buffer size as the same as kernel

2014-04-24 Thread Gerd Hoffmann
Hi, > if (!(s->mouse_status & MOUSE_STATUS_REMOTE) && > -(s->common.queue.count < (PS2_QUEUE_SIZE - 16))) { > +(s->common.queue.count < PS2_QUEUE_SIZE - 4)) { > for(;;) { Almost there. The check for enougth space in the queue should be for every ps2_mouse_send_pac

[Qemu-devel] [PATCH v2 3/4] console: Abort on property access errors

2014-04-24 Thread Kirill Batuzov
All defined properties of QemuConsole are mandatory and no access to them should fail. Nevertheless not checking returned errors is bad because in case of unexpected failure it will hide the bug and cause a memory leak. Abort in case of unexpected property access errors. This change exposed a bug

[Qemu-devel] [PATCH 4/6] input: switch ps/2 mouse to new input api

2014-04-24 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/input/ps2.c | 67 +- 1 file changed, 52 insertions(+), 15 deletions(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 9b35869..bda2c94 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -368,28 +368,

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-24 Thread Michael S. Tsirkin
On Thu, Apr 24, 2014 at 09:21:00AM +0100, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > "Dr. David Alan Gilbert" writes: > > > > > * Eric Blake (ebl...@redhat.com) wrote: > > >> On 04/23/2014 10:37 AM, Dr. David Alan Gilbert (git) wrote: > > >> > From: "Dr. Da

Re: [Qemu-devel] [PULL v2 2/2] usb: mtp filesharing

2014-04-24 Thread Eric Blake
On 04/24/2014 07:21 AM, Stefan Hajnoczi wrote: >> +static void usb_mtp_object_readdir(MTPState *s, MTPObject *o) >> +{ >> +struct dirent *entry; >> +DIR *dir; >> + >> +o->nchildren = 0; >> +dir = opendir(o->path); >> +if (!dir) { >> +return; >> +} >> +while ((en

Re: [Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen argument

2014-04-24 Thread Eric Blake
On 04/24/2014 06:49 AM, Andreas Färber wrote: > POSIX specifies that address_len shall on output specify the length of > the stored address; it does not however specify whether it may get > updated on failure as well to, e.g., zero. Your reading of POSIX leaving the value undefined matches mine.

Re: [Qemu-devel] [PULL v2 2/2] usb: mtp filesharing

2014-04-24 Thread Stefan Hajnoczi
On Wed, Apr 23, 2014 at 10:31:01AM +0200, Gerd Hoffmann wrote: Just a quick review. If I understand correctly, the guest never sends filenames to the guest. Instead filenames are discovered using readdir inside QEMU and the guest accesses objects by handle. This seems like a good property for s

[Qemu-devel] [PATCH v2 01/13] tcg: Fix missed pointer size != TCG_TARGET_REG_BITS changes

2014-04-24 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/def-helper.h | 2 +- tcg/tcg-op.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/exec/def-helper.h b/include/exec/def-helper.h index 73d51f9..255b58b 100644 --- a/include/exec/def-helper.h +++ b/inclu

Re: [Qemu-devel] qemu projects

2014-04-24 Thread Stefan Hajnoczi
On Wed, Apr 09, 2014 at 07:28:15PM +0200, Pradeep Kiruvale wrote: > I am new to qemu-kvm.But have good knowledge about virtulization and cloud > computing.I would like to do some projects in qemu-kvm.Please let me know > how can I start. > > Please suggest me some small projects which I can take

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-24 Thread Fam Zheng
On Thu, 04/24 08:19, Jan Kiszka wrote: > On 2014-04-23 11:25, Stefan Hajnoczi wrote: > > Dear QEMU, Libvirt, and KVM communities, > > We are participating in Google Summer of Code 2014 > > (http://google-melange.com/) and Outreach Program for Women > > (http://opw.gnome.org/). Both programs fund c

Re: [Qemu-devel] [PULL v2 2/2] usb: mtp filesharing

2014-04-24 Thread Gerd Hoffmann
Hi, > Just a quick review. If I understand correctly, the guest never sends > filenames to the guest. Instead filenames are discovered using readdir > inside QEMU and the guest accesses objects by handle. Correct. > This seems like a > good property for security since it eliminates '..' esca

Re: [Qemu-devel] [Bug 1288620] Re: memory leak with default NIC model

2014-04-24 Thread Stefan Hajnoczi
On Wed, Apr 23, 2014 at 08:18:21PM -, Aidan Gauland wrote: > On Wed, 23 Apr 2014 13:10:39 -, Stefan Hajnoczi wrote: > > So this is a problem that only happens under Valgrind? Perhaps this > > is > > a valgrind bug. > > No, it happens outside of Valgrind as well. It only happens when QEM

Re: [Qemu-devel] [PATCH 04/10] qtest: Add error reporting to socket_accept()

2014-04-24 Thread Stefan Hajnoczi
On Thu, Apr 24, 2014 at 02:49:17PM +0200, Andreas Färber wrote: > We're not using the GLib infrastructure here, to allow cleaning up the > sockets. Still, knowing why a certain test run failed can be valuable. > > Signed-off-by: Andreas Färber > --- > tests/libqtest.c | 3 +++ > 1 file changed,

[Qemu-devel] [Bug 1288620] Re: memory leak with config file

2014-04-24 Thread Aidan Gauland
It does seem to be related to the guest, because with a dummy (non- bootable, garbage data) disk image, the rapid memory leak does not occur. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1288620 Tit

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

2014-04-24 Thread Michael Tokarev
Thanks, applied to trivial patches. Finally. /mjt

Re: [Qemu-devel] [PATCH 05/10] qtest: Be paranoid about accept() addrlen argument

2014-04-24 Thread Eric Blake
On 04/24/2014 06:55 AM, Eric Blake wrote: > On 04/24/2014 06:49 AM, Andreas Färber wrote: >> POSIX specifies that address_len shall on output specify the length of >> the stored address; it does not however specify whether it may get >> updated on failure as well to, e.g., zero. > > Your reading o

[Qemu-devel] [PATCH v2 08/13] tcg-sparc: Tidy check_fit_* tests

2014-04-24 Thread Richard Henderson
Use sextract instead of raw bit shifting for the tests. Introduce a new check_fit_ptr macro to make it clear we're looking at pointers. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff -

  1   2   >