Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-25 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Tue, Apr 22, 2014 at 09:20:41AM +0200, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 18/04/2014 23:56, Amos Kong ha scritto: Currently we always add a space after c_type in mcgen(), there is some redundant space in generated

Re: [Qemu-devel] [PATCH] block: Expose host_* drivers in blockdev-add

2014-04-25 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 24.04.2014 um 09:27 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: Am 23.04.2014 um 17:34 hat Eric Blake geschrieben: On 04/23/2014 09:12 AM, Kevin Wolf wrote: All the functionality to use the host_device, host_cdrom and

Re: [Qemu-devel] [PATCH microblaze v1 1/1] net: xilinx_axienet.c: Add phy soft reset bit clearing

2014-04-25 Thread Edgar E. Iglesias
On Thu, Apr 24, 2014 at 02:03:45PM +0200, Stefan Hajnoczi wrote: On Tue, Apr 08, 2014 at 06:52:39PM -0700, Peter Crosthwaite wrote: From: Nathan Rossi nathan.ro...@xilinx.com Clear the BMCR Reset when writing to registers. Signed-off-by: Nathan Rossi nathan.ro...@xilinx.com [ PC:

Re: [Qemu-devel] [PATCH 0/3] virtio: Eliminate exit(1) upon invalid request in virtio-blk and virtio-scsi

2014-04-25 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Apr 24, 2014 at 12:43:56PM +0200, Kevin Wolf wrote: Am 24.04.2014 um 09:55 hat Michael S. Tsirkin geschrieben: On Thu, Apr 24, 2014 at 09:15:25AM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed,

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-25 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 24.04.2014 08:19, schrieb Jan Kiszka: On 2014-04-23 11:25, Stefan Hajnoczi wrote: Dear QEMU, Libvirt, and KVM communities, We are participating in Google Summer of Code 2014 (http://google-melange.com/) and Outreach Program for Women

Re: [Qemu-devel] [PATCH] qxl: Fix initial screenshot with spice

2014-04-25 Thread Gerd Hoffmann
Hi, ui/console.c:qmp_screendump attempts to handle this by calling graphic_hw_update, but qxl handle's that asynchronously, and it isn't run until after the first screendump is performed. That's why the second screendump is correct. Known issue. The graphic_hw_update makes sure it works

Re: [Qemu-devel] [PATCH for-2.0 v2] tests: Don't run qom-test twice

2014-04-25 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 24.04.2014 16:34, schrieb Peter Maydell: On 24 April 2014 15:29, Stefan Hajnoczi stefa...@redhat.com wrote: On Mon, Apr 07, 2014 at 04:13:00PM +0200, Andreas Färber wrote: Commit 3687d5325 accidentally resulted in running qom-test twice for x86_64,

Re: [Qemu-devel] [RFC PATCH v2 00/16] visitor+BER migration format

2014-04-25 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Apr 24, 2014 at 09:21:00AM +0100, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Dr. David Alan Gilbert dgilb...@redhat.com writes: * Eric Blake (ebl...@redhat.com) wrote: On 04/23/2014 10:37 AM, Dr.

[Qemu-devel] Discussion: xen hvm guest direct kernel boot

2014-04-25 Thread Chun Yan Liu
Hi, I'm looking at xen hvm guest direct kernel boot and interested to do it. I found there were some discussions about it and an early work around by Daniel (based on xen qemu-dm). [1]http://old-list-archives.xenproject.org/xen-devel/2011-08/msg00414.html

Re: [Qemu-devel] [PATCH 0/3] disas/libvixl: update to upstream 1.3

2014-04-25 Thread Christoffer Dall
On 24 April 2014 21:11, Peter Maydell peter.mayd...@linaro.org wrote: This patchset updates our copy of libvixl to the upstream 1.3 release. I don't think there's anything particularly earthshattering in 1.3 compared to what we had before. I had a bit of a dilemma with this patchset: *

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-25 Thread Jan Kiszka
On 2014-04-24 08:19, Jan Kiszka wrote: On 2014-04-23 11:25, Stefan Hajnoczi wrote: Dear QEMU, Libvirt, and KVM communities, We are participating in Google Summer of Code 2014 (http://google-melange.com/) and Outreach Program for Women (http://opw.gnome.org/). Both programs fund candidates to

[Qemu-devel] [PATCH] mirror: Check for bdrv_get_info result

2014-04-25 Thread Fam Zheng
bdrv_get_info could fail. Add check before using the returned value. Signed-off-by: Fam Zheng f...@redhat.com --- block/mirror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 0ef41f9..fafcc93 100644 --- a/block/mirror.c +++

Re: [Qemu-devel] [PATCH] monitor: fix qmp_getfd() fd leak in error case

2014-04-25 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to the caller. Therefore all code paths in qmp_getfd() should either register the file descriptor somewhere or close it. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-25 Thread Marc Marí
I'm now looking at the conditional fprintf's. I'll need a bit of help later in sending the patches :D. Marc 2014-04-25 9:24 GMT+02:00 Jan Kiszka jan.kis...@web.de: On 2014-04-24 08:19, Jan Kiszka wrote: On 2014-04-23 11:25, Stefan Hajnoczi wrote: Dear QEMU, Libvirt, and KVM communities,

[Qemu-devel] [PATCH v2 0/2] qapi: fix coding style in generated code

2014-04-25 Thread Amos Kong
Not a serious issue, but it's helpful if we can fix it. V2: split change of scripts/qapi-visit.py to a split patch, eat space by using a special char as Markus suggested Amos Kong (2): qapi: fix coding style in parameters list qapi: add a special string in c_type()'s result to each

[Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space

2014-04-25 Thread Amos Kong
Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for points by the coding style. char * value; ^ qapi_free_NameInfo(NameInfo * obj) ^ This patch added a special string

[Qemu-devel] [PATCH v2 1/2] qapi: fix coding style in parameters list

2014-04-25 Thread Amos Kong
The space before point is redundant. Signed-off-by: Amos Kong ak...@redhat.com --- scripts/qapi-visit.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 45ce3a9..8ffed3d 100644 ---

[Qemu-devel] [PATCH v3 0/4] Fix conversion from ISO to VMDK streamOptimized

2014-04-25 Thread Fam Zheng
Previouly, convert from ISO to VMDK with subformat=streamOptimized fails: $ ./qemu-img convert -O vmdk -o subformat=streamOptimized foo.iso bar.vmdk VMDK: can't write to allocated cluster for streamOptimized qemu-img: error while writing sector 64: Input/output error Because current

[Qemu-devel] [PATCH v3 3/4] vmdk: Implement .bdrv_get_info()

2014-04-25 Thread Fam Zheng
This will return cluster_size and is_compressed to caller, if all the extents has the same value (or there's only one extent). Otherwise return -ENOTSUP. cluster_size is only reported for sparse formats. Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 21

[Qemu-devel] [PATCH v3 2/4] vmdk: Implement .bdrv_write_compressed

2014-04-25 Thread Fam Zheng
Add a wrapper function to support compressed path in qemu-img convert. Only support streamOptimized subformat case for now (num_extents == 1 and extent compression is true). Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 14 ++ 1 file changed, 14 insertions(+) diff

[Qemu-devel] [PATCH v3 4/4] qemu-iotests: Test converting to streamOptimized from small cluster size

2014-04-25 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/059 | 7 +++ tests/qemu-iotests/059.out | 7 +++ 2 files changed, 14 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index ca5aa16..26a2fd3 100755 --- a/tests/qemu-iotests/059 +++

[Qemu-devel] [PATCH] improve emulation correctness

2014-04-25 Thread Dmitry Poletaev
There is a set of test, that checks QEMU CPU for similar behavior with real hardware (http://roberto.greyhats.it/projects/pills.html). Test reg/pill2579.c can detect, that program is execute in emulated environment. It is related with behavior of rcl instruction. If the number of shifted bits

Re: [Qemu-devel] [PATCH v2 1/2] qapi: fix coding style in parameters list

2014-04-25 Thread Fam Zheng
On Fri, 04/25 15:56, Amos Kong wrote: The space before point is redundant. s/point/pointer Fam Signed-off-by: Amos Kong ak...@redhat.com --- scripts/qapi-visit.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/qapi-visit.py

Re: [Qemu-devel] [PATCH 0/3] virtio: Eliminate exit(1) upon invalid request in virtio-blk and virtio-scsi

2014-04-25 Thread Kevin Wolf
Am 25.04.2014 um 08:29 hat Markus Armbruster geschrieben: Michael S. Tsirkin m...@redhat.com writes: On Thu, Apr 24, 2014 at 12:43:56PM +0200, Kevin Wolf wrote: Am 24.04.2014 um 09:55 hat Michael S. Tsirkin geschrieben: On Thu, Apr 24, 2014 at 09:15:25AM +0200, Markus Armbruster wrote:

[Qemu-devel] [PATCH v3 1/4] qemu-img: Convert by cluster size if target is compressed

2014-04-25 Thread Fam Zheng
If target block driver forces compression, qemu-img convert needs to write by cluster size as well as -c option. Particularly, this applies for converting to VMDK streamOptimized format. Signed-off-by: Fam Zheng f...@redhat.com --- include/block/block.h | 4 qemu-img.c| 1 + 2

Re: [Qemu-devel] Monitor Readline - no terminal echo after exit

2014-04-25 Thread Markus Armbruster
Mike Day ncm...@ncultra.org writes: On Thu, Apr 24, 2014 at 3:31 AM, Markus Armbruster arm...@redhat.com wrote: I believe someone on the list mentioned they are seeing a couple problems entering and exiting the Monitor. I'd like to look at this more closely, starting with my most pending

Re: [Qemu-devel] [PATCH 2/5] gtk: Fix monitor greeting

2014-04-25 Thread Gerd Hoffmann
Hi, Apparently requesting the vte terminal size isn't sufficient, we need to force a size_request so text doesn't line wrap. We use slightly different APIs for gtk3, since on 3.10 the size_request trick doesn't seem to work. Something is fishy there indeed. I somehow feel like we are

Re: [Qemu-devel] [PATCH 3/5] gtk: Fix -serial vc

2014-04-25 Thread Gerd Hoffmann
On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote: Drop use of a pty and just use vte infrastructure for reading and writing. Makes perfect sense. pty is poinless in our vte usage szenario. cheers, Gerd

[Qemu-devel] [PATCH 2/3] char: Clean up fragile use of error_is_set()

2014-04-25 Thread Markus Armbruster
Using error_is_set(ERRP) to find out whether a function failed is either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP may be null, because errors go undetected when it is. It's fragile when proving ERRP non-null involves a non-local argument. Else, it's unnecessarily opaque

[Qemu-devel] [PATCH 1/3] char: Use return values instead of error_is_set(errp)

2014-04-25 Thread Markus Armbruster
Using error_is_set(errp) to check whether a function call failed is fragile: it breaks when errp is null. Check perfectly suitable return values instead when possible. As far as I can tell, errp can't be null there, but this is more robust and more obviously correct Signed-off-by: Markus

[Qemu-devel] [PATCH 0/3] char: Purge error_is_set()

2014-04-25 Thread Markus Armbruster
I got a private branch getting rid of it entirely. This is the third part, covering character backends. Markus Armbruster (3): char: Use return values instead of error_is_set(errp) char: Clean up fragile use of error_is_set() char: Explain qmp_chardev_add()'s unusual error handling

[Qemu-devel] [PATCH 3/3] char: Explain qmp_chardev_add()'s unusual error handling

2014-04-25 Thread Markus Armbruster
Character backend open hasn't been fully converted to the Error API. Some opens fail without setting an error. qmp_chardev_add() needs to detect when that happens, and set a generic error. Explain that in a comment, and inline error_is_set() for clarity. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH] migration: remove duplicate code

2014-04-25 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com version_id is checked twice in the ram_load. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- arch_init.c | 68 ++--- 1 file changed, 33

Re: [Qemu-devel] [RFC 4/4] MemoryRegion with EOI callbacks for VFIO Platform devices

2014-04-25 Thread Alvise Rigo
Hi Eric, Thank you for reviewing it. On 23/04/2014 17:00, Eric Auger wrote: Hi Alvise, Thank you for the patch. Indeed I am very interested in further discussing the vfio-platform integration with you. On 04/17/2014 07:29 PM, Alvise Rigo wrote: The user can specify the location of the

Re: [Qemu-devel] [PATCH 4/5] gtk: Fix zoom in accelerator

2014-04-25 Thread Gerd Hoffmann
On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote: The accelerator was ctrl+shift+'+', but '+' required a shift key already, so the accelerator didn't trigger. Switch it to ctrl+shift+'=' Hmm? For me the accelerator is ctrl+alt. Also which keys need shift and which don't depends on the

Re: [Qemu-devel] [PATCH 5/5] gtk: Fix accelerators being triggered twice with gtk3

2014-04-25 Thread Gerd Hoffmann
On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote: When keyboard focus is grabbed, current qemu wants to pass every keypress to the VM, unless the user is pressing a UI accelerator. That's exactly how things work without any of the fancy handling. Drop the special handling, which seems

Re: [Qemu-devel] [RFC 2/4] Add EXEC_FLAG to VFIO DMA mappings

2014-04-25 Thread Alvise Rigo
On 24/04/2014 02:25, Peter Crosthwaite wrote: On Fri, Apr 18, 2014 at 3:29 AM, Alvise Rigo a.r...@virtualopensystems.com wrote: The flag is mandatory for the ARM SMMU, add it. When VFIO will be able to tell about the IOMMU being used, we will add it only if necessary. Signed-off-by: Alvise

Re: [Qemu-devel] [PATCH 0/5] gtk: Misc fixes

2014-04-25 Thread Gerd Hoffmann
On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote: A collection of fixes related to the gtk UI. See individual patches for details. cherry-picked #1 + #3 for now. FYI: current gtk patch queue looks like this: https://www.kraxel.org/cgit/qemu/log/?h=rebase/ui-gtk-next cheers, Gerd

Re: [Qemu-devel] [RFC 0/4] AMBA platform device passthrough

2014-04-25 Thread Alvise Rigo
Il 24/04/2014 02:16, Peter Crosthwaite ha scritto: On Thu, Apr 24, 2014 at 1:21 AM, Eric Auger eric.au...@linaro.org wrote: On 04/17/2014 07:29 PM, Alvise Rigo wrote: These patches were born after trying the current work on device passthrough (see thread [Qemu-devel] [RFC v2 0/6] KVM platform

Re: [Qemu-devel] Monitor Readline - no terminal echo after exit

2014-04-25 Thread Gerd Hoffmann
Hi, -nographic without -nodefaults sets up a default serial line and a monitor, multiplexed onto stdio. Another way to get that is -serial mon:stdio. Maybe the multiplexing has regressed. I'm not sure, as I don't use it myself. Gerd (cc'ed) might know more. Works for me. Serial line

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-25 Thread Peter Crosthwaite
On Fri, Apr 25, 2014 at 5:55 PM, Marc Marí marc.mari.barc...@gmail.com wrote: I'm now looking at the conditional fprintf's. I'll need a bit of help later in sending the patches :D. CC me in on the results. Regards, Peter Marc 2014-04-25 9:24 GMT+02:00 Jan Kiszka jan.kis...@web.de: On

Re: [Qemu-devel] [RFC 0/4] AMBA platform device passthrough

2014-04-25 Thread Alvise Rigo
On 23/04/2014 17:21, Eric Auger wrote: On 04/17/2014 07:29 PM, Alvise Rigo wrote: These patches were born after trying the current work on device passthrough (see thread [Qemu-devel] [RFC v2 0/6] KVM platform device passthrough) with a DMA330 and FastModels. This work want to be the starting

Re: [Qemu-devel] [PATCH for-2.1 v1 2/3] qdev: Implement named GPIOs

2014-04-25 Thread Peter Crosthwaite
On Fri, Apr 25, 2014 at 12:02 AM, Andreas Färber afaer...@suse.de wrote: Am 09.04.2014 01:45, schrieb Peter Crosthwaite: Implement named GPIOs on the Device layer. Listifies the existing GPIOs stuff using string keys. Legacy un-named GPIOs are preserved by using a NULL name string - they are

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-25 Thread Daniel P. Berrange
On Thu, Apr 24, 2014 at 08:19:19AM +0200, Jan Kiszka wrote: On 2014-04-23 11:25, Stefan Hajnoczi wrote: Dear QEMU, Libvirt, and KVM communities, We are participating in Google Summer of Code 2014 (http://google-melange.com/) and Outreach Program for Women (http://opw.gnome.org/). Both

Re: [Qemu-devel] [PATCH 0/3] hw/arm/virt: Support Cortex-A57

2014-04-25 Thread Christoffer Dall
On Thu, Apr 24, 2014 at 06:54:40PM +0100, Peter Maydell wrote: This patchset wires up our new Cortex-A57 emulation into the virt machine model. Rather than the somewhat hacky approach in the previous system emulation patchsets, I've decided that our best approach is to have the board model

Re: [Qemu-devel] [PULL v2 2/2] usb: mtp filesharing

2014-04-25 Thread Gerd Hoffmann
Hi, +trace_usb_mtp_op_get_device_info(s-dev.addr); + +usb_mtp_add_u16(d, 0x0100); Sect. 5.1.1.1 says: This identifies the PTP version this device can support in hundredths. For MTP devices implemented under this specification, this shall contain the value 100

[Qemu-devel] [PATCH 1/4] hw: Consistently name Error * objects err, and not errp

2014-04-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/core/qdev-properties-system.c | 10 +- hw/dma/xilinx_axidma.c | 16 hw/net/xilinx_axienet.c | 16 3 files changed, 21 insertions(+), 21 deletions(-) diff --git

[Qemu-devel] [PATCH 4/4] arm: Clean up fragile use of error_is_set() in realize() methods

2014-04-25 Thread Markus Armbruster
Using error_is_set(ERRP) to find out whether a function failed is either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP may be null, because errors go undetected when it is. It's fragile when proving ERRP non-null involves a non-local argument. Else, it's unnecessarily opaque

[Qemu-devel] [PATCH 0/4] hw: Purge error_is_set()

2014-04-25 Thread Markus Armbruster
I got a private branch getting rid of it entirely. This is the fourth part, covering devices, except for two places I need to cover together with QAPI, in a future series. Could this one go through Andreas's tree? Markus Armbruster (4): hw: Consistently name Error * objects err, and not errp

[Qemu-devel] [PATCH 2/4] hw: Consistently name Error ** objects errp, and not err

2014-04-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/core/qdev.c | 20 ++-- hw/intc/i8259.c | 4 ++-- hw/timer/i8254.c | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 60f9df1..2fd5100 100644 ---

[Qemu-devel] [PATCH 3/4] qom: Clean up fragile use of error_is_set() in set() methods

2014-04-25 Thread Markus Armbruster
Using error_is_set(ERRP) to find out whether a function failed is either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP may be null, because errors go undetected when it is. It's fragile when proving ERRP non-null involves a non-local argument. Else, it's unnecessarily opaque

[Qemu-devel] [PATCH 5/9] usb: mtp: fix error path memory leak

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 775dc8d..45f9562 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -669,6 +669,7 @@ static MTPData *usb_mtp_get_object(MTPState

[Qemu-devel] [PATCH 2/9] usb: mtp: fix usb_mtp_add_u64

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 17df447..063a426 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -416,7 +416,7 @@ static void

[Qemu-devel] [PATCH 7/9] usb: mtp: avoid empty description string

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 82d5b64..536a23d 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1049,7 +1049,7 @@ static int

[Qemu-devel] [PATCH 1/9] usb: mtp: replace debug printfs with trace points

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 8 trace-events | 3 +++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 8b44032..17df447 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -294,7

[Qemu-devel] [PATCH 8/9] usb: mtp: drop data-out hexdump

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 536a23d..6bd6a82 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1014,8 +1014,7 @@ static void

[Qemu-devel] [PATCH 3/9] usb: mtp: fix version (is decimal not bcd)

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 063a426..dff2618 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -533,7 +533,7 @@ static MTPData

[Qemu-devel] [PATCH 0/9] usb: mtp: a bunch of fixes

2014-04-25 Thread Gerd Hoffmann
Hi, Here is a bunch of incremental fixes for the just merged usb mtp device, coming from patch review by Peter and Stefan. cheers, Gerd Gerd Hoffmann (9): usb: mtp: replace debug printfs with trace points usb: mtp: fix usb_mtp_add_u64 usb: mtp: fix version (is decimal not bcd) usb:

[Qemu-devel] [PATCH 9/9] usb: mtp: reply INCOMPLETE_TRANSFER on read errors

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 6bd6a82..8e1a1b7 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -50,6 +50,7 @@ enum mtp_code {

[Qemu-devel] [PATCH 6/9] usb: mtp: fix possible buffer overflow

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 45f9562..82d5b64 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -998,6 +998,9 @@ static void usb_mtp_handle_data(USBDevice

[Qemu-devel] [PATCH 4/9] usb: mtp: fix serial (must be exact 32 chars)

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index dff2618..775dc8d 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -548,7 +548,7 @@ static MTPData

Re: [Qemu-devel] [PULL v2 2/2] usb: mtp filesharing

2014-04-25 Thread Peter Wu
On Thursday 24 April 2014 17:01:47 Gerd Hoffmann wrote: PS: Funny thing that the reviews start coming in when I send pull requests. The patches have been on the list a few weeks back already (during 2.0 freeze, thats why the long delay between [patch] and [pull]). No comments.

Re: [Qemu-devel] [PATCH 1/4] hw: Consistently name Error * objects err, and not errp

2014-04-25 Thread Andreas Färber
Am 25.04.2014 12:44, schrieb Markus Armbruster: Signed-off-by: Markus Armbruster arm...@redhat.com Thanks a lot, Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB

Re: [Qemu-devel] [PATCH 2/4] hw: Consistently name Error ** objects errp, and not err

2014-04-25 Thread Andreas Färber
Am 25.04.2014 12:44, schrieb Markus Armbruster: Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/core/qdev.c | 20 ++-- hw/intc/i8259.c | 4 ++-- hw/timer/i8254.c | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Andreas Färber

Re: [Qemu-devel] [PATCH 6/9] usb: mtp: fix possible buffer overflow

2014-04-25 Thread Peter Wu
On Friday 25 April 2014 12:48:11 Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 45f9562..82d5b64 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c

Re: [Qemu-devel] [PATCH 9/9] usb: mtp: reply INCOMPLETE_TRANSFER on read errors

2014-04-25 Thread Peter Wu
On Friday 25 April 2014 12:48:14 Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 6bd6a82..8e1a1b7 100644 --- a/hw/usb/dev-mtp.c +++

Re: [Qemu-devel] [PATCH 0/3] hw/arm/virt: Support Cortex-A57

2014-04-25 Thread Peter Maydell
On 25 April 2014 11:42, Christoffer Dall christoffer.d...@linaro.org wrote: So we're adding an incompletely modelled A57 to the virt board, and adding a board mounted GICv2. Doesn't sound like something that could ever exist in real life, but I agree that the way we are tying things together,

Re: [Qemu-devel] [PATCH 4/4] arm: Clean up fragile use of error_is_set() in realize() methods

2014-04-25 Thread Andreas Färber
Am 25.04.2014 12:44, schrieb Markus Armbruster: Using error_is_set(ERRP) to find out whether a function failed is either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP may be null, because errors go undetected when it is. It's fragile when proving ERRP non-null involves a

Re: [Qemu-devel] [PATCH 0/9] usb: mtp: a bunch of fixes

2014-04-25 Thread Peter Wu
On Friday 25 April 2014 12:48:05 Gerd Hoffmann wrote: Hi, Here is a bunch of incremental fixes for the just merged usb mtp device, coming from patch review by Peter and Stefan. cheers, Gerd Gerd Hoffmann (9): usb: mtp: replace debug printfs with trace points usb: mtp: fix

Re: [Qemu-devel] [PATCH v3] ps2: set ps/2 output buffer size as the same as kernel

2014-04-25 Thread Gerd Hoffmann
On Do, 2014-04-24 at 20:06 +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com According to the PS/2 Mouse/Keyboard Protocol, the keyboard outupt buffer size is 16 bytes. And the PS2_QUEUE_SIZE 256 was introduced in Qemu from the very beginning. Hmm, seems there is

Re: [Qemu-devel] [PATCH v3 0/5] Add common QEMU control functionality to qemu-iotests

2014-04-25 Thread Jeff Cody
On Thu, Apr 10, 2014 at 04:47:35PM -0400, Jeff Cody wrote: Changes from v2: Updated Reviewed-by for Fam and Benoit (Benoit's from the v1 patch, I forgot to add those to v2) Patch 1: * updated commit message (Thanks Fam) * Addded '-machine accel=qtest' to qemu launch

Re: [Qemu-devel] [PATCH microblaze v1 1/1] net: xilinx_axienet.c: Add phy soft reset bit clearing

2014-04-25 Thread Stefan Hajnoczi
On Tue, Apr 08, 2014 at 06:52:39PM -0700, Peter Crosthwaite wrote: From: Nathan Rossi nathan.ro...@xilinx.com Clear the BMCR Reset when writing to registers. Signed-off-by: Nathan Rossi nathan.ro...@xilinx.com [ PC: * Trivial style fixes to commit message ] Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 4/4] arm: Clean up fragile use of error_is_set() in realize() methods

2014-04-25 Thread Peter Maydell
On 25 April 2014 12:25, Andreas Färber afaer...@suse.de wrote: I do wonder, and maybe Peter can comment as native speaker, whether it should be uses (plural) or usage in both subjects? In this subject I would consider all of use, uses and usage as acceptable variations. thanks -- PMM

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-25 Thread Andreas Färber
Am 25.04.2014 08:38, schrieb Markus Armbruster: Andreas Färber afaer...@suse.de writes: Am 24.04.2014 08:19, schrieb Jan Kiszka: On 2014-04-23 11:25, Stefan Hajnoczi wrote: Dear QEMU, Libvirt, and KVM communities, We are participating in Google Summer of Code 2014

[Qemu-devel] [PULL 0/4] current s390x queue

2014-04-25 Thread Cornelia Huck
repository at: https://github.com/cohuck/qemu.git tags/s390x-20140425 for you to fetch changes up to 44b0c0bbb50818e995702cf76d8e07dd36f479bf: s390x/kvm: sync gbea and pp register (2014-04-25 12:59:57 +0200) Some s390x patches

[Qemu-devel] [PULL 3/4] s390x/kvm: rework KVM synchronize to tracing for some ONEREGS

2014-04-25 Thread Cornelia Huck
From: Christian Borntraeger borntrae...@de.ibm.com Some ONE_REGS on s390 are not protected by a capability. Older kernels might not provide those and return an error. Fortunately these registers are only critical for the migration path. There is no need to error out on reset and normal runtime.

[Qemu-devel] [PULL 4/4] s390x/kvm: sync gbea and pp register

2014-04-25 Thread Cornelia Huck
From: Christian Borntraeger borntrae...@de.ibm.com We also need to sync guest breaking event address and program parameter register for migration support. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL 2/4] linux-headers update

2014-04-25 Thread Cornelia Huck
linux-headers update against v3.15-rc2 (a798c10f) Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- linux-headers/asm-s390/kvm.h | 24 linux-headers/linux/kvm.h| 17 + linux-headers/linux/vfio.h |6 ++ 3 files changed, 47

[Qemu-devel] [PULL 1/4] s390x: empty function stubs in preparation for __KVM_HAVE_GUEST_DEBUG

2014-04-25 Thread Cornelia Huck
From: David Hildenbrand d...@linux.vnet.ibm.com This patch creates empty function stubs (used by the gdbserver) in preparation for the hw debugging support by kvm on s390, which will enable the __KVM_HAVE_GUEST_DEBUG define in the linux headers and require these methods on the qemu side.

Re: [Qemu-devel] [PATCH 3/5] gtk: Fix -serial vc

2014-04-25 Thread Andreas Färber
Am 24.04.2014 19:35, schrieb Cole Robinson: Try kicking off a rhel5 text install over serial, the text menu navigation is all messed up, and some of the kernel boot messages are randomly corrupted. Drop use of a pty and just use vte infrastructure for reading and writing. This fixes the

Re: [Qemu-devel] [PATCH 9/9] usb: mtp: reply INCOMPLETE_TRANSFER on read errors

2014-04-25 Thread Gerd Hoffmann
Hi, The bogus data packet is sent with usb_packet_copy, shouldn't you return USB_RET_NAK for now? I don't think so. The transfer must be completed, even if we don't send valid data, because the guest expects a certain number of data bytes before the result packet with the status code. If

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-25 Thread Thomas Huth
Hi Alex, On Thu, 24 Apr 2014 18:36:18 +0200 Alexander Graf ag...@suse.de wrote: On 24.04.14 17:34, Jens Freimann wrote: From: Thomas Huth th...@linux.vnet.ibm.com With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. ... diff

Re: [Qemu-devel] [PATCH RFC qom-next for-next v2 6/6] pci: Move VMSTATE_MSIX() into vmstate_pci_device

2014-04-25 Thread Dmitry Fleytman
On Apr 16, 2014, at 17:22 PM, Andreas Färber afaer...@suse.de wrote: Am 02.09.2013 13:31, schrieb Michael S. Tsirkin: On Mon, Jul 29, 2013 at 02:27:01AM +0200, Andreas Färber wrote: Use it conditional on msix_present() and drop msix_{save,load}() calls following pci_device_{save,load}().

[Qemu-devel] [PULL 2/2] linux-user: Add support for SCM_CREDENTIALS.

2014-04-25 Thread Huw Davies
Signed-off-by: Huw Davies h...@codeweavers.com --- linux-user/syscall.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index cf4372e..e9ae9c5 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1269,6 +1269,17 @@ static

[Qemu-devel] [PULL 0/2] linux-user: Add support for SCM_CREDENTIALS.

2014-04-25 Thread Huw Davies
This set has been on the mailing list unreviewed for more than a week. It implements copying of the SCM_CREDENTIALS msg payload. Patch 1 changes an if-else block to a more expandable switch block. Patch 2 is the actual implementation. The following changes since commit

[Qemu-devel] [PULL 1/2] linux-user: Move if-elses to a switch statement.

2014-04-25 Thread Huw Davies
This makes adding more message types cleaner. Signed-off-by: Huw Davies h...@codeweavers.com --- linux-user/syscall.c | 51 +-- 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index

Re: [Qemu-devel] [GSoC] Wanted: small warmup tasks

2014-04-25 Thread Andreas Färber
Am 25.04.2014 11:22, schrieb Peter Crosthwaite: On Fri, Apr 25, 2014 at 5:55 PM, Marc Marí marc.mari.barc...@gmail.com wrote: I'm now looking at the conditional fprintf's. I'll need a bit of help later in sending the patches :D. For starters, please use plain text format mails and don't

Re: [Qemu-devel] [PULL 3/4] s390x/kvm: rework KVM synchronize to tracing for some ONEREGS

2014-04-25 Thread Alexander Graf
On 25.04.14 14:02, Cornelia Huck wrote: From: Christian Borntraeger borntrae...@de.ibm.com Some ONE_REGS on s390 are not protected by a capability. Older kernels might not provide those and return an error. Fortunately these registers are only critical for the migration path. There is no need

Re: [Qemu-devel] [PATCH 3/5] gtk: Fix -serial vc

2014-04-25 Thread Gerd Hoffmann
-qemu_chr_be_write(vc-chr, buffer, len); +VirtualConsole *vc = user_data; Gerd, can we retain the white line here please? :) Andreas +qemu_chr_be_write(vc-chr, (uint8_t *)text, (unsigned int)size); Fixed in my local copy. cheers, Gerd

Re: [Qemu-devel] [PULL 3/4] s390x/kvm: rework KVM synchronize to tracing for some ONEREGS

2014-04-25 Thread Alexander Graf
On 25.04.14 14:24, Christian Borntraeger wrote: On 25/04/14 14:04, Alexander Graf wrote: On 25.04.14 14:02, Cornelia Huck wrote: From: Christian Borntraeger borntrae...@de.ibm.com Some ONE_REGS on s390 are not protected by a capability. Older kernels might not provide those and return an

Re: [Qemu-devel] [PATCH v25 10/31] QemuOpts: check NULL input for qemu_opts_del

2014-04-25 Thread Stefan Hajnoczi
On Fri, Apr 11, 2014 at 01:54:06AM +0800, Chunyan Liu wrote: To simplify later using of qemu_opts_del, accept NULL input. Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Chunyan Liu cy...@suse.com --- util/qemu-option.c | 4 1 file changed, 4 insertions(+) Reviewed-by:

Re: [Qemu-devel] [PULL 00/16] Block patches

2014-04-25 Thread Peter Maydell
On 23 April 2014 11:04, Kevin Wolf kw...@redhat.com wrote: The following changes since commit 2d03b49c3f225994c4b0b46146437d8c887d6774: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140417-1' into staging (2014-04-17 21:37:26 +0100) are available in the git

Re: [Qemu-devel] [PULL 3/4] s390x/kvm: rework KVM synchronize to tracing for some ONEREGS

2014-04-25 Thread Christian Borntraeger
On 25/04/14 14:04, Alexander Graf wrote: On 25.04.14 14:02, Cornelia Huck wrote: From: Christian Borntraeger borntrae...@de.ibm.com Some ONE_REGS on s390 are not protected by a capability. Older kernels might not provide those and return an error. Fortunately these registers are only

Re: [Qemu-devel] [PATCH] mirror: Check for bdrv_get_info result

2014-04-25 Thread Stefan Hajnoczi
On Fri, Apr 25, 2014 at 02:50:29PM +0800, Fam Zheng wrote: bdrv_get_info could fail. Add check before using the returned value. Signed-off-by: Fam Zheng f...@redhat.com --- block/mirror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/mirror.c

Re: [Qemu-devel] [PATCH 3/3] s390x/helper: Added format control bit to MMU translation

2014-04-25 Thread Alexander Graf
On 25.04.14 14:15, Thomas Huth wrote: Hi Alex, On Thu, 24 Apr 2014 18:36:18 +0200 Alexander Graf ag...@suse.de wrote: On 24.04.14 17:34, Jens Freimann wrote: From: Thomas Huth th...@linux.vnet.ibm.com With the EDAT-1 facility, the MMU translation can stop at the segment table already,

Re: [Qemu-devel] [PATCH v2 1/2] qapi: fix coding style in parameters list

2014-04-25 Thread Eric Blake
On 04/25/2014 01:56 AM, Amos Kong wrote: The space before point is redundant. Would sound better as: A space after * when declaring a pointer type is redundant. Signed-off-by: Amos Kong ak...@redhat.com --- scripts/qapi-visit.py | 20 ++-- 1 file changed, 10

Re: [Qemu-devel] [PULL 0/2] linux-user: Add support for SCM_CREDENTIALS.

2014-04-25 Thread Andreas Färber
Am 25.04.2014 14:19, schrieb Huw Davies: This set has been on the mailing list unreviewed for more than a week. It implements copying of the SCM_CREDENTIALS msg payload. Patch 1 changes an if-else block to a more expandable switch block. Patch 2 is the actual implementation. a) Patches

Re: [Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space

2014-04-25 Thread Eric Blake
On 04/25/2014 01:56 AM, Amos Kong wrote: Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for points by the coding style. s/points/pointers/ char * value; ^ qapi_free_NameInfo(NameInfo * obj)

Re: [Qemu-devel] [PATCH v25 30/31] cleanup QEMUOptionParameter

2014-04-25 Thread Stefan Hajnoczi
On Fri, Apr 11, 2014 at 01:54:26AM +0800, Chunyan Liu wrote: Now that all backend drivers are using QemuOpts, remove all QEMUOptionParameter related codes. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block.c | 86

Re: [Qemu-devel] 答复: report a suspect bug about arm gic

2014-04-25 Thread Christoffer Dall
On Wed, Apr 16, 2014 at 02:46:52AM +, zhuxiaodong wrote: I don't doubt about the algorithm of level interrupts. The problem may come from the level value tested by GIC_TEST_LEVEL(irq, cm). It is set in gic_set_irq_generic(): 115 static void gic_set_irq_generic(GICState *s, int irq, int

  1   2   3   >