Il 26/04/2014 21:36, Kevin O'Connor ha scritto:
Yes, I was thinking of something like that as well. If QEMU
internally observes the formula above, then something like the patch
below should work instead of my original patch.
However, I'm not an expert on QEMU TCG and the patch below would
Il 27/04/2014 04:33, Jun Koi ha scritto:
On Sat, Apr 26, 2014 at 4:50 PM, Paolo Bonzini pbonz...@redhat.com
mailto:pbonz...@redhat.com wrote:
Il 25/04/2014 20:13, Shehbaz Jaffer ha scritto:
Hi,
Are you talking about running KVM(hardware virtualization) enabled
On 27 April 2014 02:09, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote:
On Fri, Apr 25, 2014 at 3:54 AM, Peter Maydell peter.mayd...@linaro.org
wrote:
Rather than having the virt machine model create an a15mpcore_priv
device regardless of the actual CPU type in order to instantiate the
On 04/21/2014 12:09 PM, Michael Tokarev wrote:
21.04.2014 13:01, Michael Tokarev wrote:
libtool has an argument for .syms file, which is -export-symbols.
There's no argument `-export-syms', and it looks like at least on
linux, -export-syms is just ignored. Use the correct argument,
27.04.2014 12:05, Alon Levy wrote:
On 04/21/2014 12:09 PM, Michael Tokarev wrote:
21.04.2014 13:01, Michael Tokarev wrote:
libtool has an argument for .syms file, which is -export-symbols.
There's no argument `-export-syms', and it looks like at least on
linux, -export-syms is just ignored.
On Fri, Apr 25, 2014 at 10:17:36AM +0200, Kevin Wolf wrote:
Am 25.04.2014 um 08:29 hat Markus Armbruster geschrieben:
Michael S. Tsirkin m...@redhat.com writes:
On Thu, Apr 24, 2014 at 12:43:56PM +0200, Kevin Wolf wrote:
Am 24.04.2014 um 09:55 hat Michael S. Tsirkin geschrieben:
On
Il 22/04/2014 13:39, Dr. David Alan Gilbert ha scritto:
I agree. In many cases, _TEST is a huge review warning sign that
subsections should have been used instead.
I can see how the subsections should be used in some cases, but I've
come across at least one case where _TEST was used to
On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote:
If guest driver behaves abnormally, emulation code could mark the device
as broken.
Once broken is set, device emulation will typically wait for a reset
command and ignore any other operations, but it could also return error
On 27 April 2014 09:29, Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote:
If guest driver behaves abnormally, emulation code could mark the device
as broken.
Once broken is set, device emulation will typically wait for a reset
command and
On Fri, 2014-04-25 at 22:03 +0200, Andreas Färber wrote:
Am 09.04.2014 19:34, schrieb Marcel Apfelbaum:
This minimizes QEMUMachine usage, as part of machine QOM-ification.
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
include/hw/xen/xen.h| 2 +-
Il 15/04/2014 01:55, Michael R. Hines ha scritto:
Paolo? I see that some of the block-migration code and the qemu-img code
is also
calling buffer_is_zero() - are you guys depending on the performance of any
buffer_is_zero() calls to use the vector-optimized version like
migration does?
Yes,
On Sun, Apr 27, 2014 at 09:34:06AM +0100, Peter Maydell wrote:
On 27 April 2014 09:29, Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote:
If guest driver behaves abnormally, emulation code could mark the device
as broken.
Once broken is
18.04.2014 00:31, Stefan Weil wrote:
The Q of the logo is already included in pc-bios/qemu_logo_no_text.svg.
This file now adds the complete logo as it was designed by Benoît Canet.
Benoît licensed it under CC-BY 3.0, see
http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02865.html.
On Sat, 2014-04-26 at 00:30 +0200, Andreas Färber wrote:
Am 09.04.2014 19:34, schrieb Marcel Apfelbaum:
This is a continuation of 'QEMU Machine as QOM object' effort.
The scope of this series is to allow machine QOM-ification
of all machines gradually, by removing the need for
Il 19/04/2014 07:24, Shiru Ren ha scritto:
Thanks for your answer. It really helped me a lot. However, it cloud be
really helpful if you cloud explain how the SIG_IPI signal causes the
CPU thread to exit the vcpu thread in KVM mode. Is it like an interrupt,
causes a VM exit immediately? Or KVM
Thanks, applied to the trivial queue, with subject tweak.
20.04.2014 01:00, Paolo Bonzini wrote:
Il 19/04/2014 13:39, Mike Frysinger ha scritto:
From: Tim Comer com...@gmail.com
The current code calls accept() without initializing the size parameter
which means the accept call might write too much to the stack.
Applied to -trivial, thanks!
/mjt
Il 14/04/2014 16:47, Paul Moore ha scritto:
Yes. Also the commits don't have your signed-off-by:
so I can't apply it.
Eduardo?
It is absurd that we have had two fixes held up this long for such silly
things.
It's not silly, see http://lwn.net/Articles/592503/ for more information.
Paolo
Il 14/04/2014 17:16, Andreas Färber ha scritto:
Huh?! If you ever tried changing the order of PCI devices such as
virtio-blk-pci on the command line (or changing between if=virtio and
-device virtio-blk-pci) then surely it does change the order of the
/dev/vdX the guest sees and will be
The Sunday 27 Apr 2014 à 13:06:46 (+0400), Michael Tokarev wrote :
18.04.2014 00:31, Stefan Weil wrote:
The Q of the logo is already included in pc-bios/qemu_logo_no_text.svg.
This file now adds the complete logo as it was designed by Benoît Canet.
Benoît licensed it under CC-BY 3.0, see
10.04.2014 18:07, Kirill Batuzov wrote:
Fields name (created with strdup in new_entry) and pathname
(created with g_strdup_printf in new_entry) of pathelem struct should
be freed before the whole struct is.
Applied to -trivial, thanks!
The fun thing here is that the code _looks_ correct. I
09.04.2014 21:49, Baojun Wang wrote:
I found this could be useful to have qemu-softmmu as a cross debugger (launch
with -s -S command line option), then if we can have a command to load guest
physical memory, we can use cross gdb to do some target debug which gdb cannot
do directly.
Many
18.04.2014 15:55, Stefan Weil wrote:
Use an absolute value for SRC_PATH. This fixes a build problem:
$ LANG=C make -C po update
make: Entering directory `/qemu/po'
GEN ../po/messages.po
/bin/sh: 1: cannot create ../po/messages.po: Directory nonexistent
make: *** [../po/messages.po]
Il 27/04/2014 10:10, Michael Tokarev ha scritto:
qemu_mutex_lock
qemu_mutex_unlock
qemu_cond_wait
qemu_cond_signal
qemu_thread_create
socket_init
qemu_socket
qemu_mutex_init
qemu_cond_init
So it looks like a preparation patch is needed before this one, to
ensure bisectability.
Am 27.04.2014 11:37, schrieb Michael Tokarev:
How about moving it below inclusion of config-host.mak and using something
like
SRC_PATH ?= $(realpath ..)
? I dunno how gnu'ish this construct is... :)
However, I think I've a better fix for this:
Author: Michael Tokarev
Signed-off-by: Hani Benhabiles h...@linux.com
---
Not sure whether the qobject stringifying functions could fit or be of some use
elsewhere. Thus, I kept them as static near the only place where they are used
at the moment.
hmp-commands.hx | 2 +
hmp.c | 143
18.04.2014 16:15, Stefan Weil wrote:
Most changes were caused by line changes in ui/gtk.c and updated
automatically by running make -C po update.
In addition, the header entry Language was fixed, see this reference:
http://www.gnu.org/software/gettext/manual/html_node/Header-Entry.html.
A few more cleanups for .gitignore file.
The final goal is to have only files in there which
are generated during build. Things like .orig or
.gdbinit are definitely not generated during build.
Also, anchor a few more build-time directories.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
On Sun, Apr 27, 2014 at 10:26:30AM +0200, Paolo Bonzini wrote:
Il 22/04/2014 13:39, Dr. David Alan Gilbert ha scritto:
I agree. In many cases, _TEST is a huge review warning sign that
subsections should have been used instead.
I can see how the subsections should be used in some cases,
Hi,
On Fri, Apr 25, 2014 at 02:42:14PM +0100, Huw Davies wrote:
This makes adding more message types cleaner.
Signed-off-by: Huw Davies address@hidden
---
linux-user/syscall.c | 51
+--
1 file changed, 33 insertions(+), 18
On Sat, 2014-04-26 at 11:06 +0200, Paolo Bonzini wrote:
Il 25/04/2014 19:17, Kevin O'Connor ha scritto:
The current SMI interrupt handler is being run with the same CPL as
the code it interrupts. If the existing code is running with CPL=3,
then the SMI handler can cause spurious
On Sun, Apr 27, 2014 at 3:05 PM, Paolo Bonzini pbonz...@redhat.com wrote:
Il 27/04/2014 04:33, Jun Koi ha scritto:
On Sat, Apr 26, 2014 at 4:50 PM, Paolo Bonzini pbonz...@redhat.com
mailto:pbonz...@redhat.com wrote:
Il 25/04/2014 20:13, Shehbaz Jaffer ha scritto:
Hi,
27.04.2014 13:54, Paolo Bonzini wrote:
Il 27/04/2014 10:10, Michael Tokarev ha scritto:
[]
Well. vscclient explicitly uses them in the code, but only links with
libcacard, not with other qemu objects. So adding proper qemu objects
here should be fine. I can take care of that.
On the
- Messaggio originale -
Da: Michael Tokarev m...@tls.msk.ru
A: Paolo Bonzini pbonz...@redhat.com, Alon Levy al...@redhat.com
Cc: qemu-devel@nongnu.org
Inviato: Domenica, 27 aprile 2014 14:59:45
Oggetto: Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file
27.04.2014
oh great! do we suppport EPT, VCMS shadow yet?
No nested page tables, and VMCS shadow is only supported by Intel
processors not AMD.
Oh, I always think that without EPT, it would not be possible to have
nested VMX. Am I wrong here?
No, it's just slower. The nested hypervisor uses
27.04.2014 17:35, Paolo Bonzini пишет:
- Messaggio originale -
Da: Michael Tokarev m...@tls.msk.ru
A: Paolo Bonzini pbonz...@redhat.com, Alon Levy al...@redhat.com
Cc: qemu-devel@nongnu.org
Inviato: Domenica, 27 aprile 2014 14:59:45
Oggetto: Re: [Qemu-devel] [PATCH] libcacard:
We use default sndbuf (INT_MAX) if user assigns an invalid sndbuf.
This patch just added an error note.
Signed-off-by: Amos Kong ak...@redhat.com
---
net/tap-linux.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/net/tap-linux.c b/net/tap-linux.c
index
Il 27/04/2014 15:53, Michael Tokarev ha scritto:
So, what do we do here? Should we actually enable proper exporting?
Yes, definitely. If you don't want libqemuutil/libqemustub, you can
rewrite things to use GLib instead of the handful of libqemuutil symbols
that vscclient actually needs.
On Sun, Apr 27, 2014 at 10:09:10PM +0800, Amos Kong wrote:
We use default sndbuf (INT_MAX) if user assigns an invalid sndbuf.
This patch just added an error note.
Signed-off-by: Amos Kong ak...@redhat.com
---
net/tap-linux.c | 13 ++---
1 file changed, 10 insertions(+), 3
27.04.2014 18:14, Paolo Bonzini wrote:
Il 27/04/2014 15:53, Michael Tokarev ha scritto:
So, what do we do here? Should we actually enable proper exporting?
Yes, definitely. If you don't want libqemuutil/libqemustub, you can rewrite
things to use GLib instead of the handful of libqemuutil
Il 27/04/2014 14:22, Marcel Apfelbaum ha scritto:
On Sat, 2014-04-26 at 11:06 +0200, Paolo Bonzini wrote:
Il 25/04/2014 19:17, Kevin O'Connor ha scritto:
The current SMI interrupt handler is being run with the same CPL as
the code it interrupts. If the existing code is running with CPL=3,
libtool has an argument for .syms file, which is -export-symbols.
There's no argument `-export-syms', and it looks like at least on
linux, -export-syms is just ignored. Use the correct argument,
-export-symbols, to actually get the right export list.
But it turns out that vscclient binary, which
On 04/27/2014 05:37 PM, Michael Tokarev wrote:
libtool has an argument for .syms file, which is -export-symbols.
There's no argument `-export-syms', and it looks like at least on
linux, -export-syms is just ignored. Use the correct argument,
-export-symbols, to actually get the right export
27.04.2014 18:53, Alon Levy wrote:
On 04/27/2014 05:37 PM, Michael Tokarev wrote:
libtool has an argument for .syms file, which is -export-symbols.
There's no argument `-export-syms', and it looks like at least on
linux, -export-syms is just ignored. Use the correct argument,
Am 27.04.2014 16:37, schrieb Michael Tokarev:
libtool has an argument for .syms file, which is -export-symbols.
There's no argument `-export-syms', and it looks like at least on
linux, -export-syms is just ignored. Use the correct argument,
-export-symbols, to actually get the right export
Hello!
I would like to pass through my VGA card to KVM and use to accelerate 3D,
however everytime Windows complains about the assigned device showing error
43 in device manager. No matter I try to assign it using q35 and VFIO or pc
and legacy pci-assign, the result is the same all the time.
The
Il 22/04/2014 09:01, Peter Maydell ha scritto:
On 22 April 2014 03:42, Paolo Bonzini pbonz...@redhat.com wrote:
Il 21/04/2014 18:08, Peter Maydell ha scritto:
If we take an exception while the E bit is set we'll now incorrectly
start executing the exception handler in big-endian mode.
Do not include any qemu headers in vscclient.c, only use system
and glib headers. The file becomes quite a bit lager because
it now has more #includes and small portability functions,
but this way it is much more stand-alone and independent.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
On 27 April 2014 16:28, Paolo Bonzini pbonz...@redhat.com wrote:
Il 22/04/2014 09:01, Peter Maydell ha scritto:
Note that SCTLR.EE also sets the endianness for loads done
for translation table walks and so on.
I guess also v7m_push and v7m_pop.
Well, not really. v7M handles endianness
Signed-off-by: Hani Benhabiles h...@linux.com
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 23 +++
3 files changed, 25 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 8c93e61..648400a 100644
--- a/hmp-commands.hx
+++
Signed-off-by: Hani Benhabiles h...@linux.com
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 32 +++-
3 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 4c4d261..b3f45d6 100644
---
Also update the command's documentation.
Signed-off-by: Hani Benhabiles h...@linux.com
---
hmp-commands.hx | 3 ++-
hmp.h | 1 +
monitor.c | 15 +++
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index
Signed-off-by: Hani Benhabiles h...@linux.com
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 26 ++
3 files changed, 28 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 73fbe54..f10f52f 100644
--- a/hmp-commands.hx
+++
String -3 will be wrongly converted to -34 by strtosz_suffix().
strtosz_suffix_unit() only returns integer in success situation.
Signed-off-by: Amos Kong ak...@redhat.com
---
qapi/opts-visitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/opts-visitor.c
Il 11/04/2014 14:27, Eric Blake ha scritto:
But with just this patch, you have caused the situation where it is
neither introspectible, nor consistent across qemu versions. The only
way to code that up in libvirt is to do MULTIPLE version checks and
correlate it with architecture checks - and
Signed-off-by: Hani Benhabiles h...@linux.com
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 24 +---
3 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index b3f45d6..ba13997 100644
--- a/hmp-commands.hx
Replace QemuMutex with GMutex and QemuCond with GCond
(with corresponding function changes), to make libcacard
independent of qemu internal functions.
After this step, none of libcacard internals use any
qemu-provided symbols. Maybe it's a good idea to
stop including qemu-common.h internally
Compared to the larger series sent before:
* Patches 01-03 are already in qmp branch.
* Added patches to convert sendkey, help/? to use new completion callback.
* Dropped patch 06 (cpu index completion) as deemed not useful enough.
* netdev_add now uses the same values array as qapi instead of
27.04.2014 19:11, Andreas Färber wrote:
Am 27.04.2014 16:37, schrieb Michael Tokarev:
libtool has an argument for .syms file, which is -export-symbols.
There's no argument `-export-syms', and it looks like at least on
linux, -export-syms is just ignored. Use the correct argument,
Make it possible to query all net clients without specifying an ID when calling
qemu_find_net_clients_except().
This also adds the add_completion_option() function which is to be used for
other commands completions as well.
Signed-off-by: Hani Benhabiles h...@linux.com
---
hmp-commands.hx | 1
Signed-off-by: Hani Benhabiles h...@linux.com
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 23 +++
3 files changed, 25 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index ba13997..8c93e61 100644
--- a/hmp-commands.hx
+++
25.04.2014 21:24, Peter Maydell wrote:
On 25 April 2014 09:13, Dmitry Poletaev poletaev-q...@yandex.ru wrote:
Emulated program can execute that test and after that
can understand environment not real.
It is always going to be possible to determine that you're
running on an emulator rather
On Sun, Apr 27, 2014 at 08:10:39AM +0200, Paolo Bonzini wrote:
Il 26/04/2014 21:36, Kevin O'Connor ha scritto:
Yes, I was thinking of something like that as well. If QEMU
internally observes the formula above, then something like the patch
below should work instead of my original patch.
On 27 April 2014 17:46, Michael Tokarev m...@tls.msk.ru wrote:
25.04.2014 21:24, Peter Maydell wrote:
It is always going to be possible to determine that you're
running on an emulator rather than real hardware, so changing
QEMU behaviour just for this is uninteresting. If QEMU
behaves
On Sun, Apr 27, 2014 at 05:20:28PM +0300, Michael S. Tsirkin wrote:
On Sun, Apr 27, 2014 at 10:09:10PM +0800, Amos Kong wrote:
We use default sndbuf (INT_MAX) if user assigns an invalid sndbuf.
This patch just added an error note.
Signed-off-by: Amos Kong ak...@redhat.com
---
On Mon, Apr 28, 2014 at 01:03:04AM +0800, Amos Kong wrote:
On Sun, Apr 27, 2014 at 05:20:28PM +0300, Michael S. Tsirkin wrote:
On Sun, Apr 27, 2014 at 10:09:10PM +0800, Amos Kong wrote:
We use default sndbuf (INT_MAX) if user assigns an invalid sndbuf.
This patch just added an error note.
On Sun, Apr 27, 2014 at 04:29:25PM +0200, Paolo Bonzini wrote:
Il 27/04/2014 14:22, Marcel Apfelbaum ha scritto:
On Sat, 2014-04-26 at 11:06 +0200, Paolo Bonzini wrote:
KVM computes the CPL as follows:
if (CR0.PE == 0)
return 0;
if (!EFER.LMA EFLAGS.VM)
return 3;
return
On Sun, Apr 27, 2014 at 08:10:39AM +0200, Paolo Bonzini wrote:
Il 26/04/2014 21:36, Kevin O'Connor ha scritto:
Yes, I was thinking of something like that as well. If QEMU
internally observes the formula above, then something like the patch
below should work instead of my original patch.
On 27.04.14 18:16, Paolo Bonzini wrote:
Il 11/04/2014 14:27, Eric Blake ha scritto:
But with just this patch, you have caused the situation where it is
neither introspectible, nor consistent across qemu versions. The only
way to code that up in libvirt is to do MULTIPLE version checks and
On Sun, Apr 27, 2014 at 01:45:24PM -0400, Kevin O'Connor wrote:
On Sun, Apr 27, 2014 at 08:10:39AM +0200, Paolo Bonzini wrote:
Il 26/04/2014 21:36, Kevin O'Connor ha scritto:
Yes, I was thinking of something like that as well. If QEMU
internally observes the formula above, then something
** Changed in: qemu
Status: New = In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1310324
Title:
Commit 0f842f8a introduces regression when using tcg-interpreter
Status in QEMU:
I can reproduce a similar problem when running the latest ReactOS live
CD from http://downloads.sourceforge.net/reactos/ReactOS-0.3.16-REL-
live.zip and see the regression caused by the same commit.
It can be fixed by a small modification in cputlb.c: replace GETPC by
GETRA in these two lines
** Changed in: qemu
Status: New = Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1276847
Title:
Build fails on latest MinGW
Status in QEMU:
Invalid
Bug description:
I've run
** Changed in: qemu
Status: New = Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1298442
Title:
build problem in qemu-2.0.0-rc0 No rule to make target `trace
I can confirm that your change fixes my problem as well. Thank you very
much!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1310324
Title:
Commit 0f842f8a introduces regression when using
This series implements Named GPIOs on the qdev level. Patch 1 is the
feature presentation.
Second patch I give a useful example of the features use (an SSI
cleanup).
Changed since v1:
use QLIST (AF review)
Dropped former P1 (too far out of scope)
Peter Crosthwaite (2):
qdev: Implement named
Implement named GPIOs on the Device layer. Listifies the existing GPIOs
stuff using string keys. Legacy un-named GPIOs are preserved by using
a NULL name string - they are just a single matchable element in the
name list.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
changed
To get it out of the default GPIO list. This allows child devices to
use the un-named GPIO namespace without having to be SSI aware. That
is, there is no more need for machines to know about the obscure
policy where GPIO 0 is the SSI chip-select and GPIO 1..N are the
concrete class GPIOs (defined
On Fri, 04/25 14:18, Jeff Cody wrote:
On Wed, Apr 23, 2014 at 12:04:49PM +0200, Kevin Wolf wrote:
From: Fam Zheng f...@redhat.com
Previously, when there is a user error in argv parsing, qemu-img prints
help text and exits.
Add an error_exit function to print a helpful error message
On Sun, 04/27 11:59, Michael S. Tsirkin wrote:
On Sun, Apr 27, 2014 at 09:34:06AM +0100, Peter Maydell wrote:
On 27 April 2014 09:29, Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng wrote:
If guest driver behaves abnormally, emulation code
On Thu, Feb 13, 2014 at 5:22 AM, Peter Maydell peter.mayd...@linaro.org wrote:
On 12 February 2014 03:36, Peter Crosthwaite
peter.crosthwa...@xilinx.com wrote:
By just ignoring them and trying again later. This handles the
EGAIN case properly (the previous implementation was only dealing
with
On Fri, 04/25 14:20, Stefan Hajnoczi wrote:
On Fri, Apr 25, 2014 at 02:50:29PM +0800, Fam Zheng wrote:
bdrv_get_info could fail. Add check before using the returned value.
Signed-off-by: Fam Zheng f...@redhat.com
---
block/mirror.c | 4 ++--
1 file changed, 2 insertions(+), 2
Hi,
Il 26/04/2014 10:56, Gonglei (Arei) ha scritto:
Public bug reported:
I want to repeated hot-plug/unplug the virtio-net in the latest qemu
upstream
(commit 839a5547574e57cce62f49bfc50fe1f04b00589a), but I am failed at
the
second time hot plug the virtio-net to guest.
Then I
bdrv_get_info could fail. Add check before using the returned value.
Signed-off-by: Fam Zheng f...@redhat.com
---
V2: Handle error case (Stefan).
Signed-off-by: Fam Zheng f...@redhat.com
---
block/mirror.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/mirror.c
On Mon, Apr 28, 2014 at 09:58:53AM +0800, Fam Zheng wrote:
On Sun, 04/27 11:59, Michael S. Tsirkin wrote:
On Sun, Apr 27, 2014 at 09:34:06AM +0100, Peter Maydell wrote:
On 27 April 2014 09:29, Michael S. Tsirkin m...@redhat.com wrote:
On Tue, Apr 22, 2014 at 04:55:15PM +0800, Fam Zheng
Although bdrv_getlength() was just called above this, and checked for
error, it is better to just use the value we already get, and use
DIV_ROUND_UP.
Signed-off-by: Fam Zheng f...@redhat.com
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c
Hi Amos:
Thanks for replying.
I'm ok with the patch idea.
On Sat, Apr 26, 2014 at 06:19:12PM +0800, zhanghailiang wrote:
For e1000/rtl8139, qemu can still send/receive packets when VM is paused.
^
-
isn't running
On Sat, Apr 26, 2014 at 9:04 PM, Peter Maydell peter.mayd...@linaro.org
wrote:
On 26 April 2014 11:44, Amos Kong ak...@redhat.com wrote:
I'm ok with the patch idea.
On Sat, Apr 26, 2014 at 06:19:12PM +0800, zhanghailiang wrote:
For e1000/rtl8139, qemu can still send/receive packets
On Mon, Apr 14, 2014 at 10:57 AM, Alistair Francis
alistair.fran...@xilinx.com wrote:
On Fri, Apr 11, 2014 at 7:13 PM, Peter Crosthwaite
peter.crosthwa...@xilinx.com wrote:
On Fri, Apr 11, 2014 at 5:55 PM, Peter Maydell peter.mayd...@linaro.org
wrote:
On 11 April 2014 07:34, Alistair Francis
On Sun, Apr 27, 2014 at 08:16:58PM +0300, Michael S. Tsirkin wrote:
On Mon, Apr 28, 2014 at 01:03:04AM +0800, Amos Kong wrote:
On Sun, Apr 27, 2014 at 05:20:28PM +0300, Michael S. Tsirkin wrote:
On Sun, Apr 27, 2014 at 10:09:10PM +0800, Amos Kong wrote:
We use default sndbuf (INT_MAX) if
On Mon, Apr 28, 2014 at 12:06:49PM +0800, Amos Kong wrote:
On Sun, Apr 27, 2014 at 08:16:58PM +0300, Michael S. Tsirkin wrote:
On Mon, Apr 28, 2014 at 01:03:04AM +0800, Amos Kong wrote:
On Sun, Apr 27, 2014 at 05:20:28PM +0300, Michael S. Tsirkin wrote:
On Sun, Apr 27, 2014 at 10:09:10PM
On Mon, Apr 28, 2014 at 12:16:02AM +0800, Amos Kong wrote:
String -3 will be wrongly converted to -34 by strtosz_suffix().
strtosz_suffix_unit() only returns integer in success situation.
Signed-off-by: Amos Kong ak...@redhat.com
Looks correct to me.
nitpick: while not introduced by this
From: Stefan Weil s...@weilnetz.de
These functions don't need type casts (as does cpu_physical_memory_rw)
and also make the code better readable.
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
cpus.c |2 +-
From: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
Reviewed-by: Andreas Färber afaer...@suse.de
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Igor Mammedov imamm...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
Here's another trivial-patches pull request. I removed all
questionable or still-being-discussed patchses from there
which accumulated recently.
What's left are either code cleanups and rearrangements,
spelling fixes or --help output improvements, adding Qemu
logo file, one feature patch which's
A few more cleanups for .gitignore file.
The final goal is to have only files in there which
are generated during build. Things like .orig or
.gdbinit are definitely not generated during build.
Also, anchor a few more build-time directories.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
From: Igor Mammedov imamm...@redhat.com
Adds option to -m
size - startup memory amount
For compatibility with legacy CLI if suffix-less number is passed,
it assumes amount in Mb.
Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
Signed-off-by: Igor Mammedov
From: Laszlo Ersek ler...@redhat.com
Also sort the test-* entries in the latter.
Signed-off-by: Laszlo Ersek ler...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
.gitignore |9 -
tests/.gitignore | 11 +--
2 files changed, 9 insertions(+), 11
From: Fam Zheng f...@redhat.com
Old:
There are two paths to show help and exit 1, one is with -h or
--help, one is with invalid options.
New:
Show help and exit 0 for --help.
On invalid option, don't show the long help and bury the early ERROR:
line, just give a message pointing to --help.
From: Igor Ryzhov iryz...@arccn.ru
Signed-off-by: Igor Ryzhov iryz...@arccn.ru
Reviewed-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
net/net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index
1 - 100 of 115 matches
Mail list logo
