Re: [Qemu-devel] [PATCH v25 11/31] change block layer to support both QemuOpts and QEMUOptionParamter

2014-04-28 Thread Chun Yan Liu
On 4/23/2014 at 02:44 PM, in message 53576153.6CE : 102 : 21807, Chun Yan Liu wrote: On 4/22/2014 at 07:17 AM, in message 5355a71e.2010...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 04/10/2014 11:54 AM, Chunyan Liu wrote: Change block layer to support both QemuOpts

Re: [Qemu-devel] [PATCH v25 31/31] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList

2014-04-28 Thread Chun Yan Liu
On 4/25/2014 at 09:43 PM, in message 20140425134327.gi3...@stefanha-thinkpad.redhat.com, Stefan Hajnoczi stefa...@redhat.com wrote: On Fri, Apr 11, 2014 at 01:54:27AM +0800, Chunyan Liu wrote: /* Realloc dst option list and append options from an option list (list) * to it. dst could

Re: [Qemu-devel] [PATCH v25 30/31] cleanup QEMUOptionParameter

2014-04-28 Thread Chun Yan Liu
On 4/25/2014 at 08:42 PM, in message 20140425124255.gd3...@stefanha-thinkpad.redhat.com, Stefan Hajnoczi stefa...@redhat.com wrote: On Fri, Apr 11, 2014 at 01:54:26AM +0800, Chunyan Liu wrote: Now that all backend drivers are using QemuOpts, remove all QEMUOptionParameter related codes.

Re: [Qemu-devel] [Qemu-trivial] [PATCH V5 1/1] qmp: add pmemload command

2014-04-28 Thread Markus Armbruster
Michael Tokarev m...@tls.msk.ru writes: 09.04.2014 21:49, Baojun Wang wrote: I found this could be useful to have qemu-softmmu as a cross debugger (launch with -s -S command line option), then if we can have a command to load guest physical memory, we can use cross gdb to do some target debug

Re: [Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space

2014-04-28 Thread Amos Kong
On Fri, Apr 25, 2014 at 02:52:09PM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: Hi Markus, Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for points by the coding style. You mean

[Qemu-devel] [PATCH v3 2/3] qapi: add const prefix to 'char *' insider c_type()

2014-04-28 Thread Amos Kong
It's ugly to add const prefix for parameter type by a if statement outsider c_type(). This patch adds a parameter to do it. Signed-off-by: Amos Kong ak...@redhat.com Suggested-by: Markus Armbruster arm...@redhat.com --- scripts/qapi-commands.py | 4 +--- scripts/qapi.py | 4 +++- 2

[Qemu-devel] [PATCH v3 0/2] qapi: fix coding style in generated code

2014-04-28 Thread Amos Kong
Not a serious issue, but it's helpful if we can fix it. V2: split change of scripts/qapi-visit.py to a split patch, eat space by using a special char as Markus suggested V3: update commitlog, update special string, fix of adding const replace string by pattern Amos Kong (3): qapi: fix

[Qemu-devel] [PATCH v3 1/3] qapi: fix coding style in parameters list

2014-04-28 Thread Amos Kong
The space before pointers is redundant. Signed-off-by: Amos Kong ak...@redhat.com --- scripts/qapi-visit.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 45ce3a9..8ffed3d 100644 ---

[Qemu-devel] [PATCH] build-sys: simplify Makefile.target a bit, use just one rule for softmmu

2014-04-28 Thread Michael Tokarev
On win*, we build QEMU_PROGW (GUI) and create a console app QEMU_PROG from it, while on non-win*, we make only QEMU_PROG using the same rules as used for QEMU_PROGW on win*. Make just one rule for building main executable, and an additional rule for win* to make console app from it. Also

[Qemu-devel] [PATCH v3 3/3] qapi: Suppress unwanted space between type and identifier

2014-04-28 Thread Amos Kong
We always generate a space between type and identifier in parameter and variable declarations, even when idiomatic C style doesn't have a space there. Suppress it. Signed-off-by: Amos Kong ak...@redhat.com --- scripts/qapi.py | 18 +++--- 1 file changed, 11 insertions(+), 7

Re: [Qemu-devel] [PATCH v2 2/2] qapi: add a special string in c_type()'s result to each redundant space

2014-04-28 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On Fri, Apr 25, 2014 at 02:52:09PM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: Hi Markus, Currently we always add a space after c_type in mcgen(), there is some redundant space in generated code. The space isn't needed for

[Qemu-devel] KVM call agenda for 2014-04-28

2014-04-28 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: 15:00 CEST 13:00 UTC 09:00 EDT Every two weeks If you need phone number details, contact me privately.

[Qemu-devel] [PATCH 02/14] i386: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/i386/kvm/pci-assign.c | 18 ++ hw/i386/multiboot.c | 15 ++- 2

[Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/dma/i82374.c | 17 ++--- hw/dma/i8257.c | 24 +---

[Qemu-devel] [PATCH 09/14] tpm: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/tpm/tpm_passthrough.c | 17 ++--- hw/tpm/tpm_tis.c | 17 ++--- 2

[Qemu-devel] [PATCH 03/14] net: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/net/cadence_gem.c| 19 --- hw/net/eepro100.c | 15 ++-

[Qemu-devel] [PATCH 06/14] s390x: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/s390x/s390-virtio-bus.c | 17 ++--- hw/s390x/s390-virtio.c | 17

[Qemu-devel] [PATCH 04/14] isa: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/isa/vt82c686.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 08/14] sd: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/sd/sd.c | 14 +- hw/sd/ssi-sd.c | 24 2 files changed,

[Qemu-devel] [PATCH 05/14] pci-host: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/pci-host/bonito.c | 15 ++- hw/pci-host/ppce500.c | 15 +++ 2 files

[Qemu-devel] [PATCH 12/14] target-i386: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- target-i386/kvm.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff

[Qemu-devel] [PATCH 11/14] slirp: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- slirp/bootp.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 14/14] qemu: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- migration-rdma.c | 47 --- page_cache.c | 17

[Qemu-devel] [PATCH 07/14] scsi: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/scsi/lsi53c895a.c | 26 +- hw/scsi/scsi-generic.c | 16

[Qemu-devel] [PATCH 13/14] target-s390: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- target-s390x/helper.c | 32 ++-- target-s390x/kvm.c| 17

Re: [Qemu-devel] [PATCH 1/2] linux-user: Move if-elses to a switch statement

2014-04-28 Thread Huw Davies
On Sun, Apr 27, 2014 at 02:34:09PM +0300, Riku Voipio wrote: Hi, It looks good in my opinion. I'll include them in my next pull request. Great, thanks! Do you have a testcase for this, I didn't see one in ltp. No, I don't have a testcase, my use case is Wine. I can take a look at getting a

Re: [Qemu-devel] [PATCH] qmp: Remove unused variable.

2014-04-28 Thread Paolo Bonzini
Il 25/04/2014 17:51, Andreas Färber ha scritto: if (ambiguous) { error_setg(errp, Path '%s' is ambiguous., path); } else { error_set(errp, QERR_DEVICE_NOT_FOUND, path); } My reasoning is that an ambiguous path might deliver unpredictable results (whichever it encounters first), across

Re: [Qemu-devel] [PATCH] qmp: Remove unused variable.

2014-04-28 Thread Paolo Bonzini
Il 26/04/2014 02:46, Hani Benhabiles ha scritto: if (ambiguous) { error_setg(errp, Path '%s' is ambiguous., path); } else { error_set(errp, QERR_DEVICE_NOT_FOUND, path); } Probably, you meant something like this: if (ambiguous) { error_set(errp, QERR_AMBIGUOUS_PATH, path); }

Re: [Qemu-devel] [PATCH 01/10] MAINTAINERS: Take maintainership for QTest

2014-04-28 Thread Paolo Bonzini
Il 24/04/2014 14:49, Andreas Färber ha scritto: Invented by Anthony. Maintenance has been handled by me lately. Note that the tests themselves are intentionally not part of this entry; they are considered part of the device or subsystem they are covering. Cc: Anthony Liguori

Re: [Qemu-devel] [PATCH 01/10] MAINTAINERS: Take maintainership for QTest

2014-04-28 Thread Paolo Bonzini
Il 24/04/2014 14:49, Andreas Färber ha scritto: Invented by Anthony. Maintenance has been handled by me lately. Note that the tests themselves are intentionally not part of this entry; they are considered part of the device or subsystem they are covering. Cc: Anthony Liguori

Re: [Qemu-devel] [PATCH qom-next] MAINTAINERS: Document QOM

2014-04-28 Thread Paolo Bonzini
Il 24/04/2014 15:04, Andreas Färber ha scritto: Invented by Anthony. Maintained through my qom-next tree lately. Cc: Anthony Liguori aligu...@amazon.com Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- MAINTAINERS | 10 ++ 1 file changed, 10

Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Michael Tokarev
28.04.2014 12:26, Marc Marí пишет: From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/dma/i82374.c | 17 ++--- hw/dma/i8257.c |

Re: [Qemu-devel] [PATCH] timer: fix qemu_poll_ns early timeout on windows

2014-04-28 Thread Paolo Bonzini
Il 18/04/2014 10:29, Alex Bligh ha scritto: I suspect the easiest fix (certainly for debug purposes) would be to make all polls for non-zero time at least 10ms long. IE after the assignment of 'ms', do something like #ifdef BROKEN_POLL if (ms 10) { ms = 10; #endif } If you're

Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Kevin Wolf
Am 28.04.2014 um 10:26 hat Marc Marí geschrieben: From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/dma/i82374.c | 17 ++---

[Qemu-devel] [PULL v2 3/4] add display-vga test

2014-04-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- tests/Makefile | 5 + tests/display-vga-test.c | 38 ++ 2 files changed, 43 insertions(+) create mode 100644 tests/display-vga-test.c diff --git a/tests/Makefile b/tests/Makefile index

[Qemu-devel] [PULL v2 0/4] vga: add secondary stdvga variant

2014-04-28 Thread Gerd Hoffmann
Hi, This series adds a standard vga variant which doesn't occupy any legacy ressources and thus can easily be used as secondary (or legacy-free) graphics adapter. Programming must be done using the MMIO bar. bochsdrm (linux 3.14+) can drive the card. You can use loginctl to attach the second

[Qemu-devel] [PULL v2 1/4] vga: allow non-global vmstate

2014-04-28 Thread Gerd Hoffmann
Need a way to opt-out from vga.vram being global vmstate, for secondary vga cards. Add a bool parameter to vga_common_init to support this. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/cirrus_vga.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vga-isa-mm.c | 2 +-

[Qemu-devel] [PULL v2 2/4] vga: add secondary stdvga variant

2014-04-28 Thread Gerd Hoffmann
Add a standard vga variant which doesn't occupy any legacy resources and thus can easily be used as secondary (or legacy-free) graphics adapter. Programming must be done using the MMIO bar. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/specs/standard-vga.txt | 13 +++---

[Qemu-devel] [PULL v2 4/4] add secondary-vga to display-vga test

2014-04-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- tests/display-vga-test.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/display-vga-test.c b/tests/display-vga-test.c index 23be88f..17f5910 100644 --- a/tests/display-vga-test.c +++ b/tests/display-vga-test.c @@ -24,6

Re: [Qemu-devel] [PATCH] serial: poll the serial console with G_IO_HUP

2014-04-28 Thread Paolo Bonzini
Il 22/04/2014 19:08, Roger Pau Monne ha scritto: On FreeBSD polling a master pty while the other end is not connected with G_IO_OUT only results in an endless wait. This is different from the Linux behaviour, that returns immediately. In order to demonstrate this, I have the following example

Re: [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows

2014-04-28 Thread Paolo Bonzini
Il 22/04/2014 11:41, Stanislav Vorobiov ha scritto: m.b. it makes sense to move entire qemu_poll_ns to oslib then ? like this patch to oslib-win32.c and the rest of the stuff to oslib-posix.c ? But Stefan proposed to make it this way (which is also reasonable, since we replace buggy g_poll with

Re: [Qemu-devel] [PATCH v2] Add remove_boot_device_path() function for hot-unplug device

2014-04-28 Thread Paolo Bonzini
Il 22/04/2014 11:21, Marcel Apfelbaum ha scritto: Here is the *real* problem: fw_boot_order list is not queried again on guest reboot, so 'touching' the list has no effect. While your code is correct (as far as I can tell), it seems that his place is after the above problem is solved. Doesn't

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qcow2.c: Check if backing file name length is valid

2014-04-28 Thread Michael Tokarev
19.03.2014 12:19, Deepak Kathayat wrote: Signed-off-by: Deepak Kathayat deepak.m...@gmail.com --- The len variable is a signed integer whereas the backing file name length in the image header is unsigned. Therefore, it may overflow. Furthermore, backing file name length cannot be zero.

Re: [Qemu-devel] [PATCH] serial: poll the serial console with G_IO_HUP

2014-04-28 Thread Roger Pau Monné
On 28/04/14 11:19, Paolo Bonzini wrote: Il 22/04/2014 19:08, Roger Pau Monne ha scritto: On FreeBSD polling a master pty while the other end is not connected with G_IO_OUT only results in an endless wait. This is different from the Linux behaviour, that returns immediately. In order to

Re: [Qemu-devel] [RFC PATCH V3 5/7] hw/arm/virt: Use PSCI v0.2 function IDs when kernel supports it

2014-04-28 Thread Pranavkumar Sawargaonkar
Hi Rob, On 26 April 2014 00:17, Rob Herring robherri...@gmail.com wrote: On Thu, Apr 10, 2014 at 6:46 AM, Pranavkumar Sawargaonkar pranavku...@linaro.org wrote: If we have in-kernel emulation of PSCI v0.2 for KVM ARM/ARM64 then we enable PSCI v0.2 for each VCPU at the time of VCPU init hence

Re: [Qemu-devel] [PATCH 5/5] gtk: Fix accelerators being triggered twice with gtk3

2014-04-28 Thread Gerd Hoffmann
On Fr, 2014-04-25 at 16:46 -0400, Cole Robinson wrote: On 04/25/2014 05:11 AM, Gerd Hoffmann wrote: On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote: When keyboard focus is grabbed, current qemu wants to pass every keypress to the VM, unless the user is pressing a UI accelerator.

Re: [Qemu-devel] [PATCH v2] Add remove_boot_device_path() function for hot-unplug device

2014-04-28 Thread Marcel Apfelbaum
On Mon, 2014-04-28 at 11:22 +0200, Paolo Bonzini wrote: Il 22/04/2014 11:21, Marcel Apfelbaum ha scritto: Here is the *real* problem: fw_boot_order list is not queried again on guest reboot, so 'touching' the list has no effect. While your code is correct (as far as I can tell), it seems

Re: [Qemu-devel] [PATCH v3] ps2: set ps/2 output buffer size as the same as kernel

2014-04-28 Thread Gerd Hoffmann
Hi, If the kernel has booted up, the check will not happen, so the Linux kernel will not get confused. I didn't find that the checking is necessary in protocol docs. any hint? If we still use 256 size buffer in qemu, guest ps2 driver will drop some input keys? or just delay them?

Re: [Qemu-devel] [PATCH v2] usb-ohci: Add vmstate descriptor

2014-04-28 Thread Gerd Hoffmann
On Sa, 2014-04-26 at 23:02 +1000, Alexey Kardashevskiy wrote: On 04/13/2014 08:42 PM, Alexey Kardashevskiy wrote: This adds migration support for OHCI. This defines a descriptor for OHCIState. This changes some OHCIState field types to be migration compatible. This adds a descriptor

Re: [Qemu-devel] [PATCH] scsi-disk: Improve error messager if can't get version number

2014-04-28 Thread Paolo Bonzini
Il 16/04/2014 04:09, Fam Zheng ha scritto: More often it is that bdrv_ioctl fails due to not supported by driver or whatever reason, in this case we should be specific, because interface too old is very confusing. Signed-off-by: Fam Zheng f...@redhat.com --- hw/scsi/scsi-disk.c | 9 +++--

Re: [Qemu-devel] [PATCH 03/14] net: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Stefan Hajnoczi
On Mon, Apr 28, 2014 at 10:26:04AM +0200, Marc Marí wrote: /* Debug EEPRO100 card. */ #if 0 -# define DEBUG_EEPRO100 +#define DEBUG_EEPRO100 1 #endif There seem to be a few ways of doing this (commenting out the line, putting it in #if 0, etc). Feel free to get rid of #define DEBUG_foo 1

Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-04-28 Thread Fabio Fantoni
Il 22/01/2014 15:32, Fabio Fantoni ha scritto: Il 28/10/2013 10:38, Jan Beulich ha scritto: On 24.10.13 at 14:17, Gonglei (Arei) arei.gong...@huawei.com wrote: Now I test the patch based on the codes of trunk, which works well. The patch has been modified after your suggestion. Partly. I

[Qemu-devel] [PATCH] scsi: Improve error messages more

2014-04-28 Thread Paolo Bonzini
Make the message the same for both scsi-block and scsi-generic, including the strerror() output in both and making an explicit reference to SG_IO. Also s/can not/cannot/. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-disk.c| 5 +++-- hw/scsi/scsi-generic.c | 8 ++--

Re: [Qemu-devel] [PATCH] libcacard: replace qemu thread primitives with glib ones

2014-04-28 Thread Peter Maydell
On 27 April 2014 17:26, Michael Tokarev m...@tls.msk.ru wrote: Replace QemuMutex with GMutex and QemuCond with GCond (with corresponding function changes), to make libcacard independent of qemu internal functions. --- a/libcacard/event.c +++ b/libcacard/event.c @@ -43,13 +43,13 @@

Re: [Qemu-devel] [PATCH 03/14] net: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
I left the original definition as it was, just adding the 1, that's why there is so much diversity. I'll remove them for v2. 2014-04-28 12:10 GMT+02:00 Stefan Hajnoczi stefa...@gmail.com: On Mon, Apr 28, 2014 at 10:26:04AM +0200, Marc Marí wrote: /* Debug EEPRO100 card. */ #if 0 -#

Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-04-28 Thread Ian Campbell
On Mon, 2014-04-28 at 12:14 +0200, Fabio Fantoni wrote: Il 22/01/2014 15:32, Fabio Fantoni ha scritto: Il 28/10/2013 10:38, Jan Beulich ha scritto: On 24.10.13 at 14:17, Gonglei (Arei) arei.gong...@huawei.com wrote: Now I test the patch based on the codes of trunk, which works well.

Re: [Qemu-devel] [PATCH V2 2/4] vmxnet3: validate queues configuration coming from quest

2014-04-28 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 12:45:20PM +0300, Dmitry Fleytman wrote: CVE-2013-4544 Signed-off-by: Dmitry Fleytman dmi...@daynix.com Reported-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [PULL 0/4] current s390x queue

2014-04-28 Thread Peter Maydell
On 25 April 2014 13:02, Cornelia Huck cornelia.h...@de.ibm.com wrote: No further comments had been made on the patches below, so sending a pull request. The following changes since commit 0e96643c98eb22a5f2e11ac500852133032d38e4: Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v5 14/24] openpic: avoid buffer overrun on incoming migration

2014-04-28 Thread Michael S. Tsirkin
On Thu, Apr 03, 2014 at 08:04:23PM +0200, Alexander Graf wrote: On 03.04.2014, at 18:51, Michael S. Tsirkin m...@redhat.com wrote: From: Michael Roth mdr...@linux.vnet.ibm.com CVE-2013-4534 opp-nb_cpus is read from the wire and used to determine how many IRQDest elements to read

Re: [Qemu-devel] [PATCH v7 1/8] virtio: endian-ambivalent targets using legacy virtio

2014-04-28 Thread Paolo Bonzini
Il 17/04/2014 15:44, Michael S. Tsirkin ha scritto: I'm fine with this. And I'm not against a runtime switch to get rid of per-target build of virtio. I am merely asking for separatable patchsets, e.g. structured like this: 1. implement bi-endian support with no data path overhead for fixed

Re: [Qemu-devel] [PATCH v2 0/7] stellaris_enet: overhaul tx/rx, convert to vmstate

2014-04-28 Thread Michael S. Tsirkin
On Tue, Apr 01, 2014 at 11:14:48PM +0100, Peter Maydell wrote: This patchset overhauls the stellaris_enet TX and RX handling code, and converts it to use vmstate. The principal motivation is to fix the buffer overrun noted in the first patch, and to reimplement things using simpler state

[Qemu-devel] [PATCH] docs/memory.txt: old_portio has gone, so don't mention it

2014-04-28 Thread Peter Maydell
The old_portio mechanism in the memory API has been removed, but we forgot to update the documentation to match. Remove the stray reference to this now-vanished bit of back-compatibility API. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- docs/memory.txt | 5 ++--- 1 file changed, 2

Re: [Qemu-devel] [PULL 0/6] Net pull request

2014-04-28 Thread Peter Maydell
On 25 April 2014 15:09, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit 0e96643c98eb22a5f2e11ac500852133032d38e4: Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-5' into staging (2014-04-24 16:16:57 +0100) are available in the git repository at:

Re: [Qemu-devel] [PATCH v2 7/7] hw/net/stellaris_enet: Convert to vmstate

2014-04-28 Thread Michael S. Tsirkin
On Tue, Apr 01, 2014 at 11:14:55PM +0100, Peter Maydell wrote: Convert this device to use vmstate for its save/load, including providing a post_load function that sanitizes inbound data to avoid possible buffer overflows if it is malicious. Signed-off-by: Peter Maydell

[Qemu-devel] documenting our unfinished API/style transitions

2014-04-28 Thread Peter Maydell
QEMU tends to have rather a lot of half-finished API or coding style transitions, as an inevitable consequence of our having such a large code base with wildly varying levels of maintainedness. I thought it would be useful to at least document them on the wiki:

Re: [Qemu-devel] [PATCH] scsi: Improve error messages more

2014-04-28 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Make the message the same for both scsi-block and scsi-generic, including the strerror() output in both and making an explicit reference to SG_IO. Also s/can not/cannot/. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-disk.c

[Qemu-devel] [PATCHv2 RESEND] block/iscsi: speed up read for unallocated sectors

2014-04-28 Thread Peter Lieven
this patch implements a cache that tracks if a page on the iscsi target is allocated or not. The cache is implemented in a way that it allows for false positives (e.g. pretending a page is allocated, but it isn't), but no false negatives. The cached allocation info is then used to speed up the

[Qemu-devel] [PATCH] block/iscsi: bump year in copyright notice

2014-04-28 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index a636ea4..0819945 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2,7 +2,7 @@ * QEMU Block driver for iSCSI images * *

Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Peter Crosthwaite
Hi Marc, On such a long series, it's usual to include a cover letter summarising the entire series. Its subject is PATCH 00/NN and can be generated by adding the --cover-letter switch to git send-email. Hand edit the file them send along with the autogenerated patches. On Mon, Apr 28, 2014 at

[Qemu-devel] [PATCH] block/iscsi: allow fall back to WRITE SAME without UNMAP

2014-04-28 Thread Peter Lieven
if the iscsi driver receives a write zeroes request with the BDRV_REQ_MAY_UNMAP flag set it fails with -ENOTSUP if the iscsi target does not support WRITE SAME with UNMAP. However, the BDRV_REQ_MAY_UNMAP is only a hint and writing zeroes with WRITE SAME will still be better than falling back to

[Qemu-devel] [PATCH 3/4] target-ppc: ppc can be either endian

2014-04-28 Thread Greg Kurz
POWER7, POWER7+ and POWER8 families use the ILE bit of the LPCR special purpose register to decide the endianness to use when entering interrupt handlers. When running a linux guest, this provides a hint on the endianness used by the kernel. From a qemu point of view, the information is needed for

[Qemu-devel] [PATCH 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

2014-04-28 Thread Greg Kurz
From: Bharata B Rao bhar...@linux.vnet.ibm.com Make DumpState and endian conversion routines available for arch-specific dump code by moving into dump.h. DumpState will be needed by arch-specific dump code to access target endian information from DumpState-ArchDumpInfo. Also break the dependency

[Qemu-devel] [PATCH 0/4] little-endian dump for ppc64

2014-04-28 Thread Greg Kurz
Hi, This patch set allows to dump a little-endian ppc64 guest. Note that the target-ppc: ppc can be either endian patch will also benefit to cross-endian virtio. Cheers. --- Bharata B Rao (3): dump: Make DumpState and endian conversion routines available for arch-specific dump code

[Qemu-devel] [PATCH 2/4] ppc64-dump: Support dump for little endian ppc64

2014-04-28 Thread Greg Kurz
From: Bharata B Rao bhar...@linux.vnet.ibm.com Fix ppc64 arch specific dump code to work correctly for little endian guests. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com [ rebased on top of current master branch, Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz

[Qemu-devel] [PATCH 4/4] ppc64 dump: Set the correct endianness in ELF dump header

2014-04-28 Thread Greg Kurz
From: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com [ use ppc_cpu_interrupts_big_endian(), Greg Kurz gk...@linux.vnet.ibm.com ] Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- target-ppc/arch_dump.c |9 + 1 file changed, 5

Re: [Qemu-devel] documenting our unfinished API/style transitions

2014-04-28 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: QEMU tends to have rather a lot of half-finished API or coding style transitions, as an inevitable consequence of our having such a large code base with wildly varying levels of maintainedness. I thought it would be useful to at least document

[Qemu-devel] [PATCH v2] scsi: Improve error messages more

2014-04-28 Thread Paolo Bonzini
Remove the scsi-block: prefix for error messages as suggested by Markus. Improve the previous patch by making the message the same for both scsi-block and scsi-generic, including the strerror() output in both and making an explicit reference to SG_IO. Also s/can not/cannot/. Signed-off-by:

Re: [Qemu-devel] [PATCH 2/7] megasas: Enable MSI-X support

2014-04-28 Thread Paolo Bonzini
Il 17/04/2014 17:01, Michael S. Tsirkin ha scritto: On Thu, Apr 17, 2014 at 03:41:56PM +0200, Hannes Reinecke wrote: On 04/17/2014 02:07 PM, Andreas Färber wrote: Am 17.04.2014 08:20, schrieb Hannes Reinecke: On 04/16/2014 07:52 PM, Michael S. Tsirkin wrote: On Wed, Apr 16, 2014 at

Re: [Qemu-devel] [PATCH] libcacard: replace qemu thread primitives with glib ones

2014-04-28 Thread Michael Tokarev
28.04.2014 14:19, Peter Maydell wrote: On 27 April 2014 17:26, Michael Tokarev m...@tls.msk.ru wrote: -static QemuMutex vevent_queue_lock; -static QemuCond vevent_queue_condition; +static GMutex vevent_queue_lock; +static GCond vevent_queue_condition; void vevent_queue_init(void) { -

Re: [Qemu-devel] [PATCH 2/7] megasas: Enable MSI-X support

2014-04-28 Thread Hannes Reinecke
On 04/28/2014 01:45 PM, Paolo Bonzini wrote: Hannes Reinecke wrote: I'm happy to continue with having the original implementation at PCI, and only moving to PCIe with the gen2 emulation. Ok, for now I'm applying this patch without the PCI-PCIE change. Hmm. Better let me send a new patch

Re: [Qemu-devel] [PULL 12/18] Add QEMU logo (SVG file)

2014-04-28 Thread Benoît Canet
The Monday 28 Apr 2014 à 09:07:58 (+0400), Michael Tokarev wrote : From: Stefan Weil s...@weilnetz.de The Q of the logo is already included in pc-bios/qemu_logo_no_text.svg. This file now adds the complete logo as it was designed by Benoît Canet. Benoît licensed it under CC-BY 3.0, see

Re: [Qemu-devel] [PATCH 2/7] megasas: Enable MSI-X support

2014-04-28 Thread Paolo Bonzini
Il 28/04/2014 13:49, Hannes Reinecke ha scritto: Ok, for now I'm applying this patch without the PCI-PCIE change. Hmm. Better let me send a new patch which reverts the PCI-PCIE change and make only megasas-gen2 a PCIE board. If I push patches 1-3 and 7 to scsi-next, you can start from

Re: [Qemu-devel] documenting our unfinished API/style transitions

2014-04-28 Thread Kevin Wolf
Am 28.04.2014 um 12:56 hat Peter Maydell geschrieben: QEMU tends to have rather a lot of half-finished API or coding style transitions, as an inevitable consequence of our having such a large code base with wildly varying levels of maintainedness. I thought it would be useful to at least

Re: [Qemu-devel] [PATCH 2/7] megasas: Enable MSI-X support

2014-04-28 Thread Hannes Reinecke
On 04/28/2014 01:51 PM, Paolo Bonzini wrote: Il 28/04/2014 13:49, Hannes Reinecke ha scritto: Ok, for now I'm applying this patch without the PCI-PCIE change. Hmm. Better let me send a new patch which reverts the PCI-PCIE change and make only megasas-gen2 a PCIE board. If I push patches

Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Marc Marí
2014-04-28 11:05 GMT+02:00 Michael Tokarev m...@tls.msk.ru: 28.04.2014 12:26, Marc Marí пишет: From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com

Re: [Qemu-devel] [PATCH 03/14] net: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Kevin Wolf
Am 28.04.2014 um 12:10 hat Stefan Hajnoczi geschrieben: On Mon, Apr 28, 2014 at 10:26:04AM +0200, Marc Marí wrote: /* Debug EEPRO100 card. */ #if 0 -# define DEBUG_EEPRO100 +#define DEBUG_EEPRO100 1 #endif There seem to be a few ways of doing this (commenting out the line,

Re: [Qemu-devel] [PULL 00/10] Block patches

2014-04-28 Thread Peter Maydell
On 25 April 2014 17:07, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit 411f491e0af173cf8f39347574941bd26fbae381: Merge remote-tracking branch 'remotes/rth/tags/tgt-axp-pull-20140424' into staging (2014-04-25 13:25:22 +0100) are available in the git

Re: [Qemu-devel] [PATCH v2] Add remove_boot_device_path() function for hot-unplug device

2014-04-28 Thread Paolo Bonzini
Il 28/04/2014 11:38, Marcel Apfelbaum ha scritto: Doesn't Jun's patch fix a dangling pointer? If so, that would come first anyway. It removes pointers from a dead list, and it only deals with some symptom. Yeah, but dangling pointers are bad anyway. I think we should include Jun's patch.

Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-04-28 Thread Gonglei (Arei)
Hi, Subject: Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching On Mon, 2014-04-28 at 12:14 +0200, Fabio Fantoni wrote: Il 22/01/2014 15:32, Fabio Fantoni ha scritto: Il 28/10/2013 10:38, Jan Beulich ha

Re: [Qemu-devel] [PATCH v2] block: fix qemu-img --help invocation

2014-04-28 Thread Kevin Wolf
Am 25.04.2014 um 23:02 hat Jeff Cody geschrieben: This fixes a bug introduced in commit ac1307ab, that caused the '--help' option to not be recognized as a valid command, and not print any help. Signed-off-by: Jeff Cody jc...@redhat.com Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] mirror: Use DIV_ROUND_UP

2014-04-28 Thread Kevin Wolf
Am 28.04.2014 um 04:59 hat Fam Zheng geschrieben: Although bdrv_getlength() was just called above this, and checked for error, it is better to just use the value we already get, and use DIV_ROUND_UP. Signed-off-by: Fam Zheng f...@redhat.com The subject line is kind of hiding the real

Re: [Qemu-devel] [PATCH] uhci: Lower uhci timer freq when guest is idle

2014-04-28 Thread Gonglei (Arei)
Hi, Gerd. What's your opinion about this issue? Thanks! Best regards, -Gonglei -Original Message- From: Gonglei (Arei) Sent: Wednesday, March 26, 2014 4:15 PM To: 'Gerd Hoffmann' Cc: qemu-devel@nongnu.org; Huangweidong (C) Subject: RE: [PATCH] uhci: Lower uhci timer freq when

Re: [Qemu-devel] [PATCH 01/10] MAINTAINERS: Take maintainership for QTest

2014-04-28 Thread Andreas Färber
Am 28.04.2014 11:02, schrieb Paolo Bonzini: Il 24/04/2014 14:49, Andreas Färber ha scritto: Invented by Anthony. Maintenance has been handled by me lately. Note that the tests themselves are intentionally not part of this entry; they are considered part of the device or subsystem they are

Re: [Qemu-devel] [PATCH v2] mirror: Check for bdrv_get_info result

2014-04-28 Thread Kevin Wolf
Am 28.04.2014 um 04:57 hat Fam Zheng geschrieben: bdrv_get_info could fail. Add check before using the returned value. Signed-off-by: Fam Zheng f...@redhat.com --- V2: Handle error case (Stefan). Signed-off-by: Fam Zheng f...@redhat.com --- block/mirror.c | 6 +- 1 file changed,

Re: [Qemu-devel] [PATCH v2 4/4] PortioList: Store PortioList in device state

2014-04-28 Thread Paolo Bonzini
Il 24/04/2014 16:15, Kirill Batuzov ha scritto: v1 - v2: I tried adding PortioList to AdlibState, PCIQXLDevice etc like Paolo suggested. It worked fine for all cases except for isa_register_portio_list. isa_register_portio_list can be called: - with NULL instead of real ISADevice *, -

Re: [Qemu-devel] [PATCH] configure: make source tree build more robust

2014-04-28 Thread Paolo Bonzini
Il 28/04/2014 14:21, Michael S. Tsirkin ha scritto: A more practical way is when make runs configure automatically: 1. cd firstpath/; ./configure SRC_PATH=firstpath/ is written into config_host.mak 2. cd secondpath/; touch configure; make make now runs firstpath/configure, so configure

Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs

2014-04-28 Thread Andreas Färber
Hi Marc, Am 28.04.2014 10:26, schrieb Marc Marí: From: Marc Marí 5.markm...@gmail.com Modify debug macros as explained in https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html Signed-off-by: Marc Marí 5.markm...@gmail.com --- hw/dma/i82374.c | 17 ++---

Re: [Qemu-devel] [PATCH v3 1/3] qapi: fix coding style in parameters list

2014-04-28 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: The space before pointers is redundant. Eric suggested A space after * when declaring a pointer type is redundant. Did you see that? Signed-off-by: Amos Kong ak...@redhat.com Keeping Reviewed-by: Eric Blake ebl...@redhat.com around would've been nice.

Re: [Qemu-devel] [PATCH v3 2/3] qapi: add const prefix to 'char *' insider c_type()

2014-04-28 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: It's ugly to add const prefix for parameter type by a if statement outsider c_type(). This patch adds a parameter to do it. outside.

[Qemu-devel] [PATCH v3 6/7] hw/net/stellaris_enet: Get rid of rx_fifo pointer

2014-04-28 Thread Peter Maydell
The rx_fifo pointer is awkward to migrate, and is actually redundant since it is always possible to determine it from the current rx[].len/.data and rx_fifo_len. Remove both rx_fifo and rx_fifo_len from the state, replacing them with a simple rx_fifo_offset which points at the current location in

  1   2   3   >