Re: [Qemu-devel] [PATCH 1/2] virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 08:36, Fam Zheng ha scritto: - -if (!req->dev->blk.scsi) { -status = VIRTIO_BLK_S_UNSUPP; -goto fail; -} Where did you move this condition? Also, the scsi field of VirtIOBlockReq is now unused. Paolo

Re: [Qemu-devel] [PATCH 2/2] dataplane: Support VIRTIO_BLK_T_SCSI_CMD

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 08:36, Fam Zheng ha scritto: Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 46a6824..6a66196 100644 --- a/

Re: [Qemu-devel] [PATCH 3/7] monitor: Add migrate_set_capability completion.

2014-05-22 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Hani Benhabiles (kroo...@gmail.com) wrote: >> Signed-off-by: Hani Benhabiles >> --- >> hmp-commands.hx | 1 + >> hmp.h | 2 ++ >> monitor.c | 21 + >> 3 files changed, 24 insertions(+) >> >> diff --git a/hmp-commands.hx

Re: [Qemu-devel] [PATCH 0/2] dataplane: Enable "scsi=on"

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 08:36, Fam Zheng ha scritto: This makes the SG_IO code of non-dataplane available to dataplane, so that dataplane can use to allow scsi=on. I like the idea of using more hw/block/virtio-blk.c code in the dataplane thread. We should turn this into an actual plan to remove more a

Re: [Qemu-devel] [PATCH 2/9] target-ppc: Refactor init_proc_POWER7

2014-05-22 Thread Alexander Graf
> Am 22.05.2014 um 05:59 schrieb Alexey Kardashevskiy : > >> On 05/21/2014 11:23 PM, Alexander Graf wrote: >> >>> On 21.05.14 14:30, Alexey Kardashevskiy wrote: On 05/21/2014 08:44 PM, Alexander Graf wrote: > On 21.05.14 08:20, Alexey Kardashevskiy wrote: > This moves SPR initializ

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-22 Thread Alexander Graf
> Am 22.05.2014 um 06:25 schrieb Alexey Kardashevskiy : > >> On 05/22/2014 08:11 AM, Alexander Graf wrote: >> >>> On 21.05.14 16:21, Alexey Kardashevskiy wrote: >>> At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR >>> spec allows other page sizes and we are going to imple

Re: [Qemu-devel] [PATCH 1/2] virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi

2014-05-22 Thread Fam Zheng
On Thu, 05/22 09:03, Paolo Bonzini wrote: > Il 22/05/2014 08:36, Fam Zheng ha scritto: > >- > >-if (!req->dev->blk.scsi) { > >-status = VIRTIO_BLK_S_UNSUPP; > >-goto fail; > >-} > > Where did you move this condition? > > Also, the scsi field of VirtIOBlockReq is now unused

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-22 Thread Chen, Tiejun
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, May 22, 2014 2:45 PM > To: Chen, Tiejun > Cc: Anthony PERARD; Daniel P. Berrange; peter.mayd...@linaro.org; > xen-de...@lists.xensource.com; m...@redhat.com; > stefano.stabell...@eu.citrix.com; Kay, Alle

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-22 Thread Alexander Graf
> Am 22.05.2014 um 08:53 schrieb Alexey Kardashevskiy : > >> On 05/21/2014 10:42 PM, Alexey Kardashevskiy wrote: >>> On 05/21/2014 08:35 PM, Alexander Graf wrote: >>> On 21.05.14 12:13, Alexey Kardashevskiy wrote: > On 05/21/2014 07:50 PM, Alexander Graf wrote: >> On 21.05.14 11:33

[Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Gerd Hoffmann
Patch hooks up the xen platform device to the default device code we have in qemu. Two effects: (1) The device will not be created in case -nodefaults is specified on the command line. (2) Autocreating the device is also turned off in case xen-platform is added manually via -devic

[Qemu-devel] [PATCH v2 1/2] openpic: Move definition of openpic_reset

2014-05-22 Thread Paul Janzen
This patch moves the definition of openpic_reset after the various register read/write functions. No functional change. It is in preparation for using the register read/write functions in openpic_reset. Signed-off-by: Paul Janzen --- hw/intc/openpic.c | 99 +++-

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 09:20:50AM +0200, Gerd Hoffmann wrote: > Patch hooks up the xen platform device to the default device code we > have in qemu. Two effects: > > (1) The device will not be created in case -nodefaults is specified > on the command line. > (2) Autocreating the device

[Qemu-devel] [PATCH v2 2/2] openpic: Reset IRQ source private members

2014-05-22 Thread Paul Janzen
The openpic emulation code maintains an allowable-CPU's bitmap ("destmask") for each IRQ source which is calculated from the IDR register value whenever the guest OS writes to it. However, if the guest OS relies on the system to set the IDR register to a default value at reset, and does not write

Re: [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs

2014-05-22 Thread Peter Maydell
On 22 May 2014 01:48, Edgar E. Iglesias wrote: > On Wed, May 21, 2014 at 08:20:20PM +0100, Peter Maydell wrote: >> it needs to also fix the bit in the "returning to an exception >> level which is 32 bit" which says "new_el = 0" since that's >> not guaranteed to be true any more. (Also I think the

Re: [Qemu-devel] [PATCH] spapr_iommu: Replace @instance_id with LIOBN for migration

2014-05-22 Thread Alexey Kardashevskiy
On 05/12/2014 06:46 PM, Alexey Kardashevskiy wrote: > SPAPR IOMMU is a bus-less device and therefore its only ID in > migration stream is an instance id which is not reliable ID > as it depends on the command line parameters order. Since > libvirt may change the order, we need something better than

Re: [Qemu-devel] [PATCH v2 16/23] target-arm: Use arm_current_sctlr to access SCTLR

2014-05-22 Thread Edgar E. Iglesias
On Tue, May 13, 2014 at 06:16:01PM +0200, Fabian Aggeler wrote: > Add SCTLR_EL3 and introduce new function to access correct > instance of SCTLR in different modes/worlds. Hi, AArch64 has a couple of insn/regs that do address translation as seen by other ELs. E.g, from EL3 you can perform address

[Qemu-devel] [PATCH v2 0/2] dataplane: Enable "scsi=on"

2014-05-22 Thread Fam Zheng
This makes the SG_IO code of non-dataplane available to dataplane, so that dataplane can use to allow scsi=on. v2: [1/2] Fix scsi=off case and drop VirtIOBlockReq.scsi. [2/2] Pass conf to virtio_blk_handle_scsi_req. Fam Fam Zheng (2): virtio-blk: Factor out virtio_blk_handle_scsi_req

[Qemu-devel] [PATCH v2 2/2] dataplane: Support VIRTIO_BLK_T_SCSI_CMD

2014-05-22 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 46a6824..e833045 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block

[Qemu-devel] [PATCH v2 1/2] virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi

2014-05-22 Thread Fam Zheng
The common logic to process a scsi request in a VirtQueueElement is extracted to a function to share with dataplane. This makes VirtIOBlockReq.scsi unused, so drop it. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 83 +++--- include/hw/virtio/

Re: [Qemu-devel] [PATCH v2 14/23] target-arm: add banked coprocessor register type and macros

2014-05-22 Thread Edgar E. Iglesias
On Tue, May 13, 2014 at 06:15:59PM +0200, Fabian Aggeler wrote: > Banked CP registers can be defined with a A32_BANKED_REG macro which defines > a non-secure instance of the register followed by an adjacent secure instance. > Using a union makes the code backwards-compatible since the non-secure >

Re: [Qemu-devel] [PATCH v2 1/2] virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 09:37, Fam Zheng ha scritto: -static void virtio_blk_handle_scsi(VirtIOBlockReq *req) +int virtio_blk_handle_scsi_req(BlockDriverState *bs, + VirtIOBlkConf *conf, + VirtQueueElement *elem) Two more comments... please pas

[Qemu-devel] [PATCH v3 0/2] dataplane: Enable "scsi=on"

2014-05-22 Thread Fam Zheng
This makes the SG_IO code of non-dataplane available to dataplane, so that dataplane can use to allow scsi=on. v3: Change parameter to VirtIOBlock pointer. Undo the swap in code movement. (Paolo) v2: [1/2] Fix scsi=off case and drop VirtIOBlockReq.scsi. [2/2] Pass conf to virtio_blk_h

[Qemu-devel] [PATCH v3 1/2] virtio-blk: Factor out virtio_blk_handle_scsi_req from virtio_blk_handle_scsi

2014-05-22 Thread Fam Zheng
The common logic to process a scsi request in a VirtQueueElement is extracted to a function to share with dataplane. This makes VirtIOBlockReq.scsi unused, so drop it. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 75 +++--- include/hw/virtio/

[Qemu-devel] [PATCH v3 2/2] dataplane: Support VIRTIO_BLK_T_SCSI_CMD

2014-05-22 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 46a6824..03cbdec 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block

Re: [Qemu-devel] [PATCH v3 0/2] dataplane: Enable "scsi=on"

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 10:22, Fam Zheng ha scritto: This makes the SG_IO code of non-dataplane available to dataplane, so that dataplane can use to allow scsi=on. v3: Change parameter to VirtIOBlock pointer. Undo the swap in code movement. (Paolo) v2: [1/2] Fix scsi=off case and drop VirtIOBlock

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 10:23, Michael Mueller ha scritto: On Wed, 21 May 2014 15:22:35 +0200 Alexander Graf wrote: I have seen the slides from Eduardo which he presented during this years DevConf in Brno and made my comments according the s390x implementation on that. Is you will see, this is mostly ove

Re: [Qemu-devel] [PATCH v2 04/23] target-arm: preserve RAO/WI bits of ARMv7 SCTLR

2014-05-22 Thread Aggeler Fabian
On 21 May 2014, at 18:12, Peter Maydell wrote: > On 14 May 2014 06:43, Sergey Fedorov wrote: >> >> On 13.05.2014 20:15, Fabian Aggeler wrote: >>> From: Svetlana Fedoseeva >>> >>> Signed-off-by: Svetlana Fedoseeva >>> Signed-off-by: Sergey Fedorov >>> Signed-off-by: Fabian Aggeler >>> ---

[Qemu-devel] [PATCH] virtio-pci: report an error when disable msix

2014-05-22 Thread Amos Kong
QEMU remains 4k memory for PCI BAR, each msix entry takes 16 bytes. If user assigns more than 128 vectors, msix resource isn't enough, so msix will be disabled. This patch addes a note when fail to init exclusive bars for msix. qemu -device virtio-net-pci,netdev=h1,vectors=129,mq=on \ -net

Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

2014-05-22 Thread Aggeler Fabian
On 21 May 2014, at 16:51, Peter Maydell wrote: > On 13 May 2014 17:15, Fabian Aggeler wrote: >> --- a/target-arm/cpu.h >> +++ b/target-arm/cpu.h >> @@ -631,6 +631,7 @@ enum arm_features { >> ARM_FEATURE_CBAR, /* has cp15 CBAR */ >> ARM_FEATURE_CRC, /* ARMv8 CRC instructions */ >> AR

Re: [Qemu-devel] [PATCH] virtio-pci: report an error when disable msix

2014-05-22 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 05:02:17PM +0800, Amos Kong wrote: > QEMU remains 4k memory for PCI BAR, each msix entry takes 16 bytes. > If user assigns more than 128 vectors, msix resource isn't enough, > so msix will be disabled. > > This patch addes a note when fail to init exclusive bars for msix. >

Re: [Qemu-devel] [PATCH] virtio-pci: report an error when disable msix

2014-05-22 Thread Peter Maydell
On 22 May 2014 10:02, Amos Kong wrote: > QEMU remains 4k memory for PCI BAR, each msix entry takes 16 bytes. > If user assigns more than 128 vectors, msix resource isn't enough, > so msix will be disabled. > > This patch addes a note when fail to init exclusive bars for msix. > > qemu -device vir

[Qemu-devel] [PATCH] docs: clarify that qcow2 file size is not always a cluster multiple

2014-05-22 Thread Stefan Hajnoczi
Normally one would expect that qcow2 image file lengths are multiples of the cluster size. This is not true in all cases and the spec should document this so implementers remember to accept such files. $ qemu-img create -f qcow2 foo.qcow2 2G Formatting 'foo.qcow2', fmt=qcow2 size=2147483648 encry

Re: [Qemu-devel] [Xen-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-22 Thread Konrad Rzeszutek Wilk
On Thu, May 22, 2014 at 07:39:36AM +0200, Gerd Hoffmann wrote: > Hi, > > > > According to our discussions, I realize we may have some plans or policies > > > dedicated to how to assign devfn, but to support GFX passthrough for XEN, > > > I > > > think currently it may be a better solution to ad

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-22 Thread Alexander Graf
On 22.05.14 01:45, Alexey Kardashevskiy wrote: On 05/22/2014 08:11 AM, Alexander Graf wrote: On 21.05.14 16:21, Alexey Kardashevskiy wrote: At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR spec allows other page sizes and we are going to implement them, we need page size

Re: [Qemu-devel] [PATCH v2 1/2] openpic: Move definition of openpic_reset

2014-05-22 Thread Alexander Graf
On 22.05.14 06:46, Paul Janzen wrote: This patch moves the definition of openpic_reset after the various register read/write functions. No functional change. It is in preparation for using the register read/write functions in openpic_reset. Signed-off-by: Paul Janzen Thanks, applied both to

Re: [Qemu-devel] [Qemu-ppc] [PATCH] openpic: Initialize destmask at reset

2014-05-22 Thread Alexander Graf
On 21.05.14 21:47, Alexander Graf wrote: Am 21.05.2014 um 18:33 schrieb Paul Janzen : On Wed, May 21, 2014 at 12:45 AM, Alexander Graf wrote: Or maybe it's safer overall to just call write_IRQreg_idr() instead of setting idr directly? That would update destmask along the way as well and we

Re: [Qemu-devel] [PATCH 4/7] virtio-blk: use aliases instead of duplicate qdev properties

2014-05-22 Thread Stefan Hajnoczi
On Thu, May 22, 2014 at 12:04 AM, Paolo Bonzini wrote: > Il 21/05/2014 22:22, Stefan Hajnoczi ha scritto: > >> virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the >> qdev properties of their VirtIOBlock child. This approach does not work >> well with string or pointer properties

Re: [Qemu-devel] [PATCH 4/7] virtio-blk: use aliases instead of duplicate qdev properties

2014-05-22 Thread Andreas Färber
Am 22.05.2014 00:04, schrieb Paolo Bonzini: > Il 21/05/2014 22:22, Stefan Hajnoczi ha scritto: >> virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the >> qdev properties of their VirtIOBlock child. This approach does not work >> well with string or pointer properties since we must

Re: [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()

2014-05-22 Thread Stefan Hajnoczi
On Thu, May 22, 2014 at 12:05 AM, Paolo Bonzini wrote: > Il 21/05/2014 22:22, Stefan Hajnoczi ha scritto: >> +void object_property_add_alias(Object *obj, const char *name, >> + Object *target_obj, const char >> *target_name, >> + Error **

Re: [Qemu-devel] [PATCH 4/7] virtio-blk: use aliases instead of duplicate qdev properties

2014-05-22 Thread Stefan Hajnoczi
On Thu, May 22, 2014 at 12:18 PM, Andreas Färber wrote: > Am 22.05.2014 00:04, schrieb Paolo Bonzini: >> Il 21/05/2014 22:22, Stefan Hajnoczi ha scritto: >>> virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the >>> qdev properties of their VirtIOBlock child. This approach does no

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-22 Thread Alexey Kardashevskiy
On 05/22/2014 08:09 PM, Alexander Graf wrote: > > On 22.05.14 01:45, Alexey Kardashevskiy wrote: >> On 05/22/2014 08:11 AM, Alexander Graf wrote: >>> On 21.05.14 16:21, Alexey Kardashevskiy wrote: At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR spec allows other p

Re: [Qemu-devel] [PATCH 4/7] virtio-blk: use aliases instead of duplicate qdev properties

2014-05-22 Thread Andreas Färber
Am 22.05.2014 12:24, schrieb Stefan Hajnoczi: > On Thu, May 22, 2014 at 12:18 PM, Andreas Färber wrote: >> Am 22.05.2014 00:04, schrieb Paolo Bonzini: >>> Il 21/05/2014 22:22, Stefan Hajnoczi ha scritto: virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the qdev propertie

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-22 Thread Alexander Graf
On 22.05.14 12:24, Alexey Kardashevskiy wrote: On 05/22/2014 08:09 PM, Alexander Graf wrote: On 22.05.14 01:45, Alexey Kardashevskiy wrote: On 05/22/2014 08:11 AM, Alexander Graf wrote: On 21.05.14 16:21, Alexey Kardashevskiy wrote: At the moment only 4K pages are supported by sPAPRTCETable.

Re: [Qemu-devel] [PATCH v2] spapr: Enable dynamic change of the supported hypercalls list

2014-05-22 Thread Alexander Graf
On 21.05.14 17:21, Alexey Kardashevskiy wrote: At the moment the "ibm,hypertas-functions" list is fixed. However some calls should be listed there if they are supported by QEMU or the host kernel. This enables hyperrtas_prop to grow on stack by adding a SPAPR_HYPERRTAS_ADD macro. "qemu,hypertas

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-22 Thread Alexey Kardashevskiy
On 05/22/2014 08:45 PM, Alexander Graf wrote: > > On 22.05.14 12:24, Alexey Kardashevskiy wrote: >> On 05/22/2014 08:09 PM, Alexander Graf wrote: >>> On 22.05.14 01:45, Alexey Kardashevskiy wrote: On 05/22/2014 08:11 AM, Alexander Graf wrote: > On 21.05.14 16:21, Alexey Kardashevskiy wrot

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-22 Thread Alexander Graf
On 22.05.14 12:46, Alexey Kardashevskiy wrote: On 05/22/2014 08:45 PM, Alexander Graf wrote: On 22.05.14 12:24, Alexey Kardashevskiy wrote: On 05/22/2014 08:09 PM, Alexander Graf wrote: On 22.05.14 01:45, Alexey Kardashevskiy wrote: On 05/22/2014 08:11 AM, Alexander Graf wrote: On 21.05.14

Re: [Qemu-devel] [RFC 0/3] cpu: add device_add foo-x86_64-cpu support

2014-05-22 Thread Andreas Färber
Hi, Am 22.05.2014 04:33, schrieb chen.fan.f...@cn.fujitsu.com: >I think if we want to use 'device/device_add' to implement CPU, > we must do some check before qemu_init_vcpu(). how can we to do that? We ran into such problems before... If need be, we can change from the old parent_realize sch

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-22 Thread Chen, Tiejun
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, May 22, 2014 2:45 PM > To: Chen, Tiejun > Cc: Anthony PERARD; Daniel P. Berrange; peter.mayd...@linaro.org; > xen-de...@lists.xensource.com; m...@redhat.com; > stefano.stabell...@eu.citrix.com; Kay, Alle

[Qemu-devel] [PATCH 1/2] vmstate: Add helper to enable GHashTable migration

2014-05-22 Thread Alexey Kardashevskiy
This adds a VMSTATE_HASH_V macro. This implements put/get callbacks for it. This implements a qemu_hash_init() wrapper to save key/value sizes. Signed-off-by: Alexey Kardashevskiy --- include/migration/vmstate.h | 10 + include/qemu-common.h | 13 +++ vmstate.c

[Qemu-devel] [PATCH 2/2] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-22 Thread Alexey Kardashevskiy
Currently SPAPR PHB keeps track of all allocated MSI/MISX interrupt as XICS used to be unable to reuse interrupts which becomes a problem for dynamic MSI reconfiguration which is happening on guest driver reload or PCI hot (un)plug. Another problem is that PHB has a limit of devices supporting MSI/

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-22 Thread Alexey Kardashevskiy
On 05/22/2014 05:16 PM, Alexander Graf wrote:> > >> Am 22.05.2014 um 08:53 schrieb Alexey Kardashevskiy : >> >>> On 05/21/2014 10:42 PM, Alexey Kardashevskiy wrote: On 05/21/2014 08:35 PM, Alexander Graf wrote: > On 21.05.14 12:13, Alexey Kardashevskiy wrote: >> On 05/21/2014 0

Re: [Qemu-devel] [PATCH 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-22 Thread Alexey Kardashevskiy
On 05/22/2014 08:48 PM, Alexander Graf wrote: > > On 22.05.14 12:46, Alexey Kardashevskiy wrote: >> On 05/22/2014 08:45 PM, Alexander Graf wrote: >>> On 22.05.14 12:24, Alexey Kardashevskiy wrote: On 05/22/2014 08:09 PM, Alexander Graf wrote: > On 22.05.14 01:45, Alexey Kardashevskiy wrot

Re: [Qemu-devel] [PATCH 1/2] vmstate: Add helper to enable GHashTable migration

2014-05-22 Thread Alexander Graf
On 22.05.14 12:53, Alexey Kardashevskiy wrote: This adds a VMSTATE_HASH_V macro. This implements put/get callbacks for it. This implements a qemu_hash_init() wrapper to save key/value sizes. Signed-off-by: Alexey Kardashevskiy --- include/migration/vmstate.h | 10 + include/qemu-com

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-22 Thread Alexander Graf
On 22.05.14 12:53, Alexey Kardashevskiy wrote: On 05/22/2014 05:16 PM, Alexander Graf wrote:> Am 22.05.2014 um 08:53 schrieb Alexey Kardashevskiy : On 05/21/2014 10:42 PM, Alexey Kardashevskiy wrote: On 05/21/2014 08:35 PM, Alexander Graf wrote: On 21.05.14 12:13, Alexey Kardashevskiy wrot

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Chen, Tiejun
> -Original Message- > From: qemu-devel-bounces+tiejun.chen=intel@nongnu.org > [mailto:qemu-devel-bounces+tiejun.chen=intel@nongnu.org] On Behalf Of > Michael S. Tsirkin > Sent: Thursday, May 22, 2014 3:22 PM > To: Gerd Hoffmann > Cc: qemu-devel@nongnu.org; Anthony Liguori > Subject

[Qemu-devel] [PATCH 0/3] console: text terminal updates

2014-05-22 Thread Gerd Hoffmann
Hi, These tree patches make the text terminal consoles support multiple windows, i.e. work correctly in case a displaychangelistener binds a text terminal explicitly to a fixed QemuConsole by setting dcl->con. Use case: https://www.kraxel.org/cgit/qemu/commit/?h=rebase/ui-gtk-next&id=dc0bdb463

[Qemu-devel] [PATCH 1/3] console: update text terminal surface unconditionally

2014-05-22 Thread Gerd Hoffmann
These days each QemuConsole has its own private DisplaySurface, so we can simply render updates all the time. Signed-off-by: Gerd Hoffmann --- ui/console.c | 127 ++- 1 file changed, 56 insertions(+), 71 deletions(-) diff --git a/ui/consol

Re: [Qemu-devel] [PATCH v2] spapr: Enable dynamic change of the supported hypercalls list

2014-05-22 Thread Alexey Kardashevskiy
On 05/22/2014 08:47 PM, Alexander Graf wrote: > > On 21.05.14 17:21, Alexey Kardashevskiy wrote: >> At the moment the "ibm,hypertas-functions" list is fixed. However some >> calls should be listed there if they are supported by QEMU or the host >> kernel. >> >> This enables hyperrtas_prop to grow

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 10:57:54AM +, Chen, Tiejun wrote: > > -Original Message- > > From: qemu-devel-bounces+tiejun.chen=intel@nongnu.org > > [mailto:qemu-devel-bounces+tiejun.chen=intel@nongnu.org] On Behalf Of > > Michael S. Tsirkin > > Sent: Thursday, May 22, 2014 3:22 PM >

[Qemu-devel] [PATCH 3/3] console: add kbd_put_keysym_console

2014-05-22 Thread Gerd Hoffmann
So you can send keysyms to a specific (text terminal) console. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + ui/console.c | 9 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 8a86617..b513e20 100644

Re: [Qemu-devel] [PATCH v2] spapr: Enable dynamic change of the supported hypercalls list

2014-05-22 Thread Alexander Graf
On 22.05.14 13:01, Alexey Kardashevskiy wrote: On 05/22/2014 08:47 PM, Alexander Graf wrote: On 21.05.14 17:21, Alexey Kardashevskiy wrote: At the moment the "ibm,hypertas-functions" list is fixed. However some calls should be listed there if they are supported by QEMU or the host kernel. Thi

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-22 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Chen, Tiejun > Sent: Thursday, May 22, 2014 6:50 PM > To: Gerd Hoffmann > Cc: peter.mayd...@linaro.org; xen-de...@lists.xensour

Re: [Qemu-devel] [PATCH 1/2] vmstate: Add helper to enable GHashTable migration

2014-05-22 Thread Alexey Kardashevskiy
On 05/22/2014 08:57 PM, Alexander Graf wrote: > > On 22.05.14 12:53, Alexey Kardashevskiy wrote: >> This adds a VMSTATE_HASH_V macro. This implements put/get callbacks for it. >> This implements a qemu_hash_init() wrapper to save key/value sizes. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >

Re: [Qemu-devel] [PATCH 4/7] virtio-blk: use aliases instead of duplicate qdev properties

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 12:17, Stefan Hajnoczi ha scritto: I took a quick look at net, rng, and serial. This approach should work because the VirtIODevice qdev properties need to be exposed wholesale on the transport device. If that's what you're hinting at, I'll try it in v2. Yes, exactly. scsi too.

Re: [Qemu-devel] [PATCH 1/7] qom: add object_property_add_alias()

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 12:23, Stefan Hajnoczi ha scritto: I had an intermediate version of this patch with a flag so you could tell object_property_add_alias() whether or not to ref the target object. But in the end it seems like overengineering since the refcount case is rare or non-existent. The refco

[Qemu-devel] [PATCH V6 0/8] PSCI v0.2 support for KVM ARM/ARM64

2014-05-22 Thread Pranavkumar Sawargaonkar
This patchset adds the QEMU side changes for providing PSCI v0.2 to VM. ChangeLog: V6: - Add psci_version field in ARMCPU struct. - Misc cleanups suggested on RFC V5 of this patch. ( http://www.spinics.net/lists/kvm-arm/msg09400.html) - Dropping RFC prefix from patch. V5: - Updated "scripts/upd

[Qemu-devel] [PATCH V6 2/8] linux-headers: Update KVM headers from linux-next tag next-20140508

2014-05-22 Thread Pranavkumar Sawargaonkar
Syncup KVM related linux headers from linux-next tree using scripts/update-linux-headers.sh. Signed-off-by: Pranavkumar Sawargaonkar Signed-off-by: Anup Patel --- linux-headers/asm-arm/kvm.h | 10 +++-- linux-headers/asm-arm64/kvm.h | 10 +++-- linux-headers/asm-s390/kvm.h | 28 +++

[Qemu-devel] [PATCH V6 3/8] kvm: Handle exit reason KVM_EXIT_SYSTEM_EVENT

2014-05-22 Thread Pranavkumar Sawargaonkar
In-kernel PSCI v0.2 emulation of KVM ARM/ARM64 forwards SYSTEM_OFF and SYSTEM_RESET function calls to QEMU using KVM_EXIT_SYSTEM_EVENT exit reason. This patch updates kvm_cpu_exec() to handle KVM_SYSTEM_EVENT_SHUTDOWN and KVM_SYSTEM_EVENT_RESET system-level events from QEMU-side. Signed-off-by: P

[Qemu-devel] [PATCH V6 1/8] update-linux-headers.sh: Add psci.h to linux header sync-up script

2014-05-22 Thread Pranavkumar Sawargaonkar
We will be using linux/psci.h for KVM ARM/ARM64 hence add it to linux header sync-up script. Signed-off-by: Pranavkumar Sawargaonkar Signed-off-by: Anup Patel --- scripts/update-linux-headers.sh |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/update-linux-header

[Qemu-devel] [PATCH V6 4/8] target-arm: Common kvm_arm_vcpu_init() for KVM ARM and KVM ARM64

2014-05-22 Thread Pranavkumar Sawargaonkar
Introduce a common kvm_arm_vcpu_init() for doing KVM_ARM_VCPU_INIT ioctl in KVM ARM and KVM ARM64. This also helps us factor-out few common code lines from kvm_arch_init_vcpu() for KVM ARM/ARM64. Signed-off-by: Pranavkumar Sawargaonkar Signed-off-by: Anup Patel --- target-arm/cpu-qom.h |3 +

[Qemu-devel] [PATCH v2 7/9] spapr_iommu: Get rid of window_size in sPAPRTCETable

2014-05-22 Thread Alexey Kardashevskiy
This removes window_size as it is basically a copy of nb_table shifted by SPAPR_TCE_PAGE_SHIFT. As new dynamic DMA windows are going to support windows as big as the entire RAM and this number will be bigger that 32 capacity, we will have to do something about @window_size anyway and removal seems

[Qemu-devel] [PATCH V6 7/8] target-arm: Introduce per-CPU field for PSCI version

2014-05-22 Thread Pranavkumar Sawargaonkar
We require to know the PSCI version available to given CPU at potentially many places. Currently, we need to know PSCI version when generating DTB for virt machine. This patch introduce per-CPU 32bit field representing the PSCI version available to the CPU. The encoding of this 32bit field is same

[Qemu-devel] [PATCH V6 5/8] target-arm: Enable KVM_ARM_VCPU_PSCI_0_2 feature when possible

2014-05-22 Thread Pranavkumar Sawargaonkar
Latest linux kernel supports in-kernel emulation of PSCI v0.2 but to enable it we need to select KVM_ARM_VCPU_PSCI_0_2 feature using KVM_ARM_VCPU_INIT ioctl. Also, we can use KVM_ARM_VCPU_PSCI_0_2 feature for VCPU only when linux kernel has KVM_CAP_ARM_PSCI_0_2 capability. This patch updates kvm_

[Qemu-devel] [PATCH V6 6/8] target-arm: Implement kvm_arch_reset_vcpu() for KVM ARM64

2014-05-22 Thread Pranavkumar Sawargaonkar
To implement kvm_arch_reset_vcpu(), we simply re-init the VCPU using kvm_arm_vcpu_init() so that all registers of VCPU are set to their reset values by in-kernel KVM code. Signed-off-by: Pranavkumar Sawargaonkar Signed-off-by: Anup Patel Reviewed-by: Peter Maydell --- target-arm/kvm64.c |4

[Qemu-devel] [PATCH v2 0/9] spapr_pci: Prepare for VFIO

2014-05-22 Thread Alexey Kardashevskiy
This patchset prepares QEMU for VFIO support on SPAPR. It also does preparations for Dynamic DMA window feature which allows to create DMA windows with 16MB IOMMU pages which will allow to map the entire guest RAM for DMA at almost no cost. Changelogs are in the patches. Alexey Kardashevskiy (9):

[Qemu-devel] [PATCH v2 4/9] spapr_pci: spapr_iommu: Make DMA window a subregion

2014-05-22 Thread Alexey Kardashevskiy
Currently the default DMA window is represented by a single MemoryRegion. However there can be more than just one window so we need a "root" memory region to be separated from the actual DMA window(s). This introduces a "root" IOMMU memory region and adds a subregion for the default DMA 32bit wind

[Qemu-devel] [PATCH V6 8/8] hw/arm/virt: Use PSCI v0.2 compatible string when KVM or TCG provides it

2014-05-22 Thread Pranavkumar Sawargaonkar
If we have PSCI v0.2 emulation available for KVM ARM/ARM64 or TCG then we need to provide PSCI v0.2 compatible string via generated DTB. Signed-off-by: Pranavkumar Sawargaonkar Signed-off-by: Anup Patel --- hw/arm/virt.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v2 8/9] spapr_iommu: Introduce page_shift in sPAPRTCETable

2014-05-22 Thread Alexey Kardashevskiy
At the moment only 4K pages are supported by sPAPRTCETable. Since sPAPR spec allows other page sizes and we are going to implement them, we need page size to be configrable. This adds @page_shift into sPAPRTCETable and replaces SPAPR_TCE_PAGE_SHIFT with it whereever it is possible. This removes S

[Qemu-devel] [PATCH 2/3] console: rework text terminal cursor logic

2014-05-22 Thread Gerd Hoffmann
Have a global timer. Update all visible terminal windows syncronously. Right now this can be the active_console only, but that will change soon. The global timer will disable itself if not needed, so we only have to care start it if needed. Which might be at console switch time or when a new dis

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-22 Thread Gerd Hoffmann
Hi, > After applied your patch, 'xen-platform' is always disabled by default, right? Only in case -nodefaults is passed on the qemu command line (don't know whenever libxl does that). > gfx_passthru=1 > pci=["00:02.0@2", "00:1a.0"] > xen_platform_pci=0 ^^ That line isn't need

[Qemu-devel] [PATCH v2 3/9] spapr_pci: Introduce a finish_realize() callback

2014-05-22 Thread Alexey Kardashevskiy
The spapr-pci PHB initializes IOMMU for emulated devices only. The upcoming VFIO support will do it different. However both emulated and VFIO PHB types share most of the initialization code. For the type specific things a new finish_realize() callback is introduced. This introduces sPAPRPHBClass d

[Qemu-devel] [PATCH v2 9/9] spapr_iommu: Introduce bus_offset in sPAPRTCETable

2014-05-22 Thread Alexey Kardashevskiy
This adds @bus_offset into sPAPRTCETable to tell where TCE table starts from. It is set to 0 for emulated devices. Dynamic DMA windows will use other offset. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_iommu.c | 13 + hw/ppc/spapr_pci.c | 5 +++-- hw/ppc/spapr_vio.c

[Qemu-devel] [PATCH v2 6/9] spapr_iommu: Convert old qdev_init_nofail() to object_property_set_bool

2014-05-22 Thread Alexey Kardashevskiy
qdev_init_nofail() was replaced by object_property_set_bool("realized") all over the QEMU so do we. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index 241ceeb..0dd6509

[Qemu-devel] [PATCH v2 2/9] spapr_iommu: Enable multiple TCE requests

2014-05-22 Thread Alexey Kardashevskiy
Currently only single TCE entry per request is supported (H_PUT_TCE). However PAPR+ specification allows multiple entry requests such as H_PUT_TCE_INDIRECT and H_STUFF_TCE. Having less transitions to the host kernel via ioctls, support of these calls can accelerate IOMMU operations. This implement

[Qemu-devel] [PATCH v2 5/9] spapr_pci: Allow multiple TCE tables per PHB

2014-05-22 Thread Alexey Kardashevskiy
At the moment sPAPRPHBState contains a @tcet pointer to the only TCE table. However sPAPR spec allows having more than one DMA window. Since the TCE object is already a child of SPAPR PHB object, there is no need to keep an additional pointer to it in sPAPRPHBState so remove it. This changes the

[Qemu-devel] [PATCH v2 1/9] spapr: Enable dynamic change of the supported hypercalls list

2014-05-22 Thread Alexey Kardashevskiy
At the moment the "ibm,hypertas-functions" list is fixed. However some calls should be listed there if they are supported by QEMU or the host kernel. This enables hyperrtas_prop to grow on stack by adding a SPAPR_HYPERRTAS_ADD macro. "qemu,hypertas-functions" is converted as well. The first user

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-22 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 10:50:10AM +, Chen, Tiejun wrote: > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Thursday, May 22, 2014 2:45 PM > > To: Chen, Tiejun > > Cc: Anthony PERARD; Daniel P. Berrange; peter.mayd...@linaro.org; > > xen-de...@lists.xen

Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging

2014-05-22 Thread Sanidhya Kashyap
On Wed, May 21, 2014 at 12:15 PM, ChenLiang wrote: > On 2014/5/21 12:56, Sanidhya Kashyap wrote: > >> On Wed, May 21, 2014 at 9:43 AM, ChenLiang wrote: >>> Hi, >>> Nice job. We should avoid running migration_thread and >>> bitmap_logging_thread simultaneously. >>> >> Any particular suggestion to

[Qemu-devel] [PATCH] pci: move dereferencing of root only after verifying valid root pointer.

2014-05-22 Thread Saravanakumar
Move dereferencing of root only after verifying valid root pointer. Signed-off-by: Saravanakumar --- hw/pci/pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 22fe5ee..8d6a8d4 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -605,1

Re: [Qemu-devel] [PATCH 7/9] KVM: target-ppc: Enable transactional state migration

2014-05-22 Thread Tom Musta
On 5/21/2014 9:50 PM, Alexey Kardashevskiy wrote: > On 05/22/2014 04:11 AM, Tom Musta wrote: >> On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote: >>> This adds migration support for registers saved before transaction started. >>> [ ... ] >> >> > >> TM is not limited in the ISA to 64-bit implemen

Re: [Qemu-devel] [PATCH] virtio-pci: report an error when disable msix

2014-05-22 Thread Amos Kong
CC: Alex On Thu, May 22, 2014 at 12:11:47PM +0300, Michael S. Tsirkin wrote: > On Thu, May 22, 2014 at 05:02:17PM +0800, Amos Kong wrote: > > QEMU remains 4k memory for PCI BAR, each msix entry takes 16 bytes. > > If user assigns more than 128 vectors, msix resource isn't enough, > > so msix will

Re: [Qemu-devel] [PATCH v2 14/23] target-arm: add banked coprocessor register type and macros

2014-05-22 Thread Aggeler Fabian
On 22 May 2014, at 09:41, Edgar E. Iglesias wrote: > On Tue, May 13, 2014 at 06:15:59PM +0200, Fabian Aggeler wrote: >> Banked CP registers can be defined with a A32_BANKED_REG macro which defines >> a non-secure instance of the register followed by an adjacent secure >> instance. >> Using a un

Re: [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code

2014-05-22 Thread Amos Kong
On Fri, May 16, 2014 at 10:19:02AM -0400, Luiz Capitulino wrote: > On Thu, 8 May 2014 09:14:37 +0800 > Amos Kong wrote: > > > Not a serious issue, but it's helpful if we can fix it. > > > > V2: split change of scripts/qapi-visit.py to a split patch, > > eat space by using a special char as

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Stefano Stabellini
On Thu, 22 May 2014, Gerd Hoffmann wrote: > Patch hooks up the xen platform device to the default device code we > have in qemu. Two effects: > > (1) The device will not be created in case -nodefaults is specified > on the command line. > (2) Autocreating the device is also turned off i

Re: [Qemu-devel] [PATCH v2 14/23] target-arm: add banked coprocessor register type and macros

2014-05-22 Thread Sergey Fedorov
On 22.05.2014 15:49, Aggeler Fabian wrote: > On 22 May 2014, at 09:41, Edgar E. Iglesias wrote: > >> On Tue, May 13, 2014 at 06:15:59PM +0200, Fabian Aggeler wrote: >>> Banked CP registers can be defined with a A32_BANKED_REG macro which defines >>> a non-secure instance of the register followed

Re: [Qemu-devel] [PATCH v2 0/2] dataplane: Enable config-wce

2014-05-22 Thread Stefan Hajnoczi
On Thu, May 15, 2014 at 07:22:04PM +0800, Fam Zheng wrote: > This applies on top of Stefan's dataplane series. > > v2: > > Patch 1 moves the declaration of bdrv_get_aio_context to block.h. > Patch 2 is unchanged except for the dropped #include. > > > Fam Zheng (2): > block: Move declaration o

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

2014-05-22 Thread Michael Mueller
On Thu, 22 May 2014 10:53:38 +0200 Paolo Bonzini wrote: > Il 22/05/2014 10:23, Michael Mueller ha scritto: > > On Wed, 21 May 2014 15:22:35 +0200 > > Alexander Graf wrote: > > > > I have seen the slides from Eduardo which he presented during this years > > DevConf in Brno and made my comments ac

Re: [Qemu-devel] [PATCH] xen: make xen-platform a default device

2014-05-22 Thread Michael S. Tsirkin
On Thu, May 22, 2014 at 01:11:28PM +0100, Stefano Stabellini wrote: > On Thu, 22 May 2014, Gerd Hoffmann wrote: > > Patch hooks up the xen platform device to the default device code we > > have in qemu. Two effects: > > > > (1) The device will not be created in case -nodefaults is specified > >

[Qemu-devel] [PATCH v5 0/3] qapi: fix coding style in generated code

2014-05-22 Thread Amos Kong
Not a serious issue, but it's helpful if we can fix it. V2: split change of scripts/qapi-visit.py to a split patch, eat space by using a special char as Markus suggested V3: update commitlog, update special string, fix of adding const replace string by pattern V4: fix pattern to cleanup sp

[Qemu-devel] [PATCH v5 1/3] qapi: fix coding style in parameters list

2014-05-22 Thread Amos Kong
A space after * when declaring a pointer type is redundant. Signed-off-by: Amos Kong Reviewed-by: Eric Blake Reviewed-by: Paolo Bonzini Reviewed-by: Markus Armbruster --- scripts/qapi-visit.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/q

  1   2   3   >