Fam Zheng f...@redhat.com writes:
On Thu, 06/05 14:15, Markus Armbruster wrote:
When a device model's I/O operation fails, we execute the error
action. This lets layers above QEMU implement thin provisioning, or
attempt to correct errors before they reach the guest. But when the
I/O
On Fri, Jun 06, 2014 at 01:35:10PM +0900, Hitoshi Mitake wrote:
Current sheepdog driver has two problems in a mechanism of inode
object reloading for live snapshot. It causes inconsistent state of
snapshot volumes. A new GC algorithm implemented in sheepdog exposes
the problems. This patchset
Eduardo Habkost ehabk...@redhat.com writes:
When parsing the -smp option, check if the values (that can be anywhere
in the [0, UINT64_MAX] range) are in the int range before setting the
int globals smp_cpus, max_cpus, smp_cores, smp_threads.
Without this, it was posbible to make smp_cpus and
Hi Paolo, Andreas,
This patch series QOMifies Memory regions. This is the Memory API
specific subset of patches forming part of the Memory/GPIO/Sysbus
QOMification.
I think Paolo already has P1 enqeued. Including for ease of review.
some QOM patches in P2-4 that cut down on later boilerplate.
This if else is not needed. The previous call to memory_region_add
(whether _overlap or not) will always set priority and may_overlap
to desired values. And its not possible to get here without having
called memory_region_add_subregion due to the null guard on parent.
So we can just directly call
From: Paolo Bonzini pbonz...@redhat.com
It may be desirable to have custom link properties that do more
than just store an object. Even the addition of a check
function is not enough if setting the link has side effects
or if a non-standard reference counting is preferrable.
Avoid the
Just do nothing if passed NULL for a ref or unref. This avoids
call sites that manage a combination of NULL or non-NULL pointers
having to add iffery around every ref and unref.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
qom/object.c | 14 --
1 file changed, 8
The lower level API object_resolve_path is already published to the
world as part of the QOM API. Add object_resolve link as well. This
allows QOM clients to roll their own link property setters without
having to fallback to the less safe object_resolve_path.
Signed-off-by: Peter Crosthwaite
Split off the core looping code that actually adds subregions into
it's own fn. This prepares support for Memory Region qomification
where setting the MR address or parent via QOM will back onto this more
minimal function.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
memory_region_set_address is mostly just a function that deletes and
re-adds a memory region. Factor this generic functionality out into a
re-usable function. This prepares support for further QOMification
of MemoryRegion.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
QOMify memory regions as an Object. The former init() and destroy()
routines become instance_init() and instance_finalize() resp.
memory_region_init() is re-implemented to be:
object_initialize() + set fields
memory_region_destroy() is re-implemented to call finalize().
Signed-off-by: Peter
Expose the already existing .parent and .addr fields as QOM properties.
.parent (i.e. the field describing the memory region that contains this
one in Memory hierachy) is renamed container. This is to avoid
confusion with the owner field, which is much more akin to an actual QOM
parent.
Setting
QOM propertyify the .may-overlap and .priority fields. The setters
will re-add the memory as a subregion if needed (i.e. the values change
when the memory region is already contained).
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
changed since v2:
Fixed priority getter
To allow devices to dynamically resize the device. The motivation is
to allow devices with variable size to init their memory_region
without size early and then correctly populate size at realize() time.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
memory.c | 38
Alexey Kardashevskiy a...@ozlabs.ru writes:
Hi!
checkpatch.pl often complains on things like this:
===
ERROR: need consistent spacing around '*' (ctx:WxV)
#57: FILE: hw/misc/vfio.c:4323:
+int vfio_container_ioctl(AddressSpace *as, int32_t groupid,
^
On 06/06/2014 04:27 PM, Markus Armbruster wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
Hi!
checkpatch.pl often complains on things like this:
===
ERROR: need consistent spacing around '*' (ctx:WxV)
#57: FILE: hw/misc/vfio.c:4323:
+int vfio_container_ioctl(AddressSpace *as, int32_t
Il 06/06/2014 05:06, Zhang, Yang Z ha scritto:
Paolo Bonzini wrote on 2014-06-03:
Il 30/05/2014 10:59, Tiejun Chen ha scritto:
+static int create_pch_isa_bridge(PCIBus *bus, XenHostPCIDevice *hdev)
+{
+struct PCIDevice *dev;
+
+char rid;
+
+dev = pci_create(bus, PCI_DEVFN(0x1f, 0),
Il 06/06/2014 03:53, Fam Zheng ha scritto:
This unifies the request structure used by dataplane and non-dataplane code,
while dropping unnessary fields for bounce buffer and read flag.
Applies on top of Stefan's block tree.
v3: Address Paolo's comments:
[06/09] virtio-blk: Use
Nothing wrong with Don's patch as far as I can see, but...
Don Slutz dsl...@verizon.com writes:
This can help a user understand why -global was ignored.
For example: with -vga cirrus; -global vga.vgamem_mb=16 is just
ignored when -global cirrus-vga.vgamem_mb=16 is not.
This is currently
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 06/06/2014 04:27 PM, Markus Armbruster wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
Hi!
checkpatch.pl often complains on things like this:
===
ERROR: need consistent spacing around '*' (ctx:WxV)
#57: FILE: hw/misc/vfio.c:4323:
+int
Il 05/06/2014 14:15, Markus Armbruster ha scritto:
When a device model's I/O operation fails, we execute the error
action. This lets layers above QEMU implement thin provisioning, or
attempt to correct errors before they reach the guest. But when the
I/O operation fails because its invalid,
On Wed, 28 May 2014 12:39:17 +0200
Cornelia Huck cornelia.h...@de.ibm.com wrote:
The check for big or little endianness relies on grep reporting
match/non-match on the generated binary. If the user specified
--binary-files=without-match in their GREP_OPTIONS, this will fail.
Let's follow
Il 05/06/2014 20:18, Max Reitz ha scritto:
Why is this design cleaner? Because NBD code doesn't have to worry
about fd handlers. It uses straightforward coroutine send/recv for
socket I/O inside nbd_read_req() and nbd_write_resp(). It's easy to see
that only one coroutine receives from the
Thanks for reply.
And, vhost enabled, tx zero-copy enabled, virtio TSO enabled on kvm.
Try lro ON on client side. This would require mergable Rx buffers to be ON.
current setttings for gro and lro,
generic-receive-offload: on
large-receive-offload: off [fixed]
And Xen netfront to KVM
Il 06/06/2014 09:09, Markus Armbruster ha scritto:
Looks like this regressed in Eduardo's commit 99a0b03 qdev: Set globals
in instance_post_init function.
Before, we exited cleanly on this error, in device_initfn():
qdev_prop_set_globals(dev, err);
if (err != NULL) {
-Original Message-
From: Amos Kong [mailto:ak...@redhat.com]
Sent: Friday, June 06, 2014 1:29 PM
To: Gonglei (Arei)
Cc: qemu-devel@nongnu.org; stefa...@gmail.com; afaer...@suse.de
Subject: Re: [PATCH v3 3/4] virtio-blk-test.c: add hotplug subtest
On Fri, Jun 06, 2014 at 01:28:59AM
Il 06/06/2014 09:41, Cornelia Huck ha scritto:
On Wed, 28 May 2014 12:39:17 +0200
Cornelia Huck cornelia.h...@de.ibm.com wrote:
The check for big or little endianness relies on grep reporting
match/non-match on the generated binary. If the user specified
--binary-files=without-match in their
Dr. David Alan Gilbert dgilb...@redhat.com writes:
* Markus Armbruster (arm...@redhat.com) wrote:
Dr. David Alan Gilbert (git) dgilb...@redhat.com writes:
Hi Markus,
Thanks for the review. I've reordered your comments to group some of the
replies together.
From: Dr. David Alan
On Fri, Jun 06, 2014 at 08:05:15AM +, Gonglei (Arei) wrote:
-Original Message-
From: Amos Kong [mailto:ak...@redhat.com]
Sent: Friday, June 06, 2014 1:29 PM
To: Gonglei (Arei)
Cc: qemu-devel@nongnu.org; stefa...@gmail.com; afaer...@suse.de
Subject: Re: [PATCH v3 3/4]
On Fri, 06 Jun 2014 10:11:27 +0200
Paolo Bonzini pbonz...@redhat.com wrote:
Il 06/06/2014 09:41, Cornelia Huck ha scritto:
On Wed, 28 May 2014 12:39:17 +0200
Cornelia Huck cornelia.h...@de.ibm.com wrote:
The check for big or little endianness relies on grep reporting
match/non-match on
Paolo Bonzini pbonz...@redhat.com writes:
Il 05/06/2014 14:15, Markus Armbruster ha scritto:
When a device model's I/O operation fails, we execute the error
action. This lets layers above QEMU implement thin provisioning, or
attempt to correct errors before they reach the guest. But when
Hi,
On Wed, Jun 04, 2014 at 09:49:00AM +0200, Natanael Copa wrote:
The __SIGRTMIN and __SIGRTMAX are glibc internals and are not available
on all platforms, so we define those if they are missing. We also check
that those corresponds with the posix variables SIGRTMIN/SIGRTMAX which
may only
Am 05.06.2014 um 16:52 hat Benoît Canet geschrieben:
The Thursday 05 Jun 2014 à 15:36:23 (+0200), Kevin Wolf wrote :
Some code in the block layer makes potentially huge allocations. Failure
is not completely unexpected there, so avoid aborting qemu and handle
out-of-memory situations
On Thu, Jun 5, 2014 at 6:18 PM, Michael S. Tsirkin m...@redhat.com wrote:
On Thu, Jun 05, 2014 at 05:31:45PM +0200, Stefan Hajnoczi wrote:
qemu-iotests ./check -qcow2 067 is entering an infinite loop during
system_reset. This failure is a non-deterministic use-after-free and
the infinite loop
Hello,
v2:
- Tabs-spaces (Dave Gilbert)
- Several changes to the python script to make it more python-like
(Vitaly Kuznetsov)
- Don't store the empty fields created by VMSTATE_VALIDATE in the
json output
This series adds a static vmstate checker to check for breakage of
live migration
This commit adds a new command, '-dump-vmstate', that takes a filename
as a parameter. When executed, QEMU will dump the vmstate information
for the machine type it's invoked with to the file, and quit.
The JSON-format output can then be used to compare the vmstate info for
different QEMU
This script compares the vmstate dumps in JSON format as output by QEMU
with the -dump-vmstate option.
It flags various errors, like version mismatch, sections going away,
size mismatches, etc.
This script is tolerant of a few changes that do not change the on-wire
format, like embedding a few
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 0a8b81d..f405534 100644
---
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f405534..36a9b4b 100644
---
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f6b52d0..34bfbf6 100644
---
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 4ccfd67..f6b52d0 100644
---
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 36a9b4b..4ccfd67 100644
---
This commit modifies the dump2 data to flag incompatibilities in the
machine types being compared.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 114 +--
1 file changed, 1 insertion(+), 113 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 27 +--
1 file changed, 1 insertion(+), 26 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 13 -
1 file changed, 13 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 05b8fce..6f8a617 100644
---
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 33 +---
1 file changed, 1 insertion(+), 32 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index
On Thu, Jun 05, 2014 at 02:21:42PM +0100, Peter Maydell wrote:
On 5 June 2014 14:11, Riku Voipio riku.voi...@iki.fi wrote:
Hi,
On Tue, Jun 03, 2014 at 03:07:59PM +0100, Peter Maydell wrote:
Ping!
Looks good, I'll collect this and other linux-user patches and submit
linux-user
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 15 ---
1 file changed, 15 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 6f8a617..b5cb1aa 100644
---
This shows how the script deals with substructures added to vmstate
descriptions that don't change the on-wire format.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 115 +++
1 file changed, 64 insertions(+), 51
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 45cccaf..75719f5 100644
---
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 34bfbf6..f69966d 100644
---
On Fri, May 30, 2014 at 09:59:55AM +0200, Igor Mammedov wrote:
On Fri, 30 May 2014 00:05:51 +1000
Peter Crosthwaite peter.crosthwa...@xilinx.com wrote:
On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov imamm...@redhat.com wrote:
Provides framework for splitting host RAM allocation/
Best regards,
-Gonglei
-Original Message-
From: Amos Kong [mailto:ak...@redhat.com]
Sent: Friday, June 06, 2014 4:24 PM
To: Gonglei (Arei)
Cc: qemu-devel@nongnu.org; stefa...@gmail.com; afaer...@suse.de
Subject: Re: [PATCH v3 3/4] virtio-blk-test.c: add hotplug subtest
On
Il 06/06/2014 08:11, Peter Crosthwaite ha scritto:
Hi Paolo, Andreas,
This patch series QOMifies Memory regions. This is the Memory API
specific subset of patches forming part of the Memory/GPIO/Sysbus
QOMification.
I think Paolo already has P1 enqeued. Including for ease of review.
some QOM
Signed-off-by: Amit Shah amit.s...@redhat.com
---
tests/vmstate-static-checker-data/dump1.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump1.json
b/tests/vmstate-static-checker-data/dump1.json
index 44200fb..786ca0b 100644
---
On (Thu) 29 May 2014 [21:36:39], Laszlo Ersek wrote:
In this series I try to implement the ideas that (I believe) were
suggested by Gerd and Amit in
https://bugzilla.redhat.com/show_bug.cgi?id=1080376.
When the guest agent exits or dies (disconnects from the virtio-serial
port), the backend
From: Riku Voipio riku.voi...@linaro.org
Make all implementations of setup_sigcontext void and
remove checking it's return value from functions calling
setup_sigcontext.
Signed-off-by: Riku Voipio riku.voi...@linaro.org
---
linux-user/signal.c | 65
From: Riku Voipio riku.voi...@linaro.org
As __get_user and __put_user do not return errors, remove the
if checks from around them. This allows making the save/restore
functions void.
Signed-off-by: Riku Voipio riku.voi...@linaro.org
Cc: Alexander Graf ag...@suse.de
---
linux-user/signal.c | 126
From: Riku Voipio riku.voi...@linaro.org
Remove if(__get_user checks and their related error paths
for all architecture's do_sigreturn. Remove the unlock_user_struct
when the only way to end up there is from failed lock_user_struct.
Signed-off-by: Riku Voipio riku.voi...@linaro.org
---
From: Riku Voipio riku.voi...@linaro.org
make most implementations of restore_sigcontext void and
remove checking it's return value from functions calling
restore_sigcontext.
The exception is the X86 version of the function that is
too different from others to deal in this way.
Signed-off-by:
From: Riku Voipio riku.voi...@linaro.org
Remove all the simple cases of reading the return value
of __get_user and __put_user.
We set err = 0 in sparc versions of do_sigreturn and
sparc64_set_context to avoid compile error, but else this patch is
just general removal of err |= __get_user ...
From: Riku Voipio riku.voi...@linaro.org
Remove if(__put_user checks and their related error paths
for all architecture's setup_frame, setup_rt_frame and similar.
Remove the unlock_user_struct when the only way to end up there is
from failed lock_user_struct.
Remove err variable if there are no
From: Riku Voipio riku.voi...@linaro.org
Remove the remaining check for __put_user return
value, and all the checks for err variable which
isn't set anywhere anymore.
No we can only end up in give_sigsegv due to failed
lock_user_struct - thus we remove the unlock_user_struct
to avoid unlocking a
Am 05.06.2014 um 17:09 hat Benoît Canet geschrieben:
The Thursday 05 Jun 2014 à 15:36:26 (+0200), Kevin Wolf wrote :
Some code in the block layer makes potentially huge allocations. Failure
is not completely unexpected there, so avoid aborting qemu and handle
out-of-memory situations
Il 06/06/2014 11:03, Stefan Hajnoczi ha scritto:
commit 5c21ce77d7e5643089ceec556c0408445d017f32
Author: Bandan Das b...@redhat.com
Date: Wed Mar 12 21:02:12 2014 +0100
qdev: Realize buses on device realization
Integrate (un)realization of child buses with realization/unrealization
Il 06/06/2014 10:27, Riku Voipio ha scritto:
Hi,
On Wed, Jun 04, 2014 at 09:49:00AM +0200, Natanael Copa wrote:
The __SIGRTMIN and __SIGRTMAX are glibc internals and are not available
on all platforms, so we define those if they are missing. We also check
that those corresponds with the posix
From: Riku Voipio riku.voi...@linaro.org
gcc-4.9 finds unused operand:
linux-user/syscall.c: In function ‘host_to_target_stat64’:
linux-user/qemu.h:301:19: error: right-hand operand of comma expression
has no effect [-Werror=unused-value]
((hptr), (x)), 0)
Just removing the rh operand is
On 6 June 2014 02:47, Mike Frysinger vap...@gentoo.org wrote:
The current script isn't terribly friendly -- you basically get one chance
to run it per boot w/out manually recovering the system state.
It also doesn't lend itself to being made into an init script w/out a lot
of manual editing.
From: Riku Voipio riku.voi...@linaro.org
Since copy_siginfo_to_user always returns 0, make it void
and remove any checks for return value from calling functions.
Signed-off-by: Riku Voipio riku.voi...@linaro.org
---
linux-user/signal.c | 28 +---
1 file changed, 9
From: Riku Voipio riku.voi...@linaro.org
A function never called from anywhere, obviously half-complete.
Remove function and if someone wants to complete this, please
check the old version out of git history.
Signed-off-by: Riku Voipio riku.voi...@linaro.org
---
linux-user/signal.c | 37
From: Riku Voipio riku.voi...@linaro.org
This series is a cleanup and gcc-4.9 buildfix:
linux-user/syscall.c: In function ‘host_to_target_stat64’:
linux-user/qemu.h:301:19: error: right-hand operand of comma expression has no
effect [-Werror=unused-value]
((hptr), (x)), 0)
removing the
On Fri, Jun 06, 2014 at 09:31:57AM +, Gonglei (Arei) wrote:
-Original Message-
From: Amos Kong [mailto:ak...@redhat.com]
Sent: Friday, June 06, 2014 4:24 PM
To: Gonglei (Arei)
Cc: qemu-devel@nongnu.org; stefa...@gmail.com; afaer...@suse.de
Subject: Re: [PATCH v3 3/4]
When I try to use vhost-scsi, qemu 1.6.1 segmentation fault. The following is
the cmdline option.
qemu-system-x86_64 -m 1024 -device vhost-scsi-pci,id=vhost-scsi0,wwpn=iqn.zw
-monitor stdio
I analyzed the core file, the detail attached at the last!
I found that vhost_scsi_realize() called
Sorry, That's
Try Rx/Tx checksum offload OFF on the all the concerned guests of both
Hypervisors.
-Original Message-
From: Venkateswara Rao Nandigam
Sent: Friday, June 06, 2014 12:43 PM
To: 'Zhang Haoyu'; kvm; qemu-devel
Cc: Gleb Natapov; Paolo Bonzini; Michael S.Tsirkin; yewudi
And, vhost enabled, tx zero-copy enabled, virtio TSO enabled on kvm.
Try lro ON on client side. This would require mergable Rx buffers to be ON.
And Xen netfront to KVM virtio are not apples to apples because of their
implementation details.
Try Rx/Tx checksum offload on the all the
Sorry, correction,
Try Rx/Tx checksum offload on the all the concerned guests of both
Hypervisors.
Already ON on both hypervisors, so some other offloadings(e.g. tso, gso) can
be supported.
Try Rx/Tx checksum offload OFF on the all the concerned guests of both
Hypervisors
And While
Try Rx/Tx checksum offload on the all the concerned guests of both
Hypervisors.
Already ON on both hypervisors, so some other offloadings(e.g. tso, gso) can
be supported.
Try Rx/Tx checksum offload OFF on the all the concerned guests of both
Hypervisors
Off Rx/Tx checksum
Doesn't that answer your original question about performance gap!
-Original Message-
From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf Of
Zhang Haoyu
Sent: Friday, June 06, 2014 3:44 PM
To: Venkateswara Rao Nandigam; kvm; qemu-devel
Cc: Gleb Natapov; Paolo
From: Riku Voipio riku.voi...@linaro.org
Access is already checked in the lock_user_struct
call before.
Signed-off-by: Riku Voipio riku.voi...@linaro.org
---
linux-user/signal.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/linux-user/signal.c
From: Riku Voipio riku.voi...@linaro.org
The last remaining check for return value of __get_user.
Signed-off-by: Riku Voipio riku.voi...@linaro.org
Cc: Alexander Graf ag...@suse.de
---
linux-user/signal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/linux-user/signal.c
From: Riku Voipio riku.voi...@linaro.org
Remove checks of __get_user and the err variable
used to control flow with it.
Signed-off-by: Riku Voipio riku.voi...@linaro.org
---
linux-user/signal.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/linux-user/signal.c
-Original Message-
From: Amos Kong [mailto:ak...@redhat.com]
Sent: Friday, June 06, 2014 6:11 PM
To: Gonglei (Arei)
Cc: qemu-devel@nongnu.org; stefa...@gmail.com; afaer...@suse.de
Subject: Re: [PATCH v3 3/4] virtio-blk-test.c: add hotplug subtest
On Fri, Jun 06, 2014 at 09:31:57AM
On 06.06.14 04:37, Eduardo Habkost wrote:
On Fri, Jun 06, 2014 at 03:21:04AM +0200, Borislav Petkov wrote:
On Fri, Jun 06, 2014 at 12:24:26AM +0200, Alexander Graf wrote:
But can we drop the EMULATED name somehow? Can we rename [1] the ioctl
to say GET_UNSUPPORTED_CPUID or something along
The Thursday 05 Jun 2014 à 15:36:23 (+0200), Kevin Wolf wrote :
Some code in the block layer makes potentially huge allocations. Failure
is not completely unexpected there, so avoid aborting qemu and handle
out-of-memory situations gracefully.
This patch addresses the allocations in the
The Thursday 05 Jun 2014 à 15:36:26 (+0200), Kevin Wolf wrote :
Some code in the block layer makes potentially huge allocations. Failure
is not completely unexpected there, so avoid aborting qemu and handle
out-of-memory situations gracefully.
This patch addresses the allocations in the
* Markus Armbruster (arm...@redhat.com) wrote:
Dr. David Alan Gilbert dgilb...@redhat.com writes:
* Markus Armbruster (arm...@redhat.com) wrote:
Dr. David Alan Gilbert (git) dgilb...@redhat.com writes:
Hi Markus,
Thanks for the review. I've reordered your comments to group some
On Thu, 5 Jun 2014, Don Slutz wrote:
This is the xen part of pc q35: Add new machine opt max-ram-below-4g
Signed-off-by: Don Slutz dsl...@verizon.com
Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com
v4:
Pass is_default instead of max_ram_below_4g.
Also did not add
On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote:
* Peter Lieven (p...@kamp.de) wrote:
if a saved vm has unknown flags in the memory data qemu
currently simply ignores this flag and continues which
yields in an unpredictable result.
this patch catches all unknown flags and
Mike Frysinger writes:
The current script isn't terribly friendly -- you basically get one chance
to run it per boot w/out manually recovering the system state.
See also the discussion for:
https://patches.linaro.org/22974/
I think there is at least one other patch that was suggested that I
We're interested in this patch, is there an updated version (I'd rather not
try to fix the deprecated timer function myself), we can try? We have a
very easy way to reproduce this problem in Real Life (VMs connecting to a
scst target server) so if nothing else we can provide some testing. :)
--
This also generates warnings during make check:
GTESTER check-qtest-i386
blkdebug: Suspended request 'A'
blkdebug: Resuming request 'A'
main-loop: WARNING: I/O thread spun for 1000 iterations
acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-6P9HHX.dsl,
aml:/tmp/aml-ACAIHX], Expected
KVM tells us the number of GSIs it can handle inside the kernel. That value is
basically KVM_MAX_IRQ_ROUTES. However when we try to set the GSI mapping table,
it checks for
r = -EINVAL;
if (routing.nr = KVM_MAX_IRQ_ROUTES)
goto out;
erroring out even when we're only using all of
On Fri, 6 Jun 2014 17:29:38 +0800
Hu Tao hu...@cn.fujitsu.com wrote:
On Fri, May 30, 2014 at 09:59:55AM +0200, Igor Mammedov wrote:
On Fri, 30 May 2014 00:05:51 +1000
Peter Crosthwaite peter.crosthwa...@xilinx.com wrote:
On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov
On (Thu) 27 Mar 2014 [14:57:26], Alexey Kardashevskiy wrote:
The existing timeout is 30ms which on 100MB/s (1Gbit) gives us
3MB/s rate maximum. If we put some load on the guest, it is easy to
get page dirtying rate too big so live migration will never complete.
In the case of libvirt that
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/qapi.c | 13 ++---
include/block/qapi.h | 7 ---
2 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/block/qapi.c b/block/qapi.c
index 97e1641..f420e9a 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@
Init and uninit suggest the functions don't allocate / free
storage. But they do.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c| 14 +++---
device-hotplug.c | 2 +-
hw/usb/dev-storage.c | 2 +-
include/sysemu/blockdev.h | 4 ++--
vl.c
On 06/06/2014 03:46 AM, riku.voi...@linaro.org wrote:
From: Riku Voipio riku.voi...@linaro.org
Remove all the simple cases of reading the return value
of __get_user and __put_user.
You may want to investigate your patch mail setup. Your threading was
broken - this (and the other 12 patches)
It's always one since commit fa510eb dropped the last drive_get_ref().
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c| 18 ++
device-hotplug.c | 2 +-
hw/ide/piix.c | 2 +-
include/sysemu/blockdev.h | 4 +---
4 files
Markus Armbruster (3):
blockdev: Rename drive_init(), drive_uninit() to drive_new(),
drive_del()
blockdev: Remove unused DriveInfo reference count
block/qapi: Give some functions internal linkage
block/qapi.c | 13 ++---
blockdev.c| 28
1 - 100 of 266 matches
Mail list logo
