Re: [Qemu-devel] master: intermittent acpi-test failures

2014-06-08 Thread Michael S. Tsirkin
On Tue, May 27, 2014 at 10:38:17PM +0100, Peter Maydell wrote: I'm seeing this test failure intermittently on 'make check': ERROR:/root/qemu/tests/acpi-test.c:618:test_acpi_one: assertion failed (signature == SIGNATURE): (0x == 0xdead) GTester: last random seed:

Re: [Qemu-devel] [PATCH v4 33/33] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines

2014-06-08 Thread Michael S. Tsirkin
On Fri, Jun 06, 2014 at 05:23:06PM +0200, Igor Mammedov wrote: On Fri, 06 Jun 2014 08:44:23 -0400 Don Slutz dsl...@verizon.com wrote: This also generates warnings during make check: GTESTER check-qtest-i386 blkdebug: Suspended request 'A' blkdebug: Resuming request 'A'

Re: [Qemu-devel] checkpatch.pl question

2014-06-08 Thread Paolo Bonzini
Il 07/06/2014 18:27, Peter Maydell ha scritto: On 7 June 2014 17:00, Stefan Weil s...@weilnetz.de wrote: Am 07.06.2014 16:58, schrieb Peter Maydell: It's clearly something to do with it getting confused by the type name, because you can suppress the warning by just changing it so it has an _t

Re: [Qemu-devel] master: intermittent acpi-test failures

2014-06-08 Thread Peter Maydell
On 8 June 2014 08:37, Michael S. Tsirkin m...@redhat.com wrote: On Tue, May 27, 2014 at 10:38:17PM +0100, Peter Maydell wrote: I'm seeing this test failure intermittently on 'make check': ERROR:/root/qemu/tests/acpi-test.c:618:test_acpi_one: assertion failed (signature == SIGNATURE):

Re: [Qemu-devel] [PATCH v3.2 07/31] vl: redo -object parsing

2014-06-08 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 05:43:11PM +0800, Hu Tao wrote: From: Paolo Bonzini pbonz...@redhat.com Follow the lines of the HMP implementation, using OptsVisitor to parse the options. This gives access to OptsVisitor's rich parsing of integer lists. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v3.2 10/31] pc: pass QEMUMachineInitArgs to pc_memory_init

2014-06-08 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 05:43:14PM +0800, Hu Tao wrote: From: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com This conflicts with commit

Re: [Qemu-devel] [PATCH v3.2 01/31] NUMA: move numa related code to new file numa.c

2014-06-08 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 05:43:05PM +0800, Hu Tao wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao

Re: [Qemu-devel] [PATCH v3.2 06/31] man: improve -numa doc

2014-06-08 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 05:43:10PM +0800, Hu Tao wrote: From: Luiz Capitulino lcapitul...@redhat.com The -numa option documentation in qemu's manpage lacks the command-line options and some information regarding how it relates to options -m and -smp. This commit fills in the missing text.

Re: [Qemu-devel] [PATCH v3.2 27/31] qapi: make string input visitor parse int list

2014-06-08 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 05:43:31PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com Conflicts with commit e2cd0f4fb42b1fae65ad22e8efde9804446e6254 qapi: Replace start_optional()/end_optional() by optional() needs a rebase. --- qapi/string-input-visitor.c | 181

Re: [Qemu-devel] [PATCH v3.2 02/31] NUMA: check if the total numa memory size is equal to ram_size

2014-06-08 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 05:43:06PM +0800, Hu Tao wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI table, then the guest will ignore the wrong ACPI table and

Re: [Qemu-devel] [PATCH v3.2 31/31] hmp: add info memdev

2014-06-08 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 05:43:35PM +0800, Hu Tao wrote: This is the hmp counterpart of qmp query-memdev. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hmp.c | 36 hmp.h | 1 + monitor.c | 7 +++ 3 files changed, 44 insertions(+) diff

Re: [Qemu-devel] [PATCH v3.2 11/31] numa: introduce memory_region_allocate_system_memory

2014-06-08 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 05:43:15PM +0800, Hu Tao wrote: From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/i386/pc.c| 4 +--- include/hw/boards.h | 6 +- include/sysemu/sysemu.h |

Re: [Qemu-devel] [PATCH v3.2 00/31] NUMA series, and hostmem improvements

2014-06-08 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 05:43:04PM +0800, Hu Tao wrote: changes to v3.1: - return -1 in object_create() if there is an error (patch 07) - configure: change 'numactl' to 'numactl devel' (patch 24) - configure: error out if numactl-devel is not installed and user requests numa

Re: [Qemu-devel] [PATCH 2/3] console: rework text terminal cursor logic

2014-06-08 Thread Ian Campbell
On Thu, 2014-05-22 at 13:00 +0200, Gerd Hoffmann wrote: Have a global timer. Update all visible terminal windows syncronously. Right now this can be the active_console only, but that will change soon. The global timer will disable itself if not needed, so we only have to care start it if

Re: [Qemu-devel] Use-after-free during unrealize in system_reset

2014-06-08 Thread Michael S. Tsirkin
On Fri, Jun 06, 2014 at 11:52:46AM +0200, Paolo Bonzini wrote: Il 06/06/2014 11:03, Stefan Hajnoczi ha scritto: commit 5c21ce77d7e5643089ceec556c0408445d017f32 Author: Bandan Das b...@redhat.com Date: Wed Mar 12 21:02:12 2014 +0100 qdev: Realize buses on device realization

Re: [Qemu-devel] master: intermittent acpi-test failures

2014-06-08 Thread Michael S. Tsirkin
On Sun, Jun 08, 2014 at 09:48:39AM +0100, Peter Maydell wrote: On 8 June 2014 08:37, Michael S. Tsirkin m...@redhat.com wrote: On Tue, May 27, 2014 at 10:38:17PM +0100, Peter Maydell wrote: I'm seeing this test failure intermittently on 'make check':

Re: [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set

2014-06-08 Thread Michael S. Tsirkin
On Fri, Jun 06, 2014 at 10:26:15PM -0300, Eduardo Habkost wrote: It would be much better if we didn't terminate QEMU inside device_post_init(), but at least exiting cleanly is better than aborting and dumping core. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Michael S.

Re: [Qemu-devel] [PATCH] qdev: Move global validation to a single function

2014-06-08 Thread Michael S. Tsirkin
On Fri, Jun 06, 2014 at 11:24:49PM -0300, Eduardo Habkost wrote: This simplifies the global validation code so all its logic is contained in a single function, and fixes the following: $ qemu-system-x86_64 -global container.xxx=y hw/core/qdev-properties-system.c:450:qdev_add_one_global:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/sd/sd.c: Drop unused sd_acmd_type[] array

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] util/qemu-sockets.c: Avoid unused variable warnings

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/dma/xilinx_axidma: Remove unused stream_halted() function

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/isa/pc87312: Remove unused function is_parallel_epp()

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/intc/openpic: Remove unused function IRQ_testbit()

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/misc/milkymist-softusb: Remove unused softusb_{read, write}_pmem()

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-i386/translate.c: Remove unused tcg_gen_lshift()

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [network performance question] only ~2Gbpsthroughputbetweentwo linux guests which are running on the same host vianetperf-tTCP_STREAM -m 1400, but xen can ac

2014-06-08 Thread Michael S. Tsirkin
I see that RX checksumming is still off for you on virtio, this is likely what's contribution to the problem. Here's how it looks for me: ethtool -k eth1 Offload parameters for eth1: rx-checksumming: on tx-checksumming: on scatter-gather: on

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-microblaze: Delete unused sign_extend() function

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] AArch64 QEMU System emulation: issue with TTBR0

2014-06-08 Thread Ian Campbell
On Tue, 2014-06-03 at 14:28 +0200, Claudio Fontana wrote: Thank you for the clarifications and advice, I think executable permissions might be involved, as removing the NX / PNX check in get_phys_addr_lpae() makes it proceed ahead I'm seeing something very similar running modprobe, I get a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/net/eepro100: Implement read-only bits in MDI registers

2014-06-08 Thread Michael Tokarev
07.06.2014 20:52, Peter Maydell wrote: Although we defined an eepro100_mdi_mask[] array indicating which bits in the registers are read-only, we weren't actually doing anything with it. Make the MDI register-read code use it rather than manually making registers 2 and 3 totally read-only and

Re: [Qemu-devel] [PATCH v4 26/33] acpi:ich9: add memory hotplug handling

2014-06-08 Thread Michael S. Tsirkin
On Mon, Jun 02, 2014 at 03:25:22PM +0200, Igor Mammedov wrote: Add memory hotplug initialization/handling to ICH9 LPC device and enable it by default for post 2.0 machine types Signed-off-by: Igor Mammedov imamm...@redhat.com I applied this, resolving a conflict. Minor comments below, would

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-08 Thread Michael Tokarev
07.06.2014 21:08, Peter Maydell wrote: The tcg_out* and tcg_patch* functions are utility routines that may or may not be used by a particular backend; mark them with the 'unused' attribute to suppress spurious warnings if they aren't used. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/net/ne2000-isa: Register vmstate struct

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

[Qemu-devel] [50809c8] Attempt to boot a guest results in - qemu: could not load PC BIOS 'bios-256k.bin'

2014-06-08 Thread Kashyap Chamarthy
Heya, I built QEMU from this commit: $ git log | head -2 commit 50809c8b9288a9bfe1fdec926b7ef985608a7ea6 Merge: 4e627ae ae74bbe And, attempted to boot a Fedora guest via this QEMU CLI results as below: $ /usr/local/sbin/qemu-system-x86_64 -s -S -nographic \ -nodefconfig

Re: [Qemu-devel] AArch64 QEMU System emulation: issue with TTBR0

2014-06-08 Thread Peter Maydell
On 8 June 2014 12:26, Ian Campbell i...@hellion.org.uk wrote: On Tue, 2014-06-03 at 14:28 +0200, Claudio Fontana wrote: Thank you for the clarifications and advice, I think executable permissions might be involved, as removing the NX / PNX check in get_phys_addr_lpae() makes it proceed ahead

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/net/eepro100: Implement read-only bits in MDI registers

2014-06-08 Thread Peter Maydell
On 8 June 2014 12:31, Michael Tokarev m...@tls.msk.ru wrote: 07.06.2014 20:52, Peter Maydell wrote: Although we defined an eepro100_mdi_mask[] array indicating which bits in the registers are read-only, we weren't actually doing anything with it. Make the MDI register-read code use it rather

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-08 Thread Peter Maydell
On 8 June 2014 13:11, Michael Tokarev m...@tls.msk.ru wrote: 07.06.2014 21:08, Peter Maydell wrote: The tcg_out* and tcg_patch* functions are utility routines that may or may not be used by a particular backend; mark them with the 'unused' attribute to suppress spurious warnings if they aren't

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/net/eepro100: Implement read-only bits in MDI registers

2014-06-08 Thread Michael Tokarev
08.06.2014 16:27, Peter Maydell wrote: On 8 June 2014 12:31, Michael Tokarev m...@tls.msk.ru wrote: 07.06.2014 20:52, Peter Maydell wrote: Although we defined an eepro100_mdi_mask[] array indicating which bits in the registers are read-only, we weren't actually doing anything with it. Make

Re: [Qemu-devel] [PATCH] apb: Fix compiler warnings (large constants)

2014-06-08 Thread Mark Cave-Ayland
On 07/06/14 19:54, Stefan Weil wrote: Both constants need more than 32 bit. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/pci-host/apb.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c index 1497008..6fa2723 100644 ---

Re: [Qemu-devel] [PATCH v4 00/33] pc: ACPI memory hotplug

2014-06-08 Thread Michael S. Tsirkin
On Mon, Jun 02, 2014 at 03:24:56PM +0200, Igor Mammedov wrote: NOTE to commiter: * update precompiled ACPI hex files for iasl-less hosts and ACPI tables test to match new ACPI tables. Applied, thanks everyone! What's new since v10: * rename DimmDevice to PCDIMMDevice * allow

Re: [Qemu-devel] [Qemu-trivial] [PATCH] apb: Fix compiler warnings (large constants)

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vdi: remove double conversion

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] x86: correctly implement soft reset

2014-06-08 Thread Michael Tokarev
06.06.2014 18:06, Paolo Bonzini wrote: Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. These only reset the CPU. I'm not sure how this is -trivial material? :) Thanks, /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] smbios: use g_free directly on NULL pointers

2014-06-08 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] AArch64 QEMU System emulation: issue with TTBR0

2014-06-08 Thread Ian Campbell
On Sun, 2014-06-08 at 13:19 +0100, Peter Maydell wrote: On 8 June 2014 12:26, Ian Campbell i...@hellion.org.uk wrote: On Tue, 2014-06-03 at 14:28 +0200, Claudio Fontana wrote: Thank you for the clarifications and advice, I think executable permissions might be involved, as removing the NX /

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cpu/x86: correctly set errors in x86_cpu_parse_featurestr

2014-06-08 Thread Michael Tokarev
06.06.2014 17:21, Paolo Bonzini wrote: Because of the goto out, the contents of local_err are leaked and lost. Might just as well change 'goto out' to 'break' (instead of return), and handle the `if (local_err)' like you did. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] libcacard: Drop superfluous conditionals around g_free()

2014-06-08 Thread Michael Tokarev
Applied both to -trivial, thank you! /mjt

[Qemu-devel] [PATCH] target-arm: A64: Correct handling of UXN bit.

2014-06-08 Thread Ian Campbell
In v8 page tables bit 54 in the PTE is UXN in the EL0/EL1 translation regimes and XN elsewhere. In v7 the bit is always XN. Since we only emulate EL0/EL1 we can just treat this bit as UXN whenever we are in v8 mode. Also correctly extract the upper attributes from the PTE entry, the v8 version

Re: [Qemu-devel] AArch64 QEMU System emulation: issue with TTBR0

2014-06-08 Thread Ian Campbell
On Sun, 2014-06-08 at 14:27 +0100, Ian Campbell wrote: get_phys_addr_lpae: XN == 1000 yes, PXN == 800 no Which I think is correct. Aha, for VMSA-v8 bit 54 is UXN unlike v7 where it is just XN. So that's the underlying bug I'm seeing I think... I'll confirm and post a patch.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] readline: Clear screen on form feed.

2014-06-08 Thread Michael Tokarev
01.06.2014 15:53, Hani Benhabiles wrote: Signed-off-by: Hani Benhabiles h...@linux.com --- util/readline.c | 9 + 1 file changed, 9 insertions(+) diff --git a/util/readline.c b/util/readline.c index 8baec55..08d07e3 100644 --- a/util/readline.c +++ b/util/readline.c @@ -345,6

Re: [Qemu-devel] [PATCH] apb: Fix compiler warnings (large constants)

2014-06-08 Thread Stefan Weil
Am 08.06.2014 14:48, schrieb Mark Cave-Ayland: On 07/06/14 19:54, Stefan Weil wrote: Both constants need more than 32 bit. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/pci-host/apb.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/apb.c

Re: [Qemu-devel] Use-after-free during unrealize in system_reset

2014-06-08 Thread Paolo Bonzini
Il 08/06/2014 12:46, Michael S. Tsirkin ha scritto: Tested-by: Michael S. Tsirkin m...@redhat.com You probably tested the reversal, actually. :) Actually, there is a reason for it. Unassembling the device (unparent) should come after powering it down (unrealize). However, the bus is missing

Re: [Qemu-devel] [PATCH] vdi: remove double conversion

2014-06-08 Thread Stefan Weil
Am 06.06.2014 16:14, schrieb Benoît Canet: The Friday 06 Jun 2014 à 16:06:52 (+0200), Paolo Bonzini wrote : This should be a problem when running on big-endian machines. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- It's time to clean up old branch, and I found this nice little

Re: [Qemu-devel] Use-after-free during unrealize in system_reset

2014-06-08 Thread Michael S. Tsirkin
On Sun, Jun 08, 2014 at 04:40:56PM +0200, Paolo Bonzini wrote: Il 08/06/2014 12:46, Michael S. Tsirkin ha scritto: Tested-by: Michael S. Tsirkin m...@redhat.com You probably tested the reversal, actually. :) I guess so, maybe patch asked me about it. Actually, there is a reason for it.

Re: [Qemu-devel] Use-after-free during unrealize in system_reset

2014-06-08 Thread Michael S. Tsirkin
On Sun, Jun 08, 2014 at 04:40:56PM +0200, Paolo Bonzini wrote: Il 08/06/2014 12:46, Michael S. Tsirkin ha scritto: Tested-by: Michael S. Tsirkin m...@redhat.com You probably tested the reversal, actually. :) Actually, there is a reason for it. Unassembling the device (unparent) should

Re: [Qemu-devel] [PATCH 2/2] virtio-blk-test.c: add hotplug subtest

2014-06-08 Thread Michael S. Tsirkin
On Thu, Jun 05, 2014 at 01:12:46PM +0800, Amos Kong wrote: On Wed, Jun 04, 2014 at 05:35:06PM +0200, Stefan Hajnoczi wrote: On Tue, May 27, 2014 at 03:14:41PM +0800, Amos Kong wrote: This patch adds a new subtest, it hotplugs 29 * 8 = 232 virtio-blk devices to guest, and try to hot-unplug

Re: [Qemu-devel] [PATCH] qtest: fix hex2nib for capital characters

2014-06-08 Thread Michael S. Tsirkin
On Tue, May 27, 2014 at 12:16:00PM +0400, serge.f...@gmail.com wrote: From: Sergey Fedorov serge.f...@gmail.com Signed-off-by: Sergey Fedorov serge.f...@gmail.com Applied, thanks! --- qtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qtest.c b/qtest.c index

Re: [Qemu-devel] [PATCH v10 16/18] Add vhost-user protocol documentation

2014-06-08 Thread Michael S. Tsirkin
On Thu, Jun 05, 2014 at 10:17:35AM -0600, Eric Blake wrote: On 05/27/2014 06:06 AM, Nikolay Nikolaev wrote: This document describes the basic message format used by vhost-user for communication over a unix domain socket. The protocol is based on the existing ioctl interface used for the

Re: [Qemu-devel] [PATCH v10 00/18] Vhost and vhost-net support for userspace based backends

2014-06-08 Thread Michael S. Tsirkin
On Tue, May 27, 2014 at 03:03:21PM +0300, Nikolay Nikolaev wrote: In this patch series we would like to introduce our approach for putting a virtio-net backend in an external userspace process. Our eventual target is to run the network backend in the Snabbswitch ethernet switch, while receiving

Re: [Qemu-devel] [PATCH 0/2] virtio: Drop some superfluous conditionals

2014-06-08 Thread Michael S. Tsirkin
On Fri, Jun 06, 2014 at 06:43:28PM +0200, Markus Armbruster wrote: Markus Armbruster (2): virtio: Drop superfluous conditionals around g_free() virtio: Drop superfluous conditionals around g_strdup() Applied, thanks everyone. hw/9pfs/virtio-9p.c | 4 +--- hw/net/virtio-net.c | 27

Re: [Qemu-devel] [PATCH v5 3/3] xen-hvm: Pass is_default to xen_hvm_init

2014-06-08 Thread Michael S. Tsirkin
On Fri, Jun 06, 2014 at 01:52:06PM -0400, Don Slutz wrote: This is the xen part of pc q35: Add new machine opt max-ram-below-4g Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Don Slutz dsl...@verizon.com --- v5: Added Acked-by: Stefano Stabellini Minor

Re: [Qemu-devel] [PATCH v5 2/3] pc q35: Add new machine opt max-ram-below-4g

2014-06-08 Thread Michael S. Tsirkin
On Fri, Jun 06, 2014 at 01:52:05PM -0400, Don Slutz wrote: This is a pc q35 only machine opt. One use is to allow for more ram in a 32bit guest for example: -machine pc,max-ram-below-4g=3.75G If you add enough PCI devices then all mmio for them will not fit below 4G which may not be the

Re: [Qemu-devel] [PATCH v5 3/3] xen-hvm: Pass is_default to xen_hvm_init

2014-06-08 Thread Michael S. Tsirkin
On Fri, Jun 06, 2014 at 01:52:06PM -0400, Don Slutz wrote: This is the xen part of pc q35: Add new machine opt max-ram-below-4g Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Don Slutz dsl...@verizon.com --- v5: Added Acked-by: Stefano Stabellini Minor

[Qemu-devel] [Bug 1327800] [NEW] USB mouse is jumpy on y-axis (patch attached)

2014-06-08 Thread Christian Burger
Public bug reported: Found a problem with the mouse while using revision 50809c8b9288a9bfe1fdec926b7ef985608a7ea6. The mouse misbehaved and jumped up and down while trying to move in one direction along the y-axis (up or down). All was good at revision a9e8aeb3755bccb7b51174adcf4a3fc427e0d147

[Qemu-devel] [PATCH applied] ich: get rid of spaces in type name

2014-06-08 Thread Michael S. Tsirkin
Names with spaces in them are nasty, let's not go there. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Already in my tree, let me know if you see issues. include/hw/i386/ich9.h | 2 +- include/hw/i386/pc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v1 11/16] target-arm: Don't take interrupts targeting lower ELs

2014-06-08 Thread Aggeler Fabian
On 30 May 2014, at 09:28, Edgar E. Iglesias edgar.igles...@gmail.com wrote: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-arm/cpu.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-arm/cpu.h

[Qemu-devel] [Bug 1327800] Re: USB mouse is jumpy on y-axis (patch attached)

2014-06-08 Thread Christian Burger
Sorry, I forgot to give steps to reproduce the issue: 1) I used Tiny Core Linux from here: http://distro.ibiblio.org/tinycorelinux/downloads.html 2) started it with $ qemu-system-x86_64 -enable-kvm -m 1024 -usb -device usb-mouse -hda TinyCore-current.iso -- You received this bug notification

Re: [Qemu-devel] [PATCH 7/9 v3] FreeBSD-user: Add extattr_* to the table of syscalls

2014-06-08 Thread Sean Bruno
On Sat, 2014-06-07 at 23:10 +0100, Peter Maydell wrote: On 6 June 2014 14:49, Sean Bruno sbr...@freebsd.org wrote: Signed-off-by: Sean Bruno sbr...@freebsd.org Commit message, strace not new implementations, etc etc. Otherwise Reviewed-by: Peter Maydell peter.mayd...@linaro.org thanks

Re: [Qemu-devel] [PATCH 8/9 v3] FreeBSD-user: Add thr_* to the table of syscalls

2014-06-08 Thread Sean Bruno
On Sat, 2014-06-07 at 23:19 +0100, Peter Maydell wrote: On 6 June 2014 14:49, Sean Bruno sbr...@freebsd.org wrote: Signed-off-by: Sean Bruno sbr...@freebsd.org Other than the standard gripe about the commit message, Reviewed-by: Peter Maydell peter.mayd...@linaro.org thanks -- PMM I'm

Re: [Qemu-devel] [PATCH 9/9 v3] FreeBSD-user: Add support for missing syscalls

2014-06-08 Thread Sean Bruno
On Sat, 2014-06-07 at 23:12 +0100, Peter Maydell wrote: On 6 June 2014 14:49, Sean Bruno sbr...@freebsd.org wrote: Fix syscall format for socket, fstat, fstatfs and chown. Add additional syscalls that are missing. These aren't completely missing syscalls; please update the commit

[Qemu-devel] [PATCH 00/10 v4] bsd-user: update strace syscalls and breakout BSD distros

2014-06-08 Thread Sean Bruno
v4: Update subject to indicate additional strace syscall capabiltiy (Peter Maydell) Audit syscall strings for correct function prototypes (Peter Maydell) Move new macros TARGET_HW_MACHINE/ARCH to seperate patch (Peter Maydell) Drop new architecture support, schedule new architectures for later

[Qemu-devel] [PATCH 03/10 v4] bsd-user: Implement strace support for print_sysctl syscall

2014-06-08 Thread Sean Bruno
Signed-off-by: Sean Bruno sbr...@freebsd.org --- bsd-user/freebsd/strace.list | 21 +++-- bsd-user/strace.c| 22 ++ 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list index

[Qemu-devel] [PATCH 09/10 v4] bsd-user: Fix syscall format, add strace support for more syscalls

2014-06-08 Thread Sean Bruno
Signed-off-by: Sean Bruno sbr...@freebsd.org --- bsd-user/freebsd/strace.list | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list index ef4fa85..55f5ff8 100644 --- a/bsd-user/freebsd/strace.list +++

[Qemu-devel] [PATCH 01/10 v4] bsd-user: add HOST_VARIANT_DIR for various *BSD dependent code

2014-06-08 Thread Sean Bruno
From: Stacey Son s...@freebsd.org This change adds HOST_VARIANT_DIR so the various BSD OS dependent code can be separated into its own directories rather than using #ifdef's. This may also allow an BSD variant OS to host another BSD variant's executable as a target. Signed-off-by: Sean Bruno

[Qemu-devel] [PATCH 02/10 v4] bsd-user: GPL v2 attribution update and style

2014-06-08 Thread Sean Bruno
Signed-off-by: Sean Bruno sbr...@freebsd.org --- bsd-user/qemu.h | 26 +++ bsd-user/strace.c | 126 +- 2 files changed, 94 insertions(+), 58 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index ddc74ed..b8a34c7 100644

[Qemu-devel] [PATCH 06/10 v4] bsd-user: Implement strace support for __acl_* syscalls

2014-06-08 Thread Sean Bruno
Signed-off-by: Sean Bruno sbr...@freebsd.org --- bsd-user/freebsd/strace.list | 12 1 file changed, 12 insertions(+) diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list index 32b3c55..0deff16 100644 --- a/bsd-user/freebsd/strace.list +++

[Qemu-devel] [PATCH 05/10 v4] bsd-user: Implement new syscall print_sysarch and add strace support

2014-06-08 Thread Sean Bruno
Signed-off-by: Sean Bruno sbr...@freebsd.org --- bsd-user/freebsd/os-strace.h | 29 + bsd-user/freebsd/strace.list | 2 +- bsd-user/i386/syscall.h| 21 + bsd-user/i386/target_arch_sysarch.h| 78 ++

[Qemu-devel] [PATCH 07/10 v4] bsd-user: Implement strace support for extattr_* syscalls

2014-06-08 Thread Sean Bruno
Signed-off-by: Sean Bruno sbr...@freebsd.org --- bsd-user/freebsd/strace.list | 13 + 1 file changed, 13 insertions(+) diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list index 0deff16..ed8ead3 100644 --- a/bsd-user/freebsd/strace.list +++

[Qemu-devel] [PATCH 04/10 v4] bsd-user: Implement strace support for print_ioctl syscall

2014-06-08 Thread Sean Bruno
Signed-off-by: Sean Bruno sbr...@freebsd.org --- bsd-user/freebsd/strace.list | 2 +- bsd-user/strace.c| 19 +++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list index 3235f16..718357b 100644

[Qemu-devel] [PATCH 08/10 v4] bsd-user: Implement strace support for thr_* syscalls

2014-06-08 Thread Sean Bruno
Signed-off-by: Sean Bruno sbr...@freebsd.org --- bsd-user/freebsd/strace.list | 9 + 1 file changed, 9 insertions(+) diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list index ed8ead3..ef4fa85 100644 --- a/bsd-user/freebsd/strace.list +++

[Qemu-devel] [PATCH 10/10 v4] bsd-user: Add TARGET_HW_MACHINE TARGET_HW_MACHINE_ARCH for future use

2014-06-08 Thread Sean Bruno
Signed-off-by: Sean Bruno sbr...@freebsd.org --- bsd-user/i386/syscall.h| 2 ++ bsd-user/sparc/syscall.h | 2 ++ bsd-user/sparc64/syscall.h | 2 ++ bsd-user/x86_64/syscall.h | 2 ++ 4 files changed, 8 insertions(+) diff --git a/bsd-user/i386/syscall.h b/bsd-user/i386/syscall.h index

Re: [Qemu-devel] [Qemu-trivial] [PATCH-trivial] arch_init.c: Free 'cache' in cache_fini() to avoid memory leak

2014-06-08 Thread Michael Tokarev
02.06.2014 16:16, Chen Gang wrote: Call g_free() after cache_fini() in migration_end(), but do not call g_free() after call cache_fini() in xbzrle_cache_resize() which will cause memory leak. cache_init() and cache_fini() are pair, so need let cache_fini() call g_free(cache) to match

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-08 Thread Peter Maydell
On 8 June 2014 13:11, Michael Tokarev m...@tls.msk.ru wrote: 07.06.2014 21:08, Peter Maydell wrote: The tcg_out* and tcg_patch* functions are utility routines that may or may not be used by a particular backend; mark them with the 'unused' attribute to suppress spurious warnings if they aren't

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-08 Thread Richard Henderson
On 06/08/2014 12:04 PM, Peter Maydell wrote: The other approach we could take would be to move these definitions from this .c file into a .h file (tcg-backend-helpers.h ?). Then clang won't complain (it seems to only warn about unused static-inline-functions in .c files, not in .h files).

[Qemu-devel] [PATCH] scsi-disk: fix bug in scsi_block_new_request() introduced by commit 137745c

2014-06-08 Thread Ulrich Obergfell
This patch fixes a bug in scsi_block_new_request() that was introduced by commit 137745c5c60f083ec982fe9e861e8c16ebca1ba8. If the host cache is used - i.e. if BDRV_O_NOCACHE is _not_ set - the 'break' statement needs to be executed to 'fall back' to SG_IO. Signed-off-by: Ulrich Obergfell

Re: [Qemu-devel] [PATCH 0/2] target-cris: Avoid unused-function warnings

2014-06-08 Thread Edgar E. Iglesias
On Sat, Jun 07, 2014 at 06:03:00PM +0100, Peter Maydell wrote: These patches correct some unused-function warnings in target-cris. I've included some cleanup and removal of wrapper functions to maintain symmetry between the to-reg and from-reg code. Applied both, thanks, Edgar thanks --

Re: [Qemu-devel] [PATCH microblaze v1 0/6] Microblaze Device QOM cleanups

2014-06-08 Thread Edgar E. Iglesias
On Thu, May 29, 2014 at 02:22:46AM -0700, Peter Crosthwaite wrote: Hi Andreas, Edgar, Another 4 users of SysBusDevice::init bite the dust! A round of styling cleanup for Microblaze devices as per QOM conventions. Tested with published MB test images. I've applied these, thanks.

Re: [Qemu-devel] [PATCH v1 11/16] target-arm: Don't take interrupts targeting lower ELs

2014-06-08 Thread Edgar E. Iglesias
On Sun, Jun 08, 2014 at 03:51:24PM +, Aggeler Fabian wrote: On 30 May 2014, at 09:28, Edgar E. Iglesias edgar.igles...@gmail.com wrote: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-arm/cpu.h | 7 +++

Re: [Qemu-devel] [PATCHv2, DoS] slirp (arp): do not special-case bogus IP addresses

2014-06-08 Thread Edgar E. Iglesias
On Wed, May 14, 2014 at 03:13:09AM +0200, Samuel Thibault wrote: Do not special-case addresses with zero host part, as we do not necessarily know how big it is, and the guest can fake them anyway. Silently avoid having 0.0.0.0 as a destination, however. Signed-off-by: Samuel Thibault

Re: [Qemu-devel] [PATCH v3.1 25/31] hostmem: add properties for NUMA memory policy

2014-06-08 Thread Hu Tao
On Fri, Jun 06, 2014 at 01:15:28PM -0300, Eduardo Habkost wrote: On Fri, Jun 06, 2014 at 11:37:26AM +0800, Hu Tao wrote: On Mon, May 19, 2014 at 08:34:54PM -0300, Eduardo Habkost wrote: On Tue, May 06, 2014 at 05:27:46PM +0800, Hu Tao wrote: [...] @@ -203,6 +296,20 @@

Re: [Qemu-devel] [PATCH v3.2 07/31] vl: redo -object parsing

2014-06-08 Thread Hu Tao
On Sun, Jun 08, 2014 at 12:05:12PM +0300, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 05:43:11PM +0800, Hu Tao wrote: From: Paolo Bonzini pbonz...@redhat.com Follow the lines of the HMP implementation, using OptsVisitor to parse the options. This gives access to OptsVisitor's

Re: [Qemu-devel] [PATCH v3.2 10/31] pc: pass QEMUMachineInitArgs to pc_memory_init

2014-06-08 Thread Hu Tao
On Sun, Jun 08, 2014 at 12:40:40PM +0300, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 05:43:14PM +0800, Hu Tao wrote: From: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao

Re: [Qemu-devel] [PATCH v3.2 06/31] man: improve -numa doc

2014-06-08 Thread Hu Tao
On Sun, Jun 08, 2014 at 01:09:20PM +0300, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 05:43:10PM +0800, Hu Tao wrote: From: Luiz Capitulino lcapitul...@redhat.com The -numa option documentation in qemu's manpage lacks the command-line options and some information regarding how it

Re: [Qemu-devel] [PATCH v3.2 01/31] NUMA: move numa related code to new file numa.c

2014-06-08 Thread Hu Tao
On Sun, Jun 08, 2014 at 01:09:03PM +0300, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 05:43:05PM +0800, Hu Tao wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by:

Re: [Qemu-devel] [PATCH v3.2 02/31] NUMA: check if the total numa memory size is equal to ram_size

2014-06-08 Thread Hu Tao
On Sun, Jun 08, 2014 at 01:09:46PM +0300, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 05:43:06PM +0800, Hu Tao wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong

Re: [Qemu-devel] [PATCH v3.2 11/31] numa: introduce memory_region_allocate_system_memory

2014-06-08 Thread Hu Tao
On Wed, May 14, 2014 at 05:30:23PM -0300, Eduardo Habkost wrote: On Wed, May 14, 2014 at 05:43:15PM +0800, Hu Tao wrote: From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/i386/pc.c|

Re: [Qemu-devel] [PATCH v3.2 11/31] numa: introduce memory_region_allocate_system_memory

2014-06-08 Thread Hu Tao
On Sun, Jun 08, 2014 at 01:10:25PM +0300, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 05:43:15PM +0800, Hu Tao wrote: From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/i386/pc.c

Re: [Qemu-devel] [PATCH v3.2 31/31] hmp: add info memdev

2014-06-08 Thread Hu Tao
On Sun, Jun 08, 2014 at 01:10:37PM +0300, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 05:43:35PM +0800, Hu Tao wrote: This is the hmp counterpart of qmp query-memdev. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hmp.c | 36 hmp.h

Re: [Qemu-devel] [PATCH v3.2 27/31] qapi: make string input visitor parse int list

2014-06-08 Thread Hu Tao
On Sun, Jun 08, 2014 at 01:11:03PM +0300, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 05:43:31PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com Conflicts with commit e2cd0f4fb42b1fae65ad22e8efde9804446e6254 qapi: Replace start_optional()/end_optional() by

Re: [Qemu-devel] [PATCH v3.2 00/31] NUMA series, and hostmem improvements

2014-06-08 Thread Hu Tao
On Sun, Jun 08, 2014 at 01:11:40PM +0300, Michael S. Tsirkin wrote: On Wed, May 14, 2014 at 05:43:04PM +0800, Hu Tao wrote: changes to v3.1: - return -1 in object_create() if there is an error (patch 07) - configure: change 'numactl' to 'numactl devel' (patch 24) - configure:

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-06-08 Thread Hu Tao
On Fri, Jun 06, 2014 at 02:48:15PM +0200, Igor Mammedov wrote: On Fri, 6 Jun 2014 17:29:38 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Fri, May 30, 2014 at 09:59:55AM +0200, Igor Mammedov wrote: On Fri, 30 May 2014 00:05:51 +1000 Peter Crosthwaite peter.crosthwa...@xilinx.com wrote:

  1   2   >