Re: [Qemu-devel] [PATCH 1/3 v3] ppc: spapr-rtas - implement os-term rtas call

2014-06-27 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 06/27/2014 04:47 PM, Nikunj A Dadhania wrote: >> PAPR compliant guest calls this in absence of kdump. This finally >> reaches the guest and can be handled according to the policies set by >> higher level tools(like taking dump) for further analysis by tools like

Re: [Qemu-devel] [PATCH for 2.1] qdev: correctly send DEVICE_DELETED for recursively-deleted devices

2014-06-27 Thread Markus Armbruster
Paolo Bonzini writes: > When a device is unparented (i.e. made completely hidden from management) > we want to send a DEVICE_DELETED event only if the device actually was > realized. This avoids raising DEVICE_DELETED events when device_add > fails. > > However, this does not work right for recu

Re: [Qemu-devel] [PATCH 1/3 v3] ppc: spapr-rtas - implement os-term rtas call

2014-06-27 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > PAPR compliant guest calls this in absence of kdump. This finally > reaches the guest and can be handled according to the policies set by > higher level tools(like taking dump) for further analysis by tools like > crash. > > Linux kernel calls this only when the extend

Re: [Qemu-devel] [v5][PATCH 2/5] xen, gfx passthrough: create pseudo intel isa bridge

2014-06-27 Thread Chen, Tiejun
On 2014/6/25 17:58, Chen, Tiejun wrote: On 2014/6/25 17:44, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 05:28:48PM +0800, Chen, Tiejun wrote: On 2014/6/25 17:21, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 05:14:30PM +0800, Chen, Tiejun wrote: On 2014/6/25 17:04, Michael S. Tsirki

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-27 Thread Paolo Bonzini
Il 27/06/2014 08:23, Kevin Wolf ha scritto: Note that there is already an interface in block.c that takes multiple requests at once, bdrv_aio_multiwrite(). It is currently used by virtio-blk, even though not in dataplane mode. It also submits individual requests to the block drivers currently, so

[Qemu-devel] [PATCH v4] ppc: spapr-rtas - implement os-term rtas call

2014-06-27 Thread Nikunj A Dadhania
PAPR compliant guest calls this in absence of kdump. This finally reaches the guest and can be handled according to the policies set by higher level tools(like taking dump) for further analysis by tools like crash. Linux kernel calls this only when the extended version of os,term is implemented to

Re: [Qemu-devel] Reverse execution and deterministic replay

2014-06-27 Thread Frederic Konrad
On 27/06/2014 08:11, Peter Crosthwaite wrote: Hi Pavel, On Fri, Jun 27, 2014 at 3:18 PM, Pavel Dovgaluk wrote: Hello! We want to publish set of patches related to the reverse execution and deterministic replay of qemu. Our implementation of deterministic replay can be used for deterministic

Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support

2014-06-27 Thread Christian Borntraeger
On 26/06/14 16:42, Alexander Graf wrote: > > On 26.06.14 16:29, Jens Freimann wrote: >> Conny, Alex, Christian, >> >> here are some fixes for the s390-ccw bios. It's a mixture of >> additional features (DASD IPL support for different formats) >> and cleanups. > > From a quick glimpse it looks qui

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-27 Thread Ming Lei
On Fri, Jun 27, 2014 at 12:59 PM, Paolo Bonzini wrote: > Il 27/06/2014 03:15, Ming Lei ha scritto: >> >> On Thu, Jun 26, 2014 at 11:57 PM, Paolo Bonzini >> wrote: >>> >>> We can implement (advisory) calls like bdrv_plug/bdrv_unplug in order to >>> restore the previous levels of performance. >> >>

Re: [Qemu-devel] [RFC PATCH v5 00/13] Reverse execution.

2014-06-27 Thread Frederic Konrad
On 26/06/2014 17:52, Sebastian Tanase wrote: Hello, I'll be sending a new version (V3) of the patches on Monday. The patches add QemuOpts handling to the "-icount option". If you want I can only send the part of the patch that adds QemuOpts support. Best regards, Sebastian Tanase Hi, Yes

Re: [Qemu-devel] [PATCH] target-arm: Implement vCPU reset via KVM_ARM_VCPU_INIT for 32-bit CPUs

2014-06-27 Thread Diana Craciun
On 06/26/2014 08:16 PM, Peter Maydell wrote: Implement kvm_arm_vcpu_init() as a simple call to arm_arm_vcpu_init() (which uses the KVM_ARM_VCPU_INIT vcpu ioctl to tell the kernel to re-initialize the vCPU), rather than via the complicated code which saves a copy of the register state on first ini

[Qemu-devel] [PATCH v6 0/5] Support Archipelago as a QEMU block backend

2014-06-27 Thread Chrysostomos Nanakos
v6: - Split v5 1/4 patch into two different patches. First one implements QMP structured options and the second one implements bdrv_parse_filename(). v5: - Remove useless qemu_aio_count variable from BDRVArchipelagoState struct. - Cleanup xseg signal descriptor, call xseg_quit_local_signal()

[Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend

2014-06-27 Thread Chrysostomos Nanakos
VM Image on Archipelago volume is specified like this: file.driver=archipelago,file.volume=[,file.mport=[, file.vport=][,file.segment=]] 'archipelago' is the protocol. 'mport' is the port number on which mapperd is listening. This is optional and if not specified, QEMU will make Archipelago to u

[Qemu-devel] [PATCH v6 4/5] QMP: Add support for Archipelago

2014-06-27 Thread Chrysostomos Nanakos
Introduce new enum BlockdevOptionsArchipelago. @volume: #Name of the Archipelago volume image @mport: #'mport' is the port number on which mapperd is listening. This is optional and if not specified, QEMU will make Archipelago

[Qemu-devel] [PATCH v6 2/5] block/archipelago: Implement bdrv_parse_filename()

2014-06-27 Thread Chrysostomos Nanakos
VM Image on Archipelago volume can also be specified like this: file=archipelago:[/mport=[:vport=][: segment=]] Examples: file=archipelago:my_vm_volume file=archipelago:my_vm_volume/mport=123 file=archipelago:my_vm_volume/mport=123:vport=1234 file=archipelago:my_vm_volume/mport=123:vport=1234:se

Re: [Qemu-devel] Reverse execution and deterministic replay

2014-06-27 Thread Peter Maydell
On 27 June 2014 06:18, Pavel Dovgaluk wrote: > Our implementation is completely tested for qemu 1.5 and is in beta state for > 2.0.50. Note that you should post patches against current QEMU master; patches against old releases like 1.5 are not something we could use. thanks -- PMM

[Qemu-devel] [PATCH v6 3/5] block/archipelago: Add support for creating images

2014-06-27 Thread Chrysostomos Nanakos
qemu-img archipelago:[/mport=[:vport=] [:segment=]] [size] Signed-off-by: Chrysostomos Nanakos --- block/archipelago.c | 149 +++ 1 file changed, 149 insertions(+) diff --git a/block/archipelago.c b/block/archipelago.c index 3549454..3d5aff1 100

[Qemu-devel] [PATCH v6 5/5] qemu-iotests: add support for Archipelago protocol

2014-06-27 Thread Chrysostomos Nanakos
Signed-off-by: Chrysostomos Nanakos --- tests/qemu-iotests/common|6 ++ tests/qemu-iotests/common.rc |9 - 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index 0aaf84d..a0e35c4 100644 --- a/tests/qemu-io

Re: [Qemu-devel] [PATCH] tcg/ppc: Fix failure in tcg_out_mem_long

2014-06-27 Thread Greg Kurz
On Thu, 26 Jun 2014 21:26:00 -0700 Richard Henderson wrote: > With rt != r0 on loads, we use rt for scratch. If we need an index > register different from base, we can't use rt, but r0 is usable. > > Signed-off-by: Richard Henderson > --- > This ought to fix the problem that Greg reported. >

[Qemu-devel] [PATCH] Allow mismatched virtio config-len

2014-06-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Commit 'virtio: validate config_len on load' restricted config_len loaded from the wire to match the config_len that the device had. Unfortunately, there are cases where this isn't true, the one we found it on was the wqe addition in virtio-blk. Allow mismatched c

Re: [Qemu-devel] [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough

2014-06-27 Thread Chen, Tiejun
On 2014/6/25 14:24, Paolo Bonzini wrote: Il 25/06/2014 04:17, Tiejun Chen ha scritto: +if (xen_enabled() && xen_has_gfx_passthru) { +d = pci_create_simple(b, 0, TYPE_I440FX_XEN_PCI_DEVICE); +*pi440fx_state = I440FX_XEN_PCI_DEVICE(d); +pci_create_pch(b); +} else {

Re: [Qemu-devel] [PATCH for 2.1] qdev: correctly send DEVICE_DELETED for recursively-deleted devices

2014-06-27 Thread Andreas Färber
Am 27.06.2014 09:16, schrieb Markus Armbruster: > Paolo Bonzini writes: > >> When a device is unparented (i.e. made completely hidden from management) >> we want to send a DEVICE_DELETED event only if the device actually was >> realized. This avoids raising DEVICE_DELETED events when device_add

Re: [Qemu-devel] [PATCH 1/4] mips/kvm: Init EBase to correct KSEG0

2014-06-27 Thread Aurelien Jarno
On Thu, Jun 26, 2014 at 10:44:22AM +0100, James Hogan wrote: > The EBase CP0 register is initialised to 0x8000, however with KVM > the guest's KSEG0 is at 0x4000. The incorrect value doesn't get > passed to KVM yet as KVM doesn't implement the EBase register, however > we should set it corr

Re: [Qemu-devel] [PATCH 2/4] mips_malta: Change default KVM cpu to 24Kc (no FP)

2014-06-27 Thread Aurelien Jarno
On Thu, Jun 26, 2014 at 10:44:23AM +0100, James Hogan wrote: > Change the default Malta CPU model for when KVM is enabled to 24Kc which > doesn't have floating point support compared to the 24Kf. > > The resulting incorrect Config CP0 register value doesn't get passed to > KVM yet as KVM doesn't e

Re: [Qemu-devel] [PATCH 3/4] mips_malta: Remove incorrect KVM T&E references

2014-06-27 Thread Aurelien Jarno
On Thu, Jun 26, 2014 at 10:44:24AM +0100, James Hogan wrote: > Fix the error message and code comments relating to KVM not supporting > booting from the flash mapping when no kernel is provided. The issue is > a general MIPS KVM issue and isn't specific to the Trap & Emulate > version of MIPS KVM.

Re: [Qemu-devel] [PATCH 4/4] mips_malta: Catch kernels linked at wrong address

2014-06-27 Thread Aurelien Jarno
On Thu, Jun 26, 2014 at 10:44:25AM +0100, James Hogan wrote: > Add error reporting if the wrong type of kernel is provided for the > current mode of acceleration. > > Currently a KVM kernel linked at 0x4000 can't be used with TCG, and > a normal kernel linked at 0x8000 can't be used with K

Re: [Qemu-devel] [PATCH v5 0/3] s390: Support for Hotplug of Standby Memory

2014-06-27 Thread Igor Mammedov
On Wed, 25 Jun 2014 10:26:57 -0400 Matthew Rosato wrote: > This patchset adds support in s390 for a pool of standby memory, > which can be set online/offline by the guest (ie, via chmem). > The standby pool of memory is allocated as the difference between > the initial memory setting and the max

Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support

2014-06-27 Thread Alexander Graf
> Am 27.06.2014 um 09:53 schrieb Christian Borntraeger : > >> On 26/06/14 16:42, Alexander Graf wrote: >> >>> On 26.06.14 16:29, Jens Freimann wrote: >>> Conny, Alex, Christian, >>> >>> here are some fixes for the s390-ccw bios. It's a mixture of >>> additional features (DASD IPL support for d

Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-27 Thread Chen, Tiejun
On 2014/6/25 15:04, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 10:17:19AM +0800, Tiejun Chen wrote: Some registers of Intel IGD are mapped in host bridge, so it needs to [snip] static int is_vga_passthrough(XenHostPCIDevice *dev) { @@ -291,3 +292,158 @@ static int create_pseudo_pc

Re: [Qemu-devel] [v5][PATCH 5/5] xen, gfx passthrough: add opregion mapping

2014-06-27 Thread Chen, Tiejun
On 2014/6/25 15:13, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 10:17:21AM +0800, Tiejun Chen wrote: [snip] diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index 507165c..25147cf 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -63,7 +63,7 @@ typedef int (*xen_pt_conf_byte_read) #

Re: [Qemu-devel] [patch qemu] net: move queue number into NICPeers

2014-06-27 Thread Stefan Hajnoczi
On Mon, May 26, 2014 at 12:04:08PM +0200, Jiri Pirko wrote: > It indicates the number of elements in ncs field and makes sense to have > int inside NICPeers. Also in parse_netdev we do not need to access > container and work with NICPeers only. > > Signed-off-by: Jiri Pirko > --- > hw/core/qdev-

Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support

2014-06-27 Thread Christian Borntraeger
On 27/06/14 11:05, Alexander Graf wrote: > > >> Am 27.06.2014 um 09:53 schrieb Christian Borntraeger >> : >> >>> On 26/06/14 16:42, Alexander Graf wrote: >>> On 26.06.14 16:29, Jens Freimann wrote: Conny, Alex, Christian, here are some fixes for the s390-ccw bios. It's a mixt

Re: [Qemu-devel] [PATCH 4/5] PPC: e500: Support platform devices

2014-06-27 Thread Eric Auger
On 06/04/2014 02:28 PM, Alexander Graf wrote: > For e500 our approach to supporting platform devices is to create a simple > bus from the guest's point of view within which we map platform devices > dynamically. > > We allocate memory regions always within the "platform" hole in address > space an

Re: [Qemu-devel] [PATCH qom v2 1/4] sdhci: Fix misuse of qemu_free_irqs()

2014-06-27 Thread Andreas Färber
Am 18.06.2014 09:54, schrieb Peter Crosthwaite: > From: Andreas Färber > > It does a g_free() on the pointer. > > Reviewed-by: Peter Crosthwaite > Reviewed-by: Peter Maydell > Signed-off-by: Andreas Färber > Signed-off-by: Peter Crosthwaite Thanks for picking this up and reviewing, applied

Re: [Qemu-devel] [PATCH 0/5] qemu-char/monitor: make monitor_puts thread safe

2014-06-27 Thread Stefan Hajnoczi
On Tue, Jun 03, 2014 at 06:39:05PM +0200, Paolo Bonzini wrote: > Even though virtio-blk-dataplane mostly synchronizes with the block layer > by means of the AioContext, we still need to introduce mutexes for other > QEMU subsystems that the dataplane thread might encounter on its way. > Adding rerr

Re: [Qemu-devel] [PATCH for 2.1 0/2] Fix commit of oversized layer

2014-06-27 Thread Kevin Wolf
Am 25.06.2014 um 22:55 hat Jeff Cody geschrieben: > This fixes a regression in block-commit; if the top image is larger than the > base image, we attempt to resize the base image. The regression is that we > fail the image truncate operation, returning -EBUSY. Thanks, applied to the block branch.

Re: [Qemu-devel] [PATCH qom v2 2/4] hw: Fix qemu_allocate_irqs() leaks

2014-06-27 Thread Andreas Färber
Am 18.06.2014 09:55, schrieb Peter Crosthwaite: > From: Andreas Färber > > Replace qemu_allocate_irqs(foo, bar, 1)[0] > with qemu_allocate_irq(foo, bar, 0). > > This avoids leaking the dereferenced qemu_irq *. > > Cc: Kirill Batuzov > Cc: Markus Armbruster > Cc: Peter Maydell > Reviewed-by:

Re: [Qemu-devel] [PATCH 00/10] pc-bios/s390-ccw: Add DASD IPL support

2014-06-27 Thread Cornelia Huck
On Fri, 27 Jun 2014 11:27:12 +0200 Christian Borntraeger wrote: > On 27/06/14 11:05, Alexander Graf wrote: > > > > > >> Am 27.06.2014 um 09:53 schrieb Christian Borntraeger > >> : > >> > >>> On 26/06/14 16:42, Alexander Graf wrote: > >>> > On 26.06.14 16:29, Jens Freimann wrote: > Co

Re: [Qemu-devel] [PATCH qom v2 0/4] QOMify IRQs

2014-06-27 Thread Andreas Färber
Am 25.06.2014 11:39, schrieb Peter Crosthwaite: > Ping! > > This is fully reviewed and should be rdy for a merge. I'd like to see > this through for 2.1. I have been very wary of applying the QOM conversion without full device test coverage, similar to realization. People actually testing this co

Re: [Qemu-devel] [PATCH v11 1/3] sPAPR: Implement EEH RTAS calls

2014-06-27 Thread Gavin Shan
On Thu, Jun 26, 2014 at 12:46:50PM +0200, Alexander Graf wrote: > >On 26.06.14 12:43, Gavin Shan wrote: >>On Thu, Jun 26, 2014 at 12:30:16PM +0200, Alexander Graf wrote: >>>On 26.06.14 03:35, Gavin Shan wrote: The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the

Re: [Qemu-devel] VNC memory corruption during resolution change

2014-06-27 Thread Peter Lieven
Found the issue: during resolution change in Windows 7 it happens sometimes that it changes to an intermediate resolution where server_stride % cmp_bytes != 0. The problem that causes memory corruption is where the guest fb is copied to the server fb. It can easily be fixed truncating cmp_by

Re: [Qemu-devel] About AddressSpace in intel-iommu emulation

2014-06-27 Thread Jan Kiszka
On 2014-06-27 07:46, Le Tan wrote: > 2014-06-27 12:55 GMT+08:00 Paolo Bonzini : >> Il 27/06/2014 04:08, Le Tan ha scritto: >> >>> 1. In struct IOMMUTLBEntry, I think the addr_mask field should be the >>> mask of the page offset, right? But I see different usages of this >>> field. In spapr_tce_tran

Re: [Qemu-devel] [PATCH 0/3] virtio-blk: Suppress error action on r/w beyond end

2014-06-27 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 02:15:33PM +0200, Markus Armbruster wrote: > When a device model's I/O operation fails, we execute the error > action. This lets layers above QEMU implement thin provisioning, or > attempt to correct errors before they reach the guest. But when the > I/O operation fails be

Re: [Qemu-devel] [PATCH 3/3] virtio-blk: Treat read/write beyond end as invalid

2014-06-27 Thread Stefan Hajnoczi
On Mon, Jun 23, 2014 at 02:57:36PM +0200, Markus Armbruster wrote: > Markus Armbruster writes: > > > Stefan Hajnoczi writes: > > > >> On Thu, Jun 05, 2014 at 02:15:36PM +0200, Markus Armbruster wrote: > >>> +if (sector > total_sectors || nb_sectors > total_sectors - sector) { > >>> +

Re: [Qemu-devel] [PATCH] docs/multiple-iothreads.txt: add documentation on IOThread programming

2014-06-27 Thread Stefan Hajnoczi
On Mon, Jun 09, 2014 at 09:29:31AM -0600, Eric Blake wrote: > On 06/09/2014 07:59 AM, Stefan Hajnoczi wrote: > > This document explains how IOThreads and the main loop are related, > > especially how to write code that can run in an IOThread. Currently on > > virtio-blk-data-plane uses these techn

Re: [Qemu-devel] [PATCH] docs/multiple-iothreads.txt: add documentation on IOThread programming

2014-06-27 Thread Stefan Hajnoczi
On Mon, Jun 09, 2014 at 04:11:29PM +0200, Paolo Bonzini wrote: > >+The main loop and IOThreads > >+--- > >+QEMU is an event-driven program that can do several things at once using an > >+event loop. The VNC server and the QMP monitor are both processed from the > >+same eve

[Qemu-devel] [RFC PATCH 0/3] cpu: add device_add foo-x86_64-cpu support

2014-06-27 Thread Gu Zheng
This series is based on the previous patchset from Chen Fan: https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html This patches try to make cpu hotplug with device_add, and make "-device foo-x86_64-cpu" available,also we can set apic-id property with command line, if without setti

[Qemu-devel] [RFC PATCH 1/3] cpu: introduce CpuTopoInfo structure for argument simplification

2014-06-27 Thread Gu Zheng
Signed-off-by: Chen Fan Reviewed-by: Eduardo Habkost Signed-off-by: Gu Zheng --- target-i386/topology.h | 33 + 1 files changed, 17 insertions(+), 16 deletions(-) diff --git a/target-i386/topology.h b/target-i386/topology.h index 07a6c5f..e9ff89c 100644 --- a/

[Qemu-devel] [RFC PATCH 2/3] qom/cpu: move register_vmstate to common CPUClass.realizefn

2014-06-27 Thread Gu Zheng
Move cpu vmstate register from cpu_exec_init into cpu_common_realizefn, apic vmstate register into x86_cpu_apic_realize. And use the cc->get_arch_id as the instance id that suggested by Igor to fix the migration issue. Signed-off-by: Gu Zheng --- exec.c | 32 ++

[Qemu-devel] [RFC PATCH 3/3] cpu: add device_add foo-x86_64-cpu support

2014-06-27 Thread Gu Zheng
From: Chen Fan Add support to device_add foo-x86_64-cpu, and additional checks of apic id are added into x86_cpuid_set_apic_id() and x86_cpu_apic_create() for duplicate. Besides, in order to support "device/device_add foo-x86_64-cpu" which without specified apic id, we add a new function get_free

Re: [Qemu-devel] [RFC PATCH 1/3] cpu: introduce CpuTopoInfo structure for argument simplification

2014-06-27 Thread Gu Zheng
Correct the author. From: Chen Fan On 06/27/2014 06:03 PM, Gu Zheng wrote: > Signed-off-by: Chen Fan > Reviewed-by: Eduardo Habkost > Signed-off-by: Gu Zheng > --- > target-i386/topology.h | 33 + > 1 files changed, 17 insertions(+), 16 deletions(-) > > dif

Re: [Qemu-devel] [PATCH qom v2 2/4] hw: Fix qemu_allocate_irqs() leaks

2014-06-27 Thread Peter Crosthwaite
On Fri, Jun 27, 2014 at 7:45 PM, Andreas Färber wrote: > Am 18.06.2014 09:55, schrieb Peter Crosthwaite: >> From: Andreas Färber >> >> Replace qemu_allocate_irqs(foo, bar, 1)[0] >> with qemu_allocate_irq(foo, bar, 0). >> >> This avoids leaking the dereferenced qemu_irq *. >> >> Cc: Kirill Batuzov

[Qemu-devel] [PATCH v2] docs/multiple-iothreads.txt: add documentation on IOThread programming

2014-06-27 Thread Stefan Hajnoczi
This document explains how IOThreads and the main loop are related, especially how to write code that can run in an IOThread. Currently only virtio-blk-data-plane uses these techniques. The next obvious target is virtio-scsi; there has also been work on virtio-net. Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v1 1/1] char: cadence_uart: Convert to realize()

2014-06-27 Thread Peter Maydell
On 27 June 2014 01:11, Peter Crosthwaite wrote: > On Tue, Jun 24, 2014 at 4:06 PM, Alistair Francis > wrote: >> SysBusDevice::init is deprecated. Convert to Object::init and >> Device::realize as prescribed by QOM conventions. >> >> Signed-off-by: Alistair Francis > > Reviewed-by: Peter Crosthwa

Re: [Qemu-devel] [PATCH v2] hw/net/eepro100: Implement read-only bits in MDI registers

2014-06-27 Thread Stefan Hajnoczi
On Mon, Jun 09, 2014 at 04:03:08PM +0100, Peter Maydell wrote: > Although we defined an eepro100_mdi_mask[] array indicating which bits > in the registers are read-only, we weren't actually doing anything with > it. Make the MDI register-write code use it rather than manually making > register 1 re

Re: [Qemu-devel] [PATCH 0/5] Platform device support

2014-06-27 Thread Andreas Färber
Am 26.06.2014 14:01, schrieb Alexander Graf: > > On 20.06.14 08:43, Peter Crosthwaite wrote: >> On Wed, Jun 4, 2014 at 10:28 PM, Alexander Graf wrote: >>> Platforms without ISA and/or PCI have had a seriously hard time in >>> the dynamic >>> device creation world of QEMU. Devices on these were mo

Re: [Qemu-devel] Reverse execution and deterministic replay

2014-06-27 Thread Pavel Dovgaluk
> -Original Message- > From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > Sent: Friday, June 27, 2014 11:48 AM > To: Pavel Dovgaluk > Cc: Peter Crosthwaite; Paolo Bonzini; qemu-devel@nongnu.org Developers; Mark > Burton > Subject: Re: [Qemu-devel] Reverse execution and deterministi

[Qemu-devel] [PATCH] ui/vnc: avoid memory corruption if width % VNC_DIRTY_PIXELS_PER_BIT != 0

2014-06-27 Thread Peter Lieven
during resolution change in Windows 7 it happens sometimes that Windows changes to an intermediate resolution where server_stride % cmp_bytes != 0 (in vnc_refresh_server_surface). The problem that causes memory corruption is where the guest fb is copied to the server fb. It could be easily fixed

Re: [Qemu-devel] Reverse execution and deterministic replay

2014-06-27 Thread Peter Maydell
On 27 June 2014 11:35, Pavel Dovgaluk wrote: > The major disadvantage of icount is that it's updated only on TB boundaries. > When one instruction in the middle of the block uses virtual clock, it could > have different values for different divisions of the code to TB. This is only true if the in

Re: [Qemu-devel] [PATCH 0/5] Platform device support

2014-06-27 Thread Peter Crosthwaite
On Fri, Jun 27, 2014 at 8:30 PM, Andreas Färber wrote: > Am 26.06.2014 14:01, schrieb Alexander Graf: >> >> On 20.06.14 08:43, Peter Crosthwaite wrote: >>> On Wed, Jun 4, 2014 at 10:28 PM, Alexander Graf wrote: Platforms without ISA and/or PCI have had a seriously hard time in the dynam

Re: [Qemu-devel] Reverse execution and deterministic replay

2014-06-27 Thread Pavel Dovgaluk
> On 27 June 2014 11:35, Pavel Dovgaluk wrote: > > The major disadvantage of icount is that it's updated only on TB boundaries. > > When one instruction in the middle of the block uses virtual clock, it could > > have different values for different divisions of the code to TB. > > This is only tr

Re: [Qemu-devel] [PATCH 0/5] Platform device support

2014-06-27 Thread Andreas Färber
Am 27.06.2014 12:54, schrieb Peter Crosthwaite: > On Fri, Jun 27, 2014 at 8:30 PM, Andreas Färber wrote: >> Am 26.06.2014 14:01, schrieb Alexander Graf: >>> On 20.06.14 08:43, Peter Crosthwaite wrote: On Wed, Jun 4, 2014 at 10:28 PM, Alexander Graf wrote: > Platforms without ISA and/or P

Re: [Qemu-devel] [PATCH 0/5] Platform device support

2014-06-27 Thread Alexander Graf
On 27.06.14 13:17, Andreas Färber wrote: Am 27.06.2014 12:54, schrieb Peter Crosthwaite: On Fri, Jun 27, 2014 at 8:30 PM, Andreas Färber wrote: Am 26.06.2014 14:01, schrieb Alexander Graf: On 20.06.14 08:43, Peter Crosthwaite wrote: On Wed, Jun 4, 2014 at 10:28 PM, Alexander Graf wrote: P

[Qemu-devel] [PULL 02/10] pc-bios/s390-ccw: cleanup and enhance bootmap defintions

2014-06-27 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add declarations to describe structure of different dasd IPL sources (eckd and fba). Move the structure definitions to a new header bootmap.h. While we are at it, change structs to typedefs. Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvurechens

[Qemu-devel] [PULL 03/10] pc-bios/s390-ccw: handle different sector sizes

2014-06-27 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Use the virtio device's configuration to figure out the disk geometry and use a sector size based upon the layout. [CH: s/SECTOR_SIZE/MAX_SECTOR_SIZE/g] Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Jens Freimann Sign

[Qemu-devel] [PULL 00/10] for-2.1: s390-ccw bios patches

2014-06-27 Thread Cornelia Huck
c bug (2014-06-26 14:08:14 +0100) are available in the git repository at: git://github.com/cohuck/qemu.git tags/s390x-20140627 for you to fetch changes up to 77416f4075a673a27cfe5a7a34e93c0fa9810e35: pc-bios/s390-ccw: update binary (2014-06-27 12:11:53

[Qemu-devel] [PULL 04/10] pc-bios/s390-ccw: add some utility code

2014-06-27 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" IPL_assert(term,message) is introduced to handle error conditions. ebcdic_to_ascii() to convert chars (mostly to print VOLSERs). read_block() provision for unified block-number handling. Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvurechenski

[Qemu-devel] [PULL 05/10] pc-bios/s390-ccw: Unify error handling

2014-06-27 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Convert to IPL_assert and friends Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c | 82 +++ pc-bios/

[Qemu-devel] [PULL 08/10] pc-bios/s390-ccw: IPL from CDL-formatted ECKD DASD

2014-06-27 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add code that allows us to start from ECKD DASD using the z/OS compatible disk layout (CDL), which is the most common format for ECKD DASD. Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Jens Freimann Signed-off-by: Co

[Qemu-devel] [PULL 10/10] pc-bios/s390-ccw: update binary

2014-06-27 Thread Cornelia Huck
From: Jens Freimann Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw.img | Bin 9432 -> 17624 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index 1c7f7640fc0c5f2505c4f1114a21b3b712852dbc..603e19e0

[Qemu-devel] [PULL 01/10] pc-bios/s390-ccw: make checkpatch happy

2014-06-27 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Remove tabs, tweak whitespace and comments. Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/bootmap.c| 37 - pc

Re: [Qemu-devel] [PATCH v4 0/6] iotests: Allow out-of-tree run

2014-06-27 Thread Markus Armbruster
Max Reitz writes: > On 07.06.2014 23:21, Max Reitz wrote: >> On 24.05.2014 23:24, Max Reitz wrote: >>> This series enables qemu-iotests to be run in a build tree outside of >>> the source tree. It also makes the tests use the command for invoking >>> the Python interpreter specified through confi

Re: [Qemu-devel] [PATCH] Allow mismatched virtio config-len

2014-06-27 Thread Paolo Bonzini
Il 27/06/2014 10:34, Dr. David Alan Gilbert (git) ha scritto: From: "Dr. David Alan Gilbert" Commit 'virtio: validate config_len on load' restricted config_len loaded from the wire to match the config_len that the device had. Unfortunately, there are cases where this isn't true, the one we fou

[Qemu-devel] [PULL 07/10] pc-bios/s390-ccw: factor out ipl code

2014-06-27 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Move the scsi-disk specific ipl code from zipl_load() into a new function ipl_scsi(). This makes it easier to add ipl routines for other disk types. Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Jens Freimann Signed-o

Re: [Qemu-devel] [PATCH 4/5] PPC: e500: Support platform devices

2014-06-27 Thread Alexander Graf
On 27.06.14 11:29, Eric Auger wrote: On 06/04/2014 02:28 PM, Alexander Graf wrote: For e500 our approach to supporting platform devices is to create a simple bus from the guest's point of view within which we map platform devices dynamically. We allocate memory regions always within the "platf

[Qemu-devel] [PULL 06/10] pc-bios/s390-ccw: Add fill_hex_val func to provide better msgs

2014-06-27 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Factor out helper function for dumping a hex value into a buffer. Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw/s390-ccw.h | 16 +++- 1 f

Re: [Qemu-devel] Reverse execution and deterministic replay

2014-06-27 Thread Pavel Dovgaluk
> On 27 June 2014 11:35, Pavel Dovgaluk wrote: > > The major disadvantage of icount is that it's updated only on TB boundaries. > > When one instruction in the middle of the block uses virtual clock, it could > > have different values for different divisions of the code to TB. > > This is only tr

[Qemu-devel] [PULL 09/10] pc-bios/s390-ccw: IPL from LDL/CMS-formatted ECKD DASD

2014-06-27 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" Add code that allows us to start from two further ECKD DASD disk layouts: LDL (Linux disk layout) and CMS (cms-formatted disk). Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvurechenski Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH 2/4] mips_malta: Change default KVM cpu to 24Kc (no FP)

2014-06-27 Thread Paolo Bonzini
Il 27/06/2014 10:43, Aurelien Jarno ha scritto: On Thu, Jun 26, 2014 at 10:44:23AM +0100, James Hogan wrote: Change the default Malta CPU model for when KVM is enabled to 24Kc which doesn't have floating point support compared to the 24Kf. The resulting incorrect Config CP0 register value doesn

Re: [Qemu-devel] [v5][PATCH 4/5] xen, gfx passthrough: create host bridge to passthrough

2014-06-27 Thread Paolo Bonzini
Il 27/06/2014 10:34, Chen, Tiejun ha scritto: So how to separate this to specific to xen? Or you mean we need to create an new machine to address this scenario? But actually this is same as xenfv_machine except for these little codes. Yes, please create a new machine so that "-M pc" doesn't h

Re: [Qemu-devel] [PATCH] ahci.c: mask the interrupt on complete flag to allow ahci.c to read the correct size for the PRDT

2014-06-27 Thread Paolo Bonzini
Il 27/06/2014 01:28, Reza Jelveh ha scritto: +static int prdt_tbl_entry_size(const AHCI_SG tbl) { + return (le32_to_cpu(tbl.flags_size) & AHCI_PRDT_SIZE_MASK) + 1; +} Apart from the incorrect indentation/formatting here, the patch seems okay. How can this be reproduced? Paolo

Re: [Qemu-devel] [PATCH v1] trace: add qemu_system_powerdown_request and qemu_system_shutdown_request trace events

2014-06-27 Thread Stefan Hajnoczi
On Sun, Jun 22, 2014 at 02:43:03AM +0800, Yang Zhiyong wrote: > We have the experience that the guest doesn't stop successfully > though it was instructed to shut down. > > The root cause may be not in QEMU mostly. However, QEMU is often > suspected at the beginning just because the issue occurr

Re: [Qemu-devel] [PATCH 0/5] Platform device support

2014-06-27 Thread Alexander Graf
On 27.06.14 12:30, Andreas Färber wrote: Am 26.06.2014 14:01, schrieb Alexander Graf: On 20.06.14 08:43, Peter Crosthwaite wrote: On Wed, Jun 4, 2014 at 10:28 PM, Alexander Graf wrote: Platforms without ISA and/or PCI have had a seriously hard time in the dynamic device creation world of QEM

Re: [Qemu-devel] [PATCH 0/5] Platform device support

2014-06-27 Thread Alexander Graf
On 27.06.14 12:54, Peter Crosthwaite wrote: On Fri, Jun 27, 2014 at 8:30 PM, Andreas Färber wrote: Am 26.06.2014 14:01, schrieb Alexander Graf: On 20.06.14 08:43, Peter Crosthwaite wrote: On Wed, Jun 4, 2014 at 10:28 PM, Alexander Graf wrote: Platforms without ISA and/or PCI have had a ser

Re: [Qemu-devel] [PULL 03/10] pc-bios/s390-ccw: handle different sector sizes

2014-06-27 Thread Alexander Graf
On 27.06.14 13:25, Cornelia Huck wrote: From: "Eugene (jno) Dvurechenski" Use the virtio device's configuration to figure out the disk geometry and use a sector size based upon the layout. [CH: s/SECTOR_SIZE/MAX_SECTOR_SIZE/g] Acked-by: Christian Borntraeger Signed-off-by: Eugene (jno) Dvure

Re: [Qemu-devel] [PATCH v11 1/3] sPAPR: Implement EEH RTAS calls

2014-06-27 Thread Alexander Graf
On 27.06.14 11:53, Gavin Shan wrote: On Thu, Jun 26, 2014 at 12:46:50PM +0200, Alexander Graf wrote: On 26.06.14 12:43, Gavin Shan wrote: On Thu, Jun 26, 2014 at 12:30:16PM +0200, Alexander Graf wrote: On 26.06.14 03:35, Gavin Shan wrote: The emulation for EEH RTAS requests from guest isn't

Re: [Qemu-devel] [PATCH V3] qemu-img create: add 'nocow' option

2014-06-27 Thread Stefan Hajnoczi
On Mon, Jun 23, 2014 at 05:17:02PM +0800, Chunyan Liu wrote: > Add 'nocow' option so that users could have a chance to set NOCOW flag to > newly created files. It's useful on btrfs file system to enhance performance. > > Btrfs has low performance when hosting VM images, even more when the guest >

Re: [Qemu-devel] [PATCH 0/5] Platform device support

2014-06-27 Thread Paolo Bonzini
Il 27/06/2014 13:24, Alexander Graf ha scritto: I think we can all agree that the sysbus bus is not a bus per se. So conceptually, what's the difference between a device attached to a non-bus and a device not attached to a bus at all? And why can't we convert sysbus to not be a bus anymore? I

Re: [Qemu-devel] [PATCH trivial v2] block.c: Add return value for bdrv_append_temp_snapshot() to avoid incorrect failure processing issue

2014-06-27 Thread Stefan Hajnoczi
On Tue, Jun 24, 2014 at 01:01:52PM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 23.06.2014 um 17:28 hat Chen Gang geschrieben: > >> When failure occurs, 'ret' need be set, or may return 0 to indicate > >> success. > >> And error_propagate() also need be called only one time with

Re: [Qemu-devel] Reverse execution and deterministic replay

2014-06-27 Thread Peter Maydell
On 27 June 2014 12:31, Pavel Dovgaluk wrote: > I forgot about one more issue. > When qemu stops execution on the breakpoint, the icount > is decreased to the number of instructions in the block. > But in this case the last instruction is not executed and > should not affect the counter. Yes, inde

Re: [Qemu-devel] [PATCH 0/5] Platform device support

2014-06-27 Thread Peter Maydell
On 27 June 2014 12:48, Paolo Bonzini wrote: > We could also make TYPE_MACHINE a subclass of TYPE_DEVICE, to have an > obvious place for this SoC object. Why isn't TYPE_MACHINE a subclass of TYPE_DEVICE anyway? thanks -- PMM

[Qemu-devel] [PULL 14/32] target-ppc: Remove unused gen_qemu_ld8s()

2014-06-27 Thread Alexander Graf
From: Peter Maydell The gen_qemu_ld8s() function is unused; remove it. Signed-off-by: Peter Maydell Signed-off-by: Alexander Graf --- target-ppc/translate.c | 5 - 1 file changed, 5 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index b501655..b23933f 100644 --

[Qemu-devel] [PULL 03/32] linux-user: Identify Addition Hardware Capabilities for PowerPC

2014-06-27 Thread Alexander Graf
From: Tom Musta Add VSX, DFP and ISA 2.06 to the bits identified in the AT_HWCAP entry of the AUXV. Signed-off-by: Tom Musta Signed-off-by: Alexander Graf --- linux-user/elfload.c | 8 1 file changed, 8 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 64d

[Qemu-devel] [PULL 09/32] spapr_iommu: Make in-kernel TCE table optional

2014-06-27 Thread Alexander Graf
From: Alexey Kardashevskiy POWER KVM supports an KVM_CAP_SPAPR_TCE capability which allows allocating TCE tables in the host kernel memory and handle H_PUT_TCE requests targeted to specific LIOBN (logical bus number) right in the host without switching to QEMU. At the moment this is used for emul

[Qemu-devel] [PULL 12/32] vfio: Enable for SPAPR

2014-06-27 Thread Alexander Graf
From: Alexey Kardashevskiy This turns the sPAPR support on and enables VFIO container use in the kernel. This extends vfio_connect_container to support VFIO_SPAPR_TCE_IOMMU type in the host kernel. This registers a memory listener which sPAPR IOMMU will notify when executing H_PUT_TCE/etc DMA c

[Qemu-devel] [PULL 22/32] spapr: Add RTAS sysparm UUID

2014-06-27 Thread Alexander Graf
From: Sam bobroff Add support for the UUID parameter to the emulated RTAS call ibm,get-system-parameter. Return the guest's UUID as the value for the RTAS UUID system parameter, or null (a zero length result) if it is not set. Signed-off-by: Sam Bobroff Signed-off-by: Alexander Graf --- hw/p

[Qemu-devel] [PULL 24/32] xics: Add flags for interrupts

2014-06-27 Thread Alexander Graf
From: Alexey Kardashevskiy The existing interrupt allocation scheme in SPAPR assumes that interrupts are allocated at the start time, continously and the config will not change. However, there are cases when this is not going to work such as: 1. migration - we will have to have an ability to cho

[Qemu-devel] [PULL 11/32] spapr_pci_vfio: Add spapr-pci-vfio-host-bridge to support vfio

2014-06-27 Thread Alexander Graf
From: Alexey Kardashevskiy The patch adds a spapr-pci-vfio-host-bridge device type which is a PCI Host Bridge with VFIO support. The new device inherits from the spapr-pci-host-bridge device and adds an "iommu" property which is an IOMMU id. This ID represents a minimal entity for which IOMMU iso

[Qemu-devel] [PULL 18/32] spapr: Fix code design style (s/SPAPRMachine/sPAPRMachineState)

2014-06-27 Thread Alexander Graf
From: Alexey Kardashevskiy Every single sPAPR QOM object has small first "s". Most (not all yet) QOM objects have "State" suffix. This replaces SPAPRMachine with sPAPRMachineState to conform with QEMU code style and removes redundant empty line. Signed-off-by: Alexey Kardashevskiy Signed-off-b

[Qemu-devel] [PULL 28/32] spapr: Remove @next_irq

2014-06-27 Thread Alexander Graf
From: Alexey Kardashevskiy This removes @next_irq from sPAPREnvironment which was used in old IRQ allocator as XICS is now responsible for IRQs and keeps track of allocated IRQs. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Alexander Graf --- hw/ppc/spapr.c | 3 +-- 1 file changed, 1 in

  1   2   3   4   >