Re: [Qemu-devel] [PATCH v1 2/3] linux-aio: implement io plug and unplug

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 03:05, Ming Lei ha scritto: Busy waiting is not acceptable here (it can be unbounded if, for example, an NFS server is on the other side of a network partition). You have to add a bottom half to qemu_laio_state that calls ioq_submit, and schedule it after calling io_getevents.

[Qemu-devel] [Bug 1336123] [NEW] bad switch, segfault in hw/pci-host/bonito.c bonito_readl

2014-07-01 Thread Robin Lee
Public bug reported: http://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci- host/bonito.c;h=56292adb03cd1a9873c2c9e5a0b2978fd0572214;hb=master#l301 The switch statement is error-prone, since two branches return the same result. Segfault reproducing steps: 1. make a Linux kernel(for example

[Qemu-devel] [Bug 1307473] Dependencies.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: Dependencies.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142886/+files/Dependencies.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-07-01 Thread Ilya Almametov
AlsaDevices: total 0 crw-rw 1 root audio 116, 1 июня 30 18:31 seq crw-rw 1 root audio 116, 33 июня 30 18:31 timer AplayDevices: Error: [Errno 2] No such file or directory ApportVersion: 2.14.1-0ubuntu3.2 Architecture: amd64 ArecordDevices: Error: [Errno 2] No such file or directory

[Qemu-devel] [Bug 1307473] Lspci.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: Lspci.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142888/+files/Lspci.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473 Title:

[Qemu-devel] [Bug 1307473] BootDmesg.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: BootDmesg.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142884/+files/BootDmesg.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473

[Qemu-devel] [Bug 1307473] ProcCpuinfo.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: ProcCpuinfo.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142890/+files/ProcCpuinfo.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473

[Qemu-devel] [Bug 1307473] ProcModules.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: ProcModules.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142893/+files/ProcModules.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473

[Qemu-devel] [Bug 1307473] IwConfig.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: IwConfig.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142887/+files/IwConfig.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473 Title:

[Qemu-devel] [Bug 1307473] WifiSyslog.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: WifiSyslog.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142896/+files/WifiSyslog.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473

[Qemu-devel] [Bug 1307473] UdevDb.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: UdevDb.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142894/+files/UdevDb.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473 Title:

[Qemu-devel] [Bug 1307473] Lsusb.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: Lsusb.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142889/+files/Lsusb.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473 Title:

[Qemu-devel] [Bug 1307473] UdevLog.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: UdevLog.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142895/+files/UdevLog.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473 Title:

[Qemu-devel] [Bug 1307473] ProcEnviron.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: ProcEnviron.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142891/+files/ProcEnviron.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473

[Qemu-devel] [Bug 1307473] ProcInterrupts.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: ProcInterrupts.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142892/+files/ProcInterrupts.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1307473] CurrentDmesg.txt

2014-07-01 Thread Ilya Almametov
apport information ** Attachment added: CurrentDmesg.txt https://bugs.launchpad.net/bugs/1307473/+attachment/4142885/+files/CurrentDmesg.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-07-01 Thread Ilya Almametov
** Changed in: linux (Ubuntu) Status: Incomplete = Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473 Title: guest hang due to missing clock interrupt Status in QEMU: New

Re: [Qemu-devel] [PATCH fix for 2.1] makefile: Fix tools compile

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 07:42, Alexey Kardashevskiy ha scritto: This is wrong actually. The problem here that compiler knows how to optimize constants. sin(0.0) is the one while log(0.0) is not (it is supposed to throw error or something as it the result is infinity). So the correct test here could be:

[Qemu-devel] [RFC PATCH V4 2/2] qemu: support xen hvm direct kernel boot

2014-07-01 Thread Chunyan Liu
qemu side patch to support xen HVM direct kernel boot: if -kernel exists, calls xen_load_linux(), which will read kernel/initrd and add a linuxboot.bin or multiboot.bin option rom. The linuxboot.bin/multiboot.bin will load kernel/initrd and jump to execute kernel directly. It's working when xen

[Qemu-devel] [RFC PATCH V4 1/2] xen: pass kernel initrd to qemu

2014-07-01 Thread Chunyan Liu
xen side patch to support xen HVM direct kernel boot: support 'kernel', 'ramdisk', 'cmdline' (and 'root', 'extra' as well which would be deprecated later) in HVM config file, parse config file, pass -kernel, -initrd, -append parameters to qemu. It's working with qemu-xen when using the default

[Qemu-devel] [RFC PATCH V4 0/2] Support xen HVM direct kernel boot

2014-07-01 Thread Chunyan Liu
Updated current patch series for working with qemu-xen and default BIOS (seabios), to make it in good shape. Stubdom support will be continued. xen side patch: pass kernel/initrd/append parameters to qemu-dm qemu side patch: reuse load_linux() for xen hvm direct kernel boot. Different from

Re: [Qemu-devel] [RFC 01/14] vga: Create direct sufaces for depth 24 too

2014-07-01 Thread Gerd Hoffmann
Hi, -if (depth == 32 || ((depth == 16 || depth == 15) !byteswap)) { + if (depth == 32 || depth == 24 || + ((depth == 16 || depth == 15) !byteswap)) { Doesn't apply. depth == 15 isn't upstream. Guess you have some more local changes? Also the whitespace looks fishy

Re: [Qemu-devel] [PATCH v3] vhost-user: fix regions provied with VHOST_USER_SET_MEM_TABLE message

2014-07-01 Thread Michael S. Tsirkin
On Thu, Jun 26, 2014 at 11:01:32PM +0200, Damjan Marion wrote: Old code was affected by memory gaps which resulted in buffer pointers pointing to address outside of the mapped regions. Here we are introducing following changes: - new function qemu_get_ram_block_host_ptr() returns host

Re: [Qemu-devel] core dump with drive-mirror

2014-07-01 Thread Stefan Hajnoczi
On Mon, Jun 30, 2014 at 05:40:16PM -0600, Eric Blake wrote: On 06/30/2014 05:16 PM, Eric Blake wrote: I'm trying to track down a core dump with the QMP drive-mirror command. Looks like the bug is related to a base image that is not a multiple of a cluster size. # in one terminal:

Re: [Qemu-devel] [PATCH for-2.1] block/cow: Avoid use of uninitialized cow_bs in error path

2014-07-01 Thread Stefan Hajnoczi
On Mon, Jun 30, 2014 at 07:03:37PM +0100, Peter Maydell wrote: Commit 25814e8987 introduced an error-exit code path which does a goto exit before the cow_bs variable is initialized, meaning we would call bdrv_unref() on an uninitialized variable and likely segfault. Fix this by moving the

Re: [Qemu-devel] [PATCH] qapi: Change back sector-count to sectors-count in quorum QAPI events.

2014-07-01 Thread Stefan Hajnoczi
On Mon, Jun 30, 2014 at 05:05:41PM +0200, Benoît Canet wrote: fe069d9d had aligned code and documentation while dropping the s from the actual JSON output. Fix that. This also fix test/qemu-iotest/081 since the missing s was causing a permutation. Signed-off-by: Benoit Canet

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin

2014-07-01 Thread Stefan Hajnoczi
On Mon, Jun 30, 2014 at 04:25:47PM +0200, Benoît Canet wrote: The Monday 30 Jun 2014 à 16:09:57 (+0200), Stefan Hajnoczi wrote : On Fri, Jun 27, 2014 at 10:17:16PM +0200, Benoît Canet wrote: I think this patch can be boiled down to 2 lines: if __name__ == '__main__': +if 'quorum'

[Qemu-devel] [PATCH fix for 2.1 v2] makefile: Fix tools compile

2014-07-01 Thread Alexey Kardashevskiy
The existing test whether -lm needs to be included or not is insufficient as it reports false negative on Fedora20/ppc64. This happens because sin(0.0) is a constant value which compiler can safely throw away and therefore there is no need to add -lm. As the result, qemu-nbd/qemu-io/qemu-img tools

Re: [Qemu-devel] [PATCH v8 03/14] qcow2: Optimize bdrv_make_empty()

2014-07-01 Thread Hu Tao
On Mon, Jun 30, 2014 at 01:33:39PM +0200, Kevin Wolf wrote: Am 07.06.2014 um 20:51 hat Max Reitz geschrieben: bdrv_make_empty() is currently only called if the current image represents an external snapshot that has been committed to its base image; it is therefore unlikely to have internal

Re: [Qemu-devel] Why devfn will be -1

2014-07-01 Thread Jan Kiszka
Hi Le, On 2014-07-01 04:34, Le Tan wrote: Hi Jan, I use pci_setup_iommu() to setup a PCIIOMMUFunc for the q35 pci bus. In the iommu_fn, I print out the devfn parameter and find out that it sometimes will be -1. So what does it mean? The detail code is here: In mch_init() function, I write

Re: [Qemu-devel] [PATCH fix for 2.1 v2] makefile: Fix tools compile

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 09:30, Alexey Kardashevskiy ha scritto: The existing test whether -lm needs to be included or not is insufficient as it reports false negative on Fedora20/ppc64. This happens because sin(0.0) is a constant value which compiler can safely throw away and therefore there is no need to

Re: [Qemu-devel] [PATCH fix for 2.1 v2] makefile: Fix tools compile

2014-07-01 Thread Alexey Kardashevskiy
On 07/01/2014 05:41 PM, Paolo Bonzini wrote: Il 01/07/2014 09:30, Alexey Kardashevskiy ha scritto: The existing test whether -lm needs to be included or not is insufficient as it reports false negative on Fedora20/ppc64. This happens because sin(0.0) is a constant value which compiler can

Re: [Qemu-devel] [RFC PATCH V3 6/6] monitor: Add drift info to 'info jit'

2014-07-01 Thread Frederic Konrad
On 30/06/2014 15:59, Sebastian Tanase wrote: Show in 'info jit' the current delay between the host clock and the guest clock. In addition, print the maximum advance and delay of the guest compared to the host. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr Tested-by: Camille Bégué

[Qemu-devel] [PATCH v8 for 2.1 4/4] block: add QAPI command to allow live backing file change

2014-07-01 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com This allows a user to make a live change to the backing file recorded in an open image. The image file to modify can be specified 2 ways: 1) image filename 2) image node-name Note: this does not cause the backing file itself to be reopened; it merely changes

[Qemu-devel] [PATCH v2 0/3] linux-aio: introduce submit I/O at batch

2014-07-01 Thread Ming Lei
Hi, The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) introduces ~40% throughput regression on virtio-blk dataplane, and one of causes is that submitting I/O at batch is removed. This patchset trys to introduce this mechanism on block, at least, linux-aio can benefit from that.

[Qemu-devel] [PATCH v2 1/3] block: block: introduce bdrv_io_plug() and bdrv_io_unplug()

2014-07-01 Thread Ming Lei
This patch introduces these two APIs so that following patches can support queuing I/O requests and submitting them at batch for improving I/O performance. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Ming Lei ming@canonical.com --- block.c | 21

[Qemu-devel] [PATCH v2 2/3] linux-aio: implement io plug and unplug

2014-07-01 Thread Ming Lei
This patch implements .bdrv_io_plug and .bdrv_io_unplug callbacks for linux-aio Block Drivers, so that submitting I/O at batch can be supported on linux-aio. Signed-off-by: Ming Lei ming@canonical.com --- block/linux-aio.c | 86 +++--

[Qemu-devel] [PATCH v2 3/3] dataplane: submit I/O at batch

2014-07-01 Thread Ming Lei
Before commit 580b6b2aa2(dataplane: use the Qemu block layer for I/O), dataplane for virtio-blk submits block I/O at batch. This commit 580b6b2aa2 replaces the custom linux AIO implementation(including I/O batch) with Qemu block layer, but this commit causes ~40% throughput regression on

Re: [Qemu-devel] [PATCH fix for 2.1 v2] makefile: Fix tools compile

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 09:47, Alexey Kardashevskiy ha scritto: On 07/01/2014 05:41 PM, Paolo Bonzini wrote: Il 01/07/2014 09:30, Alexey Kardashevskiy ha scritto: The existing test whether -lm needs to be included or not is insufficient as it reports false negative on Fedora20/ppc64. This happens

[Qemu-devel] The master branch qemu compiles failed.

2014-07-01 Thread ChenLiang
Hi, Qemu compiles failed. ./configure --enable-debug --target-list=x86_64-softmmu make -j net/l2tpv3.c: In function ‘net_l2tpv3_process_queue’: net/l2tpv3.c:368: error: invalid use of undefined type ‘struct mmsghdr’ net/l2tpv3.c:369: error: dereferencing pointer to incomplete type

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin

2014-07-01 Thread Kevin Wolf
Am 30.06.2014 um 16:09 hat Stefan Hajnoczi geschrieben: On Fri, Jun 27, 2014 at 10:17:16PM +0200, Benoît Canet wrote: I think this patch can be boiled down to 2 lines: if __name__ == '__main__': +if 'quorum' not in iotests.qemu_img('--help'): +iotests.notrun('not built with

Re: [Qemu-devel] [PATCH v4 02/33] target-arm: move Aarch32 SCR into security reglist

2014-07-01 Thread Edgar E. Iglesias
On Mon, Jun 30, 2014 at 06:09:02PM -0500, greg.bell...@linaro.org wrote: From: Fabian Aggeler aggel...@ethz.ch Define a new ARM CP register info list for the ARMv7 Security Extension feature. Register that list only for ARM cores with Security Extension/EL3 support. Moving Aarch32 SCR into

Re: [Qemu-devel] The master branch qemu compiles failed.

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 10:00, ChenLiang ha scritto: ./configure --enable-debug --target-list=x86_64-softmmu make -j net/l2tpv3.c: In function ‘net_l2tpv3_process_queue’: net/l2tpv3.c:368: error: invalid use of undefined type ‘struct mmsghdr’ net/l2tpv3.c:369: error: dereferencing pointer to incomplete

Re: [Qemu-devel] [PATCH v4 04/33] target-arm: add arm_is_secure() function

2014-07-01 Thread Edgar E. Iglesias
On Mon, Jun 30, 2014 at 06:09:04PM -0500, greg.bell...@linaro.org wrote: From: Fabian Aggeler aggel...@ethz.ch arm_is_secure() function allows to determine CPU security state if the CPU implements Security Extensions/EL3. arm_is_secure_below_el3() returns true if CPU is in secure state

Re: [Qemu-devel] [PATCH fix for 2.1] makefile: Fix tools compile

2014-07-01 Thread Peter Maydell
On 1 July 2014 07:52, Paolo Bonzini pbonz...@redhat.com wrote: Il 01/07/2014 07:42, Alexey Kardashevskiy ha scritto: This is wrong actually. The problem here that compiler knows how to optimize constants. sin(0.0) is the one while log(0.0) is not (it is supposed to throw error or something as

Re: [Qemu-devel] [PATCH v4 07/33] target-arm: add non-secure Translation Block flag

2014-07-01 Thread Edgar E. Iglesias
On Mon, Jun 30, 2014 at 06:09:07PM -0500, greg.bell...@linaro.org wrote: From: Sergey Fedorov s.fedo...@samsung.com This patch is based on idea found in patch at git://github.com/jowinter/qemu-trustzone.git f3d955c6c0ed8c46bc0eb10b634201032a651dd2 by Johannes Winter

Re: [Qemu-devel] [PATCH v8 for 2.1 4/4] block: add QAPI command to allow live backing file change

2014-07-01 Thread Kevin Wolf
Am 01.07.2014 um 09:52 hat Stefan Hajnoczi geschrieben: From: Jeff Cody jc...@redhat.com This allows a user to make a live change to the backing file recorded in an open image. The image file to modify can be specified 2 ways: 1) image filename 2) image node-name Note: this does not

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-07-01 Thread Gerd Hoffmann
On Mo, 2014-06-30 at 22:32 +1000, Benjamin Herrenschmidt wrote: On Mon, 2014-06-30 at 13:14 +0200, Gerd Hoffmann wrote: Hi, From what I can tell, we only ever call the cursor drawing callback on non-shared surfaces. Should I deduce that the HW cursor emulation simply doesn't work

[Qemu-devel] [PULL for-2.1 0/3] virtio-scsi fixes, and block/iscsi compilation fix

2014-07-01 Thread Paolo Bonzini
The following changes since commit ec9fe956d5c728da770db5ec9bc429080ccb5043: Merge remote-tracking branch 'remotes/bonzini/small-fixes' into staging (2014-06-30 15:56:00 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up

[Qemu-devel] [PULL 3/3] configure: Fix -lm test, so that tools can be compiled on hosts that require -lm

2014-07-01 Thread Paolo Bonzini
From: Alexey Kardashevskiy a...@ozlabs.ru The existing test whether -lm needs to be included or not is insufficient as it reports false negative on Fedora20/ppc64. This happens because sin(0.0) is a constant value which compiler can safely throw away and therefore there is no need to add -lm. As

[Qemu-devel] [PULL 2/3] virtio-scsi: scsi events must be converted to target endianness

2014-07-01 Thread Paolo Bonzini
From: Cédric Le Goater c...@fr.ibm.com Virtio SCSI Events need to be byteswapped before being pushed when host and guest have a different endianness. Not doing so breaks hotplug of virtio scsi disks, with the following error message being printed in the guest console: virtio_scsi: Unsupport

Re: [Qemu-devel] The master branch qemu compiles failed.

2014-07-01 Thread Laurent Desnogues
On Tue, Jul 1, 2014 at 10:17 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 01/07/2014 10:00, ChenLiang ha scritto: ./configure --enable-debug --target-list=x86_64-softmmu make -j net/l2tpv3.c: In function ‘net_l2tpv3_process_queue’: net/l2tpv3.c:368: error: invalid use of undefined type

[Qemu-devel] [PULL 1/3] virtio-scsi: virtio_scsi_push_event() lacks VirtIOSCSIReq parsing

2014-07-01 Thread Paolo Bonzini
From: Greg Kurz gk...@linux.vnet.ibm.com Hotplug of a virtio scsi disk is currently broken: no disk appears in the guest (verified with a fedora 20 host running a fedora 20 guest with KVM). Bisect leeds to Paolo's patches to support any_layout, especially this commit: commit

Re: [Qemu-devel] The master branch qemu compiles failed.

2014-07-01 Thread Stefan Hajnoczi
On Tue, Jul 01, 2014 at 04:00:52PM +0800, ChenLiang wrote: Qemu compiles failed. What is your kernel version? I guess you're running an old kernel without recvmmsg(). So the kernel headers are missing the mmsghdr struct. If you would like to contribute a patch to fix this, please introduce a

Re: [Qemu-devel] [PATCH v4 09/33] target-arm: extend Aarch32 async excp masking

2014-07-01 Thread Edgar E. Iglesias
On Mon, Jun 30, 2014 at 06:09:09PM -0500, greg.bell...@linaro.org wrote: From: Fabian Aggeler aggel...@ethz.ch This patch extends arm_excp_unmasked() according to ARM ARMv7 and ARM ARMv8 (all EL running in Aarch32) and adds comments. Signed-off-by: Fabian Aggeler aggel...@ethz.ch

Re: [Qemu-devel] [PATCH fix for 2.1] makefile: Fix tools compile

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 10:19, Peter Maydell ha scritto: I think something like double x; int f(void) {return isnan(sin(x));} should be bullet proof. This is a compile_prog test, though -- the compiler could spot that x and f are both unused, since it has the entire program in hand. My suggestion would

Re: [Qemu-devel] [PULL 3/3] configure: Fix -lm test, so that tools can be compiled on hosts that require -lm

2014-07-01 Thread Peter Maydell
On 1 July 2014 09:22, Paolo Bonzini pbonz...@redhat.com wrote: From: Alexey Kardashevskiy a...@ozlabs.ru The existing test whether -lm needs to be included or not is insufficient as it reports false negative on Fedora20/ppc64. This happens because sin(0.0) is a constant value which compiler

Re: [Qemu-devel] The master branch qemu compiles failed.

2014-07-01 Thread ChenLiang
On 2014/7/1 16:17, Paolo Bonzini wrote: Il 01/07/2014 10:00, ChenLiang ha scritto: ./configure --enable-debug --target-list=x86_64-softmmu make -j net/l2tpv3.c: In function ‘net_l2tpv3_process_queue’: net/l2tpv3.c:368: error: invalid use of undefined type ‘struct mmsghdr’

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-07-01 Thread Paolo Bonzini
Il 01/07/2014 10:26, Alexander Graf ha scritto: Right. A quick fix would be to add a flag to force always using a shadow surface and set it in cirrus ... I'm not sure anybody will notice the performance difference. I suspect we can rip out hw cursor emulation and nobody will notice the

[Qemu-devel] [PULL 01/15] qom: add object_property_add_alias()

2014-07-01 Thread Paolo Bonzini
From: Stefan Hajnoczi stefa...@redhat.com Sometimes an object needs to present a property which is actually on another object, or it needs to provide an alias name for an existing property. Examples: a.foo - b.foo a.old_name - a.new_name The new object_property_add_alias() API allows

[Qemu-devel] [PULL for 2.1 00/15] MemoryRegion QOMification

2014-07-01 Thread Paolo Bonzini
The following changes since commit 53a259da5697ec8a82463161e2e32ff942a08bc2: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-pci-for-qemu-20140630.0' into staging (2014-06-30 18:31:07 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git memory for

[Qemu-devel] [PULL 04/15] mc146818rtc: add rtc-time link to /machine/rtc

2014-07-01 Thread Paolo Bonzini
From: Marcelo Tosatti mtosa...@redhat.com Add a link to rtc under /machine providing a stable location for management apps to query the value of the time. The link should be added by any object that sends RTC_TIME_CHANGE events. {execute:qom-get,arguments:{path:/machine,property:rtc-time} }

[Qemu-devel] [PULL 08/15] memory: MemoryRegion: use /machine as default owner

2014-07-01 Thread Paolo Bonzini
This will be added (after QOMification) as the QOM parent. Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- memory.c | 2 +- vl.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/memory.c b/memory.c index

[Qemu-devel] [PULL 03/15] qom: allow creating an alias of a child property

2014-07-01 Thread Paolo Bonzini
Child properties must be unique. Fix this problem by turning their aliases into links. The resolve function that forwards to the target property does not have any knowledge of the target property's type, so it works fine. Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com

[Qemu-devel] [PULL 05/15] qom: object: remove parent pointer when unparenting

2014-07-01 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Certain parts of the QOM framework test this pointer to determine if an object is parented. Nuke it when the object is unparented to allow for reuse of an object after unparenting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com

[Qemu-devel] [PULL 10/15] memory: MemoryRegion: replace owner field with QOM parent

2014-07-01 Thread Paolo Bonzini
The two are now the same. Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/exec/memory.h | 1 - memory.c | 35 +-- 2 files changed, 25 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PULL 02/15] qom: add a generic mechanism to resolve paths

2014-07-01 Thread Paolo Bonzini
It may be desirable to have custom link properties that do more than just store an object. Even the addition of a check function is not enough if setting the link has side effects or if a non-standard reference counting is preferrable. Avoid the assumption that the opaque field of a link is a

[Qemu-devel] [PULL 07/15] libqtest: escape strings in QMP commands, fix leak

2014-07-01 Thread Paolo Bonzini
libqtest is using g_strdup_printf to format QMP commands, but this does not work if the argument strings need to be escaped. Instead, use the fancy %-formatting functionality of QObject. The only change required in tests is that strings have to be formatted as %s, not '%s' or \%s\. Luckily this

[Qemu-devel] [PULL 14/15] memory: do not give a name to the internal exec.c regions

2014-07-01 Thread Paolo Bonzini
There is no need to have them visible under /machine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- exec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index df4a080..5a2a25e 100644 --- a/exec.c +++ b/exec.c @@ -1801,13 +1801,13 @@

[Qemu-devel] [PULL 13/15] memory: MemoryRegion: Add size property

2014-07-01 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com To allow devices to dynamically resize the device. The motivation is to allow devices with variable size to init their memory_region without size early and then correctly populate size at realize() time. Signed-off-by: Peter Crosthwaite

[Qemu-devel] [PULL 15/15] qdev: correctly send DEVICE_DELETED for recursively-deleted devices

2014-07-01 Thread Paolo Bonzini
When a device is unparented (i.e. made completely hidden from management) we want to send a DEVICE_DELETED event only if the device actually was realized. This avoids raising DEVICE_DELETED events when device_add fails. However, this does not work right for recursively-deleted devices: the whole

[Qemu-devel] [Bug 1336194] [NEW] Errors reporting in do_delvm caused a crash

2014-07-01 Thread Étienne Buira
Public bug reported: In case of multiple errors, it leads to a crash. Typical back trace: #0 in libc in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 in libc in __GI_abort () at abort.c:90 #2 in libc in __libc_message (do_abort=do_abort@entry=2,

Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin

2014-07-01 Thread Stefan Hajnoczi
On Tue, Jul 1, 2014 at 10:10 AM, Kevin Wolf kw...@redhat.com wrote: Am 30.06.2014 um 16:09 hat Stefan Hajnoczi geschrieben: On Fri, Jun 27, 2014 at 10:17:16PM +0200, Benoît Canet wrote: I think this patch can be boiled down to 2 lines: if __name__ == '__main__': +if 'quorum' not in

[Qemu-devel] [PULL for-2.1 00/24] Block patches

2014-07-01 Thread Stefan Hajnoczi
The following changes since commit 53a259da5697ec8a82463161e2e32ff942a08bc2: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-pci-for-qemu-20140630.0' into staging (2014-06-30 18:31:07 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git

[Qemu-devel] [PULL for-2.1 02/24] virtio-blk: avoid qdev property definition duplication

2014-07-01 Thread Stefan Hajnoczi
It becomes unwiedly to duplicate all virtio-blk qdev property definitions due to an #ifdef. The C preprocessor syntax makes it a little hard to resolve this cleanly but we can extract the #ifdef and call a macro it defines later. Avoiding duplication is important since it will only get worse

[Qemu-devel] [PULL for-2.1 08/24] virtio: fix virtio-blk child refcount in transports

2014-07-01 Thread Stefan Hajnoczi
object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug the virtio-blk child is not finalized! Drop our reference

[Qemu-devel] [PULL for-2.1 04/24] virtio-blk: move x-data-plane qdev property to virtio-blk.h

2014-07-01 Thread Stefan Hajnoczi
Move the x-data-plane property. Originally it was outside since not every transport may wish to support dataplane. But that makes little sense when we have a dedicated CONFIG_VIRTIO_BLK_DATA_PLANE ifdef already. This move makes it easier to switch to property aliases in the next patch.

[Qemu-devel] [PULL for-2.1 05/24] qdev: add qdev_alias_all_properties()

2014-07-01 Thread Stefan Hajnoczi
The qdev_alias_all_properties() function creates QOM alias properties for each qdev property on a DeviceState. This is useful for parent objects that wish to forward property accesses to their children. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Peter Crosthwaite

[Qemu-devel] [PULL for-2.1 01/24] qom: add object_property_add_alias()

2014-07-01 Thread Stefan Hajnoczi
Sometimes an object needs to present a property which is actually on another object, or it needs to provide an alias name for an existing property. Examples: a.foo - b.foo a.old_name - a.new_name The new object_property_add_alias() API allows objects to alias a property on the same object or

[Qemu-devel] [PULL for-2.1 12/24] virtio-blk: remove need for explicit x-data-plane=on option

2014-07-01 Thread Stefan Hajnoczi
The x-data-plane=on|off option is no longer useful because the iothread=iothread option conveys the same information plus which IOThread to use. Do not delete x-data-plane=on|off yet as a convenience to people using this legacy experimental option. We will drop it in QEMU 2.2. Instead, turn on

[Qemu-devel] [PULL for-2.1 06/24] virtio-blk: use aliases instead of duplicate qdev properties

2014-07-01 Thread Stefan Hajnoczi
virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the qdev properties of their VirtIOBlock child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property

[Qemu-devel] [PULL for-2.1 09/24] virtio-blk: move qdev properties into virtio-blk.c

2014-07-01 Thread Stefan Hajnoczi
There is no need to make DEFINE_VIRTIO_BLK_PROPERTIES() public. Inline it into virtio-blk.c so it cannot be used by mistake from other source files. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/block/virtio-blk.c

[Qemu-devel] [PULL for-2.1 07/24] virtio-blk: drop virtio_blk_set_conf()

2014-07-01 Thread Stefan Hajnoczi
This function is no longer used since parent objects now use child aliases to set the VirtIOBlkConf directly. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/block/virtio-blk.c | 6 --

[Qemu-devel] [PULL for-2.1 03/24] dataplane: bail out on unsupported transport

2014-07-01 Thread Stefan Hajnoczi
From: Cornelia Huck cornelia.h...@de.ibm.com If the virtio transport does not support notifiers (like s390-virtio), we can't use dataplane. Bail out early and let the user know what is wrong. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PULL for-2.1 14/24] iotests: Simplify qemu-iotests-quick.sh

2014-07-01 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com As of the iotests: Allow out-of-tree run series, the qemu-iotests may (and should) be run directly in the build tree and will then guess the binary paths themselves. Therefore, qemu-iotests-quick.sh does not need to (and should not) enter the source path anymore;

[Qemu-devel] [PULL for-2.1 11/24] qdev: drop iothread property type

2014-07-01 Thread Stefan Hajnoczi
The iothread property type is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/core/qdev-properties-system.c | 50 include/hw/qdev-properties.h | 3 --- 2 files changed, 53 deletions(-) diff --git

[Qemu-devel] [PULL for-2.1 15/24] iotests: Add qemu tests to quick group

2014-07-01 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com Now that qemu-iotests-quick.sh supports tests using the qemu binary, we are free to add such tests to the quick group. Signed-off-by: Max Reitz mre...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/group | 18

[Qemu-devel] [PULL for-2.1 10/24] virtio-blk: replace x-iothread with iothread link property

2014-07-01 Thread Stefan Hajnoczi
Up until now -device virtio-blk-pci,x-iothread=id was used to assign an IOThread. This was a temporary solution while we cleaned up QOM link properties. This patch switches over to a QOM link property since it is now possible to restrict the setter to unrealized instances and automatically unref

[Qemu-devel] [PULL for-2.1 13/24] qemu-img create: add 'nocow' option

2014-07-01 Thread Stefan Hajnoczi
From: Chunyan Liu cy...@suse.com Add 'nocow' option so that users could have a chance to set NOCOW flag to newly created files. It's useful on btrfs file system to enhance performance. Btrfs has low performance when hosting VM images, even more when the guest in those VM are also using btrfs as

[Qemu-devel] [PULL for-2.1 17/24] block: make 'top' argument to block-commit optional

2014-07-01 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com Now that active layer block-commit is supported, the 'top' argument no longer needs to be mandatory. Change it to optional, with the default being the active layer in the device chain. [kwolf: Rebased and resolved conflict in tests/qemu-iotests/040]

[Qemu-devel] [PULL for-2.1 22/24] block: add helper function to determine if a BDS is in a chain

2014-07-01 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com This is a small helper function, to determine if 'base' is in the chain of BlockDriverState 'top'. It returns true if it is in the chain, and false otherwise. If either argument is NULL, it will also return false. Reviewed-by: Benoit Canet ben...@irqsave.net

[Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow live backing file change

2014-07-01 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com This allows a user to make a live change to the backing file recorded in an open image. The image file to modify can be specified 2 ways: 1) image filename 2) image node-name Note: this does not cause the backing file itself to be reopened; it merely changes

[Qemu-devel] [PULL for-2.1 20/24] qapi: Change back sector-count to sectors-count in quorum QAPI events.

2014-07-01 Thread Stefan Hajnoczi
From: Benoît Canet benoit.ca...@irqsave.net fe069d9d had aligned code and documentation while dropping the s from the actual JSON output. Fix that. This also fix test/qemu-iotest/081 since the missing s was causing a permutation. Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Eric

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-07-01 Thread Alexander Graf
On 01.07.14 10:20, Gerd Hoffmann wrote: On Mo, 2014-06-30 at 22:32 +1000, Benjamin Herrenschmidt wrote: On Mon, 2014-06-30 at 13:14 +0200, Gerd Hoffmann wrote: Hi, From what I can tell, we only ever call the cursor drawing callback on non-shared surfaces. Should I deduce that the HW

[Qemu-devel] [PULL for-2.1 16/24] iotests: Add more tests to quick group

2014-07-01 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com While at it, add some more tests to the quick group (those that run with -nocache in under three seconds on my HDD). Signed-off-by: Max Reitz mre...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/group | 38

Re: [Qemu-devel] [RFC PATCH V3 1/6] icount: Add QemuOpts for icount

2014-07-01 Thread Frederic Konrad
On 30/06/2014 15:59, Sebastian Tanase wrote: Make icount parameter use QemuOpts style options in order to easily add other suboptions. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr Tested-by: Camille Bégué camille.be...@openwide.fr --- cpus.c| 10 +-

[Qemu-devel] [PULL for-2.1 23/24] block: extend block-commit to accept a string for the backing file

2014-07-01 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com On some image chains, QEMU may not always be able to resolve the filenames properly, when updating the backing file of an image after a block commit. For instance, certain relative pathnames may fail, or drives may have been specified originally by file

Re: [Qemu-devel] [PATCH 0/3] virtio-blk: Suppress error action on r/w beyond end

2014-07-01 Thread Markus Armbruster
Please consider for 2.1. It needs git-am -3 by now; if you need a respin, let me know. Markus Armbruster arm...@redhat.com writes: When a device model's I/O operation fails, we execute the error action. This lets layers above QEMU implement thin provisioning, or attempt to correct errors

[Qemu-devel] [PULL for-2.1 24/24] block: add backing-file option to block-stream

2014-07-01 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com On some image chains, QEMU may not always be able to resolve the filenames properly, when updating the backing file of an image after a block job. For instance, certain relative pathnames may fail, or drives may have been specified originally by file descriptor

[Qemu-devel] [PULL for-2.1 0/1] Tracing pull request

2014-07-01 Thread Stefan Hajnoczi
The following changes since commit 53a259da5697ec8a82463161e2e32ff942a08bc2: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-pci-for-qemu-20140630.0' into staging (2014-06-30 18:31:07 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git

  1   2   3   4   >