Re: [Qemu-devel] [PATCH] qmp: show QOM properties in device-list-properties

2014-07-05 Thread Paolo Bonzini
Il 20/05/2014 14:29, Stefan Hajnoczi ha scritto: Devices can use a mix of qdev and QOM properties. Currently only the qdev properties are displayed by device-list-properties. This patch extends the property enumeration algorithm to also display QOM properties (excluding the implicit type,

Re: [Qemu-devel] [PATCH for-2.1] target-i386: Add kvmclock-stable-bit feature bit name

2014-07-05 Thread Paolo Bonzini
Il 04/07/2014 21:44, Eduardo Habkost ha scritto: KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is enabled by default and supported by KVM. But not having a name defined makes QEMU treat it as an unknown and unmigratable feature flag (as any unknown feature may possibly require state to be migrated), and

Re: [Qemu-devel] [PATCH 07/46] Return path: Open a return path on QEMUFile for sockets

2014-07-05 Thread Paolo Bonzini
Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: From: Dr. David Alan Gilbert dgilb...@redhat.com Postcopy needs a method to send messages from the destination back to the source, this is the 'return path'. Wire it up for 'socket' QEMUFile's using a dup'd fd. Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH 08/46] Return path: socket_writev_buffer: Block even on non-blocking fd's

2014-07-05 Thread Paolo Bonzini
Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: From: Dr. David Alan Gilbert dgilb...@redhat.com The return path uses a non-blocking fd so as not to block waiting for the (possibly broken) destination to finish returning a message, however we still want outbound data to behave in

Re: [Qemu-devel] [PATCH 31/46] Postcopy: Rework migration thread for postcopy mode

2014-07-05 Thread Paolo Bonzini
Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: From: Dr. David Alan Gilbert dgilb...@redhat.com Switch to postcopy if: 1) There's still a significant amount to transfer 2) Postcopy is enabled 3) It's taken longer than the time set by the parameter. and change the

Re: [Qemu-devel] [PATCH 15/46] Rework loadvm path for subloops

2014-07-05 Thread Paolo Bonzini
Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: From: Dr. David Alan Gilbert dgilb...@redhat.com Postcopy needs to have two migration streams loading concurrently; one from memory (with the device state) and the other from the fd with the memory transactions. Can you explain

Re: [Qemu-devel] [PATCH 00/46] Postcopy implementation

2014-07-05 Thread Paolo Bonzini
Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: e) I've added a 'migration_set_parameter' command as somewhere to put integer parameters associated with migration. e.1) And I use that initially for the length of precopy to try. Could you have instead a

Re: [Qemu-devel] [PATCH] compile QEMU with Xen support on ARM

2014-07-05 Thread Peter Maydell
On 5 July 2014 02:53, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: I admit that this small series was lost in my mailbox. I had an older version of the build fixes patch and started from there again. Are you OK with v2 as per your link? It applies almost as is, except for the

[Qemu-devel] virtualize sparc developer workstation?

2014-07-05 Thread dennis luehring
i want to virtualize (under a linux x86 host) my noisy sparc workstation with the help of qemu and want to know if its possible to get an system image to run or what other options available for sparc virtualization im developing a low-traffic network communication software and sparc is one of my

[Qemu-devel] virtualize sparc developer workstation?

2014-07-05 Thread dennis luehring
i want to virtualize my noisy sparc workstation with the help of qemu and want to know if its possible to get an system image to run or what other options available for sparc virtualization im developing a low-traffic network communication software and sparc is one of my test platforms is the

[Qemu-devel] [PATCH v9 00/14] qemu-img: Implement commit like QMP

2014-07-05 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the commit command, this is relatively easy, so implement it first (in the hope that indeed others will follow). As qemu-img does not have access to QMP (due

[Qemu-devel] [PATCH v9 13/14] iotests: Add test for qcow2's bdrv_make_empty

2014-07-05 Thread Max Reitz
Add a test for qcow2's fast bdrv_make_empty implementation on images without internal snapshots. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/098 | 75 ++ tests/qemu-iotests/098.out | 26

[Qemu-devel] [PATCH v9 08/14] qemu-img: Empty image after commit

2014-07-05 Thread Max Reitz
After the top image has been committed, it should be emptied unless specified otherwise. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 34 +++--- qemu-img.texi| 6 +- 3

[Qemu-devel] [PATCH v9 14/14] iotests: Omit length/offset test in 040 and 041

2014-07-05 Thread Max Reitz
As the length of a mirror block job no longer directly depends on the size of the block device, drop those checks from this test. Instead, just check whether the final offset equals the block job length. As 041 uses the wait_until_completed function from iotests.py, the same applies there as well

[Qemu-devel] [PATCH v9 09/14] qemu-img: Enable progress output for commit

2014-07-05 Thread Max Reitz
Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 24 ++-- qemu-img.texi| 2 +- 3 files

[Qemu-devel] [PATCH v9 01/14] qcow2: Allow full discard

2014-07-05 Thread Max Reitz
Normally, discarded sectors should read back as zero. However, there are cases in which a sector (or rather cluster) should be discarded as if they were never written in the first place, that is, reading them should fall through to the backing file again. Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v9 03/14] qcow2: Optimize bdrv_make_empty()

2014-07-05 Thread Max Reitz
bdrv_make_empty() is currently only called if the current image represents an external snapshot that has been committed to its base image; it is therefore unlikely to have internal snapshots. In this case, bdrv_make_empty() can be greatly sped up by creating an empty L1 table and dropping all data

[Qemu-devel] [PATCH v9 10/14] qemu-img: Specify backing file for commit

2014-07-05 Thread Max Reitz
Introduce a new parameter for qemu-img commit which may be used to explicitly specify the backing file into which an image should be committed if the backing chain has more than a single layer. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com ---

[Qemu-devel] [PATCH v9 05/14] blockjob: Add ready field

2014-07-05 Thread Max Reitz
When a block job signals readiness, this is currently reported only through QMP. If qemu wants to use block jobs for internal tasks, there needs to be another way to correctly detect when a block job may be completed. For this reason, introduce a bool ready which is set when the block job may be

[Qemu-devel] [PATCH v9 11/14] iotests: Add _filter_qemu_img_map

2014-07-05 Thread Max Reitz
As different image formats most probably map guest addresses to different host addresses, add a filter to filter the host addresses out; also, the image filename should be filtered. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com ---

[Qemu-devel] [PATCH v9 12/14] iotests: Add test for backing-chain commits

2014-07-05 Thread Max Reitz
Add a test for qemu-img commit on backing chains with more than two images. This test also checks whether the top image is emptied (unless this is prevented by specifying either -d or -b) and does therefore not work for qed and vmdk which requires it to be separate from 020. Signed-off-by: Max

[Qemu-devel] [PATCH v9 06/14] block/mirror: Improve progress report

2014-07-05 Thread Max Reitz
Instead of taking the total length of the block device as the block job's length, use the number of dirty sectors. The progress is now the number of sectors mirrored to the target block device. Note that this may result in the job's length increasing during operation, which is however in fact

Re: [Qemu-devel] [libvirt] Not able to run virsh qemu-agent-command when socat is working

2014-07-05 Thread Puneet Bakshi
Sorry, that was a typo. But, it is still not working. (For some reason, I had to move to Windows2012 with name vm_win_05). [root@sdsr720-14 virtio-win]# echo {'execute':'guest-ping'} | socat stdio,ignoreeof /var/lib/libvirt/qemu/g05.agent {return: {}} [root@sdsr720-14 virtio-win]# virsh

[Qemu-devel] [PATCH v9 07/14] qemu-img: Implement commit like QMP

2014-07-05 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. As qemu-img itself has no access to QMP (since this would basically require just everything being linked into qemu-img), imitate QMP's implementation of

[Qemu-devel] [PATCH v9 04/14] blockjob: Introduce block_job_complete_sync()

2014-07-05 Thread Max Reitz
Implement block_job_complete_sync() by doing the exact same thing as block_job_cancel_sync() does, only with calling block_job_complete() instead of block_job_cancel(). Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- blockjob.c | 39

[Qemu-devel] [PATCH v9 02/14] qcow2: Implement bdrv_make_empty()

2014-07-05 Thread Max Reitz
Implement this function by making all clusters in the image file fall through to the backing file (by using the recently extended discard). Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 27

Re: [Qemu-devel] [PATCH 1/4] block: Make qiov match the request size until EOF

2014-07-05 Thread Max Reitz
On 04.07.2014 17:55, Kevin Wolf wrote: If a read request goes across EOF, the block driver sees a shortened request that stops at EOF (the rest is memsetted in block.c), however the original qiov was used for this request. This patch makes the qiov size match the request size, avoiding a

Re: [Qemu-devel] [PATCH 2/4] qcow2: Make qiov match request size until backing file EOF

2014-07-05 Thread Max Reitz
On 04.07.2014 17:55, Kevin Wolf wrote: If a qcow2 image has a shorter backing file and a read request to unallocated clusters goes across EOF of the backing file, the backing file sees a shortened request and the rest is filled with zeros. However, the original too long qiov was used with the

Re: [Qemu-devel] [PATCH 3/4] qed: Make qiov match request size until backing file EOF

2014-07-05 Thread Max Reitz
On 04.07.2014 17:55, Kevin Wolf wrote: If a QED image has a shorter backing file and a read request to unallocated clusters goes across EOF of the backing file, the backing file sees a shortened request and the rest is filled with zeros. However, the original too long qiov was used with the

Re: [Qemu-devel] [PATCH 4/4] block: Assert qiov length matches request length

2014-07-05 Thread Max Reitz
On 04.07.2014 17:55, Kevin Wolf wrote: At least raw-posix relies on this because it can allocate bounce buffers based on the request length, but access it using all of the qiov entries later. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 2 ++ block/raw-posix.c | 15

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-05 Thread Al Viro
On Sat, Jul 05, 2014 at 02:40:55AM +0100, Al Viro wrote: a) softfloat.c raises flags we don't care about. So checking that FP_STATUS.float_exception_flags is non-zero is *not* good - we catch false positives that way. b) DNZ has effect *only* for /S insns. Without /S denorm means INV and

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-05 Thread Al Viro
On Sat, Jul 05, 2014 at 10:09:51PM +0100, Al Viro wrote: Anyway, the current delta (on top of 26f86) follows; seems to get IEEE insns behave on non-finite arguments as they do on 21264. The main exception is that register bitmask supplied to trap isn't calculated in a bunch of cases; since

[Qemu-devel] How to decide the value of Host Address Width in ACPI DMAR table

2014-07-05 Thread Le Tan
Hi, I am doing Intel IOMMU emulation for q35. I need to add a DMAR table to ACPI. There is one field in the DMAR table called Host Address Width, which indicates the maximum DMA physical addressability supported by this platform. I am not sure what this value should be and how to get this value.

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-07-05 Thread Benjamin Herrenschmidt
On Wed, 2014-07-02 at 14:12 +0200, Gerd Hoffmann wrote: https://www.kraxel.org/cgit/qemu/log/?h=rebase/console-wip Added a patch for hardware cursor support via dpy_cursor_define(). Old hardware cursor code is still in, so in theory this gives you two pointers. In practice it only shows

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-07-05 Thread Benjamin Herrenschmidt
On Sun, 2014-07-06 at 12:19 +1000, Benjamin Herrenschmidt wrote: I've started to look (and while at it added use of the dirty bitmap to catch changes to the HW cursor image just because it looked easy). One obvious issue: Your patch: gtk: update mouse position in mouse_set() Completely

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-07-05 Thread Benjamin Herrenschmidt
On Sun, 2014-07-06 at 12:19 +1000, Benjamin Herrenschmidt wrote: One obvious issue: Your patch: gtk: update mouse position in mouse_set() Completely breaks cursor movement in NT4 (I haven't checked with other guests). It works fine without the patch. This is after cherry-picking on top of