Re: [Qemu-devel] [PATCH v2 1/2 for-2.1] vhost-user: Fix VHOST_SET_MEM_TABLE processing

2014-07-11 Thread Paolo Bonzini
Il 12/07/2014 03:42, Nikolay Nikolaev ha scritto: qemu_get_ram_fd doesn't accept a guest physical address. ram_addr_t are opaque values that are assigned in qemu_ram_alloc. Find the ram_addr_t corresponding to the userspace_addr using qemu_ram_addr_from_host, and then call qemu_get_ram_fd on it

[Qemu-devel] [PATCH v1 resend 2/2] virtio-blk: dataplane: notify guest as a batch

2014-07-11 Thread Ming Lei
From: Ming Lei Now requests are submitted as a batch, so it is natural to notify guest as a batch too. This may suppress interrupt notification to VM a lot: - in my test, decreased by ~13K/sec Signed-off-by: Ming Lei --- hw/block/dataplane/virtio-blk.c | 23 ---

[Qemu-devel] [PATCH v1 resend 1/2] virtio-blk: data-plane: fix save/set .complete_request in start

2014-07-11 Thread Ming Lei
The callback has to be saved and reset in virtio_blk_data_plane_start(), otherwise dataplane's requests will be completed in qemu aio context. Reviewed-by: Fam Zheng Signed-off-by: Ming Lei --- hw/block/dataplane/virtio-blk.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v1 resend 0/2] virtio-blk: dataplane: one fix plus one optimization

2014-07-11 Thread Ming Lei
Hi, The first one fixes one problem introduced recently. The second one suppresses notifications to guest a lot. V1: - use BH to suppress notifications to guest as suggested by Paolo Thanks, -- Ming Lei

[Qemu-devel] [PATCH v2 for-2.1] linux-aio: Fix laio resource leak

2014-07-11 Thread arei.gonglei
From: Gonglei when hotplug virtio-scsi disks using laio, the aio_nr will increase in laio_init() by io_setup(), we can see the number by # cat /proc/sys/fs/aio-nr 128 if the aio_nr attach the maxnum, which found from # cat /proc/sys/fs/aio-max-nr 65536 the hotplug process will fail becaus

Re: [Qemu-devel] [PATCH] block/quorum: make quorum_getlength error message user friendly

2014-07-11 Thread Liu Yuan
On Fri, Jul 11, 2014 at 12:26:58PM +0200, Kevin Wolf wrote: > Am 11.07.2014 um 09:34 hat Liu Yuan geschrieben: > > When start quorum driver with 2 different sized images, we get: > > > > qemu-system-x86_64: -drive if=virtio,driver=quorum...: Could not refresh > > total \ > > sector count: Input/o

Re: [Qemu-devel] [PATCH] block/quorum: add simple read pattern support

2014-07-11 Thread Liu Yuan
On Fri, Jul 11, 2014 at 08:06:36AM -0600, Eric Blake wrote: > On 07/10/2014 09:01 PM, Liu Yuan wrote: > > This patch adds single read pattern to quorum driver and quorum vote is > > default > > pattern. > > > > For now we do a quorum vote on all the reads, it is designed for unreliable > > underl

Re: [Qemu-devel] [PATCH] block/quorum: add simple read pattern support

2014-07-11 Thread Liu Yuan
On Fri, Jul 11, 2014 at 12:56:53PM +0200, Benoît Canet wrote: > The Friday 11 Jul 2014 à 11:01:22 (+0800), Liu Yuan wrote : > > This patch adds single read pattern to quorum driver and quorum vote is > > default > > pattern. > > > > For now we do a quorum vote on all the reads, it is designed for

[Qemu-devel] [PATCH for-2.1] linux-aio: Fix laio resource leak

2014-07-11 Thread arei.gonglei
From: Gonglei when hotplug virtio-scsi disks using laio, the aio_nr will incresment in laio_init() by io_setup(), we can see the number by # cat /proc/sys/fs/aio-nr 128 if the aio_nr attach the maxnum, which found from # cat /proc/sys/fs/aio-max-nr 65536 the hotplug process will fail beca

[Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

2014-07-11 Thread Liu Yuan
Cc: Kevin Wolf Signed-off-by: Liu Yuan --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 7dd43fd..78e7baf 100755 --- a/configure +++ b/configure @@ -3996,7 +3996,7 @@ if test "$libnfs" != "no" ; then LIBS="$LIBS $libnfs_libs" el

[Qemu-devel] [PATCH v2 2/2 for-2.1] qtest: Adapt vhost-user-test to latehs vhost-user changes

2014-07-11 Thread Nikolay Nikolaev
A new field mmap_offset was added in the vhost-user message, we need to reflect this change in the test too. Signed-off-by: Nikolay Nikolaev --- tests/vhost-user-test.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-te

[Qemu-devel] [PATCH v2 1/2 for-2.1] vhost-user: Fix VHOST_SET_MEM_TABLE processing

2014-07-11 Thread Nikolay Nikolaev
qemu_get_ram_fd doesn't accept a guest physical address. ram_addr_t are opaque values that are assigned in qemu_ram_alloc. Find the ram_addr_t corresponding to the userspace_addr using qemu_ram_addr_from_host, and then call qemu_get_ram_fd on it. Thanks to Paolo Bonzini Signed-off-by: Nikolay

[Qemu-devel] [PATCH v2 0/2 for-2.1] vhost-user fixes

2014-07-11 Thread Nikolay Nikolaev
The latest vhost-user changes changed the VHOST_SET_MEM_TABLE handling. Now the memory regions are mapped from dev->mem. There is an error when calling qemu_get_ram_fd with reg->guest_phys_addr. The right approach is to find the ram_addr_t corresponding to the userspace_addr using qemu_ram_addr_

Re: [Qemu-devel] qemu qmp [info usb] and [info hostusb]

2014-07-11 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Pascal Heinrich > Sent: Saturday, July 12, 2014 5:52 AM > To: qemu-devel@nongnu.org > Subject: [Qemu-devel] qemu qmp [info usb]

[Qemu-devel] [Bug 1341032] [NEW] no-shutdown does not fire SHUTDOWN event for some guests

2014-07-11 Thread md_5
Public bug reported: Currently using: qemu-x86_64 version 2.0.0 Steps to reproduce: Create virtual machine with the arguments -no-shutdown, such as used by libvirt. Attach to the json event system. Load a guest such as Ubuntu 14.04 and run the 'halt' command. Guest ceases to execute, qemu freeze

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-11 Thread Alexander Graf
On 11.07.14 20:22, Peter Maydell wrote: On 11 July 2014 19:15, Joakim Tjernlund wrote: Peter Maydell wrote on 2014/07/11 19:14:25: On 11 July 2014 16:18, Joakim Tjernlund wrote: ppc logs every type of Invalid instruction. This generates a lot Rather than just deleting this EXCP_DUMP, I w

Re: [Qemu-devel] [PATCH_v2] ahci.c: mask unused flags when reading size PRDT DBC

2014-07-11 Thread John Snow
On 07/01/2014 07:36 AM, Kevin Wolf wrote: Am 01.07.2014 um 13:13 hat reza.jel...@tuhh.de geschrieben: From: Reza Jelveh The data byte count(DBC) read from the description information is defined for bits 21:00. Bits 30:22 are reserved and bit 31 is the Interrupt on Completion (I) flag. Comple

Re: [Qemu-devel] dataplane: latest rc with selected patches hangs very often

2014-07-11 Thread Andrey Korolyov
On Sat, Jul 12, 2014 at 12:45 AM, Paolo Bonzini wrote: > Il 11/07/2014 21:18, Andrey Korolyov ha scritto: > >> On Fri, Jul 11, 2014 at 11:01 PM, Andrey Korolyov wrote: >>> >>> Hello, >>> >>> is it worthy to re-test dp until next tag point? I am checking aio >>> with -rc1 and following picked comm

[Qemu-devel] [PATCH 3/4] iotests: Make some qemu-io commands read-only

2014-07-11 Thread Max Reitz
Test 072 (and 089 which copied some parts from it) tests image format nesting. When opening the inner image, qemu now correctly emits a warning because you should not attempt to write to the inner image of such a constellation. An example would be: 1. Create a qcow2 image with some relatively larg

[Qemu-devel] [PATCH 4/4] iotests: Skip read and write in 040 for length=0

2014-07-11 Thread Max Reitz
Do not prevent to actually do a meaningful comparison after the commit in case the backing image has a length of zero: The reason qemu-io does not return "verification failed" in these tests is simply that it returns "I/O error" instead. Therefore, it's better to skip these comparisons instead of p

[Qemu-devel] [PATCH 0/4] block: Warn about usage of growing formats over non-growable protocols

2014-07-11 Thread Max Reitz
Some image formats (e.g. qcow2) require the underlying file to grow on write accesses, but this is in fact not supported by all protocols (e.g. nbd does not). If such a format requiring file growth is used non-read-only over a protocol which does not support this, a warning should be issued. This

[Qemu-devel] [PATCH 1/4] block: Correct bs->growable

2014-07-11 Thread Max Reitz
Currently, the field "growable" in a BDS is set iff the BDS is opened in protocol mode (with O_BDRV_PROTOCOL). However, not every protocol block driver allows growing: NBD, for instance, does not. On the other hand, a non-protocol block driver may allow growing: The raw driver does. Fix this by co

[Qemu-devel] [PATCH 2/4] block: Introduce requires_growing_file

2014-07-11 Thread Max Reitz
There are several block drivers which may require the underlying file to grow on write accesses because new clusters need to be allocated. If such a format should be used non-read-only over a protocol which does not allow file growth, emit an appropriate warning. This is relevant e.g. for qcow2 ov

[Qemu-devel] qemu qmp [info usb] and [info hostusb]

2014-07-11 Thread Pascal Heinrich
Hi, I am trying to implement a qtprogram to bind and unbind usb devices from an qemu instance. Via device_add I am able to bind a device to the vm but there is no command in qmp to list binded devices or I do not find them. I am searching for something like >"query-usb"< Is there something impl

Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension

2014-07-11 Thread Eric Blake
On 07/11/2014 12:51 PM, Luiz Capitulino wrote: { 'type': 'VersionInfo', 'data': {'qemu': {'major': 'int', 'minor': 'int', 'micro': 'int'}, + '__com.redhat.crap': {'major': 'int', 'minor': 'int', 'micro': 'int'}, 'package': 'str'} } >>> >>> And th

Re: [Qemu-devel] [PATCH v12 6/6] qcow2: Add falloc and full preallocation option

2014-07-11 Thread Max Reitz
On 11.07.2014 08:10, Hu Tao wrote: This adds preallocation=falloc and preallocation=full mode to qcow2 image creation. preallocation=full allocates disk space by writing zeros to disk to ensure disk space in any cases. preallocation=falloc likes preallocation=full, but allocates disk space by p

Re: [Qemu-devel] [PATCH 0/3] vhost-user fixes

2014-07-11 Thread Paolo Bonzini
Il 08/07/2014 16:05, Nikolay Nikolaev ha scritto: The latest vhost-user changes changed the VHOST_SET_MEM_TABLE handling. Now the memory regions are mapped from dev->mem. The BIOS is registered at address 0xfffc which is out of memory boundaries for guests with less than 4G RAM. Calling qemu_

Re: [Qemu-devel] [PATCH 2/3] vhost-user: Fix VHOST_SET_MEM_TABLE processing

2014-07-11 Thread Paolo Bonzini
Il 08/07/2014 16:06, Nikolay Nikolaev ha scritto: @@ -216,6 +216,10 @@ static int vhost_user_call(struct vhost_dev *dev, unsigned long int request, case VHOST_SET_MEM_TABLE: for (i = 0; i < dev->mem->nregions; ++i) { struct vhost_memory_region *reg = dev->mem->regions

Re: [Qemu-devel] dataplane: latest rc with selected patches hangs very often

2014-07-11 Thread Paolo Bonzini
Il 11/07/2014 21:18, Andrey Korolyov ha scritto: On Fri, Jul 11, 2014 at 11:01 PM, Andrey Korolyov wrote: Hello, is it worthy to re-test dp until next tag point? I am checking aio with -rc1 and following picked commits (sorry for patchwork references): stefanha: 368191 New [v3,1/4] v

Re: [Qemu-devel] [Xen-devel] [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-07-11 Thread Tian, Kevin
> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: Friday, July 11, 2014 12:42 PM > > On Fri, Jul 11, 2014 at 08:29:56AM +0200, Daniel Vetter wrote: > > On Thu, Jul 10, 2014 at 09:08:24PM +, Tian, Kevin wrote: > > > actually I'm curious whether it's still necessary to __dete

Re: [Qemu-devel] [Xen-devel] [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-07-11 Thread Konrad Rzeszutek Wilk
On Fri, Jul 11, 2014 at 08:29:56AM +0200, Daniel Vetter wrote: > On Thu, Jul 10, 2014 at 09:08:24PM +, Tian, Kevin wrote: > > actually I'm curious whether it's still necessary to __detect__ PCH. Could > > we assume a 1:1 mapping between GPU and PCH, e.g. BDW already hard > > code the knowledge:

Re: [Qemu-devel] dataplane: latest rc with selected patches hangs very often

2014-07-11 Thread Andrey Korolyov
On Fri, Jul 11, 2014 at 11:01 PM, Andrey Korolyov wrote: > Hello, > > is it worthy to re-test dp until next tag point? I am checking aio > with -rc1 and following picked commits (sorry for patchwork > references): > > stefanha: > 368191 New [v3,1/4] virtio-blk: avoid dataplane > VirtIOBlo

[Qemu-devel] dataplane: latest rc with selected patches hangs very often

2014-07-11 Thread Andrey Korolyov
Hello, is it worthy to re-test dp until next tag point? I am checking aio with -rc1 and following picked commits (sorry for patchwork references): stefanha: 368191 New [v3,1/4] virtio-blk: avoid dataplane VirtIOBlockReq early free 368787 New [v3,2/4] dataplane: do not free VirtQ

Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension

2014-07-11 Thread Luiz Capitulino
On Fri, 11 Jul 2014 18:01:50 +0200 Markus Armbruster wrote: > Eric Blake writes: > > > On 07/11/2014 08:42 AM, Markus Armbruster wrote: > > > Can anybody think of a use of c_var() that needs '.' preserved? > >>> > >>> Doing the replace in c_var() breaks some struct accesses in the generate

Re: [Qemu-devel] [PATCH 0/3] vhost-user fixes

2014-07-11 Thread Michael S. Tsirkin
On Tue, Jul 08, 2014 at 05:05:29PM +0300, Nikolay Nikolaev wrote: > The latest vhost-user changes changed the VHOST_SET_MEM_TABLE handling. > Now the memory regions are mapped from dev->mem. The BIOS is registered > at address 0xfffc which is out of memory boundaries for guests with > less than

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10 18/18] Add qtest for vhost-user

2014-07-11 Thread Nikolay Nikolaev
On Fri, Jul 11, 2014 at 9:35 PM, Michael S. Tsirkin wrote: > On Wed, Jul 09, 2014 at 04:24:03PM +0200, Kevin Wolf wrote: >> Am 27.05.2014 um 14:07 hat Nikolay Nikolaev geschrieben: >> > This test creates a 'server' chardev to listen for vhost-user messages. >> > Once VHOST_USER_SET_MEM_TABLE is re

Re: [Qemu-devel] [PATCH v10 18/18] Add qtest for vhost-user

2014-07-11 Thread Michael S. Tsirkin
On Wed, Jul 09, 2014 at 04:24:03PM +0200, Kevin Wolf wrote: > Am 27.05.2014 um 14:07 hat Nikolay Nikolaev geschrieben: > > This test creates a 'server' chardev to listen for vhost-user messages. > > Once VHOST_USER_SET_MEM_TABLE is received it mmaps each received region, > > and read 1k bytes from

Re: [Qemu-devel] [PULL for-2.1 00/22] Block patches for 2.1.0-rc2

2014-07-11 Thread Peter Maydell
On 11 July 2014 13:46, Peter Maydell wrote: > I'm afraid this fails 'make check' on my 32 bit ARM box: > > TEST: tests/hd-geo-test... (pid=5395) > /i386/hd-geo/ide/none: OK > /i386/hd-geo/ide/drive/mbr/blank: > qemu-system-i386: /root/qemu/block/ra

Re: [Qemu-devel] [PATCH 4/4] ppc: remove excessive logging

2014-07-11 Thread Peter Maydell
On 11 July 2014 19:15, Joakim Tjernlund wrote: > Peter Maydell wrote on 2014/07/11 19:14:25: >> On 11 July 2014 16:18, Joakim Tjernlund > wrote: >> > ppc logs every type of Invalid instruction. This generates a lot >> Rather than just deleting this EXCP_DUMP, I would suggest >> changing the EXCP

Re: [Qemu-devel] [PATCH 4/4] ppc: remove excessive logging

2014-07-11 Thread Joakim Tjernlund
Peter Maydell wrote on 2014/07/11 19:14:25: > > On 11 July 2014 16:18, Joakim Tjernlund wrote: > > ppc logs every type of Invalid instruction. This generates a lot > > of garbage on console when sshd/ssh_keygen executes as > > they try various insn to optimize its performance. > > The invalid

Re: [Qemu-devel] [PATCH for-2.1] pc_piix: Reuse pc_compat_1_2() for pc-0.1[0123]

2014-07-11 Thread Michael S. Tsirkin
On Mon, Jul 07, 2014 at 03:30:52PM -0300, Eduardo Habkost wrote: > pc-0.13 and older were missing some compat code that was present on > newer machine-types: > > * x86_cpu_compat_disable_kvm_features(FEAT_1_ECX, CPUID_EXT_X2APIC); > (pc-i440fx-1.7 and older) > (added by commit ef02ef5f4536dba0

Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types

2014-07-11 Thread Michael S. Tsirkin
On Tue, Jul 08, 2014 at 03:29:46PM +0200, Igor Mammedov wrote: > If machine doesn't support memory hotplug then staring QEMU > with initial memory less than default will make QEMU exit with > following error message: > > $QEMU -m 16 -M isapc > qemu-system-i386: "-memory 'slots|maxmem'" is not sup

Re: [Qemu-devel] [PULL 0/3] vga: some cirrus fixes.

2014-07-11 Thread Peter Maydell
(2014-07-10 > 11:53:14 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-vga-20140711-1 > > for you to fetch changes up to d16136d22af0fcf0d651de04c9e3cbc7137cc6f9: > >

Re: [Qemu-devel] [PATCH 2/4] linux-user: impl. sockaddr_ll

2014-07-11 Thread Joakim Tjernlund
Peter Maydell wrote on 2014/07/11 18:00:25: > On 11 July 2014 16:18, Joakim Tjernlund wrote: > > Used by AF_PACKET sockets > > > > Signed-off-by: Joakim Tjernlund > > --- > > linux-user/syscall.c | 8 > > linux-user/syscall_defs.h | 10 ++ > > 2 files changed, 18 inserti

Re: [Qemu-devel] [PATCH 4/4] ppc: remove excessive logging

2014-07-11 Thread Peter Maydell
On 11 July 2014 16:18, Joakim Tjernlund wrote: > ppc logs every type of Invalid instruction. This generates a lot > of garbage on console when sshd/ssh_keygen executes as > they try various insn to optimize its performance. > The invalid operation log is still there so an unknown insn > will still

Re: [Qemu-devel] [PATCH 3/4] alloca one extra byte sockets

2014-07-11 Thread Peter Maydell
On 11 July 2014 16:18, Joakim Tjernlund wrote: > target_to_host_sockaddr() may increase the lenth with 1 byte > for AF_UNIX sockets so allocate 1 extra byte. > > Signed-off-by: Joakim Tjernlund > --- > linux-user/syscall.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-07-11 Thread Mike Lowe
I can confirm that rolling back to 3.13.0-27 from 3.13.0-30 alleviated my symptoms. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473 Title: guest hang due to missing clock interrupt Status in

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-11 Thread Peter Maydell
On 11 July 2014 17:07, Joakim Tjernlund wrote: > Peter Maydell wrote on 2014/07/11 17:46:28: >> This needs braces for our coding style; you might like >> to run your patches through scripts/checkpatch.pl, which >> will warn about this kind of thing. > > Ahh, I figured you had kernel style. No, w

Re: [Qemu-devel] [PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-07-11 Thread Richard Henderson
On 07/11/2014 09:43 AM, Alex Bennée wrote: > +/* if I could put this in a header easily */ > +void tb_enable_perfmap(void); How about next to tb_flush in exec/exec-all.h? > + > +void tb_enable_perfmap(void) { Watch the { placement. > +gchar * map_file = g_strdup_printf("/tmp/perf-%d.map

[Qemu-devel] [PATCH] tcg: add ability to dump /tmp/perf-.map files

2014-07-11 Thread Alex Bennée
This allows the perf tool to map samples to each individual translation block. This could be expanded for user space but currently it gives enough information to find any hotblocks by other means. Signed-off-by: Alex Bennée --- v2: - hoist up into translate-all.c - don't use pointless glib

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-11 Thread Joakim Tjernlund
Peter Maydell wrote on 2014/07/11 17:46:28: > From: Peter Maydell > To: Joakim Tjernlund , > Cc: QEMU Developers > Date: 2014/07/11 17:46 > Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE) > > On 11 July 2014 16:18, Joakim Tjernlund wrote: > > Signed-off-b

Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension

2014-07-11 Thread Markus Armbruster
Eric Blake writes: > On 07/11/2014 08:42 AM, Markus Armbruster wrote: > Can anybody think of a use of c_var() that needs '.' preserved? >>> >>> Doing the replace in c_var() breaks some struct accesses in the generated >>> code. I didn't look deeper to determine the users though. >> >> Feels

Re: [Qemu-devel] [PULL 0/1] mtp: linux guest detection fix

2014-07-11 Thread Peter Maydell
an string (2014-07-10 > 11:53:14 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-usb-20140711-1 > > for you to fetch changes up to 13d54125a3482a5837682499d25f6be10aa824be: > > m

Re: [Qemu-devel] [PATCH 2/4] linux-user: impl. sockaddr_ll

2014-07-11 Thread Peter Maydell
On 11 July 2014 16:18, Joakim Tjernlund wrote: > Used by AF_PACKET sockets > > Signed-off-by: Joakim Tjernlund > --- > linux-user/syscall.c | 8 > linux-user/syscall_defs.h | 10 ++ > 2 files changed, 18 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/sysc

Re: [Qemu-devel] [PATCH] backends: Introduce chr-testdev

2014-07-11 Thread Paolo Bonzini
Il 11/07/2014 17:30, Eric Blake ha scritto: On 07/11/2014 01:44 AM, Andrew Jones wrote: From: Paolo Bonzini From: Paolo Bonzini chr-testdev enables a virtio serial channel to be used for guest initiated qemu exits. hw/misc/debugexit already enables guest initiated qemu exits, but only for PC

Re: [Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-11 Thread Peter Maydell
On 11 July 2014 16:18, Joakim Tjernlund wrote: > Signed-off-by: Joakim Tjernlund > --- > linux-user/syscall.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 5a272d3..1380f4e 100644 > --- a/linux-user/syscall.c > +++ b/li

Re: [Qemu-devel] [PATCH] linux-aio: fix submit aio as a batch

2014-07-11 Thread Ming Lei
On Wed, Jul 9, 2014 at 4:29 PM, Stefan Hajnoczi wrote: > On Tue, Jul 08, 2014 at 11:45:10PM +0800, Ming Lei wrote: >> In the enqueue path, we can't complete request, otherwise >> "Co-routine re-entered recursively" may be caused, so this >> patch fixes the issue with below ideas: > > Thi probably

Re: [Qemu-devel] [PATCH 37/46] Add assertion to check migration_dirty_pages doesn't go -ve; have seen it happen once but not sure why

2014-07-11 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > Long subject line. Also, spell out "negative" instead of abbreviating "-ve" Fixed. Dave > > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > a

Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension

2014-07-11 Thread Eric Blake
On 07/11/2014 08:42 AM, Markus Armbruster wrote: >>> Can anybody think of a use of c_var() that needs '.' preserved? >> >> Doing the replace in c_var() breaks some struct accesses in the generated >> code. I didn't look deeper to determine the users though. > > Feels like a misuse of c_var() to m

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-07-11 Thread Mike Lowe
I believe I have the same problem, place a guest under any amount of load, let's say 'yum upgrade' and the network stack goes out to lunch for 1-5 seconds. Here is a sample of the ping statistics (host to guest) from doing such an operation on a 3.13.0-30.55 kernel: 213 packets transmitted, 213 r

Re: [Qemu-devel] [PATCH] backends: Introduce chr-testdev

2014-07-11 Thread Eric Blake
On 07/11/2014 01:44 AM, Andrew Jones wrote: > From: Paolo Bonzini > > From: Paolo Bonzini > > chr-testdev enables a virtio serial channel to be used for guest > initiated qemu exits. hw/misc/debugexit already enables guest > initiated qemu exits, but only for PC targets. chr-testdev supports >

Re: [Qemu-devel] [PATCH 37/46] Add assertion to check migration_dirty_pages doesn't go -ve; have seen it happen once but not sure why

2014-07-11 Thread Eric Blake
On 07/04/2014 11:41 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" Long subject line. Also, spell out "negative" instead of abbreviating "-ve" > > Signed-off-by: Dr. David Alan Gilbert > --- > arch_init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch

[Qemu-devel] [PATCH 1/4] qemu-user: Impl. setsockopt(SO_BINDTODEVICE)

2014-07-11 Thread Joakim Tjernlund
Signed-off-by: Joakim Tjernlund --- linux-user/syscall.c | 12 1 file changed, 12 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5a272d3..1380f4e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1497,6 +1497,18 @@ set_timeout:

[Qemu-devel] [PATCH 3/4] alloca one extra byte sockets

2014-07-11 Thread Joakim Tjernlund
target_to_host_sockaddr() may increase the lenth with 1 byte for AF_UNIX sockets so allocate 1 extra byte. Signed-off-by: Joakim Tjernlund --- linux-user/syscall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a0e1ccc.

[Qemu-devel] [PATCH 4/4] ppc: remove excessive logging

2014-07-11 Thread Joakim Tjernlund
ppc logs every type of Invalid instruction. This generates a lot of garbage on console when sshd/ssh_keygen executes as they try various insn to optimize its performance. The invalid operation log is still there so an unknown insn will still be logged. Signed-off-by: Joakim Tjernlund --- linux-u

[Qemu-devel] [PATCH 0/4] make busybox udhcpc happy

2014-07-11 Thread Joakim Tjernlund
Fix a endian/socket bugs so that busybox udhcpc for qemu-user(host amd64, target ppc) works. Note, the "[PATCH] SIOCGIFINDEX: fix typo" patch sent yesterday is also needed for udhcpc to work. BTW, busybox still generates a Unsupported setsockopt level=263 optname=8 (AUXDATA) but that seems harml

[Qemu-devel] [PATCH 2/4] linux-user: impl. sockaddr_ll

2014-07-11 Thread Joakim Tjernlund
Used by AF_PACKET sockets Signed-off-by: Joakim Tjernlund --- linux-user/syscall.c | 8 linux-user/syscall_defs.h | 10 ++ 2 files changed, 18 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 1380f4e..a0e1ccc 100644 --- a/linux-user/syscall.c +

Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6

2014-07-11 Thread Ian Campbell
On Fri, 2014-07-11 at 15:54 +0100, Stefano Stabellini wrote: > On Fri, 11 Jul 2014, Ian Campbell wrote: > > On Fri, 2014-07-11 at 12:14 +0100, Stefano Stabellini wrote: > > > On Thu, 10 Jul 2014, Ian Jackson wrote: > > > > Stefano Stabellini writes ("Re: [PATCH v2] libxl: change default QEMU > > >

Re: [Qemu-devel] [Xen-devel] [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6

2014-07-11 Thread Stefano Stabellini
On Fri, 11 Jul 2014, Ian Campbell wrote: > On Fri, 2014-07-11 at 12:14 +0100, Stefano Stabellini wrote: > > On Thu, 10 Jul 2014, Ian Jackson wrote: > > > Stefano Stabellini writes ("Re: [PATCH v2] libxl: change default QEMU > > > machine to pc-i440fx-1.6"): > > > > ping? > > > > > > > > On Thu, 1

Re: [Qemu-devel] [PULL 0/1] spice: auth fixes

2014-07-11 Thread Peter Maydell
string (2014-07-10 > 11:53:14 +0100) > > are available in the git repository at: > > git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20140711-1 > > for you to fetch changes up to b1ea7b79e1675355ea7abe2548ad71dcf7d64b60:

Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension

2014-07-11 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 10 Jul 2014 16:31:38 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > The event code generator barfs when it sees a dot in an event >> > argument, this makes it impossible to support vendor extensions >> > in event arguments as they always

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2014-07-11 Thread Peter Maydell
What cmake is doing is an entirely legitimate and well-recognized Unix idiom for converting signals into effects on filedescriptors for select(), and there's no reason for them to change it. This is absolutely a bug in QEMU, it's just one that's not easy for us to fix. (Using socketpair would not h

Re: [Qemu-devel] [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6

2014-07-11 Thread Ian Campbell
On Fri, 2014-07-11 at 12:14 +0100, Stefano Stabellini wrote: > On Thu, 10 Jul 2014, Ian Jackson wrote: > > Stefano Stabellini writes ("Re: [PATCH v2] libxl: change default QEMU > > machine to pc-i440fx-1.6"): > > > ping? > > > > > > On Thu, 12 Jun 2014, Stefano Stabellini wrote: > > ... > > > > T

Re: [Qemu-devel] [PATCH] block/quorum: add simple read pattern support

2014-07-11 Thread Eric Blake
On 07/10/2014 09:01 PM, Liu Yuan wrote: > This patch adds single read pattern to quorum driver and quorum vote is > default > pattern. > > For now we do a quorum vote on all the reads, it is designed for unreliable > underlying storage such as non-redundant NFS to make sure data integrity at > t

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2014-07-11 Thread vitaly.v.ch
https://lists.tizen.org/pipermail/dev/2014-July/003424.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cmake hangs with qemu-arm-static Status in QEMU: Confirmed Status in Linar

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2014-07-11 Thread vitaly.v.ch
It's just excellent illustration why I hate pipes. So CMake guys can remove this crap from their code and use socketpair() or like instead. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title

Re: [Qemu-devel] [PULL 0/1] ui/gtk: Restore keyboard focus after Page change

2014-07-11 Thread Peter Maydell
(2014-07-10 > 11:53:14 +0100) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-gtk-20140711-1 > > for you to fetch changes up to e72b59fa93b68635f42cdb1b1134f60dd4040d7b: > > ui/gtk: Restore ke

Re: [Qemu-devel] [PATCH] Tap: fix vcpu long time io blocking on tap

2014-07-11 Thread Stefan Hajnoczi
On Fri, Jul 11, 2014 at 01:05:30AM +, Wangkai (Kevin,C) wrote: > When used a tap as net driver for vm, if too many packets was delivered to > the > guest os via tap interface, the guest os will be blocked on io events for a > long > time, while tap driver was busying process packets. > > kv

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-07-11 Thread Amit Shah
On (Wed) 09 Jul 2014 [12:00:13], Peter Maydell wrote: > On 9 July 2014 11:56, Amit Shah wrote: > > On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote: > >> OK; we're treating those as bugs so yes, I think this is 2.1 > >> material. Has somebody other than the original author tested > >> it? (Tha

[Qemu-devel] [PATCH for 2.1 1/1] vmstate static checker: detect section renames

2014-07-11 Thread Amit Shah
Commit 292b1634 changed the section name of "ICH9 LPC" to "ICH9-LPC", and that causes the static checker to flag this: Section "ICH9 LPC" does not exist in dest This patch introduces a function that checks for section renames and also a dictionary that maps those renames. Reported-by: "Dr. David

Re: [Qemu-devel] [PULL for-2.1 00/22] Block patches for 2.1.0-rc2

2014-07-11 Thread Peter Maydell
On 10 July 2014 13:35, Kevin Wolf wrote: > The following changes since commit 675879f6f3c9463e103735a4e41e9deb0bee9b39: > > Update version for v2.1.0-rc1 release (2014-07-08 16:53:59 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > fo

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Markus Armbruster
Eduardo Otubo writes: > On Fri, Jul 11, 2014 at 2:19 PM, Markus Armbruster wrote: >> Eduardo Otubo writes: >> >>> On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster >>> wrote: [Top-quote moved to its rightful place; please do not top quote on technical lists] Anshul Makkar

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Eduardo Otubo
On Fri, Jul 11, 2014 at 2:19 PM, Markus Armbruster wrote: > Eduardo Otubo writes: > >> On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: >>> [Top-quote moved to its rightful place; please do not top quote on >>> technical lists] >>> >>> Anshul Makkar writes: >>> On Wed, Jul 9, 2014

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Markus Armbruster
Anshul Makkar writes: > On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: >> ly, leaving your machine running on the source. > > > Hmm. Got the point. > > But as I mentioned above if we have to use live vertical scaling on > qemu 2.0, then pc-model 1.0 won't help (as the dimm handling an

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Markus Armbruster
Eduardo Otubo writes: > On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: >> [Top-quote moved to its rightful place; please do not top quote on >> technical lists] >> >> Anshul Makkar writes: >> >>> On Wed, Jul 9, 2014 at 6:25 PM, Andreas Färber wrote: Am 09.07.2014 13:09, schrieb

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Anshul Makkar
On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: > ly, leaving your machine running on the source. Hmm. Got the point. But as I mentioned above if we have to use live vertical scaling on qemu 2.0, then pc-model 1.0 won't help (as the dimm handling and bus handling has changed in pc-mod

Re: [Qemu-devel] live migration + licensing issue.

2014-07-11 Thread Eduardo Otubo
On Fri, Jul 11, 2014 at 1:12 PM, Markus Armbruster wrote: > [Top-quote moved to its rightful place; please do not top quote on > technical lists] > > Anshul Makkar writes: > >> On Wed, Jul 9, 2014 at 6:25 PM, Andreas Färber wrote: >>> Am 09.07.2014 13:09, schrieb Anshul Makkar: Thanks. I go

Re: [Qemu-devel] [PULL 1/1] mtp: linux guest detection fix.

2014-07-11 Thread Gerd Hoffmann
On Fr, 2014-07-11 at 13:33 +0200, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Attach a name to the MTP interface (android phones have this too). > > > > With this patch recent linux guests such as fedora 20 happily detect and > > use the device. It shows up in nautilus file manager au

Re: [Qemu-devel] [PATCH for-2.1? 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock

2014-07-11 Thread Christian Borntraeger
On 11/07/14 13:20, Stefan Hajnoczi wrote: > These patches convert thread-pool.c from EventNotifier to QEMUBH. They then > solve the deadlock when nested aio_poll() calls are made. > > Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of > the nested aio_poll() deadlock eve

Re: [Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Markus Armbruster
Peter Maydell writes: > On 11 July 2014 12:18, Markus Armbruster wrote: >> Gerd Hoffmann writes: >> >>> Set auth to sasl when sasl is enabled, this makes "info spice" correctly >>> display sasl auth. >> >> Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? >> >> If yes, I'd recommend to

Re: [Qemu-devel] [PULL 1/1] mtp: linux guest detection fix.

2014-07-11 Thread Markus Armbruster
Gerd Hoffmann writes: > Attach a name to the MTP interface (android phones have this too). > > With this patch recent linux guests such as fedora 20 happily detect and > use the device. It shows up in nautilus file manager automatically, and > simple-mtpfs can mount it. > > Signed-off-by: Gerd H

Re: [Qemu-devel] [PATCH v2 for-2.1 1/1] s390x/kvm: synchronize guest floating point registers

2014-07-11 Thread Alexander Graf
On 11.07.14 13:21, Cornelia Huck wrote: From: "Jason J. Herne" Add code to kvm_arch_get_registers and kvm_arch_put_registers to save/restore floating point registers. This missing sync was unnoticed until migration of userspace that uses fprs. Signed-off-by: Jason J. Herne Signed-off-by: Chr

[Qemu-devel] [PATCH for-2.1? 1/2] thread-pool: avoid per-thread-pool EventNotifier

2014-07-11 Thread Stefan Hajnoczi
EventNotifier is implemented using an eventfd or pipe. It therefore consumes file descriptors, which can be limited by rlimits and should therefore be used sparingly. Switch from EventNotifier to QEMUBH in thread-pool.c. Originally EventNotifier was used because qemu_bh_schedule() was not thread

[Qemu-devel] [PATCH v2 for-2.1 1/1] s390x/kvm: synchronize guest floating point registers

2014-07-11 Thread Cornelia Huck
From: "Jason J. Herne" Add code to kvm_arch_get_registers and kvm_arch_put_registers to save/restore floating point registers. This missing sync was unnoticed until migration of userspace that uses fprs. Signed-off-by: Jason J. Herne Signed-off-by: Christian Borntraeger [Update patch to latest

[Qemu-devel] [PATCH v2 for-2.1 0/1] s390x/kvm: bugfix

2014-07-11 Thread Cornelia Huck
Hi, another s390x bugfix for 2.1: We didn't synchronize the guest's floating point registers, which we didn't realize until we tried to migrate a guest with applications that actually used them. Turns out that Jason had already done a patch for this some time ago that somehow fell through the cra

Re: [Qemu-devel] [PULL 1/1] spice: auth fixes

2014-07-11 Thread Peter Maydell
On 11 July 2014 12:18, Markus Armbruster wrote: > Gerd Hoffmann writes: > >> Set auth to sasl when sasl is enabled, this makes "info spice" correctly >> display sasl auth. > > Fixes SPICE_CHANNEL_EVENT_CONNECTED similarly, doesn't it? > > If yes, I'd recommend to note this in the commit message.

Re: [Qemu-devel] [PATCH RESEND] ui/gtk: Restore keyboard focus after Page change

2014-07-11 Thread Markus Armbruster
John Snow writes: > (Resending for correct email addresses via MAINTAINERS ...) The note above... > In the GTK UI, after changing focus to the qemu monitor Notebook Page, > when restoring focus to the virtual machine page, the keyboard focus is lost > to a hidden GTK widget. Focus can only be r

[Qemu-devel] [PATCH for-2.1? 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock

2014-07-11 Thread Stefan Hajnoczi
These patches convert thread-pool.c from EventNotifier to QEMUBH. They then solve the deadlock when nested aio_poll() calls are made. Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of the nested aio_poll() deadlock ever having been reported, so maybe we can defer to QEM

[Qemu-devel] [PATCH for-2.1? 2/2] thread-pool: avoid deadlock in nested aio_poll() calls

2014-07-11 Thread Stefan Hajnoczi
The thread pool has a race condition if two elements complete before thread_pool_completion_bh() runs: If element A's callback waits for element B using aio_poll() it will deadlock since pool->completion_bh is not marked scheduled when the nested aio_poll() runs. Fix this by marking the BH

Re: [Qemu-devel] [PULL v3 00/10] KVM changes (+ misc small fixes) for 2.1

2014-07-11 Thread Peter Maydell
On 11 July 2014 12:14, Paolo Bonzini wrote: > Il 11/07/2014 13:13, Peter Maydell ha scritto: >> Applied, thanks. Incidentally, any plans to switch to submitting >> signed tags for pullreqs? > > > Sure, do you want to exchange keys or am I close enough to you in the web of > trust? I think as an i

  1   2   >