Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-08 Thread Hitoshi Mitake
At Fri, 8 Aug 2014 13:20:39 +0800, Liu Yuan wrote: On Thu, Aug 07, 2014 at 04:28:39PM +0900, Hitoshi Mitake wrote: The update is required for supporting iSCSI multipath. It doesn't affect behavior of QEMU driver but adding a new field to vdi request struct is required. Cc: Kevin Wolf

Re: [Qemu-devel] [PATCH 2/2] sheepdog: improve error handling for a case of failed lock

2014-08-08 Thread Hitoshi Mitake
At Fri, 8 Aug 2014 13:31:39 +0800, Liu Yuan wrote: On Thu, Aug 07, 2014 at 04:28:40PM +0900, Hitoshi Mitake wrote: Recently, sheepdog revived its VDI locking functionality. This patch updates sheepdog driver of QEMU for this feature: 1. Improve error message when QEMU fails to acquire

Re: [Qemu-devel] [PATCH V5 1/5] docs: Specification for the image fuzzer

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 05:12:46PM +0400, Maria Kustova wrote: 'Overall fuzzer requirements' chapter contains the current product vision and features done and to be done. This chapter is still in progress. Signed-off-by: Maria Kustova mari...@catit.be ---

[Qemu-devel] [PATCH] cluster/zookeeper: add log information for zk auto-recoonect

2014-08-08 Thread Liu Yuan
Reported-by: Valerio Pachera siri...@gmail.com Signed-off-by: Liu Yuan namei.u...@gmail.com --- sheep/group.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sheep/group.c b/sheep/group.c index 06a80bd..08e3884 100644 --- a/sheep/group.c +++ b/sheep/group.c @@ -979,7 +979,7 @@

Re: [Qemu-devel] [Bug 1352555] Re: iproute2 incompatibility

2014-08-08 Thread swestlake
i discovered with iproute2 i have to manually bring the lo interface link up which to me is pretty new.. after which the spice port can immediately work with 127.0.0.1:port. what I originally meant when installing iproute2 on debian was that it uninstalls ifupdown as well as iproute. I don't

Re: [Qemu-devel] [PATCH 2/2] sheepdog: improve error handling for a case of failed lock

2014-08-08 Thread Liu Yuan
On Fri, Aug 08, 2014 at 03:17:59PM +0900, Hitoshi Mitake wrote: At Fri, 8 Aug 2014 13:31:39 +0800, Liu Yuan wrote: On Thu, Aug 07, 2014 at 04:28:40PM +0900, Hitoshi Mitake wrote: Recently, sheepdog revived its VDI locking functionality. This patch updates sheepdog driver of QEMU for

Re: [Qemu-devel] [PATCH V5 1/6] icount: Add QemuOpts for icount

2014-08-08 Thread Markus Armbruster
Sebastian Tanase sebastian.tan...@openwide.fr writes: Make icount parameter use QemuOpts style options in order to easily add other suboptions. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr Tested-by: Camille Bégué camille.be...@openwide.fr Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH V5 2/5] runner: Tool for fuzz tests execution

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 05:12:47PM +0400, Maria Kustova wrote: The purpose of the test runner is to prepare the test environment (e.g. create a work directory, a test image, etc), execute a program under test with parameters, indicate a test failure if the program was killed during the test

Re: [Qemu-devel] [PATCH V5 0/5] tests: Add the image fuzzer with qcow2 support

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 05:12:45PM +0400, Maria Kustova wrote: This patch series introduces the image fuzzer, a tool for stability and reliability testing. Its approach is to run large amount of tests in background. During every test a program (e.g. qemu-img) is called to read or modify an

Re: [Qemu-devel] [PATCH V5 0/5] tests: Add the image fuzzer with qcow2 support

2014-08-08 Thread M.Kustova
On Fri, Aug 8, 2014 at 10:54 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Aug 06, 2014 at 05:12:45PM +0400, Maria Kustova wrote: This patch series introduces the image fuzzer, a tool for stability and reliability testing. Its approach is to run large amount of tests in background.

Re: [Qemu-devel] [PATCH v6 6/7] exec: report error when memory hpagesize

2014-08-08 Thread Hu Tao
On Thu, Aug 07, 2014 at 09:45:04PM +1000, Peter Crosthwaite wrote: On Thu, Aug 7, 2014 at 7:10 PM, Hu Tao hu...@cn.fujitsu.com wrote: Report error when memory hpagesize in file_ram_alloc() so callers can an error handle the error. This patch fix a problem that if user adds a

Re: [Qemu-devel] [PULL 17/19] target-i386: Support invariant tsc flag

2014-08-08 Thread chenliang (T)
Hi, We found that value of host cpus tsc are same to echo other when host has invariant tsc flag. But it is not in vm. The problem is that offset of vcpus tsc are not equal. The offset is set when vcpu is created. Is it ok to set same offset? And is it reasonable? Best regards Chen Liang

Re: [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-08 Thread Alex Bligh
On 7 Aug 2014, at 20:26, Serge E. Hallyn se...@hallyn.com wrote: A-ha, acpi wasn't a problem. I actually had a general migration problem even when coming from other utopic hosts. With that fixed, I've got successful migration from qemu-kvm 1.0 in precise to a utopic host. That's good

Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-08 Thread Liu Yuan
On Fri, Aug 08, 2014 at 03:12:17PM +0900, Hitoshi Mitake wrote: At Fri, 8 Aug 2014 13:20:39 +0800, Liu Yuan wrote: On Thu, Aug 07, 2014 at 04:28:39PM +0900, Hitoshi Mitake wrote: The update is required for supporting iSCSI multipath. It doesn't affect behavior of QEMU driver but

Re: [Qemu-devel] [PATCH] block: add watermark event

2014-08-08 Thread Francesco Romani
- Original Message - From: Stefan Hajnoczi stefa...@redhat.com To: Kevin Wolf kw...@redhat.com Cc: mdr...@linux.vnet.ibm.com, Francesco Romani from...@redhat.com, qemu-devel@nongnu.org, lcapitul...@redhat.com Sent: Tuesday, August 5, 2014 3:08:46 PM Subject: Re: [Qemu-devel] [PATCH]

Re: [Qemu-devel] [PATCH v4 00/21] block: Handle failure for potentially large allocations

2014-08-08 Thread Kevin Wolf
Am 07.08.2014 um 20:34 hat Max Reitz geschrieben: On 24.06.2014 17:36, Kevin Wolf wrote: A not too small part of the recent CVEs were DoS scenarios by letting qemu abort with too large memory allocations. We generally fixed these cases by setting some limits on values read from image files

Re: [Qemu-devel] [PATCH v2 1/2] contrib: add ivshmem client and server

2014-08-08 Thread David Marchand
Hello Markus, On 07/21/2014 07:35 PM, Markus Armbruster wrote: Do you have a compelling reason why you can't license under GPLv2+? If yes, please explain it to us. If no, please use * This work is licensed under the terms of the GNU GPL, version 2 or * later. See the COPYING file in

Re: [Qemu-devel] [PATCH V5 2/5] runner: Tool for fuzz tests execution

2014-08-08 Thread Fam Zheng
On Wed, 08/06 17:12, Maria Kustova wrote: The purpose of the test runner is to prepare the test environment (e.g. create a work directory, a test image, etc), execute a program under test with parameters, indicate a test failure if the program was killed during the test execution and collect

[Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-08 Thread David Marchand
Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some parts of the documentation and re-organise it. Signed-off-by: David Marchand david.march...@6wind.com ---

[Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools

2014-08-08 Thread David Marchand
Here is a patchset containing an update on ivshmem specs documentation and importing ivshmem server and client tools. These tools have been written from scratch and are not related to what is available in nahanni repository. I put them in contrib/ directory as the qemu-doc.texi was already telling

[Qemu-devel] [PATCH v3 1/2] contrib: add ivshmem client and server

2014-08-08 Thread David Marchand
When using ivshmem devices, notifications between guests can be sent as interrupts using a ivshmem-server (typical use described in documentation). The client is provided as a debug tool. Signed-off-by: Olivier Matz olivier.m...@6wind.com Signed-off-by: David Marchand david.march...@6wind.com ---

Re: [Qemu-devel] [PATCH V5 2/5] runner: Tool for fuzz tests execution

2014-08-08 Thread M.Kustova
On Fri, Aug 8, 2014 at 12:50 PM, Fam Zheng f...@redhat.com wrote: On Wed, 08/06 17:12, Maria Kustova wrote: The purpose of the test runner is to prepare the test environment (e.g. create a work directory, a test image, etc), execute a program under test with parameters, indicate a test

Re: [Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-08 Thread Claudio Fontana
Hello David, On 08.08.2014 10:55, David Marchand wrote: Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some parts of the documentation and re-organise it.

[Qemu-devel] [PATCH V3 0/3] image-fuzzer: Support L1/L2 tables in the qcow2 image generator

2014-08-08 Thread Maria Kustova
This patch series adds support of L1/L2 tables to the qcow2 image generator. This patch series was created for the 'block-next' branch and based on the next series: [PATCH V5 0/5] tests: Add the image fuzzer with qcow2 support. v2 - v3: * Fixed wrong entry indices in the last L2

[Qemu-devel] [PATCH V3 2/3] fuzz: Add fuzzing functions for L1/L2 table entries

2014-08-08 Thread Maria Kustova
Signed-off-by: Maria Kustova mari...@catit.be --- tests/image-fuzzer/qcow2/fuzz.py | 28 1 file changed, 28 insertions(+) diff --git a/tests/image-fuzzer/qcow2/fuzz.py b/tests/image-fuzzer/qcow2/fuzz.py index a53c84f..57527f9 100644 ---

[Qemu-devel] [PATCH V3 1/3] docs: Expand the list of supported image elements with L1/L2 tables

2014-08-08 Thread Maria Kustova
Signed-off-by: Maria Kustova mari...@catit.be --- tests/image-fuzzer/docs/image-fuzzer.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/image-fuzzer/docs/image-fuzzer.txt b/tests/image-fuzzer/docs/image-fuzzer.txt index efe0ed4..2e8e3b9 100644 ---

[Qemu-devel] [PATCH V3 3/3] layout: Add generators of L1/L2 tables

2014-08-08 Thread Maria Kustova
Entries in L1/L2 entries are based on a portion of random guest clusters. L2 entries contain offsets to host image clusters filled with random data. Clusters for L1/L2 tables and guest data are selected randomly. Signed-off-by: Maria Kustova mari...@catit.be ---

Re: [Qemu-devel] [PATCH 0/3] qcow2: Prevent corruption-related crashes

2014-08-08 Thread Kevin Wolf
Am 07.08.2014 um 22:47 hat Max Reitz geschrieben: The first two patches in this series address https://bugs.launchpad.net/qemu/+bug/1349972. For the third patch I found it hard to write an appropriate test case (it would have to make qemu-img check repair some leaks but induce the

Re: [Qemu-devel] [PATCH 3/3] block: Catch !bs-drv in bdrv_check()

2014-08-08 Thread Kevin Wolf
Am 07.08.2014 um 22:47 hat Max Reitz geschrieben: qemu-img check calls bdrv_check() twice if the first run repaired some inconsistencies. If the first run however again triggered corruption prevention (on qcow2) due to very bad inconsistencies, bs-drv may be NULL afterwards. Thus, bdrv_check()

[Qemu-devel] [PATCH v4 07/10] linux-user: check return value of malloc()

2014-08-08 Thread zhanghailiang
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- linux-user/syscall.c | 4 1 file changed, 4 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a50229d..8e5ccf1 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2870,6 +2870,10 @@

[Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc()

2014-08-08 Thread zhanghailiang
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- slirp/misc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index b8eb74c..9b457ad 100644 --- a/slirp/misc.c +++ b/slirp/misc.c @@ -55,6 +55,10 @@ int add_exec(struct ex_list

[Qemu-devel] [PATCH v4 09/10] tcg: check return value of fopen()

2014-08-08 Thread zhanghailiang
From: Li Liu john.li...@huawei.com Give a warning message if fopen() failed to open the log file. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Li Liu john.li...@huawei.com --- tcg/tcg.c | 4 1 file changed, 4 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c

[Qemu-devel] [PATCH v4 04/10] ivshmem: check the value returned by fstat()

2014-08-08 Thread zhanghailiang
The function fstat() may fail, so check its return value. Acked-by: Levente Kurusa lkur...@redhat.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- hw/misc/ivshmem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c

[Qemu-devel] [PATCH v4 05/10] util/path: check return value of malloc()

2014-08-08 Thread zhanghailiang
Reviewed-by: Gonglei arei.gong...@huawei.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- util/path.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/util/path.c b/util/path.c index 5c59d9f..df1653f 100644 --- a/util/path.c +++ b/util/path.c @@

[Qemu-devel] [PATCH v4 00/10] fix three bugs about use-after-free and several api abuse

2014-08-08 Thread zhanghailiang
This patch set fix three bugs about accessing freed memory and several api abuse. In qemu, there are serveral places that do not check the return value of fstat()/fopen()/malloc(). Though it is a small probability for the these functions to fail, but it is better to fix them, Or there may be a

[Qemu-devel] [PATCH v4 03/10] virtio-blk: fix reference a pointer which might be freed

2014-08-08 Thread zhanghailiang
In function virtio_blk_handle_request, it may freed memory pointed by req, So do not access member of req after calling this function. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- hw/block/virtio-blk.c | 5 +++-- 1 file changed,

[Qemu-devel] [PATCH v4 02/10] monitor: fix access freed memory

2014-08-08 Thread zhanghailiang
The function monitor_fdset_dup_fd_find_remove() references member of 'mon_fdset' which may be freed in function monitor_fdset_cleanup() Reviewed-by: Gonglei arei.gong...@huawei.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- monitor.c | 4 +++- 1 file changed, 3

[Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen()

2014-08-08 Thread zhanghailiang
The function fopen() may fail, so check its return value. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Li Liu john.li...@huawei.com --- tests/bios-tables-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c

[Qemu-devel] [PATCH v4 10/10] block/vvfat: fix setbuf stream parameter may be NULL

2014-08-08 Thread zhanghailiang
From: Li Liu john.li...@huawei.com fopen() may return NULL which will cause setbuf() segmentfault Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Li Liu john.li...@huawei.com --- block/vvfat.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v4 01/10] l2cap: fix access freed memory

2014-08-08 Thread zhanghailiang
Pointer 'ch' will be used in function 'l2cap_channel_open_req_msg' after it was previously freed in 'l2cap_channel_open'. Assigned it to NULL after it is freed. Reviewed-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- hw/bt/l2cap.c | 2 +- 1

Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools

2014-08-08 Thread Gonglei (Arei)
Hi, Subject: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools Here is a patchset containing an update on ivshmem specs documentation and importing ivshmem server and client tools. These tools have been written from scratch and are not related to what is

[Qemu-devel] [PATCH V2] layout: Reduce number of generator functions in __init__

2014-08-08 Thread Maria Kustova
Some issues can be found only when a fuzzed image has a partial structure, e.g. has L1/L2 tables but no refcount ones. Generation of an entirely defined image limits these cases. Now the Image constructor creates only a header and a backing file name (if any), other image elements are generated in

Re: [Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-08 Thread David Marchand
Hello Claudio, On 08/08/2014 11:04 AM, Claudio Fontana wrote: On 08.08.2014 10:55, David Marchand wrote: Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some

Re: [Qemu-devel] [PATCH v4 01/15] target-tricore: Add target stubs and qom-cpu

2014-08-08 Thread Bastian Koppelmann
On 08/08/2014 03:28 AM, Richard Henderson wrote: On 08/07/2014 04:34 AM, Bastian Koppelmann wrote: +/* PSW flag cache for faster execution + if flag != 0 then flag is set. Else flag is not set. +*/ +target_ulong PSW_USB_C; +target_ulong PSW_USB_V; +target_ulong

Re: [Qemu-devel] [PULL v2 00/11] KVM, icount changes for 2014-08-06

2014-08-08 Thread Peter Maydell
On 7 August 2014 14:34, Paolo Bonzini pbonz...@redhat.com wrote: The following changes since commit 41a1a9c42c4e0fb5f1b94aa8b72e42f66ebde3d9: po: Update German translation (2014-07-28 23:37:17 +0200) are available in the git repository at: git://github.com/bonzini/qemu.git

Re: [Qemu-devel] [PATCH v4 05/10] util/path: check return value of malloc()

2014-08-08 Thread Alex Bennée
zhanghailiang writes: Reviewed-by: Gonglei arei.gong...@huawei.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- util/path.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/util/path.c b/util/path.c index 5c59d9f..df1653f 100644 ---

Re: [Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc()

2014-08-08 Thread Alex Bennée
zhanghailiang writes: Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- slirp/misc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index b8eb74c..9b457ad 100644 --- a/slirp/misc.c +++ b/slirp/misc.c @@ -55,6

Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools

2014-08-08 Thread David Marchand
Hello Gonglei, On 08/08/2014 11:30 AM, Gonglei (Arei) wrote: If you can describe the steps of using example about your ivshmem-client and ivshmem-server will be great IMHO. I already have included a note in the qemu-doc.texi file on how to start the ivshmem-server. The (debug) client is

Re: [Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen()

2014-08-08 Thread Alex Bennée
zhanghailiang writes: The function fopen() may fail, so check its return value. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Li Liu john.li...@huawei.com --- tests/bios-tables-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] Checking underflow condition for FRCPE instr [AARCH64]

2014-08-08 Thread Gaurav Sharma
Hi, I am trying to test the floating point instruction for arm in qemu. For floating point reciprocal estimate instruction, for a64 i see a check for underflow condition in float64 HELPER(recpe_f64) method : else if (f64_exp = 1023 fpst-flush_to_zero) 1. how do we calculate the value to

Re: [Qemu-devel] Checking underflow condition for FRCPE instr [AARCH64]

2014-08-08 Thread Peter Maydell
On 8 August 2014 11:02, Gaurav Sharma gauravs.2...@gmail.com wrote: I am trying to test the floating point instruction for arm in qemu. For floating point reciprocal estimate instruction, for a64 i see a check for underflow condition in float64 HELPER(recpe_f64) method : else if (f64_exp =

Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools

2014-08-08 Thread Gonglei (Arei)
Hi, Subject: Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools Hello Gonglei, On 08/08/2014 11:30 AM, Gonglei (Arei) wrote: If you can describe the steps of using example about your ivshmem-client and ivshmem-server will be great IMHO. I already

Re: [Qemu-devel] [PATCH v4 01/15] target-tricore: Add target stubs and qom-cpu

2014-08-08 Thread Bastian Koppelmann
On 08/08/2014 11:40 AM, Bastian Koppelmann wrote: On 08/08/2014 03:28 AM, Richard Henderson wrote: On 08/07/2014 04:34 AM, Bastian Koppelmann wrote: +/* PSW flag cache for faster execution + if flag != 0 then flag is set. Else flag is not set. +*/ +target_ulong PSW_USB_C; +

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-08 Thread Ming Lei
On Thu, Aug 7, 2014 at 9:51 PM, Kevin Wolf kw...@redhat.com wrote: Am 07.08.2014 um 12:27 hat Ming Lei geschrieben: On Wed, Aug 6, 2014 at 11:40 PM, Kevin Wolf kw...@redhat.com wrote: Am 06.08.2014 um 13:28 hat Ming Lei geschrieben: On Wed, Aug 6, 2014 at 6:09 PM, Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v4 05/10] util/path: check return value of malloc()

2014-08-08 Thread zhanghailiang
On 2014/8/8 17:36, Alex Bennée wrote: zhanghailiang writes: Reviewed-by: Gongleiarei.gong...@huawei.com Signed-off-by: zhanghailiangzhang.zhanghaili...@huawei.com --- util/path.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/util/path.c b/util/path.c index

Re: [Qemu-devel] Checking underflow condition for FRCPE instr [AARCH64]

2014-08-08 Thread Peter Maydell
On 8 August 2014 11:25, Peter Maydell peter.mayd...@linaro.org wrote: Since we've already dealt with the NaN and infinity and denormal cases by this point in the code, we know that value == (-1)^S * 2^(exp-1023) * 1.frac If you plug in the value == 2.0^1022 and work it out you'll find that

Re: [Qemu-devel] Checking underflow condition for FRCPE instr [AARCH64]

2014-08-08 Thread Gaurav Sharma
My bad, I was not specific. Actually, i am trying to run some test on qemu to verify some instructions. For which i build a binary and load it on qemu in my environment and test the output. In this case even i am not sure, if the output i get from qemu is correct or not. [Use case] [sample -

Re: [Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc()

2014-08-08 Thread zhanghailiang
On 2014/8/8 17:43, Alex Bennée wrote: zhanghailiang writes: Signed-off-by: zhanghailiangzhang.zhanghaili...@huawei.com --- slirp/misc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index b8eb74c..9b457ad 100644 --- a/slirp/misc.c

Re: [Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen()

2014-08-08 Thread zhanghailiang
On 2014/8/8 17:51, Alex Bennée wrote: zhanghailiang writes: The function fopen() may fail, so check its return value. Signed-off-by: zhanghailiangzhang.zhanghaili...@huawei.com Signed-off-by: Li Liujohn.li...@huawei.com --- tests/bios-tables-test.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [Qemu-devel] [PATCH V5 2/5] runner: Tool for fuzz tests execution

2014-08-08 Thread Fam Zheng
On Fri, 08/08 12:58, M.Kustova wrote: On Fri, Aug 8, 2014 at 12:50 PM, Fam Zheng f...@redhat.com wrote: On Wed, 08/06 17:12, Maria Kustova wrote: The purpose of the test runner is to prepare the test environment (e.g. create a work directory, a test image, etc), execute a program under

Re: [Qemu-devel] [PULL 0/3] qga: support fsfreeze'ing specific mounts

2014-08-08 Thread Peter Maydell
On 7 August 2014 23:18, Eric Blake ebl...@redhat.com wrote: On 08/07/2014 04:10 PM, Michael Roth wrote: Please pull the following changes, which add a new guest-fsfreeze-freeze-list command to qemu-ga that supports specifying specific mounts to freeze, and improves the introspection

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-08 Thread Ming Lei
On Fri, Aug 8, 2014 at 6:32 PM, Ming Lei ming@canonical.com wrote: On Thu, Aug 7, 2014 at 9:51 PM, Kevin Wolf kw...@redhat.com wrote: Am 07.08.2014 um 12:27 hat Ming Lei geschrieben: On Wed, Aug 6, 2014 at 11:40 PM, Kevin Wolf kw...@redhat.com wrote: Am 06.08.2014 um 13:28 hat Ming Lei

[Qemu-devel] [PATCH 05/11] target-arm: Don't allow AArch32 to access RES0 CPSR bits

2014-08-08 Thread Peter Maydell
The CPSR has a new-in-v8 execution state bit (IL), and also some state which has effects in AArch32 but appears only in the SPSR format (SS) but is RES0 in the CPSR. Add the IL bit to CPSR_EXEC, and enforce that guest direct reads and writes to CPSR can't read or write the RES0 bits, so the guest

[Qemu-devel] [PATCH 00/11] target-arm: Implement ARMv8 debug single-stepping

2014-08-08 Thread Peter Maydell
This patchset implements the ARMv8 architecturally defined software singlestepping. This is necessary to support running gdb or gdbserver inside a Linux guest, because Linux assumes the presence of this (mandatory) architectural feature and uses it to implement PTRACE_SINGLESTEP for 64-bit

[Qemu-devel] [PATCH 04/11] target-arm: Adjust debug ID registers per-CPU

2014-08-08 Thread Peter Maydell
Allow each CPU type to specify the value for the debug ID registers, by putting them in the ARMCPU struct, and use the resulting information to only expose the correct number of watchpoint and breakpoint registers for the CPU. Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

[Qemu-devel] [PATCH 08/11] target-arm: A64: Avoid duplicate exit_tb(0) in non-linked goto_tb

2014-08-08 Thread Peter Maydell
If gen_goto_tb() decides not to link the two TBs, then the fallback path generates unnecessary code: * if singlestep is enabled then we generate unreachable code after the gen_exception_internal(EXCP_DEBUG) * if singlestep is disabled then we will generate exit_tb(0) twice, once in

[Qemu-devel] [PATCH 02/11] target-arm: Allow STATE_BOTH reginfo descriptions for more than cp14

2014-08-08 Thread Peter Maydell
Currently the STATE_BOTH shorthand for allowing a single reginfo struct to define handling for both AArch32 and AArch64 views of a register only permits this where the AArch32 view is in cp15. It turns out that the debug registers in cp14 also have neatly lined up encodings; allow these also to

[Qemu-devel] [PATCH 07/11] target-arm: Set PSTATE.SS correctly on exception return from AArch64

2014-08-08 Thread Peter Maydell
Set the PSTATE.SS bit correctly on exception returns from AArch64, as required by the debug single-step functionality. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/cpu.h | 61 ++ target-arm/op_helper.c | 20

[Qemu-devel] [PATCH 01/11] target-arm: Collect up the debug cp register definitions

2014-08-08 Thread Peter Maydell
At the moment we have a mixed set of mostly dummy register definitions for various debug related registers which have been added piecemeal in order to get Linux kernels to boot. In preparation for actually implementing debug support, bring them all together into one place. This commit doesn't

[Qemu-devel] [PATCH 09/11] target-arm: Implement ARMv8 single-step handling for A64 code

2014-08-08 Thread Peter Maydell
Implement ARMv8 software single-step handling for A64 code: correctly update the single-step state machine and generate debug exceptions when stepping A64 code. This patch has no behavioural change since MDSCR_EL1.SS can't be set by the guest yet. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 11/11] target-arm: Implement MDSCR_EL1 as having state

2014-08-08 Thread Peter Maydell
Now that all the new code to support single-stepping is in place, wire up the guest-visible MDSCR_EL1, so the guest can enable single-stepping. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 06/11] target-arm: Correctly handle PSTATE.SS when taking exception to AArch32

2014-08-08 Thread Peter Maydell
When an exception is taken to AArch32, we must clear the PSTATE.SS bit for the exception handler, and must also ensure that the SS bit is not set in the value saved to SPSR_mode. Achieve both of these aims by clearing the bit in uncached_cpsr before saving it to the SPSR. Signed-off-by: Peter

[Qemu-devel] [PATCH 03/11] target-arm: Provide both 32 and 64 bit versions of debug registers

2014-08-08 Thread Peter Maydell
Bring the 32 bit and 64 bit views of the debug registers into line by providing the same set of registers in both cases. (This still isn't a complete set, but it is consistent.) Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/helper.c | 34 --

[Qemu-devel] [PATCH 10/11] target-arm: Implement ARMv8 single-stepping for AArch32 code

2014-08-08 Thread Peter Maydell
ARMv8 single-stepping requires the exception level that controls the single-stepping to be in AArch64 execution state, but the code being stepped may be in AArch64 or AArch32. Implement the necessary support code for single-stepping AArch32 code. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-08 Thread Eric Blake
On 08/07/2014 06:40 PM, Mike Frysinger wrote: From: Mike Frysinger vap...@chromium.org The current code always returns the length of the path when it should be returning the number of bytes it wrote to the output string. That is indeed a bug. Further, readlink is not supposed to append a

Re: [Qemu-devel] [PATCH] block: add watermark event

2014-08-08 Thread Eric Blake
On 08/08/2014 02:01 AM, Francesco Romani wrote: So let the block-set-watermark caller pass an absolute sector number instead. It keeps things simple for both QEMU and thin provisioning manager. No sector numbers in external interfaces, please. These units of 512 bytes are completely

Re: [Qemu-devel] [PULL 0/3] qga: support fsfreeze'ing specific mounts

2014-08-08 Thread Michael Roth
Quoting Peter Maydell (2014-08-08 06:12:34) On 7 August 2014 23:18, Eric Blake ebl...@redhat.com wrote: On 08/07/2014 04:10 PM, Michael Roth wrote: Please pull the following changes, which add a new guest-fsfreeze-freeze-list command to qemu-ga that supports specifying specific mounts to

[Qemu-devel] [PULL v2 0/3] qga: support fsfreeze'ing specific mounts

2014-08-08 Thread Michael Roth
Hello, Please pull the following changes, which add a new guest-fsfreeze-freeze-list command to qemu-ga that supports specifying specific mounts to freeze, and improves the introspection information from guest-info by explicitly blacklisting/reporting commands that aren't supported on a

[Qemu-devel] [PATCH 3/3] qga: Disable unsupported commands by default

2014-08-08 Thread Michael Roth
From: Tomoki Sekiyama tomoki.sekiy...@hds.com Currently management softwares cannot know whether a qemu-ga command is supported or not on the running platform until they actually execute it. This patch disables unsupported commands at launch time of qemu-ga, so that management softwares can check

[Qemu-devel] [PATCH 1/3] qga: Add guest-fsfreeze-freeze-list command

2014-08-08 Thread Michael Roth
From: Tomoki Sekiyama tomoki.sekiy...@hds.com If an array of mount point paths is specified as 'mountpoints' argument of guest-fsfreeze-freeze-list, qemu-ga will only freeze the file systems mounted on specified paths in Linux guests. Otherwise, it works as the same way as guest-fsfreeze-freeze.

[Qemu-devel] [PATCH 2/3] qga: Add guest-get-fsinfo command

2014-08-08 Thread Michael Roth
From: Tomoki Sekiyama tomoki.sekiy...@hds.com Add command to get mounted filesystems information in the guest. The returned value contains a list of mountpoint paths and corresponding disks info such as disk bus type, drive address, and the disk controllers' PCI addresses, so that management

Re: [Qemu-devel] [PATCH V5 3/5] fuzz: Fuzzing functions for qcow2 images

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 05:12:48PM +0400, Maria Kustova wrote: The fuzz submodule of the qcow2 image generator contains fuzzing functions for image fields. Each fuzzing function contains a list of constraints and a call of a helper function that randomly selects a fuzzed value satisfied to one

Re: [Qemu-devel] [PATCH V5 5/5] package: Public API for image-fuzzer/runner/runner.py

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 05:12:50PM +0400, Maria Kustova wrote: __init__.py provides the public API required by the test runner Signed-off-by: Maria Kustova mari...@catit.be --- tests/image-fuzzer/qcow2/__init__.py | 1 + 1 file changed, 1 insertion(+) create mode 100644

Re: [Qemu-devel] [PATCH V5 4/5] layout: Generator of fuzzed qcow2 images

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 05:12:49PM +0400, Maria Kustova wrote: The layout submodule of the qcow2 package creates a random valid image, randomly selects some amount of its fields, fuzzes them and write the fuzzed image to the file. Fuzzing process can be controlled by an external configuration.

Re: [Qemu-devel] [Bug 1353545] Re: QED does not deliver flush on synchronized write

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 03:32:29PM -, Nybble wrote: ** Changed in: qemu Status: New = Invalid I guess you saw that bdrv_co_flush() calls bdrv_co_flush(bs-file). This means that even block drivers that do not provide -bdrv_co_flush_to_disk() will have fdatasync() called on their image

Re: [Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc()

2014-08-08 Thread Alex Bennée
zhanghailiang writes: On 2014/8/8 17:43, Alex Bennée wrote: zhanghailiang writes: Signed-off-by: zhanghailiangzhang.zhanghaili...@huawei.com --- slirp/misc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) snip Your indenting has gone a bit weird there. Hmm, this

[Qemu-devel] [PATCH 1/2] target-arm: Rename QEMU PSCI v0.1 definitions

2014-08-08 Thread Christoffer Dall
The function IDs for PSCI v0.1 are exported by KVM and defined as KVM_PSCI_FN_something. To build using these defines in non-KVM code, QEMU defines these IDs locally and check their correctness against the KVM headers when those are available. However, the naming scheme used for QEMU (almost)

[Qemu-devel] [PATCH v2 2/2] arm/virt: Use PSCI v0.2 function IDs in the DT when KVM uses PSCI v0.2

2014-08-08 Thread Christoffer Dall
The current code supplies the PSCI v0.1 function IDs in the DT even when KVM uses PSCI v0.2. This will break guest kernels that only support PSCI v0.1 as they will use the IDs provided in the DT. Guest kernels with PSCI v0.2 support are not affected by this patch, because they ignore the

Re: [Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-08 Thread Mike Frysinger
please don't take this the wrong way, but i don't see how any of your comments are relevant. i didn't say POSIX anywhere (which isn't to say your outline of POSIX semantics are incorrect), but the QEMU linux-user layer has nothing to do with POSIX. the linux-user layer in QEMU implements the

[Qemu-devel] [Bug 1353545] Re: QED does not deliver flush on synchronized write

2014-08-08 Thread Nybble
I'm really sorry that I didn't see that call when I submit this... I was writing a experimental block image driver and found it runs too slow. It turned out that it calls bdrv_flush itself and the flush on -file is than called again from block.c thanks for your confirmation! -- You received

Re: [Qemu-devel] [PULL v2 0/3] qga: support fsfreeze'ing specific mounts

2014-08-08 Thread Peter Maydell
On 8 August 2014 14:02, Michael Roth mdr...@linux.vnet.ibm.com wrote: Hello, Please pull the following changes, which add a new guest-fsfreeze-freeze-list command to qemu-ga that supports specifying specific mounts to freeze, and improves the introspection information from guest-info by

Re: [Qemu-devel] [PATCH v3 1/2] contrib: add ivshmem client and server

2014-08-08 Thread Stefan Hajnoczi
On Fri, Aug 08, 2014 at 10:55:17AM +0200, David Marchand wrote: Looks good, a few minor comments: diff --git a/contrib/ivshmem-client/Makefile b/contrib/ivshmem-client/Makefile new file mode 100644 index 000..eee97c6 --- /dev/null +++ b/contrib/ivshmem-client/Makefile @@ -0,0 +1,29 @@

Re: [Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-08 Thread Stefan Hajnoczi
On Fri, Aug 08, 2014 at 10:55:18AM +0200, David Marchand wrote: +For each client (QEMU processes) that connects to the server: +- the server assigns an ID for this client and sends this ID to him as the first + message, +- the server sends a fd to the shared memory object to this client,

[Qemu-devel] [RFC v2 0/7] machvirt dynamic sysbus device instantiation

2014-08-08 Thread Eric Auger
This RFC enables machvirt to dynamically instantiate sysbus devices from command line. the RFC originates from Alex Graf's work - Dynamic sysbus device allocation support http://lists.gnu.org/archive/html/qemu-ppc/2014-07/msg00047.html The code related to dynamic sysbus device IRQ and mmio

[Qemu-devel] [RFC v2 1/7] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding

2014-08-08 Thread Eric Auger
This new module implements routines which help in dynamic device binding (mmio regions, irq). They are supposed to be used by machine files that support dynamic sysbus instantiation. --- v1 - v2: - platform_devices renamed into dyn_sysbus_binding - PlatformParams renamed into DynSysbusParams -

[Qemu-devel] [RFC v2 5/7] hw/arm/boot: load_dtb becomes non static

2014-08-08 Thread Eric Auger
load_dtb will be used by machvirt for dynamic instantiation of platform devices Signed-off-by: Eric Auger eric.au...@linaro.org --- hw/arm/boot.c| 2 +- include/hw/arm/arm.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index

[Qemu-devel] [RFC v2 7/7] hw/arm/virt: Support dynamically spawned sysbus devices

2014-08-08 Thread Eric Auger
Allows sysbus devices to be instantiated from command line by using -device option --- v1 - v2: - remove useless vfio-platform.h include file - s/MACHVIRT_PLATFORM_HOLE/MACHVIRT_PLATFORM_SIZE - use dyn_sysbus_binding and dyn_sysbus_devtree - dynamic sysbus platform buse size shrinked to 4MB and

[Qemu-devel] [RFC v2 4/7] e500: Add support for eTSEC in device tree

2014-08-08 Thread Eric Auger
From: Alexander Graf ag...@suse.de This patch adds support to expose eTSEC devices in the dynamically created guest facing device tree. This allows us to expose eTSEC devices into guests without changes in the machine file. Because we can now tell the guest about eTSEC devices this patch allows

[Qemu-devel] [RFC v2 3/7] PPC: e500: Support dynamically spawned sysbus devices

2014-08-08 Thread Eric Auger
From: Alexander Graf ag...@suse.de For e500 our approach to supporting dynamically spawned sysbus devices is to create a simple bus from the guest's point of view within which we map those devices dynamically. We allocate memory regions always within the platform hole in address space and map

[Qemu-devel] [RFC v2 6/7] hw/arm/virt: add new add_fdt_xxx_node functions

2014-08-08 Thread Eric Auger
Create new functions: - add_fdt_uart_node - add_fdt_rtc_node - add_fdt_virtio_nodes They will be used for dynamic sysbus instantiation. Signed-off-by: Eric Auger eric.au...@linaro.org --- hw/arm/virt.c | 67 +++ 1 file changed, 44

  1   2   3   >