Re: [Qemu-devel] [PATCH trivial] Fix debug print warning

2014-08-22 Thread Gonglei
> Subject: Re: [Qemu-devel] [PATCH trivial] Fix debug print warning > > On Fri, Aug 22, 2014 at 1:38 PM, wrote: > > From: Gonglei > > > > Steps: > > > > 1.enable qemu debug print, using simply scprit as below: > > grep "//#define DEBUG" * -rl | xargs sed -i "s/\/\/#define DEBUG/#define > DEBUG

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-08-22 Thread Chris Friesen
On 07/21/2014 10:10 AM, Benoît Canet wrote: The Monday 21 Jul 2014 à 09:35:29 (-0600), Chris Friesen wrote : On 07/21/2014 09:15 AM, Benoît Canet wrote: The Monday 21 Jul 2014 à 08:59:45 (-0600), Chris Friesen wrote : On 07/19/2014 02:45 AM, Benoît Canet wrote: I think in the throttling case

Re: [Qemu-devel] [PATCH v6 0/4] test virtio-blk hotplug

2014-08-22 Thread Amos Kong
On Sun, Jul 06, 2014 at 08:14:46PM +0800, Amos Kong wrote: > On Wed, Jun 25, 2014 at 09:15:12AM +0800, Amos Kong wrote: > > It's worth to add a hotplug test to qtest, but without > > cooperation of guest OS, new devices can't be initialized > > by guest, and hot-unplug doesn't work. > > > > Howeve

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-22 Thread Andrey Korolyov
> > Andrey, > > Can you give instructions on how to reproduce please? > Please find answers inline: > - qemu.git codebase (if you have any patches relative to a > given commit id, please provide the patches). rolled to bare 2.1-release to reproduce, for 3.10 I am hitting issue with and without

Re: [Qemu-devel] [PATCH v6 11/15] target-tricore: Add instructions of SBC and SBRN opcode format

2014-08-22 Thread Richard Henderson
On 08/22/2014 09:52 AM, Bastian Koppelmann wrote: > Add instructions of SBC and SBRN opcode format. > > Signed-off-by: Bastian Koppelmann > --- > v5 -> v6: > - SBC_JEQ: Negate condition. Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v6 15/15] target-tricore: Add instructions of SR opcode format

2014-08-22 Thread Richard Henderson
On 08/22/2014 09:52 AM, Bastian Koppelmann wrote: > Add instructions of SR opcode format. > Add micro-op generator functions for saturate. > Add helper return from exception (rfe). > > Signed-off-by: Bastian Koppelmann > --- > v5 -> v6: > - Fix formating. Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v6 12/15] target-tricore: Add instructions of SBR opcode format

2014-08-22 Thread Richard Henderson
On 08/22/2014 09:52 AM, Bastian Koppelmann wrote: > Add instructions of SBR opcode format. > Add gen_loop micro-op generator function. > > Signed-off-by: Bastian Koppelmann > --- > v5 -> v6: > - SBR_JEQ: Negate condition. Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-22 Thread Marcelo Tosatti
On Fri, Aug 22, 2014 at 04:05:46PM -0300, Marcelo Tosatti wrote: > On Fri, Aug 22, 2014 at 04:05:07PM -0300, Marcelo Tosatti wrote: > > On Fri, Aug 22, 2014 at 10:39:38PM +0400, Andrey Korolyov wrote: > > > On Fri, Aug 22, 2014 at 9:45 PM, Marcelo Tosatti > > > wrote: > > > > On Fri, Aug 22, 2014

Re: [Qemu-devel] [PATCH v6 10/15] target-tricore: Add instructions of SB opcode format

2014-08-22 Thread Richard Henderson
On 08/22/2014 09:52 AM, Bastian Koppelmann wrote: > Add instructions of SB opcode format. > Add helper call/ret. > Add micro-op generator functions for branches. > Add makro to generate helper functions. > > Signed-off-by: Bastian Koppelmann > --- > v5 -> v6: > - gen_intermediate_code_interna

Re: [Qemu-devel] [PATCH v6 06/15] target-tricore: Add instructions of SRC opcode format

2014-08-22 Thread Richard Henderson
On 08/22/2014 09:52 AM, Bastian Koppelmann wrote: > Add instructions of SRC opcode format. > Add micro-op generator functions for add, conditional add/sub and shi/shai. > > Signed-off-by: Bastian Koppelmann > --- > v5 -> v6: > - gen_shaci: Add calculation of PSW.C to shift_count = -32 case. >

Re: [Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially damaging repairs

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 01:55:01PM -0600, Eric Blake wrote: > On 08/22/2014 10:31 AM, Max Reitz wrote: > > There are certain cases where repairing a qcow2 image might actually > > damage it further (or rather, where repairing it has in fact damaged it > > further with the old qcow2 check implementa

Re: [Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially damaging repairs

2014-08-22 Thread Eric Blake
On 08/22/2014 10:31 AM, Max Reitz wrote: > There are certain cases where repairing a qcow2 image might actually > damage it further (or rather, where repairing it has in fact damaged it > further with the old qcow2 check implementation). This should not > happen, so add a test for these cases. > >

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-22 Thread Andrey Korolyov
On Fri, Aug 22, 2014 at 11:05 PM, Marcelo Tosatti wrote: > On Fri, Aug 22, 2014 at 04:05:07PM -0300, Marcelo Tosatti wrote: >> On Fri, Aug 22, 2014 at 10:39:38PM +0400, Andrey Korolyov wrote: >> > On Fri, Aug 22, 2014 at 9:45 PM, Marcelo Tosatti >> > wrote: >> > > On Fri, Aug 22, 2014 at 08:44:5

Re: [Qemu-devel] [PATCH v3] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-22 Thread Eric Blake
On 08/22/2014 12:16 PM, Lluís Vilanova wrote: >>> +# @name: Event name. >>> +# @sstatic: Static tracing state. >>> +# @sdynamic: Dynamic tracing state. > >> Does the leading 's' add any value? QAPI doesn't have to use obscure >> abbreviations. > > It felt wrong to have a JSON attribute named di

Re: [Qemu-devel] [PATCH] pc: reserve more memory for ACPI for new machine types

2014-08-22 Thread Serge E. Hallyn
Quoting Michael S. Tsirkin (m...@redhat.com): > commit 868270f23d8db2cce83e4f082fe75e8625a5fbf9 > acpi-build: tweak acpi migration limits > broke kernel loading with -kernel/-initrd: it doubled > the size of ACPI tables but did not reserve > enough memory. > > As a result, issues on boot and h

Re: [Qemu-devel] [PATCH RESEND 0/2] Fix leaks on object_property_add_str() setters

2014-08-22 Thread Eduardo Habkost
Ping? Who can apply these? On Wed, Aug 06, 2014 at 03:18:19PM -0300, Eduardo Habkost wrote: > Resending two patches from the previous series which were not applied yet. > > > Eduardo Habkost (2): > rng-egd: Free old chr_name value before setting new one > hw/machine: Free old values of strin

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-22 Thread Marcelo Tosatti
On Fri, Aug 22, 2014 at 04:05:07PM -0300, Marcelo Tosatti wrote: > On Fri, Aug 22, 2014 at 10:39:38PM +0400, Andrey Korolyov wrote: > > On Fri, Aug 22, 2014 at 9:45 PM, Marcelo Tosatti > > wrote: > > > On Fri, Aug 22, 2014 at 08:44:53PM +0400, Andrey Korolyov wrote: > > >> > > > >> > I`m running

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-22 Thread Marcelo Tosatti
On Fri, Aug 22, 2014 at 10:39:38PM +0400, Andrey Korolyov wrote: > On Fri, Aug 22, 2014 at 9:45 PM, Marcelo Tosatti wrote: > > On Fri, Aug 22, 2014 at 08:44:53PM +0400, Andrey Korolyov wrote: > >> > > >> > I`m running 3.10, so patches are not here, will try 3.16 soon. Even if > >> > problem will b

Re: [Qemu-devel] [PATCH] qemu-iotests: stop using /tmp directly

2014-08-22 Thread Benoît Canet
The Friday 22 Aug 2014 à 13:25:43 (+0200), Peter Wu wrote : > Before this patch you could not run multiple tests concurrently as they > might clobber each other test files. This patch solves that by using > random temporary directory instead of `/tmp` (for writing output in the > individual tests a

Re: [Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially damaging repairs

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 06:31:44PM +0200, Max Reitz wrote: > There are certain cases where repairing a qcow2 image might actually > damage it further (or rather, where repairing it has in fact damaged it > further with the old qcow2 check implementation). This should not > happen, so add a test for

Re: [Qemu-devel] [PATCH v3 01/10] qcow2: Fix leaks in dirty images

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 06:31:35PM +0200, Max Reitz wrote: > When opening dirty images, qcow2's repair function should not only > repair errors but leaks as well. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > block/qcow2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v3 08/10] qcow2: Clean up after refcount rebuild

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 06:31:42PM +0200, Max Reitz wrote: > Because the old refcount structure will be leaked after having rebuilt > it, we need to recalculate the refcounts and run a leak-fixing operation > afterwards (if leaks should be fixed at all). > > Signed-off-by: Max Reitz > --- > bloc

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-22 Thread Andrey Korolyov
On Fri, Aug 22, 2014 at 9:45 PM, Marcelo Tosatti wrote: > On Fri, Aug 22, 2014 at 08:44:53PM +0400, Andrey Korolyov wrote: >> > >> > I`m running 3.10, so patches are not here, will try 3.16 soon. Even if >> > problem will be fixed, it still will be specific for 2.1, earlier >> > releases working w

Re: [Qemu-devel] [PATCH v2 4/4] target-openrisc: Add LPC32XX touchscreen device

2014-08-22 Thread Valentin Manea
Hi, On 2014-08-22 20:36, Eric Blake wrote: > [meta-comment] > > We prefer shallow threading (git send-email's default, if you don't mess > with configuration variables, where patch 4 is in-reply-to _only_ 0/4): > > 0/4 > + 1/4 > + 2/4 > + 3/4 > + 4/4 > > which also leads to nicer review tree la

Re: [Qemu-devel] [PATCH v3] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-22 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Thu, Aug 21, 2014 at 07:52:37PM +0200, Lluís Vilanova wrote: >> Also removes old "trace-event", "trace-file" and "info trace-events" HMP >> commands. > Is this commit description correct? I think we don't want to remove > HMP commands. It is "legacy" but users may s

Re: [Qemu-devel] [PATCH v3 06/10] qcow2: Do not perform potentially damaging repairs

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 06:31:40PM +0200, Max Reitz wrote: > If a referenced cluster has a refcount of 0, increasing its refcount may > result in clusters being allocated for the refcount structures. This may > overwrite the referenced cluster, therefore we cannot simply increase > the refcount the

Re: [Qemu-devel] [PATCH v3] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-22 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Also removes old "trace-event", "trace-file" and "info trace-events" HMP >> commands. > I can't see any HMP commands removal in your patch. You Sorry, I forgot to remove that from the commit message. >> Signed-off-by: Lluís Vilanova >>

Re: [Qemu-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-22 Thread Michael S. Tsirkin
On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: > Currenjly this ISA bridge should be fixed at 1f.0, and pass the > real vendor/device ids as the driver expect. > > Signed-off-by: Tiejun Chen > --- > hw/i386/pc_piix.c | 24 +++- > 1 file changed, 23 insertions(+)

Re: [Qemu-devel] [PATCH v3 05/10] qcow2: Fix refcount blocks beyond image end

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 06:31:39PM +0200, Max Reitz wrote: > If the qcow2 check function detects a refcount block located beyond the > image end, grow the image appropriately. This cannot break anything and > is the logical fix for such a case. > > Signed-off-by: Max Reitz > --- > block/qcow2-re

Re: [Qemu-devel] [PATCH v3] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-22 Thread Lluís Vilanova
Eric Blake writes: > On 08/21/2014 11:52 AM, Lluís Vilanova wrote: >> Also removes old "trace-event", "trace-file" and "info trace-events" HMP >> commands. >> >> Signed-off-by: Lluís Vilanova >> --- >> monitor.c | 24 +++- >> qapi-schema.json|3 ++ >> qapi/trace.jso

Re: [Qemu-devel] [PATCH v3 04/10] qcow2: Reuse refcount table in calculate_refcounts()

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 06:31:38PM +0200, Max Reitz wrote: > We will later call calculate_refcounts multiple times, so reuse the > refcount table if possible. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > dif

Re: [Qemu-devel] [PATCH v3 03/10] qcow2: Pull check_refblocks() up

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 06:31:37PM +0200, Max Reitz wrote: > Pull check_refblocks() before calculate_refcounts() so we can drop its > static declaration. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 102 > - > 1 file changed, 49 i

Re: [Qemu-devel] [PATCH v3 02/10] qcow2: Split qcow2_check_refcounts()

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 06:31:36PM +0200, Max Reitz wrote: > Put the code for calculating the reference counts and comparing them > during qemu-img check into own functions. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 153 > - >

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-22 Thread Paolo Bonzini
Il 22/08/2014 18:44, Andrey Korolyov ha scritto: >> >> I`m running 3.10, so patches are not here, will try 3.16 soon. Even if >> problem will be fixed, it still will be specific for 2.1, earlier >> releases working well and I`ll bisect at a time. > > Thanks, using 3.16 helped indeed. Though the bu

Re: [Qemu-devel] [V9fs-developer] QEMU dies on any attempt to load a Linux kernel module when using a 9P rootfs

2014-08-22 Thread Christopher Covington
Hi Dominique, On 08/22/2014 08:49 AM, Dominique Martinet wrote: > Hi, > > Christopher Covington wrote on Fri, Aug 22, 2014 at 08:37:52AM -0400: >> Thanks for the pointer to this patch. I think I started this kernel half way >> through the 3.16 merge window. The last non-cherry-picked patch I have

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-22 Thread Marcelo Tosatti
On Fri, Aug 22, 2014 at 08:44:53PM +0400, Andrey Korolyov wrote: > > > > I`m running 3.10, so patches are not here, will try 3.16 soon. Even if > > problem will be fixed, it still will be specific for 2.1, earlier > > releases working well and I`ll bisect at a time. > > Thanks, using 3.16 helped i

Re: [Qemu-devel] [PATCH v2 4/4] target-openrisc: Add LPC32XX touchscreen device

2014-08-22 Thread Eric Blake
[meta-comment] On 08/22/2014 11:06 AM, Valentin Manea wrote: > The LPC32XX is a simple MMIO touch screen device with a Linux device > driver. The device is suitable for small machines which require mouse > input but have no suitable bus(SPI, I2C). You did deep threading (patch 4 was in-reply to a

Re: [Qemu-devel] [PATCH 0/4] target-openrisc: Some openrisc improvements

2014-08-22 Thread Valentin Manea
Hi Jia, On 2014-08-22 19:11, Jia Liu wrote: > Hi Valentin, > > Thank you very much! > May you please upload the test linux image to somewhere, and tell us > your test steps? > Make me can test your change. I've resent the patches including the needed images(vmlinux and hdX). Please note that you

[Qemu-devel] [PATCH v2 3/4] target-openrisc: Add OpenCores keyboard device support

2014-08-22 Thread Valentin Manea
Add support for the OpenCores keyboard device to the default OpenRisc machine. The OpenCores keyboard device is a simple open source keyboard device created by the OpenCores project(http://opencores.org/). By default it just forwards Linux like keycodes. Signed-off-by: Valentin Manea --- hw/ope

[Qemu-devel] [PATCH v2 4/4] target-openrisc: Add LPC32XX touchscreen device

2014-08-22 Thread Valentin Manea
The LPC32XX is a simple MMIO touch screen device with a Linux device driver. The device is suitable for small machines which require mouse input but have no suitable bus(SPI, I2C). Add the LPC32XX device to the default OpenRisc machine. Signed-off-by: Valentin Manea --- default-configs/or32-sof

[Qemu-devel] [PATCH v2 2/4] target-openrisc: Add OpenCores FB device support

2014-08-22 Thread Valentin Manea
Add support for the OpenCores Framebuffer device and enable it by default in the OpenRISC machine. The OpenCores display device is a simple open source framebuffer device created http://opencores.org/project,vgafb Signed-off-by: Valentin Manea --- default-configs/or32-softmmu.mak | 1 + hw/op

[Qemu-devel] [PATCH v2 2/4] target-openrisc: Add OpenCores FB device support

2014-08-22 Thread Valentin Manea
Add support for the OpenCores Framebuffer device and enable it by default in the OpenRISC machine. The OpenCores display device is a simple open source framebuffer device created http://opencores.org/project,vgafb Signed-off-by: Valentin Manea --- default-configs/or32-softmmu.mak | 1 + hw/op

[Qemu-devel] [PATCH v2 1/4] target-openrisc: Add IDE support to default machine

2014-08-22 Thread Valentin Manea
Add MMIO ide device support to the default openrisc machine. Base address and IRQ line are the same as the or1ksim. Signed-off-by: Valentin Manea --- default-configs/or32-softmmu.mak | 3 +++ hw/openrisc/openrisc_sim.c | 32 2 files changed, 35 insertions

[Qemu-devel] [PATCH v2 0/4] target-openrisc: Machine improvements take two

2014-08-22 Thread Valentin Manea
Hi, Because of the wrapping errors in the previous set here is the set again. The purpose is to match the jor1k in functionality. For testing this vmlinux should work http://mrs.ro/dl/or1k/vmlinux and the hd images from jor1k(hdX is mirrored here http://mrs.ro/dl/or1k/hdX) Regards, Valenti

[Qemu-devel] [PATCH v2 0/4] target-openrisc: Machine improvements take two

2014-08-22 Thread Valentin Manea
Hi, Because of the wrapping errors in the previous set here is the set again. The purpose is to match the jor1k in functionality. For testing this vmlinux should work http://mrs.ro/dl/or1k/vmlinux and the hd images from jor1k(hdX is mirrored here http://mrs.ro/dl/or1k/hdX) Regards, Valenti

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-22 Thread Andrey Korolyov
> > I`m running 3.10, so patches are not here, will try 3.16 soon. Even if > problem will be fixed, it still will be specific for 2.1, earlier > releases working well and I`ll bisect at a time. Thanks, using 3.16 helped indeed. Though the bug remains as is at 2.1 on LTS 3.10, should I find the bre

[Qemu-devel] [PATCH v3 07/10] qcow2: Rebuild refcount structure during check

2014-08-22 Thread Max Reitz
The previous commit introduced the "rebuild" variable to qcow2's implementation of the image consistency check. Now make use of this by adding a function which creates a completely new refcount structure based solely on the in-memory information gathered before. The old refcount structure will be

[Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially damaging repairs

2014-08-22 Thread Max Reitz
There are certain cases where repairing a qcow2 image might actually damage it further (or rather, where repairing it has in fact damaged it further with the old qcow2 check implementation). This should not happen, so add a test for these cases. Signed-off-by: Max Reitz --- tests/qemu-iotests/10

[Qemu-devel] [PATCH v3 08/10] qcow2: Clean up after refcount rebuild

2014-08-22 Thread Max Reitz
Because the old refcount structure will be leaked after having rebuilt it, we need to recalculate the refcounts and run a leak-fixing operation afterwards (if leaks should be fixed at all). Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 35 +++ 1 file chang

[Qemu-devel] [PATCH v3 03/10] qcow2: Pull check_refblocks() up

2014-08-22 Thread Max Reitz
Pull check_refblocks() before calculate_refcounts() so we can drop its static declaration. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 102 - 1 file changed, 49 insertions(+), 53 deletions(-) diff --git a/block/qcow2-refcount.c b/block/q

[Qemu-devel] [PATCH v3 05/10] qcow2: Fix refcount blocks beyond image end

2014-08-22 Thread Max Reitz
If the qcow2 check function detects a refcount block located beyond the image end, grow the image appropriately. This cannot break anything and is the logical fix for such a case. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 50 ++ 1 file

[Qemu-devel] [PATCH v3 09/10] iotests: Fix test outputs

2014-08-22 Thread Max Reitz
039, 060 and 061 all create images with referenced clusters having a refcount of 0. Because previous commits changed handling of such errors, these tests now have a different output. Fix it. Furthermore, 060 created a refblock with a refcount greater than one which now results in having to rebuild

[Qemu-devel] [PATCH v3 06/10] qcow2: Do not perform potentially damaging repairs

2014-08-22 Thread Max Reitz
If a referenced cluster has a refcount of 0, increasing its refcount may result in clusters being allocated for the refcount structures. This may overwrite the referenced cluster, therefore we cannot simply increase the refcount then. In such cases, we can either try to replicate all the refcount

[Qemu-devel] [PATCH v3 01/10] qcow2: Fix leaks in dirty images

2014-08-22 Thread Max Reitz
When opening dirty images, qcow2's repair function should not only repair errors but leaks as well. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index f9e045f..67d6368 100644

[Qemu-devel] [PATCH v3 04/10] qcow2: Reuse refcount table in calculate_refcounts()

2014-08-22 Thread Max Reitz
We will later call calculate_refcounts multiple times, so reuse the refcount table if possible. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 2b728ef..babe

[Qemu-devel] [PATCH v3 02/10] qcow2: Split qcow2_check_refcounts()

2014-08-22 Thread Max Reitz
Put the code for calculating the reference counts and comparing them during qemu-img check into own functions. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 153 - 1 file changed, 102 insertions(+), 51 deletions(-) diff --git a/block/qcow2

Re: [Qemu-devel] [ARM - FCVT inst] : Difference in calculated value

2014-08-22 Thread Gaurav Sharma
Great !! As per my understanding this is because for minimum denormalized numbers we are ignoring the rounding value and returning the denormalized value which is rounded to zero. Will have to check the behavior in case of single and double precision value functions also. Thanks, Gaurav On Fri,

[Qemu-devel] [PATCH v3 00/10] qcow2: Fix image repairing

2014-08-22 Thread Max Reitz
As can be seen in the final patch of this series, there are certain cases where the current repair implementation of qcow2 actually damages the image further because it allocates new clusters for the refcount structure which overlap with existing but according to the on-disk refcounts (which are as

Re: [Qemu-devel] [PULL 00/29] Block patches

2014-08-22 Thread Peter Maydell
On 22 August 2014 15:51, Kevin Wolf wrote: > The following changes since commit 302fa283789a2f9b1199c327047cfad2258a23a2: > > Revert "memory: Use canonical path component as the name" (2014-08-19 > 20:05:46 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git

[Qemu-devel] [PATCH] block: Make op blockers recursive

2014-08-22 Thread Benoît Canet
Since the block layer code is starting to modify the BDS graph right in the middle of BDS chains (block-mirror's replace parameter for example) QEMU needs to properly block and unblock whole BDS subtrees; recursion is a neat way to achieve this task. This patch also takes care of modifying the op

[Qemu-devel] [PATCH] Implement recursive op blockers

2014-08-22 Thread Benoît Canet
This self contained patch implements recursives op blockers while passing all the ./check -qcow2 tests. Benoît Canet (1): block: Make op blockers recursive block.c | 69 --- block/blkverify.c | 21 +++ block/com

Re: [Qemu-devel] [PATCH 2/4] target-openrisc: Add OpenCores FB device support

2014-08-22 Thread Valentin Manea
Hi Jia, On 2014-08-22 19:00, Jia Liu wrote: > Hi Valentin, > Is here a line wrapped? > I think it should looks like: > + * Based on work by Sebastian Macke for jor1k > + * http://s-macke.github.io/jor1k/ > rather than > + http://s-macke.github.io/jor1k/ > Oh, you are completely right, I don't

Re: [Qemu-devel] [PATCH 0/4] target-openrisc: Some openrisc improvements

2014-08-22 Thread Jia Liu
Hi Valentin, On Fri, Aug 22, 2014 at 10:01 PM, Valentin Manea wrote: > Hi, > > I would like to share this series of patches to improve the openrisc > machine. Mostly my goal is to have the same features as the web based > machine and be able to boot qemu with exactly the same images. > Some f

Re: [Qemu-devel] [PATCH v2 1/9] qcow2: Fix leaks in dirty images

2014-08-22 Thread Eric Blake
On 08/15/2014 09:16 AM, Max Reitz wrote: > When opening dirty images, qcow2's repair function should not only > repair errors but leaks as well. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a

Re: [Qemu-devel] [PATCH 4/4] target-openrisc: Add LPC32XX touchscreen device

2014-08-22 Thread Jia Liu
Hi Valentin, On Fri, Aug 22, 2014 at 9:12 PM, Valentin Manea wrote: > The LPC32XX is a simple MMIO touch screen device with a Linux device > driver. The device is suitable for small machines which require mouse > input but have no suitable bus(SPI, I2C). > > Add the LPC32XX device to the default

[Qemu-devel] [Bug 1359930] Re: [ARMv5] Integrator/CP regression when reading FPSID register

2014-08-22 Thread Jakub Jermar
Yes, the patch fixes the problem for me. Thank you. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1359930 Title: [ARMv5] Integrator/CP regression when reading FPSID register Status in Home for var

Re: [Qemu-devel] [PATCH 3/4] target-openrisc: Add OpenCores keyboard device support

2014-08-22 Thread Jia Liu
Hi Valentin, On Fri, Aug 22, 2014 at 9:11 PM, Valentin Manea wrote: > Add support for the OpenCores keyboard device to the default OpenRisc > machine. > > The OpenCores keyboard device is a simple open source keyboard device > created by the OpenCores project(http://opencores.org/). By default i

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Kevin Wolf
Am 22.08.2014 um 17:34 hat Richard W.M. Jones geschrieben: > On Fri, Aug 22, 2014 at 05:22:33PM +0200, Kevin Wolf wrote: > > It's still useful because it happens to reduce the overhead in most > > implementations and it's a relatively quick operation, but the best way > > I know of to actually _ful

Re: [Qemu-devel] [PATCH 2/4] target-openrisc: Add OpenCores FB device support

2014-08-22 Thread Jia Liu
Hi Valentin, On Fri, Aug 22, 2014 at 9:10 PM, Valentin Manea wrote: > Add support for the OpenCores Framebuffer device and enable it by > default in the OpenRISC machine. > > The OpenCores display device is a simple open source framebuffer device > created http://opencores.org/project,vgafb > > S

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Richard W.M. Jones
On Fri, Aug 22, 2014 at 05:53:22PM +0200, Kevin Wolf wrote: > Am 22.08.2014 um 17:34 hat Richard W.M. Jones geschrieben: > > On Fri, Aug 22, 2014 at 05:22:33PM +0200, Kevin Wolf wrote: > > > It's still useful because it happens to reduce the overhead in most > > > implementations and it's a relativ

[Qemu-devel] [PATCH v6 12/15] target-tricore: Add instructions of SBR opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SBR opcode format. Add gen_loop micro-op generator function. Signed-off-by: Bastian Koppelmann --- v5 -> v6: - SBR_JEQ: Negate condition. target-tricore/translate.c | 66 +- 1 file changed, 65 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v6 13/15] target-tricore: Add instructions of SC opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SC opcode format. Add helper for begin interrupt service routine. Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- target-tricore/helper.h| 1 + target-tricore/op_helper.c | 59 ++ target-tricore/translate

[Qemu-devel] [PATCH v6 14/15] target-tricore: Add instructions of SLR, SSRO and SRO opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SLR, SSRO and SRO opcode format. Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- target-tricore/translate.c | 121 + 1 file changed, 121 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/

[Qemu-devel] [Bug 1278977] Re: qemu-system-sparc64 crash when initializing disk

2014-08-22 Thread Mark Cave-Ayland
Hi Waldemar, An update on this bug: it seems there is a problem with QEMU's block AIO code which seems to be easily triggerable with virtio. I think it's be identified within recent discussions on the mailing list, but I don't believe a patch has been committed to resolve the issue. Note that as

[Qemu-devel] [PATCH v6 08/15] target-tricore: Add instructions of SSR opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SSR opcode format. Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- target-tricore/translate.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c ind

[Qemu-devel] [PATCH v6 15/15] target-tricore: Add instructions of SR opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SR opcode format. Add micro-op generator functions for saturate. Add helper return from exception (rfe). Signed-off-by: Bastian Koppelmann --- v5 -> v6: - Fix formating. target-tricore/helper.h| 1 + target-tricore/op_helper.c | 52 + target-tr

[Qemu-devel] [PATCH v6 09/15] target-tricore: Add instructions of SRRS and SLRO opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SSRS and SLRO opcode format. Add micro-op generator functions for offset loads. Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- target-tricore/translate.c | 59 ++ 1 file changed, 59 insertions(+) diff --git

[Qemu-devel] [PATCH v6 07/15] target-tricore: Add instructions of SRR opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SRR opcode format. Add helper for add/sub_ssov. Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- target-tricore/helper.h| 4 ++ target-tricore/op_helper.c | 43 target-tricore/translate.c | 164

[Qemu-devel] [PATCH v6 10/15] target-tricore: Add instructions of SB opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SB opcode format. Add helper call/ret. Add micro-op generator functions for branches. Add makro to generate helper functions. Signed-off-by: Bastian Koppelmann --- v5 -> v6: - gen_intermediate_code_internal: Replace gen_goto_tb with setting of next_pc and exit_tb(0). ta

[Qemu-devel] [PATCH v6 11/15] target-tricore: Add instructions of SBC and SBRN opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SBC and SBRN opcode format. Signed-off-by: Bastian Koppelmann --- v5 -> v6: - SBC_JEQ: Negate condition. target-tricore/translate.c | 36 1 file changed, 36 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/trans

[Qemu-devel] [PATCH v6 06/15] target-tricore: Add instructions of SRC opcode format

2014-08-22 Thread Bastian Koppelmann
Add instructions of SRC opcode format. Add micro-op generator functions for add, conditional add/sub and shi/shai. Signed-off-by: Bastian Koppelmann --- v5 -> v6: - gen_shaci: Add calculation of PSW.C to shift_count = -32 case. - Remove useless parenthesis. target-tricore/helper.h|

[Qemu-devel] [PATCH v6 02/15] target-tricore: Add board for systemmode

2014-08-22 Thread Bastian Koppelmann
Add basic board to allow systemmode emulation Signed-off-by: Bastian Koppelmann --- v5 -> v6: - tricore_testboard: Fix machine name containing blanks. hw/tricore/Makefile.objs | 1 + hw/tricore/tricore_testboard.c | 129 + include/hw/tricore/t

[Qemu-devel] [PATCH v6 03/15] target-tricore: Add softmmu support

2014-08-22 Thread Bastian Koppelmann
Add basic softmmu support for TriCore Signed-off-by: Bastian Koppelmann --- v5 -> v6: - get_physical_address: Add PAGE_EXEC permission. target-tricore/helper.c| 54 +- target-tricore/op_helper.c | 33 +++- 2 files chang

[Qemu-devel] [PATCH v6 04/15] target-tricore: Add initialization for translation and activate target

2014-08-22 Thread Bastian Koppelmann
Add tcg and cpu model initialization. Add gen_intermediate_code function. Activate target in configure and add softmmu config. Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- configure | 5 ++ default-configs/tricore-softmmu.mak | 3 + target-

[Qemu-devel] [PATCH v6 05/15] target-tricore: Add masks and opcodes for decoding

2014-08-22 Thread Bastian Koppelmann
Add masks and opcodes for decoding TriCore instructions. Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson --- target-tricore/translate.c |1 + target-tricore/tricore-opcodes.h | 1406 ++ 2 files changed, 1407 insertions(+) create m

[Qemu-devel] [PATCH v6 01/15] target-tricore: Add target stubs and qom-cpu

2014-08-22 Thread Bastian Koppelmann
Add TriCore target stubs, and QOM cpu, and Maintainer Signed-off-by: Bastian Koppelmann --- v5 -> v6: - Add myself to MAINTAINERS MAINTAINERS | 6 + arch_init.c | 2 + cpu-exec.c| 11 +- cpus.c| 6 + incl

[Qemu-devel] [PATCH v6 00/15] TriCore architecture guest implementation

2014-08-22 Thread Bastian Koppelmann
Hi, my aim is to add Infineon's TriCore architecture to QEMU. This series of patches adds the target stubs, a basic testboard and a softmmu for system mode emulation. Furthermore it adds all the 16 bit long instructions of the architecture grouped by opcode format. After this series of patches

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

2014-08-22 Thread Eric Blake
On 08/22/2014 09:44 AM, Max Reitz wrote: > This is not a consequence of the extracted functions moving up, but > because of check_refblocks() preceding calculate_refcounts(). Splitting > the check won't help; and I know that Eric dislikes > (forward-)declarations of static functions (which I have t

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

2014-08-22 Thread Max Reitz
On 22.08.2014 17:44, Max Reitz wrote: [snip] […] Splitting the check won't help; […] Sorry, I meant “patch” instead of “check”. Max

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

2014-08-22 Thread Max Reitz
On 22.08.2014 17:37, Benoît Canet wrote: On Fri, Aug 22, 2014 at 05:26:45PM +0200, Max Reitz wrote: On 21.08.2014 23:16, Benoît Canet wrote: On Thu, Aug 21, 2014 at 01:13:20PM -0600, Eric Blake wrote: On 08/21/2014 12:57 PM, Benoît Canet wrote: On Fri, Aug 15, 2014 at 05:16:19PM +0200, Max Re

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Richard W.M. Jones
On Fri, Aug 22, 2014 at 04:34:40PM +0100, Richard W.M. Jones wrote: > - really really try as hard as possible to make sure that future >allocations will never fail (ie. write random non-zero data to the >file) s/will never fail/are not needed and will never fail/ Rich. -- Richard Jones

Re: [Qemu-devel] [PATCH v3] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-22 Thread Eric Blake
On 08/21/2014 11:52 AM, Lluís Vilanova wrote: > Also removes old "trace-event", "trace-file" and "info trace-events" HMP > commands. > > Signed-off-by: Lluís Vilanova > --- > monitor.c | 24 +++- > qapi-schema.json|3 ++ > qapi/trace.json | 44 ++

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

2014-08-22 Thread Benoît Canet
On Fri, Aug 22, 2014 at 05:26:45PM +0200, Max Reitz wrote: > On 21.08.2014 23:16, Benoît Canet wrote: > >On Thu, Aug 21, 2014 at 01:13:20PM -0600, Eric Blake wrote: > >>On 08/21/2014 12:57 PM, Benoît Canet wrote: > >>>On Fri, Aug 15, 2014 at 05:16:19PM +0200, Max Reitz wrote: > Put the code for

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Richard W.M. Jones
On Fri, Aug 22, 2014 at 05:22:33PM +0200, Kevin Wolf wrote: > It's still useful because it happens to reduce the overhead in most > implementations and it's a relatively quick operation, but the best way > I know of to actually _fully_ preallocate is still writing zeros. Which > of the two the user

Re: [Qemu-devel] [PATCH v5 15/15] target-tricore: Add instructions of SR opcode format

2014-08-22 Thread Bastian Koppelmann
On 08/21/2014 09:48 PM, Richard Henderson wrote: On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: +/* SR-format */ +case OPCM_16_SR_SYSTEM: +decode_sr_system(env, ctx); + break; +case OPCM_16_SR_ACCU: +decode_sr_accu(env, ctx); + break; Formatting is of

Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check

2014-08-22 Thread Max Reitz
On 21.08.2014 23:16, Benoît Canet wrote: On Thu, Aug 21, 2014 at 01:13:20PM -0600, Eric Blake wrote: On 08/21/2014 12:57 PM, Benoît Canet wrote: On Fri, Aug 15, 2014 at 05:16:19PM +0200, Max Reitz wrote: Put the code for calculating the reference counts during qemu-img check into an own functi

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-22 Thread Kevin Wolf
Am 22.08.2014 um 16:20 hat Daniel P. Berrange geschrieben: > On Fri, Aug 22, 2014 at 03:13:31PM +0200, Kevin Wolf wrote: > > Am 22.08.2014 um 14:25 hat Richard W.M. Jones geschrieben: > > > > > > On Mon, Jul 28, 2014 at 04:48:46PM +0800, Hu Tao wrote: > > > > ping... > > > > > > > > All the 6 pat

Re: [Qemu-devel] [PULL v3 00/22] Linux-user updates

2014-08-22 Thread Peter Maydell
On 22 August 2014 14:24, wrote: > From: Riku Voipio > > A usual set of improvements and bugfixes. New patches coming in and > I didn't have time to fix and test properly _handle_at calls so dropping > them too from the round. > > v1 -> v2: dropped "make binfmt flag O require P" has been dropped.

[Qemu-devel] [PULL 29/29] qemu-img: Allow cache mode specification for amend

2014-08-22 Thread Kevin Wolf
From: Max Reitz qemu-img amend may extensively modify the target image, depending on the options to be amended (e.g. conversion to qcow2 compat level 0.10 from 1.1 for an image with many unallocated zero clusters). Therefore it makes sense to allow the user to specify the cache mode to be used.

Re: [Qemu-devel] [PULL 00/29] Block patches

2014-08-22 Thread Daniel H Barboza
Any change of getting this patch pulled in this batch? "[PATCH v3] block.curl: adding 'timeout' option" Thanks On 08/22/2014 11:51 AM, Kevin Wolf wrote: The following changes since commit 302fa283789a2f9b1199c327047cfad2258a23a2: Revert "memory: Use canonical path component as the name" (

  1   2   3   >