Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-28 Thread Aravinda Prasad
On Wednesday 27 August 2014 03:20 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: Whenever there is a physical memory error due to bit flips, which cannot be corrected by hardware, the error is passed on to the kernel. If the memory address in error belongs to guest

Re: [Qemu-devel] [PATCH v2] blkdebug: make the fault injection functionality callable from QMP

2014-08-28 Thread Hitoshi Mitake
At Wed, 27 Aug 2014 06:43:49 -0600, Eric Blake wrote: [1 text/plain; UTF-8 (quoted-printable)] On 08/26/2014 11:34 PM, Hitoshi Mitake wrote: {execute: blkdebug-set-rules, arguments: {device: ide0-hd0, rules:[{event: write_aio, type: inject-error, immediately: Why 'write_aoi'? New

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-28 Thread Aravinda Prasad
On Wednesday 27 August 2014 04:07 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: This patch adds FWNMI support in qemu for powerKVM guests by handling the ibm,nmi-register rtas call. Whenever OS issues ibm,nmi-register RTAS call, the machine check notification

Re: [Qemu-devel] [PATCH v3 1/3] nfs: Fix leak of opts in nfs_file_open

2014-08-28 Thread Benoît Canet
The Thursday 28 Aug 2014 à 13:56:10 (+0800), Fam Zheng wrote : Signed-off-by: Fam Zheng f...@redhat.com --- block/nfs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index 93d87f3..194f301 100644 --- a/block/nfs.c +++

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-28 Thread Aravinda Prasad
On Wednesday 27 August 2014 04:10 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: It is possible for multi-processors to experience machine check at or about the same time. As per PAPR, subsequent processors serialize waiting for the first processor to issue the

Re: [Qemu-devel] [12/16] linux-user: support {name_to, open_by}_handle_at syscalls

2014-08-28 Thread Riku Voipio
Hi, On Tue, Aug 26, 2014 at 03:21:30PM +0100, Paul Burton wrote: On Tue, Aug 26, 2014 at 03:30:41PM +0300, Riku Voipio wrote: On Sun, Jun 15, 2014 at 05:18:29PM +0100, Paul Burton wrote: Implement support for the name_to_handle_at and open_by_handle_at syscalls, allowing their use by the

Re: [Qemu-devel] [question] e1000 interrupt storm happened becauseofits correspondingioapic-irr bit always set

2014-08-28 Thread Jason Wang
On 08/27/2014 05:31 PM, Zhang Haoyu wrote: Hi, all I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC interrupt storm, because if (!ent-fields.mask (ioapic-irr (1 i))) is always true in __kvm_ioapic_update_eoi(). Any ideas? We meet this several times:

Re: [Qemu-devel] [PATCH v7 0/4] s390: Support for Hotplug of Standby Memory

2014-08-28 Thread Christian Borntraeger
On 30/07/14 20:15, Matthew Rosato wrote: This patchset adds support in s390 for a pool of standby memory, which can be set online/offline by the guest (ie, via chmem). The standby pool of memory is allocated as the difference between the initial memory setting and the maxmem setting. As part

[Qemu-devel] [Bug 1361618] Re: sparc cg3 1152x900 display abnormal

2014-08-28 Thread szxray
new QEMU,cgthree.bin work fine, thank you! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1361618 Title: sparc cg3 1152x900 display abnormal Status in QEMU: New Bug description: when I use

[Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev()

2014-08-28 Thread Jason Wang
Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue support) tries to use set_pointer() and get_pointer() to set and get NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This trick works but result a unclean and fragile implementation (e.g print_netdev and parse_netdev).

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] Support ppc64le binfmt registration

2014-08-28 Thread Peter Maydell
On 28 August 2014 00:09, Serge E. Hallyn se...@hallyn.com wrote: Quoting Serge E. Hallyn (se...@hallyn.com): Quoting Alexander Graf (ag...@suse.de): So before we add anything to QEMU, I would like to first see someone point me to kernel patches that actually enable LE on Linux for 32bit

Re: [Qemu-devel] [PATCH v6 0/2] add read-pattern for block qourum

2014-08-28 Thread Liu Yuan
On Mon, Aug 25, 2014 at 10:46:21AM +0800, Liu Yuan wrote: On Mon, Aug 18, 2014 at 05:41:03PM +0800, Liu Yuan wrote: v6: - fix a unused warning introduced by last version Hi Stefan and Kevin, Benoît Canet has added Reviewed-by tag to both patches, could one of you pick this

[Qemu-devel] [PATCH] sheepdog: fix a core dump while do auto-reconnecting

2014-08-28 Thread Liu Yuan
We should reinit Local_err as NULL inside the while loop or g_free() will report corrupption and abort the QEMU when sheepdog driver tries reconnecting. qemu-system-x86_64: failed to get the header, Resource temporarily unavailable qemu-system-x86_64: Failed to connect to socket: Connection

[Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-28 Thread Richard W.M. Jones
No change in the patch itself since v1. However I have added a longer explanation to the commit message. Rich.

[Qemu-devel] [PATCH v2] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-28 Thread Richard W.M. Jones
In commit 63f0f45f2e89b60ff8245fec81328ddfde42a303 the following mechanical change was made: if (!state) { -qemu_aio_wait(); +aio_poll(state-s-aio_context, true); } The new code now checks if state is NULL and then dereferences it ('state-s') which is

Re: [Qemu-devel] block IO latency tracker without using QMP socket.

2014-08-28 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Wednesday 27 Aug 2014 à 16:58:12 (+0200), Anshul Makkar wrote : Hi, I am writing a block IO latency tracker. As obvious, I am calculating the latency by tracking the interval between start of IO and end of IO. (firing my latency tracker

Re: [Qemu-devel] [PATCH v2] block: Introduce null driver

2014-08-28 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: This is an analogue to Linux null_blk. It can be used for testing block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not necessary or wanted. Use null:// for AIO version, and null-co:// for

Re: [Qemu-devel] USB PCI host bus adapter hot plug

2014-08-28 Thread Gerd Hoffmann
Hi, Actually I have post a patch serials for supporting usb host adapter hotplugging, Which has been involved in Gerd's (the USB mantainer) usb-next tree. Please see: https://www.kraxel.org/cgit/qemu/log/?h=rebase/usb-next While being at it: I've rebased to latest master, solved some

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-28 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Il 27/08/2014 12:48, Pavel Dovgaluk ha scritto: From: Paolo Bonzini [mailto:pbonz...@redhat.com] Il 27/08/2014 12:30, Pavel Dovgaluk ha scritto: From: Paolo Bonzini [mailto:pbonz...@redhat.com] Il

Re: [Qemu-devel] USB PCI host bus adapter hot plug

2014-08-28 Thread Gonglei (Arei)
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Thursday, August 28, 2014 4:25 PM To: Gonglei (Arei) Cc: Alexey Kardashevskiy; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] USB PCI host bus adapter hot plug Hi, Actually I have post a patch serials

Re: [Qemu-devel] [PATCH] Fix OHCI ISO TD state never being written back.

2014-08-28 Thread Gerd Hoffmann
On Sa, 2014-08-09 at 23:34 +0300, Jack Un wrote: Hi, Hope i'm doing this right. Almost. There appears to be typo in OHCI with isochronous transfers resulting in isoch. transfer descriptor state never being written back. The'put_words' function is in a OR statement hence it is never

Re: [Qemu-devel] USB PCI host bus adapter hot plug

2014-08-28 Thread Gerd Hoffmann
Hi, The last missing bit (beside the make check failures) needed to finally merge this is turning off hotplug in case we have a companion setup. Have a patch work for this yet? Thanks. Havn't found time to do it yet. Patches are welcome. cheers, Gerd

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-28 Thread Alexander Graf
On 28.08.14 08:12, Aravinda Prasad wrote: On Wednesday 27 August 2014 03:20 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: Whenever there is a physical memory error due to bit flips, which cannot be corrected by hardware, the error is passed on to the kernel. If

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-28 Thread Alexander Graf
On 28.08.14 08:38, Aravinda Prasad wrote: On Wednesday 27 August 2014 04:07 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: This patch adds FWNMI support in qemu for powerKVM guests by handling the ibm,nmi-register rtas call. Whenever OS issues ibm,nmi-register

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-28 Thread Alexander Graf
On 28.08.14 08:56, Aravinda Prasad wrote: On Wednesday 27 August 2014 04:10 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: It is possible for multi-processors to experience machine check at or about the same time. As per PAPR, subsequent processors serialize

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-28 Thread Alexander Graf
On 28.08.14 08:56, Aravinda Prasad wrote: On Wednesday 27 August 2014 04:10 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: It is possible for multi-processors to experience machine check at or about the same time. As per PAPR, subsequent processors serialize

[Qemu-devel] [PATCH 0/2] qemu-iotests: fix two driver-specific option filtering problems

2014-08-28 Thread Hu Tao
See each patch for the details. Hu Tao (2): qemu-iotests: fix filter of encryption option qemu-iotests: filter out driver-specific option preallocation tests/qemu-iotests/common.filter | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.8.0

[Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option

2014-08-28 Thread Hu Tao
We should filter out encryption=on, too. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- tests/qemu-iotests/common.filter | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 51192c8..362394e 100644 ---

[Qemu-devel] [PATCH 2/2] qemu-iotests: filter out driver-specific option preallocation

2014-08-28 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- tests/qemu-iotests/common.filter | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 362394e..97d2934 100644 --- a/tests/qemu-iotests/common.filter +++

Re: [Qemu-devel] [PATCH] spapr_pci: map the MSI window in each PHB

2014-08-28 Thread Alexander Graf
On 27.08.14 19:10, Greg Kurz wrote: On Wed, 27 Aug 2014 18:17:12 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: On sPAPR, virtio devices are connected to the PCI bus and use MSI-X. Commit cc943c36faa192cd4b32af8fe5edb31894017d35 has modified MSI-X so that writes are made using the bus

Re: [Qemu-devel] [PATCH v2] block: Introduce null driver

2014-08-28 Thread Fam Zheng
On Thu, 08/28 10:22, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: This is an analogue to Linux null_blk. It can be used for testing block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not necessary or wanted.

Re: [Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-28 Thread Stefan Hajnoczi
On Tue, Aug 26, 2014 at 01:04:30PM +0200, Paolo Bonzini wrote: Il 26/08/2014 08:47, David Marchand ha scritto: Using a version message supposes we want to keep ivshmem-server and QEMU separated (for example, in two distribution packages) while we can avoid this, so why would we do so ?

Re: [Qemu-devel] [PATCH v3 0/2] sheepdog driver update related to VDI locking feature

2014-08-28 Thread Stefan Hajnoczi
On Mon, Aug 11, 2014 at 02:43:44PM +0900, Hitoshi Mitake wrote: Recently, sheepdog revived VDI locking functionality. This patchset updates sheepdog driver of QEMU for this feature. v3: - keep backward compatibility v2: - don't handle SD_RES_VDI_NOT_LOCKED as a special case

Re: [Qemu-devel] [PATCH v2] block: Introduce null driver

2014-08-28 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: On Thu, 08/28 10:22, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: This is an analogue to Linux null_blk. It can be used for testing block device emulation and general block layer functionalities such as coroutines and throttling, where

Re: [Qemu-devel] [PATCH] sheepdog: fix a core dump while do auto-reconnecting

2014-08-28 Thread Markus Armbruster
Liu Yuan namei.u...@gmail.com writes: We should reinit Local_err as NULL inside the while loop or g_free() will report You misspelled local_err. corrupption and abort the QEMU when sheepdog driver tries reconnecting. qemu-system-x86_64: failed to get the header, Resource temporarily

Re: [Qemu-devel] [PATCH v2] block: Introduce null driver

2014-08-28 Thread Fam Zheng
On Thu, 08/28 11:52, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: On Thu, 08/28 10:22, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: This is an analogue to Linux null_blk. It can be used for testing block device emulation and general block layer

Re: [Qemu-devel] [Qemu-stable] [PATCH 06/25] pci: Use bus master address space for delivering MSI/MSI-X messages

2014-08-28 Thread Greg Kurz
On Wed, 27 Aug 2014 12:36:03 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: From: Jan Kiszka jan.kis...@siemens.com The spec says (and real HW confirms this) that, if the bus master bit is 0, the device will not generate any PCI accesses. MSI and MSI-X messages fall among these, so we

Re: [Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and later

2014-08-28 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 01:13:09PM -0500, Andrew Martin wrote: I recently experienced UPS failure on several hosts which caused a hard shutdown. After restarting, 3 of the guests had corruption on their disks and required a fairly long fsck to fix. Afterwards, data that had

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-28 Thread Benjamin Herrenschmidt
On Thu, 2014-08-28 at 10:36 +0200, Alexander Graf wrote: So why not put it at 0x7000 then? Because PAPR says it has to be inside RTAS iirc Cheers, Ben.

[Qemu-devel] [PATCH v2] sheepdog: fix a core dump while do auto-reconnecting

2014-08-28 Thread Liu Yuan
We should reinit local_err as NULL inside the while loop or g_free() will report corrupption and abort the QEMU when sheepdog driver tries reconnecting. This was broken in commit 356b4ca. qemu-system-x86_64: failed to get the header, Resource temporarily unavailable qemu-system-x86_64: Failed to

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-28 Thread Alexander Graf
On 28.08.14 12:21, Benjamin Herrenschmidt wrote: On Thu, 2014-08-28 at 10:36 +0200, Alexander Graf wrote: So why not put it at 0x7000 then? Because PAPR says it has to be inside RTAS iirc Please show me the section of PAPR that does say so. Alex

Re: [Qemu-devel] [PATCH v6 0/2] add read-pattern for block qourum

2014-08-28 Thread Stefan Hajnoczi
On Mon, Aug 18, 2014 at 05:41:03PM +0800, Liu Yuan wrote: v6: - fix a unused warning introduced by last version v5: - simplify a for loop in quorum_aio_finalize() v4: - swap the patch order - update comment for fifo pattern in qaip - use qapi enumeration in quorum driver instead

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-28 Thread Benjamin Herrenschmidt
On Thu, 2014-08-28 at 12:29 +0200, Alexander Graf wrote: On 28.08.14 12:21, Benjamin Herrenschmidt wrote: On Thu, 2014-08-28 at 10:36 +0200, Alexander Graf wrote: So why not put it at 0x7000 then? Because PAPR says it has to be inside RTAS iirc Please show me the section of PAPR

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] target-ppc: Build error log

2014-08-28 Thread Benjamin Herrenschmidt
On Thu, 2014-08-28 at 20:33 +1000, Benjamin Herrenschmidt wrote: On Thu, 2014-08-28 at 12:29 +0200, Alexander Graf wrote: On 28.08.14 12:21, Benjamin Herrenschmidt wrote: On Thu, 2014-08-28 at 10:36 +0200, Alexander Graf wrote: So why not put it at 0x7000 then? Because PAPR

Re: [Qemu-devel] [PATCH] trace: [ust] Fix format string computation in tcg-enabled events

2014-08-28 Thread Stefan Hajnoczi
On Mon, Aug 18, 2014 at 03:02:07PM +0200, Lluís Vilanova wrote: TCG-enabled events start with two format strings. Delay per-argument format computation until requested ('Event.formats'). Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- scripts/tracetool/__init__.py| 19

Re: [Qemu-devel] [PATCH v6 0/2] add read-pattern for block qourum

2014-08-28 Thread Liu Yuan
On Thu, Aug 28, 2014 at 11:33:08AM +0100, Stefan Hajnoczi wrote: On Mon, Aug 18, 2014 at 05:41:03PM +0800, Liu Yuan wrote: v6: - fix a unused warning introduced by last version v5: - simplify a for loop in quorum_aio_finalize() v4: - swap the patch order - update comment

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-28 Thread Alexander Graf
On 25.08.14 15:45, Aravinda Prasad wrote: Extend rtas-blob to accommodate error log. Error log structure is saved in rtas space upon a machine check exception. Signed-off-by: Aravinda Prasad aravi...@linux.vnet.ibm.com I can't say I'm a big fan of this patch. Can we somehow separate that

Re: [Qemu-devel] [Bug 1359394] [NEW] virtio block device hangs after virtio_blk virtio3: requests:id 0 is not a head!

2014-08-28 Thread Stefan Hajnoczi
On Wed, Aug 20, 2014 at 08:37:46PM -, Slava Pestov wrote: The virtual machine is running block layer workloads, interrupted by unclean reboots (echo b /proc/sysrq-trigger). Kernel version is 3.14. Sometimes, I get this message on boot: virtio_blk virtio3: requests:id 0 is not a head!

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 10:31, Pavel Dovgaluk ha scritto: From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Il 27/08/2014 12:48, Pavel Dovgaluk ha scritto: From: Paolo Bonzini [mailto:pbonz...@redhat.com] Il 27/08/2014 12:30, Pavel Dovgaluk ha scritto: From: Paolo

Re: [Qemu-devel] qcow2 disk size information may be error while it is larger than 2T capacity

2014-08-28 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 08:26:58AM +, Guozhonghua wrote: Hi, everyone We have one qemu image file which size is 2348439044096, format is qcow2. But as we get its information with the command qemu-img info, the disk size is 139G. The info is as below: # qemu-img info APCD-CSSJK

Re: [Qemu-devel] What tests should make check-block run?

2014-08-28 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 02:16:36PM +0100, Peter Maydell wrote: On 21 August 2014 14:12, Stefan Hajnoczi stefa...@redhat.com wrote: On Thu, Aug 21, 2014 at 02:27:00PM +0200, Markus Armbruster wrote: Should we have a variant of make check-block for testing other (format, protocol)

Re: [Qemu-devel] [PATCH 31/46] Postcopy: Rework migration thread for postcopy mode

2014-08-28 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: Hi Paolo, Apologies, I realised I hadn't dug into this comment. Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: From: Dr. David Alan Gilbert dgilb...@redhat.com Switch to postcopy if: 1) There's still a significant amount to

Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function for 'qom-set'

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 07:19, arei.gong...@huawei.com ha scritto: From: Gonglei arei.gong...@huawei.com At present, 'qom-set' only can set string type property, which will restrict this qmp command's function. Using genneric string paring function can handle different types, such as int/bool/string

Re: [Qemu-devel] [Qemu-trivial] [PATCH] IDE: MMIO IDE device control should be little endian

2014-08-28 Thread Stefan Hajnoczi
On Sun, Aug 24, 2014 at 01:24:29PM +0400, Michael Tokarev wrote: 22.08.2014 12:52, Valentin Manea wrote: Set the IDE MMIO memory type to little endian. The ATA specs identify words part of the control commands encoded as little endian. While this has no impact on little endian systems, it's

Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function for 'qom-set'

2014-08-28 Thread Eric Blake
On 08/27/2014 11:19 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com In the subject: s/genneric/generic/, s/paring/parsing/ At present, 'qom-set' only can set string type property, qom-set is typed as taking arbitrary JSON 9one of the few commands with 'gen':'no',

Re: [Qemu-devel] [PATCH 2/2] apb: implement PCI bus error interrupt map registers

2014-08-28 Thread Artyom Tarasenko
On Mon, Aug 25, 2014 at 7:58 PM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: Both OpenBSD and FreeBSD SPARC64 attempt to read the interrupt map from the hardware and will fail if the correct ino isn't present. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk

Re: [Qemu-devel] [PATCH v2 0/7] build-sys: Fix iscsi module loading failure

2014-08-28 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 10:27:07AM +0800, Fam Zheng wrote: On Fri, 08/22 14:35, Stefan Hajnoczi wrote: Did you compare the before/after binary size with your patch? Please use size(1). Before: text data bss dec hex filename 242643016 827288

[Qemu-devel] [PATCH v2 04/12] parallel: adding vmstate for save/restore

2014-08-28 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the parallel port controller state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/char/parallel.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/hw/char/parallel.c

[Qemu-devel] [PATCH v2 05/12] serial: fixing vmstate for save/restore

2014-08-28 Thread Pavel Dovgalyuk
Some fields were added to VMState by this patch to preserve correct loading of the serial port controller state. Updating FCR value while loading was also modified to disable generating an interrupt by loadvm. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/char/serial.c | 265

[Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues

2014-08-28 Thread Pavel Dovgalyuk
This set of patches is related to migration issues in hardware devices. Some of the devices had fields in their states that didn't saved and restored. These patches add missed fields to the new subsections of the vmstates. For several devices (like integratorcp) the patches add new vmstates, that

[Qemu-devel] [PATCH v2 01/12] integratorcp: adding vmstate for save/restore

2014-08-28 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the integratorcp device state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/arm/integratorcp.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH v2 03/12] fdc: adding vmstate for save/restore

2014-08-28 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the FDC device state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/block/fdc.c | 74 1 files changed, 74 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH v2 06/12] apic_common: fixing loading vmstate

2014-08-28 Thread Pavel Dovgalyuk
This patch adds missed sipi_vector and wait_for_sipi fields to the new subsection of the vmstate of the apic_common module. Saving and loading of these fields makes migration of the apic state deterministic. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/intc/apic_common.c | 24

[Qemu-devel] [PATCH v2 10/12] piix: do not raise irq while loading vmstate

2014-08-28 Thread Pavel Dovgalyuk
This patch disables raising an irq while loading the state of PCI bridge. The aim of this patch is preserving the same behavior while saving and restoring the VM state. IRQ is not raised while saving the state of the bridge. That's why the behavior of the restored system will differ from the

[Qemu-devel] [PATCH v2 02/12] pcspk: adding vmstate for save/restore

2014-08-28 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the PC speaker device state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/audio/pcspk.c | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c index

[Qemu-devel] [PATCH v2 08/12] hpet: fixing saving and loading process

2014-08-28 Thread Pavel Dovgalyuk
VM clock does not run while saving, so there is no need for saving the ticks in HPET. Also added saving of hpet_offset field. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/timer/hpet.c | 15 ++- 1 files changed, 2 insertions(+), 13 deletions(-) diff --git

[Qemu-devel] [PATCH v2 09/12] pckbd: adding new fields to vmstate

2014-08-28 Thread Pavel Dovgalyuk
This patch adds outport to VMState to allow correct saving and restoring the state of PC keyboard controller. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/input/pckbd.c | 51 +++ 1

Re: [Qemu-devel] [PATCH v2 1/2] device_tree.c: redirect load_device_tree err message to stderr

2014-08-28 Thread Li Liu
Could this patchset apply to -trivial, thank you! Best regards, Li. On 2014/8/26 14:38, john.liuli wrote: From: Li Liu john.li...@huawei.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Li Liu john.li...@huawei.com --- changes v1 - v2: 1) fix indent issue as

[Qemu-devel] [PATCH 0/5] s390x/kvm: avoid synchronize_rcu's in kernel

2014-08-28 Thread Jens Freimann
Whenever we call an ioctl from a wrong vcpu thread, the next ioctl will be painfully slow because a synchronize_rcu thread has to be performed, therefore involving all vcpu. This patch series forces most ioctls to run on the associated vcpu. It speeds up all start/restart/reset operations

Re: [Qemu-devel] [PATCH v2 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs

2014-08-28 Thread Alexander Graf
On 15.08.14 07:29, Peter Crosthwaite wrote: Hi All, So phase one was the QOMification of qemu_irq. This is the next step. We start to setup GPIOs as proper QOM objects. Inputs are child objects of their device. Outputs are settable Links and connection is made via proper setting of a QOM

[Qemu-devel] [PATCH 2/5] s390x/kvm: run guest triggered resets on the target vcpu thread

2014-08-28 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com Currently, load_normal_reset() and modified_clear_reset() as triggered by a guest vcpu will initiate cpu resets on the current vcpu thread for all cpus. The reset should happen on the individual vcpu thread instead, so let's use run_on_cpu() for

[Qemu-devel] [PATCH 3/5] s390x/kvm: execute sigp orders on the target vcpu thread

2014-08-28 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com All sigp orders that can result in ioctls on the target vcpu should be executed on the associated vcpu thread. Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Acked-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: David

[Qemu-devel] [PATCH 5/5] s390x/kvm: execute the first cpu reset on the vcpu thread

2014-08-28 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com As all full cpu resets currently call into the kernel to do initial cpu reset, let's run this reset (triggered by cpu_s390x_init()) on the proper vcpu thread. Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com Acked-by: Christian Borntraeger

[Qemu-devel] [PATCH 1/5] kvm: run cpu state synchronization on target vcpu thread

2014-08-28 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com As already done for kvm_cpu_synchronize_state(), let's trigger kvm_arch_put_registers() via run_on_cpu() for kvm_cpu_synchronize_post_reset() and kvm_cpu_synchronize_post_init(). This way, we make sure that the register synchronizing ioctls are

Re: [Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 13:18, Pavel Dovgalyuk ha scritto: This set of patches is related to migration issues in hardware devices. Some of the devices had fields in their states that didn't saved and restored. These patches add missed fields to the new subsections of the vmstates. For several devices

Re: [Qemu-devel] [PATCH v2 06/12] apic_common: fixing loading vmstate

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 13:18, Pavel Dovgalyuk ha scritto: This patch adds missed sipi_vector and wait_for_sipi fields to the new subsection of the vmstate of the apic_common module. Saving and loading of these fields makes migration of the apic state deterministic. Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-devel] [PATCH v2 0/7] build-sys: Fix iscsi module loading failure

2014-08-28 Thread Fam Zheng
On Thu, 08/28 12:17, Stefan Hajnoczi wrote: On Mon, Aug 25, 2014 at 10:27:07AM +0800, Fam Zheng wrote: On Fri, 08/22 14:35, Stefan Hajnoczi wrote: Did you compare the before/after binary size with your patch? Please use size(1). Before: text data bss dec hex

Re: [Qemu-devel] [PATCH] coroutine: Drop co_sleep_ns

2014-08-28 Thread Stefan Hajnoczi
On Tue, Aug 26, 2014 at 03:15:43PM +0800, Fam Zheng wrote: block_job_sleep_ns is the only user. Since we are moving towards AioContext aware code, it's better to use the explict version and drop the old one. Signed-off-by: Fam Zheng f...@redhat.com --- blockjob.c| 2 +-

Re: [Qemu-devel] [PATCH] scripts: Remove scripts/qtest

2014-08-28 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 11:11:55AM +0800, Fam Zheng wrote: This is a dummy file with no user, drop it. Signed-off-by: Fam Zheng f...@redhat.com --- scripts/qtest | 5 - 1 file changed, 5 deletions(-) delete mode 100755 scripts/qtest Fine by me. I'm not aware of any users.

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add VMWare devices maintainer

2014-08-28 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 08:58:43AM +0300, Dmitry Fleytman wrote: Signed-off-by: Dmitry Fleytman dmi...@daynix.com --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com pgpw5RiSmXHPB.pgp Description: PGP signature

Re: [Qemu-devel] [PATCH v2 0/7] build-sys: Fix iscsi module loading failure

2014-08-28 Thread Paolo Bonzini
Il 28/08/2014 14:12, Fam Zheng ha scritto: OK. I'm working on an alternative approach (-Wl,-u,SYMBOL) as suggested by the binutils developer: https://sourceware.org/bugzilla/show_bug.cgi?id=17306#c5 (Also as said in the comment, --just-symbols may not be a right way to do this.) I'll

Re: [Qemu-devel] [PATCH v2 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs

2014-08-28 Thread Alexander Graf
On 28.08.14 13:59, Alexander Graf wrote: On 15.08.14 07:29, Peter Crosthwaite wrote: Hi All, So phase one was the QOMification of qemu_irq. This is the next step. We start to setup GPIOs as proper QOM objects. Inputs are child objects of their device. Outputs are settable Links and

Re: [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message

2014-08-28 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 02:29:59PM +0100, Stefan Hajnoczi wrote: Name the 'granularity' parameter and give its expected value range. Previously the device name was mistakingly reported as the parameter name. Note that the error class is unchanged from ERROR_CLASS_GENERIC_ERROR.

Re: [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message

2014-08-28 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote: But what you have is a strict improvement, so depending on whether you do a v2 to fix buf-size, vs. do a followup patch, you could add: Thanks, I will send a follow-up. Stefan pgp_ZOFFNNMnE.pgp Description: PGP signature

Re: [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message

2014-08-28 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote: buf-size has the same bug a few lines later; might as well fix both at once. Hmm...which git tree are you looking at? I don't see any error paths for buf_size:

Re: [Qemu-devel] block IO latency tracker without using QMP socket.

2014-08-28 Thread Stefan Hajnoczi
On Wed, Aug 27, 2014 at 04:58:12PM +0200, Anshul Makkar wrote: I am writing a block IO latency tracker. As obvious, I am calculating the latency by tracking the interval between start of IO and end of IO. (firing my latency tracker from function BlockDriverAIOCB *raw_aio_submit()

Re: [Qemu-devel] [PATCH] blockdev: fix drive-mirror 'granularity' error message

2014-08-28 Thread Eric Blake
On 08/28/2014 06:31 AM, Stefan Hajnoczi wrote: On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote: buf-size has the same bug a few lines later; might as well fix both at once. Hmm...which git tree are you looking at? Serves me right for going off of a 'git grep' rather than actually

[Qemu-devel] [PULL 1/6] qapi.py: avoid Python 2.5+ any() function

2014-08-28 Thread Stefan Hajnoczi
There is one instance of any() in qapi.py that breaks builds on older distros that ship Python 2.4 (like RHEL5): GEN qmp-commands.h Traceback (most recent call last): File build/scripts/qapi-commands.py, line 445, in ? exprs = parse_schema(input_file) File build/scripts/qapi.py, line

[Qemu-devel] [PULL 0/6] Fixes for buildbot failures

2014-08-28 Thread Stefan Hajnoczi
The following changes since commit c47c61be8dcd91689c8fc6db924d684c3b39: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-pci-for-qemu-20140825.0' into staging (2014-08-26 10:42:06 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git

[Qemu-devel] [PULL 3/6] trace: avoid Python 2.5 all() in tracetool

2014-08-28 Thread Stefan Hajnoczi
Red Hat Enterprise Linux 5 ships Python 2.4.3. The all() function was added in Python 2.5 so we cannot use it. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- scripts/tracetool/backend/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 5/6] block: sort formats alphabetically in bdrv_iterate_format()

2014-08-28 Thread Stefan Hajnoczi
Format names are best consumed in alphabetical order. This makes human-readable output easy to produce. bdrv_iterate_format() already has an array of format strings. Sort them before invoking the iteration callback. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 14

[Qemu-devel] [PULL 4/6] mirror: fix uninitialized variable delay_ns warnings

2014-08-28 Thread Stefan Hajnoczi
The gcc 4.1.2 compiler warns that delay_ns may be uninitialized in mirror_iteration(). There are two break statements in the do ... while loop that skip over the delay_ns assignment. These are probably the cause of the warning. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

[Qemu-devel] [PULL 2/6] libqtest: launch QEMU with QEMU_AUDIO_DRV=none

2014-08-28 Thread Stefan Hajnoczi
No test case actually uses the audio backend. Disable audio to prevent warnings on hosts with no sound hardware present: GTESTER check-qtest-aarch64 sdl: SDL_OpenAudio failed sdl: Reason: No available audio device sdl: SDL_OpenAudio failed sdl: Reason: No available audio device

[Qemu-devel] [PULL 6/6] Revert qemu-img: sort block formats in help message

2014-08-28 Thread Stefan Hajnoczi
This reverts commit 1a443c1b8b4314d365e82bddeb1de5b4b1c15fb3 and the later commit 395071a76328189f50c778f4dee6dabb90503dd9. GSequence was introduced in glib 2.14. RHEL 5 fails to compile since it uses glib 2.12.3. Now that bdrv_iterate_format() invokes the iteration callback in sorted order

Re: [Qemu-devel] [question] e1000 interrupt storm happenedbecauseofits correspondingioapic-irr bit always set

2014-08-28 Thread Zhang Haoyu
Hi Jason, I tested below patch, it's okay, the e1000 interrupt storm disappeared. But I am going to make a bit change on it, could you help review it? Currently, we call ioapic_service() immediately when we find the irq is still active during eoi broadcast. But for real hardware, there's some

Re: [Qemu-devel] [PATCH 0/5] s390x/kvm: avoid synchronize_rcu's in kernel

2014-08-28 Thread Christian Borntraeger
On 28/08/14 13:58, Jens Freimann wrote: Whenever we call an ioctl from a wrong vcpu thread, the next ioctl will be painfully slow because a synchronize_rcu thread has to be performed, therefore involving all vcpu. This patch series forces most ioctls to run on the associated vcpu. It speeds

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-28 Thread Tom Musta
On 8/28/2014 3:37 AM, Alexander Graf wrote: On 28.08.14 08:38, Aravinda Prasad wrote: On Wednesday 27 August 2014 04:07 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: This patch adds FWNMI support in qemu for powerKVM guests by handling the ibm,nmi-register rtas

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-28 Thread Alexander Graf
On 28.08.14 15:06, Tom Musta wrote: On 8/28/2014 3:37 AM, Alexander Graf wrote: On 28.08.14 08:38, Aravinda Prasad wrote: On Wednesday 27 August 2014 04:07 PM, Alexander Graf wrote: On 25.08.14 15:45, Aravinda Prasad wrote: This patch adds FWNMI support in qemu for powerKVM guests by

Re: [Qemu-devel] [PATCH v2 1/2] device_tree.c: redirect load_device_tree err message to stderr

2014-08-28 Thread Peter Crosthwaite
Hi Li, On Thu, Aug 28, 2014 at 9:37 PM, Li Liu john.li...@huawei.com wrote: Could this patchset apply to -trivial, thank you! Pings should generally only be sent after a week or so. My personal rule is 7 calendar days from the original send before pinging. Maintainers will often silently take

Re: [Qemu-devel] [PULL] Update OpenBIOS images to r1316

2014-08-28 Thread Peter Maydell
On 26 August 2014 14:16, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: Hi Peter, The following commit updates the OpenBIOS images to SVN r1316 (primarily at the request of Alex who has some dependent PPC patches queued). Please pull. ATB, Mark. The following changes since

  1   2   3   >