Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-01 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen, Tiejun wrote: On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), +

Re: [Qemu-devel] [PATCH v3 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-09-01 Thread Peter Crosthwaite
On Mon, Sep 1, 2014 at 3:50 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com At present, this function doesn't have partial cleanup implemented, which will cause resource leak in some scenarios. Example: 1. Assuming that dc-realize(dev, local_err) execute

Re: [Qemu-devel] [PATCH v3 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-09-01 Thread Gonglei (Arei)
-Original Message- From: peter.crosthwa...@petalogix.com [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite Sent: Monday, September 01, 2014 2:08 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org Developers; Huangweidong (C); Michael S. Tsirkin; Luonengjun;

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-01 Thread Gerd Hoffmann
Hi, +static bool is_same_fw_dev_path(DeviceState *src, DeviceState *dst) +{ +bool ret = false; +char *devpath_src = qdev_get_fw_dev_path(src); +char *devpath_dst = qdev_get_fw_dev_path(dst); + +if (!strcmp(devpath_src, devpath_dst)) { +ret = true; +} + +

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 10:08:34AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:48, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:23:48AM +0800, Chen, Tiejun wrote: On 2014/8/28 9:44, Chen, Tiejun wrote: On 2014/8/27 21:03, Michael S. Tsirkin wrote: On Wed, Aug 27, 2014 at 05:13:07PM

Re: [Qemu-devel] [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration

2014-09-01 Thread Michael S. Tsirkin
On Mon, Aug 25, 2014 at 08:20:31PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com This patch based on Knut's patch: ioh3420: Remove unused ioh3420_init() declaration which has been pulled on the fly. Signed-off-by: Gonglei arei.gong...@huawei.com

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-01 Thread Gonglei (Arei)
From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Monday, September 01, 2014 2:43 PM Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function Importance: High Hi, +static bool is_same_fw_dev_path(DeviceState *src, DeviceState *dst) +{ +bool ret = false;

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-01 Thread Gal Hammer
On 17/08/2014 12:49, Paolo Bonzini wrote: Il 12/08/2014 10:02, Gal Hammer ha scritto: Hi, On 10/08/2014 20:22, Paolo Bonzini wrote: Il 10/08/2014 13:32, Gal Hammer ha scritto: Based on Microsoft's sepecifications (paper can be dowloaded from http://go.microsoft.com/fwlink/?LinkId=260709),

Re: [Qemu-devel] [PATCH v8 0/4] s390: Support for Hotplug of Standby Memory

2014-09-01 Thread Christian Borntraeger
On 28/08/14 17:25, Matthew Rosato wrote: This patchset adds support in s390 for a pool of standby memory, which can be set online/offline by the guest (ie, via chmem). The standby pool of memory is allocated as the difference between the initial memory setting and the maxmem setting. As part

Re: [Qemu-devel] [PATCH] dump: let dump_error printf the error reason

2014-09-01 Thread zhanghailiang
On 2014/8/29 20:55, Luiz Capitulino wrote: On Fri, 29 Aug 2014 16:06:18 +0800 zhanghailiangzhang.zhanghaili...@huawei.com wrote: On 2014/8/27 21:18, Luiz Capitulino wrote: On Wed, 27 Aug 2014 19:18:53 +0800 zhanghailiangzhang.zhanghaili...@huawei.com wrote: The second parameter of

[Qemu-devel] [PATCH 1/8] block/quorum: initialize qcrs.aiocb for read

2014-09-01 Thread Liu Yuan
This is required by quorum_aio_cancel() Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan namei.u...@gmail.com --- block/quorum.c | 23 --- 1 file changed, 12

[Qemu-devel] [PATCH 4/8] block/quorum: add quorum_aio_release() helper

2014-09-01 Thread Liu Yuan
Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan namei.u...@gmail.com --- block/quorum.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 0/8] add basic recovery logic to quorum driver

2014-09-01 Thread Liu Yuan
This patch set mainly add mainly two logics to implement device recover - notify qourum driver of the broken states from the child driver(s) - dirty track and sync the device after it is repaired Thus quorum allow VMs to continue while some child devices are broken and when the child devices are

[Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Liu Yuan
For a fifo read pattern, we only have one running aio (possible other cases that has less number than num_children in the future), so we need to check if .acb is NULL against bdrv_aio_cancel() to avoid segfault. Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf

[Qemu-devel] [PATCH 2/8] block: add driver operation callbacks

2014-09-01 Thread Liu Yuan
Driver operations are defined as callbacks passed from block upper drivers to lower drivers and are supposed to be called by lower drivers. Requests handling(queuing, submitting, etc.) are done in protocol tier in the block layer and connection states are also maintained down there. Driver

[Qemu-devel] [PATCH 8/8] quorum: add basic device recovery logic

2014-09-01 Thread Liu Yuan
For some configuration, quorum allow VMs to continue while some child devices are broken and when the child devices are repaired and return back, we need to sync dirty bits during downtime to keep data consistency. The recovery logic is based on the driver state bitmap and will sync the dirty

[Qemu-devel] [PATCH 3/8] block/sheepdog: propagate disconnect/reconnect events to upper driver

2014-09-01 Thread Liu Yuan
This is the reference usage how we propagate connection state to upper tier. Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan namei.u...@gmail.com --- block/sheepdog.c | 9

Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-09-01 Thread Alexey Kardashevskiy
On 08/25/2014 11:45 PM, Aravinda Prasad wrote: Extend rtas-blob to accommodate error log. Error log structure is saved in rtas space upon a machine check exception. Signed-off-by: Aravinda Prasad aravi...@linux.vnet.ibm.com --- hw/ppc/spapr.c | 13 ++---

[Qemu-devel] [PATCH 6/8] block/quorum: add broken state to BlockDriverState

2014-09-01 Thread Liu Yuan
This allow VM continues to process even if some devices are broken meanwhile with proper configuration. We mark the device broken when the protocol tier notify back some broken state(s) of the device, such as diconnection via driver operations. We could also reset the device as sound when the

[Qemu-devel] [PATCH 7/8] block: add two helpers

2014-09-01 Thread Liu Yuan
These helpers are needed by later quorum sync device logic. Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan namei.u...@gmail.com --- block.c | 10 ++

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-01 Thread Chen, Tiejun
On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen, Tiejun wrote: On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev =

[Qemu-devel] [PATCH 1/5] target-arm: add powered off cpu state

2014-09-01 Thread Ard Biesheuvel
From: Rob Herring rob.herr...@linaro.org Add tracking of cpu power state in order to support powering off of cores in system emuluation. The initial state is determined by the start-powered-off QOM property. Signed-off-by: Rob Herring rob.herr...@linaro.org Signed-off-by: Ard Biesheuvel

[Qemu-devel] [PATCH 4/5] target-arm: add emulation of PSCI calls for system emulation

2014-09-01 Thread Ard Biesheuvel
From: Rob Herring rob.herr...@linaro.org Add support for handling PSCI calls in system emulation. Both version 0.1 and 0.2 of the PSCI spec are supported. Platforms can enable support by setting psci-method QOM property on the cpus to SMC or HVC emulation and having PSCI binding in their dtb.

[Qemu-devel] [PATCH 2/5] target-arm: support AArch64 for arm_cpu_set_pc

2014-09-01 Thread Ard Biesheuvel
From: Rob Herring rob.herr...@linaro.org Add AArch64 support to arm_cpu_set_pc and make it available to other files. Signed-off-by: Rob Herring rob.herr...@linaro.org Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- target-arm/cpu.c | 7 --- target-arm/cpu.h | 12 2

[Qemu-devel] [PATCH 0/5] ARM: add PSCI 0.2 support in TCG mode

2014-09-01 Thread Ard Biesheuvel
This series adds PSCI support to ARM and AArch64 system emulation when running in TCG mode. As PSCI calls can be made using either hypervisor call (HVC) or secure monitor call (SMC) instructions, support is added for handling those in patch #3 before patch #4 adds the actual PSCI dispatch logic.

[Qemu-devel] [PATCH 3/5] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-01 Thread Ard Biesheuvel
From: Rob Herring rob.herr...@linaro.org Add the infrastructure to handle and emulate hvc and smc exceptions. This will enable emulation of things such as PSCI calls. This commit does not change the behavior and will exit with unknown exception. Signed-off-by: Rob Herring rob.herr...@linaro.org

[Qemu-devel] [PATCH 5/5] arm/virt: enable PSCI emulation support for system emulation

2014-09-01 Thread Ard Biesheuvel
From: Rob Herring rob.herr...@linaro.org Now that we have PSCI emulation, enable it for the virt platform. This simplifies the virt machine a bit now that PSCI no longer needs to be a KVM only feature. Signed-off-by: Rob Herring rob.herr...@linaro.org Signed-off-by: Ard Biesheuvel

Re: [Qemu-devel] What tests should make check-block run?

2014-09-01 Thread Markus Armbruster
Max Reitz mre...@redhat.com writes: On 28.08.2014 17:24, Markus Armbruster wrote: Stefan Hajnoczi stefa...@gmail.com writes: On Thu, Aug 21, 2014 at 02:16:36PM +0100, Peter Maydell wrote: On 21 August 2014 14:12, Stefan Hajnoczi stefa...@redhat.com wrote: On Thu, Aug 21, 2014 at 02:27:00PM

[Qemu-devel] [Bug 1362635] Re: bdrv_read co-routine re-entered recursively

2014-09-01 Thread senya
I'm trying to reanimate github.com/jagane/qemu-kvm-livebackup there is a separate thread which connects with client through socket and sends disk blocks to it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] cpu: init vmstate for ticks and clock offset

2014-09-01 Thread Paolo Bonzini
Il 01/09/2014 07:34, Pavel Dovgalyuk ha scritto: Ticks and clock offset used by CPU timers have to be saved in vmstate. But vmstate for these fields registered only in icount mode. Missing registration leads to breaking the continuity when vmstate is loaded. This patch introduces new

Re: [Qemu-devel] bug (bisected): qemu-system-sh4 serial console, ctrl-C kills emulator

2014-09-01 Thread Paolo Bonzini
Il 01/09/2014 07:05, Rob Landley ha scritto: If you grab http://landley.net/aboriginal/bin/qemu-system-sh4.tar.bz2 extract it and ./run-emulator.sh (which is a fairly straightforward qemu-system-sh4 invocation on the included kernel image and squashfs root filesystem), older qemu versions

Re: [Qemu-devel] tcmu-runner and QEMU

2014-09-01 Thread Paolo Bonzini
Il 31/08/2014 22:03, Andy Grover ha scritto: So I think what you want is a `qemu-iscsi'? ie. the same as qemu-nbd, but with an iSCSI frontend (to replace the NBD server). You want qemu to be able to issue SCSI commands over iSCSI? I thought qemu used libiscsi for this, to be the initiator.

Re: [Qemu-devel] [PATCH V3] vhost_net: start/stop guest notifiers properly

2014-09-01 Thread Michael S. Tsirkin
On Fri, Aug 29, 2014 at 06:40:24PM +0800, Zhangjie (HZ) wrote: On 2014/8/27 20:59, Michael S. Tsirkin wrote: On Thu, Aug 21, 2014 at 03:42:53PM +0800, Zhangjie (HZ) wrote: On 2014/8/21 14:53, Jason Wang wrote: On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote: After migration, vhost is

Re: [Qemu-devel] [PATCH 0/8] add basic recovery logic to quorum driver

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:06 (+0800), Liu Yuan wrote : This patch set mainly add mainly two logics to implement device recover - notify qourum driver of the broken states from the child driver(s) - dirty track and sync the device after it is repaired Thus quorum allow VMs to continue

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 10:07:19AM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen tiejun.c...@intel.com ---

Re: [Qemu-devel] [PATCH 2/8] block: add driver operation callbacks

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:08 (+0800), Liu Yuan wrote : Driver operations are defined as callbacks passed from block upper drivers to lower drivers and are supposed to be called by lower drivers. Requests handling(queuing, submitting, etc.) are done in protocol tier in the block layer

Re: [Qemu-devel] [PATCH 3/8] block/sheepdog: propagate disconnect/reconnect events to upper driver

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:09 (+0800), Liu Yuan wrote : This is the reference usage how we propagate connection state to upper tier. Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] tcmu-runner and QEMU

2014-09-01 Thread Paolo Bonzini
Il 31/08/2014 22:38, Benoît Canet ha scritto: The problem with QEMU block drivers is that they are using either coroutines or QEMU custom AIO callbacks so reusing them without the block layer is not doable. Not really true. The QEMU block layer can be wrapped relatively easily in a GSource.

Re: [Qemu-devel] [PATCH 4/8] block/quorum: add quorum_aio_release() helper

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:10 (+0800), Liu Yuan wrote : Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan namei.u...@gmail.com --- block/quorum.c | 12 1

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : For a fifo read pattern, we only have one running aio (possible other cases that has less number than num_children in the future) I have trouble understanding this part of the commit message could you try to clarify it ? , so we need

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-01 Thread Paolo Bonzini
Il 29/08/2014 20:01, Peter Maydell ha scritto: [cc'ing MJT for more distro opinion since I think fundamentally the choice we ought to make upstream is what's not going to screw over distros... Paolo, is there a RedHat QEMU maintainer who would have an opinion here?] There's Cole Robinson.

Re: [Qemu-devel] [PATCH 2/2] i386: Add a Virtual Machine Generation ID device.

2014-09-01 Thread Paolo Bonzini
Il 01/09/2014 09:20, Gal Hammer ha scritto: We are still in the process of defining which devices/methods go in the DSDT and which go in the SSDT. We had bad experiences with ACPI table migration in 2.1, and one plan to fix them is the following: * the DSDT should always be the same size no

[Qemu-devel] [PATCH 0/2] vbe: bochs dispi interface fixes

2014-09-01 Thread Gerd Hoffmann
Hi, Two fixes for the bochs dispi interface, one of them fixing a minor security issue. please review, Gerd Gerd Hoffmann (2): vbe: make bochs dispi interface return the correct memory size with qxl vbe: rework sanity checks hw/display/qxl.c | 1 + hw/display/vga.c | 159

[Qemu-devel] [PATCH 2/2] vbe: rework sanity checks

2014-09-01 Thread Gerd Hoffmann
Plug a bunch of holes in the bochs dispi interface parameter checking. Add a function doing verification on all registers. Call that unconditionally on every register write. That way we should catch everything, even changing one register affecting the valid range of another register. Some of

[Qemu-devel] [PATCH 1/2] vbe: make bochs dispi interface return the correct memory size with qxl

2014-09-01 Thread Gerd Hoffmann
VgaState-vram_size is the size of the pci bar. In case of qxl not the whole pci bar can be used as vga framebuffer. Add a new variable vbe_size to handle that case. By default (if unset) it equals vram_size, but qxl can set vbe_size to something else. This makes sure

Re: [Qemu-devel] [PATCH 7/8] block: add two helpers

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:13 (+0800), Liu Yuan wrote : These helpers are needed by later quorum sync device logic. Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan

Re: [Qemu-devel] [PATCH 6/8] block/quorum: add broken state to BlockDriverState

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:12 (+0800), Liu Yuan wrote : This allow VM continues to process even if some devices are broken meanwhile with proper configuration. We mark the device broken when the protocol tier notify back some broken state(s) of the device, such as diconnection via driver

[Qemu-devel] [PATCH v1 2/2] block/archipelago: Use QEMU atomic builtins

2014-09-01 Thread Chrysostomos Nanakos
Replace __sync builtins with the ones provided by QEMU for atomic operations. Signed-off-by: Chrysostomos Nanakos cnana...@grnet.gr --- block/archipelago.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/block/archipelago.c b/block/archipelago.c index

[Qemu-devel] [PATCH v1 1/2] Extend header file for atomic operations

2014-09-01 Thread Chrysostomos Nanakos
Add __sync_*_and_fetch builtins used in several places. Signed-off-by: Chrysostomos Nanakos cnana...@grnet.gr --- include/qemu/atomic.h |4 1 file changed, 4 insertions(+) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index 492bce1..48fc283 100644 ---

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-01 Thread Peter Maydell
On 1 September 2014 09:51, Paolo Bonzini pbonz...@redhat.com wrote: Il 29/08/2014 20:01, Peter Maydell ha scritto: [cc'ing MJT for more distro opinion since I think fundamentally the choice we ought to make upstream is what's not going to screw over distros... Paolo, is there a RedHat QEMU

Re: [Qemu-devel] [PATCH 2/5] target-arm: support AArch64 for arm_cpu_set_pc

2014-09-01 Thread Ard Biesheuvel
On 1 September 2014 11:09, Peter Maydell peter.mayd...@linaro.org wrote: On 1 September 2014 08:53, Ard Biesheuvel ard.biesheu...@linaro.org wrote: From: Rob Herring rob.herr...@linaro.org Add AArch64 support to arm_cpu_set_pc and make it available to other files. This is still the wrong way

Re: [Qemu-devel] [PATCH 2/8] block: add driver operation callbacks

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 10:28:54AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:08 (+0800), Liu Yuan wrote : Driver operations are defined as callbacks passed from block upper drivers to lower drivers and are supposed to be called by lower drivers. Requests

[Qemu-devel] [PATCH v5] block: Introduce null drivers

2014-09-01 Thread Fam Zheng
This is an analogue to Linux null_blk. It can be used for testing or benchmarking block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not necessary or wanted. Use null-aio:// for AIO version, and null-co:// for coroutine version.

Re: [Qemu-devel] [PATCH 3/8] block/sheepdog: propagate disconnect/reconnect events to upper driver

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 10:31:47AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:09 (+0800), Liu Yuan wrote : This is the reference usage how we propagate connection state to upper tier. Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : For a fifo read pattern, we only have one running aio (possible other cases that has less number than num_children in the future) I have trouble understanding this part

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Chen, Tiejun
On 2014/9/1 16:27, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:07:19AM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-01 Thread Paolo Bonzini
Il 01/09/2014 11:12, Peter Maydell ha scritto: We'd just add Ps and we'd be fine. But this would break all your existing users' existing chroot setups. That's the question I'm after an answer to: what do you (as a distro) think would be acceptable as transitional breakage, if anything?

Re: [Qemu-devel] [PATCH 2/8] block: add driver operation callbacks

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 17:19:19 (+0800), Liu Yuan wrote : On Mon, Sep 01, 2014 at 10:28:54AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:08 (+0800), Liu Yuan wrote : Driver operations are defined as callbacks passed from block upper drivers to lower drivers and are

Re: [Qemu-devel] [PATCH 2/5] target-arm: support AArch64 for arm_cpu_set_pc

2014-09-01 Thread Peter Maydell
On 1 September 2014 08:53, Ard Biesheuvel ard.biesheu...@linaro.org wrote: From: Rob Herring rob.herr...@linaro.org Add AArch64 support to arm_cpu_set_pc and make it available to other files. This is still the wrong way to do this. See review on previous version of this patchset:

Re: [Qemu-devel] [PATCH 6/8] block/quorum: add broken state to BlockDriverState

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 10:57:43AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:12 (+0800), Liu Yuan wrote : This allow VM continues to process even if some devices are broken meanwhile with proper configuration. We mark the device broken when the protocol tier notify back

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-01 Thread Peter Maydell
On 1 September 2014 10:28, Paolo Bonzini pbonz...@redhat.com wrote: Il 01/09/2014 11:12, Peter Maydell ha scritto: We'd just add Ps and we'd be fine. But this would break all your existing users' existing chroot setups. That's the question I'm after an answer to: what do you (as a distro)

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 17:26:09 (+0800), Liu Yuan wrote : On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : For a fifo read pattern, we only have one running aio (possible other cases that has less number than

[Qemu-devel] [Patch] block:qemu will crash when vhost-scsi disk vm reboot

2014-09-01 Thread Zhang Min
From: subo su...@huawei.com When the vm reboot, it will call virtio_scsi_handle_event(), for vhost-scsi device,vdev is VIRTIO_SCSI_COMMON, not VIRTIO_SCSI, if vdev convert to the VIRTIO_SCSI, it will cause qemu crash. Signed-off-by: Zhang Min rudy.zhang...@huawei.com Signed-off-by: subo

Re: [Qemu-devel] [Patch] block:qemu will crash when vhost-scsi disk vm reboot

2014-09-01 Thread Paolo Bonzini
Il 01/09/2014 11:33, Zhang Min ha scritto: From: subo su...@huawei.com When the vm reboot, it will call virtio_scsi_handle_event(), for vhost-scsi device,vdev is VIRTIO_SCSI_COMMON, not VIRTIO_SCSI, if vdev convert to the VIRTIO_SCSI, it will cause qemu crash. Signed-off-by: Zhang Min

Re: [Qemu-devel] [PATCH 8/8] quorum: add basic device recovery logic

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:14 (+0800), Liu Yuan wrote : For some configuration, quorum allow VMs to continue while some child devices are broken and when the child devices are repaired and return back, we need to sync dirty bits during downtime to keep data consistency. The recovery

Re: [Qemu-devel] [PATCH 2/4] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2014-09-01 Thread Michael S. Tsirkin
On Fri, Aug 29, 2014 at 09:17:07AM +0200, Knut Omang wrote: This patch provides the building blocks for creating an SR/IOV PCIe Extended Capability header and creating and removing SR/IOV Virtual Functions. Signed-off-by: Knut Omang knut.om...@oracle.com --- hw/pci/pci.c | 107

Re: [Qemu-devel] [PATCH 2/8] block: add driver operation callbacks

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 11:28:22AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 17:19:19 (+0800), Liu Yuan wrote : On Mon, Sep 01, 2014 at 10:28:54AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:08 (+0800), Liu Yuan wrote : Driver operations are defined as callbacks

Re: [Qemu-devel] [PATCH v1 2/2] block/archipelago: Use QEMU atomic builtins

2014-09-01 Thread Paolo Bonzini
Il 01/09/2014 10:58, Chrysostomos Nanakos ha scritto: Replace __sync builtins with the ones provided by QEMU for atomic operations. Signed-off-by: Chrysostomos Nanakos cnana...@grnet.gr --- block/archipelago.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH 8/8] quorum: add basic device recovery logic

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 11:37:20AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:14 (+0800), Liu Yuan wrote : For some configuration, quorum allow VMs to continue while some child devices are broken and when the child devices are repaired and return back, we need to sync

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 11:32:04AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 17:26:09 (+0800), Liu Yuan wrote : On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : For a fifo read pattern, we only have one

Re: [Qemu-devel] [PULL 00/35] Block patches

2014-09-01 Thread Peter Maydell
On 29 August 2014 17:29, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit a6aebb38ba4682951ab04fe6d6e6b169bd9e4dca: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-08-28 17:08:13 +0100) are available in the git repository

[Qemu-devel] KVM call for agenda for 2014-09-02

2014-09-01 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: 15:00 CEST 13:00 UTC 09:00 EDT Every two weeks By popular demand, a google calendar public entry with it

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-01 Thread Riku Voipio
On Mon, Sep 01, 2014 at 10:12:18AM +0100, Peter Maydell wrote: On 1 September 2014 09:51, Paolo Bonzini pbonz...@redhat.com wrote: Il 29/08/2014 20:01, Peter Maydell ha scritto: [cc'ing MJT for more distro opinion since I think fundamentally the choice we ought to make upstream is what's

Re: [Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-09-01 Thread David Marchand
On 08/28/2014 11:49 AM, Stefan Hajnoczi wrote: On Tue, Aug 26, 2014 at 01:04:30PM +0200, Paolo Bonzini wrote: Il 26/08/2014 08:47, David Marchand ha scritto: Using a version message supposes we want to keep ivshmem-server and QEMU separated (for example, in two distribution packages) while we

Re: [Qemu-devel] IO accounting overhaul

2014-09-01 Thread Markus Armbruster
Cc'ing libvirt following Stefan's lead. Benoît Canet benoit.ca...@irqsave.net writes: Hi, I collected some items of a cloud provider wishlist regarding I/O accouting. Feedback from real power-users, lovely! In a cloud I/O accouting can have 3 purpose: billing, helping the customers and

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 05:26:24PM +0800, Chen, Tiejun wrote: On 2014/9/1 16:27, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:07:19AM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes

Re: [Qemu-devel] [PATCH 0/5] s390x/gdb: various fixes

2014-09-01 Thread Christian Borntraeger
On 29/08/14 15:52, Jens Freimann wrote: Conny, Alex, Christian, here are some patches improving our gdb support. * Patch 1 fixes a bug where the cc was changed accidentally. * Patch 2 adds the gdb feature XML files for s390x * Patch 3 Define acr and fpr registers as coprocessor

[Qemu-devel] [PATCH v8 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-09-01 Thread Marc Marí
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 95e6861..07ae754

[Qemu-devel] [PATCH v8 0/7] Virtio PCI libqos driver

2014-09-01 Thread Marc Marí
v3: Solved problems, added indirect descriptor support and test for configuration changes v4: Solved bugs, changed some interfaces, added MSI-X and event_idx support. v5: Simplified virtio-blk-test, solved bugs, avoid patches already merged. v6: Solve bugs (qpci_iomap changed prototype) v7:

[Qemu-devel] [PATCH v8 2/7] tests: Add virtio device initialization

2014-09-01 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 71 +

[Qemu-devel] [PATCH v8 4/7] libqos: Added indirect descriptor support to virtio implementation

2014-09-01 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 10 + tests/libqos/virtio.c | 64

[Qemu-devel] [PATCH v8 1/7] tests: Functions bus_foreach and device_find from libqos virtio API

2014-09-01 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com ---

[Qemu-devel] [PATCH v8 3/7] libqos: Added basic virtqueue support to virtio implementation

2014-09-01 Thread Marc Marí
Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 82 +

[Qemu-devel] [PATCH v8 6/7] libqos: Added MSI-X support

2014-09-01 Thread Marc Marí
Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/pci.c| 111 +++- tests/libqos/pci.h| 10 +++ tests/libqos/virtio-pci.c

[Qemu-devel] [PATCH v8 7/7] libqos: Added EVENT_IDX support

2014-09-01 Thread Marc Marí
Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c |1 + tests/libqos/virtio.c | 27 +- tests/libqos/virtio.h |5 ++ tests/virtio-blk-test.c | 124

Re: [Qemu-devel] [PATCH v1 2/2] block/archipelago: Use QEMU atomic builtins

2014-09-01 Thread Chrysostomos Nanakos
On 09/01/2014 12:43 PM, Paolo Bonzini wrote: Il 01/09/2014 10:58, Chrysostomos Nanakos ha scritto: Replace __sync builtins with the ones provided by QEMU for atomic operations. Signed-off-by: Chrysostomos Nanakos cnana...@grnet.gr --- block/archipelago.c | 11 ++- 1 file changed,

Re: [Qemu-devel] [PATCH 5/5] gdb: provide the name of the architecture in the target.xml

2014-09-01 Thread Peter Maydell
[ccing Andreas in case he wants to review the QOM aspects of this, though they're fairly straightforward I think.] On 29 August 2014 14:52, Jens Freimann jf...@linux.vnet.ibm.com wrote: From: David Hildenbrand d...@linux.vnet.ibm.com This patch provides the name of the architecture in the

Re: [Qemu-devel] [PATCH 5/5] gdb: provide the name of the architecture in the target.xml

2014-09-01 Thread Andreas Färber
Am 01.09.2014 12:19, schrieb Peter Maydell: [ccing Andreas in case he wants to review the QOM aspects of this, though they're fairly straightforward I think.] On 29 August 2014 14:52, Jens Freimann jf...@linux.vnet.ibm.com wrote: From: David Hildenbrand d...@linux.vnet.ibm.com This patch

Re: [Qemu-devel] [PATCH 5/5] gdb: provide the name of the architecture in the target.xml

2014-09-01 Thread Christian Borntraeger
On 01/09/14 12:19, Peter Maydell wrote: [ccing Andreas in case he wants to review the QOM aspects of this, though they're fairly straightforward I think.] On 29 August 2014 14:52, Jens Freimann jf...@linux.vnet.ibm.com wrote: From: David Hildenbrand d...@linux.vnet.ibm.com This patch

Re: [Qemu-devel] [PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Chen, Tiejun
On 2014/9/1 17:53, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 05:26:24PM +0800, Chen, Tiejun wrote: On 2014/9/1 16:27, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:07:19AM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its

Re: [Qemu-devel] [PATCH 5/5] gdb: provide the name of the architecture in the target.xml

2014-09-01 Thread Peter Maydell
On 1 September 2014 11:31, Christian Borntraeger borntrae...@de.ibm.com wrote: On 01/09/14 12:19, Peter Maydell wrote: [ccing Andreas in case he wants to review the QOM aspects of this, though they're fairly straightforward I think.] On 29 August 2014 14:52, Jens Freimann

Re: [Qemu-devel] [PATCH v1 2/2] block/archipelago: Use QEMU atomic builtins

2014-09-01 Thread Paolo Bonzini
Il 01/09/2014 12:13, Chrysostomos Nanakos ha scritto: -if ((__sync_add_and_fetch(segreq-ref, -segments_nr + i)) == 0) { +if ((atomic_add_fetch(segreq-ref, -segments_nr + i)) == 0) { What about this one? It seems easier to me to read the above and understand what is going

[Qemu-devel] [v3][PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Tiejun Chen
We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen tiejun.c...@intel.com --- hw/i386/kvm/pci-assign.c| 46 +

[Qemu-devel] [v3][PATCH 0/1] qemu:pci-assign: try to pci-assign.c

2014-09-01 Thread Tiejun Chen
v3: * Don't move out those common structures. * Just include minimum required head file. * Rename dev_load_option_rom with pci_assign_dev_load_option_rom to avoid global namespace pollution. v2: * v1 is making so much code inline, so try to move it to an out of line file. * rename pci-assign

Re: [Qemu-devel] [PATCH v1 2/2] block/archipelago: Use QEMU atomic builtins

2014-09-01 Thread Chrysostomos Nanakos
On 09/01/2014 01:33 PM, Paolo Bonzini wrote: Il 01/09/2014 12:13, Chrysostomos Nanakos ha scritto: -if ((__sync_add_and_fetch(segreq-ref, -segments_nr + i)) == 0) { +if ((atomic_add_fetch(segreq-ref, -segments_nr + i)) == 0) { What about this one? It seems easier to me to read

Re: [Qemu-devel] [libvirt] IO accounting overhaul

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 11:52:00 (+0200), Markus Armbruster wrote : Cc'ing libvirt following Stefan's lead. Benoît Canet benoit.ca...@irqsave.net writes: Hi, I collected some items of a cloud provider wishlist regarding I/O accouting. Feedback from real power-users, lovely! In

Re: [Qemu-devel] [v3][PATCH 1/1] hw/pci-assign: split pci-assign.c

2014-09-01 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 06:36:47PM +0800, Tiejun Chen wrote: We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen tiejun.c...@intel.com ---

Re: [Qemu-devel] [PATCH] KVM_CAP_IRQFD and KVM_CAP_IRQFD_RESAMPLE checks

2014-09-01 Thread Paolo Bonzini
Il 29/08/2014 19:38, Eric Auger ha scritto: Compute kvm_irqfds_allowed by checking the KVM_CAP_IRQFD extension. Remove direct settings in architecture specific files. Add a new kvm_resamplefds_allowed variable, initialized by checking the KVM_CAP_IRQFD_RESAMPLE extension. Add a corresponding

Re: [Qemu-devel] [PATCH] block: kill tail whitespace in block.c

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 13:35:21 (+0800), Liu Yuan wrote : Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan namei.u...@gmail.com --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount

2014-09-01 Thread Jun Li
When every item of refcount block is NULL, free refcount block and reset the corresponding item of refcount table with NULL. Signed-off-by: Jun Li address@hidden --- The v2 do following change to modify some potential issue. +--- Here should start from 0. | for

  1   2   3   >