Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 02:17:02AM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 2:09 AM, Andrey Korolyov and...@xdel.ru wrote: On Wed, Sep 3, 2014 at 1:51 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 03, 2014 at 01:29:29AM +0400, Andrey Korolyov wrote: On Wed, Sep 3,

[Qemu-devel] [PATCH V2] fix: unix sockets created for virtio-serail has insufficient permissions

2014-09-03 Thread Chunyan Liu
Add umask to _virCommand, allow user to set umask to command. Set umask(002) to qemu process to overwrite default umask(022) so that unix sockets created for virtio-serial has expected permissions. Fix problem reported here: https://sourceware.org/bugzilla/show_bug.cgi?id=13078#c11

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-03 Thread Gerd Hoffmann
Hi, 4. When we hotplug the virtio-net-pci device, only pass virtio-net-pci's pointer to del_boot_device_path(). But virtio-net-pci != virtio-net-device, so I add a function named is_same_fw_dev_path() to handle this situation. When hot-unplugging virtio-net-pci I'd expect we free

[Qemu-devel] [PATCH] vhost_net: initialize acked_features to a safe value during ack

2014-09-03 Thread Jason Wang
commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to backend_features. This will result an unexpected value of acked_features which may fail the features setting of vhost. This patch fixes it

[Qemu-devel] [PULL 07/10] query-memdev: fix potential memory leaks

2014-09-03 Thread Michael Tokarev
From: Chen Fan chen.fan.f...@cn.fujitsu.com Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- numa.c |6 +- 1 file changed, 5

[Qemu-devel] [PULL 00/10] Trivial patches for 2014-09-03

2014-09-03 Thread Michael Tokarev
Here's a next trivial-patches batch. A few little things here and there. Please consider applying. Thanks, /mjt The following changes since commit 30eaca3acdf17d7bcbd1213eb149c02037edfb0b: Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20140902-1' into staging (2014-09-02

[Qemu-devel] [PULL 10/10] slirp: Honour vlan/stack in hostfwd_remove commands

2014-09-03 Thread Michael Tokarev
From: Peter Maydell peter.mayd...@linaro.org The hostfwd_add and hostfwd_remove monitor commands allow the user to optionally specify a vlan/stack tuple. hostfwd_add honours this, but hostfwd_remove does not (it looks up the tuple but then ignores the SlirpState it has looked up and always uses

[Qemu-devel] [PULL 02/10] Fix debug print warning

2014-09-03 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Steps: 1.enable qemu debug print, using simply scprit as below: grep //#define DEBUG * -rl | xargs sed -i s/\/\/#define DEBUG/#define DEBUG/g 2. make -j 3. get some warning: hw/i2c/pm_smbus.c: In function 'smb_ioport_writeb': hw/i2c/pm_smbus.c:142:

[Qemu-devel] [PULL 05/10] device_tree.c: dump all err mesages with error_report

2014-09-03 Thread Michael Tokarev
From: Li Liu john.li...@huawei.com Signed-off-by: Li Liu john.li...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- device_tree.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/device_tree.c b/device_tree.c index

[Qemu-devel] [PULL 03/10] scripts: Remove scripts/qtest

2014-09-03 Thread Michael Tokarev
From: Fam Zheng f...@redhat.com This is a dummy file with no user, drop it. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- scripts/qtest |5 - 1 file changed, 5 deletions(-) delete mode 100755

[Qemu-devel] [PULL 09/10] hmp: fix MemdevList memory leak

2014-09-03 Thread Michael Tokarev
From: Chen Fan chen.fan.f...@cn.fujitsu.com the memdev_list in hmp_info_memdev() is never freed. so we use existent method qapi_free_MemdevList() to free it. and also we can use qapi_free_MemdevList() to replace list loops to clean up the memdev list in error path. Signed-off-by: Chen Fan

[Qemu-devel] [PULL 04/10] device_tree.c: redirect load_device_tree err message to stderr

2014-09-03 Thread Michael Tokarev
From: Li Liu john.li...@huawei.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Li Liu john.li...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- device_tree.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PULL 01/10] curl: The macro that you have to uncomment to get debugging is DEBUG_CURL.

2014-09-03 Thread Michael Tokarev
From: Richard W.M. Jones rjo...@redhat.com Signed-off-by: Richard W.M. Jones rjo...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- block/curl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index 0258339..938f9d9 100644 ---

[Qemu-devel] [PULL 08/10] qom/object.c, hmp.c: fix string_output_get_string() memory leak

2014-09-03 Thread Michael Tokarev
From: Chen Fan chen.fan.f...@cn.fujitsu.com string_output_get_string() uses g_string_free(str, false) to transfer the 'str' pointer to callers and never free it. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Hu Tao

[Qemu-devel] [PULL 06/10] MAINTAINERS: Add VMWare devices maintainer

2014-09-03 Thread Michael Tokarev
From: Dmitry Fleytman dmi...@daynix.com Signed-off-by: Dmitry Fleytman dmi...@daynix.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-03 Thread Gonglei (Arei)
Best regards, -Gonglei -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Wednesday, September 03, 2014 2:25 PM To: Gonglei (Arei) Cc: Eduardo Habkost; qemu-devel@nongnu.org; aligu...@amazon.com; m...@redhat.com; pbonz...@redhat.com; ak...@redhat.com;

[Qemu-devel] Question about cow format with hexdump

2014-09-03 Thread shhuiw
Hi, I'm reading the source code of cow.c: https://github.com/qemu/qemu/blob/master/block/cow.c and try to understand the format better. I created a cow format imagefile and can run 'qume-img info' to query the header info

[Qemu-devel] Fw:Re:What does COW mean?

2014-09-03 Thread shhuiw
Hi, Sorry to trouble you. I posted my question in the user mailing list, but can not get the right answer. So I forward it to the devel mailing list. Hope to find answer here. At 2014-09-02 04:33:50, shhuiw shh...@163.com wrote: Hi, I'm new to qemu community, and I'm trying the COW image

Re: [Qemu-devel] tcmu-runner and QEMU

2014-09-03 Thread Paolo Bonzini
Il 03/09/2014 02:20, Andy Grover ha scritto: The qemu-lio tool would live in the QEMU codebase and reuse all the infrastructure. For example, it could include a QMP monitor just like the one you are adding to qemu-nbd. Benoit and I talked a little about QMP on another part of the thread...

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-03 Thread Andrey Korolyov
On Wed, Sep 3, 2014 at 10:10 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 03, 2014 at 02:17:02AM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 2:09 AM, Andrey Korolyov and...@xdel.ru wrote: On Wed, Sep 3, 2014 at 1:51 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed,

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-03 Thread Gonglei (Arei)
Hi, -Original Message- From: Gonglei (Arei) Sent: Saturday, August 30, 2014 6:00 PM Subject: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property From: Gonglei arei.gong...@huawei.com when we remove bootindex form qdev.property to qom.property, we can use

Re: [Qemu-devel] [PATCH 0/3] build-sys: Exclude empty object files when linking libqemuutil.a

2014-09-03 Thread Paolo Bonzini
Il 03/09/2014 05:44, Fam Zheng ha scritto: On Mac OS X, ranlib complains on a few empty objects: ARlibqemuutil.a /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libqemuutil.a(generated-tracers.o) has no symbols

Re: [Qemu-devel] [PATCH v2] dump: let dump_error return error info to caller

2014-09-03 Thread zhanghailiang
On 2014/9/3 3:56, Eric Blake wrote: On 09/02/2014 02:25 AM, zhanghailiang wrote: The second parameter of dump_error is unused, but one purpose of using this function is to report the error info. Use error_set to return the error info to the caller. Signed-off-by:

Re: [Qemu-devel] [PATCH] block/iscsi: use 16 byte CDBs only when necessary

2014-09-03 Thread Peter Lieven
Am 02.09.2014 um 21:30 schrieb Peter Lieven p...@kamp.de: Looking at the code, is it possible that not the guest is causing trouble here, but multiwrite_merge code? From what I see the only limit it has when merging requests is the number of IOVs. Any thoughts? Mine are: a)

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 11:43:54AM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 10:10 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 03, 2014 at 02:17:02AM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 2:09 AM, Andrey Korolyov and...@xdel.ru wrote: On Wed, Sep 3,

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-03 Thread Gerd Hoffmann
Hi, +void set_bootindex(int32_t *bootindex, Visitor *v, + const char *name, Error **errp) +{ +int32_t boot_index; +Error *local_err = NULL; + +visit_type_int32(v, boot_index, name, local_err); + +if (local_err == NULL) { +/* check the

Re: [Qemu-devel] [PATCH] vhost_net: initialize acked_features to a safe value during ack

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 02:25:30PM +0800, Jason Wang wrote: commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to backend_features. But acked features are set in vhost_ack_features. why

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-03 Thread Andrey Korolyov
On Wed, Sep 3, 2014 at 12:13 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 03, 2014 at 11:43:54AM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 10:10 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 03, 2014 at 02:17:02AM +0400, Andrey Korolyov wrote: On Wed, Sep

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-03 Thread Gonglei (Arei)
From: Gerd Hoffmann [mailto:kra...@redhat.com] Hi, +void set_bootindex(int32_t *bootindex, Visitor *v, + const char *name, Error **errp) +{ +int32_t boot_index; +Error *local_err = NULL; + +visit_type_int32(v, boot_index, name, local_err);

[Qemu-devel] [RFC] vfio: migration to trace points

2014-09-03 Thread Eric Auger
This patch removes all DPRINTF and replace them by trace points. A few DPRINTF used in error cases were transformed into error_report. Signed-off-by: Eric Auger eric.au...@linaro.org --- - __func__ is removed since trace point name does the same job - HWADDR_PRIx were replaced by PRIx64

[Qemu-devel] [PATCH] vhost_net: initialize acked_features to a safe value during ack

2014-09-03 Thread Michael S. Tsirkin
commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to backend_features. As this field is now uninitialized, vhost initialization will sometimes fail. To fix, initialize field in core vhost

Re: [Qemu-devel] [PATCH] vhost_net: initialize acked_features to a safe value during ack

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 02:25:30PM +0800, Jason Wang wrote: commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to backend_features. This will result an unexpected value of acked_features

Re: [Qemu-devel] [PATCH V2] fix: unix sockets created for virtio-serail has insufficient permissions

2014-09-03 Thread Daniel P. Berrange
On Wed, Sep 03, 2014 at 02:18:07PM +0800, Chunyan Liu wrote: Add umask to _virCommand, allow user to set umask to command. Set umask(002) to qemu process to overwrite default umask(022) so that unix sockets created for virtio-serial has expected permissions. Fix problem reported here:

Re: [Qemu-devel] [PATCH v2 2/3] target-sparc: address_mask(), asi_address_mask() are TARGET_SPARC64 only

2014-09-03 Thread Artyom Tarasenko
On Tue, Sep 2, 2014 at 1:52 PM, Peter Maydell peter.mayd...@linaro.org wrote: The address_mask() and asi_address_mask() functions are only used in TARGET_SPARC64 configs, so guard with ifdefs to avoid warnings about unused functions in 32-bit builds. Since the main reason these functions were

Re: [Qemu-devel] [PATCH] vhost_net: initialize acked_features to a safe value during ack

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 11:50:05AM +0300, Michael S. Tsirkin wrote: commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to backend_features. As this field is now uninitialized, vhost

[Qemu-devel] [PATCH] vhost_net: init acked_features to backend_features

2014-09-03 Thread Michael S. Tsirkin
commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to backend_features. As this field is now uninitialized, vhost initialization will sometimes fail. To fix, initialize field in core vhost

Re: [Qemu-devel] [PATCH] vhost_net: initialize acked_features to a safe value during ack

2014-09-03 Thread Andrey Korolyov
On Wed, Sep 3, 2014 at 12:52 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 03, 2014 at 02:25:30PM +0800, Jason Wang wrote: commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to

[Qemu-devel] [PATCH] vhost-scsi: init backend features earlier

2014-09-03 Thread Michael S. Tsirkin
As vhost core uses backend_features during init, clear it earlier to avoid using uninitialized memory. This is harmless since vhost scsi ignores the result anyway, but it avoids valgrind errors. Cc: qemu-sta...@nongnu.org Cc: Jason Wang jasow...@redhat.com Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 12:36:18PM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 12:13 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 03, 2014 at 11:43:54AM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 10:10 AM, Michael S. Tsirkin m...@redhat.com wrote: On Wed,

Re: [Qemu-devel] [RFC PATCH v1 0/4] Handle memory hotplug errors from guest OS.

2014-09-03 Thread tangchen
Hi, Would anyone help to review this patch-set ? I'm not quit sure if this is a suitable way solve this problem. Thanks. On 08/27/2014 04:14 PM, tangchen wrote: Forgot to mention, this patch-set is based on the following patch-set: [RESEND PATCH v3 0/8] QEmu memory hot unplug support.

Re: [Qemu-devel] [PATCH] vhost_net: initialize acked_features to a safe value during ack

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 12:54:03PM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 12:52 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 03, 2014 at 02:25:30PM +0800, Jason Wang wrote: commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and

[Qemu-devel] [PATCH] vhost_net: cleanup recovery

2014-09-03 Thread Michael S. Tsirkin
commit aad4dce934649b3a398396fc2a76f215bb194ea4 vhost_net: start/stop guest notifiers properly changed the order of calls for guest notifiers, but did not recover in the correct (reverse) order. Fix it up. Cc: qemu-sta...@nongnu.org Cc: Andrey Korolyov and...@xdel.ru Cc: Jason Wang

Re: [Qemu-devel] [PATCH] vhost-scsi: init backend features earlier

2014-09-03 Thread Paolo Bonzini
Il 03/09/2014 11:02, Michael S. Tsirkin ha scritto: As vhost core uses backend_features during init, clear it earlier to avoid using uninitialized memory. This is harmless since vhost scsi ignores the result anyway, but it avoids valgrind errors. Cc: qemu-sta...@nongnu.org Cc: Jason Wang

Re: [Qemu-devel] [PATCH] vhost-scsi: init backend features earlier

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 11:08:00AM +0200, Paolo Bonzini wrote: Il 03/09/2014 11:02, Michael S. Tsirkin ha scritto: As vhost core uses backend_features during init, clear it earlier to avoid using uninitialized memory. This is harmless since vhost scsi ignores the result anyway, but it

Re: [Qemu-devel] [RFC] vfio: migration to trace points

2014-09-03 Thread Alexander Graf
On 03.09.14 10:45, Eric Auger wrote: This patch removes all DPRINTF and replace them by trace points. A few DPRINTF used in error cases were transformed into error_report. Signed-off-by: Eric Auger eric.au...@linaro.org --- - __func__ is removed since trace point name does the same

Re: [Qemu-devel] [PATCH] vhost_net: initialize acked_features to a safe value during ack

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 12:54:03PM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 12:52 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Sep 03, 2014 at 02:25:30PM +0800, Jason Wang wrote: commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and

Re: [Qemu-devel] [PATCH] vhost-scsi: init backend features earlier

2014-09-03 Thread Jason Wang
On 09/03/2014 05:02 PM, Michael S. Tsirkin wrote: As vhost core uses backend_features during init, clear it earlier to avoid using uninitialized memory. This is harmless since vhost scsi ignores the result anyway, but it avoids valgrind errors. Cc: qemu-sta...@nongnu.org Cc: Jason Wang

Re: [Qemu-devel] [PATCH] vhost_net: init acked_features to backend_features

2014-09-03 Thread Jason Wang
On 09/03/2014 04:57 PM, Michael S. Tsirkin wrote: commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to backend_features. As this field is now uninitialized, vhost initialization will

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-03 Thread Andrey Korolyov
OK so my patch fixes initialization likely by luck. with crash still in place. Hmm so something is still wrong with the userspace path. Could you please apply this debugging patch on top of all the stack that is now working for you, and see if assert still surfaces? diff --git

Re: [Qemu-devel] [PATCH] vhost_net: cleanup recovery

2014-09-03 Thread Jason Wang
On 09/03/2014 05:10 PM, Michael S. Tsirkin wrote: commit aad4dce934649b3a398396fc2a76f215bb194ea4 vhost_net: start/stop guest notifiers properly changed the order of calls for guest notifiers, but did not recover in the correct (reverse) order. Fix it up. Cc: qemu-sta...@nongnu.org

[Qemu-devel] [PATCH 0/5] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-09-03 Thread Gu Zheng
Gu Zheng (5): acpi/cpu: add cpu hotplug callback function to match hotplug_handler API acpi:ich9: convert cpu hotplug handle to hotplug_handler API acpi:piix4: convert cpu hotplug handle to hotplug_handler API pc: add cpu hotplug handler to PC_MACHINE cpu/hotplug: remove the left

[Qemu-devel] [PATCH 1/5] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-09-03 Thread Gu Zheng
Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/cpu_hotplug.c | 17 + include/hw/acpi/cpu_hotplug.h |3 +++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c index 2ad83a0..92c189b 100644 ---

[Qemu-devel] [PATCH 2/5] acpi:ich9: convert cpu hotplug handle to hotplug_handler API

2014-09-03 Thread Gu Zheng
Convert notifier based hotplug handle to hotplug_handler API. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/ich9.c | 13 ++--- include/hw/acpi/ich9.h |1 - 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index

[Qemu-devel] [PATCH 3/5] acpi:piix4: convert cpu hotplug handle to hotplug_handler API

2014-09-03 Thread Gu Zheng
Convert notifier based hotplug handle to hotplug_handler API. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/piix4.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index b72b34e..6209385 100644 ---

[Qemu-devel] [PATCH 4/5] pc: add cpu hotplug handler to PC_MACHINE

2014-09-03 Thread Gu Zheng
Add cpu hotplug handler to PC_MACHINE, which will perform the acpi cpu hotplug callback via hotplug_handler API. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/i386/pc.c | 26 +- qom/cpu.c|1 - 2 files changed, 25 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH 1/5] s390x/gdb: don't touch the cc if tcg is not enabled

2014-09-03 Thread Alexander Graf
On 02.09.14 09:07, Christian Borntraeger wrote: On 02/09/14 00:39, Alexander Graf wrote: On 29.08.14 15:52, Jens Freimann wrote: From: David Hildenbrand d...@linux.vnet.ibm.com When reading/writing the psw mask, the condition code may only be touched if running on tcg. Why? Shouldn't

[Qemu-devel] [PATCH 5/5] cpu/hotplug: remove the left unused cpu hotplug notifier function

2014-09-03 Thread Gu Zheng
Remove the left unused cpu hotplug notifier function, and rename AcpiCpuHotplug_init -- acpi_cpu_hotplug_init AcpiCpuHotplug_ops -- acpi_cpu_hotplug_ops to match the coding style. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/cpu_hotplug.c | 17 +++--

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 2.1.1, freeze on 2014-09-03

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 01:18:47PM +0400, Andrey Korolyov wrote: OK so my patch fixes initialization likely by luck. with crash still in place. Hmm so something is still wrong with the userspace path. Could you please apply this debugging patch on top of all the stack that is now

Re: [Qemu-devel] [PATCH] vhost_net: init acked_features to backend_features

2014-09-03 Thread Andrey Korolyov
On Wed, Sep 3, 2014 at 1:16 PM, Jason Wang jasow...@redhat.com wrote: On 09/03/2014 04:57 PM, Michael S. Tsirkin wrote: commit 2e6d46d77ed328d34a94688da8371bcbe243479b (vhost: add vhost_get_features and vhost_ack_features) removes the step that initializes the acked_features to

Re: [Qemu-devel] [PATCH] vhost_net: cleanup recovery

2014-09-03 Thread Andrey Korolyov
On Wed, Sep 3, 2014 at 1:20 PM, Jason Wang jasow...@redhat.com wrote: On 09/03/2014 05:10 PM, Michael S. Tsirkin wrote: commit aad4dce934649b3a398396fc2a76f215bb194ea4 vhost_net: start/stop guest notifiers properly changed the order of calls for guest notifiers, but did not recover in

Re: [Qemu-devel] [PATCH 5/5] gdb: provide the name of the architecture in the target.xml

2014-09-03 Thread David Hildenbrand
[ccing Andreas in case he wants to review the QOM aspects of this, though they're fairly straightforward I think.] On 29 August 2014 14:52, Jens Freimann jf...@linux.vnet.ibm.com wrote: From: David Hildenbrand d...@linux.vnet.ibm.com This patch provides the name of the architecture in

[Qemu-devel] [PATCH v2] vhost_net: cleanup recovery

2014-09-03 Thread Michael S. Tsirkin
commit aad4dce934649b3a398396fc2a76f215bb194ea4 vhost_net: start/stop guest notifiers properly changed the order of calls for guest notifiers, but did not recover in the correct (reverse) order. Fix it up. Cc: qemu-sta...@nongnu.org Cc: Andrey Korolyov and...@xdel.ru Cc: Jason Wang

Re: [Qemu-devel] [PATCH 5/5] gdb: provide the name of the architecture in the target.xml

2014-09-03 Thread Edgar E. Iglesias
On Wed, Sep 03, 2014 at 11:37:24AM +0200, David Hildenbrand wrote: [ccing Andreas in case he wants to review the QOM aspects of this, though they're fairly straightforward I think.] On 29 August 2014 14:52, Jens Freimann jf...@linux.vnet.ibm.com wrote: From: David Hildenbrand

[Qemu-devel] [PATCH] qtest: fix qtest log fd should be initialized before qtest chardev

2014-09-03 Thread john.liuli
From: Li Liu john.li...@huawei.com qtest_log_fp should be inited before qemu_chr_add_handlers. If not the log dumped from callback functions may be lost. easy to reproduce it by command: QTEST_LOG=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 gtester -k --verbose -m=quick

[Qemu-devel] [PATCH v2 0/2] actual checks of KVM_CAP_IRQFD and KVM_CAP_IRQFD_RESAMPLE

2014-09-03 Thread Eric Auger
This patch serie replaces direct settings of kvm_irqfds_allowed by actual checks of the KVM_CAP_IRQFD extension. Also A new kvm_resamplefds_enabled() enables to check KVM_CAP_IRQFD_RESAMPLE. in the second patch file the vfio device is the first user of kvm_resamplefds_enabled(). Eric Auger (2):

[Qemu-devel] [PATCH v2 1/2] KVM_CAP_IRQFD and KVM_CAP_IRQFD_RESAMPLE checks

2014-09-03 Thread Eric Auger
Compute kvm_irqfds_allowed by checking the KVM_CAP_IRQFD extension. Remove direct settings in architecture specific files. Add a new kvm_resamplefds_allowed variable, initialized by checking the KVM_CAP_IRQFD_RESAMPLE extension. Add a corresponding kvm_resamplefds_enabled() function.

[Qemu-devel] [PATCH v2 2/2] vfio: use kvm_resamplefds_enabled()

2014-09-03 Thread Eric Auger
Use the kvm_resamplefds_enabled function Signed-off-by: Eric Auger eric.au...@linaro.org --- hw/misc/vfio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 40dcaa6..24f6a3a 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -406,7

[Qemu-devel] [PATCH v3] dump: let dump_error return error info to caller

2014-09-03 Thread zhanghailiang
The second parameter of dump_error is unused, but one purpose of using this function is to report the error info. Use error_set to return the error info to the caller. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- V3: - Drop the '\n' in the message when call dump_error(comment

Re: [Qemu-devel] [PATCH 5/5] gdb: provide the name of the architecture in the target.xml

2014-09-03 Thread David Hildenbrand
On Wed, Sep 03, 2014 at 11:37:24AM +0200, David Hildenbrand wrote: [ccing Andreas in case he wants to review the QOM aspects of this, though they're fairly straightforward I think.] On 29 August 2014 14:52, Jens Freimann jf...@linux.vnet.ibm.com wrote: From: David Hildenbrand

Re: [Qemu-devel] [PATCH 5/5] gdb: provide the name of the architecture in the target.xml

2014-09-03 Thread Edgar E. Iglesias
On Wed, Sep 03, 2014 at 11:59:45AM +0200, David Hildenbrand wrote: On Wed, Sep 03, 2014 at 11:37:24AM +0200, David Hildenbrand wrote: [ccing Andreas in case he wants to review the QOM aspects of this, though they're fairly straightforward I think.] On 29 August 2014 14:52, Jens

Re: [Qemu-devel] [libvirt] [PATCH V2] fix: unix sockets created for virtio-serail has insufficient permissions

2014-09-03 Thread Eric Blake
On 09/03/2014 12:18 AM, Chunyan Liu wrote: s/serail/serial/ in the subject Actually, I'd go with a broader subject line: qemu: ensure sane umask for qemu process Add umask to _virCommand, allow user to set umask to command. Set umask(002) to qemu process to overwrite default umask(022) so

Re: [Qemu-devel] [PATCH v5] block: Introduce null drivers

2014-09-03 Thread Fam Zheng
On Wed, 09/03 12:10, Kevin Wolf wrote: Am 01.09.2014 um 11:22 hat Fam Zheng geschrieben: This is an analogue to Linux null_blk. It can be used for testing or benchmarking block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not

[Qemu-devel] [PATCH v3] vhost_net: cleanup recovery

2014-09-03 Thread Michael S. Tsirkin
commit aad4dce934649b3a398396fc2a76f215bb194ea4 vhost_net: start/stop guest notifiers properly changed the order of calls for guest notifiers, but did not recover in the correct (reverse) order. Fix it up. Cc: qemu-sta...@nongnu.org Cc: Andrey Korolyov and...@xdel.ru Cc: Jason Wang

Re: [Qemu-devel] [PATCH] vhost_net: cleanup recovery

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 01:37:33PM +0400, Andrey Korolyov wrote: On Wed, Sep 3, 2014 at 1:20 PM, Jason Wang jasow...@redhat.com wrote: On 09/03/2014 05:10 PM, Michael S. Tsirkin wrote: commit aad4dce934649b3a398396fc2a76f215bb194ea4 vhost_net: start/stop guest notifiers properly

Re: [Qemu-devel] [PATCH 09/12] spapr_pci: enable basic hotplug operations

2014-09-03 Thread Bharata B Rao
On Tue, Aug 19, 2014 at 5:51 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: This enables hotplug for PHB bridges. Upon hotplug we generate the OF-nodes required by PAPR specification and IEEE 1275-1994 PCI Bus Binding to Open Firmware for the device. We associate the corresponding FDT for

Re: [Qemu-devel] Query regarding bdrv_co_discard

2014-09-03 Thread Stefan Hajnoczi
On Tue, Sep 02, 2014 at 02:09:44AM -0700, Sanjay Kumar2 wrote: Please let me know how to test bdrv_co_discard interface. I mean what steps I need to do on KVM host and inside guest to do end to end testing of this interface. I have implemented a network protocol based block driver and

[Qemu-devel] Serial: possible hang during intensive interaction over the console

2014-09-03 Thread Andrey Korolyov
Given 2.1 and isa-serial output, set as ttyS0 for the guest VM with 9600 baud rate. The test case is quite simple - display as much data as possible over serial console and do not hang the system. While qemu-1.1 works perfectly, with complaining for lost interrupts (known bug for used guest

Re: [Qemu-devel] [PATCH] block/archipelago: Use QEMU atomic builtins

2014-09-03 Thread Stefan Hajnoczi
On Tue, Sep 02, 2014 at 03:41:34PM +0300, Chrysostomos Nanakos wrote: Replace __sync builtins with ones provided by QEMU for atomic operations. Special thanks goes to Paolo Bonzini for his refactoring suggestion in order to use the already existing atomic builtins interface.

Re: [Qemu-devel] [PATCH v2 0/2] qemu-img: src_mode option documentation improvements

2014-09-03 Thread Stefan Hajnoczi
On Tue, Sep 02, 2014 at 11:01:01AM +0100, Stefan Hajnoczi wrote: v2: * Fix backing file files - backing files typo [Fam] These patches clarify and fix the documentation for the recent qemu-img src_mode (-T) option. Stefan Hajnoczi (2): qemu-img: clarify src_cache option documentation

Re: [Qemu-devel] Query regarding bdrv_co_discard

2014-09-03 Thread Sanjay Kumar2
Thanks Stefan. I using the same. Below is the XML. disk type='network' device='disk' driver name='qemu' type='raw' cache='none' io='native' discard='unmap'/ source protocol='oflame' name='/dev/of/vdisk/{a30c3997-0ad8-4495-8549-68431abfa84a}' host name='10.209.133.163'

Re: [Qemu-devel] qemu-system-sparc64 hang (possibly virtio related?) with 2.1

2014-09-03 Thread Stefan Hajnoczi
On Tue, Sep 02, 2014 at 02:12:45PM +0100, Mark Cave-Ayland wrote: Fortunately I can reproduce the issue with a debug-enabled build of qemu-system-sparc64, and I've posted a backtrace obtained during the hung state at http://www.ilande.co.uk/tmp/sparc64-gdb-bt.txt. I can't see anything too

Re: [Qemu-devel] [PATCH] virtio-net: don't run bh on vm stopped

2014-09-03 Thread Stefan Hajnoczi
On Tue, Sep 02, 2014 at 05:26:12PM +0300, Michael S. Tsirkin wrote: commit 783e7706937fe15523b609b545587a028a2bdd03 virtio-net: stop/start bh when appropriate is incomplete: BH might execute within the same main loop iteration but after vmstop, so in theory, we might trigger an

Re: [Qemu-devel] [PATCH v3] vhost_net: cleanup recovery

2014-09-03 Thread Andrey Korolyov
On Wed, Sep 3, 2014 at 2:35 PM, Michael S. Tsirkin m...@redhat.com wrote: commit aad4dce934649b3a398396fc2a76f215bb194ea4 vhost_net: start/stop guest notifiers properly changed the order of calls for guest notifiers, but did not recover in the correct (reverse) order. Fix it up. Cc:

Re: [Qemu-devel] [PATCH v3] vhost_net: cleanup recovery

2014-09-03 Thread Jason Wang
On 09/03/2014 06:35 PM, Michael S. Tsirkin wrote: commit aad4dce934649b3a398396fc2a76f215bb194ea4 vhost_net: start/stop guest notifiers properly changed the order of calls for guest notifiers, but did not recover in the correct (reverse) order. Fix it up. Cc: qemu-sta...@nongnu.org

Re: [Qemu-devel] Question about cow format with hexdump

2014-09-03 Thread Stefan Hajnoczi
On Wed, Sep 03, 2014 at 01:27:00PM +0800, shhuiw wrote: I'm reading the source code of cow.c: https://github.com/qemu/qemu/blob/master/block/cow.c and try to understand the format better. The 'cow' format is an old format that is rarely used. It's not a good example. qcow2 is actively

Re: [Qemu-devel] Fw:Re:What does COW mean?

2014-09-03 Thread Stefan Hajnoczi
On Wed, Sep 03, 2014 at 12:47:44PM +0800, shhuiw wrote: At 2014-09-02 04:33:50, shhuiw shh...@163.com wrote: Hi, I'm new to qemu community, and I'm trying the COW image format (old but simple:-). I have read through its source code, and didn't find anything about 'copy on write'. I

Re: [Qemu-devel] [PATCH v5] block: Introduce null drivers

2014-09-03 Thread Kevin Wolf
Am 01.09.2014 um 11:22 hat Fam Zheng geschrieben: This is an analogue to Linux null_blk. It can be used for testing or benchmarking block device emulation and general block layer functionalities such as coroutines and throttling, where disk IO is not necessary or wanted. Use null-aio:// for

Re: [Qemu-devel] [PATCH v3] block: Introduce null driver

2014-09-03 Thread Kevin Wolf
Am 29.08.2014 um 02:55 hat Fam Zheng geschrieben: On Thu, 08/28 16:23, Eric Blake wrote: On 08/27/2014 11:53 PM, Fam Zheng wrote: This is an analogue to Linux null_blk. It can be used for testing block device emulation and general block layer functionalities such as coroutines and

Re: [Qemu-devel] [PULL 00/13] pci, pc fixes, features

2014-09-03 Thread Michael S. Tsirkin
On Tue, Sep 02, 2014 at 06:07:01PM +0300, Michael S. Tsirkin wrote: The following changes since commit 187de915e8d06aaf82be206aebc551c82bf0670c: pcie: fix trailing whitespace (2014-08-25 00:16:07 +0200) are available in the git repository at:

Re: [Qemu-devel] [PATCH v3] vhost_net: cleanup recovery

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 06:52:46PM +0800, Jason Wang wrote: On 09/03/2014 06:35 PM, Michael S. Tsirkin wrote: commit aad4dce934649b3a398396fc2a76f215bb194ea4 vhost_net: start/stop guest notifiers properly changed the order of calls for guest notifiers, but did not recover in the

Re: [Qemu-devel] [PATCH] virtio-net: don't run bh on vm stopped

2014-09-03 Thread Michael S. Tsirkin
On Wed, Sep 03, 2014 at 11:45:57AM +0100, Stefan Hajnoczi wrote: On Tue, Sep 02, 2014 at 05:26:12PM +0300, Michael S. Tsirkin wrote: commit 783e7706937fe15523b609b545587a028a2bdd03 virtio-net: stop/start bh when appropriate is incomplete: BH might execute within the same main loop

[Qemu-devel] [PATCH v4 00/20] block: Asynchronous request cancellation

2014-09-03 Thread Fam Zheng
v4: Drop AIOCBInfo.cancel. This series adds a new block layer API: void bdrv_aio_cancel_async(BlockDriverAIOCB *acb); And use it to emulate bdrv_aio_cancel. The function is similar to bdrv_aio_cancel in that it cancels an AIO request, but different that it doesn't block until the request is

[Qemu-devel] [PATCH v4 03/20] block: Drop bdrv_em_co_aiocb_info.cancel

2014-09-03 Thread Fam Zheng
Also drop the now unused -done pointer. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 21 - 1 file changed, 21 deletions(-) diff --git a/block.c b/block.c index 2dfd1be..4aa1bd7 100644 --- a/block.c +++ b/block.c @@ -4757,22 +4757,8 @@ typedef struct

[Qemu-devel] [PATCH v4 07/20] dma: Check iov pointer before unmap memory

2014-09-03 Thread Fam Zheng
Not all the iov elements are always valid. Signed-off-by: Fam Zheng f...@redhat.com --- dma-helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dma-helpers.c b/dma-helpers.c index 499b52b..3655d88 100644 --- a/dma-helpers.c +++ b/dma-helpers.c @@ -105,6 +105,9 @@ static void

[Qemu-devel] [PATCH v4 02/20] block: Add bdrv_aio_cancel_async

2014-09-03 Thread Fam Zheng
This is the async version of bdrv_aio_cancel, which doesn't block the caller. It guarantees that the cb is called either before returning or some time later. bdrv_aio_cancel can base on bdrv_aio_cancel_async, later we can convert all .io_cancel implementations to .io_cancel_async, and the

[Qemu-devel] [PATCH v4 01/20] block: Add refcnt in BlockDriverAIOCB

2014-09-03 Thread Fam Zheng
This will be useful in synchronous cancel emulation with bdrv_aio_cancel_async. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 12 +++- include/block/aio.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index cb670fd..78d68cb

[Qemu-devel] [PATCH v4 06/20] linux-aio: Convert laio_aiocb_info.cancel to .cancel_async

2014-09-03 Thread Fam Zheng
Just call io_cancel (2), if it fails, it means the request is not canceled, so the event loop will eventually call qemu_laio_process_completion. In qemu_laio_process_completion, change to call the cb unconditionally. It is required by bdrv_aio_cancel_async. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v4 15/20] quorum: Convert quorum_aiocb_info.cancel to .cancel_async

2014-09-03 Thread Fam Zheng
Before, we cancel all the child requests with bdrv_aio_cancel, then free the acb.. Now we just kick off asynchronous cancellation of child requests and return, we know quorum_aio_cb will be called later, so in the end quorum_aio_finalize will take care of calling the caller's cb. Signed-off-by:

[Qemu-devel] [PATCH v4 10/20] archipelago: Drop archipelago_aiocb_info.cancel

2014-09-03 Thread Fam Zheng
The cancelled flag is no longer useful. Later the request will complete as before, and cb will be called. Signed-off-by: Fam Zheng f...@redhat.com --- block/archipelago.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/block/archipelago.c

[Qemu-devel] [PATCH v4 09/20] iscsi: Convert iscsi_aiocb_info.cancel to .cancel_async

2014-09-03 Thread Fam Zheng
Also drop the unused field canceled. Signed-off-by: Fam Zheng f...@redhat.com --- block/iscsi.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 3e19202..a0aca5f 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -88,7

  1   2   3   >