[Qemu-devel] [PULL 0/2] vnc patch queue

2014-09-17 Thread Gerd Hoffmann
Hi, Two little vnc patches. please pull, Gerd The following changes since commit e4d50d47a9eb15f42bdd561803a29a4d7c3eb8ec: qemu-char: Rename register_char_driver_qapi() to register_char_driver() (2014-09-16 23:36:32 +0100) are available in the git repository at: git://git.kraxel.org/

[Qemu-devel] [PATCH] usb-storage: fix possible memory leak and missing error message

2014-09-17 Thread arei.gonglei
From: Gonglei When scsi_bus_legacy_add_drive() return NULL, meanwhile err will be not NULL, which will casue memory leak and missing error message. Signed-off-by: Gonglei --- hw/usb/dev-storage.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/usb/dev-storage

Re: [Qemu-devel] [PATCH v2] slirp: udp: fix NULL pointer dereference because of uninitialized socket

2014-09-17 Thread Jan Kiszka
On 2014-09-18 08:35, Petr Matousek wrote: > When guest sends udp packet with source port and source addr 0, > uninitialized socket is picked up when looking for matching and already > created udp sockets, and later passed to sosendto() where NULL pointer > dereference is hit during so->slirp->vnetw

Re: [Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation

2014-09-17 Thread Markus Armbruster
Jeff Cody writes: > On Wed, Sep 17, 2014 at 08:33:10AM +0200, Markus Armbruster wrote: >> Jeff Cody writes: >> >> > In vhdx_create_metadata(), we allocate 40 bytes to entry_buffer for >> > the various metadata table entries. However, we write out 64kB from >> > that buffer into the new file.

[Qemu-devel] [PULL 2/2] vnc-tls: Clean up dead store in vnc_set_x509_credential()

2014-09-17 Thread Gerd Hoffmann
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- ui/vnc-tls.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c index 6392326..0f59f9b 100644 --- a/ui/vnc-tls.c +++ b/ui/vnc-tls.c @@ -444,8 +444,6 @@ static int vnc_set_x50

[Qemu-devel] [PATCH v2] slirp: udp: fix NULL pointer dereference because of uninitialized socket

2014-09-17 Thread Petr Matousek
When guest sends udp packet with source port and source addr 0, uninitialized socket is picked up when looking for matching and already created udp sockets, and later passed to sosendto() where NULL pointer dereference is hit during so->slirp->vnetwork_mask.s_addr access. Fix this by checking that

[Qemu-devel] [PULL 1/2] ui/vnc: set TCP_NODELAY

2014-09-17 Thread Gerd Hoffmann
From: Peter Lieven we currently have the Nagle algorithm enabled for all outgoing VNC updates. This may delay sensitive updates as mouse movements or typing in the console. As we currently prepare all data in a buffer and then send as much as we can disabling the Nagle algorithm should not cause

[Qemu-devel] 答复: [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Li, Guang
> -邮件原件- > 发件人: qemu-devel-bounces+lig.fnst=cn.fujitsu@nongnu.org > [mailto:qemu-devel-bounces+lig.fnst=cn.fujitsu@nongnu.org] 代表 Peter > Maydell > 发送时间: 2014年9月18日 0:09 > 收件人: Gerd Hoffmann > 抄送: Stefano Stabellini; Markus Armbruster; qemu-devel; > xen-de...@lists.xen.org; Anthony

Re: [Qemu-devel] vhost-user: VHOST_SET_MEM_TABLE, VHOST_SET_VRING_CALL need a reply?

2014-09-17 Thread Michael S. Tsirkin
On Thu, Sep 18, 2014 at 10:39:00AM +0800, Linhaifeng wrote: > > > On 2014/9/17 17:56, Michael S. Tsirkin wrote: > > On Wed, Sep 17, 2014 at 05:39:04PM +0800, Linhaifeng wrote: > >> I think maybe is not need for the backend to wait for response. > >> > >> There is another way.vhost-user send "VHOS

Re: [Qemu-devel] vhost-user: VHOST_SET_MEM_TABLE, VHOST_SET_VRING_CALL need a reply?

2014-09-17 Thread Michael S. Tsirkin
On Thu, Sep 18, 2014 at 08:45:37AM +0800, Linhaifeng wrote: > > > On 2014/9/17 17:56, Michael S. Tsirkin wrote: > > On Wed, Sep 17, 2014 at 05:39:04PM +0800, Linhaifeng wrote: > >> I think maybe is not need for the backend to wait for response. > >> > >> There is another way.vhost-user send "VHOS

[Qemu-devel] [PATCH] exec.c: fix setting 1-byte-long watchpoints

2014-09-17 Thread Max Filippov
With commit 05068c0dfb5b 'exec.c: Relax restrictions on watchpoint length and alignment' it's no longer possible to set 1-byte-long watchpoint because of incorrect address range check. Fix that by changing condition that checks for address wraparound. Signed-off-by: Max Filippov --- exec.c | 2 +

Re: [Qemu-devel] [PULL 07/23] exec.c: Relax restrictions on watchpoint length and alignment

2014-09-17 Thread Peter Maydell
On 17 September 2014 21:48, Max Filippov wrote: > Hi Peter, > > On Fri, Sep 12, 2014 at 6:23 AM, Peter Maydell > wrote: >> The current implementation of watchpoints requires that they >> have a power of 2 length which is not greater than TARGET_PAGE_SIZE >> and that their address is a multiple o

Re: [Qemu-devel] [PULL 07/23] exec.c: Relax restrictions on watchpoint length and alignment

2014-09-17 Thread Max Filippov
Hi Peter, On Fri, Sep 12, 2014 at 6:23 AM, Peter Maydell wrote: > The current implementation of watchpoints requires that they > have a power of 2 length which is not greater than TARGET_PAGE_SIZE > and that their address is a multiple of their length. Watchpoints > on ARM don't fit these restric

[Qemu-devel] [PATCH] qga: Fix possible freed memory accessing

2014-09-17 Thread zhanghailiang
If readdir_r fails, error_setg_errno will reference the freed pointer *dirpath*. Signed-off-by: zhanghailiang --- qga/commands-posix.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 7eed7f4..3082eae 100644 --- a/qg

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Alexey Kardashevskiy
On 09/18/2014 01:07 AM, Stefan Hajnoczi wrote: > On Wed, Sep 17, 2014 at 2:44 PM, Alexey Kardashevskiy wrote: >> On 09/17/2014 07:25 PM, Paolo Bonzini wrote: >> btw any better idea of a hack to try? Testers are pushing me - they want to >> upgrade the broken setup and I am blocking them :) Thanks!

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-17 Thread Gonglei (Arei)
> but switching all usb over to realize is a bigger project indeed. > Hi, Gerd I want to do this job which converting USB devices from init to realize. So all the implementations can use error_setg instead of error_report for reporting error. Include those devices as below: name "usb-host", bu

Re: [Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Nanakos Chrysostomos
> On 17 Σεπ 2014, at 4:51 μ.μ., Andreas Färber wrote: > > Hi, > > As a general comment, when sending a cover letter for a single patch, > please use --numbered, so that the cover letter becomes [PATCH 0/1] and > the patch [PATCH 1/1] so they don't end up with identical subjects. > My fault.

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-09-17 Thread Fam Zheng
On Mon, 09/15 15:17, Benoît Canet wrote: > On Fri, Sep 12, 2014 at 11:48:33AM +0800, Fam Zheng wrote: > > On Tue, 09/09 14:28, Benoît Canet wrote: > > > On Tue, Sep 09, 2014 at 01:56:46PM +0200, Kevin Wolf wrote: > > > > Am 22.08.2014 um 18:11 hat Benoît Canet geschrieben: > > > > > Since the block

Re: [Qemu-devel] vhost-user: VHOST_SET_MEM_TABLE, VHOST_SET_VRING_CALL need a reply?

2014-09-17 Thread Linhaifeng
On 2014/9/17 17:56, Michael S. Tsirkin wrote: > On Wed, Sep 17, 2014 at 05:39:04PM +0800, Linhaifeng wrote: >> I think maybe is not need for the backend to wait for response. >> >> There is another way.vhost-user send "VHOST_GET_MEM_TABLE" to qemu then qemu >> send VHOST_SET_MEM_TABLE to update

[Qemu-devel] [PATCH 3/3] virtio-scsi: Handle TMF request cancellation asynchronously

2014-09-17 Thread Fam Zheng
For VIRTIO_SCSI_T_TMF_ABORT_TASK and VIRTIO_SCSI_T_TMF_ABORT_TASK_SET, use scsi_req_cancel_async to start the cancellation. In virtio_scsi_handle_ctrl, wait for virtio_scsi_cancel_dep_complete before completing the request. Signed-off-by: Fam Zheng --- hw/scsi/virtio-scsi.c | 45

[Qemu-devel] [PATCH 2/3] scsi: Introduce scsi_req_cancel_async

2014-09-17 Thread Fam Zheng
Devices can call this function to start an asynchronous cancellation. The bus->info->cancel will be called later. Two fields are added to SCSIRequest to respectively keep track of: 1) The list of (TMF) requests that are waiting for this request to be canceled. 2) The number of (IO) request

[Qemu-devel] [PATCH 0/3] virtio-scsi: Asynchronous cancellation

2014-09-17 Thread Fam Zheng
This series changes VIRTIO_SCSI_T_TMF_ABORT_TASK and VIRTIO_SCSI_T_TMF_ABORT_TASK_SET emulation to asynchronous by making use of bdrv_aio_cancel_async. Before, when guest cancels a SCSI command, we use a nested poll loop to wait until the request is cancelled or completed before returning. This bl

[Qemu-devel] [PATCH 1/3] scsi-bus: Unify request unref in scsi_req_cancel

2014-09-17 Thread Fam Zheng
Before, scsi_req_cancel will take ownership of the canceled request and unref it. This is because we didn't know if AIO CB will be called or not during the cancelling, so we set the io_canceled flag before calling it, and skip to unref in the potentially called callbacks, which is not very nice. N

Re: [Qemu-devel] [PATCH] virtio-balloon: Fix ballooning not working correctly when hotplug memory

2014-09-17 Thread zhanghailiang
Hi, Ping... Is anyone concerned about this patch? Is this a bug? Thanks, zhanghailiang On 2014/9/15 20:29, zhanghailiang wrote: When do memory balloon, it references the ram_size as the real ram size of VM, But here ram_size is not include the hotplugged memory, and the result will be confuse

Re: [Qemu-devel] [PATCH 1/2] pc-dimm: No numa option shouldn't break hotplug memory feature

2014-09-17 Thread Hu Tao
On Wed, Sep 17, 2014 at 02:19:05PM +0400, Andrey Korolyov wrote: > On Wed, Sep 17, 2014 at 2:00 PM, Tang Chen wrote: > > Add Andrey Korolyov > > > > On 09/17/2014 04:32 PM, Hu Tao wrote: > >> > >> On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote: > >>> > >>> If we do not configure nu

Re: [Qemu-devel] vhost-user: VHOST_SET_MEM_TABLE, VHOST_SET_VRING_CALL need a reply?

2014-09-17 Thread Linhaifeng
On 2014/9/17 17:56, Michael S. Tsirkin wrote: > On Wed, Sep 17, 2014 at 05:39:04PM +0800, Linhaifeng wrote: >> I think maybe is not need for the backend to wait for response. >> >> There is another way.vhost-user send "VHOST_GET_MEM_TABLE" to qemu then qemu >> send VHOST_SET_MEM_TABLE to update

Re: [Qemu-devel] [PATCH v2 1/4] qapi: add visit_start_union and visit_end_union

2014-09-17 Thread Eric Blake
On 09/17/2014 03:32 PM, Michael Roth wrote: > In some cases an input visitor might bail out on filling out a > struct for various reasons, such as missing fields when running > in strict mode. In the case of a QAPI Union type, this may lead > to cases where the .kind field which encodes the union t

Re: [Qemu-devel] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator

2014-09-17 Thread Eric Blake
On 09/17/2014 03:32 PM, Michael Roth wrote: > This more of an exercise of the dealloc visitor, where it may s/This more/This is more/ > erroneously use an uninitialized discriminator field as indication > that union fields corresponding to that discriminator field/type are > present, which can le

Re: [Qemu-devel] [PATCH v2 2/4] qapi: dealloc visitor, implement visit_start_union

2014-09-17 Thread Eric Blake
On 09/17/2014 03:32 PM, Michael Roth wrote: > If the .data field of a QAPI Union is NULL, we don't need to free > any of the union fields. > > Make use of the new visit_start_union interface to access this > information and instruct the generated code to not visit these > fields when this occurs.

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-17 Thread Greg Bellows
Reviewed-by: Greg Bellows On 12 September 2014 21:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h | 1 + > target-arm/helper-a64.c| 1 + > target-arm/helper.c| 6 ++ > target-arm/helper.h

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Ard Biesheuvel
On 17 September 2014 10:14, Andreas Färber wrote: > Am 17.09.2014 um 18:47 schrieb Peter Maydell: >> On 17 September 2014 09:40, Andreas Färber wrote: >>> We avoided that by not using DeviceClass::reset but CPUClass::reset. >>> It's a question of assuring appropriate reset ordering between CPU an

Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC insn

2014-09-17 Thread Greg Bellows
Reviewed-by: Greg Bellows On 12 September 2014 21:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h | 1 + > target-arm/helper-a64.c| 1 + > target-arm/helper.c| 28 +++- > ta

[Qemu-devel] [PATCH v2 1/4] qapi: add visit_start_union and visit_end_union

2014-09-17 Thread Michael Roth
In some cases an input visitor might bail out on filling out a struct for various reasons, such as missing fields when running in strict mode. In the case of a QAPI Union type, this may lead to cases where the .kind field which encodes the union type is uninitialized. Subsequently, other visitors,

[Qemu-devel] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator

2014-09-17 Thread Michael Roth
This more of an exercise of the dealloc visitor, where it may erroneously use an uninitialized discriminator field as indication that union fields corresponding to that discriminator field/type are present, which can lead to attempts to free random chunks of heap memory. Cc: qemu-sta...@nongnu.org

[Qemu-devel] [PATCH v2 2/4] qapi: dealloc visitor, implement visit_start_union

2014-09-17 Thread Michael Roth
If the .data field of a QAPI Union is NULL, we don't need to free any of the union fields. Make use of the new visit_start_union interface to access this information and instruct the generated code to not visit these fields when this occurs. Cc: qemu-sta...@nongnu.org Reported-by: Fam Zheng Sugg

[Qemu-devel] [PATCH v2 4/4] qemu-iotests: Test missing "driver" key for blockdev-add

2014-09-17 Thread Michael Roth
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Cc: qemu-sta...@nongnu.org Signed-off-by: Michael Roth --- tests/qemu-iotests/087 | 17 + tests/qemu-iotests/087.out | 13 + 2 files changed, 30 insertions(+) diff --git a/tests/qemu-iotests/087

[Qemu-devel] [PATCH v2 0/4] qapi: fix crash in dealloc visitor for union types

2014-09-17 Thread Michael Roth
This series introduces visit_start_union and visit_end_union as a way of allowing visitors to trigger generated code to bail out on visiting union fields if the visitor implementation deems doing so to be unsafe. See patch 1 for the circumstances that cause the segfault in the dealloc visitor. Th

[Qemu-devel] [Bug 1370585] [NEW] qemu-img cannot create fixed vhdx

2014-09-17 Thread Adelina Tuvenie
Public bug reported: When trying to create a fixed vhdx image, qemu-img fails with the following error: qemu-img: test.vhdx: Could not create image: Cannot allocate memory This happens because of a incorrect check in vhdx.c ** Affects: qemu Importance: Undecided Status: N

[Qemu-devel] (no subject)

2014-09-17 Thread Priyanka Ranjan
Hello Experts, I am using CentOS 6.5. I am getting an issue with libguestfs (qemu-kvm) # /usr/libexec/qemu-kvm -nographic -machine accel=kvm:tcg -device \? open /dev/kvm: No such file or directory failed to initialize KVM: Operation not permitted Back to tcg accelerator. Could not allocate

Re: [Qemu-devel] Microcheckpointing: Memory-VCPU / Disk State consistency

2014-09-17 Thread Walid Nouri
Thank you for your Time and the detailed answer! I have needed some time to work through your answer ;-) What MC needs is a block device agnostic, controlled and asynchronous approach for replicating the contents of block devices and its state changes to the secondary VM while the primary VM is

[Qemu-devel] qemu process stuck in Rl state

2014-09-17 Thread Andrey Korolyov
Hello, I`ve faced an issue with qemu VMs with very large uptime spans - half of year or so. They are hanging in running state forever and are not killable in any imaginable fashion. Tried to freeze it via freezer cg without any luck. VM itself went unresponsive with zero cpu consumption after reac

Re: [Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation

2014-09-17 Thread Jeff Cody
On Wed, Sep 17, 2014 at 08:33:10AM +0200, Markus Armbruster wrote: > Jeff Cody writes: > > > In vhdx_create_metadata(), we allocate 40 bytes to entry_buffer for > > the various metadata table entries. However, we write out 64kB from > > that buffer into the new file. Only write out the correct

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-17 Thread Peter Maydell
On 17 September 2014 12:25, Paolo Bonzini wrote: > Il 17/09/2014 18:12, Peter Maydell ha scritto: >> Does anybody care to try to float the idea of an API >> extension to the binfmt stuff to pass us the argv0 >> out-of-band (eg via an elf auxv vector entry if some >> new binfmt flag is passed)? Tha

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-17 Thread Paolo Bonzini
Il 17/09/2014 18:12, Peter Maydell ha scritto: > On 17 September 2014 08:34, Joakim Tjernlund > wrote: >> Did this go anywhere ? Is there a solution in sight? > > I was hoping for more distro input, but absent that: > > Does anybody care to try to float the idea of an API > extension to the binf

[Qemu-devel] [PATCH] vmxcap: Update according to SDM of September 2014

2014-09-17 Thread Adrian-Ken Rueegsegger
This adds reporting of RDSEED exiting and XSAVES/XRSTORS #UD and fixes the range of VMCS revision as well as some typos. Signed-off-by: Adrian-Ken Rueegsegger --- scripts/kvm/vmxcap | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/

Re: [Qemu-devel] [PATCH 1/4] .travis.yml: add more linux-user to the build matrix

2014-09-17 Thread Alex Bennée
Alex Bennée writes: > At the same time I've grouped the $ARCH-linux-user and $ARCH-softmmu > builds together (hoping FS cache helps) and grouped all $ARCH-softmmu > only builds into one target. This reduces the build matrix slightly > which will hopefully help with build times. Pinging Alex who

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-09-17 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 07:21:09PM +0200, Greg Kurz wrote: > On Sun, 14 Sep 2014 21:30:36 +0300 > "Michael S. Tsirkin" wrote: > > > Current support for bus master (clearing OK bit) > > together with the need to support guests which do not > > enable PCI bus mastering, leads to extra state in > >

Re: [Qemu-devel] [PATCH] virtio-pci: fix migration for pci bus master

2014-09-17 Thread Greg Kurz
On Sun, 14 Sep 2014 21:30:36 +0300 "Michael S. Tsirkin" wrote: > Current support for bus master (clearing OK bit) > together with the need to support guests which do not > enable PCI bus mastering, leads to extra state in > VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust > in case of cross

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Andreas Färber
Am 17.09.2014 um 18:47 schrieb Peter Maydell: > On 17 September 2014 09:40, Andreas Färber wrote: >> We avoided that by not using DeviceClass::reset but CPUClass::reset. >> It's a question of assuring appropriate reset ordering between CPU and >> devices. PowerPC needed a special reset order via h

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Andreas Färber
Am 17.09.2014 um 18:17 schrieb Peter Maydell: > On 17 September 2014 08:55, Andreas Färber wrote: >> IIRC each machine is responsible for registering a reset hook that calls >> - in most cases - cpu_reset(). >> >> The thing to look out for here is, does any machine already register a >> reset hook

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Peter Maydell
On 17 September 2014 09:40, Andreas Färber wrote: > We avoided that by not using DeviceClass::reset but CPUClass::reset. > It's a question of assuring appropriate reset ordering between CPU and > devices. PowerPC needed a special reset order via hook in (what is now) > MachineClass. > So while I

Re: [Qemu-devel] [PATCH v4 2/8] ahci: MSI capability should be at 0x80, not 0x50.

2014-09-17 Thread John Snow
On 09/17/2014 12:42 PM, Michael S. Tsirkin wrote: On Wed, Sep 17, 2014 at 05:54:28PM +0200, Jan Kiszka wrote: On 2014-08-21 19:44, John Snow wrote: In the Intel ICH9 data sheet, the MSI capability offset in the PCI configuration space for ICH9 AHCI devices is specified to be 0x80. Further, t

Re: [Qemu-devel] [Xen-devel] [PATCH v2 3/5] xenfb: Add option to use a grant ref for shared page

2014-09-17 Thread Ian Campbell
On Wed, 2014-09-17 at 15:30 +0100, Owen smith wrote: > Adds "page-gref" to the frontend location to specify the grant xen.git/xen/include/public/io/fbif.h is a bit sparse in terms of docs right now, but could I encourage you to add the new keys which you are implementing in this series to it pleas

Re: [Qemu-devel] [PATCH v4 2/8] ahci: MSI capability should be at 0x80, not 0x50.

2014-09-17 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 05:54:28PM +0200, Jan Kiszka wrote: > On 2014-08-21 19:44, John Snow wrote: > > In the Intel ICH9 data sheet, the MSI capability offset > > in the PCI configuration space for ICH9 AHCI devices is > > specified to be 0x80. > > > > Further, the PCI capability pointer should a

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Peter Maydell
On 17 September 2014 08:55, Andreas Färber wrote: > IIRC each machine is responsible for registering a reset hook that calls > - in most cases - cpu_reset(). > > The thing to look out for here is, does any machine already register a > reset hook and would reset twice with this patch? Probably not

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-17 Thread Peter Maydell
On 17 September 2014 08:34, Joakim Tjernlund wrote: > Did this go anywhere ? Is there a solution in sight? I was hoping for more distro input, but absent that: Does anybody care to try to float the idea of an API extension to the binfmt stuff to pass us the argv0 out-of-band (eg via an elf auxv

Re: [Qemu-devel] [PATCH] vnc: add additional key up event before repeated key down

2014-09-17 Thread Peter Maydell
On 17 September 2014 04:24, Gerd Hoffmann wrote: >> Which brings us to the other half of this: what does our >> UI layer specify should be the behaviour for key repeat? >> Gerd, can you clarify what the common input layer's expectation >> is here? Should UI front ends call qemu_input_event_send_ke

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-17 Thread Marc Marí
El Tue, 16 Sep 2014 00:17:57 +0200 Marc Marí escribió: > > This means agressive timeout is not the problem. The problem is the > ISR not being raised at all after sending a read or write request. > > If this is the log of the failing case: > https://travis-ci.org/qemu/qemu/builds/35118444 > (fir

Re: [Qemu-devel] [PATCH] slirp: udp: fix NULL pointer dereference because of uninitialized socket

2014-09-17 Thread Jan Kiszka
On 2014-09-17 13:41, Petr Matousek wrote: > When guest sends udp packet with source port and source addr 0, > uninitialized socket is picked up when looking for matching and already > created udp sockets, and later passed to sosendto() where NULL pointer > dereference is hit during so->slirp->vnetw

Re: [Qemu-devel] [PATCH 03/14] target-ppc: use separate indices for various translation modes

2014-09-17 Thread Richard Henderson
On 09/17/2014 08:50 AM, Paolo Bonzini wrote: >> > And if we choose to do something like this, this is where I'd prefer a >> > define >> > in the relevant tcg-target.h. Because you've missed ia64 and s390 that >> > have >> > positive offsets larger than 64k (21 and 19 bits, respectively). > Right

Re: [Qemu-devel] [PATCH v4 2/8] ahci: MSI capability should be at 0x80, not 0x50.

2014-09-17 Thread Jan Kiszka
On 2014-08-21 19:44, John Snow wrote: > In the Intel ICH9 data sheet, the MSI capability offset > in the PCI configuration space for ICH9 AHCI devices is > specified to be 0x80. > > Further, the PCI capability pointer should always point > to 0x80 in ICH9 devices, despite the fact that AHCI 1.3 >

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Andreas Färber
Am 17.09.2014 um 17:50 schrieb Ard Biesheuvel: > On 9 September 2014 11:14, Peter Maydell wrote: >> On 5 September 2014 16:15, Ard Biesheuvel wrote: >>> When booting with -bios or -pflash rather than -kernel, we need to make sure >>> reset handlers are registered. >>> >>> Signed-off-by: Ard Biesh

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Paolo Bonzini
Il 17/09/2014 17:04, Stefan Hajnoczi ha scritto: > On Wed, Sep 17, 2014 at 10:25 AM, Paolo Bonzini wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: >>> I think the fundamental problem here is that the mirror block job >>> on the sour

Re: [Qemu-devel] [PATCH 4/6] hw/arm/boot: register cpu reset handlers if using -bios

2014-09-17 Thread Ard Biesheuvel
On 9 September 2014 11:14, Peter Maydell wrote: > On 5 September 2014 16:15, Ard Biesheuvel wrote: >> When booting with -bios or -pflash rather than -kernel, we need to make sure >> reset handlers are registered. >> >> Signed-off-by: Ard Biesheuvel >> --- >> hw/arm/boot.c | 4 >> 1 file ch

Re: [Qemu-devel] [PATCH 03/14] target-ppc: use separate indices for various translation modes

2014-09-17 Thread Paolo Bonzini
Il 17/09/2014 17:33, Richard Henderson ha scritto: > Hum. Well, it's not that all the tlbs together that must be less than 64k, > it's the addend of the first entry of the last tlb that must be within 64k of > the start of env. Nit picking, but perhaps we can word the comment better. Indeed. >

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-17 Thread Greg Bellows
Reviewed-by: Greg Bellows On 12 September 2014 21:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 19 ++- > target-arm/helper.c | 35 +-- > 2 files changed, 51 insertio

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-09-17 Thread Joakim Tjernlund
Riku Voipio wrote on 2014/09/01 11:51:15: > > On Mon, Sep 01, 2014 at 10:12:18AM +0100, Peter Maydell wrote: > > On 1 September 2014 09:51, Paolo Bonzini wrote: > > > Il 29/08/2014 20:01, Peter Maydell ha scritto: > > >> [cc'ing MJT for more distro opinion since I think fundamentally > > >> the

Re: [Qemu-devel] [PATCH 03/14] target-ppc: use separate indices for various translation modes

2014-09-17 Thread Richard Henderson
On 09/17/2014 01:53 AM, Paolo Bonzini wrote: > +/* All the TLBs together must be smaller than 64k on RISC machines */ > +#if !defined(__i386__) && !defined(__x86_64__) && !defined(__aarch64__) \ > +&& !defined(__sparc__) && !defined(CONFIG_TCG_INTERPRETER) > +#define CPU_TLB_BITS (NB_MMU_MODES

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-17 Thread Richard Henderson
On 09/17/2014 04:54 AM, Andreas Färber wrote: > I am fine with adding such hooks, but please let's use a better, active > name. CPUClass is the struct name and cpu-exec is a file name; the hook > should say what it's doing, not where the code (used to) live(s). Just > exec_enter/exec_exit possibly?

Re: [Qemu-devel] [PATCH v2] target-i386: update fp status fix

2014-09-17 Thread Richard Henderson
On 09/17/2014 02:16 AM, Paolo Bonzini wrote: > > Looks good. Richard, are you going to pick it up or shall I? Go ahead. r~

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Eric Blake
[adding libvirt list] On 09/17/2014 09:04 AM, Stefan Hajnoczi wrote: > On Wed, Sep 17, 2014 at 10:25 AM, Paolo Bonzini wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: >>> I think the fundamental problem here is that the mirror bloc

Re: [Qemu-devel] [PATCH v4 0/8] AHCI test suite framework

2014-09-17 Thread Stefan Hajnoczi
On Thu, Aug 21, 2014 at 01:44:31PM -0400, John Snow wrote: > This submission does not re-send earlier patches in the series which > have already been merged into QEMU, which were primarily staging > fixes and small tweaks to support this smaller set of patches. > > This patch series introduces a n

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Stefan Hajnoczi
On Wed, Sep 17, 2014 at 2:44 PM, Alexey Kardashevskiy wrote: > On 09/17/2014 07:25 PM, Paolo Bonzini wrote: > btw any better idea of a hack to try? Testers are pushing me - they want to > upgrade the broken setup and I am blocking them :) Thanks! Paolo's qemu_co_mutex_lock(&s->lock) idea in qcow2

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Stefan Hajnoczi
On Wed, Sep 17, 2014 at 10:25 AM, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: >> I think the fundamental problem here is that the mirror block job >> on the source host does not synchronize with live migration. >> >> R

[Qemu-devel] [PATCH v2 5/5] xenfb: Add "feature-no-console"

2014-09-17 Thread Owen smith
Added feature to allow vkbd connection without waiting for vfb device. Windows PV frontend requires connection without a vfb device, Ubuntu HVM would not start correctly without the wait for vfb device. backend: feature-no-console Value: 0/1 (boolean) Default Value: 0 A value of "1" i

[Qemu-devel] [PATCH v2 0/5] xenfb: Add support for Windows PV frontend

2014-09-17 Thread Owen smith
This patch series contains improvments for the Xen vkbd backend to support a Windows PV frontend mouse and keyboard. This allows VNC connections to have an absolute pointer without the USB tabled device enabled, and any unneccessary polling associated with the USB devices. Changes over v1: * Spl

[Qemu-devel] [PATCH v2 3/5] xenfb: Add option to use a grant ref for shared page

2014-09-17 Thread Owen smith
Adds "page-gref" to the frontend location to specify the grant reference of the shared page. Adds the DEVOPS_FLAG_NEED_GNTDEV to both vfb and vkbd device flags. "page-ref" is checked first to avoid breaking existing frontends. "page-gref" Value: Grant reference to use to map the shared ri

[Qemu-devel] [PATCH v2 4/5] xenfb: Add "feature-no-abs-rescale"

2014-09-17 Thread Owen smith
Some frontends may require absolute axes that are not scaled to DisplaySurface sizes. backend: feature-no-abs-rescale Value: 0/1 (boolean) Default: 0 Indicates whether backend supports unscaled absolute axes. Unscaled axes are in the range [0, 0x7fff]. frontend: request-no-abs-re

[Qemu-devel] [PATCH v2 1/5] xenfb: Unregister keyboard event handler correctly

2014-09-17 Thread Owen smith
The keyboard event handler was not being removed, a NULL-callback entry was being added to intercept events. Use the unregister call to remove the keyboard event handler when appropriate. Signed-off-by: Owen smith --- hw/display/xenfb.c | 12 ++-- 1 file changed, 10 insertions(+), 2 dele

[Qemu-devel] [PATCH v2 2/5] xenfb: Activate mouse event handler

2014-09-17 Thread Owen smith
Without activating the mouse event handler, mouse events are not delivered to the new handler. Input events are only delivered to the first matching handler in the input chain. Activating a handler moves the handler to the start of the chain. Note: qemu_add_kbd_event_handler adds and activates the

Re: [Qemu-devel] [PATCH] slirp: udp: fix NULL pointer dereference because of uninitialized socket

2014-09-17 Thread Michael S. Tsirkin
On Wed, Sep 17, 2014 at 01:41:30PM +0200, Petr Matousek wrote: > When guest sends udp packet with source port and source addr 0, > uninitialized socket is picked up when looking for matching and already > created udp sockets, and later passed to sosendto() where NULL pointer > dereference is hit du

Re: [Qemu-devel] [PATCH 4/4] blocksize: add blkconf_blocksize call to all block devices

2014-09-17 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 02:28:26PM +0400, Ekaterina Tumanova wrote: > On 09/03/2014 07:46 PM, Stefan Hajnoczi wrote: > >On Tue, Jul 29, 2014 at 02:27:19PM +0200, Ekaterina Tumanova wrote: > >>This patch add the blkconf_blocksize call to all > >>devices, which use DEFINE_BLOCK_PROPERTIES. > >>If the

Re: [Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Eric Blake
On 09/17/2014 07:51 AM, Andreas Färber wrote: > Hi, > > As a general comment, when sending a cover letter for a single patch, > please use --numbered, so that the cover letter becomes [PATCH 0/1] and > the patch [PATCH 1/1] so they don't end up with identical subjects. Or, when sending a single p

Re: [Qemu-devel] [PATCH 4/4] blocksize: add blkconf_blocksize call to all block devices

2014-09-17 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 04:15:21PM +0200, Christian Borntraeger wrote: > On 03/09/14 17:46, Stefan Hajnoczi wrote: > > On Tue, Jul 29, 2014 at 02:27:19PM +0200, Ekaterina Tumanova wrote: > > guest after live migration? QEMU doesn't automatically query the > > storage because these parameters must

Re: [Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Andreas Färber
Hi, As a general comment, when sending a cover letter for a single patch, please use --numbered, so that the cover letter becomes [PATCH 0/1] and the patch [PATCH 1/1] so they don't end up with identical subjects. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germa

Re: [Qemu-devel] Data classification in Qemu

2014-09-17 Thread Wu Libin
Cool, the document should be the design of the patch. The patch is a lustre in intel. Thanks,-:) On 17 Sep, 2014, at 5:01 pm, Stefan Hajnoczi wrote: > On Tue, Sep 16, 2014 at 11:03:04PM +0800, Wu Libin wrote: >> Yeah, i know dm-cache, it’s in the layer of block. >> >> Maybe my description is no

[Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Chrysostomos Nanakos
v3->v4 -- * Remove escaped single quotes from error messages. * Rephrase commit log. v2->v3 -- * Remove errno usage and print the detailed message based on errno when event_notifier_init() fails. * Propagate error and return from iothread_complete() if aio_context_new() fails. * Return

[Qemu-devel] [PATCH v4] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Chrysostomos Nanakos
On a system with a low limit of open files the initialization of the event notifier could fail and QEMU exits without printing any error information to the user. The problem can be easily reproduced by enforcing a low limit of open files and start QEMU with enough I/O threads to hit this limit. T

Re: [Qemu-devel] migration: qemu-coroutine-lock.c:141: qemu_co_mutex_unlock: Assertion `mutex->locked == 1' failed

2014-09-17 Thread Alexey Kardashevskiy
On 09/17/2014 07:25 PM, Paolo Bonzini wrote: > Il 17/09/2014 11:06, Stefan Hajnoczi ha scritto: >> I think the fundamental problem here is that the mirror block job >> on the source host does not synchronize with live migration. > >> Remember the mirror block job iterates on the dirty bitmap >> w

Re: [Qemu-devel] [PATCH] block: Validate node-name

2014-09-17 Thread Benoît Canet
The Wednesday 17 Sep 2014 à 13:31:06 (+0200), Kevin Wolf wrote : > The device_name of a BlockDriverState is currently checked because it is > always used as a QemuOpts ID and qemu_opts_create() checks whether such > IDs are wellformed. > > node-name is supposed to share the same namespace, but it

Re: [Qemu-devel] [PATCH V2 0/3] image-fuzzer: Support refcount structures in the qcow2 image generator

2014-09-17 Thread Stefan Hajnoczi
On Tue, Aug 19, 2014 at 04:25:10PM +0400, Maria Kustova wrote: > This patch series was created for the 'block-next' branch and based on the > next > series: > [PATCH V3] layout: Reduce number of generator functions in __init__ > > v0 -> v1 (based on the review of Fam Zheng): > * Fixed t

Re: [Qemu-devel] [PATCH v3] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Chrysostomos Nanakos
On 09/17/2014 04:01 PM, Eric Blake wrote: On 09/17/2014 03:16 AM, Chrysostomos Nanakos wrote: On 09/16/2014 10:40 PM, Eric Blake wrote: On 09/16/2014 12:04 PM, Chrysostomos Nanakos wrote: If event_notifier_init fails QEMU exits without printing any error information to the user. This commit ad

Re: [Qemu-devel] [PATCH 0/4] qapi/block-core: Add "new" qcow2 options

2014-09-17 Thread Stefan Hajnoczi
On Wed, Aug 20, 2014 at 07:59:32PM +0200, Max Reitz wrote: > This is a follow-up series to my previous series > "[PATCH v2 0/4] qcow2: Allow runtime specification of cache sizes" which > adds missing qcow2 runtime options to the appropriate structure in > qapi/block-core (overlap check mode and met

Re: [Qemu-devel] [PATCH] hmp: fix memory leak at hmp_info_block_jobs()

2014-09-17 Thread Stefan Hajnoczi
On Tue, Sep 16, 2014 at 09:36:55PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > hmp.c | 2 ++ > 1 file changed, 2 insertions(+) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan pgpnBQq4Qev3R.pgp Description:

Re: [Qemu-devel] [PATCH v3] async: aio_context_new(): Handle event_notifier_init failure

2014-09-17 Thread Eric Blake
On 09/17/2014 03:16 AM, Chrysostomos Nanakos wrote: > On 09/16/2014 10:40 PM, Eric Blake wrote: >> On 09/16/2014 12:04 PM, Chrysostomos Nanakos wrote: >>> If event_notifier_init fails QEMU exits without printing >>> any error information to the user. This commit adds an error >>> message on failure

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-17 Thread Eric Blake
On 09/16/2014 11:54 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 09/16/2014 12:31 PM, Paolo Bonzini wrote: >> Change legacy_name to point to a detailed human-readable description of the type? E.g. "Ethernet 6-byte MAC Address, format: AA:BB:CC:DD:EE:FF"? >>> >>> If lib

Re: [Qemu-devel] [PATCH] block: Validate node-name

2014-09-17 Thread Kevin Wolf
Am 17.09.2014 um 13:49 hat Benoît Canet geschrieben: > > > > +int qemu_opts_id_wellformed(const char *id) > > This return 0 and 1 as a bool. > Could we make the function return bool in the same series ? I considered the change (as you probably saw, the new block.c function returns a bool), but

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-17 Thread Andreas Färber
Am 13.09.2014 um 18:45 schrieb Richard Henderson: > In preparation for removing a bunch of ifdefs from cpu_exec. > > Cc: Andreas Färber > Signed-off-by: Richard Henderson > --- > cpu-exec.c| 9 ++--- > include/qom/cpu.h | 5 + > qom/cpu.c | 6 -- > 3 files changed, 1

Re: [Qemu-devel] [PATCH v3 19/23] blockdev: Drop DriveInfo member enable_auto_del

2014-09-17 Thread Benoît Canet
> 1.9.3 > Reviewed-by: Benoit Canet

Re: [Qemu-devel] [PATCH v3 18/23] blockdev: Fix blockdev-add not to create IDE drive (0, 0)

2014-09-17 Thread Benoît Canet
> -- > 1.9.3 > Reviewed-by: Benoit Canet

  1   2   >