Re: [Qemu-devel] [PATCH v3] add input-send-event command

2014-09-29 Thread Gerd Hoffmann
Hi, > > 'console' is mandatory; I guess that's okay. > > > > Are we guaranteed that either all events are sent? Or is there a need to > > Events can be dropped at hardware level if the event queue is full, for > example. Would have to modify individual drivers to return error codes, > i supp

[Qemu-devel] [PATCH v2] vfio: migration to trace points

2014-09-29 Thread Eric Auger
This patch removes all DPRINTF and replace them by trace points. A few DPRINTF used in error cases were transformed into error_report. Signed-off-by: Eric Auger --- - __func__ is removed since trace point name does the same job - HWADDR_PRIx were replaced by PRIx64 - this transformation just is

Re: [Qemu-devel] [PATCH v2 3/6] pc/vl: Add units-per-default-bus property

2014-09-29 Thread Markus Armbruster
John Snow writes: > This patch adds the 'units_per_default_bus' property which > allows individual boards to declare their desired > index => (bus,unit) mapping for their default HBA, so that > boards such as Q35 can specify that its default if_ide HBA, > AHCI, only accepts one unit per bus. > >

Re: [Qemu-devel] [PATCH v3 2/3] pcie: add check for ari capability of pcie devices

2014-09-29 Thread Gonglei (Arei)
> > > > In QEMU, ARI Forwarding is enabled defualt at emulation of PCIe > > ports. ARI Forwarding enable setting at firmware/OS Control handoff. > > If the bit is Set when a non-ARI Device is present, the non-ARI > > Device can respond to Configuration Space accesses under what it > > interprets as

Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load

2014-09-29 Thread Peter Lieven
On 23.09.2014 11:51, Paolo Bonzini wrote: Il 23/09/2014 11:46, Paolo Bonzini ha scritto: Il 02/09/2014 11:17, Peter Lieven ha scritto: Juan is back, I'll let him pick it through his tree. Juan, have you picked this up? commit db80facefa62dff42bb50c73b0f03eda5f732b49 Author: Peter Lieven Date

[Qemu-devel] [PATCHv3 0/3] introduce max_transfer_length

2014-09-29 Thread Peter Lieven
This series adds the basics for introducing a maximum transfer length to the block layer. Its main purpose is currently avoiding that a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN. This is a required bug fix. Splitting up requests according to the max_transfer_length will fo

Re: [Qemu-devel] [PATCH v2 2/6] blockdev: Allow overriding if_max_dev property

2014-09-29 Thread Markus Armbruster
John Snow writes: > The if_max_devs table as in the past been an immutable > default that controls the mapping of index => (bus,unit) > for all boards and all HBAs for each interface type. > > Since adding this mapping information to the HBA device > itself is currently unwieldly from the perspec

[Qemu-devel] [PATCHv3 3/3] block: avoid creating oversized writes in multiwrite_merge

2014-09-29 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg --- block.c |5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index 26806e0..a26e6a5 100644 --- a/block.c +++ b/block.c @@ -4559,6 +4559,11 @@ static int multiwrite_merge(BlockDriverState *bs, BlockRequest *req

[Qemu-devel] [PATCHv3 1/3] BlockLimits: introduce max_transfer_length

2014-09-29 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg --- block.c |4 include/block/block_int.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/block.c b/block.c index c5a251c..26806e0 100644 --- a/block.c +++ b/block.c @@ -541,6 +541,7 @@ void bdrv_refre

[Qemu-devel] [PATCHv3 2/3] block/iscsi: set max_transfer_length

2014-09-29 Thread Peter Lieven
the limit of 0xff for 16 byte CDBs is intentional to avoid overflows on 32-bit architectures. Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg --- block/iscsi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5c

Re: [Qemu-devel] [PATCH v2] trace: tighten up trace-events regex to fix bad parse

2014-09-29 Thread Eric Auger
Dear all, this patch fixes the issues I reported (related to VFIO trace points). Many thanks for that. Best Regards Eric On 09/23/2014 12:37 PM, Stefan Hajnoczi wrote: > Use \w for properties and trace event names since they are both drawn > from [a-zA-Z0-9_] character sets. > > The .* for ma

Re: [Qemu-devel] [PATCH v3 18/23] blockdev: Fix blockdev-add not to create IDE drive (0, 0)

2014-09-29 Thread Markus Armbruster
Kevin Wolf writes: > Am 29.09.2014 um 15:05 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben: >> >> @@ -903,21 +899,19 @@ DriveInfo *drive_new(QemuOpts *all_opts, >> >> BlockInterfaceType block_default_type) >> >> } >

[Qemu-devel] [PATCH v2 10/12] virtio-9p: use aliases instead of duplicate qdev properties

2014-09-29 Thread arei.gonglei
From: Gonglei virtio-9p-pci all duplicate the qdev properties of their V9fsState child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property accesses to the V9fsState child

[Qemu-devel] [PATCH v2 05/12] virtio-serial: use aliases instead of duplicate qdev properties

2014-09-29 Thread arei.gonglei
From: Gonglei virtio-serial-{pci, s390, ccw} all duplicate the qdev properties of their VirtIOSerial child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property accesses to

[Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports

2014-09-29 Thread arei.gonglei
From: Gonglei virtio-$device-{pci, s390, ccw} all duplicate the qdev properties of their virtio child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property accesses to the

[Qemu-devel] [PATCH v2 11/12] virtio-9p: fix virtio-9p child refcount in transports

2014-09-29 Thread arei.gonglei
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon unplug the virtio-9p child is not finalized! Drop our

[Qemu-devel] [PATCH v2 02/12] virtio-net: fix virtio-net child refcount in transports

2014-09-29 Thread arei.gonglei
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-net child is not finalized! Dr

[Qemu-devel] [PATCH v2 07/12] virtio-rng: use aliases instead of duplicate qdev properties

2014-09-29 Thread arei.gonglei
From: Gonglei virtio-rng-{pci, s390, ccw} all duplicate the qdev properties of their VirtIORNG child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward property accesses to the V

[Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization

2014-09-29 Thread arei.gonglei
From: Gonglei For better code sharing, add a wrapper help funciton for various virtio devices. Cc: Cornelia Huck Cc: Michael S. Tsirkin Signed-off-by: Gonglei --- hw/s390x/s390-virtio-bus.c | 42 +-- hw/s390x/virtio-ccw.c | 42 +---

[Qemu-devel] [PATCH v2 04/12] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports

2014-09-29 Thread arei.gonglei
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-scsi/vhost-scsi child is not fi

[Qemu-devel] [PATCH v2 08/12] virtio-rng: fix virtio-rng child refcount in transports

2014-09-29 Thread arei.gonglei
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-rng child is not finalized! Dr

[Qemu-devel] [PATCH v2 09/12] virtio-balloon: fix virtio-balloon child refcount in transports

2014-09-29 Thread arei.gonglei
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-balloon child is not finalized!

[Qemu-devel] [PATCH v2 03/12] virtio/vhost-scsi: use aliases instead of duplicate qdev properties

2014-09-29 Thread arei.gonglei
From: Gonglei {virtio, vhost}-scsi-{pci, s390, ccw} all duplicate the qdev properties of their VirtIOSCSI/VHostSCSI child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward prope

[Qemu-devel] [PATCH v2 01/12] virtio-net: use aliases instead of duplicate qdev properties

2014-09-29 Thread arei.gonglei
From: Gonglei virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the qdev properties of their VirtIONet child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward pr

[Qemu-devel] [PATCH v2 06/12] virtio-serial: fix virtio-serial child refcount in transports

2014-09-29 Thread arei.gonglei
From: Gonglei object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount >= 1. Upon hot unplug the virtio-serial child is not finalized!

Re: [Qemu-devel] [PULL v3 14/15] virtio-pci: fix migration for pci bus master

2014-09-29 Thread Nikunj A Dadhania
Greg Kurz writes: > On Mon, 29 Sep 2014 19:15:05 +0300 > "Michael S. Tsirkin" wrote: > > It may be possible to change the way SLOF configures the virtq so > that it wouldn't suffer from the device being reset. We have some > time left before 2.2. I have a tentative patch for SLOF that I'll > be g

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-09-29 Thread Tony Breeds
openstack review at: https://review.openstack.org/#/c/123957/ Qemu patches at: http://patchwork.ozlabs.org/patch/393494/ ; and http://patchwork.ozlabs.org/patch/393495/ ** Changed in: nova Assignee: (unassigned) => Tony Breeds (o-tony) ** Changed in: qemu Status: New => In Prog

[Qemu-devel] [PATCH v5 6/7] scsi: Introduce scsi_req_cancel_async

2014-09-29 Thread Fam Zheng
Devices will call this function to start an asynchronous cancellation. The bus->info->cancel will be called after the request is canceled. Devices will probably need to track a separate TMF request that triggers this cancellation, and wait until the cancellation is done before completing it. So we

[Qemu-devel] [PATCH v5 7/7] virtio-scsi: Handle TMF request cancellation asynchronously

2014-09-29 Thread Fam Zheng
For VIRTIO_SCSI_T_TMF_ABORT_TASK and VIRTIO_SCSI_T_TMF_ABORT_TASK_SET, use scsi_req_cancel_async to start the cancellation. Because each tmf command may cancel multiple requests, we need to use a counter to track the number of remaining requests we still need to wait for. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v5 4/7] scsi: Drop SCSIReqOps.cancel_io

2014-09-29 Thread Fam Zheng
The only two implementations are identical to each other, with nothing specific to device: they only call bdrv_aio_cancel with the SCSIRequest.aiocb. Let's move it to scsi-bus. Signed-off-by: Fam Zheng --- hw/scsi/scsi-bus.c | 4 ++-- hw/scsi/scsi-disk.c| 14 -- hw/scsi/scs

[Qemu-devel] [PATCH v5 5/7] scsi: Introduce scsi_req_cancel_complete

2014-09-29 Thread Fam Zheng
Let the aio cb do the clean up and notification job after scsi_req_cancel, in preparation for asynchronous cancellation. Signed-off-by: Fam Zheng --- hw/scsi/scsi-bus.c | 14 ++ hw/scsi/scsi-disk.c| 8 hw/scsi/scsi-generic.c | 1 + include/hw/scsi/scsi.h | 1 + 4

[Qemu-devel] [PATCH v5 1/7] scsi: Drop scsi_req_abort

2014-09-29 Thread Fam Zheng
The only user of this function is spapr_vscsi.c. We can convert to scsi_req_cancel plus adding a check in vscsi_request_cancelled. Suggested-by: Paolo Bonzini Signed-off-by: Fam Zheng --- hw/scsi/scsi-bus.c| 15 --- hw/scsi/spapr_vscsi.c | 11 --- 2 files changed, 8 inse

[Qemu-devel] [PATCH v5 0/7] virtio-scsi: Asynchronous cancellation

2014-09-29 Thread Fam Zheng
v5: Squash in Paolo's suggested patch into patch 7, fixed "notifier->tmf_req" and did some test. v4: Call notifier_list_notify in scsi_req_complete. (Paolo) v3: Address Paolo's comments: - scsi_req_canceled -> scsi_req_cancel_complete - Drop unnecessary changes in scsi_req_alloc and s

[Qemu-devel] [PATCH v5 3/7] scsi-bus: Unify request unref in scsi_req_cancel

2014-09-29 Thread Fam Zheng
Before, scsi_req_cancel will take ownership of the canceled request and unref it. We did this because we didn't know whether AIO CB will be called or not during the cancelling, so we set the io_canceled flag before calling it, and skip unref in the potentially called callbacks, which is not very ni

[Qemu-devel] [PATCH v5 2/7] scsi-generic: Handle canceled request in scsi_command_complete

2014-09-29 Thread Fam Zheng
Now that we always called the cb in bdrv_aio_cancel, let's make scsi-generic callbacks check io_canceled flag similarly to scsi-disk. Signed-off-by: Fam Zheng --- hw/scsi/scsi-generic.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/scsi/scsi-generic.c b/hw/scs

[Qemu-devel] [PATCH v2 1/2] main-loop: Pass AioContext into qemu_poll_ns

2014-09-29 Thread Fam Zheng
qemu_poll_ns may ultilize the information in AioContext to achieve better performance. Signed-off-by: Fam Zheng --- aio-posix.c | 2 +- include/qemu/timer.h | 3 ++- main-loop.c | 6 -- qemu-timer.c | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --gi

[Qemu-devel] [PATCH v2 2/2] main-loop: Use epoll on Linux

2014-09-29 Thread Fam Zheng
A new implementation for qemu_poll_ns based on epoll is introduced here to address the slowness of g_poll and ppoll when the number of fds are high. On my laptop this would reduce the virtio-blk on top of null-aio device's response time from 32 us to 29 us with few fds (~10), and 48 us to 32 us wi

[Qemu-devel] [PATCH v2 0/2] main-loop: Use epoll on Linux

2014-09-29 Thread Fam Zheng
v2: Introduce patch 1 to allow qemu_epoll to access AioContext. Don't pollute g_* namespace. (Stefan) Fam Zheng (2): main-loop: Pass AioContext into qemu_poll_ns main-loop: Use epoll on Linux Makefile.objs| 1 + aio-posix.c | 2 +- include/block/aio.h |

[Qemu-devel] [PATCH v4 2/5] qom: add description field in ObjectProperty struct

2014-09-29 Thread arei.gonglei
From: Gonglei The descriptions can serve as documentation in the code, and they can be used to provide better help. When we call object_property_add_alias() adding alias properties to the source object on the target Object, set the object property's description to the source object property's.

[Qemu-devel] [PATCH v4 3/5] qdev: set the object property's description to the qdev property's.

2014-09-29 Thread arei.gonglei
From: Gonglei Set all static qdev properties' descriptions to object property's description. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei --- hw/core/qdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c inde

[Qemu-devel] [PATCH v4 5/5] qdev: drop legacy_name from qdev properties

2014-09-29 Thread arei.gonglei
From: Gonglei The legacy_name is useless now, the better help information provied by description field of property. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei --- hw/core/qdev-properties-system.c | 4 hw/core/qdev-properties.c| 6 -

[Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

2014-09-29 Thread arei.gonglei
From: Gonglei The descriptions can serve as documentation in the code, and they can be used to provide better help. Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Markus Armbruster Signed-off-by: Gonglei Signed-off-by: Paolo Bonzini --- hw/core/qdev-properties-system.c | 4 hw/core/qdev

[Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-09-29 Thread arei.gonglei
From: Gonglei This patch series based on qom-next tree: https://github.com/afaerber/qemu-cpu/commits/qom-next Add a description field in both ObjectProperty and PropertyInfo struct. The descriptions can serve as documentation in the code, and they can be used to provide better help. For example

[Qemu-devel] [PATCH v4 4/5] qmp: print descriptions of object properties

2014-09-29 Thread arei.gonglei
From: Gonglei Add a new "description" field to DevicePropertyInfo. The descriptions can serve as documentation in the code, and they can be used to provide better help. For example: $./qemu-system-x86_64 -device virtio-blk-pci,? Before this patch: virtio-blk-pci.iothread=link virtio-blk-pci.x-

Re: [Qemu-devel] [PATCH] main-loop: Use epoll on Linux

2014-09-29 Thread Fam Zheng
On Mon, 09/29 11:28, Stefan Hajnoczi wrote: > On Mon, Sep 29, 2014 at 01:26:29PM +0800, Fam Zheng wrote: > > +int qemu_epoll(GPollFD *fds, guint nfds, int64_t timeout) > > +{ > > +/* A copy of last fd array, used to skip epoll_prepare when nothing > > + * changed. */ > > +static GPollFD

Re: [Qemu-devel] [PATCH v4 7/7] virtio-scsi: Handle TMF request cancellation asynchronously

2014-09-29 Thread Fam Zheng
On Mon, 09/29 12:56, Paolo Bonzini wrote: > @@ -241,7 +235,6 @@ static int virtio_scsi_do_tmf(VirtIOSCSI *s, > VirtIOSCSIReq *req) > BusChild *kid; > int target; > int ret = 0; > -int cancel_count; > > if (s->dataplane_started && bdrv_get_aio_context(d->conf.bs) != s->ctx

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-29 Thread Chen, Tiejun
On 2014/9/29 18:01, Michael S. Tsirkin wrote: On Sun, Sep 28, 2014 at 10:59:05AM +0800, Chen, Tiejun wrote: On 2014/9/3 9:40, Kay, Allen M wrote: -Original Message- From: Chen, Tiejun Sent: Monday, September 01, 2014 12:50 AM To: Michael S. Tsirkin Cc: xen-de...@lists.xensource.com;

Re: [Qemu-devel] [PATCH v4 7/7] virtio-scsi: Handle TMF request cancellation asynchronously

2014-09-29 Thread Fam Zheng
On Mon, 09/29 12:56, Paolo Bonzini wrote: > Il 29/09/2014 12:11, Paolo Bonzini ha scritto: > > Il 28/09/2014 03:48, Fam Zheng ha scritto: > >> +virtio_scsi_complete_req(req); > >> +} else { > >> +assert(r = -EINPROGRESS); > >> +} > >> } > > > > = instead of == here. > > >

[Qemu-devel] [PATCH v3 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-29 Thread Jan Vesely
Signed-off-by: Jan Vesely --- v2: rebase v3: fixup error handling hw/usb/dev-hid.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 467ec86..5d37d63 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb

[Qemu-devel] [PATCH v3 3/3] usb-hid: Add high speed keyboard configuration

2014-09-29 Thread Jan Vesely
Signed-off-by: Jan Vesely --- v2: rebase v3: add compat property rebase hw/i386/pc_piix.c | 4 hw/usb/dev-hid.c | 66 ++- 2 files changed, 69 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 6a17

[Qemu-devel] [PATCH v4 2/3] usb-hid: Add high speed mouse configuration

2014-09-29 Thread Jan Vesely
Signed-off-by: Jan Vesely --- v2: add usb_mouse_properties use macros for bmAttributes v3: rebase v4: add compat property rebase hw/i386/pc_piix.c | 4 hw/usb/dev-hid.c | 71 ++- 2 files changed, 74 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v3 6/7] qmp: print descriptions of object properties

2014-09-29 Thread Gonglei (Arei)
> > On 09/26/2014 11:14 PM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Add a new "description" field to DevicePropertyInfo. > > The descriptions can serve as documentation in the code, > > and they can be used to provide better help. For example: > > > > $./qemu-system-x86_64 -devic

Re: [Qemu-devel] [PATCH v3 4/7] qom: add description field in ObjectProperty struct

2014-09-29 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v3 4/7] qom: add description field in ObjectProperty > struct > > Il 27/09/2014 07:13, arei.gong...@huawei.com ha scritto: > > +void object_property_set_description(Object *obj, const char *name, > > + const char *description, Error >

[Qemu-devel] [PATCH] smbios: Fix assertion on socket count calculation

2014-09-29 Thread Eduardo Habkost
QEMU currently allows the number of VCPUs to not be a multiple of the number of threads per socket, but the smbios socket count calculation introduced by commit c97294ec1b9e36887e119589d456557d72ab37b5 doesn't take that into account, triggering an assertion. e.g.: $ ./x86_64-softmmu/qemu-system-

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Don Slutz
On 09/29/14 09:14, Paolo Bonzini wrote: Il 29/09/2014 14:57, Alexander Graf ha scritto: Yeah, that would be possible. You do not even need synchronize_state, it seems to me that it introduces more complication for little gain. Well, it makes all accels behave the same and keep information alw

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Don Slutz
On 09/29/14 07:53, Alexander Graf wrote: On 29.09.14 13:10, Paolo Bonzini wrote: Il 29/09/2014 10:12, Alexander Graf ha scritto: Could you instead plug into the existing cpu_synchronize_registers() framework and just implement register synchronization for the Xen side, just like it's been done

Re: [Qemu-devel] [PATCH v3 0/7] add description field in ObjectProperty and PropertyInfo struct

2014-09-29 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v3 0/7] add description field in > ObjectProperty and PropertyInfo struct > > Hi, > > Am 27.09.2014 um 07:13 schrieb arei.gong...@huawei.com: > > Gonglei (7): > > qom: add error handler for object_property_print() > > qom: add error handler for object alias

Re: [Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-29 Thread Gonglei (Arei)
> > > > > > > > Hm... > > > > > > > > void virtio_instance_init_common(Object *proxydev, > > > > DeviceState *vdev, > > > > size_t vdevsize, > > > > const char *vdevname) > > > > { > > > > object_

Re: [Qemu-devel] [PATCH v2 03/11] vga: Separate LE and BE conversion functions

2014-09-29 Thread David Gibson
On Mon, Sep 29, 2014 at 11:31:04AM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > Provide different functions for converting from an LE vs a BE > framebuffer. We cannot rely on the simple cases always being > shared surfaces since cirrus will need to always shadow for > cursor emu

Re: [Qemu-devel] [PATCH v2 10/11] vga: Add endian control register

2014-09-29 Thread David Gibson
On Mon, Sep 29, 2014 at 11:31:11AM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt > > Include the endian state in the migration stream as an optional > subsection which we only include when the endian isn't the default, > thus enabling backward compatibility of the common case. > > S

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Don Slutz
On 09/29/14 06:25, Stefano Stabellini wrote: On Mon, 29 Sep 2014, Stefano Stabellini wrote: On Fri, 26 Sep 2014, Don Slutz wrote: This adds synchronisation of the vcpu registers between Xen and QEMU. Signed-off-by: Don Slutz [...] diff --git a/xen-hvm.c b/xen-hvm.c index 05e522c..e1274bb 1

Re: [Qemu-devel] [PATCH 1/8] virtio-gpu/2d: add hardware spec include file

2014-09-29 Thread Dave Airlie
> Triggered by the framebuffer endian issues we have with stdvga I've > started to check where we stand with virtio-gpu and whenever we have to > fix something in the virtio protocol before setting in stone with the > upstream merge. Let me start by saying its not that I don't care about endiannes

Re: [Qemu-devel] [PATCH v3 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

2014-09-29 Thread Benoît Canet
On Mon, Sep 29, 2014 at 11:54:47PM +0200, Paolo Bonzini wrote: > Il 29/09/2014 18:04, Benoît Canet ha scritto: > > On Wed, Sep 24, 2014 at 05:33:45PM +0200, Paolo Bonzini wrote: > >> Il 24/09/2014 17:21, Benoît Canet ha scritto: > >>> Reviewed-by: Eric Blake > >>> Signed-off-by: Benoît Canet > >>

Re: [Qemu-devel] [PATCH v3 00/17] QOMify accelerator code

2014-09-29 Thread Paolo Bonzini
Il 26/09/2014 22:45, Eduardo Habkost ha scritto: > This is an attempt to convert the accel initialization and registration code > to be QOM-based. Some use cases for this are: > > * Isolating KVM-specific CPU initialization and compatibility code; > * Use compat_props to implement accelrator-spe

Re: [Qemu-devel] [PATCH v3 2/3] timers: Move NANOSECONDS_PER_SECONDS to timer.h for future reuse

2014-09-29 Thread Paolo Bonzini
Il 29/09/2014 18:04, Benoît Canet ha scritto: > On Wed, Sep 24, 2014 at 05:33:45PM +0200, Paolo Bonzini wrote: >> Il 24/09/2014 17:21, Benoît Canet ha scritto: >>> Reviewed-by: Eric Blake >>> Signed-off-by: Benoît Canet >>> --- >>> include/qemu/throttle.h | 2 -- >>> include/qemu/timer.h| 2

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: Add support for 9p migration.

2014-09-29 Thread Benoît Canet
The Friday 26 Sep 2014 à 18:19:56 (+0300), Boris Sukholitko wrote : > This patch is a rebase of Aneesh Kumar's and Benoit Canet's previous > work. > > Signed-off-by: Boris Sukholitko If Aneesh and me worked on this you should also keep our signed-off in addition of yours. Best regards Benoît

Re: [Qemu-devel] [PATCH 0/2] Virtio-9p live migration patchset

2014-09-29 Thread Benoît Canet
The Friday 26 Sep 2014 à 18:19:55 (+0300), Boris Sukholitko wrote : > This patchset is a small rebase of the 9p live migration patches made a year > ago by Benoit Canet. > > See http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg02190.html > for the previous thread. > > I took the liberty to

Re: [Qemu-devel] [PATCH v1 3/3] monitor: add del completion for peripheral device

2014-09-29 Thread Hani Benhabiles
On Fri, Sep 26, 2014 at 01:29:41PM -0400, Luiz Capitulino wrote: > On Fri, 26 Sep 2014 13:25:45 -0400 > Luiz Capitulino wrote: > > > On Thu, 18 Sep 2014 15:53:21 +0800 > > Zhu Guihua wrote: > > > > > Add peripheral_device_del_completion() to let peripheral device del > > > completion > > > be

Re: [Qemu-devel] [PULL v3 14/15] virtio-pci: fix migration for pci bus master

2014-09-29 Thread Greg Kurz
On Mon, 29 Sep 2014 19:15:05 +0300 "Michael S. Tsirkin" wrote: > On Mon, Sep 22, 2014 at 07:28:57PM +0200, Greg Kurz wrote: > > On Thu, 18 Sep 2014 21:54:58 +0300 > > "Michael S. Tsirkin" wrote: > > > > > Current support for bus master (clearing OK bit) > > > together with the need to support g

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

2014-09-29 Thread Nenad Cuturic
Todd, thank you for your post and advise. It helped me to fix the same problem with one of the virtual disks that became corrupted after ubuntu host release upgrade to 14.0.1 LTS I tried first to install qemu 2.1.2 from sources but without any improvement. qemu 1.7.2 could convert to raw img form

Re: [Qemu-devel] [PATCH v3] add input-send-event command

2014-09-29 Thread Marcelo Tosatti
On Mon, Sep 29, 2014 at 01:12:44PM -0600, Eric Blake wrote: > On 09/29/2014 12:56 PM, Marcelo Tosatti wrote: > > > > Which allows specification of absolute/relative, > > up/down and console parameters. > > > > Suggested by Gerd Hoffman. > > > > Signed-off-by: Marcelo Tosatti > > > > --- > > q

Re: [Qemu-devel] [PATCH v3] add input-send-event command

2014-09-29 Thread Eric Blake
On 09/29/2014 12:56 PM, Marcelo Tosatti wrote: > > Which allows specification of absolute/relative, > up/down and console parameters. > > Suggested by Gerd Hoffman. > > Signed-off-by: Marcelo Tosatti > > --- > qapi-schema.json | 17 +++ > qmp-commands.hx | 63

[Qemu-devel] [PULL v2 9/9] tcg: Always enable TCGv type checking

2014-09-29 Thread Richard Henderson
Instead of using structures, which imply some amount of overhead on certain ABIs, use pointer types. This actually reduces the size of the binaries vs a NON-debug build on ppc64 and x86_64, due to a reduction in the number of sign-extension insns. Signed-off-by: Richard Henderson --- tcg/tcg.h

[Qemu-devel] [PULL v2 8/9] qemu/compiler: Define QEMU_ARTIFICIAL

2014-09-29 Thread Richard Henderson
The combination of always_inline + artificial allows tiny inline functions to be written that do not interfere with debugging. In particular, gdb will not step into an artificial function. The always_inline attribute was introduced in gcc 4.2, and the artificial attribute was introduced in gcc 4.3

[Qemu-devel] [PULL v2 7/9] tcg-aarch64: Use 32-bit loads for qemu_ld_i32

2014-09-29 Thread Richard Henderson
The "old" qemu_ld opcode did not specify the size of the result, and so we had to assume full register width. With the new opcodes, we can narrow the result. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 27 +++ tcg/tcg-be-ldst.h| 5 +++-- 2 fi

[Qemu-devel] [PULL v2 6/9] tcg-sparc: Use UMULXHI instruction

2014-09-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- disas/sparc.c | 1 + tcg/sparc/tcg-target.c | 5 + tcg/sparc/tcg-target.h | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/disas/sparc.c b/disas/sparc.c index 22ceac3..8e755d1 100644 --- a/disas/sparc.c +++ b/disas/sparc.c @@

[Qemu-devel] [PULL v2 4/9] tcg-sparc: Use ADDXC in setcond_i64

2014-09-29 Thread Richard Henderson
Similar to the ADDC tricks we use in setcond_i32. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 3b232d6..d0bd08c 100644 --- a/tcg/sparc/tcg-target.c +++ b/tc

[Qemu-devel] [PULL v2 3/9] tcg-sparc: Fix setcond_i32 uninitialized value

2014-09-29 Thread Richard Henderson
We failed to swap c1 and c2 correctly for NE c2 == 0. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 08ca482..3b232d6 100644 --- a/tcg/sparc/tcg-target.c

[Qemu-devel] [PULL v2 2/9] tcg-sparc: Use ADDXC in addsub2_i64

2014-09-29 Thread Richard Henderson
On T4 and newer Sparc chips we have an add-with-carry insn that takes its input from %xcc instead of %icc. Signed-off-by: Richard Henderson --- disas/sparc.c | 3 +++ include/elf.h | 37 + tcg/sparc/tcg-target.c | 28 +++-

[Qemu-devel] [PULL v2 5/9] tcg-sparc: Rename ADDX/SUBX insns

2014-09-29 Thread Richard Henderson
The pre-v9 ADDX/SUBX insns were renamed ADDC/SUBC for v9. Standardizing on the v9 name makes things less confusing. Signed-off-by: Richard Henderson --- disas/sparc.c | 32 +++- tcg/sparc/tcg-target.c | 14 +++--- 2 files changed, 18 insertions(+), 28

[Qemu-devel] [PULL v2 1/9] tcg-sparc: Support addsub2_i64

2014-09-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 72 +- tcg/sparc/tcg-target.h | 4 +-- 2 files changed, 67 insertions(+), 9 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 40f2ec1..21981d8 100644 --- a

[Qemu-devel] [PULL v2 0/9] tcg-next queue

2014-09-29 Thread Richard Henderson
A replacement for the one from the 22nd. This one drops the patch that would have conflicted with Paolo's 12 mmu idx patch set. It also adjusts the aarch64 patch that Claudio objected to. Re-tested on x86_64 and aarch64. Please pull. r~ The following changes since commit b60a7726cc0f5cbb2ae

Re: [Qemu-devel] [PATCH] gdbstub: Allow target CPUs to specify watchpoint STOP_BEFORE_ACCESS flag

2014-09-29 Thread Max Filippov
On Tue, Sep 16, 2014 at 9:16 AM, Max Filippov wrote: > On Mon, Sep 15, 2014 at 9:15 PM, Peter Maydell > wrote: >> On 15 September 2014 20:59, Max Filippov wrote: >>> I've tested xtensa part and have noticed no difference with or without >>> this patch: >>> gdb connected to qemu gdbstub always s

[Qemu-devel] [PATCH v3] add input-send-event command

2014-09-29 Thread Marcelo Tosatti
Which allows specification of absolute/relative, up/down and console parameters. Suggested by Gerd Hoffman. Signed-off-by: Marcelo Tosatti --- qapi-schema.json | 17 +++ qmp-commands.hx | 63 + ui/input.c | 31

Re: [Qemu-devel] Timer issues with 2.1.1 and migration (was: latest rc: virtio-blk hangs forever after migration)

2014-09-29 Thread Andrey Korolyov
On Mon, Sep 29, 2014 at 10:25 PM, Marcelo Tosatti wrote: > Andrey, > > Can you get a trace of the guest (echo kvm > > /sys/kernel/debug/tracing/set_event; sleep 1s; cp > /sys/kernel/debug/tracing/trace /tmp/trace.txt) while it is in the 100% > cpu consumption state? > > Is it otherwise operational

Re: [Qemu-devel] [PULL 0/9] QMP queue

2014-09-29 Thread Peter Maydell
On 26 September 2014 20:03, Luiz Capitulino wrote: > The following changes since commit 81ab11a7a524d12412a59ef49c6b270671e62ea0: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2014-09-26 15:41:50 +0100) > > are available in the git repository at: > > > g

[Qemu-devel] [PULL 09/19] target-arm: Add HCR_EL2

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Reviewed-by: Greg Bellows Reviewed-by: Peter Maydell Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-2-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.h| 36 target-arm/hel

[Qemu-devel] [PULL 11/19] target-arm: A64: Refactor aarch64_cpu_do_interrupt

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Introduce new_el and new_mode in preparation for future patches that add support for taking exceptions to and from EL2 and 3. No functional change. Reviewed-by: Peter Maydell Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-4-git-send-email-edgar.igles...@

[Qemu-devel] [PULL 01/19] target-arm: Implement setting guest breakpoints

2014-09-29 Thread Peter Maydell
This patch adds support for setting guest breakpoints based on values the guest writes to the DBGBVR and DBGBCR registers. (It doesn't include the code to handle when these breakpoints fire, so has no guest-visible effect.) Signed-off-by: Peter Maydell Message-id: 1410523465-13400-2-git-send-emai

[Qemu-devel] [PULL 10/19] target-arm: Add SCR_EL3

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-3-git-send-email-edgar.igles...@gmail.com [PMM: apply offsetoflow32() to correct regdef] Signed-off-by: Peter Maydell --- target-arm/cpu.h| 19 ++- target-arm/helper.c | 35 ++

[Qemu-devel] [PULL 08/19] target-arm: Don't handle c15_cpar changes via tb_flush()

2014-09-29 Thread Peter Maydell
At the moment we try to handle c15_cpar with the strategy of: * emit generated code which makes assumptions about its value * when the register value changes call tb_flush() to throw away the now-invalid generated code This works because XScale CPUs are always uniprocessor, but it's confusing

[Qemu-devel] [PULL 05/19] hw/intc/imx_avic.c: Remove unused function imx_avic_set_prio()

2014-09-29 Thread Peter Maydell
The function imx_avic_set_prio() is unused; delete it. Signed-off-by: Peter Maydell Message-id: 1410723223-17711-3-git-send-email-peter.mayd...@linaro.org --- hw/intc/imx_avic.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/intc/imx_avic.c b/hw/intc/imx_avic.c index ec5f9ad..e48

[Qemu-devel] [PULL 02/19] target-arm: Implement handling of breakpoint firing

2014-09-29 Thread Peter Maydell
Implement handling of breakpoint event firing to correctly inject the debug exception into the guest. Since the breakpoint and watchpoint control register format is very similar we adjust wp_matches() to also handle breakpoints as well rather than using a separate function. Signed-off-by: Peter M

[Qemu-devel] [PULL 14/19] target-arm: A64: Correct updates to FAR and ESR on exceptions

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Not all exception types update both FAR and ESR. Reviewed-by: Alex Bennée Reviewed-by: Greg Bellows Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-7-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/helper-a64.c | 7 +

[Qemu-devel] [PULL 03/19] configure: Build GDB XML for 32 bit ARM CPUs into qemu aarch64 binaries

2014-09-29 Thread Peter Maydell
The qemu-aarch64 and qemu-system-aarch64 binaries include support for all the 32 bit ARM CPUs as well as the 64 bit ones. This means we need to build in the GDB XML files for the 32 bit CPUs too. Otherwise gdb will complain: warning: while parsing target description (at line 1): Could not load XML

[Qemu-devel] [PULL 13/19] target-arm: Don't take interrupts targeting lower ELs

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Reviewed-by: Alex Bennée Reviewed-by: Greg Bellows Reviewed-by: Peter Maydell Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-6-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.h | 7 +++ 1 file changed, 7 ins

[Qemu-devel] [PULL 04/19] hw/display/blizzard.c: Delete unused function blizzard_rgb2yuv

2014-09-29 Thread Peter Maydell
The function blizzard_rgb2yuv() is unused; delete it. Signed-off-by: Peter Maydell Message-id: 1410723223-17711-2-git-send-email-peter.mayd...@linaro.org --- hw/display/blizzard.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 55c0d

[Qemu-devel] [PULL 19/19] target-arm: Add support for VIRQ and VFIQ

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" This only implements the external delivery method via the GIC. Acked-by: Greg Bellows Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-12-git-send-email-edgar.igles...@gmail.com [PMM: adjusted following cpu-exec refactoring] Signed-off-by: Peter Maydell -

[Qemu-devel] [PULL 06/19] hw/display/pxa2xx_lcd.c: Remove unused function pxa2xx_dma_rdst_set

2014-09-29 Thread Peter Maydell
The function pxa2xx_dma_rdst_set() is unused; delete it. Signed-off-by: Peter Maydell Message-id: 1410723223-17711-4-git-send-email-peter.mayd...@linaro.org --- hw/display/pxa2xx_lcd.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c in

[Qemu-devel] [PULL 16/19] target-arm: Add a Hypervisor Trap exception type

2014-09-29 Thread Peter Maydell
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Message-id: 1411718914-6608-9-git-send-email-edgar.igles...@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.h| 1 + target-arm/helper-a64.c | 1 + target-arm/helper.c | 1 + target-arm/internals.h | 1 + 4 files

  1   2   3   >