[Qemu-devel] [PATCH 0/1] MAINTAINERS update for s390x

2014-10-20 Thread Cornelia Huck
We've added a bunch of files for s390x that are not reflected in the respective sections. I'd hope Christian and Alex do not object to adding them :) Cornelia Huck (1): s390x: sweep up unmaintained files MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- 1.8.5.5

[Qemu-devel] [PATCH 1/1] s390x: sweep up unmaintained files

2014-10-20 Thread Cornelia Huck
Several s390x/kvm/ccw related files don't have an entry in MAINTAINERS: Sort them into the appropriate sections. CC: Christian Borntraeger CC: Alexander Graf Signed-off-by: Cornelia Huck --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAIN

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-20 Thread Thomas Huth
On Mon, 20 Oct 2014 17:15:48 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote: > > On 20 October 2014 10:19, Markus Armbruster wrote: > > > Contributors rely on this script to find maintainers to copy. The > > > script falls back to git when no e

Re: [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-20 Thread Gonglei
On 2014/10/21 13:53, Weidong Huang wrote: > On 2014/10/20 19:39, Kevin Wolf wrote: > >> Am 20.10.2014 um 13:27 hat Weidong Huang geschrieben: >>> On 2014/10/20 17:41, Kevin Wolf wrote: >>> Am 18.10.2014 um 12:02 hat Weidong Huang geschrieben: > Hi ALL: > > There are two ways to e

Re: [Qemu-devel] [PATCH 6/6] vnc: track & limit connections

2014-10-20 Thread Gonglei
On 2014/10/20 15:02, Gerd Hoffmann wrote: > > Hi, > >> If we set the max trying times, and then >> There are some concepts: >> - INTERVAL_TIME: a time window that user can connnet vnc server >> - REJECT_TIME: the time of reject any connection >> - MAX_TRY_TIMES: the times that user can conn

Re: [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-20 Thread Weidong Huang
On 2014/10/20 19:39, Kevin Wolf wrote: > Am 20.10.2014 um 13:27 hat Weidong Huang geschrieben: >> On 2014/10/20 17:41, Kevin Wolf wrote: >> >>> Am 18.10.2014 um 12:02 hat Weidong Huang geschrieben: Hi ALL: There are two ways to eject the cdrom tray. One is by the eject's qmp c

Re: [Qemu-devel] [PATCH V5 8/8] acpi/cpu-hotplug: introduce helper function to keep bit setting in one place

2014-10-20 Thread Gu Zheng
Hi Igor, On 10/20/2014 11:09 PM, Igor Mammedov wrote: > On Fri, 10 Oct 2014 10:16:07 +0800 > Gu Zheng wrote: > >> Introduce helper function acpi_set_cpu_present_bit() to simplify >> acpi_cpu_plug_cb >> and acpi_cpu_hotplug_init, so that we can keep bit setting in one place. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges

2014-10-20 Thread Knut Omang
On Tue, 2014-10-21 at 01:29 +0200, Alexander Graf wrote: > > > > Am 21.10.2014 um 00:34 schrieb Knut Omang : > > > > This patch set changes the data structure used to handle address spaces > > within > > the emulated Intel iommu to support traversal also if bus numbers are > > dynamically > >

Re: [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-20 Thread Weidong Huang
On 2014/10/20 20:12, Markus Armbruster wrote: > > Correct. This is a known wart. To work around it, wait for event > DEVICE_TRAY_MOVED and eject again. Yes, this is racy: the guest can > reclose the tray and lock it before you get your eject in. Yes. You got it. But how to resolve the racy?

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-20 Thread Guenter Roeck
On 10/20/2014 08:23 AM, Chen Gang wrote: On 10/19/2014 10:58 PM, Guenter Roeck wrote: This doesn't use devicetree, but the configurations are known to be working with kernel releases all the way back to kernel version 3.10. Yeah, really it is ! After try upstream qemu and upstream kernel, f

Re: [Qemu-devel] [question] savevm/delvm: Is it necessary to perform bdrv_drain_all before savevm and delvm?

2014-10-20 Thread Zhang Haoyu
>> >> Hi, >> >> >> >> I noticed that bdrv_drain_all is performed in load_vmstate before >> bdrv_snapshot_goto, >> >> and bdrv_drain_all is performed in qmp_transaction before >> internal_snapshot_prepare, >> >> so is it also neccesary to perform bdrv_drain_all in savevm and delvm? >> > >> >Definite

Re: [Qemu-devel] Close the BlockDriverState when guest eject the media

2014-10-20 Thread Weidong Huang
On 2014/10/20 19:39, Kevin Wolf wrote: > Am 20.10.2014 um 13:27 hat Weidong Huang geschrieben: >> On 2014/10/20 17:41, Kevin Wolf wrote: >> >>> Am 18.10.2014 um 12:02 hat Weidong Huang geschrieben: Hi ALL: There are two ways to eject the cdrom tray. One is by the eject's qmp c

Re: [Qemu-devel] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges

2014-10-20 Thread Alexander Graf
> Am 21.10.2014 um 00:34 schrieb Knut Omang : > > This patch set changes the data structure used to handle address spaces within > the emulated Intel iommu to support traversal also if bus numbers are > dynamically > allocated, as is the case for devices that sit behind root ports or > downst

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 21:03 +0200, Knut Omang wrote: > On Mon, 2014-10-20 at 20:18 +0200, Jan Kiszka wrote: > > On 2014-10-20 17:15, Knut Omang wrote: > > > On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: > > >> WRT intel_iommu, it does not yet seem to be as fully functional as I > > >

[Qemu-devel] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges

2014-10-20 Thread Knut Omang
This patch set changes the data structure used to handle address spaces within the emulated Intel iommu to support traversal also if bus numbers are dynamically allocated, as is the case for devices that sit behind root ports or downstream switches. This means that we cannot use bus number as ind

[Qemu-devel] [PATCH 2/2] intel_iommu: Add support for translation for devices behind bridges.

2014-10-20 Thread Knut Omang
- Add call to pci_setup_iommu for the secondary bus in a bridge. - Refactor IntelIOMMUState to use a list instead of tables based on bus/devfn, as bus numbers can change dynamically. - Instead store reference to the VTDAddressSpace as an AddressSpace pointer, dma_as within PCIDevice. - Use NULL

[Qemu-devel] [PATCH 1/2] iommu: Replace bus+devfn arguments with PCIDevice* in PCIIOMMUFunc

2014-10-20 Thread Knut Omang
The dev pointer is needed by intel_iommu to enable it to store the dma address pointer with the device. Signed-off-by: Knut Omang --- hw/alpha/typhoon.c | 2 +- hw/pci-host/apb.c| 2 +- hw/pci-host/prep.c | 3 +-- hw/pci-host/q35.c| 5 +++-- hw/pci/pci.c | 7 +++ hw/ppc/

Re: [Qemu-devel] spec, RFC: TLS support for NBD

2014-10-20 Thread Wouter Verhelst
On Mon, Oct 20, 2014 at 01:56:43PM +0200, Florian Weimer wrote: > I cannot comment on whether the proposed STARTTLS command is at the correct > stage of the NBD protocol. If there is a protocol description for NBD, I > can have a look. To make this discussion in that regard a bit easier, I've com

Re: [Qemu-devel] spec, RFC: TLS support for NBDµ

2014-10-20 Thread Wouter Verhelst
On Mon, Oct 20, 2014 at 01:51:43PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Mon, Oct 20, 2014 at 08:58:14AM +0100, Daniel P. Berrange wrote: > >> On Sat, Oct 18, 2014 at 07:33:22AM +0100, Richard W.M. Jones wrote: > >> > On Sat, Oct 18, 2014 at 12:03:23AM +0200, Wouter V

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-20 Thread Peter Maydell
On 20 October 2014 21:10, Don Slutz wrote: > Here is a possible patch (based on a xen change). It adds the special > supporter:THE REST > > Which is listed at the end of MAINTAINERS. I included a quick guess... > +THE REST > +M: Michael S. Tsirkin > +M: Peter Maydell > +L: qemu-devel@nongnu.o

Re: [Qemu-devel] [PATCH 0/4] multiwrite patches for 2.2

2014-10-20 Thread Peter Lieven
Am 20.10.2014 um 17:56 schrieb Max Reitz : > On 20.10.2014 at 16:35, Peter Lieven wrote: >> This adds some preparing patches for upcoming multiwrite modifications. >> I will leave the dangerous patches for after 2.2 release. >> >> Peter Lieven (4): >> block: add accounting for merged requests

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-20 Thread Don Slutz
On 10/20/14 15:03, Michael S. Tsirkin wrote: On Mon, Oct 20, 2014 at 03:19:52PM +0100, Peter Maydell wrote: On 20 October 2014 15:15, Michael S. Tsirkin wrote: On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote: On 20 October 2014 10:19, Markus Armbruster wrote: Contributors rely

[Qemu-devel] [PATCH v7 0/1] Add support for Xen access to vmport

2014-10-20 Thread Don Slutz
Changes v6 to v7: Stefano Stabellini Use QEMU_BUILD_BUG_ON, please do not define your own. Switched to QEMU_BUILD_BUG_ON. Dropped Reviewed-by: Paul Durrant (moved below ---) Changes v5 to v6: Paul Durrant Do we need a forward declaration? Nope. Drooped. Added Reviewe

[Qemu-devel] [PATCH v7 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-20 Thread Don Slutz
This adds synchronisation of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu registers used by the code in vmport.c and vmmouse.c The registers are passed in the new sha

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 21:03 +0200, Knut Omang wrote: > On Mon, 2014-10-20 at 20:18 +0200, Jan Kiszka wrote: > > On 2014-10-20 17:15, Knut Omang wrote: > > > On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: > > >> WRT intel_iommu, it does not yet seem to be as fully functional as I > > >

[Qemu-devel] Qemu Translation Blocks Execute slightly different each time?

2014-10-20 Thread M Chen
Hi all! I found that each time when Qemu is running via gdb, with the same start options, the exact Translation Blocks (TBs) execute slightly different each time. For example the first time I start Qemu with gdb, and set the breakpoint at tcg_qemu_tb_exec(env, tc_ptr), and I ignore the first 1000

Re: [Qemu-devel] [PATCH v6 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-20 Thread Don Slutz
On 10/20/14 11:03, Stefano Stabellini wrote: On Mon, 20 Oct 2014, Don Slutz wrote: This adds synchronisation of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu registe

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 20:18 +0200, Jan Kiszka wrote: > On 2014-10-20 17:15, Knut Omang wrote: > > On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: > >> WRT intel_iommu, it does not yet seem to be as fully functional as I > >> hoped. People also discussed the best way to handle virtio v

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-20 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 03:19:52PM +0100, Peter Maydell wrote: > On 20 October 2014 15:15, Michael S. Tsirkin wrote: > > On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote: > >> On 20 October 2014 10:19, Markus Armbruster wrote: > >> > Contributors rely on this script to find maintaine

Re: [Qemu-devel] [PATCH 3/3] libcacard: don't free sign buffer while sign op is pending

2014-10-20 Thread Paolo Bonzini
On 10/19/2014 08:23 AM, Alon Levy wrote: On 10/19/2014 05:12 AM, Ray Strode wrote: From: Ray Strode commit 57f97834efe0c208ffadc9d2959f3d3d55580e52 cleaned up the cac_applet_pki_process_apdu function to have a single exit point. Unfortunately, that commit introduced a bug where the sign buff

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-20 Thread Paolo Bonzini
On 10/20/2014 04:15 PM, Michael S. Tsirkin wrote: What do you want to happen in this case? Won't this cause even more patches to fall to the floor? The benefit seems marginal, the risk high. I agree with Michael. Can we detect if get_maintainer.pl is invoked as a cccmd, and in this case defa

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-20 Thread Paolo Bonzini
On 10/20/2014 11:19 AM, Markus Armbruster wrote: In my experience, too many files are not covered by MAINTAINERS. scripts/get_maintainer.pl falls back to git then, unless you say --no-git-fallback. Copies sent there tends to annoy their recipients without accomplishing all that much. Two obviou

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-20 Thread Paolo Bonzini
On 10/16/2014 10:12 AM, Dr. David Alan Gilbert wrote: Yes; I suspect it's the vmstate_register_ram that uses TARGET_PAGE_MASK, one of the patches in my postcopy world adds a function in exec.c that returns TARGET_PAGE_BITS so that stuff that needs to know target page size can make a call to find

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Jan Kiszka
On 2014-10-20 19:20, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 04:37:15PM +0200, Jan Kiszka wrote: >> On 2014-10-20 16:23, Michael S. Tsirkin wrote: >>> >>> WRT intel_iommu, it does not yet seem to be as fully functional as I >>> hoped. >> >> What is missing or broken? > > PCI to PCI bri

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Jan Kiszka
On 2014-10-20 17:15, Knut Omang wrote: > On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: >> WRT intel_iommu, it does not yet seem to be as fully functional as I >> hoped. People also discussed the best way to handle virtio versus iommu >> (it bypasses it ATM). >> I'd like to suggest w

Re: [Qemu-devel] [PATCH v2 1/1] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-10-20 Thread Eduardo Habkost
On Fri, Oct 03, 2014 at 05:33:37PM -0400, Don Slutz wrote: > From: "Dr. David Alan Gilbert" > > This is a pc & q35 only machine opt. > > VMWare apparently doesn't like running under QEMU due to our > incomplete emulation of it's special IO Port. This adds a > pc & q35 property to allow it to be

Re: [Qemu-devel] [PATCH] block: char devices on FreeBSD are not behind a pager

2014-10-20 Thread Kevin Wolf
Am 20.10.2014 um 18:39 hat Roger Pau Monne geschrieben: > Acknowledge this and forcefully set BDRV_O_NOCACHE and O_DIRECT in order to > force QEMU to use aligned buffers. > > Signed-off-by: Roger Pau Monné > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > --- > block/raw-posix.c | 12 > 1

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 04:37:15PM +0200, Jan Kiszka wrote: > On 2014-10-20 16:23, Michael S. Tsirkin wrote: > > > > WRT intel_iommu, it does not yet seem to be as fully functional as I > > hoped. > > What is missing or broken? PCI to PCI bridges don't work, do they? > > People also discussed

Re: [Qemu-devel] [PATCH v2 2/2] vl.c: reduce exit on error code duplication

2014-10-20 Thread Eric Blake
On 10/20/2014 06:29 AM, Igor Mammedov wrote: > use error_report_fatal() helper instead of a bunch of > if (local_err) { > error_report(foo); > error_free(local_err); > exit(1); > } > code blocks > > Signed-off-by: Igor Mammedov > --- > * s/exit_if_error/error_repo

Re: [Qemu-devel] [PATCH v6 06/11] qcow2: Fix refcount blocks beyond image end

2014-10-20 Thread Kevin Wolf
Am 20.10.2014 um 16:35 hat Max Reitz geschrieben: > If the qcow2 check function detects a refcount block located beyond the > image end, grow the image appropriately. This cannot break anything and > is the logical fix for such a case. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > ---

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-20 Thread Greg Kurz
On Mon, 20 Oct 2014 18:08:56 +0200 Alexander Graf wrote: > > > On 20.10.14 08:58, Michael S. Tsirkin wrote: > > Current support for bus master (clearing OK bit) together with the need to > > support guests which do not enable PCI bus mastering, leads to extra state > > in > > VIRTIO_PCI_FLAG_B

[Qemu-devel] [PATCH] block: char devices on FreeBSD are not behind a pager

2014-10-20 Thread Roger Pau Monne
Acknowledge this and forcefully set BDRV_O_NOCACHE and O_DIRECT in order to force QEMU to use aligned buffers. Signed-off-by: Roger Pau Monné Cc: Kevin Wolf Cc: Stefan Hajnoczi --- block/raw-posix.c | 12 1 file changed, 12 insertions(+) diff --git a/block/raw-posix.c b/block/raw

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-20 Thread Alexander Graf
On 20.10.14 08:58, Michael S. Tsirkin wrote: > Current support for bus master (clearing OK bit) together with the need to > support guests which do not enable PCI bus mastering, leads to extra state in > VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of > cross-version > migratio

Re: [Qemu-devel] [question] savevm/delvm: Is it necessary to perform bdrv_drain_all before savevm and delvm?

2014-10-20 Thread Kevin Wolf
Am 20.10.2014 um 17:09 hat Zhang Haoyu geschrieben: > >> Hi, > >> > >> I noticed that bdrv_drain_all is performed in load_vmstate before > bdrv_snapshot_goto, > >> and bdrv_drain_all is performed in qmp_transaction before > internal_snapshot_prepare, > >> so is it also neccesary to perform bdrv_dra

Re: [Qemu-devel] [PATCH 0/4] multiwrite patches for 2.2

2014-10-20 Thread Max Reitz
On 20.10.2014 at 16:35, Peter Lieven wrote: This adds some preparing patches for upcoming multiwrite modifications. I will leave the dangerous patches for after 2.2 release. Peter Lieven (4): block: add accounting for merged requests block: introduce bdrv_runtime_opts block: add a knob

Re: [Qemu-devel] [PATCH 4/4] hw/virtio-blk: add a constant for max number of merged requests

2014-10-20 Thread Max Reitz
On 20.10.2014 at 16:35, Peter Lieven wrote: As it was not obvious (at least for me) where the 32 comes from add a constant for it. This needs some separator ("...comes from; add a..." or something like that). Signed-off-by: Peter Lieven --- hw/block/virtio-blk.c |4 +++- 1 file chan

Re: [Qemu-devel] [PATCH 3/4] block: add a knob to disable multiwrite_merge

2014-10-20 Thread Max Reitz
On 20.10.2014 at 16:35, Peter Lieven wrote: the block layer silently merges write requests since It's still s/^t/T/ ;-) commit 40b4f539. This patch adds a knob to disable this feature as there has been some discussion lately if multiwrite is a good idea at all and as it falsifies benchmarks.

Re: [Qemu-devel] [PATCH V5 6/8] qom/cpu: remove the unused CPU hot-plug notifier

2014-10-20 Thread Igor Mammedov
On Fri, 10 Oct 2014 10:16:05 +0800 Gu Zheng wrote: > Remove the unused CPU hot-plug notifier. > > Signed-off-by: Gu Zheng Reviewed-by: Igor Mammedov > --- > v5: > -delete the caller of notifier_list_notify() in this patch. > > include/sysemu/sysemu.h |3 --- > qom/cpu.c |

Re: [Qemu-devel] [PATCH 2/4] block: introduce bdrv_runtime_opts

2014-10-20 Thread Max Reitz
On 20.10.2014 at 16:35, Peter Lieven wrote: This patch (orginally by Kevin) adds a bdrv_runtime_opts QemuOptsList. The list will absorb all options that belong to the BDS (and not the BlockBackend) and will be parsed and handled in bdrv_open_common. Signed-off-by: Kevin Wolf Signed-off-by: Pete

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-20 Thread Chen Gang
On 10/19/2014 10:58 PM, Guenter Roeck wrote: > > This doesn't use devicetree, but the configurations are known to be working > with kernel releases all the way back to kernel version 3.10. > Yeah, really it is ! After try upstream qemu and upstream kernel, for me, neither them can work well. Fo

Re: [Qemu-devel] [PATCH v5 01/11] qcow2: Calculate refcount block entry count

2014-10-20 Thread Kevin Wolf
Am 29.08.2014 um 23:40 hat Max Reitz geschrieben: > The size of a refblock entry is (in theory) variable; calculate > therefore the number of entries per refblock and the according bit shift > (1 << x == entry count) when opening an image. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 2 +

Re: [Qemu-devel] [PATCH 2/7] runstate: Add runstate store

2014-10-20 Thread Eric Blake
On 10/20/2014 04:52 AM, Juan Quintela wrote: > "Dr. David Alan Gilbert" wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >>> This allows us to store the current state to send it through migration. >> >> Why store the runstate as a string? The later code then ends up doing >> string compares

Re: [Qemu-devel] [PATCH v6 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-20 Thread Stefano Stabellini
On Mon, 20 Oct 2014, Don Slutz wrote: > This adds synchronisation of the 6 vcpu registers (only 32bits of > them) that vmport.c needs between Xen and QEMU. > > This is to avoid a 2nd and 3rd exchange between QEMU and Xen to > fetch and put these 6 vcpu registers used by the code in vmport.c > and

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 17:23 +0300, Michael S. Tsirkin wrote: > WRT intel_iommu, it does not yet seem to be as fully functional as I > hoped. People also discussed the best way to handle virtio versus iommu > (it bypasses it ATM). > I'd like to suggest we hide the iommu from the command line > help

Re: [Qemu-devel] [PATCH v6 05/11] qcow2: Reuse refcount table in calculate_refcounts()

2014-10-20 Thread Kevin Wolf
Am 20.10.2014 um 16:35 hat Max Reitz geschrieben: > We will later call calculate_refcounts multiple times, so reuse the > refcount table if possible. > > Signed-off-by: Max Reitz > Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [question] savevm/delvm: Is it necessary to perform bdrv_drain_all before savevm and delvm?

2014-10-20 Thread Zhang Haoyu
>> Hi, >> >> I noticed that bdrv_drain_all is performed in load_vmstate before bdrv_snapshot_goto, >> and bdrv_drain_all is performed in qmp_transaction before internal_snapshot_prepare, >> so is it also neccesary to perform bdrv_drain_all in savevm and delvm? > >Definitely yes for savevm. do_s

Re: [Qemu-devel] [PATCH V5 8/8] acpi/cpu-hotplug: introduce helper function to keep bit setting in one place

2014-10-20 Thread Igor Mammedov
On Fri, 10 Oct 2014 10:16:07 +0800 Gu Zheng wrote: > Introduce helper function acpi_set_cpu_present_bit() to simplify > acpi_cpu_plug_cb > and acpi_cpu_hotplug_init, so that we can keep bit setting in one place. > > Signed-off-by: Gu Zheng > --- > v5: > -rename acpi_set_local_sts to acpi_set_

Re: [Qemu-devel] [PATCH 1/4] block: add accounting for merged requests

2014-10-20 Thread Max Reitz
On 20.10.2014 at 16:35, Peter Lieven wrote: Signed-off-by: Peter Lieven --- block.c|2 ++ block/accounting.c |8 +++- block/qapi.c |2 ++ hmp.c |6 +- include/block/accounting.h |3 +++ qapi/block-c

Re: [Qemu-devel] [PATCH v6 04/11] qcow2: Pull check_refblocks() up

2014-10-20 Thread Kevin Wolf
Am 20.10.2014 um 16:35 hat Max Reitz geschrieben: > Pull check_refblocks() before calculate_refcounts() so we can drop its > static declaration. > > Signed-off-by: Max Reitz > Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-20 Thread Eric Blake
On 10/20/2014 03:19 AM, Markus Armbruster wrote: > Contributors rely on this script to find maintainers to copy. The > script falls back to git when no exact MAINTAINERS pattern matches. > When that happens, recent contributors get copied, which tends not be > particularly useful. Some contributo

Re: [Qemu-devel] [PATCH V5 7/8] cpu-hotplug: rename function for better readability

2014-10-20 Thread Igor Mammedov
On Fri, 10 Oct 2014 10:16:06 +0800 Gu Zheng wrote: > Rename: > AcpiCpuHotplug_init --> acpi_cpu_hotplug_init > AcpiCpuHotplug_ops --> acpi_cpu_hotplug_ops > for better readability, just cleanup. > > Signed-off-by: Gu Zheng Reviewed-by: Igor Mammedov > --- > hw/acpi/cpu_hotplug.c |

Re: [Qemu-devel] [RFC 0/7] Optional toplevel sections

2014-10-20 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 15/10/2014 17:59, Juan Quintela ha scritto: > > My idea here is that, if you don't use libvirt, you just start without > > -S. > > If you don't use libvirt or any other QEMU management layer, you're not > going to do migration except for debugging

[Qemu-devel] [PATCH v6 11/11] iotests: Add test for potentially damaging repairs

2014-10-20 Thread Max Reitz
There are certain cases where repairing a qcow2 image might actually damage it further (or rather, where repairing it has in fact damaged it further with the old qcow2 check implementation). This should not happen, so add a test for these cases. Furthermore, the repair function now repairs refbloc

Re: [Qemu-devel] [PATCH V5 5/8] pc: Update rtc_cmos in pc_cpu_plug

2014-10-20 Thread Igor Mammedov
On Fri, 10 Oct 2014 10:16:04 +0800 Gu Zheng wrote: > Update rtc_cmos in pc_cpu_plug() directly, instead of the notifier. > > Signed-off-by: Gu Zheng Reviewed-by: Igor Mammedov > --- > v5: > -move CPU hot-plug notifier cleanup hunk into Patch 6/8. > > v4: > -Make link property in PCMachine

Re: [Qemu-devel] [PATCH V5 4/8] pc: add cpu hotplug handler to PC_MACHINE

2014-10-20 Thread Igor Mammedov
On Fri, 10 Oct 2014 10:16:03 +0800 Gu Zheng wrote: > Add cpu hotplug handler to PC_MACHINE, which will perform the acpi > cpu hotplug callback via hotplug_handler API. > > Signed-off-by: Gu Zheng Reviewed-by: Igor Mammedov > --- > v5: > -split the check out of acpi_dev block. > v3: > -deal

Re: [Qemu-devel] [PATCH v5 03/11] qcow2: Split qcow2_check_refcounts()

2014-10-20 Thread Kevin Wolf
Am 29.08.2014 um 23:40 hat Max Reitz geschrieben: > Put the code for calculating the reference counts and comparing them > during qemu-img check into own functions. > > Signed-off-by: Max Reitz > Reviewed-by: Benoît Canet > +static int calculate_refcounts(BlockDriverState *bs, BdrvCheckResult *

Re: [Qemu-devel] [PATCH V5 3/8] acpi:piix4: convert cpu hotplug to hotplug_handler API

2014-10-20 Thread Igor Mammedov
On Fri, 10 Oct 2014 10:16:02 +0800 Gu Zheng wrote: > Convert notifier based hotplug to hotplug_handler API, > and remove the unused AcpiCpuHotplug_add(). > > Signed-off-by: Gu Zheng Reviewed-by: Igor Mammedov > --- > v5: > -drop 'handle' from the comment and subject. > v2: > -remove the unu

[Qemu-devel] [PATCH 0/4] multiwrite patches for 2.2

2014-10-20 Thread Peter Lieven
This adds some preparing patches for upcoming multiwrite modifications. I will leave the dangerous patches for after 2.2 release. Peter Lieven (4): block: add accounting for merged requests block: introduce bdrv_runtime_opts block: add a knob to disable multiwrite_merge hw/virtio-blk: add

Re: [Qemu-devel] [PATCH V5 2/8] acpi:ich9: convert cpu hotplug to hotplug_handler API

2014-10-20 Thread Igor Mammedov
On Fri, 10 Oct 2014 10:16:01 +0800 Gu Zheng wrote: > Convert notifier based hotplug to hotplug_handler API. > > Signed-off-by: Gu Zheng Reviewed-by: Igor Mammedov > --- > v5: > -drop 'handle' from the comment and subject. > > hw/acpi/ich9.c | 13 ++--- > include/hw/acpi/i

Re: [Qemu-devel] [PATCH v5 01/11] qcow2: Calculate refcount block entry count

2014-10-20 Thread Max Reitz
On 20.10.2014 at 16:25, Kevin Wolf wrote: Am 29.08.2014 um 23:40 hat Max Reitz geschrieben: The size of a refblock entry is (in theory) variable; calculate therefore the number of entries per refblock and the according bit shift (1 << x == entry count) when opening an image. Signed-off-by: Max

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Knut Omang
On Mon, 2014-10-20 at 20:14 +0800, Le Tan wrote: > Hi Markus, > > 2014-10-20 19:41 GMT+08:00 Markus Armbruster : > > "Michael S. Tsirkin" writes: > > > >> (((sid) >> 8) && 0xff) makes no sense > >> (((sid) >> 8) & 0xff) seems to be what was meant. > >> > >> Suggested-by: Markus Armbruster > > >

Re: [Qemu-devel] [PATCH v5 01/11] qcow2: Calculate refcount block entry count

2014-10-20 Thread Kevin Wolf
Am 20.10.2014 um 16:39 hat Max Reitz geschrieben: > On 20.10.2014 at 16:25, Kevin Wolf wrote: > >Am 29.08.2014 um 23:40 hat Max Reitz geschrieben: > >>The size of a refblock entry is (in theory) variable; calculate > >>therefore the number of entries per refblock and the according bit shift > >>(1

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Jan Kiszka
On 2014-10-20 16:23, Michael S. Tsirkin wrote: > > WRT intel_iommu, it does not yet seem to be as fully functional as I > hoped. What is missing or broken? > People also discussed the best way to handle virtio versus iommu > (it bypasses it ATM). We need to declare in the ACPI tables that the

Re: [Qemu-devel] [PATCH v3 6/6] hw/arm/virt: Support dynamically spawned sysbus devices

2014-10-20 Thread Eric Auger
On 09/09/2014 01:11 PM, Paolo Bonzini wrote: > Il 09/09/2014 09:54, Eric Auger ha scritto: >> Allows sysbus devices to be instantiated from command line by >> using -device option >> >> Signed-off-by: Alexander Graf >> Signed-off-by: Eric Auger >> >> --- >> >> v2 -> v3 >> - renaming of arm_platfo

[Qemu-devel] [PATCH 4/4] hw/virtio-blk: add a constant for max number of merged requests

2014-10-20 Thread Peter Lieven
As it was not obvious (at least for me) where the 32 comes from add a constant for it. Signed-off-by: Peter Lieven --- hw/block/virtio-blk.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 6051027..23bc948 100644 --- a

Re: [Qemu-devel] [PULL 3/7] balloon: re-enable balloon stats

2014-10-20 Thread Simon Pickartz
Am 25.01.13 um 15:14 schrieb Luiz Capitulino: The statistics are now available through device properties via a polling mechanism. First a client has to enable polling, then it can query available stats. Polling is enabled by setting an update interval (in seconds) to a property named guest-stats

[Qemu-devel] [PATCH 3/4] block: add a knob to disable multiwrite_merge

2014-10-20 Thread Peter Lieven
the block layer silently merges write requests since commit 40b4f539. This patch adds a knob to disable this feature as there has been some discussion lately if multiwrite is a good idea at all and as it falsifies benchmarks. Signed-off-by: Peter Lieven --- block.c |9 +

[Qemu-devel] [PATCH 2/4] block: introduce bdrv_runtime_opts

2014-10-20 Thread Peter Lieven
This patch (orginally by Kevin) adds a bdrv_runtime_opts QemuOptsList. The list will absorb all options that belong to the BDS (and not the BlockBackend) and will be parsed and handled in bdrv_open_common. Signed-off-by: Kevin Wolf Signed-off-by: Peter Lieven --- block.c | 39

Re: [Qemu-devel] [PATCH V5 1/8] acpi/cpu: add cpu hotplug callback function to match hotplug_handler API

2014-10-20 Thread Igor Mammedov
On Fri, 10 Oct 2014 10:16:00 +0800 Gu Zheng wrote: > Add cpu hotplug callback function (acpi_cpu_plug_cb) to match hotplug_handler > API. > > Signed-off-by: Gu Zheng > --- Reviewed-by: Igor Mammedov > v4: > -convert CPUState *cpu to DeviceState *dev like it's done for other handlers > and

[Qemu-devel] [PATCH 1/4] block: add accounting for merged requests

2014-10-20 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c|2 ++ block/accounting.c |8 +++- block/qapi.c |2 ++ hmp.c |6 +- include/block/accounting.h |3 +++ qapi/block-core.json |9 - 6 files changed, 27

[Qemu-devel] [PATCH v6 08/11] qcow2: Rebuild refcount structure during check

2014-10-20 Thread Max Reitz
The previous commit introduced the "rebuild" variable to qcow2's implementation of the image consistency check. Now make use of this by adding a function which creates a completely new refcount structure based solely on the in-memory information gathered before. The old refcount structure will be

[Qemu-devel] [PATCH v6 07/11] qcow2: Do not perform potentially damaging repairs

2014-10-20 Thread Max Reitz
If a referenced cluster has a refcount of 0, increasing its refcount may result in clusters being allocated for the refcount structures. This may overwrite the referenced cluster, therefore we cannot simply increase the refcount then. In such cases, we can either try to replicate all the refcount

[Qemu-devel] [PATCH v6 03/11] qcow2: Split qcow2_check_refcounts()

2014-10-20 Thread Max Reitz
Put the code for calculating the reference counts and comparing them during qemu-img check into own functions. Signed-off-by: Max Reitz Reviewed-by: Benoît Canet --- block/qcow2-refcount.c | 153 - 1 file changed, 102 insertions(+), 51 deletions(-

[Qemu-devel] [PATCH v6 04/11] qcow2: Pull check_refblocks() up

2014-10-20 Thread Max Reitz
Pull check_refblocks() before calculate_refcounts() so we can drop its static declaration. Signed-off-by: Max Reitz Reviewed-by: Benoît Canet --- block/qcow2-refcount.c | 102 - 1 file changed, 49 insertions(+), 53 deletions(-) diff --git a/block

[Qemu-devel] [PATCH v6 09/11] qcow2: Clean up after refcount rebuild

2014-10-20 Thread Max Reitz
Because the old refcount structure will be leaked after having rebuilt it, we need to recalculate the refcounts and run a leak-fixing operation afterwards (if leaks should be fixed at all). Signed-off-by: Max Reitz Reviewed-by: Benoît Canet --- block/qcow2-refcount.c | 35 ++

[Qemu-devel] [PATCH v6 01/11] qcow2: Calculate refcount block entry count

2014-10-20 Thread Max Reitz
The size of a refblock entry is (in theory) variable; calculate therefore the number of entries per refblock and the according bit shift (1 << x == entry count) when opening an image. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2.c | 3 +++ block/qcow2.h | 2 ++ 2 files chang

[Qemu-devel] [PATCH v6 10/11] iotests: Fix test outputs

2014-10-20 Thread Max Reitz
039, 060 and 061 all create images with referenced clusters having a refcount of 0. Because previous commits changed handling of such errors, these tests now have a different output. Fix it. Furthermore, 060 created a refblock with a refcount greater than one which now results in having to rebuild

[Qemu-devel] [PATCH v6 05/11] qcow2: Reuse refcount table in calculate_refcounts()

2014-10-20 Thread Max Reitz
We will later call calculate_refcounts multiple times, so reuse the refcount table if possible. Signed-off-by: Max Reitz Reviewed-by: Benoît Canet --- block/qcow2-refcount.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-ref

[Qemu-devel] [PATCH v6 02/11] qcow2: Fix leaks in dirty images

2014-10-20 Thread Max Reitz
When opening dirty images, qcow2's repair function should not only repair errors but leaks as well. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoît Canet --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c ind

[Qemu-devel] [PATCH v6 06/11] qcow2: Fix refcount blocks beyond image end

2014-10-20 Thread Max Reitz
If the qcow2 check function detects a refcount block located beyond the image end, grow the image appropriately. This cannot break anything and is the logical fix for such a case. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-refcount.c | 62 ++

[Qemu-devel] [PATCH v6 00/11] qcow2: Fix image repairing

2014-10-20 Thread Max Reitz
As can be seen in the final patch of this series, there are certain cases where the current repair implementation of qcow2 actually damages the image further because it allocates new clusters for the refcount structure which overlap with existing but according to the on-disk refcounts (which are as

Re: [Qemu-devel] [PATCH v5 02/11] qcow2: Fix leaks in dirty images

2014-10-20 Thread Kevin Wolf
Am 29.08.2014 um 23:40 hat Max Reitz geschrieben: > When opening dirty images, qcow2's repair function should not only > repair errors but leaks as well. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 6/6] target-mips: enable features in MIPS64R6-generic CPU

2014-10-20 Thread Yongbok Kim
On 14/07/2014 17:19, Leon Alrae wrote: Signed-off-by: Leon Alrae --- target-mips/translate_init.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c index bcfc46a..0b70d05 100644 --- a/target-mips/trans

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-20 Thread Peter Maydell
On 20 October 2014 15:15, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote: >> On 20 October 2014 10:19, Markus Armbruster wrote: >> > Contributors rely on this script to find maintainers to copy. The >> > script falls back to git when no exact MAINTAINER

Re: [Qemu-devel] [PATCH] intel_iommu: fix VTD_SID_TO_BUS

2014-10-20 Thread Michael S. Tsirkin
WRT intel_iommu, it does not yet seem to be as fully functional as I hoped. People also discussed the best way to handle virtio versus iommu (it bypasses it ATM). I'd like to suggest we hide the iommu from the command line help for 2.2, this way people don't activate it mistakenly. Let's make it

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-20 Thread Greg Kurz
On Mon, 20 Oct 2014 09:58:50 +0300 "Michael S. Tsirkin" wrote: > Current support for bus master (clearing OK bit) together with the need to > support guests which do not enable PCI bus mastering, leads to extra state in > VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of > cross-v

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-20 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 03:04:44PM +0100, Peter Maydell wrote: > On 20 October 2014 10:19, Markus Armbruster wrote: > > Contributors rely on this script to find maintainers to copy. The > > script falls back to git when no exact MAINTAINERS pattern matches. > > When that happens, recent contribut

Re: [Qemu-devel] Patch checking bot

2014-10-20 Thread Peter Maydell
On 20 October 2014 11:25, Stefan Hajnoczi wrote: > Hi, > At KVM Forum 2014 we discussed a patch checking bot that automates patch > format checking and smoke testing: > > 1. Did the patch submitter include Signed-off-by? > 2. Does checkpatch.pl pass? > 3. Does the patch apply to qemu.git/master? >

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-20 Thread Peter Maydell
On 20 October 2014 10:19, Markus Armbruster wrote: > Contributors rely on this script to find maintainers to copy. The > script falls back to git when no exact MAINTAINERS pattern matches. > When that happens, recent contributors get copied, which tends not be > particularly useful. Some contrib

Re: [Qemu-devel] [question] savevm/delvm: Is it neccesary to perform bdrv_drain_all before savevm and delvm?

2014-10-20 Thread Kevin Wolf
Am 20.10.2014 um 15:48 hat Zhang Haoyu geschrieben: > Hi, > > I noticed that bdrv_drain_all is performed in load_vmstate before > bdrv_snapshot_goto, > and bdrv_drain_all is performed in qmp_transaction before > internal_snapshot_prepare, > so is it also neccesary to perform bdrv_drain_all in sa

  1   2   3   >