Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-22 Thread Michael Tokarev
On 10/22/2014 05:25 PM, Arthur Gautier wrote: > We can not rely on int cast to get a correct number of cylinders. The > cylinders information was wrong in 49.% of cases. > > This ensures the cylinders always gets the ceiling value. Good thing, especially the good probability :), and also a go

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1] vl: Fix possible freed memory accessing

2014-10-22 Thread Markus Armbruster
Michael Tokarev writes: > On 09/22/2014 11:34 AM, Michael Tokarev wrote: >> 22.09.2014 10:23, Markus Armbruster wrote: >>> Michael Tokarev writes: >>> Applied to -trivial, thank you! >>> >>> Makes my 'hmp: Remove "info pcmcia"' conflict. Either revert this one >>> before applying mine, or

Re: [Qemu-devel] [Qemu-trivial] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'

2014-10-22 Thread Michael Tokarev
On 10/21/2014 07:50 PM, Peter Maydell wrote: > On 9 October 2014 15:00, Chen Gang wrote: [] >> --- a/disas/libvixl/a64/instructions-a64.h >> +++ b/disas/libvixl/a64/instructions-a64.h >> @@ -95,30 +95,6 @@ const unsigned kDoubleExponentBits = 11; >> const unsigned kFloatMantissaBits = 23; >> con

Re: [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-22 Thread Jan Kiszka
On 2014-10-22 22:34, Benjamin Herrenschmidt wrote: > On Wed, 2014-10-22 at 16:17 +0200, Jan Kiszka wrote: >> I thought about this again, and I'm not sure anymore if we can use >> ACPI >> to "black-list" the incompatible virtio devices. Reason: hotplug. To >> my >> understanding, the ACPI DRHD table

Re: [Qemu-devel] [Qemu-trivial] [PATCH] util: Improve os_mem_prealloc error message

2014-10-22 Thread Michael Tokarev
On 10/16/2014 05:13 PM, Michal Privoznik wrote: > Currently, when the preallocating guest memory process fails, an not > so helpful error message is printed out: [..] Applied to -trivial finally, with small commit message corrections from Eric. Thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] sparse: fix build

2014-10-22 Thread Michael Tokarev
On 10/15/2014 01:51 PM, Gerd Hoffmann wrote: > c++ compiler isn't wrapped with cgcc, resulting in gcc complaining about > the sparse compiler flags which it doesn't know in case qemu is built > with --enable-sparse. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-arm: A64: remove redundant store

2014-10-22 Thread Michael Tokarev
On 10/15/2014 11:16 AM, Alex Bennée wrote: > There is not much point storing the same value twice in a row. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-xtensa: mark XtensaConfig structs as unused

2014-10-22 Thread Michael Tokarev
On 10/10/2014 08:24 PM, Peter Maydell wrote: > On 14 September 2014 21:29, Max Filippov wrote: >> On Sun, Sep 14, 2014 at 12:36 PM, Peter Maydell >> wrote: >>> The XtensaConfig structs will be defined but not used if they are >>> for the opposite endianness from that of the binary being built; >>

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/3] bitops: Header dependency fixes

2014-10-22 Thread Michael Tokarev
On 09/26/2014 11:46 PM, Eduardo Habkost wrote: > This series adds a missing include, kills a circular header dependency, and > avoid including qemu-common.h from a header to avoid new circular > dependencies. > > Eduardo Habkost (3): > tests: Add missing include to test-bitops.c > bitops.h: D

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1] vl: Fix possible freed memory accessing

2014-10-22 Thread Michael Tokarev
On 09/22/2014 11:34 AM, Michael Tokarev wrote: > 22.09.2014 10:23, Markus Armbruster wrote: >> Michael Tokarev writes: >> >>> Applied to -trivial, thank you! >> >> Makes my 'hmp: Remove "info pcmcia"' conflict. Either revert this one >> before applying mine, or resolve the conflict and drop the p

[Qemu-devel] [PATCH] vnc: fix fd leak at vnc_display_open()

2014-10-22 Thread arei.gonglei
From: Gonglei When using qmp change vnc interface, will leak fd of vs->lsock and vs->lwebsock (if configed). Close them before: re-evaluate. Signed-off-by: Gonglei --- This patch based on my just prvious vnc patch seires. Easy to reproduce this leak: $ ./qemu-system-x86_64 [...] -monitor stdi

Re: [Qemu-devel] [PATCH] i386: fix breakpoints handling in icount mode

2014-10-22 Thread Pavel Dovgaluk
> From: Frederic Konrad [mailto:fred.kon...@greensocs.com] > On 22/10/2014 13:38, Pavel Dovgalyuk wrote: > > Hi Pavel, > > This patch fixes instructions counting when execution is stopped on > > breakpoint (e.g. set from gdb). Without a patch extra instruction is > > translated > > and icount is

[Qemu-devel] [PATCH 3/3] vnc: remove superfluous DisplayState *ds parameter

2014-10-22 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- include/ui/console.h | 2 +- qmp.c| 2 +- ui/vnc.c | 2 +- vl.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 22ef8ca..8cc48cc 100644 -

[Qemu-devel] [PATCH 0/3] vnc: trivial problem and memory leak fix

2014-10-22 Thread arei.gonglei
From: Gonglei Beside those problems, I also found another issue, see below pls. Qemu command line: $ ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 -drive file=/home/redhat.img,if=none,id=drive-ide0-0-0 -device ide-hd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex

[Qemu-devel] [PATCH 1/3] vnc: remove superfluous vnc_display_close()

2014-10-22 Thread arei.gonglei
From: Gonglei vnc_display_close() is called in vnc_display_open(). And in this moment, the ds variable is initilized at vnc_display_init(). Calling vnc_display_close() is superfluous. For another scenario, qmp_change_vnc_listen() pass NULL into vnc_display_open(), which is not influenced too. L

[Qemu-devel] [PATCH 2/3] vnc: fix memory leak at vnc_display_open

2014-10-22 Thread arei.gonglei
From: Gonglei When using qmp change vnc interface, will leak memory of vs->display and vs->ws_display (if configed). Free them before calling g_strdup()/g_strconcat(). Signed-off-by: Gonglei --- ui/vnc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 628a7ba..3

Re: [Qemu-devel] [PATCHv4 1/4] util: introduce MIN_NON_ZERO

2014-10-22 Thread Eric Blake
On 10/16/2014 01:54 AM, Peter Lieven wrote: > at least in block layer we have the case of limits being defined for a > BlockDriverState. However, in this context often zero (0) has the special > meanining of undefined which means no limit. If two of those limits are > combined and the minimum is ne

[Qemu-devel] [Bug 1384343] Re: 2.1.2 build broken with --prefix

2014-10-22 Thread Ethan Grammatikidis
my bad; i missed the initial path element from the prefix. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1384343 Title: 2.1.2 build broken with --

[Qemu-devel] [Bug 1384343] Re: 2.1.2 build broken on latest slackware

2014-10-22 Thread Ethan Grammatikidis
** Description changed: building qemu 2.1.2 on slackware 14.1 with make -j6, libtool gives an error. this is it, with some context:   LINK tests/qemu-iotests/socket_scm_helper   CPP optionrom/kvmvapic.asm   ASoptionrom/multiboot.o   ASoptionrom/linuxboot.o lt LINK libca

[Qemu-devel] [Bug 1384343] [NEW] 2.1.2 build broken on latest slackware

2014-10-22 Thread Ethan Grammatikidis
Public bug reported: building qemu 2.1.2 on slackware 14.1 with make -j6, libtool gives an error. this is it, with some context:   LINK tests/qemu-iotests/socket_scm_helper   CPP optionrom/kvmvapic.asm   ASoptionrom/multiboot.o   ASoptionrom/linuxboot.o lt LINK libcacard.la   ASopt

[Qemu-devel] [Bug 1384343] Re: 2.1.2 build broken on latest slackware

2014-10-22 Thread Ethan Grammatikidis
** Description changed: building qemu 2.1.2 on slackware 14.1 with make -j6, libtool gives an error. this is it, with some context: - LINK tests/qemu-iotests/socket_scm_helper - CPP optionrom/kvmvapic.asm - ASoptionrom/multiboot.o - ASoptionrom/linuxboot.o +   LINK tests

[Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-22 Thread Chao Peng
Add AVX512 feature bits, register definition and corresponding xsave/vmstate support. Signed-off-by: Chao Peng --- target-i386/cpu.c | 10 -- target-i386/cpu.h | 61 ++ target-i386/kvm.c | 19 +++ target-i386/machine.c | 87

Re: [Qemu-devel] [PATCH] snapshot: use local variable to bdrv_pwrite_sync L1 table

2014-10-22 Thread Gonglei
On 2014/10/23 6:18, Eric Blake wrote: > On 10/21/2014 03:24 AM, Max Reitz wrote: >> On 2014-10-21 at 10:04, Zhang Haoyu wrote: >>> Use local variable to bdrv_pwrite_sync L1 table, >>> needless to make conversion of cached L1 table between >>> big-endian and host style. >>> >>> Signed-off-by: Zhang

Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory

2014-10-22 Thread zhanghailiang
Hi, Ping... This patch has been reviewed, please pick up, Thanks. Best Regargs, zhanghailiang On 2014/10/17 17:02, Gonglei wrote: On 2014/10/17 16:50, zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For

[Qemu-devel] [Bug 1368815] Re: qemu-img convert intermittently corrupts output images

2014-10-22 Thread Tony Breeds
FWIW the following 2 commits in qemu master resolve the issue for qemu- img. http://git.qemu.org/?p=qemu.git;a=commit;h=38c4d0aea3e1264c86e282d99560330adf2b6e25 http://git.qemu.org/?p=qemu.git;a=commit;h=7c15903789953ead14a417882657d52dc0c19a24 If possible they should be back ported to trus

Re: [Qemu-devel] [PATCH] snapshot: use local variable to bdrv_pwrite_sync L1 table

2014-10-22 Thread Eric Blake
On 10/21/2014 03:24 AM, Max Reitz wrote: > On 2014-10-21 at 10:04, Zhang Haoyu wrote: >> Use local variable to bdrv_pwrite_sync L1 table, >> needless to make conversion of cached L1 table between >> big-endian and host style. >> >> Signed-off-by: Zhang Haoyu >> --- >> block/qcow2-refcount.c | 22

Re: [Qemu-devel] Crashes of qemu-system-mips64 and qemu-system-mips64el

2014-10-22 Thread Aurelien Jarno
On Wed, Oct 22, 2014 at 10:31:45PM +0200, Torbjörn Granlund wrote: > Aurelien Jarno writes: > > On Fri, Oct 17, 2014 at 08:57:38PM +0200, Torbjörn Granlund wrote: > > Aurelien Jarno writes: > > > > I am using 2.1.2 under GNU/Linux. > > > > Ah, so you're not trying to reproduc

[Qemu-devel] [Bug 1383857] Re: aarch64: virtio disks don't show up in guest (neither blk nor scsi)

2014-10-22 Thread Richard Jones
Finally finished the git bisect (of the guest kernel, not qemu): 421520ba98290a73b35b7644e877a48f18e06004 is the first bad commit commit 421520ba98290a73b35b7644e877a48f18e06004 Author: Yalin Wang Date: Fri Sep 26 03:07:09 2014 +0100 ARM: 8167/1: extend the reserved memory for initrd to be

[Qemu-devel] Qemu Memory Management Files

2014-10-22 Thread Shiva
Hello I am new to qemu. I installed the qemu from source and would like to know how the memory management in qemu is performed? (the flow). What are the files involved? My aim is to have a encrypted region created when the qemu starts up the guest. So, for sure I need to change the existing MMU

Re: [Qemu-devel] [PATCH] libqos: Convert malloc-pc allocator to a generic allocator

2014-10-22 Thread Marc Marí
> > +void alloc_uninit(QGuestAllocator *allocator) > > +{ > > +MemBlock *node; > > +MemBlock *tmp; > > +QAllocOpts mask; > > + > > +/* Check for guest leaks, and destroy the list. */ > > +QTAILQ_FOREACH_SAFE(node, &allocator->used, MLIST_ENTNAME, > > tmp) { > > +if (allo

Re: [Qemu-devel] A Patch to enable qemu-nbd run as an inetd service

2014-10-22 Thread Eric Blake
On 10/22/2014 12:54 PM, Jun Sheng wrote: > From: Chaos Eternal > > > run qemu-nbd as an inetd service has some benefits > * more scriptable, such as serve multiple images to different clients > on one ip/port > * access control using tcpd > > @@ -363,7 +365,13 @@ static void nbd_accept(void *o

Re: [Qemu-devel] [PULL v2 0/9] pc, virtio, misc bugfixes

2014-10-22 Thread Peter Maydell
On 22 October 2014 09:18, Michael S. Tsirkin wrote: > The following changes since commit 5f77ef69a195098baddfdc6d189f1b4a94587378: > > glib: add compatibility interface for g_strcmp0() (2014-10-16 23:02:31 > +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/v

Re: [Qemu-devel] [PULL 0/5] target-tricore patches

2014-10-22 Thread Peter Maydell
On 21 October 2014 17:54, Bastian Koppelmann wrote: > The following changes since commit 5f77ef69a195098baddfdc6d189f1b4a94587378: > > glib: add compatibility interface for g_strcmp0() (2014-10-16 23:02:31 > +0100) > > are available in the git repository at: > > https://github.com/bkoppelmann

Re: [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-22 Thread Benjamin Herrenschmidt
On Wed, 2014-10-22 at 16:17 +0200, Jan Kiszka wrote: > I thought about this again, and I'm not sure anymore if we can use > ACPI > to "black-list" the incompatible virtio devices. Reason: hotplug. To > my > understanding, the ACPI DRHD tables won't change during runtime when a > device shows up or

Re: [Qemu-devel] Crashes of qemu-system-mips64 and qemu-system-mips64el

2014-10-22 Thread Torbjörn Granlund
Aurelien Jarno writes: On Fri, Oct 17, 2014 at 08:57:38PM +0200, Torbjörn Granlund wrote: > Aurelien Jarno writes: > > I am using 2.1.2 under GNU/Linux. > > Ah, so you're not trying to reproduce the problem! I do. Well you talked about 2.1.0, the latest stable one is 2.1

Re: [Qemu-devel] [PATCHv2 3/6] block: add a knob to disable multiwrite_merge

2014-10-22 Thread Peter Lieven
Am 22.10.2014 um 20:29 schrieb Eric Blake: > On 10/22/2014 07:21 AM, Peter Lieven wrote: >> The block layer silently merges write requests since >> commit 40b4f539. This patch adds a knob to disable >> this feature as there has been some discussion lately >> if multiwrite is a good idea at all and

Re: [Qemu-devel] [PATCHv2 1/6] block: add accounting for merged requests

2014-10-22 Thread Peter Lieven
Am 22.10.2014 um 20:20 schrieb Eric Blake: > On 10/22/2014 07:21 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> Reviewed-by: Max Reitz >> --- >> block.c|2 ++ >> block/accounting.c |7 +++ >> block/qapi.c |2 ++ >> hmp.c

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

2014-10-22 Thread Don Slutz
On 10/22/14 04:29, Michael S. Tsirkin wrote: On Wed, Oct 22, 2014 at 10:03:53AM +0200, Markus Armbruster wrote: "Michael S. Tsirkin" writes: On Wed, Oct 22, 2014 at 09:01:24AM +0200, Markus Armbruster wrote: "Michael S. Tsirkin" writes: On Tue, Oct 21, 2014 at 03:34:46PM +0200, Markus Arm

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Remove the --git-chief-penguins option

2014-10-22 Thread Don Slutz
On 10/22/14 08:28, Thomas Huth wrote: Linus likely does not want to get e-mails about QEMU, so let's just remove this option. Suggested-by: Michael S. Tsirkin Signed-off-by: Thomas Huth Looks good to me. Reviewed-by: Don Slutz -Don Slutz --- scripts/get_maintainer.pl | 45 +-

Re: [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty()

2014-10-22 Thread Kevin Wolf
Am 22.10.2014 um 14:51 hat Max Reitz geschrieben: > bdrv_make_empty() is currently only called if the current image > represents an external snapshot that has been committed to its base > image; it is therefore unlikely to have internal snapshots. In this > case, bdrv_make_empty() can be greatly sp

[Qemu-devel] A Patch to enable qemu-nbd run as an inetd service

2014-10-22 Thread Jun Sheng
From: Chaos Eternal run qemu-nbd as an inetd service has some benefits * more scriptable, such as serve multiple images to different clients on one ip/port * access control using tcpd simple usage: #!/bin/sh # qemu-nbd wrapper, select image file according to client ip address IMG_FILE=`sed -n "

Re: [Qemu-devel] [PATCHv2 3/6] block: add a knob to disable multiwrite_merge

2014-10-22 Thread Eric Blake
On 10/22/2014 07:21 AM, Peter Lieven wrote: > The block layer silently merges write requests since > commit 40b4f539. This patch adds a knob to disable > this feature as there has been some discussion lately > if multiwrite is a good idea at all and as it falsifies > benchmarks. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] hw/pci: fixed crash when using rombar=0 for hotplugged devices

2014-10-22 Thread Marcel Apfelbaum
On Wed, 2014-10-22 at 10:26 -0600, Alex Williamson wrote: > On Wed, 2014-10-22 at 11:02 +0300, Michael S. Tsirkin wrote: > > On Wed, Oct 22, 2014 at 10:41:05AM +0300, Marcel Apfelbaum wrote: > > > On Wed, 2014-10-22 at 00:06 +0200, Paolo Bonzini wrote: > > > > > > > > On 10/21/2014 02:37 PM, Marce

Re: [Qemu-devel] [PATCHv2 1/6] block: add accounting for merged requests

2014-10-22 Thread Eric Blake
On 10/22/2014 07:21 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > Reviewed-by: Max Reitz > --- > block.c|2 ++ > block/accounting.c |7 +++ > block/qapi.c |2 ++ > hmp.c |6 +- > include/block/accoun

Re: [Qemu-devel] [Bug 1362755] [NEW] QEmu +2 does not route VLAN tagged packets, that are originated within the Hypervisor itself.

2014-10-22 Thread Martinx - ジェームズ
Guys, In fact, the "ethtool" workaround is far from perfect, I'm still seeing lots of connectivity issues within my KVM Host and its Guests, even after disabling gso/tso/tx on all interfaces, both virtual (within guests) and physical (at the host). I really appreciate any help! Thanks! Thiago O

Re: [Qemu-devel] [PATCH] vfio: fix adding memory listener to the right address space

2014-10-22 Thread Alex Williamson
On Sat, 2014-10-18 at 07:04 +0200, Frank Blaschka wrote: > Depending on the device, container->space->as contains the valid AddressSpace. > Using address_space_memory breaks devices sitting behind an iommu (and using > a separate address space). > > Signed-off-by: Frank Blaschka > --- > hw/misc/

Re: [Qemu-devel] [PULL 0/1] s390x files MAINTAINERS update

2014-10-22 Thread Peter Maydell
On 21 October 2014 12:05, Cornelia Huck wrote: > The following changes since commit 5f77ef69a195098baddfdc6d189f1b4a94587378: > > glib: add compatibility interface for g_strcmp0() (2014-10-16 23:02:31 > +0100) > > are available in the git repository at: > > git://github.com/cohuck/qemu.git ta

[Qemu-devel] [PATCH] hw/ppc/spapr_pci.c: Avoid functions not in glib 2.12 (g_hash_table_iter_*)

2014-10-22 Thread Peter Maydell
The g_hash_table_iter_* functions for iterating through a hash table are not present in glib 2.12, which is our current minimum requirement. Rewrite the code to use g_hash_table_foreach() instead. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Maydell --- I have tested that this builds with a gl

Re: [Qemu-devel] [PULL 00/28] Block patches

2014-10-22 Thread Peter Maydell
On 20 October 2014 14:35, Kevin Wolf wrote: > The following changes since commit 5f77ef69a195098baddfdc6d189f1b4a94587378: > > glib: add compatibility interface for g_strcmp0() (2014-10-16 23:02:31 > +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/f

Re: [Qemu-devel] [PATCH] vfio: check if host device supports INTx

2014-10-22 Thread Alex Williamson
On Wed, 2014-10-22 at 17:13 +0200, Frank Blaschka wrote: > From: Frank Blaschka > > Let the kernel announce if INTx is available. Yes, there are platforms > (e.g. s390) which do not support INTx. > > Signed-off-by: Frank Blaschka > --- > hw/misc/vfio.c | 18 +- > 1 file changed

Re: [Qemu-devel] [PATCH v13 14/14] iotests: Add test for qcow2's bdrv_make_empty

2014-10-22 Thread Eric Blake
On 10/22/2014 06:51 AM, Max Reitz wrote: > Add a test for qcow2's fast bdrv_make_empty implementation on images > without internal snapshots. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/098 | 79 > ++ > tests/qemu-iotests/098.out | 45

Re: [Qemu-devel] [PATCH v3 2/3] raw-posix: raw_co_get_block_status() return value

2014-10-22 Thread Eric Blake
On 10/22/2014 09:57 AM, Max Reitz wrote: > Instead of generating the full return value thrice in try_fiemap(), > try_seek_hole() and as a fall-back in raw_co_get_block_status() itself, > generate the value only in raw_co_get_block_status(). > > While at it, also remove the pnum parameter from try_

Re: [Qemu-devel] [PATCH v3 1/3] raw-posix: Fix raw_co_get_block_status() after EOF

2014-10-22 Thread Eric Blake
On 10/22/2014 09:57 AM, Max Reitz wrote: > As its comment states, raw_co_get_block_status() should unconditionally > return 0 and set *pnum to 0 for after EOF. > > An assertion after lseek(..., SEEK_HOLE) tried to catch this case by > asserting that errno != -ENXIO (which would indicate a position

Re: [Qemu-devel] [PATCH v3 3/3] iotests: Add test for external image truncation

2014-10-22 Thread Eric Blake
On 10/22/2014 09:57 AM, Max Reitz wrote: > It should not be happening, but it is possible to truncate an image > outside of qemu while qemu is running (or any of the qemu tools using > the block layer. raw_co_get_block_status() should not break then. > > Signed-off-by: Max Reitz > --- > tests/qe

Re: [Qemu-devel] [PATCH] libqos: Convert malloc-pc allocator to a generic allocator

2014-10-22 Thread John Snow
On 10/18/2014 05:24 AM, Marc Marí wrote: The allocator in malloc-pc has been extracted, so it can be used in every arch. This operation showed that both the alloc and free functions can be also generic. Because of this, the QGuestAllocator has been removed from is function to wrap the alloc and

Re: [Qemu-devel] [PATCH] hw/pci: fixed crash when using rombar=0 for hotplugged devices

2014-10-22 Thread Alex Williamson
On Wed, 2014-10-22 at 11:02 +0300, Michael S. Tsirkin wrote: > On Wed, Oct 22, 2014 at 10:41:05AM +0300, Marcel Apfelbaum wrote: > > On Wed, 2014-10-22 at 00:06 +0200, Paolo Bonzini wrote: > > > > > > On 10/21/2014 02:37 PM, Marcel Apfelbaum wrote: > > > > ROM images must be loaded at startup. Usa

Re: [Qemu-devel] [PATCH v13 08/14] qemu-img: Implement commit like QMP

2014-10-22 Thread Eric Blake
On 10/22/2014 06:51 AM, Max Reitz wrote: > qemu-img should use QMP commands whenever possible in order to ensure > feature completeness of both online and offline image operations. As > qemu-img itself has no access to QMP (since this would basically require > just everything being linked into qemu

Re: [Qemu-devel] [PATCH v13 03/14] qcow2: Optimize bdrv_make_empty()

2014-10-22 Thread Eric Blake
On 10/22/2014 06:51 AM, Max Reitz wrote: > bdrv_make_empty() is currently only called if the current image > represents an external snapshot that has been committed to its base > image; it is therefore unlikely to have internal snapshots. In this > case, bdrv_make_empty() can be greatly sped up by

Re: [Qemu-devel] [PATCH] libqos: Convert malloc-pc allocator to a generic allocator

2014-10-22 Thread Stefan Hajnoczi
On Sat, Oct 18, 2014 at 11:24:17AM +0200, Marc Marí wrote: > The allocator in malloc-pc has been extracted, so it can be used in every > arch. > This operation showed that both the alloc and free functions can be also > generic. > Because of this, the QGuestAllocator has been removed from is funct

Re: [Qemu-devel] [PATCH v4 1/2] qcow2: Add qcow2_shrink_l1_and_l2_table for qcow2 shrinking

2014-10-22 Thread Jun Li
On Mon, 10/20 13:47, Max Reitz wrote: > On 2014-10-14 at 19:53, Jun Li wrote: > >This patch is the realization of new function qcow2_shrink_l1_and_l2_table. > >This function will shrink/discard l1 and l2 table when do qcow2 shrinking. > > > >Signed-off-by: Jun Li > >--- > >v4: > > Add deal with

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Samuel Thibault as usb-serial.c and baum.c maintainer

2014-10-22 Thread Samuel Thibault
Paolo Bonzini, le Wed 22 Oct 2014 14:54:20 +0200, a écrit : > He wrote "I've written mostly all of usb-serial.c and baum.c, and keep > maintaining them, since I use them regularly." > > Cc: Samuel Thibault > Signed-off-by: Paolo Bonzini Signed-off-by: Samuel Thibault > --- > MAINTAINERS | 12

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

2014-10-22 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> In my experience, too many files are not covered by MAINTAINERS. >> scripts/get_maintainer.pl falls back to git then, unless you say >> --no-git-fallback. Copies sent there tends to annoy their recipients >> without accomplishing all that muc

Re: [Qemu-devel] [PATCH 2/7] runstate: Add runstate store

2014-10-22 Thread Eric Blake
On 10/22/2014 05:40 AM, Markus Armbruster wrote: >> I think the question here really comes from RunState being an enum defined >> in qapi-schema.json; so we could use that directly in the migration stream >> if we were guaranteed that the encoding of that enum wasn't going to change. >> Does qapi m

[Qemu-devel] [PATCH v3 3/3] iotests: Add test for external image truncation

2014-10-22 Thread Max Reitz
It should not be happening, but it is possible to truncate an image outside of qemu while qemu is running (or any of the qemu tools using the block layer. raw_co_get_block_status() should not break then. Signed-off-by: Max Reitz --- tests/qemu-iotests/102 | 15 +++ tests/qemu-iot

[Qemu-devel] [PATCH v3 1/3] raw-posix: Fix raw_co_get_block_status() after EOF

2014-10-22 Thread Max Reitz
As its comment states, raw_co_get_block_status() should unconditionally return 0 and set *pnum to 0 for after EOF. An assertion after lseek(..., SEEK_HOLE) tried to catch this case by asserting that errno != -ENXIO (which would indicate a position after the EOF); but it should be errno != ENXIO in

[Qemu-devel] [PATCH v3 2/3] raw-posix: raw_co_get_block_status() return value

2014-10-22 Thread Max Reitz
Instead of generating the full return value thrice in try_fiemap(), try_seek_hole() and as a fall-back in raw_co_get_block_status() itself, generate the value only in raw_co_get_block_status(). While at it, also remove the pnum parameter from try_fiemap() and try_seek_hole(). Suggested-by: Kevin

[Qemu-devel] [PATCH v3 0/3] raw-posix: Fix raw_co_get_block_status()

2014-10-22 Thread Max Reitz
raw_co_get_block_status() should return 0 and set *pnum to 0 after the EOF; currently it does this merely by accident, so implement it directly. Also, nb_sectors should be clamped against the image end. While doing that, centralize the generation of raw_co_get_block_status()'s return value along t

Re: [Qemu-devel] Help wanted: QEMU Advent Calendar 2014 extravaganza

2014-10-22 Thread Stefan Hajnoczi
On Wed, Oct 22, 2014 at 3:12 PM, Paolo Bonzini wrote: > On 10/22/2014 03:50 PM, Stefan Hajnoczi wrote: > Also perhaps a 512-byte image that prints PI digits > (based on tests/tcg/pi_10.com). Sounds good. SYSLINUX may be able to boot the COM file without DOS. A demoscene disk image would be swee

Re: [Qemu-devel] [PULL 0/4] usb: add high speed mouse & keyboard configuration

2014-10-22 Thread Peter Maydell
On 15 October 2014 12:52, Gerd Hoffmann wrote: > Hi, > > usb patch queue, bringing high speed configurations for usb mouse & > keyboard, so you can hook them up to ehci without companion controllers. > Also a small xhci fix. > > please pull, > Gerd > > The following changes since commit b1d28e

Re: [Qemu-devel] [PATCH v5 0/3] monitor: add peripheral device del completion support

2014-10-22 Thread Igor Mammedov
On Tue, 21 Oct 2014 19:46:03 +0800 Zhu Guihua wrote: > After inputting device_del command in monitor, we expect to list all > hotpluggable devices automatically by pressing tab key. This patchset provides > the function to list all peripheral devices such as memory devices. > > v5: > - In patch

Re: [Qemu-devel] Help wanted: QEMU Advent Calendar 2014 extravaganza

2014-10-22 Thread Stefan Hajnoczi
On Wed, Oct 22, 2014 at 3:28 PM, Alexander Graf wrote: > > > On 22.10.14 15:50, Stefan Hajnoczi wrote: >> Want to do something cool with QEMU? Whether you are a developer or >> user, you can help us create the QEMU Advent Calendar 2014! >> >> I've had this whacky idea for a while and the right ti

Re: [Qemu-devel] [PATCH] hw/pci: fixed crash when using rombar=0 for hotplugged devices

2014-10-22 Thread Michael S. Tsirkin
On Wed, Oct 22, 2014 at 06:28:15PM +0300, Marcel Apfelbaum wrote: > On Wed, 2014-10-22 at 11:31 +0300, Michael S. Tsirkin wrote: > > On Wed, Oct 22, 2014 at 11:16:05AM +0300, Marcel Apfelbaum wrote: > > > On Wed, 2014-10-22 at 10:58 +0300, Michael S. Tsirkin wrote: > > > > On Wed, Oct 22, 2014 at 1

Re: [Qemu-devel] [PATCH 0/2] qcow2: Do not overflow when writing an L1 sector

2014-10-22 Thread Kevin Wolf
Am 16.10.2014 um 15:25 hat Max Reitz geschrieben: > qcow2_write_l1_entry() may read L1 entries from beyond the end of the > in-memory L1 table when updating a sector. Fix this and add a > qemu-iotest. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 08/20] target-mips: add msa_helper.c

2014-10-22 Thread James Hogan
On 14/07/14 10:55, Yongbok Kim wrote: > +#define B(pwr, i) (((wr_t *)pwr)->b[i]) > +#define BR(pwr, i) (((wr_t *)pwr)->b[i]) > +#define BL(pwr, i) (((wr_t *)pwr)->b[i + MSA_WRLEN/16]) macro argument references should be enclosed in brackets really (to avoid precedence problems). > + > +#define A

Re: [Qemu-devel] A Patch to enable qemu-nbd run as an inetd service

2014-10-22 Thread Eric Blake
On 10/22/2014 12:41 AM, Jun Sheng wrote: > run qemu-nbd as an inetd service has some benefits > * more scriptable, such as serve multiple images to different clients > on one ip/port > * access control using tcpd > > simple usage: > #!/bin/sh > # qemu-nbd wrapper, select image file according to cl

Re: [Qemu-devel] [PATCH] hw/pci: fixed crash when using rombar=0 for hotplugged devices

2014-10-22 Thread Marcel Apfelbaum
On Wed, 2014-10-22 at 11:31 +0300, Michael S. Tsirkin wrote: > On Wed, Oct 22, 2014 at 11:16:05AM +0300, Marcel Apfelbaum wrote: > > On Wed, 2014-10-22 at 10:58 +0300, Michael S. Tsirkin wrote: > > > On Wed, Oct 22, 2014 at 10:34:21AM +0300, Marcel Apfelbaum wrote: > > > > On Wed, 2014-10-22 at 09:

Re: [Qemu-devel] [PATCH] xhci: add property to turn on/off streams support

2014-10-22 Thread Markus Armbruster
Could you briefly explain in the commit message why turning off streams support is useful?

Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer

2014-10-22 Thread Markus Armbruster
Samuel Thibault writes: > Markus Armbruster, le Wed 22 Oct 2014 15:00:20 +0200, a écrit : >> Samuel Thibault writes: >> >> > I've written mostly all of usb-serial.c and baum.c, and keep maintaining >> > them, since I use them regularly. >> >> Please post the obvious patch to MAINTAINERS then :

Re: [Qemu-devel] [PATCH v3 0/3] block: Fix is_allocated() for truncated images

2014-10-22 Thread Kevin Wolf
Am 22.10.2014 um 17:00 hat Max Reitz geschrieben: > Patch 2: > The bdrv_is_allocated() functions may return a number of zero sectors > e.g. if a sector beyond the image end has been queried. Respect this > case in qemu-io's map implementation so it doesn't run into an infinite > loop (https://bugs.

[Qemu-devel] [PATCH] vfio: check if host device supports INTx

2014-10-22 Thread Frank Blaschka
From: Frank Blaschka Let the kernel announce if INTx is available. Yes, there are platforms (e.g. s390) which do not support INTx. Signed-off-by: Frank Blaschka --- hw/misc/vfio.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/hw/misc/vfio.c b/hw/misc/vf

[Qemu-devel] [PATCH 2/3 RFC] s390: implement pci instructions

2014-10-22 Thread Frank Blaschka
From: Frank Blaschka This patch implements the s390 pci instructions in qemu. It allows to access and drive pci devices attached to the s390 pci bus. Because of platform constrains devices using IO BARs are not supported. Also a device has to support MSI/MSI-X to run on s390. Signed-off-by: Fran

[Qemu-devel] [PATCH 0/3 RFC] add PCI support for the s390 platform

2014-10-22 Thread Frank Blaschka
This set of patches implemets PCI support for the s390 platform. Now it is possible to run virtio-net-pci and potentially all virtual pci devices conforming to s390 platform constrains. (In parallel I also post some changes to make vfio run on s390) I hope to get feedback and guidance especially f

[Qemu-devel] [PATCH 1/3 RFC] s390: Add PCI bus support

2014-10-22 Thread Frank Blaschka
From: Frank Blaschka This patch implements a pci bus for s390x together with infrastructure to generate and handle hotplug events, to configure/unconfigure via sclp instruction, to do iommu translations and provide s390 support for MSI/MSI-X notification processing. Signed-off-by: Frank Blaschka

[Qemu-devel] [PATCH 3/3 RPC] kvm: extend kvm_irqchip_add_msi_route to work on s390

2014-10-22 Thread Frank Blaschka
From: Frank Blaschka on s390 MSI-X irqs are presented as thin or adapter interrupts for this we have to reorganize the routing entry to contain valid information for the adapter interrupt code on s390. To minimize impact on existing code we introduce an architecture function to fixup the routing

[Qemu-devel] [PATCH v3 1/3] block: Respect underlying file's EOF

2014-10-22 Thread Max Reitz
When falling through to the underlying file in bdrv_co_get_block_status(), if it returns that the query offset is beyond the file end (by setting *pnum to 0), return the range to be zero and do not let the number of sectors for which information could be obtained be overwritten. Signed-off-by: Max

[Qemu-devel] [PATCH v3 2/3] qemu-io: Respect early image end for map

2014-10-22 Thread Max Reitz
bdrv_is_allocated() may report zero clusters which most probably means the image (file) is shorter than expected. Respect this case in order to avoid an infinite loop. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Benoît Canet Reviewed-by: Kevin Wolf --- qemu-io-cmds.c | 5 +++

[Qemu-devel] [PATCH v3 3/3] iotests: Add test for map commands

2014-10-22 Thread Max Reitz
Add a test for qemu-img map and qemu-io -c map on truncated files. Signed-off-by: Max Reitz --- tests/qemu-iotests/102 | 64 ++ tests/qemu-iotests/102.out | 10 tests/qemu-iotests/group | 1 + 3 files changed, 75 insertions(+) create m

[Qemu-devel] [PATCH v3 0/3] block: Fix is_allocated() for truncated images

2014-10-22 Thread Max Reitz
Patch 2: The bdrv_is_allocated() functions may return a number of zero sectors e.g. if a sector beyond the image end has been queried. Respect this case in qemu-io's map implementation so it doesn't run into an infinite loop (https://bugs.launchpad.net/qemu/+bug/1356969). Patch 1: In that bug repo

Re: [Qemu-devel] [PATCH] xhci: add property to turn on/off streams support

2014-10-22 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/usb/hcd-xhci.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c > index a27c9d3..2930b72 100644 > --- a/hw/usb/hcd-xhci.c > +++ b/hw

[Qemu-devel] [Bug 1383936] Re: OSX VNC mouse speed is way slower than desktop

2014-10-22 Thread Pete Ashdown
Tried usb-table and usb-wacom-tablet. OSX doesn't recognize them by default. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1383936 Title: OSX VNC mouse speed is way slower than desktop Status in

[Qemu-devel] [Bug 1383936] Re: OSX VNC mouse speed is way slower than desktop

2014-10-22 Thread Pete Ashdown
*usb-tablet that is -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1383936 Title: OSX VNC mouse speed is way slower than desktop Status in QEMU: Won't Fix Bug description: When installing/usin

Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for map commands

2014-10-22 Thread Max Reitz
On 2014-10-22 at 16:48, Max Reitz wrote: On 2014-10-22 at 15:54, Max Reitz wrote: On 2014-10-22 at 15:51, Kevin Wolf wrote: Am 22.10.2014 um 15:24 hat Max Reitz geschrieben: Add a test for qemu-img map and qemu-io -c map on truncated files. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for map commands

2014-10-22 Thread Max Reitz
On 2014-10-22 at 15:54, Max Reitz wrote: On 2014-10-22 at 15:51, Kevin Wolf wrote: Am 22.10.2014 um 15:24 hat Max Reitz geschrieben: Add a test for qemu-img map and qemu-io -c map on truncated files. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf But how about adding a case for patch 2,

Re: [Qemu-devel] [PULL 0/1] qxl: keep going if reaching guest bug on empty area

2014-10-22 Thread Peter Maydell
On 15 October 2014 11:51, Gerd Hoffmann wrote: > Hi, > > Spice patch queue with a qxl device fix. > > please pull, > Gerd > > The following changes since commit b1d28ec6a7dbdaadda39d29322f0de694aeb0b74: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20141010' into > staging (20

Re: [Qemu-devel] [PATCH v8 05/17] qcow2: Use sizeof(**refcount_table)

2014-10-22 Thread Eric Blake
On 10/22/2014 06:09 AM, Max Reitz wrote: > When implementing variable refcounts, we want to be able to easily find > all the places in qemu which are tied to a certain refcount order. > Replace sizeof(uint16_t) in the check code by sizeof(**refcount_table) > so we can later find it more easily. >

Re: [Qemu-devel] [Bug 1383857] Re: aarch64: virtio-scsi disks don't show up in guest

2014-10-22 Thread Christopher Covington
On 10/21/2014 05:58 PM, Peter Maydell wrote: > On 21 October 2014 22:33, Peter Maydell wrote: >> Suggestions: > > ...you might also try asking on kvm...@lists.cs.columbia.edu, which > is where the KVM/ARM kernel devs hang out, to see if somebody > else has seen this. It may be useful to also CC:

Re: [Qemu-devel] [PATCH] xhci: add property to turn on/off streams support

2014-10-22 Thread Hans de Goede
Hi, On 10/21/2014 03:16 PM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Looks good: Acked-by: Hans de Goede Regards, Hans > --- > hw/usb/hcd-xhci.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c > in

Re: [Qemu-devel] [PATCH RFC 04/11] virtio_ring: implement endian reversal based on VERSION_1 feature.

2014-10-22 Thread Michael S. Tsirkin
On Wed, Oct 22, 2014 at 04:28:34PM +0200, Cornelia Huck wrote: > On Wed, 22 Oct 2014 17:02:26 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Oct 07, 2014 at 04:39:45PM +0200, Cornelia Huck wrote: > > > From: Rusty Russell > > > > > > [Cornelia Huck: we don't need the vq->vring.num -> vq->rin

Re: [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-22 Thread Michael S. Tsirkin
On Wed, Oct 22, 2014 at 04:17:40PM +0200, Jan Kiszka wrote: > On 2014-10-22 10:44, Michael S. Tsirkin wrote: > > On Wed, Oct 08, 2014 at 11:04:28AM +0200, Cornelia Huck wrote: > >> On Tue, 07 Oct 2014 18:24:22 -0700 > >> Andy Lutomirski wrote: > >> > >>> On 10/07/2014 07:39 AM, Cornelia Huck wrote

Re: [Qemu-devel] [PATCH RFC 04/11] virtio_ring: implement endian reversal based on VERSION_1 feature.

2014-10-22 Thread Cornelia Huck
On Wed, 22 Oct 2014 17:02:26 +0300 "Michael S. Tsirkin" wrote: > On Tue, Oct 07, 2014 at 04:39:45PM +0200, Cornelia Huck wrote: > > From: Rusty Russell > > > > [Cornelia Huck: we don't need the vq->vring.num -> vq->ring_mask change] > > Signed-off-by: Rusty Russell > > Signed-off-by: Cornelia

  1   2   3   4   >