[Qemu-devel] [PATCH 2/2] tests/Makefile: Add check-block to make check

2014-10-27 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index 16f0e4c..f430b18 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -463,7 +463,7 @@ check-qapi-schema: $(patsubst %,check-%, $(check-qapi-schema

[Qemu-devel] [PATCH 0/2] tests: Add check-block to "make check"

2014-10-27 Thread Fam Zheng
qemu-iotests contains useful tests that have a nice coverage of block layer code. Adding check-block (which calls tests/qemu-iotests-quick.sh) to "make check" is good for developers' self-testing. With the first patch, this set takes a half minute on my laptop. If "-j" option is used, it only take

[Qemu-devel] [PATCH 1/2] qemu-iotests: Speed up make check-block

2014-10-27 Thread Fam Zheng
Using /tmp (usually mounted as tmpfs) and cache=writeback, the quick group can be quicker. On my laptop (Lenovo T430s with Fedora 20), this reduces the time from 50s to 30s. Signed-off-by: Fam Zheng --- tests/qemu-iotests-quick.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[Qemu-devel] [PATCH] target-arm: Add guest cpu endianness determination for virtio in KVM ARM64

2014-10-27 Thread Pranavkumar Sawargaonkar
This patch implements a fucntion pointer virtio_is_big_endian() from "CPUClass" structure for arm64. Function aarch64_cpu_virtio_endianness() is added to determine and returns the guest cpu endianness to virtio. This is required for running cross endian guests with virtio on ARM64. Signed-off-by:

Re: [Qemu-devel] [PATCH] hw/virtio/virtio.c: fix the vring_avail_event error

2014-10-27 Thread Michael S. Tsirkin
On Tue, Oct 28, 2014 at 02:13:02AM +, Bin Wu wrote: > The event idx in virtio is an effective way to reduce the number of > interrupts and exits of the guest. When the guest puts an request > into the virtio ring, it doesn't exit immediately to inform the > backend. Instead, the guest checks th

Re: [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-27 Thread Michael S. Tsirkin
On Fri, Oct 24, 2014 at 10:38:39AM +0200, Cornelia Huck wrote: > On Fri, 24 Oct 2014 00:42:20 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Oct 07, 2014 at 04:39:56PM +0200, Cornelia Huck wrote: > > > This patchset aims to get us some way to implement virtio-1 compliant > > > and transitional

[Qemu-devel] [PATCH] hw/virtio/virtio.c: fix the vring_avail_event error

2014-10-27 Thread Bin Wu
The event idx in virtio is an effective way to reduce the number of interrupts and exits of the guest. When the guest puts an request into the virtio ring, it doesn't exit immediately to inform the backend. Instead, the guest checks the "avail" event idx to determine the notification. In virtqueue

[Qemu-devel] [Bug 1386478] [NEW] PS/2 keyboard returns incorrect scan code for F7 to guest

2014-10-27 Thread Kevin Lamonte
Public bug reported: Using qemu 2.1 as supplied in Debian jessie, the F7 scan code (scan set 2) is being returned by qemu to the guest as 0x02, and not the correct value of 0x83. (I assume 0x83 is correct, given that I cannot locate any scan set 2 charts that use any other value for F7. Includin

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself as bootdevice.c maintainer

2014-10-27 Thread Gonglei
On 2014/10/23 20:27, Gerd Hoffmann wrote: > Hi, > >> I expect some of the patches to be in the Kevin's, Paolos and Gerd's >> next pull requests. Happy to collect whatever's left after the dust >> settled. > > I happily leave this one to you. > Looking forward to see your first pull req ;) >

[Qemu-devel] [Bug 917645] Re: [Feature request] ia64-softmmu wanted

2014-10-27 Thread Jakub Jermar
It may be actually easier to start with recreating the Ski machine inside QEMU. The result will be a faster Ski in a maintained codebase. Definitely not a bad start. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchp

Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory

2014-10-27 Thread zhanghailiang
On 2014/10/27 20:46, Luiz Capitulino wrote: On Mon, 27 Oct 2014 17:40:11 +0800 zhanghailiang wrote: Hi Luiz, Can you apply this to your qmp branch? It has been reviewd;) I can, but I don't have bandwidth for another pull request for v2.2 unless it's a fix for a blocker. This means you have

Re: [Qemu-devel] [PATCH 1/2] target-arm: Separate out M profile cpu_exec_interrupt handling

2014-10-27 Thread Edgar E. Iglesias
On Mon, Oct 27, 2014 at 12:58:06PM +, Peter Maydell wrote: > The M profile cpu_exec_interrupt handling is fairly simple > but does include an M profile specific oddity (disabling > interrupts for certain PC values). A/R profile handling > on the other hand is getting rapidly more complicated >

Re: [Qemu-devel] [PATCH 2/2] target-arm: Correct condition for taking VIRQ and VFIQ

2014-10-27 Thread Peter Maydell
On 27 October 2014 23:25, Edgar E. Iglesias wrote: > On Mon, Oct 27, 2014 at 12:58:07PM +, Peter Maydell wrote: >> The VIRQ and VFIQ exceptions are (as the comments say) only >> taken if the CPU is in Non-secure state and the IMO/FMO bits >> are set to enable virtualized interrupts. Correct th

Re: [Qemu-devel] [PATCH 2/2] target-arm: Correct condition for taking VIRQ and VFIQ

2014-10-27 Thread Edgar E. Iglesias
On Mon, Oct 27, 2014 at 12:58:07PM +, Peter Maydell wrote: > The VIRQ and VFIQ exceptions are (as the comments say) only > taken if the CPU is in Non-secure state and the IMO/FMO bits > are set to enable virtualized interrupts. Correct the code > to actually implement this by using '||' rather

Re: [Qemu-devel] Postcopy failures

2014-10-27 Thread Gary Hook
On 10/27/14, 7:41 AM, "Dr. David Alan Gilbert" wrote: >It should be possible to postcopy block storage as well, if that's >the question (it might take some work to make sure that they play >nicely together; e.g. wanting to making the page transfer higher >priority than block transfer). >However,

Re: [Qemu-devel] Solaris 8 SPARC, Web Start Launcher Crashing

2014-10-27 Thread Mark Cave-Ayland
On 25/10/14 20:16, P. Wilhelm wrote: > In late May of 2011, Brian Vandenberg queried this group about failures > he was having trying to install Solaris 8 SPARC 02/04 on a Qemu VM. The > interaction seemed to have ended with Blue Swirl indicating that Brian > should run with “-d in_ascm,int” and t

Re: [Qemu-devel] [PATCH 5/6] ide: Correct handling of malformed/short PRDTs

2014-10-27 Thread John Snow
On 10/27/2014 06:06 AM, Paolo Bonzini wrote: On 10/02/2014 12:55 AM, John Snow wrote: +/* If this is true, you're leaking memory. */ ... or qsg is uninitialized, which would work because qemu_sglist_init initializes all fields. This is the only comment I have on the series. :) Paolo

Re: [Qemu-devel] Patch checking bot

2014-10-27 Thread Andreas Färber
Hi, Am 22.10.2014 um 12:03 schrieb Stefan Hajnoczi: > On Mon, Oct 20, 2014 at 03:08:35PM +0100, Peter Maydell wrote: >> On 20 October 2014 11:25, Stefan Hajnoczi wrote: >>> At KVM Forum 2014 we discussed a patch checking bot that automates patch >>> format checking and smoke testing: >>> >>> 1. D

Re: [Qemu-devel] [PULL 00/28] Changes for 2014-10-27

2014-10-27 Thread Andreas Färber
Am 27.10.2014 um 16:13 schrieb Paolo Bonzini: > Peter Crosthwaite (10): > qom: Allow clearing of a Link property > qom: Demote already-has-a-parent to a regular error > qdev: gpio: Re-implement qdev_connect_gpio QOM style > qdev: gpio: Add API for intercepting a GPIO >

[Qemu-devel] [Bug 1386197] [NEW] keyboard suddenly stops working in VM and problem persists until host reboot. All super-standard setup no funny stuff

2014-10-27 Thread John Smith
Public bug reported: QEMU emulator version 2.1.2, Copyright (c) 2003-2008 Fabrice Bellard Linux HOST 3.16.3-1-ck #1 SMP PREEMPT Sun Sep 21 11:27:46 CEST 2014 x86_64 GNU/Linux qemu-system-x86_64 -daemonize -enable-kvm -cpu host -smp 4,maxcpus=4,sockets=1,cores=2,threads=1 -m 4096 -monitor telnet:

[Qemu-devel] [Bug 1386197] Re: keyboard suddenly stops working in VM and problem persists until host reboot. All super-standard setup no funny stuff

2014-10-27 Thread John Smith
So installed qemu-git 2.2.r35796.gff0d487-1 from AUR shows up as QEMU emulator version 2.1.50, Copyright (c) 2003-2008 Fabrice Bellard no host system reboot but still exact same ... no wait! Now I see this: I can press all the printable character keys except 0-9 A-Z :space: and KP_keys so basicall

Re: [Qemu-devel] [RFC PATCH v2 21/23] COLO nic: implement colo nic device interface configure()

2014-10-27 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > implement colo nic device interface configure() > add a script to configure nic devices: > ${QEMU_SCRIPT_DIR}/network-colo > > Script for configuring the network of Master & Slaver. You might also like to think about making this possible via libvir

[Qemu-devel] [PATCH v4 1/2] hw/pci: fixed error flow in pci_qdev_init

2014-10-27 Thread Marcel Apfelbaum
Verify return code for pci_add_option_rom. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 6ce75aa..36226eb 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1776,7 +1776,12 @@ static int

[Qemu-devel] [PATCH v4 0/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-10-27 Thread Marcel Apfelbaum
Hot-plugging a device that has a romfile (either supplied by user or built-in) using rombar=0 option is a user error, do not allow the device to be hot-plugged. v3 -> v4: - Fixed a typo in the commit (Eric Blake) v2 -> v3: - Reverse the decision to forbid the hotplug on user error (Michael S. T

[Qemu-devel] [PATCH v4 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-10-27 Thread Marcel Apfelbaum
Hot-plugging a device that has a romfile (either supplied by user or built-in) using rombar=0 option is a user error, do not allow the device to be hot-plugged. Reviewed-by: Eric Blake Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-10-27 Thread Michael S. Tsirkin
On Mon, Oct 27, 2014 at 07:15:38PM +0200, Marcel Apfelbaum wrote: > On Mon, 2014-10-27 at 11:10 -0600, Eric Blake wrote: > > On 10/27/2014 10:41 AM, Marcel Apfelbaum wrote: > > > Hot-plugging a device that has a romfile (either supplied by user > > > or built-in) using rombar=0 option is an user er

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-10-27 Thread Marcel Apfelbaum
On Mon, 2014-10-27 at 11:10 -0600, Eric Blake wrote: > On 10/27/2014 10:41 AM, Marcel Apfelbaum wrote: > > Hot-plugging a device that has a romfile (either supplied by user > > or built-in) using rombar=0 option is an user error, > > s/an/a/ (user is pronounced with a leading hard "y" sound rather

Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for non-existing backing file

2014-10-27 Thread Eric Blake
On 10/27/2014 06:30 AM, Max Reitz wrote: > Test the error message when a COW file is about to be created which is > supposed to inherit the size of its backing file, while the backing file > given does not actually exist. > > Signed-off-by: Max Reitz > --- > + > +$QEMU_IMG create -f $IMGFMT -b "

Re: [Qemu-devel] [PATCH v3 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-10-27 Thread Eric Blake
On 10/27/2014 10:41 AM, Marcel Apfelbaum wrote: > Hot-plugging a device that has a romfile (either supplied by user > or built-in) using rombar=0 option is an user error, s/an/a/ (user is pronounced with a leading hard "y" sound rather than a soft "u", it may help to remember you can "give a unico

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Eric Blake
On 10/27/2014 10:03 AM, Michael S. Tsirkin wrote: > On Mon, Oct 27, 2014 at 05:04:03PM +0200, Marcel Apfelbaum wrote: >> On Mon, 2014-10-27 at 16:52 +0200, Michael S. Tsirkin wrote: >>> On Mon, Oct 27, 2014 at 03:44:04PM +0200, Marcel Apfelbaum wrote: Combining rombar=0 with romfile= is an use

Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-27 Thread Peter Maydell
On 27 October 2014 15:05, Peter Maydell wrote: > On 27 October 2014 14:39, Paolo Bonzini wrote: >> What about: >> >> /* SIGINT cannot be handled via signalfd, so that ^C can be used >> * to interrupt QEMU when it is being run under gdb. SIGHUP and >> * SIGTERM are also handled asyn

Re: [Qemu-devel] is it possible to use a disk with multiple iothreads ?

2014-10-27 Thread Alexandre DERUMIER
>>You are missing debug information unfortunately, Ok thanks, I'll try to add qemu debug symbols. (I have already libc6,librbd,librados debug symbols installed) - Mail original - De: "Paolo Bonzini" À: "Alexandre DERUMIER" , "Stefan Hajnoczi" Cc: "josh durgin" , "qemu-devel" Envoyé

[Qemu-devel] [PATCH v3 2/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-10-27 Thread Marcel Apfelbaum
Hot-plugging a device that has a romfile (either supplied by user or built-in) using rombar=0 option is an user error, do not allow the device to be hot-plugged. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pc

[Qemu-devel] [PATCH v3 0/2] hw/pci: fixed hotplug crash when using rombar=0 with devices having romfile

2014-10-27 Thread Marcel Apfelbaum
Hot-plugging a device that has a romfile (either supplied by user or built-in) using rombar=0 option is an user error, do not allow the device to be hot-plugged. v2 -> v3: - Reverse the decision to forbit the hotplug on user error (Michael S. Tsirkin) - Split the patch in two, first part being a

[Qemu-devel] [PATCH v3 1/2] hw/pci: fixed error flow in pci_qdev_init

2014-10-27 Thread Marcel Apfelbaum
Verify return code for pci_add_option_rom. Signed-off-by: Marcel Apfelbaum --- hw/pci/pci.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 6ce75aa..36226eb 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1776,7 +1776,12 @@ static int

[Qemu-devel] Adding new arguments to qemu binary

2014-10-27 Thread Shiva
Hello , I am new to qemu development. I want to add the following to qemu. I want to start a qemu process with a new argument EECREATE. This when given to qemu-i386 binary should create an encrypted space in memory with few new data structures inside. Like for example, qemu-system-i386 -hda ub

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-27 Thread Marc-André Lureau
On Mon, Oct 27, 2014 at 1:43 PM, Amit Shah wrote: > Great, so there's no other change required to actually use the > functionality in my patch? Does my patch fit your need fine, or do > you need to tweak the notification somehow? > > It seems to be working nicely. > It would be great to get yo

Re: [Qemu-devel] [PATCH] tcg/mips: fix store softmmu slow path

2014-10-27 Thread Richard Henderson
On 10/27/2014 08:11 AM, Aurelien Jarno wrote: > Commit 9d8bf2d1 moved the softmmu slow path out of line and introduce a > regression at the same time by always calling tcg_out_tlb_load with > is_load=1. This makes impossible to run any significant code under > qemu-system-mips*. > > Cc: Paolo Bonz

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Michael S. Tsirkin
On Mon, Oct 27, 2014 at 05:04:03PM +0200, Marcel Apfelbaum wrote: > On Mon, 2014-10-27 at 16:52 +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 27, 2014 at 03:44:04PM +0200, Marcel Apfelbaum wrote: > > > Combining rombar=0 with romfile= is an user error, > > > silently dropping the romfile is a re

Re: [Qemu-devel] [PATCH v7 07/32] target-arm: extend async excp masking

2014-10-27 Thread Greg Bellows
On 27 October 2014 06:57, Peter Maydell wrote: > On 26 October 2014 22:30, Peter Maydell wrote: > > In fact, since all of the "exception is not taken" cases are for > > "we are in secure EL3 and the exception is not being routed to > > secure EL3" you could just make all those entries read "1" a

Re: [Qemu-devel] [PATCH 1/6] ahci: Correct PIO/D2H FIS responses

2014-10-27 Thread Markus Armbruster
John Snow writes: > On 10/27/2014 05:32 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Currently, the D2H FIS packets AHCI generates simply parrot back >>> the LBA that the guest sent to us in the cmd_fis. However, some >>> commands (like READ NATIVE MAX) modify the LBA registers as a

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Markus Armbruster
Marcel Apfelbaum writes: > On Mon, 2014-10-27 at 15:59 +0100, Markus Armbruster wrote: >> Marcel Apfelbaum writes: >> >> > Combining rombar=0 with romfile= is an user error, >> > silently dropping the romfile is a reasonable thing to do. >> > >> > Signed-off-by: Marcel Apfelbaum >> > --- >> >

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-27 Thread Paolo Bonzini
On 10/27/2014 04:48 PM, Eduardo Habkost wrote: > On Fri, Oct 24, 2014 at 07:55:10AM +0200, Paolo Bonzini wrote: > [...] >> I think we can keep the macros. The actual cleanup would be to have a >> single member for the 32 512-bit ZMM registers, instead of splitting >> xmm/ymmh/zmmh/zmm_hi16. Thi

Re: [Qemu-devel] [PULL 18/28] MAINTAINERS: add myself for X86

2014-10-27 Thread Paolo Bonzini
On 10/27/2014 04:41 PM, Aurelien Jarno wrote: > On Mon, Oct 27, 2014 at 04:13:35PM +0100, Paolo Bonzini wrote: >> Still not moving it beyond "Odd fixes". Richard Henderson also has >> reviewed a bunch of X86 TCG patches, so add him as well. All we want >> is to avoid that patches fall on the fl

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-27 Thread Eduardo Habkost
On Fri, Oct 24, 2014 at 07:55:10AM +0200, Paolo Bonzini wrote: [...] > I think we can keep the macros. The actual cleanup would be to have a > single member for the 32 512-bit ZMM registers, instead of splitting > xmm/ymmh/zmmh/zmm_hi16. This will get rid of the YMM_* and ZMM_* > registers. Howe

Re: [Qemu-devel] [PATCH v14 14/14] iotests: Add test for qcow2's bdrv_make_empty

2014-10-27 Thread Eric Blake
On 10/27/2014 02:06 AM, Max Reitz wrote: > On 2014-10-24 at 18:31, Eric Blake wrote: >> On 10/24/2014 07:57 AM, Max Reitz wrote: >>> Add a test for qcow2's fast bdrv_make_empty implementation on images >>> without internal snapshots. >>> >>> +for event in l1_update empty_image_prepare reftable_upd

Re: [Qemu-devel] [PATCH 1/6] ahci: Correct PIO/D2H FIS responses

2014-10-27 Thread John Snow
On 10/27/2014 05:32 AM, Markus Armbruster wrote: John Snow writes: Currently, the D2H FIS packets AHCI generates simply parrot back the LBA that the guest sent to us in the cmd_fis. However, some commands (like READ NATIVE MAX) modify the LBA registers as a return value, through which the AH

Re: [Qemu-devel] [PULL 18/28] MAINTAINERS: add myself for X86

2014-10-27 Thread Aurelien Jarno
On Mon, Oct 27, 2014 at 04:13:35PM +0100, Paolo Bonzini wrote: > Still not moving it beyond "Odd fixes". Richard Henderson also has > reviewed a bunch of X86 TCG patches, so add him as well. All we want > is to avoid that patches fall on the floor. Great! Thanks for stepping up. Could you pleas

[Qemu-devel] [PULL 21/28] MAINTAINERS: avoid M entries that point to mailing lists

2014-10-27 Thread Paolo Bonzini
"L" entries that point to qemu-devel are not much better either, but at least the get_maintainer.pl output is clearer. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b1d229f..82f21c5 1

[Qemu-devel] [PULL 28/28] aio / timers: De-document -clock

2014-10-27 Thread Paolo Bonzini
From: Markus Armbruster Commit 6d32717 "aio / timers: Remove alarm timers" has issues: 1. It silently ignores -clock for backward compatibility. Incompatible change: -clock help no longer terminates the program. Tolerable. 2. Failed to update option documentation. In particular, -help still ad

[Qemu-devel] [PULL 25/28] target-i386: add Intel AVX-512 support

2014-10-27 Thread Paolo Bonzini
From: Chao Peng Add AVX512 feature bits, register definition and corresponding xsave/vmstate support. Reviewed-by: Eduardo Habkost Signed-off-by: Chao Peng Signed-off-by: Paolo Bonzini --- target-i386/cpu.c | 10 -- target-i386/cpu.h | 61 tar

[Qemu-devel] [PULL 17/28] MAINTAINERS: add Samuel Thibault as usb-serial.c and baum.c maintainer

2014-10-27 Thread Paolo Bonzini
He wrote "I've written mostly all of usb-serial.c and baum.c, and keep maintaining them, since I use them regularly." Cc: Samuel Thibault Signed-off-by: Paolo Bonzini --- MAINTAINERS | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-devel] [PULL 27/28] hw/scsi/virtio-scsi.c: fix the "type" use error in virtio_scsi_handle_ctrl

2014-10-27 Thread Paolo Bonzini
From: Bin Wu The local variable "type" in virtio_scsi_handle_ctl represents the tmf command type from the guest and it has the same meaning as the req->req.tmf.type. However, before the invoking of virtio_scsi_parse_req the req->req.tmf.type doesn't has the correct value(just initialized to zero)

Re: [Qemu-devel] [PULL 17/28] MAINTAINERS: add Samuel Thibault as usb-serial.c and baum.c maintainer

2014-10-27 Thread Samuel Thibault
Paolo Bonzini, le Mon 27 Oct 2014 16:13:34 +0100, a écrit : > He wrote "I've written mostly all of usb-serial.c and baum.c, and keep > maintaining them, since I use them regularly." > > Cc: Samuel Thibault Signed-off-by: Samuel Thibault > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 12

[Qemu-devel] [PULL 19/28] MAINTAINERS: Add more TCG files

2014-10-27 Thread Paolo Bonzini
Unfortunately, TCG files do not really have a maintainer yet. But at least there will be fewer unmaintained files. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 17 + 1 file changed, 17 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6519d67..3f371f6 100644 --- a/MAI

[Qemu-devel] [PULL 22/28] qtest: fix qtest log fd should be initialized before qtest chardev

2014-10-27 Thread Paolo Bonzini
From: Li Liu qtest_log_fp should be inited before qemu_chr_add_handlers. If not the log dumped from callback functions may be lost. easy to reproduce it by command: "QTEST_LOG=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 gtester -k --verbose -m=quick tests/qdev-monitor-test" The log "[

[Qemu-devel] [PULL 24/28] get_maintainer.pl: restrict cases where it falls back to --git

2014-10-27 Thread Paolo Bonzini
The list emitted by --git-fallback often leads inexperienced contributors to add pointless CCs. While not discouraging usage of --git-fallback, we want to: 1) disable the fallback if only some files lack a maintainer $ scripts/get_maintainer.pl -f util/cutils.c hw/ide/core.c Kevin Wolf

[Qemu-devel] [PULL 26/28] virtio-scsi: sense in virtio_scsi_command_complete

2014-10-27 Thread Paolo Bonzini
From: Ting Wang If req->resp.cmd.status is not GOOD, the address of sense for qemu_iovec_from_buf should be modified from &req->resp to sense. Cc: qemu-sta...@nongnu.org Signed-off-by: Ting Wang Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PULL 18/28] MAINTAINERS: add myself for X86

2014-10-27 Thread Paolo Bonzini
Still not moving it beyond "Odd fixes". Richard Henderson also has reviewed a bunch of X86 TCG patches, so add him as well. All we want is to avoid that patches fall on the floor. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 15/28] target-i386: warns users when CPU threads>1 for non-Intel CPUs

2014-10-27 Thread Paolo Bonzini
From: Wei Huang Only Intel CPUs support hyperthreading. When users select threads>1 in -smp option, QEMU fixes it by adjusting CPUID__0001_EBX and CPUID_8000_0008_ECX based on inputs (sockets, cores, threads); so guest VM can boot correctly. However it is still better to gives users a warning

[Qemu-devel] [PULL 23/28] get_maintainer.pl: move git loop under "if ($email) {"

2014-10-27 Thread Paolo Bonzini
All checks in the loop are guarded by that condition, and there is a handy "if" just below. Simplify the code. Reviewed-by: Markus Armbruster Signed-off-by: Paolo Bonzini --- scripts/get_maintainer.pl | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/scri

[Qemu-devel] [PULL 20/28] MAINTAINERS: add some tests directories

2014-10-27 Thread Paolo Bonzini
Low-hanging fruit... Signed-off-by: Paolo Bonzini --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3f371f6..b1d229f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -77,6 +77,7 @@ M: Richard Henderson S: Maintained F: target-alpha/ F: hw

[Qemu-devel] [PULL 14/28] sysbus: Use TYPE_DEVICE GPIO functionality

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite Re-implement the Sysbus GPIOs to use the existing TYPE_DEVICE GPIO named framework. A constant string name is chosen to avoid conflicts with existing unnamed GPIOs. This unifies GPIOs are IRQs for sysbus devices and allows removal of all Sysbus state for GPIOs. Any exist

[Qemu-devel] [PULL 10/28] irq: Remove qemu_irq_intercept_out

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite No more users left and obsoleted by qdev_intercept_gpio_out. Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite Signed-off-by: Paolo Bonzini --- hw/core/irq.c| 6 -- include/hw/irq.h | 1 - 2 files changed, 7 deletions(-) diff --git a/hw/core/irq.c

[Qemu-devel] [PULL 12/28] qdev: gpio: Remove qdev_init_gpio_out x1 restriction

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite Previously this was restricted to a single call per-dev/per-name. With the conversion of the GPIO output state to QOM the implementation can now handle repeated calls. Remove the restriction. Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite Signed-off-by: Pa

[Qemu-devel] [PULL 16/28] MAINTAINERS: grab more files from Anthony's pile

2014-10-27 Thread Paolo Bonzini
I am picking up character devices and the main loop, as agreed during QEMU Summit. Signed-off-by: Paolo Bonzini --- MAINTAINERS | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8eed800..4045561 100644 --- a/MAINTAINERS +++ b/MAINTAINER

[Qemu-devel] [PULL 11/28] qdev: gpio: delete NamedGPIOList::out

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite All users of GPIO outputs are fully QOMified, using QOM properties to access the GPIO data. Delete. Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 1 - include/hw/qdev-core.h | 1 - 2 files change

[Qemu-devel] [PULL 08/28] qdev: gpio: Add API for intercepting a GPIO

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite To replace the old qemu_irq intercept API (which had users reaching into qdev private state for GPIOs). Reviewed-by: Alexander Graf Signed-off-by: Peter Crosthwaite Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 25 + include/hw/qdev

[Qemu-devel] [PULL 01/28] virtio-scsi-dataplane: Add op blocker

2014-10-27 Thread Paolo Bonzini
From: Fam Zheng We need this to protect dataplane thread from race conditions with block jobs until the latter is made dataplane-safe. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi-dataplane.c | 4 hw/scsi/virtio-scsi.c | 19 +--

[Qemu-devel] [PULL 13/28] qdev: gpio: Define qdev_pass_gpios()

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite Allows a container to take ownership of GPIOs in a contained device and automatically connect them as GPIOs to the container. This prepares for deprecation of the SYSBUS IRQ functionality, which has this feature. We push it up to the device level instead of sysbus level.

[Qemu-devel] [PULL 03/28] virtio-scsi: dataplane: fail setup gracefully

2014-10-27 Thread Paolo Bonzini
From: Cornelia Huck The dataplane code is currently doing a hard exit on various setup failures. In practice, this may mean that a guest suddenly dies after a dataplane device failed to come up (e.g., when a file descriptor limit is hit for the nth device). Let's just try to unwind the setup ins

[Qemu-devel] [PULL 05/28] qom: Allow clearing of a Link property

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite By passing in "" to object_property_set_link. The lead user of this is the QDEV GPIO framework which will implement GPIO disconnects via an "unlink". GPIO disconnection is used by qtest's irq_intercept_out command. Reviewed-by: Alexander Graf Signed-off-by: Peter Crost

[Qemu-devel] [PULL 04/28] virtio-scsi: dataplane: stop trying on notifier error

2014-10-27 Thread Paolo Bonzini
From: Cornelia Huck There's no use to constantly trying to enable dataplane if we failed to set up guest or host notifiers, so fence it off in that case. We'll try again if the device is reinitialized. Signed-off-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi-dataplane

[Qemu-devel] [PULL 09/28] qtest/irq: Rework IRQ interception

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite Change the qtest intercept handler to accept just the individual IRQ being intercepted as opaque. n is still expected to be correctly set as for the original intercepted irq. qemu_intercept_irq_in is updated accordingly. Then covert the qemu_irq_intercept_out call to use

[Qemu-devel] [PULL 07/28] qdev: gpio: Re-implement qdev_connect_gpio QOM style

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite Re-implement as a link setter. This should allow the QOM framework to keep track of ref counts properly etc. We need to add a default parent for the connecting input incase it's coming from a non-qdev source. We simply parent the IRQ to the machine in this case. Reviewed

[Qemu-devel] [PULL 06/28] qom: Demote already-has-a-parent to a regular error

2014-10-27 Thread Paolo Bonzini
From: Peter Crosthwaite Rather than an abort(). This allows callers to decide whether parenting an already-parented object is a fatal error condition. Useful for providing a default value for an object's parent in the case where you want to set one iff it doesn't already have one. Reviewed-by:

[Qemu-devel] [PULL 02/28] virtio-scsi: dataplane: print why starting failed

2014-10-27 Thread Paolo Bonzini
From: Cornelia Huck Setting up guest or host notifiers may fail, but the user will have no idea why: Let's print the error returned by the callback. Signed-off-by: Cornelia Huck Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi-dataplane.c | 11 +++ 1 file changed, 7 insertions(+),

[Qemu-devel] [PULL 00/28] Changes for 2014-10-27

2014-10-27 Thread Paolo Bonzini
The following changes since commit e40830afa1cff3ffdc37bdfdd40d80860074636c: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2014-10-22-tag' into staging (2014-10-22 21:42:33 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for

[Qemu-devel] [PATCH] tcg/mips: fix store softmmu slow path

2014-10-27 Thread Aurelien Jarno
Commit 9d8bf2d1 moved the softmmu slow path out of line and introduce a regression at the same time by always calling tcg_out_tlb_load with is_load=1. This makes impossible to run any significant code under qemu-system-mips*. Cc: Paolo Bonzini Cc: Richard Henderson Cc: qemu-sta...@nongnu.org Sig

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Marcel Apfelbaum
On Mon, 2014-10-27 at 15:59 +0100, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > Combining rombar=0 with romfile= is an user error, > > silently dropping the romfile is a reasonable thing to do. > > > > Signed-off-by: Marcel Apfelbaum > > --- > > v1 -> v2: > > After a discussion wit

Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-27 Thread Peter Maydell
On 27 October 2014 14:39, Paolo Bonzini wrote: > > > On 10/27/2014 03:18 PM, Peter Maydell wrote: >> On 26 October 2014 09:32, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks >>> debuggability of qemu. >>> >>> Signed-off-by:

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Marcel Apfelbaum
On Mon, 2014-10-27 at 16:52 +0200, Michael S. Tsirkin wrote: > On Mon, Oct 27, 2014 at 03:44:04PM +0200, Marcel Apfelbaum wrote: > > Combining rombar=0 with romfile= is an user error, > > silently dropping the romfile is a reasonable thing to do. > > > > Signed-off-by: Marcel Apfelbaum > > How a

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Markus Armbruster
Marcel Apfelbaum writes: > Combining rombar=0 with romfile= is an user error, > silently dropping the romfile is a reasonable thing to do. > > Signed-off-by: Marcel Apfelbaum > --- > v1 -> v2: > After a discussion with Michael, Paolo and Alex, this > patch silent drops the romfile instead of n

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Michael S. Tsirkin
On Mon, Oct 27, 2014 at 03:44:04PM +0200, Marcel Apfelbaum wrote: > Combining rombar=0 with romfile= is an user error, > silently dropping the romfile is a reasonable thing to do. > > Signed-off-by: Marcel Apfelbaum How about failing adding the device instead? Return error from pci_add_option_ro

[Qemu-devel] [Bug 1385934] Re: USB with passthrougth guest cannot enumerate USB host

2014-10-27 Thread Iggy
You might try connecting the device to a ehci/xhci bus (instead of the default uhci bus... i.e. USB 1.1). See docs/usb2.txt in the qemu source for more info. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

Re: [Qemu-devel] [Consult] microblaze: About running upstream main branch qemu

2014-10-27 Thread Chen Gang
After a little try, I succeed run microblaze under upstream qemu 2.1.2 and upstream Linux kernel 3.17-rc7, with the xilinux own ramdisk: "microblaze_complete.cpio.gz". :-) Compiler is "gcc version 4.9.1 20140717 (Red Hat Cross 4.9.1-1) (GCC)" for microblaze, and "gcc version 4.8.3 20140624 (Red H

Re: [Qemu-devel] is it possible to use a disk with multiple iothreads ?

2014-10-27 Thread Paolo Bonzini
On 10/27/2014 03:13 PM, Alexandre DERUMIER wrote: >>> That's very interesting! Please keep Josh and me in CC when you want to >>> >>discuss the results. > Here the aggregate results (perf report details attached in this mail) > > + 33,02%3974368751 kvm [kernel.kallsyms]

Re: [Qemu-devel] [PATCH] aio / timers: De-document -clock

2014-10-27 Thread Paolo Bonzini
On 10/06/2014 04:19 PM, Markus Armbruster wrote: > Commit 6d32717 "aio / timers: Remove alarm timers" has issues: > > 1. It silently ignores -clock for backward compatibility. > Incompatible change: -clock help no longer terminates the program. > Tolerable. > > 2. Failed to update option document

Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-27 Thread Paolo Bonzini
On 10/27/2014 03:18 PM, Peter Maydell wrote: > On 26 October 2014 09:32, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks >> debuggability of qemu. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Feel free to apply this before or

Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-27 Thread Peter Maydell
On 26 October 2014 09:32, Jan Kiszka wrote: > From: Jan Kiszka > > This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks > debuggability of qemu. > > Signed-off-by: Jan Kiszka > --- > > Feel free to apply this before or after "Make qemu_shutdown_requested > signal-safe". > > m

Re: [Qemu-devel] [PATCH] aio / timers: De-document -clock

2014-10-27 Thread Markus Armbruster
Ping? Markus Armbruster writes: > Commit 6d32717 "aio / timers: Remove alarm timers" has issues: > > 1. It silently ignores -clock for backward compatibility. > Incompatible change: -clock help no longer terminates the program. > Tolerable. > > 2. Failed to update option documentation. In parti

Re: [Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Marcel Apfelbaum
On Mon, 2014-10-27 at 15:44 +0200, Marcel Apfelbaum wrote: > Combining rombar=0 with romfile= is an user error, > silently dropping the romfile is a reasonable thing to do. > > Signed-off-by: Marcel Apfelbaum > --- > v1 -> v2: > After a discussion with Michael, Paolo and Alex, this > patch sile

[Qemu-devel] [PATCH v2] hw/pci: fixed crash when using rombar=0 with romfile=path for hotplugged devices

2014-10-27 Thread Marcel Apfelbaum
Combining rombar=0 with romfile= is an user error, silently dropping the romfile is a reasonable thing to do. Signed-off-by: Marcel Apfelbaum --- v1 -> v2: After a discussion with Michael, Paolo and Alex, this patch silent drops the romfile instead of not allowing the hotplug. An OK from li

Re: [Qemu-devel] is it possible to use a disk with multiple iothreads ?

2014-10-27 Thread Stefan Hajnoczi
On Fri, Oct 24, 2014 at 03:39:52PM +0200, Alexandre DERUMIER wrote: > >>Regarding Ceph, do you know why it burns a lot of CPU? > > I'm currently doing some perfs to find why is so huge. > > One thing is that qemu+ qemu rbd block driver + librbd seem to use 2-3x more > cpu, than passing krbd /dev

[Qemu-devel] [PATCH 1/2] target-arm: Separate out M profile cpu_exec_interrupt handling

2014-10-27 Thread Peter Maydell
The M profile cpu_exec_interrupt handling is fairly simple but does include an M profile specific oddity (disabling interrupts for certain PC values). A/R profile handling on the other hand is getting rapidly more complicated with the support for EL2 and EL3. Split the M profile code out into its o

[Qemu-devel] [PATCH 2/2] target-arm: Correct condition for taking VIRQ and VFIQ

2014-10-27 Thread Peter Maydell
The VIRQ and VFIQ exceptions are (as the comments say) only taken if the CPU is in Non-secure state and the IMO/FMO bits are set to enable virtualized interrupts. Correct the code to actually implement this by using '||' rather than '&&'. Signed-off-by: Peter Maydell --- target-arm/cpu.h | 4 ++-

[Qemu-devel] [PATCH 0/2] target-arm: fix some exception-masking issues

2014-10-27 Thread Peter Maydell
These patches fix a couple of issues I noticed with the existing code in the ARM arm_excp_unmasked() function while I was reviewing the TrustZone series: * we currently try to use the same function for M profile and A/R profile, which makes both code paths harder to read (and maybe one day w

Re: [Qemu-devel] A Patch to enable qemu-nbd run as an inetd service

2014-10-27 Thread Jun Sheng
Hi, Since errx is used everywhere in qemu-nbd.c, I suggest that I follow this convention in submitting my patch. On Thu, Oct 23, 2014 at 4:48 AM, Eric Blake wrote: > On 10/22/2014 12:54 PM, Jun Sheng wrote: >> From: Chaos Eternal >> >> >> run qemu-nbd as an inetd service has some benefits >> *

Re: [Qemu-devel] [PATCH v6] numa: make 'info numa' take into account hotplugged memory

2014-10-27 Thread Luiz Capitulino
On Mon, 27 Oct 2014 17:40:11 +0800 zhanghailiang wrote: > Hi Luiz, > > Can you apply this to your qmp branch? > It has been reviewd;) I can, but I don't have bandwidth for another pull request for v2.2 unless it's a fix for a blocker. This means you have two options, wait for v2.3 or find anoth

Re: [Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create()

2014-10-27 Thread Peter Lieven
On 27.10.2014 13:30, Max Reitz wrote: Currently, when trying to create a backed image without specifying its size, when the backing file does not exist or is not accessible, an appropriate error message will be generated which is then (in bdrv_img_create()) prefixed with the image file name and t

  1   2   >