Re: [Qemu-devel] [PATCH 3/4] pcnet: fix Negative array index read

On 2014/11/20 15:08, Paolo Bonzini wrote: On 20/11/2014 07:44, Gonglei wrote: Maybe not, since two branch are if and else if not if and else, so this change make the below code segment's wide ... bcnt = 4096 - GET_FIELD(tmd.length, TMDL, BCNT); s-phys_mem_read(s-dma_opaque,

Re: [Qemu-devel] [PATCH 4/4] rtl8139: fix Pointer to local outside scope

On 11/20/2014 03:12 PM, Gonglei wrote: On 2014/11/20 14:55, Jason Wang wrote: On 11/20/2014 02:29 PM, Paolo Bonzini wrote: On 20/11/2014 06:57, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Coverity spot: Assigning: iov = struct iovec [3]({{buf, 12UL},

Re: [Qemu-devel] [PATCH v2 0/3] Migration-safe ACPI table sizing algorithm

On Thu, Nov 20, 2014 at 08:11:05AM +0100, Paolo Bonzini wrote: On 20/11/2014 07:55, Michael S. Tsirkin wrote: I thought we agreed we'll consider alternate approaches after 2.2? I would prefer not to have yet another mode to support if we can help it. I agree, but: 1) looks like

<    1   2   3