Re: [Qemu-devel] [Question] about ipxe version update

2014-12-04 Thread Gerd Hoffmann
Hi, When we tried the latest ipxe code, it's ok. By git bisect, I found the patch of ipxe.git solved this problem. # git show 9f0b7f428af04d0c5ddda78f9b034625f2f91831 Author: Michael Brown mc...@ipxe.org Date: Sun Jun 1 19:24:16 2014 +0100 I noticed that the latest ipxe version in

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

2014-12-04 Thread Gerd Hoffmann
Hi, Hum.. Now, I encountered this situation that the common clienteles just use tightvnc client, but want to change keymap dynamically. As you say, the only way address this scenario is doing it on the server side. So, do you think this patch series make sense and consider to accept it in

Re: [Qemu-devel] [Question] about ipxe version update

2014-12-04 Thread Gonglei
On 2014/12/4 16:07, Gerd Hoffmann wrote: Hi, When we tried the latest ipxe code, it's ok. By git bisect, I found the patch of ipxe.git solved this problem. # git show 9f0b7f428af04d0c5ddda78f9b034625f2f91831 Author: Michael Brown mc...@ipxe.org Date: Sun Jun 1 19:24:16 2014 +0100

[Qemu-devel] [PATCH v4] block: add event when disk usage exceeds threshold

2014-12-04 Thread Francesco Romani
Managing applications, like oVirt (http://www.ovirt.org), make extensive use of thin-provisioned disk images. To let the guest run smoothly and be not unnecessarily paused, oVirt sets a disk usage threshold (so called 'high water mark') based on the occupation of the device, and automatically

Re: [Qemu-devel] [PATCH v4] block: add event when disk usage exceeds threshold

2014-12-04 Thread Francesco Romani
- Original Message - From: Francesco Romani from...@redhat.com To: qemu-devel@nongnu.org Cc: kw...@redhat.com, stefa...@redhat.com, lcapitul...@redhat.com, mdr...@linux.vnet.ibm.com, ebl...@redhat.com, Francesco Romani from...@redhat.com Sent: Thursday, December 4, 2014 9:59:08 AM

Re: [Qemu-devel] [PATCH v4 2/6] vmdk: Fix comment to match code of extent lines

2014-12-04 Thread Max Reitz
On 2014-12-04 at 00:28, Fam Zheng wrote: commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent type but the comment above the changed code is left out. Update the comment so they are consistent. Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 6 -- 1 file

Re: [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it

2014-12-04 Thread Max Reitz
On 2014-12-04 at 00:28, Fam Zheng wrote: Since a too small file cannot be a valid VMDK image, and also since the buffer's first 4 bytes will be unconditionally examined by vmdk_open_sparse, let's error out the small file case to be clear. Signed-off-by: Fam Zheng f...@redhat.com ---

Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory

2014-12-04 Thread Markus Armbruster
Bryan D. Payne bdpa...@acm.org writes: Out of curiosity, what are existing solutions? Basically just attaching gdb and pulling memory out manually (or writing a program to do the same). Can you explain again why the existing commands to read guest memory (from the top of my head:

Re: [Qemu-devel] [PATCH 0/2] Remove BLOCK_OPT_NOCOW from VDI and VPC

2014-12-04 Thread Max Reitz
On 2014-12-04 at 07:25, Stefan Weil wrote: Am 03.12.2014 um 17:50 schrieb Max Reitz: On 2014-12-03 at 16:30, Jeff Cody wrote: This removes the unneeded BLOCK_OPT_NOCOW options from vdi and vpc. Jeff Cody (2): block: remove BLOCK_OPT_NOCOW from vdi_create_opts block: remove

Re: [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it

2014-12-04 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: Since a too small file cannot be a valid VMDK image, and also since the buffer's first 4 bytes will be unconditionally examined by vmdk_open_sparse, let's error out the small file case to be clear. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by:

Re: [Qemu-devel] [PATCH v4 2/6] vmdk: Fix comment to match code of extent lines

2014-12-04 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent type but the comment above the changed code is left out. Update the comment so they are consistent. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- backends/rng-random.c| 6 +- hw/tpm/tpm_passthrough.c | 4 +--- util/uri.c | 43 +-- 3 files changed, 19 insertions(+), 34 deletions(-) diff --git a/backends/rng-random.c

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Fam Zheng
On Thu, 12/04 10:26, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- backends/rng-random.c| 6 +- hw/tpm/tpm_passthrough.c | 4 +--- util/uri.c | 43 +-- 3 files changed, 19 insertions(+), 34

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

2014-12-04 Thread Gonglei
On 2014/12/4 16:47, Gerd Hoffmann wrote: Hi, Hum.. Now, I encountered this situation that the common clienteles just use tightvnc client, but want to change keymap dynamically. As you say, the only way address this scenario is doing it on the server side. So, do you think this patch

Re: [Qemu-devel] [PATCH v4 26/26] iotests: Add test for different refcount widths

2014-12-04 Thread Max Reitz
On 2014-12-04 at 01:03, Eric Blake wrote: On 12/03/2014 05:37 AM, Max Reitz wrote: Add a test for conversion between different refcount widths and errors specific to certain widths (i.e. snapshots with refcount_bits=1). Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/112

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

2014-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2014 at 05:46:22PM +0800, Gonglei wrote: On 2014/12/4 16:47, Gerd Hoffmann wrote: Hi, Hum.. Now, I encountered this situation that the common clienteles just use tightvnc client, but want to change keymap dynamically. As you say, the only way address this scenario

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

2014-12-04 Thread Gonglei
On 2014/12/4 17:53, Daniel P. Berrange wrote: On Thu, Dec 04, 2014 at 05:46:22PM +0800, Gonglei wrote: On 2014/12/4 16:47, Gerd Hoffmann wrote: Hi, Hum.. Now, I encountered this situation that the common clienteles just use tightvnc client, but want to change keymap dynamically. As you

Re: [Qemu-devel] [kernel PATCH v2 0/2] devicetree: document ARM bindings for QEMU's Firmware Config interface

2014-12-04 Thread Peter Maydell
On 30 November 2014 at 16:51, Laszlo Ersek ler...@redhat.com wrote: V2 seeks to address comments raised in the v1 review. Changes are broken out per patch, as git notes. Thanks Laszlo Laszlo Ersek (2): devicetree: document the qemu and virtio vendor prefixes devicetree: document ARM

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: On Thu, 12/04 10:26, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- backends/rng-random.c| 6 +- hw/tpm/tpm_passthrough.c | 4 +--- util/uri.c | 43 +-- 3

Re: [Qemu-devel] [RFC PATCH v5 07/31] icount: implement icount requesting

2014-12-04 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 26/11/2014 11:39, Pavel Dovgalyuk wrote: +int64_t cpu_get_instructions_counter(void) +{ +/* This function calls are synchnonized to timer changes, + calling cpu_get_instructions_counter_locked

[Qemu-devel] [PATCH 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler

2014-12-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. For x86 architecture, we pass error_abort to set_boot_dev() when vm startup in pc_coms_init(). Cc: Michael S. Tsirkin m...@redhat.com Cc:

[Qemu-devel] [PATCH 3/5] bootdevice: add Error **errp argument for qemu_boot_set()

2014-12-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c| 14 ++ include/sysemu/sysemu.h | 2 +-

[Qemu-devel] [PATCH 0/5] bootdevice: Refactor and improvement

2014-12-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Patch 1 just move boot order related code to bootdevice.c. Patch 2,3,5 add an argument to corresponding functions. This way, we can propagate the error messages to the caller. Maybe somebody will say we will remove the legacy boot order in the future, instead

[Qemu-devel] [PATCH 1/5] bootdevice: move code about bootorder from vl.c to bootdevice.c

2014-12-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com First, we can downsize vl.c, make it simpler by little and little. Second, I can maintain those code and make some improvement. Cc: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c| 62

[Qemu-devel] [PATCH 2/5] bootdevice: add Error **errp argument for validate_bootdevices()

2014-12-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com We can use it for checking when we change traditional boot order dynamically and propagate error message to the monitor. Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c| 10 +- include/sysemu/sysemu.h | 2 +- vl.c

[Qemu-devel] [PATCH 4/5] bootdevice: add validate check for qemu_boot_set()

2014-12-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- bootdevice.c | 8 1 file changed, 8 insertions(+) diff --git a/bootdevice.c b/bootdevice.c index 7f07507..9de34ba 100644 --- a/bootdevice.c +++ b/bootdevice.c @@ -49,12 +49,20 @@ void

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Fam Zheng
On Thu, 12/04 11:39, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: On Thu, 12/04 10:26, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- backends/rng-random.c| 6 +- hw/tpm/tpm_passthrough.c | 4 +--- util/uri.c |

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Remove the --git-chief-penguins option

2014-12-04 Thread Thomas Huth
On Mon, 3 Nov 2014 13:50:24 +0100 Thomas Huth th...@linux.vnet.ibm.com wrote: On Wed, 22 Oct 2014 15:16:29 -0400 Don Slutz dsl...@verizon.com wrote: On 10/22/14 08:28, Thomas Huth wrote: Linus likely does not want to get e-mails about QEMU, so let's just remove this option.

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

2014-12-04 Thread Gonglei
On 2014/12/4 17:53, Daniel P. Berrange wrote: We do now provide Windows builds of viewer-viewer + remote-viewer in a single MSI installer for Win 32 64 bit http://virt-manager.org/download/ Hi, I had installed virt-viewer-x86-1.0.msi on my windows machine, and I connected the guest with

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

2014-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2014 at 08:07:14PM +0800, Gonglei wrote: On 2014/12/4 17:53, Daniel P. Berrange wrote: We do now provide Windows builds of viewer-viewer + remote-viewer in a single MSI installer for Win 32 64 bit http://virt-manager.org/download/ Hi, I had installed

[Qemu-devel] [PULL for-2.2 0/2] cirrus: fix blit region check (cve-2014-8106)

2014-12-04 Thread Gerd Hoffmann
in the git repository at: git://git.kraxel.org/qemu tags/pull-cve-2014-8106-20141204-1 for you to fetch changes up to bf25983345ca44aec3dd92c57142be45452bd38a: cirrus: don't overflow CirrusVGAState-cirrus_bltbuf (2014-12-01 10:25:46 +0100

[Qemu-devel] [PULL 2/2] cirrus: don't overflow CirrusVGAState-cirrus_bltbuf

2014-12-04 Thread Gerd Hoffmann
This is CVE-2014-8106. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/display/cirrus_vga.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index d54fb06..2725264 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@

[Qemu-devel] [PULL 1/2] cirrus: fix blit region check

2014-12-04 Thread Gerd Hoffmann
Issues: * Doesn't check pitches correctly in case it is negative. * Doesn't check width at all. Turn macro into functions while being at it, also factor out the check for one region which we then can simply call twice for src + dst. This is CVE-2014-8106. Reported-by: Paolo Bonzini

Re: [Qemu-devel] [RFC PATCH v2 0/6] Support to change VNC keyboard layout dynamically

2014-12-04 Thread Gonglei
On 2014/12/4 20:10, Daniel P. Berrange wrote: On Thu, Dec 04, 2014 at 08:07:14PM +0800, Gonglei wrote: On 2014/12/4 17:53, Daniel P. Berrange wrote: We do now provide Windows builds of viewer-viewer + remote-viewer in a single MSI installer for Win 32 64 bit

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: On Thu, 12/04 11:39, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: On Thu, 12/04 10:26, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- backends/rng-random.c| 6 +- hw/tpm/tpm_passthrough.c | 4

[Qemu-devel] [PATCH] block: Use g_new0() for a bit of extra type checking

2014-12-04 Thread Markus Armbruster
g_new(T, 1) is safer than g_malloc(sizeof(T)), because it returns T * rather than void *, which lets the compiler catch more type errors. Missed in commit 02c4f26. Signed-off-by: Markus Armbruster arm...@redhat.com --- aio-posix.c | 2 +- aio-win32.c | 4 ++-- async.c | 2 +- 3 files

Re: [Qemu-devel] [PATCH] block: Use g_new0() for a bit of extra type checking

2014-12-04 Thread Max Reitz
On 2014-12-04 at 13:55, Markus Armbruster wrote: g_new(T, 1) is safer than g_malloc(sizeof(T)), because it returns T * rather than void *, which lets the compiler catch more type errors. Missed in commit 02c4f26. Signed-off-by: Markus Armbruster arm...@redhat.com --- aio-posix.c | 2 +-

[Qemu-devel] [PATCH 0/3] scsi: Trivial cleanups around g_malloc()

2014-12-04 Thread Markus Armbruster
Markus Armbruster (3): scsi: Drop superfluous conditionals around g_free() scsi: Fuse g_malloc(); memset() into g_malloc0() scsi: Use g_new() friends where that makes obvious sense hw/scsi/lsi53c895a.c | 2 +- hw/scsi/megasas.c | 6 ++ hw/scsi/scsi-generic.c | 6 ++

[Qemu-devel] [PATCH 3/3] scsi: Use g_new() friends where that makes obvious sense

2014-12-04 Thread Markus Armbruster
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form

[Qemu-devel] [PATCH 2/3] scsi: Fuse g_malloc(); memset() into g_malloc0()

2014-12-04 Thread Markus Armbruster
Coccinelle semantic patch: @@ expression LHS, SZ; @@ - LHS = g_malloc(SZ); - memset(LHS, 0, SZ); + LHS = g_malloc0(SZ); Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/scsi/megasas.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 1/3] scsi: Drop superfluous conditionals around g_free()

2014-12-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/scsi/scsi-generic.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index 6b9e4e1..e53470f 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -298,8

Re: [Qemu-devel] [PULL for-2.2 0/2] cirrus: fix blit region check (cve-2014-8106)

2014-12-04 Thread Peter Maydell
On 4 December 2014 at 12:13, Gerd Hoffmann kra...@redhat.com wrote: Hi, Last minute pull req for 2.2, carrying a security fix for cirrus bitblit ops. Applied, thanks. We'll need to do an rc5 now; is there anything else in the pipeline? thanks -- PMM

[Qemu-devel] [PATCH 0/2] net: Trivial cleanups around g_malloc()

2014-12-04 Thread Markus Armbruster
Markus Armbruster (2): net: Fuse g_malloc(); memset() into g_new0() net: Use g_new() friends where that makes obvious sense net/l2tpv3.c | 9 - net/queue.c | 2 +- net/slirp.c | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH 1/2] net: Fuse g_malloc(); memset() into g_new0()

2014-12-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- net/l2tpv3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index 3b805a7..6014c43 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -695,8 +695,7 @@ int net_init_l2tpv3(const NetClientOptions

[Qemu-devel] [PATCH 2/2] net: Use g_new() friends where that makes obvious sense

2014-12-04 Thread Markus Armbruster
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form

Re: [Qemu-devel] [PATCH v4 1/3] qmp: Add command 'blockdev-backup'

2014-12-04 Thread Max Reitz
On 2014-12-04 at 03:29, Fam Zheng wrote: Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible

[Qemu-devel] [PATCH 3/4] x86: Use g_new() friends where that makes obvious sense

2014-12-04 Thread Markus Armbruster
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form

[Qemu-devel] [PATCH 2/4] x86: Fuse g_malloc(); memset() into g_malloc0()

2014-12-04 Thread Markus Armbruster
Coccinelle semantic patch: @@ expression LHS, SZ; @@ - LHS = g_malloc(SZ); - memset(LHS, 0, SZ); + LHS = g_malloc0(SZ); Signed-off-by: Markus Armbruster arm...@redhat.com --- target-i386/arch_dump.c | 16 1 file changed, 4

[Qemu-devel] [PATCH 0/4] x86: Trivial cleanups around g_malloc()

2014-12-04 Thread Markus Armbruster
Markus Armbruster (4): x86: Drop superfluous conditionals around g_free() x86: Fuse g_malloc(); memset() into g_malloc0() x86: Use g_new() friends where that makes obvious sense x86: Drop some superfluous casts from void * hw/i386/pc.c| 3 +-- hw/i386/pc_sysfw.c | 4

[Qemu-devel] [PATCH 1/4] x86: Drop superfluous conditionals around g_free()

2014-12-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/i386/pc_sysfw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c index 75913c5..662d997 100644 --- a/hw/i386/pc_sysfw.c +++ b/hw/i386/pc_sysfw.c @@ -204,9 +204,7 @@ static void

Re: [Qemu-devel] [PATCH] target-arm: ARM64: Adding EL1 AARCH32 guest support for KVM.

2014-12-04 Thread Pranavkumar Sawargaonkar
Hi PMM, On 2 December 2014 at 21:29, Peter Maydell peter.mayd...@linaro.org wrote: On 28 November 2014 at 13:06, Pranavkumar Sawargaonkar pranavku...@linaro.org wrote: In KVM ARM64 one can choose to run guest in 32bit mode i.e EL1 in AARCH32 mode. This patch adds qemu support for running

[Qemu-devel] [PATCH 4/4] x86: Drop some superfluous casts from void *

2014-12-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- target-i386/cpu.c | 2 +- target-i386/kvm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e9df33e..e132c7e 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1530,7

Re: [Qemu-devel] [PATCH v4 2/3] block: Add blockdev-backup to transaction

2014-12-04 Thread Max Reitz
On 2014-12-04 at 03:29, Fam Zheng wrote: Also add version info for other transaction types. Signed-off-by: Fam Zheng f...@redhat.com --- blockdev.c | 81 qapi-schema.json | 7 + 2 files changed, 88 insertions(+) diff --git

[Qemu-devel] [PATCH 3/3] util: Use g_new() friends where that makes obvious sense

2014-12-04 Thread Markus Armbruster
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form

[Qemu-devel] [PATCH 1/3] util: Drop superfluous conditionals around g_free()

2014-12-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- util/uri.c | 48 ++-- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/util/uri.c b/util/uri.c index bbf2832..01dc09e 100644 --- a/util/uri.c +++ b/util/uri.c @@ -225,7 +225,7 @@

[Qemu-devel] [PATCH 0/3] util: Trivial cleanups around g_malloc()

2014-12-04 Thread Markus Armbruster
Markus Armbruster (3): util: Drop superfluous conditionals around g_free() Fuse g_malloc(); memset() into g_new0() util: Use g_new() friends where that makes obvious sense util/hbitmap.c | 4 ++-- util/iov.c | 4 ++-- util/uri.c | 51

[Qemu-devel] [PATCH 2/3] Fuse g_malloc(); memset() into g_new0()

2014-12-04 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- util/uri.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/util/uri.c b/util/uri.c index 01dc09e..918d235 100644 --- a/util/uri.c +++ b/util/uri.c @@ -1004,8 +1004,7 @@ URI * uri_new(void) { URI *ret; -ret =

Re: [Qemu-devel] [PATCH 2/3] Fuse g_malloc(); memset() into g_new0()

2014-12-04 Thread Markus Armbruster
Oops, subject lacks util: prefix. Perhaps it can be fixed up on commit.

Re: [Qemu-devel] [RFC PATCH 3/3] virtio-blk: introduce multiread

2014-12-04 Thread Kevin Wolf
Am 02.12.2014 um 15:33 hat Peter Lieven geschrieben: this patch finally introduce multiread support to virtio-blk while multiwrite support was there for a long time read support was missing. To achieve this the patch does serveral things which might need futher explaination: - the whole

Re: [Qemu-devel] [PATCH v4 2/6] vmdk: Fix comment to match code of extent lines

2014-12-04 Thread Don Koch
On Thu, 4 Dec 2014 07:28:30 +0800 Fam Zheng f...@redhat.com wrote: commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent type but the comment above the changed code is left out. Update the comment so they are consistent. Signed-off-by: Fam Zheng f...@redhat.com ---

Re: [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it

2014-12-04 Thread Don Koch
On Thu, 4 Dec 2014 07:28:32 +0800 Fam Zheng f...@redhat.com wrote: Since a too small file cannot be a valid VMDK image, and also since the buffer's first 4 bytes will be unconditionally examined by vmdk_open_sparse, let's error out the small file case to be clear. Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH v4 3/3] qemu-iotests: Test blockdev-backup in 055

2014-12-04 Thread Max Reitz
On 2014-12-04 at 03:29, Fam Zheng wrote: This applies cases on drive-backup on blockdev-backup, except cases with target format and mode. Also add a case to check source == target. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/055 | 211

Re: [Qemu-devel] [PATCH v4 0/6] vmdk: A few small fixes

2014-12-04 Thread Max Reitz
On 2014-12-04 at 00:28, Fam Zheng wrote: v4: Add Don's and Max's rev-by in 1, 3, 5, 6. 2/6: Add VMFSSPARSE (Max) 4/6: Don't set errno, and add a comment. Fam Zheng (6): vmdk: Use g_random_int to generate CID vmdk: Fix comment to match code of extent lines vmdk: Clean up

Re: [Qemu-devel] [RFC PATCH 3/3] linux-aio: Don't reenter request coroutine recursively

2014-12-04 Thread Kevin Wolf
Am 26.11.2014 um 15:46 hat Kevin Wolf geschrieben: When getting an error while submitting requests, we must be careful to wake up only inactive coroutines. Therefore we must special-case the currently active coroutine and communicate an error for that request using the ordinary return value of

[Qemu-devel] [Bug 1399191] [NEW] Large VHDX image size

2014-12-04 Thread AMULYA L
Public bug reported: We are trying to convert a VMDK image to VHDX image for deploy to HyperV Server ( SCVMM 2012 SP1) using qemu-img. We tried converting the image using both 'fixed' as well as 'dynamic' format. We found that both the disks occupy the same size of 50GB. When the same is done

Re: [Qemu-devel] [RFC PATCH 3/3] virtio-blk: introduce multiread

2014-12-04 Thread Peter Lieven
On 04.12.2014 15:12, Kevin Wolf wrote: Am 02.12.2014 um 15:33 hat Peter Lieven geschrieben: this patch finally introduce multiread support to virtio-blk while multiwrite support was there for a long time read support was missing. To achieve this the patch does serveral things which might need

[Qemu-devel] [PATCH v2 0/3] iotests: Fix test 039

2014-12-04 Thread Max Reitz
Test 039 used to fail because qemu-io -c abort may generate core dumps even with ulimit -c 0 (and the output then contains (core dumped)). Fix this by adding a new qemu-io command sigraise which invokes raise(). Using this command to raise SIGKILL for example does not result in a core dump, but it

[Qemu-devel] [PATCH v2 2/3] iotests: Filter for Killed in qemu-io output

2014-12-04 Thread Max Reitz
_filter_qemu_io already filters out the process ID when qemu-io is aborted; the same should be done when it is killed. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/common.filter | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 3/3] iotests: Fix test 039

2014-12-04 Thread Max Reitz
Test 039 used qemu-io -c abort for simulating a qemu crash; however, abort() generally results in a core dump and ulimit -c 0 is no reliable way of preventing that. Use abort -S 9 instead to have it crash without a core dump. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/039

[Qemu-devel] [PATCH v2 1/3] qemu-io: Add sigraise command

2014-12-04 Thread Max Reitz
abort() has the sometimes undesirable side-effect of generating a core dump. If that is not needed, SIGKILL has the same effect of abruptly crash qemu; without a core dump. Thus, -c abort is not always useful to simulate a qemu-io crash; therefore, this patch adds a new sigraise command which

Re: [Qemu-devel] [RFC PATCH 3/3] virtio-blk: introduce multiread

2014-12-04 Thread Kevin Wolf
Am 04.12.2014 um 15:42 hat Peter Lieven geschrieben: On 04.12.2014 15:12, Kevin Wolf wrote: Am 02.12.2014 um 15:33 hat Peter Lieven geschrieben: this patch finally introduce multiread support to virtio-blk while multiwrite support was there for a long time read support was missing. To

Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory

2014-12-04 Thread Eric Blake
On 12/03/2014 03:07 PM, Bryan D. Payne wrote: In addition to Fam's review, I have a question - does this code properly use qemu_open() so that I can use 'add-fd' to pass in a pre-opened socket fd into fdset 1, then call pmemaccess with '/dev/fdset/1'? If not, can you please fix it to allow

Re: [Qemu-devel] [RFC PATCH 3/3] virtio-blk: introduce multiread

2014-12-04 Thread Peter Lieven
On 04.12.2014 16:03, Kevin Wolf wrote: Am 04.12.2014 um 15:42 hat Peter Lieven geschrieben: On 04.12.2014 15:12, Kevin Wolf wrote: Am 02.12.2014 um 15:33 hat Peter Lieven geschrieben: this patch finally introduce multiread support to virtio-blk while multiwrite support was there for a long

[Qemu-devel] question: guest will hang when call system function in migration thread.

2014-12-04 Thread 陈梁
Hi all guest will hang when call system function in migration thread. The cpu usage of vcpu thread is 100%. the code like this: static void *migration_thread(void *opaque) { MigrationState *s = opaque; int64_t initial_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); int64_t

Re: [Qemu-devel] [RFC PATCH 3/3] linux-aio: Don't reenter request coroutine recursively

2014-12-04 Thread Ming Lei
On Thu, Dec 4, 2014 at 10:37 PM, Kevin Wolf kw...@redhat.com wrote: Am 26.11.2014 um 15:46 hat Kevin Wolf geschrieben: When getting an error while submitting requests, we must be careful to wake up only inactive coroutines. Therefore we must special-case the currently active coroutine and

Re: [Qemu-devel] [RFC PATCH 3/3] linux-aio: Don't reenter request coroutine recursively

2014-12-04 Thread Kevin Wolf
Am 04.12.2014 um 16:22 hat Ming Lei geschrieben: On Thu, Dec 4, 2014 at 10:37 PM, Kevin Wolf kw...@redhat.com wrote: Am 26.11.2014 um 15:46 hat Kevin Wolf geschrieben: When getting an error while submitting requests, we must be careful to wake up only inactive coroutines. Therefore we must

Re: [Qemu-devel] [RFC PATCH 3/3] linux-aio: Don't reenter request coroutine recursively

2014-12-04 Thread Ming Lei
On Thu, Dec 4, 2014 at 11:39 PM, Kevin Wolf kw...@redhat.com wrote: Am 04.12.2014 um 16:22 hat Ming Lei geschrieben: On Thu, Dec 4, 2014 at 10:37 PM, Kevin Wolf kw...@redhat.com wrote: Am 26.11.2014 um 15:46 hat Kevin Wolf geschrieben: When getting an error while submitting requests, we must

Re: [Qemu-devel] [RFC PATCH v5 07/31] icount: implement icount requesting

2014-12-04 Thread Paolo Bonzini
On 04/12/2014 12:02, Pavel Dovgaluk wrote: Why do you need to do this if !cpu_can_do_io(cpu)? We save number of executed instruction when saving interrupt or exception event. It leads to the call of cpu_get_instructions_counter() from cpu_exec function (through several replay functions).

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-04 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: [ CCed Benoît and Max, this is blockdev work ] [ CCed Jeff, we're also talking about op blockers ] Not stripping quoted text for their convenience. Am 02.12.2014 um 20:06 hat Markus Armbruster geschrieben: = Introduction = The block layer and its

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-04 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: On Tue, 12/02 20:06, Markus Armbruster wrote: == block-core.json == * block-commit @device names a backend, @top and @base each name one of its nodes via file name matching. TODO: support specifying the two nodes via node name. Why do we

Re: [Qemu-devel] [PATCH RFC v5 10/19] s390x/virtio-ccw: add virtio set-revision call

2014-12-04 Thread Michael S. Tsirkin
On Tue, Dec 02, 2014 at 02:00:18PM +0100, Cornelia Huck wrote: From: Thomas Huth th...@linux.vnet.ibm.com Handle the virtio-ccw revision according to what the guest sets. When revision 1 is selected, we have a virtio-1 standard device with byteswapping for the virtio rings. When a channel

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-04 Thread Don Slutz
On 12/03/14 09:50, Stefano Stabellini wrote: On Wed, 3 Dec 2014, Don Slutz wrote: On 12/03/14 07:20, Stefano Stabellini wrote: On Wed, 3 Dec 2014, Wei Liu wrote: On Tue, Dec 02, 2014 at 03:23:29PM -0500, Don Slutz wrote: [...] hw_error(xc_domain_getinfo failed); } -if

Re: [Qemu-devel] [Xen-devel] [PATCH] increase maxmem before calling xc_domain_populate_physmap

2014-12-04 Thread Wei Liu
On Thu, Dec 04, 2014 at 11:26:58AM -0500, Don Slutz wrote: [...] those warnings less scary. It was not so much that hvmloader is the one to change (but having it check for room first might be good), but more that a change to xen would be good (like changing the wording or maybe only output

Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory

2014-12-04 Thread Bryan D. Payne
This doesn't stop the client from using a different alignment than we expect. It's necessary to be explicit as a binary protocol. Ok, I'll move ahead with packing the data and sort out the backwards compat issues on the client side. -bryan

Re: [Qemu-devel] [PATCH RFC v5 10/19] s390x/virtio-ccw: add virtio set-revision call

2014-12-04 Thread Cornelia Huck
On Thu, 4 Dec 2014 18:20:05 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Dec 02, 2014 at 02:00:18PM +0100, Cornelia Huck wrote: From: Thomas Huth th...@linux.vnet.ibm.com Handle the virtio-ccw revision according to what the guest sets. When revision 1 is selected, we have a

Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory

2014-12-04 Thread Bryan D. Payne
Can you explain again why the existing commands to read guest memory (from the top of my head: dump-guest-memory, memsave, pmemsave) are insufficient? How does your solution improve on them? What exactly can it do what these commands can't? What exactly can't it do what these commands

Re: [Qemu-devel] [PATCH] target-mips: Correct 32-bit address space wrapping

2014-12-04 Thread Leon Alrae
On 19/11/2014 17:29, Maciej W. Rozycki wrote: qemu-mips32-addr.diff Index: qemu-git-trunk/target-mips/cpu.h === --- qemu-git-trunk.orig/target-mips/cpu.h 2014-11-12 07:41:26.597542010 + +++

Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory

2014-12-04 Thread Bryan D. Payne
Off the top of my head, I know the -tpm command line options (related to the 'query-tpm' QMP command) do this; look at hw/tpm/tpm_passthrough.c for that implementation. Thanks, I'll check that out. Cheers, -bryan

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-04 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Eric Blake ebl...@redhat.com writes: On 12/03/2014 03:30 AM, Kevin Wolf wrote: [ CCed Benoît and Max, this is blockdev work ] [ CCed Jeff, we're also talking about op blockers ] Not stripping quoted text for their convenience. I still intend

[Qemu-devel] [PATCH] arm_gic_kvm: Tell kernel about number of IRQs

2014-12-04 Thread Peter Maydell
Newer kernels support a device attribute on the GIC which allows us to tell it how many IRQs this GIC instance is configured with; use it, if it exists. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/intc/arm_gic_kvm.c | 20 1 file changed, 20 insertions(+)

[Qemu-devel] [PATCH] ide: Implement VPD response for ATAPI

2014-12-04 Thread John Snow
SCSI devices have multiple kinds of queries they need to respond to, as defined in the cmd inquiry section in MMC-6 and SPC-3. Relevent sections: MMC-6 revision 2g: Non-VPD response data and pointer to SPC-3; Section 6.8 Inquiry Command SPC-3 revision 23: Inquiry command and

Re: [Qemu-devel] [PATCH v4 26/26] iotests: Add test for different refcount widths

2014-12-04 Thread Eric Blake
On 12/04/2014 02:51 AM, Max Reitz wrote: Side note: Now that we can produce MUCH smaller images where the reftable can easily require enough contiguous clusters to require the creation of at least one refblock that cannot be self-referential, it would probably be good to modify an existing

Re: [Qemu-devel] [PATCH] target-arm: Check error conditions on kvm_arm_reset_vcpu

2014-12-04 Thread Peter Maydell
On 3 December 2014 at 20:17, Christoffer Dall christoffer.d...@linaro.org wrote: When resetting a VCPU we currently call both kvm_arm_vcpu_init() and write_kvmstate_to_list(), both of which can fail, but we never check the return value. The only choice here is to print an error an exit if the

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Eric Blake
On 12/04/2014 03:39 AM, Markus Armbruster wrote: As per standard operating procedure, I expanded tabs in the lines I touched. No visual difference, except in patches. What do you want me to do? 1. Don't expand tabs, ignore checkpatch.pl whining 2. Expand tabs in touched lines (current

Re: [Qemu-devel] [PATCH] Drop superfluous conditionals around g_strdup()

2014-12-04 Thread Eric Blake
On 12/04/2014 02:26 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- backends/rng-random.c| 6 +- hw/tpm/tpm_passthrough.c | 4 +--- util/uri.c | 43 +-- 3 files changed, 19 insertions(+), 34

Re: [Qemu-devel] Review of monitor commands identifying BDS / BB by name

2014-12-04 Thread Eric Blake
On 12/04/2014 08:56 AM, Markus Armbruster wrote: @device is a sub-optimal name for this single parameter. Either we accept that and move on, or we deprecate it in favor of a new parameter with a better name. I guess the better name isn't worth that much trouble, in particular since the

[Qemu-devel] [Bug 1349277] Re: AArch64 emulation ignores SPSel=0 when taking (or returning from) an exception at EL1 or greater

2014-12-04 Thread Chris J Arges
** Changed in: qemu (Ubuntu) Assignee: (unassigned) = Chris J Arges (arges) ** Changed in: qemu (Ubuntu) Status: New = In Progress ** Changed in: qemu (Ubuntu) Importance: Undecided = Medium -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [Bug 1349277] Re: AArch64 emulation ignores SPSel=0 when taking (or returning from) an exception at EL1 or greater

2014-12-04 Thread Ubuntu Foundations Team Bug Bot
The attachment Proposed fix seems to be a patch. If it isn't, please remove the patch flag from the attachment, remove the patch tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for

[Qemu-devel] [Bug 1349277] Re: AArch64 emulation ignores SPSel=0 when taking (or returning from) an exception at EL1 or greater

2014-12-04 Thread Chris J Arges
Uploaded fixed package for Vivid: https://launchpad.net/ubuntu/+source/qemu/2.1+dfsg-7ubuntu3 Please let me know if this fixes the issue. ** Changed in: qemu (Ubuntu) Status: In Progress = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH] target-arm: Check error conditions on kvm_arm_reset_vcpu

2014-12-04 Thread Christoffer Dall
On Thu, Dec 4, 2014 at 8:13 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 3 December 2014 at 20:17, Christoffer Dall christoffer.d...@linaro.org wrote: When resetting a VCPU we currently call both kvm_arm_vcpu_init() and write_kvmstate_to_list(), both of which can fail, but we never

  1   2   >