This was reported for this warning:
hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
the left hand side of comparison [-Wlogical-not-parentheses]
Reported-by: dcb
Suggested-by: dcb
Bug: https://bugs.launchpad.net/qemu/+bug/1393486
Signed-off-by: Amit Shah
---
hw/virtio/vir
Thanks Poalo, This was helpful.
Regards,Sai Pavan
On Wednesday, December 10, 2014 6:27 PM, Paolo Bonzini
wrote:
On 09/12/2014 12:28, boddu pavan wrote:
> Hi,
>
> I am new to qemu, And i need help in understanding a part of code, Can
> any one tell the use of Canonical paths of t
On 2014/12/4 14:34, Gonglei (Arei) wrote:
> From: Gonglei
>
> Variable local_err going out of scope
> leaks the storage it points to.
>
> Cc: Markus Armbruster
> Signed-off-by: Gonglei
> ---
> block/rbd.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Ping...
> diff --g
This patch adds a new bit to memory hotplug IO port indicating that
ej0 has been evaluated by guest OS. And call pc-dimm unplug cb to do
the real removal.
Signed-off-by: Hu Tao
Signed-off-by: Tang Chen
---
docs/specs/acpi_mem_hotplug.txt | 8 ++--
hw/acpi/memory_hotplug.c| 23
Currently, as rbd driver do not support dynamic growth when write beyond EOF,
so just print a clear error message.
Signed-off-by: Jun Li
---
v2:
Just use rbd_aio_write to realize error detection.
---
block/rbd.c | 4
1 file changed, 4 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
in
From: Hu Tao
This patch implements MEMORY_SLOT_EJECT_METHOD according to ACPI spec.
Signed-off-by: Hu Tao
Signed-off-by: Tang Chen
---
hw/i386/acpi-dsdt-mem-hotplug.dsl | 11 ++-
hw/i386/ssdt-mem.dsl | 5 +
include/hw/acpi/pc-hotplug.h | 2 ++
3 files changed,
Implement unplug cb for pc-dimm. It remove the corresponding
memory region, and unregister vmstat. At last, it calls memory
unplug cb to reset memory status and do unparenting.
---
hw/i386/pc.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/hw/i386/p
Call memory unplug cb in piix4_device_unplug_cb().
---
hw/acpi/piix4.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index f809c3a..4ae4867 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -377,8 +377,16 @@ static void piix
Implement memory unplug request cb for pc-dimm, and call it in
pc_machine_device_unplug_request_cb().
---
hw/i386/pc.c | 28 ++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 27d82b1..fa8bed4 100644
--- a/hw/i386/pc.c
+++
Reset all memory status, and unparent the memory device.
---
hw/acpi/memory_hotplug.c | 16
include/hw/acpi/memory_hotplug.h | 2 ++
2 files changed, 18 insertions(+)
diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
index 3d8e398..2b0c8ca 100644
--- a/hw/
Memory hot unplug are both asynchronize procedures.
When the unplug operation happens, unplug request cb is called first.
And when ghest OS finished handling unplug, unplug cb will be called
to do the real removal of device.
This patch adds unplug request cb for memory device. Add a new bool
membe
Add a new API named acpi_memory_hotplug_sci() to send memory hotplug SCI.
Doing this is because this procedure will be used by other functions in the
next coming patches.
Signed-off-by: Tang Chen
---
hw/acpi/memory_hotplug.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
dif
Call memory unplug request cb in ich9_pm_device_unplug_request_cb().
---
hw/acpi/ich9.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index c48d176..841f57d 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -304,8 +304,14 @@ void i
Add a new API named acpi_memory_get_slot_status_descriptor() to obtain
a single memory slot status. Doing this is because this procedure will
be used by other functions in the next coming patches.
Signed-off-by: Tang Chen
---
hw/acpi/memory_hotplug.c | 27 +++
1 file chan
Memory hot unplug are both asynchronize procedures.
When the unplug operation happens, unplug request cb is called first.
And when ghest OS finished handling unplug, unplug cb will be called
to do the real removal of device.
This patch-set is based on QEmu 2.2
Hu Tao (2):
acpi, piix4: Add memor
Call memory unplug cb in ich9_pm_device_unplug_cb().
---
hw/acpi/ich9.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 841f57d..0a8e757 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -317,8 +317,14 @@ void ich9_pm_device_un
From: Hu Tao
Call memory unplug request cb in piix4_device_unplug_request_cb().
Signed-off-by: Hu Tao
Signed-off-by: Tang Chen
---
hw/acpi/piix4.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index 4407388..f809c3a 100644
--- a/hw/
Memory and CPU hot unplug are both asynchronize procedures.
When the unplug operation happens, unplug request cb is called first.
And when ghest OS finished handling unplug, unplug cb will be called
to do the real removal of device.
This patch adds hotunplug cb for piix4, and memory and CPU
hot un
Memory and CPU hot unplug are both asynchronize procedures.
When the unplug operation happens, unplug request cb is called first.
And when ghest OS finished handling unplug, unplug cb will be called
to do the real removal of device.
This patch adds hotunplug cb for ich9, and memory and CPU
hot unp
Memory and CPU hot unplug are both asynchronize procedures.
When the unplug operation happens, unplug request cb is called first.
And when ghest OS finished handling unplug, unplug cb will be called
to do the real removal of device.
They both need pc-machine, piix4 and ich9 unplug and unplug reque
Replace string "slot" in acpi_memory_plug_cb() with MACRO PC_DIMM_SLOT_PROP.
Signed-off-by: Tang Chen
---
hw/acpi/memory_hotplug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
index ed39241..c6580da 100644
--- a/hw/acpi
Memory and CPU hot unplug are both asynchronize procedures.
When the unplug operation happens, unplug request cb is called first.
And when ghest OS finished handling unplug, unplug cb will be called
to do the real removal of device.
This patch adds hotunplug cb for pc machine, and memory and CPU
h
Memory and CPU hot unplug are both asynchronize procedures.
They both need unplug request cb when the unplug operation happens.
This patch adds hotunplug request cb for ich9, and memory and CPU
hot unplug will base on it.
---
hw/acpi/ich9.c | 7 +++
hw/isa/lpc_ich9.c | 5 +++--
i
Memory and CPU hot unplug are both asynchronous procedures.
They both need unplug request callback to initiate unplug operation.
Add unplug handler to pc machine that will be used by following
CPU and memory unplug patches.
---
hw/i386/pc.c | 8
1 file changed, 8 insertions(+)
diff --gi
>
> Look good. I believe QMP will be in between, and if it doesn't work as
> well,
> could you also try to use QEMU's char dev instead of limit this to unix
> socket?
>
Sure, I'll look into that as well.
-bryan
On Wed, 2014-12-10 at 16:59 -0600, Greg Bellows wrote:
>
>
> On 10 December 2014 at 07:19, Marcel Apfelbaum
> wrote:
> QEMU has support for options per machine, keeping
> a global list of options is no longer necessary.
>
> Signed-off-by: Marcel Apfelbaum
>
On Wed, 12/10 21:33, Bryan D. Payne wrote:
> > By "evidence", I mean actual numbers for actual QEMU code. Nothing
> >> sophisticated, just use your new interface in a way you consider
> >> relevant for your own use case, then approximate this use with existing
> >> interfaces. The approximation c
Some drivers probe PHY addresses beyond the first one, and
also (unfortunately) don't check for MDIC_ERROR on reads. It appears
that the driver assumes that the data reads will return zero in this
case (invalid PHY address). Anecdotally, hardware is believed to do
this; but qemu wasn't, and instead
Some drivers set RDT=RDH. Oddly, this works on real hardware. To work
around this, autodecrement RDT when this happens.
Signed-off-by: Richard Tollerton
Signed-off-by: Jeff Westfahl
---
hw/net/e1000.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
inde
The 8254x driver in certain versions of Phar Lap ETS hasn't been
initializing the e1000 device properly in qemu. It looks like the driver
is relying on two specific pieces of behavior which (anecdotally) exist
in hardware, although I can't cite any datasheets on the matter; in any
case, these two p
On 2014/12/11 11:10, Linhaifeng wrote:
> Hi,all
>
> Yestoday i tested the set_mem_table message found that qemu not send all the
> memory info(fd and size) when
> VM memory size is 2G and have two numa nodes(two hugepage files).If VM memory
> size is 4G and have two numa nodes
> will send all
Chris,
I've read through 1292234 and I'll have a play with your reproducer locally and
see if I can gain any insight.
I'm sorry my fix didn't help 1292234, but glad you can't hit 1368815
with upstream, I was kinda having kittens here ;P
--
You received this bug notification because you are a me
Currently, the RTAS time of day functions only partially validate the
number of parameters they receive and return. Because of how the
parameters are used, this is unlikely to lead to a crash, but it's messy.
This patch adds the missing checks.
Signed-off-by: David Gibson
---
hw/ppc/spapr_rtc.
At the moment, the PAPR RTC implementation (actually a paravirt
firmware interface, rather than a normal device) works directly off
host time, and so doesn't respect the options such as clock=vm which
can be specified in the -rtc command line option.
This series is a first cut at addressing this.
In the 'pseries' machine the real time clock is provided by a
paravirtualized firmware interface rather than a device per se; the RTAS
get-time-of-day and set-time-of-day calls.
Out current implementations of those work directly off host time (with
an offset), not respecting options such as clock=
At the moment the RTAS (firmware/hypervisor) time of day functions are
implemented in spapr_rtas.c along with a bunch of other things. Since
we're going to be expanding these a bit, move the RTAS RTC related code
out into new file spapr_rtc.c. Also add its own initialization function,
spapr_rtc_i
Hi,
I raised a bug https://bugs.launchpad.net/qemu/+bug/1399191 in the qemu
bugzilla and immediately started getting these patch mails. But, I am not
seeing any update in the bugzilla site.
Till now I have got 4 patch mails regarding the issue. Please let me know which
patch I should apply. Als
Just to clarify it's bug 1292234 in the previous comment.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently corrupts output images
Status in OpenStack Co
Tony,
Yea, its a different bug. I tested with the above patched package and
upstream qemu from git, and I can still hit bug 129224. I was hoping
this also fixed my issue, but unfortunately it seems to be a different
issue that occurs when using the same types of filesystems. I have a
solid reprodu
> By "evidence", I mean actual numbers for actual QEMU code. Nothing
>> sophisticated, just use your new interface in a way you consider
>> relevant for your own use case, then approximate this use with existing
>> interfaces. The approximation can be very rough. For instance, showing
>> that do
On Wed, 12/10 13:48, Josh Durgin wrote:
> On 12/10/2014 07:47 AM, Jun Li wrote:
> >Currently, as rbd driver do not support dynamic growth when write beyond EOF,
> >so just print a clear error message.
> >
> >Signed-off-by: Jun Li
> >---
> > block/rbd.c | 14 ++
> > 1 file changed, 14
Hi,all
Yestoday i tested the set_mem_table message found that qemu not send all the
memory info(fd and size) when
VM memory size is 2G and have two numa nodes(two hugepage files).If VM memory
size is 4G and have two numa nodes
will send all the memory info.
Here is my understand,is this right?
On 2014/12/10 17:37, Gerd Hoffmann wrote:
> This patch switches vnc over to QemuOpts, and it (more or less
> as side effect) allows multiple vnc server instances.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/ui/console.h | 4 +-
> qmp.c| 15 ++-
> ui/vnc.c | 2
Introduce PCI_DEVFN_AUTO rather than using -1 in code.
Signed-off-by: Hu Tao
---
hw/pci/pci.c | 5 ++---
include/hw/pci/pci.h | 2 ++
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 371699c..73c7dec 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/p
On Thu, Dec 11, 2014 at 10:20:28AM +0800, Hu Tao wrote:
> Introduce PCI_DEVFN_AUTO rather than using -1 in code.
>
> Signed-off-by: Hu Tao
> ---
> hw/core/qdev-properties.c | 1 +
> hw/pci/pci.c | 5 ++---
> include/hw/pci/pci.h | 2 ++
> 3 files changed, 5 insertions(+), 3 del
On 2014/12/10 18:39, Dr. David Alan Gilbert wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> wrote:
>>> From: ChenLiang
>>>
>>> Signed-off-by: ChenLiang
>>> Signed-off-by: Gonglei
>>> Reviewed-by: Dr. David Alan Gilbert
>>> ---
>>> arch_init.c | 8 +++-
>>> 1 file changed, 3 inse
Introduce PCI_DEVFN_AUTO rather than using -1 in code.
Signed-off-by: Hu Tao
---
hw/core/qdev-properties.c | 1 +
hw/pci/pci.c | 5 ++---
include/hw/pci/pci.h | 2 ++
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-propert
On 2014/12/10 18:09, Amit Shah wrote:
> On (Wed) 10 Dec 2014 [08:03:33], Amit Shah wrote:
>> On (Mon) 24 Nov 2014 [19:55:46], arei.gong...@huawei.com wrote:
>>> From: ChenLiang
>>>
>>> Hi,
>>>
>>> This set of patches rebase on
>>> https://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg04956.
PCI_HOST_BRIDGE_CONFIG_ADDR and PCI_HOST_BRIDGE_CONFIG_DATA are
defined in PCI specification, so move them to common place.
Signed-off-by: Hu Tao
Reviewed-by: Marcel Apfelbaum
---
hw/pci-host/piix.c| 8
hw/pci-host/prep.c| 6 --
hw/pci-host/q35.c | 8
This makes code more readable.
Signed-off-by: Hu Tao
Reviewed-by: Marcel Apfelbaum
---
hw/mips/gt64xxx_pci.c | 4 ++--
hw/pci/pci_host.c | 5 +++--
include/hw/pci/pci_host.h | 5 +
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt
Since the limit parameter is always set to the size of pci device's
configuration space, and we can determine the size from the type of pci
device.
Signed-off-by: Hu Tao
---
hw/pci/pci_host.c | 15 +++
hw/pci/pcie_host.c| 9 +
hw/ppc/spapr_pci.c| 3 +
Hi,
This is v3 of PCI clenaup series. See each patch for the detail.
Regards,
Hu
changes:
v3:
- rebase on top of 7fb8da2b886, all 5 patches applied cleanly.
- new patch: pci: introduce PCI_DEVFN_AUTO
v2:
- remove patch 3 from v1 which is incorrect.
- rename defined macros as per Marcel
This makes code more readable.
Signed-off-by: Hu Tao
Reviewed-by: Marcel Apfelbaum
---
include/hw/pci/pci.h | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index c352c7b..b18759a 100644
---
Since the limit parameter is always set to the size of pci device's
configuration space, and we can determine the size from the type of pci
device.
Signed-off-by: Hu Tao
---
hw/pci/pci_host.c | 13 ++---
hw/pci/pcie_host.c| 9 +
hw/ppc/spapr_pci.c| 3 +--
On 2014/12/10 17:37, Gerd Hoffmann wrote:
> In case the display id is "default" (which is the one you get if you
> don't explicitly assign one) we keep the old name scheme, without
> display, for backward compatibility reasons.
>
> Signed-off-by: Gerd Hoffmann
> ---
> ui/vnc.c | 22
On 2014/12/10 17:37, Gerd Hoffmann wrote:
> DisplayState isn't used anywhere, drop it. Add the vnc server ID as
> parameter instead, so it is possible to specify the server instance.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/ui/console.h | 16
> ui/vnc.c | 2
On 2014/12/10 17:37, Gerd Hoffmann wrote:
> Replace with a vnc_displays list, so we can have multiple vnc server
> instances. Add vnc_server_find function to lookup a display by id.
> With no id supplied return the first vnc server, for backward
> compatibility reasons.
>
> It is not possible (y
Old kernels that used high memory only allowed the initrd to be in the
first 896MB of memory. If you load the initrd above, they complain
that "initrd extends beyond end of memory".
In order to fix this, while not breaking machines with small amounts
of memory fixed by cdebec5 (linuxboot: compute
Set register widths in the GDB stub as follows:
- for the system emulation mode -- to the native register size of the
processor selected, any MIPS I, MIPS II or MIPS32 (any revision)
processor will have 32-bit general purpose registers and any MIPS III,
MIPS IV or MIPS64 (again, any revis
Rework the MIPS ABIs and CPU emulations available according to the
following target list:
- mips|mipsel -- 32-bit CPUs only, system and user emulation mode,
o32 user ABI,
- mips64|mips64el -- 32-bit and 64-bit CPUs, system and user emulation
On Wed, 12/10 13:50, Markus Armbruster wrote:
> Fam Zheng writes:
>
> > This will make it easier to keep checkpatch.pl happy.
> >
> > Fam Zheng (2):
> > qemu-iotests: Remove traling whitespaces in *.out
> > block: Don't add trailing space in "Formating..." message
>
> Sounds like PATCH 1 bre
On Wed, 10 Dec 2014, Peter Maydell wrote:
> > Except that apart from coming to an agreement someone has to make it
> > happen yet. ;)
>
> Ah, but I'm happy with the current state of the codebase...
Ack.
> > Fair enough, I want to move forward though. Would it make you happy if I
> > dropped
On 10 December 2014 at 16:50, Peter Maydell
wrote:
> On 10 December 2014 at 22:26, Greg Bellows
> wrote:
> >
> >
> > On 9 December 2014 at 13:46, Peter Maydell
> wrote:
> >> +static bool raw_accessors_valid(const ARMCPRegInfo *ri)
> >> +{
> >> +/* Return true if a raw access on this registe
On 10 December 2014 at 16:46, Peter Maydell
wrote:
> On 10 December 2014 at 22:01, Greg Bellows
> wrote:
> >
> >
> > On 9 December 2014 at 13:46, Peter Maydell
> wrote:
> >>
> >> /* TimerValue views: a 32 bit downcounting view of the underlying
> >> state */
> >> { .name = "CNTP_TVAL"
On 10 December 2014 at 07:19, Marcel Apfelbaum wrote:
> QEMU has support for options per machine, keeping
> a global list of options is no longer necessary.
>
> Signed-off-by: Marcel Apfelbaum
> ---
> hw/core/machine.c | 45 +
> hw/i386/pc.c | 7 +
> hw/ppc
On 10 December 2014 at 22:14, Maciej W. Rozycki wrote:
> On Wed, 10 Dec 2014, Peter Maydell wrote:
>> > As noted in 0/3 ideally we'd handle all ELF flavours with a single
>> > binary. Then we could have two system configurations only, mips|mipsel (a
>> > limited configuration for 32-bit host op
On 10 December 2014 at 22:26, Greg Bellows wrote:
>
>
> On 9 December 2014 at 13:46, Peter Maydell wrote:
>> +static bool raw_accessors_valid(const ARMCPRegInfo *ri)
>> +{
>> +/* Return true if a raw access on this register is OK (ie will not
>> + * fall into the assert in raw_read() or r
On 10 December 2014 at 22:01, Greg Bellows wrote:
>
>
> On 9 December 2014 at 13:46, Peter Maydell wrote:
>>
>> /* TimerValue views: a 32 bit downcounting view of the underlying
>> state */
>> { .name = "CNTP_TVAL", .cp = 15, .crn = 14, .crm = 2, .opc1 = 0,
>> .opc2 = 0,
>> - .type
On 9 December 2014 at 13:46, Peter Maydell wrote:
> Add assertion checking when cpreg structures are registered that they
> either forbid raw-access attempts or at least make an attempt at
> handling them. Also add an assert in the raw-accessor-of-last-resort,
> to avoid silently doing a read or
On Wed, 10 Dec 2014, Peter Maydell wrote:
> > This is a tricky change, the system emulation mode configuration also has
> > an ELF loader (invoked with the -kernel option) and as such is also
> > affected. There are three MIPS ELF flavours corresponding to the three
> > ABIs: ELF32 no-ABI2 for o
On 09/12/2014 19:15, Dr. David Alan Gilbert (git) wrote:
> (With the previous atapi_dma flag recovery)
> If migration happens between the ATAPI command being written and the
> bmdma being started, the DMA is dropped. Eventually the guest times
> out and recovers, but that can take many seconds.
On 9 December 2014 at 13:46, Peter Maydell wrote:
> We currently mark ARM coprocessor/system register definitions with
> the flag ARM_CP_NO_MIGRATE for two different reasons:
> 1) register is an alias on to state that's also visible via
>some other register, and that other register is the one
Hi Chris,
Markus' rework will not reintroduce this bug as it completely removes all
fiemap code.
bug 129224 is a different issue, I'll comment on that bug.
You say: you encounter issues with upstream with ^extent and ext3
filesystems. Just to be clear: Are you saying that *this* bug is still
a
On 12/10/2014 07:47 AM, Jun Li wrote:
Currently, as rbd driver do not support dynamic growth when write beyond EOF,
so just print a clear error message.
Signed-off-by: Jun Li
---
block/rbd.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
index 5
On 10 December 2014 at 20:29, Maciej W. Rozycki wrote:
> On Wed, 10 Dec 2014, Peter Maydell wrote:
>
>> > Index: qemu-git-trunk/default-configs/mipsn32-softmmu.mak
>> > Index: qemu-git-trunk/default-configs/mipsn32el-softmmu.mak
>> > Index: qemu-git-trunk/default-configs/mipsn64el-linux-user.mak
>
Filed a separate issue for MOS
https://bugs.launchpad.net/mos/+bug/1401261
** No longer affects: mos
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently co
** Tags removed: verification-needed-utopic
** Tags added: verification-done-utopic
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368815
Title:
qemu-img convert intermittently corrupts output imag
Looking at the fixes, I also see the following commits remove the above
changes, which could mean we might encounter this again:
c4875e5 raw-posix: SEEK_HOLE suffices, get rid of FIEMAP
d1f06fe raw-posix: The SEEK_HOLE code is flawed, rewrite it
Note there is also a related issue:
bug 1292234
So
On Wed, 10 Dec 2014, Peter Maydell wrote:
> > Index: qemu-git-trunk/default-configs/mipsn32-softmmu.mak
> > Index: qemu-git-trunk/default-configs/mipsn32el-softmmu.mak
> > Index: qemu-git-trunk/default-configs/mipsn64el-linux-user.mak
> > Index: qemu-git-trunk/default-configs/mipsn64el-softmmu.mak
On Wed, Dec 10, 2014 at 08:43:55PM +0100, Igor Mammedov wrote:
> On Wed, 10 Dec 2014 20:28:01 +0200
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Dec 10, 2014 at 06:39:49PM +0100, Igor Mammedov wrote:
> > > On Wed, 10 Dec 2014 19:13:59 +0200
> > > "Michael S. Tsirkin" wrote:
> > >
> > > > On Wed,
* John Snow (js...@redhat.com) wrote:
> What makes me the most curious is how this plays out in Windows if this case
> is triggered. Throw a trace around the fake error and see if you can't
> observe it getting called during a pingpong test while Windows reads a CD.
I've not managed to trigger it
On 10 December 2014 at 19:26, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost
> ---
> exec.c | 1 -
> hw/virtio/virtio.c | 1 -
> include/exec/exec-all.h | 2 ++
> 3 files changed, 2 insertions(+), 2 deletions(-)
I thought this prototype was deliberately not in a g
On Wed, 10 Dec 2014 20:28:01 +0200
"Michael S. Tsirkin" wrote:
> On Wed, Dec 10, 2014 at 06:39:49PM +0100, Igor Mammedov wrote:
> > On Wed, 10 Dec 2014 19:13:59 +0200
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Dec 10, 2014 at 05:45:58PM +0100, Igor Mammedov wrote:
> > > > On Wed, 10 Dec
On 10 December 2014 at 18:53, Maciej W. Rozycki wrote:
> Mechanically add new n32/n64 configuration files copying the relevant
> preexisting ones, fixing the system emulation configuration build, that
> breaks due to the lack of the respective configuration files, for the
> `mipsn32' and `mipsn32e
Signed-off-by: Eduardo Habkost
---
tests/test-x86-cpu.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/tests/test-x86-cpu.c b/tests/test-x86-cpu.c
index b6e4382..fb3de05 100644
--- a/tests/test-x86-cpu.c
+++ b/tests/test-x86-cpu.c
@@ -54,6 +54,30 @@ static void tes
Instead of using a test-specific hack to add -I$(SRC_PATH)/target-i386, add
test-x86-cpuid to $(test-obj-x86_64-softmmu-y).
Signed-off-by: Eduardo Habkost
---
tests/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/Makefile b/tests/Makefile
index 85ac430..f
Signed-off-by: Eduardo Habkost
---
exec.c | 1 -
hw/virtio/virtio.c | 1 -
include/exec/exec-all.h | 2 ++
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index 71ac104..ed5 100644
--- a/exec.c
+++ b/exec.c
@@ -2845,7 +2845,6 @@ int cpu_mem
The unit test includes target-i386/cpu.c instead of simply linking
against cpu.o because the test code will use static variables/functions
from cpu.c.
Reasoning for each object file included in the test binary:
* qom/cpu.o - for TYPE_CPU. Dependencies:
* qom/qom-qobject.o
* qom/qdev.o - for T
This will make it easier to write unit tests for the feature
initialization logic.
Signed-off-by: Eduardo Habkost
---
target-i386/cpu.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index e9df33e..b6b3c4f 100644
--- a/targe
Signed-off-by: Eduardo Habkost
---
tests/test-x86-cpu.c | 90
1 file changed, 90 insertions(+)
diff --git a/tests/test-x86-cpu.c b/tests/test-x86-cpu.c
index fb3de05..20842c5 100644
--- a/tests/test-x86-cpu.c
+++ b/tests/test-x86-cpu.c
@@ -78,
Changes v2 -> v3:
* Extra KVM "host" CPU model test cases
* Move target_words_bigendian() prototype to exec-all.h
Changes v1 -> v2:
* Make dependency list of test binary much simpler, now that cpus.o
was removed.
Eduardo Habkost (7):
Move target_words_bigendian() prototype to exec-all.h
To make unit tests that depend on target-specific files, use
check-unit--y and test-obj--y.
Note that the qtest test cases were per-*arch* (e.g. i386, mips, ppc),
not per-*target* (e.g. i386-softmmu, x86_64-linux-user), because they
implicitly apply only to the -softmmu targets. Target-specific un
** Also affects: mos
Importance: Undecided
Status: New
** Changed in: mos
Status: New => Triaged
** Changed in: mos
Importance: Undecided => Critical
** Changed in: mos
Assignee: (unassigned) => MOS Linux (mos-linux)
** Changed in: mos
Milestone: None => 6.0
--
Yo
On 10/12/2014 19:39, Radim Krčmář wrote:
> 2014-12-10 18:55+0100, Paolo Bonzini:
>> Well, my preferred choice would be automatic adjustment with a module
>> parameter. If we need manual tuning, per-CPU would be my choice, but
>> automatic is nicer anyway. :)
>
> I agree with Paolo, and think it
Set register widths in the GDB stub as follows:
- for the system emulation mode -- to the native register size of the
processor selected, any MIPS I, MIPS II or MIPS32 (any revision)
processor will have 32-bit general purpose registers and any MIPS III,
MIPS IV or MIPS64 (again, any revis
Rework the MIPS ABIs and CPU emulations available according to the
following target list:
- mips|mipsel -- 32-bit CPUs only, o32 user and GDB ABI,
- mips64|mips64el -- 32-bit and 64-bit CPUs, o32 user and GDB ABI,
- mipsn32|mipsn32el -- 64-bit CPUs only, n32 user and GDB ABI,
- mipsn64
Mechanically add new n32/n64 configuration files copying the relevant
preexisting ones, fixing the system emulation configuration build, that
breaks due to the lack of the respective configuration files, for the
`mipsn32' and `mipsn32el' targets on this occasion as well.
Signed-off-by: Maciej W
Hi,
This mini patch series corrects some misguided assumptions in QEMU's MIPS
processor selection while also adding another configuration to support a
missing ABI-processor combination, and then corrects register widths used
by the GDB stub so as to match the processor selected (for the system
I couldn't reproduce the bug on the old qemu myself, however Michael has
verified the (same) fix on trusty, and the full qa-regression-test
passed for me on utopic-proposed. So I would request that we call this
verification-done.
--
You received this bug notification because you are a member of
2014-12-10 18:55+0100, Paolo Bonzini:
> Well, my preferred choice would be automatic adjustment with a module
> parameter. If we need manual tuning, per-CPU would be my choice, but
> automatic is nicer anyway. :)
I agree with Paolo, and think it would be better not to touch QEMU ...
it makes litt
1 - 100 of 345 matches
Mail list logo
