[Qemu-devel] [PATCH 12/15] cpu_ldst_template.h: Use ld*_p directly rather than via ld*_raw macros

2015-01-15 Thread Peter Maydell
The ld*_raw and st*_raw macros are now only used within the code produced by cpu_ldst_template.h, and only in three places. Expand these out to just call the ld_p and st_p functions directly. Note that in all the callsites the address argument is a uintptr_t, so we can drop that part of the

Re: [Qemu-devel] [PATCH 03/15] target-sparc: Don't use {ld, st}*_raw functions

2015-01-15 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Instead of using the _raw family of ld/st accessor functions, use cpu_*_data. All this code is CONFIG_USER_ONLY, so the two are the same semantically, but the _raw functions are really a detail of the implementation which has leaked into a few

Re: [Qemu-devel] [RFC PATCH 4/4] hw/arm/sysbus-fdt: arm, pl330 vfio device property

2015-01-15 Thread Eric Auger
Hi Baptiste, On 01/12/2015 02:21 PM, Baptiste Reynal wrote: Adapt arm,pl330 function to use the vfio device property API. Clock apb-pclk is the default if a clock is needed by the device. Three optional parameters are taken into account : - #dma-cells - #dma-channels - #dma-requests

Re: [Qemu-devel] [RfC PATCH 2/3] sdl2: add support for display rendering using opengl.

2015-01-15 Thread Max Reitz
On 2015-01-12 at 07:46, Gerd Hoffmann wrote: Hi, +glBegin(GL_QUADS); +glTexCoord2f(0, 1); glVertex3f(-1, -1, 0); +glTexCoord2f(0, 0); glVertex3f(-1, 1, 0); +glTexCoord2f(1, 0); glVertex3f(1, 1, 0); +glTexCoord2f(1, 1); glVertex3f(1, -1, 0); +glEnd(); I've been

Re: [Qemu-devel] [PATCH 2/3] multiboot: Fix offset of bootloader name

2015-01-15 Thread Max Reitz
On 2015-01-15 at 06:26, Kevin Wolf wrote: This fixes a bug introduced in commit 5eba5a66 ('Add bootloader name to multiboot implementation'). The calculation of the bootloader name offset didn't consider space occupied by module command lines, so some unlucky module got its command line

Re: [Qemu-devel] [PATCH] arm: define version-based machine type for ARM

2015-01-15 Thread Peter Maydell
On 15 January 2015 at 17:50, Wei Huang w...@redhat.com wrote: ARM virt machine type (machvirt) had been stable for a while. But recently new devices have been added to support extra features. Considerring the support of long-term compatibility, it is time to create a version-based machine

Re: [Qemu-devel] [PATCH 3/3] tests/multiboot: Add test for modules

2015-01-15 Thread Max Reitz
On 2015-01-15 at 06:26, Kevin Wolf wrote: This test case is meant to detect corruptions of the Multiboot modules as well as the multiboot modules list and the module command lines. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/multiboot/Makefile| 5 - tests/multiboot/libc.c

Re: [Qemu-devel] [PATCH v5 1/3] qcow2: Add qcow2_shrink_l1_and_l2_table for qcow2 shrinking

2015-01-15 Thread Max Reitz
On 2015-01-03 at 07:23, Jun Li wrote: On Fri, 11/21 11:56, Max Reitz wrote: So, as for what I think we do need to do when shrinking (and keep in mind: The offset given to qcow2_truncate() is the guest size! NOT the host image size!): (1) Determine the first L2 table and the first entry in the

[Qemu-devel] [PATCH] arm: define version-based machine type for ARM

2015-01-15 Thread Wei Huang
ARM virt machine type (machvirt) had been stable for a while. But recently new devices have been added to support extra features. Considerring the support of long-term compatibility, it is time to create a version-based machine types. This patch defines a qemu 2.2 specific machine type

Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Peter Maydell
On 15 January 2015 at 15:32, Lluís Vilanova vilan...@ac.upc.edu wrote: I haven't reviewed the patches, but that's a much appreciated cleanup! I was also trying to make sense of all the variants while implementing guest memory access tracing I drew the following terrible ASCII art diagram of

Re: [Qemu-devel] [PATCH 0/3] multiboot: Fix offset of bootloader name

2015-01-15 Thread Drew DeVault
On 01/15/2015 04:26 AM, Kevin Wolf wrote: This fixes a recent Multiboot load regression (see patch 2) that we noticed while hacking on the advent calendar image for December 24. These changes all look fine to me.

Re: [Qemu-devel] [PATCH v4 39/47] postcopy_ram.c: place_page and helpers

2015-01-15 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: On Fri, Oct 03, 2014 at 06:47:45PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com postcopy_place_page (etc) provide a way for postcopy to place a page into guests memory atomically (using the

Re: [Qemu-devel] kvmclock, Migration, and NTP clock jitter

2015-01-15 Thread Paolo Bonzini
On 15/01/2015 17:39, Mohammed Gamal wrote: The increase in the jitter and offset values is well within the 500 ppm frequency tolerance limit, and therefore are easily corrected by subsequent NTP clock sync events, but some live migrations do cause much higher jitter and offset jumps, which

Re: [Qemu-devel] [PATCH] arm: define version-based machine type for ARM

2015-01-15 Thread Wei Huang
On 01/15/2015 12:10 PM, Peter Maydell wrote: On 15 January 2015 at 17:50, Wei Huang w...@redhat.com wrote: ARM virt machine type (machvirt) had been stable for a while. But recently new devices have been added to support extra features. Considerring the support of long-term compatibility, it

Re: [Qemu-devel] [PATCH] WIP: add GCoroutine support

2015-01-15 Thread Stefan Hajnoczi
On Fri, Jan 09, 2015 at 06:19:50PM +0100, Marc-André Lureau wrote: Learn to use the GCoroutine library instead of qemu own coroutine implementation. GCoroutine is hosted on github: https://github.com/elmarco/gcoroutine This allows to share the same coroutine implementation between various

Re: [Qemu-devel] [RFC PATCH v2 2/3] hw/vfio: amba device support

2015-01-15 Thread Eric Auger
Baptiste, On 12/22/2014 05:23 PM, Baptiste Reynal wrote: Add VFIO_DEVICE_TYPE_AMBA. Differentiate amba and platform devices according to compatible string. Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com --- hw/vfio/platform.c| 15 ---

[Qemu-devel] [PATCH 05/15] bsd-user/elfload.c: Don't use ldl() or ldq_raw()

2015-01-15 Thread Peter Maydell
Use get_user_u64() and get_user_ual() instead of the ldl() and ldq_raw() functions. [Note that this change is not compile tested as it is actually in dead code -- none of the bsd-user configurations are PPC.] Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- bsd-user/elfload.c | 11

[Qemu-devel] [PATCH 15/15] cpu_ldst.h, cpu-all.h, bswap.h: Update documentation on ld/st accessors

2015-01-15 Thread Peter Maydell
Add documentation of what the cpu_*_* accessors look like. Correct some minor errors in the existing documentation of the direct _p accessor family. Remove the near-duplicate comment on the _p accessors from cpu-all.h and replace it with a reference to the comment in bswap.h. Signed-off-by: Peter

[Qemu-devel] [PATCH 10/15] cpu_ldst.h: Remove unused very short ld*/st* defines

2015-01-15 Thread Peter Maydell
The very short ld*/st* defines are now not used anywhere; delete them. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/exec/cpu_ldst.h | 26 -- 1 file changed, 26 deletions(-) diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h index

Re: [Qemu-devel] [PATCH 04/15] linux-user/elfload.c: Don't use _raw accessor functions

2015-01-15 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: The _raw accessor functions are an implementation detail that has leaked out to some callsites. Use get_user_u64() instead of ldq_raw(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Alex Bennée alex.ben...@linaro.org ---

[Qemu-devel] kvmclock, Migration, and NTP clock jitter

2015-01-15 Thread Mohammed Gamal
Hi, I've seen some strange time behavior in some of our VMs usually triggered by live migration. In some VMs we have seen some significant time drift which NTP was not able to correct after doing a live migration. I've not been able so far to reproduce the same case, however, I did notice that

Re: [Qemu-devel] [PATCH] WIP: add GCoroutine support

2015-01-15 Thread Stefan Hajnoczi
On Fri, Jan 09, 2015 at 05:32:14PM +, Peter Maydell wrote: On 9 January 2015 at 17:19, Marc-André Lureau marcandre.lur...@gmail.com wrote: Learn to use the GCoroutine library instead of qemu own coroutine implementation. GCoroutine is hosted on github:

Re: [Qemu-devel] [RFC PATCH v2 1/3] hw/vfio/sysbus-fdt: refactoring

2015-01-15 Thread Eric Auger
Hi Baptiste, On 12/22/2014 05:23 PM, Baptiste Reynal wrote: Creates set_interrupts_fdt_node and set_regions_fdt_node for code reusability. Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com --- hw/arm/sysbus-fdt.c | 102 +---

[Qemu-devel] [PATCH 06/15] linux-user/vm86.c: Use cpu_ldl_data c rather than plain ldl c

2015-01-15 Thread Peter Maydell
Use the cpu_ld*_data and cpu_st*_data family of functions to access guest memory in vm86.c rather than the very short-named ldl/stl functions. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- linux-user/vm86.c | 57 ++- 1 file changed,

Re: [Qemu-devel] Help for beginner

2015-01-15 Thread Alex Bennée
Ady Wahyudi Paundu awpau...@gmail.com writes: Hi all, Happy New Year (not too late I hope) I also hope you guys don't' mind to be bothered by newbie questions related to Qemu, because I really don't know where else to ask. I want to learn how several aspects of qemu works, and it really

Re: [Qemu-devel] [PATCH 02/15] monitor.c: Use ld*_p() instead of ld*_raw()

2015-01-15 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: The monitor code for doing a memory_dump() was using ld*_raw() to do target-CPU accesses out of a local buf[] array. The correct functions for this purpose are ld*_p(), which take a host pointer, rather than ld*_raw(), which take an integer

Re: [Qemu-devel] [PATCH 07/15] linux-user/main.c (m68k): Use get_user_u16 rather than lduw in cpu_loop

2015-01-15 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: In the m68k cpu_loop() use get_user_u16 to read the immediate for the simcall rahter than lduw, to bring it into line with how other archs do it and to remove another user of the ldl family of functions. Signed-off-by: Peter Maydell

Re: [Qemu-devel] Press Inquiry: Qemu Advent Calendar (German Linux Magazin)

2015-01-15 Thread Stefan Hajnoczi
On Tue, Jan 13, 2015 at 01:35:55PM +0100, Tim Schürmann wrote: Hi Tim, In order to comply with the license on GPL images you will need to offer the source code (see links on http://qemu-advent-calendar.org/ for each image). The Ubuntu Core and Ceph sourcecodes won't fit on our DVD. So we

[Qemu-devel] [PATCH 08/15] target-mips: Don't use _raw load/store accessors

2015-01-15 Thread Peter Maydell
Use cpu_*_data instead of the direct *_raw load/store accessors. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-mips/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index d619ba4..ea7d95f

Re: [Qemu-devel] [RFC PATCH v2 3/3] hw/vfio: add pl330 device support

2015-01-15 Thread Eric Auger
On 12/22/2014 05:23 PM, Baptiste Reynal wrote: Create a meta-device for PL330 DMA. Add add_arm_pl330_fdt_node function, with multiple compatible string and clocks support. Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com --- hw/arm/sysbus-fdt.c | 84

Re: [Qemu-devel] [PATCH 06/15] linux-user/vm86.c: Use cpu_ldl_data c rather than plain ldl c

2015-01-15 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Use the cpu_ld*_data and cpu_st*_data family of functions to access guest memory in vm86.c rather than the very short-named ldl/stl functions. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Alex Bennée alex.ben...@linaro.org

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix supported_oses check

2015-01-15 Thread Stefan Hajnoczi
On Thu, Jan 15, 2015 at 01:44:34PM +0800, Fam Zheng wrote: There is a bug in the recently added sys.platform test and we no longer run python tests, because linux2 is the value to compare here. So do a prefix match, although the python documentation claims Linux is always linux2. It would be

Re: [Qemu-devel] [v3 4/5] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms backen.

2015-01-15 Thread Stefan Berger
On 12/30/2014 06:03 PM, Quan Xu wrote: This Patch provides the glue for the TPM_TIS(Qemu frontend) to Xen stubdom vTPM domain that provides the actual TPM functionality. It sends data and TPM commends with xen_vtpm_frontend. It is similar as another two vTPM backens: *vTPM passthrough backen

Re: [Qemu-devel] [PATCH 05/15] bsd-user/elfload.c: Don't use ldl() or ldq_raw()

2015-01-15 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Use get_user_u64() and get_user_ual() instead of the ldl() and ldq_raw() functions. [Note that this change is not compile tested as it is actually in dead code -- none of the bsd-user configurations are PPC.] Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 03/15] target-sparc: Don't use {ld, st}*_raw functions

2015-01-15 Thread Peter Maydell
Instead of using the _raw family of ld/st accessor functions, use cpu_*_data. All this code is CONFIG_USER_ONLY, so the two are the same semantically, but the _raw functions are really a detail of the implementation which has leaked into a few callsites like this one. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 09/15] cpu_ldst.h: Drop unused ld/st*_kernel defines

2015-01-15 Thread Peter Maydell
The ld*_kernel and st*_kernel defines are not used anywhere; delete them. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/exec/cpu_ldst.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h index 4700831..64d9087

Re: [Qemu-devel] [PATCH] WIP: add GCoroutine support

2015-01-15 Thread Kevin Wolf
Am 09.01.2015 um 18:19 hat Marc-André Lureau geschrieben: Learn to use the GCoroutine library instead of qemu own coroutine implementation. GCoroutine is hosted on github: https://github.com/elmarco/gcoroutine This allows to share the same coroutine implementation between various

[Qemu-devel] [PATCH 11/15] cpu_ldst.h: Use inline functions for usermode cpu_ld/st accessors

2015-01-15 Thread Peter Maydell
Use inline functions rather than macros for cpu_ld/st accessors for the *-user configurations, as we already do for softmmu. This has a two advantages: * we can actually typecheck our arguments * we don't need to leak the _raw macros everywhere Since the _kernel functions were only used by

[Qemu-devel] [PATCH 13/15] cpu_ldst.h: Drop unused _raw macros, saddr() and laddr()

2015-01-15 Thread Peter Maydell
The _raw macros and their helpers saddr() and laddr() are now totally unused -- delete them. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/exec/cpu_ldst.h | 23 --- 1 file changed, 23 deletions(-) diff --git a/include/exec/cpu_ldst.h

[Qemu-devel] [PATCH 14/15] cpu_ldst_template.h: Drop unused cpu_ldfq/stfq/ldfl/stfl accessors

2015-01-15 Thread Peter Maydell
The cpu_ldfq/stfq/ldfl/stfl accessors for loading and storing float32 and float64 are completely unused, so delete them. (The union they use for converting from the float32/float64 type to uint32_t or uint64_t is the wrong way to do it anyway: they should be using make_float* and float*_val.)

[Qemu-devel] [PATCH 01/15] cpu_ldst.h: Remove unused ldul_ macros

2015-01-15 Thread Peter Maydell
The five ldul_ macros are not used anywhere and are marked up with an XXX comment. ldul is a non-standard prefix for our family of load instructions: we don't mark 32-bit accesses for signedness because they return a 32 bit quantity. So just delete them. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 02/15] monitor.c: Use ld*_p() instead of ld*_raw()

2015-01-15 Thread Peter Maydell
The monitor code for doing a memory_dump() was using ld*_raw() to do target-CPU accesses out of a local buf[] array. The correct functions for this purpose are ld*_p(), which take a host pointer, rather than ld*_raw(), which take an integer representing a guest address and are somewhat meaningless

[Qemu-devel] [PATCH 04/15] linux-user/elfload.c: Don't use _raw accessor functions

2015-01-15 Thread Peter Maydell
The _raw accessor functions are an implementation detail that has leaked out to some callsites. Use get_user_u64() instead of ldq_raw(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- linux-user/elfload.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] Help for beginner

2015-01-15 Thread Stefan Hajnoczi
On Tue, Jan 13, 2015 at 10:40:01AM +0900, Ady Wahyudi Paundu wrote: Hi all, Happy New Year (not too late I hope) I also hope you guys don't' mind to be bothered by newbie questions related to Qemu, because I really don't know where else to ask. I want to learn how several aspects of qemu

Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Lluís Vilanova
Peter Maydell writes: I was looking at our confusing mess of memory accessor functions, and I realised that partly it was confusing because we have a bunch of unnecessary junk lurking in there :-) This series attempts to clean things up by removing things we weren't using at all or were only

Re: [Qemu-devel] [PATCH v3 4/5] Split the QEMU buffered file code out

2015-01-15 Thread Stefan Berger
On 12/18/2014 04:24 AM, Dr. David Alan Gilbert wrote: * David Gibson (da...@gibson.dropbear.id.au) wrote: On Fri, Dec 12, 2014 at 11:13:41AM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com The splitting of qemu-file and addition of the buffered file

Re: [Qemu-devel] [PATCH v2 1/2] configure: Default to enable module build

2015-01-15 Thread Stefan Hajnoczi
On Tue, Jan 13, 2015 at 04:53:58PM +0800, Fam Zheng wrote: We have module build support around for a while, but also had it bitrot several times. It probably makes sense to enable it by default so that people can notice and use it. Counterpart to --enable-modules, which is turned as default,

[Qemu-devel] [PATCH 07/15] linux-user/main.c (m68k): Use get_user_u16 rather than lduw in cpu_loop

2015-01-15 Thread Peter Maydell
In the m68k cpu_loop() use get_user_u16 to read the immediate for the simcall rahter than lduw, to bring it into line with how other archs do it and to remove another user of the ldl family of functions. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- linux-user/main.c | 2 +- 1 file

[Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Peter Maydell
I was looking at our confusing mess of memory accessor functions, and I realised that partly it was confusing because we have a bunch of unnecessary junk lurking in there :-) This series attempts to clean things up by removing things we weren't using at all or were only using by mistake in a few

Re: [Qemu-devel] [PATCH 0/2] qed: additional input validation

2015-01-15 Thread Stefan Hajnoczi
On Mon, Jan 12, 2015 at 12:31:31PM +, Stefan Hajnoczi wrote: These patches add an overflow check and a test case for invalid QED headers. Note that this has no security impact because reading the backing filename is limited to sizeof(bs-backing_file). Stefan Hajnoczi (2): qed: check

Re: [Qemu-devel] [RFC PATCH 3/4] hw/arm/sysbus-fdt: vfio device property for interrupts

2015-01-15 Thread Eric Auger
Hi Baptiste On 01/12/2015 02:21 PM, Baptiste Reynal wrote: Use the VFIO device property API to retrieve interrupt information (type and flags) during device node creation. Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com --- hw/arm/sysbus-fdt.c | 26 ++

Re: [Qemu-devel] [PATCH 2/4] console: add opengl rendering helper functions

2015-01-15 Thread Max Reitz
On 2015-01-12 at 07:35, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 23 ++ ui/Makefile.objs | 5 ++ ui/console-gl.c | 127 +++ 3 files changed, 155 insertions(+) create

Re: [Qemu-devel] global_mutex and multithread.

2015-01-15 Thread Mark Burton
On 15 Jan 2015, at 21:27, Paolo Bonzini pbonz...@redhat.com wrote: On 15/01/2015 20:07, Mark Burton wrote: However - if we go this route -the current patch is only for x86. (apart from the fact that we still seem to land in a deadlock…) Jan said he had it working at least on ARM

Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Paolo Bonzini
On 15/01/2015 20:10, Lluís Vilanova wrote: Peter Maydell writes: On 15 January 2015 at 15:32, Lluís Vilanova vilan...@ac.upc.edu wrote: I haven't reviewed the patches, but that's a much appreciated cleanup! I was also trying to make sense of all the variants while implementing guest

Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors

2015-01-15 Thread Lluís Vilanova
Peter Maydell writes: On 15 January 2015 at 15:32, Lluís Vilanova vilan...@ac.upc.edu wrote: I haven't reviewed the patches, but that's a much appreciated cleanup! I was also trying to make sense of all the variants while implementing guest memory access tracing I drew the following

[Qemu-devel] [Bug 1409246] Re: ARM GIC / PL061 error on uni-processor system

2015-01-15 Thread Christopher Horler
In arch/arm/mach-realview/realview_*.c pl061_platform_data irq_base members are statically (default) initialised to 0 (whereas for versatile they are explicitly set via defines in the platform headers). In pl061_probe, -ENODEV is returned for irq_base = 0. Changing this to 0, results in

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2015-01-15 Thread Serge Hallyn
It looks as though the relevant commits were re-committed to upstream git HEAD (9a48bcd1b82494671c09b0eefdb882581499 and 317b0a6d8ba44e9bf8f9c3dbd776c4536843d82c). So this may be fixed in vivid, and we might be able to cherrypick the final patches to trusty. ** Package changed: libvirt

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2015-01-15 Thread Serge Hallyn
@Paul, could you confirm whether qemu 1:2.2+dfsg-3exp~ubuntu1 from https://launchpad.net/~ubuntu-virt/+archive/ubuntu/virt-daily-upstream fixes this issue? If it does then I'll go ahead and backport the patch. -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] global_mutex and multithread.

2015-01-15 Thread Mark Burton
Still in agony on this issue - I’ve CC’d Jan as his patch looks important… the patch below would seem to offer by far and away the best result here. (If only we could get it working ;-) ) it allows threads to proceed as we want them to, it means we dont have to ‘count’ the number of

Re: [Qemu-devel] Press Inquiry: Qemu Advent Calendar (German Linux Magazin)

2015-01-15 Thread Tim Schürmann
Hi Stefan, if nothing went wrong the (whole) advent calendar will be on the DVD published with the Linux Magazin issue 03/2015. The release date is the 05. Feb. 2015 (in germany). Best regards, Tim Schürmann i...@tim-schuermann.de Am 15.01.2015 um 15:47 schrieb Stefan Hajnoczi: On Tue,

Re: [Qemu-devel] [PATCH] arm: define version-based machine type for ARM

2015-01-15 Thread Peter Maydell
On 15 January 2015 at 18:52, Wei Huang w...@redhat.com wrote: On 01/15/2015 12:10 PM, Peter Maydell wrote: I don't think we're anywhere ready yet to support between version migration compatibility. We will want this *eventually* but we are a long long way away from needing it...(maybe a

Re: [Qemu-devel] global_mutex and multithread.

2015-01-15 Thread Paolo Bonzini
On 15/01/2015 20:07, Mark Burton wrote: However - if we go this route -the current patch is only for x86. (apart from the fact that we still seem to land in a deadlock…) Jan said he had it working at least on ARM (MusicPal). One thing I wonder - why do we need to go to the extent of

[Qemu-devel] [PATCH v2] Fixes key mapping so all keys work

2015-01-15 Thread Programmingkid
Fixes keyboard mapping so right shift, right command, right option, right control, keypad period, keypad '=', keypad enter, and F13 all work. Signed-off-by: John Arbuckle programmingk...@gmail.com --- Undid most changes to keyboard map in cocoa.m. Most changes made to keyboard map in adb.c.

Re: [Qemu-devel] [PATCH 4/4] sdl2: move SDL_* includes to sdl2.h

2015-01-15 Thread Max Reitz
On 2015-01-12 at 07:35, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 7 +++ ui/sdl2-2d.c | 6 -- ui/sdl2-gl.c | 7 --- ui/sdl2-input.c | 6 -- ui/sdl2.c | 6 -- 5 files changed, 7 insertions(+), 25

Re: [Qemu-devel] [PATCH 3/4] sdl2: add support for display rendering using opengl.

2015-01-15 Thread Max Reitz
On 2015-01-12 at 07:35, Gerd Hoffmann wrote: Add new sdl2-gl.c file, with display rendering functions using opengl. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 1 + include/ui/sdl2.h| 10 + ui/Makefile.objs | 4 ++ ui/sdl.c | 11

[Qemu-devel] [PATCH v7] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-15 Thread Programmingkid
This patch allows Mac OS X to use a real CDROM disc in QEMU. Testing this patch will require using QEMU v2.2.0 because the current git version has a bug in it that prevents /dev/cdrom from being used. make check did pass and my Debian boot disc did work. Signed-off-by: John Arbuckle

[Qemu-devel] [PATCH] pc-dimm: fix checking for backend memory size

2015-01-15 Thread Zhu Guihua
If hot add 100MiB memory like this: (monitor) object_add memory-backend-ram,id=ram0,size=100M (monitor) device_add pc-dimm,id=d0,memdev=ram0 The hotplug operation will faile, and the guest will print error message: Section-unaligned hotplug range: start 0x1, size 0x640 acpi

Re: [Qemu-devel] [PATCH] pc-dimm: fix checking for backend memory size

2015-01-15 Thread Zhu Guihua
Hi all, I am sorry that this method to fix this bug was not perfect. I will find another way to do this. Plz ignore this patch. Regards, Zhu On Fri, 2015-01-16 at 13:45 +0800, Zhu Guihua wrote: If hot add 100MiB memory like this: (monitor) object_add memory-backend-ram,id=ram0,size=100M

Re: [Qemu-devel] [PATCH] Add 'setup' phase to docs for query-migrate QMP command

2015-01-15 Thread Amit Shah
On (Mon) 15 Dec 2014 [10:05:40], Markus Armbruster wrote: Copying migration maintainers. Thanks, Eric, pls give this a look too. Alex Bligh a...@alex.org.uk writes: The QMP command 'query-migrate' returns the state 'setup' during the setup phase. This patch documents it.

Re: [Qemu-devel] [PATCH v4 01/17] docs: add sPAPR hotplug/dynamic-reconfiguration documentation

2015-01-15 Thread David Gibson
On Tue, Dec 23, 2014 at 06:30:15AM -0600, Michael Roth wrote: This adds a general overview of hotplug/dynamic-reconfiguration for sPAPR/pSeries guest. As specified in PAPR+ v2.7. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- docs/specs/ppc-spapr-hotplug.txt | 287

Re: [Qemu-devel] [PATCH v4 02/17] spapr_drc: initial implementation of sPAPRDRConnector device

2015-01-15 Thread David Gibson
On Tue, Dec 23, 2014 at 06:30:16AM -0600, Michael Roth wrote: This device emulates a firmware abstraction used by pSeries guests to manage hotplug/dynamic-reconfiguration of host-bridges, PCI devices, memory, and CPUs. It is conceptually similar to an SHPC device, complete with LED indicators

Re: [Qemu-devel] [PATCH v4 03/17] spapr_rtas: add get/set-power-level RTAS interfaces

2015-01-15 Thread David Gibson
On Tue, Dec 23, 2014 at 06:30:17AM -0600, Michael Roth wrote: From: Nathan Fontenot nf...@linux.vnet.ibm.com Signed-off-by: Nathan Fontenot nf...@linux.vnet.ibm.com Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/ppc/spapr_rtas.c | 25 + 1 file

Re: [Qemu-devel] [PATCH v4 04/17] spapr_rtas: add set-indicator RTAS interface

2015-01-15 Thread David Gibson
On Tue, Dec 23, 2014 at 06:30:18AM -0600, Michael Roth wrote: From: Mike Day ncm...@ncultra.org Signed-off-by: Mike Day ncm...@ncultra.org Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/ppc/spapr_rtas.c | 80 + 1 file

Re: [Qemu-devel] [PATCH v4 05/17] spapr_rtas: add get-sensor-state RTAS interface

2015-01-15 Thread David Gibson
On Tue, Dec 23, 2014 at 06:30:19AM -0600, Michael Roth wrote: From: Mike Day ncm...@ncultra.org Even simple patches should have commit messages. Signed-off-by: Mike Day ncm...@ncultra.org Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/ppc/spapr_rtas.c | 35

Re: [Qemu-devel] [RFC PATCH v7 21/21] replay: recording of the user input

2015-01-15 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 12/01/2015 13:01, Pavel Dovgalyuk wrote: +void qemu_input_event_send(QemuConsole *src, InputEvent *evt) { -QemuInputHandlerState *s; - if (!runstate_is_running() !runstate_check(RUN_STATE_SUSPENDED)) { return;

Re: [Qemu-devel] global_mutex and multithread.

2015-01-15 Thread Mark Burton
On 15 Jan 2015, at 22:41, Paolo Bonzini pbonz...@redhat.com wrote: On 15/01/2015 21:53, Mark Burton wrote: Jan said he had it working at least on ARM (MusicPal). yeah - our problem is when we enable multi-threads - which I dont believe Jan did… Multithreaded TCG, or

[Qemu-devel] [PULL] migration patches

2015-01-15 Thread Amit Shah
The following changes since commit df58887b20fab8fe8a6dcca4db30cd4e4077d53a: Merge remote-tracking branch 'remotes/mjt/tags/pull-trivial-patches-2015-01-15' into staging (2015-01-15 10:08:46 +) are available in the git repository at:

Re: [Qemu-devel] [PATCH 1/4] configure: opengl overhaul

2015-01-15 Thread Max Reitz
On 2015-01-12 at 07:35, Gerd Hoffmann wrote: Rename config option from glx to opengl, glx will not be the only option for opengl in near future. Also switch over to pkg-config for opengl support detection. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure|

Re: [Qemu-devel] global_mutex and multithread.

2015-01-15 Thread Paolo Bonzini
On 15/01/2015 21:53, Mark Burton wrote: Jan said he had it working at least on ARM (MusicPal). yeah - our problem is when we enable multi-threads - which I dont believe Jan did… Multithreaded TCG, or single-threaded TCG with SMP? One thing I wonder - why do we need to go to the extent

Re: [Qemu-devel] global_mutex and multithread.

2015-01-15 Thread Paolo Bonzini
On 15/01/2015 21:53, Mark Burton wrote: Jan said he had it working at least on ARM (MusicPal). yeah - our problem is when we enable multi-threads - which I dont believe Jan did… Multithreaded TCG, or single-threaded TCG with SMP? One thing I wonder - why do we need to go to the extent

[Qemu-devel] [PATCH v2] qemu-iotests: Fix supported_oses check

2015-01-15 Thread Fam Zheng
There is a bug in the recently added sys.platform test, and we no longer run python tests, because linux2 is the value to compare here. So do a prefix match. According to python doc [1], the way to use sys.platform is unless you want to test for a specific system version, it is therefore

Re: [Qemu-devel] [PATCH 3/8] rcu: add rcutorture

2015-01-15 Thread Fam Zheng
On Tue, 01/13 18:52, Paolo Bonzini wrote: +int main(int argc, char *argv[]) +{ +int nreaders = 1; +int duration = 1; + +if (argc = 2 argv[1][0] == '-') { +g_test_init(argc, argv, NULL); +g_test_add_func(/rcu/torture/short/1reader, gtest_stress_1_1); +

[Qemu-devel] [PATCH v3 0/2] buildsys: Fix and enable module build

2015-01-15 Thread Fam Zheng
v3: Fix commit message, error message and function name. (Stefan) Fam Zheng (2): configure: Default to enable module build .travis.yml: Add --disable-modules .travis.yml | 3 ++ configure | 95 ++--- 2 files changed, 69

[Qemu-devel] [PATCH v3 2/2] .travis.yml: Add --disable-modules

2015-01-15 Thread Fam Zheng
Now we default to --enable-modules, let's cover the old way in travis. Signed-off-by: Fam Zheng f...@redhat.com --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index ad66e5b..12bf1db 100644 --- a/.travis.yml +++ b/.travis.yml @@ -98,3 +98,6 @@

Re: [Qemu-devel] [PATCH v3] spapr-pci: Enable huge BARs

2015-01-15 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/14/2015 03:51 PM, David Gibson wrote: On Fri, Jan 09, 2015 at 12:11:14PM +1100, Alexey Kardashevskiy wrote: At the moment sPAPR only supports 512MB window for MMIO BARs. However modern devices might want bigger 64bit BARs. This extends

[Qemu-devel] [PULL 05/12] target-tricore: Fix new typos

2015-01-15 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de adress - address managment - management Cc: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Michael Tokarev m...@tls.msk.ru --- target-tricore/csfr.def | 2 +- target-tricore/translate.c

[Qemu-devel] [PULL 10/12] Makefile: Remove config.status and common.env during 'make distclean'

2015-01-15 Thread Michael Tokarev
From: Thomas Huth th...@linux.vnet.ibm.com config.status and tests/qemu-iotests/common.env are generated files that should be deleted during 'make distclean'. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- Makefile | 4 ++-- 1 file

Re: [Qemu-devel] [RFC v3 1/2] pci/pci-host: Add generic-pci PCI host controller device

2015-01-15 Thread alvise rigo
Hi Claudio, Sorry, I should have missed this one. On Wed, Jan 14, 2015 at 2:12 PM, Claudio Fontana claudio.font...@huawei.com wrote: On 14.01.2015 11:16, Alvise Rigo wrote: Add a generic PCI host controller for virtual platforms, based on the previous work by Rob Herring:

[Qemu-devel] [PULL 00/12] Trivial patches for 2015-01-15

2015-01-15 Thread Michael Tokarev
This is a next trivial-patches pull request, since the previous one which was at 2014-12-11 - 4 weeks ago. Only 12 patches in 4 weeks. There's nothing exciting in there, but there are several (small) bugfixes. Please consider applying/pulling. With the introduction of pbonzini's misc patches

[Qemu-devel] [PULL 07/12] misc: Fix new typos in comments

2015-01-15 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de recieve - receive suprise - surprise Cc: Igor Mammedov imamm...@redhat.com Cc: John Snow js...@redhat.com Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: John Snow js...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru ---

[Qemu-devel] [PULL 01/12] vt82c686: avoid out-of-bounds read

2015-01-15 Thread Michael Tokarev
From: Paolo Bonzini pbonz...@redhat.com superio_ioport_readb can read the 256th element of the array. Coverity reports an out-of-bounds write in superio_ioport_writeb, but it does not show the corresponding out-of-bounds read because it cannot prove that it can happen. Fix the root cause of the

[Qemu-devel] [PULL 12/12] vl.c: fix some alignment issues

2015-01-15 Thread Michael Tokarev
From: Marcel Apfelbaum mar...@redhat.com The misalignment was caused by tabs which were used instead of spaces. Signed-off-by: Marcel Apfelbaum mar...@redhat.com Reviewed-by: Stefan Weil s...@weilnetz.de Signed-off-by: Michael Tokarev m...@tls.msk.ru --- vl.c | 38

[Qemu-devel] [PULL 06/12] target-arm: Fix typo in comment (seperately - separately)

2015-01-15 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de Cc: Peter Maydell peter.mayd...@linaro.org Cc: Greg Bellows greg.bell...@linaro.org Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Michael Tokarev m...@tls.msk.ru --- target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PULL 08/12] Do not hang on full PTY

2015-01-15 Thread Michael Tokarev
From: Don Slutz dsl...@verizon.com Signed-off-by: Don Slutz dsl...@verizon.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- qemu-char.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-char.c b/qemu-char.c index 5430b87..98d4342 100644

Re: [Qemu-devel] [RFC PATCH 3/4] vfio-pci: add aer capability support

2015-01-15 Thread Chen Fan
On 01/12/2015 09:14 PM, Paolo Bonzini wrote: On 12/01/2015 04:04, Chen Fan wrote: +static int vfio_add_ext_capabilities(VFIOPCIDevice *vdev) +{ +PCIDevice *pdev = vdev-pdev; +PCIExpressDevice *exp; +uint32_t header; +uint16_t next = PCI_CONFIG_SPACE_SIZE; + +if

Re: [Qemu-devel] [PATCH 4/4] vmstate: accept QEMUTimer in VMSTATE_TIMER*, add VMSTATE_TIMER_PTR*

2015-01-15 Thread Paolo Bonzini
On 15/01/2015 10:04, Amit Shah wrote: diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index e45fc49..55ba584 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -642,17 +642,29 @@ extern const VMStateInfo vmstate_info_bitmap;

Re: [Qemu-devel] global_mutex and multithread.

2015-01-15 Thread Peter Maydell
On 15 January 2015 at 10:25, Frederic Konrad fred.kon...@greensocs.com wrote: Hi everybody, In case of multithread TCG what is the best way to handle qemu_global_mutex? It shouldn't need any changes I think. You're basically bringing TCG into line with what KVM already has -- one thread per

[Qemu-devel] [PATCH 0/3] multiboot: Fix offset of bootloader name

2015-01-15 Thread Kevin Wolf
This fixes a recent Multiboot load regression (see patch 2) that we noticed while hacking on the advent calendar image for December 24. Kevin Wolf (3): tests/multiboot: Update reference output multiboot: Fix offset of bootloader name tests/multiboot: Add test for modules

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-15 Thread Lluís Vilanova
Richard Henderson writes: On 01/14/2015 10:15 AM, Lluís Vilanova wrote: Sorry I wasn't clear. I meant that it might be better to remove tcg/README and instead document all the operations (those in the readme and the additional ones) in the header. If we did that, it would go somewhere

[Qemu-devel] global_mutex and multithread.

2015-01-15 Thread Frederic Konrad
Hi everybody, In case of multithread TCG what is the best way to handle qemu_global_mutex? We though to have one mutex per vcpu and then synchronize vcpu threads when they exit (eg: in tcg_exec_all). Is that making sense? Thanks, Fred

  1   2   >