Re: [Qemu-devel] [PATCH 0/4] ioeventfd support for virtio-mmio

2015-01-21 Thread Paolo Bonzini
On 04/11/2014 13:47, Shannon Zhao wrote: > Add host/guest notifiers support for virtio-mmio, so that qemu can > enable vhost-net for kvm-arm. > > Refer to the patches from Ying-Shiuan Pan > https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg00715.html > > As vhost-net can improve the net

Re: [Qemu-devel] [PATCH] dataplane: endianness-aware accesses

2015-01-21 Thread Cornelia Huck
On Thu, 22 Jan 2015 14:16:22 +1100 David Gibson wrote: > On Wed, Jan 21, 2015 at 08:56:46AM +0100, Cornelia Huck wrote: > > David: I saw you tested Stefan's endianness patch. > > > > Could you also give my alternative implementation a try? Thanks! > > Yes, sorry, I got a bit confused about whic

Re: [Qemu-devel] [PATCH] hw/input/hid.c Fix capslock hid code

2015-01-21 Thread Gerd Hoffmann
On Mi, 2015-01-21 at 23:48 +0100, dval...@suse.de wrote: > From: Dinar Valeev > > When ever USB keyboard is used, e.g. '-usbdevice keyboard' pressing > caps lock key send 0x32 hid code, which is treated as backslash. > Instead it should be 0x39 code. This affects sending uppercase keys, > as they

Re: [Qemu-devel] [PATCH] dataplane: endianness-aware accesses

2015-01-21 Thread David Gibson
On Wed, Jan 21, 2015 at 08:56:46AM +0100, Cornelia Huck wrote: > David: I saw you tested Stefan's endianness patch. > > Could you also give my alternative implementation a try? Thanks! Yes, sorry, I got a bit confused about which series was which there. I gave this a whirl on our P8 and with it

Re: [Qemu-devel] [Bug 1399191] [NEW] Large VHDX image size

2015-01-21 Thread AMULYA L
-Original Message- From: Jeff Cody [mailto:jc...@redhat.com] Sent: Wednesday, January 21, 2015 2:41 AM To: Lokesha, Amulya Cc: Bug 1399191; Geoffroy, Daniel Subject: Re: [Qemu-devel] [Bug 1399191] [NEW] Large VHDX image size On Mon, Jan 19, 2015 at 03:19:05PM +, Lokesha, Amulya wrote:

Re: [Qemu-devel] [sheepdog] [PATCH v2] sheepdog: selectable object size support

2015-01-21 Thread Hitoshi Mitake
At Tue, 20 Jan 2015 16:14:28 +0900, Teruaki Ishizaki wrote: > > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additional

[Qemu-devel] [PATCH] hw/input/hid.c Fix capslock hid code

2015-01-21 Thread dvaleev
From: Dinar Valeev When ever USB keyboard is used, e.g. '-usbdevice keyboard' pressing caps lock key send 0x32 hid code, which is treated as backslash. Instead it should be 0x39 code. This affects sending uppercase keys, as they typed whith caps lock active. While on x86 this can be workarounded

Re: [Qemu-devel] [v6][PATCH 08/10] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2015-01-21 Thread Kay, Allen M
> -Original Message- > From: Chen, Tiejun > Sent: Tuesday, January 20, 2015 7:17 PM > To: Michael S. Tsirkin; Kay, Allen M > Cc: pbonz...@redhat.com; aligu...@amazon.com; r...@twiddle.net; Zhang, > Yang Z; qemu-devel@nongnu.org > Subject: Re: [v6][PATCH 08/10] xen, gfx passthrough: suppor

[Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list

2015-01-21 Thread Chen Fan
Signed-off-by: Chen Fan --- hw/vfio/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index cf483ff..e71385e 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -32,7 +32,7 @@ #include "trace.h" struct vfio_group_head vfio_gro

[Qemu-devel] [PATCH v2 5/5] qga: add memory block command that unsupported to blacklist

2015-01-21 Thread zhanghailiang
For memory block command, we only support for linux with sysfs. Signed-off-by: zhanghailiang Reviewed-by: Michael Roth --- qga/commands-posix.c | 4 +++- qga/commands-win32.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index

[Qemu-devel] [PATCH v2 4/5] qga: implement qmp_guest_get_memory_block_size() for Linux with sysfs

2015-01-21 Thread zhanghailiang
The size of a memory block is architecture dependent, it represents the logical unit upon which memory online/offline operations are to be performed. Signed-off-by: zhanghailiang --- qga/commands-posix.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff -

[Qemu-devel] [PATCH v2 1/5] qga: introduce three guest memory block commmands with stubs

2015-01-21 Thread zhanghailiang
Introduce three new guest commands: guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. With these three commands, we can support online/offline guest's memory block (logical memory hotplug/unplug) as required from host. Signed-off-by: zhanghailiang --- qga/commands-p

[Qemu-devel] [PATCH v2 3/5] qga: implement qmp_guest_set_memory_blocks() for Linux with sysfs

2015-01-21 Thread zhanghailiang
We can change guest's online/offline state of memory blocks, by using command 'guest-set-memory-blocks'. Signed-off-by: zhanghailiang --- qga/commands-posix.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-po

[Qemu-devel] [PATCH v2 0/5] qga: add three logical memory hotplug related commands

2015-01-21 Thread zhanghailiang
This patch series add three guest commands about memory block: guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. With these three commands, we can get information about guest's memory block online/offline status and memory block size (unit of memory online/offline ope

[Qemu-devel] [PATCH v2 2/5] qga: implement qmp_guest_get_memory_blocks() for Linux with sysfs

2015-01-21 Thread zhanghailiang
We can get guest's memory block information by using command "guest-get-memory-blocks", the returned value contains a list of memory block info, such as phys-index, online state, can-offline info. Signed-off-by: zhanghailiang --- qga/commands-posix.c | 231 +++

[Qemu-devel] [PATCH v1 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

2015-01-21 Thread Alistair Francis
This patch adds the Cortex-A9 ARM CPU to the A9MPCore. The CPU is only created if the num-cpu property is set. This patch relies on Stefan Hajnoczi's v3 'virtio-blk: use alias properties in transport devices' patch. This is used to pass the CPU properties through to the mpcore. This patch allows

[Qemu-devel] [PATCH v1 2/2] zynq: Update Zynq to init the CPU in the a9mpcore device

2015-01-21 Thread Alistair Francis
This patch removes the initialisation of the ARM Cortex-A9 in Zynq and instead allows the a9mpcore device to init the CPU. This also updates components that rely on the CPU and GIC, as they are now initialised in a slightly different way Signed-off-by: Alistair Francis --- Changes since RFC: - R

Re: [Qemu-devel] [PATCH RFC v6 02/20] virtio: cull virtio_bus_set_vdev_features

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:04PM +0100, Cornelia Huck wrote: > The only user of this function was virtio-ccw, and it should use > virtio_set_features() like everybody else: We need to make sure > that bad features are masked out properly, which this function did > not do. > > Reviewed-by: Thomas

Re: [Qemu-devel] [PATCH RFC v6 08/20] dataplane: allow virtio-1 devices

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:10PM +0100, Cornelia Huck wrote: > Handle endianness conversion for virtio-1 virtqueues correctly. > > Note that dataplane now needs to be built per-target. > > Signed-off-by: Cornelia Huck Reviewed-by: David Gibson -- David Gibson| I'll have

Re: [Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:07PM +0100, Cornelia Huck wrote: > With virtio-1, we support more than 32 feature bits. Let's extend both > host and guest features to 64, which should suffice for a while. > > vhost and migration have been ignored for now. [snip] > diff --git a/include/hw/virtio/vi

Re: [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:14PM +0100, Cornelia Huck wrote: > For virtio-1 devices, the driver must not attempt to set feature bits > after it set FEATURES_OK in the device status. Simply reject it in > that case. > > Signed-off-by: Cornelia Huck Reviewed-by: David Gibson -- David Gibson

Re: [Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:05PM +0100, Cornelia Huck wrote: > Add virtio_{add,clear}_feature helper functions for manipulating a > feature bits variable. This has some benefits over open coding: > - add check that the bit is in a sane range > - make it obvious at a glance what is going on > - ha

Re: [Qemu-devel] [PATCH RFC v6 07/20] virtio: allow virtio-1 queue layout

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:09PM +0100, Cornelia Huck wrote: > For virtio-1 devices, we allow a more complex queue layout that doesn't > require descriptor table and rings on a physically-contigous memory area: > add virtio_queue_set_rings() to allow transports to set this up. > > Signed-off-by:

Re: [Qemu-devel] [PATCH RFC v6 04/20] virtio: add feature checking helpers

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:06PM +0100, Cornelia Huck wrote: > Add a helper function for checking whether a bit is set in the guest > features for a vdev as well as one that works on a feature bit set. > > Convert code that open-coded this: It cleans up the code and makes it > easier to extend t

Re: [Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits

2015-01-21 Thread David Gibson
On Fri, Dec 12, 2014 at 11:17:47AM +0100, Cornelia Huck wrote: > On Fri, 12 Dec 2014 11:06:40 +0100 > Thomas Huth wrote: > > > On Thu, 11 Dec 2014 14:25:07 +0100 > > Cornelia Huck wrote: [snip] > > > vdev->queue_sel = 0; > > > vdev->status = 0; > > > vdev->isr = 0; > > > @@ -924,7

Re: [Qemu-devel] [PATCH RFC v6 06/20] virtio: endianness checks for virtio 1.0 devices

2015-01-21 Thread David Gibson
On Thu, Dec 11, 2014 at 02:25:08PM +0100, Cornelia Huck wrote: > Add code that checks for the VERSION_1 feature bit in order to make > decisions about the device's endianness. This allows us to support > transitional devices. > > Signed-off-by: Cornelia Huck > --- > hw/virtio/virtio.c

Re: [Qemu-devel] [PATCH] WIP: add GCoroutine support

2015-01-21 Thread Marc-André Lureau
On Thu, Jan 15, 2015 at 4:54 PM, Kevin Wolf wrote: > Hm, I guess there might be uses for holding references after the > coroutine has exited if there are external references to the coroutine, > but is it useful not to drop one reference after the coroutine exits? I > guess in most cases, and in qe

Re: [Qemu-devel] [PATCH 1/4] qdev: support to get a device firmware path directly

2015-01-21 Thread Gonglei
On 2015/1/21 18:52, Paolo Bonzini wrote: > > > On 21/01/2015 03:14, Gonglei wrote: >> On 2015/1/21 0:10, Paolo Bonzini wrote: >> >>> >>> >>> On 19/01/2015 14:23, arei.gong...@huawei.com wrote: @@ -780,6 +788,12 @@ static int qdev_get_fw_dev_path_helper(DeviceState *dev, char *p, int s

Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-01-21 Thread Chen, Tiejun
On 2015/1/21 19:56, Ian Campbell wrote: On Wed, 2015-01-21 at 11:37 +, Ian Jackson wrote: Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"): When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru"

Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-01-21 Thread Chen, Tiejun
On 2015/1/21 21:48, Gerd Hoffmann wrote: On Mi, 2015-01-21 at 11:37 +, Ian Jackson wrote: Tiejun Chen writes ("[RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough"): When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru"

Re: [Qemu-devel] [PATCH v5 1/1] hw: misc, add educational driver

2015-01-21 Thread Eric Blake
On 01/21/2015 09:48 AM, Jiri Slaby wrote: > I am using qemu for teaching the Linux kernel at our university. I > wrote a simple PCI device that can answer to writes/reads, generate > interrupts and perform DMA. As I am dragging it locally over 2 years, > I am sending it to you now. > > Signed-off-

Re: [Qemu-devel] [PATCH v5 1/1] hw: misc, add educational driver

2015-01-21 Thread Eric Blake
On 01/21/2015 09:48 AM, Jiri Slaby wrote: > I am using qemu for teaching the Linux kernel at our university. I > wrote a simple PCI device that can answer to writes/reads, generate > interrupts and perform DMA. As I am dragging it locally over 2 years, > I am sending it to you now. > > Signed-off-

Re: [Qemu-devel] [PATCH] qemu-ga-win: Fail loudly on bare 'set-time'

2015-01-21 Thread Eric Blake
On 01/21/2015 04:09 AM, Michal Privoznik wrote: > The command is not implemented correctly yet. The documentation allows > to not pass any value to set, in which case the time is re-read from > RTC. However, reading CMOS on Windows is not trivial to implement. So > instead of pretending we've set t

Re: [Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2015-01-21 Thread Max Reitz
On 2015-01-21 at 11:53, Stefan Hajnoczi wrote: On Mon, Nov 24, 2014 at 04:56:49PM +0100, Max Reitz wrote: +static void build_window_bitmap(Qcow2MetadataList *mdl, +Qcow2MetadataWindow *window) +{ +int cache_i, oldest_cache_i = -1, i; +unsigned oldest_cache

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-01-21 Thread neil prideaux
I also confirm the problem on Windows 7 host. I tried the following over the past few nights: Downloaded the OpenVPN tap 32 adapter. Installed it and gave it a different network address (192.168.200.10) to my normal LAN (192.168.1.10). Bridged the 2 connections, which gets me a new IP via DHCP a

[Qemu-devel] [PATCH 2/3] kvm_stat: Update exit reasons to the latest defintion

2015-01-21 Thread Wei Huang
This patch updates the exit reasons for x86_vmx, x86_svm, and userspace to the latest definition. Signed-off-by: Wei Huang --- scripts/kvm/kvm_stat | 4 1 file changed, 4 insertions(+) diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index 470ca08..e8b3295 100755 --- a/scripts/kvm/

[Qemu-devel] [PATCH 3/3] kvm_stat: Print errno when syscall to perf_event_open() fails

2015-01-21 Thread Wei Huang
kvm_stat uses syscall() to call perf_event_open(). If this function call fails, the returned value is -1, which doesn't tell the details of such failure (i.e. ENOSYS or EINVAL). This patch retrieves errno and prints it when syscall() fails. The error message will look like "Exception: perf_event_op

[Qemu-devel] [PATCH 0/3] kvm_stat update

2015-01-21 Thread Wei Huang
This patch set updates kvm_stat with the following new features: * support for ARM aarch64 * the latest exit reasons (vmx, svm and userspace) * print errno when syscall fails Thanks, -Wei *** BLURB HERE *** Wei Huang (3): kvm_stat: Add aarch64 support kvm_stat: Update exit reasons to the l

[Qemu-devel] [PATCH 1/3] kvm_stat: Add aarch64 support

2015-01-21 Thread Wei Huang
This patch enables aarch64 support for kvm_stat. The platform detection is based on OS uname. Signed-off-by: Wei Huang --- scripts/kvm/kvm_stat | 8 1 file changed, 8 insertions(+) diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index 7b1437c..470ca08 100755 --- a/scripts/kvm/

[Qemu-devel] [PATCH 1/1] Add error checking to vcard_emul_options.

2015-01-21 Thread Jeremy White
Also add an alias of 'nssemul' for the default card of hw=yes hw_type=cac, and an alias of 'passthru' for the new card type of hw=yes hw_type=passthru. This allows the spice-gtk client to take a more human friendly set of arguments and relay them through to this code. Signed-off-by: Jeremy White

[Qemu-devel] [PATCH 0/1] Add error checking to vcard_emul_options

2015-01-21 Thread Jeremy White
This patch is based on a discussion on the spice-devel list: http://lists.freedesktop.org/archives/spice-devel/2015-January/018639.html and on a proposed spice-gtk patch: http://lists.freedesktop.org/archives/spice-devel/2015-January/018648.html Essentially, it tidies up the vcard_emul_option

Re: [Qemu-devel] [PATCH 4/4] target-tricore: Add instructions of RRR opcode format

2015-01-21 Thread Richard Henderson
On 01/21/2015 10:04 AM, Bastian Koppelmann wrote: > Add microcode generator function gen_cond_sub. > > Add helper functions: > * ixmax/ixmin: search for the max/min value and its related index in a >vector of 16-bit values. > * pack: dack two data registers into an IEEE

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-21 Thread Richard Henderson
On 01/21/2015 10:12 AM, Bastian Koppelmann wrote: > Richard, before I put too much work into this. Are you happy with the general > direction of this documentation? Yes. r~

[Qemu-devel] [PATCH v3] Fixes several full screen issues on Mac OS X

2015-01-21 Thread Programmingkid
This patch makes several changes: - Minimizes distorted full screen display by respecting aspect ratios. - Makes full screen mode available on Mac OS 10.7 and higher. - Allows user to decide if video should be stretched to fill the screen, using a menu item called "Zoom To Fit". - Hides the normalW

Re: [Qemu-devel] [PATCH 3/4] target-tricore: Add instructions of RRPW opcode format

2015-01-21 Thread Richard Henderson
On 01/21/2015 10:04 AM, Bastian Koppelmann wrote: > Signed-off-by: Bastian Koppelmann > --- > target-tricore/translate.c | 63 > ++ > 1 file changed, 63 insertions(+) > > diff --git a/target-tricore/translate.c b/target-tricore/translate.c > index 4af

[Qemu-devel] [PATCH v2 0/4] target-arm: ARM64: Adding EL1 AARCH32 guest support

2015-01-21 Thread Greg Bellows
Added support for running an AArch32 guest on a AArch64 KVM host. Support has only been added to the QEMU machvirt machine. The addition of CPU properties specifiable from the command line were added to allow disablement of AArch64 execution state hereby forcing EL1 to be AArch32. The new CPU co

[Qemu-devel] [PATCH v2 1/4] target-arm: Add CPU property to disable AArch64

2015-01-21 Thread Greg Bellows
Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the execution state. The below QEMU invocation would have AArch64 execution state dis

[Qemu-devel] [PATCH v2 2/4] target-arm: Add feature parsing to virt

2015-01-21 Thread Greg Bellows
Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows --- v1 -> v2 - Fix multiple property handling --- hw/arm/virt.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(

[Qemu-devel] [PATCH v2 3/4] target-arm: Add 32/64-bit register sync

2015-01-21 Thread Greg Bellows
Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows --- target-arm/helper-a64.c | 5 +-- target-arm/internals.h | 89 ++

[Qemu-devel] [PATCH v2 4/4] target-arm: Add AArch32 guest support to KVM64

2015-01-21 Thread Greg Bellows
Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows --- target-arm/kvm64.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/target-arm/kvm64.c b/target-arm/kvm

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2015-01-21 Thread Serge Hallyn
Hi, just to be clear, the backport.patch which you uploaded actually increased jitter for you, making the situation worse, right? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1297218 Title: guest

Re: [Qemu-devel] [PATCH 2/4] target-tricore: Add instructions of RR2 opcode format

2015-01-21 Thread Richard Henderson
On 01/21/2015 10:04 AM, Bastian Koppelmann wrote: > +case OPC2_32_RR2_MUL_32: > +gen_mul_i32s(cpu_gpr_d[r3], cpu_gpr_d[r1], cpu_gpr_d[r2]); > +break; > +case OPC2_32_RR2_MUL_64: > +gen_mul_i64s(cpu_gpr_d[r3], cpu_gpr_d[r3+1], cpu_gpr_d[r1], > + cp

Re: [Qemu-devel] [PATCH 1/4] target-tricore: target-tricore: Add instructions of RR1 opcode format, that have 0x93 as first opcode

2015-01-21 Thread Richard Henderson
On 01/21/2015 10:04 AM, Bastian Koppelmann wrote: > Signed-off-by: Bastian Koppelmann > --- > target-tricore/translate.c | 276 > + > 1 file changed, 276 insertions(+) > > diff --git a/target-tricore/translate.c b/target-tricore/translate.c > index de

[Qemu-devel] [Bug 1318830] Re: High CPU usage on windows virtual machine

2015-01-21 Thread Serge Hallyn
** Changed in: qemu (Ubuntu) Status: New => Invalid ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1318830 Title: High CPU usage on windows

Re: [Qemu-devel] Can we make better use of Coverity?

2015-01-21 Thread Markus Armbruster
Paolo Bonzini writes: > On 21/01/2015 17:05, Markus Armbruster wrote: >> What do you mean by "a GLib model"? scripts/coverity-model.c? >>> > >>> > Yes. It models g_malloc0 in a way that avoids a lot of false positives, >>> > but still is able to flag leaks. >> Understood. It's hugely bett

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Jason Wang as net subsystem maintainer

2015-01-21 Thread Stefan Hajnoczi
On Tue, Jan 20, 2015 at 03:40:38PM +, Stefan Hajnoczi wrote: > Jason Wang will be co-maintaining the QEMU net subsystem with me. He > has contributed improvements and reviewed patches over the past years as > part of working on virtio-net and virtualized networking. > > Jason has already been

[Qemu-devel] [PATCH 3/4] target-tricore: Add instructions of RRPW opcode format

2015-01-21 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index 4af31c2..73d8d7d 100644 --- a/target-tricore/translate.c +++ b/target-

Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend

2015-01-21 Thread Bastian Koppelmann
On 01/14/2015 03:51 PM, Bastian Koppelmann wrote: There is no overview, that shows all the frontend operation one can use, as found on the wiki. Unfortunatly the wiki is out of date, so let's try to move this documentation to the source files, which has the benefit, that it is easy to update the

[Qemu-devel] [PATCH 4/4] target-tricore: Add instructions of RRR opcode format

2015-01-21 Thread Bastian Koppelmann
Add microcode generator function gen_cond_sub. Add helper functions: * ixmax/ixmin: search for the max/min value and its related index in a vector of 16-bit values. * pack: dack two data registers into an IEEE-754 single precision floating point format number

[Qemu-devel] [PATCH 0/4] TriCore add instructions of RR1, RR2, RRPW and RRR opcode format

2015-01-21 Thread Bastian Koppelmann
Hi, this is a rather short patchset, that only implements instructions of four formats. There will be another patchset, which has a few bugfixes. Cheers, Bastian Bastian Koppelmann (4): target-tricore: target-tricore: Add instructions of RR1 opcode format, that have 0x93 as first opcode

[Qemu-devel] [PATCH 1/4] target-tricore: target-tricore: Add instructions of RR1 opcode format, that have 0x93 as first opcode

2015-01-21 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 276 + 1 file changed, 276 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index def7f4a..da8ecbc 100644 --- a/target-tricore/translate.c +++ b/target

[Qemu-devel] [PATCH 2/4] target-tricore: Add instructions of RR2 opcode format

2015-01-21 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 37 + 1 file changed, 37 insertions(+) diff --git a/target-tricore/translate.c b/target-tricore/translate.c index da8ecbc..4af31c2 100644 --- a/target-tricore/translate.c +++ b/target-tricore/t

[Qemu-devel] [PATCH 1/4] target-tricore: Several translator and cpu model fixes

2015-01-21 Thread Bastian Koppelmann
Fix tc1796 cpu model using wrong ISA version. Fix cond_add sometimes writing back wrong result. Fix RCR_SEL and RCR_SELN using wrong registers for result and cond. Signed-off-by: Bastian Koppelmann --- target-tricore/cpu.c | 2 +- target-tricore/op_helper.c | 1 + target-tricore/translate.

[Qemu-devel] [PATCH 3/4] target-tricore: Fix bugs found by coverity

2015-01-21 Thread Bastian Koppelmann
This fixes one bug and one false positive found by coverity. The bug is, that gen_mtcr was missing a mask to check the flag, which resulted in dead code. The false positive is a intentional missing break for a jump and link address insn followed by a jump and link insn. This adds a fall through co

[Qemu-devel] [PATCH 4/4] target-tricore: split up suov32 into suov32_pos and suov32_neg

2015-01-21 Thread Bastian Koppelmann
suov checks unsigned for an overflow and an underflow, after some arithmetic operations and saturates the result to either max_uint32 or 0. So far we handled this by expanding to the next bigger data type and compare whether the result is > max_uint32 or < 0. However this approach can fail for an

[Qemu-devel] [PATCH 2/4] target-tricore: calculate av bits before saturation

2015-01-21 Thread Bastian Koppelmann
64 bit mac instructions calculated the av bits after the saturation, which resulted in a wrong PSW. This moves the av bit calculation before the saturation. Signed-off-by: Bastian Koppelmann --- target-tricore/op_helper.c | 28 1 file changed, 16 insertions(+), 12 de

[Qemu-devel] [PATCH 0/4] TriCore bugfixes

2015-01-21 Thread Bastian Koppelmann
Hi, this patchset only contains bugfixes, like the ones found by coverity, and some minor corner cases in some instructions. Cheers, Bastian Bastian Koppelmann (4): target-tricore: Several translator and cpu model fixes target-tricore: calculate av bits before saturation target-tricore: Fi

[Qemu-devel] [PULL] qemu-sparc update

2015-01-21 Thread Mark Cave-Ayland
Hi Peter, This is mainly to apply your outstanding clang warning patches. Please pull. ATB, Mark. The following changes since commit 699eae17b841e6784dc3864bf357e26bff1e9dfe: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-misc-20150120' into staging (2015-01-20 16:19:58 +)

Re: [Qemu-devel] [PATCH v5 1/1] hw: misc, add educational driver

2015-01-21 Thread Paolo Bonzini
On 21/01/2015 17:48, Jiri Slaby wrote: > I am using qemu for teaching the Linux kernel at our university. I > wrote a simple PCI device that can answer to writes/reads, generate > interrupts and perform DMA. As I am dragging it locally over 2 years, > I am sending it to you now. > > Signed-off-b

[Qemu-devel] [PATCH v5 1/1] hw: misc, add educational driver

2015-01-21 Thread Jiri Slaby
I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, I am sending it to you now. Signed-off-by: Jiri Slaby --- MAINTAINERS | 5 +

Re: [Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2015-01-21 Thread Stefan Hajnoczi
On Mon, Nov 24, 2014 at 04:56:49PM +0100, Max Reitz wrote: > +static void build_window_bitmap(Qcow2MetadataList *mdl, > +Qcow2MetadataWindow *window) > +{ > +int cache_i, oldest_cache_i = -1, i; > +unsigned oldest_cache_age = 0; > + > +for (cache_i = 0; c

Re: [Qemu-devel] Can we make better use of Coverity?

2015-01-21 Thread Markus Armbruster
Paolo Bonzini writes: > On 21/01/2015 14:58, Markus Armbruster wrote: >> Defect density by component, from >> https://scan.coverity.com/projects/378?tab=overview > > Updated: > > bt46101.748 > slirp 69681.4410 > 9pfs 94931.3713 > user

Re: [Qemu-devel] [PATCH v4 1/1] pci-host: add educational driver

2015-01-21 Thread Jiri Slaby
On 01/21/2015, 05:40 PM, Paolo Bonzini wrote: > > > On 21/01/2015 17:28, Jiri Slaby wrote: >> +if (atomic_fetch_or(&edu->status, EDU_STATUS_COMPUTING) & >> EDU_STATUS_COMPUTING) { > > Theoretically the other thread could see EDU_STATUS_COMPUTING here and > not enter the condvar wait. S

Re: [Qemu-devel] [PATCH v4 1/1] pci-host: add educational driver

2015-01-21 Thread Paolo Bonzini
On 21/01/2015 17:28, Jiri Slaby wrote: > +if (atomic_fetch_or(&edu->status, EDU_STATUS_COMPUTING) & > EDU_STATUS_COMPUTING) { Theoretically the other thread could see EDU_STATUS_COMPUTING here and not enter the condvar wait. So... > +break; > +} > +qemu_mut

Re: [Qemu-devel] [RFC PATCH 2/4] pcie-aer: Fix command pcie_aer_inject_error is invalid

2015-01-21 Thread Marcel Apfelbaum
On 01/21/2015 11:56 AM, Chen Fan wrote: On 01/16/2015 03:56 PM, Chen Fan wrote: On 01/12/2015 09:56 PM, Marcel Apfelbaum wrote: On 01/12/2015 05:04 AM, Chen Fan wrote: in spec "PCI Express 3.0" section 6.2.6 Figure 6-3 virtual bridge part, the flowchart showing tell us SERR# enable at Bridge

[Qemu-devel] [PATCH v4 1/1] pci-host: add educational driver

2015-01-21 Thread Jiri Slaby
I am using qemu for teaching the Linux kernel at our university. I wrote a simple PCI device that can answer to writes/reads, generate interrupts and perform DMA. As I am dragging it locally over 2 years, I am sending it to you now. Signed-off-by: Jiri Slaby --- MAINTAINERS | 5 +

Re: [Qemu-devel] Can we make better use of Coverity?

2015-01-21 Thread Paolo Bonzini
On 21/01/2015 17:05, Markus Armbruster wrote: >>> >> What do you mean by "a GLib model"? scripts/coverity-model.c? >> > >> > Yes. It models g_malloc0 in a way that avoids a lot of false positives, >> > but still is able to flag leaks. > Understood. It's hugely better than nothing, Yes, I thin

[Qemu-devel] [PATCH v2 0/4] ARM: Add support for a generic PCI Express host bridge

2015-01-21 Thread Alexander Graf
Linux implements a nice binding to describe a "generic" PCI Express host bridge using only device tree. This patch set adds enough emulation logic to expose the parts that are "generic" as a simple sysbus device and maps it into ARM's virt machine. With this patch set, we can finally spawn PCI de

[Qemu-devel] [PATCH v2 3/4] arm: Add PCIe host bridge in virt machine

2015-01-21 Thread Alexander Graf
Now that we have a working "generic" PCIe host bridge driver, we can plug it into ARMs virt machine to always have PCIe available to normal ARM VMs. I've successfully managed to expose a Bochs VGA device, XHCI and an e1000 into an AArch64 VM with this and they all lived happily ever after. Signed

[Qemu-devel] [PATCH v2 2/4] pci: Add generic PCIe host bridge

2015-01-21 Thread Alexander Graf
With simple exposure of MMFG, ioport window, mmio window and an IRQ line we can successfully create a workable PCIe host bridge that can be mapped anywhere and only needs to get described to the OS using whatever means it likes. This patch implements such a "generic" host bridge. It only supports

[Qemu-devel] [PATCH v2 4/4] pci: Move PCI VGA to pci.mak

2015-01-21 Thread Alexander Graf
Every platform that supports PCI can also spawn the Bochs VGA PCI adapter. Move it to pci.mak to enable it for everyone. Signed-off-by: Alexander Graf --- default-configs/alpha-softmmu.mak| 2 -- default-configs/i386-softmmu.mak | 2 -- default-configs/mips-softmmu.mak | 2 -- defaul

[Qemu-devel] [PATCH v2 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-21 Thread Alexander Graf
The mmcfg space is a memory region that allows access to PCI config space in the PCIe world. To maintain abstraction layers, I would like to expose the mmcfg space as a sysbus mmio region rather than have it mapped straight into the system's memory address space though. So this patch splits the in

Re: [Qemu-devel] [PATCH 0/5] SPARC: fix clang warnings

2015-01-21 Thread Mark Cave-Ayland
On 18/01/15 21:15, Mark Cave-Ayland wrote: > On 02/01/15 17:30, Peter Maydell wrote: > >> On 2 January 2015 at 13:57, Mark Cave-Ayland >> wrote: >>> On 23/12/14 22:11, Peter Maydell wrote: These patches fix warnings generated by clang. Patches 1-3 have been onlist before (and reviewed

Re: [Qemu-devel] Can we make better use of Coverity?

2015-01-21 Thread Paolo Bonzini
On 21/01/2015 16:59, Peter Maydell wrote: >> > I wasn't bold enough to suggest "daily", let alone "release blocker". > I think the Coverity FAQ says we can't do more than 2 > scans a week for a project of QEMU's size anyway... That's just a default. You can ask them to be an exception, and QEMU

Re: [Qemu-devel] Can we make better use of Coverity?

2015-01-21 Thread Markus Armbruster
Paolo Bonzini writes: > On 21/01/2015 15:57, Markus Armbruster wrote: >>> QEMU is also using a GLib model on Coverity Scan, as well as a >>> QEMU-specific model, which suggests one of the following: >> >> What do you mean by "a GLib model"? scripts/coverity-model.c? > > Yes. It models g_malloc

Re: [Qemu-devel] [PATCH v2 11/12] qcow2/overlaps: Protect inactive L2 tables

2015-01-21 Thread Max Reitz
On 2015-01-21 at 10:23, Stefan Hajnoczi wrote: On Mon, Nov 24, 2014 at 04:56:59PM +0100, Max Reitz wrote: @@ -136,6 +138,34 @@ int qcow2_read_snapshots(BlockDriverState *bs) size_to_clusters(s, sn->l1_size *

[Qemu-devel] [PATCHv2 7/7] openpic: fix up loadvm under -M mac99

2015-01-21 Thread Mark Cave-Ayland
Issuing loadvm under -M mac99 would fail for two reasons: firstly an incorrect version number for openpic would cause openpic_load() to abort, and secondly a cut/paste error when restoring the IVPR and IDR registers caused subsequent vmstate sections to become misaligned and abort early. Signed-of

Re: [Qemu-devel] [PATCH RFC v6 16/20] virtio-net: support longer header

2015-01-21 Thread Cornelia Huck
On Tue, 20 Jan 2015 13:18:14 + Stefan Hajnoczi wrote: > On Thu, Dec 11, 2014 at 02:25:18PM +0100, Cornelia Huck wrote: > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > > index ebbea60..7ee2bd6 100644 > > --- a/hw/net/virtio-net.c > > +++ b/hw/net/virtio-net.c > > @@ -373,15 +373,2

[Qemu-devel] [PATCHv2 6/7] openpic: fix segfault on -M mac99 savevm

2015-01-21 Thread Mark Cave-Ayland
A simple copy/paste error causes savevm on -M mac99 to segfault. Signed-off-by: Mark Cave-Ayland --- hw/intc/openpic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c index 7d1f3b9..8699a4a 100644 --- a/hw/intc/openpic.c +++ b/hw/intc/

[Qemu-devel] [PATCHv2 3/7] cuda.c: include adb_poll_timer in VMStateDescription

2015-01-21 Thread Mark Cave-Ayland
Make sure that we include the adb_poll_timer when saving the VM state for client OSs that use it, e.g. Darwin. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index b4

Re: [Qemu-devel] Can we make better use of Coverity?

2015-01-21 Thread Paolo Bonzini
On 21/01/2015 14:58, Markus Armbruster wrote: > Defect density by component, from > https://scan.coverity.com/projects/378?tab=overview Updated: bt 46101.748 slirp 69681.4410 9pfs94931.3713 user32263 0.6822 fpu

[Qemu-devel] [PATCHv2 5/7] target-ppc: force update of msr bits in cpu_post_load

2015-01-21 Thread Mark Cave-Ayland
Since env->msr has already been restored by the time cpu_post_load is called, make sure that ppc_store_msr() is explicitly called with all msr bits except MSR_TGPR marked as invalid. This solves the issue where MSR flags aren't set correctly when restoring a VM snapshot, in particular the internal

[Qemu-devel] [PATCHv2 2/7] adb.c: include ADBDevice parent state in KBDState and MouseState

2015-01-21 Thread Mark Cave-Ayland
The parent ADBDevice contains the device id on the ADB bus. Make sure that this state is included in both its subclasses since some clients (such as OpenBIOS) reprogram each device id after enumeration. Signed-off-by: Mark Cave-Ayland --- hw/input/adb.c | 22 ++ 1 file chan

[Qemu-devel] [PATCHv2 0/7] ppc: loadvm/savevm fixups for -M g3beige and -M mac99

2015-01-21 Thread Mark Cave-Ayland
This patchset fixes up various bugs in loadvm/savevm for -M g3beige and -M mac99 so that it is becomes possible to save and restore image snapshots. The focus of this patchset is on -M g3beige since this matches the majority of my test images, but there were some easy fixes to be made to -M mac99

[Qemu-devel] [PATCHv2 1/7] macio.c: include parent PCIDevice state in VMStateDescription

2015-01-21 Thread Mark Cave-Ayland
This ensures that the macio PCI device is correctly configured when restoring from a VM snapshot. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/macio.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c index e0f1e88.

[Qemu-devel] [PATCHv2 4/7] target-ppc: move sdr1 value change detection logic to helper_store_sdr1()

2015-01-21 Thread Mark Cave-Ayland
Otherwise when cpu_post_load calls ppc_store_sdr1() when restoring a VM snapshot the value is deemed unchanged and so the internal env->htab* variables aren't set correctly. Signed-off-by: Mark Cave-Ayland Reviewed-by: Paolo Bonzini --- target-ppc/misc_helper.c |7 ++- target-ppc/mmu_he

Re: [Qemu-devel] Can we make better use of Coverity?

2015-01-21 Thread Peter Maydell
On 21 January 2015 at 15:55, Markus Armbruster wrote: > I wasn't bold enough to suggest "daily", let alone "release blocker". I think the Coverity FAQ says we can't do more than 2 scans a week for a project of QEMU's size anyway... -- PMM

Re: [Qemu-devel] Can we make better use of Coverity?

2015-01-21 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Jan 21, 2015 at 01:47:22PM +0100, Markus Armbruster wrote: >> We're using the Coverity Scan service[*]. We've put in some effort, and >> we've gotten some mileage out of it, but I feel we could get more. >> >> Judging from the report e-mail I have lying ab

Re: [Qemu-devel] [PATCH v11 03/13] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-01-21 Thread Eric Blake
On 01/21/2015 02:34 AM, Markus Armbruster wrote: > Opinions? > I'm still thinking about my reply (it's a big enough question that I want to make sure I consider ramifications), so this is just a meta-reply to let you know I'm tracking this conversation. CC'ing Eric Blake, as well, for comme

[Qemu-devel] [PATCH V2] s390x/pci: avoid sign extension in stpcifc

2015-01-21 Thread Frank Blaschka
this patch avoids sign extension and fixes a data conversion bug in stpcifc. Both issues where found by Coverity. Signed-off-by: Frank Blaschka --- hw/s390x/s390-pci-inst.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-in

  1   2   >